[webkit-changes] [190851] trunk/Source/WebKit2

[gyuyoung . kim]

Title: [190851] trunk/Source/WebKit2








Revision 190851
Author gyuyoung@webkit.org
Date 2015-10-12 00:52:53 -0700 (Mon, 12 Oct 2015)


Log Message
[EFL] Bump Version/X in user agent
https://bugs.webkit.org/show_bug.cgi?id=150013

Reviewed by Csaba Osztrogonác.

EFL port needs to ensure maximum compatibility with existing web sites.
Thus version number needs to be bumped from 5.0 to 8.0 as GTK port.

* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::standardUserAgent):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (190850 => 190851)

--- trunk/Source/WebKit2/ChangeLog	2015-10-12 04:41:36 UTC (rev 190850)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-12 07:52:53 UTC (rev 190851)
@@ -1,3 +1,16 @@
+2015-10-12  Gyuyoung Kim  
+
+[EFL] Bump Version/X in user agent
+https://bugs.webkit.org/show_bug.cgi?id=150013
+
+Reviewed by Csaba Osztrogonác.
+
+EFL port needs to ensure maximum compatibility with existing web sites.
+Thus version number needs to be bumped from 5.0 to 8.0 as GTK port.
+
+* UIProcess/efl/WebPageProxyEfl.cpp:
+(WebKit::WebPageProxy::standardUserAgent):
+
 2015-10-10  Dan Bernstein  
 
 [iOS] Remove unnecessary iOS version checks


Modified: trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp (190850 => 190851)

--- trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp	2015-10-12 04:41:36 UTC (rev 190850)
+++ trunk/Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp	2015-10-12 07:52:53 UTC (rev 190851)
@@ -63,7 +63,7 @@
 osVersion = "Unknown";
 
 standardUserAgentString = "Mozilla/5.0 (" + platform + "; " + osVersion + ") AppleWebKit/" + version
-+ " (KHTML, like Gecko) Version/5.0 Safari/" + version;
++ " (KHTML, like Gecko) Version/8.0 Safari/" + version;
 
 return applicationNameForUserAgent.isEmpty() ? standardUserAgentString : standardUserAgentString + ' ' + applicationNameForUserAgent;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190855] trunk/Tools

[mario]

Title: [190855] trunk/Tools








Revision 190855
Author ma...@webkit.org
Date 2015-10-12 08:30:32 -0700 (Mon, 12 Oct 2015)


Log Message
[GTK] Update jhbuild's version of harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=149749

Reviewed by Martin Robinson.

Update harfbuzz to 0.9.35, following the lead of Debian Stable.

* gtk/jhbuild.modules: Updated details for harfbuzz.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (190854 => 190855)

--- trunk/Tools/ChangeLog	2015-10-12 12:37:05 UTC (rev 190854)
+++ trunk/Tools/ChangeLog	2015-10-12 15:30:32 UTC (rev 190855)
@@ -1,5 +1,16 @@
 2015-10-12  Mario Sanchez Prada  
 
+[GTK] Update jhbuild's version of harfbuzz
+https://bugs.webkit.org/show_bug.cgi?id=149749
+
+Reviewed by Martin Robinson.
+
+Update harfbuzz to 0.9.35, following the lead of Debian Stable.
+
+* gtk/jhbuild.modules: Updated details for harfbuzz.
+
+2015-10-12  Mario Sanchez Prada  
+
 [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
 https://bugs.webkit.org/show_bug.cgi?id=150026
 


Modified: trunk/Tools/gtk/jhbuild.modules (190854 => 190855)

--- trunk/Tools/gtk/jhbuild.modules	2015-10-12 12:37:05 UTC (rev 190854)
+++ trunk/Tools/gtk/jhbuild.modules	2015-10-12 15:30:32 UTC (rev 190855)
@@ -104,11 +104,12 @@
   
 
   
-+ repo="freedesktop.org"
-hash="sha256:d07c0ffdbbbfdfbb6c65e73fe9c76466e87dbf04b094cbd0abf5fd7d571a4004"
-md5sum="7e1990b79060e98e2d31f677a0ac9eed">
+hash="sha256:0aa1a8aba6f502321cf6fef3c9d2c73dde48389c5ed1d3615a7691944c2a06ed"
+md5sum="531ee8650626ecddcd90b2a4637e31d4">
 
   
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190852] trunk/Source/WebCore

[zandobersek]

Title: [190852] trunk/Source/WebCore








Revision 190852
Author zandober...@gmail.com
Date 2015-10-12 04:24:40 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, followup to r190643.

Inline the std::function<> constructor wrappings around lambdas
into a single line, instead of spanning it across four lines.

* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190851 => 190852)

--- trunk/Source/WebCore/ChangeLog	2015-10-12 07:52:53 UTC (rev 190851)
+++ trunk/Source/WebCore/ChangeLog	2015-10-12 11:24:40 UTC (rev 190852)
@@ -1,3 +1,40 @@
+2015-10-12  Zan Dobersek  
+
+Unreviewed, followup to r190643.
+
+Inline the std::function<> constructor wrappings around lambdas
+into a single line, instead of spanning it across four lines.
+
+* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
+(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
+(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
+(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
+(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
+(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
+(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
+(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
+(WebCore::MediaPlayerPrivateGStreamer::textChanged):
+(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
+(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
+(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
+* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
+(WebCore::TrackPrivateBaseGStreamer::activeChanged):
+(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
+(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):
+* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
+(webkitVideoSinkRender):
+* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+(webKitWebSrcChangeState):
+(webKitWebSrcNeedDataCb):
+(webKitWebSrcEnoughDataMainCb):
+(webKitWebSrcEnoughDataCb):
+(webKitWebSrcSeekMainCb):
+(webKitWebSrcSeekDataCb):
+
 2015-10-11  Brian Burg  
 
 Add missing builtins files to the Xcode projects


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp (190851 => 190852)

--- trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp	2015-10-12 07:52:53 UTC (rev 190851)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp	

[webkit-changes] [190854] trunk/Tools

[mario]

Title: [190854] trunk/Tools








Revision 190854
Author ma...@webkit.org
Date 2015-10-12 05:37:05 -0700 (Mon, 12 Oct 2015)


Log Message
[GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
https://bugs.webkit.org/show_bug.cgi?id=150026

Reviewed by Philippe Normand.

Backport upstream patch from gst-plugins-bad so that the right version
of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
gets compiled properly, avoiding crashes on runtime while running tests.

* gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
* gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules


Added Paths

trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch




Diff

Modified: trunk/Tools/ChangeLog (190853 => 190854)

--- trunk/Tools/ChangeLog	2015-10-12 11:31:26 UTC (rev 190853)
+++ trunk/Tools/ChangeLog	2015-10-12 12:37:05 UTC (rev 190854)
@@ -1,3 +1,17 @@
+2015-10-12  Mario Sanchez Prada  
+
+[GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
+https://bugs.webkit.org/show_bug.cgi?id=150026
+
+Reviewed by Philippe Normand.
+
+Backport upstream patch from gst-plugins-bad so that the right version
+of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
+gets compiled properly, avoiding crashes on runtime while running tests.
+
+* gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
+* gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
+
 2015-10-11  Myles C. Maxfield  
 
 Test font-variant-* and font-feature-settings with mocked preinstalled fonts


Modified: trunk/Tools/gtk/jhbuild.modules (190853 => 190854)

--- trunk/Tools/gtk/jhbuild.modules	2015-10-12 11:31:26 UTC (rev 190853)
+++ trunk/Tools/gtk/jhbuild.modules	2015-10-12 12:37:05 UTC (rev 190854)
@@ -322,6 +322,7 @@
 hash="sha256:e41b36105c0a13a2cb1ff9f559714e839b82dc3841484cd664790fb7947e55c7"
 md5sum="972c6e22dd2e44fcf0b04b9d810a56be">
   
+  
 
   
 


Added: trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch (0 => 190854)

--- trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch	(rev 0)
+++ trunk/Tools/gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch	2015-10-12 12:37:05 UTC (rev 190854)
@@ -0,0 +1,35 @@
+From 1f738ca5b8711ca5532a326cd646312e60484863 Mon Sep 17 00:00:00 2001
+From: Wim Taymans 
+Date: Wed, 13 May 2015 16:23:26 +0200
+Subject: [PATCH] fix faad2 version check
+
+On fedora 22, the output of cpp inserts extra debug comments, which
+makes our regexp for the faad2 version check fail. This in turn causes
+it to compile with the wrong arguments passed which then causes stack
+corruption and crashes.
+
+Fix this by only checking for the version (which should be by itself on
+a single line). This is potentially less safe, it might be possible that
+a similar string would appear in a later version in the header file.
+
+Fixes https://bugzilla.gnome.org/show_bug.cgi?id=748571
+---
+ configure.ac | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index f5ce28c..d295253 100644
+--- a/configure.ac
 b/configure.ac
+@@ -2008,9 +2008,9 @@ AG_GST_CHECK_FEATURE(FAAD, [AAC decoder plug-in], faad, [
+   AC_MSG_CHECKING([Checking FAAD2 version in $faad_hdr])
+   for minor in 10 9 8 7 6 5 0; do
+ if test x$faad2_minor_version = "x"; then
+-  AC_EGREP_CPP([GST_CHECK_FAAD_VERSION \"2\.$minor\"], [
++  AC_EGREP_CPP([\"2\.$minor\"$], [
+   #include <$faad_hdr>
+-  GST_CHECK_FAAD_VERSION FAAD2_VERSION
++  FAAD2_VERSION
+ ], [
+   faad2_minor_version=$minor
+ ])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190853] trunk/Source/WebCore

[zandobersek]

Title: [190853] trunk/Source/WebCore








Revision 190853
Author zandober...@gmail.com
Date 2015-10-12 04:31:26 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, fixing debug builds with Clang on Linux
by including the stdio.h header where it's required
under a debug configuration.

* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
* rendering/SimpleLineLayoutFunctions.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp
trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190852 => 190853)

--- trunk/Source/WebCore/ChangeLog	2015-10-12 11:24:40 UTC (rev 190852)
+++ trunk/Source/WebCore/ChangeLog	2015-10-12 11:31:26 UTC (rev 190853)
@@ -1,5 +1,15 @@
 2015-10-12  Zan Dobersek  
 
+Unreviewed, fixing debug builds with Clang on Linux
+by including the stdio.h header where it's required
+under a debug configuration.
+
+* page/scrolling/ScrollingStateTree.cpp:
+(WebCore::ScrollingStateTree::ScrollingStateTree):
+* rendering/SimpleLineLayoutFunctions.cpp:
+
+2015-10-12  Zan Dobersek  
+
 Unreviewed, followup to r190643.
 
 Inline the std::function<> constructor wrappings around lambdas


Modified: trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp (190852 => 190853)

--- trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp	2015-10-12 11:24:40 UTC (rev 190852)
+++ trunk/Source/WebCore/page/scrolling/ScrollingStateTree.cpp	2015-10-12 11:31:26 UTC (rev 190853)
@@ -35,6 +35,10 @@
 #include "ScrollingStateStickyNode.h"
 #include 
 
+#ifndef NDEBUG
+#include 
+#endif
+
 namespace WebCore {
 
 ScrollingStateTree::ScrollingStateTree(AsyncScrollingCoordinator* scrollingCoordinator)


Modified: trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp (190852 => 190853)

--- trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp	2015-10-12 11:24:40 UTC (rev 190852)
+++ trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp	2015-10-12 11:31:26 UTC (rev 190853)
@@ -43,6 +43,10 @@
 #include "Text.h"
 #include "TextPaintStyle.h"
 
+#if ENABLE(TREE_DEBUGGING)
+#include 
+#endif
+
 namespace WebCore {
 namespace SimpleLineLayout {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190856] trunk

[commit-queue]

Title: [190856] trunk








Revision 190856
Author commit-qu...@webkit.org
Date 2015-10-12 10:01:05 -0700 (Mon, 12 Oct 2015)


Log Message
[GTK] Use --version-script only on Linux
https://bugs.webkit.org/show_bug.cgi?id=144555

Patch by Philip Chimento  on 2015-10-12
Reviewed by Philippe Normand.

* Source/cmake/OptionsGTK.cmake: Don't add --version-script
option on Darwin (whose linker doesn't support it.)

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (190855 => 190856)

--- trunk/ChangeLog	2015-10-12 15:30:32 UTC (rev 190855)
+++ trunk/ChangeLog	2015-10-12 17:01:05 UTC (rev 190856)
@@ -1,3 +1,13 @@
+2015-10-12  Philip Chimento  
+
+[GTK] Use --version-script only on Linux
+https://bugs.webkit.org/show_bug.cgi?id=144555
+
+Reviewed by Philippe Normand.
+
+* Source/cmake/OptionsGTK.cmake: Don't add --version-script
+option on Darwin (whose linker doesn't support it.)
+
 2015-10-09  Gyuyoung Kim  
 
 [CMake] Remove ENABLE_SUBPIXEL_LAYOUT macro


Modified: trunk/Source/cmake/OptionsGTK.cmake (190855 => 190856)

--- trunk/Source/cmake/OptionsGTK.cmake	2015-10-12 15:30:32 UTC (rev 190855)
+++ trunk/Source/cmake/OptionsGTK.cmake	2015-10-12 17:01:05 UTC (rev 190856)
@@ -104,7 +104,9 @@
 else ()
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MINIBROWSER PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS PRIVATE OFF)
-set(WebKit2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/gtksymbols.filter")
+if (NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
+set(WebKit2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/gtksymbols.filter")
+endif ()
 endif ()
 
 if (CMAKE_SYSTEM_NAME MATCHES "Linux")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190864] branches/safari-601.2.7.2-branch/Source

[bshafiei]

Title: [190864] branches/safari-601.2.7.2-branch/Source








Revision 190864
Author bshaf...@apple.com
Date 2015-10-12 11:06:33 -0700 (Mon, 12 Oct 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (190863 => 190864)

--- branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-12 18:04:17 UTC (rev 190863)
+++ branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-12 18:06:33 UTC (rev 190864)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig (190863 => 190864)

--- branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-12 18:04:17 UTC (rev 190863)
+++ branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-12 18:06:33 UTC (rev 190864)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (190863 => 190864)

--- branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-12 18:04:17 UTC (rev 190863)
+++ branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-12 18:06:33 UTC (rev 190864)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig (190863 => 190864)

--- branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-12 18:04:17 UTC (rev 190863)
+++ branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-12 18:06:33 UTC (rev 190864)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig (190863 => 190864)

--- branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-12 18:04:17 UTC (rev 190863)
+++ branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-12 18:06:33 UTC (rev 190864)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190867] trunk/Source/JavaScriptCore

[fpizlo]

Title: [190867] trunk/Source/_javascript_Core








Revision 190867
Author fpi...@apple.com
Date 2015-10-12 11:11:26 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, clarify a comment. The example code had a bug.

* ftl/FTLLowerDFGToLLVM.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190866 => 190867)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 18:10:23 UTC (rev 190866)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 18:11:26 UTC (rev 190867)
@@ -1,5 +1,11 @@
 2015-10-12  Filip Pizlo  
 
+Unreviewed, clarify a comment. The example code had a bug.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+
+2015-10-12  Filip Pizlo  
+
 Unreviewed, fix no-FTL build.
 
 * ftl/FTLLazySlowPath.cpp:


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (190866 => 190867)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-10-12 18:10:23 UTC (rev 190866)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-10-12 18:11:26 UTC (rev 190867)
@@ -7309,6 +7309,9 @@
 // },
 // input);
 //
+// You can basically pass as many inputs as you like, either using this varargs form, or by
+// passing a Vector of LValues.
+//
 // Note that if your slow path is only doing a call, you can use the createLazyCallGenerator()
 // helper. For example:
 //
@@ -7317,7 +7320,7 @@
 // [=] (const Vector& locations) -> RefPtr {
 // return createLazyCallGenerator(
 // operationDoThings, locations[0].directGPR(), locations[1].directGPR());
-// });
+// }, input);
 //
 // Finally, note that all of the lambdas - both the stage (2) lambda and the stage (3) lambda -
 // run after the function that created them returns. Hence, you should not use by-reference






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190868] trunk/LayoutTests

[bfulgham]

Title: [190868] trunk/LayoutTests








Revision 190868
Author bfulg...@apple.com
Date 2015-10-12 11:11:42 -0700 (Mon, 12 Oct 2015)


Log Message
[Win] Unreviewed test gardening after r190667.

Mark fast/css/will-change/will-change-create-stacking-context-inline.html as failing, because
Windows does not support backdrop-filter.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190867 => 190868)

--- trunk/LayoutTests/ChangeLog	2015-10-12 18:11:26 UTC (rev 190867)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 18:11:42 UTC (rev 190868)
@@ -1,5 +1,14 @@
 2015-10-12  Brent Fulgham  
 
+[Win] Unreviewed test gardening after r190667.
+
+Mark fast/css/will-change/will-change-create-stacking-context-inline.html as failing, because
+Windows does not support backdrop-filter.
+
+* platform/win/TestExpectations:
+
+2015-10-12  Brent Fulgham  
+
 [Win] Unreviewed test gardening after r190840.
 
 Rebaseline tests to match new output (same changes as Mac).


Modified: trunk/LayoutTests/platform/win/TestExpectations (190867 => 190868)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-12 18:11:26 UTC (rev 190867)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-12 18:11:42 UTC (rev 190868)
@@ -552,6 +552,9 @@
 css3/blending/ [ Skip ]
 transitions/blendmode-transitions.html [ Skip ]
 
+# Backdrop Filters do not work on Windows
+fast/css/will-change/will-change-creates-stacking-context-inline.html [ ImageOnlyFailure ] 
+
 # TODO Not supported in CFNetwork yet. https://bugs.webkit.org/show_bug.cgi?id=100349
 webkit.org/b/100349 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html [ Skip ]
 webkit.org/b/100349 http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190857] trunk/Source/JavaScriptCore

[commit-queue]

Title: [190857] trunk/Source/_javascript_Core








Revision 190857
Author commit-qu...@webkit.org
Date 2015-10-12 10:03:48 -0700 (Mon, 12 Oct 2015)


Log Message
webkit-gtk-2.3.4 fails to link _javascript_Core, missing symbols add_history and readline
https://bugs.webkit.org/show_bug.cgi?id=127059

Patch by Philip Chimento  on 2015-10-12
Reviewed by Philippe Normand.

* shell/CMakeLists.txt: Link JSC with -ledit on Mac OSX.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/CMakeLists.txt




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190856 => 190857)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 17:01:05 UTC (rev 190856)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 17:03:48 UTC (rev 190857)
@@ -1,3 +1,12 @@
+2015-10-12  Philip Chimento  
+
+webkit-gtk-2.3.4 fails to link _javascript_Core, missing symbols add_history and readline
+https://bugs.webkit.org/show_bug.cgi?id=127059
+
+Reviewed by Philippe Normand.
+
+* shell/CMakeLists.txt: Link JSC with -ledit on Mac OSX.
+
 2015-10-11  Yusuke Suzuki  
 
 ES6 classes: When a class extends B, super() invokes B.prototype.constructor() instead of B()


Modified: trunk/Source/_javascript_Core/shell/CMakeLists.txt (190856 => 190857)

--- trunk/Source/_javascript_Core/shell/CMakeLists.txt	2015-10-12 17:01:05 UTC (rev 190856)
+++ trunk/Source/_javascript_Core/shell/CMakeLists.txt	2015-10-12 17:03:48 UTC (rev 190857)
@@ -8,6 +8,10 @@
 WTF${DEBUG_SUFFIX}
 )
 
+if (WTF_OS_MAC_OS_X)
+list(APPEND JSC_LIBRARIES edit)
+endif ()
+
 if ("${_javascript_Core_LIBRARY_TYPE}" MATCHES "STATIC")
 add_definitions(-DSTATICALLY_LINKED_WITH_JavaScriptCore)
 endif ()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190858] trunk/LayoutTests

[commit-queue]

Title: [190858] trunk/LayoutTests








Revision 190858
Author commit-qu...@webkit.org
Date 2015-10-12 10:23:06 -0700 (Mon, 12 Oct 2015)


Log Message
Marking http/tests/notifications/events.html as flaky again as patch did not resolve crashes
https://bugs.webkit.org/show_bug.cgi?id=149218

Patch by Ryan Haddad  on 2015-10-12
Reviewed by Brian Burg.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190857 => 190858)

--- trunk/LayoutTests/ChangeLog	2015-10-12 17:03:48 UTC (rev 190857)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 17:23:06 UTC (rev 190858)
@@ -1,3 +1,12 @@
+2015-10-12  Ryan Haddad  
+
+Marking http/tests/notifications/events.html as flaky again as patch did not resolve crashes
+https://bugs.webkit.org/show_bug.cgi?id=149218
+
+Reviewed by Brian Burg.
+
+* platform/mac/TestExpectations:
+
 2015-10-11  Myles C. Maxfield  
 
 Test font-variant-* and font-feature-settings with mocked preinstalled fonts


Modified: trunk/LayoutTests/platform/mac/TestExpectations (190857 => 190858)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-10-12 17:03:48 UTC (rev 190857)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-10-12 17:23:06 UTC (rev 190858)
@@ -1336,5 +1336,8 @@
 # Marking test as flaky in El Capitan
 webkit.org/b/149819 [ Debug ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ]
 
+# Marking as flaky again, patch did not work
+webkit.org/b/149218 http/tests/notifications/events.html [ Pass Crash ]
+
 # Imported Blink tests which have not been investigated.
 imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190859] trunk

[andersca]

Title: [190859] trunk








Revision 190859
Author ander...@apple.com
Date 2015-10-12 10:25:37 -0700 (Mon, 12 Oct 2015)


Log Message
Don't allow plug-ins to override image types for  elements
https://bugs.webkit.org/show_bug.cgi?id=149979

Reviewed by Tim Horton.

Source/WebCore:

Stop allowing plug-ins to take over image types for  elements. We already do this
for  elements, but had to make  elements exempt because of webkit.org/b/49016.
The QuickTime plug-in hasn't supported image types since Lion, so there's no point in keeping this code around.

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::HTMLEmbedElement):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):
(WebCore::HTMLObjectElement::parametersForPlugin):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::isImageType):
(WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
* html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::shouldPreferPlugInsForImages): Deleted.
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::resourceWillUsePlugin):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::shouldUsePlugin):
* loader/SubframeLoader.h:

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::objectContentType):

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::objectContentType):
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

LayoutTests:

Remove test.

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
* plugins/embed-prefers-plugins-for-images.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAppletElement.cpp
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp
trunk/Source/WebCore/html/HTMLPlugInImageElement.h
trunk/Source/WebCore/loader/EmptyClients.h
trunk/Source/WebCore/loader/FrameLoaderClient.h
trunk/Source/WebCore/loader/SubframeLoader.cpp
trunk/Source/WebCore/loader/SubframeLoader.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h


Removed Paths

trunk/LayoutTests/plugins/embed-prefers-plugins-for-images-expected.txt
trunk/LayoutTests/plugins/embed-prefers-plugins-for-images.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190858 => 190859)

--- trunk/LayoutTests/ChangeLog	2015-10-12 17:23:06 UTC (rev 190858)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 17:25:37 UTC (rev 190859)
@@ -1,3 +1,17 @@
+2015-10-09  Anders Carlsson  
+
+Don't allow plug-ins to override image types for  elements
+https://bugs.webkit.org/show_bug.cgi?id=149979
+
+Reviewed by Tim Horton.
+
+Remove test.
+
+* platform/efl/TestExpectations:
+* platform/gtk/TestExpectations:
+* plugins/embed-prefers-plugins-for-images-expected.txt: Removed.
+* plugins/embed-prefers-plugins-for-images.html: Removed.
+
 2015-10-12  Ryan Haddad  
 
 Marking http/tests/notifications/events.html as flaky again as patch did not resolve crashes


Modified: trunk/LayoutTests/platform/efl/TestExpectations (190858 => 190859)

--- trunk/LayoutTests/platform/efl/TestExpectations	2015-10-12 17:23:06 UTC (rev 190858)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2015-10-12 17:25:37 UTC (rev 190859)
@@ -1954,8 +1954,6 @@
 
 webkit.org/b/127725 media/video-restricted-no-preload-auto.html [ Failure ]
 
-webkit.org/b/127731 plugins/embed-prefers-plugins-for-images.html [ Failure ]
-
 # Subpixel rendering: borders are reporting float values.
 webkit.org/b/128061 fast/block/float/016.html [ Failure ]
 webkit.org/b/128061 fast/css/bidi-override-in-anonymous-block.html [ Failure ]


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (190858 => 190859)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-10-12 17:23:06 UTC (rev 190858)
+++ 

[webkit-changes] [190861] trunk/LayoutTests

[bfulgham]

Title: [190861] trunk/LayoutTests








Revision 190861
Author bfulg...@apple.com
Date 2015-10-12 10:59:05 -0700 (Mon, 12 Oct 2015)


Log Message
[Win] Unreviewed test gardening after r190840.

Rebaseline tests to match new output (same changes as Mac).

* platform/win/fast/css-generated-content/details-summary-before-after-expected.txt:
* platform/win/fast/html/details-add-child-2-expected.txt:
* platform/win/fast/html/details-open2-expected.txt:
* platform/win/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/win/fast/html/details-remove-summary-4-and-click-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/fast/css-generated-content/details-summary-before-after-expected.txt
trunk/LayoutTests/platform/win/fast/html/details-add-child-2-expected.txt
trunk/LayoutTests/platform/win/fast/html/details-open2-expected.txt
trunk/LayoutTests/platform/win/fast/html/details-remove-summary-1-and-click-expected.txt
trunk/LayoutTests/platform/win/fast/html/details-remove-summary-4-and-click-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (190860 => 190861)

--- trunk/LayoutTests/ChangeLog	2015-10-12 17:56:26 UTC (rev 190860)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 17:59:05 UTC (rev 190861)
@@ -1,3 +1,15 @@
+2015-10-12  Brent Fulgham  
+
+[Win] Unreviewed test gardening after r190840.
+
+Rebaseline tests to match new output (same changes as Mac).
+
+* platform/win/fast/css-generated-content/details-summary-before-after-expected.txt:
+* platform/win/fast/html/details-add-child-2-expected.txt:
+* platform/win/fast/html/details-open2-expected.txt:
+* platform/win/fast/html/details-remove-summary-1-and-click-expected.txt:
+* platform/win/fast/html/details-remove-summary-4-and-click-expected.txt:
+
 2015-10-09  Anders Carlsson  
 
 Don't allow plug-ins to override image types for  elements


Modified: trunk/LayoutTests/platform/win/fast/css-generated-content/details-summary-before-after-expected.txt (190860 => 190861)

--- trunk/LayoutTests/platform/win/fast/css-generated-content/details-summary-before-after-expected.txt	2015-10-12 17:56:26 UTC (rev 190860)
+++ trunk/LayoutTests/platform/win/fast/css-generated-content/details-summary-before-after-expected.txt	2015-10-12 17:59:05 UTC (rev 190861)
@@ -24,6 +24,7 @@
   RenderText at (0,0) size 28x18
 text run at (0,0) width 28: "after"
 RenderBlock (anonymous) at (1,77) size 782x18
+  RenderText {#text} at (0,0) size 0x0
   RenderText {#text} at (0,0) size 48x18
 text run at (0,0) width 48: "Details "
   RenderInline (generated) at (0,0) size 28x18


Modified: trunk/LayoutTests/platform/win/fast/html/details-add-child-2-expected.txt (190860 => 190861)

--- trunk/LayoutTests/platform/win/fast/html/details-add-child-2-expected.txt	2015-10-12 17:56:26 UTC (rev 190860)
+++ trunk/LayoutTests/platform/win/fast/html/details-add-child-2-expected.txt	2015-10-12 17:59:05 UTC (rev 190861)
@@ -12,5 +12,3 @@
   RenderInline {B} at (0,0) size 142x18
 RenderText {#text} at (0,0) size 142x18
   text run at (0,0) width 142: "should have bold test"
-  RenderText {#text} at (0,0) size 0x0
-  RenderText {#text} at (0,0) size 0x0


Modified: trunk/LayoutTests/platform/win/fast/html/details-open2-expected.txt (190860 => 190861)

--- trunk/LayoutTests/platform/win/fast/html/details-open2-expected.txt	2015-10-12 17:56:26 UTC (rev 190860)
+++ trunk/LayoutTests/platform/win/fast/html/details-open2-expected.txt	2015-10-12 17:59:05 UTC (rev 190861)
@@ -10,7 +10,5 @@
 text run at (16,0) width 59: "summary"
 RenderBlock (anonymous) at (0,18) size 784x25
   RenderTextControl {INPUT} at (2,2) size 149x21 [bgcolor=#FF] [border: (2px inset #00)]
-  RenderText {#text} at (0,0) size 0x0
-  RenderText {#text} at (0,0) size 0x0
 layer at (12,31) size 145x15
   RenderBlock {DIV} at (2,3) size 145x15


Modified: trunk/LayoutTests/platform/win/fast/html/details-remove-summary-1-and-click-expected.txt (190860 => 190861)

--- trunk/LayoutTests/platform/win/fast/html/details-remove-summary-1-and-click-expected.txt	2015-10-12 17:56:26 UTC (rev 190860)
+++ trunk/LayoutTests/platform/win/fast/html/details-remove-summary-1-and-click-expected.txt	2015-10-12 17:59:05 UTC (rev 190861)
@@ -8,4 +8,4 @@
   RenderDetailsMarker {DIV} at (0,4) size 11x11: down
   RenderText {#text} at (16,0) size 45x18
 text run at (16,0) width 45: "Details"
-caret: position 0 of child 0 {DIV} of {#document-fragment} of child 0 {SUMMARY} of child 0 {WEBKITSHADOWCONTENT} of {#document-fragment} of child 1 {DETAILS} of body
+caret: position 0 of child 0 {DIV} of {#document-fragment} of child 0 {SUMMARY} of child 0 {SLOT} of {#document-fragment} of child 1 {DETAILS} of body

[webkit-changes] [190865] trunk/Source/JavaScriptCore

[fpizlo]

Title: [190865] trunk/Source/_javascript_Core








Revision 190865
Author fpi...@apple.com
Date 2015-10-12 11:08:50 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, fix no-FTL build.

* ftl/FTLLazySlowPath.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190864 => 190865)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 18:06:33 UTC (rev 190864)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 18:08:50 UTC (rev 190865)
@@ -1,3 +1,9 @@
+2015-10-12  Filip Pizlo  
+
+Unreviewed, fix no-FTL build.
+
+* ftl/FTLLazySlowPath.cpp:
+
 2015-10-12  Philip Chimento  
 
 webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"


Modified: trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.cpp (190864 => 190865)

--- trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.cpp	2015-10-12 18:06:33 UTC (rev 190864)
+++ trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.cpp	2015-10-12 18:08:50 UTC (rev 190865)
@@ -26,6 +26,8 @@
 #include "config.h"
 #include "FTLLazySlowPath.h"
 
+#if ENABLE(FTL_JIT)
+
 #include "FTLSlowPathCall.h"
 #include "LinkBuffer.h"
 
@@ -71,4 +73,4 @@
 
 } } // namespace JSC::FTL
 
-
+#endif // ENABLE(FTL_JIT)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190870] branches/safari-601.2.7.2-branch/Source/WebKit/win

[bshafiei]

Title: [190870] branches/safari-601.2.7.2-branch/Source/WebKit/win








Revision 190870
Author bshaf...@apple.com
Date 2015-10-12 11:17:03 -0700 (Mon, 12 Oct 2015)


Log Message
Merge patch for rdar://problem/23025615.

Modified Paths

branches/safari-601.2.7.2-branch/Source/WebKit/win/ChangeLog
branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.cpp




Diff

Modified: branches/safari-601.2.7.2-branch/Source/WebKit/win/ChangeLog (190869 => 190870)

--- branches/safari-601.2.7.2-branch/Source/WebKit/win/ChangeLog	2015-10-12 18:14:16 UTC (rev 190869)
+++ branches/safari-601.2.7.2-branch/Source/WebKit/win/ChangeLog	2015-10-12 18:17:03 UTC (rev 190870)
@@ -1,3 +1,18 @@
+2015-10-12  Babak Shafiei  
+
+Merge patch for rdar://problem/23025615.
+
+2015-10-09  Brent Fulgham  
+
+[Win] Load the proper library for _javascript_Core symbols
+
+
+Rubberstamped by Jer Noble.
+
+* WebKitDLL.cpp:
+(bindJavaScriptTrampoline): We need to use "_javascript_Core.dll",
+not the LLVM library.
+
 2015-10-07  Babak Shafiei  
 
 Merge patch for rdar://problem/23025615.


Modified: branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.cpp (190869 => 190870)

--- branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.cpp	2015-10-12 18:14:16 UTC (rev 190869)
+++ branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.cpp	2015-10-12 18:17:03 UTC (rev 190870)
@@ -262,7 +262,7 @@
 
 void bindJavaScriptTrampoline()
 {
-const wchar_t* libraryName = L"libllvmForJSC.dll";
+const wchar_t* libraryName = L"_javascript_Core.dll";
 
 HMODULE library = ::LoadLibrary(libraryName);
 if (!library)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190863] branches/safari-601.2.7.2-branch/

[bshafiei]

Title: [190863] branches/safari-601.2.7.2-branch/








Revision 190863
Author bshaf...@apple.com
Date 2015-10-12 11:04:17 -0700 (Mon, 12 Oct 2015)


Log Message
New Branch.

Added Paths

branches/safari-601.2.7.2-branch/




Diff

Property changes: branches/safari-601.2.7.2-branch



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190862] trunk/Source/JavaScriptCore

[mcatanzaro]

Title: [190862] trunk/Source/_javascript_Core








Revision 190862
Author mcatanz...@igalia.com
Date 2015-10-12 10:59:45 -0700 (Mon, 12 Oct 2015)


Log Message
webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
https://bugs.webkit.org/show_bug.cgi?id=126433

Patch by Philip Chimento  on 2015-10-12
Reviewed by Philippe Normand

Don't include CoreFoundation.h when building the GTK port.

* Source/_javascript_Core/API/WebKitAvailability.h: Add !defined(BUILDING_GTK__) to defined(__APPLE__).

Modified Paths

trunk/Source/_javascript_Core/API/WebKitAvailability.h
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/WebKitAvailability.h (190861 => 190862)

--- trunk/Source/_javascript_Core/API/WebKitAvailability.h	2015-10-12 17:59:05 UTC (rev 190861)
+++ trunk/Source/_javascript_Core/API/WebKitAvailability.h	2015-10-12 17:59:45 UTC (rev 190862)
@@ -26,7 +26,7 @@
 #ifndef __WebKitAvailability__
 #define __WebKitAvailability__
 
-#ifdef __APPLE__
+#if defined(__APPLE__) && !defined(BUILDING_GTK__)
 
 #include 
 #include 


Modified: trunk/Source/_javascript_Core/ChangeLog (190861 => 190862)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 17:59:05 UTC (rev 190861)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 17:59:45 UTC (rev 190862)
@@ -1,3 +1,14 @@
+2015-10-12  Philip Chimento  
+
+webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
+https://bugs.webkit.org/show_bug.cgi?id=126433
+
+Reviewed by Philippe Normand
+
+Don't include CoreFoundation.h when building the GTK port.
+
+* Source/_javascript_Core/API/WebKitAvailability.h: Add !defined(BUILDING_GTK__) to defined(__APPLE__).
+
 2015-10-10  Filip Pizlo  
 
 FTL should generate code to call slow paths lazily






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190866] branches/safari-601.2.7.2-branch/Source/WebKit/win

[bshafiei]

Title: [190866] branches/safari-601.2.7.2-branch/Source/WebKit/win








Revision 190866
Author bshaf...@apple.com
Date 2015-10-12 11:10:23 -0700 (Mon, 12 Oct 2015)


Log Message
Merge patch for rdar://problem/23025615.

Modified Paths

branches/safari-601.2.7.2-branch/Source/WebKit/win/ChangeLog
branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.cpp
branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.h




Diff

Modified: branches/safari-601.2.7.2-branch/Source/WebKit/win/ChangeLog (190865 => 190866)

--- branches/safari-601.2.7.2-branch/Source/WebKit/win/ChangeLog	2015-10-12 18:08:50 UTC (rev 190865)
+++ branches/safari-601.2.7.2-branch/Source/WebKit/win/ChangeLog	2015-10-12 18:10:23 UTC (rev 190866)
@@ -1,3 +1,26 @@
+2015-10-07  Babak Shafiei  
+
+Merge patch for rdar://problem/23025615.
+
+2015-09-10  Brent Fulgham  
+
+[Win] Re-export a few symbols for backwards compatibility
+
+
+Reviewed by Dean Jackson.
+
+Check in a workaround (in a custom branch) to re-export a few _javascript_Core
+functions that had been erroneously exported by WebKit in older builds. This
+is needed so that we do not break certain old software still being used.
+
+* WebKitDLL.cpp:
+(DllMain): Bind functions at startup.
+(bindJavaScriptTrampoline): Find _javascript_Core library functions and
+re-export them from WebKit.dll.
+* WebKitDLL.h:
+* WebView.cpp:
+(WebView::unused5): Work around a linker bug.
+
 2015-09-25  Brent Fulgham  
 
 Merge r190235. rdar://problem/22852382


Modified: branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.cpp (190865 => 190866)

--- branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.cpp	2015-10-12 18:08:50 UTC (rev 190865)
+++ branches/safari-601.2.7.2-branch/Source/WebKit/win/WebKitDLL.cpp	2015-10-12 18:10:23 UTC (rev 190866)
@@ -23,6 +23,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
+#define DEPRECATED_EXPORT_SYMBOLS 1
 #include "WebKitDLL.h"
 
 #include "ForEachCoClass.h"
@@ -61,6 +62,7 @@
 return gClassNameCount.get();
 }
 
+void bindJavaScriptTrampoline();
 
 STDAPI_(BOOL) DllMain( HMODULE hModule, DWORD  ul_reason_for_call, LPVOID /*lpReserved*/)
 {
@@ -77,6 +79,7 @@
 gLockCount = gClassCount = 0;
 gInstance = hModule;
 WebCore::setInstanceHandle(hModule);
+bindJavaScriptTrampoline();
 return TRUE;
 
 case DLL_PROCESS_DETACH:
@@ -221,3 +224,171 @@
 
 return WebCore::SharedBuffer::create(reinterpret_cast(resource), size);
 }
+
+// Force symbols to be included so we can export them for legacy clients.
+// DEPRECATED! People should get these symbols from _javascript_Core.dll, not WebKit.dll!
+//#include <_javascript_Core/JSObjectRef.h>
+
+typedef JSClassRef (*JSClassCreateFunction)(const JSClassDefinition* definition);
+typedef void* (*JSObjectGetPrivateFunction)(JSObjectRef);
+typedef JSObjectRef (*JSObjectMakeFunctionStub)(JSContextRef, JSClassRef, void*);
+typedef void (*JSObjectSetPropertyFunction)(JSContextRef, JSObjectRef, JSStringRef propertyName, JSValueRef, JSPropertyAttributes, JSValueRef* exception);
+typedef JSStringRef (*JSStringCreateWithCFStringFunction)(CFStringRef);
+typedef JSStringRef (*JSStringCreateWithUTF8CStringFunction)(const char*);
+typedef const JSChar* (*JSStringGetCharactersPtrFunction)(JSStringRef);
+typedef size_t (*JSStringGetLengthFunction)(JSStringRef);
+typedef void (*JSStringReleaseFunction)(JSStringRef);
+typedef bool (*JSValueIsTypeFunction)(JSContextRef, JSValueRef);
+typedef JSValueRef(*JSValueMakeUndefinedFunction)(JSContextRef);
+typedef double(*JSValueToNumberFunction)(JSContextRef, JSValueRef, JSValueRef* exception);
+typedef JSValueRef(*JSValueMakeStringFunction)(JSContextRef, JSStringRef);
+typedef JSStringRef (*JSValueToStringCopyFunction)(JSContextRef, JSValueRef, JSValueRef* exception);
+
+JSClassCreateFunction m_jsClassCreateFunction = nullptr;
+JSObjectGetPrivateFunction m_jsObjectGetPrivateFunction = nullptr;
+JSObjectMakeFunctionStub m_jsObjectMakeFunction = nullptr;
+JSObjectSetPropertyFunction m_jsObjectSetPropertyFunction = nullptr;
+JSStringCreateWithCFStringFunction m_jsStringCreateWithCFStringFunction = nullptr;
+JSStringCreateWithUTF8CStringFunction m_jsStringCreateWithUTF8CStringFunction = nullptr;
+JSStringGetCharactersPtrFunction m_jsStringGetCharactersPtrFunction = nullptr;
+JSStringGetLengthFunction m_jsStringGetLengthFunction = nullptr;
+JSStringReleaseFunction m_jsStringReleaseFunction = nullptr;
+JSValueIsTypeFunction m_jsValueIsNumberFunction = nullptr;
+JSValueIsTypeFunction m_jsValueIsStringFunction = nullptr;
+JSValueMakeUndefinedFunction m_jsValueMakeUndefinedFunction = nullptr;
+JSValueToNumberFunction m_jsValueToNumberFunction = 

[webkit-changes] [190869] branches/safari-601.2.7.2-branch/Source

[bshafiei]

Title: [190869] branches/safari-601.2.7.2-branch/Source








Revision 190869
Author bshaf...@apple.com
Date 2015-10-12 11:14:16 -0700 (Mon, 12 Oct 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (190868 => 190869)

--- branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-12 18:11:42 UTC (rev 190868)
+++ branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-12 18:14:16 UTC (rev 190869)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig (190868 => 190869)

--- branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-12 18:11:42 UTC (rev 190868)
+++ branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-12 18:14:16 UTC (rev 190869)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (190868 => 190869)

--- branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-12 18:11:42 UTC (rev 190868)
+++ branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-12 18:14:16 UTC (rev 190869)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig (190868 => 190869)

--- branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-12 18:11:42 UTC (rev 190868)
+++ branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-12 18:14:16 UTC (rev 190869)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig (190868 => 190869)

--- branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-12 18:11:42 UTC (rev 190868)
+++ branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-12 18:14:16 UTC (rev 190869)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190871] tags/Safari-601.2.7.2.2/

[bshafiei]

Title: [190871] tags/Safari-601.2.7.2.2/








Revision 190871
Author bshaf...@apple.com
Date 2015-10-12 11:18:28 -0700 (Mon, 12 Oct 2015)


Log Message
New tag.

Added Paths

tags/Safari-601.2.7.2.2/




Diff

Property changes: tags/Safari-601.2.7.2.2



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190872] branches/safari-601.2.7.2-branch/Source

[bshafiei]

Title: [190872] branches/safari-601.2.7.2-branch/Source








Revision 190872
Author bshaf...@apple.com
Date 2015-10-12 11:23:02 -0700 (Mon, 12 Oct 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (190871 => 190872)

--- branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-12 18:18:28 UTC (rev 190871)
+++ branches/safari-601.2.7.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-10-12 18:23:02 UTC (rev 190872)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig (190871 => 190872)

--- branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-12 18:18:28 UTC (rev 190871)
+++ branches/safari-601.2.7.2-branch/Source/WebCore/Configurations/Version.xcconfig	2015-10-12 18:23:02 UTC (rev 190872)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (190871 => 190872)

--- branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-12 18:18:28 UTC (rev 190871)
+++ branches/safari-601.2.7.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-10-12 18:23:02 UTC (rev 190872)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig (190871 => 190872)

--- branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-12 18:18:28 UTC (rev 190871)
+++ branches/safari-601.2.7.2-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-10-12 18:23:02 UTC (rev 190872)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig (190871 => 190872)

--- branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-12 18:18:28 UTC (rev 190871)
+++ branches/safari-601.2.7.2-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-10-12 18:23:02 UTC (rev 190872)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 2;
 TINY_VERSION = 7;
 MICRO_VERSION = 2;
-NANO_VERSION = 2;
+NANO_VERSION = 3;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190874] trunk/LayoutTests

[bfulgham]

Title: [190874] trunk/LayoutTests








Revision 190874
Author bfulg...@apple.com
Date 2015-10-12 11:43:00 -0700 (Mon, 12 Oct 2015)


Log Message
[Win] Unreviewed test gardening after r190800.

Skip mac-specific 'fast/forms/hidpi-textfield-background-bleeding.html' test
on Windows.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190873 => 190874)

--- trunk/LayoutTests/ChangeLog	2015-10-12 18:39:06 UTC (rev 190873)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 18:43:00 UTC (rev 190874)
@@ -1,5 +1,14 @@
 2015-10-12  Brent Fulgham  
 
+[Win] Unreviewed test gardening after r190800.
+
+Skip mac-specific 'fast/forms/hidpi-textfield-background-bleeding.html' test
+on Windows.
+
+* platform/win/TestExpectations:
+
+2015-10-12  Brent Fulgham  
+
 REGRESSION(r190735, not fixed by r190741) failures.
 https://bugs.webkit.org/show_bug.cgi?id=150040
 


Modified: trunk/LayoutTests/platform/win/TestExpectations (190873 => 190874)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-12 18:39:06 UTC (rev 190873)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-12 18:43:00 UTC (rev 190874)
@@ -3293,3 +3293,6 @@
 webkit.org/b/150040 imported/w3c/web-platform-tests/dom/ranges/Range-insertNode.html [ Failure ]
 webkit.org/b/150040 imported/w3c/web-platform-tests/dom/ranges/Range-surroundContents.html [ Failure ]
 webkit.org/b/150040 js/dom/dfg-custom-getter.html [ Failure ]
+
+# The following tests are not relevant on the Windows platform:
+fast/forms/hidpi-textfield-background-bleeding.html [ Skip ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190877] trunk/LayoutTests

[commit-queue]

Title: [190877] trunk/LayoutTests








Revision 190877
Author commit-qu...@webkit.org
Date 2015-10-12 12:03:17 -0700 (Mon, 12 Oct 2015)


Log Message
Marking storage/domstorage/events/basic-body-attribute.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=148435

Patch by Ryan Haddad  on 2015-10-12
Reviewed by Alexey Proskuryakov.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190876 => 190877)

--- trunk/LayoutTests/ChangeLog	2015-10-12 19:00:47 UTC (rev 190876)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 19:03:17 UTC (rev 190877)
@@ -1,3 +1,12 @@
+2015-10-12  Ryan Haddad  
+
+Marking storage/domstorage/events/basic-body-attribute.html as flaky
+https://bugs.webkit.org/show_bug.cgi?id=148435
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/mac/TestExpectations:
+
 2015-10-12  Myles C. Maxfield  
 
 Test font-variant-* and font-feature-settings on Yosemite and Mavericks


Modified: trunk/LayoutTests/platform/mac/TestExpectations (190876 => 190877)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-10-12 19:00:47 UTC (rev 190876)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-10-12 19:03:17 UTC (rev 190877)
@@ -1340,5 +1340,8 @@
 # Marking as flaky again, patch did not work
 webkit.org/b/149218 http/tests/notifications/events.html [ Pass Crash ]
 
+# Flaky on Mac
+webkit.org/b/148435 storage/domstorage/events/basic-body-attribute.html [ Pass Failure ]
+
 # Imported Blink tests which have not been investigated.
 imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190879] trunk

[simon . fraser]

Title: [190879] trunk








Revision 190879
Author simon.fra...@apple.com
Date 2015-10-12 12:15:28 -0700 (Mon, 12 Oct 2015)


Log Message
Clip-path transitions sometimes trigger endless animation timers
https://bugs.webkit.org/show_bug.cgi?id=150018

Reviewed by Tim Horton.

Source/WebCore:

Transitioning -webkit-clip-path could trigger endless animation
timers, because when CompositeAnimation::updateTransitions() calls
isTargetPropertyEqual(), a false negative answer triggers canceling the
current transition and starting a new one over and over.

This happened because StyleRareNonInheritedData simply tested pointer
equality for m_clipPath and m_shapeOutside. Both of these need to do deep
equality testing, requiring the implementation of operator== in BasicShapes
classes.

In addition, the PropertyWrappers in CSSPropertyAnimation need equals()
implementations that also do more than pointer equality testing.

Tests: transitions/clip-path-transitions.html
   transitions/shape-outside-transitions.html

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperClipPath::equals):
(WebCore::PropertyWrapperShape::equals):
* rendering/ClipPathOperation.h:
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeCircle::operator==):
(WebCore::BasicShapeEllipse::operator==):
(WebCore::BasicShapePolygon::operator==):
(WebCore::BasicShapeInset::operator==):
* rendering/style/BasicShapes.h:
(WebCore::BasicShapeCenterCoordinate::operator==):
(WebCore::BasicShapeRadius::operator==):
* rendering/style/ShapeValue.cpp:
(WebCore::pointersOrValuesEqual):
(WebCore::ShapeValue::operator==):
* rendering/style/ShapeValue.h:
(WebCore::ShapeValue::operator!=):
(WebCore::ShapeValue::operator==): Deleted.
(WebCore::ShapeValue::ShapeValue): Deleted.
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::clipPathOperationsEquivalent):
(WebCore::StyleRareNonInheritedData::shapeOutsideDataEquivalent):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

New tests for transitions of clip-path and shape-outside.

* transitions/clip-path-transitions-expected.txt: Added.
* transitions/clip-path-transitions.html: Added.
* transitions/resources/transition-test-helpers.js:
(parseClipPath):
(checkExpectedValue):
* transitions/shape-outside-transitions-expected.txt: Added.
* transitions/shape-outside-transitions.html: Added.
* transitions/svg-transitions-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/transitions/resources/transition-test-helpers.js
trunk/LayoutTests/transitions/svg-transitions-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/rendering/ClipPathOperation.h
trunk/Source/WebCore/rendering/style/BasicShapes.cpp
trunk/Source/WebCore/rendering/style/BasicShapes.h
trunk/Source/WebCore/rendering/style/ShapeValue.cpp
trunk/Source/WebCore/rendering/style/ShapeValue.h
trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h


Added Paths

trunk/LayoutTests/transitions/clip-path-transitions-expected.txt
trunk/LayoutTests/transitions/clip-path-transitions.html
trunk/LayoutTests/transitions/shape-outside-transitions-expected.txt
trunk/LayoutTests/transitions/shape-outside-transitions.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190878 => 190879)

--- trunk/LayoutTests/ChangeLog	2015-10-12 19:15:17 UTC (rev 190878)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 19:15:28 UTC (rev 190879)
@@ -1,3 +1,21 @@
+2015-10-12  Simon Fraser  
+
+Clip-path transitions sometimes trigger endless animation timers
+https://bugs.webkit.org/show_bug.cgi?id=150018
+
+Reviewed by Tim Horton.
+
+New tests for transitions of clip-path and shape-outside.
+
+* transitions/clip-path-transitions-expected.txt: Added.
+* transitions/clip-path-transitions.html: Added.
+* transitions/resources/transition-test-helpers.js:
+(parseClipPath):
+(checkExpectedValue):
+* transitions/shape-outside-transitions-expected.txt: Added.
+* transitions/shape-outside-transitions.html: Added.
+* transitions/svg-transitions-expected.txt:
+
 2015-10-12  Ryan Haddad  
 
 Marking storage/domstorage/events/basic-body-attribute.html as flaky


Added: trunk/LayoutTests/transitions/clip-path-transitions-expected.txt (0 => 190879)

--- trunk/LayoutTests/transitions/clip-path-transitions-expected.txt	(rev 0)
+++ trunk/LayoutTests/transitions/clip-path-transitions-expected.txt	2015-10-12 19:15:28 UTC (rev 190879)
@@ -0,0 +1,5 @@
+PASS - "-webkit-clip-path" property for "circle" element at 0.5s saw something close to: circle(60px at 50px 40px)
+PASS - "-webkit-clip-path" property for "ellipse" element at 0.5s saw something close to: 

[webkit-changes] [190878] trunk/Source/JavaScriptCore

[fpizlo]

Title: [190878] trunk/Source/_javascript_Core








Revision 190878
Author fpi...@apple.com
Date 2015-10-12 12:15:17 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, fix non-FTL build for real.

* ftl/FTLLazySlowPath.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190877 => 190878)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 19:03:17 UTC (rev 190877)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 19:15:17 UTC (rev 190878)
@@ -1,5 +1,11 @@
 2015-10-12  Filip Pizlo  
 
+Unreviewed, fix non-FTL build for real.
+
+* ftl/FTLLazySlowPath.h:
+
+2015-10-12  Filip Pizlo  
+
 Unreviewed, clarify a comment. The example code had a bug.
 
 * ftl/FTLLowerDFGToLLVM.cpp:


Modified: trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.h (190877 => 190878)

--- trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.h	2015-10-12 19:03:17 UTC (rev 190877)
+++ trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.h	2015-10-12 19:15:17 UTC (rev 190878)
@@ -26,6 +26,8 @@
 #ifndef FTLLazySlowPath_h
 #define FTLLazySlowPath_h
 
+#if ENABLE(FTL_JIT)
+
 #include "CCallHelpers.h"
 #include "CodeBlock.h"
 #include "CodeLocation.h"
@@ -87,5 +89,7 @@
 
 } } // namespace JSC::FTL
 
+#endif // ENABLE(FTL_JIT)
+
 #endif // FTLLazySlowPath_h
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190873] trunk/LayoutTests

[bfulgham]

Title: [190873] trunk/LayoutTests








Revision 190873
Author bfulg...@apple.com
Date 2015-10-12 11:39:06 -0700 (Mon, 12 Oct 2015)


Log Message
REGRESSION(r190735, not fixed by r190741) failures.
https://bugs.webkit.org/show_bug.cgi?id=150040

* platform/win/TestExpectations: Skip several test failures introduced by JSC changes.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190872 => 190873)

--- trunk/LayoutTests/ChangeLog	2015-10-12 18:23:02 UTC (rev 190872)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 18:39:06 UTC (rev 190873)
@@ -1,5 +1,12 @@
 2015-10-12  Brent Fulgham  
 
+REGRESSION(r190735, not fixed by r190741) failures.
+https://bugs.webkit.org/show_bug.cgi?id=150040
+
+* platform/win/TestExpectations: Skip several test failures introduced by JSC changes.
+
+2015-10-12  Brent Fulgham  
+
 [Win] Unreviewed test gardening after r190667.
 
 Mark fast/css/will-change/will-change-create-stacking-context-inline.html as failing, because


Modified: trunk/LayoutTests/platform/win/TestExpectations (190872 => 190873)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-12 18:23:02 UTC (rev 190872)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-12 18:39:06 UTC (rev 190873)
@@ -3287,3 +3287,9 @@
 imported/blink/fast/block/float/float-mark-descendants-for-layout-crash.html [ Failure ]
 imported/blink/http/tests/security/script-crossorigin-loads-correctly-credentials.html [ Failure ]
 imported/blink/printing/print-document-without-documentElement-crash.html [ Failure ]
+
+# Failure introduced by _javascript_Core change:
+webkit.org/b/150040 fast/events/tabindex-focus-blur-all.html [ Failure ]
+webkit.org/b/150040 imported/w3c/web-platform-tests/dom/ranges/Range-insertNode.html [ Failure ]
+webkit.org/b/150040 imported/w3c/web-platform-tests/dom/ranges/Range-surroundContents.html [ Failure ]
+webkit.org/b/150040 js/dom/dfg-custom-getter.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190880] trunk/LayoutTests

[bfulgham]

Title: [190880] trunk/LayoutTests








Revision 190880
Author bfulg...@apple.com
Date 2015-10-12 12:18:49 -0700 (Mon, 12 Oct 2015)


Log Message
[Win] Unreviewed gardening

Unskip a bunch of passing tests.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190879 => 190880)

--- trunk/LayoutTests/ChangeLog	2015-10-12 19:15:28 UTC (rev 190879)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 19:18:49 UTC (rev 190880)
@@ -1,3 +1,11 @@
+2015-10-12  Brent Fulgham  
+
+[Win] Unreviewed gardening
+
+Unskip a bunch of passing tests.
+
+* platform/win/TestExpectations:
+
 2015-10-12  Simon Fraser  
 
 Clip-path transitions sometimes trigger endless animation timers


Modified: trunk/LayoutTests/platform/win/TestExpectations (190879 => 190880)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-10-12 19:15:28 UTC (rev 190879)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-10-12 19:18:49 UTC (rev 190880)
@@ -285,9 +285,6 @@
 http/tests/misc/link-rel-prefetch-and-subresource.html [ Skip ]
 http/tests/misc/prefetch-purpose.html [ Skip ]
 
-# TODO testRunner::pageProperty is not responding to changing user style sheet.
-printing/page-rule-selection.html [ Failure ]
-
 # TODO Hyphenation is not implemented yet.
 webkit.org/b/140234 fast/text/hyphenate-character.html [ Failure ]
 webkit.org/b/140234 fast/text/hyphens.html [ Failure ]
@@ -494,7 +491,6 @@
 webkit.org/b/87919 fast/inline/hidpi-inline-selection-leaves-gap.html [ ImageOnlyFailure ]
 webkit.org/b/87919 fast/inline/hidpi-inline-text-decoration-with-subpixel-value.html [ ImageOnlyFailure ]
 webkit.org/b/87919 fast/layers/hidpi-box-positioned-off-by-one-when-transform-is-present.html [ ImageOnlyFailure ]
-webkit.org/b/87919 fast/layers/hidpi-transform-on-child-content-is-mispositioned.html [ ImageOnlyFailure ]
 webkit.org/b/87919 fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html [ Failure ]
 webkit.org/b/87919 fast/repaint/hidpi-content-inside-iframe-leaves-trails.html [ Failure ]
 webkit.org/b/87919 fast/repaint/hidpi-device-pixel-based-repaint-rect-tracking.html [ Failure ]
@@ -1239,7 +1235,6 @@
 ## Command enabling
 editing/execCommand/enabling-and-selection-2.html [ Failure ]
 webkit.org/b/101539 editing/execCommand/switch-list-type-with-orphaned-li.html [ Failure ]
-editing/execCommand/find-after-replace.html [ Failure ]
 
 ## Inserting
 # TODO testRunner::setAutomaticLinkDetectionEnabled isn't implemented
@@ -1878,8 +1873,6 @@
 webkit.org/b/97026 svg/text/non-bmp-positioning-lists.svg [ Failure ]
 webkit.org/b/97026 svg/W3C-SVG-1.1/paths-data-03-f.svg	[ Failure ]
 webkit.org/b/97026 svg/css/svg-resource-fragment-identifier-img-src.html [ ImageOnlyFailure ]
-webkit.org/b/97026 [ Release ] svg/custom/composited-svg-with-opacity.html [ ImageOnlyFailure ]
-webkit.org/b/97026 [ Debug ] svg/custom/composited-svg-with-opacity.html [ Skip ] # Debug Assertion
 
 webkit.org/b/97026 svg/custom/remove-subtree-including-use-with-child-textpath-that-references-earlier-path.html [ Failure ]
 svg/W3C-SVG-1.1-SE/painting-control-04-f.svg [ Failure ]
@@ -1889,18 +1882,14 @@
 svg/text/bidi-text-anchor-direction.svg [ Failure ]
 svg/text/font-size-below-point-five.svg [ Failure ]
 svg/css/shadow-changes.svg [ Failure ]
-webkit.org/b/140705 imported/mozilla/svg/stroke-width-percentage-02a.svg [ ImageOnlyFailure ]
 webkit.org/b/116564 transitions/svg-text-shadow-transition.html [ Failure ]
 webkit.org/b/117322 svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg [ ImageOnlyFailure ]
 webkit.org/b/117322 svg/filters/feDisplacementMap-filterUnits.svg [ ImageOnlyFailure ]
-webkit.org/b/144417 svg/filters/sourceAlpha-input-filter-effect.html [ ImageOnlyFailure ]
 
 # Subpixel rendering: borders are reporting float values.
 webkit.org/b/128061 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [ Failure ]
 webkit.org/b/128061 svg/zoom/page/zoom-svg-through-object-with-auto-size.html [ Failure ]
 
-dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR.svg [ Pass Timeout ]
-
 webkit.org/b/131745 svg/W3C-SVG-1.1/metadata-example-01-b.svg [ Failure ]
 #  2 SVG text tests failing (due to bad rounding?)
 svg/batik/text/textOnPath.svg [ Failure ]
@@ -1964,8 +1953,6 @@
 ##  MathML Issues   
 
 webkit.org/b/119002 mathml/presentation/bug97990.html [ ImageOnlyFailure ]
-webkit.org/b/119002 mathml/presentation/scripts-subsup.html [ ImageOnlyFailure ]
-webkit.org/b/127495 mathml/presentation/maction-toggle.html [ ImageOnlyFailure ]
 mathml/presentation/mo-stacked-glyphs.html [ ImageOnlyFailure ]
 mathml/presentation/tokenElements-background-color.html [ ImageOnlyFailure ]
 

[webkit-changes] [190882] trunk/Source

[akling]

Title: [190882] trunk/Source








Revision 190882
Author akl...@apple.com
Date 2015-10-12 12:44:52 -0700 (Mon, 12 Oct 2015)


Log Message
"A + B" with strings shouldn't copy if A or B is empty.


Reviewed by Anders Carlsson.

Source/_javascript_Core:

* runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
* runtime/Lookup.cpp:
(JSC::reifyStaticAccessor):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):

Source/WTF:

Add a fast path to WTF's operator+ magic for concatenation of two strings where
one of them is empty. In that case, try to avoid allocation altogether by returning
the non-empty string.

Spotted this while analyzing memory peaks during page load; it turns out we were
duplicating whole text resources (JS, CSS) at the end of decoding, below
TextResourceDecoder::decodeAndFlush(). That function effectively does:

return decode() + flush();

Very often, flush() returns an empty string, so due to the naive operator+,
we'd allocate a new StringImpl of length (decode().length() + flush().length())
and copy the return value from decode() into it. So silly!

Had to make the tryMakeString() machinery use String as a return type instead of
RefPtr to make all the right overloads gel. StringTypeAdapter templates
are now required to provide a toString() function.

* wtf/text/StringConcatenate.h:
(WTF::StringTypeAdapter::toString):
(WTF::StringTypeAdapter::toString):
(WTF::StringTypeAdapter::toString):
(WTF::StringTypeAdapter::toString):
(WTF::tryMakeString):
(WTF::makeString):
* wtf/text/StringOperators.h:
(WTF::StringAppend::operator String):
* wtf/text/StringView.h:
(WTF::StringTypeAdapter::toString):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSStringBuilder.h
trunk/Source/_javascript_Core/runtime/Lookup.cpp
trunk/Source/_javascript_Core/runtime/ObjectPrototype.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringConcatenate.h
trunk/Source/WTF/wtf/text/StringOperators.h
trunk/Source/WTF/wtf/text/StringView.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190881 => 190882)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 19:36:03 UTC (rev 190881)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 19:44:52 UTC (rev 190882)
@@ -1,3 +1,17 @@
+2015-10-12  Andreas Kling  
+
+"A + B" with strings shouldn't copy if A or B is empty.
+
+
+Reviewed by Anders Carlsson.
+
+* runtime/JSStringBuilder.h:
+(JSC::jsMakeNontrivialString):
+* runtime/Lookup.cpp:
+(JSC::reifyStaticAccessor):
+* runtime/ObjectPrototype.cpp:
+(JSC::objectProtoFuncToString):
+
 2015-10-12  Joseph Pecoraro  
 
 VisitedValueCount GC Counter misses parallel SlotVisitors


Modified: trunk/Source/_javascript_Core/runtime/JSStringBuilder.h (190881 => 190882)

--- trunk/Source/_javascript_Core/runtime/JSStringBuilder.h	2015-10-12 19:36:03 UTC (rev 190881)
+++ trunk/Source/_javascript_Core/runtime/JSStringBuilder.h	2015-10-12 19:44:52 UTC (rev 190882)
@@ -127,10 +127,10 @@
 template
 inline JSValue jsMakeNontrivialString(ExecState* exec, const StringType& string, const StringTypes&... strings)
 {
-RefPtr result = WTF::tryMakeString(string, strings...);
+String result = WTF::tryMakeString(string, strings...);
 if (!result)
 return throwOutOfMemoryError(exec);
-return jsNontrivialString(exec, result.release());
+return jsNontrivialString(exec, result);
 }
 
 }


Modified: trunk/Source/_javascript_Core/runtime/Lookup.cpp (190881 => 190882)

--- trunk/Source/_javascript_Core/runtime/Lookup.cpp	2015-10-12 19:36:03 UTC (rev 190881)
+++ trunk/Source/_javascript_Core/runtime/Lookup.cpp	2015-10-12 19:44:52 UTC (rev 190882)
@@ -32,12 +32,12 @@
 JSGlobalObject* globalObject = thisObj.globalObject();
 GetterSetter* accessor = GetterSetter::create(vm, globalObject);
 if (value.accessorGetter()) {
-RefPtr getterName = WTF::tryMakeString(ASCIILiteral("get "), String(*propertyName.publicName()));
+String getterName = WTF::tryMakeString(ASCIILiteral("get "), String(*propertyName.publicName()));
 if (!getterName)
 return;
 accessor->setGetter(vm, globalObject, value.attributes() & Builtin
-? JSFunction::createBuiltinFunction(vm, value.builtinAccessorGetterGenerator()(vm), globalObject, *getterName)
-: JSFunction::create(vm, globalObject, 0, *getterName, value.accessorGetter()));
+? JSFunction::createBuiltinFunction(vm, value.builtinAccessorGetterGenerator()(vm), globalObject, getterName)
+: JSFunction::create(vm, globalObject, 0, getterName, value.accessorGetter()));
 }
 thisObj.putDirectNonIndexAccessor(vm, propertyName, accessor, attributesForStructure(value.attributes()));
 }


Modified: trunk/Source/_javascript_Core/runtime/ObjectPrototype.cpp (190881 => 190882)

--- 

[webkit-changes] [190883] trunk

[commit-queue]

Title: [190883] trunk








Revision 190883
Author commit-qu...@webkit.org
Date 2015-10-12 12:51:11 -0700 (Mon, 12 Oct 2015)


Log Message
REGRESSION(r184895): border-image should always slice the SVG image to nine pieces when drawing it in the container element
https://bugs.webkit.org/show_bug.cgi?id=149901


Patch by Said Abou-Hallawa  on 2015-10-12
Reviewed by Darin Adler.

Source/WebCore:

The nine-pieces algorithm should be applied to the border-image regardless
whether the image has an intrinsic size or not. It is not guaranteed to have
a meaningful border-image in all the cases of non-intrinsic size images. But
it should work as expected in most of the cases.

* rendering/RenderBoxModelObject.cpp:
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
Revert the changes which were added to return whether the image has
intrinsic size or not.

(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Size of the image is now the return value of calculateImageIntrinsicDimensions().

* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateContent):
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::createShapeForImage):
Size of the image is now the return value of calculateImageIntrinsicDimensions().

* rendering/style/NinePieceImage.cpp:
* rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::paint):
Delete the logic for the non-intrinsic case. Both intrinsic and non-intrinsic
cases will be treated the same.

(WebCore::NinePieceImage::computeNineRects):
(WebCore::NinePieceImage::computeSideTileScale):
(WebCore::NinePieceImage::computeMiddleTileScale):
(WebCore::NinePieceImage::computeTileScales):
(WebCore::NinePieceImage::computeIntrinsicRects): Deleted.
(WebCore::NinePieceImage::computeIntrinsicSideTileScale): Deleted.
(WebCore::NinePieceImage::computeIntrinsicMiddleTileScale): Deleted.
(WebCore::NinePieceImage::computeIntrinsicTileScales): Deleted.
Remove *Intrinsic* from the name of the functions.

(WebCore::NinePieceImage::computeNonIntrinsicRects): Deleted.
(WebCore::NinePieceImage::computeNonIntrinsicTileScales): Deleted.
Delete the *NonIntrinsic* functions.

LayoutTests:

* fast/borders/border-image-fill-no-intrinsic-size-expected.html:
* fast/borders/border-image-fill-no-intrinsic-size.html:
* fast/borders/resources/svg-border-100x100-relative.svg: Added.
* fast/borders/resources/svg-border-100x100-viewbox.svg: Added.
* fast/borders/resources/svg-border-140x140-intrinsic.svg:
New test cases for relative lengths border images were added. The relative
lengths can be specified by using percentage lengths or adding viewBox to
the root element.

One of the non-intrinsic image-borders must be removed from this test.
The SVG image in the expected file has to be scaled by (100 / 140), which
can be done. But run-webkit-tests found a very slight difference between
the actual and the result files.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/borders/border-image-fill-no-intrinsic-size-expected.html
trunk/LayoutTests/fast/borders/border-image-fill-no-intrinsic-size.html
trunk/LayoutTests/fast/borders/resources/svg-border-140x140-intrinsic.svg
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.h
trunk/Source/WebCore/rendering/RenderListMarker.cpp
trunk/Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp
trunk/Source/WebCore/rendering/style/NinePieceImage.cpp
trunk/Source/WebCore/rendering/style/NinePieceImage.h


Added Paths

trunk/LayoutTests/fast/borders/resources/svg-border-100x100-relative.svg
trunk/LayoutTests/fast/borders/resources/svg-border-100x100-viewbox.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (190882 => 190883)

--- trunk/LayoutTests/ChangeLog	2015-10-12 19:44:52 UTC (rev 190882)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 19:51:11 UTC (rev 190883)
@@ -1,3 +1,25 @@
+2015-10-12  Said Abou-Hallawa  
+
+REGRESSION(r184895): border-image should always slice the SVG image to nine pieces when drawing it in the container element
+https://bugs.webkit.org/show_bug.cgi?id=149901
+
+
+Reviewed by Darin Adler.
+
+* fast/borders/border-image-fill-no-intrinsic-size-expected.html:
+* fast/borders/border-image-fill-no-intrinsic-size.html:
+* fast/borders/resources/svg-border-100x100-relative.svg: Added.
+* fast/borders/resources/svg-border-100x100-viewbox.svg: Added.
+* fast/borders/resources/svg-border-140x140-intrinsic.svg:
+New test cases for relative lengths border images were added. The relative
+lengths can be specified by using percentage lengths or adding viewBox to
+the root element.
+
+One of the non-intrinsic image-borders must be removed from this test.
+The SVG image in the 

[webkit-changes] [190885] trunk/Source/JavaScriptCore

[sbarati]

Title: [190885] trunk/Source/_javascript_Core








Revision 190885
Author sbar...@apple.com
Date 2015-10-12 13:37:05 -0700 (Mon, 12 Oct 2015)


Log Message
Each *ById inline cache in the FTL must have its own CallSiteIndex
https://bugs.webkit.org/show_bug.cgi?id=150039

Reviewed by Geoffrey Garen and Filip Pizlo.

When lowering to LLVM, we create a patchpoint intrinsic for each
*ById in DFG IR. LLVM may choose to duplicate these patchpoints.
Therefore, we want each resulting inline cache to have a unique
CallSiteIndex because each inline cache will have its own set of 
used registers. This change is necessary when we implement try/catch 
in the FTL because an inline cache will ask for the set of used 
registers it will need to restore in the event of an exception 
being thrown. It asks for this set of registers by giving JITCode
a CallSiteIndex. Because each corresponding inline cache that results
from a duplicated patchpoint may all ask this for this set of registers, 
we must assign each inline cache a unique CallSiteIndex.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
* dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::addUniqueCallSiteIndex):
(JSC::DFG::CommonData::addCodeOriginUnconditionally): Deleted.
* dfg/DFGCommonData.h:
* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
* ftl/FTLInlineCacheDescriptor.h:
(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::InlineCacheDescriptor::stackmapID):
(JSC::FTL::InlineCacheDescriptor::codeOrigin):
(JSC::FTL::InlineCacheDescriptor::uid):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
(JSC::FTL::CheckInDescriptor::CheckInDescriptor):
(JSC::FTL::LazySlowPathDescriptor::LazySlowPathDescriptor):
(JSC::FTL::InlineCacheDescriptor::callSiteIndex): Deleted.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIn):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/dfg/DFGCommonData.cpp
trunk/Source/_javascript_Core/dfg/DFGCommonData.h
trunk/Source/_javascript_Core/ftl/FTLCompile.cpp
trunk/Source/_javascript_Core/ftl/FTLInlineCacheDescriptor.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190884 => 190885)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 20:24:32 UTC (rev 190884)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 20:37:05 UTC (rev 190885)
@@ -1,3 +1,47 @@
+2015-10-12  Saam barati  
+
+Each *ById inline cache in the FTL must have its own CallSiteIndex
+https://bugs.webkit.org/show_bug.cgi?id=150039
+
+Reviewed by Geoffrey Garen and Filip Pizlo.
+
+When lowering to LLVM, we create a patchpoint intrinsic for each
+*ById in DFG IR. LLVM may choose to duplicate these patchpoints.
+Therefore, we want each resulting inline cache to have a unique
+CallSiteIndex because each inline cache will have its own set of 
+used registers. This change is necessary when we implement try/catch 
+in the FTL because an inline cache will ask for the set of used 
+registers it will need to restore in the event of an exception 
+being thrown. It asks for this set of registers by giving JITCode
+a CallSiteIndex. Because each corresponding inline cache that results
+from a duplicated patchpoint may all ask this for this set of registers, 
+we must assign each inline cache a unique CallSiteIndex.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):
+* dfg/DFGCommonData.cpp:
+(JSC::DFG::CommonData::addCodeOrigin):
+(JSC::DFG::CommonData::addUniqueCallSiteIndex):
+(JSC::DFG::CommonData::addCodeOriginUnconditionally): Deleted.
+* dfg/DFGCommonData.h:
+* ftl/FTLCompile.cpp:
+(JSC::FTL::mmAllocateDataSection):
+* ftl/FTLInlineCacheDescriptor.h:
+(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
+(JSC::FTL::InlineCacheDescriptor::stackmapID):
+(JSC::FTL::InlineCacheDescriptor::codeOrigin):
+(JSC::FTL::InlineCacheDescriptor::uid):
+(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
+(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
+(JSC::FTL::CheckInDescriptor::CheckInDescriptor):
+(JSC::FTL::LazySlowPathDescriptor::LazySlowPathDescriptor):
+(JSC::FTL::InlineCacheDescriptor::callSiteIndex): Deleted.
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
+(JSC::FTL::DFG::LowerDFGToLLVM::compileIn):
+(JSC::FTL::DFG::LowerDFGToLLVM::getById):
+

[webkit-changes] [190881] trunk/Source/JavaScriptCore

[commit-queue]

Title: [190881] trunk/Source/_javascript_Core








Revision 190881
Author commit-qu...@webkit.org
Date 2015-10-12 12:36:03 -0700 (Mon, 12 Oct 2015)


Log Message
VisitedValueCount GC Counter misses parallel SlotVisitors
https://bugs.webkit.org/show_bug.cgi?id=149980

Patch by Joseph Pecoraro  on 2015-10-12
Reviewed by Geoffrey Garen.

* heap/Heap.cpp:
(JSC::Heap::updateObjectCounts):
Include threaded slot visitor's object counts in the debugging value.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190880 => 190881)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 19:18:49 UTC (rev 190880)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 19:36:03 UTC (rev 190881)
@@ -1,3 +1,14 @@
+2015-10-12  Joseph Pecoraro  
+
+VisitedValueCount GC Counter misses parallel SlotVisitors
+https://bugs.webkit.org/show_bug.cgi?id=149980
+
+Reviewed by Geoffrey Garen.
+
+* heap/Heap.cpp:
+(JSC::Heap::updateObjectCounts):
+Include threaded slot visitor's object counts in the debugging value.
+
 2015-10-12  Filip Pizlo  
 
 Unreviewed, fix non-FTL build for real.


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (190880 => 190881)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2015-10-12 19:18:49 UTC (rev 190880)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	2015-10-12 19:36:03 UTC (rev 190881)
@@ -851,7 +851,7 @@
 
 void Heap::updateObjectCounts(double gcStartTime)
 {
-GCCOUNTER(VisitedValueCount, m_slotVisitor.visitCount());
+GCCOUNTER(VisitedValueCount, m_slotVisitor.visitCount() + threadVisitCount());
 
 if (Options::logGC() == GCLogging::Verbose) {
 size_t visitCount = m_slotVisitor.visitCount();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190875] trunk/Source/WTF

[fpizlo]

Title: [190875] trunk/Source/WTF








Revision 190875
Author fpi...@apple.com
Date 2015-10-12 11:45:00 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, fix style in the hopes that it fixes Windows.

* wtf/ParallelHelperPool.cpp:
(WTF::ParallelHelperClient::~ParallelHelperClient):
(WTF::ParallelHelperClient::setTask):
(WTF::ParallelHelperClient::doSomeHelping):
(WTF::ParallelHelperClient::runTaskInParallel):
(WTF::ParallelHelperClient::finish):
(WTF::ParallelHelperClient::claimTask):
(WTF::ParallelHelperClient::runTask):
(WTF::ParallelHelperPool::doSomeHelping):
(WTF::ParallelHelperPool::helperThreadBody):
* wtf/ParallelHelperPool.h:
(WTF::ParallelHelperClient::setFunction):
(WTF::ParallelHelperClient::runFunctionInParallel):
(WTF::ParallelHelperClient::pool):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ParallelHelperPool.cpp
trunk/Source/WTF/wtf/ParallelHelperPool.h




Diff

Modified: trunk/Source/WTF/ChangeLog (190874 => 190875)

--- trunk/Source/WTF/ChangeLog	2015-10-12 18:43:00 UTC (rev 190874)
+++ trunk/Source/WTF/ChangeLog	2015-10-12 18:45:00 UTC (rev 190875)
@@ -1,3 +1,22 @@
+2015-10-12  Filip Pizlo  
+
+Unreviewed, fix style in the hopes that it fixes Windows.
+
+* wtf/ParallelHelperPool.cpp:
+(WTF::ParallelHelperClient::~ParallelHelperClient):
+(WTF::ParallelHelperClient::setTask):
+(WTF::ParallelHelperClient::doSomeHelping):
+(WTF::ParallelHelperClient::runTaskInParallel):
+(WTF::ParallelHelperClient::finish):
+(WTF::ParallelHelperClient::claimTask):
+(WTF::ParallelHelperClient::runTask):
+(WTF::ParallelHelperPool::doSomeHelping):
+(WTF::ParallelHelperPool::helperThreadBody):
+* wtf/ParallelHelperPool.h:
+(WTF::ParallelHelperClient::setFunction):
+(WTF::ParallelHelperClient::runFunctionInParallel):
+(WTF::ParallelHelperClient::pool):
+
 2015-10-10  Filip Pizlo  
 
 FTL should generate code to call slow paths lazily


Modified: trunk/Source/WTF/wtf/ParallelHelperPool.cpp (190874 => 190875)

--- trunk/Source/WTF/wtf/ParallelHelperPool.cpp	2015-10-12 18:43:00 UTC (rev 190874)
+++ trunk/Source/WTF/wtf/ParallelHelperPool.cpp	2015-10-12 18:45:00 UTC (rev 190875)
@@ -53,7 +53,7 @@
 }
 }
 
-void ParallelHelperClient::setTask(RefPtr> task)
+void ParallelHelperClient::setTask(RefPtr task)
 {
 LockHolder locker(m_pool->m_lock);
 RELEASE_ASSERT(!m_task);
@@ -69,7 +69,7 @@
 
 void ParallelHelperClient::doSomeHelping()
 {
-RefPtr> task;
+RefPtr task;
 {
 LockHolder locker(m_pool->m_lock);
 task = claimTask(locker);
@@ -80,7 +80,7 @@
 runTask(task);
 }
 
-void ParallelHelperClient::runTaskInParallel(RefPtr> task)
+void ParallelHelperClient::runTaskInParallel(RefPtr task)
 {
 setTask(task);
 doSomeHelping();
@@ -94,7 +94,7 @@
 m_pool->m_workCompleteCondition.wait(m_pool->m_lock);
 }
 
-RefPtr> ParallelHelperClient::claimTask(const LockHolder&)
+RefPtr ParallelHelperClient::claimTask(const LockHolder&)
 {
 if (!m_task)
 return nullptr;
@@ -103,7 +103,7 @@
 return m_task;
 }
 
-void ParallelHelperClient::runTask(RefPtr> task)
+void ParallelHelperClient::runTask(RefPtr task)
 {
 RELEASE_ASSERT(m_numActive);
 RELEASE_ASSERT(task);
@@ -153,7 +153,7 @@
 void ParallelHelperPool::doSomeHelping()
 {
 ParallelHelperClient* client;
-RefPtr> task;
+RefPtr task;
 {
 LockHolder locker(m_lock);
 client = getClientWithTask(locker);
@@ -182,7 +182,7 @@
 {
 for (;;) {
 ParallelHelperClient* client;
-RefPtr> task;
+RefPtr task;
 
 {
 LockHolder locker(m_lock);


Modified: trunk/Source/WTF/wtf/ParallelHelperPool.h (190874 => 190875)

--- trunk/Source/WTF/wtf/ParallelHelperPool.h	2015-10-12 18:43:00 UTC (rev 190874)
+++ trunk/Source/WTF/wtf/ParallelHelperPool.h	2015-10-12 18:45:00 UTC (rev 190875)
@@ -130,12 +130,12 @@
 WTF_EXPORT_PRIVATE ParallelHelperClient(RefPtr);
 WTF_EXPORT_PRIVATE ~ParallelHelperClient();
 
-WTF_EXPORT_PRIVATE void setTask(RefPtr>);
+WTF_EXPORT_PRIVATE void setTask(RefPtr);
 
 template
 void setFunction(const Functor& functor)
 {
-setTask(createSharedTask(functor));
+setTask(createSharedTask(functor));
 }
 
 WTF_EXPORT_PRIVATE void finish();
@@ -146,7 +146,7 @@
 // client->setTask(task);
 // client->doSomeHelping();
 // client->finish();
-WTF_EXPORT_PRIVATE void runTaskInParallel(RefPtr>);
+WTF_EXPORT_PRIVATE void runTaskInParallel(RefPtr);
 
 // Equivalent to:
 // client->setFunction(functor);
@@ 

[webkit-changes] [190876] trunk

[mmaxfield]

Title: [190876] trunk








Revision 190876
Author mmaxfi...@apple.com
Date 2015-10-12 12:00:47 -0700 (Mon, 12 Oct 2015)


Log Message
Test font-variant-* and font-feature-settings on Yosemite and Mavericks
https://bugs.webkit.org/show_bug.cgi?id=149778

Reviewed by Simon Fraser.

Source/WebCore:

We can simply call the function which enables features on Yosemite and Mavericks.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamily):

LayoutTests:

* platform/mac-wk1/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/font-feature-settings-rendering-expected.html
trunk/LayoutTests/css3/font-feature-settings-rendering.html
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (190875 => 190876)

--- trunk/LayoutTests/ChangeLog	2015-10-12 18:45:00 UTC (rev 190875)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 19:00:47 UTC (rev 190876)
@@ -1,3 +1,13 @@
+2015-10-12  Myles C. Maxfield  
+
+Test font-variant-* and font-feature-settings on Yosemite and Mavericks
+https://bugs.webkit.org/show_bug.cgi?id=149778
+
+Reviewed by Simon Fraser.
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac/TestExpectations:
+
 2015-10-12  Brent Fulgham  
 
 [Win] Unreviewed test gardening after r190800.


Modified: trunk/LayoutTests/css3/font-feature-settings-rendering-expected.html (190875 => 190876)

--- trunk/LayoutTests/css3/font-feature-settings-rendering-expected.html	2015-10-12 18:45:00 UTC (rev 190875)
+++ trunk/LayoutTests/css3/font-feature-settings-rendering-expected.html	2015-10-12 19:00:47 UTC (rev 190876)
@@ -16,6 +16,8 @@
 This tests that font features are able to be turned on and off as desired. It uses a special font
 designed specifically for this purpose. The test passes if you see a sequence of alternating check
 marks and X below.
+AB
+AB
 BA
 BA
 BA


Modified: trunk/LayoutTests/css3/font-feature-settings-rendering.html (190875 => 190876)

--- trunk/LayoutTests/css3/font-feature-settings-rendering.html	2015-10-12 18:45:00 UTC (rev 190875)
+++ trunk/LayoutTests/css3/font-feature-settings-rendering.html	2015-10-12 19:00:47 UTC (rev 190876)
@@ -16,6 +16,8 @@
 This tests that font features are able to be turned on and off as desired. It uses a special font
 designed specifically for this purpose. The test passes if you see a sequence of alternating check
 marks and X below.
+AB
+AB
 
 
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (190875 => 190876)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-10-12 18:45:00 UTC (rev 190875)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-10-12 19:00:47 UTC (rev 190876)
@@ -258,8 +258,9 @@
 # ENABLE(DRAGGABLE_REGION) is disabled
 fast/css/draggable-region-parser.html
 
-webkit.org/b/149246 [ Mavericks Yosemite ] css3/font-feature-settings-rendering.html [ ImageOnlyFailure ]
-webkit.org/b/149246 [ Mavericks Yosemite ] css3/font-variant-all.html [ ImageOnlyFailure ]
+# Font features are not implemented on Mavericks.
+webkit.org/b/149246 [ Mavericks ] css3/font-feature-settings-rendering.html [ ImageOnlyFailure ]
+webkit.org/b/149246 [ Mavericks ] css3/font-variant-all.html [ ImageOnlyFailure ]
 
 # This feature is disabled on Mavericks.
 [ Mavericks ] http/tests/navigation/page-cache-pending-image-load.html [ Skip ]


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (190875 => 190876)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-12 18:45:00 UTC (rev 190875)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-12 19:00:47 UTC (rev 190876)
@@ -161,4 +161,4 @@
 [ Release ] imported/blink/svg/custom/marker-layout-invalidation.html [ Pass Timeout ]
 [ Release ] imported/blink/fast/css/crash-corner-present.html [ Pass Timeout ]
 [ Release ] imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
-[ Debug ] imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]
\ No newline at end of file
+[ Debug ] imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]


Modified: trunk/Source/WebCore/ChangeLog (190875 => 190876)

--- trunk/Source/WebCore/ChangeLog	2015-10-12 18:45:00 UTC (rev 190875)
+++ trunk/Source/WebCore/ChangeLog	2015-10-12 19:00:47 UTC (rev 190876)
@@ -1,3 +1,16 @@
+2015-10-12  Myles C. Maxfield  
+
+Test font-variant-* and font-feature-settings on Yosemite and Mavericks
+https://bugs.webkit.org/show_bug.cgi?id=149778
+
+Reviewed by Simon Fraser.
+
+We can simply call the function which enables features on Yosemite and 

[webkit-changes] [190886] trunk/Source/bmalloc

[ggaren]

Title: [190886] trunk/Source/bmalloc








Revision 190886
Author gga...@apple.com
Date 2015-10-12 14:04:08 -0700 (Mon, 12 Oct 2015)


Log Message
bmalloc: Don't ASSERT that all syscalls succeed
https://bugs.webkit.org/show_bug.cgi?id=150047


Reviewed by Mark Lam.

madvise can fail due to VM behaviors outside of our control:
copy-on-write, fork, mprotect, and other stuff.

Older darwin kernels sometimes return this error value, and new kernels
might again in future.

We haven't gained much from this ASSERT so far, so let's remove it.

Perhaps in future we can come up with a scheme that makes madvise
never fail, or that responds to failure.

* bmalloc/Syscall.h:

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Syscall.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (190885 => 190886)

--- trunk/Source/bmalloc/ChangeLog	2015-10-12 20:37:05 UTC (rev 190885)
+++ trunk/Source/bmalloc/ChangeLog	2015-10-12 21:04:08 UTC (rev 190886)
@@ -1,3 +1,24 @@
+2015-10-12  Geoffrey Garen  
+
+bmalloc: Don't ASSERT that all syscalls succeed
+https://bugs.webkit.org/show_bug.cgi?id=150047
+
+
+Reviewed by Mark Lam.
+
+madvise can fail due to VM behaviors outside of our control:
+copy-on-write, fork, mprotect, and other stuff.
+
+Older darwin kernels sometimes return this error value, and new kernels
+might again in future.
+
+We haven't gained much from this ASSERT so far, so let's remove it.
+
+Perhaps in future we can come up with a scheme that makes madvise
+never fail, or that responds to failure.
+
+* bmalloc/Syscall.h:
+
 2015-10-10  Dan Bernstein  
 
 [iOS] Remove project support for iOS 8


Modified: trunk/Source/bmalloc/bmalloc/Syscall.h (190885 => 190886)

--- trunk/Source/bmalloc/bmalloc/Syscall.h	2015-10-12 20:37:05 UTC (rev 190885)
+++ trunk/Source/bmalloc/bmalloc/Syscall.h	2015-10-12 21:04:08 UTC (rev 190886)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014 Apple Inc. All rights reserved.
+ * Copyright (C) 2014, 2015 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -28,21 +28,8 @@
 
 #include 
 
-#if defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && (__MAC_OS_X_VERSION_MIN_REQUIRED >= 101000)
-
 #define SYSCALL(x) do { \
-while ((x) == -1) \
-RELEASE_BASSERT(errno == EAGAIN); \
-} while (0);
-
-#else
-
-// Older versions of OS X return EINVAL when trying to madvise COW pages. So, we
-// can't ASSERT that we'll only see EAGAIN.
-#define SYSCALL(x) do { \
 while ((x) == -1 && errno == EAGAIN) { } \
 } while (0);
 
-#endif
-
 #endif // Syscall_h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190899] trunk/Source/WebCore

[beidson]

Title: [190899] trunk/Source/WebCore








Revision 190899
Author beid...@apple.com
Date 2015-10-12 15:51:59 -0700 (Mon, 12 Oct 2015)


Log Message
Followup to:
Modern IDB: Start version change transaction for connections to new database.
https://bugs.webkit.org/show_bug.cgi?id=150033

Reviewed by NOBODY (Fixing existing test flakiness)

No new tests (Covered by existing tests)

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations): Early return if a version change transaction
  is already in progress.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190898 => 190899)

--- trunk/Source/WebCore/ChangeLog	2015-10-12 22:43:49 UTC (rev 190898)
+++ trunk/Source/WebCore/ChangeLog	2015-10-12 22:51:59 UTC (rev 190899)
@@ -1,3 +1,17 @@
+2015-10-12  Brady Eidson  
+
+Followup to:
+Modern IDB: Start version change transaction for connections to new database.
+https://bugs.webkit.org/show_bug.cgi?id=150033
+
+Reviewed by NOBODY (Fixing existing test flakiness)
+
+No new tests (Covered by existing tests)
+
+* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations): Early return if a version change transaction
+  is already in progress.
+
 2015-10-12  Myles C. Maxfield  
 
 [Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()


Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (190898 => 190899)

--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2015-10-12 22:43:49 UTC (rev 190898)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp	2015-10-12 22:51:59 UTC (rev 190899)
@@ -68,6 +68,11 @@
 ASSERT(isMainThread());
 LOG(IndexedDB, "(main) UniqueIDBDatabase::handleOpenDatabaseOperations");
 
+// If a version change transaction is currently in progress, no new connections can be opened right now.
+// We will try again later.
+if (m_versionChangeDatabaseConnection)
+return;
+
 auto operation = m_pendingOpenDatabaseOperations.takeFirst();
 
 // 3.3.1 Opening a database






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190900] trunk/Websites/perf.webkit.org

[rniwa]

Title: [190900] trunk/Websites/perf.webkit.org








Revision 190900
Author rn...@webkit.org
Date 2015-10-12 16:05:43 -0700 (Mon, 12 Oct 2015)


Log Message
Perf dashboard tools shouldn't require server credentials in multiple configuration files
https://bugs.webkit.org/show_bug.cgi?id=149994

Reviewed by Chris Dumez.

Made detect-changes.js and pull-svn.py pull username and passwords from the server config JSON to reduce
the number of JSON files that need to include credentials.

Also made each script reload the server config after sleep to allow dynamic credential updates.

In addition, change the server config JSON's format to include scheme, host, and port numbers separately
instead of a url since detect-changes.js needs each value separately.

This reduces the number of JSONs with credentials to two for our internal dashboard.

* tools/detect-changes.js:
(main): Added a property argument parsing. Now takes --server-config-json, --change-detection-config-json,
and --seconds-to-sleep like other scripts.
(parseArgument): Added.
(fetchManifestAndAnalyzeData): Reload the server config JSON.
(loadServerConfig): Added. Set settings.perfserver and settings.slave from the server config JSON. Also
add settings.perfserver.host to match the old format.
(configurationsForTesting): Fixed a bug that we throw an exception when a dashboard contains an empty cell.

* tools/pull-os-versions.py:
(main): Use load_server_config after each sleep.

* tools/pull-svn.py:
(main): Use load_server_config after each sleep.
(fetch_commits_and_submit): Use the perf dashboard's auth as subversion credential when useServerAuth is set.

* tools/sync-with-buildbot.py:
(main): Use load_server_config after each sleep.

* tools/util.py:
(load_server_config): Extracted from python scripts. Computes server's url from scheme, host, and port number
to match the old format python scripts except.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/tools/detect-changes.js
trunk/Websites/perf.webkit.org/tools/pull-os-versions.py
trunk/Websites/perf.webkit.org/tools/pull-svn.py
trunk/Websites/perf.webkit.org/tools/sync-with-buildbot.py
trunk/Websites/perf.webkit.org/tools/util.py




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (190899 => 190900)

--- trunk/Websites/perf.webkit.org/ChangeLog	2015-10-12 22:51:59 UTC (rev 190899)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2015-10-12 23:05:43 UTC (rev 190900)
@@ -1,3 +1,43 @@
+2015-10-12  Ryosuke Niwa  
+
+Perf dashboard tools shouldn't require server credentials in multiple configuration files
+https://bugs.webkit.org/show_bug.cgi?id=149994
+
+Reviewed by Chris Dumez.
+
+Made detect-changes.js and pull-svn.py pull username and passwords from the server config JSON to reduce
+the number of JSON files that need to include credentials.
+
+Also made each script reload the server config after sleep to allow dynamic credential updates.
+
+In addition, change the server config JSON's format to include scheme, host, and port numbers separately
+instead of a url since detect-changes.js needs each value separately.
+
+This reduces the number of JSONs with credentials to two for our internal dashboard.
+
+* tools/detect-changes.js:
+(main): Added a property argument parsing. Now takes --server-config-json, --change-detection-config-json,
+and --seconds-to-sleep like other scripts.
+(parseArgument): Added.
+(fetchManifestAndAnalyzeData): Reload the server config JSON.
+(loadServerConfig): Added. Set settings.perfserver and settings.slave from the server config JSON. Also
+add settings.perfserver.host to match the old format.
+(configurationsForTesting): Fixed a bug that we throw an exception when a dashboard contains an empty cell.
+
+* tools/pull-os-versions.py:
+(main): Use load_server_config after each sleep.
+
+* tools/pull-svn.py:
+(main): Use load_server_config after each sleep.
+(fetch_commits_and_submit): Use the perf dashboard's auth as subversion credential when useServerAuth is set.
+
+* tools/sync-with-buildbot.py:
+(main): Use load_server_config after each sleep.
+
+* tools/util.py:
+(load_server_config): Extracted from python scripts. Computes server's url from scheme, host, and port number
+to match the old format python scripts except.
+
 2015-10-11  Ryosuke Niwa  
 
 Build fix after r190817.  Now that pull-os-versions store fake timestamps, we need to bypass timestamp


Modified: trunk/Websites/perf.webkit.org/tools/detect-changes.js (190899 => 190900)

--- trunk/Websites/perf.webkit.org/tools/detect-changes.js	2015-10-12 22:51:59 UTC (rev 190899)
+++ trunk/Websites/perf.webkit.org/tools/detect-changes.js	2015-10-12 23:05:43 UTC (rev 190900)
@@ -7,32 +7,84 @@
 var RunsData = 

[webkit-changes] [190890] trunk

[commit-queue]

Title: [190890] trunk








Revision 190890
Author commit-qu...@webkit.org
Date 2015-10-12 14:48:32 -0700 (Mon, 12 Oct 2015)


Log Message
[SVG] Handle endEvent for svg animations
https://bugs.webkit.org/show_bug.cgi?id=121587

Patch by Antoine Quint  on 2015-10-12
Reviewed by Dean Jackson.

Source/WebCore:

Add support for the "endEvent" SVG event triggered when an animation completes, as
specified in http://www.w3.org/TR/SMIL3/smil-timing.html#q135. This event doesn't
bubble and can't be canceled. Added test coverage for the event through the DOM
Events API as well as the declarative SMIL Animation syntax.

Adapted from a Chromium patch by pava...@samsung.com
https://chromium.googlesource.com/chromium/blink/+/4d415ca0268231aa80e3552fe21bf3480a6978f8

Tests: svg/animations/end-event-declarative-expected.svg
   svg/animations/end-event-declarative.svg
   svg/animations/end-event-script-expected.svg
   svg/animations/end-event-script.svg

* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
* svg/animation/SVGSMILElement.cpp:
(WebCore::smilEndEventSender):
(WebCore::SVGSMILElement::~SVGSMILElement):
(WebCore::SVGSMILElement::progress):
(WebCore::SVGSMILElement::dispatchPendingEvent):
* svg/animation/SVGSMILElement.h:
(WebCore::SVGSMILElement::hasConditionsConnected):

LayoutTests:

Tests for the "endEvent" event for SVG animations.

* svg/animations/end-event-declarative-expected.svg: Added.
* svg/animations/end-event-declarative.svg: Added.
* svg/animations/end-event-script-expected.svg: Added.
* svg/animations/end-event-script.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/animation/SMILTimeContainer.cpp
trunk/Source/WebCore/svg/animation/SVGSMILElement.cpp
trunk/Source/WebCore/svg/animation/SVGSMILElement.h


Added Paths

trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg
trunk/LayoutTests/svg/animations/end-event-declarative.svg
trunk/LayoutTests/svg/animations/end-event-script-expected.svg
trunk/LayoutTests/svg/animations/end-event-script.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (190889 => 190890)

--- trunk/LayoutTests/ChangeLog	2015-10-12 21:31:28 UTC (rev 190889)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 21:48:32 UTC (rev 190890)
@@ -1,3 +1,17 @@
+2015-10-12  Antoine Quint  
+
+[SVG] Handle endEvent for svg animations
+https://bugs.webkit.org/show_bug.cgi?id=121587
+
+Reviewed by Dean Jackson.
+
+Tests for the "endEvent" event for SVG animations.
+
+* svg/animations/end-event-declarative-expected.svg: Added.
+* svg/animations/end-event-declarative.svg: Added.
+* svg/animations/end-event-script-expected.svg: Added.
+* svg/animations/end-event-script.svg: Added.
+
 2015-10-12  Brady Eidson  
 
 Modern IDB: Start version change transaction for connections to new database.


Added: trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg (0 => 190890)

--- trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg	(rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-declarative-expected.svg	2015-10-12 21:48:32 UTC (rev 190890)
@@ -0,0 +1,5 @@
+
+
+
+
+
\ No newline at end of file


Added: trunk/LayoutTests/svg/animations/end-event-declarative.svg (0 => 190890)

--- trunk/LayoutTests/svg/animations/end-event-declarative.svg	(rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-declarative.svg	2015-10-12 21:48:32 UTC (rev 190890)
@@ -0,0 +1,19 @@
+
+
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function loaded() {
+document.documentElement.setCurrentTime(2);
+
+if (window.testRunner)
+setTimeout(function() {testRunner.notifyDone();}, 100);
+}
+
+
\ No newline at end of file


Added: trunk/LayoutTests/svg/animations/end-event-script-expected.svg (0 => 190890)

--- trunk/LayoutTests/svg/animations/end-event-script-expected.svg	(rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-script-expected.svg	2015-10-12 21:48:32 UTC (rev 190890)
@@ -0,0 +1,5 @@
+
+
+
+
+
\ No newline at end of file


Added: trunk/LayoutTests/svg/animations/end-event-script.svg (0 => 190890)

--- trunk/LayoutTests/svg/animations/end-event-script.svg	(rev 0)
+++ trunk/LayoutTests/svg/animations/end-event-script.svg	2015-10-12 21:48:32 UTC (rev 190890)
@@ -0,0 +1,21 @@
+
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function loaded() {
+document.getElementById("anim").addEventListener("endEvent", function(event) {
+document.getElementById("rect").setAttribute("fill", "green");
+testRunner.notifyDone();
+});
+
+document.documentElement.setCurrentTime(2);
+}
+
+
+
\ No 

[webkit-changes] [190908] trunk/PerformanceTests

[jonlee]

Title: [190908] trunk/PerformanceTests








Revision 190908
Author jon...@apple.com
Date 2015-10-12 17:11:16 -0700 (Mon, 12 Oct 2015)


Log Message
Refactor tune() to pass in an integer-based count
https://bugs.webkit.org/show_bug.cgi?id=150060


Reviewed by Dean Jackson.

All of the tune functions do an initial step of flooring the
# of painting objects to add or remove. Factor that out since
the complexity of all of these tests is always expressed in terms
of countable items.

* Animometer/tests/resources/main.js:
(Benchmark.prototype.update): Update the tuneValue.

* Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
(BouncingParticlesStage.prototype.tune): Remove the count adjustment.
* Animometer/tests/examples/resources/canvas-electrons.js:
(CanvasElectronsStage.prototype.tune): Ditto.
* Animometer/tests/examples/resources/canvas-stars.js:
(CanvasStarsStage.prototype.tune): Ditto.
* Animometer/tests/text/resources/layering-text.js:
(LayeringTextStage.prototype.tune): Ditto.

Modified Paths

trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js
trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-electrons.js
trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-stars.js
trunk/PerformanceTests/Animometer/tests/resources/main.js
trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js (190907 => 190908)

--- trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js	2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js	2015-10-13 00:11:16 UTC (rev 190908)
@@ -95,8 +95,6 @@
 
 BouncingParticlesStage.prototype.tune = function(count)
 {
-count = count > 0 ? Math.floor(count) : Math.ceil(count);
-
 if (count == 0)
 return this._particles.length;
 


Modified: trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-electrons.js (190907 => 190908)

--- trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-electrons.js	2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-electrons.js	2015-10-13 00:11:16 UTC (rev 190908)
@@ -60,8 +60,6 @@
 
 CanvasElectronsStage.prototype.tune = function(count)
 {
-count = count > 0 ? Math.floor(count) : Math.ceil(count);
-
 if (count == 0)
 return this._electrons.length;
 


Modified: trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-stars.js (190907 => 190908)

--- trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-stars.js	2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/examples/resources/canvas-stars.js	2015-10-13 00:11:16 UTC (rev 190908)
@@ -61,8 +61,6 @@
 
 CanvasStarsStage.prototype.tune = function(count)
 {
-count = count > 0 ? Math.floor(count) : Math.ceil(count);
-
 if (count == 0)
 return this._objects.length;
 


Modified: trunk/PerformanceTests/Animometer/tests/resources/main.js (190907 => 190908)

--- trunk/PerformanceTests/Animometer/tests/resources/main.js	2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/resources/main.js	2015-10-13 00:11:16 UTC (rev 190908)
@@ -183,6 +183,7 @@
 // The relationship between frameRate and test complexity is inverse-proportional so we
 // need to use the negative of PIDController.tune() to change the complexity of the test.
 tuneValue = -this._controller.tune(currentFrameRate, timeDelta / 1000);
+tuneValue = tuneValue > 0 ? Math.floor(tuneValue) : Math.ceil(tuneValue);
 }
 
 var currentComplexity = this.tune(tuneValue);


Modified: trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js (190907 => 190908)

--- trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js	2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js	2015-10-13 00:11:16 UTC (rev 190908)
@@ -220,8 +220,6 @@
 
 LayeringTextStage.prototype.tune = function(count)
 {
-count = count > 0 ? Math.floor(count) : Math.ceil(count);
-
 if (count == 0)
 return this._textElements.length;
 


Modified: trunk/PerformanceTests/ChangeLog (190907 => 190908)

--- trunk/PerformanceTests/ChangeLog	2015-10-13 00:03:31 UTC (rev 190907)
+++ trunk/PerformanceTests/ChangeLog	2015-10-13 00:11:16 UTC (rev 190908)
@@ -1,5 +1,30 @@
 2015-10-12  Jon Lee  
 
+Refactor tune() to pass in an integer-based count
+https://bugs.webkit.org/show_bug.cgi?id=150060
+
+
+Reviewed by Dean Jackson.
+
+All of the tune functions do an initial step of flooring the
+# of painting objects to add or remove. Factor 

[webkit-changes] [190917] trunk/PerformanceTests

[jonlee]

Title: [190917] trunk/PerformanceTests








Revision 190917
Author jon...@apple.com
Date 2015-10-12 19:10:08 -0700 (Mon, 12 Oct 2015)


Log Message
Add canvas path fill tests
https://bugs.webkit.org/show_bug.cgi?id=150071


Reviewed by Dean Jackson.

* Animometer/runner/resources/tests.js: Add new pathTypes for path fills.
* Animometer/tests/simple/resources/simple-canvas-paths.js:
(CanvasLinePoint): Add basic point for a line, and call lineTo.
(SimpleCanvasPathFillStage): Add a new stage similar to SimpleCanvasPathStrokeStage.
(CanvasPathBenchmark.prototype.createStage): Add the tests.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/tests.js (190916 => 190917)

--- trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 02:09:34 UTC (rev 190916)
+++ trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 02:10:08 UTC (rev 190917)
@@ -167,6 +167,18 @@
 name: "Canvas rects"
 },
 {
+url: "simple/simple-canvas-paths.html?pathType=lineFill",
+name: "Canvas line path, fill"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=quadraticFill",
+name: "Canvas quadratic path, fill"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=bezierFill",
+name: "Canvas bezier path, fill"
+},
+{
 url: "simple/simple-canvas-paths.html?=arcToFill",
 name: "Canvas arcTo segments, fill"
 },


Modified: trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js (190916 => 190917)

--- trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:09:34 UTC (rev 190916)
+++ trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:10:08 UTC (rev 190917)
@@ -1,5 +1,12 @@
 // === PAINT OBJECTS ===
 
+function CanvasLinePoint(stage, coordinateMaximum) {
+this._point = stage.randomPosition(new Point(Math.min(stage.size.x, coordinateMaximum), Math.min(stage.size.y, coordinateMaximum)));
+}
+CanvasLinePoint.prototype.draw = function(context) {
+context.lineTo(this._point.x, this._point.y);
+};
+
 function CanvasQuadraticSegment(stage) {
 var maxSize = stage.randomInt(20, 200);
 var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2));
@@ -142,6 +149,22 @@
 context.stroke();
 }
 
+function SimpleCanvasPathFillStage(element, options, canvasObject) {
+SimpleCanvasStage.call(this, element, options, canvasObject);
+}
+SimpleCanvasPathFillStage.prototype = Object.create(SimpleCanvasStage.prototype);
+SimpleCanvasPathFillStage.prototype.constructor = SimpleCanvasPathFillStage;
+SimpleCanvasPathFillStage.prototype.animate = function() {
+var context = this.context;
+context.fillStyle = this.randomColor();
+context.beginPath();
+context.moveTo(0,0);
+this._objects.forEach(function(object) {
+object.draw(context);
+});
+context.fill();
+}
+
 // === BENCHMARK ===
 
 function CanvasPathBenchmark(suite, test, options, recordTable, progressBar) {
@@ -166,6 +189,12 @@
 return new SimpleCanvasStage(element, this._options, CanvasArcSegment);
 case "rect":
 return new SimpleCanvasStage(element, this._options, CanvasRect);
+case "lineFill":
+return new SimpleCanvasPathFillStage(element, this._options, CanvasLinePoint);
+case "quadraticFill":
+return new SimpleCanvasPathFillStage(element, this._options, CanvasQuadraticPoint);
+case "bezierFill":
+return new SimpleCanvasPathFillStage(element, this._options, CanvasBezierPoint);
 case "arcToFill":
 return new SimpleCanvasStage(element, this._options, CanvasArcToSegmentFill);
 case "arcFill":


Modified: trunk/PerformanceTests/ChangeLog (190916 => 190917)

--- trunk/PerformanceTests/ChangeLog	2015-10-13 02:09:34 UTC (rev 190916)
+++ trunk/PerformanceTests/ChangeLog	2015-10-13 02:10:08 UTC (rev 190917)
@@ -1,5 +1,19 @@
 2015-10-12  Jon Lee  
 
+Add canvas path fill tests
+https://bugs.webkit.org/show_bug.cgi?id=150071
+
+
+Reviewed by Dean Jackson.
+
+* Animometer/runner/resources/tests.js: Add new pathTypes for path fills.
+* Animometer/tests/simple/resources/simple-canvas-paths.js:
+(CanvasLinePoint): Add basic point for a line, and call lineTo.
+(SimpleCanvasPathFillStage): Add a new stage similar to SimpleCanvasPathStrokeStage.
+(CanvasPathBenchmark.prototype.createStage): Add the tests.
+
+2015-10-12  Jon Lee  
+
 Add canvas path tests
 https://bugs.webkit.org/show_bug.cgi?id=150067
 

[webkit-changes] [190903] trunk/PerformanceTests

[jonlee]

Title: [190903] trunk/PerformanceTests








Revision 190903
Author jon...@apple.com
Date 2015-10-12 16:25:41 -0700 (Mon, 12 Oct 2015)


Log Message
Remove "../tests/" from the URLs of all tests
https://bugs.webkit.org/show_bug.cgi?id=150054


Reviewed by Dean Jackson.

Presumably all tests will be running from the tests/ directory,
so we don't have to specify it in all of the test URLs.

* Animometer/runner/resources/benchmark-runner.js:
(BenchmarkRunnerState.prototype.prepareCurrentTest): Prepend
"../tests/" to all tests.
* Animometer/runner/resources/tests.js: Remove "../tests/" from
all URLs.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/benchmark-runner.js
trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/benchmark-runner.js (190902 => 190903)

--- trunk/PerformanceTests/Animometer/runner/resources/benchmark-runner.js	2015-10-12 23:22:23 UTC (rev 190902)
+++ trunk/PerformanceTests/Animometer/runner/resources/benchmark-runner.js	2015-10-12 23:25:41 UTC (rev 190903)
@@ -46,7 +46,7 @@
 frame._onload_ = function() {
 suite.prepare(runner, frame.contentWindow, frame.contentDocument).then(function(result) { promise.resolve(result); });
 }
-frame.src = ""
+frame.src = "" + test.url;
 return promise;
 }
 


Modified: trunk/PerformanceTests/Animometer/runner/resources/tests.js (190902 => 190903)

--- trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-12 23:22:23 UTC (rev 190902)
+++ trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-12 23:25:41 UTC (rev 190903)
@@ -60,27 +60,27 @@
 Suites.push(new Suite("HTML suite",
 [
 { 
-url: "../tests/bouncing-particles/bouncing-css-shapes.html?gain=1=100=5=12=12=circle",
+url: "bouncing-particles/bouncing-css-shapes.html?gain=1=100=5=12=12=circle",
 name: "CSS bouncing circles"
 },
 { 
-url: "../tests/bouncing-particles/bouncing-css-shapes.html?gain=1=100=5=40=40=rect=star",
+url: "bouncing-particles/bouncing-css-shapes.html?gain=1=100=5=40=40=rect=star",
 name: "CSS bouncing clipped rects"
 },
 { 
-url: "../tests/bouncing-particles/bouncing-css-shapes.html?gain=1=100=5=50=50=circle=gradient",
+url: "bouncing-particles/bouncing-css-shapes.html?gain=1=100=5=50=50=circle=gradient",
 name: "CSS bouncing gradient circles"
 },
 {
-url: "../tests/bouncing-particles/bouncing-css-images.html?gain=0.4=5=2=80=80=../resources/yin-yang.svg",
+url: "bouncing-particles/bouncing-css-images.html?gain=0.4=5=2=80=80=../resources/yin-yang.svg",
 name: "CSS bouncing SVG images"
 },
 {
-url: "../tests/bouncing-particles/bouncing-css-images.html?gain=1=100=5=80=80=../resources/yin-yang.png",
+url: "bouncing-particles/bouncing-css-images.html?gain=1=100=5=80=80=../resources/yin-yang.png",
 name: "CSS bouncing PNG images"
 },
 {
-url: "../tests/text/layering-text.html?gain=4=100=100",
+url: "text/layering-text.html?gain=4=100=100",
 name: "CSS layering text"
 },
 ]
@@ -89,23 +89,23 @@
 Suites.push(new Suite("Canvas suite",
 [
 { 
-url: "../tests/bouncing-particles/bouncing-canvas-shapes.html?gain=4=100=1000=12=12=circle",
+url: "bouncing-particles/bouncing-canvas-shapes.html?gain=4=100=1000=12=12=circle",
 name: "canvas bouncing circles"
 },
 { 
-url: "../tests/bouncing-particles/bouncing-canvas-shapes.html?gain=4=100=1000=40=40=rect=star",
+url: "bouncing-particles/bouncing-canvas-shapes.html?gain=4=100=1000=40=40=rect=star",
 name: "canvas bouncing clipped rects"
 },
 { 
-url: "../tests/bouncing-particles/bouncing-canvas-shapes.html?gain=4=100=1000=50=50=circle=gradient",
+url: "bouncing-particles/bouncing-canvas-shapes.html?gain=4=100=1000=50=50=circle=gradient",
 name: "canvas bouncing gradient circles"
 },
 { 
-url: "../tests/bouncing-particles/bouncing-canvas-images.html?gain=0.4=5=1=80=80=../resources/yin-yang.svg",
+url: "bouncing-particles/bouncing-canvas-images.html?gain=0.4=5=1=80=80=../resources/yin-yang.svg",
 name: "canvas bouncing SVG images"
 },
 {
-url: "../tests/bouncing-particles/bouncing-canvas-images.html?gain=4=1000=1000=80=80=../resources/yin-yang.png",
+url: "bouncing-particles/bouncing-canvas-images.html?gain=4=1000=1000=80=80=../resources/yin-yang.png",
 name: "canvas bouncing PNG images"
 },
 ]
@@ -114,23 +114,23 @@
 Suites.push(new Suite("SVG suite",
 [
 {
-url: 

[webkit-changes] [190911] trunk/Source/WebCore

[simon . fraser]

Title: [190911] trunk/Source/WebCore








Revision 190911
Author simon.fra...@apple.com
Date 2015-10-12 17:55:06 -0700 (Mon, 12 Oct 2015)


Log Message
Fix iOS and Efl builds.

* platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::drawPattern):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/NamedImageGeneratedImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190910 => 190911)

--- trunk/Source/WebCore/ChangeLog	2015-10-13 00:52:13 UTC (rev 190910)
+++ trunk/Source/WebCore/ChangeLog	2015-10-13 00:55:06 UTC (rev 190911)
@@ -1,5 +1,12 @@
 2015-10-12  Simon Fraser  
 
+Fix iOS and Efl builds.
+
+* platform/graphics/NamedImageGeneratedImage.cpp:
+(WebCore::NamedImageGeneratedImage::drawPattern):
+
+2015-10-12  Simon Fraser  
+
 Remove Image::spaceSize() and ImageBuffer::spaceSize()
 https://bugs.webkit.org/show_bug.cgi?id=150064
 


Modified: trunk/Source/WebCore/platform/graphics/NamedImageGeneratedImage.cpp (190910 => 190911)

--- trunk/Source/WebCore/platform/graphics/NamedImageGeneratedImage.cpp	2015-10-13 00:52:13 UTC (rev 190910)
+++ trunk/Source/WebCore/platform/graphics/NamedImageGeneratedImage.cpp	2015-10-13 00:55:06 UTC (rev 190911)
@@ -77,6 +77,7 @@
 UNUSED_PARAM(srcRect);
 UNUSED_PARAM(patternTransform);
 UNUSED_PARAM(phase);
+UNUSED_PARAM(spacing);
 UNUSED_PARAM(styleColorSpace);
 UNUSED_PARAM(dstRect);
 UNUSED_PARAM(compositeOp);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190913] trunk/PerformanceTests

[jonlee]

Title: [190913] trunk/PerformanceTests








Revision 190913
Author jon...@apple.com
Date 2015-10-12 18:18:03 -0700 (Mon, 12 Oct 2015)


Log Message
Add canvas path tests
https://bugs.webkit.org/show_bug.cgi?id=150067
rdar://problem/23081463

Reviewed by Dean Jackson.

* Animometer/runner/resources/tests.js: Add a quadratic and bezier path test.

* Animometer/tests/simple/resources/simple-canvas.js:
(SimpleCanvasStage.prototype.tune): This kind of test joins all of the segments
into one long path, and tries to render that one path. Random points make it
difficult to tell what is going on, so add a parameter to the constructor to
confine the area where the random coordinates can land. The more complicated the
case is, the larger an area the path will cover. Add an artificial minimum so
that the first 200 points aren't confined to a space that is too small.

* Animometer/tests/simple/resources/simple-canvas-paths.js:
(SimpleCanvasPathStrokeStage): Add a new kind of stage that inherits from
SimpleCanvasStage. Each time the frame animates a random line width and stroke
color are chosen. The path setup is done outside of each paint object.
(CanvasQuadraticPoint): This point just calls quadraticCurveTo.
(CanvasPathBenchmark.prototype.createStage): Add the tests.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/tests.js (190912 => 190913)

--- trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 01:11:45 UTC (rev 190912)
+++ trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 01:18:03 UTC (rev 190913)
@@ -143,10 +143,18 @@
 name: "Canvas quadratic segments"
 },
 {
+url: "simple/simple-canvas-paths.html?pathType=quadraticPath",
+name: "Canvas quadratic path"
+},
+{
 url: "simple/simple-canvas-paths.html?pathType=bezier",
 name: "Canvas bezier segments"
 },
 {
+url: "simple/simple-canvas-paths.html?pathType=bezierPath",
+name: "Canvas bezier path"
+},
+{
 url: "simple/simple-canvas-paths.html?=arcTo",
 name: "Canvas arcTo segments"
 },


Modified: trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js (190912 => 190913)

--- trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 01:11:45 UTC (rev 190912)
+++ trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 01:18:03 UTC (rev 190913)
@@ -19,6 +19,15 @@
 context.stroke();
 };
 
+function CanvasQuadraticPoint(stage, coordinateMaximum) {
+var pointMaximum = new Point(Math.min(stage.size.x, coordinateMaximum), Math.min(stage.size.y, coordinateMaximum));
+this._point1 = stage.randomPosition(pointMaximum);
+this._point2 = stage.randomPosition(pointMaximum);
+};
+CanvasQuadraticPoint.prototype.draw = function(context) {
+context.quadraticCurveTo(this._point1.x, this._point1.y, this._point2.x, this._point2.y);
+};
+
 function CanvasBezierSegment(stage) {
 var maxSize = stage.randomInt(20, 200);
 var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2));
@@ -39,6 +48,16 @@
 context.stroke();
 };
 
+function CanvasBezierPoint(stage, coordinateMaximum) {
+var pointMaximum = new Point(Math.min(stage.size.x, coordinateMaximum), Math.min(stage.size.y, coordinateMaximum));
+this._point1 = stage.randomPosition(pointMaximum);
+this._point2 = stage.randomPosition(pointMaximum);
+this._point3 = stage.randomPosition(pointMaximum);
+};
+CanvasBezierPoint.prototype.draw = function(context) {
+context.bezierCurveTo(this._point1.x, this._point1.y, this._point2.x, this._point2.y, this._point3.x, this._point3.y);
+};
+
 function CanvasArcToSegment(stage) {
 var maxSize = stage.randomInt(20, 200);
 var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2));
@@ -104,6 +123,25 @@
 context.fill();
 };
 
+// === STAGES ===
+
+function SimpleCanvasPathStrokeStage(element, options, canvasObject) {
+SimpleCanvasStage.call(this, element, options, canvasObject);
+}
+SimpleCanvasPathStrokeStage.prototype = Object.create(SimpleCanvasStage.prototype);
+SimpleCanvasPathStrokeStage.prototype.constructor = SimpleCanvasPathStrokeStage;
+SimpleCanvasPathStrokeStage.prototype.animate = function() {
+var context = this.context;
+context.lineWidth = this.randomInt(1, 20);
+context.strokeStyle = this.randomColor();
+context.beginPath();
+context.moveTo(0,0);
+this._objects.forEach(function(object) {
+object.draw(context);
+});
+context.stroke();
+}

[webkit-changes] [190891] trunk

[mmaxfield]

Title: [190891] trunk








Revision 190891
Author mmaxfi...@apple.com
Date 2015-10-12 15:08:27 -0700 (Mon, 12 Oct 2015)


Log Message
REGRESSION(r182192): Ligatures do not interact correctly with SHY in some fonts
https://bugs.webkit.org/show_bug.cgi?id=150006

Reviewed by Simon Fraser.

Source/WebCore:

When performing font transforms and we encounter kCGFontIndexInvalid, we filter it out of the
GlyphBuffer. However, this filter was only interacting with part of the GlyphBuffer instead
of the whole thing. This causes glyph IDs from one font to be rendered with other fonts,
thereby showing garbage glyphs.

However, now that  is fixed, we don't need to perform this filter in
the first place.

Test: fast/text/undefined-glyph-with-ligature.html

* platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::copyItem):
(WebCore::GlyphBuffer::swap):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyFontTransforms):

LayoutTests:

* fast/text/resources/tiny-ligature-font.svg: Added.
* fast/text/undefined-glyph-with-ligature-expected.html: Added.
* fast/text/undefined-glyph-with-ligature.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/WidthIterator.cpp


Added Paths

trunk/LayoutTests/fast/text/resources/tiny-ligature-font.svg
trunk/LayoutTests/fast/text/undefined-glyph-with-ligature-expected.html
trunk/LayoutTests/fast/text/undefined-glyph-with-ligature.html




Diff

Modified: trunk/LayoutTests/ChangeLog (190890 => 190891)

--- trunk/LayoutTests/ChangeLog	2015-10-12 21:48:32 UTC (rev 190890)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 22:08:27 UTC (rev 190891)
@@ -1,3 +1,14 @@
+2015-10-12  Myles C. Maxfield  
+
+REGRESSION(r182192): Ligatures do not interact correctly with SHY in some fonts
+https://bugs.webkit.org/show_bug.cgi?id=150006
+
+Reviewed by Simon Fraser.
+
+* fast/text/resources/tiny-ligature-font.svg: Added.
+* fast/text/undefined-glyph-with-ligature-expected.html: Added.
+* fast/text/undefined-glyph-with-ligature.html: Added.
+
 2015-10-12  Antoine Quint  
 
 [SVG] Handle endEvent for svg animations


Added: trunk/LayoutTests/fast/text/resources/tiny-ligature-font.svg (0 => 190891)

--- trunk/LayoutTests/fast/text/resources/tiny-ligature-font.svg	(rev 0)
+++ trunk/LayoutTests/fast/text/resources/tiny-ligature-font.svg	2015-10-12 22:08:27 UTC (rev 190891)
@@ -0,0 +1,13 @@
+
+
+  
+
+  
+  
+
+
+
+
+
+  
+


Added: trunk/LayoutTests/fast/text/undefined-glyph-with-ligature-expected.html (0 => 190891)

--- trunk/LayoutTests/fast/text/undefined-glyph-with-ligature-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/undefined-glyph-with-ligature-expected.html	2015-10-12 22:08:27 UTC (rev 190891)
@@ -0,0 +1,16 @@
+
+
+
+
+@font-face {
+font-family: Litherum;
+src: url("resources/tiny-ligature-font.svg") format("svg");
+}
+
+
+
+This test makes sure that the combination of ligatures and nonexistant glyphs do not cause arbitrary glyphs to be rendered.
+The test passes if you see two black rectangles below, and nothing else.
+ABA
+
+


Added: trunk/LayoutTests/fast/text/undefined-glyph-with-ligature.html (0 => 190891)

--- trunk/LayoutTests/fast/text/undefined-glyph-with-ligature.html	(rev 0)
+++ trunk/LayoutTests/fast/text/undefined-glyph-with-ligature.html	2015-10-12 22:08:27 UTC (rev 190891)
@@ -0,0 +1,16 @@
+
+
+
+
+@font-face {
+font-family: Litherum;
+src: url("resources/tiny-ligature-font.svg") format("svg");
+}
+
+
+
+This test makes sure that the combination of ligatures and nonexistant glyphs do not cause arbitrary glyphs to be rendered.
+The test passes if you see two black rectangles below, and nothing else.
+ABA
+
+


Modified: trunk/Source/WebCore/ChangeLog (190890 => 190891)

--- trunk/Source/WebCore/ChangeLog	2015-10-12 21:48:32 UTC (rev 190890)
+++ trunk/Source/WebCore/ChangeLog	2015-10-12 22:08:27 UTC (rev 190891)
@@ -1,3 +1,26 @@
+2015-10-12  Myles C. Maxfield  
+
+REGRESSION(r182192): Ligatures do not interact correctly with SHY in some fonts
+https://bugs.webkit.org/show_bug.cgi?id=150006
+
+Reviewed by Simon Fraser.
+
+When performing font transforms and we encounter kCGFontIndexInvalid, we filter it out of the
+GlyphBuffer. However, this filter was only interacting with part of the GlyphBuffer instead
+of the whole thing. This causes glyph IDs from one font to be rendered with other fonts,
+thereby showing garbage glyphs.
+
+However, now that  is fixed, we don't need to perform this filter in
+the first place.
+
+Test: fast/text/undefined-glyph-with-ligature.html
+
+* platform/graphics/GlyphBuffer.h:
+(WebCore::GlyphBuffer::copyItem):
+

[webkit-changes] [190902] trunk/PerformanceTests

[jonlee]

Title: [190902] trunk/PerformanceTests








Revision 190902
Author jon...@apple.com
Date 2015-10-12 16:22:23 -0700 (Mon, 12 Oct 2015)


Log Message
Refactor test suites to a separate class.
https://bugs.webkit.org/show_bug.cgi?id=150053


Reviewed by Dean Jackson.

Create a Suite class to refactor out prepare() and run().
Generate the checkboxes representing the suites using Suites
instead of maintaining a separate list. Also, save the
selections out to localStorage.

* Animometer/runner/animometer.html: Remove the explicitly listed
suites. These will be generated from Suites instead.
* Animometer/runner/resources/animometer.js:
(populateSettings): Iterate through Suites, and create the
label and checkbox. Attach the Suite object to the checkbox so
when the benchmark is started, we get direct access. Initialize
the checkmark based on its value in localStorage. Set this to
run when DOMContentLoaded is dispatched.
(startBenchmark): Grab all of the checkboxes, inspect their
values, add it to enabledSuites if selected. Remember whether
the suite was enabled in localStorage, so that it's easy to do
repeated runs.
* Animometer/runner/resources/tests.js:
(Suite): Create a new Suite class. Refactor out prepare() and
run(), since all of them have the same implementation. Populate
Suites with Suite instances instead of generic objects.

Modified Paths

trunk/PerformanceTests/Animometer/runner/animometer.html
trunk/PerformanceTests/Animometer/runner/resources/animometer.js
trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/animometer.html (190901 => 190902)

--- trunk/PerformanceTests/Animometer/runner/animometer.html	2015-10-12 23:20:24 UTC (rev 190901)
+++ trunk/PerformanceTests/Animometer/runner/animometer.html	2015-10-12 23:22:23 UTC (rev 190902)
@@ -19,12 +19,7 @@
 to tune their complexities to stay close to 50 FPS.
 
 
-
- HTML elements suite
- Canvas drawings suite
- SVG elements suite
- Examples suite
- Template suite
+
 
 
 Test interval:  seconds


Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.js (190901 => 190902)

--- trunk/PerformanceTests/Animometer/runner/resources/animometer.js	2015-10-12 23:20:24 UTC (rev 190901)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.js	2015-10-12 23:22:23 UTC (rev 190902)
@@ -59,13 +59,16 @@
 
 function startBenchmark()
 {
-var checkboxes = [ 
-document.getElementById("html-suite"), 
-document.getElementById("canvas-suite"), 
-document.getElementById("svg-suite"),
-document.getElementById("examples-suite"),
-document.getElementById("template-suite"),
-];
+var enabledSuites = [];
+var checkboxes = document.querySelectorAll("#suites input");
+for (var i = 0; i < checkboxes.length; ++i) {
+var checkbox = checkboxes[i];
+if (checkbox.checked) {
+enabledSuites.push(checkbox.suite);
+}
+localStorage.setItem(checkbox.suite.name, +checkbox.checked);
+}
+
 var enabledSuites = Suites.filter(function (suite, index) { return !suite.disabled && checkboxes[index].checked; });
 var testsCount = enabledSuites.reduce(function (testsCount, suite) { return testsCount + suite.tests.length; }, 0);
 benchmarkRunnerClient.testsCount = benchmarkRunnerClient.iterationCount * testsCount;
@@ -110,3 +113,25 @@
 graph("#graphContainer", new Point(700, 400), new Insets(20, 50, 20, 50), axes, samples, samplingTimeOffset);
 showSection("graph", true);
 }
+
+function populateSettings() {
+var suitesDiv = document.getElementById("suites");
+Suites.forEach(function(suite) {
+var suiteDiv = document.createDocumentFragment();
+
+var label = document.createElement("label");
+var checkbox = document.createElement("input");
+checkbox.setAttribute("type", "checkbox");
+checkbox.suite = suite;
+if (+localStorage.getItem(suite.name)) {
+checkbox.checked = true;
+}
+label.appendChild(checkbox);
+label.appendChild(document.createTextNode(" " + suite.name));
+
+suiteDiv.appendChild(label);
+suiteDiv.appendChild(document.createElement("br"));
+suitesDiv.appendChild(suiteDiv);
+});
+}
+document.addEventListener("DOMContentLoaded", populateSettings);
\ No newline at end of file


Modified: trunk/PerformanceTests/Animometer/runner/resources/tests.js (190901 => 190902)

--- trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-12 23:20:24 UTC (rev 190901)
+++ trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-12 23:22:23 UTC (rev 190902)
@@ -38,24 +38,27 @@
 }
 ];
 
-var 

[webkit-changes] [190909] trunk

[commit-queue]

Title: [190909] trunk








Revision 190909
Author commit-qu...@webkit.org
Date 2015-10-12 17:37:48 -0700 (Mon, 12 Oct 2015)


Log Message
[GTK] OSX linker doesn't understand --whole-archive
https://bugs.webkit.org/show_bug.cgi?id=144557

Patch by Philip Chimento  on 2015-10-12
Reviewed by Martin Robinson.

.:

* Source/cmake/OptionsGTK.cmake: Turn the macro
ADD_WHOLE_ARCHIVE_TO_LIBRARIES into a no-op on Darwin systems,
because XCode's linker doesn't have the --whole-archive option.

Source/WebKit2:

* PlatformGTK.cmake: Link with extra libraries on Darwin, since
we don't have the --whole-archive linker option.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (190908 => 190909)

--- trunk/ChangeLog	2015-10-13 00:11:16 UTC (rev 190908)
+++ trunk/ChangeLog	2015-10-13 00:37:48 UTC (rev 190909)
@@ -1,5 +1,16 @@
 2015-10-12  Philip Chimento  
 
+[GTK] OSX linker doesn't understand --whole-archive
+https://bugs.webkit.org/show_bug.cgi?id=144557
+
+Reviewed by Martin Robinson.
+
+* Source/cmake/OptionsGTK.cmake: Turn the macro
+ADD_WHOLE_ARCHIVE_TO_LIBRARIES into a no-op on Darwin systems,
+because XCode's linker doesn't have the --whole-archive option.
+
+2015-10-12  Philip Chimento  
+
 [GTK] Use --version-script only on Linux
 https://bugs.webkit.org/show_bug.cgi?id=144555
 


Modified: trunk/Source/WebKit2/ChangeLog (190908 => 190909)

--- trunk/Source/WebKit2/ChangeLog	2015-10-13 00:11:16 UTC (rev 190908)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-13 00:37:48 UTC (rev 190909)
@@ -1,3 +1,13 @@
+2015-10-12  Philip Chimento  
+
+[GTK] OSX linker doesn't understand --whole-archive
+https://bugs.webkit.org/show_bug.cgi?id=144557
+
+Reviewed by Martin Robinson.
+
+* PlatformGTK.cmake: Link with extra libraries on Darwin, since
+we don't have the --whole-archive linker option.
+
 2015-10-09  Anders Carlsson  
 
 Don't allow plug-ins to override image types for  elements


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (190908 => 190909)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2015-10-13 00:11:16 UTC (rev 190908)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2015-10-13 00:37:48 UTC (rev 190909)
@@ -923,11 +923,18 @@
 ${WEBKIT2_DIR}/UIProcess/API/gtk/*.cpp
 )
 
+# Manually add some libraries on OSX because we don't have the --whole-archive flag
+if (CMAKE_SYSTEM_NAME MATCHES "Darwin")
+set(INTROSPECTION_ADDITIONAL_LIBRARIES --library=c++)
+set(INTROSPECTION_ADDITIONAL_LDFLAGS -lGObjectDOMBindings)
+endif ()
+
 add_custom_command(
 OUTPUT ${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
 DEPENDS ${CMAKE_BINARY_DIR}/_javascript_Core-${WEBKITGTK_API_VERSION}.gir
 DEPENDS ${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
-COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=
+COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations
+LDFLAGS="${INTROSPECTION_ADDITIONAL_LDFLAGS}"
 LD_LIBRARY_PATH="${INTROSPECTION_ADDITIONAL_LIBRARY_PATH}"
 ${INTROSPECTION_SCANNER}
 --quiet
@@ -942,6 +949,7 @@
 --include-uninstalled=${CMAKE_BINARY_DIR}/_javascript_Core-${WEBKITGTK_API_VERSION}.gir
 --library=webkit2gtk-${WEBKITGTK_API_VERSION}
 --library=_javascript_coregtk-${WEBKITGTK_API_VERSION}
+${INTROSPECTION_ADDITIONAL_LIBRARIES}
 -L${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
 ${INTROSPECTION_ADDITIONAL_LINKER_FLAGS}
 --no-libtool


Modified: trunk/Source/cmake/OptionsGTK.cmake (190908 => 190909)

--- trunk/Source/cmake/OptionsGTK.cmake	2015-10-13 00:11:16 UTC (rev 190908)
+++ trunk/Source/cmake/OptionsGTK.cmake	2015-10-13 00:37:48 UTC (rev 190909)
@@ -471,12 +471,15 @@
 # CMake does not automatically add --whole-archive when building shared objects from
 # a list of convenience libraries. This can lead to missing symbols in the final output.
 # We add --whole-archive to all libraries manually to prevent the linker from trimming
-# symbols that we actually need later.
+# symbols that we actually need later. (--whole-archive isn't an option on XCode's
+# linker, though.)
 macro(ADD_WHOLE_ARCHIVE_TO_LIBRARIES _list_name)
-foreach (library IN LISTS ${_list_name})
-  list(APPEND ${_list_name}_TMP -Wl,--whole-archive ${library} -Wl,--no-whole-archive)
-endforeach ()
-set(${_list_name} "${${_list_name}_TMP}")
+if (NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
+foreach (library IN LISTS ${_list_name})
+  list(APPEND ${_list_name}_TMP -Wl,--whole-archive ${library} -Wl,--no-whole-archive)
+endforeach ()
+set(${_list_name} "${${_list_name}_TMP}")
+endif ()
 

[webkit-changes] [190898] trunk/Websites/perf.webkit.org

[rniwa]

Title: [190898] trunk/Websites/perf.webkit.org








Revision 190898
Author rn...@webkit.org
Date 2015-10-12 15:43:49 -0700 (Mon, 12 Oct 2015)


Log Message
Build fix after r190817.  Now that pull-os-versions store fake timestamps, we need to bypass timestamp
checks for OS versions when bots try to report new results. Otherwise, we fail to process the reports
with a MismatchingCommitTime error.

* public/include/report-processor.php:
(ReportProcessor::resolve_build_id):

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/include/report-processor.php




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (190897 => 190898)

--- trunk/Websites/perf.webkit.org/ChangeLog	2015-10-12 22:42:21 UTC (rev 190897)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2015-10-12 22:43:49 UTC (rev 190898)
@@ -1,3 +1,12 @@
+2015-10-11  Ryosuke Niwa  
+
+Build fix after r190817.  Now that pull-os-versions store fake timestamps, we need to bypass timestamp
+checks for OS versions when bots try to report new results. Otherwise, we fail to process the reports
+with a MismatchingCommitTime error.
+
+* public/include/report-processor.php:
+(ReportProcessor::resolve_build_id):
+
 2015-10-08  Ryosuke Niwa  
 
 Perf dashboard erroneously shows an old OS build in A/B testing range


Modified: trunk/Websites/perf.webkit.org/public/include/report-processor.php (190897 => 190898)

--- trunk/Websites/perf.webkit.org/public/include/report-processor.php	2015-10-12 22:42:21 UTC (rev 190897)
+++ trunk/Websites/perf.webkit.org/public/include/report-processor.php	2015-10-12 22:43:49 UTC (rev 190898)
@@ -152,7 +152,7 @@
 array('repository' => $repository_id, 'revision' => $revision_data['revision']), $commit_data, '*');
 if (!$commit_row)
 $this->exit_with_error('FailedToRecordCommit', $commit_data);
-if (abs($commit_row['commit_time'] - $commit_data['time']) > 1.0)
+if ($commit_data['time'] && abs($commit_row['commit_time'] - $commit_data['time']) > 1.0)
 $this->exit_with_error('MismatchingCommitTime', array('existing' => $commit_row, 'new' => $commit_data));
 
 if (!$this->db->select_or_insert_row('build_commits', null,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190914] trunk/Source/WebCore

[simon . fraser]

Title: [190914] trunk/Source/WebCore








Revision 190914
Author simon.fra...@apple.com
Date 2015-10-12 18:39:30 -0700 (Mon, 12 Oct 2015)


Log Message
Speculative Cairo build fixes after r190910.

* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::drawPattern):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (190913 => 190914)

--- trunk/Source/WebCore/ChangeLog	2015-10-13 01:18:03 UTC (rev 190913)
+++ trunk/Source/WebCore/ChangeLog	2015-10-13 01:39:30 UTC (rev 190914)
@@ -1,5 +1,14 @@
 2015-10-12  Simon Fraser  
 
+Speculative Cairo build fixes after r190910.
+
+* platform/graphics/cairo/ImageBufferCairo.cpp:
+(WebCore::ImageBuffer::drawPattern):
+* platform/graphics/cairo/ImageCairo.cpp:
+(WebCore::Image::drawPattern):
+
+2015-10-12  Simon Fraser  
+
 Fix iOS and Efl builds.
 
 * platform/graphics/NamedImageGeneratedImage.cpp:


Modified: trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp (190913 => 190914)

--- trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp	2015-10-13 01:18:03 UTC (rev 190913)
+++ trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp	2015-10-13 01:39:30 UTC (rev 190914)
@@ -174,10 +174,10 @@
 }
 
 void ImageBuffer::drawPattern(GraphicsContext& context, const FloatRect& srcRect, const AffineTransform& patternTransform,
-const FloatPoint& phase, ColorSpace styleColorSpace, CompositeOperator op, const FloatRect& destRect, BlendMode)
+const FloatPoint& phase, const FloatSize& spacing, ColorSpace styleColorSpace, CompositeOperator op, const FloatRect& destRect, BlendMode)
 {
 if (RefPtr image = copyImage(DontCopyBackingStore))
-image->drawPattern(context, srcRect, patternTransform, phase, styleColorSpace, op, destRect);
+image->drawPattern(context, srcRect, patternTransform, phase, spacing, styleColorSpace, op, destRect);
 }
 
 void ImageBuffer::platformTransformColorSpace(const Vector& lookUpTable)


Modified: trunk/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp (190913 => 190914)

--- trunk/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp	2015-10-13 01:18:03 UTC (rev 190913)
+++ trunk/Source/WebCore/platform/graphics/cairo/ImageCairo.cpp	2015-10-13 01:39:30 UTC (rev 190914)
@@ -42,7 +42,7 @@
 namespace WebCore {
 
 void Image::drawPattern(GraphicsContext& context, const FloatRect& tileRect, const AffineTransform& patternTransform,
-const FloatPoint& phase, ColorSpace, CompositeOperator op, const FloatRect& destRect, BlendMode)
+const FloatPoint& phase, const FloatSize&, ColorSpace, CompositeOperator op, const FloatRect& destRect, BlendMode)
 {
 RefPtr surface = nativeImageForCurrentFrame();
 if (!surface) // If it's too early we won't have an image yet.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190905] trunk/Source/JavaScriptCore

[commit-queue]

Title: [190905] trunk/Source/_javascript_Core








Revision 190905
Author commit-qu...@webkit.org
Date 2015-10-12 16:37:51 -0700 (Mon, 12 Oct 2015)


Log Message
Web Inspector: Rebaseline Inspector generator tests and make better use of RWIProtocol constant
https://bugs.webkit.org/show_bug.cgi?id=150044

Patch by Joseph Pecoraro  on 2015-10-12
Reviewed by Brian Burg.

* inspector/scripts/codegen/generate_objc_configuration_header.py:
(ObjCConfigurationHeaderGenerator.generate_output):
(ObjCConfigurationHeaderGenerator._generate_configuration_interface_for_domains):
* inspector/scripts/codegen/generate_objc_configuration_implementation.py:
(ObjCBackendDispatcherImplementationGenerator._generate_configuration_implementation_for_domains):
* inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator.generate_output):
* inspector/scripts/codegen/generate_objc_internal_header.py:
(ObjCInternalHeaderGenerator.generate_output):
* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
* inspector/scripts/tests/expected/enum-values.json-result:
* inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
* inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
* inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
* inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
* inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
* inspector/scripts/tests/expected/type-declaration-array-type.json-result:
* inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
* inspector/scripts/tests/expected/type-declaration-object-type.json-result:
* inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_configuration_header.py
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_configuration_implementation.py
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_header.py
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_objc_internal_header.py
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/enum-values.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/events-with-optional-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/same-type-id-different-domain.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-array-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-enum-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190904 => 190905)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 23:26:36 UTC (rev 190904)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 23:37:51 UTC (rev 190905)
@@ -1,3 +1,33 @@
+2015-10-12  Joseph Pecoraro  
+
+Web Inspector: Rebaseline Inspector generator tests and make better use of RWIProtocol constant
+https://bugs.webkit.org/show_bug.cgi?id=150044
+
+Reviewed by Brian Burg.
+
+* inspector/scripts/codegen/generate_objc_configuration_header.py:
+(ObjCConfigurationHeaderGenerator.generate_output):
+(ObjCConfigurationHeaderGenerator._generate_configuration_interface_for_domains):
+* inspector/scripts/codegen/generate_objc_configuration_implementation.py:
+(ObjCBackendDispatcherImplementationGenerator._generate_configuration_implementation_for_domains):
+* inspector/scripts/codegen/generate_objc_header.py:
+(ObjCHeaderGenerator.generate_output):
+* inspector/scripts/codegen/generate_objc_internal_header.py:
+(ObjCInternalHeaderGenerator.generate_output):
+* 

[webkit-changes] [190907] trunk/PerformanceTests

[jonlee]

Title: [190907] trunk/PerformanceTests








Revision 190907
Author jon...@apple.com
Date 2015-10-12 17:03:31 -0700 (Mon, 12 Oct 2015)


Log Message
Store test-interval in localStorage
https://bugs.webkit.org/show_bug.cgi?id=150055


Reviewed by Dean Jackson.

* Animometer/runner/resources/animometer.js:
(populateSettings): Keep track of the specified test interval in localStorage
to make it easy to repeat a test suite.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/animometer.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.js (190906 => 190907)

--- trunk/PerformanceTests/Animometer/runner/resources/animometer.js	2015-10-12 23:39:48 UTC (rev 190906)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.js	2015-10-13 00:03:31 UTC (rev 190907)
@@ -67,6 +67,7 @@
 enabledSuites.push(checkbox.suite);
 }
 localStorage.setItem(checkbox.suite.name, +checkbox.checked);
+localStorage.setItem("test-interval", document.getElementById("test-interval").value);
 }
 
 var enabledSuites = Suites.filter(function (suite, index) { return !suite.disabled && checkboxes[index].checked; });
@@ -133,5 +134,10 @@
 suiteDiv.appendChild(document.createElement("br"));
 suitesDiv.appendChild(suiteDiv);
 });
+
+var interval = localStorage.getItem("test-interval");
+if (interval) {
+document.getElementById("test-interval").value = interval;
+}
 }
 document.addEventListener("DOMContentLoaded", populateSettings);
\ No newline at end of file


Modified: trunk/PerformanceTests/ChangeLog (190906 => 190907)

--- trunk/PerformanceTests/ChangeLog	2015-10-12 23:39:48 UTC (rev 190906)
+++ trunk/PerformanceTests/ChangeLog	2015-10-13 00:03:31 UTC (rev 190907)
@@ -1,5 +1,17 @@
 2015-10-12  Jon Lee  
 
+Store test-interval in localStorage
+https://bugs.webkit.org/show_bug.cgi?id=150055
+
+
+Reviewed by Dean Jackson.
+
+* Animometer/runner/resources/animometer.js:
+(populateSettings): Keep track of the specified test interval in localStorage
+to make it easy to repeat a test suite.
+
+2015-10-12  Jon Lee  
+
 Remove "../tests/" from the URLs of all tests
 https://bugs.webkit.org/show_bug.cgi?id=150054
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190889] trunk/Source/JavaScriptCore

[sbarati]

Title: [190889] trunk/Source/_javascript_Core








Revision 190889
Author sbar...@apple.com
Date 2015-10-12 14:31:28 -0700 (Mon, 12 Oct 2015)


Log Message
Update JSC features.json
https://bugs.webkit.org/show_bug.cgi?id=150043

Reviewed by Mark Lam.

There were a lot of things implemented that weren't in
the list. We should be better about updating the list
as we land patches for new ES6 features.

* features.json:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/features.json




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190888 => 190889)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 21:29:21 UTC (rev 190888)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 21:31:28 UTC (rev 190889)
@@ -1,3 +1,16 @@
+2015-10-12  Saam barati  
+
+Update JSC features.json
+https://bugs.webkit.org/show_bug.cgi?id=150043
+
+Reviewed by Mark Lam.
+
+There were a lot of things implemented that weren't in
+the list. We should be better about updating the list
+as we land patches for new ES6 features.
+
+* features.json:
+
 2015-10-12  Joseph Pecoraro  
 
 Cleanup Heap.h and some related headers


Modified: trunk/Source/_javascript_Core/features.json (190888 => 190889)

--- trunk/Source/_javascript_Core/features.json	2015-10-12 21:29:21 UTC (rev 190888)
+++ trunk/Source/_javascript_Core/features.json	2015-10-12 21:31:28 UTC (rev 190889)
@@ -3,7 +3,12 @@
 {
 "name": "ES6",
 "url": "http://wiki.ecmascript.org/doku.php?id=harmony:specification_drafts",
-"keywords": ["es6", "es2015", "ecmascript"]
+"keywords": ["es6", "es2015", "ecmascript"],
+"contact": {
+"name": "Saam Barati",
+"email": "sbar...@apple.com",
+"twitter": "@saambarati"
+}
 },
 {
 "name": "ES7",
@@ -13,7 +18,7 @@
 {
 "name": "Internationalization API",
 "status": {
-"status": "Work in progress"
+"status": "In Development"
 },
 "url": "http://ecma-international.org/publications/standards/Ecma-402.htm",
 "documentation-url": "https://developer.mozilla.org/en-US/docs/Web/_javascript_/Reference/Global_Objects/Intl",
@@ -32,7 +37,7 @@
 {
 "name": "ASM.js",
 "status": {
-"status": "Continuously improving",
+"status": "In Development",
 "enabled-by-default": true
 },
 "url": "http://asmjs.org",
@@ -66,19 +71,74 @@
 "specification": "ES7"
 },
 {
+"name": "Arrow Functions",
+"status": {
+"status": "In Development",
+"enabled-by-default": true
+},
+"url": "http://www.ecma-international.org/ecma-262/6.0/index.html#sec-arrow-function-definitions",
+"documentation-url": "https://developer.mozilla.org/en-US/docs/Web/_javascript_/Reference/Functions/Arrow_functions",
+"description": "Arrow functions are a new type of function _expression_ in ES6 that lexically binds this, new.target, arguments, and super.",
+"specification": "ES6"
+},
+{
+"name": "Block Scoping",
+"status": {
+"status": "In Development",
+"enabled-by-default": true
+},
+"url": "http://www.ecma-international.org/ecma-262/6.0/#sec-let-and-const-declarations",
+"documentation-url": "http://www.2ality.com/2015/02/es6-scoping.html",
+"description": "Block Scoping let/const/class variables are a new way of declaring variables that are local to the block they're defined in. They have clearer scoping semantics than var variables.",
+"specification": "ES6"
+},
+{
 "name": "Classes",
 "status": {
+"status": "In Development",
+"enabled-by-default": true
+},
+"url": "http://www.ecma-international.org/ecma-262/6.0/#sec-class-definitions",
+"documentation-url": "https://developer.mozilla.org/en-US/docs/Web/_javascript_/Reference/Classes",
+"description": "Classes are a way to write object oriented code in _javascript_ with standard syntax and semantics.",
+"specification": "ES6"
+},
+{
+"name": "Default Parameter Values",
+"status": {
 "status": "Done",
 "enabled-by-default": true
 },
-"url": "https://people.mozilla.org/~jorendorff/es6-draft.html#sec-class-definitions",
-"documentation-url": "https://developer.mozilla.org/en-US/docs/Web/_javascript_/Reference/Classes",
-"webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=142774",
+"url": "http://www.ecma-international.org/ecma-262/6.0/#sec-function-definitions",
+"documentation-url": "https://developer.mozilla.org/en-US/docs/Web/_javascript_/Reference/Functions/Default_parameters",
+

[webkit-changes] [190892] trunk/LayoutTests

[jhoneycutt]

Title: [190892] trunk/LayoutTests








Revision 190892
Author jhoneyc...@apple.com
Date 2015-10-12 15:15:49 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, more Mac test gardening after r190629.

* platform/mac-wk1/TestExpectations:
Add a new expected time out. Group expected time outs for imported
Blink tests using requestAnimationFrame.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (190891 => 190892)

--- trunk/LayoutTests/ChangeLog	2015-10-12 22:08:27 UTC (rev 190891)
+++ trunk/LayoutTests/ChangeLog	2015-10-12 22:15:49 UTC (rev 190892)
@@ -1,3 +1,11 @@
+2015-10-12  Jon Honeycutt  
+
+Unreviewed, more Mac test gardening after r190629.
+
+* platform/mac-wk1/TestExpectations:
+Add a new expected time out. Group expected time outs for imported
+Blink tests using requestAnimationFrame.
+
 2015-10-12  Myles C. Maxfield  
 
 REGRESSION(r182192): Ligatures do not interact correctly with SHY in some fonts


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (190891 => 190892)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-12 22:08:27 UTC (rev 190891)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-10-12 22:15:49 UTC (rev 190892)
@@ -147,18 +147,20 @@
 fast/text/international/system-language [ Pass Failure ImageOnlyFailure ]
 
 # Imported Blink tests which have not been investigated.
+imported/blink/fast/canvas/bug382588.html [ Pass Timeout ImageOnlyFailure ]
+[ Debug ] imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]
+
+# Blink tests that time out waiting on requestAnimationFrame callbacks. http://webkit.org/b/150050
 imported/blink/animations/background-shorthand-crash.html [ Pass Timeout ]
 imported/blink/compositing/squashing/invalidate-on-grouped-mapping-reorder.html [ Pass Timeout ]
 imported/blink/css3/calc/transition-asan-crash.html [ Pass Timeout ]
-imported/blink/fast/canvas/bug382588.html [ Pass Timeout ImageOnlyFailure ]
+imported/blink/fast/images/image-hover-display-alt.html [ Pass Timeout ]
 imported/blink/fast/inline/reparent-inline-box.html [ Pass Timeout ]
 imported/blink/fast/text-autosizing/print-autosizing.html  [ Pass Timeout ]
 imported/blink/paint/theme/search-field-resuts-decoration-crash.html [ Pass Timeout ]
 imported/blink/svg/filters/feColorMatrix-setAttribute-crash1.html [ Pass Timeout ]
 imported/blink/svg/hittest/rect-miterlimit.html [ Pass Timeout ]
-
 [ Release ] imported/blink/compositing/reorder-z-with-style.html [ Pass Timeout ]
 [ Release ] imported/blink/svg/custom/marker-layout-invalidation.html [ Pass Timeout ]
 [ Release ] imported/blink/fast/css/crash-corner-present.html [ Pass Timeout ]
 [ Release ] imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
-[ Debug ] imported/blink/compositing/video/video-controls-layer-creation-squashing.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190906] trunk/Source/WebCore

[akling]

Title: [190906] trunk/Source/WebCore








Revision 190906
Author akl...@apple.com
Date 2015-10-12 16:39:48 -0700 (Mon, 12 Oct 2015)


Log Message
Have TransformState::mappedSecondaryQuad() return an Optional.


Reviewed by Simon Fraser.

Using Optional instead of std::unique_ptr allows us to signal the absence of a
secondary quad without incurring a heap allocation in cases where one is present.

This dodges ~132000 malloc/free pairs on loading thelocal.se

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::computeVisibleAndCoverageRect):
* platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::mappedSecondaryQuad):
* platform/graphics/transforms/TransformState.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/transforms/TransformState.cpp
trunk/Source/WebCore/platform/graphics/transforms/TransformState.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (190905 => 190906)

--- trunk/Source/WebCore/ChangeLog	2015-10-12 23:37:51 UTC (rev 190905)
+++ trunk/Source/WebCore/ChangeLog	2015-10-12 23:39:48 UTC (rev 190906)
@@ -1,3 +1,21 @@
+2015-10-12  Andreas Kling  
+
+Have TransformState::mappedSecondaryQuad() return an Optional.
+
+
+Reviewed by Simon Fraser.
+
+Using Optional instead of std::unique_ptr allows us to signal the absence of a
+secondary quad without incurring a heap allocation in cases where one is present.
+
+This dodges ~132000 malloc/free pairs on loading thelocal.se
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::computeVisibleAndCoverageRect):
+* platform/graphics/transforms/TransformState.cpp:
+(WebCore::TransformState::mappedSecondaryQuad):
+* platform/graphics/transforms/TransformState.h:
+
 2015-10-12  Brady Eidson  
 
 Followup to:


Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (190905 => 190906)

--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2015-10-12 23:37:51 UTC (rev 190905)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2015-10-12 23:39:48 UTC (rev 190906)
@@ -1240,9 +1240,9 @@
 }
 
 FloatRect coverageRect = clipRectForSelf;
-std::unique_ptr quad = state.mappedSecondaryQuad();
+Optional quad = state.mappedSecondaryQuad();
 if (quad && !mapWasClamped && !applyWasClamped)
-coverageRect = quad->boundingBox();
+coverageRect = (*quad).boundingBox();
 
 return VisibleAndCoverageRects(clipRectForSelf, coverageRect);
 }


Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformState.cpp (190905 => 190906)

--- trunk/Source/WebCore/platform/graphics/transforms/TransformState.cpp	2015-10-12 23:37:51 UTC (rev 190905)
+++ trunk/Source/WebCore/platform/graphics/transforms/TransformState.cpp	2015-10-12 23:39:48 UTC (rev 190906)
@@ -183,17 +183,17 @@
 return quad;
 }
 
-std::unique_ptr TransformState::mappedSecondaryQuad(bool* wasClamped) const
+Optional TransformState::mappedSecondaryQuad(bool* wasClamped) const
 {
 if (wasClamped)
 *wasClamped = false;
 
 if (!m_lastPlanarSecondaryQuad)
-return nullptr;
+return Optional();
 
 FloatQuad quad = *m_lastPlanarSecondaryQuad;
 mapQuad(quad, m_direction, wasClamped);
-return std::make_unique(quad);
+return quad;
 }
 
 void TransformState::setLastPlanarSecondaryQuad(const FloatQuad* quad)


Modified: trunk/Source/WebCore/platform/graphics/transforms/TransformState.h (190905 => 190906)

--- trunk/Source/WebCore/platform/graphics/transforms/TransformState.h	2015-10-12 23:37:51 UTC (rev 190905)
+++ trunk/Source/WebCore/platform/graphics/transforms/TransformState.h	2015-10-12 23:39:48 UTC (rev 190906)
@@ -32,6 +32,7 @@
 #include "IntSize.h"
 #include "LayoutSize.h"
 #include "TransformationMatrix.h"
+#include 
 
 namespace WebCore {
 
@@ -112,7 +113,7 @@
 // Return the point or quad mapped through the current transform
 FloatPoint mappedPoint(bool* wasClamped = nullptr) const;
 FloatQuad mappedQuad(bool* wasClamped = nullptr) const;
-std::unique_ptr mappedSecondaryQuad(bool* wasClamped = nullptr) const;
+Optional mappedSecondaryQuad(bool* wasClamped = nullptr) const;
 
 private:
 void translateTransform(const LayoutSize&);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190921] trunk/PerformanceTests

[jonlee]

Title: [190921] trunk/PerformanceTests








Revision 190921
Author jon...@apple.com
Date 2015-10-12 19:12:11 -0700 (Mon, 12 Oct 2015)


Log Message
Add canvas line dash test
https://bugs.webkit.org/show_bug.cgi?id=150078


Reviewed by Dean Jackson.

* Animometer/runner/resources/tests.js: Add line dash test.
* Animometer/tests/simple/resources/simple-canvas-paths.js:
(CanvasLineDashStage): Create a new stage with a default dash pattern and stroke style.
Maintain a step which will animate the dash.
(CanvasLineDashStage.prototype.animate): Render the line path with the dash. Increment
the dash offset to animate.
(CanvasPathBenchmark.prototype.createStage): Add the test.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/tests.js (190920 => 190921)

--- trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 02:11:44 UTC (rev 190920)
+++ trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 02:12:11 UTC (rev 190921)
@@ -163,6 +163,10 @@
 name: "Canvas line path, miter join"
 },
 {
+url: "simple/simple-canvas-paths.html?pathType=linePath=1",
+name: "Canvas line path with dash pattern"
+},
+{
 url: "simple/simple-canvas-paths.html?pathType=quadratic",
 name: "Canvas quadratic segments"
 },


Modified: trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js (190920 => 190921)

--- trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:11:44 UTC (rev 190920)
+++ trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:12:11 UTC (rev 190921)
@@ -221,6 +221,27 @@
 CanvasLinePathStage.prototype = Object.create(SimpleCanvasPathStrokeStage.prototype);
 CanvasLinePathStage.prototype.constructor = CanvasLinePathStage;
 
+function CanvasLineDashStage(element, options)
+{
+SimpleCanvasStage.call(this, element, options, CanvasLinePoint);
+this.context.setLineDash([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
+this.context.lineWidth = 1;
+this.context.strokeStyle = "#000";
+this._step = 0;
+}
+CanvasLineDashStage.prototype = Object.create(SimpleCanvasStage.prototype);
+CanvasLineDashStage.prototype.constructor = CanvasLineDashStage;
+CanvasLineDashStage.prototype.animate = function() {
+var context = this.context;
+context.lineDashOffset = this._step++;
+context.beginPath();
+context.moveTo(0,0);
+this._objects.forEach(function(object) {
+object.draw(context);
+});
+context.stroke();
+};
+
 // === BENCHMARK ===
 
 function CanvasPathBenchmark(suite, test, options, recordTable, progressBar) {
@@ -236,6 +257,8 @@
 case "linePath": {
 if ("lineJoin" in this._options)
 return new CanvasLinePathStage(element, this._options);
+if ("lineDash" in this._options)
+return new CanvasLineDashStage(element, this._options);
 break;
 }
 case "quadratic":


Modified: trunk/PerformanceTests/ChangeLog (190920 => 190921)

--- trunk/PerformanceTests/ChangeLog	2015-10-13 02:11:44 UTC (rev 190920)
+++ trunk/PerformanceTests/ChangeLog	2015-10-13 02:12:11 UTC (rev 190921)
@@ -1,5 +1,21 @@
 2015-10-12  Jon Lee  
 
+Add canvas line dash test
+https://bugs.webkit.org/show_bug.cgi?id=150078
+
+
+Reviewed by Dean Jackson.
+
+* Animometer/runner/resources/tests.js: Add line dash test.
+* Animometer/tests/simple/resources/simple-canvas-paths.js:
+(CanvasLineDashStage): Create a new stage with a default dash pattern and stroke style.
+Maintain a step which will animate the dash.
+(CanvasLineDashStage.prototype.animate): Render the line path with the dash. Increment
+the dash offset to animate.
+(CanvasPathBenchmark.prototype.createStage): Add the test.
+
+2015-10-12  Jon Lee  
+
 Add canvas line path tests
 https://bugs.webkit.org/show_bug.cgi?id=150076
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190920] trunk/PerformanceTests

[jonlee]

Title: [190920] trunk/PerformanceTests








Revision 190920
Author jon...@apple.com
Date 2015-10-12 19:11:44 -0700 (Mon, 12 Oct 2015)


Log Message
Add canvas line path tests
https://bugs.webkit.org/show_bug.cgi?id=150076


Reviewed by Dean Jackson.

* Animometer/runner/resources/tests.js: Add new line path tests, with different
line joins.
* Animometer/tests/simple/resources/simple-canvas-paths.js:
(CanvasLinePathStage): The stage is the same as the SimpleCanvasPathStrokeStage
but sets the lineJoin on the context.
(CanvasPathBenchmark.prototype.createStage): Add the tests.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/tests.js (190919 => 190920)

--- trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 02:11:06 UTC (rev 190919)
+++ trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 02:11:44 UTC (rev 190920)
@@ -151,6 +151,18 @@
 name: "Canvas line segments, square caps"
 },
 {
+url: "simple/simple-canvas-paths.html?pathType=linePath=bevel",
+name: "Canvas line path, bevel join"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=linePath=round",
+name: "Canvas line path, round join"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=linePath=miter",
+name: "Canvas line path, miter join"
+},
+{
 url: "simple/simple-canvas-paths.html?pathType=quadratic",
 name: "Canvas quadratic segments"
 },


Modified: trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js (190919 => 190920)

--- trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:11:06 UTC (rev 190919)
+++ trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:11:44 UTC (rev 190920)
@@ -213,6 +213,14 @@
 CanvasLineSegmentStage.prototype = Object.create(SimpleCanvasStage.prototype);
 CanvasLineSegmentStage.prototype.constructor = CanvasLineSegmentStage;
 
+function CanvasLinePathStage(element, options)
+{
+SimpleCanvasPathStrokeStage.call(this, element, options, CanvasLinePoint);
+this.context.lineJoin = options["lineJoin"] || "bevel";
+}
+CanvasLinePathStage.prototype = Object.create(SimpleCanvasPathStrokeStage.prototype);
+CanvasLinePathStage.prototype.constructor = CanvasLinePathStage;
+
 // === BENCHMARK ===
 
 function CanvasPathBenchmark(suite, test, options, recordTable, progressBar) {
@@ -225,6 +233,11 @@
 switch (this._options["pathType"]) {
 case "line":
 return new CanvasLineSegmentStage(element, this._options);
+case "linePath": {
+if ("lineJoin" in this._options)
+return new CanvasLinePathStage(element, this._options);
+break;
+}
 case "quadratic":
 return new SimpleCanvasStage(element, this._options, CanvasQuadraticSegment);
 case "quadraticPath":


Modified: trunk/PerformanceTests/ChangeLog (190919 => 190920)

--- trunk/PerformanceTests/ChangeLog	2015-10-13 02:11:06 UTC (rev 190919)
+++ trunk/PerformanceTests/ChangeLog	2015-10-13 02:11:44 UTC (rev 190920)
@@ -1,5 +1,20 @@
 2015-10-12  Jon Lee  
 
+Add canvas line path tests
+https://bugs.webkit.org/show_bug.cgi?id=150076
+
+
+Reviewed by Dean Jackson.
+
+* Animometer/runner/resources/tests.js: Add new line path tests, with different
+line joins.
+* Animometer/tests/simple/resources/simple-canvas-paths.js:
+(CanvasLinePathStage): The stage is the same as the SimpleCanvasPathStrokeStage
+but sets the lineJoin on the context.
+(CanvasPathBenchmark.prototype.createStage): Add the tests.
+
+2015-10-12  Jon Lee  
+
 Add missing paint objects for arc and arcTo fills
 https://bugs.webkit.org/show_bug.cgi?id=150075
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190888] trunk/Source/JavaScriptCore

[joepeck]

Title: [190888] trunk/Source/_javascript_Core








Revision 190888
Author joep...@webkit.org
Date 2015-10-12 14:29:21 -0700 (Mon, 12 Oct 2015)


Log Message
Cleanup Heap.h and some related headers
https://bugs.webkit.org/show_bug.cgi?id=149981

Reviewed by Geoffrey Garen.

* heap/Heap.h:
- Some functions did not need export.
- threadDupStrings never had an implementation.

* heap/ConservativeRoots.cpp:
* heap/ConservativeRoots.h:
* heap/Heap.cpp:
* heap/ListableHandler.h:
* heap/WeakReferenceHarvester.h:
* jit/Repatch.cpp:
* runtime/JSONObject.h:
* runtime/VM.h:
- Stale forward declarations / includes.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/ConservativeRoots.cpp
trunk/Source/_javascript_Core/heap/ConservativeRoots.h
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/heap/ListableHandler.h
trunk/Source/_javascript_Core/heap/WeakReferenceHarvester.h
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/runtime/JSONObject.h
trunk/Source/_javascript_Core/runtime/VM.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190887 => 190888)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 21:22:01 UTC (rev 190887)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 21:29:21 UTC (rev 190888)
@@ -1,3 +1,24 @@
+2015-10-12  Joseph Pecoraro  
+
+Cleanup Heap.h and some related headers
+https://bugs.webkit.org/show_bug.cgi?id=149981
+
+Reviewed by Geoffrey Garen.
+
+* heap/Heap.h:
+- Some functions did not need export.
+- threadDupStrings never had an implementation.
+
+* heap/ConservativeRoots.cpp:
+* heap/ConservativeRoots.h:
+* heap/Heap.cpp:
+* heap/ListableHandler.h:
+* heap/WeakReferenceHarvester.h:
+* jit/Repatch.cpp:
+* runtime/JSONObject.h:
+* runtime/VM.h:
+- Stale forward declarations / includes.
+
 2015-10-12  Saam barati  
 
 Each *ById inline cache in the FTL must have its own CallSiteIndex


Modified: trunk/Source/_javascript_Core/heap/ConservativeRoots.cpp (190887 => 190888)

--- trunk/Source/_javascript_Core/heap/ConservativeRoots.cpp	2015-10-12 21:22:01 UTC (rev 190887)
+++ trunk/Source/_javascript_Core/heap/ConservativeRoots.cpp	2015-10-12 21:29:21 UTC (rev 190888)
@@ -34,6 +34,7 @@
 #include "JSObject.h"
 #include "JSCInlines.h"
 #include "Structure.h"
+#include 
 
 namespace JSC {
 


Modified: trunk/Source/_javascript_Core/heap/ConservativeRoots.h (190887 => 190888)

--- trunk/Source/_javascript_Core/heap/ConservativeRoots.h	2015-10-12 21:22:01 UTC (rev 190887)
+++ trunk/Source/_javascript_Core/heap/ConservativeRoots.h	2015-10-12 21:29:21 UTC (rev 190888)
@@ -27,13 +27,10 @@
 #define ConservativeRoots_h
 
 #include "Heap.h"
-#include 
-#include 
 
 namespace JSC {
 
 class CodeBlockSet;
-class Heap;
 class JITStubRoutineSet;
 class JSCell;
 


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (190887 => 190888)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2015-10-12 21:22:01 UTC (rev 190887)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	2015-10-12 21:29:21 UTC (rev 190888)
@@ -38,22 +38,20 @@
 #include "HeapVerifier.h"
 #include "IncrementalSweeper.h"
 #include "Interpreter.h"
+#include "JSCInlines.h"
 #include "JSGlobalObject.h"
 #include "JSLock.h"
-#include "JSONObject.h"
-#include "JSCInlines.h"
 #include "JSVirtualMachineInternal.h"
-#include "RegExpCache.h"
 #include "Tracing.h"
 #include "TypeProfilerLog.h"
 #include "UnlinkedCodeBlock.h"
 #include "VM.h"
 #include "WeakSetInlines.h"
 #include 
-#include 
 #include 
 #include 
 #include 
+#include 
 
 using namespace std;
 using namespace JSC;


Modified: trunk/Source/_javascript_Core/heap/Heap.h (190887 => 190888)

--- trunk/Source/_javascript_Core/heap/Heap.h	2015-10-12 21:22:01 UTC (rev 190887)
+++ trunk/Source/_javascript_Core/heap/Heap.h	2015-10-12 21:29:21 UTC (rev 190888)
@@ -113,7 +113,7 @@
 
 Heap(VM*, HeapType);
 ~Heap();
-JS_EXPORT_PRIVATE void lastChanceToFinalize();
+void lastChanceToFinalize();
 void releaseDelayedReleasedObjects();
 
 VM* vm() const { return m_vm; }
@@ -207,7 +207,7 @@
 size_t sizeBeforeLastFullCollection() const { return m_sizeBeforeLastFullCollect; }
 size_t sizeAfterLastFullCollection() const { return m_sizeAfterLastFullCollect; }
 
-JS_EXPORT_PRIVATE void deleteAllCodeBlocks();
+void deleteAllCodeBlocks();
 void deleteAllUnlinkedCodeBlocks();
 
 void didAllocate(size_t);
@@ -252,7 +252,6 @@
 friend class CopiedSpace;
 friend class CopyVisitor;
 friend class SlotVisitor;
-friend class SuperRegion;
 friend class IncrementalSweeper;
 friend class HeapStatistics;
 friend class VM;
@@ -340,7 +339,6 @@
 size_t threadVisitCount();
 size_t threadBytesVisited();
 size_t threadBytesCopied();
-

[webkit-changes] [190894] trunk/Source/WebCore

[simon . fraser]

Title: [190894] trunk/Source/WebCore








Revision 190894
Author simon.fra...@apple.com
Date 2015-10-12 15:36:03 -0700 (Mon, 12 Oct 2015)


Log Message
Add a CGContextStateSaver and use it
https://bugs.webkit.org/show_bug.cgi?id=150049

Reviewed by Tim Horton.

Add a stack-based graphics state save/restore class for CGContext,
like the one we have for GraphicsContext, and use it in GraphicsContextCG.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawJoinedLines):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::strokeRect):
* platform/graphics/cg/GraphicsContextCG.h:
(WebCore::CGContextStateSaver::CGContextStateSaver):
(WebCore::CGContextStateSaver::~CGContextStateSaver):
(WebCore::CGContextStateSaver::save):
(WebCore::CGContextStateSaver::restore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (190893 => 190894)

--- trunk/Source/WebCore/ChangeLog	2015-10-12 22:33:03 UTC (rev 190893)
+++ trunk/Source/WebCore/ChangeLog	2015-10-12 22:36:03 UTC (rev 190894)
@@ -1,3 +1,29 @@
+2015-10-12  Simon Fraser  
+
+Add a CGContextStateSaver and use it
+https://bugs.webkit.org/show_bug.cgi?id=150049
+
+Reviewed by Tim Horton.
+
+Add a stack-based graphics state save/restore class for CGContext,
+like the one we have for GraphicsContext, and use it in GraphicsContextCG.
+
+* platform/graphics/cg/GraphicsContextCG.cpp:
+(WebCore::GraphicsContext::drawNativeImage):
+(WebCore::GraphicsContext::drawLine):
+(WebCore::GraphicsContext::drawJoinedLines):
+(WebCore::GraphicsContext::fillPath):
+(WebCore::GraphicsContext::strokePath):
+(WebCore::GraphicsContext::fillRect):
+(WebCore::GraphicsContext::platformFillRoundedRect):
+(WebCore::GraphicsContext::fillRectWithRoundedHole):
+(WebCore::GraphicsContext::strokeRect):
+* platform/graphics/cg/GraphicsContextCG.h:
+(WebCore::CGContextStateSaver::CGContextStateSaver):
+(WebCore::CGContextStateSaver::~CGContextStateSaver):
+(WebCore::CGContextStateSaver::save):
+(WebCore::CGContextStateSaver::restore):
+
 2015-10-12  Zalan Bujtas  
 
 display: table-cell; bug when resizing window


Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (190893 => 190894)

--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2015-10-12 22:33:03 UTC (rev 190893)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2015-10-12 22:36:03 UTC (rev 190894)
@@ -154,7 +154,7 @@
 return;
 
 CGContextRef context = platformContext();
-CGContextSaveGState(context);
+CGContextStateSaver stateSaver(context);
 
 #if PLATFORM(IOS)
 // Anti-aliasing is on by default on the iPhone. Need to turn it off when drawing images.
@@ -241,8 +241,6 @@
 
 // Draw the image.
 CGContextDrawImage(context, adjustedDestRect, image.get());
-
-CGContextRestoreGState(context);
 }
 
 // Draws a filled rectangle with a stroked border.
@@ -292,12 +290,13 @@
 return;
 
 CGContextRef context = platformContext();
+
 StrokeStyle strokeStyle = this->strokeStyle();
 float cornerWidth = 0;
 bool drawsDashedLine = strokeStyle == DottedStroke || strokeStyle == DashedStroke;
 
+CGContextStateSaver stateSaver(context, drawsDashedLine);
 if (drawsDashedLine) {
-CGContextSaveGState(context);
 // Figure out end points to ensure we always paint corners.
 cornerWidth = strokeStyle == DottedStroke ? thickness : std::min(2 * thickness, std::max(thickness, strokeWidth / 3));
 setCGFillColor(context, strokeColor(), strokeColorSpace());
@@ -311,10 +310,8 @@
 strokeWidth -= 2 * cornerWidth;
 float patternWidth = strokeStyle == DottedStroke ? thickness : std::min(3 * thickness, std::max(thickness, strokeWidth / 3));
 // Check if corner drawing sufficiently covers the line.
-if (strokeWidth <= patternWidth + 1) {
-CGContextRestoreGState(context);
+if (strokeWidth <= patternWidth + 1)
 return;
-}
 
 // Pattern starts with full fill and ends with the empty fill.
 // 1. Let's start with the empty phase after the corner.
@@ -362,8 +359,6 @@
 CGContextMoveToPoint(context, p1.x(), p1.y());
 CGContextAddLineToPoint(context, p2.x(), p2.y());
 CGContextStrokePath(context);
-if (drawsDashedLine)
-

[webkit-changes] [190901] trunk/PerformanceTests

[jonlee]

Title: [190901] trunk/PerformanceTests








Revision 190901
Author jon...@apple.com
Date 2015-10-12 16:20:24 -0700 (Mon, 12 Oct 2015)


Log Message
Update graph styles for legibility.
https://bugs.webkit.org/show_bug.cgi?id=150052


Reviewed by Dean Jackson.

* Animometer/runner/resources/animometer.css: Update colors and
stroke thicknesses to make the graphs easier to read.
(.smaple-time): Correct to .sample-time
* Animometer/runner/resources/graph.js:
(graph): Ditto.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/animometer.css
trunk/PerformanceTests/Animometer/runner/resources/graph.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.css (190900 => 190901)

--- trunk/PerformanceTests/Animometer/runner/resources/animometer.css	2015-10-12 23:05:43 UTC (rev 190900)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.css	2015-10-12 23:20:24 UTC (rev 190901)
@@ -186,36 +186,38 @@
 .axis path,
 .axis line {
   fill: none;
-  stroke: rgb(235, 235, 235);
+  stroke: #999;
   shape-rendering: crispEdges;
 }
 
 .left-samples {
   fill: none;
-  stroke: steelblue;
+  stroke: #7ADD49;
   stroke-width: 1.5px;
 }
 
 .right-samples {
 fill: none;
-stroke: red;
+stroke: #FA4925;
 stroke-width: 1.5px;
 }
 
-.smaple-time {
+.sample-time {
 fill: none;
-stroke: green;
-stroke-width: 1.5px;
+stroke: #5493D6;
+stroke-width: 1px;
 }
 
 .left-mean {
 fill: none;
-stroke: yellow;
-stroke-width: 1.5px;
+stroke: #7ADD49;
+stroke-width: 1px;
+opacity: .8;
 }
 
 .right-mean {
 fill: none;
-stroke: magenta;
-stroke-width: 1.5px;
+stroke: #FA4925;
+stroke-width: 1px;
+opacity: .8;
 }


Modified: trunk/PerformanceTests/Animometer/runner/resources/graph.js (190900 => 190901)

--- trunk/PerformanceTests/Animometer/runner/resources/graph.js	2015-10-12 23:05:43 UTC (rev 190900)
+++ trunk/PerformanceTests/Animometer/runner/resources/graph.js	2015-10-12 23:20:24 UTC (rev 190901)
@@ -76,13 +76,13 @@
 // yLeft-axis
 svg.append("g")
 .attr("class", "y axis")
-.attr("fill", "steelblue")
+.attr("fill", "#7ADD49")
 .call(yAxisLeft)
 .append("text")
 .attr("class", "label")
 .attr("transform", "rotate(-90)")
 .attr("y", 6)
-.attr("fill", "steelblue")
+.attr("fill", "#7ADD49")
 .attr("dy", ".71em")
 .style("text-anchor", "end")
 .text(axes[0]);
@@ -90,14 +90,14 @@
 // yRight-axis
 svg.append("g")
 .attr("class", "y axis")
-.attr("fill", "red")
+.attr("fill", "#FA4925")
 .attr("transform", "translate(" + size.width + ", 0)")
 .call(yAxisRight)
 .append("text")
 .attr("class", "label")
 .attr("transform", "rotate(-90)")
 .attr("y", 6)
-.attr("fill", "red")
+.attr("fill", "#FA4925")
 .attr("dy", ".71em")
 .style("text-anchor", "end")
 .text(axes[1]);
@@ -124,7 +124,7 @@
 .attr("x2", x(samplingTimeOffset))
 .attr("y1", yLeft(0))
 .attr("y2", yLeft(yAxisLeft.scale().domain()[1]))
-.attr("class", "smaple-time");
+.attr("class", "sample-time");
 
 // left-samples
 svg.append("path")


Modified: trunk/PerformanceTests/ChangeLog (190900 => 190901)

--- trunk/PerformanceTests/ChangeLog	2015-10-12 23:05:43 UTC (rev 190900)
+++ trunk/PerformanceTests/ChangeLog	2015-10-12 23:20:24 UTC (rev 190901)
@@ -1,3 +1,17 @@
+2015-10-12  Jon Lee  
+
+Update graph styles for legibility.
+https://bugs.webkit.org/show_bug.cgi?id=150052
+
+
+Reviewed by Dean Jackson.
+
+* Animometer/runner/resources/animometer.css: Update colors and
+stroke thicknesses to make the graphs easier to read.
+(.smaple-time): Correct to .sample-time
+* Animometer/runner/resources/graph.js:
+(graph): Ditto.
+
 2015-10-12  Filip Pizlo  
 
 Unreviewed, revert an unintended commit.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190897] trunk/PerformanceTests

[fpizlo]

Title: [190897] trunk/PerformanceTests








Revision 190897
Author fpi...@apple.com
Date 2015-10-12 15:42:21 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed, revert an unintended commit.

* JetStream/Octane2/crypto.js:
(montRevert):
(montReduce):

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/JetStream/Octane2/crypto.js




Diff

Modified: trunk/PerformanceTests/ChangeLog (190896 => 190897)

--- trunk/PerformanceTests/ChangeLog	2015-10-12 22:41:01 UTC (rev 190896)
+++ trunk/PerformanceTests/ChangeLog	2015-10-12 22:42:21 UTC (rev 190897)
@@ -1,3 +1,11 @@
+2015-10-12  Filip Pizlo  
+
+Unreviewed, revert an unintended commit.
+
+* JetStream/Octane2/crypto.js:
+(montRevert):
+(montReduce):
+
 2015-10-05  Said Abou-Hallawa  
 
 Add a graphics benchmark


Modified: trunk/PerformanceTests/JetStream/Octane2/crypto.js (190896 => 190897)

--- trunk/PerformanceTests/JetStream/Octane2/crypto.js	2015-10-12 22:41:01 UTC (rev 190896)
+++ trunk/PerformanceTests/JetStream/Octane2/crypto.js	2015-10-12 22:42:21 UTC (rev 190897)
@@ -580,18 +580,11 @@
 }
 
 // x = x/R mod m (HAC 14.32)
-//var outerCounter = 0;
-//var innerCounter = 0;
-var globalThingy = 0;
 function montReduce(x) {
   var x_array = x.array;
   while(x.t <= this.mt2)	// pad x so am has enough room later
 x_array[x.t++] = 0;
-  //outerCounter++;
-  globalThingy = 665;
   for(var i = 0; i < this.m.t; ++i) {
-//innerCounter++;
-globalThingy = 666;
 // faster way of calculating u0 = x[i]*mp mod DV
 var j = x_array[i]&0x7fff;
 var u0 = (j*this.mpl+(((j*this.mph+(x_array[i]>>15)*this.mpl))<<15))_DM;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190895] trunk/Source/WebCore

[mmaxfield]

Title: [190895] trunk/Source/WebCore








Revision 190895
Author mmaxfi...@apple.com
Date 2015-10-12 15:40:36 -0700 (Mon, 12 Oct 2015)


Log Message
[Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
https://bugs.webkit.org/show_bug.cgi?id=150051

Reviewed by Simon Fraser.

There are no typesetting features which aren't kerning nor ligatures.

No new tests because there is no behavior difference.

* platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::codePath):
* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::supportsTypesettingFeatures): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
trunk/Source/WebCore/platform/graphics/WidthIterator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (190894 => 190895)

--- trunk/Source/WebCore/ChangeLog	2015-10-12 22:36:03 UTC (rev 190894)
+++ trunk/Source/WebCore/ChangeLog	2015-10-12 22:40:36 UTC (rev 190895)
@@ -1,3 +1,19 @@
+2015-10-12  Myles C. Maxfield  
+
+[Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures()
+https://bugs.webkit.org/show_bug.cgi?id=150051
+
+Reviewed by Simon Fraser.
+
+There are no typesetting features which aren't kerning nor ligatures.
+
+No new tests because there is no behavior difference.
+
+* platform/graphics/FontCascade.cpp:
+(WebCore::FontCascade::codePath):
+* platform/graphics/WidthIterator.h:
+(WebCore::WidthIterator::supportsTypesettingFeatures): Deleted.
+
 2015-10-12  Simon Fraser  
 
 Add a CGContextStateSaver and use it


Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (190894 => 190895)

--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2015-10-12 22:36:03 UTC (rev 190894)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2015-10-12 22:40:36 UTC (rev 190895)
@@ -603,9 +603,11 @@
 // FIXME: This shouldn't be necessary because Font::applyTransforms() should perform all necessary shaping.
 if (m_fontDescription.featureSettings().size() > 0 || !m_fontDescription.variantSettings().isAllNormal())
 return Complex;
-
-if (run.length() > 1 && !WidthIterator::supportsTypesettingFeatures(*this))
+
+#if !PLATFORM(COCOA)
+if (run.length() > 1 && typesettingFeatures())
 return Complex;
+#endif
 
 if (!run.characterScanForCodePath())
 return Simple;


Modified: trunk/Source/WebCore/platform/graphics/WidthIterator.h (190894 => 190895)

--- trunk/Source/WebCore/platform/graphics/WidthIterator.h	2015-10-12 22:36:03 UTC (rev 190894)
+++ trunk/Source/WebCore/platform/graphics/WidthIterator.h	2015-10-12 22:40:36 UTC (rev 190895)
@@ -61,15 +61,6 @@
 Vector& arabicForms() { return m_arabicForms; }
 #endif
 
-static bool supportsTypesettingFeatures(const FontCascade& font)
-{
-#if PLATFORM(COCOA)
-return !(font.typesettingFeatures() & ~(Kerning | Ligatures));
-#else
-return !font.typesettingFeatures();
-#endif
-}
-
 const FontCascade* m_font;
 
 const TextRun& m_run;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190904] trunk/Source/JavaScriptCore

[mmaxfield]

Title: [190904] trunk/Source/_javascript_Core








Revision 190904
Author mmaxfi...@apple.com
Date 2015-10-12 16:26:36 -0700 (Mon, 12 Oct 2015)


Log Message
Unreviewed build fix

* runtime/JSObject.cpp:
(JSC::JSObject::reallocateAndShrinkButterfly):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (190903 => 190904)

--- trunk/Source/_javascript_Core/ChangeLog	2015-10-12 23:25:41 UTC (rev 190903)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-10-12 23:26:36 UTC (rev 190904)
@@ -1,3 +1,10 @@
+2015-10-12  Myles C. Maxfield  
+
+Unreviewed build fix
+
+* runtime/JSObject.cpp:
+(JSC::JSObject::reallocateAndShrinkButterfly):
+
 2015-10-08  Filip Pizlo  
 
 GC should have a Baker barrier for concurrent copying


Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (190903 => 190904)

--- trunk/Source/_javascript_Core/runtime/JSObject.cpp	2015-10-12 23:25:41 UTC (rev 190903)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp	2015-10-12 23:26:36 UTC (rev 190904)
@@ -2494,8 +2494,8 @@
 ASSERT(length < MAX_ARRAY_INDEX);
 ASSERT(length < MAX_STORAGE_VECTOR_LENGTH);
 ASSERT(hasContiguous(indexingType()) || hasInt32(indexingType()) || hasDouble(indexingType()) || hasUndecided(indexingType()));
-ASSERT(m_butterfly->vectorLength() > length);
-ASSERT(!m_butterfly->indexingHeader()->preCapacity(structure()));
+ASSERT(m_butterfly.get(this)->vectorLength() > length);
+ASSERT(!m_butterfly.get(this)->indexingHeader()->preCapacity(structure()));
 
 DeferGC deferGC(vm.heap);
 Butterfly* newButterfly = m_butterfly.get(this)->resizeArray(vm, this, structure(), 0, ArrayStorage::sizeFor(length));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190910] trunk/Source/WebCore

[simon . fraser]

Title: [190910] trunk/Source/WebCore








Revision 190910
Author simon.fra...@apple.com
Date 2015-10-12 17:52:13 -0700 (Mon, 12 Oct 2015)


Log Message
Remove Image::spaceSize() and ImageBuffer::spaceSize()
https://bugs.webkit.org/show_bug.cgi?id=150064

Reviewed by Tim Horton.

Image spacing when tiled should not be a property of the image; but a description
of how it's drawn, like tile size. So remove spacing from Image and ImageBuffer,
and pass it in as an argument.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
* platform/graphics/BitmapImage.h:
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawPattern):
* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/GeneratedImage.h:
* platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::drawPattern):
* platform/graphics/GradientImage.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h:
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/Image.h:
(WebCore::Image::spaceSize): Deleted.
(WebCore::Image::setSpaceSize): Deleted.
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::spaceSize): Deleted.
(WebCore::ImageBuffer::setSpaceSize): Deleted.
* platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::drawPattern):
* platform/graphics/NamedImageGeneratedImage.h:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::drawPattern):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
* svg/graphics/SVGImageForContainer.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp
trunk/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.h
trunk/Source/WebCore/platform/graphics/GeneratedImage.h
trunk/Source/WebCore/platform/graphics/GradientImage.cpp
trunk/Source/WebCore/platform/graphics/GradientImage.h
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/Image.cpp
trunk/Source/WebCore/platform/graphics/Image.h
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebCore/platform/graphics/NamedImageGeneratedImage.cpp
trunk/Source/WebCore/platform/graphics/NamedImageGeneratedImage.h
trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageCG.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/svg/graphics/SVGImage.cpp
trunk/Source/WebCore/svg/graphics/SVGImage.h
trunk/Source/WebCore/svg/graphics/SVGImageForContainer.cpp
trunk/Source/WebCore/svg/graphics/SVGImageForContainer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (190909 => 190910)

--- trunk/Source/WebCore/ChangeLog	2015-10-13 00:37:48 UTC (rev 190909)
+++ trunk/Source/WebCore/ChangeLog	2015-10-13 00:52:13 UTC (rev 190910)
@@ -1,3 +1,52 @@
+2015-10-12  Simon Fraser  
+
+Remove Image::spaceSize() and ImageBuffer::spaceSize()
+https://bugs.webkit.org/show_bug.cgi?id=150064
+
+Reviewed by Tim Horton.
+
+Image spacing when tiled should not be a property of the image; but a description
+of how it's drawn, like tile size. So remove spacing from Image and ImageBuffer,
+and pass it in as an argument.
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::drawPattern):
+* platform/graphics/BitmapImage.h:
+* platform/graphics/CrossfadeGeneratedImage.cpp:
+(WebCore::CrossfadeGeneratedImage::drawPattern):
+* platform/graphics/CrossfadeGeneratedImage.h:
+* platform/graphics/GeneratedImage.h:
+* platform/graphics/GradientImage.cpp:
+(WebCore::GradientImage::drawPattern):
+* platform/graphics/GradientImage.h:
+* platform/graphics/GraphicsContext.cpp:
+(WebCore::GraphicsContext::drawTiledImage):
+* platform/graphics/GraphicsContext.h:
+* platform/graphics/Image.cpp:
+(WebCore::Image::drawTiled):
+* platform/graphics/Image.h:
+(WebCore::Image::spaceSize): Deleted.
+(WebCore::Image::setSpaceSize): Deleted.
+* platform/graphics/ImageBuffer.h:
+(WebCore::ImageBuffer::spaceSize): Deleted.
+(WebCore::ImageBuffer::setSpaceSize): Deleted.
+* platform/graphics/NamedImageGeneratedImage.cpp:
+(WebCore::NamedImageGeneratedImage::drawPattern):
+* 

[webkit-changes] [190912] trunk/PerformanceTests

[jonlee]

Title: [190912] trunk/PerformanceTests








Revision 190912
Author jon...@apple.com
Date 2015-10-12 18:11:45 -0700 (Mon, 12 Oct 2015)


Log Message
Add basic canvas tests
https://bugs.webkit.org/show_bug.cgi?id=150066
rdar://problem/23081143

Reviewed by Dean Jackson.

This adds a new test suite that will cover all of the path-based canvas calls.
The patch will be divided up to cover tests with similar techniques.

The simplest version uses a SimpleCanvasStage.

* Animometer/runner/resources/tests.js: Add tests for quadratic, bezier, arcTo,
arc, and rect segments. Also include arcTo, arc, and rect fills.
* Animometer/tests/resources/stage.js:
(Stage.prototype.randomBool): Added for counterclockwise property for arc segments.
(Stage.prototype.randomInt): Fix how values are rounded, used by randomBool. It should
round instead of flooring everything.
* Animometer/tests/simple/resources/simple-canvas.js: Added. Defines common classes
used by all simple canvas tests. The page reads best bottom to top.
(SimpleCanvasStage): Basic stage. Pass a canvasObject which will be used to create new
objects as needed in tune().
(SimpleCanvasStage.prototype.tune): Modeled on other tests. Adds and removed objects
as specified by the provided |count|.
(SimpleCanvasStage.prototype.animate): Iterate over all the objects and ask them to draw.
There is no "animating" of the objects; they will just paint statically on the canvas.
(SimpleCanvasAnimator): Basic animator clears the canvas prior to painting.
(SimpleCanvasBenchmark): Hard-code the feedback loop parameters instead of including
them in the query parameters to the test URLs.
(SimpleCanvasBenchmark.prototype.createAnimator):
* Animometer/tests/simple/simple-canvas-paths.html: Added.

* Animometer/tests/simple/resources/simple-canvas-paths.js: Added. There is no "animating"
of these objects--they just paint statically on the canvas.
(CanvasQuadraticSegment): Paint a quadratic segment stroke.
(CanvasBezierSegment): Paint a bezier segment stroke.
(CanvasArcToSegment): Paint an arcTo stroke.
(CanvasArcSegment): Paint an arc stroke.
(CanvasRect): Paint a rect.
(CanvasRectFill): Paint a filled rect.

(CanvasPathBenchmark):
(CanvasPathBenchmark.prototype.createStage): Look for the pathType and create the
stage using the right paint object.
(window.benchmarkClient.create):

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/Animometer/tests/resources/stage.js
trunk/PerformanceTests/ChangeLog


Added Paths

trunk/PerformanceTests/Animometer/tests/simple/
trunk/PerformanceTests/Animometer/tests/simple/resources/
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas.js
trunk/PerformanceTests/Animometer/tests/simple/simple-canvas-paths.html




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/tests.js (190911 => 190912)

--- trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 00:55:06 UTC (rev 190911)
+++ trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 01:11:45 UTC (rev 190912)
@@ -136,6 +136,43 @@
 ]
 ));
 
+Suites.push(new Suite("Basic canvas path suite",
+[
+{
+url: "simple/simple-canvas-paths.html?pathType=quadratic",
+name: "Canvas quadratic segments"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=bezier",
+name: "Canvas bezier segments"
+},
+{
+url: "simple/simple-canvas-paths.html?=arcTo",
+name: "Canvas arcTo segments"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=arc",
+name: "Canvas arc segments"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=rect",
+name: "Canvas rects"
+},
+{
+url: "simple/simple-canvas-paths.html?=arcToFill",
+name: "Canvas arcTo segments, fill"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=arcFill",
+name: "Canvas arc segments, fill"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=rectFill",
+name: "Canvas rects, fill"
+}
+]
+));
+
 Suites.push(new Suite("Complex examples",
 [
 {


Modified: trunk/PerformanceTests/Animometer/tests/resources/stage.js (190911 => 190912)

--- trunk/PerformanceTests/Animometer/tests/resources/stage.js	2015-10-13 00:55:06 UTC (rev 190911)
+++ trunk/PerformanceTests/Animometer/tests/resources/stage.js	2015-10-13 01:11:45 UTC (rev 190912)
@@ -55,9 +55,14 @@
 return (Math.random() * (max - min)) + min;
 },
 
+randomBool: function()
+{
+return !!Math.round(this.random(0, 1));
+},
+
 randomInt: function(min, max)
 {
-return Math.floor(this.random(min, max));
+return 

[webkit-changes] [190922] trunk/Tools

[ap]

Title: [190922] trunk/Tools








Revision 190922
Author a...@apple.com
Date 2015-10-12 19:49:33 -0700 (Mon, 12 Oct 2015)


Log Message
Add a Mac debug EWS queue
https://bugs.webkit.org/show_bug.cgi?id=150069

Reviewed by Geoffrey Garen.

* QueueStatusServer/config/queues.py:
* Scripts/webkitpy/common/config/ews.json:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.archive_last_test_results):
(AbstractEarlyWarningSystem.build_style):
(AbstractEarlyWarningSystem.refetch_patch):
(AbstractEarlyWarningSystem.load_ews_classes):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/config/queues.py
trunk/Tools/Scripts/webkitpy/common/config/ews.json
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py




Diff

Modified: trunk/Tools/ChangeLog (190921 => 190922)

--- trunk/Tools/ChangeLog	2015-10-13 02:12:11 UTC (rev 190921)
+++ trunk/Tools/ChangeLog	2015-10-13 02:49:33 UTC (rev 190922)
@@ -1,3 +1,19 @@
+2015-10-12  Alexey Proskuryakov  
+
+Add a Mac debug EWS queue
+https://bugs.webkit.org/show_bug.cgi?id=150069
+
+Reviewed by Geoffrey Garen.
+
+* QueueStatusServer/config/queues.py:
+* Scripts/webkitpy/common/config/ews.json:
+* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+(AbstractEarlyWarningSystem):
+(AbstractEarlyWarningSystem.archive_last_test_results):
+(AbstractEarlyWarningSystem.build_style):
+(AbstractEarlyWarningSystem.refetch_patch):
+(AbstractEarlyWarningSystem.load_ews_classes):
+
 2015-10-12  Mario Sanchez Prada  
 
 [GTK] Update jhbuild's version of harfbuzz


Modified: trunk/Tools/QueueStatusServer/config/queues.py (190921 => 190922)

--- trunk/Tools/QueueStatusServer/config/queues.py	2015-10-13 02:12:11 UTC (rev 190921)
+++ trunk/Tools/QueueStatusServer/config/queues.py	2015-10-13 02:49:33 UTC (rev 190922)
@@ -37,6 +37,7 @@
 "ios-ews",
 "mac-ews",
 "mac-wk2-ews",
+"mac-debug-32bit-ews",
 "win-ews",
 "efl-wk2-ews",
 ]


Modified: trunk/Tools/Scripts/webkitpy/common/config/ews.json (190921 => 190922)

--- trunk/Tools/Scripts/webkitpy/common/config/ews.json	2015-10-13 02:12:11 UTC (rev 190921)
+++ trunk/Tools/Scripts/webkitpy/common/config/ews.json	2015-10-13 02:49:33 UTC (rev 190922)
@@ -34,5 +34,11 @@
 "rn...@webkit.org"
 ],
 "runTests": true
+},
+"Mac Debug 32-bit WK2 EWS": {
+"port": "mac",
+"name": "mac-debug-32bit-ews",
+"style": "debug",
+"architecture": "i386",
 }
 }


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (190921 => 190922)

--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py	2015-10-13 02:12:11 UTC (rev 190921)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py	2015-10-13 02:49:33 UTC (rev 190922)
@@ -44,7 +44,6 @@
 
 
 class AbstractEarlyWarningSystem(AbstractReviewQueue, EarlyWarningSystemTaskDelegate):
-_build_style = "release"
 # FIXME: Switch _default_run_tests from opt-in to opt-out once more bots are ready to run tests.
 run_tests = False
 
@@ -124,7 +123,7 @@
 return self._layout_test_results_reader.archive(patch)
 
 def build_style(self):
-return self._build_style
+return self.build_style
 
 def refetch_patch(self, patch):
 return self._tool.bugs.fetch_attachment(patch.id())
@@ -150,10 +149,11 @@
 
 classes = []
 for name, config in ewses.iteritems():
-classes.append(type(str(name.replace(' ', '')), (AbstractEarlyWarningSystem,), {
-'name': config['port'] + '-ews',
+classes.append(type(str(name).translate(None, ' -'), (AbstractEarlyWarningSystem,), {
+'name': config.get('name', config['port'] + '-ews'),
 'port_name': config['port'],
 'architecture': config.get('architecture', None),
+'build_style': config.get('style', "release"),
 'watchers': config.get('watchers', []),
 'run_tests': config.get('runTests', cls.run_tests),
 }))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190924] trunk/Tools

[ap]

Title: [190924] trunk/Tools








Revision 190924
Author a...@apple.com
Date 2015-10-12 22:08:52 -0700 (Mon, 12 Oct 2015)


Log Message
Fix webkitpy tests after r190922.

* Scripts/webkitpy/common/config/ews.json:
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/ews.json
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py
trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (190923 => 190924)

--- trunk/Tools/ChangeLog	2015-10-13 03:24:02 UTC (rev 190923)
+++ trunk/Tools/ChangeLog	2015-10-13 05:08:52 UTC (rev 190924)
@@ -1,5 +1,13 @@
 2015-10-12  Alexey Proskuryakov  
 
+Fix webkitpy tests after r190922.
+
+* Scripts/webkitpy/common/config/ews.json:
+* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+
+2015-10-12  Alexey Proskuryakov  
+
 Add a Mac debug EWS queue
 https://bugs.webkit.org/show_bug.cgi?id=150069
 


Modified: trunk/Tools/Scripts/webkitpy/common/config/ews.json (190923 => 190924)

--- trunk/Tools/Scripts/webkitpy/common/config/ews.json	2015-10-13 03:24:02 UTC (rev 190923)
+++ trunk/Tools/Scripts/webkitpy/common/config/ews.json	2015-10-13 05:08:52 UTC (rev 190924)
@@ -39,6 +39,6 @@
 "port": "mac",
 "name": "mac-debug-32bit-ews",
 "style": "debug",
-"architecture": "i386",
+"architecture": "i386"
 }
 }


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (190923 => 190924)

--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py	2015-10-13 03:24:02 UTC (rev 190923)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py	2015-10-13 05:08:52 UTC (rev 190924)
@@ -123,7 +123,7 @@
 return self._layout_test_results_reader.archive(patch)
 
 def build_style(self):
-return self.build_style
+return self._build_style
 
 def refetch_patch(self, patch):
 return self._tool.bugs.fetch_attachment(patch.id())
@@ -149,11 +149,11 @@
 
 classes = []
 for name, config in ewses.iteritems():
-classes.append(type(str(name).translate(None, ' -'), (AbstractEarlyWarningSystem,), {
+classes.append(type(name.encode('utf-8').translate(None, ' -'), (AbstractEarlyWarningSystem,), {
 'name': config.get('name', config['port'] + '-ews'),
 'port_name': config['port'],
 'architecture': config.get('architecture', None),
-'build_style': config.get('style', "release"),
+'_build_style': config.get('style', "release"),
 'watchers': config.get('watchers', []),
 'run_tests': config.get('runTests', cls.run_tests),
 }))


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (190923 => 190924)

--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py	2015-10-13 03:24:02 UTC (rev 190923)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py	2015-10-13 05:08:52 UTC (rev 190924)
@@ -64,6 +64,7 @@
 "name": ews.name,
 "port": ews.port_name,
 "architecture": " --architecture=%s" % ews.architecture if ews.architecture else "",
+"build_style": ews.build_style(),
 }
 if ews.run_tests:
 run_tests_line = "Running: webkit-patch --status-host=example.com build-and-test --no-clean --no-update --test --non-interactive --port=%(port)s%(architecture)s\n" % string_replacements
@@ -76,7 +77,7 @@
 "process_work_item": """Running: webkit-patch --status-host=example.com clean --port=%(port)s%(architecture)s
 Running: webkit-patch --status-host=example.com update --port=%(port)s%(architecture)s
 Running: webkit-patch --status-host=example.com apply-attachment --no-update --non-interactive 1 --port=%(port)s%(architecture)s
-Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=release --port=%(port)s%(architecture)s
+Running: webkit-patch --status-host=example.com build --no-clean --no-update --build-style=%(build_style)s --port=%(port)s%(architecture)s
 %(run_tests_line)sMOCK: update_status: %(name)s Pass
 MOCK: release_work_item: %(name)s 1
 """ % string_replacements,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190919] trunk/PerformanceTests

[jonlee]

Title: [190919] trunk/PerformanceTests








Revision 190919
Author jon...@apple.com
Date 2015-10-12 19:11:06 -0700 (Mon, 12 Oct 2015)


Log Message
Add missing paint objects for arc and arcTo fills
https://bugs.webkit.org/show_bug.cgi?id=150075


Reviewed by Dean Jackson.

* Animometer/tests/simple/resources/simple-canvas-paths.js: Add missing paint objects
for arcTo and arc segment fills.
(CanvasArcToSegmentFill):
(CanvasArcToSegmentFill.prototype.draw):
(CanvasArcSegmentFill):
(CanvasArcSegmentFill.prototype.draw):

Modified Paths

trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js (190918 => 190919)

--- trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:10:42 UTC (rev 190918)
+++ trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:11:06 UTC (rev 190919)
@@ -104,6 +104,17 @@
 context.stroke();
 };
 
+function CanvasArcToSegmentFill(stage) {
+CanvasArcToSegment.call(this, stage);
+};
+CanvasArcToSegmentFill.prototype.draw = function(context) {
+context.fillStyle = this._color;
+context.beginPath();
+context.moveTo(this._point1.x, this._point1.y);
+context.arcTo(this._point2.x, this._point2.y, this._point3.x, this._point3.y, this._radius);
+context.fill();
+};
+
 function CanvasArcSegment(stage) {
 var maxSize = stage.randomInt(20, 200);
 var toCenter = stage.randomPosition(stage.size).subtract(new Point(maxSize/2, maxSize/2));
@@ -124,6 +135,16 @@
 context.stroke();
 };
 
+function CanvasArcSegmentFill(stage) {
+CanvasArcSegment.call(this, stage);
+};
+CanvasArcSegmentFill.prototype.draw = function(context) {
+context.fillStyle = this._color;
+context.beginPath();
+context.arc(this._point.x, this._point.y, this._radius, this._startAngle, this._endAngle, this._counterclockwise);
+context.fill();
+};
+
 function CanvasRect(stage) {
 this._width = stage.randomInt(20, 200);
 this._height = stage.randomInt(20, 200);


Modified: trunk/PerformanceTests/ChangeLog (190918 => 190919)

--- trunk/PerformanceTests/ChangeLog	2015-10-13 02:10:42 UTC (rev 190918)
+++ trunk/PerformanceTests/ChangeLog	2015-10-13 02:11:06 UTC (rev 190919)
@@ -1,5 +1,20 @@
 2015-10-12  Jon Lee  
 
+Add missing paint objects for arc and arcTo fills
+https://bugs.webkit.org/show_bug.cgi?id=150075
+
+
+Reviewed by Dean Jackson.
+
+* Animometer/tests/simple/resources/simple-canvas-paths.js: Add missing paint objects
+for arcTo and arc segment fills.
+(CanvasArcToSegmentFill):
+(CanvasArcToSegmentFill.prototype.draw):
+(CanvasArcSegmentFill):
+(CanvasArcSegmentFill.prototype.draw):
+
+2015-10-12  Jon Lee  
+
 Add canvas line segment tests
 https://bugs.webkit.org/show_bug.cgi?id=150073
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190918] trunk/PerformanceTests

[jonlee]

Title: [190918] trunk/PerformanceTests








Revision 190918
Author jon...@apple.com
Date 2015-10-12 19:10:42 -0700 (Mon, 12 Oct 2015)


Log Message
Add canvas line segment tests
https://bugs.webkit.org/show_bug.cgi?id=150073


Reviewed by Dean Jackson.

* Animometer/runner/resources/tests.js: Add new line segment tests, with different
line caps.
* Animometer/tests/simple/resources/simple-canvas-paths.js:
(CanvasLineSegment): Add new line segment paint object.
(CanvasLineSegmentStage): Create a new stage that sets the lineCap.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/tests.js (190917 => 190918)

--- trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 02:10:08 UTC (rev 190917)
+++ trunk/PerformanceTests/Animometer/runner/resources/tests.js	2015-10-13 02:10:42 UTC (rev 190918)
@@ -139,6 +139,18 @@
 Suites.push(new Suite("Basic canvas path suite",
 [
 {
+url: "simple/simple-canvas-paths.html?pathType=line=butt",
+name: "Canvas line segments, butt caps"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=line=round",
+name: "Canvas line segments, round caps"
+},
+{
+url: "simple/simple-canvas-paths.html?pathType=line=square",
+name: "Canvas line segments, square caps"
+},
+{
 url: "simple/simple-canvas-paths.html?pathType=quadratic",
 name: "Canvas quadratic segments"
 },


Modified: trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js (190917 => 190918)

--- trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:10:08 UTC (rev 190917)
+++ trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js	2015-10-13 02:10:42 UTC (rev 190918)
@@ -1,5 +1,24 @@
 // === PAINT OBJECTS ===
 
+function CanvasLineSegment(stage) {
+var radius = stage.randomInt(10, 100);
+var center = stage.randomPosition(stage.size);
+var delta = Point.pointOnCircle(stage.randomAngle(), radius/2);
+
+this._point1 = center.add(delta);
+this._point2 = center.subtract(delta);
+this._color = stage.randomColor();
+this._lineWidth = stage.randomInt(1, 100);
+}
+CanvasLineSegment.prototype.draw = function(context) {
+context.strokeStyle = this._color;
+context.lineWidth = this._lineWidth;
+context.beginPath();
+context.moveTo(this._point1.x, this._point1.y);
+context.lineTo(this._point2.x, this._point2.y);
+context.stroke();
+};
+
 function CanvasLinePoint(stage, coordinateMaximum) {
 this._point = stage.randomPosition(new Point(Math.min(stage.size.x, coordinateMaximum), Math.min(stage.size.y, coordinateMaximum)));
 }
@@ -165,6 +184,14 @@
 context.fill();
 }
 
+function CanvasLineSegmentStage(element, options)
+{
+SimpleCanvasStage.call(this, element, options, CanvasLineSegment);
+this.context.lineCap = options["lineCap"] || "butt";
+}
+CanvasLineSegmentStage.prototype = Object.create(SimpleCanvasStage.prototype);
+CanvasLineSegmentStage.prototype.constructor = CanvasLineSegmentStage;
+
 // === BENCHMARK ===
 
 function CanvasPathBenchmark(suite, test, options, recordTable, progressBar) {
@@ -175,6 +202,8 @@
 CanvasPathBenchmark.prototype.createStage = function(element)
 {
 switch (this._options["pathType"]) {
+case "line":
+return new CanvasLineSegmentStage(element, this._options);
 case "quadratic":
 return new SimpleCanvasStage(element, this._options, CanvasQuadraticSegment);
 case "quadraticPath":


Modified: trunk/PerformanceTests/ChangeLog (190917 => 190918)

--- trunk/PerformanceTests/ChangeLog	2015-10-13 02:10:08 UTC (rev 190917)
+++ trunk/PerformanceTests/ChangeLog	2015-10-13 02:10:42 UTC (rev 190918)
@@ -1,5 +1,19 @@
 2015-10-12  Jon Lee  
 
+Add canvas line segment tests
+https://bugs.webkit.org/show_bug.cgi?id=150073
+
+
+Reviewed by Dean Jackson.
+
+* Animometer/runner/resources/tests.js: Add new line segment tests, with different
+line caps.
+* Animometer/tests/simple/resources/simple-canvas-paths.js:
+(CanvasLineSegment): Add new line segment paint object.
+(CanvasLineSegmentStage): Create a new stage that sets the lineCap.
+
+2015-10-12  Jon Lee  
+
 Add canvas path fill tests
 https://bugs.webkit.org/show_bug.cgi?id=150071
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [190925] trunk/Tools

[ap]

Title: [190925] trunk/Tools








Revision 190925
Author a...@apple.com
Date 2015-10-12 22:13:05 -0700 (Mon, 12 Oct 2015)


Log Message
Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
https://bugs.webkit.org/show_bug.cgi?id=149983

Reviewed by Dan Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js (190924 => 190925)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js	2015-10-13 05:08:52 UTC (rev 190924)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js	2015-10-13 05:13:05 UTC (rev 190925)
@@ -29,7 +29,7 @@
 "commit-queue": {platform: Dashboard.Platform.MacOSXMavericks, shortName: "commit", title: "Commit Queue"},
 "style-queue": {shortName: "style", title: "Style Checker Queue"},
 "gtk-wk2-ews": {platform: Dashboard.Platform.LinuxGTK, shortName: "gtk-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"},
-"ios-ews": {platform: Dashboard.Platform.iOS8Device, shortName: "ios", title: "WebKit\xa0Release\xa0Build\xa0EWS"},
+"ios-ews": {platform: Dashboard.Platform.iOS9Device, shortName: "ios", title: "WebKit\xa0Release\xa0Build\xa0EWS"},
 "mac-ews": {platform: Dashboard.Platform.MacOSXMavericks, shortName: "mac", title: "WebKit1\xa0Release\xa0Tests\xa0EWS"},
 "mac-wk2-ews": {platform: Dashboard.Platform.MacOSXMavericks, shortName: "mac-wk2", title: "WebKit2\xa0Release\xa0Tests\xa0EWS"},
 "win-ews": {platform: Dashboard.Platform.Windows7, shortName: "win", title: "WebKit1\xa0Release\xa0Build\xa0EWS"},


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js (190924 => 190925)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js	2015-10-13 05:08:52 UTC (rev 190924)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js	2015-10-13 05:13:05 UTC (rev 190925)
@@ -29,8 +29,7 @@
 MacOSXYosemite: { name: "mac-os-x-yosemite", readableName: "OS X Yosemite", order: 10 },
 MacOSXMavericks: { name: "mac-os-x-mavericks", readableName: "OS X Mavericks", order: 20 },
 iOS9Simulator: { name: "ios-simulator-9", readableName: "iOS 9 Simulator", order: 30 },
-iOS9Device: { name: "ios-9", readableName: "iOS 9", order: 35 },
-iOS8Device: { name: "ios-8", readableName: "iOS 8", order: 40 },
+iOS9Device: { name: "ios-9", readableName: "iOS 9", order: 40 },
 Windows8: { name: "windows-8", readableName: "Windows 8", order: 50 },
 Windows7: { name: "windows-7", readableName: "Windows 7", order: 60 },
 WindowsXP: { name: "windows-xp", readableName: "Windows XP", order: 70 },


Modified: trunk/Tools/ChangeLog (190924 => 190925)

--- trunk/Tools/ChangeLog	2015-10-13 05:08:52 UTC (rev 190924)
+++ trunk/Tools/ChangeLog	2015-10-13 05:13:05 UTC (rev 190925)
@@ -1,5 +1,16 @@
 2015-10-12  Alexey Proskuryakov  
 
+Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
+https://bugs.webkit.org/show_bug.cgi?id=149983
+
+Reviewed by Dan Bates.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
+(BubbleQueueServer):
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
+
+2015-10-12  Alexey Proskuryakov  
+
 Fix webkitpy tests after r190922.
 
 * Scripts/webkitpy/common/config/ews.json:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes