[webkit-changes] [192514] trunk/LayoutTests

[bfulgham]

Title: [192514] trunk/LayoutTests








Revision 192514
Author bfulg...@apple.com
Date 2015-11-17 09:58:42 -0800 (Tue, 17 Nov 2015)


Log Message
[WK1] Mark test failure to get bots green after r192499
https://bugs.webkit.org/show_bug.cgi?id=151055

* webgl/1.0.3/151055_asan.html: Mark webgl/1.0.3/151055_asan.html as failing.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (192513 => 192514)

--- trunk/LayoutTests/ChangeLog	2015-11-17 10:13:19 UTC (rev 192513)
+++ trunk/LayoutTests/ChangeLog	2015-11-17 17:58:42 UTC (rev 192514)
@@ -1,3 +1,10 @@
+2015-11-17  Brent Fulgham  
+
+[WK1] Mark test failure to get bots green after r192499
+https://bugs.webkit.org/show_bug.cgi?id=151055
+
+* webgl/1.0.3/151055_asan.html: Mark webgl/1.0.3/151055_asan.html as failing.
+
 2015-11-17  Sergio Villar Senin  
 
 ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192513 => 192514)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-11-17 10:13:19 UTC (rev 192513)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-11-17 17:58:42 UTC (rev 192514)
@@ -172,3 +172,6 @@
 imported/blink/svg/custom/marker-layout-invalidation.html [ Pass Timeout ]
 imported/blink/fast/css/crash-corner-present.html [ Pass Timeout ]
 imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
+
+# ASAN test only fails on WK1:
+webgl/1.0.3/151055_asan.html [ Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192515] trunk/LayoutTests

[wenson_hsieh]

Title: [192515] trunk/LayoutTests








Revision 192515
Author wenson_hs...@apple.com
Date 2015-11-17 11:05:29 -0800 (Tue, 17 Nov 2015)


Log Message
Unreviewed, skip crashing mediastream tests

Tests in fast/mediastream/ that attempt to render mock video source frames crash due to
use-after-free. https://bugs.webkit.org/show_bug.cgi?id=151353 tracks these crashes.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (192514 => 192515)

--- trunk/LayoutTests/ChangeLog	2015-11-17 17:58:42 UTC (rev 192514)
+++ trunk/LayoutTests/ChangeLog	2015-11-17 19:05:29 UTC (rev 192515)
@@ -1,3 +1,12 @@
+2015-11-17  Wenson Hsieh  
+
+Unreviewed, skip crashing mediastream tests
+
+Tests in fast/mediastream/ that attempt to render mock video source frames crash due to
+use-after-free. https://bugs.webkit.org/show_bug.cgi?id=151353 tracks these crashes.
+
+* platform/mac/TestExpectations:
+
 2015-11-17  Brent Fulgham  
 
 [WK1] Mark test failure to get bots green after r192499


Modified: trunk/LayoutTests/platform/mac/TestExpectations (192514 => 192515)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-11-17 17:58:42 UTC (rev 192514)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-11-17 19:05:29 UTC (rev 192515)
@@ -156,6 +156,10 @@
 fast/mediastream/MediaStreamTrack-onended.html
 fast/mediastream/MediaStreamTrack.html
 
+# Media Stream tests that crash unexpectedly under GuardMalloc, see https://bugs.webkit.org/show_bug.cgi?id=151353
+fast/mediastream/MediaStream-video-element-track-stop.html
+fast/mediastream/MediaStream-video-element.html
+
 # WebRTC is not supported yet.
 fast/mediastream/RTCPeerConnection-AddRemoveStream.html
 fast/mediastream/RTCPeerConnection-createAnswer.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192542] trunk/Source/JavaScriptCore

[fpizlo]

Title: [192542] trunk/Source/_javascript_Core








Revision 192542
Author fpi...@apple.com
Date 2015-11-17 14:46:53 -0800 (Tue, 17 Nov 2015)


Log Message
Add a FTL_USES_B3 compile-time setting and set it to 0.

Rubber stamped by Benjamin Poulain.

* dfg/DFGCommon.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGCommon.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192541 => 192542)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:41:24 UTC (rev 192541)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:46:53 UTC (rev 192542)
@@ -1,5 +1,13 @@
 2015-11-17  Filip Pizlo  
 
+Add a FTL_USES_B3 compile-time setting and set it to 0.
+
+Rubber stamped by Benjamin Poulain.
+
+* dfg/DFGCommon.h:
+
+2015-11-17  Filip Pizlo  
+
 CheckAdd/Mul should have commutativity optimizations in B3->Air lowering
 https://bugs.webkit.org/show_bug.cgi?id=151214
 


Modified: trunk/Source/_javascript_Core/dfg/DFGCommon.h (192541 => 192542)

--- trunk/Source/_javascript_Core/dfg/DFGCommon.h	2015-11-17 22:41:24 UTC (rev 192541)
+++ trunk/Source/_javascript_Core/dfg/DFGCommon.h	2015-11-17 22:46:53 UTC (rev 192542)
@@ -35,6 +35,11 @@
 
 namespace JSC { namespace DFG {
 
+// We are in the middle of an experimental transition from LLVM to B3 as the backend for the FTL. We don't
+// yet know how it will turn out. For now, this flag will control whether FTL uses B3. Remember to set this
+// to 0 before committing!
+#define FTL_USES_B3 0
+
 struct Node;
 
 typedef uint32_t BlockIndex;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192544] trunk/Source/JavaScriptCore

[commit-queue]

Title: [192544] trunk/Source/_javascript_Core








Revision 192544
Author commit-qu...@webkit.org
Date 2015-11-17 15:10:14 -0800 (Tue, 17 Nov 2015)


Log Message
[JSC] Do not copy the adjacency list when we just need to manipulate them
https://bugs.webkit.org/show_bug.cgi?id=151343

Patch by Benjamin Poulain  on 2015-11-17
Reviewed by Geoffrey Garen.

* b3/air/AirIteratedRegisterCoalescing.cpp:
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::precoloredCoalescingHeuristic):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::conservativeHeuristic):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192543 => 192544)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:48:19 UTC (rev 192543)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 23:10:14 UTC (rev 192544)
@@ -1,5 +1,16 @@
 2015-11-17  Benjamin Poulain  
 
+[JSC] Do not copy the adjacency list when we just need to manipulate them
+https://bugs.webkit.org/show_bug.cgi?id=151343
+
+Reviewed by Geoffrey Garen.
+
+* b3/air/AirIteratedRegisterCoalescing.cpp:
+(JSC::B3::Air::IteratedRegisterCoalescingAllocator::precoloredCoalescingHeuristic):
+(JSC::B3::Air::IteratedRegisterCoalescingAllocator::conservativeHeuristic):
+
+2015-11-17  Benjamin Poulain  
+
 [JSC] Remove FTLOutput operations that act directly on floats
 https://bugs.webkit.org/show_bug.cgi?id=151342
 


Modified: trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp (192543 => 192544)

--- trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp	2015-11-17 22:48:19 UTC (rev 192543)
+++ trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp	2015-11-17 23:10:14 UTC (rev 192544)
@@ -464,7 +464,7 @@
 // If any adjacent of the non-colored node is not an adjacent of the colored node AND has a degree >= K
 // there is a risk that this node needs to have the same color as our precolored node. If we coalesce such
 // move, we may create an uncolorable graph.
-auto adjacentsOfV = m_adjacencyList[AbsoluteTmpHelper::absoluteIndex(v)];
+const auto& adjacentsOfV = m_adjacencyList[AbsoluteTmpHelper::absoluteIndex(v)];
 for (Tmp adjacentTmp : adjacentsOfV) {
 if (!adjacentTmp.isReg()
 && !hasBeenSimplified(adjacentTmp)
@@ -486,8 +486,8 @@
 ASSERT(!u.isReg());
 ASSERT(!v.isReg());
 
-auto adjacentsOfU = m_adjacencyList[AbsoluteTmpHelper::absoluteIndex(u)];
-auto adjacentsOfV = m_adjacencyList[AbsoluteTmpHelper::absoluteIndex(v)];
+const auto& adjacentsOfU = m_adjacencyList[AbsoluteTmpHelper::absoluteIndex(u)];
+const auto& adjacentsOfV = m_adjacencyList[AbsoluteTmpHelper::absoluteIndex(v)];
 
 if (adjacentsOfU.size() + adjacentsOfV.size() < m_numberOfRegisters) {
 // Shortcut: if the total number of adjacents is less than the number of register, the condition is always met.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192549] trunk/PerformanceTests

[commit-queue]

Title: [192549] trunk/PerformanceTests








Revision 192549
Author commit-qu...@webkit.org
Date 2015-11-17 16:08:38 -0800 (Tue, 17 Nov 2015)


Log Message
Use the media queries to dynamically set the stage for the graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=151327

Patch by Said Abou-Hallawa  on 2015-11-17
Reviewed by Simon Fraser.

Clean setting the benchmark css rules by using the media queries. Accessing
document.stylesheets.cssRules seems to be unreliable. Fix the test harness
load event listener invocation. And also remove the options for normalizing
the stage resolution for retina display.

* Animometer/resources/extensions.js:
(window.DocumentExtension.insertCssRuleAfter): Deleted.
* Animometer/runner/animometer.html:
* Animometer/runner/resources/animometer.css:
(@media screen and (min-device-width: 1800px)):
* Animometer/runner/resources/animometer.js:
(window.sectionsManager.setupRunningSectionStyle):
(window.benchmarkController.initialize):
(window.sectionsManager.setupSectionStyle): Deleted.
* Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
(BouncingParticlesStage):
* Animometer/tests/text/layering-text.html:
* Animometer/tests/text/resources/layering-text.js:
(LayeringTextStage):
(LayeringTextStage.prototype._setFontSize): Deleted.

Modified Paths

trunk/PerformanceTests/Animometer/resources/extensions.js
trunk/PerformanceTests/Animometer/runner/animometer.html
trunk/PerformanceTests/Animometer/runner/resources/animometer.css
trunk/PerformanceTests/Animometer/runner/resources/animometer.js
trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js
trunk/PerformanceTests/Animometer/tests/text/layering-text.html
trunk/PerformanceTests/Animometer/tests/text/resources/layering-text.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/resources/extensions.js (192548 => 192549)

--- trunk/PerformanceTests/Animometer/resources/extensions.js	2015-11-18 00:07:34 UTC (rev 192548)
+++ trunk/PerformanceTests/Animometer/resources/extensions.js	2015-11-18 00:08:38 UTC (rev 192549)
@@ -160,22 +160,6 @@
 
 parentElement.appendChild(element);
 return element;
-},
-
-insertCssRuleAfter: function(newRule, referenceRule)
-{
-var styleSheets = document.styleSheets;
-
-for (var i = 0; i < styleSheets.length; ++i) {   
-for (var j = 0; j < styleSheets[i].cssRules.length; ++j) {
-if (styleSheets[i].cssRules[j].selectorText == referenceRule) {
-styleSheets[i].insertRule(newRule, j + 1);
-return true;
-}
-}
-}
-
-return false;
 }
 }
 


Modified: trunk/PerformanceTests/Animometer/runner/animometer.html (192548 => 192549)

--- trunk/PerformanceTests/Animometer/runner/animometer.html	2015-11-18 00:07:34 UTC (rev 192548)
+++ trunk/PerformanceTests/Animometer/runner/animometer.html	2015-11-18 00:08:38 UTC (rev 192549)
@@ -32,7 +32,6 @@
  Estimated Frame Rate
  Fix test complexity after warmup
  Show running results
- Normalize for device scale factor
  Adaptive test
 
 


Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.css (192548 => 192549)

--- trunk/PerformanceTests/Animometer/runner/resources/animometer.css	2015-11-18 00:07:34 UTC (rev 192548)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.css	2015-11-18 00:08:38 UTC (rev 192549)
@@ -240,6 +240,13 @@
 justify-content: center;
 }
 
+@media screen and (min-device-width: 1800px) {
+section {
+width: 1600px;
+height: 800px;
+}
+}
+
 /* -- */
 /* Home Section   */
 /* -- */


Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.js (192548 => 192549)

--- trunk/PerformanceTests/Animometer/runner/resources/animometer.js	2015-11-18 00:07:34 UTC (rev 192548)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.js	2015-11-18 00:08:38 UTC (rev 192549)
@@ -109,30 +109,10 @@
 history.pushState({section: sectionIdentifier}, document.title);
 },
 
-setupSectionStyle: function()
-{
-if (screen.width >= 1800 && screen.height >= 1000)
-DocumentExtension.insertCssRuleAfter(" section { width: 1600px; height: 800px; }", "section");
-else
-DocumentExtension.insertCssRuleAfter(" section { width: 800px; height: 600px; }", "section");
-},
-
 setupRunningSectionStyle: function(options)
 {
 if (!options["show-running-results"])
 document.getElementById("record").style.display = 

[webkit-changes] [192551] trunk/Source/WebInspectorUI

[mattbaker]

Title: [192551] trunk/Source/WebInspectorUI








Revision 192551
Author mattba...@apple.com
Date 2015-11-17 16:23:56 -0800 (Tue, 17 Nov 2015)


Log Message
Web Inspector: Breakpoint condition field should use CodeMirror
https://bugs.webkit.org/show_bug.cgi?id=151333

Reviewed by Joseph Pecoraro.

Updated breakpoint popover's condition field to use CodeMirror.

* UserInterface/Controllers/BreakpointPopoverController.js:
Removed keyboard shortcuts. Now handled by CodeMirror.
(WebInspector.BreakpointPopoverController.prototype.completionControllerShouldAllowEscapeCompletion):
Prevent handling of escape to allow tabbing to next element.
(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
Create CodeMirror instance.
(WebInspector.BreakpointPopoverController.prototype._conditionCodeMirrorChanged):
(WebInspector.BreakpointPopoverController.prototype._conditionCodeMirrorBeforeChange):
Enforce single-line editor.
(WebInspector.BreakpointPopoverController.prototype._conditionCodeMirrorEscapeOrEnterKey):
(WebInspector.BreakpointPopoverController): Deleted.
(WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.editBreakpoint):
Removed condition element select. CodeMirror sets focus when popover content is created.
(WebInspector.BreakpointPopoverController.prototype._popoverConditionInputChanged): Deleted.
Replaced by BreakpointPopoverController.prototype._conditionCodeMirrorChanged.
(WebInspector.BreakpointPopoverController.prototype._popoverConditionInputKeyDown): Deleted.
Replaced by BreakpointPopoverController.prototype._conditionCodeMirrorEscapeOrEnterKey.

* UserInterface/Views/BreakpointPopoverController.css:
(.edit-breakpoint-popover-condition):
(.edit-breakpoint-popover-condition > .CodeMirror):
(#edit-breakpoint-popover-condition): Deleted.
Replace selector id with class, styled CodeMirror element to match original input element.

* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-placeholder): Deleted.
Moved common CodeMirror placeholder text style to CodeMirrorOverrides.css.

* UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror .CodeMirror-placeholder):
Add placeholder style.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/BreakpointPopoverController.js
trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorOverrides.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (192550 => 192551)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-11-18 00:16:56 UTC (rev 192550)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-11-18 00:23:56 UTC (rev 192551)
@@ -1,3 +1,44 @@
+2015-11-17  Matt Baker  
+
+Web Inspector: Breakpoint condition field should use CodeMirror
+https://bugs.webkit.org/show_bug.cgi?id=151333
+
+Reviewed by Joseph Pecoraro.
+
+Updated breakpoint popover's condition field to use CodeMirror.
+
+* UserInterface/Controllers/BreakpointPopoverController.js:
+Removed keyboard shortcuts. Now handled by CodeMirror.
+(WebInspector.BreakpointPopoverController.prototype.completionControllerShouldAllowEscapeCompletion):
+Prevent handling of escape to allow tabbing to next element.
+(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
+Create CodeMirror instance.
+(WebInspector.BreakpointPopoverController.prototype._conditionCodeMirrorChanged):
+(WebInspector.BreakpointPopoverController.prototype._conditionCodeMirrorBeforeChange):
+Enforce single-line editor.
+(WebInspector.BreakpointPopoverController.prototype._conditionCodeMirrorEscapeOrEnterKey):
+(WebInspector.BreakpointPopoverController): Deleted.
+(WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.editBreakpoint):
+Removed condition element select. CodeMirror sets focus when popover content is created.
+(WebInspector.BreakpointPopoverController.prototype._popoverConditionInputChanged): Deleted.
+Replaced by BreakpointPopoverController.prototype._conditionCodeMirrorChanged.
+(WebInspector.BreakpointPopoverController.prototype._popoverConditionInputKeyDown): Deleted.
+Replaced by BreakpointPopoverController.prototype._conditionCodeMirrorEscapeOrEnterKey.
+
+* UserInterface/Views/BreakpointPopoverController.css:
+(.edit-breakpoint-popover-condition):
+(.edit-breakpoint-popover-condition > .CodeMirror):
+(#edit-breakpoint-popover-condition): Deleted.
+Replace selector id with class, styled CodeMirror element to match original input element.
+
+* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
+(.css-style-text-editor > 

[webkit-changes] [192552] branches/safari-601.1.46-branch/Source

[matthew_hanson]

Title: [192552] branches/safari-601.1.46-branch/Source








Revision 192552
Author matthew_han...@apple.com
Date 2015-11-17 16:26:54 -0800 (Tue, 17 Nov 2015)


Log Message
Rollout r192501. rdar://problem/22846841

Modified Paths

branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.h
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
branches/safari-601.1.46-branch/Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h
branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (192551 => 192552)

--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-11-18 00:23:56 UTC (rev 192551)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-11-18 00:26:54 UTC (rev 192552)
@@ -1,23 +1,7 @@
-2015-11-16  Matthew Hanson  
+2015-11-13  Matthew Hanson  
 
-Merge r192284. rdar://problem/22846841
+Rollout r192501. rdar://problem/22846841
 
-2015-11-10  Simon Fraser  
-
-Use different pixel formats for displays that support them
-https://bugs.webkit.org/show_bug.cgi?id=151122
-rdar://problem/22846841
-
-Reviewed by Tim Horton.
-
-Add new IOSurface format enum values, and set up the appropriate IOSurfaceCreate()
-property dictionaries for them.
-
-* platform/graphics/cocoa/IOSurface.h:
-* platform/graphics/cocoa/IOSurface.mm:
-(IOSurface::IOSurface):
-* platform/spi/cocoa/IOSurfaceSPI.h:
-
 2015-11-16  Matthew Hanson  
 
 Merge r192138. rdar://problem/22846841


Modified: branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.h (192551 => 192552)

--- branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2015-11-18 00:23:56 UTC (rev 192551)
+++ branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2015-11-18 00:26:54 UTC (rev 192552)
@@ -41,9 +41,7 @@
 enum class Format {
 RGBA,
 #if PLATFORM(IOS)
-YUV422,
-RGB10,
-RGB10A8,
+YUV422
 #endif
 };
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm (192551 => 192552)

--- branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm	2015-11-18 00:23:56 UTC (rev 192551)
+++ branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm	2015-11-18 00:26:54 UTC (rev 192552)
@@ -102,115 +102,44 @@
 , m_size(size)
 , m_contextSize(size)
 {
+unsigned pixelFormat = 'BGRA';
+unsigned bytesPerPixel = 4;
+unsigned bytesPerElement = 4;
+unsigned elementWidth = 1;
 
-unsigned pixelFormat;
-unsigned bytesPerPixel;
-unsigned bytesPerElement;
+#if PLATFORM(IOS)
+if (format == Format::YUV422) {
+pixelFormat = 'yuvf';
+bytesPerPixel = 2;
+elementWidth = 2;
+bytesPerElement = 4;
+}
+#endif
 
 int width = size.width();
 int height = size.height();
 
-NSDictionary *options;
-
-if (format == Format::RGB10A8) {
-pixelFormat = 'b3a8';
-
-// RGB plane (10-10-10)
-bytesPerPixel = 4;
-bytesPerElement = 4;
+size_t bytesPerRow = IOSurfaceAlignProperty(kIOSurfaceBytesPerRow, width * bytesPerPixel);
+ASSERT(bytesPerRow);
 
-size_t rgbPlaneBytesPerRow = IOSurfaceAlignProperty(kIOSurfaceBytesPerRow, width * bytesPerElement);
-size_t rgbPlaneTotalBytes = IOSurfaceAlignProperty(kIOSurfaceAllocSize, height * rgbPlaneBytesPerRow);
+m_totalBytes = IOSurfaceAlignProperty(kIOSurfaceAllocSize, height * bytesPerRow);
+ASSERT(m_totalBytes);
 
-// Alpha plane (8)
-bytesPerElement = 1;
-size_t alphaPlaneBytesPerRow = IOSurfaceAlignProperty(kIOSurfaceBytesPerRow, width * bytesPerElement);
-size_t alphaPlaneTotalBytes = IOSurfaceAlignProperty(kIOSurfaceAllocSize, height * alphaPlaneBytesPerRow);
-
-m_totalBytes = rgbPlaneTotalBytes + alphaPlaneTotalBytes;
-
-NSArray *planeInfo = @[
-@{
-(id)kIOSurfacePlaneWidth: @(width),
-(id)kIOSurfacePlaneHeight: @(height),
-(id)kIOSurfacePlaneBytesPerRow: @(rgbPlaneBytesPerRow),
-(id)kIOSurfacePlaneOffset: @(0),
-(id)kIOSurfacePlaneSize: @(rgbPlaneTotalBytes)
-},
-@{
-(id)kIOSurfacePlaneWidth: @(width),
-(id)kIOSurfacePlaneHeight: @(height),
-(id)kIOSurfacePlaneBytesPerRow: @(alphaPlaneBytesPerRow),
-(id)kIOSurfacePlaneOffset: 

[webkit-changes] [192553] branches/safari-601.1.46-branch/Source

[matthew_hanson]

Title: [192553] branches/safari-601.1.46-branch/Source








Revision 192553
Author matthew_han...@apple.com
Date 2015-11-17 16:27:03 -0800 (Tue, 17 Nov 2015)


Log Message
Rollout r192479. rdar://problem/22846841

Modified Paths

branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/GraphicsContext.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/ImageBuffer.h
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cg/BitmapImageCG.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cg/ColorCG.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/filters/FEFlood.h
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/filters/FETile.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/filters/FilterEffect.cpp
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/filters/SourceGraphic.h
branches/safari-601.1.46-branch/Source/WebCore/rendering/FilterEffectRenderer.cpp
branches/safari-601.1.46-branch/Source/WebCore/rendering/RenderThemeMac.mm
branches/safari-601.1.46-branch/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
branches/safari-601.1.46-branch/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
branches/safari-601.1.46-branch/Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp
branches/safari-601.1.46-branch/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
branches/safari-601.1.46-branch/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp
branches/safari-601.1.46-branch/Source/WebCore/svg/graphics/SVGImage.cpp
branches/safari-601.1.46-branch/Source/WebCore/svg/graphics/filters/SVGFEImage.cpp
branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (192552 => 192553)

--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-11-18 00:26:54 UTC (rev 192552)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-11-18 00:27:03 UTC (rev 192553)
@@ -1,62 +1,11 @@
 2015-11-13  Matthew Hanson  
 
-Rollout r192501. rdar://problem/22846841
+Rollout r192479. rdar://problem/22846841
 
-2015-11-16  Matthew Hanson  
+2015-11-13  Matthew Hanson  
 
-Merge r192138. rdar://problem/22846841
+Rollout r192501. rdar://problem/22846841
 
-2015-11-07  Simon Fraser  
-
-Use ColorSpaceSRGB for image buffers everywhere
-https://bugs.webkit.org/show_bug.cgi?id=150990
-
-Reviewed by Zalan Bujtas.
-
-ColorSpaceSRGB and ColorSpaceDeviceRGB are equivalent now, so convert
-code that creates image buffers tagged with ColorSpaceDeviceRGB to use ColorSpaceSRGB.
-
-* platform/graphics/GraphicsContext.cpp:
-(WebCore::GraphicsContext::createCompatibleBuffer):
-* platform/graphics/ImageBuffer.h:
-(WebCore::ImageBuffer::create):
-* platform/graphics/cg/BitmapImageCG.cpp:
-(WebCore::BitmapImage::checkForSolidColor):
-* platform/graphics/cg/ColorCG.cpp:
-(WebCore::Color::Color):
-* platform/graphics/cg/GraphicsContextCG.cpp:
-(WebCore::sRGBColorSpaceRef): Deleted.
-* platform/graphics/cg/ImageBufferCG.cpp:
-(WebCore::ImageBuffer::putByteArray):
-* platform/graphics/cocoa/IOSurface.mm:
-(IOSurface::createFromImage):
-* platform/graphics/filters/FEFlood.h:
-* platform/graphics/filters/FETile.cpp:
-(WebCore::FETile::platformApplySoftware):
-* platform/graphics/filters/FilterEffect.cpp:
-(WebCore::FilterEffect::FilterEffect):
-* platform/graphics/filters/SourceGraphic.h:
-(WebCore::SourceGraphic::SourceGraphic):
-* rendering/FilterEffectRenderer.cpp:
-(WebCore::FilterEffectRenderer::build):
-(WebCore::FilterEffectRenderer::apply):
-* rendering/RenderThemeMac.mm:
-(WebCore::RenderThemeMac::paintProgressBar):
-* rendering/svg/RenderSVGResourceClipper.cpp:
-(WebCore::RenderSVGResourceClipper::applyClippingToContext):
-* rendering/svg/RenderSVGResourceFilter.cpp:
-(WebCore::RenderSVGResourceFilter::buildPrimitives):
-* rendering/svg/RenderSVGResourceGradient.cpp:
-

[webkit-changes] [192545] trunk/LayoutTests

[ryanhaddad]

Title: [192545] trunk/LayoutTests








Revision 192545
Author ryanhad...@apple.com
Date 2015-11-17 15:15:31 -0800 (Tue, 17 Nov 2015)


Log Message
Marking storage/indexeddb/modern/get-index-failures.html as flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=151364

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (192544 => 192545)

--- trunk/LayoutTests/ChangeLog	2015-11-17 23:10:14 UTC (rev 192544)
+++ trunk/LayoutTests/ChangeLog	2015-11-17 23:15:31 UTC (rev 192545)
@@ -1,3 +1,12 @@
+2015-11-17  Ryan Haddad  
+
+Marking storage/indexeddb/modern/get-index-failures.html as flaky on mac-wk1
+https://bugs.webkit.org/show_bug.cgi?id=151364
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2015-11-17  Brady Eidson  
 
 Modern IDB: Support IDBObjectStore.indexNames.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192544 => 192545)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-11-17 23:10:14 UTC (rev 192544)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-11-17 23:15:31 UTC (rev 192545)
@@ -145,6 +145,8 @@
 
 webkit.org/b/151219 storage/indexeddb/modern/idbindex-properties-basic.html [ Pass Timeout ]
 
+webkit.org/b/151364 storage/indexeddb/modern/get-index-failures.html [ Pass Timeout ]
+
 ### END OF (2) Failures without bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192546] trunk/Source/JavaScriptCore

[benjamin]

Title: [192546] trunk/Source/_javascript_Core








Revision 192546
Author benja...@webkit.org
Date 2015-11-17 15:44:01 -0800 (Tue, 17 Nov 2015)


Log Message
[JSC] Add an empty FTLOutput for B3 that crashes on any operation
https://bugs.webkit.org/show_bug.cgi?id=151366

Patch by Benjamin Poulain  on 2015-11-17
Reviewed by Filip Pizlo.

* _javascript_Core.xcodeproj/project.pbxproj:
* ftl/B3Output.h: Added.
* ftl/FTLAbbreviatedTypes.h:
* ftl/FTLAbstractHeap.cpp:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::createPhiVariables):
* ftl/FTLOutput.cpp:
* ftl/FTLOutput.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/ftl/FTLAbbreviatedTypes.h
trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
trunk/Source/_javascript_Core/ftl/FTLOutput.cpp
trunk/Source/_javascript_Core/ftl/FTLOutput.h


Added Paths

trunk/Source/_javascript_Core/ftl/FTLB3Output.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192545 => 192546)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 23:15:31 UTC (rev 192545)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 23:44:01 UTC (rev 192546)
@@ -1,5 +1,21 @@
 2015-11-17  Benjamin Poulain  
 
+[JSC] Add an empty FTLOutput for B3 that crashes on any operation
+https://bugs.webkit.org/show_bug.cgi?id=151366
+
+Reviewed by Filip Pizlo.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* ftl/B3Output.h: Added.
+* ftl/FTLAbbreviatedTypes.h:
+* ftl/FTLAbstractHeap.cpp:
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::createPhiVariables):
+* ftl/FTLOutput.cpp:
+* ftl/FTLOutput.h:
+
+2015-11-17  Benjamin Poulain  
+
 [JSC] Do not copy the adjacency list when we just need to manipulate them
 https://bugs.webkit.org/show_bug.cgi?id=151343
 


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (192545 => 192546)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2015-11-17 23:15:31 UTC (rev 192545)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2015-11-17 23:44:01 UTC (rev 192546)
@@ -1083,6 +1083,7 @@
 		2600B5A7152BAAA70091EE5F /* JSStringJoiner.h in Headers */ = {isa = PBXBuildFile; fileRef = 2600B5A5152BAAA70091EE5F /* JSStringJoiner.h */; };
 		26718BA41BE99F780052017B /* AirIteratedRegisterCoalescing.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26718BA21BE99F780052017B /* AirIteratedRegisterCoalescing.cpp */; };
 		26718BA51BE99F780052017B /* AirIteratedRegisterCoalescing.h in Headers */ = {isa = PBXBuildFile; fileRef = 26718BA31BE99F780052017B /* AirIteratedRegisterCoalescing.h */; };
+		269D636E1BFBE5D100101B1D /* FTLB3Output.h in Headers */ = {isa = PBXBuildFile; fileRef = 269D636D1BFBE5D000101B1D /* FTLB3Output.h */; };
 		2A05ABD51961DF2400341750 /* JSPropertyNameEnumerator.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2A05ABD31961DF2400341750 /* JSPropertyNameEnumerator.cpp */; };
 		2A05ABD61961DF2400341750 /* JSPropertyNameEnumerator.h in Headers */ = {isa = PBXBuildFile; fileRef = 2A05ABD41961DF2400341750 /* JSPropertyNameEnumerator.h */; };
 		2A111245192FCE79005EE18D /* CustomGetterSetter.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2A111243192FCE79005EE18D /* CustomGetterSetter.cpp */; };
@@ -3103,6 +3104,7 @@
 		264091FA1BE2FD4100684DB2 /* AirOpcode.opcodes */ = {isa = PBXFileReference; lastKnownFileType = text; name = AirOpcode.opcodes; path = b3/air/AirOpcode.opcodes; sourceTree = ""; };
 		26718BA21BE99F780052017B /* AirIteratedRegisterCoalescing.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = AirIteratedRegisterCoalescing.cpp; path = b3/air/AirIteratedRegisterCoalescing.cpp; sourceTree = ""; };
 		26718BA31BE99F780052017B /* AirIteratedRegisterCoalescing.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AirIteratedRegisterCoalescing.h; path = b3/air/AirIteratedRegisterCoalescing.h; sourceTree = ""; };
+		269D636D1BFBE5D000101B1D /* FTLB3Output.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FTLB3Output.h; path = ftl/FTLB3Output.h; sourceTree = ""; };
 		2A05ABD31961DF2400341750 /* JSPropertyNameEnumerator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSPropertyNameEnumerator.cpp; sourceTree = ""; };
 		2A05ABD41961DF2400341750 /* JSPropertyNameEnumerator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSPropertyNameEnumerator.h; sourceTree = ""; };
 		2A111243192FCE79005EE18D /* CustomGetterSetter.cpp */ = {isa = PBXFileReference; fileEncoding = 4; 

[webkit-changes] [192547] trunk/Source/JavaScriptCore

[fpizlo]

Title: [192547] trunk/Source/_javascript_Core








Revision 192547
Author fpi...@apple.com
Date 2015-11-17 16:05:47 -0800 (Tue, 17 Nov 2015)


Log Message
FTL::State should be able to refer to B3::Procedure

Rubber stamped by Benjamin Poulain.

* ftl/FTLState.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLState.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192546 => 192547)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 23:44:01 UTC (rev 192546)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-18 00:05:47 UTC (rev 192547)
@@ -1,3 +1,11 @@
+2015-11-17  Filip Pizlo  
+
+FTL::State should be able to refer to B3::Procedure
+
+Rubber stamped by Benjamin Poulain.
+
+* ftl/FTLState.h:
+
 2015-11-17  Benjamin Poulain  
 
 [JSC] Add an empty FTLOutput for B3 that crashes on any operation


Modified: trunk/Source/_javascript_Core/ftl/FTLState.h (192546 => 192547)

--- trunk/Source/_javascript_Core/ftl/FTLState.h	2015-11-17 23:44:01 UTC (rev 192546)
+++ trunk/Source/_javascript_Core/ftl/FTLState.h	2015-11-18 00:05:47 UTC (rev 192547)
@@ -28,6 +28,7 @@
 
 #if ENABLE(FTL_JIT)
 
+#include "B3Procedure.h"
 #include "DFGCommon.h"
 #include "DFGGraph.h"
 #include "FTLAbbreviations.h"
@@ -64,6 +65,9 @@
 // None of these things is owned by State. It is the responsibility of
 // FTL phases to properly manage the lifecycle of the module and function.
 DFG::Graph& graph;
+#if FTL_USES_B3
+std::unique_ptr proc;
+#endif
 LContext context;
 LModule module;
 LValue function;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192550] trunk/PerformanceTests

[said]

Title: [192550] trunk/PerformanceTests








Revision 192550
Author s...@apple.com
Date 2015-11-17 16:16:56 -0800 (Tue, 17 Nov 2015)


Log Message
Disable flattening the stage iframe of the graphics benchmark when running on iOS
https://bugs.webkit.org/show_bug.cgi?id=151361

Reviewed by Simon Fraser.

Use fixed size for stage iframe of the graphics benchmark to disable
flattening the iframe while animating the particles. Also ensure the
bouncing particles do not go outside the iframe's boundaries.

* Animometer/runner/resources/animometer.css:
(section#running > #running-test > iframe):
(@media screen and (min-device-width: 1800px)):
* Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
(BouncingParticle.prototype.animate):

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/animometer.css
trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.css (192549 => 192550)

--- trunk/PerformanceTests/Animometer/runner/resources/animometer.css	2015-11-18 00:08:38 UTC (rev 192549)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.css	2015-11-18 00:16:56 UTC (rev 192550)
@@ -328,9 +328,10 @@
 }
 
 section#running > #running-test > iframe {
-width: 100%;
-height: 100%;
+width: 800px;
+height: 600px;
 border: 0px none;
+overflow: hidden;
 }
 
 section#running > #progress {
@@ -361,6 +362,13 @@
 padding: 16px;
 }
 
+@media screen and (min-device-width: 1800px) {
+section#running > #running-test > iframe {
+width: 1600px;
+height: 800px;
+}
+}
+
 /* -- */
 /*   Results Section  */
 /* -- */


Modified: trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js (192549 => 192550)

--- trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js	2015-11-18 00:08:38 UTC (rev 192549)
+++ trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js	2015-11-18 00:16:56 UTC (rev 192550)
@@ -23,36 +23,44 @@
 
 // If particle is going to move off right side
 if (this._position.x + this._size.x > this._stageSize.x) {
-// If direction is East-South
+// If direction is East-South, go West-South.
 if (this._angle >= 0 && this._angle < Math.PI / 2)
 this._angle = Math.PI - this._angle;
-// If angle is East-North
+// If angle is East-North, go West-North.
 else if (this._angle > Math.PI / 2 * 3)
 this._angle = this._angle - (this._angle - Math.PI / 2 * 3) * 2;
+// Make sure the particle does not go outside the stage boundaries.
+this._position.x = this._stageSize.x - this._size.x;
 }
 
 // If particle is going to move off left side
 if (this._position.x < 0) {
-// If angle is West-South
+// If angle is West-South, go East-South.
 if (this._angle > Math.PI / 2 && this._angle < Math.PI)
 this._angle = Math.PI - this._angle;
-// If angle is West-North
+// If angle is West-North, go East-North.
 else if (this._angle > Math.PI && this._angle < Math.PI / 2 * 3)
 this._angle = this._angle + (Math.PI / 2 * 3 - this._angle) * 2;
+// Make sure the particle does not go outside the stage boundaries.
+this._position.x = 0;
 }
 
 // If particle is going to move off bottom side
 if (this._position.y + this._size.y > this._stageSize.y) {
-// If direction is South
+// If direction is South, go North.
 if (this._angle > 0 && this._angle < Math.PI)
 this._angle = Math.PI * 2 - this._angle;
+// Make sure the particle does not go outside the stage boundaries.
+this._position.y = this._stageSize.y - this._size.y;
 }
 
 // If particle is going to move off top side
 if (this._position.y < 0) {
-// If direction is North
+// If direction is North, go South.
 if (this._angle > Math.PI && this._angle < Math.PI * 2)
 this._angle = this._angle - (this._angle - Math.PI) * 2;
+// Make sure the particle does not go outside the stage boundaries.
+this._position.y = 0;
 }
 }
 }


Modified: trunk/PerformanceTests/ChangeLog (192549 => 192550)

--- trunk/PerformanceTests/ChangeLog	2015-11-18 00:08:38 UTC (rev 192549)
+++ trunk/PerformanceTests/ChangeLog	2015-11-18 00:16:56 UTC (rev 192550)
@@ -1,5 +1,22 @@
 2015-11-17  

[webkit-changes] [192554] branches/safari-601.1.46-branch/Source/WebKit2

[matthew_hanson]

Title: [192554] branches/safari-601.1.46-branch/Source/WebKit2








Revision 192554
Author matthew_han...@apple.com
Date 2015-11-17 16:27:05 -0800 (Tue, 17 Nov 2015)


Log Message
Rollout r192475. rdar://problem/22846841

Modified Paths

branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h




Diff

Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (192553 => 192554)

--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-11-18 00:27:03 UTC (rev 192553)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-11-18 00:27:05 UTC (rev 192554)
@@ -1,5 +1,9 @@
 2015-11-13  Matthew Hanson  
 
+Rollout r192475. rdar://problem/22846841
+
+2015-11-13  Matthew Hanson  
+
 Rollout r192479. rdar://problem/22846841
 
 2015-11-13  Matthew Hanson  
@@ -39,18 +43,6 @@
 (WebKit::WebPageProxy::processDidBecomeResponsive):  Call navigationClient's processDidBecomeResponsive if the page proxy
 has navigationClient.
 
-2015-11-16  Matthew Hanson  
-
-Merge r189637. rdar://problem/22846841
-
-2015-09-11  Beth Dakin  
-
-Another build fix.
-
-* UIProcess/mac/ViewSnapshotStore.h:
-(WebKit::ViewSnapshot::size):
-(WebKit::ViewSnapshot::imageSizeInBytes):
-
 2015-11-13  Matthew Hanson  
 
 Merge r191872. rdar://problem/23395972


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h (192553 => 192554)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h	2015-11-18 00:27:03 UTC (rev 192553)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h	2015-11-18 00:27:05 UTC (rev 192554)
@@ -83,7 +83,6 @@
 void setSurface(std::unique_ptr);
 #else
 WebCore::IntSize size() const { return m_size; }
-size_t imageSizeInBytes() const { return m_imageSizeInBytes; }
 #endif
 
 private:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192556] branches/safari-601.1.46-branch/Source/WebKit2

[matthew_hanson]

Title: [192556] branches/safari-601.1.46-branch/Source/WebKit2








Revision 192556
Author matthew_han...@apple.com
Date 2015-11-17 16:27:12 -0800 (Tue, 17 Nov 2015)


Log Message
Rollout r192418. rdar://problem/22846841

Modified Paths

branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (192555 => 192556)

--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-11-18 00:27:09 UTC (rev 192555)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-11-18 00:27:12 UTC (rev 192556)
@@ -1,5 +1,9 @@
 2015-11-13  Matthew Hanson  
 
+Rollout r192418. rdar://problem/22846841
+
+2015-11-13  Matthew Hanson  
+
 Rollout r192419. rdar://problem/22846841
 
 2015-11-13  Matthew Hanson  
@@ -82,43 +86,6 @@
 
 2015-11-12  Matthew Hanson  
 
-Merge r189635. rdar://problem/22846841
-
-2015-09-11  Beth Dakin  
-
-Still need view snapshotting code for non-IOSurface for the sim
-https://bugs.webkit.org/show_bug.cgi?id=149077
-
-Reviewed by Tim Horton.
-
-This fixes the simulator build.
-* UIProcess/API/Cocoa/WKWebView.mm:
-(-[WKWebView _takeViewSnapshot]):
-(-[WKWebView _zoomToPoint:atScale:animated:]):
-* UIProcess/mac/ViewGestureControllerMac.mm:
-(WebKit::ViewGestureController::beginSwipeGesture):
-(WebKit::ViewGestureController::removeSwipeSnapshot):
-* UIProcess/mac/ViewSnapshotStore.h:
-(WebKit::ViewSnapshot::setDeviceScaleFactor):
-(WebKit::ViewSnapshot::deviceScaleFactor):
-(WebKit::ViewSnapshot::surface):
-(WebKit::ViewSnapshot::imageSizeInBytes):
-(WebKit::ViewSnapshot::size):
-* UIProcess/mac/ViewSnapshotStore.mm:
-(WebKit::ViewSnapshotStore::singleton):
-(WebKit::ViewSnapshotStore::snapshottingContext):
-(WebKit::ViewSnapshotStore::didAddImageToSnapshot):
-(WebKit::ViewSnapshotStore::discardSnapshotImages):
-(WebKit::ViewSnapshot::create):
-(WebKit::ViewSnapshot::ViewSnapshot):
-(WebKit::ViewSnapshot::~ViewSnapshot):
-(WebKit::ViewSnapshot::setSurface):
-(WebKit::ViewSnapshot::hasImage):
-(WebKit::ViewSnapshot::clearImage):
-(WebKit::ViewSnapshot::asLayerContents):
-
-2015-11-12  Matthew Hanson  
-
 Merge r189628. rdar://problem/22846841
 
 2015-09-11  Beth Dakin  


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (192555 => 192556)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2015-11-18 00:27:09 UTC (rev 192555)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2015-11-18 00:27:12 UTC (rev 192556)
@@ -1109,22 +1109,10 @@
 snapshotSize.scale(deviceScale, deviceScale);
 
 CATransform3D transform = CATransform3DMakeScale(deviceScale, deviceScale, 1);
-
-#if USE(IOSURFACE)
 auto surface = WebCore::IOSurface::create(WebCore::expandedIntSize(snapshotSize), WebCore::ColorSpaceDeviceRGB);
 CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, self.layer.context.contextId, reinterpret_cast(self.layer), surface->surface(), 0, 0, );
 
 return WebKit::ViewSnapshot::create(nullptr);
-#else
-uint32_t slotID = [WebKit::ViewSnapshotStore::snapshottingContext() createImageSlot:snapshotSize hasAlpha:YES];
-
-if (!slotID)
-return nullptr;
-
-CARenderServerCaptureLayerWithTransform(MACH_PORT_NULL, self.layer.context.contextId, (uint64_t)self.layer, slotID, 0, 0, );
-WebCore::IntSize imageSize = WebCore::expandedIntSize(WebCore::FloatSize(snapshotSize));
-return WebKit::ViewSnapshot::create(slotID, imageSize, imageSize.width() * imageSize.height() * 4);
-#endif
 }
 
 - (void)_zoomToPoint:(WebCore::FloatPoint)point atScale:(double)scale animated:(BOOL)animated


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h (192555 => 192556)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h	2015-11-18 00:27:09 UTC (rev 192555)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h	2015-11-18 00:27:12 UTC (rev 192556)
@@ -53,11 +53,7 @@
 
 class ViewSnapshot : public RefCounted {
 public:
-#if USE(IOSURFACE)
 static Ref create(std::unique_ptr);
-#else
-static Ref create(uint32_t slotID, 

[webkit-changes] [192555] branches/safari-601.1.46-branch/Source

[matthew_hanson]

Title: [192555] branches/safari-601.1.46-branch/Source








Revision 192555
Author matthew_han...@apple.com
Date 2015-11-17 16:27:09 -0800 (Tue, 17 Nov 2015)


Log Message
Rollout r192419. rdar://problem/22846841

Modified Paths

branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.h
branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
branches/safari-601.1.46-branch/Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h
branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (192554 => 192555)

--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-11-18 00:27:05 UTC (rev 192554)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2015-11-18 00:27:09 UTC (rev 192555)
@@ -1,5 +1,9 @@
 2015-11-13  Matthew Hanson  
 
+Rollout r192419. rdar://problem/22846841
+
+2015-11-13  Matthew Hanson  
+
 Rollout r192479. rdar://problem/22846841
 
 2015-11-13  Matthew Hanson  
@@ -402,36 +406,6 @@
 (WebCore::WillChangeData::AnimatableFeature::AnimatableFeature):
 (WebCore::WillChangeData::AnimatableFeature::operator==):
 
-2015-11-12  Matthew Hanson  
-
-Merge r190574. rdar://problem/22846841
-
-2015-10-05  Beth Dakin  
-
-Compress snapshots on iOS
-https://bugs.webkit.org/show_bug.cgi?id=149814
--and corresponding-
-rdar://problem/22976230
-
-Reviewed by Simon Fraser.
-
-Though the default is still RGBA, it is now possible to create an IOSurface
-that uses the YUV422 pixel format.
-* platform/graphics/cocoa/IOSurface.h:
-* platform/graphics/cocoa/IOSurface.mm:
-(IOSurface::surfaceFromPool):
-(IOSurface::create):
-(IOSurface::createFromImage):
-(IOSurface::IOSurface):
-(IOSurface::releaseGraphicsContext):
-
-In order to have a YUV IOSurface, we actually have to create an RGBA surface
-first and then convert it to YUV, so this class method will handle that.
-(IOSurface::convertToFormat):
-
-Necessary SPI.
-* platform/spi/cocoa/IOSurfaceSPI.h:
-
 2015-10-29  Lucas Forschler  
 
 Merge r191706. rdar://problem/23319282


Modified: branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.h (192554 => 192555)

--- branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2015-11-18 00:27:05 UTC (rev 192554)
+++ branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2015-11-18 00:27:09 UTC (rev 192555)
@@ -38,14 +38,7 @@
 
 class IOSurface final {
 public:
-enum class Format {
-RGBA,
-#if PLATFORM(IOS)
-YUV422
-#endif
-};
-
-WEBCORE_EXPORT static std::unique_ptr create(IntSize, ColorSpace, Format = Format::RGBA);
+WEBCORE_EXPORT static std::unique_ptr create(IntSize, ColorSpace);
 WEBCORE_EXPORT static std::unique_ptr create(IntSize, IntSize contextSize, ColorSpace);
 WEBCORE_EXPORT static std::unique_ptr createFromSendRight(const MachSendRight&, ColorSpace);
 static std::unique_ptr createFromSurface(IOSurfaceRef, ColorSpace);
@@ -80,7 +73,6 @@
 IntSize size() const { return m_size; }
 size_t totalBytes() const { return m_totalBytes; }
 ColorSpace colorSpace() const { return m_colorSpace; }
-Format format() const { return m_format; }
 
 WEBCORE_EXPORT bool isInUse() const;
 
@@ -88,12 +80,8 @@
 // an accurate result from isInUse(), it needs to be released.
 WEBCORE_EXPORT void releaseGraphicsContext();
 
-#if PLATFORM(IOS)
-WEBCORE_EXPORT static void convertToFormat(std::unique_ptr&& inSurface, Format, std::function);
-#endif
-
 private:
-IOSurface(IntSize, ColorSpace, Format);
+IOSurface(IntSize, ColorSpace);
 IOSurface(IntSize, IntSize contextSize, ColorSpace);
 IOSurface(IOSurfaceRef, ColorSpace);
 
@@ -102,7 +90,6 @@
 void setContextSize(IntSize);
 
 ColorSpace m_colorSpace;
-Format m_format;
 IntSize m_size;
 IntSize m_contextSize;
 size_t m_totalBytes;


Modified: branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm (192554 => 192555)

--- branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm	2015-11-18 00:27:05 UTC (rev 192554)
+++ branches/safari-601.1.46-branch/Source/WebCore/platform/graphics/cocoa/IOSurface.mm	2015-11-18 00:27:09 UTC (rev 192555)
@@ 

[webkit-changes] [192557] branches/safari-601.1.46-branch/Source/WebKit2

[matthew_hanson]

Title: [192557] branches/safari-601.1.46-branch/Source/WebKit2








Revision 192557
Author matthew_han...@apple.com
Date 2015-11-17 16:27:16 -0800 (Tue, 17 Nov 2015)


Log Message
Rollout r192417. rdar://problem/22846841

Modified Paths

branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm




Diff

Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (192556 => 192557)

--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-11-18 00:27:12 UTC (rev 192556)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog	2015-11-18 00:27:16 UTC (rev 192557)
@@ -1,5 +1,9 @@
 2015-11-13  Matthew Hanson  
 
+Rollout r192417. rdar://problem/22846841
+
+2015-11-13  Matthew Hanson  
+
 Rollout r192418. rdar://problem/22846841
 
 2015-11-13  Matthew Hanson  
@@ -84,47 +88,6 @@
 (IPC::ArgumentCoder::encode):
 (IPC::ArgumentCoder::decode):
 
-2015-11-12  Matthew Hanson  
-
-Merge r189628. rdar://problem/22846841
-
-2015-09-11  Beth Dakin  
-
-Should use CARenderServerRenderLayerWithTransform for snapshots on iOS
-https://bugs.webkit.org/show_bug.cgi?id=149069
--and corresponding-
-rdar://problem/19726953
-
-Reviewed by Tim Horton.
-
-This will let us own the backing IOSurface, which will let us share more code
-with Mac.
-
-Use CARenderServerRenderLayerWithTransform
-* UIProcess/API/Cocoa/WKWebView.mm:
-(-[WKWebView _takeViewSnapshot]):
-(-[WKWebView _zoomToPoint:atScale:animated:]):
-
-We can eliminate things needed for the slot-based API.
-* UIProcess/mac/ViewSnapshotStore.h:
-(WebKit::ViewSnapshot::setDeviceScaleFactor):
-(WebKit::ViewSnapshot::deviceScaleFactor):
-(WebKit::ViewSnapshot::surface):
-(WebKit::ViewSnapshot::imageSizeInBytes):
-(WebKit::ViewSnapshot::size):
-* UIProcess/mac/ViewSnapshotStore.mm:
-(WebKit::ViewSnapshotStore::singleton):
-(WebKit::ViewSnapshotStore::didAddImageToSnapshot):
-(WebKit::ViewSnapshotStore::discardSnapshotImages):
-(WebKit::ViewSnapshot::create):
-(WebKit::ViewSnapshot::ViewSnapshot):
-(WebKit::ViewSnapshot::~ViewSnapshot):
-(WebKit::ViewSnapshot::setSurface):
-(WebKit::ViewSnapshot::hasImage):
-(WebKit::ViewSnapshot::clearImage):
-(WebKit::ViewSnapshot::asLayerContents):
-(WebKit::ViewSnapshotStore::snapshottingContext): Deleted.
-
 2015-11-06  Babak Shafiei  
 
 Merge r189753.


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (192556 => 192557)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2015-11-18 00:27:12 UTC (rev 192556)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2015-11-18 00:27:16 UTC (rev 192557)
@@ -1105,14 +1105,20 @@
 - (PassRefPtr)_takeViewSnapshot
 {
 float deviceScale = WKGetScreenScaleFactor();
-WebCore::FloatSize snapshotSize(self.bounds.size);
-snapshotSize.scale(deviceScale, deviceScale);
+CGSize snapshotSize = self.bounds.size;
+snapshotSize.width *= deviceScale;
+snapshotSize.height *= deviceScale;
 
+uint32_t slotID = [WebKit::ViewSnapshotStore::snapshottingContext() createImageSlot:snapshotSize hasAlpha:YES];
+
+if (!slotID)
+return nullptr;
+
 CATransform3D transform = CATransform3DMakeScale(deviceScale, deviceScale, 1);
-auto surface = WebCore::IOSurface::create(WebCore::expandedIntSize(snapshotSize), WebCore::ColorSpaceDeviceRGB);
-CARenderServerRenderLayerWithTransform(MACH_PORT_NULL, self.layer.context.contextId, reinterpret_cast(self.layer), surface->surface(), 0, 0, );
+CARenderServerCaptureLayerWithTransform(MACH_PORT_NULL, self.layer.context.contextId, (uint64_t)self.layer, slotID, 0, 0, );
 
-return WebKit::ViewSnapshot::create(nullptr);
+WebCore::IntSize imageSize = WebCore::expandedIntSize(WebCore::FloatSize(snapshotSize));
+return WebKit::ViewSnapshot::create(slotID, imageSize, imageSize.width() * imageSize.height() * 4);
 }
 
 - (void)_zoomToPoint:(WebCore::FloatPoint)point atScale:(double)scale animated:(BOOL)animated


Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h (192556 => 192557)

--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/mac/ViewSnapshotStore.h	2015-11-18 00:27:12 

[webkit-changes] [192543] trunk/Source/JavaScriptCore

[commit-queue]

Title: [192543] trunk/Source/_javascript_Core








Revision 192543
Author commit-qu...@webkit.org
Date 2015-11-17 14:48:19 -0800 (Tue, 17 Nov 2015)


Log Message
[JSC] Remove FTLOutput operations that act directly on floats
https://bugs.webkit.org/show_bug.cgi?id=151342

Patch by Benjamin Poulain  on 2015-11-17
Reviewed by Geoffrey Garen.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithFRound):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutByVal):
* ftl/FTLOutput.cpp:
(JSC::FTL::Output::store):
* ftl/FTLOutput.h:
(JSC::FTL::Output::loadFloatToDouble):
(JSC::FTL::Output::fround):
(JSC::FTL::Output::loadFloat): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp
trunk/Source/_javascript_Core/ftl/FTLOutput.cpp
trunk/Source/_javascript_Core/ftl/FTLOutput.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192542 => 192543)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:46:53 UTC (rev 192542)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:48:19 UTC (rev 192543)
@@ -1,3 +1,21 @@
+2015-11-17  Benjamin Poulain  
+
+[JSC] Remove FTLOutput operations that act directly on floats
+https://bugs.webkit.org/show_bug.cgi?id=151342
+
+Reviewed by Geoffrey Garen.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::compileArithFRound):
+(JSC::FTL::DFG::LowerDFGToLLVM::compileGetByVal):
+(JSC::FTL::DFG::LowerDFGToLLVM::compilePutByVal):
+* ftl/FTLOutput.cpp:
+(JSC::FTL::Output::store):
+* ftl/FTLOutput.h:
+(JSC::FTL::Output::loadFloatToDouble):
+(JSC::FTL::Output::fround):
+(JSC::FTL::Output::loadFloat): Deleted.
+
 2015-11-17  Filip Pizlo  
 
 Add a FTL_USES_B3 compile-time setting and set it to 0.


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (192542 => 192543)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-11-17 22:46:53 UTC (rev 192542)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-11-17 22:48:19 UTC (rev 192543)
@@ -2035,8 +2035,7 @@
 
 void compileArithFRound()
 {
-LValue floatValue = m_out.fpCast(lowDouble(m_node->child1()), m_out.floatType);
-setDouble(m_out.fpCast(floatValue, m_out.doubleType));
+setDouble(m_out.fround(lowDouble(m_node->child1(;
 }
 
 void compileArithNegate()
@@ -2789,7 +2788,7 @@
 LValue result;
 switch (type) {
 case TypeFloat32:
-result = m_out.fpCast(m_out.loadFloat(pointer), m_out.doubleType);
+result = m_out.loadFloatToDouble(pointer);
 break;
 case TypeFloat64:
 result = m_out.loadDouble(pointer);
@@ -3062,7 +3061,7 @@
 LValue value = lowDouble(child3);
 switch (type) {
 case TypeFloat32:
-valueToStore = m_out.fpCast(value, m_out.floatType);
+valueToStore = value;
 refType = m_out.refFloat;
 break;
 case TypeFloat64:


Modified: trunk/Source/_javascript_Core/ftl/FTLOutput.cpp (192542 => 192543)

--- trunk/Source/_javascript_Core/ftl/FTLOutput.cpp	2015-11-17 22:46:53 UTC (rev 192542)
+++ trunk/Source/_javascript_Core/ftl/FTLOutput.cpp	2015-11-17 22:48:19 UTC (rev 192543)
@@ -91,6 +91,8 @@
 
 void Output::store(LValue value, TypedPointer pointer, LType refType)
 {
+if (refType == refFloat)
+value = buildFPCast(m_builder, value, floatType);
 LValue result = set(value, intToPtr(pointer.value(), refType));
 pointer.heap().decorateInstruction(result, *m_heaps);
 }


Modified: trunk/Source/_javascript_Core/ftl/FTLOutput.h (192542 => 192543)

--- trunk/Source/_javascript_Core/ftl/FTLOutput.h	2015-11-17 22:46:53 UTC (rev 192542)
+++ trunk/Source/_javascript_Core/ftl/FTLOutput.h	2015-11-17 22:48:19 UTC (rev 192543)
@@ -224,6 +224,8 @@
 LValue intToPtr(LValue value, LType type) { return buildIntToPtr(m_builder, value, type); }
 LValue ptrToInt(LValue value, LType type) { return buildPtrToInt(m_builder, value, type); }
 LValue bitCast(LValue value, LType type) { return buildBitCast(m_builder, value, type); }
+
+LValue fround(LValue doubleValue);
 
 // Hilariously, the #define machinery in the stdlib means that this method is actually called
 // __builtin_alloca. So far this appears benign. :-|
@@ -249,7 +251,7 @@
 LValue load32(TypedPointer pointer) { return load(pointer, ref32); }
 LValue load64(TypedPointer pointer) { return load(pointer, ref64); }
 LValue loadPtr(TypedPointer pointer) { return load(pointer, refPtr); }
-LValue loadFloat(TypedPointer pointer) { 

[webkit-changes] [192548] trunk/Source/JavaScriptCore/ChangeLog

[fpizlo]

Title: [192548] trunk/Source/_javascript_Core/ChangeLog








Revision 192548
Author fpi...@apple.com
Date 2015-11-17 16:07:34 -0800 (Tue, 17 Nov 2015)


Log Message
Unreviewed, fix a ChangeLog entry to have the right filename.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192547 => 192548)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-18 00:05:47 UTC (rev 192547)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-18 00:07:34 UTC (rev 192548)
@@ -14,7 +14,7 @@
 Reviewed by Filip Pizlo.
 
 * _javascript_Core.xcodeproj/project.pbxproj:
-* ftl/B3Output.h: Added.
+* ftl/FTLB3Output.h: Added.
 * ftl/FTLAbbreviatedTypes.h:
 * ftl/FTLAbstractHeap.cpp:
 * ftl/FTLLowerDFGToLLVM.cpp:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192517] trunk/Websites/bugs.webkit.org

[lforschler]

Title: [192517] trunk/Websites/bugs.webkit.org








Revision 192517
Author lforsch...@apple.com
Date 2015-11-17 11:30:14 -0800 (Tue, 17 Nov 2015)


Log Message
Commit working changes from build.webkit.org

Modified Paths

trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm
trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/data/params
trunk/Websites/bugs.webkit.org/jobqueue.pl




Diff

Modified: trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm (192516 => 192517)

--- trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm	2015-11-17 19:11:22 UTC (rev 192516)
+++ trunk/Websites/bugs.webkit.org/Bugzilla/Util.pm	2015-11-17 19:30:14 UTC (rev 192517)
@@ -654,12 +654,17 @@
 sub validate_email_syntax {
 my ($addr) = @_;
 my $match = Bugzilla->params->{'emailregexp'};
-my $ret = ($addr =~ /$match/ && $addr !~ /[\\\(\)<>&,;:"\[\] \t\r\n\P{ASCII}]/);
-if ($ret) {
+# We set the max length to 127 to ensure addresses aren't truncated when
+# inserted into the tokens.eventdata field.
+if ($addr =~ /$match/
+&& $addr !~ /[\\\(\)<>&,;:"\[\] \t\r\n\P{ASCII}]/
+&& length($addr) <= 127)
+{
 # We assume these checks to suffice to consider the address untainted.
 trick_taint($_[0]);
+return 1;
 }
-return $ret ? 1 : 0;
+return 0;
 }
 
 sub validate_date {


Modified: trunk/Websites/bugs.webkit.org/ChangeLog (192516 => 192517)

--- trunk/Websites/bugs.webkit.org/ChangeLog	2015-11-17 19:11:22 UTC (rev 192516)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2015-11-17 19:30:14 UTC (rev 192517)
@@ -1,3 +1,10 @@
+2015-11-17  Lucas Forschler  
+
+bugs.webkit.org is running with changes that are not checked in.
+Check them in.
+
+Reviewed by Matt Hanson.
+ 
 2015-07-30  Aakash Jain  
 
 Replace Google App Engine with AppScale


Modified: trunk/Websites/bugs.webkit.org/data/params (192516 => 192517)

--- trunk/Websites/bugs.webkit.org/data/params	2015-11-17 19:11:22 UTC (rev 192516)
+++ trunk/Websites/bugs.webkit.org/data/params	2015-11-17 19:30:14 UTC (rev 192517)
@@ -85,7 +85,7 @@
'timetrackinggroup' => '',
'upgrade_notification' => 'latest_stable_release',
'urlbase' => 'https://bugs.webkit.org/',
-   'use_mailer_queue' => 0,
+   'use_mailer_queue' => '1',
'use_see_also' => 1,
'usebugaliases' => '1',
'useclassification' => 0,


Modified: trunk/Websites/bugs.webkit.org/jobqueue.pl (192516 => 192517)

--- trunk/Websites/bugs.webkit.org/jobqueue.pl	2015-11-17 19:11:22 UTC (rev 192516)
+++ trunk/Websites/bugs.webkit.org/jobqueue.pl	2015-11-17 19:30:14 UTC (rev 192517)
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl -w
+#!/usr/bin/perl
 # -*- Mode: perl; indent-tabs-mode: nil -*-
 #
 # The contents of this file are subject to the Mozilla Public






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192523] branches/safari-601-branch/Source/WebInspectorUI

[bshafiei]

Title: [192523] branches/safari-601-branch/Source/WebInspectorUI








Revision 192523
Author bshaf...@apple.com
Date 2015-11-17 12:23:02 -0800 (Tue, 17 Nov 2015)


Log Message
Merged r192172.  rdar://problem/23488498

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TabBar.css




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (192522 => 192523)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-11-17 20:21:50 UTC (rev 192522)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-11-17 20:23:02 UTC (rev 192523)
@@ -1,5 +1,19 @@
 2015-11-17  Babak Shafiei  
 
+Merge r192172.
+
+2015-11-09  Nikita Vasilyev  
+
+Web Inspector: [Regression] [Mavericks] Top border of selected tab matches the background when Web Inspector is undocked
+https://bugs.webkit.org/show_bug.cgi?id=150981
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TabBar.css:
+(body.mavericks .tab-bar > .item:not(.disabled).selected): Added.
+
+2015-11-17  Babak Shafiei  
+
 Merge r192134.
 
 2015-11-07  Nikita Vasilyev  


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TabBar.css (192522 => 192523)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2015-11-17 20:21:50 UTC (rev 192522)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/TabBar.css	2015-11-17 20:23:02 UTC (rev 192523)
@@ -113,6 +113,10 @@
 background-size: 100% 100%;
 }
 
+body.mavericks .tab-bar > .item:not(.disabled).selected {
+border-top-color: hsl(0, 0%, 68%);
+}
+
 .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover,
 .tab-bar > .item.new-tab-button:not(.disabled):hover {
 background-position: 0 100%;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192525] trunk/Source/JavaScriptCore

[sbarati]

Title: [192525] trunk/Source/_javascript_Core








Revision 192525
Author sbar...@apple.com
Date 2015-11-17 12:52:26 -0800 (Tue, 17 Nov 2015)


Log Message
FTLLazySlowPaths should be able to handle being passed the zero register as a location
https://bugs.webkit.org/show_bug.cgi?id=151193

Reviewed by Geoffrey Garen.

On arm64, SP and ZR are the same register number. The meaning
of the register number being SP or ZR is dependent on context of
the instruction and the register within the instruction. LLVM may
prove that a value is zero, or sometimes, we will lower a
value as a constant zero (for example, we might compile
CreateDirectArguments of an inlined call frame and we might know
that the arguments have a length of zero). LazySlowPaths should
be able to gracefully handle being passed a stackmap location
with a gpr value of SP by moving zero into another register
and replacing the location's register with the new register.
This way, no lazy slow path will ever have access to a location with a GPR
value of SP.  This patch makes this work by using a scratch register
allocator when we need to do this maneuver of moving zero into a scratch
register.  Inside FTLCompile, we track if we need to move zero into a register,
and if so, into which register. We actually emit the necessary
instructions to move zero into this register, and to spill reused
registers if necessary, while generating the code for the lazy slow
path itself.

* ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
* ftl/FTLDWARFRegister.cpp:
(JSC::FTL::DWARFRegister::reg):
* ftl/FTLLazySlowPath.cpp:
(JSC::FTL::LazySlowPath::LazySlowPath):
(JSC::FTL::LazySlowPath::generate):
* ftl/FTLLazySlowPath.h:
(JSC::FTL::LazySlowPath::createGenerator):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLCompile.cpp
trunk/Source/_javascript_Core/ftl/FTLDWARFRegister.cpp
trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.cpp
trunk/Source/_javascript_Core/ftl/FTLLazySlowPath.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192524 => 192525)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 20:24:12 UTC (rev 192524)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 20:52:26 UTC (rev 192525)
@@ -1,3 +1,39 @@
+2015-11-17  Saam barati  
+
+FTLLazySlowPaths should be able to handle being passed the zero register as a location
+https://bugs.webkit.org/show_bug.cgi?id=151193
+
+Reviewed by Geoffrey Garen.
+
+On arm64, SP and ZR are the same register number. The meaning
+of the register number being SP or ZR is dependent on context of
+the instruction and the register within the instruction. LLVM may
+prove that a value is zero, or sometimes, we will lower a
+value as a constant zero (for example, we might compile
+CreateDirectArguments of an inlined call frame and we might know
+that the arguments have a length of zero). LazySlowPaths should
+be able to gracefully handle being passed a stackmap location
+with a gpr value of SP by moving zero into another register
+and replacing the location's register with the new register.
+This way, no lazy slow path will ever have access to a location with a GPR
+value of SP.  This patch makes this work by using a scratch register 
+allocator when we need to do this maneuver of moving zero into a scratch
+register.  Inside FTLCompile, we track if we need to move zero into a register,
+and if so, into which register. We actually emit the necessary
+instructions to move zero into this register, and to spill reused
+registers if necessary, while generating the code for the lazy slow
+path itself.
+
+* ftl/FTLCompile.cpp:
+(JSC::FTL::mmAllocateDataSection):
+* ftl/FTLDWARFRegister.cpp:
+(JSC::FTL::DWARFRegister::reg):
+* ftl/FTLLazySlowPath.cpp:
+(JSC::FTL::LazySlowPath::LazySlowPath):
+(JSC::FTL::LazySlowPath::generate):
+* ftl/FTLLazySlowPath.h:
+(JSC::FTL::LazySlowPath::createGenerator):
+
 2015-11-17  Mark Lam  
 
 [JSC] Support Doubles with B3's Mul.


Modified: trunk/Source/_javascript_Core/ftl/FTLCompile.cpp (192524 => 192525)

--- trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2015-11-17 20:24:12 UTC (rev 192524)
+++ trunk/Source/_javascript_Core/ftl/FTLCompile.cpp	2015-11-17 20:52:26 UTC (rev 192525)
@@ -922,10 +922,6 @@
 for (unsigned i = 0; i < iter->value.size(); ++i) {
 StackMaps::Record& record = iter->value[i].record;
 RegisterSet usedRegisters = usedRegistersFor(record);
-Vector locations;
-for (auto location : record.locations)
-locations.append(Location::forStackmaps(, location));
-
 char* startOfIC =
 

[webkit-changes] [192524] trunk/Source/JavaScriptCore

[mark . lam]

Title: [192524] trunk/Source/_javascript_Core








Revision 192524
Author mark@apple.com
Date 2015-11-17 12:24:12 -0800 (Tue, 17 Nov 2015)


Log Message
[JSC] Support Doubles with B3's Mul.
https://bugs.webkit.org/show_bug.cgi?id=151355

Reviewed by Filip Pizlo.

* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
* b3/air/AirOpcode.opcodes:
* b3/testb3.cpp:
(JSC::B3::testMulLoadTwice):
(JSC::B3::testMulArgDouble):
(JSC::B3::testMulArgsDouble):
(JSC::B3::testMulArgImmDouble):
(JSC::B3::testMulImmArgDouble):
(JSC::B3::testMulImmsDouble):
(JSC::B3::testDivArgDouble):
(JSC::B3::run):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/_javascript_Core/b3/testb3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192523 => 192524)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 20:23:02 UTC (rev 192523)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 20:24:12 UTC (rev 192524)
@@ -1,3 +1,23 @@
+2015-11-17  Mark Lam  
+
+[JSC] Support Doubles with B3's Mul.
+https://bugs.webkit.org/show_bug.cgi?id=151355
+
+Reviewed by Filip Pizlo.
+
+* b3/B3LowerToAir.cpp:
+(JSC::B3::Air::LowerToAir::lower):
+* b3/air/AirOpcode.opcodes:
+* b3/testb3.cpp:
+(JSC::B3::testMulLoadTwice):
+(JSC::B3::testMulArgDouble):
+(JSC::B3::testMulArgsDouble):
+(JSC::B3::testMulArgImmDouble):
+(JSC::B3::testMulImmArgDouble):
+(JSC::B3::testMulImmsDouble):
+(JSC::B3::testDivArgDouble):
+(JSC::B3::run):
+
 2015-11-17  Matthew Daiter  
 
 Removed useless variable scriptResult from testExecutionTimeLimit


Modified: trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp (192523 => 192524)

--- trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp	2015-11-17 20:23:02 UTC (rev 192523)
+++ trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp	2015-11-17 20:24:12 UTC (rev 192524)
@@ -1260,7 +1260,7 @@
 }
 
 case Mul: {
-appendBinOp(
+appendBinOp(
 m_value->child(0), m_value->child(1));
 return;
 }


Modified: trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes (192523 => 192524)

--- trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes	2015-11-17 20:23:02 UTC (rev 192523)
+++ trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes	2015-11-17 20:24:12 UTC (rev 192524)
@@ -114,6 +114,10 @@
 Mul64 U:G, UD:G
 Tmp, Tmp
 
+MulDouble U:F, UD:F
+Tmp, Tmp
+Addr, Tmp
+
 DivDouble U:F, UD:F
 Tmp, Tmp
 Addr, Tmp


Modified: trunk/Source/_javascript_Core/b3/testb3.cpp (192523 => 192524)

--- trunk/Source/_javascript_Core/b3/testb3.cpp	2015-11-17 20:23:02 UTC (rev 192523)
+++ trunk/Source/_javascript_Core/b3/testb3.cpp	2015-11-17 20:24:12 UTC (rev 192524)
@@ -386,6 +386,70 @@
 test(1);
 }
 
+void testMulArgDouble(double a)
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+Value* value = root->appendNew(proc, Origin(), FPRInfo::argumentFPR0);
+root->appendNew(
+proc, Return, Origin(),
+root->appendNew(proc, Mul, Origin(), value, value));
+
+CHECK(isIdentical(compileAndRun(proc, a), a * a));
+}
+
+void testMulArgsDouble(double a, double b)
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+Value* valueA = root->appendNew(proc, Origin(), FPRInfo::argumentFPR0);
+Value* valueB = root->appendNew(proc, Origin(), FPRInfo::argumentFPR1);
+root->appendNew(
+proc, Return, Origin(),
+root->appendNew(proc, Mul, Origin(), valueA, valueB));
+
+CHECK(isIdentical(compileAndRun(proc, a, b), a * b));
+}
+
+void testMulArgImmDouble(double a, double b)
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+Value* valueA = root->appendNew(proc, Origin(), FPRInfo::argumentFPR0);
+Value* valueB = root->appendNew(proc, Origin(), b);
+root->appendNew(
+proc, Return, Origin(),
+root->appendNew(proc, Mul, Origin(), valueA, valueB));
+
+CHECK(isIdentical(compileAndRun(proc, a), a * b));
+}
+
+void testMulImmArgDouble(double a, double b)
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+Value* valueA = root->appendNew(proc, Origin(), a);
+Value* valueB = root->appendNew(proc, Origin(), FPRInfo::argumentFPR0);
+root->appendNew(
+proc, Return, Origin(),
+root->appendNew(proc, Mul, Origin(), valueA, valueB));
+
+CHECK(isIdentical(compileAndRun(proc, b), a * b));
+}
+
+void testMulImmsDouble(double a, double b)
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+Value* valueA = root->appendNew(proc, Origin(), a);
+Value* valueB = root->appendNew(proc, Origin(), b);
+root->appendNew(
+proc, 

[webkit-changes] [192519] trunk/Source/JavaScriptCore

[mark . lam]

Title: [192519] trunk/Source/_javascript_Core








Revision 192519
Author mark@apple.com
Date 2015-11-17 11:41:27 -0800 (Tue, 17 Nov 2015)


Log Message
[JSC] Support Doubles with B3's Sub.
https://bugs.webkit.org/show_bug.cgi?id=151322

Reviewed by Filip Pizlo.

* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
* b3/air/AirOpcode.opcodes:

* b3/testb3.cpp:
(JSC::B3::testSubImmArg32):
(JSC::B3::testSubArgDouble):
(JSC::B3::testSubArgsDouble):
(JSC::B3::testSubArgImmDouble):
(JSC::B3::testSubImmArgDouble):
(JSC::B3::testSubImmsDouble):
(JSC::B3::testBitAndArgs):
(JSC::B3::negativeZero):
(JSC::B3::posInfinity):
(JSC::B3::negInfinity):
(JSC::B3::doubleOperands):
(JSC::B3::run):
- Added RUN_UNARY and RUN_BINARY macros to auto generate permutations
  of operands for the tests.
- Added SubDouble tests using the new macros.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/_javascript_Core/b3/testb3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192518 => 192519)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 19:41:26 UTC (rev 192518)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 19:41:27 UTC (rev 192519)
@@ -1,3 +1,31 @@
+2015-11-16  Mark Lam  
+
+[JSC] Support Doubles with B3's Sub.
+https://bugs.webkit.org/show_bug.cgi?id=151322
+
+Reviewed by Filip Pizlo.
+
+* b3/B3LowerToAir.cpp:
+(JSC::B3::Air::LowerToAir::lower):
+* b3/air/AirOpcode.opcodes:
+
+* b3/testb3.cpp:
+(JSC::B3::testSubImmArg32):
+(JSC::B3::testSubArgDouble):
+(JSC::B3::testSubArgsDouble):
+(JSC::B3::testSubArgImmDouble):
+(JSC::B3::testSubImmArgDouble):
+(JSC::B3::testSubImmsDouble):
+(JSC::B3::testBitAndArgs):
+(JSC::B3::negativeZero):
+(JSC::B3::posInfinity):
+(JSC::B3::negInfinity):
+(JSC::B3::doubleOperands):
+(JSC::B3::run):
+- Added RUN_UNARY and RUN_BINARY macros to auto generate permutations
+  of operands for the tests.
+- Added SubDouble tests using the new macros.
+
 2015-11-17  Benjamin Poulain  
 
 [JSC] IteratedRegisterCoalescingAllocator's freeze can add zombie Tmps to our coloring algorithm


Modified: trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp (192518 => 192519)

--- trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp	2015-11-17 19:41:26 UTC (rev 192518)
+++ trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp	2015-11-17 19:41:27 UTC (rev 192519)
@@ -1255,7 +1255,7 @@
 if (m_value->child(0)->isInt(0))
 appendUnOp(m_value->child(1));
 else
-appendBinOp(m_value->child(0), m_value->child(1));
+appendBinOp(m_value->child(0), m_value->child(1));
 return;
 }
 


Modified: trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes (192518 => 192519)

--- trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes	2015-11-17 19:41:26 UTC (rev 192518)
+++ trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes	2015-11-17 19:41:27 UTC (rev 192519)
@@ -93,6 +93,10 @@
 Tmp, Tmp
 Imm, Tmp
 
+SubDouble U:F, UD:F
+Tmp, Tmp
+Addr, Tmp
+
 Neg32 UD:G
 Tmp
 Addr


Modified: trunk/Source/_javascript_Core/b3/testb3.cpp (192518 => 192519)

--- trunk/Source/_javascript_Core/b3/testb3.cpp	2015-11-17 19:41:26 UTC (rev 192518)
+++ trunk/Source/_javascript_Core/b3/testb3.cpp	2015-11-17 19:41:27 UTC (rev 192519)
@@ -42,8 +42,10 @@
 #include "InitializeThreading.h"
 #include "JSCInlines.h"
 #include "LinkBuffer.h"
+#include "PureNaN.h"
 #include "VM.h"
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -552,6 +554,70 @@
 CHECK(compileAndRun(proc, b) == a - b);
 }
 
+void testSubArgDouble(double a)
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+Value* value = root->appendNew(proc, Origin(), FPRInfo::argumentFPR0);
+root->appendNew(
+proc, Return, Origin(),
+root->appendNew(proc, Sub, Origin(), value, value));
+
+CHECK(isIdentical(compileAndRun(proc, a), a - a));
+}
+
+void testSubArgsDouble(double a, double b)
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+Value* valueA = root->appendNew(proc, Origin(), FPRInfo::argumentFPR0);
+Value* valueB = root->appendNew(proc, Origin(), FPRInfo::argumentFPR1);
+root->appendNew(
+proc, Return, Origin(),
+root->appendNew(proc, Sub, Origin(), valueA, valueB));
+
+CHECK(isIdentical(compileAndRun(proc, a, b), a - b));
+}
+
+void testSubArgImmDouble(double a, double b)
+{
+Procedure proc;
+BasicBlock* root = proc.addBlock();
+Value* valueA = root->appendNew(proc, Origin(), FPRInfo::argumentFPR0);
+Value* valueB = 

[webkit-changes] [192521] branches/safari-601-branch/Source

[bshafiei]

Title: [192521] branches/safari-601-branch/Source








Revision 192521
Author bshaf...@apple.com
Date 2015-11-17 12:00:40 -0800 (Tue, 17 Nov 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig (192520 => 192521)

--- branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-11-17 19:56:01 UTC (rev 192520)
+++ branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-11-17 20:00:40 UTC (rev 192521)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 601;
-MINOR_VERSION = 3;
-TINY_VERSION = 10;
+MINOR_VERSION = 4;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig (192520 => 192521)

--- branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2015-11-17 19:56:01 UTC (rev 192520)
+++ branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2015-11-17 20:00:40 UTC (rev 192521)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 601;
-MINOR_VERSION = 3;
-TINY_VERSION = 10;
+MINOR_VERSION = 4;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (192520 => 192521)

--- branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-11-17 19:56:01 UTC (rev 192520)
+++ branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-11-17 20:00:40 UTC (rev 192521)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
-MINOR_VERSION = 3;
-TINY_VERSION = 10;
+MINOR_VERSION = 4;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig (192520 => 192521)

--- branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-11-17 19:56:01 UTC (rev 192520)
+++ branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-11-17 20:00:40 UTC (rev 192521)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 601;
-MINOR_VERSION = 3;
-TINY_VERSION = 10;
+MINOR_VERSION = 4;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig (192520 => 192521)

--- branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-11-17 19:56:01 UTC (rev 192520)
+++ branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-11-17 20:00:40 UTC (rev 192521)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 601;
-MINOR_VERSION = 3;
-TINY_VERSION = 10;
+MINOR_VERSION = 4;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192522] branches/safari-601-branch/Source/WebInspectorUI

[bshafiei]

Title: [192522] branches/safari-601-branch/Source/WebInspectorUI








Revision 192522
Author bshaf...@apple.com
Date 2015-11-17 12:21:50 -0800 (Tue, 17 Nov 2015)


Log Message
Merged r192134.  rdar://problem/23488495

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (192521 => 192522)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-11-17 20:00:40 UTC (rev 192521)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2015-11-17 20:21:50 UTC (rev 192522)
@@ -1,3 +1,21 @@
+2015-11-17  Babak Shafiei  
+
+Merge r192134.
+
+2015-11-07  Nikita Vasilyev  
+
+Web Inspector: [Regression] [Mavericks] Toolbar is too dark while docked
+https://bugs.webkit.org/show_bug.cgi?id=150977
+
+Set the toolbar color of the docked inspector to be the same as on OS X 10.10+.
+Undocked toolbar color on Mavericks is unnaffected.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/Toolbar.css:
+(body.mavericks.docked .toolbar):
+(body:not(.mavericks) .toolbar): Added.
+
 2015-10-19  Matthew Hanson  
 
 Merge r190437. rdar://problem/23166302


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (192521 => 192522)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-11-17 20:00:40 UTC (rev 192521)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-11-17 20:21:50 UTC (rev 192522)
@@ -36,7 +36,8 @@
 height: 36px;
 }
 
-body:not(.mavericks) .toolbar {
+body:not(.mavericks) .toolbar,
+body.mavericks.docked .toolbar {
 background-image: linear-gradient(to bottom, hsl(0, 0%, 92%), hsl(0, 0%, 87%));
 box-shadow: inset hsla(0, 0%, 100%, 0.5) 0 1px 1px;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192516] trunk/Source/JavaScriptCore

[commit-queue]

Title: [192516] trunk/Source/_javascript_Core








Revision 192516
Author commit-qu...@webkit.org
Date 2015-11-17 11:11:22 -0800 (Tue, 17 Nov 2015)


Log Message
[JSC] IteratedRegisterCoalescingAllocator's freeze can add zombie Tmps to our coloring algorithm
https://bugs.webkit.org/show_bug.cgi?id=151345

Patch by Benjamin Poulain  on 2015-11-17
Reviewed by Filip Pizlo.

The extended test of https://bugs.webkit.org/show_bug.cgi?id=151214 revealed a problem with
the Move freezing step of the iterated register allocator.

When freezing a move related Tmp, we go over all the move instructions and update the other
Tmp of the move as needed. If that Tmp is no longer Move related and is of low degree it can
be simplified too.

The problem arise when one of those Tmp was already coalesced. For example, say we have

  1: move %tmp42, %tmp43
  2: move %tmp42, %tmp44

The first move cannot be coalesced for some reason and is moved to the Active worklist.
The second move is coalesced and %tmp42 is now %tmp44.

When nothing can be simplified or coalesced, we look at freezing a Move-related Tmp.
Let's say we pick %tmp43. The code of freeze() was going to all the Move instructions
to update them. Here you would find @1 above, get %tmp42 as the other Tmp. Since %tmp42
is no longer move related, it is added to the simplify work list.
-> We just added a coalesced Tmp to our worklist!

To fix that, I get the alias of every other Tmp before updating its status.

There is still a problem: multiple Moves instructions may have been coalesced to the same
Tmp. We must not add a Tmp twice to a worklist.
To avoid duplicates, I rely on the fact that the freeze worklist should not contains
aliased Tmps. Before adding something to the simplify worklist, I check that it was
in the freeze worklist.

I cannot find how this problem would have been avoided in the original paper. I suspect
that may have been a bug in the pseudo-code.

* b3/air/AirIteratedRegisterCoalescing.cpp:
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::freeze):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::freezeMoves):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192515 => 192516)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 19:05:29 UTC (rev 192515)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 19:11:22 UTC (rev 192516)
@@ -1,3 +1,46 @@
+2015-11-17  Benjamin Poulain  
+
+[JSC] IteratedRegisterCoalescingAllocator's freeze can add zombie Tmps to our coloring algorithm
+https://bugs.webkit.org/show_bug.cgi?id=151345
+
+Reviewed by Filip Pizlo.
+
+The extended test of https://bugs.webkit.org/show_bug.cgi?id=151214 revealed a problem with
+the Move freezing step of the iterated register allocator.
+
+When freezing a move related Tmp, we go over all the move instructions and update the other
+Tmp of the move as needed. If that Tmp is no longer Move related and is of low degree it can
+be simplified too.
+
+The problem arise when one of those Tmp was already coalesced. For example, say we have
+
+  1: move %tmp42, %tmp43
+  2: move %tmp42, %tmp44
+
+The first move cannot be coalesced for some reason and is moved to the Active worklist.
+The second move is coalesced and %tmp42 is now %tmp44.
+
+When nothing can be simplified or coalesced, we look at freezing a Move-related Tmp.
+Let's say we pick %tmp43. The code of freeze() was going to all the Move instructions
+to update them. Here you would find @1 above, get %tmp42 as the other Tmp. Since %tmp42
+is no longer move related, it is added to the simplify work list.
+-> We just added a coalesced Tmp to our worklist!
+
+To fix that, I get the alias of every other Tmp before updating its status.
+
+There is still a problem: multiple Moves instructions may have been coalesced to the same
+Tmp. We must not add a Tmp twice to a worklist.
+To avoid duplicates, I rely on the fact that the freeze worklist should not contains
+aliased Tmps. Before adding something to the simplify worklist, I check that it was
+in the freeze worklist.
+
+I cannot find how this problem would have been avoided in the original paper. I suspect
+that may have been a bug in the pseudo-code.
+
+* b3/air/AirIteratedRegisterCoalescing.cpp:
+(JSC::B3::Air::IteratedRegisterCoalescingAllocator::freeze):
+(JSC::B3::Air::IteratedRegisterCoalescingAllocator::freezeMoves):
+
 2015-11-16  Benjamin Poulain  
 
 [JSC] Make FTLOutput's load8() and load16() compatible with B3


Modified: trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp (192515 => 192516)

--- 

[webkit-changes] [192520] trunk/Source/JavaScriptCore

[commit-queue]

Title: [192520] trunk/Source/_javascript_Core








Revision 192520
Author commit-qu...@webkit.org
Date 2015-11-17 11:56:01 -0800 (Tue, 17 Nov 2015)


Log Message
Removed useless variable scriptResult from testExecutionTimeLimit
https://bugs.webkit.org/show_bug.cgi?id=151331

Patch by Matthew Daiter  on 2015-11-17
Reviewed by Alex Christensen.

* API/tests/ExecutionTimeLimitTest.cpp: Removed scriptResult
(testExecutionTimeLimit):

Modified Paths

trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp (192519 => 192520)

--- trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp	2015-11-17 19:41:27 UTC (rev 192519)
+++ trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp	2015-11-17 19:56:01 UTC (rev 192520)
@@ -128,7 +128,6 @@
 JSObjectRef globalObject = JSContextGetGlobalObject(context);
 ASSERT(JSValueIsObject(context, globalObject));
 
-JSValueRef scriptResult = nullptr;
 JSValueRef exception = nullptr;
 
 JSStringRef currentCPUTimeStr = JSStringCreateWithUTF8CString("currentCPUTime");
@@ -151,7 +150,7 @@
 exception = nullptr;
 shouldTerminateCallbackWasCalled = false;
 auto startTime = currentCPUTime();
-scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, );
+JSEvaluateScript(context, script, nullptr, nullptr, 1, );
 auto endTime = currentCPUTime();
 
 if (((endTime - startTime) < milliseconds(timeAfterWatchdogShouldHaveFired)) && shouldTerminateCallbackWasCalled)
@@ -188,7 +187,7 @@
 shouldTerminateCallbackWasCalled = false;
 
 auto startTime = currentCPUTime();
-scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, );
+JSEvaluateScript(context, script, nullptr, nullptr, 1, );
 auto endTime = currentCPUTime();
 
 if (((endTime - startTime) >= milliseconds(timeAfterWatchdogShouldHaveFired)) || !shouldTerminateCallbackWasCalled) {
@@ -225,7 +224,7 @@
 shouldTerminateCallbackWasCalled = false;
 
 auto startTime = currentCPUTime();
-scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, );
+JSEvaluateScript(context, script, nullptr, nullptr, 1, );
 auto endTime = currentCPUTime();
 
 if (((endTime - startTime) < milliseconds(timeAfterWatchdogShouldHaveFired)) && !shouldTerminateCallbackWasCalled)
@@ -262,7 +261,7 @@
 cancelTerminateCallbackWasCalled = false;
 
 auto startTime = currentCPUTime();
-scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, );
+JSEvaluateScript(context, script, nullptr, nullptr, 1, );
 auto endTime = currentCPUTime();
 
 if (((endTime - startTime) >= milliseconds(timeAfterWatchdogShouldHaveFired)) && cancelTerminateCallbackWasCalled && !exception)
@@ -299,7 +298,7 @@
 extendTerminateCallbackCalled = 0;
 
 auto startTime = currentCPUTime();
-scriptResult = JSEvaluateScript(context, script, nullptr, nullptr, 1, );
+JSEvaluateScript(context, script, nullptr, nullptr, 1, );
 auto endTime = currentCPUTime();
 auto deltaTime = endTime - startTime;
 


Modified: trunk/Source/_javascript_Core/ChangeLog (192519 => 192520)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 19:41:27 UTC (rev 192519)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 19:56:01 UTC (rev 192520)
@@ -1,3 +1,13 @@
+2015-11-17  Matthew Daiter  
+
+Removed useless variable scriptResult from testExecutionTimeLimit
+https://bugs.webkit.org/show_bug.cgi?id=151331
+
+Reviewed by Alex Christensen.
+
+* API/tests/ExecutionTimeLimitTest.cpp: Removed scriptResult
+(testExecutionTimeLimit):
+
 2015-11-16  Mark Lam  
 
 [JSC] Support Doubles with B3's Sub.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192518] trunk

[beidson]

Title: [192518] trunk








Revision 192518
Author beid...@apple.com
Date 2015-11-17 11:41:26 -0800 (Tue, 17 Nov 2015)


Log Message
Modern IDB: Support IDBObjectStore.indexNames.
https://bugs.webkit.org/show_bug.cgi?id=151341

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Covered by existing storage/indexeddb/modern/objectstore-attributes.html).

* Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::indexNames):
* Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:
(WebCore::IDBObjectStoreInfo::indexNames):
* Modules/indexeddb/shared/IDBObjectStoreInfo.h:

LayoutTests:

* storage/indexeddb/modern/objectstore-attributes-expected.txt:
* storage/indexeddb/modern/objectstore-attributes.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/modern/objectstore-attributes-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/objectstore-attributes.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/client/IDBObjectStoreImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp
trunk/Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.h




Diff

Modified: trunk/LayoutTests/ChangeLog (192517 => 192518)

--- trunk/LayoutTests/ChangeLog	2015-11-17 19:30:14 UTC (rev 192517)
+++ trunk/LayoutTests/ChangeLog	2015-11-17 19:41:26 UTC (rev 192518)
@@ -1,3 +1,13 @@
+2015-11-17  Brady Eidson  
+
+Modern IDB: Support IDBObjectStore.indexNames.
+https://bugs.webkit.org/show_bug.cgi?id=151341
+
+Reviewed by Alex Christensen.
+
+* storage/indexeddb/modern/objectstore-attributes-expected.txt:
+* storage/indexeddb/modern/objectstore-attributes.html:
+
 2015-11-17  Wenson Hsieh  
 
 Unreviewed, skip crashing mediastream tests


Modified: trunk/LayoutTests/storage/indexeddb/modern/objectstore-attributes-expected.txt (192517 => 192518)

--- trunk/LayoutTests/storage/indexeddb/modern/objectstore-attributes-expected.txt	2015-11-17 19:30:14 UTC (rev 192517)
+++ trunk/LayoutTests/storage/indexeddb/modern/objectstore-attributes-expected.txt	2015-11-17 19:41:26 UTC (rev 192518)
@@ -1,17 +1,30 @@
-ALERT: First upgrade needed: Old version - 0 New version - 1
-ALERT: [object IDBTransaction] - versionchange
-ALERT: [object IDBDatabase]
-ALERT: TestObjectStore1
-ALERT: TestObjectStore2
-ALERT: true
-ALERT: false
-ALERT: foo
-ALERT: null
-ALERT: [object IDBTransaction]
-ALERT: [object IDBTransaction]
-ALERT: true
-ALERT: true
-ALERT: true
-ALERT: First version change transaction completed
-ALERT: Done
 This test exercises the readonly attributes on an IDBObjectStore.
+First upgrade needed: Old version - 0 New version - 1
+[object IDBTransaction] - versionchange
+[object IDBDatabase]
+TestObjectStore1
+TestObjectStore2
+true
+false
+foo
+null
+[object IDBTransaction]
+[object IDBTransaction]
+true
+true
+true
+Object store has indexes:
+Bar index
+Foo index
+After adding another, object store now has indexes:
+Bar index
+Baz index
+Foo index
+First version change transaction completed
+In a new transaction, object store has indexes:
+Bar index
+Baz index
+Foo index
+readonly transaction complete
+Done
+


Modified: trunk/LayoutTests/storage/indexeddb/modern/objectstore-attributes.html (192517 => 192518)

--- trunk/LayoutTests/storage/indexeddb/modern/objectstore-attributes.html	2015-11-17 19:30:14 UTC (rev 192517)
+++ trunk/LayoutTests/storage/indexeddb/modern/objectstore-attributes.html	2015-11-17 19:41:26 UTC (rev 192518)
@@ -1,4 +1,5 @@
-This test exercises the readonly attributes on an IDBObjectStore.
+This test exercises the readonly attributes on an IDBObjectStore.
+
 
 
 if (window.testRunner) {
@@ -8,51 +9,99 @@
 
 var request = window.indexedDB.open("ObjectStoreAttributesTestDatabase");
 
+function log(message)
+{
+document.getElementById("logger").innerHTML += message + "
";
+}
+
 function done()
 {
-alert("Done");
+log("Done");
 if (window.testRunner)
 testRunner.notifyDone();
 }
 
+var database;
+
 request._onupgradeneeded_ = function(event)
 {
-alert("First upgrade needed: Old version - " + event.oldVersion + " New version - " + event.newVersion);
+log("First upgrade needed: Old version - " + event.oldVersion + " New version - " + event.newVersion);
 
 var tx = request.transaction;
-var db = event.target.result;
+database = event.target.result;
 
-alert(tx + 

[webkit-changes] [192558] trunk/Source/JavaScriptCore

[fpizlo]

Title: [192558] trunk/Source/_javascript_Core








Revision 192558
Author fpi...@apple.com
Date 2015-11-17 17:27:28 -0800 (Tue, 17 Nov 2015)


Log Message
B3::generate should separate out the final Air codegen, so that it can be done outside the Graph safepoint
https://bugs.webkit.org/show_bug.cgi?id=151371

Reviewed by Benjamin Poulain.

One of the FTL optimizations is that while the expensive backend is running, we are at a "graph
safepoint" that allows the VM to do GCs and other dangerous and time-sensitive things without
waiting for the compilation thread. While in the safepoint, we cannot do anything that touches
anything other than the backend's state. That means, for example, that we wouldn't be able to run
any of the stackmap generation callbacks, since those need to mess with DFG state.

That means that we need to separate the B3 pipeline into "preparation" and "generation".
Preparation is all of the expensive stuff: all B3 phases, lowering to Air, all Air phases.
Generation is just the part where we turn fully lowered Air into machine code. Generation also
happens to be the part where we call stackmap generation callbacks. In other words, preparation
is exactly the stuff that should go into the graph safepoint, while generation is the stuff that
we want to do after we emerge from the safepoint.

Because the tests were using the higher-level Compilation API, I didn't have to change any test
code. The FTL will not use that high-level API.

* b3/B3Compilation.cpp:
(JSC::B3::Compilation::Compilation):
* b3/B3Generate.cpp:
(JSC::B3::prepareForGeneration):
(JSC::B3::generate):
(JSC::B3::generateToAir):
* b3/B3Generate.h:
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::LowerToAir):
(JSC::B3::lowerToAir):
* b3/B3LowerToAir.h:
* b3/B3Procedure.cpp:
(JSC::B3::Procedure::Procedure):
* b3/B3Procedure.h:
(JSC::B3::Procedure::takeByproducts):
(JSC::B3::Procedure::code):
* b3/air/AirCode.h:
(JSC::B3::Air::Code::proc):
(JSC::B3::Air::Code::lastPhaseName):
* b3/air/AirGenerate.cpp:
(JSC::B3::Air::prepareForGeneration):
(JSC::B3::Air::generate):
* b3/air/AirGenerate.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3Compilation.cpp
trunk/Source/_javascript_Core/b3/B3Generate.cpp
trunk/Source/_javascript_Core/b3/B3Generate.h
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/B3LowerToAir.h
trunk/Source/_javascript_Core/b3/B3Procedure.cpp
trunk/Source/_javascript_Core/b3/B3Procedure.h
trunk/Source/_javascript_Core/b3/air/AirCode.h
trunk/Source/_javascript_Core/b3/air/AirGenerate.cpp
trunk/Source/_javascript_Core/b3/air/AirGenerate.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192557 => 192558)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-18 00:27:16 UTC (rev 192557)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-18 01:27:28 UTC (rev 192558)
@@ -1,5 +1,52 @@
 2015-11-17  Filip Pizlo  
 
+B3::generate should separate out the final Air codegen, so that it can be done outside the Graph safepoint
+https://bugs.webkit.org/show_bug.cgi?id=151371
+
+Reviewed by Benjamin Poulain.
+
+One of the FTL optimizations is that while the expensive backend is running, we are at a "graph
+safepoint" that allows the VM to do GCs and other dangerous and time-sensitive things without
+waiting for the compilation thread. While in the safepoint, we cannot do anything that touches
+anything other than the backend's state. That means, for example, that we wouldn't be able to run
+any of the stackmap generation callbacks, since those need to mess with DFG state.
+
+That means that we need to separate the B3 pipeline into "preparation" and "generation".
+Preparation is all of the expensive stuff: all B3 phases, lowering to Air, all Air phases.
+Generation is just the part where we turn fully lowered Air into machine code. Generation also
+happens to be the part where we call stackmap generation callbacks. In other words, preparation
+is exactly the stuff that should go into the graph safepoint, while generation is the stuff that
+we want to do after we emerge from the safepoint.
+
+Because the tests were using the higher-level Compilation API, I didn't have to change any test
+code. The FTL will not use that high-level API.
+
+* b3/B3Compilation.cpp:
+(JSC::B3::Compilation::Compilation):
+* b3/B3Generate.cpp:
+(JSC::B3::prepareForGeneration):
+(JSC::B3::generate):
+(JSC::B3::generateToAir):
+* b3/B3Generate.h:
+* b3/B3LowerToAir.cpp:
+(JSC::B3::Air::LowerToAir::LowerToAir):
+(JSC::B3::lowerToAir):
+* b3/B3LowerToAir.h:
+* b3/B3Procedure.cpp:
+(JSC::B3::Procedure::Procedure):
+* b3/B3Procedure.h:
+(JSC::B3::Procedure::takeByproducts):
+(JSC::B3::Procedure::code):
+   

[webkit-changes] [192559] trunk/PerformanceTests

[commit-queue]

Title: [192559] trunk/PerformanceTests








Revision 192559
Author commit-qu...@webkit.org
Date 2015-11-17 17:29:15 -0800 (Tue, 17 Nov 2015)


Log Message
Reorganize the graphics benchmark string table
https://bugs.webkit.org/show_bug.cgi?id=151334

Patch by Said Abou-Hallawa  on 2015-11-17
Reviewed by Simon Fraser.

Make the graphics benchmark string table be an object of sub-objects. Each
sub-object represents an associative array, the key is the string name and
the value is the string data.

* Animometer/resources/extensions.js:
(ResultsDashboard.prototype.toJSON):
(ResultsTable.prototype._showGraph):
(ResultsTable.prototype._showJSON):
(ResultsTable.prototype._isNoisyMeasurement):
(ResultsTable.prototype._isNoisyTest):
(ResultsTable.prototype._showTest):
(ResultsTable.prototype._showSuite):
(ResultsTable.prototype._showIteration):
* Animometer/resources/sampler.js:
(Sampler.prototype.toJSON):
* Animometer/resources/strings.js:
* Animometer/runner/resources/animometer.js:
(window.benchmarkRunnerClient.didFinishLastIteration):
(window.suitesManager.updateLocalStorageFromJSON):
(window.benchmarkController.showResults):
(window.benchmarkController.showJson):
(window.benchmarkController.showTestGraph):
(window.benchmarkController.showTestJSON):
* Animometer/runner/resources/tests.js:
* Animometer/tests/resources/main.js:

Modified Paths

trunk/PerformanceTests/Animometer/resources/extensions.js
trunk/PerformanceTests/Animometer/resources/sampler.js
trunk/PerformanceTests/Animometer/resources/strings.js
trunk/PerformanceTests/Animometer/runner/resources/animometer.js
trunk/PerformanceTests/Animometer/runner/resources/tests.js
trunk/PerformanceTests/Animometer/tests/resources/main.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/resources/extensions.js (192558 => 192559)

--- trunk/PerformanceTests/Animometer/resources/extensions.js	2015-11-18 01:27:28 UTC (rev 192558)
+++ trunk/PerformanceTests/Animometer/resources/extensions.js	2015-11-18 01:29:15 UTC (rev 192559)
@@ -219,24 +219,24 @@
 for (var testName in suiteSamplers) {
 var sampler = suiteSamplers[testName];
 testsResults[testName] = sampler.toJSON(statistics, graph);
-testsScores.push(testsResults[testName][Strings["JSON_SCORE"]]);
+testsScores.push(testsResults[testName][Strings.json.score]);
 }
 
 suitesResults[suiteName] =  {};
-suitesResults[suiteName][Strings["JSON_SCORE"]] = Statistics.geometricMean(testsScores);
-suitesResults[suiteName][Strings["JSON_RESULTS"][2]] = testsResults;
-suitesScores.push(suitesResults[suiteName][Strings["JSON_SCORE"]]);
+suitesResults[suiteName][Strings.json.score] = Statistics.geometricMean(testsScores);
+suitesResults[suiteName][Strings.json.results.tests] = testsResults;
+suitesScores.push(suitesResults[suiteName][Strings.json.score]);
 }
 
 iterationsResults[index] = {};
-iterationsResults[index][Strings["JSON_SCORE"]] = Statistics.geometricMean(suitesScores);
-iterationsResults[index][Strings["JSON_RESULTS"][1]] = suitesResults;
-iterationsScores.push(iterationsResults[index][Strings["JSON_SCORE"]]);
+iterationsResults[index][Strings.json.score] = Statistics.geometricMean(suitesScores);
+iterationsResults[index][Strings.json.results.suites] = suitesResults;
+iterationsScores.push(iterationsResults[index][Strings.json.score]);
 });
 
 var json = {};
-json[Strings["JSON_SCORE"]] = Statistics.sampleMean(iterationsScores.length, iterationsScores.reduce(function(a, b) { return a * b; }));
-json[Strings["JSON_RESULTS"][0]] = iterationsResults;
+json[Strings.json.score] = Statistics.sampleMean(iterationsScores.length, iterationsScores.reduce(function(a, b) { return a * b; }));
+json[Strings.json.results.iterations] = iterationsResults;
 return json;
 }
 }
@@ -324,7 +324,7 @@
 
 _showGraph: function(row, testName, testResults)
 {
-var data = ""
+var data = ""
 if (!data) {
 this._showEmptyCell(row, "");
 return;
@@ -334,18 +334,18 @@
 var button = DocumentExtension.createElement("button", { class: "small-button" }, td);
 
 button.addEventListener("click", function() {
-var samples = data[Strings["JSON_GRAPH"][0]];
-var samplingTimeOffset = data[Strings["JSON_GRAPH"][1]];
-var axes = Strings["TEXT_EXPERIMENTS"];
+var samples = data[Strings.json.graph.points];
+var samplingTimeOffset = data[Strings.json.graph.samplingTimeOffset];
+var axes = [Strings.text.experiments.complexity, Strings.text.experiments.frameRate];
 

[webkit-changes] [192561] trunk/Source/JavaScriptCore

[benjamin]

Title: [192561] trunk/Source/_javascript_Core








Revision 192561
Author benja...@webkit.org
Date 2015-11-17 17:53:44 -0800 (Tue, 17 Nov 2015)


Log Message
[JSC] Untangle the dependencies on FTLAbbreviations a bit
https://bugs.webkit.org/show_bug.cgi?id=151375

Patch by Benjamin Poulain  on 2015-11-17
Reviewed by Geoffrey Garen.

FTLAbbreviations was included in many places but in most cases
we just need the Abbreviated types. Update the #include accordingly.

Also remove the IntrinsicRepository dependency from the B3Output.

* ftl/FTLAbstractHeap.cpp:
* ftl/FTLAbstractHeap.h:
* ftl/FTLAbstractHeapRepository.cpp:
* ftl/FTLB3Output.h:
(JSC::FTL::Output::Output):
(JSC::FTL::Output::stackmapIntrinsic):
(JSC::FTL::Output::frameAddressIntrinsic):
(JSC::FTL::Output::patchpointInt64Intrinsic):
(JSC::FTL::Output::patchpointVoidIntrinsic):
* ftl/FTLCommonValues.cpp:
* ftl/FTLCommonValues.h:
* ftl/FTLFormattedValue.h:
* ftl/FTLIntrinsicRepository.cpp:
* ftl/FTLOSRExit.h:
* ftl/FTLOSRExitCompilationInfo.h:
* ftl/FTLStackmapArgumentList.h:
* ftl/FTLState.cpp:
* ftl/FTLState.h:
* ftl/FTLTypedPointer.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.cpp
trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.h
trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp
trunk/Source/_javascript_Core/ftl/FTLB3Output.h
trunk/Source/_javascript_Core/ftl/FTLCommonValues.cpp
trunk/Source/_javascript_Core/ftl/FTLCommonValues.h
trunk/Source/_javascript_Core/ftl/FTLFormattedValue.h
trunk/Source/_javascript_Core/ftl/FTLIntrinsicRepository.cpp
trunk/Source/_javascript_Core/ftl/FTLOSRExit.h
trunk/Source/_javascript_Core/ftl/FTLOSRExitCompilationInfo.h
trunk/Source/_javascript_Core/ftl/FTLStackmapArgumentList.h
trunk/Source/_javascript_Core/ftl/FTLState.cpp
trunk/Source/_javascript_Core/ftl/FTLState.h
trunk/Source/_javascript_Core/ftl/FTLTypedPointer.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192560 => 192561)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-18 01:34:49 UTC (rev 192560)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-18 01:53:44 UTC (rev 192561)
@@ -1,3 +1,35 @@
+2015-11-17  Benjamin Poulain  
+
+[JSC] Untangle the dependencies on FTLAbbreviations a bit
+https://bugs.webkit.org/show_bug.cgi?id=151375
+
+Reviewed by Geoffrey Garen.
+
+FTLAbbreviations was included in many places but in most cases
+we just need the Abbreviated types. Update the #include accordingly.
+
+Also remove the IntrinsicRepository dependency from the B3Output.
+
+* ftl/FTLAbstractHeap.cpp:
+* ftl/FTLAbstractHeap.h:
+* ftl/FTLAbstractHeapRepository.cpp:
+* ftl/FTLB3Output.h:
+(JSC::FTL::Output::Output):
+(JSC::FTL::Output::stackmapIntrinsic):
+(JSC::FTL::Output::frameAddressIntrinsic):
+(JSC::FTL::Output::patchpointInt64Intrinsic):
+(JSC::FTL::Output::patchpointVoidIntrinsic):
+* ftl/FTLCommonValues.cpp:
+* ftl/FTLCommonValues.h:
+* ftl/FTLFormattedValue.h:
+* ftl/FTLIntrinsicRepository.cpp:
+* ftl/FTLOSRExit.h:
+* ftl/FTLOSRExitCompilationInfo.h:
+* ftl/FTLStackmapArgumentList.h:
+* ftl/FTLState.cpp:
+* ftl/FTLState.h:
+* ftl/FTLTypedPointer.h:
+
 2015-11-17  Filip Pizlo  
 
 B3::generate should separate out the final Air codegen, so that it can be done outside the Graph safepoint


Modified: trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.cpp (192560 => 192561)

--- trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.cpp	2015-11-18 01:34:49 UTC (rev 192560)
+++ trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.cpp	2015-11-18 01:53:44 UTC (rev 192561)
@@ -29,6 +29,7 @@
 #if ENABLE(FTL_JIT)
 
 #include "DFGCommon.h"
+#include "FTLAbbreviatedTypes.h"
 #include "FTLAbbreviations.h"
 #include "FTLAbstractHeapRepository.h"
 #include "FTLB3Output.h"


Modified: trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.h (192560 => 192561)

--- trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.h	2015-11-18 01:34:49 UTC (rev 192560)
+++ trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.h	2015-11-18 01:53:44 UTC (rev 192561)
@@ -28,7 +28,7 @@
 
 #if ENABLE(FTL_JIT)
 
-#include "FTLAbbreviations.h"
+#include "FTLAbbreviatedTypes.h"
 #include "JSCJSValue.h"
 #include 
 #include 


Modified: trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp (192560 => 192561)

--- trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp	2015-11-18 01:34:49 UTC (rev 192560)
+++ trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp	2015-11-18 01:53:44 UTC (rev 192561)
@@ -29,6 +29,7 @@
 #if ENABLE(FTL_JIT)
 
 #include "DirectArguments.h"
+#include "FTLAbbreviations.h"
 #include "GetterSetter.h"
 #include "JSArrowFunction.h"
 #include "JSEnvironmentRecord.h"


Modified: 

[webkit-changes] [192563] tags/Safari-601.1.46.81/

[matthew_hanson]

Title: [192563] tags/Safari-601.1.46.81/








Revision 192563
Author matthew_han...@apple.com
Date 2015-11-17 17:54:47 -0800 (Tue, 17 Nov 2015)


Log Message
New Tag.

Added Paths

tags/Safari-601.1.46.81/




Diff

Property changes: tags/Safari-601.1.46.81



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192562] tags/Safari-601.1.46.81/

[matthew_hanson]

Title: [192562] tags/Safari-601.1.46.81/








Revision 192562
Author matthew_han...@apple.com
Date 2015-11-17 17:54:36 -0800 (Tue, 17 Nov 2015)


Log Message
Delete Tag.

Removed Paths

tags/Safari-601.1.46.81/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192560] trunk/Source/WebInspectorUI

[commit-queue]

Title: [192560] trunk/Source/WebInspectorUI








Revision 192560
Author commit-qu...@webkit.org
Date 2015-11-17 17:34:49 -0800 (Tue, 17 Nov 2015)


Log Message
Web Inspector: Move Timeline creation into a recording
https://bugs.webkit.org/show_bug.cgi?id=151367

Patch by Joseph Pecoraro  on 2015-11-17
Reviewed by Timothy Hatcher.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._loadNewRecording): Deleted.
* UserInterface/Models/Timeline.js:
(WebInspector.Timeline.create):
(WebInspector.Timeline.prototype.get type):
(WebInspector.Timeline): Deleted.
(WebInspector.Timeline.prototype.get recording): Deleted.
* UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording):
(WebInspector.TimelineRecording.prototype.get readonly):
(WebInspector.TimelineRecording.prototype.unloaded):
(WebInspector.TimelineRecording.prototype.reset):
(WebInspector.TimelineRecording.prototype.isWritable): Deleted.
* UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview):
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.shown):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js
trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (192559 => 192560)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-11-18 01:29:15 UTC (rev 192559)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-11-18 01:34:49 UTC (rev 192560)
@@ -1,3 +1,28 @@
+2015-11-17  Joseph Pecoraro  
+
+Web Inspector: Move Timeline creation into a recording
+https://bugs.webkit.org/show_bug.cgi?id=151367
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Controllers/TimelineManager.js:
+(WebInspector.TimelineManager.prototype._loadNewRecording): Deleted.
+* UserInterface/Models/Timeline.js:
+(WebInspector.Timeline.create):
+(WebInspector.Timeline.prototype.get type):
+(WebInspector.Timeline): Deleted.
+(WebInspector.Timeline.prototype.get recording): Deleted.
+* UserInterface/Models/TimelineRecording.js:
+(WebInspector.TimelineRecording):
+(WebInspector.TimelineRecording.prototype.get readonly):
+(WebInspector.TimelineRecording.prototype.unloaded):
+(WebInspector.TimelineRecording.prototype.reset):
+(WebInspector.TimelineRecording.prototype.isWritable): Deleted.
+* UserInterface/Views/TimelineOverview.js:
+(WebInspector.TimelineOverview):
+* UserInterface/Views/TimelineRecordingContentView.js:
+(WebInspector.TimelineRecordingContentView.prototype.shown):
+
 2015-11-17  Matt Baker  
 
 Web Inspector: Breakpoint condition field should use CodeMirror


Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (192559 => 192560)

--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js	2015-11-18 01:29:15 UTC (rev 192559)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js	2015-11-18 01:34:49 UTC (rev 192560)
@@ -447,19 +447,10 @@
 
 var identifier = this._nextRecordingIdentifier++;
 var newRecording = new WebInspector.TimelineRecording(identifier, WebInspector.UIString("Timeline Recording %d").format(identifier));
-newRecording.addTimeline(WebInspector.Timeline.create(WebInspector.TimelineRecord.Type.Network, newRecording));
-newRecording.addTimeline(WebInspector.Timeline.create(WebInspector.TimelineRecord.Type.Layout, newRecording));
-newRecording.addTimeline(WebInspector.Timeline.create(WebInspector.TimelineRecord.Type.Script, newRecording));
 
-// COMPATIBILITY (iOS 8): TimelineAgent.EventType.RenderingFrame did not exist.
-if (window.TimelineAgent && TimelineAgent.EventType.RenderingFrame)
-newRecording.addTimeline(WebInspector.Timeline.create(WebInspector.TimelineRecord.Type.RenderingFrame, newRecording));
-
 this._recordings.push(newRecording);
 this.dispatchEventToListeners(WebInspector.TimelineManager.Event.RecordingCreated, {recording: newRecording});
 
-console.assert(newRecording.isWritable());
-
 if (this._isCapturing)
 this.stopCapturing();
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js (192559 => 192560)

--- trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js	2015-11-18 01:29:15 UTC (rev 192559)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Timeline.js	2015-11-18 01:34:49 UTC (rev 192560)
@@ -25,28 +25,32 @@
 
 WebInspector.Timeline = 

[webkit-changes] [192564] trunk

[zalan]

Title: [192564] trunk








Revision 192564
Author za...@apple.com
Date 2015-11-17 19:00:43 -0800 (Tue, 17 Nov 2015)


Log Message
Simple line layout: Add letter-spacing support.
https://bugs.webkit.org/show_bug.cgi?id=151362

Reviewed by Antti Koivisto.

This enables us to use simple line layout on letter-spacing content.
(fixme: webkit.org/b/151368 -> Repaint rect is not computed correctly when negative letter-spacing applied)

Source/WebCore:

Test: fast/text/simple-line-letterspacing.html

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForStyle):
* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow): RenderLineBoxList tests vertical intersection only.
* rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth):

LayoutTests:

* fast/text/simple-line-letterspacing-expected.html: Added.
* fast/text/simple-line-letterspacing.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp
trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp
trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp


Added Paths

trunk/LayoutTests/fast/text/simple-line-letterspacing-expected.html
trunk/LayoutTests/fast/text/simple-line-letterspacing.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192563 => 192564)

--- trunk/LayoutTests/ChangeLog	2015-11-18 01:54:47 UTC (rev 192563)
+++ trunk/LayoutTests/ChangeLog	2015-11-18 03:00:43 UTC (rev 192564)
@@ -1,3 +1,16 @@
+2015-11-17  Zalan Bujtas  
+
+Simple line layout: Add letter-spacing support.
+https://bugs.webkit.org/show_bug.cgi?id=151362
+
+Reviewed by Antti Koivisto.
+
+This enables us to use simple line layout on letter-spacing content.
+(fixme: webkit.org/b/151368 -> Repaint rect is not computed correctly when negative letter-spacing applied)
+
+* fast/text/simple-line-letterspacing-expected.html: Added.
+* fast/text/simple-line-letterspacing.html: Added.
+
 2015-11-17  Ryan Haddad  
 
 Marking storage/indexeddb/modern/get-index-failures.html as flaky on mac-wk1


Added: trunk/LayoutTests/fast/text/simple-line-letterspacing-expected.html (0 => 192564)

--- trunk/LayoutTests/fast/text/simple-line-letterspacing-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/simple-line-letterspacing-expected.html	2015-11-18 03:00:43 UTC (rev 192564)
@@ -0,0 +1,22 @@
+
+
+This tests that simple line layout renders letter-spacing properly.
+
+	div {
+		margin: 10px;
+	}
+
+
+
+
+if (window.internals)
+	internals.settings.setSimpleLineLayoutEnabled(false);
+for (var i = -10; i < 10; ++i) {
+var element = document.createElement("div");
+element.innerText = "foobar";
+element.style.letterSpacing = i;
+	document.body.appendChild(element);
+}
+
+
+


Added: trunk/LayoutTests/fast/text/simple-line-letterspacing.html (0 => 192564)

--- trunk/LayoutTests/fast/text/simple-line-letterspacing.html	(rev 0)
+++ trunk/LayoutTests/fast/text/simple-line-letterspacing.html	2015-11-18 03:00:43 UTC (rev 192564)
@@ -0,0 +1,20 @@
+
+
+This tests that simple line layout renders letter-spacing properly.
+
+	div {
+		margin: 10px;
+	}
+
+
+
+
+for (var i = -10; i < 10; ++i) {
+var element = document.createElement("div");
+element.innerText = "foobar";
+element.style.letterSpacing = i;
+	document.body.appendChild(element);
+}
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (192563 => 192564)

--- trunk/Source/WebCore/ChangeLog	2015-11-18 01:54:47 UTC (rev 192563)
+++ trunk/Source/WebCore/ChangeLog	2015-11-18 03:00:43 UTC (rev 192564)
@@ -1,3 +1,22 @@
+2015-11-17  Zalan Bujtas  
+
+Simple line layout: Add letter-spacing support.
+https://bugs.webkit.org/show_bug.cgi?id=151362
+
+Reviewed by Antti Koivisto.
+
+This enables us to use simple line layout on letter-spacing content.
+(fixme: webkit.org/b/151368 -> Repaint rect is not computed correctly when negative letter-spacing applied)
+
+Test: fast/text/simple-line-letterspacing.html
+
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::canUseForStyle):
+* rendering/SimpleLineLayoutFunctions.cpp:
+(WebCore::SimpleLineLayout::paintFlow): RenderLineBoxList tests vertical intersection only. 
+* rendering/SimpleLineLayoutTextFragmentIterator.cpp:
+(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth):
+
 2015-11-17  Per Arne Vollan  
 
 [WinCairo][MediaFoundation] Current playback time is not shown.


Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (192563 => 192564)

--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2015-11-18 01:54:47 UTC (rev 192563)
+++ 

[webkit-changes] [192510] trunk/Source/WebKit2

[carlosgc]

Title: [192510] trunk/Source/WebKit2








Revision 192510
Author carlo...@webkit.org
Date 2015-11-17 00:37:21 -0800 (Tue, 17 Nov 2015)


Log Message
[GTK] Web Process crashes on reparenting a WebView with AC mode on
https://bugs.webkit.org/show_bug.cgi?id=151139

Reviewed by Mario Sanchez Prada.

When the web view is reparented, the widget is first unrealized,
and then realized again when added to the new parent. In the
second realize, the old redirected XComposite window is destroyed
and a new one is created, but the web process is still using the
old redirected window ID. As soon as the redirected window is
destroyed and the web process tries to use the window ID, it
crashes due to a BadDrawable X error. We have to notify the web
process as soon as the web view is unrealized to stop using the
current window ID and exit accelerated compositing mode until a
new window ID is given. This notification needs to be synchronous,
because the window can be destroyed in the UI process before the
message is received in the web process.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize): Add an assert to ensure we never have
a redirected window when the view is realized. Also check drawing
area is not nullptr, since it can be destroyed at any time if the
web process crashes.
(webkitWebViewBaseUnrealize): Call
DrawingAreaProxyImpl::destroyNativeSurfaceHandleForCompositing()
and destroy the redirected XComposite window.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::destroyNativeSurfaceHandleForCompositing):
Send DestroyNativeSurfaceHandleForCompositing synchronous messsage
to the web process.
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in: Add
DestroyNativeSurfaceHandleForCompositing message.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::destroyNativeSurfaceHandleForCompositing):
Set the native surface handler for compositing to 0 to reset it.
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::makeContextCurrent): Return false
early always when layer tree context ID is 0, even if we already
have a context.
(WebKit::LayerTreeHostGtk::setNativeSurfaceHandleForCompositing):
Cancel any pending layer flush when setting a new handler.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h
trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (192509 => 192510)

--- trunk/Source/WebKit2/ChangeLog	2015-11-17 08:11:37 UTC (rev 192509)
+++ trunk/Source/WebKit2/ChangeLog	2015-11-17 08:37:21 UTC (rev 192510)
@@ -1,3 +1,50 @@
+2015-11-17  Carlos Garcia Campos  
+
+[GTK] Web Process crashes on reparenting a WebView with AC mode on
+https://bugs.webkit.org/show_bug.cgi?id=151139
+
+Reviewed by Mario Sanchez Prada.
+
+When the web view is reparented, the widget is first unrealized,
+and then realized again when added to the new parent. In the
+second realize, the old redirected XComposite window is destroyed
+and a new one is created, but the web process is still using the
+old redirected window ID. As soon as the redirected window is
+destroyed and the web process tries to use the window ID, it
+crashes due to a BadDrawable X error. We have to notify the web
+process as soon as the web view is unrealized to stop using the
+current window ID and exit accelerated compositing mode until a
+new window ID is given. This notification needs to be synchronous,
+because the window can be destroyed in the UI process before the
+message is received in the web process.
+
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseRealize): Add an assert to ensure we never have
+a redirected window when the view is realized. Also check drawing
+area is not nullptr, since it can be destroyed at any time if the
+web process crashes.
+(webkitWebViewBaseUnrealize): Call
+DrawingAreaProxyImpl::destroyNativeSurfaceHandleForCompositing()
+and destroy the redirected XComposite window.
+* UIProcess/DrawingAreaProxyImpl.cpp:
+(WebKit::DrawingAreaProxyImpl::destroyNativeSurfaceHandleForCompositing):
+Send DestroyNativeSurfaceHandleForCompositing synchronous messsage
+to the web process.
+* UIProcess/DrawingAreaProxyImpl.h:
+* 

[webkit-changes] [192511] trunk/Source/WebCore

[carlosgc]

Title: [192511] trunk/Source/WebCore








Revision 192511
Author carlo...@webkit.org
Date 2015-11-17 01:57:42 -0800 (Tue, 17 Nov 2015)


Log Message
[GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer
https://bugs.webkit.org/show_bug.cgi?id=151256

Reviewed by Žan Doberšek.

Use RunLoop instead of the platform specific code. The AudioBus
can be created from any thread, so we create a helper thread to
ensure we don't use the main RunLoop.

This patch also includes some code cleanups:
  - Uses smart pointers when possible.
  - Fixes uninitialized members in constructors.
  - Makes private members private.
  - Uses lambdas instead of static non-members functions.
  - nullptr instead of 0 in some places.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createWeakPtr):
(WebCore::AudioFileReader::deinterleavePadAddedCallback):
(WebCore::AudioFileReader::deinterleaveReadyCallback):
(WebCore::AudioFileReader::decodebinPadAddedCallback):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::handleSample):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::deinterleavePadsConfigured):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::decodeAudioForBusCreation):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
(WebCore::onAppsinkPullRequiredCallback): Deleted.
(WebCore::messageCallback): Deleted.
(WebCore::onGStreamerDeinterleavePadAddedCallback): Deleted.
(WebCore::onGStreamerDeinterleaveReadyCallback): Deleted.
(WebCore::onGStreamerDecodebinPadAddedCallback): Deleted.
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF::refGPtr):
(WTF::derefGPtr):
* platform/graphics/gstreamer/GRefPtrGStreamer.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (192510 => 192511)

--- trunk/Source/WebCore/ChangeLog	2015-11-17 08:37:21 UTC (rev 192510)
+++ trunk/Source/WebCore/ChangeLog	2015-11-17 09:57:42 UTC (rev 192511)
@@ -1,3 +1,48 @@
+2015-11-17  Carlos Garcia Campos  
+
+[GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer
+https://bugs.webkit.org/show_bug.cgi?id=151256
+
+Reviewed by Žan Doberšek.
+
+Use RunLoop instead of the platform specific code. The AudioBus
+can be created from any thread, so we create a helper thread to
+ensure we don't use the main RunLoop.
+
+This patch also includes some code cleanups:
+  - Uses smart pointers when possible.
+  - Fixes uninitialized members in constructors.
+  - Makes private members private.
+  - Uses lambdas instead of static non-members functions.
+  - nullptr instead of 0 in some places.
+
+* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
+(WebCore::AudioFileReader::createWeakPtr):
+(WebCore::AudioFileReader::deinterleavePadAddedCallback):
+(WebCore::AudioFileReader::deinterleaveReadyCallback):
+(WebCore::AudioFileReader::decodebinPadAddedCallback):
+(WebCore::AudioFileReader::AudioFileReader):
+(WebCore::AudioFileReader::~AudioFileReader):
+(WebCore::AudioFileReader::handleSample):
+(WebCore::AudioFileReader::handleMessage):
+(WebCore::AudioFileReader::handleNewDeinterleavePad):
+(WebCore::AudioFileReader::deinterleavePadsConfigured):
+(WebCore::AudioFileReader::plugDeinterleave):
+(WebCore::AudioFileReader::decodeAudioForBusCreation):
+(WebCore::AudioFileReader::createBus):
+(WebCore::createBusFromAudioFile):
+(WebCore::createBusFromInMemoryAudioFile):
+(WebCore::onAppsinkPullRequiredCallback): Deleted.
+(WebCore::messageCallback): Deleted.
+(WebCore::onGStreamerDeinterleavePadAddedCallback): Deleted.
+(WebCore::onGStreamerDeinterleaveReadyCallback): Deleted.
+(WebCore::onGStreamerDecodebinPadAddedCallback): Deleted.
+* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
+(WTF::adoptGRef):
+(WTF::refGPtr):
+(WTF::derefGPtr):
+* platform/graphics/gstreamer/GRefPtrGStreamer.h:
+
 2015-11-16  Eric Carlson  
 
 [MediaStream] VideoTrack should respond to MediaStreamTrack state changes


Modified: trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp (192510 => 192511)

--- trunk/Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp	2015-11-17 08:37:21 UTC (rev 192510)
+++ 

[webkit-changes] [192512] trunk

[svillar]

Title: [192512] trunk








Revision 192512
Author svil...@igalia.com
Date 2015-11-17 02:11:43 -0800 (Tue, 17 Nov 2015)


Log Message
[css-grid] Fix alignment with gutters and negative free spaces
https://bugs.webkit.org/show_bug.cgi?id=151307

Reviewed by Zalan Bujtas.

Source/WebCore:

This is a regression caused by r192154. The problem was that
the free space was not properly computed when the grid
container was narrower than the track sizes + gutters size for
a given axis. The culprit was an unneeded clamp to 0 which was
polluting the freeSpace computation as the track sizing
algorithm works perfectly OK with negative freeSpace values.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeTrackSizesForDirection):

LayoutTests:

* fast/css-grid-layout/grid-gutters-and-alignment-expected.txt:
* fast/css-grid-layout/grid-gutters-and-alignment.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (192511 => 192512)

--- trunk/LayoutTests/ChangeLog	2015-11-17 09:57:42 UTC (rev 192511)
+++ trunk/LayoutTests/ChangeLog	2015-11-17 10:11:43 UTC (rev 192512)
@@ -1,3 +1,13 @@
+2015-11-17  Sergio Villar Senin  
+
+[css-grid] Fix alignment with gutters and negative free spaces
+https://bugs.webkit.org/show_bug.cgi?id=151307
+
+Reviewed by Zalan Bujtas.
+
+* fast/css-grid-layout/grid-gutters-and-alignment-expected.txt:
+* fast/css-grid-layout/grid-gutters-and-alignment.html:
+
 2015-11-17  Hunseop Jeong  
 
 Unreviewed EFL Gardening on 16th Nov.


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment-expected.txt (192511 => 192512)

--- trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment-expected.txt	2015-11-17 09:57:42 UTC (rev 192511)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment-expected.txt	2015-11-17 10:11:43 UTC (rev 192512)
@@ -56,3 +56,21 @@
 direction: RTL (parall) | align-items: 'self-start' | justify-items: 'self-start'
 
 PASS
+Negative free space. justify-content: start
+
+PASS
+Negative free space. justify-content: center
+
+PASS
+Negative free space. justify-content: end
+
+PASS
+Negative free space. align-content: start
+
+PASS
+Negative free space. align-content: center
+
+PASS
+Negative free space. align-content: end
+
+PASS


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment.html (192511 => 192512)

--- trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment.html	2015-11-17 09:57:42 UTC (rev 192511)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-alignment.html	2015-11-17 10:11:43 UTC (rev 192512)
@@ -40,6 +40,22 @@
 position: relative; /* For the  comments */
 }
 
+.gridWithAutoColumns {
+grid-auto-columns: 20px;
+border: 2px solid black;
+width: 10px;
+margin-left: 200px;
+position: relative;
+}
+
+.gridWithAutoRows {
+-webkit-grid-auto-rows: 40px;
+border: 2px solid black;
+height: 50px;
+width: 20px;
+position: relative;
+}
+
 .stretch {
 align-self: stretch;
 justify-self: stretch;
@@ -63,6 +79,11 @@
 margin: 4px 8px 12px 16px;
 }
 
+.thirdRowFirstColumn {
+background-color: lime;
+grid-row: 3;
+grid-column: 1;
+}
 
 .container {
 position: relative;
@@ -294,4 +315,60 @@
 
 
 
+
+
+Negative free space. justify-content: start
+
+
+
+
+
+
+
+
+Negative free space. justify-content: center
+
+
+
+
+
+
+
+
+Negative free space. justify-content: end
+
+
+
+
+
+
+
+
+
+Negative free space. align-content: start
+
+
+
+
+
+
+
+
+Negative free space. align-content: center
+
+
+
+
+
+
+
+
+Negative free space. align-content: end
+
+
+
+
+
+
+
 


Modified: trunk/Source/WebCore/ChangeLog (192511 => 192512)

--- trunk/Source/WebCore/ChangeLog	2015-11-17 09:57:42 UTC (rev 192511)
+++ trunk/Source/WebCore/ChangeLog	2015-11-17 10:11:43 UTC (rev 192512)
@@ -1,3 +1,20 @@
+2015-11-17  Sergio Villar Senin  
+
+[css-grid] Fix alignment with gutters and negative free spaces
+https://bugs.webkit.org/show_bug.cgi?id=151307
+
+Reviewed by Zalan Bujtas.
+
+This is a regression caused by r192154. The problem was that
+the free space was not properly computed when the grid
+container was narrower than the track sizes + gutters size for
+a given axis. The culprit was an unneeded clamp to 0 which was
+polluting the freeSpace computation as the track sizing
+algorithm works 

[webkit-changes] [192513] trunk

[svillar]

Title: [192513] trunk








Revision 192513
Author svil...@igalia.com
Date 2015-11-17 02:13:19 -0800 (Tue, 17 Nov 2015)


Log Message
ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
https://bugs.webkit.org/show_bug.cgi?id=151025

Reviewed by Darin Adler.

Source/WebCore:

Negative margins could make RenderFlexibleBox compute negative
intrinsic sizes. Clamp intrinsic sizes to 0.

Test: css3/flexbox/negative-margins-assert.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):

LayoutTests:

* css3/flexbox/negative-margins-assert-expected.txt: Added.
* css3/flexbox/negative-margins-assert.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp


Added Paths

trunk/LayoutTests/css3/flexbox/negative-margins-assert-expected.txt
trunk/LayoutTests/css3/flexbox/negative-margins-assert.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192512 => 192513)

--- trunk/LayoutTests/ChangeLog	2015-11-17 10:11:43 UTC (rev 192512)
+++ trunk/LayoutTests/ChangeLog	2015-11-17 10:13:19 UTC (rev 192513)
@@ -1,5 +1,15 @@
 2015-11-17  Sergio Villar Senin  
 
+ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
+https://bugs.webkit.org/show_bug.cgi?id=151025
+
+Reviewed by Darin Adler.
+
+* css3/flexbox/negative-margins-assert-expected.txt: Added.
+* css3/flexbox/negative-margins-assert.html: Added.
+
+2015-11-17  Sergio Villar Senin  
+
 [css-grid] Fix alignment with gutters and negative free spaces
 https://bugs.webkit.org/show_bug.cgi?id=151307
 


Added: trunk/LayoutTests/css3/flexbox/negative-margins-assert-expected.txt (0 => 192513)

--- trunk/LayoutTests/css3/flexbox/negative-margins-assert-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/negative-margins-assert-expected.txt	2015-11-17 10:13:19 UTC (rev 192513)
@@ -0,0 +1 @@
+PASS if we don't assert


Added: trunk/LayoutTests/css3/flexbox/negative-margins-assert.html (0 => 192513)

--- trunk/LayoutTests/css3/flexbox/negative-margins-assert.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/negative-margins-assert.html	2015-11-17 10:13:19 UTC (rev 192513)
@@ -0,0 +1,20 @@
+
+
+if (window.testRunner)
+window.testRunner.dumpAsText();
+
+
+div {
+  display: flex;
+}
+
+.inner {
+  margin-left: -4em;
+}
+
+
+
+
+PASS if we don't assert
+
+


Modified: trunk/Source/WebCore/ChangeLog (192512 => 192513)

--- trunk/Source/WebCore/ChangeLog	2015-11-17 10:11:43 UTC (rev 192512)
+++ trunk/Source/WebCore/ChangeLog	2015-11-17 10:13:19 UTC (rev 192513)
@@ -1,5 +1,20 @@
 2015-11-17  Sergio Villar Senin  
 
+ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
+https://bugs.webkit.org/show_bug.cgi?id=151025
+
+Reviewed by Darin Adler.
+
+Negative margins could make RenderFlexibleBox compute negative
+intrinsic sizes. Clamp intrinsic sizes to 0.
+
+Test: css3/flexbox/negative-margins-assert.html
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
+
+2015-11-17  Sergio Villar Senin  
+
 [css-grid] Fix alignment with gutters and negative free spaces
 https://bugs.webkit.org/show_bug.cgi?id=151307
 


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (192512 => 192513)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2015-11-17 10:11:43 UTC (rev 192512)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2015-11-17 10:13:19 UTC (rev 192513)
@@ -123,6 +123,9 @@
 }
 }
 
+// Due to negative margins, it is possible that we calculated a negative intrinsic width.
+// Make sure that we never return a negative width.
+minLogicalWidth = std::max(LayoutUnit(), minLogicalWidth);
 maxLogicalWidth = std::max(minLogicalWidth, maxLogicalWidth);
 
 LayoutUnit scrollbarWidth = intrinsicScrollbarLogicalWidth();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192566] trunk

[carlosgc]

Title: [192566] trunk








Revision 192566
Author carlo...@webkit.org
Date 2015-11-17 23:48:06 -0800 (Tue, 17 Nov 2015)


Log Message
REGRESSION(r192459): [GTK] User agent string is broken after r192459
https://bugs.webkit.org/show_bug.cgi?id=151347

Reviewed by Žan Doberšek.

.:

Pass UA version numbers as strings to the build.

* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

Remove the incorrect macro and simply use the given values
USER_AGENT_GTK_MAJOR_VERSION and USER_AGENT_GTK_MINOR_VERSION that
are now strings.

* platform/gtk/UserAgentGtk.cpp:
(WebCore::versionForUAString):
(WebCore::buildUserAgentString):

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (192565 => 192566)

--- trunk/ChangeLog	2015-11-18 06:27:09 UTC (rev 192565)
+++ trunk/ChangeLog	2015-11-18 07:48:06 UTC (rev 192566)
@@ -1,3 +1,14 @@
+2015-11-17  Carlos Garcia Campos  
+
+REGRESSION(r192459): [GTK] User agent string is broken after r192459
+https://bugs.webkit.org/show_bug.cgi?id=151347
+
+Reviewed by Žan Doberšek.
+
+Pass UA version numbers as strings to the build.
+
+* Source/cmake/OptionsGTK.cmake:
+
 2015-11-16  Alex Christensen  
 
 Fix CMake build and make PluginProcess executable


Modified: trunk/Source/WebCore/ChangeLog (192565 => 192566)

--- trunk/Source/WebCore/ChangeLog	2015-11-18 06:27:09 UTC (rev 192565)
+++ trunk/Source/WebCore/ChangeLog	2015-11-18 07:48:06 UTC (rev 192566)
@@ -1,3 +1,18 @@
+2015-11-17  Carlos Garcia Campos  
+
+REGRESSION(r192459): [GTK] User agent string is broken after r192459
+https://bugs.webkit.org/show_bug.cgi?id=151347
+
+Reviewed by Žan Doberšek.
+
+Remove the incorrect macro and simply use the given values
+USER_AGENT_GTK_MAJOR_VERSION and USER_AGENT_GTK_MINOR_VERSION that
+are now strings.
+
+* platform/gtk/UserAgentGtk.cpp:
+(WebCore::versionForUAString):
+(WebCore::buildUserAgentString):
+
 2015-11-17  Zalan Bujtas  
 
 Simple line layout: Add letter-spacing support.


Modified: trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp (192565 => 192566)

--- trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp	2015-11-18 06:27:09 UTC (rev 192565)
+++ trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp	2015-11-18 07:48:06 UTC (rev 192566)
@@ -113,9 +113,7 @@
 
 static const char* versionForUAString()
 {
-#define MAKE_VERSION(major, minor) #major "." #minor
-return MAKE_VERSION(USER_AGENT_GTK_MAJOR_VERSION, USER_AGENT_GTK_MINOR_VERSION);
-#undef MAKE_VERSION
+return USER_AGENT_GTK_MAJOR_VERSION "." USER_AGENT_GTK_MINOR_VERSION;
 }
 
 static String buildUserAgentString(const UserAgentQuirks& quirks)


Modified: trunk/Source/cmake/OptionsGTK.cmake (192565 => 192566)

--- trunk/Source/cmake/OptionsGTK.cmake	2015-11-18 06:27:09 UTC (rev 192565)
+++ trunk/Source/cmake/OptionsGTK.cmake	2015-11-18 07:48:06 UTC (rev 192566)
@@ -215,8 +215,8 @@
 add_definitions(-DBUILDING_GTK__=1)
 add_definitions(-DGETTEXT_PACKAGE="WebKit2GTK-${WEBKITGTK_API_VERSION}")
 add_definitions(-DDATA_DIR="${CMAKE_INSTALL_DATADIR}")
-add_definitions(-DUSER_AGENT_GTK_MAJOR_VERSION=602)
-add_definitions(-DUSER_AGENT_GTK_MINOR_VERSION=1)
+add_definitions(-DUSER_AGENT_GTK_MAJOR_VERSION="602")
+add_definitions(-DUSER_AGENT_GTK_MINOR_VERSION="1")
 add_definitions(-DWEBKITGTK_API_VERSION_STRING="${WEBKITGTK_API_VERSION}")
 
 set(GTK_LIBRARIES ${GTK3_LIBRARIES})






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192567] trunk

[carlosgc]

Title: [192567] trunk








Revision 192567
Author carlo...@webkit.org
Date 2015-11-17 23:52:47 -0800 (Tue, 17 Nov 2015)


Log Message
Null dereference loading Blink layout test editing/execCommand/indent-button-crash.html
https://bugs.webkit.org/show_bug.cgi?id=151187

Reviewed by Darin Adler.

Source/WebCore:

This is a merge of Blink r174671:
https://codereview.chromium.org/291143002

Fixes imported/blink/editing/execCommand/indent-button-crash.html.

* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):

LayoutTests:

Unskip the test.

* platform/gtk/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ApplyBlockElementCommand.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (192566 => 192567)

--- trunk/LayoutTests/ChangeLog	2015-11-18 07:48:06 UTC (rev 192566)
+++ trunk/LayoutTests/ChangeLog	2015-11-18 07:52:47 UTC (rev 192567)
@@ -1,3 +1,15 @@
+2015-11-17  Carlos Garcia Campos  
+
+Null dereference loading Blink layout test editing/execCommand/indent-button-crash.html
+https://bugs.webkit.org/show_bug.cgi?id=151187
+
+Reviewed by Darin Adler.
+
+Unskip the test.
+
+* platform/gtk/TestExpectations:
+* platform/win/TestExpectations:
+
 2015-11-17  Zalan Bujtas  
 
 Simple line layout: Add letter-spacing support.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (192566 => 192567)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-11-18 07:48:06 UTC (rev 192566)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-11-18 07:52:47 UTC (rev 192567)
@@ -699,8 +699,6 @@
 
 webkit.org/b/144771 editing/selection/selection-invalid-offset.html [ Crash ]
 
-webkit.org/b/151260 imported/blink/editing/execCommand/indent-button-crash.html [ Crash ]
-
 #
 # End of Crashing tests
 #


Modified: trunk/LayoutTests/platform/win/TestExpectations (192566 => 192567)

--- trunk/LayoutTests/platform/win/TestExpectations	2015-11-18 07:48:06 UTC (rev 192566)
+++ trunk/LayoutTests/platform/win/TestExpectations	2015-11-18 07:52:47 UTC (rev 192567)
@@ -3232,7 +3232,6 @@
 # Imported Blink tests.
 imported/blink/compositing/iframes/ancestor-clipping-layer.html [ Skip ]
 imported/blink/compositing/perspective-origin-overflow-hidden.html [ Skip ]
-imported/blink/editing/execCommand/indent-button-crash.html [ Skip ]
 imported/blink/http/tests/plugins/get-url-notify-on-removal.html [ Skip ]
 imported/blink/plugins/empty-per-context-data.html [ Skip ]
 imported/blink/animations/animation-iteration-event-short-iterations.html [ Failure Pass ]


Modified: trunk/Source/WebCore/ChangeLog (192566 => 192567)

--- trunk/Source/WebCore/ChangeLog	2015-11-18 07:48:06 UTC (rev 192566)
+++ trunk/Source/WebCore/ChangeLog	2015-11-18 07:52:47 UTC (rev 192567)
@@ -1,5 +1,20 @@
 2015-11-17  Carlos Garcia Campos  
 
+Null dereference loading Blink layout test editing/execCommand/indent-button-crash.html
+https://bugs.webkit.org/show_bug.cgi?id=151187
+
+Reviewed by Darin Adler.
+
+This is a merge of Blink r174671:
+https://codereview.chromium.org/291143002
+
+Fixes imported/blink/editing/execCommand/indent-button-crash.html.
+
+* editing/ApplyBlockElementCommand.cpp:
+(WebCore::ApplyBlockElementCommand::doApply):
+
+2015-11-17  Carlos Garcia Campos  
+
 REGRESSION(r192459): [GTK] User agent string is broken after r192459
 https://bugs.webkit.org/show_bug.cgi?id=151347
 


Modified: trunk/Source/WebCore/editing/ApplyBlockElementCommand.cpp (192566 => 192567)

--- trunk/Source/WebCore/editing/ApplyBlockElementCommand.cpp	2015-11-18 07:48:06 UTC (rev 192566)
+++ trunk/Source/WebCore/editing/ApplyBlockElementCommand.cpp	2015-11-18 07:52:47 UTC (rev 192567)
@@ -70,8 +70,12 @@
 // FIXME: We paint the gap before some paragraphs that are indented with left 
 // margin/padding, but not others.  We should make the gap painting more consistent and 
 // then use a left margin/padding rule here.
-if (visibleEnd != visibleStart && isStartOfParagraph(visibleEnd))
-setEndingSelection(VisibleSelection(visibleStart, visibleEnd.previous(CannotCrossEditingBoundary), endingSelection().isDirectional()));
+if (visibleEnd != visibleStart && isStartOfParagraph(visibleEnd)) {
+VisibleSelection newSelection(visibleStart, visibleEnd.previous(CannotCrossEditingBoundary), endingSelection().isDirectional());
+if (newSelection.isNone())
+return;
+setEndingSelection(newSelection);
+}
 

[webkit-changes] [192526] trunk/Source/WebCore

[zalan]

Title: [192526] trunk/Source/WebCore








Revision 192526
Author za...@apple.com
Date 2015-11-17 13:16:07 -0800 (Tue, 17 Nov 2015)


Log Message
Split SimpleLineLayout::canUseFor into canUseForStyle and canUseForFontAndText.
https://bugs.webkit.org/show_bug.cgi?id=151338

Reviewed by Myles C. Maxfield.

No change in functionality.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForFontAndText):
(WebCore::SimpleLineLayout::canUseForStyle):
(WebCore::SimpleLineLayout::canUseFor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (192525 => 192526)

--- trunk/Source/WebCore/ChangeLog	2015-11-17 20:52:26 UTC (rev 192525)
+++ trunk/Source/WebCore/ChangeLog	2015-11-17 21:16:07 UTC (rev 192526)
@@ -1,3 +1,17 @@
+2015-11-17  Zalan Bujtas  
+
+Split SimpleLineLayout::canUseFor into canUseForStyle and canUseForFontAndText.
+https://bugs.webkit.org/show_bug.cgi?id=151338
+
+Reviewed by Myles C. Maxfield.
+
+No change in functionality.
+
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::canUseForFontAndText):
+(WebCore::SimpleLineLayout::canUseForStyle):
+(WebCore::SimpleLineLayout::canUseFor):
+
 2015-11-17  Brady Eidson  
 
 Modern IDB: Support IDBObjectStore.indexNames.


Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (192525 => 192526)

--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2015-11-17 20:52:26 UTC (rev 192525)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2015-11-17 21:16:07 UTC (rev 192526)
@@ -90,41 +90,29 @@
 return canUseForText(textRenderer.characters16(), textRenderer.textLength(), font);
 }
 
-bool canUseFor(const RenderBlockFlow& flow)
+static bool canUseForFontAndText(const RenderBlockFlow& flow)
 {
-if (!flow.frame().settings().simpleLineLayoutEnabled())
+// We assume that all lines have metrics based purely on the primary font.
+const auto& style = flow.style();
+auto& primaryFont = style.fontCascade().primaryFont();
+if (primaryFont.isLoading())
 return false;
-if (!flow.firstChild())
-return false;
-// This currently covers #text, #text and mutiple (sibling) RenderText cases.
-// The #text case is also popular and should be relatively easy to cover.
-for (const auto& renderer : childrenOfType(flow)) {
-if (is(renderer))
-continue;
-if (is(renderer) && !downcast(renderer).isWBR() && renderer.style().clear() == CNONE)
-continue;
-return false;
+for (const auto& textRenderer : childrenOfType(flow)) {
+if (textRenderer.isCombineText() || textRenderer.isCounter() || textRenderer.isQuote() || textRenderer.isTextFragment()
+|| textRenderer.isSVGInlineText())
+return false;
+if (style.fontCascade().codePath(TextRun(textRenderer.text())) != FontCascade::Simple)
+return false;
+if (!canUseForText(textRenderer, primaryFont))
+return false;
 }
-if (!flow.isHorizontalWritingMode())
+return true;
+}
+
+static bool canUseForStyle(const RenderStyle& style)
+{
+if (style.textOverflow())
 return false;
-if (flow.flowThreadState() != RenderObject::NotInsideFlowThread)
-return false;
-// Printing does pagination without a flow thread.
-if (flow.document().paginated())
-return false;
-if (flow.hasOutline())
-return false;
-if (flow.isRubyText() || flow.isRubyBase())
-return false;
-if (flow.parent()->isDeprecatedFlexibleBox())
-return false;
-// FIXME: Implementation of wrap=hard looks into lineboxes.
-if (flow.parent()->isTextArea() && flow.parent()->element()->fastHasAttribute(HTMLNames::wrapAttr))
-return false;
-// FIXME: Placeholders do something strange.
-if (is(*flow.parent()) && downcast(*flow.parent()).textFormControlElement().placeholderElement())
-return false;
-const RenderStyle& style = flow.style();
 if (style.textDecorationsInEffect() != TextDecorationNone)
 return false;
 if (style.textAlign() == JUSTIFY)
@@ -156,12 +144,8 @@
 return false;
 if (style.textShadow())
 return false;
-if (style.textOverflow() || (flow.isAnonymousBlock() && flow.parent()->style().textOverflow()))
-return false;
 if (style.hasPseudoStyle(FIRST_LINE) || style.hasPseudoStyle(FIRST_LETTER))
 return false;
-else if (flow.isAnonymous() && flow.firstLineBlock())
-return false;
 if (style.hasTextCombine())
 return false;
 if (style.backgroundClip() == TextFillBox)
@@ -174,7 +158,57 @@
 if (style.trailingWord() != TrailingWord::Auto)
 return false;
 #endif
+if (style.fontCascade().primaryFont().isSVGFont())
+return false;
+return true;
+}
 

[webkit-changes] [192533] branches/safari-601.4-branch/Source

[bshafiei]

Title: [192533] branches/safari-601.4-branch/Source








Revision 192533
Author bshaf...@apple.com
Date 2015-11-17 14:01:40 -0800 (Tue, 17 Nov 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.4-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.4-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (192532 => 192533)

--- branches/safari-601.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-11-17 21:57:09 UTC (rev 192532)
+++ branches/safari-601.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-11-17 22:01:40 UTC (rev 192533)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601.4-branch/Source/WebCore/Configurations/Version.xcconfig (192532 => 192533)

--- branches/safari-601.4-branch/Source/WebCore/Configurations/Version.xcconfig	2015-11-17 21:57:09 UTC (rev 192532)
+++ branches/safari-601.4-branch/Source/WebCore/Configurations/Version.xcconfig	2015-11-17 22:01:40 UTC (rev 192533)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (192532 => 192533)

--- branches/safari-601.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-11-17 21:57:09 UTC (rev 192532)
+++ branches/safari-601.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-11-17 22:01:40 UTC (rev 192533)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig (192532 => 192533)

--- branches/safari-601.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-11-17 21:57:09 UTC (rev 192532)
+++ branches/safari-601.4-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-11-17 22:01:40 UTC (rev 192533)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601.4-branch/Source/WebKit2/Configurations/Version.xcconfig (192532 => 192533)

--- branches/safari-601.4-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-11-17 21:57:09 UTC (rev 192532)
+++ branches/safari-601.4-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-11-17 22:01:40 UTC (rev 192533)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 4;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192537] tags/Safari-601.1.46.81/

[matthew_hanson]

Title: [192537] tags/Safari-601.1.46.81/








Revision 192537
Author matthew_han...@apple.com
Date 2015-11-17 14:20:52 -0800 (Tue, 17 Nov 2015)


Log Message
Delete Tag.

Removed Paths

tags/Safari-601.1.46.81/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192538] tags/Safari-601.1.46.81/

[matthew_hanson]

Title: [192538] tags/Safari-601.1.46.81/








Revision 192538
Author matthew_han...@apple.com
Date 2015-11-17 14:21:30 -0800 (Tue, 17 Nov 2015)


Log Message
New Tag.

Added Paths

tags/Safari-601.1.46.81/




Diff

Property changes: tags/Safari-601.1.46.81



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192530] tags/Safari-601.4.1/

[bshafiei]

Title: [192530] tags/Safari-601.4.1/








Revision 192530
Author bshaf...@apple.com
Date 2015-11-17 13:45:32 -0800 (Tue, 17 Nov 2015)


Log Message
New tag.

Added Paths

tags/Safari-601.4.1/




Diff

Property changes: tags/Safari-601.4.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192539] trunk/Source

[fpizlo]

Title: [192539] trunk/Source








Revision 192539
Author fpi...@apple.com
Date 2015-11-17 14:29:54 -0800 (Tue, 17 Nov 2015)


Log Message
Air should lay out code optimally
https://bugs.webkit.org/show_bug.cgi?id=150478

Reviewed by Geoffrey Garen.

Source/_javascript_Core:

This adds a phase that optimizes code layout using something that's worked well for me in the past.
Basically, it just forces pre-ordering on the CFG, except that:

- Blocks that are only reachable by Rare control flow are scheduled separately, all the way at the
  end.

- Successors of the same frequency class are pushed in ascending order of frequency, so that the most
  frequent successor is scheduled immediately after.

This also adds the requisite branch flipping, so that a branch's taken successor is not the
fall-through block. We want the fall-through to be the not-taken successor if at all possible.

* _javascript_Core.xcodeproj/project.pbxproj:
* b3/B3BlockWorklist.h:
* b3/B3GenericFrequentedBlock.h:
(JSC::B3::GenericFrequentedBlock::frequency):
(JSC::B3::GenericFrequentedBlock::isRare):
(JSC::B3::GenericFrequentedBlock::dump):
* b3/B3Procedure.h:
* b3/air/AirArg.h:
(JSC::B3::Air::Arg::isDoubleCond):
(JSC::B3::Air::Arg::isCondition):
(JSC::B3::Air::Arg::isSpecial):
(JSC::B3::Air::Arg::asDoubleCondition):
(JSC::B3::Air::Arg::isInvertible):
(JSC::B3::Air::Arg::inverted):
* b3/air/AirBasicBlock.h:
(JSC::B3::Air::BasicBlock::index):
(JSC::B3::Air::BasicBlock::setIndex):
(JSC::B3::Air::BasicBlock::size):
(JSC::B3::Air::BasicBlock::begin):
(JSC::B3::Air::BasicBlock::containsPredecessor):
(JSC::B3::Air::BasicBlock::frequency):
* b3/air/AirBlockWorklist.h: Added.
* b3/air/AirCode.cpp:
(JSC::B3::Air::Code::findNextBlock):
* b3/air/AirCode.h:
(JSC::B3::Air::Code::proc):
(JSC::B3::Air::Code::at):
(JSC::B3::Air::Code::operator[]):
(JSC::B3::Air::Code::blockList):
* b3/air/AirGenerate.cpp:
(JSC::B3::Air::generate):
* b3/air/AirOpcode.opcodes:
* b3/air/AirOptimizeBlockOrder.cpp: Added.
(JSC::B3::Air::optimizeBlockOrder):
* b3/air/AirOptimizeBlockOrder.h: Added.

Source/WTF:

* wtf/GraphNodeWorklist.h:
(WTF::GraphNodeWorklist::push):
(WTF::GraphNodeWorklist::isEmpty):
(WTF::GraphNodeWorklist::notEmpty):
(WTF::GraphNodeWorklist::pop):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/b3/B3BlockWorklist.h
trunk/Source/_javascript_Core/b3/B3GenericFrequentedBlock.h
trunk/Source/_javascript_Core/b3/B3Procedure.h
trunk/Source/_javascript_Core/b3/air/AirArg.h
trunk/Source/_javascript_Core/b3/air/AirBasicBlock.h
trunk/Source/_javascript_Core/b3/air/AirCode.cpp
trunk/Source/_javascript_Core/b3/air/AirCode.h
trunk/Source/_javascript_Core/b3/air/AirGenerate.cpp
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/GraphNodeWorklist.h


Added Paths

trunk/Source/_javascript_Core/b3/air/AirBlockWorklist.h
trunk/Source/_javascript_Core/b3/air/AirOptimizeBlockOrder.cpp
trunk/Source/_javascript_Core/b3/air/AirOptimizeBlockOrder.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192538 => 192539)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:21:30 UTC (rev 192538)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:29:54 UTC (rev 192539)
@@ -1,3 +1,58 @@
+2015-11-17  Filip Pizlo  
+
+Air should lay out code optimally
+https://bugs.webkit.org/show_bug.cgi?id=150478
+
+Reviewed by Geoffrey Garen.
+
+This adds a phase that optimizes code layout using something that's worked well for me in the past.
+Basically, it just forces pre-ordering on the CFG, except that:
+
+- Blocks that are only reachable by Rare control flow are scheduled separately, all the way at the
+  end.
+
+- Successors of the same frequency class are pushed in ascending order of frequency, so that the most
+  frequent successor is scheduled immediately after.
+
+This also adds the requisite branch flipping, so that a branch's taken successor is not the
+fall-through block. We want the fall-through to be the not-taken successor if at all possible.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* b3/B3BlockWorklist.h:
+* b3/B3GenericFrequentedBlock.h:
+(JSC::B3::GenericFrequentedBlock::frequency):
+(JSC::B3::GenericFrequentedBlock::isRare):
+(JSC::B3::GenericFrequentedBlock::dump):
+* b3/B3Procedure.h:
+* b3/air/AirArg.h:
+(JSC::B3::Air::Arg::isDoubleCond):
+(JSC::B3::Air::Arg::isCondition):
+(JSC::B3::Air::Arg::isSpecial):
+(JSC::B3::Air::Arg::asDoubleCondition):
+(JSC::B3::Air::Arg::isInvertible):
+(JSC::B3::Air::Arg::inverted):
+* b3/air/AirBasicBlock.h:
+(JSC::B3::Air::BasicBlock::index):
+(JSC::B3::Air::BasicBlock::setIndex):
+

[webkit-changes] [192528] trunk/Source/WebKit2

[ggaren]

Title: [192528] trunk/Source/WebKit2








Revision 192528
Author gga...@apple.com
Date 2015-11-17 13:31:57 -0800 (Tue, 17 Nov 2015)


Log Message
A window with a hung tab waits 5s before closing
https://bugs.webkit.org/show_bug.cgi?id=151319

Reviewed by Anders Carlsson.

I manually tested that I did not break unload events upon window close
by running run-webkit-httpd and invoking a 1x1 image load of
http://127.0.0.1:8000/navigation/resources/save-Ping.php from an unload
handler.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::tryClose): Use the sudden termination bit to
close without waiting for a response.

* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::isSuddenTerminationEnabled): Expose the bit.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (192527 => 192528)

--- trunk/Source/WebKit2/ChangeLog	2015-11-17 21:30:01 UTC (rev 192527)
+++ trunk/Source/WebKit2/ChangeLog	2015-11-17 21:31:57 UTC (rev 192528)
@@ -1,3 +1,22 @@
+2015-11-17  Geoffrey Garen  
+
+A window with a hung tab waits 5s before closing
+https://bugs.webkit.org/show_bug.cgi?id=151319
+
+Reviewed by Anders Carlsson.
+
+I manually tested that I did not break unload events upon window close
+by running run-webkit-httpd and invoking a 1x1 image load of
+http://127.0.0.1:8000/navigation/resources/save-Ping.php from an unload
+handler.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::tryClose): Use the sudden termination bit to
+close without waiting for a response.
+
+* UIProcess/WebProcessProxy.h:
+(WebKit::WebProcessProxy::isSuddenTerminationEnabled): Expose the bit.
+
 2015-11-17  Carlos Garcia Campos  
 
 [GTK] Web Process crashes on reparenting a WebView with AC mode on


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (192527 => 192528)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2015-11-17 21:30:01 UTC (rev 192527)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2015-11-17 21:31:57 UTC (rev 192528)
@@ -861,6 +861,11 @@
 if (!isValid())
 return true;
 
+// Close without delay if the process allows it. Our goal is to terminate
+// the process, so we check a per-process status bit.
+if (m_process->isSuddenTerminationEnabled())
+return true;
+
 m_process->send(Messages::WebPage::TryClose(), m_pageID);
 m_process->responsivenessTimer().start();
 return false;


Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.h (192527 => 192528)

--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.h	2015-11-17 21:30:01 UTC (rev 192527)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.h	2015-11-17 21:31:57 UTC (rev 192528)
@@ -131,6 +131,7 @@
 
 void enableSuddenTermination();
 void disableSuddenTermination();
+bool isSuddenTerminationEnabled() { return !m_numberOfTimesSuddenTerminationWasDisabled; }
 
 void requestTermination();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192531] trunk/Source/JavaScriptCore

[mark . lam]

Title: [192531] trunk/Source/_javascript_Core








Revision 192531
Author mark@apple.com
Date 2015-11-17 13:55:33 -0800 (Tue, 17 Nov 2015)


Log Message
Use the JITAddGenerator snippet in the DFG.
https://bugs.webkit.org/show_bug.cgi?id=151266

Reviewed by Geoffrey Garen.

No tests added because the op_add.js stress test already tests for correctness
(using the LLINT as a reference).

Performance-wise, the difference from the pre-existing DFG implementation is
insignificant (at least as measured on x86 and x86_64).  We're moving forward
with adopting this implementation because it unifies the 32-bit and 64-bit
implementations, as well as lays ground work for a repatching inline cache
implementation of op_add later.

* dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::resultType):
- Made an assertion less restrictive.  For ValueAdd operands, the DFG thinks that
  the operand can also be empty (though we should never see this in practice).

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- Add fallback to unused type operands.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueAdd):
- Introduce a common function to compile the ValueAdd node.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::JSValueOperand::JSValueOperand):
- Add the forwarding constructor so that we can use Optional.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Changed to use the common compileValueAdd().

* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::moveValue):
- Similar to moveTrustedValue() but used for untrusted constants.

* jit/JITAddGenerator.cpp:
(JSC::JITAddGenerator::generateFastPath):
* jit/JITAddGenerator.h:
(JSC::JITAddGenerator::JITAddGenerator):
- Updated to take the left or right operand as a constant.  This is necessary
  because the client should not be making assumptions about whether the snippet
  will determine the operation to be commutative or not.  Instead, the client
  should just pass in the operands and let the snippet do any operand order
  swapping if necessary.

* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
- Updated to use the new JITAddGenerator interface.

* tests/stress/op_add.js:
(stringifyIfNeeded):
(runTest):
- Made test output more clear about when string results are expected.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractValue.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
trunk/Source/_javascript_Core/jit/JITAddGenerator.cpp
trunk/Source/_javascript_Core/jit/JITAddGenerator.h
trunk/Source/_javascript_Core/jit/JITArithmetic.cpp
trunk/Source/_javascript_Core/tests/stress/op_add.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192530 => 192531)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 21:45:32 UTC (rev 192530)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 21:55:33 UTC (rev 192531)
@@ -1,3 +1,65 @@
+2015-11-17  Mark Lam  
+
+Use the JITAddGenerator snippet in the DFG.
+https://bugs.webkit.org/show_bug.cgi?id=151266
+
+Reviewed by Geoffrey Garen.
+
+No tests added because the op_add.js stress test already tests for correctness
+(using the LLINT as a reference).
+
+Performance-wise, the difference from the pre-existing DFG implementation is
+insignificant (at least as measured on x86 and x86_64).  We're moving forward
+with adopting this implementation because it unifies the 32-bit and 64-bit
+implementations, as well as lays ground work for a repatching inline cache
+implementation of op_add later.
+
+* dfg/DFGAbstractValue.cpp:
+(JSC::DFG::AbstractValue::resultType):
+- Made an assertion less restrictive.  For ValueAdd operands, the DFG thinks that
+  the operand can also be empty (though we should never see this in practice).
+
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::fixupNode):
+- Add fallback to unused type operands.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileValueAdd):
+- Introduce a common function to compile the ValueAdd node.
+
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::JSValueOperand::JSValueOperand):
+- Add the forwarding constructor so that we can use Optional.
+
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+- Changed to use the common compileValueAdd().
+
+* jit/AssemblyHelpers.h:
+

[webkit-changes] [192535] trunk/Source/JavaScriptCore

[mark . lam]

Title: [192535] trunk/Source/_javascript_Core








Revision 192535
Author mark@apple.com
Date 2015-11-17 14:09:07 -0800 (Tue, 17 Nov 2015)


Log Message
Refactoring: move branchMul32's imm arg to the 3rd argument to be consistent.
https://bugs.webkit.org/show_bug.cgi?id=151358

Reviewed by Saam Barati.

branch32, branchAdd32, and branchSub32 all have it as the 3rd argument.
branchMul32 is the odd man out.  This patch makes branchMul32 consistent with
the others.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchMul32):
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branchMul32):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchMul32):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchMul32):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchNeg32):
(JSC::MacroAssemblerSH4::branchMul32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchMul32):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mul):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/jit/JITArithmetic.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192534 => 192535)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:05:15 UTC (rev 192534)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:09:07 UTC (rev 192535)
@@ -1,5 +1,35 @@
 2015-11-17  Mark Lam  
 
+Refactoring: move branchMul32's imm arg to the 3rd argument to be consistent.
+https://bugs.webkit.org/show_bug.cgi?id=151358
+
+Reviewed by Saam Barati.
+
+branch32, branchAdd32, and branchSub32 all have it as the 3rd argument.
+branchMul32 is the odd man out.  This patch makes branchMul32 consistent with
+the others.
+
+* assembler/MacroAssembler.h:
+(JSC::MacroAssembler::branchAdd32):
+(JSC::MacroAssembler::branchMul32):
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::branchMul32):
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::branchMul32):
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::branchMul32):
+* assembler/MacroAssemblerMIPS.h:
+(JSC::MacroAssemblerMIPS::branchMul32):
+* assembler/MacroAssemblerSH4.h:
+(JSC::MacroAssemblerSH4::branchNeg32):
+(JSC::MacroAssemblerSH4::branchMul32):
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::branchMul32):
+* jit/JITArithmetic.cpp:
+(JSC::JIT::emit_op_mul):
+
+2015-11-17  Mark Lam  
+
 Use the JITAddGenerator snippet in the DFG.
 https://bugs.webkit.org/show_bug.cgi?id=151266
 


Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (192534 => 192535)

--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2015-11-17 22:05:15 UTC (rev 192534)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2015-11-17 22:09:07 UTC (rev 192535)
@@ -1605,7 +1605,7 @@
 return branchAdd32(cond, src, imm.asTrustedImm32(), dest);
 }
 
-Jump branchMul32(ResultCondition cond, Imm32 imm, RegisterID src, RegisterID dest)
+Jump branchMul32(ResultCondition cond, RegisterID src, Imm32 imm, RegisterID dest)
 {
 if (src == dest)
 ASSERT(haveScratchRegisterForBlinding());
@@ -1618,7 +1618,7 @@
 loadXorBlindedConstant(xorBlindConstant(imm), dest);
 return branchMul32(cond, src, dest);  
 }
-return branchMul32(cond, imm.asTrustedImm32(), src, dest);
+return branchMul32(cond, src, imm.asTrustedImm32(), dest);
 }
 
 // branchSub32 takes a scratch register as 32 bit platforms make use of this,


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (192534 => 192535)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2015-11-17 22:05:15 UTC (rev 192534)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2015-11-17 22:09:07 UTC (rev 192535)
@@ -825,7 +825,7 @@
 return branchMul32(cond, src, dest, dest);
 }
 
-Jump branchMul32(ResultCondition cond, TrustedImm32 imm, RegisterID src, RegisterID dest)
+Jump branchMul32(ResultCondition cond, RegisterID src, TrustedImm32 imm, RegisterID dest)
 {
 ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond 

[webkit-changes] [192536] trunk/Source/JavaScriptCore

[akling]

Title: [192536] trunk/Source/_javascript_Core








Revision 192536
Author akl...@apple.com
Date 2015-11-17 14:13:41 -0800 (Tue, 17 Nov 2015)


Log Message
[JSC] JSPropertyNameEnumerator could be destructorless.


Reviewed by Mark Lam.

Make JSPropertyNameEnumerator destructorless and have it store the property names
cache in CopiedSpace. This was the most popular occupant of 64-byte destructor cells
in MarkedSpace, so making it destructorless gets rid of some ill-filled MarkedBlocks.

This patch had two issues on 32-bit platforms when first landed:

- Copied space allocations are required to be 8-byte divisible in size.

- WriteBarrier and WriteBarrier are not the same size on 32-bit;
  the former is a 64-bit EncodedJSValue internally, and the latter is a 32-bit JSCell*.
  My patch was reinterpret_cast'ing a WriteBarrier to a WriteBarrier
  when passing to SlotVisitor::appendValues(), which led to invalid addresses getting
  marked and strings getting GC'd prematurely.

* heap/CopyToken.h:
* runtime/JSPropertyNameEnumerator.cpp:
(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):
(JSC::JSPropertyNameEnumerator::destroy): Deleted.
* runtime/JSPropertyNameEnumerator.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/CopyToken.h
trunk/Source/_javascript_Core/runtime/JSPropertyNameEnumerator.cpp
trunk/Source/_javascript_Core/runtime/JSPropertyNameEnumerator.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192535 => 192536)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:09:07 UTC (rev 192535)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 22:13:41 UTC (rev 192536)
@@ -1,3 +1,32 @@
+2015-11-17  Andreas Kling  
+
+[JSC] JSPropertyNameEnumerator could be destructorless.
+
+
+Reviewed by Mark Lam.
+
+Make JSPropertyNameEnumerator destructorless and have it store the property names
+cache in CopiedSpace. This was the most popular occupant of 64-byte destructor cells
+in MarkedSpace, so making it destructorless gets rid of some ill-filled MarkedBlocks.
+
+This patch had two issues on 32-bit platforms when first landed:
+
+- Copied space allocations are required to be 8-byte divisible in size.
+
+- WriteBarrier and WriteBarrier are not the same size on 32-bit;
+  the former is a 64-bit EncodedJSValue internally, and the latter is a 32-bit JSCell*.
+  My patch was reinterpret_cast'ing a WriteBarrier to a WriteBarrier
+  when passing to SlotVisitor::appendValues(), which led to invalid addresses getting
+  marked and strings getting GC'd prematurely.
+
+* heap/CopyToken.h:
+* runtime/JSPropertyNameEnumerator.cpp:
+(JSC::JSPropertyNameEnumerator::finishCreation):
+(JSC::JSPropertyNameEnumerator::visitChildren):
+(JSC::JSPropertyNameEnumerator::copyBackingStore):
+(JSC::JSPropertyNameEnumerator::destroy): Deleted.
+* runtime/JSPropertyNameEnumerator.h:
+
 2015-11-17  Mark Lam  
 
 Refactoring: move branchMul32's imm arg to the 3rd argument to be consistent.


Modified: trunk/Source/_javascript_Core/heap/CopyToken.h (192535 => 192536)

--- trunk/Source/_javascript_Core/heap/CopyToken.h	2015-11-17 22:09:07 UTC (rev 192535)
+++ trunk/Source/_javascript_Core/heap/CopyToken.h	2015-11-17 22:13:41 UTC (rev 192536)
@@ -32,7 +32,8 @@
 ButterflyCopyToken,
 TypedArrayVectorCopyToken,
 MapBackingStoreCopyToken,
-DirectArgumentsOverridesCopyToken
+DirectArgumentsOverridesCopyToken,
+JSPropertyNameEnumeratorCopyToken,
 };
 
 } // namespace JSC


Modified: trunk/Source/_javascript_Core/runtime/JSPropertyNameEnumerator.cpp (192535 => 192536)

--- trunk/Source/_javascript_Core/runtime/JSPropertyNameEnumerator.cpp	2015-11-17 22:09:07 UTC (rev 192535)
+++ trunk/Source/_javascript_Core/runtime/JSPropertyNameEnumerator.cpp	2015-11-17 22:13:41 UTC (rev 192536)
@@ -26,6 +26,8 @@
 #include "config.h"
 #include "JSPropertyNameEnumerator.h"
 
+#include "CopiedBlockInlines.h"
+#include "CopyVisitorInlines.h"
 #include "JSCInlines.h"
 #include "StrongInlines.h"
 
@@ -70,25 +72,46 @@
 m_endStructurePropertyIndex = endStructurePropertyIndex;
 m_endGenericPropertyIndex = vector.size();
 
-m_propertyNames.resizeToFit(vector.size());
-for (unsigned i = 0; i < vector.size(); ++i) {
-const Identifier& identifier = vector[i];
-m_propertyNames[i].set(vm, this, jsString(, identifier.string()));
+if (!vector.isEmpty()) {
+void* backingStore;
+RELEASE_ASSERT(vm.heap.tryAllocateStorage(this, propertyNameCacheSize(), ));
+WriteBarrier* propertyNames = reinterpret_cast(backingStore);
+m_propertyNames.set(vm, this, propertyNames);
+
+for (unsigned i = 0; i < vector.size(); 

[webkit-changes] [192540] trunk

[fpizlo]

Title: [192540] trunk








Revision 192540
Author fpi...@apple.com
Date 2015-11-17 14:31:40 -0800 (Tue, 17 Nov 2015)


Log Message
CheckAdd/Mul should have commutativity optimizations in B3->Air lowering
https://bugs.webkit.org/show_bug.cgi?id=151214

Reviewed by Geoffrey Garen.

Source/_javascript_Core:

This is an overhaul of CheckAdd/CheckSub/CheckMul that fixes bugs, improves codegen, and
simplifies the contract between B3 and its client.

Previously, the idea was that the operands to the Air BranchAdd/Sub/Mul matched the children of
the B3 CheckAdd/Sub/Mul, or at least, that's what the B3::CheckSpecial would make you believe.
This meant that B3/Air had to avoid optimizations that would break this protocol. This prevented
commutativity optimizations on CheckAdd/Mul and it also prevented strength reduction from
CheckMul(x, 2) to CheckAdd(x, x), for example. Those optimizations would break things because the
client's Stackmap generation callback was allowed to assume that the first entry in params.reps
was the first child. Also, there was a contract between B3 and its client that for CheckAdd/Sub,
the client would undo the operation by doing the opposite operation with the params.reps[0] as the
source and params.reps[1] as the destination.

This not only prevented commutativity optimizations, it also led to bugs. Here are two bugs that
we had:

- Add(x, x) would not work. The client would be told to undo the add using %x as both the source
  and destination. The client would use a sub() instruction. The result would not be x - it would
  be zero.

- Mul where the result got coalesced with one of the sources. You can't undo a multiplication, so
  you need to keep the inputs alive until after the result is computed - i.e. the inputs are late
  uses. I initially thought I worked around this by using a three-operand form of Mul, but of
  course that doesn't actually fix the issue.

This patch fixes these issues comprehensively by introducing the following changes:

The params.reps corresponding to the first two children of CheckAdd/Sub/Mul and the first child of
Check are always garbage: if you want to know the values of those children in the slow path, pass
them as additional stackmap children. This makes it clear to the compiler whose values you
actually care about, and frees the compiler to reorder and commute the non-stackmap children.

The "undo" of an Add or Sub is handled internally by B3: the client doesn't have to know anything
about undoing. B3 does it. The contract is simply that if a B3::Value* is a stackmap child of a
CheckXYZ, then the corresponding entry in params.reps inside the stackmap generator callback will
contain the value of that Value*. For Add and Sub, B3 undoes the operation. For Add(x, x), the
undo uses the carry flag and some shift magic. For Mul, B3 uses LateUse:

A new kind of Arg::Role called Arg::LateUse is introduced: This kind of use means that the use
happens at the start of the execution of the next instruction. None of the built-in Air opcodes
use LateUse, but it is used by B3::CheckSpecial. We use it to implement CheckMul.

Finally, this change fixes testComplex to actually create many live variables. This revealed a
really dumb pathology in allocateStack(), and this patch fixes it. Basically, it's a bad idea to
build interference graphs by repeatedly recreating the same cliques.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::setCarry):
(JSC::MacroAssemblerX86Common::invert):
* b3/B3CheckSpecial.cpp:
(JSC::B3::Air::numB3Args):
(JSC::B3::CheckSpecial::Key::Key):
(JSC::B3::CheckSpecial::Key::dump):
(JSC::B3::CheckSpecial::CheckSpecial):
(JSC::B3::CheckSpecial::forEachArg):
(JSC::B3::CheckSpecial::isValid):
(JSC::B3::CheckSpecial::generate):
(JSC::B3::CheckSpecial::dumpImpl):
(JSC::B3::CheckSpecial::deepDumpImpl):
* b3/B3CheckSpecial.h:
(JSC::B3::CheckSpecial::Key::Key):
(JSC::B3::CheckSpecial::Key::operator==):
(JSC::B3::CheckSpecial::Key::operator!=):
(JSC::B3::CheckSpecial::Key::opcode):
(JSC::B3::CheckSpecial::Key::numArgs):
(JSC::B3::CheckSpecial::Key::stackmapRole):
(JSC::B3::CheckSpecial::Key::hash):
* b3/B3CheckValue.cpp:
(JSC::B3::CheckValue::~CheckValue):
(JSC::B3::CheckValue::convertToAdd):
(JSC::B3::CheckValue::CheckValue):
* b3/B3CheckValue.h:
* b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::checkMulConstant):
(JSC::B3::Const32Value::checkNegConstant):
(JSC::B3::Const32Value::divConstant):
* b3/B3Const32Value.h:
* b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::checkMulConstant):
(JSC::B3::Const64Value::checkNegConstant):
(JSC::B3::Const64Value::divConstant):
* b3/B3Const64Value.h:
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::appendBinOp):
(JSC::B3::Air::LowerToAir::lower):
* b3/B3Opcode.h:
* b3/B3PatchpointSpecial.cpp:
(JSC::B3::PatchpointSpecial::~PatchpointSpecial):
(JSC::B3::PatchpointSpecial::forEachArg):
(JSC::B3::PatchpointSpecial::isValid):
* b3/B3ReduceStrength.cpp:
* 

[webkit-changes] [192527] trunk/Source/JavaScriptCore

[msaboff]

Title: [192527] trunk/Source/_javascript_Core








Revision 192527
Author msab...@apple.com
Date 2015-11-17 13:30:01 -0800 (Tue, 17 Nov 2015)


Log Message
Reserved VM pool established in r187125 is likely too conservative
https://bugs.webkit.org/show_bug.cgi?id=151351

Reviewed by Filip Pizlo.

Reduce the VM allocation reserved pool from 25% to 15% for ARM32.

* jit/ExecutableAllocator.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/ExecutableAllocator.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192526 => 192527)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 21:16:07 UTC (rev 192526)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 21:30:01 UTC (rev 192527)
@@ -1,3 +1,14 @@
+2015-11-17  Michael Saboff  
+
+Reserved VM pool established in r187125 is likely too conservative
+https://bugs.webkit.org/show_bug.cgi?id=151351
+
+Reviewed by Filip Pizlo.
+
+Reduce the VM allocation reserved pool from 25% to 15% for ARM32.
+
+* jit/ExecutableAllocator.h:
+
 2015-11-17  Saam barati  
 
 FTLLazySlowPaths should be able to handle being passed the zero register as a location


Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.h (192526 => 192527)

--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.h	2015-11-17 21:16:07 UTC (rev 192526)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.h	2015-11-17 21:30:01 UTC (rev 192527)
@@ -82,7 +82,11 @@
 #else
 static const size_t fixedExecutableMemoryPoolSize = 32 * 1024 * 1024;
 #endif
+#if CPU(ARM)
+static const double executablePoolReservationFraction = 0.15;
+#else
 static const double executablePoolReservationFraction = 0.25;
+#endif
 
 extern uintptr_t startOfFixedExecutableMemoryPool;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192529] trunk/Source/JavaScriptCore

[fpizlo]

Title: [192529] trunk/Source/_javascript_Core








Revision 192529
Author fpi...@apple.com
Date 2015-11-17 13:41:43 -0800 (Tue, 17 Nov 2015)


Log Message
It's best for the DFG to always have some guess of basic block frequency
https://bugs.webkit.org/show_bug.cgi?id=151350

Reviewed by Geoffrey Garen.

It'll simplify things for B3 if we always have some estimate of block frequency, even if it's not
a great estimate. Using NaN as an estimate is probably worse than using any non-NaN number.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGCriticalEdgeBreakingPhase.cpp:
(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge):
* dfg/DFGLoopPreHeaderCreationPhase.cpp:
(JSC::DFG::createPreHeader):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGCriticalEdgeBreakingPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGLoopPreHeaderCreationPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192528 => 192529)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-17 21:31:57 UTC (rev 192528)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-17 21:41:43 UTC (rev 192529)
@@ -1,3 +1,22 @@
+2015-11-17  Filip Pizlo  
+
+It's best for the DFG to always have some guess of basic block frequency
+https://bugs.webkit.org/show_bug.cgi?id=151350
+
+Reviewed by Geoffrey Garen.
+
+It'll simplify things for B3 if we always have some estimate of block frequency, even if it's not
+a great estimate. Using NaN as an estimate is probably worse than using any non-NaN number.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::inlineCall):
+(JSC::DFG::ByteCodeParser::handleInlining):
+(JSC::DFG::ByteCodeParser::parseCodeBlock):
+* dfg/DFGCriticalEdgeBreakingPhase.cpp:
+(JSC::DFG::CriticalEdgeBreakingPhase::breakCriticalEdge):
+* dfg/DFGLoopPreHeaderCreationPhase.cpp:
+(JSC::DFG::createPreHeader):
+
 2015-11-17  Michael Saboff  
 
 Reserved VM pool established in r187125 is likely too conservative


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (192528 => 192529)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2015-11-17 21:31:57 UTC (rev 192528)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2015-11-17 21:41:43 UTC (rev 192529)
@@ -1505,7 +1505,7 @@
 ASSERT(lastBlock->terminal());
 
 // Need to create a new basic block for the continuation at the caller.
-RefPtr block = adoptRef(new BasicBlock(nextOffset, m_numArguments, m_numLocals, PNaN));
+RefPtr block = adoptRef(new BasicBlock(nextOffset, m_numArguments, m_numLocals, 1));
 
 // Link the early returns to the basic block we're about to create.
 for (size_t i = 0; i < inlineStackEntry.m_unlinkedBlocks.size(); ++i) {
@@ -1848,7 +1848,7 @@
 
 for (unsigned i = 0; i < callLinkStatus.size(); ++i) {
 m_currentIndex = oldOffset;
-RefPtr block = adoptRef(new BasicBlock(UINT_MAX, m_numArguments, m_numLocals, PNaN));
+RefPtr block = adoptRef(new BasicBlock(UINT_MAX, m_numArguments, m_numLocals, 1));
 m_currentBlock = block.get();
 m_graph.appendBlock(block);
 prepareToParseBlock();
@@ -1899,7 +1899,7 @@
 }
 
 RefPtr slowPathBlock = adoptRef(
-new BasicBlock(UINT_MAX, m_numArguments, m_numLocals, PNaN));
+new BasicBlock(UINT_MAX, m_numArguments, m_numLocals, 1));
 m_currentIndex = oldOffset;
 m_exitOK = true;
 data.fallThrough = BranchTarget(slowPathBlock.get());
@@ -1933,7 +1933,7 @@
 }
 
 RefPtr continuationBlock = adoptRef(
-new BasicBlock(UINT_MAX, m_numArguments, m_numLocals, PNaN));
+new BasicBlock(UINT_MAX, m_numArguments, m_numLocals, 1));
 m_graph.appendBlock(continuationBlock);
 if (verbose)
 dataLog("Adding unlinked block ", RawPointer(continuationBlock.get()), " (continuation)\n");
@@ -4895,7 +4895,7 @@
 m_currentBlock = m_graph.lastBlock();
 m_currentBlock->bytecodeBegin = m_currentIndex;
 } else {
-RefPtr block = adoptRef(new BasicBlock(m_currentIndex, m_numArguments, m_numLocals, PNaN));
+RefPtr block = adoptRef(new BasicBlock(m_currentIndex, m_numArguments, m_numLocals, 1));
 m_currentBlock = block.get();
 // This assertion checks two things:
 // 1) If the bytecodeBegin is greater than currentIndex, then something has gone


Modified: trunk/Source/_javascript_Core/dfg/DFGCriticalEdgeBreakingPhase.cpp (192528 => 192529)

--- trunk/Source/_javascript_Core/dfg/DFGCriticalEdgeBreakingPhase.cpp	2015-11-17 21:31:57 UTC (rev 192528)
+++ 

[webkit-changes] [192532] branches/safari-601.4-branch/

[bshafiei]

Title: [192532] branches/safari-601.4-branch/








Revision 192532
Author bshaf...@apple.com
Date 2015-11-17 13:57:09 -0800 (Tue, 17 Nov 2015)


Log Message
New Branch.

Added Paths

branches/safari-601.4-branch/




Diff

Property changes: branches/safari-601.4-branch



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192565] trunk/Tools

[ap]

Title: [192565] trunk/Tools








Revision 192565
Author a...@apple.com
Date 2015-11-17 22:27:09 -0800 (Tue, 17 Nov 2015)


Log Message
run-webkit-tests should not truncate persistent lines
https://bugs.webkit.org/show_bug.cgi?id=151376
rdar://problem/23162775

Reviewed by Antti Koivisto.

It is OK to truncate progress lines, but it's not OK to truncate error (or otherwise
unexpected result) messages that remain on the screen to be read. In practice, this
almost always truncates the test path, which is important to see.

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer._test_status_line):
(Printer.print_finished_test):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_test_status_line):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py
trunk/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (192564 => 192565)

--- trunk/Tools/ChangeLog	2015-11-18 03:00:43 UTC (rev 192564)
+++ trunk/Tools/ChangeLog	2015-11-18 06:27:09 UTC (rev 192565)
@@ -1,3 +1,21 @@
+2015-11-17  Alexey Proskuryakov  
+
+run-webkit-tests should not truncate persistent lines
+https://bugs.webkit.org/show_bug.cgi?id=151376
+rdar://problem/23162775
+
+Reviewed by Antti Koivisto.
+
+It is OK to truncate progress lines, but it's not OK to truncate error (or otherwise
+unexpected result) messages that remain on the screen to be read. In practice, this
+almost always truncates the test path, which is important to see.
+
+* Scripts/webkitpy/layout_tests/views/printing.py:
+(Printer._test_status_line):
+(Printer.print_finished_test):
+* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
+(Testprinter.test_test_status_line):
+
 2015-11-16  Carlos Garcia Campos  
 
 Unreviewed. Fix GTK+ unit tests after r192469.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py (192564 => 192565)

--- trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py	2015-11-18 03:00:43 UTC (rev 192564)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/printing.py	2015-11-18 06:27:09 UTC (rev 192565)
@@ -287,10 +287,10 @@
 self._print_quiet(summary)
 self._print_quiet("")
 
-def _test_status_line(self, test_name, suffix):
+def _test_status_line(self, test_name, suffix, truncate=True):
 format_string = '[%d/%d] %s%s'
 status_line = format_string % (self.num_started, self.num_tests, test_name, suffix)
-if len(status_line) > self._meter.number_of_columns():
+if truncate and len(status_line) > self._meter.number_of_columns():
 overflow_columns = len(status_line) - self._meter.number_of_columns()
 ellipsis = '...'
 if len(test_name) < overflow_columns + len(ellipsis) + 2:
@@ -324,7 +324,7 @@
 if self._options.details:
 self._print_test_trace(result, exp_str, got_str)
 elif (self._options.verbose and not self._options.debug_rwt_logging) or not expected:
-self.writeln(self._test_status_line(test_name, result_message))
+self.writeln(self._test_status_line(test_name, result_message, truncate=False))
 elif self.num_started == self.num_tests:
 self._meter.write_update('')
 else:
@@ -334,7 +334,7 @@
 self._completed_tests.append([test_name, result_message])
 
 for test_name, result_message in self._completed_tests:
-self._meter.write_throttled_update(self._test_status_line(test_name, result_message))
+self._meter.write_throttled_update(self._test_status_line(test_name, result_message, truncate=False))
 self._completed_tests = []
 self._running_tests.remove(test_name)
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py (192564 => 192565)

--- trunk/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py	2015-11-18 03:00:43 UTC (rev 192564)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py	2015-11-18 06:27:09 UTC (rev 192565)
@@ -150,6 +150,11 @@
 self.assertEqual(80, len(actual))
 self.assertEqual(actual, '[0/0] fast/dom/HTMLFormElement/associa...after-index-assertion-fail1.html passed')
 
+printer._meter.number_of_columns = lambda: 80
+actual = printer._test_status_line('fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html', ' passed', truncate=False)
+self.assertEqual(90, len(actual))
+self.assertEqual(actual, '[0/0] fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html passed')
+
 printer._meter.number_of_columns = lambda: 89
 actual = printer._test_status_line('fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html', ' passed')