date:20151120

[webkit-changes] [192685] trunk/Tools

2015-11-20 Thread mcatanzaro

Title: [192685] trunk/Tools








Revision 192685
Author mcatanz...@igalia.com
Date 2015-11-20 07:17:36 -0800 (Fri, 20 Nov 2015)


Log Message
Unreviewed, fix installation of ninja-build after the previous commit

* gtk/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (192684 => 192685)

--- trunk/Tools/ChangeLog	2015-11-20 15:01:27 UTC (rev 192684)
+++ trunk/Tools/ChangeLog	2015-11-20 15:17:36 UTC (rev 192685)
@@ -1,5 +1,11 @@
 2015-11-20  Michael Catanzaro  
 
+Unreviewed, fix installation of ninja-build after the previous commit
+
+* gtk/install-dependencies:
+
+2015-11-20  Michael Catanzaro  
+
 [GTK] install-dependencies should run installer exactly once
 https://bugs.webkit.org/show_bug.cgi?id=151477
 


Modified: trunk/Tools/gtk/install-dependencies (192684 => 192685)

--- trunk/Tools/gtk/install-dependencies	2015-11-20 15:01:27 UTC (rev 192684)
+++ trunk/Tools/gtk/install-dependencies	2015-11-20 15:17:36 UTC (rev 192685)
@@ -92,6 +92,7 @@
 libxt-dev \
 libxtst-dev \
 libwayland-dev \
+ninja-build \
 ruby \
 xfonts-utils"
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192683] trunk/Tools

2015-11-20 Thread mcatanzaro

Title: [192683] trunk/Tools








Revision 192683
Author mcatanz...@igalia.com
Date 2015-11-20 06:41:50 -0800 (Fri, 20 Nov 2015)


Log Message
[GTK] install-dependencies should run installer exactly once
https://bugs.webkit.org/show_bug.cgi?id=151477

Reviewed by Carlos Garcia Campos.

* gtk/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (192682 => 192683)

--- trunk/Tools/ChangeLog	2015-11-20 11:38:10 UTC (rev 192682)
+++ trunk/Tools/ChangeLog	2015-11-20 14:41:50 UTC (rev 192683)
@@ -1,3 +1,12 @@
+2015-11-20  Michael Catanzaro  
+
+[GTK] install-dependencies should run installer exactly once
+https://bugs.webkit.org/show_bug.cgi?id=151477
+
+Reviewed by Carlos Garcia Campos.
+
+* gtk/install-dependencies:
+
 2015-11-20  Csaba Osztrogonác  
 
 [EFL] Enable FTL JIT by default on X86_64


Modified: trunk/Tools/gtk/install-dependencies (192682 => 192683)

--- trunk/Tools/gtk/install-dependencies	2015-11-20 11:38:10 UTC (rev 192682)
+++ trunk/Tools/gtk/install-dependencies	2015-11-20 14:41:50 UTC (rev 192683)
@@ -22,20 +22,13 @@
 exit 0
 fi
 
-# dnf - Fedora 22 and above
+# dnf - Fedora
 dnf --version &> /dev/null
 if [ $? -eq 0 ]; then
-installFedoraDependencies dnf
+installDependenciesWithDnf
 exit 0
 fi
 
-# yum - Fedora 21 and below
-yum --version &> /dev/null
-if [ $? -eq 0 ]; then
-installFedoraDependencies yum
-exit 0
-fi
-
 # pacman - Arch Linux
 # pacman --version and pacman --help both return non-0
 pacman -Ss &> /dev/null
@@ -49,7 +42,7 @@
 
 function installDependenciesWithApt {
 # These are dependencies necessary for building WebKitGTK+.
-apt-get install \
+packages=" \
 autoconf \
 automake \
 autopoint \
@@ -100,10 +93,10 @@
 libxtst-dev \
 libwayland-dev \
 ruby \
-xfonts-utils
+xfonts-utils"
 
 # These are dependencies necessary for running tests.
-apt-get install \
+packages="$packages \
 apache2 \
 curl \
 dbus-x11 \
@@ -115,10 +108,10 @@
 ruby \
 ruby-json \
 ruby-highline \
-xvfb
+xvfb"
 
 # These are dependencies necessary for building the jhbuild.
-apt-get install \
+packages="$packages \
 git \
 gobject-introspection \
 icon-naming-utils \
@@ -153,16 +146,14 @@
 x11proto-xf86dri-dev \
 xfonts-utils \
 xtrans-dev \
-xutils-dev
+xutils-dev"
 
 # These are dependencies necessary for using webkit-patch
-apt-get install \
+packages="$packages \
 git-svn \
-subversion
+subversion"
 
-# ninja is a faster build system than GNU make, but it doesn't
-# exist on Ubuntu 12.04
-apt-get install ninja-build || true
+apt-get install $packages
 }
 
 function installDependenciesWithPacman {
@@ -297,9 +288,9 @@
 echo "https://wiki.archlinux.org/index.php/Python#Dealing_with_version_problem_in_build_scripts"
 }
 
-function installFedoraDependencies {
+function installDependenciesWithDnf {
 # These are dependencies necessary for building WebKitGTK+.
-$1 install \
+packages=" \
 atk-devel \
 autoconf \
 automake \
@@ -351,10 +342,10 @@
 python-devel \
 orc-devel \
 ruby \
-sqlite-devel
+sqlite-devel"
 
 # These are dependencies necessary for running tests.
-$1 install \
+packages="$packages \
 curl \
 dbus-x11 \
 hunspell-en \
@@ -369,10 +360,10 @@
 ruby \
 rubygem-json \
 rubygem-highline \
-xorg-x11-server-Xvfb
+xorg-x11-server-Xvfb"
 
 # These are dependencies necessary for building the jhbuild.
-$1 install \
+packages="$packages \
 docbook-utils \
 docbook-utils-pdf \
 git \
@@ -393,12 +384,14 @@
 xorg-x11-font-utils \
 xorg-x11-proto-devel \
 xorg-x11-util-macros \
-xorg-x11-xtrans-devel
+xorg-x11-xtrans-devel"
 
 # These are dependencies necessary for using webkit-patch
-$1 install \
+packages="$packages
 git-svn \
-subversion
+subversion"
+
+dnf install $packages
 }
 
 checkInstaller






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192684] trunk/LayoutTests

2015-11-20 Thread youenn . fablet

Title: [192684] trunk/LayoutTests








Revision 192684
Author youenn.fab...@crf.canon.fr
Date 2015-11-20 07:01:27 -0800 (Fri, 20 Nov 2015)


Log Message
Changing some imported/w3c/web-platform-tests/html/semantics expectations from Timeout/Failure to Pass
https://bugs.webkit.org/show_bug.cgi?id=151492

Unreviewed.


* TestExpectations: Removing timeout/failure expectations.
* platform/efl/TestExpectations: Removing no longer needed pass expectation.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (192683 => 192684)

--- trunk/LayoutTests/ChangeLog	2015-11-20 14:41:50 UTC (rev 192683)
+++ trunk/LayoutTests/ChangeLog	2015-11-20 15:01:27 UTC (rev 192684)
@@ -1,3 +1,13 @@
+2015-11-20  Youenn Fablet  
+
+Changing some imported/w3c/web-platform-tests/html/semantics expectations from Timeout/Failure to Pass
+https://bugs.webkit.org/show_bug.cgi?id=151492
+
+Unreviewed.
+
+* TestExpectations: Removing timeout/failure expectations.
+* platform/efl/TestExpectations: Removing no longer needed pass expectation.
+
 2015-11-20  David Kilzer  
 
 Unskip mediastream tests after crash was fixed


Modified: trunk/LayoutTests/TestExpectations (192683 => 192684)

--- trunk/LayoutTests/TestExpectations	2015-11-20 14:41:50 UTC (rev 192683)
+++ trunk/LayoutTests/TestExpectations	2015-11-20 15:01:27 UTC (rev 192684)
@@ -292,7 +292,6 @@
 imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-twice.html [ Slow ]
 
 # New W3C ref tests that are failing.
-webkit.org/b/148847 imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html [ ImageOnlyFailure ]
 webkit.org/b/148856 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ ImageOnlyFailure ]
 
 # @supports W3C Failures
@@ -356,10 +355,8 @@
 
 # W3C html timing out tests
 imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html [ Timeout ]
-imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_multiple.html [ Timeout ]
 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01.html [ Timeout ]
 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-style-element/style-error-01.html [ Timeout ]
-imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/object-handler.html [ Timeout ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html [ Timeout ]
 
 # Imported W3C canvas failed tests


Modified: trunk/LayoutTests/platform/efl/TestExpectations (192683 => 192684)

--- trunk/LayoutTests/platform/efl/TestExpectations	2015-11-20 14:41:50 UTC (rev 192683)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2015-11-20 15:01:27 UTC (rev 192684)
@@ -1280,7 +1280,6 @@
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html [ Pass ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_initially_paused.html [ Pass ]
 imported/w3c/web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol.html [ Pass ]
-imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-wbr-element/wbr-element.html [ Pass ]
 css3/conditional/w3c/at-supports-010.html [ Pass ]
 css3/conditional/w3c/at-supports-014.html [ Pass ]
 fast/borders/border-painting-dashed.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192682] trunk

2015-11-20 Thread ossy

Title: [192682] trunk








Revision 192682
Author o...@webkit.org
Date 2015-11-20 03:38:10 -0800 (Fri, 20 Nov 2015)


Log Message
[EFL] Enable FTL JIT by default on X86_64
https://bugs.webkit.org/show_bug.cgi?id=143822

Reviewed by Carlos Garcia Campos.

.:

* Source/cmake/OptionsEfl.cmake:

Tools:

* Scripts/build-jsc:
* Scripts/run-_javascript_core-tests:
* Scripts/webkitperl/FeatureList.pm:
* efl/jhbuild.modules:
* gtk/jhbuildrc:
* jhbuild/jhbuildrc_common.py:
(init):

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-jsc
trunk/Tools/Scripts/run-_javascript_core-tests
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/Tools/efl/jhbuild.modules
trunk/Tools/gtk/jhbuildrc
trunk/Tools/jhbuild/jhbuildrc_common.py




Diff

Modified: trunk/ChangeLog (192681 => 192682)

--- trunk/ChangeLog	2015-11-20 09:33:23 UTC (rev 192681)
+++ trunk/ChangeLog	2015-11-20 11:38:10 UTC (rev 192682)
@@ -1,3 +1,12 @@
+2015-11-20  Csaba Osztrogonác  
+
+[EFL] Enable FTL JIT by default on X86_64
+https://bugs.webkit.org/show_bug.cgi?id=143822
+
+Reviewed by Carlos Garcia Campos.
+
+* Source/cmake/OptionsEfl.cmake:
+
 2015-11-19  Commit Queue  
 
 Unreviewed, rolling out r192667 and r192668.


Modified: trunk/Source/cmake/OptionsEfl.cmake (192681 => 192682)

--- trunk/Source/cmake/OptionsEfl.cmake	2015-11-20 09:33:23 UTC (rev 192681)
+++ trunk/Source/cmake/OptionsEfl.cmake	2015-11-20 11:38:10 UTC (rev 192682)
@@ -66,6 +66,12 @@
 set(WebKit2_VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter")
 endif ()
 
+if (WTF_CPU_X86_64)
+set(ENABLE_FTL_DEFAULT ON)
+else ()
+set(ENABLE_FTL_DEFAULT OFF)
+endif ()
+
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_TRANSFORMS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ALLINONE_BUILD PUBLIC OFF)
@@ -88,6 +94,7 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA_V2 PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS_LEVEL_2 PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PUBLIC ${ENABLE_FTL_DEFAULT})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FULLSCREEN_API PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD_DEPRECATED PUBLIC ON)


Modified: trunk/Tools/ChangeLog (192681 => 192682)

--- trunk/Tools/ChangeLog	2015-11-20 09:33:23 UTC (rev 192681)
+++ trunk/Tools/ChangeLog	2015-11-20 11:38:10 UTC (rev 192682)
@@ -1,3 +1,18 @@
+2015-11-20  Csaba Osztrogonác  
+
+[EFL] Enable FTL JIT by default on X86_64
+https://bugs.webkit.org/show_bug.cgi?id=143822
+
+Reviewed by Carlos Garcia Campos.
+
+* Scripts/build-jsc:
+* Scripts/run-_javascript_core-tests:
+* Scripts/webkitperl/FeatureList.pm:
+* efl/jhbuild.modules:
+* gtk/jhbuildrc:
+* jhbuild/jhbuildrc_common.py:
+(init):
+
 2015-11-19  Michael Catanzaro  
 
 Unreviewed, install llvm-static on Fedora to fix build now FTL is enabled


Modified: trunk/Tools/Scripts/build-jsc (192681 => 192682)

--- trunk/Tools/Scripts/build-jsc	2015-11-20 09:33:23 UTC (rev 192681)
+++ trunk/Tools/Scripts/build-jsc	2015-11-20 11:38:10 UTC (rev 192682)
@@ -40,7 +40,7 @@
 my $shouldRunStaticAnalyzer = 0;
 my $coverageSupport = 0;
 my $showHelp = 0;
-my $ftlJIT = int(isAppleMacWebKit() && !willUseIOSSimulatorSDK());
+my $ftlJIT = int(isAppleMacWebKit() && !willUseIOSSimulatorSDK() || isX86_64() && (isGtk() || isEfl()));
 my $forceCLoop = 0;
 my $cli = 0;
 my $makeArgs = "";


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (192681 => 192682)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2015-11-20 09:33:23 UTC (rev 192681)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2015-11-20 11:38:10 UTC (rev 192682)
@@ -62,7 +62,7 @@
 my $gmallocPath = undef;
 my $gmallocDefaultPath = "/usr/lib/libgmalloc.dylib";
 
-my $enableFTL = isAppleMacWebKit() || (isGtk() && isX86_64());
+my $enableFTL = isAppleMacWebKit() || isX86_64() && (isGtk() || isEfl());
 my $createTarball = 0;
 my $remoteHost = 0;
 my $remoteConfigFile;


Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (192681 => 192682)

--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2015-11-20 09:33:23 UTC (rev 192681)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2015-11-20 11:38:10 UTC (rev 192682)
@@ -458,7 +458,7 @@
   define => "ENABLE_XSLT", default => 1, value => \$xsltSupport },
 
 { option => "ftl-jit", desc => "Toggle FTLJIT support",
-  define => "ENABLE_FTL_JIT", default => (isGtk() && isX86_64()), value => \$ftlJITSupport },
+  define => "ENABLE_FTL_JIT", default => (isX86_64() && (isGtk() || isEfl())) , value => \$ftlJITSupport },
 );

[webkit-changes] [192681] trunk/LayoutTests

2015-11-20 Thread ddkilzer

Title: [192681] trunk/LayoutTests








Revision 192681
Author ddkil...@apple.com
Date 2015-11-20 01:33:23 -0800 (Fri, 20 Nov 2015)


Log Message
Unskip mediastream tests after crash was fixed


* platform/mac/TestExpectations: Bug 151462 fixed the crash, so
unskip the tests again.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (192680 => 192681)

--- trunk/LayoutTests/ChangeLog	2015-11-20 09:25:56 UTC (rev 192680)
+++ trunk/LayoutTests/ChangeLog	2015-11-20 09:33:23 UTC (rev 192681)
@@ -1,3 +1,11 @@
+2015-11-20  David Kilzer  
+
+Unskip mediastream tests after crash was fixed
+
+
+* platform/mac/TestExpectations: Bug 151462 fixed the crash, so
+unskip the tests again.
+
 2015-11-19  Adam Bergkvist  
 
 WebRTC: Initial testing of updated RTCPeerConnection API


Modified: trunk/LayoutTests/platform/mac/TestExpectations (192680 => 192681)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-11-20 09:25:56 UTC (rev 192680)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-11-20 09:33:23 UTC (rev 192681)
@@ -156,25 +156,6 @@
 fast/mediastream/MediaStreamTrack-onended.html
 fast/mediastream/MediaStreamTrack.html
 
-# Media Stream tests that crash unexpectedly under GuardMalloc, see https://bugs.webkit.org/show_bug.cgi?id=151353
-fast/mediastream/delayed-permission-denied.html
-fast/mediastream/getusermedia.html
-fast/mediastream/MediaDevices-getUserMedia.html
-fast/mediastream/MediaStream-clone.html
-fast/mediastream/MediaStream-construct-with-ended-tracks.html
-fast/mediastream/MediaStream-video-element-track-stop.html
-fast/mediastream/MediaStream-video-element.html
-fast/mediastream/MediaStreamConstructor.html
-fast/mediastream/MediaStreamTrack-clone.html
-fast/mediastream/MediaStreamTrack-kind.html
-fast/mediastream/MediaStreamTrack-stop.html
-fast/mediastream/MediaStream-getTracks.html
-fast/mediastream/RTCSessionDescription.html
-fast/mediastream/enabled.html
-fast/mediastream/MediaStreamTrackEvent-constructor.html
-fast/mediastream/argument-types.html
-fast/mediastream/error.html
-
 # WebRTC is not supported yet.
 fast/mediastream/RTCIceCandidate.html
 fast/mediastream/RTCPeerConnection-AddRemoveStream.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192680] trunk/Source/WebCore

2015-11-20 Thread youenn . fablet

Title: [192680] trunk/Source/WebCore








Revision 192680
Author youenn.fab...@crf.canon.fr
Date 2015-11-20 01:25:56 -0800 (Fri, 20 Nov 2015)


Log Message
Use HTTPHeaderName as much as possible in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=151438

Reviewed by Darin Adler.

Removing XMLHttpRequest::setRequestHeaderInternal and XMLHttpRequest::getRequestHeader.
Using directly HTTPHeaderMap.add, HTTPHeaderMap.set and HTTPHeaderMap.get.

No change in behavior.

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::setRequestHeader):
(WebCore::XMLHttpRequest::getAllResponseHeaders):
* xml/XMLHttpRequest.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (192679 => 192680)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 09:06:05 UTC (rev 192679)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 09:25:56 UTC (rev 192680)
@@ -1,3 +1,21 @@
+2015-11-20  Youenn Fablet  
+
+Use HTTPHeaderName as much as possible in XMLHttpRequest
+https://bugs.webkit.org/show_bug.cgi?id=151438
+
+Reviewed by Darin Adler.
+
+Removing XMLHttpRequest::setRequestHeaderInternal and XMLHttpRequest::getRequestHeader.
+Using directly HTTPHeaderMap.add, HTTPHeaderMap.set and HTTPHeaderMap.get.
+
+No change in behavior.
+
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::send):
+(WebCore::XMLHttpRequest::setRequestHeader):
+(WebCore::XMLHttpRequest::getAllResponseHeaders):
+* xml/XMLHttpRequest.h:
+
 2015-11-20  Eric Carlson  
 
 MediaStream: Fix mock video source crash


Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (192679 => 192680)

--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2015-11-20 09:06:05 UTC (rev 192679)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp	2015-11-20 09:25:56 UTC (rev 192680)
@@ -595,11 +595,11 @@
 if (!m_requestHeaders.contains(HTTPHeaderName::ContentType)) {
 #if ENABLE(DASHBOARD_SUPPORT)
 if (usesDashboardBackwardCompatibilityMode())
-setRequestHeaderInternal("Content-Type", "application/x-www-form-urlencoded");
+m_requestHeaders.set(HTTPHeaderName::ContentType, ASCIILiteral("application/x-www-form-urlencoded"));
 else
 #endif
 // FIXME: this should include the charset used for encoding.
-setRequestHeaderInternal("Content-Type", document->isHTMLDocument() ? "text/html;charset=UTF-8":"application/xml;charset=UTF-8");
+m_requestHeaders.set(HTTPHeaderName::ContentType, document->isHTMLDocument() ? ASCIILiteral("text/html;charset=UTF-8") : ASCIILiteral("application/xml;charset=UTF-8"));
 }
 
 // FIXME: According to XMLHttpRequest Level 2, this should use the Document.innerHTML algorithm
@@ -620,14 +620,14 @@
 return;
 
 if (!body.isNull() && m_method != "GET" && m_method != "HEAD" && m_url.protocolIsInHTTPFamily()) {
-String contentType = getRequestHeader("Content-Type");
+String contentType = m_requestHeaders.get(HTTPHeaderName::ContentType);
 if (contentType.isNull()) {
 #if ENABLE(DASHBOARD_SUPPORT)
 if (usesDashboardBackwardCompatibilityMode())
-setRequestHeaderInternal("Content-Type", "application/x-www-form-urlencoded");
+m_requestHeaders.set(HTTPHeaderName::ContentType, ASCIILiteral("application/x-www-form-urlencoded"));
 else
 #endif
-setRequestHeaderInternal("Content-Type", "text/plain;charset=UTF-8");
+m_requestHeaders.set(HTTPHeaderName::ContentType, ASCIILiteral("text/plain;charset=UTF-8"));
 } else {
 replaceCharsetInMediaType(contentType, "UTF-8");
 m_requestHeaders.set(HTTPHeaderName::ContentType, contentType);
@@ -650,10 +650,10 @@
 if (!m_requestHeaders.contains(HTTPHeaderName::ContentType)) {
 const String& blobType = body->type();
 if (!blobType.isEmpty() && isValidContentType(blobType))
-setRequestHeaderInternal("Content-Type", blobType);
+m_requestHeaders.set(HTTPHeaderName::ContentType, blobType);
 else {
 // From FileAPI spec, whenever media type cannot be determined, empty string must be returned.
-setRequestHeaderInternal("Content-Type", "");
+m_requestHeaders.set(HTTPHeaderName::ContentType, emptyString());
 }
 }
 
@@ -675,7 +675,7 @@
 m_requestEntityBody->generateFiles(document());
 
 if (!m_requestHeaders.contains(HTTPHeaderName::ContentType))
-setRequestHeaderInternal("Content-Type", makeString("multipart/form-data; boundary=", m_requestEntityBody->boundary().data()));
+

[webkit-changes] [192686] trunk

2015-11-20 Thread beidson

Title: [192686] trunk








Revision 192686
Author beid...@apple.com
Date 2015-11-20 10:55:11 -0800 (Fri, 20 Nov 2015)


Log Message
Modern IDB: Get IDBRequest.readyState right.
https://bugs.webkit.org/show_bug.cgi?id=151484

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/request-readystate.html

* Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::readyState):

LayoutTests:

* storage/indexeddb/modern/request-readystate-expected.txt: Added.
* storage/indexeddb/modern/request-readystate.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp


Added Paths

trunk/LayoutTests/storage/indexeddb/modern/request-readystate-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/request-readystate.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192685 => 192686)

--- trunk/LayoutTests/ChangeLog	2015-11-20 15:17:36 UTC (rev 192685)
+++ trunk/LayoutTests/ChangeLog	2015-11-20 18:55:11 UTC (rev 192686)
@@ -1,3 +1,13 @@
+2015-11-20  Brady Eidson  
+
+Modern IDB: Get IDBRequest.readyState right.
+https://bugs.webkit.org/show_bug.cgi?id=151484
+
+Reviewed by Alex Christensen.
+
+* storage/indexeddb/modern/request-readystate-expected.txt: Added.
+* storage/indexeddb/modern/request-readystate.html: Added.
+
 2015-11-20  Youenn Fablet  
 
 Changing some imported/w3c/web-platform-tests/html/semantics expectations from Timeout/Failure to Pass


Added: trunk/LayoutTests/storage/indexeddb/modern/request-readystate-expected.txt (0 => 192686)

--- trunk/LayoutTests/storage/indexeddb/modern/request-readystate-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/modern/request-readystate-expected.txt	2015-11-20 18:55:11 UTC (rev 192686)
@@ -0,0 +1,11 @@
+This test makes sure that IDBRequest.readyState returns expected values.
+After calling indexedDB.open(), create request readyState is: pending
+Initial upgrade needed: Old version - 0 New version - 1
+Create request readyState is: done
+After calling openCursor, request readyState is: pending
+After successful opening of the cursor, request readyState is: done
+After calling continue(), request readyState is: pending
+After continue() completed, request readyState is: done
+Initial upgrade versionchange transaction complete
+Done
+


Added: trunk/LayoutTests/storage/indexeddb/modern/request-readystate.html (0 => 192686)

--- trunk/LayoutTests/storage/indexeddb/modern/request-readystate.html	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/modern/request-readystate.html	2015-11-20 18:55:11 UTC (rev 192686)
@@ -0,0 +1,65 @@
+This test makes sure that IDBRequest.readyState returns expected values.
+
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+function done()
+{
+log("Done");
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+function log(message)
+{
+document.getElementById("logger").innerHTML += message + "
";
+}
+
+var createRequest = window.indexedDB.open("RequestReadyStateDatabase", 1);
+log("After calling indexedDB.open(), create request readyState is: " + createRequest.readyState);
+
+createRequest._onupgradeneeded_ = function(event) {
+log("Initial upgrade needed: Old version - " + event.oldVersion + " New version - " + event.newVersion);
+log("Create request readyState is: " + createRequest.readyState);
+
+var versionTransaction = createRequest.transaction;
+var database = event.target.result;
+var objectStore = database.createObjectStore("TestObjectStore");
+
+for (var i = 0; i < 2; ++i)
+objectStore.put("Record " + i, i);
+
+var request = objectStore.openCursor();
+log("After calling openCursor, request readyState is: " + request.readyState);
+request._onsuccess_ = function() {
+log("After successful opening of the cursor, request readyState is: " + request.readyState);
+
+request._onsuccess_ = function() {
+log("After continue() completed, request readyState is: " + request.readyState);
+}
+
+request.result.continue();
+log("After calling continue(), request readyState is: " + request.readyState);
+}
+  
+versionTransaction._onabort_ = function(event) {
+log("Initial upgrade versionchange transaction unexpected aborted");
+done();
+}
+
+versionTransaction._oncomplete_ = function(event) {
+log("Initial upgrade versionchange transaction complete");
+done();
+}
+
+versionTransaction._onerror_ = function(event) {
+log("Initial upgrade versionchange transaction unexpected error" + event);
+done();
+}
+}
+
+


Modified: trunk/Source/WebCore/ChangeLog (192685 => 192686)

--- trunk/Source/WebCore/ChangeLog

[webkit-changes] [192688] trunk

2015-11-20 Thread zalan

Title: [192688] trunk








Revision 192688
Author za...@apple.com
Date 2015-11-20 11:20:57 -0800 (Fri, 20 Nov 2015)


Log Message
Simple line layout: Add text-indent support.
https://bugs.webkit.org/show_bug.cgi?id=151472

Reviewed by Simon Fraser.

This enables us to use simple line layout on text-indent content.

Source/WebCore:

Test: fast/text/simple-line-text-indent.html

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::canUseForStyle): Deleted.

LayoutTests:

* fast/text/simple-line-text-indent-expected.html: Added.
* fast/text/simple-line-text-indent.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/text/simple-line-text-indent-expected.html
trunk/LayoutTests/fast/text/simple-line-text-indent.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192687 => 192688)

--- trunk/LayoutTests/ChangeLog	2015-11-20 18:55:42 UTC (rev 192687)
+++ trunk/LayoutTests/ChangeLog	2015-11-20 19:20:57 UTC (rev 192688)
@@ -1,3 +1,15 @@
+2015-11-20  Zalan Bujtas  
+
+Simple line layout: Add text-indent support.
+https://bugs.webkit.org/show_bug.cgi?id=151472
+
+Reviewed by Simon Fraser.
+
+This enables us to use simple line layout on text-indent content.
+
+* fast/text/simple-line-text-indent-expected.html: Added.
+* fast/text/simple-line-text-indent.html: Added.
+
 2015-11-20  Brady Eidson  
 
 Modern IDB: IDBFactory.deleteDatabase() support.


Added: trunk/LayoutTests/fast/text/simple-line-text-indent-expected.html (0 => 192688)

--- trunk/LayoutTests/fast/text/simple-line-text-indent-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/simple-line-text-indent-expected.html	2015-11-20 19:20:57 UTC (rev 192688)
@@ -0,0 +1,28 @@
+
+
+This tests that simple line layout renders text-indent properly.
+
+div {
+  margin-left: 350px;
+}
+
+
+
+
+if (window.internals)
+	internals.settings.setSimpleLineLayoutEnabled(false);
+for (var i = -30; i < 30; i = i + 5) {
+var element = document.createElement("div");
+element.innerHTML = "first line
second line";
+element.style.textIndent = i;
+	document.body.appendChild(element);
+}
+for (var i = -20; i < 20; i = i + 5) {
+var element = document.createElement("div");
+element.innerHTML = "first line
second line";
+element.style.textIndent = i + "%";
+	document.body.appendChild(element);
+}
+
+
+


Added: trunk/LayoutTests/fast/text/simple-line-text-indent.html (0 => 192688)

--- trunk/LayoutTests/fast/text/simple-line-text-indent.html	(rev 0)
+++ trunk/LayoutTests/fast/text/simple-line-text-indent.html	2015-11-20 19:20:57 UTC (rev 192688)
@@ -0,0 +1,26 @@
+
+
+This tests that simple line layout renders text-indent properly.
+
+div {
+  margin-left: 350px;
+}
+
+
+
+
+for (var i = -30; i < 30; i = i + 5) {
+var element = document.createElement("div");
+element.innerHTML = "first line
second line";
+element.style.textIndent = i;
+	document.body.appendChild(element);
+}
+for (var i = -20; i < 20; i = i + 5) {
+var element = document.createElement("div");
+element.innerHTML = "first line
second line";
+element.style.textIndent = i + "%";
+	document.body.appendChild(element);
+}
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (192687 => 192688)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 18:55:42 UTC (rev 192687)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 19:20:57 UTC (rev 192688)
@@ -1,3 +1,19 @@
+2015-11-20  Zalan Bujtas  
+
+Simple line layout: Add text-indent support.
+https://bugs.webkit.org/show_bug.cgi?id=151472
+
+Reviewed by Simon Fraser.
+
+This enables us to use simple line layout on text-indent content.
+
+Test: fast/text/simple-line-text-indent.html
+
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::updateLineConstrains):
+(WebCore::SimpleLineLayout::createTextRuns):
+(WebCore::SimpleLineLayout::canUseForStyle): Deleted.
+
 2015-11-20  Brady Eidson  
 
 Modern IDB: IDBFactory.deleteDatabase() support.


Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (192687 => 192688)

--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2015-11-20 18:55:42 UTC (rev 192687)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2015-11-20 19:20:57 UTC (rev 192688)
@@ -120,8 +120,6 @@
 // Non-visible overflow should be pretty easy to support.
 if (style.overflowX() != OVISIBLE || style.overflowY() != OVISIBLE)
 return false;
-if (!style.textIndent().isZero())
-return false;
 if (!style.isLeftToRightDirection())
 return false;
 if

[webkit-changes] [192689] trunk/Source

2015-11-20 Thread simon . fraser

Title: [192689] trunk/Source








Revision 192689
Author simon.fra...@apple.com
Date 2015-11-20 12:05:05 -0800 (Fri, 20 Nov 2015)


Log Message
Back-buffer to front-buffer copy fails for some buffer formats
https://bugs.webkit.org/show_bug.cgi?id=151475
rdar://problem/23617899

Reviewed by Tim Horton.

Source/WebCore:

Fix some fo the bitsPerComponent/bitsPerPixel options in IOSurface::ensurePlatformContext()
for RGB10 buffers. Fix IOSurface::format() to return the new formats.

Implement IOSurface::copyToSurface(), which does a synchronous copy between
surfaces.

* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
(IOSurface::create):
(IOSurface::ensurePlatformContext):
(IOSurface::format):
(IOSurface::copyToSurface):

Source/WebKit2:

When displaying RemoteLayerBackingStore, we copy the back buffer to the front
buffer before painting the updated regions. For buffers using Format::RGB10A8,
the CGImage-based copy fails, so in this case, use IOSurface::copyToSurface().

Reorganized RemoteLayerBackingStore::drawInContext() to make this a bit easier
to understand. First, we either copy the entire surface over, or paint the backImage.
Then we clip to the dirty rects, and clear them, then paint the layer contents.

* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
(WebKit::RemoteLayerBackingStore::drawInContext):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h
trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (192688 => 192689)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 19:20:57 UTC (rev 192688)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 20:05:05 UTC (rev 192689)
@@ -1,3 +1,24 @@
+2015-11-19  Simon Fraser  
+
+Back-buffer to front-buffer copy fails for some buffer formats
+https://bugs.webkit.org/show_bug.cgi?id=151475
+rdar://problem/23617899
+
+Reviewed by Tim Horton.
+
+Fix some fo the bitsPerComponent/bitsPerPixel options in IOSurface::ensurePlatformContext()
+for RGB10 buffers. Fix IOSurface::format() to return the new formats.
+
+Implement IOSurface::copyToSurface(), which does a synchronous copy between
+surfaces.
+
+* platform/graphics/cocoa/IOSurface.h:
+* platform/graphics/cocoa/IOSurface.mm:
+(IOSurface::create):
+(IOSurface::ensurePlatformContext):
+(IOSurface::format):
+(IOSurface::copyToSurface):
+
 2015-11-20  Zalan Bujtas  
 
 Simple line layout: Add text-indent support.


Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h (192688 => 192689)

--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2015-11-20 19:20:57 UTC (rev 192688)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h	2015-11-20 20:05:05 UTC (rev 192689)
@@ -80,7 +80,7 @@
 IntSize size() const { return m_size; }
 size_t totalBytes() const { return m_totalBytes; }
 ColorSpace colorSpace() const { return m_colorSpace; }
-Format format() const;
+WEBCORE_EXPORT Format format() const;
 
 WEBCORE_EXPORT bool isInUse() const;
 
@@ -89,6 +89,7 @@
 WEBCORE_EXPORT void releaseGraphicsContext();
 
 #if PLATFORM(IOS)
+WEBCORE_EXPORT void copyToSurface(IOSurface&);
 WEBCORE_EXPORT static void convertToFormat(std::unique_ptr&& inSurface, Format, std::function);
 #endif
 


Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm (192688 => 192689)

--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm	2015-11-20 19:20:57 UTC (rev 192688)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm	2015-11-20 20:05:05 UTC (rev 192689)
@@ -54,6 +54,7 @@
 std::unique_ptr IOSurface::create(IntSize size, ColorSpace colorSpace, Format pixelFormat)
 {
 // YUV422 IOSurfaces do not go in the pool.
+// FIXME: Want pooling of RGB10, RGB10A8.
 if (pixelFormat == Format::RGBA) {
 if (auto cachedSurface = surfaceFromPool(size, size, colorSpace))
 return cachedSurface;
@@ -259,8 +260,27 @@
 return m_cgContext.get();
 
 CGBitmapInfo bitmapInfo = kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host;
+
 size_t bitsPerComponent = 8;
 size_t bitsPerPixel = 32;
+
+switch (format()) {
+case Format::RGBA:
+break;
+case Format::RGB10:
+bitsPerComponent = 10;
+bitsPerPixel = 32;
+break;
+case Format::RGB10A8:
+// FIXME: This doesn't take the two-plane format into account.
+bitsPerComponent = 10;
+bitsPerPixel = 32;
+break;
+case Format::YUV422:
+ASSERT_NOT_REACHED();
+break;
+}
+
 m_cgContext =

[webkit-changes] [192690] trunk/Websites/perf.webkit.org

2015-11-20 Thread rniwa

Title: [192690] trunk/Websites/perf.webkit.org








Revision 192690
Author rn...@webkit.org
Date 2015-11-20 12:35:18 -0800 (Fri, 20 Nov 2015)


Log Message
Perf dashboard always fetches charts JSON twice
https://bugs.webkit.org/show_bug.cgi?id=151483

Reviewed by Andreas Kling.

Only re-generate "runs" JSON via /api/runs/ when the cache doesn't exist in /data/ or the cached JSON is
obsolete (shouldRefetch is set true) or corrupt (the second closure).

* public/v2/app.js:
(App.Pane._fetch):

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v2/app.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (192689 => 192690)

--- trunk/Websites/perf.webkit.org/ChangeLog	2015-11-20 20:05:05 UTC (rev 192689)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2015-11-20 20:35:18 UTC (rev 192690)
@@ -1,3 +1,16 @@
+2015-11-19  Ryosuke Niwa  
+
+Perf dashboard always fetches charts JSON twice
+https://bugs.webkit.org/show_bug.cgi?id=151483
+
+Reviewed by Andreas Kling.
+
+Only re-generate "runs" JSON via /api/runs/ when the cache doesn't exist in /data/ or the cached JSON is
+obsolete (shouldRefetch is set true) or corrupt (the second closure).
+
+* public/v2/app.js:
+(App.Pane._fetch):
+
 2015-11-18  Ryosuke Niwa  
 
 Internal perf dashboard takes forever to load


Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (192689 => 192690)

--- trunk/Websites/perf.webkit.org/public/v2/app.js	2015-11-20 20:05:05 UTC (rev 192689)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js	2015-11-20 20:35:18 UTC (rev 192690)
@@ -355,11 +355,13 @@
 var useCache = true;
 App.Manifest.fetchRunsWithPlatformAndMetric(this.get('store'), platformId, metricId, null, useCache)
 .then(function (result) {
-if (result || result.shouldRefetch)
+if (!result || !result.data || result.shouldRefetch)
 self.refetchRuns(platformId, metricId);
-if (result)
+else
 self._didFetchRuns(result);
-}, this._handleFetchErrors.bind(this, platformId, metricId));
+}, function () {
+self.refetchRuns(platformId, metricId);
+});
 if (!this.get('inDashboard'))
 this.fetchAnalyticRanges();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192691] trunk/Websites/perf.webkit.org

2015-11-20 Thread rniwa

Title: [192691] trunk/Websites/perf.webkit.org








Revision 192691
Author rn...@webkit.org
Date 2015-11-20 12:39:34 -0800 (Fri, 20 Nov 2015)


Log Message
Perf dashboard's runs API uses more than 128MB of memory
https://bugs.webkit.org/show_bug.cgi?id=151478

Reviewed by Andreas Kling.

Don't fetch all query results at once to avoid using twice as much memory as needed.
Use iterative API to format each result at a time.

This change is also a 5% runtime performance gain.

* public/api/runs.php:
(RunsGenerator::__construct): Takes a Database instance instead of a list of configurations. The latter is
no longer needed as we pass in each configuration type explicitly to fetch_runs.
(RunsGenerator::fetch_runs): Renamed from add_runs since it now executes the database query via execute_query.
Also moved the logic to compute the last modified time here.
(RunsGenerator::execute_query): Moved from fetch_runs_for_config. Use Database::query instead of query_and_fetch_all.
(RunsGeneratorForTestGroup):
(RunsGeneratorForTestGroup::__construct):
(RunsGeneratorForTestGroup::execute_query): Moved from fetch_runs_for_config_and_test_group.

* public/include/db.php:
(generate_data_file): Lock the file to avoid corruption.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/api/runs.php
trunk/Websites/perf.webkit.org/public/include/db.php




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (192690 => 192691)

--- trunk/Websites/perf.webkit.org/ChangeLog	2015-11-20 20:35:18 UTC (rev 192690)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2015-11-20 20:39:34 UTC (rev 192691)
@@ -1,3 +1,28 @@
+2015-11-20  Ryosuke Niwa  
+
+Perf dashboard's runs API uses more than 128MB of memory
+https://bugs.webkit.org/show_bug.cgi?id=151478
+
+Reviewed by Andreas Kling.
+
+Don't fetch all query results at once to avoid using twice as much memory as needed.
+Use iterative API to format each result at a time.
+
+This change is also a 5% runtime performance gain.
+
+* public/api/runs.php:
+(RunsGenerator::__construct): Takes a Database instance instead of a list of configurations. The latter is
+no longer needed as we pass in each configuration type explicitly to fetch_runs.
+(RunsGenerator::fetch_runs): Renamed from add_runs since it now executes the database query via execute_query.
+Also moved the logic to compute the last modified time here.
+(RunsGenerator::execute_query): Moved from fetch_runs_for_config. Use Database::query instead of query_and_fetch_all.
+(RunsGeneratorForTestGroup):
+(RunsGeneratorForTestGroup::__construct):
+(RunsGeneratorForTestGroup::execute_query): Moved from fetch_runs_for_config_and_test_group.
+
+* public/include/db.php:
+(generate_data_file): Lock the file to avoid corruption.
+
 2015-11-19  Ryosuke Niwa  
 
 Perf dashboard always fetches charts JSON twice


Modified: trunk/Websites/perf.webkit.org/public/api/runs.php (192690 => 192691)

--- trunk/Websites/perf.webkit.org/public/api/runs.php	2015-11-20 20:35:18 UTC (rev 192690)
+++ trunk/Websites/perf.webkit.org/public/api/runs.php	2015-11-20 20:39:34 UTC (rev 192691)
@@ -2,27 +2,6 @@
 
 require('../include/json-header.php');
 
-function fetch_runs_for_config_and_test_group($db, $config, $test_group_id) {
-return $db->query_and_fetch_all('
-SELECT test_runs.*, builds.*, array_agg((commit_repository, commit_revision, commit_time)) AS revisions
-FROM builds
-LEFT OUTER JOIN build_commits ON commit_build = build_id
-LEFT OUTER JOIN commits ON build_commit = commit_id,
-test_runs, build_requests, analysis_test_groups
-WHERE run_build = build_id AND run_config = $1 AND request_build = build_id AND request_group = $2
-GROUP BY build_id, run_id', array($config['config_id'], $test_group_id));
-}
-
-function fetch_runs_for_config($db, $config) {
-return $db->query_and_fetch_all('
-SELECT test_runs.*, builds.*, array_agg((commit_repository, commit_revision, commit_time)) AS revisions
-FROM builds
-LEFT OUTER JOIN build_commits ON commit_build = build_id
-LEFT OUTER JOIN commits ON build_commit = commit_id, test_runs
-WHERE run_build = build_id AND run_config = $1 AND NOT EXISTS (SELECT * FROM build_requests WHERE request_build = build_id)
-GROUP BY build_id, run_id', array($config['config_id']));
-}
-
 function main($path) {
 if (count($path) != 1)
 exit_with_error('InvalidRequest');
@@ -52,15 +31,13 @@
 header("Cache-Control: maxage=$maxage");
 }
 
-$generator = new RunsGenerator($config_rows);
+if ($test_group_id)
+$generator = new RunsGeneratorForTestGroup($db, $test_group_id);
+else
+$generator = new

[webkit-changes] [192687] trunk

2015-11-20 Thread beidson

Title: [192687] trunk








Revision 192687
Author beid...@apple.com
Date 2015-11-20 10:55:42 -0800 (Fri, 20 Nov 2015)


Log Message
Modern IDB: IDBFactory.deleteDatabase() support.
https://bugs.webkit.org/show_bug.cgi?id=151456

Reviewed by Alex Christensen.

Source/WebCore:

Tests: storage/indexeddb/modern/deletedatabase-1.html
   storage/indexeddb/modern/deletedatabase-2.html

* Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::hasPendingActivity):
(WebCore::IDBClient::IDBDatabase::didCommitOrAbortTransaction):
* Modules/indexeddb/client/IDBDatabaseImpl.h:

* Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::onDeleteDatabaseSuccess):
(WebCore::IDBClient::IDBOpenDBRequest::requestCompleted):
* Modules/indexeddb/client/IDBOpenDBRequestImpl.h:

* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::hasPendingActivity): Deleted.

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::deleteDatabase):
(WebCore::IDBServer::IDBServer::deleteUniqueIDBDatabase):
* Modules/indexeddb/server/IDBServer.h:

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::hasAnyPendingCallbacks):
(WebCore::IDBServer::UniqueIDBDatabase::maybeDeleteDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations):
(WebCore::IDBServer::UniqueIDBDatabase::handleDelete):
(WebCore::IDBServer::UniqueIDBDatabase::notifyConnectionsOfVersionChangeForUpgrade):
(WebCore::IDBServer::UniqueIDBDatabase::notifyConnectionsOfVersionChange):
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabase::enqueueTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::invokeDeleteOrRunTransactionTimer):
(WebCore::IDBServer::UniqueIDBDatabase::deleteOrRunTransactionsTimerFired):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformActivateTransactionInBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::inProgressTransactionCompleted):
(WebCore::IDBServer::UniqueIDBDatabase::invokeTransactionScheduler): Deleted.
(WebCore::IDBServer::UniqueIDBDatabase::transactionSchedulingTimerFired): Deleted.
* Modules/indexeddb/server/UniqueIDBDatabase.h:
(WebCore::IDBServer::UniqueIDBDatabase::identifier):
(WebCore::IDBServer::UniqueIDBDatabase::deletePending):

* Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::deleteDatabaseSuccess):
* Modules/indexeddb/shared/IDBResultData.h:

LayoutTests:

* storage/indexeddb/modern/deletedatabase-1-expected.txt: Added.
* storage/indexeddb/modern/deletedatabase-1.html: Added.
* storage/indexeddb/modern/deletedatabase-2-expected.txt: Added.
* storage/indexeddb/modern/deletedatabase-2.html: Added.
* storage/indexeddb/modern/deletedatabase-request-event-expected.txt:
* storage/indexeddb/modern/deletedatabase-request-event.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-request-event-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-request-event.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.h
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h
trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.cpp
trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.h


Added Paths

trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1.html
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192686 => 192687)

--- trunk/LayoutTests/ChangeLog	2015-11-20 18:55:11 UTC (rev 192686)
+++ trunk/LayoutTests/ChangeLog	2015-11-20 18:55:42 UTC (rev 192687)
@@ -1,5 +1,19 @@
 2015-11-20  Brady Eidson  
 
+Modern IDB: IDBFactory.deleteDatabase() support.
+https://bugs.webkit.org/show_bug.cgi?id=151456
+
+Reviewed by Alex Christensen.
+
+* storage/indexeddb/modern/deletedatabase-1-expected.txt: Added.
+* storage/indexeddb/modern/deletedatabase-1.html: Added.
+* storage/indexeddb/modern/deletedatabase-2-expected.txt: Added.
+* storage/indexeddb/modern/deletedatabase-2.html: Added.
+* storage/indexeddb/modern/deletedatabase-request-event-expected.txt:
+*

[webkit-changes] [192693] trunk

2015-11-20 Thread cdumez

Title: [192693] trunk








Revision 192693
Author cdu...@apple.com
Date 2015-11-20 12:45:12 -0800 (Fri, 20 Nov 2015)


Log Message
Caching of properties on objects that have named property getters is sometimes incorrect
https://bugs.webkit.org/show_bug.cgi?id=151453


Reviewed by Gavin Barraclough.

Source/_javascript_Core:

Add new GetOwnPropertySlotIsImpureForPropertyAbsence TypeInfo flag to be
used by objects that have a non-'OverrideBuiltins' named property getter.
This flag prevents caching of properties that are missing as a named
property with this name may later become available.

Objects with an 'OverrideBuiltins' named property getter will keep using
the GetOwnPropertySlotIsImpure TypeInfo flag, which prevents all property
caching since named properties can override own properties or properties
on the prototype.

* bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
* bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::isStillValid):
* jit/Repatch.cpp:
(JSC::tryCacheGetByID):
(JSC::tryRepatchIn):
* jsc.cpp:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::getOwnPropertySlotIsImpure):
(JSC::TypeInfo::getOwnPropertySlotIsImpureForPropertyAbsence):
(JSC::TypeInfo::prohibitsPropertyCaching): Deleted.
* runtime/Structure.h:

Source/WebCore:

In r188590, we dropped the JSC::GetOwnPropertySlotIsImpure TypeInfo flag for
interfaces that have a non-'OverrideBuiltins' named property getter in order
to allow caching of properties returns by GetOwnPropertySlot(). We assumed
this was safe as it was no longer possible for named properties to override
own properties (or properties on the prototype).

However, there is an issue when we cache the non-existence of a property.
Even though at one point the property did not exist, a named property with
this name may later become available. In such case, caching would cause us
to wrongly report a property as missing.

To address the problem, this patch introduces a new
GetOwnPropertySlotIsImpureForPropertyAbsence TypeInfo flag and uses it for
interfaces that have a non-'OverrideBuiltins' named property getter. This
will cause us to not cache the fact that a property is missing on such
objects, while maintaining the performance win from r188590 in the common
case.

Test: fast/dom/NamedNodeMap-named-getter-caching.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
* bindings/scripts/test/JS/JSTestEventTarget.h:
* bindings/scripts/test/JS/JSTestOverrideBuiltins.h:

LayoutTests:

Add layout test to make sure caching does not cause NamedNodeMap's
named property getter to sometimes wrongly report a property as
missing.

* fast/dom/NamedNodeMap-named-getter-caching-expected.txt: Added.
* fast/dom/NamedNodeMap-named-getter-caching.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/ComplexGetStatus.cpp
trunk/Source/_javascript_Core/bytecode/PropertyCondition.cpp
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/_javascript_Core/runtime/JSTypeInfo.h
trunk/Source/_javascript_Core/runtime/Structure.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.h


Added Paths

trunk/LayoutTests/fast/dom/NamedNodeMap-named-getter-caching-expected.txt
trunk/LayoutTests/fast/dom/NamedNodeMap-named-getter-caching.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192692 => 192693)

--- trunk/LayoutTests/ChangeLog	2015-11-20 20:40:26 UTC (rev 192692)
+++ trunk/LayoutTests/ChangeLog	2015-11-20 20:45:12 UTC (rev 192693)
@@ -1,3 +1,18 @@
+2015-11-20  Chris Dumez  
+
+Caching of properties on objects that have named property getters is sometimes incorrect
+https://bugs.webkit.org/show_bug.cgi?id=151453
+
+
+Reviewed by Gavin Barraclough.
+
+Add layout test to make sure caching does not cause NamedNodeMap's
+named property getter to sometimes wrongly report a property as
+missing.
+
+* fast/dom/NamedNodeMap-named-getter-caching-expected.txt: Added.
+* fast/dom/NamedNodeMap-named-getter-caching.html: Added.
+
 2015-11-20  Zalan Bujtas  
 
 Simple line layout: Add text-indent support.


Added: trunk/LayoutTests/fast/dom/NamedNodeMap-named-getter-caching-expected.txt (0 => 192693)

--- trunk/LayoutTests/fast/dom/NamedNodeMap-named-getter-caching-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/NamedNodeMap-named-getter-caching-expected.txt	2015-11-20 20:45:12 UTC (rev 192693)
@@ -0,0 +1,11 @@
+Tests caching of result of NamedNodeMap named property getter
+
+On success, you will see a series of "PASS" messages,

[webkit-changes] [192692] trunk/Websites/perf.webkit.org

2015-11-20 Thread rniwa

Title: [192692] trunk/Websites/perf.webkit.org








Revision 192692
Author rn...@webkit.org
Date 2015-11-20 12:40:26 -0800 (Fri, 20 Nov 2015)


Log Message
Remove chartPointRadius from interactive chart component
https://bugs.webkit.org/show_bug.cgi?id=151480

Reviewed by Darin Adler.

Replaced the parameter by CSS rules.

* public/v2/chart-pane.css:
(.chart .dot):
(.chart .dot.foreground):
(.chart .highlight):
(.chart .extent):
* public/v2/index.html:
* public/v2/interactive-chart.js:
(App.InteractiveChartComponent.Ember.Component.extend._constructGraphIfPossible):
(App.InteractiveChartComponent.Ember.Component.extend._highlightedItemsChanged):

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v2/chart-pane.css
trunk/Websites/perf.webkit.org/public/v2/index.html
trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (192691 => 192692)

--- trunk/Websites/perf.webkit.org/ChangeLog	2015-11-20 20:39:34 UTC (rev 192691)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2015-11-20 20:40:26 UTC (rev 192692)
@@ -1,5 +1,24 @@
 2015-11-20  Ryosuke Niwa  
 
+Remove chartPointRadius from interactive chart component
+https://bugs.webkit.org/show_bug.cgi?id=151480
+
+Reviewed by Darin Adler.
+
+Replaced the parameter by CSS rules.
+
+* public/v2/chart-pane.css:
+(.chart .dot):
+(.chart .dot.foreground):
+(.chart .highlight):
+(.chart .extent):
+* public/v2/index.html:
+* public/v2/interactive-chart.js:
+(App.InteractiveChartComponent.Ember.Component.extend._constructGraphIfPossible):
+(App.InteractiveChartComponent.Ember.Component.extend._highlightedItemsChanged):
+
+2015-11-20  Ryosuke Niwa  
+
 Perf dashboard's runs API uses more than 128MB of memory
 https://bugs.webkit.org/show_bug.cgi?id=151478
 


Modified: trunk/Websites/perf.webkit.org/public/v2/chart-pane.css (192691 => 192692)

--- trunk/Websites/perf.webkit.org/public/v2/chart-pane.css	2015-11-20 20:39:34 UTC (rev 192691)
+++ trunk/Websites/perf.webkit.org/public/v2/chart-pane.css	2015-11-20 20:40:26 UTC (rev 192692)
@@ -361,7 +361,9 @@
 .chart .dot {
 fill: #ccc;
 stroke: none;
+r: 2px;
 }
+
 .chart .dot.foreground {
 fill: #666;
 }
@@ -437,6 +439,7 @@
 stroke: #f93;
 stroke-width: 2px;
 fill: none;
+r: 3.6px;
 }
 
 .chart .extent {


Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (192691 => 192692)

--- trunk/Websites/perf.webkit.org/public/v2/index.html	2015-11-20 20:39:34 UTC (rev 192691)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html	2015-11-20 20:40:26 UTC (rev 192692)
@@ -170,7 +170,6 @@
 ranges=ranges
 domain=mainPlotDomain
 interactive=true
-chartPointRadius=2
 currentItem=hoveredOrSelectedItem
 currentTime=sharedTime
 selectedItem=selectedItem
@@ -602,7 +601,6 @@
 ranges=pane.ranges
 domain=overviewDomain
 interactive=true
-chartPointRadius=2
 currentItem=pane.hoveredOrSelectedItem
 selectedPoints=pane.selectedPoints
 selection=timeRange
@@ -683,7 +681,6 @@
 {{interactive-chart
 chartData=referenceChart.data
 domain=overviewDomain
-chartPointRadius=2
 showYAxis=false
 enableSelection=false
 highlightedItems=referenceChart.highlightedItems}}


Modified: trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js (192691 => 192692)

--- trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js	2015-11-20 20:39:34 UTC (rev 192691)
+++ trunk/Websites/perf.webkit.org/public/v2/interactive-chart.js	2015-11-20 20:40:26 UTC (rev 192692)
@@ -142,8 +142,7 @@
 .selectAll(".dot")
 .data(this._currentTimeSeriesData)
 .enter().append("circle")
-.attr("class", "dot" + foregroundClass)
-.attr("r", this.get('chartPointRadius') || 1));
+.attr("class", "dot" + foregroundClass));
 
 if (movingAverageIsVisible) {
 this._paths.push(this._clippedContainer
@@ -611,8 +610,7 @@
 .selectAll(".highlight")
 .data(data)
 .enter().append("circle")
-.attr("class", "highlight")
-.attr("r", (this.get('chartPointRadius') || 1) * 1.8);
+.attr("class", "highlight");
 
 this._domainChanged();
 }.observes('highlightedItems'),

[webkit-changes] [192696] trunk/Source/JavaScriptCore

2015-11-20 Thread benjamin

Title: [192696] trunk/Source/_javascript_Core








Revision 192696
Author benja...@webkit.org
Date 2015-11-20 14:07:05 -0800 (Fri, 20 Nov 2015)


Log Message
[JSC] Add Air lowering to BitNot() for Xor(value, -1)
https://bugs.webkit.org/show_bug.cgi?id=151474

Patch by Benjamin Poulain  on 2015-11-20
Reviewed by Filip Pizlo.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::not32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::not64):
* assembler/X86Assembler.h:
(JSC::X86Assembler::notq_r):
(JSC::X86Assembler::notq_m):
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createGenericCompare):
(JSC::B3::Air::LowerToAir::lower):
* b3/B3ReduceStrength.cpp:
* b3/air/AirOpcode.opcodes:
* b3/testb3.cpp:
(JSC::B3::testNegValueSubOne):
(JSC::B3::testNegValueSubOne32):
(JSC::B3::testBitNotArg):
(JSC::B3::testBitNotImm):
(JSC::B3::testBitNotMem):
(JSC::B3::testBitNotArg32):
(JSC::B3::testBitNotImm32):
(JSC::B3::testBitNotMem32):
(JSC::B3::testBitNotOnBooleanAndBranch32):
(JSC::B3::int64Operands):
(JSC::B3::int32Operands):
(JSC::B3::run):
* ftl/FTLB3Output.h:
(JSC::FTL::Output::bitNot):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/assembler/X86Assembler.h
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/_javascript_Core/b3/testb3.cpp
trunk/Source/_javascript_Core/ftl/FTLB3Output.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192695 => 192696)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-20 21:19:57 UTC (rev 192695)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-20 22:07:05 UTC (rev 192696)
@@ -1,3 +1,38 @@
+2015-11-20  Benjamin Poulain  
+
+[JSC] Add Air lowering to BitNot() for Xor(value, -1)
+https://bugs.webkit.org/show_bug.cgi?id=151474
+
+Reviewed by Filip Pizlo.
+
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::not32):
+* assembler/MacroAssemblerX86_64.h:
+(JSC::MacroAssemblerX86_64::not64):
+* assembler/X86Assembler.h:
+(JSC::X86Assembler::notq_r):
+(JSC::X86Assembler::notq_m):
+* b3/B3LowerToAir.cpp:
+(JSC::B3::Air::LowerToAir::createGenericCompare):
+(JSC::B3::Air::LowerToAir::lower):
+* b3/B3ReduceStrength.cpp:
+* b3/air/AirOpcode.opcodes:
+* b3/testb3.cpp:
+(JSC::B3::testNegValueSubOne):
+(JSC::B3::testNegValueSubOne32):
+(JSC::B3::testBitNotArg):
+(JSC::B3::testBitNotImm):
+(JSC::B3::testBitNotMem):
+(JSC::B3::testBitNotArg32):
+(JSC::B3::testBitNotImm32):
+(JSC::B3::testBitNotMem32):
+(JSC::B3::testBitNotOnBooleanAndBranch32):
+(JSC::B3::int64Operands):
+(JSC::B3::int32Operands):
+(JSC::B3::run):
+* ftl/FTLB3Output.h:
+(JSC::FTL::Output::bitNot):
+
 2015-11-20  Yusuke Suzuki  
 
 Super use should be recorded in per-function scope


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h (192695 => 192696)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h	2015-11-20 21:19:57 UTC (rev 192695)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h	2015-11-20 22:07:05 UTC (rev 192696)
@@ -481,6 +481,16 @@
 xor32(imm, dest);
 }
 
+void not32(RegisterID srcDest)
+{
+m_assembler.notl_r(srcDest);
+}
+
+void not32(Address dest)
+{
+m_assembler.notl_m(dest.offset, dest.base);
+}
+
 void sqrtDouble(FPRegisterID src, FPRegisterID dst)
 {
 m_assembler.sqrtsd_rr(src, dst);


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h (192695 => 192696)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h	2015-11-20 21:19:57 UTC (rev 192695)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h	2015-11-20 22:07:05 UTC (rev 192696)
@@ -502,6 +502,16 @@
 m_assembler.xorq_ir(imm.m_value, srcDest);
 }
 
+void not64(RegisterID srcDest)
+{
+m_assembler.notq_r(srcDest);
+}
+
+void not64(Address dest)
+{
+m_assembler.notq_m(dest.offset, dest.base);
+}
+
 void load64(ImplicitAddress address, RegisterID dest)
 {
 m_assembler.movq_mr(address.offset, address.base, dest);


Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (192695 => 192696)

--- trunk/Source/_javascript_Core/assembler/X86Assembler.h	2015-11-20 21:19:57 UTC (rev 192695)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h	2015-11-20 22:07:05 UTC (rev 192696)
@@ -622,6 +622,18 @@
 m_formatter.oneByteOp(OP_GROUP3_Ev,

[webkit-changes] [192698] trunk

2015-11-20 Thread beidson

Title: [192698] trunk








Revision 192698
Author beid...@apple.com
Date 2015-11-20 14:14:56 -0800 (Fri, 20 Nov 2015)


Log Message
Modern IDB: In the VersionChangeEvent for delete database calls, oldVersion should be null instead of 0.
https://bugs.webkit.org/show_bug.cgi?id=151481

Reviewed by Sam Weinig.

Source/WebCore:

No new tests, covered by changes to:
storage/indexeddb/modern/deletedatabase-1.html
storage/indexeddb/modern/deletedatabase-2.html

* Modules/indexeddb/IDBVersionChangeEvent.h:
* Modules/indexeddb/IDBVersionChangeEvent.idl:

* Modules/indexeddb/client/IDBVersionChangeEventImpl.cpp:
(WebCore::IDBClient::IDBVersionChangeEvent::newVersion):
* Modules/indexeddb/client/IDBVersionChangeEventImpl.h:

* Modules/indexeddb/legacy/LegacyVersionChangeEvent.cpp:
(WebCore::LegacyVersionChangeEvent::newVersion):
* Modules/indexeddb/legacy/LegacyVersionChangeEvent.h:

LayoutTests:

* storage/indexeddb/modern/deletedatabase-1-expected.txt:
* storage/indexeddb/modern/deletedatabase-2-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h
trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl
trunk/Source/WebCore/Modules/indexeddb/client/IDBVersionChangeEventImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBVersionChangeEventImpl.h
trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyVersionChangeEvent.cpp
trunk/Source/WebCore/Modules/indexeddb/legacy/LegacyVersionChangeEvent.h




Diff

Modified: trunk/LayoutTests/ChangeLog (192697 => 192698)

--- trunk/LayoutTests/ChangeLog	2015-11-20 22:10:52 UTC (rev 192697)
+++ trunk/LayoutTests/ChangeLog	2015-11-20 22:14:56 UTC (rev 192698)
@@ -1,3 +1,13 @@
+2015-11-20  Brady Eidson  
+
+Modern IDB: In the VersionChangeEvent for delete database calls, oldVersion should be null instead of 0.
+https://bugs.webkit.org/show_bug.cgi?id=151481
+
+Reviewed by Sam Weinig.
+
+* storage/indexeddb/modern/deletedatabase-1-expected.txt:
+* storage/indexeddb/modern/deletedatabase-2-expected.txt:
+
 2015-11-20  Chris Dumez  
 
 Caching of properties on objects that have named property getters is sometimes incorrect


Modified: trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt (192697 => 192698)

--- trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt	2015-11-20 22:10:52 UTC (rev 192697)
+++ trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt	2015-11-20 22:14:56 UTC (rev 192698)
@@ -2,8 +2,8 @@
 Initial upgrade old version - 0 new version - 1
 Version change complete
 Requesting deleteDatabase
-First connection received versionchange event: oldVersion 1, newVersion 0
-Delete database success: oldVersion 1, newVersion 0
+First connection received versionchange event: oldVersion 1, newVersion null
+Delete database success: oldVersion 1, newVersion null
 Recreating database to make sure it's new and empty
 Second upgrade old version - 0 new version - 1
 Unable to get object store in second upgrade transaction (which is correct because it should not be there)


Modified: trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt (192697 => 192698)

--- trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt	2015-11-20 22:10:52 UTC (rev 192697)
+++ trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt	2015-11-20 22:14:56 UTC (rev 192698)
@@ -2,9 +2,9 @@
 That open connection also has an in-progress transaction at the time it gets the versionChange event.
 Initial upgrade old version - 0 new version - 1
 Requesting deleteDatabase
-First connection received versionchange event: oldVersion 0, newVersion 0
+First connection received versionchange event: oldVersion 0, newVersion null
 First version change complete
-Delete database success: oldVersion 1, newVersion 0
+Delete database success: oldVersion 1, newVersion null
 Recreating database to make sure it's new and empty
 Second upgrade old version - 0 new version - 1
 Unable to get object store in second upgrade transaction (which is correct because it should not be there)


Modified: trunk/Source/WebCore/ChangeLog (192697 => 192698)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 22:10:52 UTC (rev 192697)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 22:14:56 UTC (rev 192698)
@@ -1,5 +1,27 @@
 2015-11-20  Brady Eidson  
 
+Modern IDB: In the VersionChangeEvent for delete database calls, oldVersion should be null instead of 0.
+https://bugs.webkit.org/show_bug.cgi?id=151481
+
+Reviewed by Sam Weinig.
+
+No new tests, covered by changes to:
+storage/indexeddb/modern/deletedatabase-1.html
+

[webkit-changes] [192694] trunk/Source/WebCore

2015-11-20 Thread beidson

Title: [192694] trunk/Source/WebCore








Revision 192694
Author beid...@apple.com
Date 2015-11-20 13:14:58 -0800 (Fri, 20 Nov 2015)


Log Message
Addressing missed review feedback for:
Modern IDB: Make in-memory ObjectStore cursors work.
https://bugs.webkit.org/show_bug.cgi?id=151196

Reviewed by Darin Adler.

* Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::maybeOpenCursor):
* Modules/indexeddb/server/MemoryObjectStoreCursor.cpp:
(WebCore::IDBServer::MemoryObjectStoreCursor::create): Deleted.
* Modules/indexeddb/server/MemoryObjectStoreCursor.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp
trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp
trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (192693 => 192694)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 20:45:12 UTC (rev 192693)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 21:14:58 UTC (rev 192694)
@@ -1,3 +1,17 @@
+2015-11-20  Brady Eidson  
+
+Addressing missed review feedback for:
+Modern IDB: Make in-memory ObjectStore cursors work.
+https://bugs.webkit.org/show_bug.cgi?id=151196
+
+Reviewed by Darin Adler.
+
+* Modules/indexeddb/server/MemoryObjectStore.cpp:
+(WebCore::IDBServer::MemoryObjectStore::maybeOpenCursor):
+* Modules/indexeddb/server/MemoryObjectStoreCursor.cpp:
+(WebCore::IDBServer::MemoryObjectStoreCursor::create): Deleted.
+* Modules/indexeddb/server/MemoryObjectStoreCursor.h:
+
 2015-11-20  Chris Dumez  
 
 Caching of properties on objects that have named property getters is sometimes incorrect


Modified: trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp (192693 => 192694)

--- trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp	2015-11-20 20:45:12 UTC (rev 192693)
+++ trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp	2015-11-20 21:14:58 UTC (rev 192694)
@@ -480,7 +480,7 @@
 if (!result.isNewEntry)
 return nullptr;
 
-result.iterator->value = MemoryObjectStoreCursor::create(*this, info);
+result.iterator->value = std::make_unique(*this, info);
 return result.iterator->value.get();
 }
 


Modified: trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp (192693 => 192694)

--- trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp	2015-11-20 20:45:12 UTC (rev 192693)
+++ trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.cpp	2015-11-20 21:14:58 UTC (rev 192694)
@@ -34,11 +34,6 @@
 namespace WebCore {
 namespace IDBServer {
 
-std::unique_ptr MemoryObjectStoreCursor::create(MemoryObjectStore& objectStore, const IDBCursorInfo& info)
-{
-return std::make_unique(objectStore, info);
-}
-
 MemoryObjectStoreCursor::MemoryObjectStoreCursor(MemoryObjectStore& objectStore, const IDBCursorInfo& info)
 : MemoryCursor(info)
 , m_objectStore(objectStore)


Modified: trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.h (192693 => 192694)

--- trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.h	2015-11-20 20:45:12 UTC (rev 192693)
+++ trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStoreCursor.h	2015-11-20 21:14:58 UTC (rev 192694)
@@ -40,17 +40,14 @@
 class MemoryObjectStore;
 
 class MemoryObjectStoreCursor : public MemoryCursor {
-friend std::unique_ptr std::make_unique(WebCore::IDBServer::MemoryObjectStore&, const WebCore::IDBCursorInfo&);
 public:
-static std::unique_ptr create(MemoryObjectStore&, const IDBCursorInfo&);
+MemoryObjectStoreCursor(MemoryObjectStore&, const IDBCursorInfo&);
 
 void objectStoreCleared();
 void keyDeleted(const IDBKeyData&);
 void keyAdded(std::set::iterator);
 
 private:
-MemoryObjectStoreCursor(MemoryObjectStore&, const IDBCursorInfo&);
-
 virtual void currentData(IDBGetResult&) override final;
 virtual void iterate(const IDBKeyData&, uint32_t count, IDBGetResult&) override final;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192708] trunk/Source/JavaScriptCore

2015-11-20 Thread mark . lam

Title: [192708] trunk/Source/_javascript_Core








Revision 192708
Author mark@apple.com
Date 2015-11-20 15:45:40 -0800 (Fri, 20 Nov 2015)


Log Message
New JSC tests introduced in r192664 fail on ARM.
https://bugs.webkit.org/show_bug.cgi?id=151485

Reviewed by Geoffrey Garen.

The newly added tests are exposing some pre-existing bugs.  The bugs are tracked here:
https://bugs.webkit.org/show_bug.cgi?id=151514
https://bugs.webkit.org/show_bug.cgi?id=151515

Skipping the tests for now.

* tests/stress/op_div.js:
* tests/stress/op_rshift.js:
* tests/stress/op_urshift.js:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/tests/stress/op_div.js
trunk/Source/_javascript_Core/tests/stress/op_rshift.js
trunk/Source/_javascript_Core/tests/stress/op_urshift.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192707 => 192708)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-20 23:37:23 UTC (rev 192707)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-20 23:45:40 UTC (rev 192708)
@@ -1,3 +1,20 @@
+2015-11-20  Mark Lam  
+
+New JSC tests introduced in r192664 fail on ARM.
+https://bugs.webkit.org/show_bug.cgi?id=151485
+
+Reviewed by Geoffrey Garen.
+
+The newly added tests are exposing some pre-existing bugs.  The bugs are tracked here:
+https://bugs.webkit.org/show_bug.cgi?id=151514
+https://bugs.webkit.org/show_bug.cgi?id=151515
+
+Skipping the tests for now.
+
+* tests/stress/op_div.js:
+* tests/stress/op_rshift.js:
+* tests/stress/op_urshift.js:
+
 2015-11-20  Filip Pizlo  
 
 B3 should have a Select opcode


Modified: trunk/Source/_javascript_Core/tests/stress/op_div.js (192707 => 192708)

--- trunk/Source/_javascript_Core/tests/stress/op_div.js	2015-11-20 23:37:23 UTC (rev 192707)
+++ trunk/Source/_javascript_Core/tests/stress/op_div.js	2015-11-20 23:45:40 UTC (rev 192708)
@@ -1,4 +1,5 @@
-//@ runFTLNoCJIT
+//@ skip
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=151515
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.


Modified: trunk/Source/_javascript_Core/tests/stress/op_rshift.js (192707 => 192708)

--- trunk/Source/_javascript_Core/tests/stress/op_rshift.js	2015-11-20 23:37:23 UTC (rev 192707)
+++ trunk/Source/_javascript_Core/tests/stress/op_rshift.js	2015-11-20 23:45:40 UTC (rev 192708)
@@ -1,4 +1,5 @@
-//@ runFTLNoCJIT
+//@ skip
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=151514
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.


Modified: trunk/Source/_javascript_Core/tests/stress/op_urshift.js (192707 => 192708)

--- trunk/Source/_javascript_Core/tests/stress/op_urshift.js	2015-11-20 23:37:23 UTC (rev 192707)
+++ trunk/Source/_javascript_Core/tests/stress/op_urshift.js	2015-11-20 23:45:40 UTC (rev 192708)
@@ -1,4 +1,5 @@
-//@ runFTLNoCJIT
+//@ skip
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=151514
 
 // If all goes well, this test module will terminate silently. If not, it will print
 // errors. See binary-op-test.js for debugging options if needed.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192710] trunk/LayoutTests

2015-11-20 Thread cdumez

Title: [192710] trunk/LayoutTests








Revision 192710
Author cdu...@apple.com
Date 2015-11-20 16:20:53 -0800 (Fri, 20 Nov 2015)


Log Message
Unreviewed, rolling out r192139.
https://bugs.webkit.org/show_bug.cgi?id=151525

as it may cause WKTR to crash when the Flash plugin is
installed (Requested by cdumez on #webkit).

Reverted changeset:

"Unreviewed gardening, update fast/replaced/replaced-
breaking.html"
http://trac.webkit.org/changeset/192139

Patch by Commit Queue  on 2015-11-20

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/replaced/replaced-breaking.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192709 => 192710)

--- trunk/LayoutTests/ChangeLog	2015-11-21 00:04:20 UTC (rev 192709)
+++ trunk/LayoutTests/ChangeLog	2015-11-21 00:20:53 UTC (rev 192710)
@@ -1,3 +1,17 @@
+2015-11-20  Commit Queue  
+
+Unreviewed, rolling out r192139.
+https://bugs.webkit.org/show_bug.cgi?id=151525
+
+as it may cause WKTR to crash when the Flash plugin is
+installed (Requested by cdumez on #webkit).
+
+Reverted changeset:
+
+"Unreviewed gardening, update fast/replaced/replaced-
+breaking.html"
+http://trac.webkit.org/changeset/192139
+
 2015-11-20  Brady Eidson  
 
 Modern IDB: In the VersionChangeEvent for delete database calls, oldVersion should be null instead of 0.


Modified: trunk/LayoutTests/fast/replaced/replaced-breaking.html (192709 => 192710)

--- trunk/LayoutTests/fast/replaced/replaced-breaking.html	2015-11-21 00:04:20 UTC (rev 192709)
+++ trunk/LayoutTests/fast/replaced/replaced-breaking.html	2015-11-21 00:20:53 UTC (rev 192710)
@@ -15,7 +15,7 @@
 
 
 
-
+
 
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192679] trunk/Source/WebCore

2015-11-20 Thread eric . carlson

Title: [192679] trunk/Source/WebCore








Revision 192679
Author eric.carl...@apple.com
Date 2015-11-20 01:06:05 -0800 (Fri, 20 Nov 2015)


Log Message
MediaStream: Fix mock video source crash
https://bugs.webkit.org/show_bug.cgi?id=151462

Reviewed by Alexey Proskuryakov.

No new tests, this fixes existing tests.

* platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::drawText): Declare the String used to intialize a
  StringView explicitly so it outlives the StringView.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (192678 => 192679)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 08:09:16 UTC (rev 192678)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 09:06:05 UTC (rev 192679)
@@ -1,3 +1,16 @@
+2015-11-20  Eric Carlson  
+
+MediaStream: Fix mock video source crash
+https://bugs.webkit.org/show_bug.cgi?id=151462
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests, this fixes existing tests.
+
+* platform/mock/MockRealtimeVideoSource.cpp:
+(WebCore::MockRealtimeVideoSource::drawText): Declare the String used to intialize a 
+  StringView explicitly so it outlives the StringView.
+
 2015-11-20  David Kilzer  
 
 REGRESSION (r192460,r192677): Fix all the builds


Modified: trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp (192678 => 192679)

--- trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp	2015-11-20 08:09:16 UTC (rev 192678)
+++ trunk/Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp	2015-11-20 09:06:05 UTC (rev 192679)
@@ -43,6 +43,7 @@
 #include "UUID.h"
 #include 
 #include 
+#include 
 #include 
 
 namespace WebCore {
@@ -308,12 +309,12 @@
 unsigned frameMod = m_frameNumber % 60;
 if (frameMod <= 15) {
 context.setFillColor(Color::gray);
-TextRun run(StringView("Bip"));
-context.drawText(m_bipBopFont, run, bipBopLocation, 0, -1);
+String bip(ASCIILiteral("Bip"));
+context.drawText(m_bipBopFont, TextRun(StringView(bip)), bipBopLocation, 0, -1);
 } else if (frameMod > 30 && frameMod <= 45) {
 context.setFillColor(Color::white);
-TextRun run(StringView("Bop"));
-context.drawText(m_bipBopFont, run, bipBopLocation, 0, -1);
+String bop(ASCIILiteral("Bop"));
+context.drawText(m_bipBopFont, TextRun(StringView(bop)), bipBopLocation, 0, -1);
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192703] trunk/Source/WebKit2

2015-11-20 Thread ggaren

Title: [192703] trunk/Source/WebKit2








Revision 192703
Author gga...@apple.com
Date 2015-11-20 15:10:57 -0800 (Fri, 20 Nov 2015)


Log Message
A window with a hung tab waits 5s before becoming active
https://bugs.webkit.org/show_bug.cgi?id=151426

Reviewed by Sam Weinig.

This patch adds an optimization to skip the synchronous web process
message to check for a legacy scrollbar when we know that legacy
scrollbars are not enabled.

(Note that legacy scrollbars don't work quite right, due to
 and . Still, I verified
with logging that we do the synchronous message when legacy scrollbars
are enabled.)

A consequence of this change is that we will no longer support
click-to-scroll-while-inactive behavior for scrollbars with custom looks
on systems with modern scrollbars. I spoke with Beth and Dan, and they
agreed that this is a reasonable change to make, since we don't support
click-to-scroll-while-inactive behavior for fully custom scrollbars either,
and since systems with modern scrollbars typically use swipe to scroll.

* UIProcess/Cocoa/WebViewImpl.h: Added some helper functions to explain
the behaviors we're checking for.

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::mightBeginDragWhileInactive): Factored out from
shouldDelayWindowOrderingForEvent.

(WebKit::WebViewImpl::mightBeginScrollWhileInactive): New function.

(WebKit::WebViewImpl::acceptsFirstMouse): Moved this function next to
shouldDelayWindowOrderingForEvent because their responsibilities are
very similar. Added a fast path check for when we know that we will
not accept first mouse because we can't start a drag or scroll by
clicking while inactive.

(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent): Refactored
to use the helper function. Behavior unchanged.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h
trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (192702 => 192703)

--- trunk/Source/WebKit2/ChangeLog	2015-11-20 23:10:02 UTC (rev 192702)
+++ trunk/Source/WebKit2/ChangeLog	2015-11-20 23:10:57 UTC (rev 192703)
@@ -1,5 +1,46 @@
 2015-11-20  Geoffrey Garen  
 
+A window with a hung tab waits 5s before becoming active
+https://bugs.webkit.org/show_bug.cgi?id=151426
+
+Reviewed by Sam Weinig.
+
+This patch adds an optimization to skip the synchronous web process
+message to check for a legacy scrollbar when we know that legacy
+scrollbars are not enabled.
+
+(Note that legacy scrollbars don't work quite right, due to
+ and . Still, I verified
+with logging that we do the synchronous message when legacy scrollbars
+are enabled.)
+
+A consequence of this change is that we will no longer support
+click-to-scroll-while-inactive behavior for scrollbars with custom looks
+on systems with modern scrollbars. I spoke with Beth and Dan, and they
+agreed that this is a reasonable change to make, since we don't support
+click-to-scroll-while-inactive behavior for fully custom scrollbars either,
+and since systems with modern scrollbars typically use swipe to scroll.
+
+* UIProcess/Cocoa/WebViewImpl.h: Added some helper functions to explain
+the behaviors we're checking for.
+
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::mightBeginDragWhileInactive): Factored out from
+shouldDelayWindowOrderingForEvent.
+
+(WebKit::WebViewImpl::mightBeginScrollWhileInactive): New function.
+
+(WebKit::WebViewImpl::acceptsFirstMouse): Moved this function next to
+shouldDelayWindowOrderingForEvent because their responsibilities are
+very similar. Added a fast path check for when we know that we will
+not accept first mouse because we can't start a drag or scroll by
+clicking while inactive.
+
+(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent): Refactored
+to use the helper function. Behavior unchanged.
+
+2015-11-20  Geoffrey Garen  
+
 A hung webpage pretends to be responsive if you scroll
 https://bugs.webkit.org/show_bug.cgi?id=151518
 


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h (192702 => 192703)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h	2015-11-20 23:10:02 UTC (rev 192702)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h	2015-11-20 23:10:57 UTC (rev 192703)
@@ -504,6 +504,9 @@
 void mouseUpInternal(NSEvent *);
 void mouseDraggedInternal(NSEvent *);
 
+bool mightBeginDragWhileInactive();
+bool mightBeginScrollWhileInactive();
+
 NSView  *m_view;
 std::unique_ptr m_pageClient;
 Ref m_page;


Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm (192702 => 192703)

--- trunk/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm	2015-11-20 23:10:02 UTC (rev 192702)
+++

[webkit-changes] [192699] trunk/Source/JavaScriptCore

2015-11-20 Thread fpizlo

Title: [192699] trunk/Source/_javascript_Core








Revision 192699
Author fpi...@apple.com
Date 2015-11-20 14:31:19 -0800 (Fri, 20 Nov 2015)


Log Message
B3 should have a Select opcode
https://bugs.webkit.org/show_bug.cgi?id=150762

Reviewed by Benjamin Poulain.

This cleans up our conditional move implementation - specifically so that it distinguishes between
comparing the low 32 bits of a GPR and all bits of a GPR - and fixes bugs with operand ordering. It
then adds a Select opcode to B3 and adds all of the strength reduction and lowering magic that it
needs. Finally this change implements FTL::Output::select() in terms of B3::Select.

This patch lets us run Kraken/imaging-gaussian-blur. Running that benchmark using FTL+B3 is a 17%
speed-up. The compile times go down dramatically (by about 7x) and code quality stays about the same.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::moveDoubleConditionally32):
(JSC::MacroAssembler::moveDoubleConditionally64):
(JSC::MacroAssembler::moveDoubleConditionallyTest32):
(JSC::MacroAssembler::moveDoubleConditionallyTest64):
(JSC::MacroAssembler::moveDoubleConditionallyDouble):
(JSC::MacroAssembler::lea):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::move):
(JSC::MacroAssemblerX86Common::moveConditionallyDouble):
(JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
(JSC::MacroAssemblerX86Common::moveConditionally32):
(JSC::MacroAssemblerX86Common::moveConditionallyTest32):
(JSC::MacroAssemblerX86Common::set32):
(JSC::MacroAssemblerX86Common::cmov):
(JSC::MacroAssemblerX86Common::moveConditionally): Deleted.
(JSC::MacroAssemblerX86Common::moveConditionallyTest): Deleted.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchNeg64):
(JSC::MacroAssemblerX86_64::moveConditionally64):
(JSC::MacroAssemblerX86_64::moveConditionallyTest64):
(JSC::MacroAssemblerX86_64::abortWithReason):
* assembler/X86Assembler.h:
(JSC::X86Assembler::cmovl_rr):
(JSC::X86Assembler::cmovl_mr):
(JSC::X86Assembler::cmovel_rr):
(JSC::X86Assembler::cmovnel_rr):
(JSC::X86Assembler::cmovpl_rr):
(JSC::X86Assembler::cmovnpl_rr):
(JSC::X86Assembler::cmovq_rr):
(JSC::X86Assembler::cmovq_mr):
(JSC::X86Assembler::cmoveq_rr):
(JSC::X86Assembler::cmovneq_rr):
(JSC::X86Assembler::cmovpq_rr):
(JSC::X86Assembler::cmovnpq_rr):
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createCompare):
(JSC::B3::Air::LowerToAir::createSelect):
(JSC::B3::Air::LowerToAir::marshallCCallArgument):
(JSC::B3::Air::LowerToAir::lower):
* b3/B3MoveConstants.cpp:
* b3/B3Opcode.cpp:
(WTF::printInternal):
* b3/B3Opcode.h:
* b3/B3ReduceStrength.cpp:
* b3/B3Validate.cpp:
* b3/B3Value.cpp:
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::checkOpcode):
(JSC::B3::Value::typeFor):
* b3/B3Value.h:
* b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::dump):
(JSC::B3::ValueKey::materialize):
* b3/B3ValueKey.h:
(JSC::B3::ValueKey::ValueKey):
(JSC::B3::ValueKey::hash):
(JSC::B3::ValueKey::operator bool):
* b3/B3ValueKeyInlines.h:
(JSC::B3::ValueKey::ValueKey):
(JSC::B3::ValueKey::child):
* b3/air/AirOpcode.opcodes:
* b3/testb3.cpp:
(JSC::B3::testTruncSExt32):
(JSC::B3::testBasicSelect):
(JSC::B3::testSelectTest):
(JSC::B3::testSelectCompareDouble):
(JSC::B3::testSelectDouble):
(JSC::B3::testSelectDoubleTest):
(JSC::B3::testSelectDoubleCompareDouble):
(JSC::B3::zero):
(JSC::B3::run):
* ftl/FTLB3Output.h:
(JSC::FTL::Output::testIsZeroPtr):
(JSC::FTL::Output::testNonZeroPtr):
(JSC::FTL::Output::select):
(JSC::FTL::Output::extractValue):
(JSC::FTL::Output::fence):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/assembler/X86Assembler.h
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp
trunk/Source/_javascript_Core/b3/B3Opcode.cpp
trunk/Source/_javascript_Core/b3/B3Opcode.h
trunk/Source/_javascript_Core/b3/B3ReduceStrength.cpp
trunk/Source/_javascript_Core/b3/B3Validate.cpp
trunk/Source/_javascript_Core/b3/B3Value.cpp
trunk/Source/_javascript_Core/b3/B3Value.h
trunk/Source/_javascript_Core/b3/B3ValueKey.cpp
trunk/Source/_javascript_Core/b3/B3ValueKey.h
trunk/Source/_javascript_Core/b3/B3ValueKeyInlines.h
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/_javascript_Core/b3/testb3.cpp
trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.cpp
trunk/Source/_javascript_Core/ftl/FTLAbstractHeap.h
trunk/Source/_javascript_Core/ftl/FTLB3Output.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192698 => 192699)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-20 22:14:56 UTC (rev 192698)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-20 22:31:19 UTC (rev 192699)
@@ -1,3 +1,98 @@
+2015-11-20  Filip Pizlo  
+
+B3 should have a Select opcode
+

[webkit-changes] [192702] trunk/Source/WebKit2

2015-11-20 Thread ggaren

Title: [192702] trunk/Source/WebKit2








Revision 192702
Author gga...@apple.com
Date 2015-11-20 15:10:02 -0800 (Fri, 20 Nov 2015)


Log Message
A hung webpage pretends to be responsive if you scroll
https://bugs.webkit.org/show_bug.cgi?id=151518

Reviewed by Sam Weinig.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent): Don't treat wheel events as
starting or stopping the responsiveness timer. Wheel events usually
process on the event dispatch thread, which responds even if the main
thread is hung.

Instead, send an out-of-band ping to the main thread to verify that
it is still responsive and we'll be able to paint and respond to clicks
after scrolling.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::sendMainThreadPing):
(WebKit::WebProcessProxy::didReceiveMainThreadPing):
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in: UI process support for pinging
the main thread in the web process.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::mainThreadPing):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Web process support for responding
to pings.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.h
trunk/Source/WebKit2/UIProcess/WebProcessProxy.messages.in
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
trunk/Source/WebKit2/WebProcess/WebProcess.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (192701 => 192702)

--- trunk/Source/WebKit2/ChangeLog	2015-11-20 22:55:56 UTC (rev 192701)
+++ trunk/Source/WebKit2/ChangeLog	2015-11-20 23:10:02 UTC (rev 192702)
@@ -1,3 +1,34 @@
+2015-11-20  Geoffrey Garen  
+
+A hung webpage pretends to be responsive if you scroll
+https://bugs.webkit.org/show_bug.cgi?id=151518
+
+Reviewed by Sam Weinig.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::sendWheelEvent):
+(WebKit::WebPageProxy::didReceiveEvent): Don't treat wheel events as
+starting or stopping the responsiveness timer. Wheel events usually
+process on the event dispatch thread, which responds even if the main
+thread is hung.
+
+Instead, send an out-of-band ping to the main thread to verify that
+it is still responsive and we'll be able to paint and respond to clicks
+after scrolling.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::sendMainThreadPing):
+(WebKit::WebProcessProxy::didReceiveMainThreadPing):
+* UIProcess/WebProcessProxy.h:
+* UIProcess/WebProcessProxy.messages.in: UI process support for pinging
+the main thread in the web process.
+
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::mainThreadPing):
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in: Web process support for responding
+to pings.
+
 2015-11-20  Simon Fraser  
 
 Allow more buffer formats in the IOSurface pool


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (192701 => 192702)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2015-11-20 22:55:56 UTC (rev 192701)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2015-11-20 23:10:02 UTC (rev 192702)
@@ -1797,8 +1797,6 @@
 
 void WebPageProxy::sendWheelEvent(const WebWheelEvent& event)
 {
-m_process->responsivenessTimer().start();
-
 m_process->send(
 Messages::EventDispatcher::WheelEvent(
 m_pageID,
@@ -1808,6 +1806,8 @@
 rubberBandsAtTop(),
 rubberBandsAtBottom()
 ), 0);
+
+m_process->sendMainThreadPing();
 }
 
 void WebPageProxy::handleKeyboardEvent(const NativeWebKeyboardEvent& event)
@@ -4500,6 +4500,7 @@
 switch (type) {
 case WebEvent::NoType:
 case WebEvent::MouseMove:
+case WebEvent::Wheel:
 break;
 
 case WebEvent::MouseDown:
@@ -4507,7 +4508,6 @@
 case WebEvent::MouseForceChanged:
 case WebEvent::MouseForceDown:
 case WebEvent::MouseForceUp:
-case WebEvent::Wheel:
 case WebEvent::KeyDown:
 case WebEvent::KeyUp:
 case WebEvent::RawKeyDown:


Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (192701 => 192702)

--- trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2015-11-20 22:55:56 UTC (rev 192701)
+++ trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp	2015-11-20 23:10:02 UTC (rev 192702)
@@ -1002,4 +1002,15 @@
 m_tokenForHoldingLockedFiles = m_throttler.backgroundActivityToken();
 }
 
+void WebProcessProxy::sendMainThreadPing()
+{
+responsivenessTimer().start();
+send(Messages::WebProcess::MainThreadPing(), 0);
+}
+
+void WebProcessProxy::didReceiveMainThreadPing()
+{
+responsivenessTimer().stop();
+}
+
 } // namespace WebKit

[webkit-changes] [192704] trunk/Tools

2015-11-20 Thread commit-queue

Title: [192704] trunk/Tools








Revision 192704
Author commit-qu...@webkit.org
Date 2015-11-20 15:14:52 -0800 (Fri, 20 Nov 2015)


Log Message
Update the patch and the plan files of the graphics benchmark with the latest revision
https://bugs.webkit.org/show_bug.cgi?id=151503

Patch by Said Abou-Hallawa  on 2015-11-20
Reviewed by Ryosuke Niwa.

The time for each graphics test has been shortened from 30 seconds to 10
seconds. We need to update the graphics benchmark patch and plan files so
we can get the results faster. Also this will allow running the benchmark
also on the iOS performance bots.

* Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
* Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan




Diff

Modified: trunk/Tools/ChangeLog (192703 => 192704)

--- trunk/Tools/ChangeLog	2015-11-20 23:10:57 UTC (rev 192703)
+++ trunk/Tools/ChangeLog	2015-11-20 23:14:52 UTC (rev 192704)
@@ -1,3 +1,18 @@
+2015-11-20  Said Abou-Hallawa  
+
+Update the patch and the plan files of the graphics benchmark with the latest revision
+https://bugs.webkit.org/show_bug.cgi?id=151503
+
+Reviewed by Ryosuke Niwa.
+
+The time for each graphics test has been shortened from 30 seconds to 10
+seconds. We need to update the graphics benchmark patch and plan files so
+we can get the results faster. Also this will allow running the benchmark
+also on the iOS performance bots.
+
+* Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
+* Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
+
 2015-11-20  Michael Catanzaro  
 
 Unreviewed, fix installation of ninja-build after the previous commit


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch (192703 => 192704)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch	2015-11-20 23:10:57 UTC (rev 192703)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch	2015-11-20 23:14:52 UTC (rev 192704)
@@ -1,5 +1,5 @@
 diff --git a/runner/resources/animometer.js b/runner/resources/animometer.js
-index e567681..ba0ab0f 100644
+index d3ac8db..230ac05 100644
 --- a/runner/resources/animometer.js
 +++ b/runner/resources/animometer.js
 @@ -41,14 +41,62 @@ window.benchmarkRunnerClient = {
@@ -8,15 +8,15 @@
  
 +_computeTestReport: function(testName, testResults)
 +{
-+return [testResults[Strings["JSON_SCORE"][0]]];
++return [testResults[Strings.json.score]];
 +},
 +
 +_computeSuiteReports: function(suiteName, suiteResults)
 +{
 +var testsReports = {};
 +
-+for (var testName in suiteResults[Strings["JSON_RESULTS"][2]]) {
-+var testReports = this._computeTestReport(testName, suiteResults[Strings["JSON_RESULTS"][2]][testName]);
++for (var testName in suiteResults[Strings.json.results.tests]) {
++var testReports = this._computeTestReport(testName, suiteResults[Strings.json.results.tests][testName]);
 +testsReports[testName] = { "metrics": { "Score": { "current": testReports } } };
 +}
 +
@@ -27,31 +27,31 @@
 +{
 +var suitesReports = {};
 +
-+for (var suiteName in iterationResults[Strings["JSON_RESULTS"][1]]) {
-+var testsReports = this._computeSuiteReports(suiteName, iterationResults[Strings["JSON_RESULTS"][1]][suiteName]);
++for (var suiteName in iterationResults[Strings.json.results.suites]) {
++var testsReports = this._computeSuiteReports(suiteName, iterationResults[Strings.json.results.suites][suiteName]);
 +suitesReports[suiteName] = { "metrics": { "Score": ["Geometric"] }, "tests": testsReports };
 +}
 +
 +return suitesReports;
 +},
 +
-+computeResultsReports: function()
++_computeResultsReports: function()
 +{
 +var json = this._resultsDashboard.toJSON(false, false);
-+var iterationReports = this._computeIterationReports(json[Strings["JSON_RESULTS"][0]][0])
++var iterationReports = this._computeIterationReports(json[Strings.json.results.iterations][0])
 +return {"Animometer": {"metrics" : {"Score" : ["Geometric"]}, "tests" : iterationReports } };
 +},
 +
  didFinishLastIteration: function ()
  {
 -var json = this._resultsDashboard.toJSON(true, true);
--this.score = json[Strings["JSON_SCORE"]];
--this._resultsTable.showIterations(json[Strings["JSON_RESULTS"][0]]);
--sectionsManager.showJSON("json", json[Strings["JSON_RESULTS"][0]][0]);
--suitesManager.updateLocalStorageFromJSON(json[Strings["JSON_RESULTS"][0]][0]);
+-

[webkit-changes] [192700] trunk/Source/WebCore

2015-11-20 Thread bfulgham

Title: [192700] trunk/Source/WebCore








Revision 192700
Author bfulg...@apple.com
Date 2015-11-20 14:35:01 -0800 (Fri, 20 Nov 2015)


Log Message
[Win] Support High DPI drawing with CACFLayers
https://bugs.webkit.org/show_bug.cgi?id=147242


Reviewed by Simon Fraser.

* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
(WebCore::WKCACFViewLayerTreeHost::initializeContext): Set correct content scale factor
for current screen, and apply an appropriate base transform to the CACFLayer so drawing
operations are done properly.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (192699 => 192700)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 22:31:19 UTC (rev 192699)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 22:35:01 UTC (rev 192700)
@@ -1,3 +1,16 @@
+2015-11-20  Brent Fulgham  
+
+[Win] Support High DPI drawing with CACFLayers
+https://bugs.webkit.org/show_bug.cgi?id=147242
+
+
+Reviewed by Simon Fraser.
+
+* platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
+(WebCore::WKCACFViewLayerTreeHost::initializeContext): Set correct content scale factor
+for current screen, and apply an appropriate base transform to the CACFLayer so drawing
+operations are done properly.
+
 2015-11-20  Brady Eidson  
 
 Modern IDB: In the VersionChangeEvent for delete database calls, oldVersion should be null instead of 0.


Modified: trunk/Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp (192699 => 192700)

--- trunk/Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp	2015-11-20 22:31:19 UTC (rev 192699)
+++ trunk/Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp	2015-11-20 22:35:01 UTC (rev 192700)
@@ -26,8 +26,10 @@
 #include "config.h"
 #include "WKCACFViewLayerTreeHost.h"
 
+#include "GDIUtilities.h"
 #include "PlatformCALayer.h"
 #include "SoftLinking.h"
+#include 
 #include 
 #include 
 
@@ -120,6 +122,12 @@
 
 void WKCACFViewLayerTreeHost::initializeContext(void* userData, PlatformCALayer* layer)
 {
+#if HAVE(CACFLAYER_SETCONTENTSSCALE)
+float scaleFactor = deviceScaleFactorForWindow(nullptr);
+CACFLayerSetTransform(layer->platformLayer(), CATransform3DMakeScale(scaleFactor, scaleFactor, 1));
+CACFLayerSetContentsScale(layer->platformLayer(), scaleFactor);
+#endif
+
 WKCACFViewSetContextUserData(m_view.get(), userData);
 WKCACFViewSetLayer(m_view.get(), layer->platformLayer());
 WKCACFViewSetContextDidChangeCallback(m_view.get(), contextDidChangeCallback, this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192701] trunk/Source

2015-11-20 Thread simon . fraser

Title: [192701] trunk/Source








Revision 192701
Author simon.fra...@apple.com
Date 2015-11-20 14:55:56 -0800 (Fri, 20 Nov 2015)


Log Message
Allow more buffer formats in the IOSurface pool
https://bugs.webkit.org/show_bug.cgi?id=151516

Reviewed by Tim Horton.
Source/WebCore:

Previously IOSurface::create was only looking in the pool for RGBA-format surfaces. Change that to
always look in the pool, and to cache all format types. We include format in the criteria used
to pick a surface from the pool.

* platform/graphics/cg/IOSurfacePool.cpp:
(WebCore::surfaceMatchesParameters):
(WebCore::IOSurfacePool::takeSurface):
(WebCore::IOSurfacePool::shouldCacheFormat):
(WebCore::IOSurfacePool::shouldCacheSurface):
(WebCore::IOSurfacePool::addSurface):
* platform/graphics/cg/IOSurfacePool.h:
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
(IOSurface::surfaceFromPool):
(IOSurface::create):
(IOSurface::IOSurface):

Source/WebKit2:

Have RemoteLayerBackingStore go through a static function on IOSurface to return
a surface to the pool, rather than knowing about IOSurfacePool directly.

* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::Buffer::discard):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp
trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.h
trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.h
trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (192700 => 192701)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 22:35:01 UTC (rev 192700)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 22:55:56 UTC (rev 192701)
@@ -1,3 +1,27 @@
+2015-11-20  Simon Fraser  
+
+Allow more buffer formats in the IOSurface pool
+https://bugs.webkit.org/show_bug.cgi?id=151516
+
+Reviewed by Tim Horton.
+
+Previously IOSurface::create was only looking in the pool for RGBA-format surfaces. Change that to
+always look in the pool, and to cache all format types. We include format in the criteria used
+to pick a surface from the pool.
+
+* platform/graphics/cg/IOSurfacePool.cpp:
+(WebCore::surfaceMatchesParameters):
+(WebCore::IOSurfacePool::takeSurface):
+(WebCore::IOSurfacePool::shouldCacheFormat):
+(WebCore::IOSurfacePool::shouldCacheSurface):
+(WebCore::IOSurfacePool::addSurface):
+* platform/graphics/cg/IOSurfacePool.h:
+* platform/graphics/cocoa/IOSurface.h:
+* platform/graphics/cocoa/IOSurface.mm:
+(IOSurface::surfaceFromPool):
+(IOSurface::create):
+(IOSurface::IOSurface):
+
 2015-11-20  Brent Fulgham  
 
 [Win] Support High DPI drawing with CACFLayers


Modified: trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp (192700 => 192701)

--- trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp	2015-11-20 22:35:01 UTC (rev 192700)
+++ trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp	2015-11-20 22:55:56 UTC (rev 192701)
@@ -29,7 +29,6 @@
 #if USE(IOSURFACE)
 
 #include "GraphicsContextCG.h"
-#include "IOSurface.h"
 #include 
 #include 
 #include 
@@ -65,12 +64,13 @@
 return pool;
 }
 
-static bool surfaceMatchesParameters(IOSurface& surface, const IntSize& requestedSize, ColorSpace colorSpace)
+static bool surfaceMatchesParameters(IOSurface& surface, IntSize requestedSize, ColorSpace colorSpace, IOSurface::Format format)
 {
-IntSize surfaceSize = surface.size();
+if (format != surface.format())
+return false;
 if (colorSpace != surface.colorSpace())
 return false;
-if (surfaceSize != requestedSize)
+if (requestedSize != surface.size())
 return false;
 return true;
 }
@@ -107,7 +107,7 @@
 m_sizesInPruneOrder.append(size);
 }
 
-std::unique_ptr IOSurfacePool::takeSurface(IntSize size, ColorSpace colorSpace)
+std::unique_ptr IOSurfacePool::takeSurface(IntSize size, ColorSpace colorSpace, IOSurface::Format format)
 {
 CachedSurfaceMap::iterator mapIter = m_cachedSurfaces.find(size);
 
@@ -117,7 +117,7 @@
 }
 
 for (auto surfaceIter = mapIter->value.begin(); surfaceIter != mapIter->value.end(); ++surfaceIter) {
-if (!surfaceMatchesParameters(*surfaceIter->get(), size, colorSpace))
+if (!surfaceMatchesParameters(*surfaceIter->get(), size, colorSpace, format))
 continue;
 
 auto surface = WTF::move(*surfaceIter);
@@ -140,7 +140,7 @@
 
 // Some of the in-use surfaces may no longer actually be in-use, but we haven't moved them over yet.
 for (auto surfaceIter = m_inUseSurfaces.begin(); surfaceIter != m_inUseSurfaces.end(); ++surfaceIter) {
-if (!surfaceMatchesParameters(*surfaceIter->get(), size, colorSpace))
+if

[webkit-changes] [192705] trunk/Source/WebInspectorUI

2015-11-20 Thread commit-queue

Title: [192705] trunk/Source/WebInspectorUI








Revision 192705
Author commit-qu...@webkit.org
Date 2015-11-20 15:16:18 -0800 (Fri, 20 Nov 2015)


Log Message
Web Inspector: Add support for Gradients in the Visual sidebar background editor
https://bugs.webkit.org/show_bug.cgi?id=150494

Patch by Devin Rousso  on 2015-11-20
Reviewed by Timothy Hatcher.

Allows the editors in the Visual sidebar Background Style section to
work with gradients and data URIs.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Controllers/CodeMirrorGradientEditingController.css: Deleted.
Some styling was reused in VisualStyleBackgroundPicker.css.

* UserInterface/Controllers/CodeMirrorGradientEditingController.js:
(WebInspector.CodeMirrorGradientEditingController):
(WebInspector.CodeMirrorGradientEditingController.prototype.popoverWillPresent):
(WebInspector.CodeMirrorGradientEditingController.prototype.popoverDidPresent):
(WebInspector.CodeMirrorGradientEditingController.prototype._gradientEditorGradientChanged):
(WebInspector.CodeMirrorGradientEditingController.prototype.handleEvent): Deleted.
(WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopsDidChange): Deleted.
(WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected): Deleted.
(WebInspector.CodeMirrorGradientEditingController.prototype.dragToAdjustControllerWasAdjustedByAmount): Deleted.
(WebInspector.CodeMirrorGradientEditingController.prototype._handleInputEvent): Deleted.
(WebInspector.CodeMirrorGradientEditingController.prototype._angleInputValueDidChange): Deleted.
(WebInspector.CodeMirrorGradientEditingController.prototype._handleChangeEvent): Deleted.
(WebInspector.CodeMirrorGradientEditingController.prototype._colorPickerColorChanged): Deleted.
(WebInspector.CodeMirrorGradientEditingController.prototype._updateCSSClassForGradientType): Deleted.
Reworked gradient editor popup into WebInspector.GradientEditor.

* UserInterface/Main.html:
* UserInterface/Models/Gradient.js:
(WebInspector.Gradient.fromString):
(WebInspector.Gradient.stopsWithComponents):
(WebInspector.LinearGradient.linearGradientWithComponents):
Removed console.error statements as they didn't do anything but clog the console.

* UserInterface/Views/GradientEditor.css: Added.
(.gradient-editor):
(.gradient-editor.radial-gradient):
(.gradient-editor.editing-color):
(.gradient-editor.radial-gradient.editing-color):
(.gradient-editor > .gradient-type-select):
(.gradient-editor > .gradient-slider):
(.gradient-editor > .color-picker):
(.gradient-editor > .color-picker > .slider):
(.gradient-editor > .color-picker > .brightness):
(.gradient-editor > .color-picker > .opacity):
(.gradient-editor > .gradient-angle):
(.gradient-editor.radial-gradient > .gradient-angle):
(.gradient-editor > .gradient-angle > input):

* UserInterface/Views/GradientEditor.js: Added.
(WebInspector.GradientEditor):
(WebInspector.GradientEditor.prototype.get element):
(WebInspector.GradientEditor.prototype.set gradient):
(WebInspector.GradientEditor.prototype.get gradient):
(WebInspector.GradientEditor.prototype.gradientSliderStopsDidChange):
(WebInspector.GradientEditor.prototype.gradientSliderStopWasSelected):
(WebInspector.GradientEditor.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.GradientEditor.prototype._updateCSSClassForGradientType):
(WebInspector.GradientEditor.prototype._gradientTypeChanged):
(WebInspector.GradientEditor.prototype._colorPickerColorChanged):
(WebInspector.GradientEditor.prototype._angleChanged):
(WebInspector.GradientEditor.prototype._angleInputValueDidChange):
New standalone editor for CSS Gradients.

* UserInterface/Views/VisualStyleBackgroundPicker.css: Added.
(.visual-style-property-container.background-picker > .visual-style-property-value-container):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .color-gradient-swatch):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .color-gradient-swatch:hover):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .color-gradient-swatch:active):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .color-gradient-swatch > span):
(.visual-style-property-container.background-picker > .visual-style-property-value-container.gradient-value > .color-gradient-swatch):
(.visual-style-property-container.background-picker > .visual-style-property-value-container.gradient-value > .color-gradient-swatch + .value-input):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .value-input):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .value-input[disabled]):
(.visual-style-property-container.background-picker > .visual-style-property-value-container > .value-type-picker-select):

*

[webkit-changes] [192707] trunk/Tools

2015-11-20 Thread ap

Title: [192707] trunk/Tools








Revision 192707
Author a...@apple.com
Date 2015-11-20 15:37:23 -0800 (Fri, 20 Nov 2015)


Log Message
Went a bit too far, revert part of the previous patch.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/maveri...@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/maveri...@2x.png




Diff

Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png

(Binary files differ)

Property changes on: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png
___

Added: svn:mime-type

Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/maveri...@2x.png

(Binary files differ)

Property changes on: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/maveri...@2x.png
___

Added: svn:mime-type

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js (192706 => 192707)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js	2015-11-20 23:16:44 UTC (rev 192706)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js	2015-11-20 23:37:23 UTC (rev 192707)
@@ -27,6 +27,7 @@
 Platform: {
 MacOSXElCapitan: { name: "mac-os-x-elcapitan", readableName: "OS X El Capitan", order: 9 },
 MacOSXYosemite: { name: "mac-os-x-yosemite", readableName: "OS X Yosemite", order: 10 },
+MacOSXMavericks: { name: "mac-os-x-mavericks", readableName: "OS X Mavericks", order: 20 },
 iOS9Simulator: { name: "ios-simulator-9", readableName: "iOS 9 Simulator", order: 30 },
 iOS9Device: { name: "ios-9", readableName: "iOS 9", order: 40 },
 Windows8: { name: "windows-8", readableName: "Windows 8", order: 50 },


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (192706 => 192707)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css	2015-11-20 23:16:44 UTC (rev 192706)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css	2015-11-20 23:37:23 UTC (rev 192707)
@@ -188,6 +188,10 @@
 content: -webkit-image-set(url(../Images/yosem...@2x.png) 2x, url(../Images/Yosemite.png) 1x);
 }
 
+table.queue-grid tr.platform.mac-os-x-mavericks img.logo { 
+content: -webkit-image-set(url(../Images/maveri...@2x.png) 2x, url(../Images/Mavericks.png) 1x); 
+} 
+
 table.queue-grid tr.platform.windows-8 img.logo {
 content: -webkit-image-set(url(../Images/windo...@2x.png) 2x, url(../Images/Windows8.png) 1x);
 }


Modified: trunk/Tools/ChangeLog (192706 => 192707)

--- trunk/Tools/ChangeLog	2015-11-20 23:16:44 UTC (rev 192706)
+++ trunk/Tools/ChangeLog	2015-11-20 23:37:23 UTC (rev 192707)
@@ -1,5 +1,14 @@
 2015-11-20  Alexey Proskuryakov  
 
+Went a bit too far, revert part of the previous patch.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/maveri...@2x.png: Added.
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
+* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+
+2015-11-20  Alexey Proskuryakov  
+
 Remove Mavericks bots.
 
 Rubber-stamped by Lucas Forschler.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192709] trunk/Source/WebCore

2015-11-20 Thread simon . fraser

Title: [192709] trunk/Source/WebCore








Revision 192709
Author simon.fra...@apple.com
Date 2015-11-20 16:04:20 -0800 (Fri, 20 Nov 2015)


Log Message
Fix the Windows build.

* platform/graphics/cg/IOSurfacePool.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (192708 => 192709)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 23:45:40 UTC (rev 192708)
+++ trunk/Source/WebCore/ChangeLog	2015-11-21 00:04:20 UTC (rev 192709)
@@ -1,5 +1,11 @@
 2015-11-20  Simon Fraser  
 
+Fix the Windows build.
+
+* platform/graphics/cg/IOSurfacePool.h:
+
+2015-11-20  Simon Fraser  
+
 Allow more buffer formats in the IOSurface pool
 https://bugs.webkit.org/show_bug.cgi?id=151516
 


Modified: trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.h (192708 => 192709)

--- trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.h	2015-11-20 23:45:40 UTC (rev 192708)
+++ trunk/Source/WebCore/platform/graphics/cg/IOSurfacePool.h	2015-11-21 00:04:20 UTC (rev 192709)
@@ -26,6 +26,8 @@
 #ifndef IOSurfacePool_h
 #define IOSurfacePool_h
 
+#if USE(IOSURFACE)
+
 #include "ColorSpace.h"
 #include "IOSurface.h"
 #include "IntSize.h"
@@ -36,8 +38,6 @@
 #include 
 #include 
 
-#if USE(IOSURFACE)
-
 namespace WebCore {
 
 class IOSurfacePool {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192711] trunk/Source/WebCore

2015-11-20 Thread commit-queue

Title: [192711] trunk/Source/WebCore








Revision 192711
Author commit-qu...@webkit.org
Date 2015-11-20 17:42:11 -0800 (Fri, 20 Nov 2015)


Log Message
Renaming PageCache suspension code to support more reasons for suspension.
https://bugs.webkit.org/show_bug.cgi?id=151527

Patch by Katlyn Graff  on 2015-11-20
Reviewed by Ryosuke Niwa.

No new tests because this is simply a refactor.

Renamed Element:: and Document:: documentWillSuspendForPageCache(),
documentDidResumeFromPageCache(),
registerForPageCacheSuspensionCallbacks(),
unregisterForPageCacheSuspensionCallbacks() to prepare to support
alternate reasons for document-level suspension.

* dom/Document.cpp:
(WebCore::Document::suspend):
(WebCore::Document::resume):
(WebCore::Document::registerForDocumentSuspensionCallbacks):
(WebCore::Document::unregisterForDocumentSuspensionCallbacks):
(WebCore::Document::documentWillSuspendForPageCache): Deleted.
(WebCore::Document::documentDidResumeFromPageCache): Deleted.
(WebCore::Document::registerForPageCacheSuspensionCallbacks): Deleted.
(WebCore::Document::unregisterForPageCacheSuspensionCallbacks): Deleted.
* dom/Document.h:
* dom/Element.h:
(WebCore::Element::prepareForDocumentSuspension):
(WebCore::Element::resumeFromDocumentSuspension):
(WebCore::Element::documentWillSuspendForPageCache): Deleted.
(WebCore::Element::documentDidResumeFromPageCache): Deleted.
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::parseAttribute):
(WebCore::HTMLFormElement::resumeFromDocumentSuspension):
(WebCore::HTMLFormElement::didMoveToNewDocument):
(WebCore::HTMLFormElement::documentDidResumeFromPageCache): Deleted.
* html/HTMLFormElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::registerForSuspensionCallbackIfNeeded):
(WebCore::HTMLInputElement::unregisterForSuspensionCallbackIfNeeded):
(WebCore::HTMLInputElement::resumeFromDocumentSuspension):
(WebCore::HTMLInputElement::prepareForDocumentSuspension):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::documentDidResumeFromPageCache): Deleted.
(WebCore::HTMLInputElement::documentWillSuspendForPageCache): Deleted.
* html/HTMLInputElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::prepareForDocumentSuspension):
(WebCore::HTMLMediaElement::resumeFromDocumentSuspension):
(WebCore::HTMLMediaElement::documentWillSuspendForPageCache): Deleted.
(WebCore::HTMLMediaElement::documentDidResumeFromPageCache): Deleted.
* html/HTMLMediaElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::createElementRenderer):
(WebCore::HTMLPlugInImageElement::didMoveToNewDocument):
(WebCore::HTMLPlugInImageElement::prepareForDocumentSuspension):
(WebCore::HTMLPlugInImageElement::resumeFromDocumentSuspension):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache): Deleted.
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache): Deleted.
* html/HTMLPlugInImageElement.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::prepareForDocumentSuspension):
(WebCore::SVGSVGElement::resumeFromDocumentSuspension):
(WebCore::SVGSVGElement::documentWillSuspendForPageCache): Deleted.
(WebCore::SVGSVGElement::documentDidResumeFromPageCache): Deleted.
* svg/SVGSVGElement.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/history/CachedFrame.cpp
trunk/Source/WebCore/html/HTMLFormElement.cpp
trunk/Source/WebCore/html/HTMLFormElement.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp
trunk/Source/WebCore/html/HTMLPlugInImageElement.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/svg/SVGSVGElement.cpp
trunk/Source/WebCore/svg/SVGSVGElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (192710 => 192711)

--- trunk/Source/WebCore/ChangeLog	2015-11-21 00:20:53 UTC (rev 192710)
+++ trunk/Source/WebCore/ChangeLog	2015-11-21 01:42:11 UTC (rev 192711)
@@ -1,3 +1,82 @@
+2015-11-20  Katlyn Graff  
+
+Renaming PageCache suspension code to support more reasons for suspension.
+https://bugs.webkit.org/show_bug.cgi?id=151527
+
+Reviewed by Ryosuke Niwa.
+
+No

[webkit-changes] [192712] trunk/Source

2015-11-20 Thread simon . fraser

Title: [192712] trunk/Source








Revision 192712
Author simon.fra...@apple.com
Date 2015-11-20 17:51:48 -0800 (Fri, 20 Nov 2015)


Log Message
More deviceRGB color cleanup
https://bugs.webkit.org/show_bug.cgi?id=151523


Reviewed by Tim Horton.

Replace calls to deviceRGBColorSpaceRef() with sRGBColorSpaceRef(), and use
sRGBColorSpaceRef() in a few places that were manually creating the colorspace.

Also use cachedCGColor() in a more places that were manually constructing CGColorRefs
from Colors.

Source/WebCore:

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect):
(WebCore::createImageFromPixelBuffer):
* platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::setBackgroundColor):
(PlatformCALayerCocoa::setBorderColor):
* platform/graphics/ca/cocoa/WebSystemBackdropLayer.mm:
(-[WebLightSystemBackdropLayer init]):
(-[WebDarkSystemBackdropLayer init]):
* platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformGradient):
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::linearRGBColorSpaceRef):
* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer copyImageSnapshotWithColorSpace:]):
* platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::currentFrameCGImage):
* rendering/RenderThemeIOS.mm:
(WebCore::drawRadialGradient):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):

Source/WebKit2:

* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::createCGImage):
* Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::cgColorFromColor):
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::initializeDebugIndicator):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
trunk/Source/WebCore/platform/graphics/ca/cocoa/WebSystemBackdropLayer.mm
trunk/Source/WebCore/platform/graphics/cg/GradientCG.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
trunk/Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm
trunk/Source/WebCore/platform/graphics/mac/WebGLLayer.mm
trunk/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
trunk/Source/WebCore/rendering/RenderThemeIOS.mm
trunk/Source/WebCore/rendering/RenderThemeMac.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp
trunk/Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm
trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (192711 => 192712)

--- trunk/Source/WebCore/ChangeLog	2015-11-21 01:42:11 UTC (rev 192711)
+++ trunk/Source/WebCore/ChangeLog	2015-11-21 01:51:48 UTC (rev 192712)
@@ -1,3 +1,48 @@
+2015-11-20  Simon Fraser  
+
+More deviceRGB color cleanup
+https://bugs.webkit.org/show_bug.cgi?id=151523
+
+
+Reviewed by Tim Horton.
+
+Replace calls to deviceRGBColorSpaceRef() with sRGBColorSpaceRef(), and use
+sRGBColorSpaceRef() in a few places that were manually creating the colorspace.
+
+Also use cachedCGColor() in a more places that were manually constructing CGColorRefs
+from Colors.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect):
+(WebCore::createImageFromPixelBuffer):
+* platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
+* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
+(PlatformCALayerCocoa::setBackgroundColor):
+(PlatformCALayerCocoa::setBorderColor):
+* platform/graphics/ca/cocoa/WebSystemBackdropLayer.mm:
+(-[WebLightSystemBackdropLayer init]):
+(-[WebDarkSystemBackdropLayer init]):
+* platform/graphics/cg/GradientCG.cpp:
+(WebCore::Gradient::platformGradient):
+* platform/graphics/cg/GraphicsContext3DCG.cpp:
+(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
+(WebCore::GraphicsContext3D::paintToCanvas):
+* platform/graphics/cg/ImageBufferCG.cpp:
+(WebCore::ImageBuffer::copyImage):
+

[webkit-changes] [192678] trunk/Source/WebCore

2015-11-20 Thread ddkilzer

Title: [192678] trunk/Source/WebCore








Revision 192678
Author ddkil...@apple.com
Date 2015-11-20 00:09:16 -0800 (Fri, 20 Nov 2015)


Log Message
REGRESSION (r192460,r192677): Fix all the builds

* platform/spi/cocoa/QuartzCoreSPI.h: Check different.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (192677 => 192678)

--- trunk/Source/WebCore/ChangeLog	2015-11-20 07:02:23 UTC (rev 192677)
+++ trunk/Source/WebCore/ChangeLog	2015-11-20 08:09:16 UTC (rev 192678)
@@ -1,3 +1,9 @@
+2015-11-20  David Kilzer  
+
+REGRESSION (r192460,r192677): Fix all the builds
+
+* platform/spi/cocoa/QuartzCoreSPI.h: Check different.
+
 2015-11-19  David Kilzer  
 
 REGRESSION (r192460): Fix tvOS build again


Modified: trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h (192677 => 192678)

--- trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h	2015-11-20 07:02:23 UTC (rev 192677)
+++ trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h	2015-11-20 08:09:16 UTC (rev 192678)
@@ -196,10 +196,10 @@
 EXTERN_C NSString * const kCAContextDisplayId;
 EXTERN_C NSString * const kCAContextIgnoresHitTest;
 
-#if (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED < 9) \
-|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED < 3) \
-|| (PLATFORM(IOS) && TARGET_OS_IOS && __IPHONE_OS_VERSION_MAX_ALLOWED < 10) \
-|| (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101200)
+#if (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED < 10) \
+|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED < 3) \
+|| (PLATFORM(IOS) && TARGET_OS_IOS && __IPHONE_OS_VERSION_MIN_REQUIRED < 10) \
+|| (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101200)
 @protocol CALayerDelegate 
 @end
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192713] trunk/LayoutTests

2015-11-20 Thread cdumez

Title: [192713] trunk/LayoutTests








Revision 192713
Author cdu...@apple.com
Date 2015-11-20 18:29:23 -0800 (Fri, 20 Nov 2015)


Log Message
Unreviewed, mark fast/replaced/replaced-breaking.html as failing on ElCapitan-wk1.

The test gives a slightly different output of this configuration only
and I don't think we can have platform-specific test expectations for
this particular configuration.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (192712 => 192713)

--- trunk/LayoutTests/ChangeLog	2015-11-21 01:51:48 UTC (rev 192712)
+++ trunk/LayoutTests/ChangeLog	2015-11-21 02:29:23 UTC (rev 192713)
@@ -1,3 +1,13 @@
+2015-11-20  Chris Dumez  
+
+Unreviewed, mark fast/replaced/replaced-breaking.html as failing on ElCapitan-wk1.
+
+The test gives a slightly different output of this configuration only
+and I don't think we can have platform-specific test expectations for
+this particular configuration.
+
+* platform/mac-wk1/TestExpectations:
+
 2015-11-20  Commit Queue  
 
 Unreviewed, rolling out r192139.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192712 => 192713)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-11-21 01:51:48 UTC (rev 192712)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-11-21 02:29:23 UTC (rev 192713)
@@ -143,6 +143,9 @@
 
 [ ElCapitan+ ] css3/masking/mask-repeat-space-padding.html [ ImageOnlyFailure ]
 
+# This test gives a different output on ElCapitan-wk1 only.
+[ ElCapitan+ ] fast/replaced/replaced-breaking.html [ Failure ]
+
 webkit.org/b/151219 storage/indexeddb/modern/idbindex-properties-basic.html [ Pass Timeout ]
 
 webkit.org/b/151364 storage/indexeddb/modern/get-index-failures.html [ Pass Timeout ]
@@ -182,4 +185,4 @@
 imported/blink/compositing/layer-creation/iframe-clip-removed.html [ Pass Timeout ]
 
 # ASAN test only fails on WK1:
-webgl/1.0.3/151055_asan.html [ Failure ]
\ No newline at end of file
+webgl/1.0.3/151055_asan.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192714] trunk/Tools

2015-11-20 Thread said

Title: [192714] trunk/Tools








Revision 192714
Author s...@apple.com
Date 2015-11-20 18:51:51 -0800 (Fri, 20 Nov 2015)


Log Message
Unreviewed, add watchlist for PerformanceTests/Animometer and add myself.
 
* Scripts/webkitpy/common/config/watchlist:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist




Diff

Modified: trunk/Tools/ChangeLog (192713 => 192714)

--- trunk/Tools/ChangeLog	2015-11-21 02:29:23 UTC (rev 192713)
+++ trunk/Tools/ChangeLog	2015-11-21 02:51:51 UTC (rev 192714)
@@ -1,3 +1,9 @@
+2015-11-20  Said Abou-Hallawa  
+
+Unreviewed, add watchlist for PerformanceTests/Animometer and add myself.
+ 
+* Scripts/webkitpy/common/config/watchlist:
+
 2015-11-20  Alexey Proskuryakov  
 
 Went a bit too far, revert part of the previous patch.


Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (192713 => 192714)

--- trunk/Tools/Scripts/webkitpy/common/config/watchlist	2015-11-21 02:29:23 UTC (rev 192713)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist	2015-11-21 02:51:51 UTC (rev 192714)
@@ -236,6 +236,9 @@
 "filename": r"PerformanceTests"
 r"|Tools/Scripts/webkitpy/performance_tests",
 },
+"Animometer": {
+"filename": r"PerformanceTests/Animometer",
+},
 "ConsoleUsage": {
 "more": r"[Aa]ddConsoleMessage|reportException|logExceptionToConsole|addMessage|printErrorMessage"
 },
@@ -339,6 +342,7 @@
 # two different accounts as far as bugzilla is concerned.
 "Accessibility": [ "cfleiz...@apple.com", "dmazz...@google.com", "apinhe...@igalia.com", "jdi...@igalia.com", "aboxh...@chromium.org", "ma...@webkit.org", "samuel_wh...@apple.com", "jcr...@apple.com" ],
 "Animation" : [ "simon.fra...@apple.com", "d...@apple.com", "dstockw...@chromium.org" ],
+"Animometer" : [ "sabouhall...@apple.com" ],
 "AppleMacPublicApi": [ "timo...@apple.com" ],
 "Battery": [ "gyuyoung@webkit.org" ],
 "BindingsScripts": [ "cdu...@apple.com", "cgar...@igalia.com" ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192717] trunk/Websites/perf.webkit.org

2015-11-20 Thread rniwa

Title: [192717] trunk/Websites/perf.webkit.org








Revision 192717
Author rn...@webkit.org
Date 2015-11-20 19:16:11 -0800 (Fri, 20 Nov 2015)


Log Message
Build fix for old version of PHP.

* public/api/runs.php:

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/api/runs.php




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (192716 => 192717)

--- trunk/Websites/perf.webkit.org/ChangeLog	2015-11-21 03:12:14 UTC (rev 192716)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2015-11-21 03:16:11 UTC (rev 192717)
@@ -1,5 +1,11 @@
 2015-11-20  Ryosuke Niwa  
 
+Build fix for old version of PHP.
+
+* public/api/runs.php:
+
+2015-11-20  Ryosuke Niwa  
+
 Perf dashboard's should not include results more than 366 days old in JSON
 https://bugs.webkit.org/show_bug.cgi?id=151529
 


Modified: trunk/Websites/perf.webkit.org/public/api/runs.php (192716 => 192717)

--- trunk/Websites/perf.webkit.org/public/api/runs.php	2015-11-21 03:12:14 UTC (rev 192716)
+++ trunk/Websites/perf.webkit.org/public/api/runs.php	2015-11-21 03:16:11 UTC (rev 192717)
@@ -41,9 +41,10 @@
 foreach ($config_rows as $config)
 $generator->fetch_runs($config['config_type'], $config['config_id'], $config['config_runs_last_modified']);
 
-$content = success_json($generator->results());
+$results = $generator->results();
+$content = success_json($results);
 if (!$should_echo_results) {
-echo $generator->results()['elapsedTime'];
+echo $results['elapsedTime'];
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192715] trunk/PerformanceTests

2015-11-20 Thread simon . fraser

Title: [192715] trunk/PerformanceTests








Revision 192715
Author simon.fra...@apple.com
Date 2015-11-20 19:05:50 -0800 (Fri, 20 Nov 2015)


Log Message
Animometer: graphs should not do interpolation
https://bugs.webkit.org/show_bug.cgi?id=151526

Reviewed by Simon Fraser.

Having the graphs do interpolation is misleading, because you can't see the actual data.

Also remove "shape-rendering: crispEdges;" so the lines get antialiased.

* Animometer/runner/resources/animometer.css:
(section#test-graph > data > svg): Deleted.
* Animometer/runner/resources/graph.js:
(graph): Deleted.

Modified Paths

trunk/PerformanceTests/Animometer/runner/resources/animometer.css
trunk/PerformanceTests/Animometer/runner/resources/graph.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/runner/resources/animometer.css (192714 => 192715)

--- trunk/PerformanceTests/Animometer/runner/resources/animometer.css	2015-11-21 02:51:51 UTC (rev 192714)
+++ trunk/PerformanceTests/Animometer/runner/resources/animometer.css	2015-11-21 03:05:50 UTC (rev 192715)
@@ -419,7 +419,6 @@
 
 section#test-graph > data > svg {
 fill: none;
-shape-rendering: crispEdges;  
 }
 
 .axis path,


Modified: trunk/PerformanceTests/Animometer/runner/resources/graph.js (192714 => 192715)

--- trunk/PerformanceTests/Animometer/runner/resources/graph.js	2015-11-21 02:51:51 UTC (rev 192714)
+++ trunk/PerformanceTests/Animometer/runner/resources/graph.js	2015-11-21 03:05:50 UTC (rev 192715)
@@ -30,12 +30,10 @@
 .orient("right");
 
 var lineLeft = d3.svg.line()
-.interpolate("basis")
 .x(function(d) { return x(d.timeOffset); })
 .y(function(d) { return yLeft(d.values[0]); });
 
 var lineRight = d3.svg.line()
-.interpolate("basis")
 .x(function(d) { return x(d.timeOffset); })
 .y(function(d) { return yRight(d.values[1]); });
 


Modified: trunk/PerformanceTests/ChangeLog (192714 => 192715)

--- trunk/PerformanceTests/ChangeLog	2015-11-21 02:51:51 UTC (rev 192714)
+++ trunk/PerformanceTests/ChangeLog	2015-11-21 03:05:50 UTC (rev 192715)
@@ -1,3 +1,19 @@
+2015-11-20  Simon Fraser  
+
+Animometer: graphs should not do interpolation
+https://bugs.webkit.org/show_bug.cgi?id=151526
+
+Reviewed by Simon Fraser.
+
+Having the graphs do interpolation is misleading, because you can't see the actual data.
+
+Also remove "shape-rendering: crispEdges;" so the lines get antialiased.
+
+* Animometer/runner/resources/animometer.css:
+(section#test-graph > data > svg): Deleted.
+* Animometer/runner/resources/graph.js:
+(graph): Deleted.
+
 2015-11-19  Said Abou-Hallawa  
 
 Calculate the graphics benchmark test gain adaptively






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192722] trunk

2015-11-20 Thread akling

Title: [192722] trunk








Revision 192722
Author akl...@apple.com
Date 2015-11-20 22:07:40 -0800 (Fri, 20 Nov 2015)


Log Message
REGRESSION(r192536): Null pointer dereference in JSPropertyNameEnumerator::visitChildren().


Reviewed by Mark Lam.

Source/_javascript_Core:

The copied space allocation in JSPropertyNameEnumerator::finishCreation()
may end up triggering a GC, and so JSPropertyNameEnumerator::visitChildren()
would get called while m_propertyNames was still null.

This patch fixes that by having visitChildren() check for pointer nullity
instead of the number of names, since that is non-zero even before the
allocation is made.

Added a test that induces GC during JSPropertyNameEnumerator construction
to cover this bug.

Test: property-name-enumerator-gc-151495.js

* runtime/JSPropertyNameEnumerator.cpp:
(JSC::JSPropertyNameEnumerator::visitChildren):

LayoutTests:

* js/property-name-enumerator-gc-151495.html: Added.
* js/property-name-enumerator-gc-151495-expected.txt: Added.
* js/script-tests/property-name-enumerator-gc-151495.js: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSPropertyNameEnumerator.cpp


Added Paths

trunk/LayoutTests/js/property-name-enumerator-gc-151495-expected.txt
trunk/LayoutTests/js/property-name-enumerator-gc-151495.html
trunk/LayoutTests/js/script-tests/property-name-enumerator-gc-151495.js




Diff

Modified: trunk/LayoutTests/ChangeLog (192721 => 192722)

--- trunk/LayoutTests/ChangeLog	2015-11-21 04:40:40 UTC (rev 192721)
+++ trunk/LayoutTests/ChangeLog	2015-11-21 06:07:40 UTC (rev 192722)
@@ -1,3 +1,14 @@
+2015-11-20  Andreas Kling  
+
+REGRESSION(r192536): Null pointer dereference in JSPropertyNameEnumerator::visitChildren().
+
+
+Reviewed by Mark Lam.
+
+* js/property-name-enumerator-gc-151495.html: Added.
+* js/property-name-enumerator-gc-151495-expected.txt: Added.
+* js/script-tests/property-name-enumerator-gc-151495.js: Added.
+
 2015-11-20  Brady Eidson  
 
 Modern IDB: After versionchange transactions complete, fire onsuccess on the original IDBOpenDBRequest


Added: trunk/LayoutTests/js/property-name-enumerator-gc-151495-expected.txt (0 => 192722)

--- trunk/LayoutTests/js/property-name-enumerator-gc-151495-expected.txt	(rev 0)
+++ trunk/LayoutTests/js/property-name-enumerator-gc-151495-expected.txt	2015-11-21 06:07:40 UTC (rev 192722)
@@ -0,0 +1,9 @@
+Regression test for https://webkit.org/b/151495. - This test should not crash.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/js/property-name-enumerator-gc-151495.html (0 => 192722)

--- trunk/LayoutTests/js/property-name-enumerator-gc-151495.html	(rev 0)
+++ trunk/LayoutTests/js/property-name-enumerator-gc-151495.html	2015-11-21 06:07:40 UTC (rev 192722)
@@ -0,0 +1,10 @@
+
+
+

[webkit-changes] [192718] trunk/Source/WebInspectorUI

2015-11-20 Thread mattbaker

Title: [192718] trunk/Source/WebInspectorUI








Revision 192718
Author mattba...@apple.com
Date 2015-11-20 19:29:31 -0800 (Fri, 20 Nov 2015)


Log Message
Web Inspector: Remove "Show only resources with breakpoints" filter button
https://bugs.webkit.org/show_bug.cgi?id=151517

Reviewed by Timothy Hatcher.

Removed filter button in preparation for https://bugs.webkit.org/show_bug.cgi?id=151119.

* UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.showResourcesWithBreakpointsOnlyFilterFunction): Deleted.
(WebInspector.DebuggerSidebarPanel): Deleted.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (192717 => 192718)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-11-21 03:16:11 UTC (rev 192717)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-11-21 03:29:31 UTC (rev 192718)
@@ -1,3 +1,16 @@
+2015-11-20  Matt Baker  
+
+Web Inspector: Remove "Show only resources with breakpoints" filter button
+https://bugs.webkit.org/show_bug.cgi?id=151517
+
+Reviewed by Timothy Hatcher.
+
+Removed filter button in preparation for https://bugs.webkit.org/show_bug.cgi?id=151119.
+
+* UserInterface/Views/DebuggerSidebarPanel.js:
+(WebInspector.DebuggerSidebarPanel.showResourcesWithBreakpointsOnlyFilterFunction): Deleted.
+(WebInspector.DebuggerSidebarPanel): Deleted.
+
 2015-11-20  Devin Rousso  
 
 Web Inspector: Add support for Gradients in the Visual sidebar background editor


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js (192717 => 192718)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2015-11-21 03:16:11 UTC (rev 192717)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js	2015-11-21 03:29:31 UTC (rev 192718)
@@ -93,22 +93,7 @@
 this._allUncaughtExceptionsBreakpointTreeElement = new WebInspector.BreakpointTreeElement(WebInspector.debuggerManager.allUncaughtExceptionsBreakpoint, WebInspector.DebuggerSidebarPanel.ExceptionIconStyleClassName, WebInspector.UIString("All Uncaught Exceptions"));
 
 this.filterBar.placeholder = WebInspector.UIString("Filter Breakpoint List");
-var showResourcesWithBreakpointsOnlyFilterFunction = function(treeElement)
-{
-// Keep breakpoints.
-if (treeElement instanceof WebInspector.BreakpointTreeElement)
-return true;
 
-// Keep resources with breakpoints.
-if (treeElement.hasChildren) {
-for (var child of treeElement.children) {
-if (child instanceof WebInspector.BreakpointTreeElement)
-return true;
-}
-}
-return false;
-};
-
 var showResourcesWithIssuesOnlyFilterFunction = function(treeElement)
 {
 // Keep issues.
@@ -125,7 +110,6 @@
 return false;
 };
 
-this.filterBar.addFilterBarButton("debugger-show-resources-with-breakpoints-only", showResourcesWithBreakpointsOnlyFilterFunction, true, WebInspector.UIString("Show only resources with breakpoints."), WebInspector.UIString("Show resources with and without breakpoints."), "Images/Breakpoints.svg", 15, 15);
 this.filterBar.addFilterBarButton("debugger-show-resources-with-issues-only", showResourcesWithIssuesOnlyFilterFunction, true, WebInspector.UIString("Show only resources with issues."), WebInspector.UIString("Show resources with and without issues."), "Images/Errors.svg", 15, 15);
 
 this._breakpointsContentTreeOutline = this.contentTreeOutline;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192716] trunk/Websites/perf.webkit.org

2015-11-20 Thread rniwa

Title: [192716] trunk/Websites/perf.webkit.org








Revision 192716
Author rn...@webkit.org
Date 2015-11-20 19:12:14 -0800 (Fri, 20 Nov 2015)


Log Message
Perf dashboard's should not include results more than 366 days old in JSON
https://bugs.webkit.org/show_bug.cgi?id=151529

Reviewed by Timothy Hatcher.

Don't return results more than 366 days old in /api/runs/ JSON API.
This is a ~5% runtime improvement and reduces the JSON file size by 20-50% in the internal perf dashboard.

* public/api/runs.php:
(main): Added the support for "?noResults" to avoid echoing results. This is useful for debugging.
Also instantiate RunsGenerator before issuing the query to find all configurations so that the runtime cost
of doing so will be included in elapsedTime.
(RunsGenerator::fetch_runs): Skip a row when its build and commit times are more than 366 days old.
(RunsGenerator::format_run): Takes build_time and revisions as arguments since fetch_runs uses them now.
(RunsGenerator::parse_revisions_array): Compute the max of commit times.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/api/runs.php




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (192715 => 192716)

--- trunk/Websites/perf.webkit.org/ChangeLog	2015-11-21 03:05:50 UTC (rev 192715)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2015-11-21 03:12:14 UTC (rev 192716)
@@ -1,5 +1,23 @@
 2015-11-20  Ryosuke Niwa  
 
+Perf dashboard's should not include results more than 366 days old in JSON
+https://bugs.webkit.org/show_bug.cgi?id=151529
+
+Reviewed by Timothy Hatcher.
+
+Don't return results more than 366 days old in /api/runs/ JSON API.
+This is a ~5% runtime improvement and reduces the JSON file size by 20-50% in the internal perf dashboard.
+
+* public/api/runs.php:
+(main): Added the support for "?noResults" to avoid echoing results. This is useful for debugging.
+Also instantiate RunsGenerator before issuing the query to find all configurations so that the runtime cost
+of doing so will be included in elapsedTime.
+(RunsGenerator::fetch_runs): Skip a row when its build and commit times are more than 366 days old.
+(RunsGenerator::format_run): Takes build_time and revisions as arguments since fetch_runs uses them now.
+(RunsGenerator::parse_revisions_array): Compute the max of commit times.
+
+2015-11-20  Ryosuke Niwa  
+
 Remove chartPointRadius from interactive chart component
 https://bugs.webkit.org/show_bug.cgi?id=151480
 


Modified: trunk/Websites/perf.webkit.org/public/api/runs.php (192715 => 192716)

--- trunk/Websites/perf.webkit.org/public/api/runs.php	2015-11-21 03:05:50 UTC (rev 192715)
+++ trunk/Websites/perf.webkit.org/public/api/runs.php	2015-11-21 03:12:14 UTC (rev 192716)
@@ -10,10 +10,19 @@
 if (count($parts) != 2)
 exit_with_error('InvalidRequest');
 
+$test_group_id = array_get($_GET, 'testGroup');
+$should_cache = array_get($_GET, 'cache');
+$should_echo_results = !array_key_exists('noResult', $_GET);
+
 $db = new Database;
 if (!$db->connect())
 exit_with_error('DatabaseConnectionFailure');
 
+if ($test_group_id)
+$generator = new RunsGeneratorForTestGroup($db, $test_group_id);
+else
+$generator = new RunsGenerator($db);
+
 $platform_id = intval($parts[0]);
 $metric_id = intval($parts[1]);
 $config_rows = $db->query_and_fetch_all('SELECT *
@@ -21,8 +30,6 @@
 if (!$config_rows)
 exit_with_error('ConfigurationNotFound');
 
-$test_group_id = array_get($_GET, 'testGroup');
-$should_cache = array_get($_GET, 'cache');
 if ($test_group_id)
 $test_group_id = intval($test_group_id);
 else if ($should_cache) { // Only v1 UI needs caching.
@@ -31,15 +38,15 @@
 header("Cache-Control: maxage=$maxage");
 }
 
-if ($test_group_id)
-$generator = new RunsGeneratorForTestGroup($db, $test_group_id);
-else
-$generator = new RunsGenerator($db);
-
 foreach ($config_rows as $config)
 $generator->fetch_runs($config['config_type'], $config['config_id'], $config['config_runs_last_modified']);
 
 $content = success_json($generator->results());
+if (!$should_echo_results) {
+echo $generator->results()['elapsedTime'];
+return;
+}
+
 if (!$test_group_id)
 generate_data_file("$platform_id-$metric_id.json", $content);
 echo $content;
@@ -63,11 +70,19 @@
 function fetch_runs($name, $config_id, $last_modified) {
 $this->last_modified = max($this->last_modified, Database::to_js_time($last_modified));
 
+$beginning_of_time = intval(time() - 366 * 24 * 3600) * 1000;
+
 $results = $this->execute_query($config_id);
 
 $formatted_runs = array();
-while ($row = $this->db->fetch_next_row($results))
-

[webkit-changes] [192719] trunk/Source/WebInspectorUI

2015-11-20 Thread commit-queue

Title: [192719] trunk/Source/WebInspectorUI








Revision 192719
Author commit-qu...@webkit.org
Date 2015-11-20 19:31:08 -0800 (Fri, 20 Nov 2015)


Log Message
Web Inspector: Timeline does not immediately update current time after switching tabs while recording
https://bugs.webkit.org/show_bug.cgi?id=151528

Patch by Joseph Pecoraro  on 2015-11-20
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.shown):
Provide a number so that _startUpdatingCurrentTime doesn't decide
to wait until the next event to update current time.

(WebInspector.TimelineRecordingContentView.prototype._update):
When switching tabs we stop updating and hit this code. However
we want to keep _lastUpdateTimestamp so that if we switch back
to the tab we can re-compute the current time. So don't clear it
in cases where the view was hidden, as it might need to use
it when it is shown again.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (192718 => 192719)

--- trunk/Source/WebInspectorUI/ChangeLog	2015-11-21 03:29:31 UTC (rev 192718)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-11-21 03:31:08 UTC (rev 192719)
@@ -1,3 +1,22 @@
+2015-11-20  Joseph Pecoraro  
+
+Web Inspector: Timeline does not immediately update current time after switching tabs while recording
+https://bugs.webkit.org/show_bug.cgi?id=151528
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TimelineRecordingContentView.js:
+(WebInspector.TimelineRecordingContentView.prototype.shown):
+Provide a number so that _startUpdatingCurrentTime doesn't decide
+to wait until the next event to update current time.
+
+(WebInspector.TimelineRecordingContentView.prototype._update):
+When switching tabs we stop updating and hit this code. However
+we want to keep _lastUpdateTimestamp so that if we switch back
+to the tab we can re-compute the current time. So don't clear it
+in cases where the view was hidden, as it might need to use
+it when it is shown again.
+
 2015-11-20  Matt Baker  
 
 Web Inspector: Remove "Show only resources with breakpoints" filter button


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (192718 => 192719)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2015-11-21 03:29:31 UTC (rev 192718)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js	2015-11-21 03:31:08 UTC (rev 192719)
@@ -168,7 +168,7 @@
 this._currentContentViewDidChange();
 
 if (!this._updating && WebInspector.timelineManager.activeRecording === this._recording && WebInspector.timelineManager.isCapturing())
-this._startUpdatingCurrentTime();
+this._startUpdatingCurrentTime(this._currentTime);
 }
 
 hidden()
@@ -408,7 +408,8 @@
 // Only stop updating if the current time is greater than the end time, or the end time is NaN.
 // The recording end time will be NaN if no records were added.
 if (!this._updating && (currentTime >= endTime || isNaN(endTime))) {
-this._lastUpdateTimestamp = NaN;
+if (this.visible)
+this._lastUpdateTimestamp = NaN;
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192720] trunk

2015-11-20 Thread beidson

Title: [192720] trunk








Revision 192720
Author beid...@apple.com
Date 2015-11-20 19:57:19 -0800 (Fri, 20 Nov 2015)


Log Message
Modern IDB: After versionchange transactions complete, fire onsuccess on the original IDBOpenDBRequest
https://bugs.webkit.org/show_bug.cgi?id=151522

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/opendatabase-success-after-versionchange.html (And changes to other existing tests)

* Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::startVersionChangeTransaction):
* Modules/indexeddb/client/IDBDatabaseImpl.h:

* Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit):
(WebCore::IDBClient::IDBOpenDBRequest::onUpgradeNeeded):
* Modules/indexeddb/client/IDBOpenDBRequestImpl.h:

* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::create):
(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::dispatchEvent):
* Modules/indexeddb/client/IDBTransactionImpl.h:

LayoutTests:

* storage/indexeddb/modern/deletedatabase-1-expected.txt:
* storage/indexeddb/modern/deletedatabase-1.html:
* storage/indexeddb/modern/deletedatabase-2-expected.txt:
* storage/indexeddb/modern/deletedatabase-2.html:
* storage/indexeddb/modern/opendatabase-success-after-versionchange-expected.txt: Added.
* storage/indexeddb/modern/opendatabase-success-after-versionchange.html: Added.
* storage/indexeddb/modern/opendatabase-versions-expected.txt:
* storage/indexeddb/modern/opendatabase-versions.html:
* storage/indexeddb/modern/versionchange-event-expected.txt:
* storage/indexeddb/modern/versionchange-event.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1.html
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-2.html
trunk/LayoutTests/storage/indexeddb/modern/opendatabase-versions-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/opendatabase-versions.html
trunk/LayoutTests/storage/indexeddb/modern/versionchange-event-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/versionchange-event.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBDatabaseImpl.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h


Added Paths

trunk/LayoutTests/storage/indexeddb/modern/opendatabase-success-after-versionchange-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/opendatabase-success-after-versionchange.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192719 => 192720)

--- trunk/LayoutTests/ChangeLog	2015-11-21 03:31:08 UTC (rev 192719)
+++ trunk/LayoutTests/ChangeLog	2015-11-21 03:57:19 UTC (rev 192720)
@@ -1,3 +1,21 @@
+2015-11-20  Brady Eidson  
+
+Modern IDB: After versionchange transactions complete, fire onsuccess on the original IDBOpenDBRequest
+https://bugs.webkit.org/show_bug.cgi?id=151522
+
+Reviewed by Alex Christensen.
+
+* storage/indexeddb/modern/deletedatabase-1-expected.txt:
+* storage/indexeddb/modern/deletedatabase-1.html:
+* storage/indexeddb/modern/deletedatabase-2-expected.txt:
+* storage/indexeddb/modern/deletedatabase-2.html:
+* storage/indexeddb/modern/opendatabase-success-after-versionchange-expected.txt: Added.
+* storage/indexeddb/modern/opendatabase-success-after-versionchange.html: Added.
+* storage/indexeddb/modern/opendatabase-versions-expected.txt:
+* storage/indexeddb/modern/opendatabase-versions.html:
+* storage/indexeddb/modern/versionchange-event-expected.txt:
+* storage/indexeddb/modern/versionchange-event.html:
+
 2015-11-20  Chris Dumez  
 
 Unreviewed, mark fast/replaced/replaced-breaking.html as failing on ElCapitan-wk1.


Modified: trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt (192719 => 192720)

--- trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt	2015-11-21 03:31:08 UTC (rev 192719)
+++ trunk/LayoutTests/storage/indexeddb/modern/deletedatabase-1-expected.txt	2015-11-21 03:57:19 UTC (rev 192720)
@@ -2,6 +2,7 @@
 Initial upgrade old version - 0 new version - 1
 Version change complete
 Requesting deleteDatabase
+open db success
 First connection received versionchange event: oldVersion 1, newVersion null
 Delete database success: oldVersion 1, newVersion null
 Recreating database to make sure it's new and empty


Modified:

[webkit-changes] [192721] trunk/Source/JavaScriptCore

2015-11-20 Thread akling

Title: [192721] trunk/Source/_javascript_Core








Revision 192721
Author akl...@apple.com
Date 2015-11-20 20:40:40 -0800 (Fri, 20 Nov 2015)


Log Message
GC timers should carry on gracefully when Heap claims it grew from GC.


Reviewed by Mark Lam.

TL;DR the Heap "extra memory" reporting APIs are hard to use 100% correctly
and GC scheduling shouldn't break if someone makes a mistake with it.

The JSC::Heap allows you to report an extra memory cost for any GC object.
This is reported first when allocating the memory, and then each time the
object is visited during the marking phase.

When reporting an allocation, it's added to the Heap's "bytes allocated in
this cycle" counter. This contributes to the computed heap size at the start
of a collection.

When visiting a GC object that reports extra memory, it's added to the Heap's
"extra memory visited in this collection" counter. This contributes to the
computed heap size at the end of a collection.

As you can see, this means that visiting more memory than we said we allocated
can lead to the Heap thinking it's bigger after a collection than it was before.

Clients of this API do some sketchy things to compute costs, for instance
StringImpl cost is determined by dividing the number of bytes used for the
characters, and dividing it by the StringImpl's ref count. Since a JSString
could be backed by any StringImpl, any code that modifies a StringImpl's
ref count during collection will change the extra memory reported by all
JSString objects that wrap that StringImpl.

So anyways...

The object death rate, which is the basis for when to schedule the next
collection is computed like so:

deathRate = (sizeBeforeGC - sizeAfterGC) / sizeBeforeGC

This patch adds a safety mechanism that returns a zero death rate when the Heap
claims it grew from collection.

* heap/EdenGCActivityCallback.cpp:
(JSC::EdenGCActivityCallback::deathRate):
* heap/FullGCActivityCallback.cpp:
(JSC::FullGCActivityCallback::deathRate):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/EdenGCActivityCallback.cpp
trunk/Source/_javascript_Core/heap/FullGCActivityCallback.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (192720 => 192721)

--- trunk/Source/_javascript_Core/ChangeLog	2015-11-21 03:57:19 UTC (rev 192720)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-11-21 04:40:40 UTC (rev 192721)
@@ -1,3 +1,50 @@
+2015-11-20  Andreas Kling  
+
+GC timers should carry on gracefully when Heap claims it grew from GC.
+
+
+Reviewed by Mark Lam.
+
+TL;DR the Heap "extra memory" reporting APIs are hard to use 100% correctly
+and GC scheduling shouldn't break if someone makes a mistake with it.
+
+The JSC::Heap allows you to report an extra memory cost for any GC object.
+This is reported first when allocating the memory, and then each time the
+object is visited during the marking phase.
+
+When reporting an allocation, it's added to the Heap's "bytes allocated in
+this cycle" counter. This contributes to the computed heap size at the start
+of a collection.
+
+When visiting a GC object that reports extra memory, it's added to the Heap's
+"extra memory visited in this collection" counter. This contributes to the
+computed heap size at the end of a collection.
+
+As you can see, this means that visiting more memory than we said we allocated
+can lead to the Heap thinking it's bigger after a collection than it was before.
+
+Clients of this API do some sketchy things to compute costs, for instance
+StringImpl cost is determined by dividing the number of bytes used for the
+characters, and dividing it by the StringImpl's ref count. Since a JSString
+could be backed by any StringImpl, any code that modifies a StringImpl's
+ref count during collection will change the extra memory reported by all
+JSString objects that wrap that StringImpl.
+
+So anyways...
+
+The object death rate, which is the basis for when to schedule the next
+collection is computed like so:
+
+deathRate = (sizeBeforeGC - sizeAfterGC) / sizeBeforeGC
+
+This patch adds a safety mechanism that returns a zero death rate when the Heap
+claims it grew from collection.
+
+* heap/EdenGCActivityCallback.cpp:
+(JSC::EdenGCActivityCallback::deathRate):
+* heap/FullGCActivityCallback.cpp:
+(JSC::FullGCActivityCallback::deathRate):
+
 2015-11-20  Mark Lam  
 
 New JSC tests introduced in r192664 fail on ARM.


Modified: trunk/Source/_javascript_Core/heap/EdenGCActivityCallback.cpp (192720 => 192721)

--- trunk/Source/_javascript_Core/heap/EdenGCActivityCallback.cpp	2015-11-21 03:57:19 UTC (rev 192720)
+++ trunk/Source/_javascript_Core/heap/EdenGCActivityCallback.cpp	2015-11-21

42 matches

Mail list logo