[webkit-changes] [196367] trunk/Source/WebCore

[jer . noble]

Title: [196367] trunk/Source/WebCore








Revision 196367
Author jer.no...@apple.com
Date 2016-02-10 09:23:22 -0800 (Wed, 10 Feb 2016)


Log Message
REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy
https://bugs.webkit.org/show_bug.cgi?id=153727


Reviewed by Darin Adler.

Follow-up after r195965. Only protect those parts of CachedResource::removeClient() which
affect the MemoryCache when allowsCaching() is false.

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (196366 => 196367)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 16:53:49 UTC (rev 196366)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 17:23:22 UTC (rev 196367)
@@ -1,3 +1,17 @@
+2016-02-10  Jer Noble  
+
+REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy
+https://bugs.webkit.org/show_bug.cgi?id=153727
+
+
+Reviewed by Darin Adler.
+
+Follow-up after r195965. Only protect those parts of CachedResource::removeClient() which
+affect the MemoryCache when allowsCaching() is false.
+
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::removeClient):
+
 2016-02-10  Csaba Osztrogonác  
 
 Fix the !(ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT)) after r196281


Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (196366 => 196367)

--- trunk/Source/WebCore/loader/cache/CachedResource.cpp	2016-02-10 16:53:49 UTC (rev 196366)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp	2016-02-10 17:23:22 UTC (rev 196367)
@@ -487,17 +487,21 @@
 return;
 }
 
-if (!allowsCaching() || hasClients())
+if (hasClients())
 return;
 
 auto& memoryCache = MemoryCache::singleton();
-if (inCache()) {
+if (allowsCaching() && inCache()) {
 memoryCache.removeFromLiveResourcesSize(*this);
 memoryCache.removeFromLiveDecodedResourcesList(*this);
 }
 if (!m_switchingClientsToRevalidatedResource)
 allClientsRemoved();
 destroyDecodedDataIfNeeded();
+
+if (!allowsCaching())
+return;
+
 if (response().cacheControlContainsNoStore() && url().protocolIs("https")) {
 // RFC2616 14.9.2:
 // "no-store: ... MUST make a best-effort attempt to remove the information from volatile storage as promptly as possible"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196366] branches/safari-601-branch/Source/JavaScriptCore

[bshafiei]

Title: [196366] branches/safari-601-branch/Source/_javascript_Core








Revision 196366
Author bshaf...@apple.com
Date 2016-02-10 08:53:49 -0800 (Wed, 10 Feb 2016)


Log Message
Merged r196179.  rdar://problem/24574519

Modified Paths

branches/safari-601-branch/Source/_javascript_Core/ChangeLog
branches/safari-601-branch/Source/_javascript_Core/runtime/JSArrayBufferView.cpp
branches/safari-601-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h
branches/safari-601-branch/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h
branches/safari-601-branch/Source/_javascript_Core/runtime/JSObject.cpp
branches/safari-601-branch/Source/_javascript_Core/runtime/Structure.h


Added Paths

branches/safari-601-branch/Source/_javascript_Core/tests/stress/arrayify-array-storage-typed-array.js
branches/safari-601-branch/Source/_javascript_Core/tests/stress/arrayify-int32-typed-array.js




Diff

Modified: branches/safari-601-branch/Source/_javascript_Core/ChangeLog (196365 => 196366)

--- branches/safari-601-branch/Source/_javascript_Core/ChangeLog	2016-02-10 10:28:23 UTC (rev 196365)
+++ branches/safari-601-branch/Source/_javascript_Core/ChangeLog	2016-02-10 16:53:49 UTC (rev 196366)
@@ -1,3 +1,37 @@
+2016-02-10  Babak Shafiei  
+
+Merge r196179.
+
+2016-02-05  Filip Pizlo  
+
+Arrayify for a typed array shouldn't create a monster
+https://bugs.webkit.org/show_bug.cgi?id=153908
+rdar://problem/24290639
+
+Reviewed by Mark Lam.
+
+Previously if you convinced the DFG to emit an Arrayify to ArrayStorage and then gave it a
+typed array, you'd corrupt the object.
+
+* runtime/JSArrayBufferView.cpp:
+(WTF::printInternal):
+* runtime/JSArrayBufferView.h:
+* runtime/JSGenericTypedArrayViewInlines.h:
+(JSC::JSGenericTypedArrayView::visitChildren):
+(JSC::JSGenericTypedArrayView::slowDownAndWasteMemory):
+* runtime/JSObject.cpp:
+(JSC::JSObject::copyButterfly):
+(JSC::JSObject::enterDictionaryIndexingMode):
+(JSC::JSObject::ensureInt32Slow):
+(JSC::JSObject::ensureDoubleSlow):
+(JSC::JSObject::ensureContiguousSlow):
+(JSC::JSObject::ensureArrayStorageSlow):
+(JSC::JSObject::growOutOfLineStorage):
+(JSC::getBoundSlotBaseFunctionForGetterSetter):
+* runtime/Structure.h:
+* tests/stress/arrayify-array-storage-typed-array.js: Added. This test failed.
+* tests/stress/arrayify-int32-typed-array.js: Added. This test case already had other protections, but we beefed them up.
+
 2016-01-29  Babak Shafiei  
 
 Merge r194479.


Modified: branches/safari-601-branch/Source/_javascript_Core/runtime/JSArrayBufferView.cpp (196365 => 196366)

--- branches/safari-601-branch/Source/_javascript_Core/runtime/JSArrayBufferView.cpp	2016-02-10 10:28:23 UTC (rev 196365)
+++ branches/safari-601-branch/Source/_javascript_Core/runtime/JSArrayBufferView.cpp	2016-02-10 16:53:49 UTC (rev 196366)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2016 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -220,3 +220,28 @@
 
 } // namespace JSC
 
+namespace WTF {
+
+using namespace JSC;
+
+void printInternal(PrintStream& out, TypedArrayMode mode)
+{
+switch (mode) {
+case FastTypedArray:
+out.print("FastTypedArray");
+return;
+case OversizeTypedArray:
+out.print("OversizeTypedArray");
+return;
+case WastefulTypedArray:
+out.print("WastefulTypedArray");
+return;
+case DataViewMode:
+out.print("DataViewMode");
+return;
+}
+RELEASE_ASSERT_NOT_REACHED();
+}
+
+} // namespace WTF
+


Modified: branches/safari-601-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h (196365 => 196366)

--- branches/safari-601-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h	2016-02-10 10:28:23 UTC (rev 196365)
+++ branches/safari-601-branch/Source/_javascript_Core/runtime/JSArrayBufferView.h	2016-02-10 16:53:49 UTC (rev 196366)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013, 2016 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -184,5 +184,11 @@
 
 } // namespace JSC
 
+namespace WTF {
+
+void printInternal(PrintStream&, JSC::TypedArrayMode);
+
+} // namespace WTF
+
 #endif // JSArrayBufferView_h
 


Modified: branches/safari-601-branch/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h (196365 => 196366)

--- 

[webkit-changes] [196373] trunk/Source/WebCore

[beidson]

Title: [196373] trunk/Source/WebCore








Revision 196373
Author beid...@apple.com
Date 2016-02-10 11:27:58 -0800 (Wed, 10 Feb 2016)


Log Message
Modern IDB: Ref cycle between IDBObjectStore and IDBTransaction.
https://bugs.webkit.org/show_bug.cgi?id=154061

Reviewed by Alex Christensen.

No new tests (Currently untestable).

* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::transitionedToFinishing): Make sure the new state makes sense,
  set the new state, and then clear the set of referenced object stores which is no longer needed.
(WebCore::IDBClient::IDBTransaction::abort):
(WebCore::IDBClient::IDBTransaction::commit):
* Modules/indexeddb/client/IDBTransactionImpl.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (196372 => 196373)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 19:22:08 UTC (rev 196372)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 19:27:58 UTC (rev 196373)
@@ -1,3 +1,19 @@
+2016-02-10  Brady Eidson  
+
+Modern IDB: Ref cycle between IDBObjectStore and IDBTransaction.
+https://bugs.webkit.org/show_bug.cgi?id=154061
+
+Reviewed by Alex Christensen.
+
+No new tests (Currently untestable).
+
+* Modules/indexeddb/client/IDBTransactionImpl.cpp:
+(WebCore::IDBClient::IDBTransaction::transitionedToFinishing): Make sure the new state makes sense,
+  set the new state, and then clear the set of referenced object stores which is no longer needed.
+(WebCore::IDBClient::IDBTransaction::abort):
+(WebCore::IDBClient::IDBTransaction::commit):
+* Modules/indexeddb/client/IDBTransactionImpl.h:
+
 2016-02-10  Jer Noble  
 
 REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy


Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp (196372 => 196373)

--- trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp	2016-02-10 19:22:08 UTC (rev 196372)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp	2016-02-10 19:27:58 UTC (rev 196373)
@@ -177,6 +177,13 @@
 abort(ec);
 }
 
+void IDBTransaction::transitionedToFinishing(IndexedDB::TransactionState state)
+{
+ASSERT(!isFinishedOrFinishing());
+m_state = state;
+m_referencedObjectStores.clear();
+}
+
 void IDBTransaction::abort(ExceptionCodeWithMessage& ec)
 {
 LOG(IndexedDB, "IDBTransaction::abort");
@@ -187,13 +194,14 @@
 return;
 }
 
-m_state = IndexedDB::TransactionState::Aborting;
 m_database->willAbortTransaction(*this);
 
 if (isVersionChange()) {
 for (auto& objectStore : m_referencedObjectStores.values())
 objectStore->rollbackInfoForVersionChangeAbort();
 }
+
+transitionedToFinishing(IndexedDB::TransactionState::Aborting);
 
 m_abortQueue.swap(m_transactionOperationQueue);
 
@@ -319,7 +327,7 @@
 
 ASSERT(!isFinishedOrFinishing());
 
-m_state = IndexedDB::TransactionState::Committing;
+transitionedToFinishing(IndexedDB::TransactionState::Committing);
 m_database->willCommitTransaction(*this);
 
 auto operation = createTransactionOperation(*this, nullptr, ::commitOnServer);


Modified: trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h (196372 => 196373)

--- trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h	2016-02-10 19:22:08 UTC (rev 196372)
+++ trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.h	2016-02-10 19:27:58 UTC (rev 196373)
@@ -183,6 +183,8 @@
 void iterateCursorOnServer(TransactionOperation&, const IDBKeyData&, const unsigned long& count);
 void didIterateCursorOnServer(IDBRequest&, const IDBResultData&);
 
+void transitionedToFinishing(IndexedDB::TransactionState);
+
 void establishOnServer();
 
 void scheduleOperationTimer();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196374] trunk

[cdumez]

Title: [196374] trunk








Revision 196374
Author cdu...@apple.com
Date 2016-02-10 11:47:10 -0800 (Wed, 10 Feb 2016)


Log Message
Attributes on the Window instance should be configurable unless [Unforgeable]
https://bugs.webkit.org/show_bug.cgi?id=153920


Reviewed by Darin Adler.

Source/_javascript_Core:

Marking the Window instance attributes as configurable but cause
getOwnPropertyDescriptor() to report them as configurable, as
expected. However, trying to delete them would actually lead to
unexpected behavior because:
- We did not reify custom accessor properties (most of the Window
  properties are custom accessors) upon deletion.
- For non-reified static properties marked as configurable,
  JSObject::deleteProperty() would attempt to call the property
  setter with undefined. As a result, calling delete window.name
  would cause window.name to become the string "undefined" instead
  of the undefined value.

* runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
Now that we reify ALL properties, we only need to check the property table
if we have not reified. As a result, I dropped the 'didReify' parameter for
this function and instead only call this function if we have not yet reified.

(JSC::JSObject::putInlineSlow):
Only call putEntry() if we have not reified: Drop the
'|| !(entry->attributes() & BuiltinOrFunctionOrAccessor)'
check as such properties now get reified as well.

(JSC::JSObject::deleteProperty):
- Call reifyAllStaticProperties() instead of reifyStaticFunctionsForDelete()
  so that we now reify all properties upon deletion, including the custom
  accessors. reifyStaticFunctionsForDelete() is now removed and the same
  reification function is now used by: deletion, getOwnPropertyDescriptor()
  and eager reification of the prototype objects in the bindings.
- Drop code that falls back to calling the static property setter with
  undefined if we cannot find the property in the property storage. As
  we now reify ALL properties, the code removing the property from the
  property storage should succeed, provided that the property actually
  exists.

(JSC::JSObject::getOwnNonIndexPropertyNames):
Only call getClassPropertyNames() if we have not reified. We should no longer
check the static property table after reifying now that we reify all
properties.

(JSC::JSObject::reifyAllStaticProperties):
Merge with reifyStaticFunctionsForDelete(). The only behavior change is the
flattening to an uncacheable dictionary, like reifyStaticFunctionsForDelete()
used to do.

* runtime/JSObject.h:

Source/WebCore:

Attributes on the Window instance should be configurable unless [Unforgeable]:
1. 'constructor' property:
   - http://www.w3.org/TR/WebIDL/#interface-prototype-object
2. Constructor properties (e.g. window.Node):
   - http://www.w3.org/TR/WebIDL/#es-interfaces
3. IDL attributes:
   - http://heycam.github.io/webidl/#es-attributes (configurable unless
 [Unforgeable], e.g. window.location)

Firefox complies with the WebIDL specification but WebKit does not for 1. and 3.

Test: fast/dom/Window/window-properties-configurable.html

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
For known Window properties (i.e. properties in the static property table),
if we have reified and this is same-origin access, then call
Base::getOwnPropertySlot() to get the property from the local property
storage. If we have not reified yet, or this is cross-origin access, query
the static property table. This is to match the behavior of Firefox and
Chrome which seem to keep returning the original properties upon cross
origin access, even if those were deleted or redefined.

(WebCore::JSDOMWindow::put):
The previous code used to call the static property setter for properties in
the static table. However, this does not do the right thing if properties
were reified. For example, deleting window.name and then trying to set it
again would not work. Therefore, update this code to only do this if the
properties have not been reified, similarly to what is done in
JSObject::putInlineSlow().

* bindings/scripts/CodeGeneratorJS.pm:
(ConstructorShouldBeOnInstance):
Add a FIXME comment indicating that window.constructor should be on
the prototype as per the Web IDL specification.

(GenerateAttributesHashTable):
- Mark 'constructor' property as configurable for Window, as per the
  specification and consistently with other 'constructor' properties:
  http://www.w3.org/TR/WebIDL/#interface-prototype-object
- Mark properties as configurable even though they are on the instance.
  Window has its properties on the instance as per the specification:
  1. http://heycam.github.io/webidl/#es-attributes
  2. http://heycam.github.io/webidl/#PrimaryGlobal (window is [PrimaryGlobal]
  However, these properties should be configurable as long as they are
  not marked as [Unforgeable], as per 1.

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
* bindings/scripts/test/JS/JSTestException.cpp:
* 

[webkit-changes] [196370] trunk/Source/WebKit2

[mitz]

Title: [196370] trunk/Source/WebKit2








Revision 196370
Author m...@apple.com
Date 2016-02-10 10:20:12 -0800 (Wed, 10 Feb 2016)


Log Message
[Mac] Stop installing the legacy processes
https://bugs.webkit.org/show_bug.cgi?id=154062

Reviewed by Anders Carlsson.

* Configurations/All.xcconfig: Removed the legacy processes from EXCLUDED_SOURCE_FILE_NAMES
  for iOS, now that they are no longer included in a Copy Files build phase.
* Configurations/BaseLegacyProcess.xcconfig: Set SKIP_INSTALL to YES for OS X as well.
* WebKit2.xcodeproj/project.pbxproj: Removed the Copy Files build phase that copied the
  processes into the framework in engineering builds. Renamed the “Add current version
  symlinks” script build phase to “Add XPCServices symlink”, and changed it to do just that.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/All.xcconfig
trunk/Source/WebKit2/Configurations/BaseLegacyProcess.xcconfig
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196369 => 196370)

--- trunk/Source/WebKit2/ChangeLog	2016-02-10 18:13:24 UTC (rev 196369)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-10 18:20:12 UTC (rev 196370)
@@ -1,3 +1,17 @@
+2016-02-10  Dan Bernstein  
+
+[Mac] Stop installing the legacy processes
+https://bugs.webkit.org/show_bug.cgi?id=154062
+
+Reviewed by Anders Carlsson.
+
+* Configurations/All.xcconfig: Removed the legacy processes from EXCLUDED_SOURCE_FILE_NAMES
+  for iOS, now that they are no longer included in a Copy Files build phase.
+* Configurations/BaseLegacyProcess.xcconfig: Set SKIP_INSTALL to YES for OS X as well.
+* WebKit2.xcodeproj/project.pbxproj: Removed the Copy Files build phase that copied the
+  processes into the framework in engineering builds. Renamed the “Add current version
+  symlinks” script build phase to “Add XPCServices symlink”, and changed it to do just that.
+
 2016-02-09  Carlos Garcia Campos  
 
 REGRESSION(r196183): [GTK] Broke TestInspector


Modified: trunk/Source/WebKit2/Configurations/All.xcconfig (196369 => 196370)

--- trunk/Source/WebKit2/Configurations/All.xcconfig	2016-02-10 18:13:24 UTC (rev 196369)
+++ trunk/Source/WebKit2/Configurations/All.xcconfig	2016-02-10 18:20:12 UTC (rev 196370)
@@ -25,6 +25,4 @@
 
 #include "BaseTarget.xcconfig"
 
-EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = DatabaseProcess.app NetworkProcess.app PluginProcess.app WebProcess.app;
-
 SKIP_INSTALL = YES;


Modified: trunk/Source/WebKit2/Configurations/BaseLegacyProcess.xcconfig (196369 => 196370)

--- trunk/Source/WebKit2/Configurations/BaseLegacyProcess.xcconfig	2016-02-10 18:13:24 UTC (rev 196369)
+++ trunk/Source/WebKit2/Configurations/BaseLegacyProcess.xcconfig	2016-02-10 18:20:12 UTC (rev 196370)
@@ -35,4 +35,4 @@
 
 EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(CONFIGURATION)) *.xib;
 
-SKIP_INSTALL[sdk=iphone*] = YES;
+SKIP_INSTALL = YES;


Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (196369 => 196370)

--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2016-02-10 18:13:24 UTC (rev 196369)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2016-02-10 18:20:12 UTC (rev 196370)
@@ -11,8 +11,7 @@
 			isa = PBXAggregateTarget;
 			buildConfigurationList = 1A50DB48110A3C27000D3FE5 /* Build configuration list for PBXAggregateTarget "All" */;
 			buildPhases = (
-1A50DB70110A3D67000D3FE5 /* Copy Files */,
-BCFFCA8A160D6DEA003DF315 /* Add current version symlinks */,
+BCFFCA8A160D6DEA003DF315 /* Add XPCServices symlink */,
 BCFFCA8B160D6E7B003DF315 /* Copy XPC services for engineering builds */,
 			);
 			dependencies = (
@@ -255,7 +254,6 @@
 		1A4D664818A2D91A00D82E21 /* APIUIClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A4D664718A2D91A00D82E21 /* APIUIClient.h */; };
 		1A4D664B18A3030E00D82E21 /* WKFrameInfo.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A4D664918A3030E00D82E21 /* WKFrameInfo.mm */; };
 		1A4D664C18A3030E00D82E21 /* WKFrameInfo.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A4D664A18A3030E00D82E21 /* WKFrameInfo.h */; settings = {ATTRIBUTES = (Public, ); }; };
-		1A50DB66110A3D57000D3FE5 /* WebProcess.app in Copy Files */ = {isa = PBXBuildFile; fileRef = 1A50DB1E110A3BDC000D3FE5 /* WebProcess.app */; };
 		1A52C0F71A38CDC70016160A /* WebStorageNamespaceProvider.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A52C0F51A38CDC70016160A /* WebStorageNamespaceProvider.cpp */; };
 		1A52C0F81A38CDC70016160A /* WebStorageNamespaceProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A52C0F61A38CDC70016160A /* WebStorageNamespaceProvider.h */; };
 		1A53C2A21A323004004E8C70 /* InjectedBundleCSSStyleDeclarationHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7C4ED3261A3119D90079BD49 /* InjectedBundleCSSStyleDeclarationHandle.cpp */; };
@@ -868,7 

[webkit-changes] [196371] trunk/LayoutTests

[ryanhaddad]

Title: [196371] trunk/LayoutTests








Revision 196371
Author ryanhad...@apple.com
Date 2016-02-10 11:22:07 -0800 (Wed, 10 Feb 2016)


Log Message
Skop fast/regions/text-break-properties.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153762

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (196370 => 196371)

--- trunk/LayoutTests/ChangeLog	2016-02-10 18:20:12 UTC (rev 196370)
+++ trunk/LayoutTests/ChangeLog	2016-02-10 19:22:07 UTC (rev 196371)
@@ -1,3 +1,12 @@
+2016-02-10  Ryan Haddad  
+
+Skop fast/regions/text-break-properties.html on ios-simulator
+https://bugs.webkit.org/show_bug.cgi?id=153762
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/TestExpectations:
+
 2016-02-09  Nan Wang  
 
 AX: Implement word related text marker functions using TextIterator


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (196370 => 196371)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-02-10 18:20:12 UTC (rev 196370)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-02-10 19:22:07 UTC (rev 196371)
@@ -2940,3 +2940,5 @@
 webkit.org/b/153933 css3/filters/multiple-filters-invalidation.html [ Pass Crash ]
 
 webkit.org/b/154055 perf/adding-radio-buttons.html [ Pass Failure ]
+
+webkit.org/b/153762 fast/regions/text-break-properties.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196369] trunk/Source/JavaScriptCore

[commit-queue]

Title: [196369] trunk/Source/_javascript_Core








Revision 196369
Author commit-qu...@webkit.org
Date 2016-02-10 10:13:24 -0800 (Wed, 10 Feb 2016)


Log Message
Unreviewed, rolling out r196251.
https://bugs.webkit.org/show_bug.cgi?id=154078

Large regression on Dromaeo needs explanation (Requested by
kling on #webkit).

Reverted changeset:

"Visiting a WeakBlock should report bytes visited, since we
reported them allocated."
https://bugs.webkit.org/show_bug.cgi?id=153978
http://trac.webkit.org/changeset/196251

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/SlotVisitor.h
trunk/Source/_javascript_Core/heap/WeakBlock.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (196368 => 196369)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-10 17:50:07 UTC (rev 196368)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-10 18:13:24 UTC (rev 196369)
@@ -1,3 +1,18 @@
+2016-02-10  Commit Queue  
+
+Unreviewed, rolling out r196251.
+https://bugs.webkit.org/show_bug.cgi?id=154078
+
+Large regression on Dromaeo needs explanation (Requested by
+kling on #webkit).
+
+Reverted changeset:
+
+"Visiting a WeakBlock should report bytes visited, since we
+reported them allocated."
+https://bugs.webkit.org/show_bug.cgi?id=153978
+http://trac.webkit.org/changeset/196251
+
 2016-02-10  Csaba Osztrogonác  
 
 REGRESSION(r196331): It made ~180 JSC tests crash on ARMv7 Linux


Modified: trunk/Source/_javascript_Core/heap/SlotVisitor.h (196368 => 196369)

--- trunk/Source/_javascript_Core/heap/SlotVisitor.h	2016-02-10 17:50:07 UTC (rev 196368)
+++ trunk/Source/_javascript_Core/heap/SlotVisitor.h	2016-02-10 18:13:24 UTC (rev 196369)
@@ -105,7 +105,6 @@
 void copyLater(JSCell*, CopyToken, void*, size_t);
 
 void reportExtraMemoryVisited(size_t);
-void reportMemoryVisited(size_t bytes) { m_bytesVisited += bytes; }
 
 void addWeakReferenceHarvester(WeakReferenceHarvester*);
 void addUnconditionalFinalizer(UnconditionalFinalizer*);


Modified: trunk/Source/_javascript_Core/heap/WeakBlock.cpp (196368 => 196369)

--- trunk/Source/_javascript_Core/heap/WeakBlock.cpp	2016-02-10 17:50:07 UTC (rev 196368)
+++ trunk/Source/_javascript_Core/heap/WeakBlock.cpp	2016-02-10 18:13:24 UTC (rev 196369)
@@ -109,8 +109,6 @@
 
 SlotVisitor& visitor = heapRootVisitor.visitor();
 
-visitor.reportMemoryVisited(WeakBlock::blockSize);
-
 for (size_t i = 0; i < weakImplCount(); ++i) {
 WeakImpl* weakImpl = ()[i];
 if (weakImpl->state() != WeakImpl::Live)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196383] trunk/Source/WebCore

[antti]

Title: [196383] trunk/Source/WebCore








Revision 196383
Author an...@apple.com
Date 2016-02-10 12:47:04 -0800 (Wed, 10 Feb 2016)


Log Message
Optimize style invalidation after class attribute change
https://bugs.webkit.org/show_bug.cgi?id=154075
rdar://problem/12526450

Reviewed by Andreas Kling.

Currently a class attribute change invalidates style for the entire element subtree for any class found in the
active stylesheet set.

This patch optimizes class changes by building a new optimization structure called ancestorClassRules. It contains
rules that have class selectors in the portion of the complex selector that matches ancestor elements. The sets
of rules are hashes by the class name.

On class attribute change the existing StyleInvalidationAnalysis mechanism is used with ancestorClassRules to invalidate
exactly those descendants that are affected by the addition or removal of the class name. This is fast because the CSS JIT
makes selector matching cheap and the number of relevant rules is typically small.

This optimization is very effective on many dynamic pages. For example when focusing and unfocusing the web inspector it
cuts down the number of resolved elements from ~1000 to ~50. Even in PLT it reduces the number of resolved elements by ~11%.

* css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::collectFeatures):
(WebCore::DocumentRuleSets::ancestorClassRules):

Create optimization RuleSets on-demand when there is an actual dynamic class change.

* css/DocumentRuleSets.h:
(WebCore::DocumentRuleSets::features):
(WebCore::DocumentRuleSets::sibling):
(WebCore::DocumentRuleSets::uncommonAttribute):
* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ElementRuleCollector):

Add a new constructor that doesn't requires DocumentRuleSets. Only the user and author style is required.

(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
* css/ElementRuleCollector.h:
* css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):

Collect class names that show up in the ancestor portion of the selector.
Make this a member.

(WebCore::RuleFeatureSet::collectFeatures):

Move this code from RuleData.
Add the rule to ancestorClassRules if needed.

(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
(WebCore::RuleFeatureSet::shrinkToFit):
(WebCore::recursivelyCollectFeaturesFromSelector): Deleted.
(WebCore::RuleFeatureSet::collectFeaturesFromSelector): Deleted.
* css/RuleFeature.h:
(WebCore::RuleFeature::RuleFeature):
(WebCore::RuleFeatureSet::RuleFeatureSet): Deleted.
* css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::collectFeaturesFromRuleData): Deleted.
* css/RuleSet.h:
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::RuleSet): Deleted.
* css/StyleInvalidationAnalysis.cpp:
(WebCore::shouldDirtyAllStyle):
(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):

Add a new constructor that takes a ready made RuleSet instead of a stylesheet.

(WebCore::StyleInvalidationAnalysis::invalidateIfNeeded):
(WebCore::StyleInvalidationAnalysis::invalidateStyleForTree):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):

New function for invalidating a subtree instead of the whole document.

* css/StyleInvalidationAnalysis.h:
(WebCore::StyleInvalidationAnalysis::dirtiesAllStyle):
(WebCore::StyleInvalidationAnalysis::hasShadowPseudoElementRulesInAuthorSheet):
* dom/Element.cpp:
(WebCore::classStringHasClassName):
(WebCore::collectClasses):
(WebCore::computeClassChange):

Factor to return the changed classes.

(WebCore::invalidateStyleForClassChange):

First filter out classes that don't show up in stylesheets. If something remains invalidate the current
element for inline style change (that is a style change that doesn't affect descendants).

Next check if there are any ancestorClassRules for the changed class. If so use the StyleInvalidationAnalysis
to find any affected descendants and invalidate them with inline style change as well.

(WebCore::Element::classAttributeChanged):

Invalidate for removed classes before setting new attribute value, invalidate for added classes afterwards.

(WebCore::Element::absoluteLinkURL):
(WebCore::checkSelectorForClassChange): Deleted.
* dom/ElementData.h:
(WebCore::ElementData::setClassNames):
(WebCore::ElementData::classNames):
(WebCore::ElementData::classNamesMemoryOffset):
(WebCore::ElementData::clearClass): Deleted.
(WebCore::ElementData::setClass): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/DocumentRuleSets.cpp
trunk/Source/WebCore/css/DocumentRuleSets.h
trunk/Source/WebCore/css/ElementRuleCollector.cpp

[webkit-changes] [196384] trunk/Source/WebKit2

[achristensen]

Title: [196384] trunk/Source/WebKit2








Revision 196384
Author achristen...@apple.com
Date 2016-02-10 12:56:11 -0800 (Wed, 10 Feb 2016)


Log Message
Fix assertions when loading from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=154079

Reviewed by Anders Carlsson.

Assertions were failing, mostly when using NetworkProcess, and mostly involving Top Sites.
When we do loading from the WebProcess (which we should eventually not allow), we were sometimes
using a private browsing session that did not exist because the UIProcess had told the NetworkProcess
to create a private browsing session with the given SessionID, but the WebProcess was not told about
the private browsing session.
Also, sometimes we were calling NetworkProcess::singleton() from the WebProcess, which caused problems
with the PlatformStrategies object being reset.  This prevents that, too.

* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
Added an assertion that we have a network session when we have just made a NetworkingContext with the given SessionID.
* NetworkProcess/NetworkSession.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
Call NetworkProcess::singleton only when we know we are in the network process.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
Tell the WebProcesses about the new private session, too.  Sometimes they use the new private session.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
Removed useless macros that were always true for all WK2 clients.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkSession.h
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm
trunk/Source/WebKit2/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196383 => 196384)

--- trunk/Source/WebKit2/ChangeLog	2016-02-10 20:47:04 UTC (rev 196383)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-10 20:56:11 UTC (rev 196384)
@@ -1,3 +1,38 @@
+2016-02-10  Alex Christensen  
+
+Fix assertions when loading from WebProcess
+https://bugs.webkit.org/show_bug.cgi?id=154079
+
+Reviewed by Anders Carlsson.
+
+Assertions were failing, mostly when using NetworkProcess, and mostly involving Top Sites.
+When we do loading from the WebProcess (which we should eventually not allow), we were sometimes
+using a private browsing session that did not exist because the UIProcess had told the NetworkProcess
+to create a private browsing session with the given SessionID, but the WebProcess was not told about
+the private browsing session.
+Also, sometimes we were calling NetworkProcess::singleton() from the WebProcess, which caused problems
+with the PlatformStrategies object being reset.  This prevents that, too.
+
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::NetworkLoad):
+Added an assertion that we have a network session when we have just made a NetworkingContext with the given SessionID.
+* NetworkProcess/NetworkSession.h:
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSession::defaultSession):
+(WebKit::NetworkSession::NetworkSession):
+* NetworkProcess/mac/RemoteNetworkingContext.mm:
+(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
+Call NetworkProcess::singleton only when we know we are in the network process.
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::WebPageProxy):
+* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
+(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
+Tell the WebProcesses about the new private session, too.  Sometimes they use the new private session.
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::ensurePrivateBrowsingSession):
+(WebKit::WebProcess::destroyPrivateBrowsingSession):
+Removed useless macros that were always true for all WK2 clients.
+
 2016-02-10  Dan Bernstein  
 
 [Mac] Stop installing the legacy processes


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp (196383 => 196384)

--- trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp	2016-02-10 20:47:04 UTC (rev 196383)
+++ 

[webkit-changes] [196388] trunk/Source/WebCore

[mmaxfield]

Title: [196388] trunk/Source/WebCore








Revision 196388
Author mmaxfi...@apple.com
Date 2016-02-10 13:07:59 -0800 (Wed, 10 Feb 2016)


Log Message
CSSSegmentedFontFace does not need to be reference counted
https://bugs.webkit.org/show_bug.cgi?id=154083

Reviewed by Antti Koivisto.

...There is only ever a single reference to one.

No new tests because there is no behavior change.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
* css/CSSFontSelector.h:
* css/CSSSegmentedFontFace.h:
(WebCore::CSSSegmentedFontFace::create): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontSelector.cpp
trunk/Source/WebCore/css/CSSFontSelector.h
trunk/Source/WebCore/css/CSSSegmentedFontFace.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (196387 => 196388)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 21:07:52 UTC (rev 196387)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 21:07:59 UTC (rev 196388)
@@ -1,3 +1,20 @@
+2016-02-10  Myles C. Maxfield  
+
+CSSSegmentedFontFace does not need to be reference counted
+https://bugs.webkit.org/show_bug.cgi?id=154083
+
+Reviewed by Antti Koivisto.
+
+...There is only ever a single reference to one.
+
+No new tests because there is no behavior change.
+
+* css/CSSFontSelector.cpp:
+(WebCore::CSSFontSelector::getFontFace):
+* css/CSSFontSelector.h:
+* css/CSSSegmentedFontFace.h:
+(WebCore::CSSSegmentedFontFace::create): Deleted.
+
 2016-02-10  Antti Koivisto  
 
 Optimize style invalidation after class attribute change


Modified: trunk/Source/WebCore/css/CSSFontSelector.cpp (196387 => 196388)

--- trunk/Source/WebCore/css/CSSFontSelector.cpp	2016-02-10 21:07:52 UTC (rev 196387)
+++ trunk/Source/WebCore/css/CSSFontSelector.cpp	2016-02-10 21:07:59 UTC (rev 196388)
@@ -465,15 +465,15 @@
 return nullptr;
 auto& familyFontFaces = iterator->value;
 
-auto& segmentedFontFaceCache = m_fonts.add(family, HashMap()).iterator->value;
+auto& segmentedFontFaceCache = m_fonts.add(family, HashMap()).iterator->value;
 
 FontTraitsMask traitsMask = fontDescription.traitsMask();
 
-RefPtr& face = segmentedFontFaceCache.add(traitsMask, nullptr).iterator->value;
+std::unique_ptr& face = segmentedFontFaceCache.add(traitsMask, nullptr).iterator->value;
 if (face)
 return face.get();
 
-face = CSSSegmentedFontFace::create(*this);
+face = std::make_unique(*this);
 
 Vector candidateFontFaces;
 for (int i = familyFontFaces.size() - 1; i >= 0; --i) {


Modified: trunk/Source/WebCore/css/CSSFontSelector.h (196387 => 196388)

--- trunk/Source/WebCore/css/CSSFontSelector.h	2016-02-10 21:07:52 UTC (rev 196387)
+++ trunk/Source/WebCore/css/CSSFontSelector.h	2016-02-10 21:07:59 UTC (rev 196388)
@@ -88,7 +88,7 @@
 Document* m_document;
 HashMap, ASCIICaseInsensitiveHash> m_fontFaces;
 HashMap, ASCIICaseInsensitiveHash> m_locallyInstalledFontFaces;
-HashMap, ASCIICaseInsensitiveHash> m_fonts;
+HashMap, ASCIICaseInsensitiveHash> m_fonts;
 HashSet m_clients;
 
 Vector m_fontsToBeginLoading;


Modified: trunk/Source/WebCore/css/CSSSegmentedFontFace.h (196387 => 196388)

--- trunk/Source/WebCore/css/CSSSegmentedFontFace.h	2016-02-10 21:07:52 UTC (rev 196387)
+++ trunk/Source/WebCore/css/CSSSegmentedFontFace.h	2016-02-10 21:07:59 UTC (rev 196388)
@@ -39,9 +39,10 @@
 class CSSFontSelector;
 class FontDescription;
 
-class CSSSegmentedFontFace : public RefCounted {
+class CSSSegmentedFontFace {
+WTF_MAKE_FAST_ALLOCATED;
 public:
-static Ref create(CSSFontSelector& selector) { return adoptRef(*new CSSSegmentedFontFace(selector)); }
+CSSSegmentedFontFace(CSSFontSelector&);
 ~CSSSegmentedFontFace();
 
 CSSFontSelector& fontSelector() const { return m_fontSelector; }
@@ -53,7 +54,6 @@
 FontRanges fontRanges(const FontDescription&);
 
 private:
-CSSSegmentedFontFace(CSSFontSelector&);
 
 CSSFontSelector& m_fontSelector;
 HashMap m_cache;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196376] trunk/Source/WebCore

[mmaxfield]

Title: [196376] trunk/Source/WebCore








Revision 196376
Author mmaxfi...@apple.com
Date 2016-02-10 11:54:38 -0800 (Wed, 10 Feb 2016)


Log Message
Addressing post-review comments after r196322

Unreviwed.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
* css/CSSFontFaceSource.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSource.cpp
trunk/Source/WebCore/css/CSSFontFaceSource.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (196375 => 196376)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 19:53:54 UTC (rev 196375)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 19:54:38 UTC (rev 196376)
@@ -1,3 +1,13 @@
+2016-02-10  Myles C. Maxfield  
+
+Addressing post-review comments after r196322
+
+Unreviwed.
+
+* css/CSSFontFaceSource.cpp:
+(WebCore::CSSFontFaceSource::font):
+* css/CSSFontFaceSource.h:
+
 2016-02-10  Chris Dumez  
 
 Attributes on the Window instance should be configurable unless [Unforgeable]


Modified: trunk/Source/WebCore/css/CSSFontFaceSource.cpp (196375 => 196376)

--- trunk/Source/WebCore/css/CSSFontFaceSource.cpp	2016-02-10 19:53:54 UTC (rev 196375)
+++ trunk/Source/WebCore/css/CSSFontFaceSource.cpp	2016-02-10 19:54:38 UTC (rev 196376)
@@ -147,7 +147,7 @@
 
 #if ENABLE(SVG_FONTS)
 #if ENABLE(SVG_OTF_CONVERTER)
-if (!m_svgFontFaceElement->parentNode() || !is(m_svgFontFaceElement->parentNode()))
+if (!is(m_svgFontFaceElement->parentNode()))
 return nullptr;
 SVGFontElement& fontElement = downcast(*m_svgFontFaceElement->parentNode());
 // FIXME: Re-run this when script modifies the element or any of its descendents


Modified: trunk/Source/WebCore/css/CSSFontFaceSource.h (196375 => 196376)

--- trunk/Source/WebCore/css/CSSFontFaceSource.h	2016-02-10 19:53:54 UTC (rev 196375)
+++ trunk/Source/WebCore/css/CSSFontFaceSource.h	2016-02-10 19:54:38 UTC (rev 196376)
@@ -46,11 +46,11 @@
 WTF_MAKE_FAST_ALLOCATED;
 public:
 
-//  => Succeeded
+//  => Success
 ////
 // Pending => Loading
 //\\.
-//  => Failed
+//  => Failure
 enum class Status {
 Pending,
 Loading,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196389] trunk/LayoutTests

[ryanhaddad]

Title: [196389] trunk/LayoutTests








Revision 196389
Author ryanhad...@apple.com
Date 2016-02-10 13:10:37 -0800 (Wed, 10 Feb 2016)


Log Message
Marking fast/css-generated-content/details-summary-before-after.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153029

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (196388 => 196389)

--- trunk/LayoutTests/ChangeLog	2016-02-10 21:07:59 UTC (rev 196388)
+++ trunk/LayoutTests/ChangeLog	2016-02-10 21:10:37 UTC (rev 196389)
@@ -1,5 +1,14 @@
 2016-02-10  Ryan Haddad  
 
+Marking fast/css-generated-content/details-summary-before-after.html as failing on ios-simulator
+https://bugs.webkit.org/show_bug.cgi?id=153029
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/TestExpectations:
+
+2016-02-10  Ryan Haddad  
+
 Reaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196374
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (196388 => 196389)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-02-10 21:07:59 UTC (rev 196388)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-02-10 21:10:37 UTC (rev 196389)
@@ -2942,3 +2942,5 @@
 webkit.org/b/154055 perf/adding-radio-buttons.html [ Pass Failure ]
 
 webkit.org/b/153762 fast/regions/text-break-properties.html [ Skip ]
+
+webkit.org/b/153029 fast/css-generated-content/details-summary-before-after.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196377] trunk/Source/WebKit

[achristensen]

Title: [196377] trunk/Source/WebKit








Revision 196377
Author achristen...@apple.com
Date 2016-02-10 11:56:25 -0800 (Wed, 10 Feb 2016)


Log Message
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=154080
rdar://problem/24584417

Reviewed by Brent Fulgham.

* CMakeLists.txt:
Explicitly make WebKit dependent on WebKitGUID so that WebKit will not start building
before WebKitGUID is finished generating and copying all headers, including WebKit/WebKit.h.

Modified Paths

trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog




Diff

Modified: trunk/Source/WebKit/CMakeLists.txt (196376 => 196377)

--- trunk/Source/WebKit/CMakeLists.txt	2016-02-10 19:54:38 UTC (rev 196376)
+++ trunk/Source/WebKit/CMakeLists.txt	2016-02-10 19:56:25 UTC (rev 196377)
@@ -38,6 +38,9 @@
 
 add_library(WebKit ${WebKit_LIBRARY_TYPE} ${WebKit_SOURCES})
 add_dependencies(WebKit WebCore)
+if (WIN32)
+add_dependencies(WebKit WebKitGUID)
+endif ()
 target_link_libraries(WebKit ${WebKit_LIBRARIES})
 set_target_properties(WebKit PROPERTIES FOLDER "WebKit")
 


Modified: trunk/Source/WebKit/ChangeLog (196376 => 196377)

--- trunk/Source/WebKit/ChangeLog	2016-02-10 19:54:38 UTC (rev 196376)
+++ trunk/Source/WebKit/ChangeLog	2016-02-10 19:56:25 UTC (rev 196377)
@@ -1,3 +1,15 @@
+2016-02-10  Alex Christensen  
+
+Fix internal Windows build
+https://bugs.webkit.org/show_bug.cgi?id=154080
+rdar://problem/24584417
+
+Reviewed by Brent Fulgham.
+
+* CMakeLists.txt:
+Explicitly make WebKit dependent on WebKitGUID so that WebKit will not start building
+before WebKitGUID is finished generating and copying all headers, including WebKit/WebKit.h.
+
 2016-01-27  Anders Carlsson  
 
 Add WebKitAdditions extension points to WebCore, WebKit and WebKitLegacy






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196386] trunk/Websites/perf.webkit.org

[rniwa]

Title: [196386] trunk/Websites/perf.webkit.org








Revision 196386
Author rn...@webkit.org
Date 2016-02-10 13:05:37 -0800 (Wed, 10 Feb 2016)


Log Message
Add the support for maintenance mode
https://bugs.webkit.org/show_bug.cgi?id=154072

Reviewed by Chris Dumez.

Added the crude support for maintenance mode whereby which the reports are stored in the filesystem
instead of the database.

* config.json: Added maintenanceMode and maintenanceDirectory as well as forgotten siteTitle and
remoteServer.httpdMutexDir.
* public/api/report.php:
(main): Don't connect to the database or modify database when maintenanceMode is set.
* public/include/json-header.php:
(ensure_privileged_api_data): Exit with InMaintenanceMode when maintenanceMode is set. This prevents
privileged API such as creating analysis tasks and new A/B testing groups from modifying the database.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/config.json
trunk/Websites/perf.webkit.org/public/api/report.php
trunk/Websites/perf.webkit.org/public/include/json-header.php




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (196385 => 196386)

--- trunk/Websites/perf.webkit.org/ChangeLog	2016-02-10 20:56:26 UTC (rev 196385)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2016-02-10 21:05:37 UTC (rev 196386)
@@ -1,3 +1,21 @@
+2016-02-10  Ryosuke Niwa  
+
+Add the support for maintenance mode
+https://bugs.webkit.org/show_bug.cgi?id=154072
+
+Reviewed by Chris Dumez.
+
+Added the crude support for maintenance mode whereby which the reports are stored in the filesystem
+instead of the database.
+
+* config.json: Added maintenanceMode and maintenanceDirectory as well as forgotten siteTitle and
+remoteServer.httpdMutexDir.
+* public/api/report.php:
+(main): Don't connect to the database or modify database when maintenanceMode is set.
+* public/include/json-header.php:
+(ensure_privileged_api_data): Exit with InMaintenanceMode when maintenanceMode is set. This prevents
+privileged API such as creating analysis tasks and new A/B testing groups from modifying the database.
+
 2016-02-09  Ryosuke Niwa  
 
 Analysis task page on v3 show progression as regressions


Modified: trunk/Websites/perf.webkit.org/config.json (196385 => 196386)

--- trunk/Websites/perf.webkit.org/config.json	2016-02-10 20:56:26 UTC (rev 196385)
+++ trunk/Websites/perf.webkit.org/config.json	2016-02-10 21:05:37 UTC (rev 196386)
@@ -1,4 +1,5 @@
 {
+"siteTitle": "WebKit Performance Dashboard",
 "debug": true,
 "jsonCacheMaxAge": 600,
 "dataDirectory": "public/data/",
@@ -9,6 +10,8 @@
 "password": "password",
 "name": "webkit-perf-db"
 },
+"maintenanceMode": false,
+"maintenanceDirectory": "reported/",
 "testServer": {
 "hostname": "localhost",
 "port": 80
@@ -20,7 +23,8 @@
 "httpdConfig": "tools/remote-server-relay.conf",
 "httpdPID": "tools/remote-server-relay.pid",
 "httpdErrorLog": "tools/remote-server-relay.log",
-"url": "http://perf.webkit.org",
+"httpdMutexDir": "/tmp/org.webkit.perf.remote/",
+"url": "https://perf-safari.apple.com",
 "basicAuth": {
 "username": "username",
 "password": "password"


Modified: trunk/Websites/perf.webkit.org/public/api/report.php (196385 => 196386)

--- trunk/Websites/perf.webkit.org/public/api/report.php	2016-02-10 20:56:26 UTC (rev 196385)
+++ trunk/Websites/perf.webkit.org/public/api/report.php	2016-02-10 21:05:37 UTC (rev 196386)
@@ -7,8 +7,12 @@
 function main($post_data) {
 set_exit_detail('failureStored', false);
 
+$maintenance_mode = config('maintenanceMode');
+if ($maintenance_mode && !config('maintenanceDirectory'))
+exit_with_error('MaintenanceDirectoryNotSet');
+
 $db = new Database;
-if (!$db->connect())
+if (!$maintenance_mode && !$db->connect())
 exit_with_error('DatabaseConnectionFailure');
 
 // Convert all floating points to strings to avoid parsing them in PHP.
@@ -19,16 +23,29 @@
 
 set_exit_detail('processedRuns', 0);
 foreach ($parsed_json as $i => $report) {
-$processor = new ReportProcessor($db);
-$processor->process($report);
+if (!$maintenance_mode) {
+$processor = new ReportProcessor($db);
+$processor->process($report);
+}
 set_exit_detail('processedRuns', $i + 1);
 }
 
-$generator = new ManifestGenerator($db);
-if (!$generator->generate())
-exit_with_error('FailedToGenerateManifest');
-else if (!$generator->store())
-exit_with_error('FailedToStoreManifest');
+if ($maintenance_mode) {
+$files = scandir(config_path('maintenanceDirectory', ''));
+$i = 0;
+$filename = '';
+do {
+$i++;
+$filename = 

[webkit-changes] [196390] trunk/Websites/perf.webkit.org

[rniwa]

Title: [196390] trunk/Websites/perf.webkit.org








Revision 196390
Author rn...@webkit.org
Date 2016-02-10 13:18:02 -0800 (Wed, 10 Feb 2016)


Log Message
Removed the duplicated definition of ChartPaneBase.

* public/v3/components/chart-pane-base.js:

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (196389 => 196390)

--- trunk/Websites/perf.webkit.org/ChangeLog	2016-02-10 21:10:37 UTC (rev 196389)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2016-02-10 21:18:02 UTC (rev 196390)
@@ -1,3 +1,9 @@
+2016-02-10  Ryosuke Niwa  
+
+Removed the duplicated definition of ChartPaneBase.
+
+* public/v3/components/chart-pane-base.js:
+
 2016-02-09  Ryosuke Niwa  
 
 Analysis task page on v3 UI should show charts


Modified: trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js (196389 => 196390)

--- trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js	2016-02-10 21:10:37 UTC (rev 196389)
+++ trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js	2016-02-10 21:18:02 UTC (rev 196390)
@@ -302,311 +302,3 @@
 }
 
 }
-
-class ChartPaneBase extends ComponentBase {
-
-constructor(name)
-{
-super(name);
-
-this._errorMessage = null;
-this._platformId = null;
-this._metricId = null;
-this._platform = null;
-this._metric = null;
-
-this._overviewChart = null;
-this._mainChart = null;
-this._mainChartStatus = null;
-this._commitLogViewer = null;
-}
-
-configure(platformId, metricId)
-{
-var result = ChartStyles.createChartSourceList(platformId, metricId);
-this._errorMessage = result.error;
-this._platformId = platformId;
-this._metricId = metricId;
-this._platform = result.platform;
-this._metric = result.metric;
-
-this._overviewChart = null;
-this._mainChart = null;
-this._mainChartStatus = null;
-
-this._commitLogViewer = this.content().querySelector('commit-log-viewer').component();
-
-if (result.error)
-return;
-
-var formatter = result.metric.makeFormatter(4);
-var self = this;
-
-var overviewOptions = ChartStyles.overviewChartOptions(formatter);
-overviewOptions.selection._onchange_ = this._overviewSelectionDidChange.bind(this);
-
-this._overviewChart = new InteractiveTimeSeriesChart(result.sourceList, overviewOptions);
-this.renderReplace(this.content().querySelector('.chart-pane-overview'), this._overviewChart);
-
-var mainOptions = ChartStyles.mainChartOptions(formatter);
-mainOptions.indicator._onchange_ = this._indicatorDidChange.bind(this);
-mainOptions.selection._onchange_ = this._mainSelectionDidChange.bind(this);
-mainOptions.selection._onzoom_ = this._mainSelectionDidZoom.bind(this);
-mainOptions.annotations._onclick_ = this._openAnalysisTask.bind(this);
-mainOptions._ondata_ = this._didFetchData.bind(this);
-this._mainChart = new InteractiveTimeSeriesChart(result.sourceList, mainOptions);
-this.renderReplace(this.content().querySelector('.chart-pane-main'), this._mainChart);
-
-this._mainChartStatus = new ChartPaneStatusView(result.metric, this._mainChart, this._openCommitViewer.bind(this));
-this.renderReplace(this.content().querySelector('.chart-pane-details'), this._mainChartStatus);
-
-this.content().querySelector('.chart-pane').addEventListener('keyup', this._keyup.bind(this));
-
-this._fetchAnalysisTasks(platformId, metricId);
-}
-
-_fetchAnalysisTasks(platformId, metricId)
-{
-var self = this;
-AnalysisTask.fetchByPlatformAndMetric(platformId, metricId).then(function (tasks) {
-self._mainChart.setAnnotations(tasks.map(function (task) {
-var fillStyle = '#fc6';
-switch (task.changeType()) {
-case 'inconclusive':
-fillStyle = '#fcc';
-case 'progression':
-fillStyle = '#39f';
-break;
-case 'regression':
-fillStyle = '#c60';
-break;
-case 'unchanged':
-fillStyle = '#ccc';
-break;
-}
-
-return {
-task: task,
-startTime: task.startTime(),
-endTime: task.endTime(),
-label: task.label(),
-fillStyle: fillStyle,
-};
-}));
-});
-}
-
-platformId() { return this._platformId; }
-metricId() { return this._metricId; }
-
-setOverviewDomain(startTime, endTime)
-{
-

[webkit-changes] [196382] tags/Safari-602.1.18.6/Source/WebKit

[bshafiei]

Title: [196382] tags/Safari-602.1.18.6/Source/WebKit








Revision 196382
Author bshaf...@apple.com
Date 2016-02-10 12:46:38 -0800 (Wed, 10 Feb 2016)


Log Message
Merged r196377.  rdar://problem/24584417

Modified Paths

tags/Safari-602.1.18.6/Source/WebKit/CMakeLists.txt
tags/Safari-602.1.18.6/Source/WebKit/ChangeLog




Diff

Modified: tags/Safari-602.1.18.6/Source/WebKit/CMakeLists.txt (196381 => 196382)

--- tags/Safari-602.1.18.6/Source/WebKit/CMakeLists.txt	2016-02-10 20:45:01 UTC (rev 196381)
+++ tags/Safari-602.1.18.6/Source/WebKit/CMakeLists.txt	2016-02-10 20:46:38 UTC (rev 196382)
@@ -38,6 +38,9 @@
 
 add_library(WebKit ${WebKit_LIBRARY_TYPE} ${WebKit_SOURCES})
 add_dependencies(WebKit WebCore)
+if (WIN32)
+add_dependencies(WebKit WebKitGUID)
+endif ()
 target_link_libraries(WebKit ${WebKit_LIBRARIES})
 set_target_properties(WebKit PROPERTIES FOLDER "WebKit")
 


Modified: tags/Safari-602.1.18.6/Source/WebKit/ChangeLog (196381 => 196382)

--- tags/Safari-602.1.18.6/Source/WebKit/ChangeLog	2016-02-10 20:45:01 UTC (rev 196381)
+++ tags/Safari-602.1.18.6/Source/WebKit/ChangeLog	2016-02-10 20:46:38 UTC (rev 196382)
@@ -1,3 +1,19 @@
+2016-02-10  Babak Shafiei  
+
+Merge r196377.
+
+2016-02-10  Alex Christensen  
+
+Fix internal Windows build
+https://bugs.webkit.org/show_bug.cgi?id=154080
+rdar://problem/24584417
+
+Reviewed by Brent Fulgham.
+
+* CMakeLists.txt:
+Explicitly make WebKit dependent on WebKitGUID so that WebKit will not start building
+before WebKitGUID is finished generating and copying all headers, including WebKit/WebKit.h.
+
 2016-01-27  Anders Carlsson  
 
 Add WebKitAdditions extension points to WebCore, WebKit and WebKitLegacy






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196387] trunk/Websites/perf.webkit.org

[rniwa]

Title: [196387] trunk/Websites/perf.webkit.org








Revision 196387
Author rn...@webkit.org
Date 2016-02-10 13:07:52 -0800 (Wed, 10 Feb 2016)


Log Message
Analysis task page on v3 UI should show charts
https://bugs.webkit.org/show_bug.cgi?id=154057

Reviewed by Chris Dumez.

Extracted ChartPaneBase out of ChartPane and added an instance of its new subclass, AnalysisTaskChartPane,
to the analysis task page. The main difference is that ChartPaneBase doesn't depend on the presence of
this._chartsPage unlike ChartPane. It also doesn't have the header with toolbar (to show breakdown, etc...).

* public/v3/components/base.js:
(ComponentBase.prototype._constructShadowTree): Call htmlTemplate() and cssTemplate() with the right "this".

* public/v3/components/chart-pane-base.js: Added.
(ChartPaneBase): Extracted from ChartPane.
(ChartPaneBase.prototype.configure): Extracted from the constructor. Separating this function allows the
component to be instantiated inside a HTML template.
(ChartPaneBase.prototype._fetchAnalysisTasks): Moved from ChartPane._fetchAnalysisTasks.
(ChartPaneBase.prototype.platformId): Ditto.
(ChartPaneBase.prototype.metricId): Ditto.
(ChartPaneBase.prototype.setOverviewDomain): Ditto.
(ChartPaneBase.prototype.setMainDomain): Ditto.
(ChartPaneBase.prototype._overviewSelectionDidChange): Extracted from the constructor. This is overridden in
ChartPane and unused in AnalysisTaskChartPane.
(ChartPaneBase.prototype._mainSelectionDidChange): Extracted from ChartPane._mainSelectionDidChange.
(ChartPaneBase.prototype._mainSelectionDidZoom): Extracted from ChartPane._mainSelectionDidZoom.
(ChartPaneBase.prototype._indicatorDidChange): Extracted from ChartPane._indicatorDidChange.
(ChartPaneBase.prototype._didFetchData): Moved from ChartPane._fetchAnalysisTasks.
(ChartPaneBase.prototype._openAnalysisTask): Ditto.
(ChartPaneBase.prototype._openCommitViewer): Ditto. Also fixed a bug that we don't show the spinner while
waiting for the data to be fetched by calling this.render() here.
(ChartPaneBase.prototype._keyup): Moved from ChartPane._keyup. Also fixed the bug that the revisions list
doesn't update by calling this.render() here.
(ChartPaneBase.prototype.render): Extracted from ChartPane.render.
(ChartPaneBase.htmlTemplate): Extracted from ChartPane.htmlTemplate.
(ChartPaneBase.paneHeaderTemplate): Added. This is overridden in ChartPane and unused in AnalysisTaskChartPane.
(ChartPaneBase.cssTemplate): Extracted from ChartPane.htmlTemplate.

* public/v3/components/chart-styles.js: Renamed from public/v3/pages/page-with-charts.js.
(PageWithCharts): Renamed from PageWithCharts since it no longer extends PageWithHeading.
(ChartStyles.createChartSourceList):

* public/v3/components/commit-log-viewer.js:
(CommitLogViewer.prototype.view): Set this._repository right away instead of waiting for the fetched data
so that spinner will be shown while the data is being fetched.

* public/v3/index.html:

* public/v3/pages/analysis-task-page.js:
(AnalysisTaskChartPane): Added extends ChartPaneBase.
(AnalysisTaskPage): Added. this._chartPane.
(AnalysisTaskPage.prototype._didFetchTask): Initialize this._chartPane with a domain.
(AnalysisTaskPage.prototype.render): Render this._chartPane.
(AnalysisTaskPage.htmlTemplate):

* public/v3/pages/chart-pane-status-view.js:
(ChartPaneStatusView): Removed the unused router from the argument list.
(ChartPaneStatusView.prototype.pointsRangeForAnalysis): Renamed from analyzeData() since it was ambiguous.
(ChartPaneStatusView.prototype.moveRepositoryWithNotification): Fixed the bug that we don't update the list
of the revisions here.
(ChartPaneStatusView.prototype.computeChartStatusLabels):

* public/v3/pages/chart-pane.js:
(ChartPane): Now extends ChartPaneBase. 
(ChartPane.prototype._overviewSelectionDidChange): Extracted from the constructor.
(ChartPane.prototype._mainSelectionDidChange): 
(ChartPane.prototype._mainSelectionDidZoom):
(ChartPane.prototype._indicatorDidChange):
(ChartPane.prototype.render):
(ChartPane.prototype._renderActionToolbar):
(ChartPane.paneHeaderTemplate): Extracted from htmlTemplate.
(ChartPane.cssTemplate):
(ChartPane.overviewOptions.selection.onchange): Deleted.
(ChartPane.prototype._fetchAnalysisTasks): Deleted.
(ChartPane.prototype.platformId): Deleted.
(ChartPane.prototype.metricId): Deleted.
(ChartPane.prototype.setOverviewDomain): Deleted.
(ChartPane.prototype.setMainDomain): Deleted.
(ChartPane.prototype._openCommitViewer): Deleted.
(ChartPane.prototype._didFetchData): Deleted.
(ChartPane.prototype._keyup): Deleted.

* public/v3/pages/charts-page.js:
(ChartsPage):
(ChartsPage.createDomainForAnalysisTask): Extracted by createDomainForAnalysisTask; used to set the domain
of the charts in the analysis task page.
(ChartsPage.createStateForAnalysisTask):

* public/v3/pages/dashboard-page.js:
(DashboardPage):
(DashboardPage.prototype._createChartForCell):

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog

[webkit-changes] [196375] branches/safari-601-branch/Source/WebInspectorUI

[bshafiei]

Title: [196375] branches/safari-601-branch/Source/WebInspectorUI








Revision 196375
Author bshaf...@apple.com
Date 2016-02-10 11:53:54 -0800 (Wed, 10 Feb 2016)


Log Message
Merge patch for rdar://problem/24267980.

Modified Paths

branches/safari-601-branch/Source/WebInspectorUI/ChangeLog
branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js




Diff

Modified: branches/safari-601-branch/Source/WebInspectorUI/ChangeLog (196374 => 196375)

--- branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2016-02-10 19:47:10 UTC (rev 196374)
+++ branches/safari-601-branch/Source/WebInspectorUI/ChangeLog	2016-02-10 19:53:54 UTC (rev 196375)
@@ -1,3 +1,17 @@
+2016-02-10  Babak Shafiei  
+
+Merge patch for rdar://problem/24267980.
+
+2016-02-09  Timothy Hatcher  
+
+ Names of watch expressions all the same
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
+(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection): Bind the _expression_ var since
+lexical scoping is not available on the branch, and this was converted to a var from a let.
+
 2016-01-26  Timothy Hatcher  
 
 Merge r195323. rdar://problem/24302730


Modified: branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js (196374 => 196375)

--- branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js	2016-02-10 19:47:10 UTC (rev 196374)
+++ branches/safari-601-branch/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js	2016-02-10 19:53:54 UTC (rev 196375)
@@ -261,13 +261,13 @@
 
 var promises = [];
 for (var _expression_ of watchExpressions) {
-promises.push(new Promise(function(resolve, reject) {
+promises.push(new Promise(function(_expression_, resolve, reject) {
 WebInspector.runtimeManager.evaluateInInspectedWindow(_expression_, WebInspector.ScopeChainDetailsSidebarPanel.WatchExpressionsObjectGroupName, false, true, false, true, false, function(object, wasThrown) {
 var propertyDescriptor = new WebInspector.PropertyDescriptor({name: _expression_, value: object}, undefined, undefined, wasThrown);
 objectTree.appendExtraPropertyDescriptor(propertyDescriptor);
 resolve(propertyDescriptor);
 });
-}));
+}.bind(null, _expression_)));
 }
 
 return Promise.all(promises).then(function() {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196380] branches/safari-601-branch/Source/WebCore

[matthew_hanson]

Title: [196380] branches/safari-601-branch/Source/WebCore








Revision 196380
Author matthew_han...@apple.com
Date 2016-02-10 12:33:20 -0800 (Wed, 10 Feb 2016)


Log Message
Merge r196226. rdar://problem/24417430

Modified Paths

branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h
branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm




Diff

Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (196379 => 196380)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2016-02-10 20:33:18 UTC (rev 196379)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2016-02-10 20:33:20 UTC (rev 196380)
@@ -1,5 +1,27 @@
 2016-02-10  Matthew Hanson  
 
+Merge r196226. rdar://problem/24417430
+
+2016-02-06  Beth Dakin  
+
+ScrollbarPainters needs to be deallocated on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=153932
+-and corresponding-
+rdar://problem/24015483
+
+Reviewed by Dan Bernstein.
+
+Darin pointed out that this was still race-y. There was still a race
+condition between the destruction of the two local variables and the
+destruction of the lambda on the main thread. This should fix that.
+* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
+* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
+(WebCore::ScrollingTreeFrameScrollingNodeMac::releaseReferencesToScrollbarPaintersOnTheMainThread):
+(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
+
+2016-02-10  Matthew Hanson  
+
 Merge r196208. rdar://problem/24417430
 
 2016-02-05  Beth Dakin  


Modified: branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h (196379 => 196380)

--- branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h	2016-02-10 20:33:18 UTC (rev 196379)
+++ branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h	2016-02-10 20:33:20 UTC (rev 196380)
@@ -45,6 +45,8 @@
 private:
 ScrollingTreeFrameScrollingNodeMac(ScrollingTree&, ScrollingNodeID);
 
+void releaseReferencesToScrollbarPaintersOnTheMainThread();
+
 // ScrollingTreeNode member functions.
 virtual void updateBeforeChildren(const ScrollingStateNode&) override;
 virtual void updateAfterChildren(const ScrollingStateNode&) override;


Modified: branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm (196379 => 196380)

--- branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm	2016-02-10 20:33:18 UTC (rev 196379)
+++ branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm	2016-02-10 20:33:20 UTC (rev 196380)
@@ -65,12 +65,20 @@
 
 ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac()
 {
+releaseReferencesToScrollbarPaintersOnTheMainThread();
+}
+
+void ScrollingTreeFrameScrollingNodeMac::releaseReferencesToScrollbarPaintersOnTheMainThread()
+{
 if (m_verticalScrollbarPainter || m_horizontalScrollbarPainter) {
 // FIXME: This is a workaround in place for the time being since NSScrollerImps cannot be deallocated
 // on a non-main thread. rdar://problem/24535055
-RetainPtr retainedVerticalScrollbarPainter = WTFMove(m_verticalScrollbarPainter);
-RetainPtr retainedHorizontalScrollbarPainter = WTFMove(m_horizontalScrollbarPainter);
-WTF::callOnMainThread([retainedVerticalScrollbarPainter, retainedHorizontalScrollbarPainter] { });
+ScrollbarPainter retainedVerticalScrollbarPainter = m_verticalScrollbarPainter.leakRef();
+ScrollbarPainter retainedHorizontalScrollbarPainter = m_horizontalScrollbarPainter.leakRef();
+WTF::callOnMainThread([retainedVerticalScrollbarPainter, retainedHorizontalScrollbarPainter] {
+[retainedVerticalScrollbarPainter release];
+[retainedHorizontalScrollbarPainter release];
+});
 }
 }
 
@@ -113,14 +121,7 @@
 m_footerLayer = scrollingStateNode.footerLayer();
 
 if (scrollingStateNode.hasChangedProperty(ScrollingStateFrameScrollingNode::PainterForScrollbar)) {
-{
-// FIXME: This is a workaround in place for the time being since NSScrollerImps cannot be deallocated
-// on a non-main thread. rdar://problem/24535055
-RetainPtr retainedVerticalScrollbarPainter = WTFMove(m_verticalScrollbarPainter);
-RetainPtr retainedHorizontalScrollbarPainter = 

[webkit-changes] [196379] branches/safari-601-branch/Source/WebCore

[matthew_hanson]

Title: [196379] branches/safari-601-branch/Source/WebCore








Revision 196379
Author matthew_han...@apple.com
Date 2016-02-10 12:33:18 -0800 (Wed, 10 Feb 2016)


Log Message
Merge r196208. rdar://problem/24417430

Modified Paths

branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm




Diff

Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (196378 => 196379)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2016-02-10 20:33:15 UTC (rev 196378)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2016-02-10 20:33:18 UTC (rev 196379)
@@ -1,5 +1,23 @@
 2016-02-10  Matthew Hanson  
 
+Merge r196208. rdar://problem/24417430
+
+2016-02-05  Beth Dakin  
+
+ScrollbarPainters needs to be deallocated on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=153932
+-and corresponding-
+rdar://problem/24015483
+
+Reviewed by Geoff Garen.
+
+Follow-up fix since the first one was still race-y.
+* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
+(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
+
+2016-02-10  Matthew Hanson  
+
 Merge r196206. rdar://problem/24417430
 
 2016-02-05  Beth Dakin  


Modified: branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm (196378 => 196379)

--- branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm	2016-02-10 20:33:15 UTC (rev 196378)
+++ branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm	2016-02-10 20:33:18 UTC (rev 196379)
@@ -68,8 +68,8 @@
 if (m_verticalScrollbarPainter || m_horizontalScrollbarPainter) {
 // FIXME: This is a workaround in place for the time being since NSScrollerImps cannot be deallocated
 // on a non-main thread. rdar://problem/24535055
-RetainPtr retainedVerticalScrollbarPainter = m_verticalScrollbarPainter;
-RetainPtr retainedHorizontalScrollbarPainter = m_horizontalScrollbarPainter;
+RetainPtr retainedVerticalScrollbarPainter = WTFMove(m_verticalScrollbarPainter);
+RetainPtr retainedHorizontalScrollbarPainter = WTFMove(m_horizontalScrollbarPainter);
 WTF::callOnMainThread([retainedVerticalScrollbarPainter, retainedHorizontalScrollbarPainter] { });
 }
 }
@@ -116,8 +116,8 @@
 {
 // FIXME: This is a workaround in place for the time being since NSScrollerImps cannot be deallocated
 // on a non-main thread. rdar://problem/24535055
-RetainPtr retainedVerticalScrollbarPainter = m_verticalScrollbarPainter;
-RetainPtr retainedHorizontalScrollbarPainter = m_horizontalScrollbarPainter;
+RetainPtr retainedVerticalScrollbarPainter = WTFMove(m_verticalScrollbarPainter);
+RetainPtr retainedHorizontalScrollbarPainter = WTFMove(m_horizontalScrollbarPainter);
 WTF::callOnMainThread([retainedVerticalScrollbarPainter, retainedHorizontalScrollbarPainter]
 {});
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196378] branches/safari-601-branch/Source/WebCore

[matthew_hanson]

Title: [196378] branches/safari-601-branch/Source/WebCore








Revision 196378
Author matthew_han...@apple.com
Date 2016-02-10 12:33:15 -0800 (Wed, 10 Feb 2016)


Log Message
Merge r196206. rdar://problem/24417430

Modified Paths

branches/safari-601-branch/Source/WebCore/ChangeLog
branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm




Diff

Modified: branches/safari-601-branch/Source/WebCore/ChangeLog (196377 => 196378)

--- branches/safari-601-branch/Source/WebCore/ChangeLog	2016-02-10 19:56:25 UTC (rev 196377)
+++ branches/safari-601-branch/Source/WebCore/ChangeLog	2016-02-10 20:33:15 UTC (rev 196378)
@@ -1,3 +1,23 @@
+2016-02-10  Matthew Hanson  
+
+Merge r196206. rdar://problem/24417430
+
+2016-02-05  Beth Dakin  
+
+ScrollbarPainters needs to be deallocated on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=153932
+-and corresponding-
+rdar://problem/24015483
+
+Reviewed by Tim Horton.
+
+Ensure the the destructor of ScrollingTreeFrameScrollingNodeMac and the
+assignments done in this class are not responsible for deallocating the
+ScrollbarPainter.
+* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
+(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
+(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
+
 2016-02-09  Babak Shafiei  
 
 Merge r190616.


Modified: branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm (196377 => 196378)

--- branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm	2016-02-10 19:56:25 UTC (rev 196377)
+++ branches/safari-601-branch/Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm	2016-02-10 20:33:15 UTC (rev 196378)
@@ -65,6 +65,13 @@
 
 ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac()
 {
+if (m_verticalScrollbarPainter || m_horizontalScrollbarPainter) {
+// FIXME: This is a workaround in place for the time being since NSScrollerImps cannot be deallocated
+// on a non-main thread. rdar://problem/24535055
+RetainPtr retainedVerticalScrollbarPainter = m_verticalScrollbarPainter;
+RetainPtr retainedHorizontalScrollbarPainter = m_horizontalScrollbarPainter;
+WTF::callOnMainThread([retainedVerticalScrollbarPainter, retainedHorizontalScrollbarPainter] { });
+}
 }
 
 #if ENABLE(CSS_SCROLL_SNAP)
@@ -106,6 +113,14 @@
 m_footerLayer = scrollingStateNode.footerLayer();
 
 if (scrollingStateNode.hasChangedProperty(ScrollingStateFrameScrollingNode::PainterForScrollbar)) {
+{
+// FIXME: This is a workaround in place for the time being since NSScrollerImps cannot be deallocated
+// on a non-main thread. rdar://problem/24535055
+RetainPtr retainedVerticalScrollbarPainter = m_verticalScrollbarPainter;
+RetainPtr retainedHorizontalScrollbarPainter = m_horizontalScrollbarPainter;
+WTF::callOnMainThread([retainedVerticalScrollbarPainter, retainedHorizontalScrollbarPainter]
+{});
+}
 m_verticalScrollbarPainter = scrollingStateNode.verticalScrollbarPainter();
 m_horizontalScrollbarPainter = scrollingStateNode.horizontalScrollbarPainter();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196381] trunk/PerformanceTests

[said]

Title: [196381] trunk/PerformanceTests








Revision 196381
Author s...@apple.com
Date 2016-02-10 12:45:01 -0800 (Wed, 10 Feb 2016)


Log Message
Add internal benchmark tests for CSS mix-blend-modes and filters
https://bugs.webkit.org/show_bug.cgi?id=154058

Provisionally reviewed by Jon Lee.

* Animometer/resources/debug-runner/tests.js: Include the new tests in the
"HTML suite" of the debug runner.

* Animometer/resources/extensions.js:
(Utilities.browserPrefix):
(Utilities.setElementPrefixedProperty): Utility functions to allow setting
prefixed style properties.

* Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js:
Set the mix-blend-mode and the filter to some random values if the options
of the test requested that.

* Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
(parseShapeParameters): Parse the url options "blend" and "filter" and set
the corresponding flags.

* Animometer/tests/resources/main.js:
(randomStyleMixBlendMode):
(randomStyleFilter): Return random mix-blend-mode and filter.

Modified Paths

trunk/PerformanceTests/Animometer/resources/debug-runner/tests.js
trunk/PerformanceTests/Animometer/resources/extensions.js
trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js
trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-particles.js
trunk/PerformanceTests/Animometer/tests/resources/main.js
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/resources/debug-runner/tests.js (196380 => 196381)

--- trunk/PerformanceTests/Animometer/resources/debug-runner/tests.js	2016-02-10 20:33:20 UTC (rev 196380)
+++ trunk/PerformanceTests/Animometer/resources/debug-runner/tests.js	2016-02-10 20:45:01 UTC (rev 196381)
@@ -130,6 +130,14 @@
 name: "CSS bouncing gradient circles"
 },
 {
+url: "bouncing-particles/bouncing-css-shapes.html?particleWidth=80=80=circle",
+name: "CSS bouncing blend circles"
+},
+{
+url: "bouncing-particles/bouncing-css-shapes.html?particleWidth=80=80=circle",
+name: "CSS bouncing filter circles"
+},
+{
 url: "bouncing-particles/bouncing-css-images.html?particleWidth=80=80=../resources/yin-yang.svg",
 name: "CSS bouncing SVG images"
 },


Modified: trunk/PerformanceTests/Animometer/resources/extensions.js (196380 => 196381)

--- trunk/PerformanceTests/Animometer/resources/extensions.js	2016-02-10 20:33:20 UTC (rev 196380)
+++ trunk/PerformanceTests/Animometer/resources/extensions.js	2016-02-10 20:45:01 UTC (rev 196381)
@@ -82,6 +82,40 @@
 
 parentElement.appendChild(element);
 return element;
+},
+
+browserPrefix: function()
+{
+// Get the HTML element's CSSStyleDeclaration
+var styles = window.getComputedStyle(document.documentElement, '');
+
+// Convert the styles list to an array
+var stylesArray = Array.prototype.slice.call(styles);
+
+// Concatenate all the styles in one big string
+var stylesString = stylesArray.join('');
+
+// Search the styles string for a known prefix type, settle on Opera if none is found.
+var prefixes = stylesString.match(/-(moz|webkit|ms)-/) || (styles.OLink === '' && ['', 'o']);
+
+// prefixes has two elements; e.g. for webkit it has ['-webkit-', 'webkit'];
+var prefix = prefixes[1];
+
+// Have 'O' before 'Moz' in the string so it is matched first.
+var dom = ('WebKit|O|Moz|MS').match(new RegExp(prefix, 'i'))[0];
+
+// Return all the required prefixes.
+return {
+dom: dom,
+lowercase: prefix,
+css: '-' + prefix + '-',
+js: prefix[0].toUpperCase() + prefix.substr(1)
+};
+},
+
+setElementPrefixedProperty: function(element, property, value)
+{
+element.style[property] = element.style[this.browserPrefix().js + property[0].toUpperCase() + property.substr(1)] = value;
 }
 };
 


Modified: trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js (196380 => 196381)

--- trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js	2016-02-10 20:33:20 UTC (rev 196380)
+++ trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js	2016-02-10 20:45:01 UTC (rev 196381)
@@ -18,6 +18,13 @@
 break;
 }
 
+if (stage.blend)
+this.element.style.mixBlendMode = Stage.randomStyleMixBlendMode();
+
+// Some browsers have not un-prefixed the css filter yet.
+if (stage.filter)
+Utilities.setElementPrefixedProperty(this.element, "filter", Stage.randomStyleFilter());
+
 this._move();
 }, {
 


Modified: 

[webkit-changes] [196385] trunk/LayoutTests

[ryanhaddad]

Title: [196385] trunk/LayoutTests








Revision 196385
Author ryanhad...@apple.com
Date 2016-02-10 12:56:26 -0800 (Wed, 10 Feb 2016)


Log Message
Reaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196374

Unreviewed test gardening.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (196384 => 196385)

--- trunk/LayoutTests/ChangeLog	2016-02-10 20:56:11 UTC (rev 196384)
+++ trunk/LayoutTests/ChangeLog	2016-02-10 20:56:26 UTC (rev 196385)
@@ -1,3 +1,11 @@
+2016-02-10  Ryan Haddad  
+
+Reaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196374
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
+
 2016-02-10  Chris Dumez  
 
 Attributes on the Window instance should be configurable unless [Unforgeable]


Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (196384 => 196385)

--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-10 20:56:11 UTC (rev 196384)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-10 20:56:26 UTC (rev 196385)
@@ -3800,30 +3800,34 @@
 PASS Window interface object name 
 FAIL Window interface: existence and properties of interface prototype object assert_equals: Class name for prototype of Window.prototype is not "WindowProperties" expected "[object WindowProperties]" but got "[object Object]"
 FAIL Window interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Window.prototype does not have own property "constructor" expected property "constructor" missing
-FAIL Window interface: attribute self assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute name assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute history assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute locationbar assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute menubar assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute personalbar assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute scrollbars assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute statusbar assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute toolbar assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute status assert_true: property must be configurable expected true got false
+PASS Window interface: attribute self 
+PASS Window interface: attribute name 
+FAIL Window interface: attribute history assert_equals: setter must be undefined for readonly attributes expected (undefined) undefined but got (function) function "function history() {
+[native code]
+}"
+PASS Window interface: attribute locationbar 
+PASS Window interface: attribute menubar 
+PASS Window interface: attribute personalbar 
+PASS Window interface: attribute scrollbars 
+PASS Window interface: attribute statusbar 
+PASS Window interface: attribute toolbar 
+PASS Window interface: attribute status 
 FAIL Window interface: operation close() assert_equals: property should be writable if and only if not unforgeable expected true but got false
-FAIL Window interface: attribute closed assert_true: property must be configurable expected true got false
+PASS Window interface: attribute closed 
 FAIL Window interface: operation stop() desc is not an Object. (evaluating '"get" in desc')
 FAIL Window interface: operation focus() assert_equals: property should be writable if and only if not unforgeable expected true but got false
 FAIL Window interface: operation blur() assert_equals: property should be writable if and only if not unforgeable expected true but got false
-FAIL Window interface: attribute frames assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute length assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute opener assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute parent assert_true: property must be configurable expected true got false
-FAIL Window interface: attribute frameElement assert_true: property 

[webkit-changes] [196391] trunk/Source/WebCore

[jer . noble]

Title: [196391] trunk/Source/WebCore








Revision 196391
Author jer.no...@apple.com
Date 2016-02-10 13:45:12 -0800 (Wed, 10 Feb 2016)


Log Message
[Mac] Graphical corruption in videos when enabling custom loading path
https://bugs.webkit.org/show_bug.cgi?id=154044

Reviewed by Alex Christensen.

Revert the "Drive-by fix" in r196345 as it breaks the WebCoreNSURLSessionTests.BasicOperation API test.

* platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (196390 => 196391)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 21:18:02 UTC (rev 196390)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 21:45:12 UTC (rev 196391)
@@ -1,3 +1,15 @@
+2016-02-10  Jer Noble  
+
+[Mac] Graphical corruption in videos when enabling custom loading path
+https://bugs.webkit.org/show_bug.cgi?id=154044
+
+Reviewed by Alex Christensen.
+
+Revert the "Drive-by fix" in r196345 as it breaks the WebCoreNSURLSessionTests.BasicOperation API test.
+
+* platform/network/cocoa/WebCoreNSURLSession.mm:
+(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
+
 2016-02-10  Myles C. Maxfield  
 
 CSSSegmentedFontFace does not need to be reference counted


Modified: trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm (196390 => 196391)

--- trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm	2016-02-10 21:18:02 UTC (rev 196390)
+++ trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm	2016-02-10 21:45:12 UTC (rev 196391)
@@ -513,11 +513,10 @@
 // FIXME: try to avoid a copy, if possible.
 // e.g., RetainPtr cfData = resource->resourceBuffer()->createCFData();
 
-self.countOfBytesReceived += length;
-
 RetainPtr nsData = adoptNS([[NSData alloc] initWithBytes:data length:length]);
 RetainPtr strongSelf { self };
 [self.session addDelegateOperation:[strongSelf, length, nsData] {
+strongSelf.get().countOfBytesReceived += length;
 id dataDelegate = (id)strongSelf.get().session.delegate;
 if ([dataDelegate respondsToSelector:@selector(URLSession:dataTask:didReceiveData:)])
 [dataDelegate URLSession:(NSURLSession *)strongSelf.get().session dataTask:(NSURLSessionDataTask *)strongSelf.get() didReceiveData:nsData.get()];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196394] trunk/Source/WebCore

[commit-queue]

Title: [196394] trunk/Source/WebCore








Revision 196394
Author commit-qu...@webkit.org
Date 2016-02-10 14:01:18 -0800 (Wed, 10 Feb 2016)


Log Message
[cmake] Consolidate CMake code related to image decoders.
https://bugs.webkit.org/show_bug.cgi?id=154074

Patch by Konstantin Tokarev  on 2016-02-10
Reviewed by Alex Christensen.

Common image decoder sources, includes and libs are moved to
platform/ImageDecoders.cmake.

Also, added include directories of libjpeg and libpng to
WebCore_SYSTEM_INCLUDE_DIRECTORIES.

No new tests needed.

* CMakeLists.txt: Moved common include paths to ImageDecoders.cmake.
* PlatformEfl.cmake: Moved common sources and libs to ImageDecoders.cmake.
* PlatformGTK.cmake: Ditto.
* PlatformWinCairo.cmake: Moved common sources to ImageDecoders.cmake.
* platform/ImageDecoders.cmake: Added.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/PlatformWinCairo.cmake


Added Paths

trunk/Source/WebCore/platform/ImageDecoders.cmake




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (196393 => 196394)

--- trunk/Source/WebCore/CMakeLists.txt	2016-02-10 21:57:53 UTC (rev 196393)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-02-10 22:01:18 UTC (rev 196394)
@@ -80,13 +80,6 @@
 "${WEBCORE_DIR}/platform/graphics/opentype"
 "${WEBCORE_DIR}/platform/graphics/texmap"
 "${WEBCORE_DIR}/platform/graphics/transforms"
-"${WEBCORE_DIR}/platform/image-decoders"
-"${WEBCORE_DIR}/platform/image-decoders/bmp"
-"${WEBCORE_DIR}/platform/image-decoders/gif"
-"${WEBCORE_DIR}/platform/image-decoders/ico"
-"${WEBCORE_DIR}/platform/image-decoders/jpeg"
-"${WEBCORE_DIR}/platform/image-decoders/png"
-"${WEBCORE_DIR}/platform/image-decoders/webp"
 "${WEBCORE_DIR}/platform/mediastream"
 "${WEBCORE_DIR}/platform/mock"
 "${WEBCORE_DIR}/platform/mock/mediasource"


Modified: trunk/Source/WebCore/ChangeLog (196393 => 196394)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 21:57:53 UTC (rev 196393)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 22:01:18 UTC (rev 196394)
@@ -1,3 +1,24 @@
+2016-02-10  Konstantin Tokarev  
+
+[cmake] Consolidate CMake code related to image decoders.
+https://bugs.webkit.org/show_bug.cgi?id=154074
+
+Reviewed by Alex Christensen.
+
+Common image decoder sources, includes and libs are moved to
+platform/ImageDecoders.cmake.
+
+Also, added include directories of libjpeg and libpng to
+WebCore_SYSTEM_INCLUDE_DIRECTORIES.
+
+No new tests needed.
+
+* CMakeLists.txt: Moved common include paths to ImageDecoders.cmake.
+* PlatformEfl.cmake: Moved common sources and libs to ImageDecoders.cmake.
+* PlatformGTK.cmake: Ditto.
+* PlatformWinCairo.cmake: Moved common sources to ImageDecoders.cmake.
+* platform/ImageDecoders.cmake: Added.
+
 2016-02-10  Myles C. Maxfield  
 
 CSSSegmentedFontFace does not need to be reference counted


Modified: trunk/Source/WebCore/PlatformEfl.cmake (196393 => 196394)

--- trunk/Source/WebCore/PlatformEfl.cmake	2016-02-10 21:57:53 UTC (rev 196393)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2016-02-10 22:01:18 UTC (rev 196394)
@@ -1,3 +1,5 @@
+include(platform/ImageDecoders.cmake)
+
 list(APPEND WebCore_INCLUDE_DIRECTORIES
 "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}"
 "${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/inspector"
@@ -226,24 +228,8 @@
 
 platform/image-encoders/JPEGImageEncoder.cpp
 
-platform/image-decoders/ImageDecoder.cpp
-
-platform/image-decoders/bmp/BMPImageDecoder.cpp
-platform/image-decoders/bmp/BMPImageReader.cpp
-
 platform/image-decoders/cairo/ImageDecoderCairo.cpp
 
-platform/image-decoders/gif/GIFImageDecoder.cpp
-platform/image-decoders/gif/GIFImageReader.cpp
-
-platform/image-decoders/ico/ICOImageDecoder.cpp
-
-platform/image-decoders/jpeg/JPEGImageDecoder.cpp
-
-platform/image-decoders/png/PNGImageDecoder.cpp
-
-platform/image-decoders/webp/WEBPImageDecoder.cpp
-
 platform/linux/GamepadDeviceLinux.cpp
 platform/linux/MemoryPressureHandlerLinux.cpp
 
@@ -344,14 +330,11 @@
 ${GLIB_GOBJECT_LIBRARIES}
 ${GLIB_LIBRARIES}
 ${HARFBUZZ_LIBRARIES}
-${JPEG_LIBRARIES}
 ${LIBSOUP_LIBRARIES}
 ${LIBXML2_LIBRARIES}
 ${LIBXSLT_LIBRARIES}
 ${HYPHEN_LIBRARIES}
-${PNG_LIBRARIES}
 ${SQLITE_LIBRARIES}
-${WEBP_LIBRARIES}
 ${X11_X11_LIB}
 ${ZLIB_LIBRARIES}
 )
@@ -374,7 +357,6 @@
 ${LIBXML2_INCLUDE_DIR}
 ${LIBXSLT_INCLUDE_DIR}
 ${SQLITE_INCLUDE_DIR}
-${WEBP_INCLUDE_DIRS}
 ${GLIB_INCLUDE_DIRS}
 ${LIBSOUP_INCLUDE_DIRS}
 ${ZLIB_INCLUDE_DIRS}


Modified: trunk/Source/WebCore/PlatformGTK.cmake (196393 => 196394)

--- trunk/Source/WebCore/PlatformGTK.cmake	2016-02-10 21:57:53 UTC (rev 196393)
+++ 

[webkit-changes] [196395] trunk/Source/WebKit/mac

[mark . lam]

Title: [196395] trunk/Source/WebKit/mac








Revision 196395
Author mark@apple.com
Date 2016-02-10 14:16:58 -0800 (Wed, 10 Feb 2016)


Log Message
WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture: should assert that it is being called from the "main" thread.
https://bugs.webkit.org/show_bug.cgi?id=154059

Reviewed by Geoffrey Garen.

This makes it so that misbehaving clients which call it (indirectly) from another
thread (not the main thread) will fail faster.  Otherwise, we get potential
memory corruption that results in strange crashes elsewhere later.

* WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebFrame.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (196394 => 196395)

--- trunk/Source/WebKit/mac/ChangeLog	2016-02-10 22:01:18 UTC (rev 196394)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-02-10 22:16:58 UTC (rev 196395)
@@ -1,3 +1,17 @@
+2016-02-10  Mark Lam  
+
+WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture: should assert that it is being called from the "main" thread.
+https://bugs.webkit.org/show_bug.cgi?id=154059
+
+Reviewed by Geoffrey Garen.
+
+This makes it so that misbehaving clients which call it (indirectly) from another
+thread (not the main thread) will fail faster.  Otherwise, we get potential
+memory corruption that results in strange crashes elsewhere later.
+
+* WebView/WebFrame.mm:
+(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
+
 2016-02-04  Jer Noble  
 
 [Mac] Adopt NSURLSession properties in AVAssetResourceLoader


Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (196394 => 196395)

--- trunk/Source/WebKit/mac/WebView/WebFrame.mm	2016-02-10 22:01:18 UTC (rev 196394)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm	2016-02-10 22:16:58 UTC (rev 196395)
@@ -670,6 +670,8 @@
 if (!string)
 return @"";
 
+RELEASE_ASSERT(isMainThread());
+
 ASSERT(_private->coreFrame->document());
 RetainPtr protect(self); // Executing arbitrary _javascript_ can destroy the frame.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196393] trunk/Source/WebCore

[mmaxfield]

Title: [196393] trunk/Source/WebCore








Revision 196393
Author mmaxfi...@apple.com
Date 2016-02-10 13:57:53 -0800 (Wed, 10 Feb 2016)


Log Message
CSSSegmentedFontFace does not need to be reference counted
https://bugs.webkit.org/show_bug.cgi?id=154083

Reviewed by Antti Koivisto.

...There is only ever a single reference to one.

No new tests because there is no behavior change.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
* css/CSSFontSelector.h:
* css/CSSSegmentedFontFace.h:
(WebCore::CSSSegmentedFontFace::create): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontSelector.cpp
trunk/Source/WebCore/platform/graphics/FontCache.cpp
trunk/Source/WebCore/platform/graphics/FontCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (196392 => 196393)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 21:51:18 UTC (rev 196392)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 21:57:53 UTC (rev 196393)
@@ -1,3 +1,39 @@
+2016-02-10  Myles C. Maxfield  
+
+CSSSegmentedFontFace does not need to be reference counted
+https://bugs.webkit.org/show_bug.cgi?id=154083
+
+Reviewed by Antti Koivisto.
+
+...There is only ever a single reference to one.
+
+No new tests because there is no behavior change.
+
+* css/CSSFontSelector.cpp:
+(WebCore::CSSFontSelector::getFontFace):
+* css/CSSFontSelector.h:
+* css/CSSSegmentedFontFace.h:
+(WebCore::CSSSegmentedFontFace::create): Deleted.
+
+2016-02-10  Myles C. Maxfield  
+
+FontCache's clients should use references instead of pointers
+https://bugs.webkit.org/show_bug.cgi?id=154085
+
+Reviewed by Antti Koivisto.
+
+They are never null.
+
+No new tests because there is no behavior change.
+
+* css/CSSFontSelector.cpp:
+(WebCore::CSSFontSelector::CSSFontSelector):
+(WebCore::CSSFontSelector::~CSSFontSelector):
+* platform/graphics/FontCache.cpp:
+(WebCore::FontCache::addClient):
+(WebCore::FontCache::removeClient):
+* platform/graphics/FontCache.h:
+
 2016-02-10  Chris Dumez  
 
 [Web IDL] interface objects should be Function objects


Modified: trunk/Source/WebCore/css/CSSFontSelector.cpp (196392 => 196393)

--- trunk/Source/WebCore/css/CSSFontSelector.cpp	2016-02-10 21:51:18 UTC (rev 196392)
+++ trunk/Source/WebCore/css/CSSFontSelector.cpp	2016-02-10 21:57:53 UTC (rev 196393)
@@ -73,13 +73,13 @@
 // seem to be any such guarantee.
 
 ASSERT(m_document);
-FontCache::singleton().addClient(this);
+FontCache::singleton().addClient(*this);
 }
 
 CSSFontSelector::~CSSFontSelector()
 {
 clearDocument();
-FontCache::singleton().removeClient(this);
+FontCache::singleton().removeClient(*this);
 }
 
 bool CSSFontSelector::isEmpty() const


Modified: trunk/Source/WebCore/platform/graphics/FontCache.cpp (196392 => 196393)

--- trunk/Source/WebCore/platform/graphics/FontCache.cpp	2016-02-10 21:51:18 UTC (rev 196392)
+++ trunk/Source/WebCore/platform/graphics/FontCache.cpp	2016-02-10 21:57:53 UTC (rev 196393)
@@ -485,21 +485,21 @@
 
 static HashSet* gClients;
 
-void FontCache::addClient(FontSelector* client)
+void FontCache::addClient(FontSelector& client)
 {
 if (!gClients)
 gClients = new HashSet;
 
-ASSERT(!gClients->contains(client));
-gClients->add(client);
+ASSERT(!gClients->contains());
+gClients->add();
 }
 
-void FontCache::removeClient(FontSelector* client)
+void FontCache::removeClient(FontSelector& client)
 {
 ASSERT(gClients);
-ASSERT(gClients->contains(client));
+ASSERT(gClients->contains());
 
-gClients->remove(client);
+gClients->remove();
 }
 
 static unsigned short gGeneration = 0;


Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (196392 => 196393)

--- trunk/Source/WebCore/platform/graphics/FontCache.h	2016-02-10 21:51:18 UTC (rev 196392)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h	2016-02-10 21:57:53 UTC (rev 196393)
@@ -193,8 +193,8 @@
 WEBCORE_EXPORT Ref fontForPlatformData(const FontPlatformData&);
 RefPtr similarFont(const FontDescription&, const AtomicString& family);
 
-void addClient(FontSelector*);
-void removeClient(FontSelector*);
+void addClient(FontSelector&);
+void removeClient(FontSelector&);
 
 unsigned short generation();
 WEBCORE_EXPORT void invalidate();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196396] trunk/Source/WebCore

[ryanhaddad]

Title: [196396] trunk/Source/WebCore








Revision 196396
Author ryanhad...@apple.com
Date 2016-02-10 14:50:12 -0800 (Wed, 10 Feb 2016)


Log Message
Rebaselining bindings tests

Unreviewed test gardening.

No new tests needed.

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
* bindings/scripts/test/JS/JSTestCallback.cpp:
* bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
* bindings/scripts/test/JS/JSTestException.cpp:
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
* bindings/scripts/test/JS/JSattribute.cpp:
* bindings/scripts/test/JS/JSreadonly.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (196395 => 196396)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 22:16:58 UTC (rev 196395)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 22:50:12 UTC (rev 196396)
@@ -1,3 +1,33 @@
+2016-02-10  Ryan Haddad  
+
+Rebaselining bindings tests
+
+Unreviewed test gardening.
+
+No new tests needed.
+
+* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
+* bindings/scripts/test/JS/JSTestCallback.cpp:
+* bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
+* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
+* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
+* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+* bindings/scripts/test/JS/JSTestEventTarget.cpp:
+* bindings/scripts/test/JS/JSTestException.cpp:
+* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
+* bindings/scripts/test/JS/JSTestInterface.cpp:
+* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
+* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
+* bindings/scripts/test/JS/JSTestObj.cpp:
+* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
+* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
+* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
+* bindings/scripts/test/JS/JSTestTypedefs.cpp:
+* bindings/scripts/test/JS/JSattribute.cpp:
+* bindings/scripts/test/JS/JSreadonly.cpp:
+
 2016-02-10  Konstantin Tokarev  
 
 [cmake] Consolidate CMake code related to image decoders.


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp (196395 => 196396)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp	

[webkit-changes] [196397] trunk/Source/WTF

[mark . lam]

Title: [196397] trunk/Source/WTF








Revision 196397
Author mark@apple.com
Date 2016-02-10 15:02:24 -0800 (Wed, 10 Feb 2016)


Log Message
Changed WTFCrash to not trash the crash site register state.
https://bugs.webkit.org/show_bug.cgi?id=153996

Reviewed by Geoffrey Garen.

When doing post-mortem crash site analysis using data from crash reports, it is
immensely valuable to be able to infer the crashing program's state from the
register values at crash time.  However, for RELEASE_ASSERT failures, we crash
using WTFCrash(), and WTFCrash() is currently implemented as a function call
that, in turn, calls a lot of other functions to do crash handling before
actually crashing.  As a result, the register values captured in the crash
reports are not likely to still contain the values used by the caller function
that failed the RELEASE_ASSERT.

This patch aims to remedy this issue for non-debug builds on OS(DARWIN) ports.
It does so by changing WTFCrash() into an inlined function that has an inlined
asm statement to issues the CPU specific breakpoint trap instruction.  As a
result, for non-debug OS(DARWIN) builds, crashes due to failed RELEASE_ASSERTs
will now show up in crash reports as crashing due to EXC_BREAKPOINT (SIGTRAP)
instead of a EXC_BAD_ACCESS (SIGSEGV) on address 0xbbadbeef.

For debug and non-DARWIN builds, WTFCrash() behavior currently remains unchanged.

* wtf/Assertions.cpp:
* wtf/Assertions.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.cpp
trunk/Source/WTF/wtf/Assertions.h




Diff

Modified: trunk/Source/WTF/ChangeLog (196396 => 196397)

--- trunk/Source/WTF/ChangeLog	2016-02-10 22:50:12 UTC (rev 196396)
+++ trunk/Source/WTF/ChangeLog	2016-02-10 23:02:24 UTC (rev 196397)
@@ -1,3 +1,31 @@
+2016-02-09  Mark Lam  
+
+Changed WTFCrash to not trash the crash site register state.
+https://bugs.webkit.org/show_bug.cgi?id=153996
+
+Reviewed by Geoffrey Garen.
+
+When doing post-mortem crash site analysis using data from crash reports, it is
+immensely valuable to be able to infer the crashing program's state from the
+register values at crash time.  However, for RELEASE_ASSERT failures, we crash
+using WTFCrash(), and WTFCrash() is currently implemented as a function call
+that, in turn, calls a lot of other functions to do crash handling before
+actually crashing.  As a result, the register values captured in the crash
+reports are not likely to still contain the values used by the caller function
+that failed the RELEASE_ASSERT.
+
+This patch aims to remedy this issue for non-debug builds on OS(DARWIN) ports.
+It does so by changing WTFCrash() into an inlined function that has an inlined
+asm statement to issues the CPU specific breakpoint trap instruction.  As a
+result, for non-debug OS(DARWIN) builds, crashes due to failed RELEASE_ASSERTs
+will now show up in crash reports as crashing due to EXC_BREAKPOINT (SIGTRAP)
+instead of a EXC_BAD_ACCESS (SIGSEGV) on address 0xbbadbeef.
+
+For debug and non-DARWIN builds, WTFCrash() behavior currently remains unchanged.
+
+* wtf/Assertions.cpp:
+* wtf/Assertions.h:
+
 2016-02-09  Csaba Osztrogonác  
 
 [GTK][EFL] Fix several build configuration related to SamplingProfiler after r196245


Modified: trunk/Source/WTF/wtf/Assertions.cpp (196396 => 196397)

--- trunk/Source/WTF/wtf/Assertions.cpp	2016-02-10 22:50:12 UTC (rev 196396)
+++ trunk/Source/WTF/wtf/Assertions.cpp	2016-02-10 23:02:24 UTC (rev 196397)
@@ -312,6 +312,7 @@
 globalHook = function;
 }
 
+#if !defined(NDEBUG) || !OS(DARWIN)
 void WTFCrash()
 {
 if (globalHook)
@@ -326,6 +327,7 @@
 ((void(*)())0)();
 #endif
 }
+#endif // !defined(NDEBUG) || !OS(DARWIN)
 
 void WTFCrashWithSecurityImplication()
 {


Modified: trunk/Source/WTF/wtf/Assertions.h (196396 => 196397)

--- trunk/Source/WTF/wtf/Assertions.h	2016-02-10 22:50:12 UTC (rev 196396)
+++ trunk/Source/WTF/wtf/Assertions.h	2016-02-10 23:02:24 UTC (rev 196397)
@@ -162,7 +162,27 @@
 #ifdef __cplusplus
 extern "C" {
 #endif
-WTF_EXPORT_PRIVATE NO_RETURN_DUE_TO_CRASH void WTFCrash();
+#if defined(NDEBUG) && OS(DARWIN)
+ALWAYS_INLINE NO_RETURN_DUE_TO_CRASH void WTFCrash()
+{
+// Crash with a SIGTRAP i.e EXC_BREAKPOINT.
+// We are not using __builtin_trap because it is only guaranteed to abort, but not necessarily
+// trigger a SIGTRAP. Instead, we use inline asm to ensure that we trigger the SIGTRAP.
+#if CPU(X86_64) || CPU(X86)
+asm volatile ("int3");
+#elif CPU(ARM_THUMB2)
+asm volatile ("bkpt #0");
+#elif CPU(ARM64)
+asm volatile ("brk #0");
+#else
+#error "Unsupported CPU".
+#endif
+__builtin_unreachable();
+}
+#else
+WTF_EXPORT_PRIVATE NO_RETURN_DUE_TO_CRASH void WTFCrash();
+#endif
+
 #ifdef __cplusplus
 }
 #endif

[webkit-changes] [196403] trunk/Tools

[jmarcell]

Title: [196403] trunk/Tools








Revision 196403
Author jmarc...@apple.com
Date 2016-02-10 16:29:26 -0800 (Wed, 10 Feb 2016)


Log Message
Remove calls to parseInt in order to work with non-integer revisions
https://bugs.webkit.org/show_bug.cgi?id=153820

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
revisions.
(BuildbotIteration.prototype._parseData): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.update): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
(MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
(MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (196402 => 196403)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js	2016-02-11 00:29:26 UTC (rev 196403)
@@ -214,17 +214,14 @@
 fallbackKey = null;
 }
 var revision = parseRevisionProperty(revisionProperty, key, fallbackKey);
-if (repository.isSVN)
-this.revision[repositoryName] = parseInt(revision);
-else
-this.revision[repositoryName] = revision;
+this.revision[repositoryName] = revision;
 }
 
 function sourceStampChanges(sourceStamp) {
 var result = [];
 var changes = sourceStamp.changes;
 for (var i = 0; i < changes.length; ++i) {
-var change = { revisionNumber: parseInt(changes[i].revision, 10) }
+var change = { revisionNumber: changes[i].revision }
 if (changes[i].repository)
 change.repository = changes[i].repository;
 if (changes[i].branch)


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (196402 => 196403)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js	2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js	2016-02-11 00:29:26 UTC (rev 196403)
@@ -209,7 +209,7 @@
 for (var i = data.cachedBuilds.length - 1; i >= 0; --i) {
 var iteration = this._knownIterations[data.cachedBuilds[i]];
 if (!iteration) {
-iteration = new BuildbotIteration(this, parseInt(data.cachedBuilds[i], 10), !(data.cachedBuilds[i] in currentBuilds));
+iteration = new BuildbotIteration(this, data.cachedBuilds[i], !(data.cachedBuilds[i] in currentBuilds));
 newIterations.push(iteration);
 this.iterations.push(iteration);
 this._knownIterations[iteration.id] = iteration;


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js (196402 => 196403)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js	2016-02-11 00:29:24 UTC (rev 196402)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js	2016-02-11 00:29:26 UTC (rev 196403)
@@ -44,7 +44,7 @@
 {
 return {
 revision: {
-"openSource": 33020
+"openSource": "33020"
 }
 };
 }


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js (196402 => 196403)

--- 

[webkit-changes] [196402] trunk/Tools

[jmarcell]

Title: [196402] trunk/Tools








Revision 196402
Author jmarc...@apple.com
Date 2016-02-10 16:29:24 -0800 (Wed, 10 Feb 2016)


Log Message
Teach dashboard code to compare non-integer revisions
https://bugs.webkit.org/show_bug.cgi?id=152345

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
revisions. Also uses new Trac.nextRevision method to calculate a revision range.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
methods.
(Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
(Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
(Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
(Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
(Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (196401 => 196402)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js	2016-02-11 00:10:52 UTC (rev 196401)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js	2016-02-11 00:29:24 UTC (rev 196402)
@@ -285,9 +285,15 @@
 var sortedRepositories = Dashboard.sortedRepositories;
 for (var i = 0; i < sortedRepositories.length; ++i) {
 var repositoryName = sortedRepositories[i].name;
-var result = b.revision[repositoryName] - a.revision[repositoryName];
-if (result)
-return result;
+var trac = sortedRepositories[i].trac;
+console.assert(trac);
+var indexA = trac.indexOfRevision(a.revision[repositoryName]);
+var indexB = trac.indexOfRevision(b.revision[repositoryName]);
+if (indexA !== -1 && indexB !== -1) {
+var result = indexB - indexA;
+if (result)
+return result;
+}
 }
 
 return 0;


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (196401 => 196402)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js	2016-02-11 00:10:52 UTC (rev 196401)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js	2016-02-11 00:29:24 UTC (rev 196402)
@@ -94,12 +94,12 @@
 continue;
 if (!trac)
 continue;
-if (!trac.latestRecordedRevisionNumber || trac.oldestRecordedRevisionNumber > latestProductiveRevisionNumber) {
+if (!trac.latestRecordedRevisionNumber || trac.indexOfRevision(trac.oldestRecordedRevisionNumber) > trac.indexOfRevision(latestProductiveRevisionNumber)) {
 trac.loadMoreHistoricalData();
 return;
 }
 
-totalRevisionsBehind += trac.commitsOnBranch(branch.name, function(commit) { return commit.revisionNumber > latestProductiveRevisionNumber; }).length;
+totalRevisionsBehind += trac.commitsOnBranchLaterThanRevision(branch.name, latestProductiveRevisionNumber).length;
 }
 
 if (!totalRevisionsBehind)
@@ -140,11 +140,11 @@
 return result;
 }
 
-console.assert(trac.oldestRecordedRevisionNumber <= firstRevisionNumber);
+

[webkit-changes] [196405] trunk/LayoutTests

[ryanhaddad]

Title: [196405] trunk/LayoutTests








Revision 196405
Author ryanhad...@apple.com
Date 2016-02-10 16:44:18 -0800 (Wed, 10 Feb 2016)


Log Message
Adding an ios-simulator expectation for fast/dom/event-handler-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=153763

Unreviewed test gardening.

* platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (196404 => 196405)

--- trunk/LayoutTests/ChangeLog	2016-02-11 00:32:18 UTC (rev 196404)
+++ trunk/LayoutTests/ChangeLog	2016-02-11 00:44:18 UTC (rev 196405)
@@ -1,3 +1,12 @@
+2016-02-10  Ryan Haddad  
+
+Adding an ios-simulator expectation for fast/dom/event-handler-attributes.html
+https://bugs.webkit.org/show_bug.cgi?id=153763
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt: Added.
+
 2016-02-10  Eric Carlson  
 
 Update "manual" caption track logic


Added: trunk/LayoutTests/platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt (0 => 196405)

--- trunk/LayoutTests/platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt	2016-02-11 00:44:18 UTC (rev 196405)
@@ -0,0 +1,948 @@
+Test which event listeners are set up by event handler attributes (the ones with names like onclick).
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Event names we expect to be able to set on the window object
+
+PASS testScriptAttribute(window, "abort") is "window"
+PASS testScriptAttribute(window, "animationend") is "window"
+PASS testScriptAttribute(window, "animationiteration") is "window"
+PASS testScriptAttribute(window, "animationstart") is "window"
+PASS testScriptAttribute(window, "beforeunload") is "window"
+PASS testScriptAttribute(window, "blur") is "window"
+PASS testScriptAttribute(window, "canplay") is "window"
+PASS testScriptAttribute(window, "canplaythrough") is "window"
+PASS testScriptAttribute(window, "change") is "window"
+PASS testScriptAttribute(window, "click") is "window"
+PASS testScriptAttribute(window, "contextmenu") is "window"
+PASS testScriptAttribute(window, "dblclick") is "window"
+PASS testScriptAttribute(window, "drag") is "window"
+PASS testScriptAttribute(window, "dragend") is "window"
+PASS testScriptAttribute(window, "dragenter") is "window"
+PASS testScriptAttribute(window, "dragleave") is "window"
+PASS testScriptAttribute(window, "dragover") is "window"
+PASS testScriptAttribute(window, "dragstart") is "window"
+PASS testScriptAttribute(window, "drop") is "window"
+PASS testScriptAttribute(window, "durationchange") is "window"
+PASS testScriptAttribute(window, "emptied") is "window"
+PASS testScriptAttribute(window, "ended") is "window"
+PASS testScriptAttribute(window, "error") is "window"
+PASS testScriptAttribute(window, "focus") is "window"
+PASS testScriptAttribute(window, "hashchange") is "window"
+PASS testScriptAttribute(window, "input") is "window"
+PASS testScriptAttribute(window, "invalid") is "window"
+PASS testScriptAttribute(window, "keydown") is "window"
+PASS testScriptAttribute(window, "keypress") is "window"
+PASS testScriptAttribute(window, "keyup") is "window"
+PASS testScriptAttribute(window, "load") is "window"
+PASS testScriptAttribute(window, "loadeddata") is "window"
+PASS testScriptAttribute(window, "loadedmetadata") is "window"
+PASS testScriptAttribute(window, "loadstart") is "window"
+PASS testScriptAttribute(window, "message") is "window"
+PASS testScriptAttribute(window, "mousedown") is "window"
+PASS testScriptAttribute(window, "mouseenter") is "window"
+PASS testScriptAttribute(window, "mouseleave") is "window"
+PASS testScriptAttribute(window, "mousemove") is "window"
+PASS testScriptAttribute(window, "mouseout") is "window"
+PASS testScriptAttribute(window, "mouseover") is "window"
+PASS testScriptAttribute(window, "mouseup") is "window"
+PASS testScriptAttribute(window, "mousewheel") is "window"
+PASS testScriptAttribute(window, "offline") is "window"
+PASS testScriptAttribute(window, "online") is "window"
+PASS testScriptAttribute(window, "pagehide") is "window"
+PASS testScriptAttribute(window, "pageshow") is "window"
+PASS testScriptAttribute(window, "pause") is "window"
+PASS testScriptAttribute(window, "play") is "window"
+PASS testScriptAttribute(window, "playing") is "window"
+PASS testScriptAttribute(window, "popstate") is "window"
+PASS testScriptAttribute(window, "progress") is "window"
+PASS testScriptAttribute(window, "ratechange") is "window"
+PASS testScriptAttribute(window, "reset") is "window"
+PASS testScriptAttribute(window, 

[webkit-changes] [196404] trunk/Source/WebInspectorUI

[mattbaker]

Title: [196404] trunk/Source/WebInspectorUI








Revision 196404
Author mattba...@apple.com
Date 2016-02-10 16:32:18 -0800 (Wed, 10 Feb 2016)


Log Message
Web Inspector: Switching actions in Edit Breakpoint popover causes a jerk
https://bugs.webkit.org/show_bug.cgi?id=154093


Reviewed by Timothy Hatcher.

Adjusted CodeMirror eval editor styles to match vanilla input field.

* UserInterface/Views/BreakpointActionView.css:
(.breakpoint-action-eval-editor):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (196403 => 196404)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-11 00:29:26 UTC (rev 196403)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-11 00:32:18 UTC (rev 196404)
@@ -1,3 +1,16 @@
+2016-02-10  Matt Baker  
+
+Web Inspector: Switching actions in Edit Breakpoint popover causes a jerk
+https://bugs.webkit.org/show_bug.cgi?id=154093
+
+
+Reviewed by Timothy Hatcher.
+
+Adjusted CodeMirror eval editor styles to match vanilla input field.
+
+* UserInterface/Views/BreakpointActionView.css:
+(.breakpoint-action-eval-editor):
+
 2016-02-09  Joseph Pecoraro  
 
 Regression: Web Inspector: Sometimes in Elements panel two elements showed as selected at the same time


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css (196403 => 196404)

--- trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css	2016-02-11 00:29:26 UTC (rev 196403)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css	2016-02-11 00:32:18 UTC (rev 196404)
@@ -68,7 +68,8 @@
 }
 
 .breakpoint-action-eval-editor {
-padding: 4px 0 2px 0;
+margin: 2px 0;
+padding: 2px 0 1px 0;
 -webkit-appearance: textfield;
 border: 1px solid hsl(0, 0%, 78%);
 background: white;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196415] trunk/PerformanceTests

[jonlee]

Title: [196415] trunk/PerformanceTests








Revision 196415
Author jon...@apple.com
Date 2016-02-10 23:42:00 -0800 (Wed, 10 Feb 2016)


Log Message
Add new benchmark tests.
https://bugs.webkit.org/show_bug.cgi?id=154063

Provisionally reviewed by Said Abou-Hallawa.

Add tests for get/put image data, filters, opacity, and css transforms.

* Animometer/resources/runner/benchmark-runner.js:
(_runBenchmarkAndRecordResults): Update the body background color to match that of
the stage.
(this._runNextIteration): Clear the background color style for the results page.
* Animometer/resources/runner/tests.js:
* Animometer/tests/master/focus.html: Added.
* Animometer/tests/master/image-data.html: Added.
* Animometer/tests/master/multiply.html: Added.
* Animometer/tests/master/resources/focus.js: Added.
* Animometer/tests/master/resources/image-data.js: Added.
* Animometer/tests/master/resources/multiply.js: Added.
* Animometer/tests/master/resources/stage.css: Move common styles out.
* Animometer/tests/resources/main.js: Update Stage.randomBool to use Math.random.
Add Stage.randomSign for randomly setting a direction. Add the notion of the
current timestamp of the test to Benchmark, since some animations cycle through
colors and rely on an incremental counter like the time.

Modified Paths

trunk/PerformanceTests/Animometer/resources/extensions.js
trunk/PerformanceTests/Animometer/resources/runner/benchmark-runner.js
trunk/PerformanceTests/Animometer/resources/runner/tests.js
trunk/PerformanceTests/Animometer/tests/master/resources/stage.css
trunk/PerformanceTests/Animometer/tests/resources/main.js
trunk/PerformanceTests/ChangeLog


Added Paths

trunk/PerformanceTests/Animometer/tests/master/focus.html
trunk/PerformanceTests/Animometer/tests/master/image-data.html
trunk/PerformanceTests/Animometer/tests/master/multiply.html
trunk/PerformanceTests/Animometer/tests/master/resources/focus.js
trunk/PerformanceTests/Animometer/tests/master/resources/image-data.js
trunk/PerformanceTests/Animometer/tests/master/resources/multiply.js




Diff

Modified: trunk/PerformanceTests/Animometer/resources/extensions.js (196414 => 196415)

--- trunk/PerformanceTests/Animometer/resources/extensions.js	2016-02-11 04:06:37 UTC (rev 196414)
+++ trunk/PerformanceTests/Animometer/resources/extensions.js	2016-02-11 07:42:00 UTC (rev 196415)
@@ -83,21 +83,21 @@
 parentElement.appendChild(element);
 return element;
 },
-
+
 browserPrefix: function()
 {
 // Get the HTML element's CSSStyleDeclaration
 var styles = window.getComputedStyle(document.documentElement, '');
-
+
 // Convert the styles list to an array
 var stylesArray = Array.prototype.slice.call(styles);
-
+
 // Concatenate all the styles in one big string
 var stylesString = stylesArray.join('');
 
 // Search the styles string for a known prefix type, settle on Opera if none is found.
 var prefixes = stylesString.match(/-(moz|webkit|ms)-/) || (styles.OLink === '' && ['', 'o']);
-
+
 // prefixes has two elements; e.g. for webkit it has ['-webkit-', 'webkit'];
 var prefix = prefixes[1];
 
@@ -112,10 +112,20 @@
 js: prefix[0].toUpperCase() + prefix.substr(1)
 };
 },
-
+
 setElementPrefixedProperty: function(element, property, value)
 {
 element.style[property] = element.style[this.browserPrefix().js + property[0].toUpperCase() + property.substr(1)] = value;
+},
+
+progressValue: function(value, min, max)
+{
+return (value - min) / (max - min);
+},
+
+lerp: function(value, min, max)
+{
+return min + (max - min) * value;
 }
 };
 


Modified: trunk/PerformanceTests/Animometer/resources/runner/benchmark-runner.js (196414 => 196415)

--- trunk/PerformanceTests/Animometer/resources/runner/benchmark-runner.js	2016-02-11 04:06:37 UTC (rev 196414)
+++ trunk/PerformanceTests/Animometer/resources/runner/benchmark-runner.js	2016-02-11 07:42:00 UTC (rev 196415)
@@ -94,6 +94,7 @@
 Utilities.extendObject(options, contentWindow.Utilities.parseParameters());
 
 var benchmark = new contentWindow.benchmarkClass(options);
+document.body.style.backgroundColor = benchmark.backgroundColor();
 benchmark.run().then(function(results) {
 var suiteResults = self._suitesResults[suite.name] || {};
 suiteResults[test.name] = results;
@@ -153,8 +154,10 @@
 currentIteration++;
 if (currentIteration < self._client.iterationCount)
 self.runAllSteps();
-else if (this._client && this._client.didFinishLastIteration)
+else if (this._client && this._client.didFinishLastIteration) {
+document.body.style.backgroundColor = "";
 self._client.didFinishLastIteration();
+}
 }
 
 if (this._client && 

[webkit-changes] [196414] trunk/Source/JavaScriptCore

[keith_miller]

Title: [196414] trunk/Source/_javascript_Core








Revision 196414
Author keith_mil...@apple.com
Date 2016-02-10 20:06:37 -0800 (Wed, 10 Feb 2016)


Log Message
Symbol.species accessors on builtin constructors should be configurable
https://bugs.webkit.org/show_bug.cgi?id=154097

Reviewed by Benjamin Poulain.

We did not have the Symbol.species accessors on our builtin constructors
marked as configurable. This does not accurately follow the ES6 spec as
the ES6 spec states that all default accessors on builtins should be
configurable. This means that we need an additional watchpoint on
ArrayConstructor to make sure that no users re-configures Symbol.species.

* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::finishCreation):
* runtime/ArrayPrototype.cpp:
(JSC::speciesConstructArray):
(JSC::ArrayPrototype::setConstructor):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::didChangeConstructorOrSpeciesProperties):
(JSC::ArrayPrototype::didChangeConstructorProperty): Deleted.
* runtime/JSArrayBufferConstructor.cpp:
(JSC::JSArrayBufferConstructor::finishCreation):
* runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::finishCreation):
* runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
* runtime/MapConstructor.cpp:
(JSC::MapConstructor::finishCreation):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::finishCreation):
* runtime/SetConstructor.cpp:
(JSC::SetConstructor::finishCreation):
* tests/stress/array-species-config-array-constructor.js: Added.
(A):
* tests/stress/symbol-species.js:
(testSymbolSpeciesOnConstructor):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayConstructor.cpp
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
trunk/Source/_javascript_Core/runtime/ArrayPrototype.h
trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.cpp
trunk/Source/_javascript_Core/runtime/JSPromiseConstructor.cpp
trunk/Source/_javascript_Core/runtime/JSTypedArrayViewConstructor.cpp
trunk/Source/_javascript_Core/runtime/MapConstructor.cpp
trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp
trunk/Source/_javascript_Core/runtime/SetConstructor.cpp
trunk/Source/_javascript_Core/tests/stress/symbol-species.js


Added Paths

trunk/Source/_javascript_Core/tests/stress/array-species-config-array-constructor.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (196413 => 196414)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-11 03:20:28 UTC (rev 196413)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-11 04:06:37 UTC (rev 196414)
@@ -1,3 +1,42 @@
+2016-02-10  Keith Miller  
+
+Symbol.species accessors on builtin constructors should be configurable
+https://bugs.webkit.org/show_bug.cgi?id=154097
+
+Reviewed by Benjamin Poulain.
+
+We did not have the Symbol.species accessors on our builtin constructors
+marked as configurable. This does not accurately follow the ES6 spec as
+the ES6 spec states that all default accessors on builtins should be
+configurable. This means that we need an additional watchpoint on
+ArrayConstructor to make sure that no users re-configures Symbol.species.
+
+* runtime/ArrayConstructor.cpp:
+(JSC::ArrayConstructor::finishCreation):
+* runtime/ArrayPrototype.cpp:
+(JSC::speciesConstructArray):
+(JSC::ArrayPrototype::setConstructor):
+(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):
+* runtime/ArrayPrototype.h:
+(JSC::ArrayPrototype::didChangeConstructorOrSpeciesProperties):
+(JSC::ArrayPrototype::didChangeConstructorProperty): Deleted.
+* runtime/JSArrayBufferConstructor.cpp:
+(JSC::JSArrayBufferConstructor::finishCreation):
+* runtime/JSPromiseConstructor.cpp:
+(JSC::JSPromiseConstructor::finishCreation):
+* runtime/JSTypedArrayViewConstructor.cpp:
+(JSC::JSTypedArrayViewConstructor::finishCreation):
+* runtime/MapConstructor.cpp:
+(JSC::MapConstructor::finishCreation):
+* runtime/RegExpConstructor.cpp:
+(JSC::RegExpConstructor::finishCreation):
+* runtime/SetConstructor.cpp:
+(JSC::SetConstructor::finishCreation):
+* tests/stress/array-species-config-array-constructor.js: Added.
+(A):
+* tests/stress/symbol-species.js:
+(testSymbolSpeciesOnConstructor):
+
 2016-02-10  Benjamin Poulain  
 
 [JSC] The destination of Sqrt should be Def, not UseDef


Modified: trunk/Source/_javascript_Core/runtime/ArrayConstructor.cpp (196413 => 196414)

--- trunk/Source/_javascript_Core/runtime/ArrayConstructor.cpp	2016-02-11 03:20:28 UTC (rev 196413)
+++ trunk/Source/_javascript_Core/runtime/ArrayConstructor.cpp	2016-02-11 04:06:37 UTC (rev 196414)
@@ -67,7 

[webkit-changes] [196365] trunk/Source/WebCore

[ossy]

Title: [196365] trunk/Source/WebCore








Revision 196365
Author o...@webkit.org
Date 2016-02-10 02:28:23 -0800 (Wed, 10 Feb 2016)


Log Message
Fix the !(ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT)) after r196281
https://bugs.webkit.org/show_bug.cgi?id=154035

Reviewed by Antti Koivisto.

* dom/ComposedTreeIterator.h:
(WebCore::ComposedTreeIterator::Context::Context):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ComposedTreeIterator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (196364 => 196365)

--- trunk/Source/WebCore/ChangeLog	2016-02-10 06:58:44 UTC (rev 196364)
+++ trunk/Source/WebCore/ChangeLog	2016-02-10 10:28:23 UTC (rev 196365)
@@ -1,3 +1,13 @@
+2016-02-10  Csaba Osztrogonác  
+
+Fix the !(ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT)) after r196281
+https://bugs.webkit.org/show_bug.cgi?id=154035
+
+Reviewed by Antti Koivisto.
+
+* dom/ComposedTreeIterator.h:
+(WebCore::ComposedTreeIterator::Context::Context):
+
 2016-02-09  Carlos Garcia Campos  
 
 [GTK] Toggle buttons are blurry with GTK+ 3.19


Modified: trunk/Source/WebCore/dom/ComposedTreeIterator.h (196364 => 196365)

--- trunk/Source/WebCore/dom/ComposedTreeIterator.h	2016-02-10 06:58:44 UTC (rev 196364)
+++ trunk/Source/WebCore/dom/ComposedTreeIterator.h	2016-02-10 10:28:23 UTC (rev 196365)
@@ -71,8 +71,14 @@
 { }
 Context(ContainerNode& root, Node& node, size_t slotNodeIndex = notFound)
 : iterator(root, )
+#if ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT)
 , slotNodeIndex(slotNodeIndex)
 { }
+#else
+{
+UNUSED_PARAM(slotNodeIndex);
+}
+#endif
 
 ElementAndTextDescendantIterator iterator;
 #if ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196412] branches/safari-601-branch/Source

[bshafiei]

Title: [196412] branches/safari-601-branch/Source








Revision 196412
Author bshaf...@apple.com
Date 2016-02-10 19:20:28 -0800 (Wed, 10 Feb 2016)


Log Message
Versioning.

Modified Paths

branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig (196411 => 196412)

--- branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-11 02:21:42 UTC (rev 196411)
+++ branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 5;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig (196411 => 196412)

--- branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2016-02-11 02:21:42 UTC (rev 196411)
+++ branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 5;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (196411 => 196412)

--- branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-11 02:21:42 UTC (rev 196411)
+++ branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 5;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig (196411 => 196412)

--- branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-11 02:21:42 UTC (rev 196411)
+++ branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 5;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig (196411 => 196412)

--- branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-02-11 02:21:42 UTC (rev 196411)
+++ branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 5;
-TINY_VERSION = 16;
+TINY_VERSION = 17;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196413] branches/safari-601.1.46-branch/Source

[bshafiei]

Title: [196413] branches/safari-601.1.46-branch/Source








Revision 196413
Author bshaf...@apple.com
Date 2016-02-10 19:20:28 -0800 (Wed, 10 Feb 2016)


Log Message
Versioning.

Modified Paths

branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (196412 => 196413)

--- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196413)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 98;
+MICRO_VERSION = 99;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (196412 => 196413)

--- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
+++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196413)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 98;
+MICRO_VERSION = 99;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (196412 => 196413)

--- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
+++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196413)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 98;
+MICRO_VERSION = 99;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (196412 => 196413)

--- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
+++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196413)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 98;
+MICRO_VERSION = 99;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (196412 => 196413)

--- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196412)
+++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-02-11 03:20:28 UTC (rev 196413)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 98;
+MICRO_VERSION = 99;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196401] trunk

[eric . carlson]

Title: [196401] trunk








Revision 196401
Author eric.carl...@apple.com
Date 2016-02-10 16:10:52 -0800 (Wed, 10 Feb 2016)


Log Message
Update "manual" caption track logic
https://bugs.webkit.org/show_bug.cgi?id=154084


Reviewed by Dean Jackson.

No new tests, media/track/track-manual-mode.html was updated.

* English.lproj/Localizable.strings: Add new string.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addTextTrack): track.setManualSelectionMode is no more.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Never enable a track automatically when
  in manual selection mode.
(WebCore::HTMLMediaElement::captionPreferencesChanged):  track.setManualSelectionMode is no more.

* html/track/TextTrack.cpp:
(WebCore::TextTrack::containsOnlyForcedSubtitles): Return true for forced tracks.
(WebCore::TextTrack::kind): Deleted.
* html/track/TextTrack.h:

* html/track/TrackBase.h:
(WebCore::TrackBase::kind): De-virtualize, nobody overrides it.

* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::trackDisplayName): Include "forced" in the name of forced tracks.

* platform/LocalizedStrings.cpp:
(WebCore::forcedTrackMenuItemText): New.
* platform/LocalizedStrings.h:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-manual-mode-expected.txt
trunk/LayoutTests/media/track/track-manual-mode.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/track/TextTrack.cpp
trunk/Source/WebCore/html/track/TextTrack.h
trunk/Source/WebCore/html/track/TrackBase.h
trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/LocalizedStrings.h




Diff

Modified: trunk/LayoutTests/ChangeLog (196400 => 196401)

--- trunk/LayoutTests/ChangeLog	2016-02-11 00:03:11 UTC (rev 196400)
+++ trunk/LayoutTests/ChangeLog	2016-02-11 00:10:52 UTC (rev 196401)
@@ -1,3 +1,14 @@
+2016-02-10  Eric Carlson  
+
+Update "manual" caption track logic
+https://bugs.webkit.org/show_bug.cgi?id=154084
+
+
+Reviewed by Dean Jackson.
+
+* media/track/track-manual-mode-expected.txt:
+* media/track/track-manual-mode.html:
+
 2016-02-10  Ryan Haddad  
 
 Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after 196392


Modified: trunk/LayoutTests/media/track/track-manual-mode-expected.txt (196400 => 196401)

--- trunk/LayoutTests/media/track/track-manual-mode-expected.txt	2016-02-11 00:03:11 UTC (rev 196400)
+++ trunk/LayoutTests/media/track/track-manual-mode-expected.txt	2016-02-11 00:10:52 UTC (rev 196401)
@@ -6,19 +6,31 @@
 RUN(internals.setCaptionDisplayMode('manual'))
 EVENT(canplaythrough)
 
-** Forced tracks should be in .textTracks as well as in the menu,
-** but should be labeled as 'subtitles'
-
+** Forced tracks should be in .textTracks as well as in the menu
 EXPECTED (video.textTracks.length == '9') OK
 EXPECTED (trackMenuItems.length == '11') OK
 
+** 'forced' should be in the title of a forced track menu item
+Track menu:
+0: "Off", checked
+1: "Auto (Recommended)"
+2: "English Closed Captions CC"
+3: "English Subtitles"
+4: "English Subtitles Forced"
+5: "French Subtitles"
+6: "French Subtitles Forced"
+7: "German Subtitles"
+8: "German Subtitles Forced"
+9: "Spanish Subtitles"
+10: "Spanish Subtitles Forced"
+
 ** No track should be enabled by default
 EXPECTED (video.textTracks[0].language == 'en') OK
 EXPECTED (video.textTracks[0].kind == 'subtitles') OK
 EXPECTED (video.textTracks[0].mode == 'disabled') OK
 
 EXPECTED (video.textTracks[1].language == 'en') OK
-EXPECTED (video.textTracks[1].kind == 'subtitles') OK
+EXPECTED (video.textTracks[1].kind == 'forced') OK
 EXPECTED (video.textTracks[1].mode == 'disabled') OK
 
 EXPECTED (video.textTracks[2].language == 'fr') OK
@@ -26,7 +38,7 @@
 EXPECTED (video.textTracks[2].mode == 'disabled') OK
 
 EXPECTED (video.textTracks[3].language == 'fr') OK
-EXPECTED (video.textTracks[3].kind == 'subtitles') OK
+EXPECTED (video.textTracks[3].kind == 'forced') OK
 EXPECTED (video.textTracks[3].mode == 'disabled') OK
 
 EXPECTED (video.textTracks[4].language == 'es') OK
@@ -34,7 +46,7 @@
 EXPECTED (video.textTracks[4].mode == 'disabled') OK
 
 EXPECTED (video.textTracks[5].language == 'es') OK
-EXPECTED (video.textTracks[5].kind == 'subtitles') OK
+EXPECTED (video.textTracks[5].kind == 'forced') OK
 EXPECTED (video.textTracks[5].mode == 'disabled') OK
 
 EXPECTED (video.textTracks[6].language == 'de') OK
@@ -42,7 +54,7 @@
 EXPECTED (video.textTracks[6].mode == 'disabled') OK
 
 EXPECTED (video.textTracks[7].language == 'de') OK
-EXPECTED (video.textTracks[7].kind == 'subtitles') OK
+EXPECTED (video.textTracks[7].kind == 'forced') OK
 EXPECTED (video.textTracks[7].mode == 'disabled') OK
 
 EXPECTED (video.textTracks[8].language == 'en') OK

[webkit-changes] [196398] trunk/LayoutTests

[ryanhaddad]

Title: [196398] trunk/LayoutTests








Revision 196398
Author ryanhad...@apple.com
Date 2016-02-10 15:31:41 -0800 (Wed, 10 Feb 2016)


Log Message
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after 196392

Unreviewed test gardening.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (196397 => 196398)

--- trunk/LayoutTests/ChangeLog	2016-02-10 23:02:24 UTC (rev 196397)
+++ trunk/LayoutTests/ChangeLog	2016-02-10 23:31:41 UTC (rev 196398)
@@ -1,3 +1,11 @@
+2016-02-10  Ryan Haddad  
+
+Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after 196392
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
+
 2016-02-10  Chris Dumez  
 
 [Web IDL] interface objects should be Function objects


Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (196397 => 196398)

--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-10 23:02:24 UTC (rev 196397)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-10 23:31:41 UTC (rev 196398)
@@ -751,7 +751,11 @@
 PASS EventTarget interface: calling dispatchEvent(Event) on document.implementation.createDocument(null, "", null) with too few arguments must throw TypeError 
 FAIL MouseEvent interface: attribute region assert_true: The prototype object must have a property "region" expected true got false
 FAIL Touch interface: attribute region assert_own_property: self does not have own property "Touch" expected property "Touch" missing
-FAIL HTMLAllCollection interface: existence and properties of interface object assert_equals: class string of HTMLAllCollection expected "[object Function]" but got "[object HTMLAllCollectionConstructor]"
+FAIL HTMLAllCollection interface: existence and properties of interface object assert_equals: prototype of HTMLAllCollection is not HTMLCollection expected function "function HTMLCollection() {
+[native code]
+}" but got function "function () {
+[native code]
+}"
 PASS HTMLAllCollection interface object length 
 PASS HTMLAllCollection interface object name 
 FAIL HTMLAllCollection interface: existence and properties of interface prototype object assert_equals: prototype of HTMLAllCollection.prototype is not HTMLCollection.prototype expected object "[object HTMLCollectionPrototype]" but got object "[object Object]"
@@ -772,7 +776,7 @@
 FAIL HTMLCollection interface: calling item(unsigned long) on document.all with too few arguments must throw TypeError assert_equals: wrong typeof object expected "function" but got "undefined"
 FAIL HTMLCollection interface: document.all must inherit property "namedItem" with the proper type (2) assert_equals: wrong typeof object expected "function" but got "undefined"
 FAIL HTMLCollection interface: calling namedItem(DOMString) on document.all with too few arguments must throw TypeError assert_equals: wrong typeof object expected "function" but got "undefined"
-FAIL HTMLFormControlsCollection interface: existence and properties of interface object assert_equals: class string of HTMLFormControlsCollection expected "[object Function]" but got "[object HTMLFormControlsCollectionConstructor]"
+PASS HTMLFormControlsCollection interface: existence and properties of interface object 
 PASS HTMLFormControlsCollection interface object length 
 PASS HTMLFormControlsCollection interface object name 
 PASS HTMLFormControlsCollection interface: existence and properties of interface prototype object 
@@ -787,13 +791,13 @@
 FAIL HTMLCollection interface: calling item(unsigned long) on document.createElement("form").elements with too few arguments must throw TypeError assert_equals: wrong typeof object expected "function" but got "object"
 FAIL HTMLCollection interface: document.createElement("form").elements must inherit property "namedItem" with the proper type (2) assert_equals: wrong typeof object expected "function" but got "object"
 FAIL HTMLCollection interface: calling namedItem(DOMString) on document.createElement("form").elements with too few arguments must throw TypeError assert_equals: wrong typeof object expected "function" but got "object"
-FAIL RadioNodeList interface: existence and properties of interface object assert_equals: class string of RadioNodeList expected "[object Function]" but got "[object RadioNodeListConstructor]"
+PASS RadioNodeList interface: existence and properties of interface object 
 PASS RadioNodeList interface object length 
 PASS 

[webkit-changes] [196399] trunk/Source/WebKit2

[andersca]

Title: [196399] trunk/Source/WebKit2








Revision 196399
Author ander...@apple.com
Date 2016-02-10 15:57:30 -0800 (Wed, 10 Feb 2016)


Log Message
Add SPI to remove individual user scripts or user style sheets
https://bugs.webkit.org/show_bug.cgi?id=154046
rdar://problem/23596352

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController _removeUserScript:]):
(-[WKUserContentController _userStyleSheets]):
(-[WKUserContentController _addUserStyleSheet:]):
(-[WKUserContentController _removeUserStyleSheet:]):
* UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
* UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::removeUserScript):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
* UIProcess/UserContent/WebUserContentControllerProxy.h:
(WebKit::WebUserContentControllerProxy::userStyleSheets):
* WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::removeUserScript):
(WebKit::WebUserContentController::removeUserStyleSheet):
* WebProcess/UserContent/WebUserContentController.h:
* WebProcess/UserContent/WebUserContentController.messages.in:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h
trunk/Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.cpp
trunk/Source/WebKit2/UIProcess/UserContent/WebUserContentControllerProxy.h
trunk/Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp
trunk/Source/WebKit2/WebProcess/UserContent/WebUserContentController.h
trunk/Source/WebKit2/WebProcess/UserContent/WebUserContentController.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196398 => 196399)

--- trunk/Source/WebKit2/ChangeLog	2016-02-10 23:31:41 UTC (rev 196398)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-10 23:57:30 UTC (rev 196399)
@@ -1,3 +1,32 @@
+2016-02-10  Anders Carlsson  
+
+Add SPI to remove individual user scripts or user style sheets
+https://bugs.webkit.org/show_bug.cgi?id=154046
+rdar://problem/23596352
+
+Reviewed by Sam Weinig.
+
+* UIProcess/API/Cocoa/WKUserContentController.mm:
+(-[WKUserContentController _removeUserScript:]):
+(-[WKUserContentController _userStyleSheets]):
+(-[WKUserContentController _addUserStyleSheet:]):
+(-[WKUserContentController _removeUserStyleSheet:]):
+* UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
+* UIProcess/UserContent/WebUserContentControllerProxy.cpp:
+(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
+(WebKit::WebUserContentControllerProxy::addProcess):
+(WebKit::WebUserContentControllerProxy::removeUserScript):
+(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
+(WebKit::WebUserContentControllerProxy::removeUserStyleSheet):
+(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
+* UIProcess/UserContent/WebUserContentControllerProxy.h:
+(WebKit::WebUserContentControllerProxy::userStyleSheets):
+* WebProcess/UserContent/WebUserContentController.cpp:
+(WebKit::WebUserContentController::removeUserScript):
+(WebKit::WebUserContentController::removeUserStyleSheet):
+* WebProcess/UserContent/WebUserContentController.h:
+* WebProcess/UserContent/WebUserContentController.messages.in:
+
 2016-02-10  Alex Christensen  
 
 Fix assertions when loading from WebProcess


Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm (196398 => 196399)

--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm	2016-02-10 23:31:41 UTC (rev 196398)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm	2016-02-10 23:57:30 UTC (rev 196399)
@@ -126,6 +126,11 @@
 
 @implementation WKUserContentController (WKPrivate)
 
+- (void)_removeUserScript:(WKUserScript *)userScript
+{
+_userContentControllerProxy->removeUserScript(*userScript->_userScript);
+}
+
 - (void)_addUserContentFilter:(_WKUserContentFilter *)userContentFilter
 {
 #if ENABLE(CONTENT_EXTENSIONS)
@@ -147,11 +152,21 @@
 #endif
 }
 
+- (NSArray *)_userStyleSheets
+{
+return wrapper(_userContentControllerProxy->userStyleSheets());
+}
+
 - (void)_addUserStyleSheet:(_WKUserStyleSheet *)userStyleSheet
 {
-_userContentControllerProxy->addUserStyleSheet(userStyleSheet->_userStyleSheet->userStyleSheet());
+_userContentControllerProxy->addUserStyleSheet(*userStyleSheet->_userStyleSheet);
 }
 
+- 

[webkit-changes] [196408] trunk/LayoutTests

[ryanhaddad]

Title: [196408] trunk/LayoutTests








Revision 196408
Author ryanhad...@apple.com
Date 2016-02-10 17:18:18 -0800 (Wed, 10 Feb 2016)


Log Message
Removing deleted tests from ios-simulator TestExpectations

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (196407 => 196408)

--- trunk/LayoutTests/ChangeLog	2016-02-11 01:00:38 UTC (rev 196407)
+++ trunk/LayoutTests/ChangeLog	2016-02-11 01:18:18 UTC (rev 196408)
@@ -1,5 +1,13 @@
 2016-02-10  Ryan Haddad  
 
+Removing deleted tests from ios-simulator TestExpectations
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/TestExpectations:
+
+2016-02-10  Ryan Haddad  
+
 Adding an ios-simulator expectation for fast/dom/event-handler-attributes.html
 https://bugs.webkit.org/show_bug.cgi?id=153763
 


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (196407 => 196408)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-02-11 01:00:38 UTC (rev 196407)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-02-11 01:18:18 UTC (rev 196408)
@@ -1216,7 +1216,6 @@
 svg/text/small-fonts-2.svg [ Failure ]
 svg/text/small-fonts-3.svg [ Failure ]
 svg/text/small-fonts.svg [ Failure ]
-svg/text/svg-font-word-rounding-hacks-spaces.html [ ImageOnlyFailure ]
 svg/text/text-align-01-b.svg [ Failure ]
 svg/text/text-align-02-b.svg [ Failure ]
 svg/text/text-align-03-b.svg [ Failure ]
@@ -2862,7 +2861,6 @@
 webkit.org/b/152141 fast/picture/image-picture-1x.html [ Skip ]
 webkit.org/b/152141 fast/picture/image-picture-invalid.html [ Skip ]
 webkit.org/b/152141 fast/picture/image-picture-nested.html [ Skip ]
-webkit.org/b/153043 fast/picture/image-picture-loads-1x.html [ Skip ]
 webkit.org/b/152992 http/tests/loading/preload-picture-invalid.html [ Skip ]
 webkit.org/b/152992 http/tests/loading/preload-picture-nested.html [ Skip ]
 webkit.org/b/152992 http/tests/loading/preload-picture-sizes.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196410] tags/Safari-601.5.16/

[bshafiei]

Title: [196410] tags/Safari-601.5.16/








Revision 196410
Author bshaf...@apple.com
Date 2016-02-10 18:21:08 -0800 (Wed, 10 Feb 2016)


Log Message
New tag.

Added Paths

tags/Safari-601.5.16/




Diff

Property changes: tags/Safari-601.5.16



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196411] tags/Safari-601.1.46.98/

[bshafiei]

Title: [196411] tags/Safari-601.1.46.98/








Revision 196411
Author bshaf...@apple.com
Date 2016-02-10 18:21:42 -0800 (Wed, 10 Feb 2016)


Log Message
New tag.

Added Paths

tags/Safari-601.1.46.98/




Diff

Property changes: tags/Safari-601.1.46.98



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196406] trunk/Source/WebInspectorUI

[timothy]

Title: [196406] trunk/Source/WebInspectorUI








Revision 196406
Author timo...@apple.com
Date 2016-02-10 16:52:30 -0800 (Wed, 10 Feb 2016)


Log Message
Web Inspector: Add new icon for the Timeline Recording navigation bar item
https://bugs.webkit.org/show_bug.cgi?id=154089
rdar://problem/24595652

Reviewed by Brian Burg.

* UserInterface/Images/Stopwatch.png: Removed.
* UserInterface/Images/stopwa...@2x.png: Removed.
* UserInterface/Images/Stopwatch.svg: Added.
* UserInterface/Views/TimelineIcons.css:
(.stopwatch-icon .icon): Use Stopwatch.svg.
(body:not(.mac-platform, .windows-platform) .stopwatch-icon .icon): Added for GTK+.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Images/Stopwatch.svg


Removed Paths

trunk/Source/WebInspectorUI/UserInterface/Images/Stopwatch.png
trunk/Source/WebInspectorUI/UserInterface/Images/stopwa...@2x.png




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (196405 => 196406)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-11 00:44:18 UTC (rev 196405)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-11 00:52:30 UTC (rev 196406)
@@ -1,3 +1,18 @@
+2016-02-10  Timothy Hatcher  
+
+Web Inspector: Add new icon for the Timeline Recording navigation bar item
+https://bugs.webkit.org/show_bug.cgi?id=154089
+rdar://problem/24595652
+
+Reviewed by Brian Burg.
+
+* UserInterface/Images/Stopwatch.png: Removed.
+* UserInterface/Images/stopwa...@2x.png: Removed.
+* UserInterface/Images/Stopwatch.svg: Added.
+* UserInterface/Views/TimelineIcons.css:
+(.stopwatch-icon .icon): Use Stopwatch.svg.
+(body:not(.mac-platform, .windows-platform) .stopwatch-icon .icon): Added for GTK+.
+
 2016-02-10  Matt Baker  
 
 Web Inspector: Switching actions in Edit Breakpoint popover causes a jerk


Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/Stopwatch.png (196405 => 196406)

--- trunk/Source/WebInspectorUI/UserInterface/Images/Stopwatch.png	2016-02-11 00:44:18 UTC (rev 196405)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/Stopwatch.png	2016-02-11 00:52:30 UTC (rev 196406)
@@ -1,26 +0,0 @@
-\x89PNG
-
--IHDR\xF3\xFFa\x99iTXtXML:com.adobe.xmp
-   
-  
- 
-
-   Copyright © 2013 Apple Inc. All rights reserved.
-
- 
-  
-  
- Adobe ImageReady
-  
-   
-
-Yp\xC5\xE7IDAT8\x85SKOQ>mg\xDA\xCEԄ\xA9}\xD86-D\xB8sQ\xAB\xB4\x86\xAA\xC4\xB1	\xC6\\x99\xD4-7\xB8t\xC3\xC6`H\xBA\xB3\x8A(	\xD1P0\xA3\xA1\x96Gi\x93\x86\xA5@\x81\xD6>\xACS\xDA\xCEL\xDE{qH\x8C&\x9E\xE4>\xCF\xF9\xBE\xF3\xBAW\xD1h4\x8BB\xA1\xB0\xA2ţ\xD7\xEB[\xF2\xF9\xFC\xBA\xC5&&@`\xDA\xE9t>\xBBk\xB3\xD9\xEA\xC3\xC3\xC3A\xA7\xF3\x9C\xCEl>f\xC3\xF8t:\xB5!I\xE2\x8B\xF5\xF5\xF8\xE3@\xE0\xA9 sb,\xF5\xFB\xD0\xE6p8\xFAj\xB5\x9A
-	=:z\xFF\xAA\xC5bQU\xABQSݖJ\xA5:\xE1\x8Dk`\xE0\x86ob\xE2yI&\x91	b~\xBF\xFF
ð\x8FZ[[\xB9l6\xA3Z^^\x82R\xE9\xC0NDz`\xB3۴>\x9Fo0xv\xB2^\xAFuONN%!\xB9\xA7T\xA9\xA8\xBE\xA1\xA1A.E\xA9\xE1\xBA\xF7\xABu06qP\x89}\x83\xB7q\x98\x9D-\x82\xD7\xDB\xEF(
-~\x84\xB9\x85\xA2\xA8+q(,\xCB\xDCq\xBB\xDD\xFD\x91\xD5Uvu\xF6\xC0\xDA\xDA\x9C\xB0ڠ]\x81&\xFB)\xB8|\xE5h4D"pw\xBA\xFB1c	
\xCF\xF3^\xA3Q\xCFn'\x93p\xA1\xCB\xCD\xCD-\xA0T*\xA1\x90\xCFAuo\x94f\xA8(\\xEEnHn'\xC1h8\xCA\xF2|\xD1{H`0\xEC\xA2(\x81(\x8A@\xD1\xA0i5t\xB8\xBA \xFC\xFAh\xCF8\xB0\xE8t:0\x99, \x88\xB1\xC3|Oj J`\xEC\x95a\xB4\xF8\x9EDpi\xE86\xD9\xCBS\xB1X\xDC:\xECH\x94\xBAIR\xC8f\xB2\xF1J\xA5\x82\xC0\xE4\xB2\xDF
\xB5S\xC6\xFC\xB1\xD6j\x89\xDBf3\xB98V\x82Ph\xFEe,+qzV\xBE.\xC1~\x91\x87<\xCA_\xD46\xD8\xD9ن\xF0\xE7O\xC0q`[\x8C9$\x88\xC7\xE3\xE3\xA1\xF9ДF\xAD\xBE\xF0>\xBE\x9F\x81\x9F\x85\xF4BI\xFE [=v\x96a/\x9A̦\xF3\xA8\xA8\xC71A\xB9\\xDEK\xA7\xD3a\xB4.\xA0\xE3\xEBh\xFF"P!\xC54pq\xE5V\xE0\xF0\xF0Y\xFE7\xFBhO\xFE
&\xF8\xBAV!\x82$ЛIEND\xAEB`\x82
\ No newline at end of file


Added: trunk/Source/WebInspectorUI/UserInterface/Images/Stopwatch.svg (0 => 196406)

--- trunk/Source/WebInspectorUI/UserInterface/Images/Stopwatch.svg	(rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/Stopwatch.svg	2016-02-11 00:52:30 UTC (rev 196406)
@@ -0,0 +1,9 @@
+
+
+
+
+
+
+
+
+


Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/stopwa...@2x.png (196405 => 196406)

--- trunk/Source/WebInspectorUI/UserInterface/Images/stopwa...@2x.png	2016-02-11 00:44:18 UTC (rev 196405)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/stopwa...@2x.png	2016-02-11 00:52:30 UTC (rev 

[webkit-changes] [196407] trunk/Source/WebCore

[ryanhaddad]

Title: [196407] trunk/Source/WebCore








Revision 196407
Author ryanhad...@apple.com
Date 2016-02-10 17:00:38 -0800 (Wed, 10 Feb 2016)


Log Message
Updating bindings test reference file for JSTestEventConstructor.cpp after r196400

Unreviewed test gardening.

No new tests needed.

* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::construct):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (196406 => 196407)

--- trunk/Source/WebCore/ChangeLog	2016-02-11 00:52:30 UTC (rev 196406)
+++ trunk/Source/WebCore/ChangeLog	2016-02-11 01:00:38 UTC (rev 196407)
@@ -1,3 +1,14 @@
+2016-02-10  Ryan Haddad  
+
+Updating bindings test reference file for JSTestEventConstructor.cpp after r196400
+
+Unreviewed test gardening.
+
+No new tests needed.
+
+* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+(WebCore::JSTestEventConstructorConstructor::construct):
+
 2016-02-10  Eric Carlson  
 
 Update "manual" caption track logic


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (196406 => 196407)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp	2016-02-11 00:52:30 UTC (rev 196406)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp	2016-02-11 01:00:38 UTC (rev 196407)
@@ -97,7 +97,7 @@
 return JSValue::encode(jsUndefined());
 }
 
-RefPtr event = TestEventConstructor::create(eventType, eventInit);
+RefPtr event = TestEventConstructor::createForBindings(eventType, eventInit);
 return JSValue::encode(toJS(state, jsConstructor->globalObject(), event.get()));
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196409] trunk/Source/JavaScriptCore

[benjamin]

Title: [196409] trunk/Source/_javascript_Core








Revision 196409
Author benja...@webkit.org
Date 2016-02-10 17:35:42 -0800 (Wed, 10 Feb 2016)


Log Message
[JSC] The destination of Sqrt should be Def, not UseDef
https://bugs.webkit.org/show_bug.cgi?id=154086

Reviewed by Geoffrey Garen.

An unfortunate copy-paste: the destination of SqrtDouble and SqrtFloat
was defined as UseDef. As a result, the argument would be interfering
with everything defined prior.

* b3/air/AirOpcode.opcodes:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (196408 => 196409)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-11 01:18:18 UTC (rev 196408)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-11 01:35:42 UTC (rev 196409)
@@ -1,3 +1,16 @@
+2016-02-10  Benjamin Poulain  
+
+[JSC] The destination of Sqrt should be Def, not UseDef
+https://bugs.webkit.org/show_bug.cgi?id=154086
+
+Reviewed by Geoffrey Garen.
+
+An unfortunate copy-paste: the destination of SqrtDouble and SqrtFloat
+was defined as UseDef. As a result, the argument would be interfering
+with everything defined prior.
+
+* b3/air/AirOpcode.opcodes:
+
 2016-02-10  Chris Dumez  
 
 [Web IDL] interface objects should be Function objects


Modified: trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes (196408 => 196409)

--- trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes	2016-02-11 01:18:18 UTC (rev 196408)
+++ trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes	2016-02-11 01:35:42 UTC (rev 196409)
@@ -386,11 +386,11 @@
 Tmp, Tmp
 x86: Addr, Tmp
 
-SqrtDouble U:F:64, UD:F:64
+SqrtDouble U:F:64, D:F:64
 Tmp, Tmp
 x86: Addr, Tmp
 
-SqrtFloat U:F:32, UD:F:32
+SqrtFloat U:F:32, D:F:32
 Tmp, Tmp
 x86: Addr, Tmp
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes