[webkit-changes] [196627] tags/Safari-601.5.17.1.1/Source

[bshafiei]

Title: [196627] tags/Safari-601.5.17.1.1/Source








Revision 196627
Author bshaf...@apple.com
Date 2016-02-15 23:14:15 -0800 (Mon, 15 Feb 2016)


Log Message
Versioning.

Modified Paths

tags/Safari-601.5.17.1.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-601.5.17.1.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-601.5.17.1.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-601.5.17.1.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-601.5.17.1.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-601.5.17.1.1/Source/_javascript_Core/Configurations/Version.xcconfig (196626 => 196627)

--- tags/Safari-601.5.17.1.1/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-16 07:12:27 UTC (rev 196626)
+++ tags/Safari-601.5.17.1.1/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-16 07:14:15 UTC (rev 196627)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 5;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-601.5.17.1.1/Source/WebCore/Configurations/Version.xcconfig (196626 => 196627)

--- tags/Safari-601.5.17.1.1/Source/WebCore/Configurations/Version.xcconfig	2016-02-16 07:12:27 UTC (rev 196626)
+++ tags/Safari-601.5.17.1.1/Source/WebCore/Configurations/Version.xcconfig	2016-02-16 07:14:15 UTC (rev 196627)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 5;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-601.5.17.1.1/Source/WebInspectorUI/Configurations/Version.xcconfig (196626 => 196627)

--- tags/Safari-601.5.17.1.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-16 07:12:27 UTC (rev 196626)
+++ tags/Safari-601.5.17.1.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-16 07:14:15 UTC (rev 196627)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 5;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-601.5.17.1.1/Source/WebKit/mac/Configurations/Version.xcconfig (196626 => 196627)

--- tags/Safari-601.5.17.1.1/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-16 07:12:27 UTC (rev 196626)
+++ tags/Safari-601.5.17.1.1/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-16 07:14:15 UTC (rev 196627)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 5;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-601.5.17.1.1/Source/WebKit2/Configurations/Version.xcconfig (196626 => 196627)

--- tags/Safari-601.5.17.1.1/Source/WebKit2/Configurations/Version.xcconfig	2016-02-16 07:12:27 UTC (rev 196626)
+++ tags/Safari-601.5.17.1.1/Source/WebKit2/Configurations/Version.xcconfig	2016-02-16 07:14:15 UTC (rev 196627)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 5;
 TINY_VERSION = 17;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196626] tags/Safari-601.5.17.1.1/

[bshafiei]

Title: [196626] tags/Safari-601.5.17.1.1/








Revision 196626
Author bshaf...@apple.com
Date 2016-02-15 23:12:27 -0800 (Mon, 15 Feb 2016)


Log Message
New tag.

Added Paths

tags/Safari-601.5.17.1.1/




Diff

Property changes: tags/Safari-601.5.17.1.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196625] trunk/LayoutTests

[mark . lam]

Title: [196625] trunk/LayoutTests








Revision 196625
Author mark@apple.com
Date 2016-02-15 23:10:11 -0800 (Mon, 15 Feb 2016)


Log Message
[ARMv7] Some JSC test fails due to exhausting the JIT code heap on the no LLINT test configuration.
https://bugs.webkit.org/show_bug.cgi?id=151611

Reviewed by Saam Barati.

These tests are only failing because they are compiling too much with the LLINT
disabled.  As a result, they are using more JIT code heap space than is allowed
by the OS.

This patch excludes these tests from the noLLINT configuration on 32-bit ARM.

* js/script-tests/dfg-float32array.js:
* js/script-tests/dfg-float64array.js:
* js/script-tests/dfg-int16array.js:
* js/script-tests/dfg-int32array-overflow-values.js:
* js/script-tests/dfg-int32array.js:
* js/script-tests/dfg-int8array.js:
* js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:
* js/script-tests/dfg-uint16array.js:
* js/script-tests/dfg-uint32array-overflow-values.js:
* js/script-tests/dfg-uint32array.js:
* js/script-tests/dfg-uint8array.js:
* js/script-tests/dfg-uint8clampedarray.js:
* js/script-tests/regress-141098.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/script-tests/dfg-float32array.js
trunk/LayoutTests/js/script-tests/dfg-float64array.js
trunk/LayoutTests/js/script-tests/dfg-int16array.js
trunk/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js
trunk/LayoutTests/js/script-tests/dfg-int32array.js
trunk/LayoutTests/js/script-tests/dfg-int8array.js
trunk/LayoutTests/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js
trunk/LayoutTests/js/script-tests/dfg-uint16array.js
trunk/LayoutTests/js/script-tests/dfg-uint32array-overflow-values.js
trunk/LayoutTests/js/script-tests/dfg-uint32array.js
trunk/LayoutTests/js/script-tests/dfg-uint8array.js
trunk/LayoutTests/js/script-tests/dfg-uint8clampedarray.js
trunk/LayoutTests/js/script-tests/regress-141098.js




Diff

Modified: trunk/LayoutTests/ChangeLog (196624 => 196625)

--- trunk/LayoutTests/ChangeLog	2016-02-16 06:42:59 UTC (rev 196624)
+++ trunk/LayoutTests/ChangeLog	2016-02-16 07:10:11 UTC (rev 196625)
@@ -1,3 +1,30 @@
+2016-02-15  Mark Lam  
+
+[ARMv7] Some JSC test fails due to exhausting the JIT code heap on the no LLINT test configuration.
+https://bugs.webkit.org/show_bug.cgi?id=151611
+
+Reviewed by Saam Barati.
+
+These tests are only failing because they are compiling too much with the LLINT
+disabled.  As a result, they are using more JIT code heap space than is allowed
+by the OS.
+
+This patch excludes these tests from the noLLINT configuration on 32-bit ARM.
+
+* js/script-tests/dfg-float32array.js:
+* js/script-tests/dfg-float64array.js:
+* js/script-tests/dfg-int16array.js:
+* js/script-tests/dfg-int32array-overflow-values.js:
+* js/script-tests/dfg-int32array.js:
+* js/script-tests/dfg-int8array.js:
+* js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:
+* js/script-tests/dfg-uint16array.js:
+* js/script-tests/dfg-uint32array-overflow-values.js:
+* js/script-tests/dfg-uint32array.js:
+* js/script-tests/dfg-uint8array.js:
+* js/script-tests/dfg-uint8clampedarray.js:
+* js/script-tests/regress-141098.js:
+
 2016-02-15  Brent Fulgham  
 
 [Mac] Gather some rudimentary statistics during resource load 


Modified: trunk/LayoutTests/js/script-tests/dfg-float32array.js (196624 => 196625)

--- trunk/LayoutTests/js/script-tests/dfg-float32array.js	2016-02-16 06:42:59 UTC (rev 196624)
+++ trunk/LayoutTests/js/script-tests/dfg-float32array.js	2016-02-16 07:10:11 UTC (rev 196625)
@@ -1,3 +1,5 @@
+//@ noNoLLIntRunLayoutTest if $architecture == "arm"
+
 description(
 "This tests that float32 arrays work in the DFG."
 );


Modified: trunk/LayoutTests/js/script-tests/dfg-float64array.js (196624 => 196625)

--- trunk/LayoutTests/js/script-tests/dfg-float64array.js	2016-02-16 06:42:59 UTC (rev 196624)
+++ trunk/LayoutTests/js/script-tests/dfg-float64array.js	2016-02-16 07:10:11 UTC (rev 196625)
@@ -1,3 +1,5 @@
+//@ noNoLLIntRunLayoutTest if $architecture == "arm"
+
 description(
 "This tests that float64 arrays work in the DFG."
 );


Modified: trunk/LayoutTests/js/script-tests/dfg-int16array.js (196624 => 196625)

--- trunk/LayoutTests/js/script-tests/dfg-int16array.js	2016-02-16 06:42:59 UTC (rev 196624)
+++ trunk/LayoutTests/js/script-tests/dfg-int16array.js	2016-02-16 07:10:11 UTC (rev 196625)
@@ -1,3 +1,5 @@
+//@ noNoLLIntRunLayoutTest if $architecture == "arm"
+
 description(
 "This tests that int16 arrays work in the DFG."
 );


Modified: trunk/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js (196624 => 196625)

--- trunk/LayoutTests/js/script-tests/dfg-int32array-overflow-values.js	2016-02-16 06:42:59 UTC (rev 196624)
+++ 

[webkit-changes] [196624] trunk/Source/WebKit2

[mitz]

Title: [196624] trunk/Source/WebKit2








Revision 196624
Author m...@apple.com
Date 2016-02-15 22:42:59 -0800 (Mon, 15 Feb 2016)


Log Message
Removed unused files after r196478.

* Configurations/DatabaseProcess.xcconfig: Removed.
* Configurations/NetworkProcess.xcconfig: Removed.
* Configurations/PluginProcess.xcconfig: Removed.
* Configurations/WebContentProcess.xcconfig: Removed.
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Removed Paths

trunk/Source/WebKit2/Configurations/DatabaseProcess.xcconfig
trunk/Source/WebKit2/Configurations/NetworkProcess.xcconfig
trunk/Source/WebKit2/Configurations/PluginProcess.xcconfig
trunk/Source/WebKit2/Configurations/WebContentProcess.xcconfig




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196623 => 196624)

--- trunk/Source/WebKit2/ChangeLog	2016-02-16 05:39:57 UTC (rev 196623)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-16 06:42:59 UTC (rev 196624)
@@ -1,3 +1,13 @@
+2016-02-15  Dan Bernstein  
+
+Removed unused files after r196478.
+
+* Configurations/DatabaseProcess.xcconfig: Removed.
+* Configurations/NetworkProcess.xcconfig: Removed.
+* Configurations/PluginProcess.xcconfig: Removed.
+* Configurations/WebContentProcess.xcconfig: Removed.
+* WebKit2.xcodeproj/project.pbxproj:
+
 2016-02-15  ChangSeok Oh  
 
 [ThreadedCompositor] position:fixed elements do not have their own layers when threaded compositor is enabled.


Deleted: trunk/Source/WebKit2/Configurations/DatabaseProcess.xcconfig (196623 => 196624)

--- trunk/Source/WebKit2/Configurations/DatabaseProcess.xcconfig	2016-02-16 05:39:57 UTC (rev 196623)
+++ trunk/Source/WebKit2/Configurations/DatabaseProcess.xcconfig	2016-02-16 06:42:59 UTC (rev 196624)
@@ -1,27 +0,0 @@
-// Copyright (C) 2013 Apple Inc. All rights reserved.
-//
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions
-// are met:
-// 1. Redistributions of source code must retain the above copyright
-//notice, this list of conditions and the following disclaimer.
-// 2. Redistributions in binary form must reproduce the above copyright
-//notice, this list of conditions and the following disclaimer in the
-//documentation and/or other materials provided with the distribution.
-//
-// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
-// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-// PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
-// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
-// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-#include "BaseLegacyProcess.xcconfig"
-
-PRODUCT_NAME = DatabaseProcess;
-INFOPLIST_FILE = DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist;


Deleted: trunk/Source/WebKit2/Configurations/NetworkProcess.xcconfig (196623 => 196624)

--- trunk/Source/WebKit2/Configurations/NetworkProcess.xcconfig	2016-02-16 05:39:57 UTC (rev 196623)
+++ trunk/Source/WebKit2/Configurations/NetworkProcess.xcconfig	2016-02-16 06:42:59 UTC (rev 196624)
@@ -1,29 +0,0 @@
-// Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
-//
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions
-// are met:
-// 1. Redistributions of source code must retain the above copyright
-//notice, this list of conditions and the following disclaimer.
-// 2. Redistributions in binary form must reproduce the above copyright
-//notice, this list of conditions and the following disclaimer in the
-//documentation and/or other materials provided with the distribution.
-//
-// THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
-// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-// PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
-// CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-// EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-// PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
-// OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS 

[webkit-changes] [196623] trunk/Source/WebKit2

[changseok . oh]

Title: [196623] trunk/Source/WebKit2








Revision 196623
Author changseok...@collabora.com
Date 2016-02-15 21:39:57 -0800 (Mon, 15 Feb 2016)


Log Message
[ThreadedCompositor] position:fixed elements do not have their own layers when threaded compositor is enabled.
https://bugs.webkit.org/show_bug.cgi?id=154100

Reviewed by Carlos Garcia Campos.

Currently, fixed elements are redrawn to a backing store every time layout or scroll happens.
It results in the bad effect on performance-wise. Letting fixed element have separate layers is
necessary when threaded compositor is enabled at least. Because async scrolling requires it.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196622 => 196623)

--- trunk/Source/WebKit2/ChangeLog	2016-02-16 05:36:38 UTC (rev 196622)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-16 05:39:57 UTC (rev 196623)
@@ -1,3 +1,17 @@
+2016-02-15  ChangSeok Oh  
+
+[ThreadedCompositor] position:fixed elements do not have their own layers when threaded compositor is enabled.
+https://bugs.webkit.org/show_bug.cgi?id=154100
+
+Reviewed by Carlos Garcia Campos.
+
+Currently, fixed elements are redrawn to a backing store every time layout or scroll happens.
+It results in the bad effect on performance-wise. Letting fixed element have separate layers is
+necessary when threaded compositor is enabled at least. Because async scrolling requires it.
+
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit::DrawingAreaImpl::updatePreferences):
+
 2016-02-15  Alex Christensen  
 
 Implement content sniffing check with NetworkSession


Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp (196622 => 196623)

--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp	2016-02-16 05:36:38 UTC (rev 196622)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp	2016-02-16 05:39:57 UTC (rev 196623)
@@ -248,7 +248,15 @@
 
 void DrawingAreaImpl::updatePreferences(const WebPreferencesStore& store)
 {
-m_webPage.corePage()->settings().setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey()));
+Settings& settings = m_webPage.corePage()->settings();
+settings.setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey()));
+
+#if USE(COORDINATED_GRAPHICS_THREADED)
+// Fixed position elements need to be composited and create stacking contexts
+// in order to be scrolled by the ScrollingCoordinator.
+settings.setAcceleratedCompositingForFixedPositionEnabled(true);
+settings.setFixedPositionCreatesStackingContext(true);
+#endif
 }
 
 void DrawingAreaImpl::layerHostDidFlushLayers()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196622] trunk

[bfulgham]

Title: [196622] trunk








Revision 196622
Author bfulg...@apple.com
Date 2016-02-15 21:36:38 -0800 (Mon, 15 Feb 2016)


Log Message
[Mac] Gather some rudimentary statistics during resource load 
https://bugs.webkit.org/show_bug.cgi?id=153575


Reviewed by Brady Eidson.

Source/WebCore:

Tested by: http/tests/navigation/statistics.html

* CMakeLists.txt:
* PlatformWin.cmake:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::updateLastHandledUserGestureTimestamp): Log user interaction
with the ResourceLoadObserver.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest): Track load statistics if the
user interacted with the document.
* loader/ResourceLoadObserver.cpp: Added.
* loader/ResourceLoadObserver.h: Added.
* loader/ResourceLoadStatistics.cpp: Added.
* loader/ResourceLoadStatistics.h: Added.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal): Track load statistics.
* page/Settings.cpp:
(WebCore::Settings::setResourceLoadStatisticsEnabled): Added.
* page/Settings.h:
(WebCore::Settings::resourceLoadStatisticsEnabled): Added.
* platform/Logging.h:
* testing/Internals.cpp:
(WebCore::Internals::resourceLoadStatisticsForOrigin):
(WebCore::Internals::setResourceLoadStatisticsEnabled):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/mac:

* Misc/WebKitNSStringExtras.h:
* Misc/WebKitNSStringExtras.mm:
(+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Added.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences resourceLoadStatisticsEnabled]): Added.
(-[WebPreferences setResourceLoadStatisticsEnabled:]): Added.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(WebKitInitializeApplicationCachePathIfNecessary):
(WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Added.
(-[WebView _commonInitializationWithFrameName:groupName:]): Add call to new
initialization method.
(-[WebView _preferencesChanged:]): Track changes in the user's desire to
monitor resource load statistics.
(+[WebView _applicationWillTerminate]): Write statistics to disk (if preferences
say to do so.)

Tools:

* MiniBrowser/mac/SettingsController.h:
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]): Add menu item for new debug flag.
(-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
(-[SettingsController resourceLoadStatisticsEnabled]): Added.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController didChangeSettings]): React to changes in
users's desire to track resource load statistics.

LayoutTests:

* http/tests/navigation/resources/redirect-on-reload-updates-history-item-statistics.php: Added.
* http/tests/navigation/resources/redirect-updates-history-item-done-statistics.html: Added.
* http/tests/navigation/statistics-expected.txt: Added.
* http/tests/navigation/statistics.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformWin.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/platform/Logging.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Misc/WebKitNSStringExtras.h
trunk/Source/WebKit/mac/Misc/WebKitNSStringExtras.mm
trunk/Source/WebKit/mac/WebKit.exp
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/MiniBrowser/mac/SettingsController.h
trunk/Tools/MiniBrowser/mac/SettingsController.m
trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m


Added Paths

trunk/LayoutTests/http/tests/navigation/resources/redirect-on-reload-updates-history-item-statistics.php
trunk/LayoutTests/http/tests/navigation/resources/redirect-updates-history-item-done-statistics.html
trunk/LayoutTests/http/tests/navigation/statistics-expected.txt
trunk/LayoutTests/http/tests/navigation/statistics.html
trunk/Source/WebCore/loader/ResourceLoadObserver.cpp
trunk/Source/WebCore/loader/ResourceLoadObserver.h
trunk/Source/WebCore/loader/ResourceLoadStatistics.cpp
trunk/Source/WebCore/loader/ResourceLoadStatistics.h




Diff

Modified: trunk/LayoutTests/ChangeLog (196621 => 196622)

--- trunk/LayoutTests/ChangeLog	2016-02-16 05:32:56 UTC (rev 196621)
+++ trunk/LayoutTests/ChangeLog	2016-02-16 05:36:38 UTC (rev 196622)
@@ -1,3 +1,16 @@
+2016-02-15  Brent Fulgham  
+
+[Mac] 

[webkit-changes] [196621] trunk

[cdumez]

Title: [196621] trunk








Revision 196621
Author cdu...@apple.com
Date 2016-02-15 21:32:56 -0800 (Mon, 15 Feb 2016)


Log Message
The following properties should exist on the global object: AudioTrackList, AudioTrack, VideoTrackList, VideoTrack
https://bugs.webkit.org/show_bug.cgi?id=154250


Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline now that more checks are passing.

* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

The following properties should exist on the global object:
- AudioTrackList, AudioTrack, VideoTrackList, VideoTrack

These interfaces are not marked as [NoInterfaceObject] in:
- https://html.spec.whatwg.org/#audiotracklist-and-videotracklist-objects

No new tests, already covered by existing tests.

* html/track/AudioTrack.idl:
* html/track/AudioTrackList.idl:
* html/track/VideoTrack.idl:
* html/track/VideoTrackList.idl:

LayoutTests:

Rebaseline now that AudioTrackList, AudioTrack, VideoTrackList and VideoTrack
are exposed on the global Window object.

* js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/AudioTrack.idl
trunk/Source/WebCore/html/track/AudioTrackList.idl
trunk/Source/WebCore/html/track/VideoTrack.idl
trunk/Source/WebCore/html/track/VideoTrackList.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (196620 => 196621)

--- trunk/LayoutTests/ChangeLog	2016-02-16 05:15:22 UTC (rev 196620)
+++ trunk/LayoutTests/ChangeLog	2016-02-16 05:32:56 UTC (rev 196621)
@@ -1,3 +1,19 @@
+2016-02-15  Chris Dumez  
+
+The following properties should exist on the global object: AudioTrackList, AudioTrack, VideoTrackList, VideoTrack
+https://bugs.webkit.org/show_bug.cgi?id=154250
+
+
+Reviewed by Eric Carlson.
+
+Rebaseline now that AudioTrackList, AudioTrack, VideoTrackList and VideoTrack
+are exposed on the global Window object.
+
+* js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+
 2016-02-15  Hunseop Jeong  
 
 [EFL] Rebaseline after r196244.


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196620 => 196621)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-16 05:15:22 UTC (rev 196620)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-16 05:32:56 UTC (rev 196621)
@@ -1,5 +1,17 @@
 2016-02-15  Chris Dumez  
 
+The following properties should exist on the global object: AudioTrackList, AudioTrack, VideoTrackList, VideoTrack
+https://bugs.webkit.org/show_bug.cgi?id=154250
+
+
+Reviewed by Eric Carlson.
+
+Rebaseline now that more checks are passing.
+
+* web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-02-15  Chris Dumez  
+
 Re-sync W3C web-platform-tests' html/dom/interfaces.html
 https://bugs.webkit.org/show_bug.cgi?id=154259
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (196620 => 196621)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-16 05:15:22 UTC (rev 196620)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-16 05:32:56 UTC (rev 196621)
@@ -2192,47 +2192,55 @@
 PASS MediaError interface: errorVideo.error must inherit property "MEDIA_ERR_DECODE" with the proper type (2) 
 PASS MediaError interface: errorVideo.error must inherit property "MEDIA_ERR_SRC_NOT_SUPPORTED" with the proper type (3) 
 FAIL MediaError interface: errorVideo.error must inherit property "code" with the proper type (4) assert_inherits: property "code" found on object expected in prototype chain
-FAIL AudioTrackList interface: existence and properties of interface object assert_own_property: self does not have own property "AudioTrackList" expected property "AudioTrackList" missing
-FAIL AudioTrackList interface object length assert_own_property: self does not have own property 

[webkit-changes] [196620] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [196620] trunk/Source/WebInspectorUI








Revision 196620
Author nvasil...@apple.com
Date 2016-02-15 21:15:22 -0800 (Mon, 15 Feb 2016)


Log Message
Web Inspector: Non-overlay scrollbars obscure the ends of lines in the console and sidebars
https://bugs.webkit.org/show_bug.cgi?id=154276

Reviewed by Timothy Hatcher.

* UserInterface/Views/DataGrid.css:
(.data-grid .data-container):
* UserInterface/Views/DatabaseContentView.css:
(.storage-view.query):
* UserInterface/Views/LogContentView.css:
(.content-view.log):
Replace all occurrences of "overflow-y: overlay" with "overflow-y: auto".

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css
trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.css
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (196619 => 196620)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-16 05:11:59 UTC (rev 196619)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-16 05:15:22 UTC (rev 196620)
@@ -1,3 +1,18 @@
+2016-02-15  Nikita Vasilyev  
+
+Web Inspector: Non-overlay scrollbars obscure the ends of lines in the console and sidebars
+https://bugs.webkit.org/show_bug.cgi?id=154276
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/DataGrid.css:
+(.data-grid .data-container):
+* UserInterface/Views/DatabaseContentView.css:
+(.storage-view.query):
+* UserInterface/Views/LogContentView.css:
+(.content-view.log):
+Replace all occurrences of "overflow-y: overlay" with "overflow-y: auto".
+
 2016-02-15  Devin Rousso  
 
 Web Inspector: Visual sidebar minor regression fixes


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (196619 => 196620)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css	2016-02-16 05:11:59 UTC (rev 196619)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css	2016-02-16 05:15:22 UTC (rev 196620)
@@ -50,7 +50,7 @@
 left: 0;
 right: 0;
 overflow-x: hidden;
-overflow-y: overlay;
+overflow-y: auto;
 }
 
 .data-grid.inline .data-container {


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.css (196619 => 196620)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.css	2016-02-16 05:11:59 UTC (rev 196619)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.css	2016-02-16 05:15:22 UTC (rev 196620)
@@ -39,7 +39,7 @@
 
 .storage-view.query {
 padding: 2px 0;
-overflow-y: overlay;
+overflow-y: auto;
 overflow-x: hidden;
 -webkit-text-size-adjust: auto;
 }


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (196619 => 196620)

--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2016-02-16 05:11:59 UTC (rev 196619)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2016-02-16 05:15:22 UTC (rev 196620)
@@ -58,7 +58,7 @@
 }
 
 .content-view.log {
-overflow-y: overlay;
+overflow-y: auto;
 overflow-x: hidden;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196619] tags/Safari-602.1.18.10

[bshafiei]

Title: [196619] tags/Safari-602.1.18.10








Revision 196619
Author bshaf...@apple.com
Date 2016-02-15 21:11:59 -0800 (Mon, 15 Feb 2016)


Log Message
Merged r196589.  rdar://problem/24644805

Modified Paths

tags/Safari-602.1.18.10/Source/WebKit/ChangeLog
tags/Safari-602.1.18.10/Source/WebKit/PlatformWin.cmake
tags/Safari-602.1.18.10/Tools/ChangeLog
tags/Safari-602.1.18.10/Tools/DumpRenderTree/PlatformWin.cmake
tags/Safari-602.1.18.10/Tools/MiniBrowser/win/CMakeLists.txt




Diff

Modified: tags/Safari-602.1.18.10/Source/WebKit/ChangeLog (196618 => 196619)

--- tags/Safari-602.1.18.10/Source/WebKit/ChangeLog	2016-02-16 05:11:02 UTC (rev 196618)
+++ tags/Safari-602.1.18.10/Source/WebKit/ChangeLog	2016-02-16 05:11:59 UTC (rev 196619)
@@ -1,3 +1,21 @@
+2016-02-15  Babak Shafiei  
+
+Merge r196589.
+
+2016-02-15  Alex Christensen  
+
+Fix internal Windows build of projects built after WebKit
+https://bugs.webkit.org/show_bug.cgi?id=154249
+rdar://problem/24644805
+
+Reviewed by Chris Dumez.
+
+* PlatformWin.cmake:
+Copy all generated headers to ForwardingHeaders/WebKit, not just WebKit.h.
+This should fix problems related to not finding headers from other projects, such as AccessibleApplication.h.
+WebKit.h, WebKitCOMAPI.h, and CFDictionaryPropertyBag.h were copied correctly, so this should copy the rest
+of the needed headers.
+
 2016-02-12  Babak Shafiei  
 
 Merge r196502.


Modified: tags/Safari-602.1.18.10/Source/WebKit/PlatformWin.cmake (196618 => 196619)

--- tags/Safari-602.1.18.10/Source/WebKit/PlatformWin.cmake	2016-02-16 05:11:02 UTC (rev 196618)
+++ tags/Safari-602.1.18.10/Source/WebKit/PlatformWin.cmake	2016-02-16 05:11:59 UTC (rev 196619)
@@ -469,7 +469,7 @@
 add_custom_command(TARGET WebKitGUID PRE_BUILD COMMAND ${WebKitGUID_PRE_BUILD_COMMAND} VERBATIM)
 
 set(WebKitGUID_POST_BUILD_COMMAND "${CMAKE_BINARY_DIR}/DerivedSources/WebKit/postBuild.cmd")
-file(WRITE "${WebKitGUID_POST_BUILD_COMMAND}" "@xcopy /y /d /f \"${DERIVED_SOURCES_WEBKIT_DIR}/Interfaces/WebKit.h\" \"${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit\" >nul 2>nul")
+file(WRITE "${WebKitGUID_POST_BUILD_COMMAND}" "@xcopy /y /d /f \"${DERIVED_SOURCES_WEBKIT_DIR}/Interfaces/*.h\" \"${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit\" >nul 2>nul")
 add_custom_command(TARGET WebKitGUID POST_BUILD COMMAND ${WebKitGUID_POST_BUILD_COMMAND} VERBATIM)
 
 set(WebKit_OUTPUT_NAME


Modified: tags/Safari-602.1.18.10/Tools/ChangeLog (196618 => 196619)

--- tags/Safari-602.1.18.10/Tools/ChangeLog	2016-02-16 05:11:02 UTC (rev 196618)
+++ tags/Safari-602.1.18.10/Tools/ChangeLog	2016-02-16 05:11:59 UTC (rev 196619)
@@ -1,3 +1,21 @@
+2016-02-15  Babak Shafiei  
+
+Merge r196589.
+
+2016-02-15  Alex Christensen  
+
+Fix internal Windows build of projects built after WebKit
+https://bugs.webkit.org/show_bug.cgi?id=154249
+rdar://problem/24644805
+
+Reviewed by Chris Dumez.
+
+* DumpRenderTree/PlatformWin.cmake:
+* MiniBrowser/win/CMakeLists.txt:
+Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
+more like projects built internally after WebKit.  They should only need to use what
+is in ForwardingHeaders/WebKit.
+
 2016-01-28  Dan Bernstein  
 
 [Cocoa] Use the non-Development variants of XPC services for development


Modified: tags/Safari-602.1.18.10/Tools/DumpRenderTree/PlatformWin.cmake (196618 => 196619)

--- tags/Safari-602.1.18.10/Tools/DumpRenderTree/PlatformWin.cmake	2016-02-16 05:11:02 UTC (rev 196618)
+++ tags/Safari-602.1.18.10/Tools/DumpRenderTree/PlatformWin.cmake	2016-02-16 05:11:59 UTC (rev 196619)
@@ -71,7 +71,6 @@
 TestNetscapePlugin/Tests
 TestNetscapePlugin/win
 TestNetscapePlugin/Tests/win
-${DERIVED_SOURCES_DIR}/WebKit/Interfaces
 )
 
 list(APPEND DumpRenderTree_LIBRARIES


Modified: tags/Safari-602.1.18.10/Tools/MiniBrowser/win/CMakeLists.txt (196618 => 196619)

--- tags/Safari-602.1.18.10/Tools/MiniBrowser/win/CMakeLists.txt	2016-02-16 05:11:02 UTC (rev 196618)
+++ tags/Safari-602.1.18.10/Tools/MiniBrowser/win/CMakeLists.txt	2016-02-16 05:11:59 UTC (rev 196619)
@@ -2,8 +2,6 @@
 ../MiniBrowser.vcxproj
 "${DERIVED_SOURCES_DIR}/ForwardingHeaders"
 "${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit"
-"${DERIVED_SOURCES_DIR}"
-"${DERIVED_SOURCES_WEBKIT_DIR}/Interfaces"
 "${WTF_DIR}"
 "${CMAKE_SOURCE_DIR}"
 "${CMAKE_SOURCE_DIR}/Source"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196618] tags/Safari-602.1.18.10/Source

[bshafiei]

Title: [196618] tags/Safari-602.1.18.10/Source








Revision 196618
Author bshaf...@apple.com
Date 2016-02-15 21:11:02 -0800 (Mon, 15 Feb 2016)


Log Message
Versioning.

Modified Paths

tags/Safari-602.1.18.10/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-602.1.18.10/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-602.1.18.10/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-602.1.18.10/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-602.1.18.10/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-602.1.18.10/Source/_javascript_Core/Configurations/Version.xcconfig (196617 => 196618)

--- tags/Safari-602.1.18.10/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-16 05:08:53 UTC (rev 196617)
+++ tags/Safari-602.1.18.10/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-16 05:11:02 UTC (rev 196618)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
-MICRO_VERSION = 9;
+MICRO_VERSION = 10;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-602.1.18.10/Source/WebCore/Configurations/Version.xcconfig (196617 => 196618)

--- tags/Safari-602.1.18.10/Source/WebCore/Configurations/Version.xcconfig	2016-02-16 05:08:53 UTC (rev 196617)
+++ tags/Safari-602.1.18.10/Source/WebCore/Configurations/Version.xcconfig	2016-02-16 05:11:02 UTC (rev 196618)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
-MICRO_VERSION = 9;
+MICRO_VERSION = 10;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-602.1.18.10/Source/WebInspectorUI/Configurations/Version.xcconfig (196617 => 196618)

--- tags/Safari-602.1.18.10/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-16 05:08:53 UTC (rev 196617)
+++ tags/Safari-602.1.18.10/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-16 05:11:02 UTC (rev 196618)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
-MICRO_VERSION = 9;
+MICRO_VERSION = 10;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-602.1.18.10/Source/WebKit/mac/Configurations/Version.xcconfig (196617 => 196618)

--- tags/Safari-602.1.18.10/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-16 05:08:53 UTC (rev 196617)
+++ tags/Safari-602.1.18.10/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-16 05:11:02 UTC (rev 196618)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
-MICRO_VERSION = 9;
+MICRO_VERSION = 10;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-602.1.18.10/Source/WebKit2/Configurations/Version.xcconfig (196617 => 196618)

--- tags/Safari-602.1.18.10/Source/WebKit2/Configurations/Version.xcconfig	2016-02-16 05:08:53 UTC (rev 196617)
+++ tags/Safari-602.1.18.10/Source/WebKit2/Configurations/Version.xcconfig	2016-02-16 05:11:02 UTC (rev 196618)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 1;
 TINY_VERSION = 18;
-MICRO_VERSION = 9;
+MICRO_VERSION = 10;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196617] tags/Safari-602.1.18.10/

[bshafiei]

Title: [196617] tags/Safari-602.1.18.10/








Revision 196617
Author bshaf...@apple.com
Date 2016-02-15 21:08:53 -0800 (Mon, 15 Feb 2016)


Log Message
New tag.

Added Paths

tags/Safari-602.1.18.10/




Diff

Property changes: tags/Safari-602.1.18.10



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196616] trunk/Source/JavaScriptCore

[commit-queue]

Title: [196616] trunk/Source/_javascript_Core








Revision 196616
Author commit-qu...@webkit.org
Date 2016-02-15 20:51:20 -0800 (Mon, 15 Feb 2016)


Log Message
[JSC] BranchAdd can override arguments of its stackmap
https://bugs.webkit.org/show_bug.cgi?id=154274

Patch by Benjamin Poulain  on 2016-02-15
Reviewed by Filip Pizlo.

With the 3 operands BranchAdd added in r196513, we can run into
a register allocation such that the destination register is also
used by a value in the stack map.

It use to be that BranchAdd was a 2 operand instruction.
In that form, the destination is also one of the source and
can be recovered through Sub. There is no conflict between
destination and the stackmap.

After r196513, the destination has its own value. It is uncommon
on x86 because of the aggressive aliasing but that can happen.
On ARM, that's a standard form since there is no need for aliasing.

Since the arguments of the stackmap are of type EarlyUse,
they appeared as not interfering with the destination. When the register
allocator gives the same register to the destination and something in
the stack map, the result of BranchAdd destroys the value kept alive
for the stackmap.

In this patch, I introduce a concept very similar to ForceLateUse
to keep the argument of the stackmap live in CheckAdd. The new
role is "ForceLateUseUnlessRecoverable".

In this mode, anything that is not also an input argument becomes
LateUse. As such, it interferes with the destination of CheckAdd.
The arguments are recovered by the slow patch of CheckAdd. They
remain Early use.

This new modes ensure that destination can be aliased to the source
when that's useful, while making sure it is not aliased with another
value that needs to be live on exit.

* b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::forEachArg):
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
* b3/B3PatchpointSpecial.cpp:
(JSC::B3::PatchpointSpecial::forEachArg):
* b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::forEachArgImpl):
(WTF::printInternal):
* b3/B3StackmapSpecial.h:
* b3/B3StackmapValue.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3CheckSpecial.cpp
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/B3PatchpointSpecial.cpp
trunk/Source/_javascript_Core/b3/B3StackmapSpecial.cpp
trunk/Source/_javascript_Core/b3/B3StackmapSpecial.h
trunk/Source/_javascript_Core/b3/B3StackmapValue.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (196615 => 196616)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-16 04:41:58 UTC (rev 196615)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-16 04:51:20 UTC (rev 196616)
@@ -1,3 +1,54 @@
+2016-02-15  Benjamin Poulain  
+
+[JSC] BranchAdd can override arguments of its stackmap
+https://bugs.webkit.org/show_bug.cgi?id=154274
+
+Reviewed by Filip Pizlo.
+
+With the 3 operands BranchAdd added in r196513, we can run into
+a register allocation such that the destination register is also
+used by a value in the stack map.
+
+It use to be that BranchAdd was a 2 operand instruction.
+In that form, the destination is also one of the source and
+can be recovered through Sub. There is no conflict between
+destination and the stackmap.
+
+After r196513, the destination has its own value. It is uncommon
+on x86 because of the aggressive aliasing but that can happen.
+On ARM, that's a standard form since there is no need for aliasing.
+
+Since the arguments of the stackmap are of type EarlyUse,
+they appeared as not interfering with the destination. When the register
+allocator gives the same register to the destination and something in
+the stack map, the result of BranchAdd destroys the value kept alive
+for the stackmap.
+
+In this patch, I introduce a concept very similar to ForceLateUse
+to keep the argument of the stackmap live in CheckAdd. The new
+role is "ForceLateUseUnlessRecoverable".
+
+In this mode, anything that is not also an input argument becomes
+LateUse. As such, it interferes with the destination of CheckAdd.
+The arguments are recovered by the slow patch of CheckAdd. They
+remain Early use.
+
+This new modes ensure that destination can be aliased to the source
+when that's useful, while making sure it is not aliased with another
+value that needs to be live on exit.
+
+* b3/B3CheckSpecial.cpp:
+(JSC::B3::CheckSpecial::forEachArg):
+* b3/B3LowerToAir.cpp:
+(JSC::B3::Air::LowerToAir::lower):
+* b3/B3PatchpointSpecial.cpp:
+(JSC::B3::PatchpointSpecial::forEachArg):
+* b3/B3StackmapSpecial.cpp:
+(JSC::B3::StackmapSpecial::forEachArgImpl):
+(WTF::printInternal):
+* 

[webkit-changes] [196614] trunk/Source/WebCore

[weinig]

Title: [196614] trunk/Source/WebCore








Revision 196614
Author wei...@apple.com
Date 2016-02-15 20:07:11 -0800 (Mon, 15 Feb 2016)


Log Message
Stop using NSMapTable in places where we were only using it to be GC safe

https://bugs.webkit.org/show_bug.cgi?id=154264

Reviewed by Dan Bernstein.

Switch from NSMapTable to HashMap.

* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMInternal.mm:
* bindings/objc/WebScriptObject.mm:
* bridge/objc/objc_instance.mm:
* platform/spi/cocoa/NSPointerFunctionsSPI.h: Removed. No longer used.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/objc/DOMInternal.h
trunk/Source/WebCore/bindings/objc/DOMInternal.mm
trunk/Source/WebCore/bindings/objc/WebScriptObject.mm
trunk/Source/WebCore/bridge/objc/objc_instance.mm


Removed Paths

trunk/Source/WebCore/platform/spi/cocoa/NSPointerFunctionsSPI.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (196613 => 196614)

--- trunk/Source/WebCore/ChangeLog	2016-02-16 02:32:55 UTC (rev 196613)
+++ trunk/Source/WebCore/ChangeLog	2016-02-16 04:07:11 UTC (rev 196614)
@@ -1,3 +1,20 @@
+2016-02-15  Sam Weinig  
+
+Stop using NSMapTable in places where we were only using it to be GC safe
+
+https://bugs.webkit.org/show_bug.cgi?id=154264
+
+Reviewed by Dan Bernstein.
+
+Switch from NSMapTable to HashMap.
+
+* WebCore.xcodeproj/project.pbxproj:
+* bindings/objc/DOMInternal.h:
+* bindings/objc/DOMInternal.mm:
+* bindings/objc/WebScriptObject.mm:
+* bridge/objc/objc_instance.mm:
+* platform/spi/cocoa/NSPointerFunctionsSPI.h: Removed. No longer used.
+
 2016-02-15  Myles C. Maxfield  
 
 [Font Loading] Implement FontFace _javascript_ object


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (196613 => 196614)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2016-02-16 02:32:55 UTC (rev 196613)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2016-02-16 04:07:11 UTC (rev 196614)
@@ -6186,7 +6186,6 @@
 		CE1252411A16B1B600864480 /* MediaPlayerSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE1252401A16B1B600864480 /* MediaPlayerSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		CE1252431A16C01A00864480 /* CoreUISPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE1252421A16C01A00864480 /* CoreUISPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		CE1252451A16C22500864480 /* DynamicLinkerSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE1252441A16C22500864480 /* DynamicLinkerSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		CE1252471A16C2C200864480 /* NSPointerFunctionsSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE1252461A16C2C200864480 /* NSPointerFunctionsSPI.h */; };
 		CE1252491A16C3BC00864480 /* MobileGestaltSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE1252481A16C3BC00864480 /* MobileGestaltSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		CE12524D1A1A77DE00864480 /* IOPMLibSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE12524C1A1A77DE00864480 /* IOPMLibSPI.h */; };
 		CE12524F1A1A78D200864480 /* MachVMSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE12524E1A1A78D200864480 /* MachVMSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -14165,7 +14164,6 @@
 		CE1252401A16B1B600864480 /* MediaPlayerSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MediaPlayerSPI.h; sourceTree = ""; };
 		CE1252421A16C01A00864480 /* CoreUISPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CoreUISPI.h; sourceTree = ""; };
 		CE1252441A16C22500864480 /* DynamicLinkerSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DynamicLinkerSPI.h; sourceTree = ""; };
-		CE1252461A16C2C200864480 /* NSPointerFunctionsSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSPointerFunctionsSPI.h; sourceTree = ""; };
 		CE1252481A16C3BC00864480 /* MobileGestaltSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MobileGestaltSPI.h; sourceTree = ""; };
 		CE12524C1A1A77DE00864480 /* IOPMLibSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IOPMLibSPI.h; sourceTree = ""; };
 		CE12524E1A1A78D200864480 /* MachVMSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MachVMSPI.h; sourceTree = ""; };
@@ -17525,7 +17523,6 @@
 31DF63561AF187DD0078FD91 /* NSColorSPI.h */,
 2DDB97F319F9AECA002025D8 /* NSExtensionSPI.h */,
 CE12523A1A16711000864480 /* NSFileManagerSPI.h */,
-CE1252461A16C2C200864480 /* NSPointerFunctionsSPI.h */,
 CE1252521A1BEC0600864480 /* NSStringSPI.h */,
 

[webkit-changes] [196613] trunk

[commit-queue]

Title: [196613] trunk








Revision 196613
Author commit-qu...@webkit.org
Date 2016-02-15 18:32:55 -0800 (Mon, 15 Feb 2016)


Log Message
Re-enable INTL on WinCairo
https://bugs.webkit.org/show_bug.cgi?id=154256

Patch by Alex Christensen  on 2016-02-15
Reviewed by Michael Catanzaro.

* Source/cmake/OptionsWin.cmake:
Peavo updated icu and it works, so let's re-enable INTL on WinCairo to catch Windows build failures.

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/OptionsWin.cmake




Diff

Modified: trunk/ChangeLog (196612 => 196613)

--- trunk/ChangeLog	2016-02-16 02:22:53 UTC (rev 196612)
+++ trunk/ChangeLog	2016-02-16 02:32:55 UTC (rev 196613)
@@ -1,3 +1,13 @@
+2016-02-15  Alex Christensen  
+
+Re-enable INTL on WinCairo
+https://bugs.webkit.org/show_bug.cgi?id=154256
+
+Reviewed by Michael Catanzaro.
+
+* Source/cmake/OptionsWin.cmake:
+Peavo updated icu and it works, so let's re-enable INTL on WinCairo to catch Windows build failures.
+
 2016-02-12  Csaba Osztrogonác  
 
 [EFL][GTK] Fix ENABLE(SVG_OTF_CONVERTER) build


Modified: trunk/Source/cmake/OptionsWin.cmake (196612 => 196613)

--- trunk/Source/cmake/OptionsWin.cmake	2016-02-16 02:22:53 UTC (rev 196612)
+++ trunk/Source/cmake/OptionsWin.cmake	2016-02-16 02:32:55 UTC (rev 196613)
@@ -37,7 +37,6 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ICONDATABASE PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTL PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_DATE PUBLIC OFF)
@@ -74,7 +73,6 @@
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_AUDIO PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_SOCKETS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_TIMING PUBLIC ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBVTT_REGIONS PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_XSLT PUBLIC ON)
 
@@ -83,9 +81,11 @@
 
 if (${WTF_PLATFORM_WIN_CAIRO})
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA_V2 PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTL PUBLIC ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC ON)
 else ()
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA_V2 PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTL PUBLIC OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC OFF)
 endif ()
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196612] branches/safari-601.1.46-branch/Source

[bshafiei]

Title: [196612] branches/safari-601.1.46-branch/Source








Revision 196612
Author bshaf...@apple.com
Date 2016-02-15 18:22:53 -0800 (Mon, 15 Feb 2016)


Log Message
Versioning.

Modified Paths

branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (196611 => 196612)

--- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-16 01:53:19 UTC (rev 196611)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-02-16 02:22:53 UTC (rev 196612)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 100;
+MICRO_VERSION = 101;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (196611 => 196612)

--- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2016-02-16 01:53:19 UTC (rev 196611)
+++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2016-02-16 02:22:53 UTC (rev 196612)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 100;
+MICRO_VERSION = 101;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (196611 => 196612)

--- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-16 01:53:19 UTC (rev 196611)
+++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-02-16 02:22:53 UTC (rev 196612)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 100;
+MICRO_VERSION = 101;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (196611 => 196612)

--- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-16 01:53:19 UTC (rev 196611)
+++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-02-16 02:22:53 UTC (rev 196612)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 100;
+MICRO_VERSION = 101;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (196611 => 196612)

--- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-02-16 01:53:19 UTC (rev 196611)
+++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-02-16 02:22:53 UTC (rev 196612)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 100;
+MICRO_VERSION = 101;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196611] trunk/LayoutTests

[ryanhaddad]

Title: [196611] trunk/LayoutTests








Revision 196611
Author ryanhad...@apple.com
Date 2016-02-15 17:53:19 -0800 (Mon, 15 Feb 2016)


Log Message
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196607

Unreviewed test gardening.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (196610 => 196611)

--- trunk/LayoutTests/ChangeLog	2016-02-16 00:50:21 UTC (rev 196610)
+++ trunk/LayoutTests/ChangeLog	2016-02-16 01:53:19 UTC (rev 196611)
@@ -1,3 +1,11 @@
+2016-02-15  Ryan Haddad  
+
+Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196607
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
+
 2016-02-15  Myles C. Maxfield  
 
 [Font Loading] Implement FontFace _javascript_ object


Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (196610 => 196611)

--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-16 00:50:21 UTC (rev 196610)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-16 01:53:19 UTC (rev 196611)
@@ -4087,7 +4087,7 @@
 PASS BarProp interface object name 
 PASS BarProp interface: existence and properties of interface prototype object 
 PASS BarProp interface: existence and properties of interface prototype object's "constructor" property 
-FAIL BarProp interface: attribute visible assert_equals: setter must be function for PutForwards, Replaceable, or non-readonly attributes expected "function" but got "undefined"
+PASS BarProp interface: attribute visible 
 PASS History interface: existence and properties of interface object 
 PASS History interface object length 
 PASS History interface object name 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196610] trunk/Source/WebInspectorUI

[commit-queue]

Title: [196610] trunk/Source/WebInspectorUI








Revision 196610
Author commit-qu...@webkit.org
Date 2016-02-15 16:50:21 -0800 (Mon, 15 Feb 2016)


Log Message
Web Inspector: Visual sidebar minor regression fixes
https://bugs.webkit.org/show_bug.cgi?id=154237


Patch by Devin Rousso  on 2016-02-15
Reviewed by Timothy Hatcher.

* UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder):
Do not display the placeholder, as it is not used in comma separated value
property editors.

(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle::before):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle): Deleted.
Added ::before to get rid of the "-" on subtitle elements (r196266).

* UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
Recalculates the width for all comma separated value elements (r196266).

(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
Only open/close sections with properties that have values when a new node
or selector item is selected.

(WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection):
Make copies of the default unit lists to prevent modifying the values used
later in other sections (r194728).

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (196609 => 196610)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-16 00:20:46 UTC (rev 196609)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-16 00:50:21 UTC (rev 196610)
@@ -1,3 +1,32 @@
+2016-02-15  Devin Rousso  
+
+Web Inspector: Visual sidebar minor regression fixes
+https://bugs.webkit.org/show_bug.cgi?id=154237
+
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
+(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder):
+Do not display the placeholder, as it is not used in comma separated value
+property editors.
+
+(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle::before):
+(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle): Deleted.
+Added ::before to get rid of the "-" on subtitle elements (r196266).
+
+* UserInterface/Views/VisualStyleDetailsPanel.js:
+(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
+Recalculates the width for all comma separated value elements (r196266).
+
+(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
+Only open/close sections with properties that have values when a new node
+or selector item is selected.
+
+(WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection):
+Make copies of the default unit lists to prevent modifying the values used
+later in other sections (r194728).
+
 2016-02-15  Matt Baker  
 
 Web Inspector: eliminate the linear and rendering frames TimelineOverview subclasses


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css (196609 => 196610)

--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css	2016-02-16 00:20:46 UTC (rev 196609)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css	2016-02-16 00:50:21 UTC (rev 196610)
@@ -32,6 +32,10 @@
 overflow: auto;
 }
 
+.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder {
+display: none;
+}
+
 .visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list {
 min-height: 51px;
 max-height: 94px;
@@ -90,7 +94,7 @@
 color: hsl(0, 0%, 83%);
 }
 

[webkit-changes] [196609] trunk/Source/WebKit2

[achristensen]

Title: [196609] trunk/Source/WebKit2








Revision 196609
Author achristen...@apple.com
Date 2016-02-15 16:20:46 -0800 (Mon, 15 Feb 2016)


Log Message
Implement content sniffing check with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=154261

Reviewed by Andy Estes.

This fixes http/tests/xmlhttprequest/small-chunks-response-text.html when using NetworkSession.

* NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::create):
* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::NetworkDataTask):
Content sniffing is enabled by default.  Disable it if the NetworkLoadParameters say not to.
This is analogous to behavior in ResourceHandle::createNSURLConnection.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h
trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196608 => 196609)

--- trunk/Source/WebKit2/ChangeLog	2016-02-16 00:17:19 UTC (rev 196608)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-16 00:20:46 UTC (rev 196609)
@@ -1,5 +1,23 @@
 2016-02-15  Alex Christensen  
 
+Implement content sniffing check with NetworkSession
+https://bugs.webkit.org/show_bug.cgi?id=154261
+
+Reviewed by Andy Estes.
+
+This fixes http/tests/xmlhttprequest/small-chunks-response-text.html when using NetworkSession.
+
+* NetworkProcess/NetworkDataTask.h:
+(WebKit::NetworkDataTask::create):
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::NetworkLoad):
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTask::NetworkDataTask):
+Content sniffing is enabled by default.  Disable it if the NetworkLoadParameters say not to.
+This is analogous to behavior in ResourceHandle::createNSURLConnection.
+
+2016-02-15  Alex Christensen  
+
 Move Download authentication code to AuthenticationManager
 https://bugs.webkit.org/show_bug.cgi?id=154132
 


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h (196608 => 196609)

--- trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h	2016-02-16 00:17:19 UTC (rev 196608)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkDataTask.h	2016-02-16 00:20:46 UTC (rev 196609)
@@ -28,6 +28,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -79,9 +80,9 @@
 class NetworkDataTask : public RefCounted {
 friend class NetworkSession;
 public:
-static Ref create(NetworkSession& session, NetworkDataTaskClient& client, const WebCore::ResourceRequest& request, WebCore::StoredCredentials storedCredentials)
+static Ref create(NetworkSession& session, NetworkDataTaskClient& client, const WebCore::ResourceRequest& request, WebCore::StoredCredentials storedCredentials, WebCore::ContentSniffingPolicy shouldContentSniff)
 {
-return adoptRef(*new NetworkDataTask(session, client, request, storedCredentials));
+return adoptRef(*new NetworkDataTask(session, client, request, storedCredentials, shouldContentSniff));
 }
 
 void suspend();
@@ -111,7 +112,7 @@
 bool tryPasswordBasedAuthentication(const WebCore::AuthenticationChallenge&, ChallengeCompletionHandler);
 
 private:
-NetworkDataTask(NetworkSession&, NetworkDataTaskClient&, const WebCore::ResourceRequest&, WebCore::StoredCredentials);
+NetworkDataTask(NetworkSession&, NetworkDataTaskClient&, const WebCore::ResourceRequest&, WebCore::StoredCredentials, WebCore::ContentSniffingPolicy);
 
 enum FailureType {
 NoFailure,


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp (196608 => 196609)

--- trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp	2016-02-16 00:17:19 UTC (rev 196608)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkLoad.cpp	2016-02-16 00:20:46 UTC (rev 196609)
@@ -54,7 +54,7 @@
 return;
 }
 if (auto* networkSession = SessionTracker::networkSession(parameters.sessionID)) {
-m_task = NetworkDataTask::create(*networkSession, *this, parameters.request, parameters.allowStoredCredentials);
+m_task = NetworkDataTask::create(*networkSession, *this, parameters.request, parameters.allowStoredCredentials, parameters.contentSniffingPolicy);
 if (!parameters.defersLoading)
 m_task->resume();
 } else


Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (196608 => 196609)

--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2016-02-16 00:17:19 UTC (rev 196608)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2016-02-16 00:20:46 UTC (rev 196609)
@@ -29,12 +29,13 @@
 #if USE(NETWORK_SESSION)
 
 #import 
+#import 
 #import 
 #import 
 
 namespace WebKit {
 

[webkit-changes] [196608] tags/Safari-601.1.46.100/

[bshafiei]

Title: [196608] tags/Safari-601.1.46.100/








Revision 196608
Author bshaf...@apple.com
Date 2016-02-15 16:17:19 -0800 (Mon, 15 Feb 2016)


Log Message
New tag.

Added Paths

tags/Safari-601.1.46.100/




Diff

Property changes: tags/Safari-601.1.46.100



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196607] trunk/LayoutTests/imported/w3c

[cdumez]

Title: [196607] trunk/LayoutTests/imported/w3c








Revision 196607
Author cdu...@apple.com
Date 2016-02-15 15:58:25 -0800 (Mon, 15 Feb 2016)


Log Message
Re-sync W3C web-platform-tests' html/dom/interfaces.html
https://bugs.webkit.org/show_bug.cgi?id=154259

Reviewed by Ryosuke Niwa.

Re-sync W3C web-platform-tests' html/dom/interfaces.html after:
- https://github.com/w3c/web-platform-tests/pull/2580

* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/html/dom/interfaces.html:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces.html




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196606 => 196607)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-15 23:57:25 UTC (rev 196606)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-15 23:58:25 UTC (rev 196607)
@@ -1,5 +1,18 @@
 2016-02-15  Chris Dumez  
 
+Re-sync W3C web-platform-tests' html/dom/interfaces.html
+https://bugs.webkit.org/show_bug.cgi?id=154259
+
+Reviewed by Ryosuke Niwa.
+
+Re-sync W3C web-platform-tests' html/dom/interfaces.html after:
+- https://github.com/w3c/web-platform-tests/pull/2580
+
+* web-platform-tests/html/dom/interfaces-expected.txt:
+* web-platform-tests/html/dom/interfaces.html:
+
+2016-02-15  Chris Dumez  
+
 XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
 https://bugs.webkit.org/show_bug.cgi?id=154230
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (196606 => 196607)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-15 23:57:25 UTC (rev 196606)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-15 23:58:25 UTC (rev 196607)
@@ -4087,7 +4087,7 @@
 PASS BarProp interface object name 
 PASS BarProp interface: existence and properties of interface prototype object 
 PASS BarProp interface: existence and properties of interface prototype object's "constructor" property 
-FAIL BarProp interface: attribute visible assert_equals: setter must be function for PutForwards, Replaceable, or non-readonly attributes expected "function" but got "undefined"
+PASS BarProp interface: attribute visible 
 PASS History interface: existence and properties of interface object 
 PASS History interface object length 
 PASS History interface object name 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces.html (196606 => 196607)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces.html	2016-02-15 23:57:25 UTC (rev 196606)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces.html	2016-02-15 23:58:25 UTC (rev 196607)
@@ -1,6 +1,6 @@
 
 
-
+
 HTML IDL tests
 
 @@ -468,7 +468,7 @@
   stringifier;
 //  iterable;
 };
-
+
 
 [Constructor(DOMString type, optional UIEventInit eventInitDict)]
 interface UIEvent : Event {
@@ -531,7 +531,7 @@
 void initMouseEvent (DOMString typeArg, boolean bubblesArg, boolean cancelableArg, Window? viewArg, long detailArg, long screenXArg, long screenYArg, long clientXArg, long clientYArg, boolean ctrlKeyArg, boolean altKeyArg, boolean shiftKeyArg, boolean metaKeyArg, short buttonArg, EventTarget? relatedTargetArg);
 };
 
-
+
 
 interface Touch {
 readonlyattribute longidentifier;
@@ -544,7 +544,7 @@
 readonlyattribute longpageY;
 };
 
-
+
 
 interface MediaList {
   stringifier attribute DOMString mediaText;
@@ -848,7 +848,7 @@
 //};
 
 
-
+
 

[webkit-changes] [196606] trunk/Source/WebInspectorUI

[mattbaker]

Title: [196606] trunk/Source/WebInspectorUI








Revision 196606
Author mattba...@apple.com
Date 2016-02-15 15:57:25 -0800 (Mon, 15 Feb 2016)


Log Message
Web Inspector: eliminate the linear and rendering frames TimelineOverview subclasses
https://bugs.webkit.org/show_bug.cgi?id=154000


Reviewed by Timothy Hatcher.

This patch eliminates the TimelineOverview subclasses, and moves logic for switching between
a time-based or frame-based graph into the overview itself. The values of the overview's start
time, current time, and end time now match the values in the timeline recording regardless of the
current view mode. When viewing the rendering frames graph, the recording times are ignored and
all frames are included. The overview maintains separate zoom level and ruler selection settings
for each view mode.

* UserInterface/Main.html:
* UserInterface/Views/LinearTimelineOverview.js: Removed.
* UserInterface/Views/RenderingFrameTimelineOverview.js: Removed.
Removed TimelineOverview subclasses.

* UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.get height):
Set FPS graph height to 108 pixels.

* UserInterface/Views/TimelineOverview.css:
(.timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:not(:first-child)):
(.timeline-overview > .graphs-container > .timeline-overview-graph:nth-child(even)): Deleted.
(.timeline-overview > .graphs-container > .timeline-overview-graph:not(:first-child)): Deleted.
Disable alternating graph styles when showing FPS instrument.

* UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview):
Create separate settings for timelines and FPS view modes.
(WebInspector.TimelineOverview.prototype.get viewMode):
(WebInspector.TimelineOverview.prototype.set viewMode):
(WebInspector.TimelineOverview.prototype.set startTime):
Adjust the current ruler selection when start time changes. Not necessary
when showing the FPS instrument, which doesn't have a start time.
(WebInspector.TimelineOverview.prototype.get secondsPerPixel):
(WebInspector.TimelineOverview.prototype.set secondsPerPixel):
Now a wrapper around the corresponding view mode setting.
(WebInspector.TimelineOverview.prototype.set pixelAlignDuration):
(WebInspector.TimelineOverview.prototype.get scrollStartTime):
(WebInspector.TimelineOverview.prototype.set scrollStartTime):
Now a wrapper around the corresponding view mode setting.
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.get height):
Return the sum height of all visible overview graphs.
(WebInspector.TimelineOverview.prototype.shown):
Show overview graphs for the current view mode.
(WebInspector.TimelineOverview.prototype.hidden):
(WebInspector.TimelineOverview.prototype.reset):
(WebInspector.TimelineOverview.prototype.recordWasFiltered):
(WebInspector.TimelineOverview.prototype.selectRecord):
(WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded):
(WebInspector.TimelineOverview.prototype.layout):
Layout for both view modes is largely identical, and differs only in the treatment
of the overview's start time, current time, and end time. Time-based instruments
use time values from the recording, while the FPS instrument has a fixed start time
of zero, and a current and end time pinned to the last rendering frame.
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
(WebInspector.TimelineOverview._handleGestureStart):
(WebInspector.TimelineOverview.prototype._handleGestureChange):
(WebInspector.TimelineOverview.prototype._instrumentAdded):
(WebInspector.TimelineOverview.prototype._instrumentRemoved):
(WebInspector.TimelineOverview.prototype._timelineRulerMouseClicked):
(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
Save the selection for the current view mode.
(WebInspector.TimelineOverview.prototype._recordSelected):
(WebInspector.TimelineOverview.prototype._resetSelection.reset):
(WebInspector.TimelineOverview.prototype._resetSelection):
(WebInspector.TimelineOverview.prototype._canShowTimelineType):
(WebInspector.TimelineOverview.prototype._viewModeDidChange):
Sets zoom level, ruler selection, and graph visibility based on current view mode.
(WebInspector.TimelineOverview.prototype._createViewModeSettings):
Helper function for creating an object to track the zoom level and ruler
selection of each view mode.
(WebInspector.TimelineOverview.prototype.get _currentSettings):
Internal getter for retrieving the settings for the current view mode.
(WebInspector.TimelineOverview.prototype.canShowTimeline): Deleted.
Not needed now that the overview contains all timelines.

* UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.shown):

[webkit-changes] [196605] trunk/Websites/perf.webkit.org

[rniwa]

Title: [196605] trunk/Websites/perf.webkit.org








Revision 196605
Author rn...@webkit.org
Date 2016-02-15 15:57:22 -0800 (Mon, 15 Feb 2016)


Log Message
v1 UI and v2 UI should share statistics.js
https://bugs.webkit.org/show_bug.cgi?id=154262

Reviewed by Chris Dumez.

Share statistics.js between v1 and v2 UI.

* public/index.html:
* public/js/shared.js: Deleted.
* public/js/statistics.js: Removed.
* public/shared: Added.
* public/shared/statistics.js: Moved from Websites/perf.webkit.org/public/v2/js/statistics.js.
* public/v2/index.html:
* public/v2/js/statistics.js: Removed.
* public/v3/index.html:
* tools/detect-changes.js:

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/index.html
trunk/Websites/perf.webkit.org/public/v2/index.html
trunk/Websites/perf.webkit.org/public/v3/index.html
trunk/Websites/perf.webkit.org/tools/detect-changes.js


Added Paths

trunk/Websites/perf.webkit.org/public/shared/
trunk/Websites/perf.webkit.org/public/shared/statistics.js


Removed Paths

trunk/Websites/perf.webkit.org/public/js/shared.js
trunk/Websites/perf.webkit.org/public/js/statistics.js
trunk/Websites/perf.webkit.org/public/v2/js/statistics.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (196604 => 196605)

--- trunk/Websites/perf.webkit.org/ChangeLog	2016-02-15 23:39:02 UTC (rev 196604)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2016-02-15 23:57:22 UTC (rev 196605)
@@ -1,3 +1,22 @@
+2016-02-15  Ryosuke Niwa  
+
+v1 UI and v2 UI should share statistics.js
+https://bugs.webkit.org/show_bug.cgi?id=154262
+
+Reviewed by Chris Dumez.
+
+Share statistics.js between v1 and v2 UI.
+
+* public/index.html:
+* public/js/shared.js: Deleted.
+* public/js/statistics.js: Removed.
+* public/shared: Added.
+* public/shared/statistics.js: Moved from Websites/perf.webkit.org/public/v2/js/statistics.js.
+* public/v2/index.html:
+* public/v2/js/statistics.js: Removed.
+* public/v3/index.html:
+* tools/detect-changes.js:
+
 2016-02-13  Ryosuke Niwa  
 
 v3 UI sometimes shows same dates twice on the x-axis of time series charts


Modified: trunk/Websites/perf.webkit.org/public/index.html (196604 => 196605)

--- trunk/Websites/perf.webkit.org/public/index.html	2016-02-15 23:39:02 UTC (rev 196604)
+++ trunk/Websites/perf.webkit.org/public/index.html	2016-02-15 23:57:22 UTC (rev 196605)
@@ -10,8 +10,7 @@
 
 
 
-
-
+
  

[webkit-changes] [196604] trunk

[mmaxfield]

Title: [196604] trunk








Revision 196604
Author mmaxfi...@apple.com
Date 2016-02-15 15:39:02 -0800 (Mon, 15 Feb 2016)


Log Message
[Font Loading] Implement FontFace _javascript_ object
https://bugs.webkit.org/show_bug.cgi?id=153345

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/text/font-face-_javascript_.html

This patch implements the FontFace _javascript_ object. This object mostly consists of
style getters / setters, which we implement by parsing input strings and generating
output strings similarly to getComputedStyle(). This object also has a load() function
which returns a promise which will be fulfilled or rejected depending on the load.
There is also a "loaded" attribute which exposes this promise directly. Also, a status
field is exposed so script knows what the state of the load is.

Currently, loading depends on our CachedResourceLoader which is part of the Document,
so this API is not available in a non-document context.

Another caveat is that immediate-mode font loading (where the content provides an
ArrayBuffer containing the bytes of the font file) is forthcoming. This requires
changing the relationship between CSSFontFaceSource and CachedFont.

CSSFontFace has been modified to keep a strong reference to the CSSFontSelector. This
is because the lifetime of the CSSFontFace can now outlive the CSSFontSelector. When
the CSSFontSelector is removed from the Document, it explicitly clears its constituent
CSSFontFaces, thereby breaking the reference cycle.

Test: fast/text/font-face-_javascript_-expected.html

* CMakeLists.txt: Add new files.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* WebCore.vcxproj/WebCore.vcxproj: Ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSDOMPromise.cpp:
(WebCore::DeferredWrapper::globalObject): Remove whitespace.
(WebCore::DeferredWrapper::deferred): Allow access to the inner JSC object.
* bindings/js/JSDOMPromise.h:
(WebCore::DOMPromise::deferred): Ditto.
* bindings/js/JSFontFaceCustom.cpp: Copied from Source/WebCore/bindings/js/JSDOMPromise.cpp.
(WebCore::JSFontFace::loaded):
(WebCore::JSFontFace::load):
* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::adoptSource):
(WebCore::CSSFontFace::updateStatus): Enforce the state machine's transitions.
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::pump):
(WebCore::CSSFontFace::load):
* css/CSSFontFace.h:
(WebCore::CSSFontFaceClient::~CSSFontFaceClient):
(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::status):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::appendSources): Update for new CSSFontFace API.
(WebCore::CSSFontSelector::registerLocalFontFacesForFamily): Ditto.
(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
(WebCore::CSSFontSelector::kick): Ditto.
(WebCore::appendSources): Deleted.
(WebCore::registerLocalFontFacesForFamily): Deleted.
* css/CSSFontSelector.h:
* css/CSSUnicodeRangeValue.cpp: Use for serializing the "unicodeRange" property.
* css/FontFace.cpp:
(WebCore::createPromise): Implement the remaining _javascript_ API functions.
(WebCore::valueFromDictionary):
(WebCore::FontFace::create):
(WebCore::FontFace::FontFace):
(WebCore::FontFace::parseString):
(WebCore::FontFace::status):
(WebCore::FontFace::kick):
(WebCore::FontFace::load):
(WebCore::FontFace::fulfillPromise):
(WebCore::FontFace::rejectPromise):
(WebCore::parseString): Deleted.
* css/FontFace.h:
(WebCore::FontFace::promise):
(WebCore::FontFace::backing):
(WebCore::FontFace::create): Deleted.
* css/FontFace.idl: Copied from Source/WebCore/bindings/js/JSDOMPromise.cpp.

LayoutTests:

* fast/text/font-face-_javascript_-expected.txt: Added.
* fast/text/font-face-_javascript_.html: Added.
* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.cpp

[webkit-changes] [196602] trunk/Source/WebCore

[jer . noble]

Title: [196602] trunk/Source/WebCore








Revision 196602
Author jer.no...@apple.com
Date 2016-02-15 14:36:00 -0800 (Mon, 15 Feb 2016)


Log Message
Null-deref crash in DefaultAudioDestinationNode::suspend()
https://bugs.webkit.org/show_bug.cgi?id=154248

Reviewed by Alex Christensen.

Null-check scriptExecutionContext() before deref.

* Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (196601 => 196602)

--- trunk/Source/WebCore/ChangeLog	2016-02-15 22:33:25 UTC (rev 196601)
+++ trunk/Source/WebCore/ChangeLog	2016-02-15 22:36:00 UTC (rev 196602)
@@ -1,3 +1,17 @@
+2016-02-15  Jer Noble  
+
+Null-deref crash in DefaultAudioDestinationNode::suspend()
+https://bugs.webkit.org/show_bug.cgi?id=154248
+
+Reviewed by Alex Christensen.
+
+Null-check scriptExecutionContext() before deref.
+
+* Modules/webaudio/DefaultAudioDestinationNode.cpp:
+(WebCore::DefaultAudioDestinationNode::resume):
+(WebCore::DefaultAudioDestinationNode::suspend):
+(WebCore::DefaultAudioDestinationNode::close):
+
 2016-02-15  Chris Dumez  
 
 XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget


Modified: trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp (196601 => 196602)

--- trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp	2016-02-15 22:33:25 UTC (rev 196601)
+++ trunk/Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp	2016-02-15 22:36:00 UTC (rev 196602)
@@ -111,7 +111,8 @@
 ASSERT(isInitialized());
 if (isInitialized())
 m_destination->start();
-context()->scriptExecutionContext()->postTask(function);
+if (auto scriptExecutionContext = context()->scriptExecutionContext())
+scriptExecutionContext->postTask(function);
 }
 
 void DefaultAudioDestinationNode::suspend(std::function function)
@@ -119,14 +120,16 @@
 ASSERT(isInitialized());
 if (isInitialized())
 m_destination->stop();
-context()->scriptExecutionContext()->postTask(function);
+if (auto scriptExecutionContext = context()->scriptExecutionContext())
+scriptExecutionContext->postTask(function);
 }
 
 void DefaultAudioDestinationNode::close(std::function function)
 {
 ASSERT(isInitialized());
 uninitialize();
-context()->scriptExecutionContext()->postTask(function);
+if (auto scriptExecutionContext = context()->scriptExecutionContext())
+scriptExecutionContext->postTask(function);
 }
 
 unsigned long DefaultAudioDestinationNode::maxChannelCount() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196601] trunk/Tools

[ossy]

Title: [196601] trunk/Tools








Revision 196601
Author o...@webkit.org
Date 2016-02-15 14:33:25 -0800 (Mon, 15 Feb 2016)


Log Message
[EFL] Update Tools/efl/install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=154239

Reviewed by Michael Catanzaro.

* efl/install-dependencies:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/efl/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (196600 => 196601)

--- trunk/Tools/ChangeLog	2016-02-15 22:25:49 UTC (rev 196600)
+++ trunk/Tools/ChangeLog	2016-02-15 22:33:25 UTC (rev 196601)
@@ -1,3 +1,12 @@
+2016-02-15  Csaba Osztrogonác  
+
+[EFL] Update Tools/efl/install-dependencies
+https://bugs.webkit.org/show_bug.cgi?id=154239
+
+Reviewed by Michael Catanzaro.
+
+* efl/install-dependencies:
+
 2016-02-15  Alex Christensen  
 
 Fix internal Windows build of projects built after WebKit


Modified: trunk/Tools/efl/install-dependencies (196600 => 196601)

--- trunk/Tools/efl/install-dependencies	2016-02-15 22:25:49 UTC (rev 196600)
+++ trunk/Tools/efl/install-dependencies	2016-02-15 22:33:25 UTC (rev 196601)
@@ -80,7 +80,7 @@
 libmpg123-dev \
 liborc-0.4-dev \
 libp11-kit-dev \
-libpng-dev \
+libpng12-dev \
 libpulse-dev \
 libsqlite3-dev \
 libssl-dev \
@@ -92,7 +92,6 @@
 libxcomposite-dev \
 libxcursor-dev \
 libxinerama-dev \
-libxp-dev \
 libxrandr-dev \
 libxrender-dev \
 libxslt1-dev \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196600] trunk/Source/WebKit2

[achristensen]

Title: [196600] trunk/Source/WebKit2








Revision 196600
Author achristen...@apple.com
Date 2016-02-15 14:25:49 -0800 (Mon, 15 Feb 2016)


Log Message
Move Download authentication code to AuthenticationManager
https://bugs.webkit.org/show_bug.cgi?id=154132

Reviewed by Sam Weinig.

When a video element makes a request that receives an authentication challenge, the
AuthenticationManager receives an AuthenticationChallenge without an AuthenticationClient.
As a result, Download::receivedCredential and other functions were being called, which
sent a message to the challenge's sender.  This functionality is not specific to downloads,
so I moved it from Download to AuthenticationManager.

This fixes http/tests/media/video-auth.html when using NetworkSession 
because I use AuthenticationManager::receivedCredential if there is no AuthenticationClient
instead of improperly asserting that there is always an AuthenticationClient if there is no
completionHandler.

* NetworkProcess/Downloads/Download.h:
* NetworkProcess/Downloads/ios/DownloadIOS.mm:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
* NetworkProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
* NetworkProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::continueWithoutCredential): Deleted.
(WebKit::Download::useCredential): Deleted.
(WebKit::Download::cancelAuthenticationChallenge): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* PlatformMac.cmake:
* Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandling):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
* Shared/Authentication/AuthenticationManager.h:
(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):
* Shared/Authentication/cocoa: Added.
* Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: Added.
(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):
* Shared/Authentication/soup: Added.
* Shared/Authentication/soup/AuthenticationManagerSoup.cpp: Added.
(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/Downloads/Download.h
trunk/Source/WebKit2/NetworkProcess/Downloads/ios/DownloadIOS.mm
trunk/Source/WebKit2/NetworkProcess/Downloads/mac/DownloadMac.mm
trunk/Source/WebKit2/NetworkProcess/Downloads/soup/DownloadSoup.cpp
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/PlatformGTK.cmake
trunk/Source/WebKit2/PlatformMac.cmake
trunk/Source/WebKit2/Shared/Authentication/AuthenticationManager.cpp
trunk/Source/WebKit2/Shared/Authentication/AuthenticationManager.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit2/Shared/Authentication/cocoa/
trunk/Source/WebKit2/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm
trunk/Source/WebKit2/Shared/Authentication/soup/

[webkit-changes] [196599] trunk

[cdumez]

Title: [196599] trunk








Revision 196599
Author cdu...@apple.com
Date 2016-02-15 14:03:04 -0800 (Mon, 15 Feb 2016)


Log Message
XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
https://bugs.webkit.org/show_bug.cgi?id=154230

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline now that more checks are passing.

* web-platform-tests/XMLHttpRequest/interfaces-expected.txt:

Source/WebCore:

MLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
as per:
https://xhr.spec.whatwg.org/#xmlhttprequesteventtarget

Firefox and Chrome already match the specification.

No new tests, already covered by existing tests.

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestEventTarget.h: Added.
* xml/XMLHttpRequestEventTarget.idl: Copied from Source/WebCore/xml/XMLHttpRequestUpload.idl.
* xml/XMLHttpRequestUpload.h:
* xml/XMLHttpRequestUpload.idl:

LayoutTests:

Rebaseline tests now that XMLHttpRequestEventTarget is exposed on the
global objects.

* js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/interfaces-expected.txt
trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt
trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/xml/XMLHttpRequest.h
trunk/Source/WebCore/xml/XMLHttpRequest.idl
trunk/Source/WebCore/xml/XMLHttpRequestUpload.h
trunk/Source/WebCore/xml/XMLHttpRequestUpload.idl


Added Paths

trunk/Source/WebCore/xml/XMLHttpRequestEventTarget.h
trunk/Source/WebCore/xml/XMLHttpRequestEventTarget.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (196598 => 196599)

--- trunk/LayoutTests/ChangeLog	2016-02-15 21:38:25 UTC (rev 196598)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 22:03:04 UTC (rev 196599)
@@ -1,3 +1,23 @@
+2016-02-15  Chris Dumez  
+
+XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
+https://bugs.webkit.org/show_bug.cgi?id=154230
+
+Reviewed by Alex Christensen.
+
+Rebaseline tests now that XMLHttpRequestEventTarget is exposed on the
+global objects.
+
+* js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
+* js/dom/global-constructors-attributes-expected.txt:
+* platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
+* platform/efl/js/dom/global-constructors-attributes-expected.txt:
+* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+* platform/win/js/dom/global-constructors-attributes-expected.txt:
+
 2016-02-15  Jiewen Tan  
 
 Refine SimulatedMouseEvent to support Event.isTrusted


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196598 => 196599)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-15 21:38:25 UTC (rev 196598)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-15 22:03:04 UTC (rev 196599)
@@ -1,3 +1,14 @@

[webkit-changes] [196598] trunk

[jiewen_tan]

Title: [196598] trunk








Revision 196598
Author jiewen_...@apple.com
Date 2016-02-15 13:38:25 -0800 (Mon, 15 Feb 2016)


Log Message
Refine SimulatedMouseEvent to support Event.isTrusted
https://bugs.webkit.org/show_bug.cgi?id=154133


Reviewed by Darin Adler.

Source/WebCore:

This patch extracts everything related to create/dispatch SimulatedMouseEvent from MouseEvent.h/cpp
and EventDispatcher.h/cpp, and produces SimulateClick.h/cpp which will handle simulated click solely.
After that, we hide the SimulatedMouseEvent and only expose simulateClick to be called. The reason is
that we both want to tell whether the call sites are from user agent/bindings and keep the
SimulatedMouseEvent intact.

Also, this patch separate Element::dispatchSimulatedClick into two: one for the user agent, and another
for the bindings. Therefore, HTMLElement.click will be treated as untrusted.

Some of the changes in this patch referred Blink r200401:
https://codereview.chromium.org/1285793004

Modified test:
LayoutTests/imported/blink/fast/events/event-trusted.html

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.cpp:
(WebCore::Element::dispatchSimulatedClick):
(WebCore::Element::dispatchSimulatedClickForBindings):
* dom/Element.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick): Deleted.
* dom/EventDispatcher.h:
* dom/MouseEvent.cpp:
(WebCore::SimulatedMouseEvent::create): Deleted.
(WebCore::SimulatedMouseEvent::~SimulatedMouseEvent): Deleted.
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent): Deleted.
* dom/MouseEvent.h:
* dom/SimulatedClick.cpp: Added.
(WebCore::simulateMouseEvent):
(WebCore::simulateClick):
* dom/SimulatedClick.h: Added.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::click):

LayoutTests:

* imported/blink/fast/events/event-trusted-expected.txt:
* imported/blink/fast/events/event-trusted.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/blink/fast/events/event-trusted-expected.txt
trunk/LayoutTests/imported/blink/fast/events/event-trusted.html
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventDispatcher.h
trunk/Source/WebCore/dom/MouseEvent.cpp
trunk/Source/WebCore/dom/MouseEvent.h
trunk/Source/WebCore/html/HTMLElement.cpp


Added Paths

trunk/Source/WebCore/dom/SimulatedClick.cpp
trunk/Source/WebCore/dom/SimulatedClick.h




Diff

Modified: trunk/LayoutTests/ChangeLog (196597 => 196598)

--- trunk/LayoutTests/ChangeLog	2016-02-15 21:37:10 UTC (rev 196597)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 21:38:25 UTC (rev 196598)
@@ -1,3 +1,14 @@
+2016-02-15  Jiewen Tan  
+
+Refine SimulatedMouseEvent to support Event.isTrusted
+https://bugs.webkit.org/show_bug.cgi?id=154133
+
+
+Reviewed by Darin Adler.
+
+* imported/blink/fast/events/event-trusted-expected.txt:
+* imported/blink/fast/events/event-trusted.html:
+
 2016-02-15  Ryan Haddad  
 
 Marking animations/animation-delay-changed.html as flaky on ios-simulator


Modified: trunk/LayoutTests/imported/blink/fast/events/event-trusted-expected.txt (196597 => 196598)

--- trunk/LayoutTests/imported/blink/fast/events/event-trusted-expected.txt	2016-02-15 21:37:10 UTC (rev 196597)
+++ trunk/LayoutTests/imported/blink/fast/events/event-trusted-expected.txt	2016-02-15 21:38:25 UTC (rev 196598)
@@ -8,6 +8,7 @@
 PASS originalEvent.isTrusted is true
 PASS redispatched is true
 PASS originalEvent.isTrusted is false
+PASS originalEvent.isTrusted is false
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/imported/blink/fast/events/event-trusted.html (196597 => 196598)

--- trunk/LayoutTests/imported/blink/fast/events/event-trusted.html	2016-02-15 21:37:10 UTC (rev 196597)
+++ trunk/LayoutTests/imported/blink/fast/events/event-trusted.html	2016-02-15 21:38:25 UTC (rev 196598)
@@ -36,6 +36,12 @@
 element.dispatchEvent(originalEvent);
 shouldBeTrue("redispatched");
 shouldBeFalse("originalEvent.isTrusted");
+
+originalEvent = null;
+element.removeEventListener('click', redispatch);
+element.addEventListener('click', originalDispatch);
+element.click();
+shouldBeFalse("originalEvent.isTrusted");
 }
 
 


Modified: trunk/Source/WebCore/CMakeLists.txt (196597 => 196598)

--- trunk/Source/WebCore/CMakeLists.txt	2016-02-15 21:37:10 UTC (rev 196597)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-02-15 21:38:25 UTC (rev 196598)
@@ -1510,6 +1510,7 @@
 dom/SecurityOriginPolicy.cpp
 dom/SelectorQuery.cpp
 dom/ShadowRoot.cpp
+dom/SimulatedClick.cpp
 dom/SlotAssignment.cpp
 dom/SpaceSplitString.cpp
 dom/StaticNodeList.cpp


Modified: trunk/Source/WebCore/ChangeLog (196597 => 196598)

--- 

[webkit-changes] [196597] trunk/Source/WebInspectorUI

[timothy]

Title: [196597] trunk/Source/WebInspectorUI








Revision 196597
Author timo...@apple.com
Date 2016-02-15 13:37:10 -0800 (Mon, 15 Feb 2016)


Log Message
Web Inspector: Show inherited CSS variables in the Style sidebar
https://bugs.webkit.org/show_bug.cgi?id=154215
rdar://problem/24644058

Reviewed by Joseph Pecoraro.

* UserInterface/Models/CSSProperty.js:
(WebInspector.CSSProperty.isInheritedPropertyName): Added.
(WebInspector.CSSProperty.prototype.update): Use WebInspector.CSSProperty.isInheritedPropertyName.
* UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload): Use WebInspector.CSSProperty.isInheritedPropertyName.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js
trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (196596 => 196597)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-15 21:30:00 UTC (rev 196596)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-15 21:37:10 UTC (rev 196597)
@@ -1,5 +1,19 @@
 2016-02-15  Timothy Hatcher  
 
+Web Inspector: Show inherited CSS variables in the Style sidebar
+https://bugs.webkit.org/show_bug.cgi?id=154215
+rdar://problem/24644058
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Models/CSSProperty.js:
+(WebInspector.CSSProperty.isInheritedPropertyName): Added.
+(WebInspector.CSSProperty.prototype.update): Use WebInspector.CSSProperty.isInheritedPropertyName.
+* UserInterface/Models/DOMNodeStyles.js:
+(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload): Use WebInspector.CSSProperty.isInheritedPropertyName.
+
+2016-02-15  Timothy Hatcher  
+
 Web Inspector: Sidebars are defaulting to their minimum width, instead of a good width
 https://bugs.webkit.org/show_bug.cgi?id=154218
 rdar://problem/24644192


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js (196596 => 196597)

--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js	2016-02-15 21:30:00 UTC (rev 196596)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js	2016-02-15 21:37:10 UTC (rev 196597)
@@ -35,6 +35,17 @@
 this.update(text, name, value, priority, enabled, overridden, implicit, anonymous, valid, styleSheetTextRange, true);
 }
 
+// Static
+
+static isInheritedPropertyName(name)
+{
+console.assert(typeof name === "string");
+if (name in WebInspector.CSSKeywordCompletions.InheritedProperties)
+return true;
+// Check if the name is a CSS variable.
+return name.startsWith("--");
+}
+
 // Public
 
 get ownerStyle()
@@ -90,7 +101,7 @@
 this._enabled = enabled;
 this._implicit = implicit;
 this._anonymous = anonymous;
-this._inherited = name in WebInspector.CSSKeywordCompletions.InheritedProperties;
+this._inherited = WebInspector.CSSProperty.isInheritedPropertyName(name);
 this._valid = valid;
 this._styleSheetTextRange = styleSheetTextRange || null;
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js (196596 => 196597)

--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js	2016-02-15 21:30:00 UTC (rev 196596)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js	2016-02-15 21:37:10 UTC (rev 196597)
@@ -614,7 +614,7 @@
 for (var i = 0; payload.cssProperties && i < payload.cssProperties.length; ++i) {
 var propertyPayload = payload.cssProperties[i];
 
-if (inherited && propertyPayload.name in WebInspector.CSSKeywordCompletions.InheritedProperties)
+if (inherited && WebInspector.CSSProperty.isInheritedPropertyName(propertyPayload.name))
 ++inheritedPropertyCount;
 
 var property = this._parseStylePropertyPayload(propertyPayload, i, styleDeclaration, text);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196596] trunk/Source/WebInspectorUI

[timothy]

Title: [196596] trunk/Source/WebInspectorUI








Revision 196596
Author timo...@apple.com
Date 2016-02-15 13:30:00 -0800 (Mon, 15 Feb 2016)


Log Message
Web Inspector: Sidebars are defaulting to their minimum width, instead of a good width
https://bugs.webkit.org/show_bug.cgi?id=154218
rdar://problem/24644192

Reviewed by Joseph Pecoraro.

* UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel): Default the setting value to 300 instead of 0, so the minimum isn't used.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (196595 => 196596)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-15 21:25:01 UTC (rev 196595)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-15 21:30:00 UTC (rev 196596)
@@ -1,5 +1,16 @@
 2016-02-15  Timothy Hatcher  
 
+Web Inspector: Sidebars are defaulting to their minimum width, instead of a good width
+https://bugs.webkit.org/show_bug.cgi?id=154218
+rdar://problem/24644192
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/SidebarPanel.js:
+(WebInspector.SidebarPanel): Default the setting value to 300 instead of 0, so the minimum isn't used.
+
+2016-02-15  Timothy Hatcher  
+
 Web Inspector: CSS variables are not formatted correctly
 https://bugs.webkit.org/show_bug.cgi?id=154217
 rdar://problem/24644154


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js (196595 => 196596)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js	2016-02-15 21:25:01 UTC (rev 196595)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js	2016-02-15 21:30:00 UTC (rev 196596)
@@ -33,7 +33,7 @@
 this._displayName = displayName;
 this._selected = false;
 
-this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 0);
+this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 300);
 this._savedScrollPosition = 0;
 
 this.element.classList.add("panel", identifier);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196595] trunk/LayoutTests

[ryanhaddad]

Title: [196595] trunk/LayoutTests








Revision 196595
Author ryanhad...@apple.com
Date 2016-02-15 13:25:01 -0800 (Mon, 15 Feb 2016)


Log Message
Marking animations/animation-delay-changed.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=154253

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (196594 => 196595)

--- trunk/LayoutTests/ChangeLog	2016-02-15 21:23:23 UTC (rev 196594)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 21:25:01 UTC (rev 196595)
@@ -1,3 +1,13 @@
+2016-02-15  Ryan Haddad  
+
+Marking animations/animation-delay-changed.html as flaky on ios-simulator
+https://bugs.webkit.org/show_bug.cgi?id=154253
+
+Unreviewed test gardening.
+
+* platform/ios-simulator-wk2/TestExpectations:
+* platform/ios-simulator/TestExpectations:
+
 2016-02-15  Joseph Pecoraro  
 
 Web Inspector: Web Workers have no access to console for debugging


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (196594 => 196595)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-02-15 21:23:23 UTC (rev 196594)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-02-15 21:25:01 UTC (rev 196595)
@@ -2918,4 +2918,6 @@
 
 webkit.org/b/153029 fast/css-generated-content/details-summary-before-after.html [ Failure ]
 
-webkit.org/b/76121 imported/blink/fast/events/event-trusted.html [ Skip ]
\ No newline at end of file
+webkit.org/b/76121 imported/blink/fast/events/event-trusted.html [ Skip ]
+
+webkit.org/b/154253 animations/animation-delay-changed.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (196594 => 196595)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-02-15 21:23:23 UTC (rev 196594)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2016-02-15 21:25:01 UTC (rev 196595)
@@ -16,7 +16,6 @@
 
 # Animation tests with issues
 animations/animation-direction-normal.html [ Pass Crash ]
-animations/animation-delay-changed.html [ Pass Crash ]
 animations/cross-fade-background-image.html [ ImageOnlyFailure ]
 
 # Compositing tests that fail:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196594] trunk

[commit-queue]

Title: [196594] trunk








Revision 196594
Author commit-qu...@webkit.org
Date 2016-02-15 13:23:23 -0800 (Mon, 15 Feb 2016)


Log Message
Web Inspector: Web Workers have no access to console for debugging
https://bugs.webkit.org/show_bug.cgi?id=26237

Patch by Joseph Pecoraro  on 2016-02-15
Reviewed by Timothy Hatcher.

LayoutTests/imported/w3c:

* web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt:
Update test results for a console.warn message that the test produces from a Worker.

Source/_javascript_Core:

* inspector/ConsoleMessage.h:
Add accessor for MessageLevel.

Source/WebCore:

This adds the most basic console message support to Workers.
Messages logged from workers get surfaced through the Page's console.
This lacks support for logging and interacting with arguments,
which would be addressed when adding more complete Worker
debugging tools.

Test: inspector/console/messageAdded-from-worker.html

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
Add new files.

* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
Set the ConsoleClient for the Worker's global object. We route
the messages to the Page's console.

* bindings/js/WorkerScriptController.h:
* workers/WorkerConsoleClient.h: Added.
* workers/WorkerConsoleClient.cpp: Added.
(WebCore::WorkerConsoleClient::WorkerConsoleClient):
(WebCore::WorkerConsoleClient::~WorkerConsoleClient):
(WebCore::WorkerConsoleClient::profile):
(WebCore::WorkerConsoleClient::profileEnd):
(WebCore::WorkerConsoleClient::count):
(WebCore::WorkerConsoleClient::time):
(WebCore::WorkerConsoleClient::timeEnd):
(WebCore::WorkerConsoleClient::timeStamp):
Stub most console methods in a Worker.

(WebCore::WorkerConsoleClient::messageWithTypeAndLevel):
Send worker log messages to the global scope and on to the main page.

* workers/WorkerGlobalScope.h:
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessageToWorkerConsole):
Ideally we want to converge on simple addConsoleMessage
APIs that just take a ConsoleMessage, without a barrage
of parameters. Add these versions now.

LayoutTests:

* inspector/console/messageAdded-from-worker-expected.txt: Added.
* inspector/console/messageAdded-from-worker.html: Added.
* inspector/console/resources/worker-console-log.js: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/ConsoleMessage.h
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WorkerScriptController.cpp
trunk/Source/WebCore/bindings/js/WorkerScriptController.h
trunk/Source/WebCore/workers/WorkerGlobalScope.cpp
trunk/Source/WebCore/workers/WorkerGlobalScope.h


Added Paths

trunk/LayoutTests/inspector/console/messageAdded-from-worker-expected.txt
trunk/LayoutTests/inspector/console/messageAdded-from-worker.html
trunk/LayoutTests/inspector/console/resources/worker-console-log.js
trunk/Source/WebCore/workers/WorkerConsoleClient.cpp
trunk/Source/WebCore/workers/WorkerConsoleClient.h




Diff

Modified: trunk/LayoutTests/ChangeLog (196593 => 196594)

--- trunk/LayoutTests/ChangeLog	2016-02-15 21:16:40 UTC (rev 196593)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 21:23:23 UTC (rev 196594)
@@ -1,3 +1,14 @@
+2016-02-15  Joseph Pecoraro  
+
+Web Inspector: Web Workers have no access to console for debugging
+https://bugs.webkit.org/show_bug.cgi?id=26237
+
+Reviewed by Timothy Hatcher.
+
+* inspector/console/messageAdded-from-worker-expected.txt: Added.
+* inspector/console/messageAdded-from-worker.html: Added.
+* inspector/console/resources/worker-console-log.js: Added.
+
 2016-02-15  Timothy Hatcher  
 
 Web Inspector: CSS variables are not formatted correctly


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (196593 => 196594)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-15 21:16:40 UTC (rev 196593)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-02-15 21:23:23 UTC (rev 196594)
@@ -1,3 +1,13 @@
+2016-02-15  Joseph Pecoraro  
+
+Web Inspector: Web Workers have no access to console for debugging
+https://bugs.webkit.org/show_bug.cgi?id=26237
+
+Reviewed by Timothy Hatcher.
+
+* web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt:
+Update test results for a console.warn message that the test produces from a Worker.
+
 2016-02-14  Chris Dumez  
 
 Window and WorkerGlobalScope should inherit EventTarget


Modified: 

[webkit-changes] [196593] trunk

[timothy]

Title: [196593] trunk








Revision 196593
Author timo...@apple.com
Date 2016-02-15 13:16:40 -0800 (Mon, 15 Feb 2016)


Log Message
Web Inspector: CSS variables are not formatted correctly
https://bugs.webkit.org/show_bug.cgi?id=154217
rdar://problem/24644154

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

* UserInterface/Views/CodeMirrorFormatters.js:
(newlineBeforeToken): Check for `variable-2` token in the `maybeprop` state.

LayoutTests:

* inspector/codemirror/prettyprinting-css-rules-expected.txt:
* inspector/codemirror/prettyprinting-css-rules.html:
* inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables-expected.css: Added.
* inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables.css: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/codemirror/prettyprinting-css-rules-expected.txt
trunk/LayoutTests/inspector/codemirror/prettyprinting-css-rules.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js


Added Paths

trunk/LayoutTests/inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables-expected.css
trunk/LayoutTests/inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables.css




Diff

Modified: trunk/LayoutTests/ChangeLog (196592 => 196593)

--- trunk/LayoutTests/ChangeLog	2016-02-15 21:13:24 UTC (rev 196592)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 21:16:40 UTC (rev 196593)
@@ -1,3 +1,16 @@
+2016-02-15  Timothy Hatcher  
+
+Web Inspector: CSS variables are not formatted correctly
+https://bugs.webkit.org/show_bug.cgi?id=154217
+rdar://problem/24644154
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/codemirror/prettyprinting-css-rules-expected.txt:
+* inspector/codemirror/prettyprinting-css-rules.html:
+* inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables-expected.css: Added.
+* inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables.css: Added.
+
 2016-02-15  Chris Dumez  
 
 Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this'


Modified: trunk/LayoutTests/inspector/codemirror/prettyprinting-css-rules-expected.txt (196592 => 196593)

--- trunk/LayoutTests/inspector/codemirror/prettyprinting-css-rules-expected.txt	2016-02-15 21:13:24 UTC (rev 196592)
+++ trunk/LayoutTests/inspector/codemirror/prettyprinting-css-rules-expected.txt	2016-02-15 21:16:40 UTC (rev 196593)
@@ -86,3 +86,6 @@
 -- Running test case: CodeMirror.PrettyPrinting.CSSRules.keep-prefixed-value.css
 PASS
 
+-- Running test case: CodeMirror.PrettyPrinting.CSSRules.css-variables.css
+PASS
+


Modified: trunk/LayoutTests/inspector/codemirror/prettyprinting-css-rules.html (196592 => 196593)

--- trunk/LayoutTests/inspector/codemirror/prettyprinting-css-rules.html	2016-02-15 21:13:24 UTC (rev 196592)
+++ trunk/LayoutTests/inspector/codemirror/prettyprinting-css-rules.html	2016-02-15 21:16:40 UTC (rev 196593)
@@ -37,6 +37,7 @@
 "resources/prettyprinting/css-rule-tests/do-not-append-semicolon.css",
 "resources/prettyprinting/css-rule-tests/do-not-add-whitespace-before-prefixed-property-value.css",
 "resources/prettyprinting/css-rule-tests/keep-prefixed-value.css",
+"resources/prettyprinting/css-rule-tests/css-variables.css",
 ]);
 
 suite.runTestCasesAndFinish();


Added: trunk/LayoutTests/inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables-expected.css (0 => 196593)

--- trunk/LayoutTests/inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables-expected.css	(rev 0)
+++ trunk/LayoutTests/inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables-expected.css	2016-02-15 21:16:40 UTC (rev 196593)
@@ -0,0 +1,4 @@
+color: var(--foo-color);
+--foo-color: red;
+--foo-index: 1;
+--foo-bar: 0;


Added: trunk/LayoutTests/inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables.css (0 => 196593)

--- trunk/LayoutTests/inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables.css	(rev 0)
+++ trunk/LayoutTests/inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables.css	2016-02-15 21:16:40 UTC (rev 196593)
@@ -0,0 +1,3 @@
+color: var(--foo-color);
+--foo-color: red; --foo-index: 1;
+--foo-bar:0;
\ No newline at end of file


Modified: trunk/Source/WebInspectorUI/ChangeLog (196592 => 196593)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-15 21:13:24 UTC (rev 196592)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-15 21:16:40 UTC (rev 196593)
@@ -1,5 +1,16 @@
 2016-02-15  Timothy Hatcher  
 
+Web Inspector: CSS variables are not formatted correctly
+https://bugs.webkit.org/show_bug.cgi?id=154217
+rdar://problem/24644154
+
+

[webkit-changes] [196592] trunk/Source/WebInspectorUI

[timothy]

Title: [196592] trunk/Source/WebInspectorUI








Revision 196592
Author timo...@apple.com
Date 2016-02-15 13:13:24 -0800 (Mon, 15 Feb 2016)


Log Message
Web Inspector: CodeMirror styles needs updated for CSS variables
https://bugs.webkit.org/show_bug.cgi?id=154216
rdar://problem/24644146

Reviewed by Joseph Pecoraro.

* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.cm-s-default .cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property)): Added .cm-variable-2.
(.cm-s-default .basic-block-has-not-executed.cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property)): Ditto.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SyntaxHighlightingDefaultTheme.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (196591 => 196592)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-02-15 21:08:47 UTC (rev 196591)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-02-15 21:13:24 UTC (rev 196592)
@@ -1,3 +1,15 @@
+2016-02-15  Timothy Hatcher  
+
+Web Inspector: CodeMirror styles needs updated for CSS variables
+https://bugs.webkit.org/show_bug.cgi?id=154216
+rdar://problem/24644146
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
+(.cm-s-default .cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property)): Added .cm-variable-2.
+(.cm-s-default .basic-block-has-not-executed.cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property)): Ditto.
+
 2016-02-13  Dan Bernstein  
 
 Removed the unused Frameworks group.


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SyntaxHighlightingDefaultTheme.css (196591 => 196592)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SyntaxHighlightingDefaultTheme.css	2016-02-15 21:08:47 UTC (rev 196591)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SyntaxHighlightingDefaultTheme.css	2016-02-15 21:13:24 UTC (rev 196592)
@@ -39,7 +39,7 @@
 }
 
 .cm-s-default :matches(.cm-tag, .cm-bracket, .cm-atom, .cm-keyword, .cm-m-_javascript_.cm-builtin),
-.cm-s-default .cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-3, .cm-property),
+.cm-s-default .cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property),
 .syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, ._javascript_-keyword, .html-tag) {
 color: var(--syntax-highlight-boolean-color);
 }
@@ -105,7 +105,7 @@
 }
 
 .cm-s-default .basic-block-has-not-executed:matches(.cm-tag, .cm-bracket, .cm-atom, .cm-keyword, .cm-m-_javascript_.cm-builtin),
-.cm-s-default .basic-block-has-not-executed.cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-3, .cm-property) {
+.cm-s-default .basic-block-has-not-executed.cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property) {
 color: hsl(309, 21%, 70%);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196591] trunk/Source/JavaScriptCore

[mark . lam]

Title: [196591] trunk/Source/_javascript_Core








Revision 196591
Author mark@apple.com
Date 2016-02-15 13:08:47 -0800 (Mon, 15 Feb 2016)


Log Message
[ARMv7] stress/op_rshift.js and stress/op_urshift.js are failing.
https://bugs.webkit.org/show_bug.cgi?id=151514

Reviewed by Filip Pizlo.

The issue turns out to be trivial: on ARMv7 (and traditional ARM too), arithmetic
shift right (ASR) and logical shift right (LSR) takes an immediate shift amount
from 1-32.  See http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0204j/Cjacbgca.html.
An immediate shift amount of 0 is interpreted as a shift of 32 bits.

Meanwhile, our macro assembler is expecting the immediate shift value to be
between 0-31.  As a result, a shift amount of 0 is being wrongly encoded with 0
bits which means shift right by 32 bits.

The fix is to check if the shift amount is 0, and if so, emit a move.  Else,
emit the right shift as usual.

This issue does not affect left shifts, as the immediate shift amount for left
shifts is between 0-31 as our macro assembler expects.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::rshift32):
(JSC::MacroAssemblerARMv7::urshift32):

* tests/stress/op_rshift.js:
* tests/stress/op_urshift.js:
- Un-skip these tests.  They should always pass now.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/tests/stress/op_rshift.js
trunk/Source/_javascript_Core/tests/stress/op_urshift.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (196590 => 196591)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-15 20:49:23 UTC (rev 196590)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-15 21:08:47 UTC (rev 196591)
@@ -1,3 +1,37 @@
+2016-02-15  Mark Lam  
+
+[ARMv7] stress/op_rshift.js and stress/op_urshift.js are failing.
+https://bugs.webkit.org/show_bug.cgi?id=151514
+
+Reviewed by Filip Pizlo.
+
+The issue turns out to be trivial: on ARMv7 (and traditional ARM too), arithmetic
+shift right (ASR) and logical shift right (LSR) takes an immediate shift amount
+from 1-32.  See http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0204j/Cjacbgca.html.
+An immediate shift amount of 0 is interpreted as a shift of 32 bits.
+
+Meanwhile, our macro assembler is expecting the immediate shift value to be
+between 0-31.  As a result, a shift amount of 0 is being wrongly encoded with 0
+bits which means shift right by 32 bits.
+
+The fix is to check if the shift amount is 0, and if so, emit a move.  Else,
+emit the right shift as usual.
+
+This issue does not affect left shifts, as the immediate shift amount for left
+shifts is between 0-31 as our macro assembler expects.
+
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::rshift32):
+(JSC::MacroAssemblerARM::urshift32):
+(JSC::MacroAssemblerARM::sub32):
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::rshift32):
+(JSC::MacroAssemblerARMv7::urshift32):
+
+* tests/stress/op_rshift.js:
+* tests/stress/op_urshift.js:
+- Un-skip these tests.  They should always pass now.
+
 2016-02-15  Filip Pizlo  
 
 Parser::parseVariableDeclarationList should null check the node before attempting to create a new CommaExpr


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (196590 => 196591)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2016-02-15 20:49:23 UTC (rev 196590)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2016-02-15 21:08:47 UTC (rev 196591)
@@ -274,7 +274,10 @@
 
 void rshift32(RegisterID src, TrustedImm32 imm, RegisterID dest)
 {
-m_assembler.movs(dest, m_assembler.asr(src, imm.m_value & 0x1f));
+if (!imm.m_value)
+move(src, dest);
+else
+m_assembler.movs(dest, m_assembler.asr(src, imm.m_value & 0x1f));
 }
 
 void urshift32(RegisterID shiftAmount, RegisterID dest)
@@ -297,7 +300,10 @@
 
 void urshift32(RegisterID src, TrustedImm32 imm, RegisterID dest)
 {
-m_assembler.movs(dest, m_assembler.lsr(src, imm.m_value & 0x1f));
+if (!imm.m_value)
+move(src, dest);
+else
+m_assembler.movs(dest, m_assembler.lsr(src, imm.m_value & 0x1f));
 }
 
 void sub32(RegisterID src, RegisterID dest)


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (196590 => 196591)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2016-02-15 20:49:23 UTC (rev 196590)
+++ 

[webkit-changes] [196590] trunk/Source/WebCore

[achristensen]

Title: [196590] trunk/Source/WebCore








Revision 196590
Author achristen...@apple.com
Date 2016-02-15 12:49:23 -0800 (Mon, 15 Feb 2016)


Log Message
CMake build fix.

* PlatformMac.cmake:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformMac.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (196589 => 196590)

--- trunk/Source/WebCore/ChangeLog	2016-02-15 20:30:52 UTC (rev 196589)
+++ trunk/Source/WebCore/ChangeLog	2016-02-15 20:49:23 UTC (rev 196590)
@@ -1,3 +1,9 @@
+2016-02-15  Alex Christensen  
+
+CMake build fix.
+
+* PlatformMac.cmake:
+
 2016-02-15  Chris Dumez  
 
 Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this'


Modified: trunk/Source/WebCore/PlatformMac.cmake (196589 => 196590)

--- trunk/Source/WebCore/PlatformMac.cmake	2016-02-15 20:30:52 UTC (rev 196589)
+++ trunk/Source/WebCore/PlatformMac.cmake	2016-02-15 20:49:23 UTC (rev 196590)
@@ -525,6 +525,7 @@
 platform/network/cocoa/ProtectionSpaceCocoa.mm
 platform/network/cocoa/ResourceRequestCocoa.mm
 platform/network/cocoa/ResourceResponseCocoa.mm
+platform/network/cocoa/WebCoreNSURLSession.mm
 
 platform/network/mac/AuthenticationMac.mm
 platform/network/mac/BlobDataFileReferenceMac.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196589] trunk

[achristensen]

Title: [196589] trunk








Revision 196589
Author achristen...@apple.com
Date 2016-02-15 12:30:52 -0800 (Mon, 15 Feb 2016)


Log Message
Fix internal Windows build of projects built after WebKit
https://bugs.webkit.org/show_bug.cgi?id=154249
rdar://problem/24644805

Reviewed by Chris Dumez.

Source/WebKit:

* PlatformWin.cmake:
Copy all generated headers to ForwardingHeaders/WebKit, not just WebKit.h.
This should fix problems related to not finding headers from other projects, such as AccessibleApplication.h.
WebKit.h, WebKitCOMAPI.h, and CFDictionaryPropertyBag.h were copied correctly, so this should copy the rest
of the needed headers.

Tools:

* DumpRenderTree/PlatformWin.cmake:
* MiniBrowser/win/CMakeLists.txt:
Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
more like projects built internally after WebKit.  They should only need to use what
is in ForwardingHeaders/WebKit.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWin.cmake
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/PlatformWin.cmake
trunk/Tools/MiniBrowser/win/CMakeLists.txt




Diff

Modified: trunk/Source/WebKit/ChangeLog (196588 => 196589)

--- trunk/Source/WebKit/ChangeLog	2016-02-15 20:09:54 UTC (rev 196588)
+++ trunk/Source/WebKit/ChangeLog	2016-02-15 20:30:52 UTC (rev 196589)
@@ -1,3 +1,17 @@
+2016-02-15  Alex Christensen  
+
+Fix internal Windows build of projects built after WebKit
+https://bugs.webkit.org/show_bug.cgi?id=154249
+rdar://problem/24644805
+
+Reviewed by Chris Dumez.
+
+* PlatformWin.cmake:
+Copy all generated headers to ForwardingHeaders/WebKit, not just WebKit.h.
+This should fix problems related to not finding headers from other projects, such as AccessibleApplication.h.
+WebKit.h, WebKitCOMAPI.h, and CFDictionaryPropertyBag.h were copied correctly, so this should copy the rest
+of the needed headers.
+
 2016-02-12  Alex Christensen  
 
 Fix internal Windows WebKit debug build.


Modified: trunk/Source/WebKit/PlatformWin.cmake (196588 => 196589)

--- trunk/Source/WebKit/PlatformWin.cmake	2016-02-15 20:09:54 UTC (rev 196588)
+++ trunk/Source/WebKit/PlatformWin.cmake	2016-02-15 20:30:52 UTC (rev 196589)
@@ -469,7 +469,7 @@
 add_custom_command(TARGET WebKitGUID PRE_BUILD COMMAND ${WebKitGUID_PRE_BUILD_COMMAND} VERBATIM)
 
 set(WebKitGUID_POST_BUILD_COMMAND "${CMAKE_BINARY_DIR}/DerivedSources/WebKit/postBuild.cmd")
-file(WRITE "${WebKitGUID_POST_BUILD_COMMAND}" "@xcopy /y /d /f \"${DERIVED_SOURCES_WEBKIT_DIR}/Interfaces/WebKit.h\" \"${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit\" >nul 2>nul")
+file(WRITE "${WebKitGUID_POST_BUILD_COMMAND}" "@xcopy /y /d /f \"${DERIVED_SOURCES_WEBKIT_DIR}/Interfaces/*.h\" \"${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit\" >nul 2>nul")
 add_custom_command(TARGET WebKitGUID POST_BUILD COMMAND ${WebKitGUID_POST_BUILD_COMMAND} VERBATIM)
 
 set(WebKit_OUTPUT_NAME


Modified: trunk/Tools/ChangeLog (196588 => 196589)

--- trunk/Tools/ChangeLog	2016-02-15 20:09:54 UTC (rev 196588)
+++ trunk/Tools/ChangeLog	2016-02-15 20:30:52 UTC (rev 196589)
@@ -1,3 +1,17 @@
+2016-02-15  Alex Christensen  
+
+Fix internal Windows build of projects built after WebKit
+https://bugs.webkit.org/show_bug.cgi?id=154249
+rdar://problem/24644805
+
+Reviewed by Chris Dumez.
+
+* DumpRenderTree/PlatformWin.cmake:
+* MiniBrowser/win/CMakeLists.txt:
+Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
+more like projects built internally after WebKit.  They should only need to use what
+is in ForwardingHeaders/WebKit.
+
 2016-02-12  Nan Wang  
 
 AX: Implement paragraph related text marker functions using TextIterator


Modified: trunk/Tools/DumpRenderTree/PlatformWin.cmake (196588 => 196589)

--- trunk/Tools/DumpRenderTree/PlatformWin.cmake	2016-02-15 20:09:54 UTC (rev 196588)
+++ trunk/Tools/DumpRenderTree/PlatformWin.cmake	2016-02-15 20:30:52 UTC (rev 196589)
@@ -71,7 +71,6 @@
 TestNetscapePlugin/Tests
 TestNetscapePlugin/win
 TestNetscapePlugin/Tests/win
-${DERIVED_SOURCES_DIR}/WebKit/Interfaces
 )
 
 list(APPEND DumpRenderTree_LIBRARIES


Modified: trunk/Tools/MiniBrowser/win/CMakeLists.txt (196588 => 196589)

--- trunk/Tools/MiniBrowser/win/CMakeLists.txt	2016-02-15 20:09:54 UTC (rev 196588)
+++ trunk/Tools/MiniBrowser/win/CMakeLists.txt	2016-02-15 20:30:52 UTC (rev 196589)
@@ -2,8 +2,6 @@
 ../MiniBrowser.vcxproj
 "${DERIVED_SOURCES_DIR}/ForwardingHeaders"
 "${DERIVED_SOURCES_DIR}/ForwardingHeaders/WebKit"
-"${DERIVED_SOURCES_DIR}"
-"${DERIVED_SOURCES_WEBKIT_DIR}/Interfaces"
 "${WTF_DIR}"
 "${CMAKE_SOURCE_DIR}"
 "${CMAKE_SOURCE_DIR}/Source"






___
webkit-changes mailing 

[webkit-changes] [196588] trunk

[cdumez]

Title: [196588] trunk








Revision 196588
Author cdu...@apple.com
Date 2016-02-15 12:09:54 -0800 (Mon, 15 Feb 2016)


Log Message
Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this'
https://bugs.webkit.org/show_bug.cgi?id=154245

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds support for calling the EventListener API without an
explicit 'this' value. If no explicit 'this' value is passed, then we
fall back to using the global object. This matches Chrome and Firefox's
behavior. It also fixes the Dromaeo/cssquery-dojo.html test.

Test: fast/dom/Window/addEventListener-implicit-this.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateFunctionCastedThis):

LayoutTests:

Add a layout test to cover the use of the EventListener API without an
explicit 'this' value.

* fast/dom/Window/addEventListener-implicit-this-expected.txt: Added.
* fast/dom/Window/addEventListener-implicit-this.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm


Added Paths

trunk/LayoutTests/fast/dom/Window/addEventListener-implicit-this-expected.txt
trunk/LayoutTests/fast/dom/Window/addEventListener-implicit-this.html




Diff

Modified: trunk/LayoutTests/ChangeLog (196587 => 196588)

--- trunk/LayoutTests/ChangeLog	2016-02-15 20:09:07 UTC (rev 196587)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 20:09:54 UTC (rev 196588)
@@ -1,3 +1,16 @@
+2016-02-15  Chris Dumez  
+
+Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this'
+https://bugs.webkit.org/show_bug.cgi?id=154245
+
+Reviewed by Ryosuke Niwa.
+
+Add a layout test to cover the use of the EventListener API without an
+explicit 'this' value.
+
+* fast/dom/Window/addEventListener-implicit-this-expected.txt: Added.
+* fast/dom/Window/addEventListener-implicit-this.html: Added.
+
 2016-02-15  Daniel Bates  
 
 CSP: 'sandbox' should be ignored in report-only mode


Added: trunk/LayoutTests/fast/dom/Window/addEventListener-implicit-this-expected.txt (0 => 196588)

--- trunk/LayoutTests/fast/dom/Window/addEventListener-implicit-this-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/Window/addEventListener-implicit-this-expected.txt	2016-02-15 20:09:54 UTC (rev 196588)
@@ -0,0 +1,16 @@
+Checks that the Window's EventListener API can be called without an explicit 'this' value.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS addEventListenerFunction.call(undefined, 'myevent', function() { wasWindowEventListenerCalled = true; }); did not throw exception.
+PASS dispatchEventFunction.call(undefined, new Event('myevent')) is true
+PASS wasWindowEventListenerCalled is true
+PASS bodyDispatchEventFunction.call(undefined, new Event('myevent')) is true
+PASS wasWindowEventListenerCalled is true
+PASS xhrDispatchEventFunction.call(undefined, new Event('myevent')) is true
+PASS wasWindowEventListenerCalled is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/Window/addEventListener-implicit-this.html (0 => 196588)

--- trunk/LayoutTests/fast/dom/Window/addEventListener-implicit-this.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/Window/addEventListener-implicit-this.html	2016-02-15 20:09:54 UTC (rev 196588)
@@ -0,0 +1,38 @@
+
+
+
+
+description("Checks that the Window's EventListener API can be called without an explicit 'this' value.");
+
+var wasWindowEventListenerCalled = false;
+
+var addEventListenerFunction = window.addEventListener;
+shouldNotThrow("addEventListenerFunction.call(undefined, 'myevent', function() { wasWindowEventListenerCalled = true; });");
+
+var dispatchEventFunction = window.dispatchEvent;
+shouldBeTrue("dispatchEventFunction.call(undefined, new Event('myevent'))");
+
+shouldBeTrue("wasWindowEventListenerCalled");
+
+// As of early 2016, this matches Firefox and Chrome's behavior: We fall back to using the global window, even if the function
+// came from a non-Window object.
+wasWindowEventListenerCalled = false;
+
+bodyDispatchEventFunction = document.body.dispatchEvent;
+shouldBeTrue("bodyDispatchEventFunction.call(undefined, new Event('myevent'))");
+
+shouldBeTrue("wasWindowEventListenerCalled");
+
+wasWindowEventListenerCalled = false;
+
+var xhr = new XMLHttpRequest();
+xhrDispatchEventFunction = xhr.dispatchEvent;
+shouldBeTrue("xhrDispatchEventFunction.call(undefined, new Event('myevent'))");
+
+shouldBeTrue("wasWindowEventListenerCalled");
+
+

[webkit-changes] [196587] trunk/Source/JavaScriptCore

[fpizlo]

Title: [196587] trunk/Source/_javascript_Core








Revision 196587
Author fpi...@apple.com
Date 2016-02-15 12:09:07 -0800 (Mon, 15 Feb 2016)


Log Message
Parser::parseVariableDeclarationList should null check the node before attempting to create a new CommaExpr
https://bugs.webkit.org/show_bug.cgi?id=154244
rdar://problem/24290670

Reviewed by Michael Saboff.

* parser/ASTBuilder.h:
(JSC::ASTBuilder::appendToCommaExpr): Catch the bug sooner in debug.
* parser/Parser.cpp:
(JSC::Parser::parseVariableDeclarationList): Fix the bug.
* tests/stress/for-let-comma.js: Added. This used to crash in debug and release.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/ASTBuilder.h
trunk/Source/_javascript_Core/parser/Parser.cpp


Added Paths

trunk/Source/_javascript_Core/tests/stress/for-let-comma.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (196586 => 196587)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-15 20:01:09 UTC (rev 196586)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-15 20:09:07 UTC (rev 196587)
@@ -1,3 +1,17 @@
+2016-02-15  Filip Pizlo  
+
+Parser::parseVariableDeclarationList should null check the node before attempting to create a new CommaExpr
+https://bugs.webkit.org/show_bug.cgi?id=154244
+rdar://problem/24290670
+
+Reviewed by Michael Saboff.
+
+* parser/ASTBuilder.h:
+(JSC::ASTBuilder::appendToCommaExpr): Catch the bug sooner in debug.
+* parser/Parser.cpp:
+(JSC::Parser::parseVariableDeclarationList): Fix the bug.
+* tests/stress/for-let-comma.js: Added. This used to crash in debug and release.
+
 2016-02-15  Benjamin Poulain  
 
 [JSC] Improve the interface of Inst::shouldTryAliasingDef()


Modified: trunk/Source/_javascript_Core/parser/ASTBuilder.h (196586 => 196587)

--- trunk/Source/_javascript_Core/parser/ASTBuilder.h	2016-02-15 20:01:09 UTC (rev 196586)
+++ trunk/Source/_javascript_Core/parser/ASTBuilder.h	2016-02-15 20:09:07 UTC (rev 196587)
@@ -729,6 +729,7 @@
 CommaNode* appendToCommaExpr(const JSTokenLocation& location, ExpressionNode*, ExpressionNode* tail, ExpressionNode* next)
 {
 ASSERT(tail->isCommaNode());
+ASSERT(next);
 CommaNode* newTail = new (m_parserArena) CommaNode(location, next);
 static_cast(tail)->setNext(newTail);
 return newTail;


Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (196586 => 196587)

--- trunk/Source/_javascript_Core/parser/Parser.cpp	2016-02-15 20:01:09 UTC (rev 196586)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp	2016-02-15 20:09:07 UTC (rev 196587)
@@ -729,14 +729,16 @@
 lastInitializer = rhs;
 }
 }
-
-if (!head)
-head = node;
-else if (!tail) {
-head = context.createCommaExpr(location, head);
-tail = context.appendToCommaExpr(location, head, head, node);
-} else
-tail = context.appendToCommaExpr(location, head, tail, node);
+
+if (node) {
+if (!head)
+head = node;
+else if (!tail) {
+head = context.createCommaExpr(location, head);
+tail = context.appendToCommaExpr(location, head, head, node);
+} else
+tail = context.appendToCommaExpr(location, head, tail, node);
+}
 } while (match(COMMA));
 if (lastIdent)
 lastPattern = context.createBindingLocation(lastIdentToken.m_location, *lastIdent, lastIdentToken.m_startPosition, lastIdentToken.m_endPosition, assignmentContext);


Added: trunk/Source/_javascript_Core/tests/stress/for-let-comma.js (0 => 196587)

--- trunk/Source/_javascript_Core/tests/stress/for-let-comma.js	(rev 0)
+++ trunk/Source/_javascript_Core/tests/stress/for-let-comma.js	2016-02-15 20:09:07 UTC (rev 196587)
@@ -0,0 +1,16 @@
+function foo() {
+var array = [];
+for (let x = 0, []; x < 10; ++x) { array.push(x); }
+return array;
+}
+
+var result = foo();
+if (result.length != 10)
+throw "Error: bad length: " + result.length;
+for (var i = 0; i < 10; ++i) {
+if (result[i] != i)
+throw "Error: bad entry at i = " + i + ": " + result[i];
+}
+if (result.length != 10)
+throw "Error: bad length: " + result.length;
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196586] branches/safari-601.1.46-branch/Source/bmalloc

[bshafiei]

Title: [196586] branches/safari-601.1.46-branch/Source/bmalloc








Revision 196586
Author bshaf...@apple.com
Date 2016-02-15 12:01:09 -0800 (Mon, 15 Feb 2016)


Log Message
Merged r196536.  rdar://problem/24620164

Modified Paths

branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog
branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/FreeList.h
branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.cpp
branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h
branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/VMHeap.h




Diff

Modified: branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog (196585 => 196586)

--- branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog	2016-02-15 19:59:46 UTC (rev 196585)
+++ branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog	2016-02-15 20:01:09 UTC (rev 196586)
@@ -1,5 +1,36 @@
 2016-02-15  Babak Shafiei  
 
+Merge r196536.
+
+2016-02-12  Michael Saboff  
+
+BASSERTs added in r196421 are causing debug test failures
+https://bugs.webkit.org/show_bug.cgi?id=154113
+
+Reviewed by Geoffrey Garen.
+
+In VMHeap::deallocateLargeObject(), we drop the lock to deallocate the physical pages.
+If the scavenger thread is running at the same time a synchronous call to scavenge()
+comes in, we could call VMHeap::deallocateLargeObject() for an adjacent object while the
+lock in the other thread is dropped.  We fix this by checking for adjacent objects we
+can merge with and loop if we have one.
+
+* bmalloc/FreeList.h:
+(bmalloc::FreeList::push): Added BASSERT to catch adding unmerged free objects
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::allocateLarge): Changed to use nextCanMerge().
+* bmalloc/LargeObject.h:
+(bmalloc::LargeObject::prevCanMerge): Repurposed prevIsAllocated.
+(bmalloc::LargeObject::nextCanMerge): Repurposed nextIsAllocated.
+(bmalloc::LargeObject::prevIsAllocated): Deleted.
+(bmalloc::LargeObject::nextIsAllocated): Deleted.
+* bmalloc/VMHeap.h:
+(bmalloc::VMHeap::allocateLargeObject): Moved adding the extra object back to the free list
+to after we set the object we'll return as being allocated.
+(bmalloc::VMHeap::deallocateLargeObject):
+
+2016-02-15  Babak Shafiei  
+
 Merge r196424.
 
 2016-02-11  Michael Saboff  


Modified: branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/FreeList.h (196585 => 196586)

--- branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/FreeList.h	2016-02-15 19:59:46 UTC (rev 196585)
+++ branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/FreeList.h	2016-02-15 20:01:09 UTC (rev 196586)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014, 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2014-2016 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -60,6 +60,8 @@
 inline void FreeList::push(Owner owner, const LargeObject& largeObject)
 {
 BASSERT(largeObject.isFree());
+BASSERT(!largeObject.prevCanMerge());
+BASSERT(!largeObject.nextCanMerge());
 if (m_vector.size() == m_limit) {
 removeInvalidAndDuplicateEntries(owner);
 m_limit = std::max(m_vector.size() * freeListGrowFactor, freeListSearchDepth);


Modified: branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.cpp (196585 => 196586)

--- branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.cpp	2016-02-15 19:59:46 UTC (rev 196585)
+++ branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.cpp	2016-02-15 20:01:09 UTC (rev 196586)
@@ -352,7 +352,7 @@
 largeObject.setFree(false);
 
 if (nextLargeObject) {
-BASSERT(nextLargeObject.nextIsAllocated());
+BASSERT(!nextLargeObject.nextCanMerge());
 m_largeObjects.insert(nextLargeObject);
 }
 


Modified: branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h (196585 => 196586)

--- branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h	2016-02-15 19:59:46 UTC (rev 196585)
+++ branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h	2016-02-15 20:01:09 UTC (rev 196586)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2016 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -54,9 +54,9 @@
 void setFree(bool) const;
 bool isFree() const;
 
-bool prevIsAllocated() const;
-bool nextIsAllocated() const;
-
+bool prevCanMerge() const;
+bool nextCanMerge() const;
+
 Owner owner() const;
 void 

[webkit-changes] [196585] branches/safari-601.1.46-branch/Source/bmalloc

[bshafiei]

Title: [196585] branches/safari-601.1.46-branch/Source/bmalloc








Revision 196585
Author bshaf...@apple.com
Date 2016-02-15 11:59:46 -0800 (Mon, 15 Feb 2016)


Log Message
Merged r196424.  rdar://problem/24620164

Modified Paths

branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog
branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h




Diff

Modified: branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog (196584 => 196585)

--- branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog	2016-02-15 19:58:59 UTC (rev 196584)
+++ branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog	2016-02-15 19:59:46 UTC (rev 196585)
@@ -1,5 +1,19 @@
 2016-02-15  Babak Shafiei  
 
+Merge r196424.
+
+2016-02-11  Michael Saboff  
+
+Unreviewed build fix after r196421.
+
+Removed BASSERTs that are firing to eliminate Debug build crashes.  I'll debug locally and
+enable or alter after the issue is understood.
+
+* bmalloc/LargeObject.h:
+(bmalloc::LargeObject::merge): Removed BASSERTs that are firing.
+
+2016-02-15  Babak Shafiei  
+
 Merge r196421.
 
 2016-02-11  Michael Saboff  


Modified: branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h (196584 => 196585)

--- branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h	2016-02-15 19:58:59 UTC (rev 196584)
+++ branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h	2016-02-15 19:59:46 UTC (rev 196585)
@@ -219,11 +219,7 @@
 beginTag->setOwner(owner);
 endTag->init(beginTag);
 
-LargeObject result(beginTag, endTag, range.begin());
-BASSERT(result.prevIsAllocated());
-BASSERT(result.nextIsAllocated());
-
-return result;
+return LargeObject(beginTag, endTag, range.begin());
 }
 
 inline std::pair LargeObject::split(size_t size) const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196584] branches/safari-601.1.46-branch/Source/bmalloc

[bshafiei]

Title: [196584] branches/safari-601.1.46-branch/Source/bmalloc








Revision 196584
Author bshaf...@apple.com
Date 2016-02-15 11:58:59 -0800 (Mon, 15 Feb 2016)


Log Message
Merged r196421.  rdar://problem/24620164

Modified Paths

branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog
branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.cpp
branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.h
branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/LargeObject.h




Diff

Modified: branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog (196583 => 196584)

--- branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog	2016-02-15 19:56:18 UTC (rev 196583)
+++ branches/safari-601.1.46-branch/Source/bmalloc/ChangeLog	2016-02-15 19:58:59 UTC (rev 196584)
@@ -1,3 +1,27 @@
+2016-02-15  Babak Shafiei  
+
+Merge r196421.
+
+2016-02-11  Michael Saboff  
+
+bmalloc: large aligned allocations will put 1 or 2 free object on free list without merging with free neighbors
+https://bugs.webkit.org/show_bug.cgi?id=154091
+
+Reviewed by Geoffrey Garen.
+
+If we split off any unused free object in the aligned version of Heap::allocateLarge(), we merge them with
+free neighbors before putting them back on the free list.  Added helpers to verify that when we
+add LargeObjects to the free list their neighbors are allocated.
+
+* bmalloc/Heap.cpp:
+(bmalloc::Heap::allocateLarge): Deleted private helper version and rolled it into the two the
+two public versions of allocateLarge().
+* bmalloc/Heap.h:
+* bmalloc/LargeObject.h:
+(bmalloc::LargeObject::prevIsAllocated): New helper.
+(bmalloc::LargeObject::nextIsAllocated): New helper.
+(bmalloc::LargeObject::merge): Check that the merge object has allocated neighbors.
+
 2015-07-26  Babak Shafiei  
 
 Merge r187270.


Modified: branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.cpp (196583 => 196584)

--- branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.cpp	2016-02-15 19:56:18 UTC (rev 196583)
+++ branches/safari-601.1.46-branch/Source/bmalloc/bmalloc/Heap.cpp	2016-02-15 19:58:59 UTC (rev 196584)
@@ -327,22 +327,8 @@
 lock.lock();
 }
 
-void* Heap::allocateLarge(std::lock_guard&, LargeObject& largeObject, size_t size)
+void* Heap::allocateLarge(std::lock_guard&, size_t size)
 {
-BASSERT(largeObject.isFree());
-
-if (largeObject.size() - size > largeMin) {
-std::pair split = largeObject.split(size);
-largeObject = split.first;
-m_largeObjects.insert(split.second);
-}
-
-largeObject.setFree(false);
-return largeObject.begin();
-}
-
-void* Heap::allocateLarge(std::lock_guard& lock, size_t size)
-{
 BASSERT(size <= largeMax);
 BASSERT(size >= largeMin);
 BASSERT(size == roundUpToMultipleOf(size));
@@ -353,10 +339,27 @@
 largeObject = m_vmHeap.allocateLargeObject(size);
 }
 
-return allocateLarge(lock, largeObject, size);
+BASSERT(largeObject.isFree());
+
+LargeObject nextLargeObject;
+
+if (largeObject.size() - size > largeMin) {
+std::pair split = largeObject.split(size);
+largeObject = split.first;
+nextLargeObject = split.second;
+}
+
+largeObject.setFree(false);
+
+if (nextLargeObject) {
+BASSERT(nextLargeObject.nextIsAllocated());
+m_largeObjects.insert(nextLargeObject);
+}
+
+return largeObject.begin();
 }
 
-void* Heap::allocateLarge(std::lock_guard& lock, size_t alignment, size_t size, size_t unalignedSize)
+void* Heap::allocateLarge(std::lock_guard&, size_t alignment, size_t size, size_t unalignedSize)
 {
 BASSERT(size <= largeMax);
 BASSERT(size >= largeMin);
@@ -374,15 +377,38 @@
 largeObject = m_vmHeap.allocateLargeObject(alignment, size, unalignedSize);
 }
 
+LargeObject prevLargeObject;
+LargeObject nextLargeObject;
+
 size_t alignmentMask = alignment - 1;
 if (test(largeObject.begin(), alignmentMask)) {
 size_t prefixSize = roundUpToMultipleOf(alignment, largeObject.begin() + largeMin) - largeObject.begin();
 std::pair pair = largeObject.split(prefixSize);
-m_largeObjects.insert(pair.first);
+prevLargeObject = pair.first;
 largeObject = pair.second;
 }
 
-return allocateLarge(lock, largeObject, size);
+BASSERT(largeObject.isFree());
+
+if (largeObject.size() - size > largeMin) {
+std::pair split = largeObject.split(size);
+largeObject = split.first;
+nextLargeObject = split.second;
+}
+
+largeObject.setFree(false);
+
+if (prevLargeObject) {
+LargeObject merged = prevLargeObject.merge();
+   

[webkit-changes] [196583] trunk/Source/WebCore

[barraclough]

Title: [196583] trunk/Source/WebCore








Revision 196583
Author barraclo...@apple.com
Date 2016-02-15 11:56:18 -0800 (Mon, 15 Feb 2016)


Log Message
Organize, deduplicate & comment JSDOMWindowCustom getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=154224

Reviewed by Chris Dumez.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::jsDOMWindowGetOwnPropertySlotNamedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
- organized property access sequence into a more logical order, removed
  duplicated code & added comments.
(WebCore::namedItemGetter): Deleted.
- there was no need for a custom callback here; merged functionality into
  jsDOMWindowGetOwnPropertySlotNamedItemGetter.
(WebCore::jsDOMWindowGetOwnPropertySlotCrossOrigin): Deleted.
- renamed to jsDOMWindowGetOwnPropertySlotRestrictedAccess
  (this now also handles frameless access).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (196582 => 196583)

--- trunk/Source/WebCore/ChangeLog	2016-02-15 18:54:30 UTC (rev 196582)
+++ trunk/Source/WebCore/ChangeLog	2016-02-15 19:56:18 UTC (rev 196583)
@@ -1,3 +1,24 @@
+2016-02-14  Gavin Barraclough  
+
+Organize, deduplicate & comment JSDOMWindowCustom getOwnPropertySlot
+https://bugs.webkit.org/show_bug.cgi?id=154224
+
+Reviewed by Chris Dumez.
+
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
+(WebCore::jsDOMWindowGetOwnPropertySlotNamedItemGetter):
+(WebCore::JSDOMWindow::getOwnPropertySlot):
+(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
+- organized property access sequence into a more logical order, removed
+  duplicated code & added comments.
+(WebCore::namedItemGetter): Deleted.
+- there was no need for a custom callback here; merged functionality into
+  jsDOMWindowGetOwnPropertySlotNamedItemGetter.
+(WebCore::jsDOMWindowGetOwnPropertySlotCrossOrigin): Deleted.
+- renamed to jsDOMWindowGetOwnPropertySlotRestrictedAccess
+  (this now also handles frameless access).
+
 2016-02-15  Daniel Bates  
 
 CSP: 'sandbox' should be ignored in report-only mode


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (196582 => 196583)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2016-02-15 18:54:30 UTC (rev 196582)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2016-02-15 19:56:18 UTC (rev 196583)
@@ -66,27 +66,6 @@
 visitor.addOpaqueRoot(frame);
 }
 
-static EncodedJSValue namedItemGetter(ExecState* exec, EncodedJSValue thisValue, PropertyName propertyName)
-{
-JSDOMWindowBase* thisObj = jsCast(JSValue::decode(thisValue));
-Document* document = thisObj->wrapped().frame()->document();
-
-ASSERT(BindingSecurity::shouldAllowAccessToDOMWindow(exec, thisObj->wrapped()));
-ASSERT(is(document));
-
-AtomicStringImpl* atomicPropertyName = propertyName.publicName();
-if (!atomicPropertyName || !downcast(*document).hasWindowNamedItem(*atomicPropertyName))
-return JSValue::encode(jsUndefined());
-
-if (UNLIKELY(downcast(*document).windowNamedItemContainsMultipleElements(*atomicPropertyName))) {
-Ref collection = document->windowNamedItems(atomicPropertyName);
-ASSERT(collection->length() > 1);
-return JSValue::encode(toJS(exec, thisObj->globalObject(), WTF::getPtr(collection)));
-}
-
-return JSValue::encode(toJS(exec, thisObj->globalObject(), downcast(*document).windowNamedItem(*atomicPropertyName)));
-}
-
 #if ENABLE(USER_MESSAGE_HANDLERS)
 static EncodedJSValue jsDOMWindowWebKit(ExecState* exec, EncodedJSValue thisValue, PropertyName)
 {
@@ -112,8 +91,34 @@
 }
 #endif
 
-static bool jsDOMWindowGetOwnPropertySlotCrossOrigin(JSDOMWindow* thisObject, ExecState* exec, PropertyName propertyName, PropertySlot& slot, String& errorMessage)
+static bool jsDOMWindowGetOwnPropertySlotRestrictedAccess(JSDOMWindow* thisObject, Frame* frame, ExecState* exec, PropertyName propertyName, PropertySlot& slot, String& errorMessage)
 {
+// Allow access to toString() cross-domain, but always Object.prototype.toString.
+if (propertyName == exec->propertyNames().toString) {
+slot.setCustom(thisObject, ReadOnly | DontDelete | DontEnum, nonCachingStaticFunctionGetter);
+return true;
+}
+
+// We don't want any properties other than "close" and "closed" on a frameless window
+// (i.e. one whose page got closed, or whose iframe got removed).
+// FIXME: This handling for frameless windows duplicates similar behaviour for cross-origin
+// access below; we 

[webkit-changes] [196582] trunk

[dbates]

Title: [196582] trunk








Revision 196582
Author dba...@webkit.org
Date 2016-02-15 10:54:30 -0800 (Mon, 15 Feb 2016)


Log Message
CSP: 'sandbox' should be ignored in report-only mode
https://bugs.webkit.org/show_bug.cgi?id=153167


Reviewed by Brent Fulgham.

Source/WebCore:

Merged from Blink (patch by Mike West):


* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportInvalidDirectiveInReportOnlyMode): Added. Logs a
console message to the console to explain that the specified directive is invalid in
report-only mode.
* page/csp/ContentSecurityPolicy.h:
* page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::applySandboxPolicy): Do not apply sandbox
policy when in report-only mode and call ContentSecurityPolicy::reportInvalidDirectiveInReportOnlyMode()
to log a message to the console.

LayoutTests:

Remove the entry from the TestExpectations file for the test
http/tests/security/contentSecurityPolicy/sandbox-report-only.html as it now passes.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp
trunk/Source/WebCore/page/csp/ContentSecurityPolicy.h
trunk/Source/WebCore/page/csp/ContentSecurityPolicyDirectiveList.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (196581 => 196582)

--- trunk/LayoutTests/ChangeLog	2016-02-15 18:53:59 UTC (rev 196581)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 18:54:30 UTC (rev 196582)
@@ -1,5 +1,18 @@
 2016-02-15  Daniel Bates  
 
+CSP: 'sandbox' should be ignored in report-only mode
+https://bugs.webkit.org/show_bug.cgi?id=153167
+
+
+Reviewed by Brent Fulgham.
+
+Remove the entry from the TestExpectations file for the test
+http/tests/security/contentSecurityPolicy/sandbox-report-only.html as it now passes.
+
+* TestExpectations:
+
+2016-02-15  Daniel Bates  
+
 CSP: Allow schemeless source expressions to match an HTTP or HTTPS resource
 https://bugs.webkit.org/show_bug.cgi?id=154177
 


Modified: trunk/LayoutTests/TestExpectations (196581 => 196582)

--- trunk/LayoutTests/TestExpectations	2016-02-15 18:53:59 UTC (rev 196581)
+++ trunk/LayoutTests/TestExpectations	2016-02-15 18:54:30 UTC (rev 196582)
@@ -833,7 +833,6 @@
 webkit.org/b/153166 http/tests/security/contentSecurityPolicy/report-uri.html [ Failure ]
 webkit.org/b/153166 webkit.org/b/153242 http/tests/security/contentSecurityPolicy/report-and-enforce.html [ Failure ]
 webkit.org/b/153166 webkit.org/b/153242 http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html [ Failure ]
-webkit.org/b/153167 http/tests/security/contentSecurityPolicy/sandbox-report-only.html [ Failure ]
 webkit.org/b/153168 http/tests/security/contentSecurityPolicy/source-list-parsing-07.html [ Failure ]
 webkit.org/b/153170 http/tests/security/contentSecurityPolicy/source-list-parsing-paths-03.html [ Failure ]
 http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html [ Pass Failure ]


Modified: trunk/Source/WebCore/ChangeLog (196581 => 196582)

--- trunk/Source/WebCore/ChangeLog	2016-02-15 18:53:59 UTC (rev 196581)
+++ trunk/Source/WebCore/ChangeLog	2016-02-15 18:54:30 UTC (rev 196582)
@@ -1,5 +1,26 @@
 2016-02-15  Daniel Bates  
 
+CSP: 'sandbox' should be ignored in report-only mode
+https://bugs.webkit.org/show_bug.cgi?id=153167
+
+
+Reviewed by Brent Fulgham.
+
+Merged from Blink (patch by Mike West):
+
+
+* page/csp/ContentSecurityPolicy.cpp:
+(WebCore::ContentSecurityPolicy::reportInvalidDirectiveInReportOnlyMode): Added. Logs a
+console message to the console to explain that the specified directive is invalid in
+report-only mode.
+* page/csp/ContentSecurityPolicy.h:
+* page/csp/ContentSecurityPolicyDirectiveList.cpp:
+(WebCore::ContentSecurityPolicyDirectiveList::applySandboxPolicy): Do not apply sandbox
+policy when in report-only mode and call ContentSecurityPolicy::reportInvalidDirectiveInReportOnlyMode()
+to log a message to the console.
+
+2016-02-15  Daniel Bates  
+
 CSP: Allow schemeless source expressions to match an HTTP or HTTPS resource
 https://bugs.webkit.org/show_bug.cgi?id=154177
 


Modified: trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp (196581 => 196582)

--- trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp	2016-02-15 18:53:59 UTC (rev 196581)
+++ trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp	2016-02-15 18:54:30 UTC (rev 196582)
@@ -452,6 +452,11 @@
 logToConsole("The 'reflected-xss' Content Security Policy directive has the invalid value \"" + invalidValue + "\". Value values are \"allow\", \"filter\", and \"block\".");
 }
 
+void 

[webkit-changes] [196581] trunk

[dbates]

Title: [196581] trunk








Revision 196581
Author dba...@webkit.org
Date 2016-02-15 10:53:59 -0800 (Mon, 15 Feb 2016)


Log Message
CSP: Allow schemeless source expressions to match an HTTP or HTTPS resource
https://bugs.webkit.org/show_bug.cgi?id=154177


Reviewed by Brent Fulgham.

Source/WebCore:

Allow a schemeless source _expression_ to match an HTTP or HTTPS subresource when the page is
delivered over HTTP as per section Matching Source Expressions of the Content Security Policy
2.0 spec.,  (21 July 2015).

Currently we have logic that implements this functionality, but it is guarded behind the compile-
time macro ENABLE(CSP_NEXT) that is disabled by default. Instead we should always compile such
code. In subsequent commits we will move more code out from under the ENABLE(CSP_NEXT)-guard
towards removing the ENABLE_CSP_NEXT macro entirely.

* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::protocolMatchesSelf):

LayoutTests:

Update test case and expected result to test that a schemeless source _expression_
matches an HTTPS subresource (and does not trigger a Content Security Policy violation)
when the page is served over HTTP.

* http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt:
* http/tests/security/contentSecurityPolicy/source-list-parsing-10.html: Change "no" to "yes"
so that we consider it a success (and continue printing "PASS") when we load and execute the
script, .

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-10.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (196580 => 196581)

--- trunk/LayoutTests/ChangeLog	2016-02-15 17:52:17 UTC (rev 196580)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 18:53:59 UTC (rev 196581)
@@ -1,3 +1,20 @@
+2016-02-15  Daniel Bates  
+
+CSP: Allow schemeless source expressions to match an HTTP or HTTPS resource
+https://bugs.webkit.org/show_bug.cgi?id=154177
+
+
+Reviewed by Brent Fulgham.
+
+Update test case and expected result to test that a schemeless source _expression_
+matches an HTTPS subresource (and does not trigger a Content Security Policy violation)
+when the page is served over HTTP.
+
+* http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt:
+* http/tests/security/contentSecurityPolicy/source-list-parsing-10.html: Change "no" to "yes"
+so that we consider it a success (and continue printing "PASS") when we load and execute the
+script, .
+
 2016-02-15  Ryan Haddad  
 
 Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196563


Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt (196580 => 196581)

--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt	2016-02-15 17:52:17 UTC (rev 196580)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt	2016-02-15 18:53:59 UTC (rev 196581)
@@ -1,5 +1,3 @@
-CONSOLE MESSAGE: Refused to load the script 'https://127.0.0.1:8443/security/contentSecurityPolicy/resources/script.js' because it violates the following Content Security Policy directive: "script-src 127.0.0.1:8443".
-
 None of these scripts should execute even though there are parse errors in the policy.
 
 


Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-10.html (196580 => 196581)

--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-10.html	2016-02-15 17:52:17 UTC (rev 196580)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-10.html	2016-02-15 18:53:59 UTC (rev 196581)
@@ -5,7 +5,7 @@
 
 var tests = [
 ['yes', 'script-src 127.0.0.1:8000', 'resources/script.js'],
-['no', 'script-src 127.0.0.1:8443', 'https://127.0.0.1:8443/security/contentSecurityPolicy/resources/script.js'],
+['yes', 'script-src 127.0.0.1:8443', 'https://127.0.0.1:8443/security/contentSecurityPolicy/resources/script.js'],
 ];
 
 


Modified: trunk/Source/WebCore/ChangeLog (196580 => 196581)

--- trunk/Source/WebCore/ChangeLog	2016-02-15 17:52:17 UTC (rev 196580)
+++ trunk/Source/WebCore/ChangeLog	2016-02-15 18:53:59 UTC (rev 196581)
@@ -1,3 +1,23 @@
+2016-02-15  Daniel Bates  
+
+CSP: Allow schemeless source expressions to match an HTTP or HTTPS resource
+https://bugs.webkit.org/show_bug.cgi?id=154177
+
+
+Reviewed by Brent Fulgham.
+
+Allow a 

[webkit-changes] [196580] trunk/Websites/webkit.org

[timothy]

Title: [196580] trunk/Websites/webkit.org








Revision 196580
Author timo...@apple.com
Date 2016-02-15 09:52:17 -0800 (Mon, 15 Feb 2016)


Log Message
Fix byline to avoid bumping into content sticks out.

* wp-content/themes/webkit/style.css:
(article .byline): Bump padding to avoid content with negative margins.

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/themes/webkit/style.css




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (196579 => 196580)

--- trunk/Websites/webkit.org/ChangeLog	2016-02-15 17:44:47 UTC (rev 196579)
+++ trunk/Websites/webkit.org/ChangeLog	2016-02-15 17:52:17 UTC (rev 196580)
@@ -1,3 +1,10 @@
+2016-02-15  Timothy Hatcher  
+
+Fix byline to avoid bumping into content sticks out.
+
+* wp-content/themes/webkit/style.css:
+(article .byline): Bump padding to avoid content with negative margins.
+
 2016-02-13  Timothy Hatcher  
 
 Adjust the appearance of mattewhite figures that are not widescreen.


Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/style.css (196579 => 196580)

--- trunk/Websites/webkit.org/wp-content/themes/webkit/style.css	2016-02-15 17:44:47 UTC (rev 196579)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/style.css	2016-02-15 17:52:17 UTC (rev 196580)
@@ -985,7 +985,7 @@
 float: left;
 width: 191px;
 text-align: right;
-padding-right: 3rem;
+padding-right: 4rem;
 box-sizing: border-box;
 }
 
@@ -1704,6 +1704,7 @@
 float: none;
 text-align: center;
 margin-bottom: 3rem;
+padding-right: 0;
 }
 
 article .byline p {
@@ -1725,6 +1726,7 @@
 float: none;
 text-align: center;
 margin-bottom: 3rem;
+padding-right: 0;
 }
 
 article .byline p {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196579] trunk/LayoutTests

[ryanhaddad]

Title: [196579] trunk/LayoutTests








Revision 196579
Author ryanhad...@apple.com
Date 2016-02-15 09:44:47 -0800 (Mon, 15 Feb 2016)


Log Message
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196563

Unreviewed test gardening.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (196578 => 196579)

--- trunk/LayoutTests/ChangeLog	2016-02-15 15:53:53 UTC (rev 196578)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 17:44:47 UTC (rev 196579)
@@ -1,3 +1,11 @@
+2016-02-15  Ryan Haddad  
+
+Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196563
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
+
 2016-02-15  Hunseop Jeong  
 
 Unreviewed. EFL gardening after r195740.


Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (196578 => 196579)

--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-15 15:53:53 UTC (rev 196578)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-02-15 17:44:47 UTC (rev 196579)
@@ -3799,14 +3799,10 @@
 FAIL DragEvent interface: existence and properties of interface prototype object assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
 FAIL DragEvent interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
 FAIL DragEvent interface: attribute dataTransfer assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
-FAIL Window interface: existence and properties of interface object assert_equals: prototype of Window is not EventTarget expected function "function EventTarget() {
-[native code]
-}" but got function "function () {
-[native code]
-}"
+PASS Window interface: existence and properties of interface object 
 PASS Window interface object length 
 PASS Window interface object name 
-FAIL Window interface: existence and properties of interface prototype object assert_equals: Class name for prototype of Window.prototype is not "WindowProperties" expected "[object WindowProperties]" but got "[object Object]"
+FAIL Window interface: existence and properties of interface prototype object assert_equals: Class name for prototype of Window.prototype is not "WindowProperties" expected "[object WindowProperties]" but got "[object EventTargetPrototype]"
 FAIL Window interface: existence and properties of interface prototype object's "constructor" property assert_own_property: Window.prototype does not have own property "constructor" expected property "constructor" missing
 PASS Window interface: attribute self 
 PASS Window interface: attribute name 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196578] trunk/Source/WebCore

[commit-queue]

Title: [196578] trunk/Source/WebCore








Revision 196578
Author commit-qu...@webkit.org
Date 2016-02-15 07:53:53 -0800 (Mon, 15 Feb 2016)


Log Message
[cmake] Consolidated Linux-specific file lists.
https://bugs.webkit.org/show_bug.cgi?id=154219

Patch by Konstantin Tokarev  on 2016-02-15
Reviewed by Gyuyoung Kim.

No new tests needed.

* PlatformEfl.cmake: Moved Linux files and include dir to Linux.cmake.
* PlatformGTK.cmake: Ditto.
* platform/Linux.cmake: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/PlatformGTK.cmake


Added Paths

trunk/Source/WebCore/platform/Linux.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (196577 => 196578)

--- trunk/Source/WebCore/ChangeLog	2016-02-15 13:30:33 UTC (rev 196577)
+++ trunk/Source/WebCore/ChangeLog	2016-02-15 15:53:53 UTC (rev 196578)
@@ -1,3 +1,16 @@
+2016-02-15  Konstantin Tokarev  
+
+[cmake] Consolidated Linux-specific file lists.
+https://bugs.webkit.org/show_bug.cgi?id=154219
+
+Reviewed by Gyuyoung Kim.
+
+No new tests needed.
+
+* PlatformEfl.cmake: Moved Linux files and include dir to Linux.cmake.
+* PlatformGTK.cmake: Ditto.
+* platform/Linux.cmake: Added.
+
 2016-02-15  Csaba Osztrogonác  
 
 Fix the !(ENABLE(SVG_FONTS) || ENABLE(SVG_OTF_CONVERTER)) build after r196322


Modified: trunk/Source/WebCore/PlatformEfl.cmake (196577 => 196578)

--- trunk/Source/WebCore/PlatformEfl.cmake	2016-02-15 13:30:33 UTC (rev 196577)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2016-02-15 15:53:53 UTC (rev 196578)
@@ -1,5 +1,6 @@
 include(platform/GStreamer.cmake)
 include(platform/ImageDecoders.cmake)
+include(platform/Linux.cmake)
 include(platform/TextureMapper.cmake)
 
 list(APPEND WebCore_INCLUDE_DIRECTORIES
@@ -40,7 +41,6 @@
 "${WEBCORE_DIR}/platform/graphics/surfaces/efl"
 "${WEBCORE_DIR}/platform/graphics/surfaces/glx"
 "${WEBCORE_DIR}/platform/graphics/x11"
-"${WEBCORE_DIR}/platform/linux"
 "${WEBCORE_DIR}/platform/mock/mediasource"
 "${WEBCORE_DIR}/platform/network/soup"
 "${WEBCORE_DIR}/platform/text/efl"
@@ -187,9 +187,6 @@
 
 platform/image-decoders/cairo/ImageDecoderCairo.cpp
 
-platform/linux/GamepadDeviceLinux.cpp
-platform/linux/MemoryPressureHandlerLinux.cpp
-
 platform/network/efl/NetworkStateNotifierEfl.cpp
 
 platform/network/soup/AuthenticationChallengeSoup.cpp


Modified: trunk/Source/WebCore/PlatformGTK.cmake (196577 => 196578)

--- trunk/Source/WebCore/PlatformGTK.cmake	2016-02-15 13:30:33 UTC (rev 196577)
+++ trunk/Source/WebCore/PlatformGTK.cmake	2016-02-15 15:53:53 UTC (rev 196578)
@@ -1,5 +1,6 @@
 include(platform/GStreamer.cmake)
 include(platform/ImageDecoders.cmake)
+include(platform/Linux.cmake)
 include(platform/TextureMapper.cmake)
 
 set(WebCore_OUTPUT_NAME WebCoreGTK)
@@ -43,7 +44,6 @@
 "${WEBCORE_DIR}/platform/graphics/opentype"
 "${WEBCORE_DIR}/platform/graphics/wayland"
 "${WEBCORE_DIR}/platform/graphics/x11"
-"${WEBCORE_DIR}/platform/linux"
 "${WEBCORE_DIR}/platform/mock/mediasource"
 "${WEBCORE_DIR}/platform/network/gtk"
 "${WEBCORE_DIR}/platform/network/soup"
@@ -152,9 +152,6 @@
 
 platform/image-decoders/cairo/ImageDecoderCairo.cpp
 
-platform/linux/GamepadDeviceLinux.cpp
-platform/linux/MemoryPressureHandlerLinux.cpp
-
 platform/network/gtk/CredentialBackingStore.cpp
 
 platform/network/soup/AuthenticationChallengeSoup.cpp


Added: trunk/Source/WebCore/platform/Linux.cmake (0 => 196578)

--- trunk/Source/WebCore/platform/Linux.cmake	(rev 0)
+++ trunk/Source/WebCore/platform/Linux.cmake	2016-02-15 15:53:53 UTC (rev 196578)
@@ -0,0 +1,8 @@
+list(APPEND WebCore_INCLUDE_DIRECTORIES
+"${WEBCORE_DIR}/platform/linux"
+)
+
+list(APPEND WebCore_SOURCES
+platform/linux/GamepadDeviceLinux.cpp
+platform/linux/MemoryPressureHandlerLinux.cpp
+)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196576] trunk/Source/WebCore

[ossy]

Title: [196576] trunk/Source/WebCore








Revision 196576
Author o...@webkit.org
Date 2016-02-15 04:28:20 -0800 (Mon, 15 Feb 2016)


Log Message
Fix the !(ENABLE(SVG_FONTS) || ENABLE(SVG_OTF_CONVERTER)) build after r196322
https://bugs.webkit.org/show_bug.cgi?id=154104

Reviewed by Myles C. Maxfield.

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (196575 => 196576)

--- trunk/Source/WebCore/ChangeLog	2016-02-15 10:30:36 UTC (rev 196575)
+++ trunk/Source/WebCore/ChangeLog	2016-02-15 12:28:20 UTC (rev 196576)
@@ -1,3 +1,13 @@
+2016-02-15  Csaba Osztrogonác  
+
+Fix the !(ENABLE(SVG_FONTS) || ENABLE(SVG_OTF_CONVERTER)) build after r196322
+https://bugs.webkit.org/show_bug.cgi?id=154104
+
+Reviewed by Myles C. Maxfield.
+
+* css/CSSFontFaceSource.cpp:
+(WebCore::CSSFontFaceSource::CSSFontFaceSource):
+
 2016-02-14  Antti Koivisto  
 
 Add test for class change style invalidation optimization


Modified: trunk/Source/WebCore/css/CSSFontFaceSource.cpp (196575 => 196576)

--- trunk/Source/WebCore/css/CSSFontFaceSource.cpp	2016-02-15 10:30:36 UTC (rev 196575)
+++ trunk/Source/WebCore/css/CSSFontFaceSource.cpp	2016-02-15 12:28:20 UTC (rev 196576)
@@ -76,8 +76,14 @@
 : m_familyNameOrURI(familyNameOrURI)
 , m_font(font)
 , m_face(owner)
+#if ENABLE(SVG_FONTS) || ENABLE(SVG_OTF_CONVERTER)
 , m_svgFontFaceElement(fontFace)
+#endif
 {
+#if !(ENABLE(SVG_FONTS) || ENABLE(SVG_OTF_CONVERTER))
+UNUSED_PARAM(fontFace);
+#endif
+
 // This may synchronously call fontLoaded().
 if (m_font)
 m_font->addClient(this);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [196575] trunk

[antti]

Title: [196575] trunk








Revision 196575
Author an...@apple.com
Date 2016-02-15 02:30:36 -0800 (Mon, 15 Feb 2016)


Log Message
Add test for class change style invalidation optimization
https://bugs.webkit.org/show_bug.cgi?id=154226

Reviewed by Myles Maxfield.

Test for https://trac.webkit.org/r196383

Source/WebCore:

Add internals.styleChangeType function.

Test: fast/css/style-invalidation-class-change-descendants.html

* testing/Internals.cpp:
(WebCore::Internals::nodeNeedsStyleRecalc):
(WebCore::asString):
(WebCore::Internals::styleChangeType):
(WebCore::Internals::description):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* fast/css/style-invalidation-class-change-descendants-expected.txt: Added.
* fast/css/style-invalidation-class-change-descendants.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Added Paths

trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt
trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants.html




Diff

Modified: trunk/LayoutTests/ChangeLog (196574 => 196575)

--- trunk/LayoutTests/ChangeLog	2016-02-15 09:50:29 UTC (rev 196574)
+++ trunk/LayoutTests/ChangeLog	2016-02-15 10:30:36 UTC (rev 196575)
@@ -1,3 +1,15 @@
+2016-02-14  Antti Koivisto  
+
+Add test for class change style invalidation optimization
+https://bugs.webkit.org/show_bug.cgi?id=154226
+
+Reviewed by Myles Maxfield.
+
+Test for https://trac.webkit.org/r196383
+
+* fast/css/style-invalidation-class-change-descendants-expected.txt: Added.
+* fast/css/style-invalidation-class-change-descendants.html: Added.
+
 2016-02-15  Hunseop Jeong  
 
 Unreviewed. EFL gardening. Mark more video tests to failure.


Added: trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt (0 => 196575)

--- trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/style-invalidation-class-change-descendants-expected.txt	2016-02-15 10:30:36 UTC (rev 196575)
@@ -0,0 +1,57 @@
+Test that we invalidate the element subtree minimally on class attribute change
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS hasExpectedStyle is true
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "NoStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Adding class NotThere
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "NoStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+Adding class style1
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Adding class style2
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Removing class style2
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Adding class style3
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Removing class style3
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "InlineStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Adding class style4
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "NoStyleChange") is true
+PASS testStyleChangeType("inert", "NoStyleChange") is true
+PASS hasExpectedStyle is true
+Removing class NotThere
+PASS testStyleChangeType("root", "NoStyleChange") || testStyleChangeType("root", "InlineStyleChange") is true
+PASS testStyleChangeType("target", "NoStyleChange") is true
+PASS 

[webkit-changes] [196573] trunk/Source/JavaScriptCore

[commit-queue]

Title: [196573] trunk/Source/_javascript_Core








Revision 196573
Author commit-qu...@webkit.org
Date 2016-02-15 01:12:45 -0800 (Mon, 15 Feb 2016)


Log Message
[JSC] Improve the interface of Inst::shouldTryAliasingDef()
https://bugs.webkit.org/show_bug.cgi?id=154227

Patch by Benjamin Poulain  on 2016-02-15
Reviewed by Andreas Kling.

Using Optional<> instead of a bool+reference looks cleaner
at the call sites.

* b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::shouldTryAliasingDef):
* b3/B3CheckSpecial.h:
* b3/air/AirCustom.h:
(JSC::B3::Air::PatchCustom::shouldTryAliasingDef):
* b3/air/AirInst.h:
* b3/air/AirInstInlines.h:
(JSC::B3::Air::Inst::shouldTryAliasingDef):
* b3/air/AirIteratedRegisterCoalescing.cpp:
* b3/air/AirSpecial.cpp:
(JSC::B3::Air::Special::shouldTryAliasingDef):
* b3/air/AirSpecial.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3CheckSpecial.cpp
trunk/Source/_javascript_Core/b3/B3CheckSpecial.h
trunk/Source/_javascript_Core/b3/air/AirCustom.h
trunk/Source/_javascript_Core/b3/air/AirInst.h
trunk/Source/_javascript_Core/b3/air/AirInstInlines.h
trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp
trunk/Source/_javascript_Core/b3/air/AirSpecial.cpp
trunk/Source/_javascript_Core/b3/air/AirSpecial.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (196572 => 196573)

--- trunk/Source/_javascript_Core/ChangeLog	2016-02-15 08:39:58 UTC (rev 196572)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-02-15 09:12:45 UTC (rev 196573)
@@ -1,3 +1,26 @@
+2016-02-15  Benjamin Poulain  
+
+[JSC] Improve the interface of Inst::shouldTryAliasingDef()
+https://bugs.webkit.org/show_bug.cgi?id=154227
+
+Reviewed by Andreas Kling.
+
+Using Optional<> instead of a bool+reference looks cleaner
+at the call sites.
+
+* b3/B3CheckSpecial.cpp:
+(JSC::B3::CheckSpecial::shouldTryAliasingDef):
+* b3/B3CheckSpecial.h:
+* b3/air/AirCustom.h:
+(JSC::B3::Air::PatchCustom::shouldTryAliasingDef):
+* b3/air/AirInst.h:
+* b3/air/AirInstInlines.h:
+(JSC::B3::Air::Inst::shouldTryAliasingDef):
+* b3/air/AirIteratedRegisterCoalescing.cpp:
+* b3/air/AirSpecial.cpp:
+(JSC::B3::Air::Special::shouldTryAliasingDef):
+* b3/air/AirSpecial.h:
+
 2016-02-14  Brian Burg  
 
 WKAutomationDelegate's requestAutomationSession should take a suggested session identifier


Modified: trunk/Source/_javascript_Core/b3/B3CheckSpecial.cpp (196572 => 196573)

--- trunk/Source/_javascript_Core/b3/B3CheckSpecial.cpp	2016-02-15 08:39:58 UTC (rev 196572)
+++ trunk/Source/_javascript_Core/b3/B3CheckSpecial.cpp	2016-02-15 09:12:45 UTC (rev 196573)
@@ -130,13 +130,11 @@
 return admitsStackImpl(numB3Args(inst), m_numCheckArgs + 1, inst, argIndex);
 }
 
-bool CheckSpecial::shouldTryAliasingDef(Inst& inst, unsigned& defIndex)
+Optional CheckSpecial::shouldTryAliasingDef(Inst& inst)
 {
-if (hiddenBranch(inst).shouldTryAliasingDef(defIndex)) {
-defIndex += 1;
-return true;
-}
-return false;
+if (Optional branchDef = hiddenBranch(inst).shouldTryAliasingDef())
+return *branchDef + 1;
+return Nullopt;
 }
 
 CCallHelpers::Jump CheckSpecial::generate(Inst& inst, CCallHelpers& jit, GenerationContext& context)


Modified: trunk/Source/_javascript_Core/b3/B3CheckSpecial.h (196572 => 196573)

--- trunk/Source/_javascript_Core/b3/B3CheckSpecial.h	2016-02-15 08:39:58 UTC (rev 196572)
+++ trunk/Source/_javascript_Core/b3/B3CheckSpecial.h	2016-02-15 09:12:45 UTC (rev 196573)
@@ -126,7 +126,7 @@
 void forEachArg(Air::Inst&, const ScopedLambda&) override;
 bool isValid(Air::Inst&) override;
 bool admitsStack(Air::Inst&, unsigned argIndex) override;
-bool shouldTryAliasingDef(Air::Inst&, unsigned& defIndex) override;
+Optional shouldTryAliasingDef(Air::Inst&) override;
 
 // NOTE: the generate method will generate the hidden branch and then register a LatePath that
 // generates the stackmap. Super crazy dude!


Modified: trunk/Source/_javascript_Core/b3/air/AirCustom.h (196572 => 196573)

--- trunk/Source/_javascript_Core/b3/air/AirCustom.h	2016-02-15 08:39:58 UTC (rev 196572)
+++ trunk/Source/_javascript_Core/b3/air/AirCustom.h	2016-02-15 09:12:45 UTC (rev 196573)
@@ -80,9 +80,9 @@
 return inst.args[0].special()->admitsStack(inst, argIndex);
 }
 
-static bool shouldTryAliasingDef(Inst& inst, unsigned& defIndex)
+static Optional shouldTryAliasingDef(Inst& inst)
 {
-return inst.args[0].special()->shouldTryAliasingDef(inst, defIndex);
+return inst.args[0].special()->shouldTryAliasingDef(inst);
 }
 
 static bool hasNonArgNonControlEffects(Inst& inst)


Modified: trunk/Source/_javascript_Core/b3/air/AirInst.h (196572 => 196573)

--- trunk/Source/_javascript_Core/b3/air/AirInst.h	

[webkit-changes] [196572] trunk/Source/WebKit2

[gyuyoung . kim]

Title: [196572] trunk/Source/WebKit2








Revision 196572
Author gyuyoung@webkit.org
Date 2016-02-15 00:39:58 -0800 (Mon, 15 Feb 2016)


Log Message
[CMake][Mac] Remove WKNPAPIPlugInContainer.mm in WebKit2/PlatformMac.cmake
https://bugs.webkit.org/show_bug.cgi?id=154234

Reviewed by Csaba Osztrogonác.

* PlatformMac.cmake: Remove WKNPAPIPlugInContainer.mm.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake




Diff

Modified: trunk/Source/WebKit2/ChangeLog (196571 => 196572)

--- trunk/Source/WebKit2/ChangeLog	2016-02-15 05:10:58 UTC (rev 196571)
+++ trunk/Source/WebKit2/ChangeLog	2016-02-15 08:39:58 UTC (rev 196572)
@@ -1,3 +1,12 @@
+2016-02-15  Gyuyoung Kim  
+
+[CMake][Mac] Remove WKNPAPIPlugInContainer.mm in WebKit2/PlatformMac.cmake
+https://bugs.webkit.org/show_bug.cgi?id=154234
+
+Reviewed by Csaba Osztrogonác.
+
+* PlatformMac.cmake: Remove WKNPAPIPlugInContainer.mm.
+
 2016-02-14  Chris Dumez  
 
 Unreviewed, land an additional Mac CMake build fix.


Modified: trunk/Source/WebKit2/PlatformMac.cmake (196571 => 196572)

--- trunk/Source/WebKit2/PlatformMac.cmake	2016-02-15 05:10:58 UTC (rev 196571)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2016-02-15 08:39:58 UTC (rev 196572)
@@ -282,7 +282,6 @@
 
 WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm
 WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm
-WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.mm
 
 WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm
 WebProcess/Plugins/PDF/PDFPlugin.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes