[webkit-changes] [198519] trunk/LayoutTests

[joepeck]

Title: [198519] trunk/LayoutTests








Revision 198519
Author joep...@webkit.org
Date 2016-03-21 20:48:28 -0700 (Mon, 21 Mar 2016)


Log Message
Skip HeapSnapshot test on WebKit1. Shared VM skews the data.

Rubber-stamped by Timothy Hatcher.

In this case, snapshots with snapshots with snapshots in the same VM
causes the test to run out of memory. This does not happen in WebKit2.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (198518 => 198519)

--- trunk/LayoutTests/ChangeLog	2016-03-22 02:58:19 UTC (rev 198518)
+++ trunk/LayoutTests/ChangeLog	2016-03-22 03:48:28 UTC (rev 198519)
@@ -1,3 +1,14 @@
+2016-03-21  Joseph Pecoraro  
+
+Skip HeapSnapshot test on WebKit1. Shared VM skews the data.
+
+Rubber-stamped by Timothy Hatcher.
+
+In this case, snapshots with snapshots with snapshots in the same VM
+causes the test to run out of memory. This does not happen in WebKit2.
+
+* platform/mac-wk1/TestExpectations:
+
 2016-03-21  Zalan Bujtas  
 
 WebCore::RenderTableCell::setCol should put a cap on the column value. 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (198518 => 198519)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2016-03-22 02:58:19 UTC (rev 198518)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2016-03-22 03:48:28 UTC (rev 198519)
@@ -194,6 +194,7 @@
 # WK1 Inspector running in the same VM as the inspected page skews heap snapshot results.
 inspector/heap/getPreview.html [ Skip ]
 inspector/heap/getRemoteObject.html [ Skip ]
+inspector/unit-tests/heap-snapshot.html [ Skip ]
 
 # This test checks ScrollAnimator events only for main frame scrollbars that use native widgets in WK1.
 fast/scrolling/scroll-animator-overlay-scrollbars-hovered.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198518] trunk/Websites/perf.webkit.org

[rniwa]

Title: [198518] trunk/Websites/perf.webkit.org








Revision 198518
Author rn...@webkit.org
Date 2016-03-21 19:58:19 -0700 (Mon, 21 Mar 2016)


Log Message
Commit log viewer repaints too frequently after r198499
https://bugs.webkit.org/show_bug.cgi?id=155732

Reviewed by Joseph Pecoraro.

The bug was caused by InteractiveTimeSeriesChart invoking onchange callback whenever mouse moved even
if the current point didn't change. Fixed the bug by avoiding the work if the indicator hadn't changed
and avoiding work in the commit log viewer when the requested repository and the revision range were
the same as those of the last request.

* public/v3/components/commit-log-viewer.js:
(CommitLogViewer):
(CommitLogViewer.prototype.currentRepository): Exit early when repository and the revision range are
identical to the one we already have to avoid repaints and issuing multiple network requests.
* public/v3/components/interactive-time-series-chart.js:
(InteractiveTimeSeriesChart.prototype._mouseMove): Don't invoke _notifyIndicatorChanged if the current
indicator hadn't changed.
* public/v3/pages/chart-pane.js:
(ChartPane.prototype._indicatorDidChange): Fixed the bug that unlocking the indicator wouldn't update
the URL. We need to check whether the lock state had changed. The old condition was also redundant
since _mainChartIndicatorWasLocked is always identically equal to isLocked per the prior assignment.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js
trunk/Websites/perf.webkit.org/public/v3/components/interactive-time-series-chart.js
trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (198517 => 198518)

--- trunk/Websites/perf.webkit.org/ChangeLog	2016-03-22 01:53:50 UTC (rev 198517)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2016-03-22 02:58:19 UTC (rev 198518)
@@ -1,5 +1,29 @@
 2016-03-21  Ryosuke Niwa  
 
+Commit log viewer repaints too frequently after r198499
+https://bugs.webkit.org/show_bug.cgi?id=155732
+
+Reviewed by Joseph Pecoraro.
+
+The bug was caused by InteractiveTimeSeriesChart invoking onchange callback whenever mouse moved even
+if the current point didn't change. Fixed the bug by avoiding the work if the indicator hadn't changed
+and avoiding work in the commit log viewer when the requested repository and the revision range were
+the same as those of the last request.
+
+* public/v3/components/commit-log-viewer.js:
+(CommitLogViewer):
+(CommitLogViewer.prototype.currentRepository): Exit early when repository and the revision range are
+identical to the one we already have to avoid repaints and issuing multiple network requests.
+* public/v3/components/interactive-time-series-chart.js:
+(InteractiveTimeSeriesChart.prototype._mouseMove): Don't invoke _notifyIndicatorChanged if the current
+indicator hadn't changed.
+* public/v3/pages/chart-pane.js:
+(ChartPane.prototype._indicatorDidChange): Fixed the bug that unlocking the indicator wouldn't update
+the URL. We need to check whether the lock state had changed. The old condition was also redundant
+since _mainChartIndicatorWasLocked is always identically equal to isLocked per the prior assignment.
+
+2016-03-21  Ryosuke Niwa  
+
 Fix A/B testing after r198503.
 
 * public/include/build-requests-fetcher.php:


Modified: trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js (198517 => 198518)

--- trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js	2016-03-22 01:53:50 UTC (rev 198517)
+++ trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js	2016-03-22 02:58:19 UTC (rev 198518)
@@ -7,13 +7,21 @@
 this._repository = null;
 this._fetchingPromise = null;
 this._commits = null;
+this._from = null;
+this._to = null;
 }
 
 currentRepository() { return this._repository; }
 
 view(repository, from, to)
 {
+if (this._repository == repository && this._from == from && this._to == to)
+return Promise.resolve(null);
+
 this._commits = null;
+this._repository = repository;
+this._from = from;
+this._to = to;
 
 if (!repository) {
 this._fetchingPromise = null;
@@ -21,8 +29,6 @@
 return Promise.resolve(null);
 }
 
-this._repository = repository;
-
 if (!to) {
 this._fetchingPromise = null;
 this.render();


Modified: trunk/Websites/perf.webkit.org/public/v3/components/interactive-time-series-chart.js (198517 => 198518)

--- trunk/Websites/perf.webkit.org/public/v3/components/interactive-time-series-chart.js	2016-03-22 01:53:50 UTC (rev 198517)
+++ 

[webkit-changes] [198517] tags/Safari-601.6.12/Source

[matthew_hanson]

Title: [198517] tags/Safari-601.6.12/Source








Revision 198517
Author matthew_han...@apple.com
Date 2016-03-21 18:53:50 -0700 (Mon, 21 Mar 2016)


Log Message
Versioning

Modified Paths

tags/Safari-601.6.12/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-601.6.12/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-601.6.12/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-601.6.12/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-601.6.12/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-601.6.12/Source/_javascript_Core/Configurations/Version.xcconfig (198516 => 198517)

--- tags/Safari-601.6.12/Source/_javascript_Core/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
+++ tags/Safari-601.6.12/Source/_javascript_Core/Configurations/Version.xcconfig	2016-03-22 01:53:50 UTC (rev 198517)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-601.6.12/Source/WebCore/Configurations/Version.xcconfig (198516 => 198517)

--- tags/Safari-601.6.12/Source/WebCore/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
+++ tags/Safari-601.6.12/Source/WebCore/Configurations/Version.xcconfig	2016-03-22 01:53:50 UTC (rev 198517)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-601.6.12/Source/WebInspectorUI/Configurations/Version.xcconfig (198516 => 198517)

--- tags/Safari-601.6.12/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
+++ tags/Safari-601.6.12/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-03-22 01:53:50 UTC (rev 198517)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-601.6.12/Source/WebKit/mac/Configurations/Version.xcconfig (198516 => 198517)

--- tags/Safari-601.6.12/Source/WebKit/mac/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
+++ tags/Safari-601.6.12/Source/WebKit/mac/Configurations/Version.xcconfig	2016-03-22 01:53:50 UTC (rev 198517)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-601.6.12/Source/WebKit2/Configurations/Version.xcconfig (198516 => 198517)

--- tags/Safari-601.6.12/Source/WebKit2/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
+++ tags/Safari-601.6.12/Source/WebKit2/Configurations/Version.xcconfig	2016-03-22 01:53:50 UTC (rev 198517)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 12;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198516] tags/Safari-601.1.46.122/Source

[matthew_hanson]

Title: [198516] tags/Safari-601.1.46.122/Source








Revision 198516
Author matthew_han...@apple.com
Date 2016-03-21 18:47:38 -0700 (Mon, 21 Mar 2016)


Log Message
Versioning.

Modified Paths

tags/Safari-601.1.46.122/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-601.1.46.122/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-601.1.46.122/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-601.1.46.122/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-601.1.46.122/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-601.1.46.122/Source/_javascript_Core/Configurations/Version.xcconfig (198515 => 198516)

--- tags/Safari-601.1.46.122/Source/_javascript_Core/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
+++ tags/Safari-601.1.46.122/Source/_javascript_Core/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 122;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-601.1.46.122/Source/WebCore/Configurations/Version.xcconfig (198515 => 198516)

--- tags/Safari-601.1.46.122/Source/WebCore/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
+++ tags/Safari-601.1.46.122/Source/WebCore/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 122;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-601.1.46.122/Source/WebInspectorUI/Configurations/Version.xcconfig (198515 => 198516)

--- tags/Safari-601.1.46.122/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
+++ tags/Safari-601.1.46.122/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 122;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-601.1.46.122/Source/WebKit/mac/Configurations/Version.xcconfig (198515 => 198516)

--- tags/Safari-601.1.46.122/Source/WebKit/mac/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
+++ tags/Safari-601.1.46.122/Source/WebKit/mac/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 122;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-601.1.46.122/Source/WebKit2/Configurations/Version.xcconfig (198515 => 198516)

--- tags/Safari-601.1.46.122/Source/WebKit2/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
+++ tags/Safari-601.1.46.122/Source/WebKit2/Configurations/Version.xcconfig	2016-03-22 01:47:38 UTC (rev 198516)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 122;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198515] branches/safari-601.1.46-branch/Source

[matthew_hanson]

Title: [198515] branches/safari-601.1.46-branch/Source








Revision 198515
Author matthew_han...@apple.com
Date 2016-03-21 18:39:50 -0700 (Mon, 21 Mar 2016)


Log Message
Versioning.

Modified Paths

branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (198514 => 198515)

--- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 123;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (198514 => 198515)

--- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
+++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 123;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (198514 => 198515)

--- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
+++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 123;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (198514 => 198515)

--- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
+++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 123;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (198514 => 198515)

--- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
+++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-03-22 01:39:50 UTC (rev 198515)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 121;
+MICRO_VERSION = 123;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198514] branches/safari-601-branch/Source

[matthew_hanson]

Title: [198514] branches/safari-601-branch/Source








Revision 198514
Author matthew_han...@apple.com
Date 2016-03-21 18:36:12 -0700 (Mon, 21 Mar 2016)


Log Message
Versioning.

Modified Paths

branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig (198513 => 198514)

--- branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-03-22 01:35:04 UTC (rev 198513)
+++ branches/safari-601-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 13;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig (198513 => 198514)

--- branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2016-03-22 01:35:04 UTC (rev 198513)
+++ branches/safari-601-branch/Source/WebCore/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 13;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (198513 => 198514)

--- branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-03-22 01:35:04 UTC (rev 198513)
+++ branches/safari-601-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 13;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig (198513 => 198514)

--- branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-03-22 01:35:04 UTC (rev 198513)
+++ branches/safari-601-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 13;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig (198513 => 198514)

--- branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-03-22 01:35:04 UTC (rev 198513)
+++ branches/safari-601-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-03-22 01:36:12 UTC (rev 198514)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 601;
 MINOR_VERSION = 6;
-TINY_VERSION = 11;
+TINY_VERSION = 13;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198512] tags/Safari-601.1.46.122/

[matthew_hanson]

Title: [198512] tags/Safari-601.1.46.122/








Revision 198512
Author matthew_han...@apple.com
Date 2016-03-21 18:21:09 -0700 (Mon, 21 Mar 2016)


Log Message
New Tag.

Added Paths

tags/Safari-601.1.46.122/




Diff

Property changes: tags/Safari-601.1.46.122



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198511] trunk/Source/WebInspectorUI

[mattbaker]

Title: [198511] trunk/Source/WebInspectorUI








Revision 198511
Author mattba...@apple.com
Date 2016-03-21 17:51:43 -0700 (Mon, 21 Mar 2016)


Log Message
Web Inspector: New icon for Heap Allocations timeline
https://bugs.webkit.org/show_bug.cgi?id=155731


Reviewed by Joseph Pecoraro and Timothy Hatcher.

* UserInterface/Images/HeapAllocationsInstrument.svg: Added.
New artwork from Jon Davis.

* UserInterface/Views/TimelineIcons.css:
(.heap-allocations-icon .icon):
(body:not(.mac-platform, .windows-platform) .memory-icon .icon):
(body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon):
New icon styles/fallbacks for GTK.

* UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
Add new icon class to UI helper method.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Images/HeapAllocationsInstrument.svg




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (198510 => 198511)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-03-22 00:51:17 UTC (rev 198510)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-03-22 00:51:43 UTC (rev 198511)
@@ -1,3 +1,24 @@
+2016-03-21  Matt Baker  
+
+Web Inspector: New icon for Heap Allocations timeline
+https://bugs.webkit.org/show_bug.cgi?id=155731
+
+
+Reviewed by Joseph Pecoraro and Timothy Hatcher.
+
+* UserInterface/Images/HeapAllocationsInstrument.svg: Added.
+New artwork from Jon Davis.
+
+* UserInterface/Views/TimelineIcons.css:
+(.heap-allocations-icon .icon):
+(body:not(.mac-platform, .windows-platform) .memory-icon .icon):
+(body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon):
+New icon styles/fallbacks for GTK.
+
+* UserInterface/Views/TimelineTabContentView.js:
+(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
+Add new icon class to UI helper method.
+
 2016-03-20  Dan Bernstein  
 
 [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR


Added: trunk/Source/WebInspectorUI/UserInterface/Images/HeapAllocationsInstrument.svg (0 => 198511)

--- trunk/Source/WebInspectorUI/UserInterface/Images/HeapAllocationsInstrument.svg	(rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/HeapAllocationsInstrument.svg	2016-03-22 00:51:43 UTC (rev 198511)
@@ -0,0 +1,7 @@
+
+
+
+
+
+
+


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css (198510 => 198511)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css	2016-03-22 00:51:17 UTC (rev 198510)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css	2016-03-22 00:51:43 UTC (rev 198511)
@@ -35,6 +35,10 @@
 content: url(../Images/MemoryInstrument.svg);
 }
 
+.heap-allocations-icon .icon {
+content: url(../Images/HeapAllocationsInstrument.svg);
+}
+
 .layout-icon .icon {
 content: url(../Images/LayoutInstrument.svg);
 }
@@ -72,6 +76,14 @@
 content: -webkit-image-set(url(../Images/Frames.png) 1x, url(../Images/fra...@2x.png) 2x);
 }
 
+body:not(.mac-platform, .windows-platform) .memory-icon .icon {
+content: -webkit-image-set(url(../Images/ScriptLarge.png) 1x, url(../Images/scriptla...@2x.png) 2x);
+}
+
+body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon {
+content: -webkit-image-set(url(../Images/ScriptLarge.png) 1x, url(../Images/scriptla...@2x.png) 2x);
+}
+
 .stopwatch-icon .icon {
 content: url(../Images/Stopwatch.svg);
 }


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js (198510 => 198511)

--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js	2016-03-22 00:51:17 UTC (rev 198510)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js	2016-03-22 00:51:43 UTC (rev 198511)
@@ -137,8 +137,7 @@
 case WebInspector.TimelineRecord.Type.Memory:
 return "memory-icon";
 case WebInspector.TimelineRecord.Type.HeapAllocations:
-// FIXME: HeapAllocation Timeline needs a new icon.
-return "memory-icon";
+return "heap-allocations-icon";
 case WebInspector.TimelineRecord.Type.Script:
 return "script-icon";
 case WebInspector.TimelineRecord.Type.RenderingFrame:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198510] tags/Safari-601.6.12/

[matthew_hanson]

Title: [198510] tags/Safari-601.6.12/








Revision 198510
Author matthew_han...@apple.com
Date 2016-03-21 17:51:17 -0700 (Mon, 21 Mar 2016)


Log Message
New Tag.

Added Paths

tags/Safari-601.6.12/




Diff

Property changes: tags/Safari-601.6.12



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198509] trunk/PerformanceTests

[jonlee]

Title: [198509] trunk/PerformanceTests








Revision 198509
Author jon...@apple.com
Date 2016-03-21 17:30:44 -0700 (Mon, 21 Mar 2016)


Log Message
Update benchmark tests
https://bugs.webkit.org/show_bug.cgi?id=155723

Reviewed by Darin Adler.
Provisionally reviewed by Said Abou-Hallawa.

Add quadratic and bezier segments to the canvas path test.

* Animometer/resources/runner/tests.js: Some of the query strings are unnecessary.
Rename the test.
* Animometer/tests/master/resources/canvas-stage.js:
(tune): Update to be able to take an array of possible constructors. Choose one randomly.
* Animometer/tests/master/resources/canvas-tests.js:
(CanvasLinePoint.Utilities.createClass): Move the point selection out to a separate
function called randomPoint() for reuse. Move X_LOOPS, Y_LOOPS, and offsets into the
class definition.
(randomPoint): Scale the grid down a little bit so that the lines along the edge of the
canvas are not cut off when the stroke size is thick.
(CanvasQuadraticSegment): Added.
(CanvasBezierSegment): Added.
(SimpleCanvasStage): Pass in an array of the different segment types. Since line segments
are short compared to the curved ones, make it twice as likely to render a line segment.
(SimpleCanvasStage.animate): Update the drawing code so that we render all line segments.

Add a helper method that selects a random element from an array.

* Animometer/tests/resources/main.js:
(Stage.randomElementInArray): Select a random element from the provided array.

* Animometer/tests/bouncing-particles/resources/bouncing-tagged-images.js: Refactor.
* Animometer/tests/dom/resources/leaves.js: Ditto.
* Animometer/tests/master/resources/dom-particles.js: Ditto.
* Animometer/tests/master/resources/image-data.js: Ditto.
* Animometer/tests/master/resources/leaves.js: Ditto.
* Animometer/tests/simple/resources/simple-canvas-paths.js: Ditto.

Add canvas tests that includes all stroke and fill paths. This makes it possible to avoid having to
include the full simple canvas suite for perf testing.

* Animometer/resources/debug-runner/tests.js: Add new tests. Move the canvas test into the Canvas
suite.
* Animometer/tests/simple/resources/simple-canvas-paths.js: Add a CanvasStroke and CanvasFill particle
that random selects an object to render.

* Animometer/resources/debug-runner/tests.js: Move 3D suite before basic canvas suite.
When updating the perf bot script, we will include the suites up to this one, but exclude
the basic canvas suite.

Move compositing transforms test to HTML suite and remove the empty Miscellaneous suite.

* Animometer/resources/debug-runner/tests.js:
* Animometer/tests/dom/compositing-transforms.html: Renamed from PerformanceTests/Animometer/tests/misc/compositing-transforms.html.
* Animometer/tests/dom/resources/compositing-transforms.js: Renamed from PerformanceTests/Animometer/tests/misc/resources/compositing-transforms.js.

Clean up miscellaneous test suite. Add a canvas ellipse test, and remove the other
canvas tests.

* Animometer/resources/debug-runner/tests.js: Add ellipse tests to the simple suite.
* Animometer/tests/misc/canvas-electrons.html: Removed.
* Animometer/tests/misc/canvas-stars.html: Removed.
* Animometer/tests/misc/resources/canvas-electrons.js: Removed.
* Animometer/tests/misc/resources/canvas-stars.js: Removed.
* Animometer/tests/simple/resources/simple-canvas-paths.js: Add ellipse primitives.

Merge text tests together into one.

* Animometer/resources/runner/tests.js: Remove international.html.
* Animometer/tests/master/international.html: Removed.
* Animometer/tests/master/resources/text.js:
(animate): Update styling. Manually calculate gradients for the shadow particles.
Reduce the step size for y direction to avoid cutting text off at the margins. Increase
step for x since there will be a little more room.
* Animometer/tests/master/text.html: Add more translations and lay it out in a table.

Modified Paths

trunk/PerformanceTests/Animometer/resources/debug-runner/tests.js
trunk/PerformanceTests/Animometer/resources/runner/tests.js
trunk/PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-tagged-images.js
trunk/PerformanceTests/Animometer/tests/dom/resources/leaves.js
trunk/PerformanceTests/Animometer/tests/master/resources/canvas-stage.js
trunk/PerformanceTests/Animometer/tests/master/resources/canvas-tests.js
trunk/PerformanceTests/Animometer/tests/master/resources/dom-particles.js
trunk/PerformanceTests/Animometer/tests/master/resources/image-data.js
trunk/PerformanceTests/Animometer/tests/master/resources/leaves.js
trunk/PerformanceTests/Animometer/tests/master/resources/text.js
trunk/PerformanceTests/Animometer/tests/master/text.html
trunk/PerformanceTests/Animometer/tests/resources/main.js
trunk/PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js
trunk/PerformanceTests/ChangeLog


Added Paths

trunk/PerformanceTests/Animometer/tests/dom/compositing-transforms.html

[webkit-changes] [198508] trunk/Websites/perf.webkit.org

[rniwa]

Title: [198508] trunk/Websites/perf.webkit.org








Revision 198508
Author rn...@webkit.org
Date 2016-03-21 17:22:14 -0700 (Mon, 21 Mar 2016)


Log Message
Fix A/B testing after r198503.

* public/include/build-requests-fetcher.php:

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (198507 => 198508)

--- trunk/Websites/perf.webkit.org/ChangeLog	2016-03-22 00:06:53 UTC (rev 198507)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2016-03-22 00:22:14 UTC (rev 198508)
@@ -1,5 +1,11 @@
 2016-03-21  Ryosuke Niwa  
 
+Fix A/B testing after r198503.
+
+* public/include/build-requests-fetcher.php:
+
+2016-03-21  Ryosuke Niwa  
+
 Analysis task page is broken after r198479
 https://bugs.webkit.org/show_bug.cgi?id=155735
 


Modified: trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php (198507 => 198508)

--- trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php	2016-03-22 00:06:53 UTC (rev 198507)
+++ trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php	2016-03-22 00:22:14 UTC (rev 198508)
@@ -92,7 +92,7 @@
 
 $root_ids = array();
 foreach ($root_rows as $row) {
-$repository_id = $row['commit_repository'];
+$repository_id = $resolve_ids ? $row['repository_name'] : $row['repository_id'];
 $revision = $row['commit_revision'];
 $commit_time = $row['commit_time'];
 array_push($root_ids, $row['commit_id']);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198507] trunk

[bfulgham]

Title: [198507] trunk








Revision 198507
Author bfulg...@apple.com
Date 2016-03-21 17:06:53 -0700 (Mon, 21 Mar 2016)


Log Message
Improve SharedBuffer testing
https://bugs.webkit.org/show_bug.cgi?id=93078


Reviewed by Ryosuke Niwa.

Source/WebCore:

* platform/SharedBuffer.h: Mark a few methods as WEBCORE_EXPORT so they
can be used by TestWebKitAPI.

Tools:

Based on a Blink patch by Huang Dongsung .



Add three test cases from the Blink project that cover various append,
copy, and createArrayBuffer calls.

* TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/SharedBuffer.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (198506 => 198507)

--- trunk/Source/WebCore/ChangeLog	2016-03-21 23:29:58 UTC (rev 198506)
+++ trunk/Source/WebCore/ChangeLog	2016-03-22 00:06:53 UTC (rev 198507)
@@ -1,3 +1,14 @@
+2016-03-21  Brent Fulgham  
+
+Improve SharedBuffer testing
+https://bugs.webkit.org/show_bug.cgi?id=93078
+
+
+Reviewed by Ryosuke Niwa.
+
+* platform/SharedBuffer.h: Mark a few methods as WEBCORE_EXPORT so they
+can be used by TestWebKitAPI.
+
 2016-03-21  Zalan Bujtas  
 
 WebCore::RenderTableCell::setCol should put a cap on the column value. 


Modified: trunk/Source/WebCore/platform/SharedBuffer.h (198506 => 198507)

--- trunk/Source/WebCore/platform/SharedBuffer.h	2016-03-21 23:29:58 UTC (rev 198506)
+++ trunk/Source/WebCore/platform/SharedBuffer.h	2016-03-22 00:06:53 UTC (rev 198507)
@@ -83,7 +83,7 @@
 WEBCORE_EXPORT const char* data() const;
 // Creates an ArrayBuffer and copies this SharedBuffer's contents to that
 // ArrayBuffer without merging segmented buffers into a flat buffer.
-RefPtr createArrayBuffer() const;
+WEBCORE_EXPORT RefPtr createArrayBuffer() const;
 
 WEBCORE_EXPORT unsigned size() const;
 
@@ -92,7 +92,7 @@
 
 WEBCORE_EXPORT void append(SharedBuffer*);
 WEBCORE_EXPORT void append(const char*, unsigned);
-void append(const Vector&);
+WEBCORE_EXPORT void append(const Vector&);
 
 WEBCORE_EXPORT void clear();
 const char* platformData() const;


Modified: trunk/Tools/ChangeLog (198506 => 198507)

--- trunk/Tools/ChangeLog	2016-03-21 23:29:58 UTC (rev 198506)
+++ trunk/Tools/ChangeLog	2016-03-22 00:06:53 UTC (rev 198507)
@@ -1,3 +1,22 @@
+2016-03-21  Brent Fulgham  
+
+Improve SharedBuffer testing
+https://bugs.webkit.org/show_bug.cgi?id=93078
+
+
+Reviewed by Ryosuke Niwa.
+
+Based on a Blink patch by Huang Dongsung .
+
+
+
+Add three test cases from the Blink project that cover various append,
+copy, and createArrayBuffer calls.
+
+* TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
+(TestWebKitAPI::TEST_F):
+
 2016-03-21  Hyungwook Lee  
 
 [Win] Connect layoutTestController.findString() to support testing


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp (198506 => 198507)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp	2016-03-21 23:29:58 UTC (rev 198506)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp	2016-03-22 00:06:53 UTC (rev 198507)
@@ -1,5 +1,7 @@
 /*
+ * Copyright (C) 2016 Apple Inc. All rights reserved.
  * Copyright (C) 2015 Canon Inc. All rights reserved.
+ * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -116,4 +118,77 @@
 EXPECT_EQ('a', buffer->data()[strlen(SharedBufferTestData)]);
 }
 
+TEST_F(SharedBufferTest, createArrayBuffer)
+{
+char testData0[] = "Hello";
+char testData1[] = "World";
+char testData2[] = "Goodbye";
+RefPtr sharedBuffer = SharedBuffer::create(testData0, strlen(testData0));
+sharedBuffer->append(testData1, strlen(testData1));
+sharedBuffer->append(testData2, strlen(testData2));
+RefPtr arrayBuffer = sharedBuffer->createArrayBuffer();
+char expectedConcatenation[] = "HelloWorldGoodbye";
+ASSERT_EQ(strlen(expectedConcatenation), arrayBuffer->byteLength());
+EXPECT_EQ(0, memcmp(expectedConcatenation, arrayBuffer->data(), strlen(expectedConcatenation)));
 }
+
+TEST_F(SharedBufferTest, createArrayBufferLargeSegments)
+{
+Vector vector0(0x4000, 'a');
+Vector vector1(0x4000, 'b');
+Vector vector2(0x4000, 'c');
+
+RefPtr sharedBuffer = SharedBuffer::adoptVector(vector0);
+sharedBuffer->append(vector1);
+sharedBuffer->append(vector2);
+RefPtr arrayBuffer = sharedBuffer->createArrayBuffer();
+ASSERT_EQ(0x4000U + 0x4000U + 0x4000U, arrayBuffer->byteLength());
+int position 

[webkit-changes] [198506] trunk

[zalan]

Title: [198506] trunk








Revision 198506
Author za...@apple.com
Date 2016-03-21 16:29:58 -0700 (Mon, 21 Mar 2016)


Log Message
WebCore::RenderTableCell::setCol should put a cap on the column value.
https://bugs.webkit.org/show_bug.cgi?id=155642


Reviewed by Simon Fraser.

This patch ensures that we don't crash when the column number is large enough.
see webkit.org/b/71135 for more information.

Source/WebCore:

Test: tables/colspan-with-large-value-crash.html

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::setCol):

LayoutTests:

* tables/colspan-with-large-value-crash-expected.txt: Added.
* tables/colspan-with-large-value-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableCell.h


Added Paths

trunk/LayoutTests/tables/colspan-with-large-value-crash-expected.txt
trunk/LayoutTests/tables/colspan-with-large-value-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (198505 => 198506)

--- trunk/LayoutTests/ChangeLog	2016-03-21 23:05:18 UTC (rev 198505)
+++ trunk/LayoutTests/ChangeLog	2016-03-21 23:29:58 UTC (rev 198506)
@@ -1,3 +1,17 @@
+2016-03-21  Zalan Bujtas  
+
+WebCore::RenderTableCell::setCol should put a cap on the column value. 
+https://bugs.webkit.org/show_bug.cgi?id=155642
+
+
+Reviewed by Simon Fraser.
+
+This patch ensures that we don't crash when the column number is large enough.
+see webkit.org/b/71135 for more information.
+
+* tables/colspan-with-large-value-crash-expected.txt: Added.
+* tables/colspan-with-large-value-crash.html: Added.
+
 2016-03-21  Brady Eidson  
 
 storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html flaky on mac-wk2.


Added: trunk/LayoutTests/tables/colspan-with-large-value-crash-expected.txt (0 => 198506)

--- trunk/LayoutTests/tables/colspan-with-large-value-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/tables/colspan-with-large-value-crash-expected.txt	2016-03-21 23:29:58 UTC (rev 198506)
@@ -0,0 +1,2 @@
+PASS if no crash.
+


Added: trunk/LayoutTests/tables/colspan-with-large-value-crash.html (0 => 198506)

--- trunk/LayoutTests/tables/colspan-with-large-value-crash.html	(rev 0)
+++ trunk/LayoutTests/tables/colspan-with-large-value-crash.html	2016-03-21 23:29:58 UTC (rev 198506)
@@ -0,0 +1,19 @@
+
+
+
+This tests that we do not crash when colspan value is large.
+
+
+PASS if no crash.
+
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (198505 => 198506)

--- trunk/Source/WebCore/ChangeLog	2016-03-21 23:05:18 UTC (rev 198505)
+++ trunk/Source/WebCore/ChangeLog	2016-03-21 23:29:58 UTC (rev 198506)
@@ -1,3 +1,19 @@
+2016-03-21  Zalan Bujtas  
+
+WebCore::RenderTableCell::setCol should put a cap on the column value. 
+https://bugs.webkit.org/show_bug.cgi?id=155642
+
+
+Reviewed by Simon Fraser.
+
+This patch ensures that we don't crash when the column number is large enough.
+see webkit.org/b/71135 for more information.
+
+Test: tables/colspan-with-large-value-crash.html
+
+* rendering/RenderTableCell.h:
+(WebCore::RenderTableCell::setCol):
+
 2016-03-21  Simon Fraser  
 
 [iOS WK2] Use larger tiles when possible to reduce per-tile painting overhead


Modified: trunk/Source/WebCore/rendering/RenderTableCell.h (198505 => 198506)

--- trunk/Source/WebCore/rendering/RenderTableCell.h	2016-03-21 23:05:18 UTC (rev 198505)
+++ trunk/Source/WebCore/rendering/RenderTableCell.h	2016-03-21 23:29:58 UTC (rev 198506)
@@ -237,7 +237,7 @@
 inline void RenderTableCell::setCol(unsigned column)
 {
 if (UNLIKELY(column > maxColumnIndex))
-CRASH();
+column = maxColumnIndex;
 m_column = column;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198505] branches/safari-601.1.46-branch/Source/WebCore

[matthew_hanson]

Title: [198505] branches/safari-601.1.46-branch/Source/WebCore








Revision 198505
Author matthew_han...@apple.com
Date 2016-03-21 16:05:18 -0700 (Mon, 21 Mar 2016)


Log Message
Merge r197967. rdar://problem/25271137

Modified Paths

branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
branches/safari-601.1.46-branch/Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h
branches/safari-601.1.46-branch/Source/WebCore/svg/properties/SVGAnimatedProperty.cpp
branches/safari-601.1.46-branch/Source/WebCore/svg/properties/SVGAnimatedProperty.h
branches/safari-601.1.46-branch/Source/WebCore/svg/properties/SVGAnimatedPropertyTearOff.h
branches/safari-601.1.46-branch/Source/WebCore/svg/properties/SVGAnimatedStaticPropertyTearOff.h
branches/safari-601.1.46-branch/Source/WebCore/svg/properties/SVGPropertyTearOff.h




Diff

Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (198504 => 198505)

--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2016-03-21 22:57:43 UTC (rev 198504)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog	2016-03-21 23:05:18 UTC (rev 198505)
@@ -1,3 +1,99 @@
+2016-03-21  Matthew Hanson  
+
+Merge r197967. rdar://problem/25271137
+
+2016-03-10  Said Abou-Hallawa  
+
+REGRESSION: GuardMallloc crash in SVGListPropertyTearOff::processIncomingListItemWrapper
+https://bugs.webkit.org/show_bug.cgi?id=154969
+
+Reviewed by Darin Adler.
+
+The life cycle of the SVGAnimatedPropertyTearOff::m_baseVal and m_animVal
+was not correct. Like what was done in SVGAnimatedListPropertyTearOff,
+m_baseVal and m_animVal have to be raw RefCounted pointers. When requested
+through, SVGAnimatedPropertyTearOff::baseVal() and animVal() they are
+encapsulated in a RefPtr to ensure they existence as long as they are
+referenced. When the animated property object (which is stored in either
+m_baseVal or m_animVal) is not referenced by anyone, it is going to be
+deleted. In the destructor of their class, SVGAnimatedPropertyTearOff
+will be notified of this deletion through propertyWillBeDeleted() to clean
+its member m_baseVal or m_animVal.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(NativeToJSValue): Now all the SVG animated property return RefPtrs. In
+addition to that, SVGViewSpec.transform also returns
+RefPtr.
+
+* svg/properties/SVGAnimatedListPropertyTearOff.h:
+(WebCore::SVGAnimatedListPropertyTearOff::animVal):
+(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
+(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
+(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
+(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):
+(WebCore::SVGAnimatedListPropertyTearOff::isAnimating):
+(WebCore::SVGAnimatedListPropertyTearOff::propertyWillBeDeleted):
+Change propertyWillBeDeleted() to be virtual and make it takes an SVGProperty*.
+Rename m_animatingAnimVal to be m_animatedProperty. Add isAnimating() which
+returns true if m_animatedProperty is not null. Use isAnimating() instead of
+m_isAnimating because it's deleted from the base class.
+
+* svg/properties/SVGAnimatedProperty.cpp:
+(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):
+(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
+* svg/properties/SVGAnimatedProperty.h:
+(WebCore::SVGAnimatedProperty::isAnimating):
+(WebCore::SVGAnimatedProperty::propertyWillBeDeleted):
+Delete m_isAnimating since its value can be deduced from the value of
+m_animatedProperty in the derived class. Add propertyWillBeDeleted() and
+isAnimating() as virtual functions with the default behavior.
+
+* svg/properties/SVGAnimatedPropertyTearOff.h:
+(WebCore::SVGAnimatedPropertyTearOff::baseVal):
+(WebCore::SVGAnimatedPropertyTearOff::animVal):
+Like SVGAnimatedListPropertyTearOff::baseVal() and animVal() create the
+value if it does not exist. Keep a raw RefCounted pointer but return a
+RefPtr.
+
+(WebCore::SVGAnimatedPropertyTearOff::isAnimating):
+(WebCore::SVGAnimatedPropertyTearOff::propertyWillBeDeleted):
+Override virtual functions.
+
+(WebCore::SVGAnimatedPropertyTearOff::currentAnimatedValue):
+(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
+(WebCore::SVGAnimatedPropertyTearOff::animationEnded):
+

[webkit-changes] [198504] trunk/LayoutTests

[beidson]

Title: [198504] trunk/LayoutTests








Revision 198504
Author beid...@apple.com
Date 2016-03-21 15:57:43 -0700 (Mon, 21 Mar 2016)


Log Message
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=154748

Reviewed by Alex Christensen.

* platform/mac/TestExpectations:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt:
* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt
trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js




Diff

Modified: trunk/LayoutTests/ChangeLog (198503 => 198504)

--- trunk/LayoutTests/ChangeLog	2016-03-21 22:27:34 UTC (rev 198503)
+++ trunk/LayoutTests/ChangeLog	2016-03-21 22:57:43 UTC (rev 198504)
@@ -1,3 +1,15 @@
+2016-03-21  Brady Eidson  
+
+storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html flaky on mac-wk2.
+https://bugs.webkit.org/show_bug.cgi?id=154748
+
+Reviewed by Alex Christensen.
+
+* platform/mac/TestExpectations:
+* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
+* storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt:
+* storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js:
+
 2016-03-21  Simon Fraser  
 
 [iOS WK2] Use larger tiles when possible to reduce per-tile painting overhead


Modified: trunk/LayoutTests/platform/mac/TestExpectations (198503 => 198504)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-03-21 22:27:34 UTC (rev 198503)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-03-21 22:57:43 UTC (rev 198504)
@@ -1333,8 +1333,6 @@
 accessibility/mac/selection-element-tabbing-to-link.html [ Pass Failure ]
 accessibility/mac/selection-notification-focus-change.html [ Pass Failure ]
 
-webkit.org/b/154748 storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html [ Pass Failure ]
-
 webkit.org/b/152506 webgl/1.0.2/conformance/extensions/get-extension.html [ Pass Timeout ]
 
 webkit.org/b/154709 [ ElCapitan+ ] fast/text/crash-complex-text-surrogate.html [ Pass Failure ]


Modified: trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt (198503 => 198504)

--- trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt	2016-03-21 22:27:34 UTC (rev 198503)
+++ trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt	2016-03-21 22:57:43 UTC (rev 198504)
@@ -11,7 +11,9 @@
 prepareDatabase():
 versionChangeComplete = false
 h = event.target.result
+blockedCalled = false
 indexedDB.deleteDatabase(dbname)
+h.createObjectStore('testObjectStore').put('bar', 'foo')
 
 onVersionChange():
 PASS event.target.version is 1


Modified: trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt (198503 => 198504)

--- trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt	2016-03-21 22:27:34 UTC (rev 198503)
+++ trunk/LayoutTests/storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private-expected.txt	2016-03-21 22:57:43 UTC (rev 198504)
@@ -11,7 +11,9 @@
 prepareDatabase():
 versionChangeComplete = false
 h = event.target.result
+blockedCalled = false
 indexedDB.deleteDatabase(dbname)
+h.createObjectStore('testObjectStore').put('bar', 'foo')
 
 onVersionChange():
 PASS event.target.version is 1


Modified: trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js (198503 => 198504)

--- trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js	2016-03-21 22:27:34 UTC (rev 198503)
+++ trunk/LayoutTests/storage/indexeddb/resources/deletedatabase-delayed-by-open-and-versionchange.js	2016-03-21 22:57:43 UTC (rev 198504)
@@ -12,7 +12,8 @@
 preamble(evt);
 evalAndLog("versionChangeComplete = false");
 evalAndLog("h = event.target.result");
-
+evalAndLog("blockedCalled = false");
+
 h._onversionchange_ = function onVersionChange(evt) {
 preamble(evt);
 shouldBe("event.target.version", "1");
@@ -36,6 +37,9 @@
 shouldBeTrue("versionChangeComplete");
 finishJSTest();
 };
+
+// Make this upgrade transaction take longer so the deleteDatabase request will always have a chance to be blocked.
+

[webkit-changes] [198503] trunk/Websites/perf.webkit.org

[rniwa]

Title: [198503] trunk/Websites/perf.webkit.org








Revision 198503
Author rn...@webkit.org
Date 2016-03-21 15:27:34 -0700 (Mon, 21 Mar 2016)


Log Message
Analysis task page is broken after r198479
https://bugs.webkit.org/show_bug.cgi?id=155735

Rubber-stamped by Chris Dumez.

* public/api/measurement-set.php:
(AnalysisResultsFetcher::fetch_commits): We need to emit the commit ID as done for regular data.
* public/include/build-requests-fetcher.php:
(BuildRequestsFetcher::fetch_roots_for_set_if_needed): Ditto. Don't use a fake ID after r198479.
* public/v3/models/commit-log.js:
(CommitLog): Assert that all commit log IDs are integers to catch regressions like this in future.
* public/v3/models/root-set.js:
(RootSet): Don't resolve Repository here as doing so would modify the shared "root" entry in the JSON
we fetched, and subsequent construction of RootSet would fail since this line would blow up trying to
find the repository with "[object]" as the ID.
* public/v3/models/test-group.js:
(TestGroup._createModelsFromFetchedTestGroups): Resolve Repository here.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/api/measurement-set.php
trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php
trunk/Websites/perf.webkit.org/public/v3/models/commit-log.js
trunk/Websites/perf.webkit.org/public/v3/models/root-set.js
trunk/Websites/perf.webkit.org/public/v3/models/test-group.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (198502 => 198503)

--- trunk/Websites/perf.webkit.org/ChangeLog	2016-03-21 22:25:08 UTC (rev 198502)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2016-03-21 22:27:34 UTC (rev 198503)
@@ -1,5 +1,25 @@
 2016-03-21  Ryosuke Niwa  
 
+Analysis task page is broken after r198479
+https://bugs.webkit.org/show_bug.cgi?id=155735
+
+Rubber-stamped by Chris Dumez.
+
+* public/api/measurement-set.php:
+(AnalysisResultsFetcher::fetch_commits): We need to emit the commit ID as done for regular data.
+* public/include/build-requests-fetcher.php:
+(BuildRequestsFetcher::fetch_roots_for_set_if_needed): Ditto. Don't use a fake ID after r198479.
+* public/v3/models/commit-log.js:
+(CommitLog): Assert that all commit log IDs are integers to catch regressions like this in future.
+* public/v3/models/root-set.js:
+(RootSet): Don't resolve Repository here as doing so would modify the shared "root" entry in the JSON
+we fetched, and subsequent construction of RootSet would fail since this line would blow up trying to
+find the repository with "[object]" as the ID.
+* public/v3/models/test-group.js:
+(TestGroup._createModelsFromFetchedTestGroups): Resolve Repository here.
+
+2016-03-21  Ryosuke Niwa  
+
 v3 UI sometimes don't update the list of revisions on the commit log viewer
 https://bugs.webkit.org/show_bug.cgi?id=155729
 


Modified: trunk/Websites/perf.webkit.org/public/api/measurement-set.php (198502 => 198503)

--- trunk/Websites/perf.webkit.org/public/api/measurement-set.php	2016-03-21 22:25:08 UTC (rev 198502)
+++ trunk/Websites/perf.webkit.org/public/api/measurement-set.php	2016-03-21 22:27:34 UTC (rev 198503)
@@ -252,14 +252,14 @@
 
 function fetch_commits()
 {
-$query = $this->db->query('SELECT commit_build, commit_repository, commit_revision, commit_time
+$query = $this->db->query('SELECT commit_id, commit_build, commit_repository, commit_revision, commit_time
 FROM commits, build_commits, build_requests, analysis_test_groups
 WHERE commit_id = build_commit AND commit_build = request_build
 AND request_group = testgroup_id AND testgroup_task = $1', array($this->task_id));
 while ($row = $this->db->fetch_next_row($query)) {
 $commit_time = Database::to_js_time($row['commit_time']);
 array_push(array_ensure_item_has_array($this->build_to_commits, $row['commit_build']),
-array($row['commit_repository'], $row['commit_revision'], $commit_time));
+array($row['commit_id'], $row['commit_repository'], $row['commit_revision'], $commit_time));
 }
 }
 


Modified: trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php (198502 => 198503)

--- trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php	2016-03-21 22:25:08 UTC (rev 198502)
+++ trunk/Websites/perf.webkit.org/public/include/build-requests-fetcher.php	2016-03-21 22:27:34 UTC (rev 198503)
@@ -92,14 +92,12 @@
 
 $root_ids = array();
 foreach ($root_rows as $row) {
-$repository = $row['repository_id'];
+$repository_id = $row['commit_repository'];
 $revision = $row['commit_revision'];
 $commit_time = $row['commit_time'];
-$root_id = $root_set_id . '-' . $repository;
- 

[webkit-changes] [198502] trunk

[simon . fraser]

Title: [198502] trunk








Revision 198502
Author simon.fra...@apple.com
Date 2016-03-21 15:25:08 -0700 (Mon, 21 Mar 2016)


Log Message
[iOS WK2] Use larger tiles when possible to reduce per-tile painting overhead
https://bugs.webkit.org/show_bug.cgi?id=155734
rdar://problem/24968144

Reviewed by Tim Horton.

Source/WebCore:

The existing tile size logic is wired to adjustScrollbars, which doesn't fire
when scrolling is delegated. For iOS WK2, key off of a new unobscuredContentSizeChanged()
function that runs when the UI process tells told WebCore that the unobscured size
has changed. In addition, contentsResized() is used to update scrollability when
page changes size.

* page/FrameView.cpp:
(WebCore::FrameView::contentsResized):
(WebCore::FrameView::addedOrRemovedScrollbar):
(WebCore::FrameView::adjustTiledBackingScrollability): Handle both delegated and non-delegated
scrolling; the former looks at the visible size (based on the unobscuredVisibleContentRect),
the latter at the presence of scrollbars.
(WebCore::FrameView::unobscuredContentSizeChanged):
* page/FrameView.h:
* platform/ScrollView.h:
(WebCore::ScrollView::unobscuredContentSizeChanged):
* platform/graphics/ca/TileController.cpp:
(WebCore::TileController::adjustTileCoverageRect): Use kDefaultTileSize rather than the
tile size, to retain the old amount of overdraw.
(WebCore::TileController::tileSize): There was a bug in the not-scrollable case; we need
to scale.
* platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::setUnobscuredContentSize):

LayoutTests:

New results with larger page tiles in WK2.

* platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
* platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
* platform/ios-simulator-wk2/compositing/tiling/transform-origin-tiled-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/platform/graphics/ca/TileController.cpp
trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm


Added Paths

trunk/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt
trunk/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/transform-origin-tiled-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (198501 => 198502)

--- trunk/LayoutTests/ChangeLog	2016-03-21 22:22:16 UTC (rev 198501)
+++ trunk/LayoutTests/ChangeLog	2016-03-21 22:25:08 UTC (rev 198502)
@@ -1,3 +1,17 @@
+2016-03-21  Simon Fraser  
+
+[iOS WK2] Use larger tiles when possible to reduce per-tile painting overhead
+https://bugs.webkit.org/show_bug.cgi?id=155734
+rdar://problem/24968144
+
+Reviewed by Tim Horton.
+
+New results with larger page tiles in WK2.
+
+* platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
+* platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
+* platform/ios-simulator-wk2/compositing/tiling/transform-origin-tiled-expected.txt: Added.
+
 2016-03-21  Hyungwook Lee  
 
 [Win] Connect layoutTestController.findString() to support testing


Added: trunk/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt (0 => 198502)

--- trunk/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt	2016-03-21 22:25:08 UTC (rev 198502)
@@ -0,0 +1,61 @@
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (visible rect 0.00, 0.00 800.00 x 600.00)
+  (coverage rect 0.00, 0.00 800.00 x 600.00)
+  (intersects coverage rect 1)
+  (contentsScale 2.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (contentsOpaque 1)
+  (visible rect 0.00, 0.00 800.00 x 600.00)
+  (coverage rect 0.00, 0.00 800.00 x 600.00)
+  (intersects coverage rect 1)
+  (contentsScale 2.00)
+  (tile cache coverage 0, 0 800 x 600)
+  (tile size 800 x 600)
+  (top left tile 0, 0 tiles grid 1 x 1)
+  (children 1
+(GraphicsLayer
+  (position 58.00 50.00)
+  (bounds 502.00 302.00)
+  (visible rect 0.00, 0.00 502.00 x 302.00)
+  (coverage rect -58.00, -50.00 800.00 x 600.00)
+  (intersects coverage rect 1)
+  (contentsScale 2.00)
+  (children 1
+(GraphicsLayer
+  (position 1.00 1.00)
+  (bounds 500.00 300.00)
+  (childrenTransform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] 

[webkit-changes] [198501] trunk

[bfulgham]

Title: [198501] trunk








Revision 198501
Author bfulg...@apple.com
Date 2016-03-21 15:22:16 -0700 (Mon, 21 Mar 2016)


Log Message

Source/WebKit/win:
[Win] Connect layoutTestController.findString() to support testing 
https://bugs.webkit.org/show_bug.cgi?id=50234

Patch by Hyungwook Lee  on 2016-03-21
Reviewed by Alex Christensen.

Implement WebView::findString to support testing efforts.

* Interfaces/IWebViewPrivate.idl: Add API declaration.
* WebView.cpp:
* WebView.h:

Tools:
[Win] Connect layoutTestController.findString() to support testing
https://bugs.webkit.org/show_bug.cgi?id=50234

Patch by Hyungwook Lee  on 2016-03-21
Reviewed by Alex Christensen.

Implement TestRunner::findString().

* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::findString):

LayoutTests:
[Win] Connect layoutTestController.findString() to support testing
https://bugs.webkit.org/show_bug.cgi?id=50234

Patch by Hyungwook Lee  on 2016-03-21
Reviewed by Alex Christensen.

* platform/win/TestExpectations: Unskip test.
* platform/win/editing/text-iterator/findString-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/IWebViewPrivate.idl
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit/win/WebView.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp


Added Paths

trunk/LayoutTests/platform/win/editing/text-iterator/
trunk/LayoutTests/platform/win/editing/text-iterator/findString-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (198500 => 198501)

--- trunk/LayoutTests/ChangeLog	2016-03-21 22:07:33 UTC (rev 198500)
+++ trunk/LayoutTests/ChangeLog	2016-03-21 22:22:16 UTC (rev 198501)
@@ -1,3 +1,13 @@
+2016-03-21  Hyungwook Lee  
+
+[Win] Connect layoutTestController.findString() to support testing
+https://bugs.webkit.org/show_bug.cgi?id=50234
+
+Reviewed by Alex Christensen.
+
+* platform/win/TestExpectations: Unskip test.
+* platform/win/editing/text-iterator/findString-expected.txt: Added.
+
 2016-03-21  Zalan Bujtas  
 
 Web Inspector search icon does not fit when zoomed in.


Modified: trunk/LayoutTests/platform/win/TestExpectations (198500 => 198501)

--- trunk/LayoutTests/platform/win/TestExpectations	2016-03-21 22:07:33 UTC (rev 198500)
+++ trunk/LayoutTests/platform/win/TestExpectations	2016-03-21 22:22:16 UTC (rev 198501)
@@ -1255,8 +1255,7 @@
 ## Text Iterator
 # Plain text controller currently in Mac DumpRenderTree only.
 editing/text-iterator [ Skip ]
-# TODO Missing testRunner.findString()
-webkit.org/b/50234 editing/text-iterator/findString.html [ Skip ]
+editing/text-iterator/findString.html [ Pass ]
 
 ## TODO Spellchecker is not implemented. Skip these test.
 webkit.org/b/66620 editing/spelling/spelling-insert-html.html [ Skip ]


Added: trunk/LayoutTests/platform/win/editing/text-iterator/findString-expected.txt (0 => 198501)

--- trunk/LayoutTests/platform/win/editing/text-iterator/findString-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/editing/text-iterator/findString-expected.txt	2016-03-21 22:22:16 UTC (rev 198501)
@@ -0,0 +1,176 @@
+Searching for ‘o’ in ‘Lorem ipsum dolor sit amet’ with options []:
+PASS: Got a match at 1,2 as expected.
+PASS: Got a match at 13,14 as expected.
+PASS: Got a match at 15,16 as expected.
+PASS: Got no match as expected.
+
+Searching for ‘o’ in ‘Lorem ipsum dolor sit amet’ with options [WrapAround]:
+PASS: Got a match at 1,2 as expected.
+PASS: Got a match at 13,14 as expected.
+PASS: Got a match at 15,16 as expected.
+PASS: Got a match at 1,2 as expected.
+
+Searching for ‘o’ in ‘Lorem ipsum dolor sit amet’ with options [Backwards]:
+PASS: Got a match at 15,16 as expected.
+PASS: Got a match at 13,14 as expected.
+PASS: Got a match at 1,2 as expected.
+PASS: Got no match as expected.
+
+Searching for ‘o’ in ‘Lorem ipsum dolor sit amet’ with options [Backwards, WrapAround]:
+PASS: Got a match at 15,16 as expected.
+PASS: Got a match at 13,14 as expected.
+PASS: Got a match at 1,2 as expected.
+PASS: Got a match at 15,16 as expected.
+
+Searching for ‘O’ in ‘Lorem ipsum dolor sit amet’ with options []:
+PASS: Got no match as expected.
+
+Searching for ‘O’ in ‘Lorem ipsum dolor sit amet’ with options [CaseInsensitive]:
+PASS: Got a match at 1,2 as expected.
+PASS: Got a match at 13,14 as expected.
+PASS: Got a match at 15,16 as expected.
+
+Searching for ‘mount’ in ‘insurmountable mountain’ with options []:
+PASS: Got a match at 5,10 as expected.
+PASS: Got a match at 15,20 as expected.
+PASS: Got no match as expected.
+
+Searching for ‘mount’ in ‘insurmountable mountain’ with options [AtWordStarts]:
+PASS: Got a match at 15,20 as expected.
+PASS: Got no match as expected.
+
+Searching 

[webkit-changes] [198500] trunk/Source/WebCore

[cdumez]

Title: [198500] trunk/Source/WebCore








Revision 198500
Author cdu...@apple.com
Date 2016-03-21 15:07:33 -0700 (Mon, 21 Mar 2016)


Log Message
Unreviewed, rolling out r197552.

May have caused a ~2% PLT regression on iOS

Reverted changeset:

"Drop DocumentSharedObjectPool immediately when going into
PageCache."
https://bugs.webkit.org/show_bug.cgi?id=154986
http://trac.webkit.org/changeset/197552

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (198499 => 198500)

--- trunk/Source/WebCore/ChangeLog	2016-03-21 20:54:27 UTC (rev 198499)
+++ trunk/Source/WebCore/ChangeLog	2016-03-21 22:07:33 UTC (rev 198500)
@@ -1,3 +1,16 @@
+2016-03-21  Chris Dumez  
+
+Unreviewed, rolling out r197552.
+
+May have caused a ~2% PLT regression on iOS
+
+Reverted changeset:
+
+"Drop DocumentSharedObjectPool immediately when going into
+PageCache."
+https://bugs.webkit.org/show_bug.cgi?id=154986
+http://trac.webkit.org/changeset/197552
+
 2016-03-21  Simon Fraser  
 
 Very flashy scrolling on http://quellish.tumblr.com page


Modified: trunk/Source/WebCore/dom/Document.cpp (198499 => 198500)

--- trunk/Source/WebCore/dom/Document.cpp	2016-03-21 20:54:27 UTC (rev 198499)
+++ trunk/Source/WebCore/dom/Document.cpp	2016-03-21 22:07:33 UTC (rev 198500)
@@ -533,7 +533,7 @@
 , m_scheduledTasksAreSuspended(false)
 , m_visualUpdatesAllowed(true)
 , m_visualUpdatesSuppressionTimer(*this, ::visualUpdatesSuppressionTimerFired)
-, m_sharedObjectPoolClearTimer(*this, ::clearSharedObjectPool)
+, m_sharedObjectPoolClearTimer(*this, ::sharedObjectPoolClearTimerFired)
 #ifndef NDEBUG
 , m_didDispatchViewportPropertiesChanged(false)
 #endif
@@ -4645,7 +4645,6 @@
 
 clearStyleResolver();
 clearSelectorQueryCache();
-clearSharedObjectPool();
 } else {
 if (childNeedsStyleRecalc())
 scheduleStyleRecalc();
@@ -5092,10 +5091,9 @@
 m_cachedResourceLoader->clearPreloads();
 }
 
-void Document::clearSharedObjectPool()
+void Document::sharedObjectPoolClearTimerFired()
 {
 m_sharedObjectPool = nullptr;
-m_sharedObjectPoolClearTimer.stop();
 }
 
 #if ENABLE(TELEPHONE_NUMBER_DETECTION)


Modified: trunk/Source/WebCore/dom/Document.h (198499 => 198500)

--- trunk/Source/WebCore/dom/Document.h	2016-03-21 20:54:27 UTC (rev 198499)
+++ trunk/Source/WebCore/dom/Document.h	2016-03-21 22:07:33 UTC (rev 198500)
@@ -1723,7 +1723,7 @@
 
 RefPtr m_namedFlows;
 
-void clearSharedObjectPool();
+void sharedObjectPoolClearTimerFired();
 Timer m_sharedObjectPoolClearTimer;
 
 std::unique_ptr m_sharedObjectPool;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198499] trunk/Websites/perf.webkit.org

[rniwa]

Title: [198499] trunk/Websites/perf.webkit.org








Revision 198499
Author rn...@webkit.org
Date 2016-03-21 13:54:27 -0700 (Mon, 21 Mar 2016)


Log Message
v3 UI sometimes don't update the list of revisions on the commit log viewer
https://bugs.webkit.org/show_bug.cgi?id=155729

Rubber-stamped by Chris Dumez.

Fixed multiple bugs that were affecting the list of blame range and commit logs for the range weren't
updated in some cases on v3 UI. Also, the commit log viewer state is now a part of the URL state so
opening and closing the commit log viewer will persist across page loads.

Also fixed a regression from r198479 that Test object can't be created for a top level test.

* public/v3/components/chart-pane-base.js:
(ChartPaneBase.prototype.configure):
(ChartPaneBase.prototype._mainSelectionDidChange): Fixed the bug that the list of blame range nor the
commit log viewer don't get updated when the selected range changes.
(ChartPaneBase.prototype._indicatorDidChange):
(ChartPaneBase.prototype._didFetchData):
(ChartPaneBase.prototype._updateStatus): Extracted from _indicatorDidChange and _didFetchData.
(ChartPaneBase.prototype._requestOpeningCommitViewer): Renamed from _openCommitViewer.

* public/v3/components/chart-status-view.js:
(ChartStatusView.prototype.updateStatusIfNeeded): Fixed the bug that the blame range doesn't get set
on the initial page load when the selection range is set but the chart data hadn't been fetched yet.

* public/v3/components/commit-log-viewer.js:
(CommitLogViewer.prototype.view): Fixed the bug that we don't clear out the old list of commits while
loading the next set of commits to show as it looked as if the list was never updated.
(CommitLogViewer.prototype.render): Fixed the bug that the view always show the last repository name
even if there were nothing being fetched or commits to show.

* public/v3/components/pane-selector.js:
(PaneSelector.prototype.focus): Removed superfluous call to console.log.

* public/v3/models/data-model.js:
(DataModelObject.listForStaticMap): Generalized the code for all to fix the bug in Test.
(DataModelObject.all):

* public/v3/models/test.js:
(Test): Fixed the bug that this code was relying on the static map to be an array.
(Test.topLevelTests): Use newly added listForStaticMap to convert the dictionary to an array.

* public/v3/pages/chart-pane-status-view.js:
(ChartPaneStatusView): Always initialize _usedRevisionRange as a triple to simplify code elsewhere.
(ChartPaneStatusView.prototype.render): Invoke _revisionCallback when user clicks on a repository
expansion mark (>>). Also fixed click handler from the row since this made selecting revision range
on the view cumbersome. Now user has to explicitly click on the expansion mark (>>).
(ChartPaneStatusView.prototype._setRevisionRange): Now takes shouldNotify, from, and to as arguments
as this function must not invoke_revisionCallback inside _updateRevisionListForNewCurrentRepository.
(ChartPaneStatusView.prototype.moveRepositoryWithNotification): Use newly added setCurrentRepository
instead of manually invoking setCurrentRepository and updateRevisionListWithNotification.
(ChartPaneStatusView.prototype.setCurrentRepository): Fixed the bug that we weren't updating the
blame list here.
(ChartPaneStatusView.prototype.updateRevisionList): Renamed from updateRevisionListWithNotification
since we no longer call _revisionCallback. In general, callbacks are only meant to communicate user
initiated actions, and not program induced updates like this API so this was a bad pattern anyway.
ChartPane now explicitly updates the commit log viewer instead of relying on this function calling
_requestOpeningCommitViewer implicitly.
(ChartPaneStatusView.prototype._updateRevisionListForNewCurrentRepository): Extracted from
updateRevisionListWithNotification so that setCurrentRepository can also call this function.

* public/v3/pages/chart-pane.js:
(ChartPane.prototype._requestOpeningCommitViewer): Overrides ChartPaneBase's method. Open the same
repository in other panes via ChartsPage.setOpenRepository.
(ChartPane.prototype.setOpenRepository): This method is called when the user selected a repository in
another pane. Open the same repository in this pane if it wasn't already open.

* public/v3/pages/charts-page.js:
(ChartsPage): Added this._currentRepositoryId.
(ChartsPage.prototype.serializeState): Serialize _currentRepositoryId.
(ChartsPage.prototype.updateFromSerializedState): Set the commit log viewer's 
(ChartsPage.prototype.setOpenRepository): Added.

* tests/api-measurement-set.js: Fixed a test after r198479.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js
trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js
trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js
trunk/Websites/perf.webkit.org/public/v3/components/pane-selector.js

[webkit-changes] [198498] trunk/Source/WebCore

[simon . fraser]

Title: [198498] trunk/Source/WebCore








Revision 198498
Author simon.fra...@apple.com
Date 2016-03-21 13:23:23 -0700 (Mon, 21 Mar 2016)


Log Message
Very flashy scrolling on http://quellish.tumblr.com page
https://bugs.webkit.org/show_bug.cgi?id=155728
rdar://problem/22299375

Reviewed by Zalan Bujtas.

http://quellish.tumblr.com/post/126712999812/how-on-earth-the-facebook-ios-application-is-so
has many elements that are nested inside elements with non-equal corner radius clipping.
This requires building bezier paths for the rounded-rect clip which is expensive.

For many rows of the table, we can avoid the rounded-rect clipping because the intersection
of the paintDirtyRect and the clip is actually rectangular.

* platform/graphics/FloatRoundedRect.cpp:
(WebCore::FloatRoundedRect::intersectionIsRectangular):
* platform/graphics/FloatRoundedRect.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FloatRoundedRect.cpp
trunk/Source/WebCore/platform/graphics/FloatRoundedRect.h
trunk/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (198497 => 198498)

--- trunk/Source/WebCore/ChangeLog	2016-03-21 20:13:25 UTC (rev 198497)
+++ trunk/Source/WebCore/ChangeLog	2016-03-21 20:23:23 UTC (rev 198498)
@@ -1,3 +1,24 @@
+2016-03-21  Simon Fraser  
+
+Very flashy scrolling on http://quellish.tumblr.com page
+https://bugs.webkit.org/show_bug.cgi?id=155728
+rdar://problem/22299375
+
+Reviewed by Zalan Bujtas.
+
+http://quellish.tumblr.com/post/126712999812/how-on-earth-the-facebook-ios-application-is-so
+has many elements that are nested inside elements with non-equal corner radius clipping.
+This requires building bezier paths for the rounded-rect clip which is expensive.
+
+For many rows of the table, we can avoid the rounded-rect clipping because the intersection
+of the paintDirtyRect and the clip is actually rectangular.
+
+* platform/graphics/FloatRoundedRect.cpp:
+(WebCore::FloatRoundedRect::intersectionIsRectangular):
+* platform/graphics/FloatRoundedRect.h:
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::clipToRect):
+
 2016-03-21  Zalan Bujtas  
 
 Web Inspector search icon does not fit when zoomed in.


Modified: trunk/Source/WebCore/platform/graphics/FloatRoundedRect.cpp (198497 => 198498)

--- trunk/Source/WebCore/platform/graphics/FloatRoundedRect.cpp	2016-03-21 20:13:25 UTC (rev 198497)
+++ trunk/Source/WebCore/platform/graphics/FloatRoundedRect.cpp	2016-03-21 20:23:23 UTC (rev 198498)
@@ -197,6 +197,12 @@
 m_radii.scale(widthRatio < heightRatio ? widthRatio : heightRatio);
 }
 
+// This is conservative; it does not test intrusion into the corner rects.
+bool FloatRoundedRect::intersectionIsRectangular(const FloatRect& rect) const
+{
+return !(rect.intersects(topLeftCorner()) || rect.intersects(topRightCorner()) || rect.intersects(bottomLeftCorner()) || rect.intersects(bottomRightCorner()));
+}
+
 TextStream& operator<<(TextStream& ts, const FloatRoundedRect& roundedRect)
 {
 ts << roundedRect.rect().x() << " " << roundedRect.rect().y() << " " << roundedRect.rect().width() << " " << roundedRect.rect().height() << "\n";


Modified: trunk/Source/WebCore/platform/graphics/FloatRoundedRect.h (198497 => 198498)

--- trunk/Source/WebCore/platform/graphics/FloatRoundedRect.h	2016-03-21 20:13:25 UTC (rev 198497)
+++ trunk/Source/WebCore/platform/graphics/FloatRoundedRect.h	2016-03-21 20:23:23 UTC (rev 198498)
@@ -131,6 +131,8 @@
 bool isRenderable() const;
 bool xInterceptsAtY(float y, float& minXIntercept, float& maxXIntercept) const;
 
+bool intersectionIsRectangular(const FloatRect&) const;
+
 private:
 FloatRect m_rect;
 Radii m_radii;


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (198497 => 198498)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2016-03-21 20:13:25 UTC (rev 198497)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2016-03-21 20:23:23 UTC (rev 198498)
@@ -3831,7 +3831,11 @@
 if (layer->renderer().hasOverflowClip() && layer->renderer().style().hasBorderRadius() && inContainingBlockChain(this, layer)) {
 LayoutRect adjustedClipRect = LayoutRect(toLayoutPoint(layer->offsetFromAncestor(paintingInfo.rootLayer, AdjustForColumns)), layer->size());
 adjustedClipRect.move(paintingInfo.subpixelAccumulation);
-context.clipRoundedRect(layer->renderer().style().getRoundedInnerBorderFor(adjustedClipRect).pixelSnappedRoundedRectForPainting(deviceScaleFactor));
+FloatRoundedRect roundedRect = layer->renderer().style().getRoundedInnerBorderFor(adjustedClipRect).pixelSnappedRoundedRectForPainting(deviceScaleFactor);
+if 

[webkit-changes] [198497] trunk

[zalan]

Title: [198497] trunk








Revision 198497
Author za...@apple.com
Date 2016-03-21 13:13:25 -0700 (Mon, 21 Mar 2016)


Log Message
Web Inspector search icon does not fit when zoomed in.
https://bugs.webkit.org/show_bug.cgi?id=155708

Reviewed by Simon Fraser.

Adjusts the paint rect for the magnifier icon so that it fits even when zoomed in.

Source/WebCore:

Covered by existing tests.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::resultsButtonSizes):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

LayoutTests:

* fast/forms/search/search-padding-cancel-results-buttons-expected.txt:
* platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt:
* platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/placeholder-position-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/mac/fast/forms/search-rtl-expected.txt:
* platform/mac/fast/forms/search-styled-expected.txt:
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
* platform/mac/fast/forms/searchfield-heights-expected.txt:
* platform/mac/fast/repaint/search-field-cancel-expected.txt:
* platform/mac/fast/replaced/width100percent-searchfield-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/search/search-padding-cancel-results-buttons-expected.txt
trunk/LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt
trunk/LayoutTests/platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt
trunk/LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/search/search-size-with-decorations-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/search-display-none-cancel-button-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/search-rtl-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.txt
trunk/LayoutTests/platform/mac/fast/repaint/search-field-cancel-expected.txt
trunk/LayoutTests/platform/mac/fast/replaced/width100percent-searchfield-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderThemeMac.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (198496 => 198497)

--- trunk/LayoutTests/ChangeLog	2016-03-21 19:28:53 UTC (rev 198496)
+++ trunk/LayoutTests/ChangeLog	2016-03-21 20:13:25 UTC (rev 198497)
@@ -1,3 +1,31 @@
+2016-03-21  Zalan Bujtas  
+
+Web Inspector search icon does not fit when zoomed in.
+https://bugs.webkit.org/show_bug.cgi?id=155708
+
+Reviewed by Simon Fraser.
+
+Adjusts the paint rect for the magnifier icon so that it fits even when zoomed in.
+
+* fast/forms/search/search-padding-cancel-results-buttons-expected.txt:
+* platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt:
+* platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
+* platform/mac/fast/css/text-overflow-input-expected.txt:
+* platform/mac/fast/forms/box-shadow-override-expected.txt:
+* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
+* platform/mac/fast/forms/input-appearance-height-expected.txt:
+* platform/mac/fast/forms/placeholder-position-expected.txt:
+* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
+* platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
+* platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
+* platform/mac/fast/forms/search-rtl-expected.txt:
+* platform/mac/fast/forms/search-styled-expected.txt:
+* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
+* platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
+* 

[webkit-changes] [198496] trunk/Source/WebKit2

[enrica]

Title: [198496] trunk/Source/WebKit2








Revision 198496
Author enr...@apple.com
Date 2016-03-21 12:28:53 -0700 (Mon, 21 Mar 2016)


Log Message
Enable preview of images as attachments.
https://bugs.webkit.org/show_bug.cgi?id=155674
rdar://problem/25242656

Reviewed by Darin Adler.

If the client cannot handle image preview, but can handle attachments,
let them handle images as attachments.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (198495 => 198496)

--- trunk/Source/WebKit2/ChangeLog	2016-03-21 19:22:42 UTC (rev 198495)
+++ trunk/Source/WebKit2/ChangeLog	2016-03-21 19:28:53 UTC (rev 198496)
@@ -1,3 +1,17 @@
+2016-03-18  Enrica Casucci  
+
+Enable preview of images as attachments.
+https://bugs.webkit.org/show_bug.cgi?id=155674
+rdar://problem/25242656
+
+Reviewed by Darin Adler.
+
+If the client cannot handle image preview, but can handle attachments,
+let them handle images as attachments.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
+
 2016-03-20  Dan Bernstein  
 
 [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR


Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (198495 => 198496)

--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2016-03-21 19:22:42 UTC (rev 198495)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm	2016-03-21 19:28:53 UTC (rev 198496)
@@ -3827,7 +3827,7 @@
 BOOL canShowLinkPreview = _positionInformation.isLink || canShowImagePreview;
 BOOL useImageURLForLink = NO;
 BOOL supportsAttachmentPreview = [uiDelegate respondsToSelector:@selector(_attachmentListForWebView:)] && [uiDelegate respondsToSelector:@selector(_webView:indexIntoAttachmentListForElement:)];
-BOOL canShowAttachmentPreview = _positionInformation.isAttachment && supportsAttachmentPreview;
+BOOL canShowAttachmentPreview = (_positionInformation.isAttachment || _positionInformation.isImage) && supportsAttachmentPreview;
 
 if (canShowImagePreview && _positionInformation.isAnimatedImage) {
 canShowImagePreview = NO;
@@ -3886,8 +3886,11 @@
 enum { WKUIPreviewItemTypeAttachment = 5 };
 *type = static_cast(WKUIPreviewItemTypeAttachment);
 const auto& element = [[_WKActivatedElementInfo alloc] _initWithType:_WKActivatedElementTypeAttachment URL:[NSURL _web_URLWithWTFString:_positionInformation.url] location:_positionInformation.point title:_positionInformation.title ID:_positionInformation.idAttribute rect:_positionInformation.bounds image:nil];
-dataForPreview[@"UIPreviewDataAttachmentList"] = [uiDelegate _attachmentListForWebView:_webView];
-dataForPreview[@"UIPreviewDataAttachmentIndex"] = [NSNumber numberWithUnsignedInteger:[uiDelegate _webView:_webView indexIntoAttachmentListForElement:element]];
+NSUInteger index = [uiDelegate _webView:_webView indexIntoAttachmentListForElement:element];
+if (index != NSNotFound) {
+dataForPreview[@"UIPreviewDataAttachmentList"] = [uiDelegate _attachmentListForWebView:_webView];
+dataForPreview[@"UIPreviewDataAttachmentIndex"] = [NSNumber numberWithUnsignedInteger:index];
+}
 }
 
 return dataForPreview;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198495] trunk/Websites/perf.webkit.org

[rniwa]

Title: [198495] trunk/Websites/perf.webkit.org








Revision 198495
Author rn...@webkit.org
Date 2016-03-21 12:22:42 -0700 (Mon, 21 Mar 2016)


Log Message
V3 Perf Dashboard should automatically select initial range when creating a new task
https://bugs.webkit.org/show_bug.cgi?id=155677

Reviewed by Joseph Pecoraro.

Select the entire range of points for which the analysis task is created by default so that creating
a test group to confirm the regression / progression is easy.

* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage): Added a boolean flag which indicates the user had modified main chart's selection.
* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype.render): Set the main chart's selection to the entire range of points in
the analysis task if the user had never modified selection.
(AnalysisTaskPage.prototype._chartSelectionDidChange): This callback is invoked only when the user had
modified the selection so set _selectionWasModifiedByUser true here unconditionally.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (198494 => 198495)

--- trunk/Websites/perf.webkit.org/ChangeLog	2016-03-21 18:09:12 UTC (rev 198494)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2016-03-21 19:22:42 UTC (rev 198495)
@@ -1,3 +1,21 @@
+2016-03-21  Ryosuke Niwa  
+
+V3 Perf Dashboard should automatically select initial range when creating a new task
+https://bugs.webkit.org/show_bug.cgi?id=155677
+
+Reviewed by Joseph Pecoraro.
+
+Select the entire range of points for which the analysis task is created by default so that creating
+a test group to confirm the regression / progression is easy.
+
+* public/v3/pages/analysis-task-page.js:
+(AnalysisTaskPage): Added a boolean flag which indicates the user had modified main chart's selection.
+* public/v3/pages/analysis-task-page.js:
+(AnalysisTaskPage.prototype.render): Set the main chart's selection to the entire range of points in
+the analysis task if the user had never modified selection.
+(AnalysisTaskPage.prototype._chartSelectionDidChange): This callback is invoked only when the user had
+modified the selection so set _selectionWasModifiedByUser true here unconditionally.
+
 2016-03-19  Ryosuke Niwa  
 
 Associated commits don't immediately show up on an analysis task page


Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js (198494 => 198495)

--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js	2016-03-21 18:09:12 UTC (rev 198494)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js	2016-03-21 19:22:42 UTC (rev 198495)
@@ -46,6 +46,7 @@
 this._currentTestGroup = null;
 this._filteredTestGroups = null;
 this._showHiddenTestGroups = false;
+this._selectionWasModifiedByUser = false;
 
 this._chartPane = this.content().querySelector('analysis-task-chart-pane').component();
 this._chartPane.setPage(this);
@@ -291,6 +292,9 @@
 this._renderTestGroupList();
 this._renderTestGroupDetails();
 
+if (!this._renderedCurrentTestGroup && !this._selectionWasModifiedByUser && this._startPoint && this._endPoint)
+this._chartPane.setMainSelection([this._startPoint.time, this._endPoint.time]);
+
 var points = this._chartPane.selectedPoints();
 this._newTestGroupFormForChart.setRootSetMap(points && points.length >= 2 ?
 {'A': points[0].rootSet(), 'B': points[points.length - 1].rootSet()} : null);
@@ -521,6 +525,7 @@
 
 _chartSelectionDidChange()
 {
+this._selectionWasModifiedByUser = true;
 this.render();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198494] trunk/PerformanceTests

[jonlee]

Title: [198494] trunk/PerformanceTests








Revision 198494
Author jon...@apple.com
Date 2016-03-21 11:09:12 -0700 (Mon, 21 Mar 2016)


Log Message
Add a link to show debug data
https://bugs.webkit.org/show_bug.cgi?id=155724

Reviewed by Simon Fraser.

* Animometer/developer.html: Attach the onclick handler to the score.
* Animometer/index.html: Ditto.

Modified Paths

trunk/PerformanceTests/Animometer/developer.html
trunk/PerformanceTests/Animometer/index.html
trunk/PerformanceTests/ChangeLog




Diff

Modified: trunk/PerformanceTests/Animometer/developer.html (198493 => 198494)

--- trunk/PerformanceTests/Animometer/developer.html	2016-03-21 17:54:19 UTC (rev 198493)
+++ trunk/PerformanceTests/Animometer/developer.html	2016-03-21 18:09:12 UTC (rev 198494)
@@ -85,7 +85,7 @@
 
 
 Animometer score
-
+
 
 
 


Modified: trunk/PerformanceTests/Animometer/index.html (198493 => 198494)

--- trunk/PerformanceTests/Animometer/index.html	2016-03-21 17:54:19 UTC (rev 198493)
+++ trunk/PerformanceTests/Animometer/index.html	2016-03-21 18:09:12 UTC (rev 198494)
@@ -26,7 +26,7 @@
 
 
 Animometer score
-
+
 
 
 


Modified: trunk/PerformanceTests/ChangeLog (198493 => 198494)

--- trunk/PerformanceTests/ChangeLog	2016-03-21 17:54:19 UTC (rev 198493)
+++ trunk/PerformanceTests/ChangeLog	2016-03-21 18:09:12 UTC (rev 198494)
@@ -1,3 +1,13 @@
+2016-03-20  Jon Lee  
+
+Add a link to show debug data
+https://bugs.webkit.org/show_bug.cgi?id=155724
+
+Reviewed by Simon Fraser.
+
+* Animometer/developer.html: Attach the onclick handler to the score.
+* Animometer/index.html: Ditto.
+
 2016-03-18  Dean Jackson  
 
 Add a basic WebGL test to Animometer






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198491] trunk/LayoutTests

[ryanhaddad]

Title: [198491] trunk/LayoutTests








Revision 198491
Author ryanhad...@apple.com
Date 2016-03-21 10:47:14 -0700 (Mon, 21 Mar 2016)


Log Message
Moving the -expected.txt file for accessibility/radio-button-group-members.html

Unreviewed test gardening.

* accessibility/radio-button-group-members-expected.txt: Renamed from LayoutTests/accessibility/mac/radio-button-group-members-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/accessibility/radio-button-group-members-expected.txt


Removed Paths

trunk/LayoutTests/accessibility/mac/radio-button-group-members-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (198490 => 198491)

--- trunk/LayoutTests/ChangeLog	2016-03-21 17:17:30 UTC (rev 198490)
+++ trunk/LayoutTests/ChangeLog	2016-03-21 17:47:14 UTC (rev 198491)
@@ -1,5 +1,13 @@
 2016-03-21  Ryan Haddad  
 
+Moving the -expected.txt file for accessibility/radio-button-group-members.html
+
+Unreviewed test gardening.
+
+* accessibility/radio-button-group-members-expected.txt: Renamed from LayoutTests/accessibility/mac/radio-button-group-members-expected.txt.
+
+2016-03-21  Ryan Haddad  
+
 Marking two inspector tests as flaky timeouts on Mac.
 https://bugs.webkit.org/show_bug.cgi?id=155607
 


Deleted: trunk/LayoutTests/accessibility/mac/radio-button-group-members-expected.txt (198490 => 198491)

--- trunk/LayoutTests/accessibility/mac/radio-button-group-members-expected.txt	2016-03-21 17:17:30 UTC (rev 198490)
+++ trunk/LayoutTests/accessibility/mac/radio-button-group-members-expected.txt	2016-03-21 17:47:14 UTC (rev 198491)
@@ -1,50 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-This tests that linked UI elements withing a radio group work
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Radio buttons within the same named group should be able to access their siblings
-PASS test1.linkedUIElementAtIndex(0).isEqual(test1) is true
-PASS test1.linkedUIElementAtIndex(1).isEqual(accessibilityController.accessibleElementById('test1_No')) is true
-PASS test1.linkedUIElementAtIndex(2).isEqual(accessibilityController.accessibleElementById('test1_Maybe')) is true
-
-
-Radio buttons that are not in a form, but in the same named group should be able to access their siblings
-PASS test2.linkedUIElementAtIndex(0).isEqual(test2) is true
-PASS test2.linkedUIElementAtIndex(1).isEqual(accessibilityController.accessibleElementById('test2_No')) is true
-
-
-Radio buttons labeled by  should be able to access their siblings
-PASS test3.linkedUIElementAtIndex(0).isEqual(test3) is true
-PASS test3.linkedUIElementAtIndex(1).isEqual(accessibilityController.accessibleElementById('test3_No')) is true
-
-
-Radio buttons not in a groups should not have siblings (the first linked element is itself)
-PASS test4.linkedUIElementAtIndex(0).isEqual(test4) is true
-PASS !test4.linkedUIElementAtIndex(1) || !test4.linkedUIElementAtIndex(1).isValid is true
-
-
-Radio buttons that just have aria roles should work.
-PASS ariaRadio1.linkedUIElementAtIndex(0).isEqual(ariaRadio1) is true
-PASS ariaRadio1.linkedUIElementAtIndex(1).isEqual(ariaRadio2) is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Copied: trunk/LayoutTests/accessibility/radio-button-group-members-expected.txt (from rev 198490, trunk/LayoutTests/accessibility/mac/radio-button-group-members-expected.txt) (0 => 198491)

--- trunk/LayoutTests/accessibility/radio-button-group-members-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/radio-button-group-members-expected.txt	2016-03-21 17:47:14 UTC (rev 198491)
@@ -0,0 +1,50 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+This tests that linked UI elements withing a radio group work
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Radio buttons within the same named group should be able to access their siblings
+PASS test1.linkedUIElementAtIndex(0).isEqual(test1) is true
+PASS test1.linkedUIElementAtIndex(1).isEqual(accessibilityController.accessibleElementById('test1_No')) is true
+PASS test1.linkedUIElementAtIndex(2).isEqual(accessibilityController.accessibleElementById('test1_Maybe')) is true
+
+
+Radio buttons that are not in a form, but in the same named group should be able to access their siblings
+PASS test2.linkedUIElementAtIndex(0).isEqual(test2) is true
+PASS test2.linkedUIElementAtIndex(1).isEqual(accessibilityController.accessibleElementById('test2_No')) is true
+
+
+Radio buttons labeled by  should be able to access their siblings
+PASS test3.linkedUIElementAtIndex(0).isEqual(test3) is true
+PASS test3.linkedUIElementAtIndex(1).isEqual(accessibilityController.accessibleElementById('test3_No')) is true
+
+
+Radio buttons not in a groups should not have siblings (the first linked element is itself)
+PASS test4.linkedUIElementAtIndex(0).isEqual(test4) is true
+PASS 

[webkit-changes] [198490] trunk/Source/JavaScriptCore

[commit-queue]

Title: [198490] trunk/Source/_javascript_Core








Revision 198490
Author commit-qu...@webkit.org
Date 2016-03-21 10:17:30 -0700 (Mon, 21 Mar 2016)


Log Message
Fixed compilation with GCC 4.8.
https://bugs.webkit.org/show_bug.cgi?id=155698

Patch by Konstantin Tokarev  on 2016-03-21
Reviewed by Alexey Proskuryakov.

GCC 4.8 does not allow aggregate initialization for type with deleted
constructor, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52707.

* dfg/DFGCSEPhase.cpp: Added ctor for ImpureDataSlot.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (198489 => 198490)

--- trunk/Source/_javascript_Core/ChangeLog	2016-03-21 17:10:39 UTC (rev 198489)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-03-21 17:17:30 UTC (rev 198490)
@@ -1,3 +1,15 @@
+2016-03-21  Konstantin Tokarev  
+
+Fixed compilation with GCC 4.8.
+https://bugs.webkit.org/show_bug.cgi?id=155698
+
+Reviewed by Alexey Proskuryakov.
+
+GCC 4.8 does not allow aggregate initialization for type with deleted
+constructor, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52707.
+
+* dfg/DFGCSEPhase.cpp: Added ctor for ImpureDataSlot.
+
 2016-03-21  Joonghun Park  
 
 [JSC] Add ArrayBuffer::tryCreate and change the callsites where it is needed


Modified: trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp (198489 => 198490)

--- trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp	2016-03-21 17:10:39 UTC (rev 198489)
+++ trunk/Source/_javascript_Core/dfg/DFGCSEPhase.cpp	2016-03-21 17:17:30 UTC (rev 198490)
@@ -55,6 +55,10 @@
 WTF_MAKE_NONCOPYABLE(ImpureDataSlot);
 WTF_MAKE_FAST_ALLOCATED;
 public:
+ImpureDataSlot(HeapLocation key, LazyNode value, unsigned hash)
+: key(key), value(value), hash(hash)
+{ }
+
 HeapLocation key;
 LazyNode value;
 unsigned hash;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198489] trunk/LayoutTests

[ryanhaddad]

Title: [198489] trunk/LayoutTests








Revision 198489
Author ryanhad...@apple.com
Date 2016-03-21 10:10:39 -0700 (Mon, 21 Mar 2016)


Log Message
Marking two inspector tests as flaky timeouts on Mac.
https://bugs.webkit.org/show_bug.cgi?id=155607

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (198488 => 198489)

--- trunk/LayoutTests/ChangeLog	2016-03-21 15:59:20 UTC (rev 198488)
+++ trunk/LayoutTests/ChangeLog	2016-03-21 17:10:39 UTC (rev 198489)
@@ -1,3 +1,12 @@
+2016-03-21  Ryan Haddad  
+
+Marking two inspector tests as flaky timeouts on Mac.
+https://bugs.webkit.org/show_bug.cgi?id=155607
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2016-02-03  Sergio Villar Senin  
 
 [css-grid] Fix percentage tracks' size computation in grids with gutters


Modified: trunk/LayoutTests/platform/mac/TestExpectations (198488 => 198489)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-03-21 15:59:20 UTC (rev 198488)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-03-21 17:10:39 UTC (rev 198489)
@@ -1234,6 +1234,8 @@
 webkit.org/b/148636 inspector/model/remote-object.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/page/main-frame-resource.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/model/remote-object-weak-collection.html [ Pass Failure ]
+webkit.org/b/155607 inspector/unit-tests/heap-snapshot.html [ Pass Timeout ]
+webkit.org/b/155607 inspector/inspector/heap/snapshot.html [ Pass Timeout ]
 
 webkit.org/b/152029 inspector/debugger/command-line-api-exception.html [ Pass Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198487] trunk/LayoutTests/platform/mac/TestExpectations

[youenn . fablet]

Title: [198487] trunk/LayoutTests/platform/mac/TestExpectations








Revision 198487
Author youenn.fab...@crf.canon.fr
Date 2016-03-21 05:58:24 -0700 (Mon, 21 Mar 2016)


Log Message
Unreviewed.
Marking imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection-2.html as flaky (Pass, Crash)

Modified Paths

trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/platform/mac/TestExpectations (198486 => 198487)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-03-21 10:42:33 UTC (rev 198486)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-03-21 12:58:24 UTC (rev 198487)
@@ -1278,6 +1278,7 @@
 
 webkit.org/b/152436 [ Debug ] imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.https.html [ Pass Crash ]
 webkit.org/b/153781 [ Debug ] imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection-1.html [ Pass Crash ]
+webkit.org/b/153781 [ Debug ] imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection-2.html [ Pass Crash ]
 
 # WOFF2 is only supported on certain Operating Systems.
 webkit.org/b/150830 [ Yosemite ElCapitan ] fast/text/woff2.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198486] trunk

[svillar]

Title: [198486] trunk








Revision 198486
Author svil...@igalia.com
Date 2016-03-21 03:42:33 -0700 (Mon, 21 Mar 2016)


Log Message
[css-grid] Fix percentage tracks' size computation in grids with gutters
https://bugs.webkit.org/show_bug.cgi?id=153825

Reviewed by Darin Adler.

Source/WebCore:

The track sizing algorithm is passed an available size
(freeSpace in the code) where to size the tracks. The total size of the grid
gutters was pre-removed from that available size because we cannot use it to size
the tracks. However that available size is also used to compute the size of
percentage tracks. As we're removing the size of the gutters, the base size for
percentage computations is smaller than it should be.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):

LayoutTests:

* fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt:
* fast/css-grid-layout/grid-gutters-and-flex-content.html:
* fast/css-grid-layout/grid-gutters-and-tracks-expected.txt:
* fast/css-grid-layout/grid-gutters-and-tracks.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content.html
trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-tracks-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-tracks.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (198485 => 198486)

--- trunk/LayoutTests/ChangeLog	2016-03-21 09:46:21 UTC (rev 198485)
+++ trunk/LayoutTests/ChangeLog	2016-03-21 10:42:33 UTC (rev 198486)
@@ -1,3 +1,15 @@
+2016-02-03  Sergio Villar Senin  
+
+[css-grid] Fix percentage tracks' size computation in grids with gutters
+https://bugs.webkit.org/show_bug.cgi?id=153825
+
+Reviewed by Darin Adler.
+
+* fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt:
+* fast/css-grid-layout/grid-gutters-and-flex-content.html:
+* fast/css-grid-layout/grid-gutters-and-tracks-expected.txt:
+* fast/css-grid-layout/grid-gutters-and-tracks.html:
+
 2016-03-20  Jinwoo Jeong  
 
 The setter of binaryType attribute in WebSocket should raise the exception.


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt (198485 => 198486)

--- trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt	2016-03-21 09:46:21 UTC (rev 198485)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content-expected.txt	2016-03-21 10:42:33 UTC (rev 198486)
@@ -5,6 +5,8 @@
 PASS
 PASS
 PASS
+PASS
+PASS
  
 XXX XXX
 X X


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content.html (198485 => 198486)

--- trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content.html	2016-03-21 09:46:21 UTC (rev 198485)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-gutters-and-flex-content.html	2016-03-21 10:42:33 UTC (rev 198486)
@@ -5,11 +5,11 @@
 

[webkit-changes] [198485] releases/WebKitGTK/webkit-2.12/Source/WebCore

[carlosgc]

Title: [198485] releases/WebKitGTK/webkit-2.12/Source/WebCore








Revision 198485
Author carlo...@webkit.org
Date 2016-03-21 02:46:21 -0700 (Mon, 21 Mar 2016)


Log Message
Merge r198484 - [GTK] scrollbar thumb clipped in 2.11.92
https://bugs.webkit.org/show_bug.cgi?id=155586

Reviewed by Michael Catanzaro.

In the current version of Adwaita, the scrollbar itself also has a
one pixel border that we are not taking into account.

* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paintThumb): Use the scrollbar size
in indicator mode, instead of only the thumb size, to correctly
position the thumb in indicator mode.

Modified Paths

releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog (198484 => 198485)

--- releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog	2016-03-21 09:18:30 UTC (rev 198484)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/ChangeLog	2016-03-21 09:46:21 UTC (rev 198485)
@@ -1,3 +1,18 @@
+2016-03-21  Carlos Garcia Campos  
+
+[GTK] scrollbar thumb clipped in 2.11.92
+https://bugs.webkit.org/show_bug.cgi?id=155586
+
+Reviewed by Michael Catanzaro.
+
+In the current version of Adwaita, the scrollbar itself also has a
+one pixel border that we are not taking into account.
+
+* platform/gtk/ScrollbarThemeGtk.cpp:
+(WebCore::ScrollbarThemeGtk::paintThumb): Use the scrollbar size
+in indicator mode, instead of only the thumb size, to correctly
+position the thumb in indicator mode.
+
 2016-03-17  Carlos Garcia Campos  
 
 REGRESSION(r195661): [GTK] very slow scrolling


Modified: releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp (198484 => 198485)

--- releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp	2016-03-21 09:18:30 UTC (rev 198484)
+++ releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp	2016-03-21 09:46:21 UTC (rev 198485)
@@ -357,15 +357,10 @@
 if (m_usesOverlayScrollbars && scrollbar.hoveredPart() == NoPart) {
 // When using overlay scrollbars we always claim the size of the scrollbar when hovered, so when
 // drawing the indicator we need to adjust the rectangle to its actual size in indicator mode.
-#if GTK_CHECK_VERSION(3, 19, 11)
-int thumbFat = thumbFatness(styleContext.get(), orientation);
-#else
-int thumbFat = thumbFatness(parentStyleContext.get(), orientation);
-#endif
 if (orientation == VerticalScrollbar)
-thumbRect.move(scrollbar.width() - thumbFat, 0);
+thumbRect.move(scrollbar.width() - scrollbarThickness(parentStyleContext.get(), orientation), 0);
 else
-thumbRect.move(0, scrollbar.height() - thumbFat);
+thumbRect.move(0, scrollbar.height() - scrollbarThickness(parentStyleContext.get(), orientation));
 }
 adjustRectAccordingToMargin(styleContext.get(), thumbRect);
 gtk_render_slider(styleContext.get(), context.platformContext()->cr(), thumbRect.x(), thumbRect.y(), thumbRect.width(), thumbRect.height(),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198484] trunk/Source/WebCore

[carlosgc]

Title: [198484] trunk/Source/WebCore








Revision 198484
Author carlo...@webkit.org
Date 2016-03-21 02:18:30 -0700 (Mon, 21 Mar 2016)


Log Message
[GTK] scrollbar thumb clipped in 2.11.92
https://bugs.webkit.org/show_bug.cgi?id=155586

Reviewed by Michael Catanzaro.

In the current version of Adwaita, the scrollbar itself also has a
one pixel border that we are not taking into account.

* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paintThumb): Use the scrollbar size
in indicator mode, instead of only the thumb size, to correctly
position the thumb in indicator mode.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (198483 => 198484)

--- trunk/Source/WebCore/ChangeLog	2016-03-21 06:05:49 UTC (rev 198483)
+++ trunk/Source/WebCore/ChangeLog	2016-03-21 09:18:30 UTC (rev 198484)
@@ -1,3 +1,18 @@
+2016-03-21  Carlos Garcia Campos  
+
+[GTK] scrollbar thumb clipped in 2.11.92
+https://bugs.webkit.org/show_bug.cgi?id=155586
+
+Reviewed by Michael Catanzaro.
+
+In the current version of Adwaita, the scrollbar itself also has a
+one pixel border that we are not taking into account.
+
+* platform/gtk/ScrollbarThemeGtk.cpp:
+(WebCore::ScrollbarThemeGtk::paintThumb): Use the scrollbar size
+in indicator mode, instead of only the thumb size, to correctly
+position the thumb in indicator mode.
+
 2016-03-20  Gyuyoung Kim  
 
 Reduce uses of PassRefPtr in WebCore/dom - 6


Modified: trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp (198483 => 198484)

--- trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp	2016-03-21 06:05:49 UTC (rev 198483)
+++ trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp	2016-03-21 09:18:30 UTC (rev 198484)
@@ -357,15 +357,10 @@
 if (m_usesOverlayScrollbars && scrollbar.hoveredPart() == NoPart) {
 // When using overlay scrollbars we always claim the size of the scrollbar when hovered, so when
 // drawing the indicator we need to adjust the rectangle to its actual size in indicator mode.
-#if GTK_CHECK_VERSION(3, 19, 11)
-int thumbFat = thumbFatness(styleContext.get(), orientation);
-#else
-int thumbFat = thumbFatness(parentStyleContext.get(), orientation);
-#endif
 if (orientation == VerticalScrollbar)
-thumbRect.move(scrollbar.width() - thumbFat, 0);
+thumbRect.move(scrollbar.width() - scrollbarThickness(parentStyleContext.get(), orientation), 0);
 else
-thumbRect.move(0, scrollbar.height() - thumbFat);
+thumbRect.move(0, scrollbar.height() - scrollbarThickness(parentStyleContext.get(), orientation));
 }
 adjustRectAccordingToMargin(styleContext.get(), thumbRect);
 gtk_render_slider(styleContext.get(), context.platformContext()->cr(), thumbRect.x(), thumbRect.y(), thumbRect.width(), thumbRect.height(),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [198483] trunk/Source/WebCore

[gyuyoung . kim]

Title: [198483] trunk/Source/WebCore








Revision 198483
Author gyuyoung@webkit.org
Date 2016-03-20 23:05:49 -0700 (Sun, 20 Mar 2016)


Log Message
Reduce uses of PassRefPtr in WebCore/dom - 6
https://bugs.webkit.org/show_bug.cgi?id=155579

Reviewed by Darin Adler.

* dom/MessagePortChannel.h:
* dom/default/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::EventData::EventData):
(WebCore::MessagePortChannel::createChannel):
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::PlatformMessagePortChannel::create):
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
* dom/default/PlatformMessagePortChannel.h:
(WebCore::PlatformMessagePortChannel::EventData::message):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DocumentMarker.cpp
trunk/Source/WebCore/dom/DocumentMarker.h
trunk/Source/WebCore/dom/DocumentMarkerController.cpp
trunk/Source/WebCore/dom/DocumentMarkerController.h
trunk/Source/WebCore/dom/EventContext.cpp
trunk/Source/WebCore/dom/EventContext.h
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/MessagePort.cpp
trunk/Source/WebCore/dom/MessagePort.h
trunk/Source/WebCore/dom/MessagePortChannel.h
trunk/Source/WebCore/dom/StaticNodeList.h
trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.cpp
trunk/Source/WebCore/dom/default/PlatformMessagePortChannel.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (198482 => 198483)

--- trunk/Source/WebCore/ChangeLog	2016-03-21 05:28:21 UTC (rev 198482)
+++ trunk/Source/WebCore/ChangeLog	2016-03-21 06:05:49 UTC (rev 198483)
@@ -1,3 +1,21 @@
+2016-03-20  Gyuyoung Kim  
+
+Reduce uses of PassRefPtr in WebCore/dom - 6
+https://bugs.webkit.org/show_bug.cgi?id=155579
+
+Reviewed by Darin Adler.
+
+* dom/MessagePortChannel.h:
+* dom/default/PlatformMessagePortChannel.cpp:
+(WebCore::PlatformMessagePortChannel::EventData::EventData):
+(WebCore::MessagePortChannel::createChannel):
+(WebCore::MessagePortChannel::MessagePortChannel):
+(WebCore::MessagePortChannel::postMessageToRemote):
+(WebCore::PlatformMessagePortChannel::create):
+(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
+* dom/default/PlatformMessagePortChannel.h:
+(WebCore::PlatformMessagePortChannel::EventData::message):
+
 2016-03-20  Jinwoo Jeong  
 
 The setter of binaryType attribute in WebSocket should raise the exception.


Modified: trunk/Source/WebCore/dom/DocumentMarker.cpp (198482 => 198483)

--- trunk/Source/WebCore/dom/DocumentMarker.cpp	2016-03-21 05:28:21 UTC (rev 198482)
+++ trunk/Source/WebCore/dom/DocumentMarker.cpp	2016-03-21 06:05:49 UTC (rev 198483)
@@ -125,7 +125,7 @@
 ASSERT(m_details);
 }
 
-DocumentMarker::DocumentMarker(MarkerType type, unsigned startOffset, unsigned endOffset, PassRefPtr details)
+DocumentMarker::DocumentMarker(MarkerType type, unsigned startOffset, unsigned endOffset, RefPtr&& details)
 : m_type(type)
 , m_startOffset(startOffset)
 , m_endOffset(endOffset)


Modified: trunk/Source/WebCore/dom/DocumentMarker.h (198482 => 198483)

--- trunk/Source/WebCore/dom/DocumentMarker.h	2016-03-21 05:28:21 UTC (rev 198482)
+++ trunk/Source/WebCore/dom/DocumentMarker.h	2016-03-21 06:05:49 UTC (rev 198483)
@@ -122,7 +122,7 @@
 DocumentMarker(MarkerType, unsigned startOffset, unsigned endOffset, const String& description, const Vector& alternatives, RetainPtr metadata);
 #endif
 DocumentMarker(unsigned startOffset, unsigned endOffset, bool activeMatch);
-DocumentMarker(MarkerType, unsigned startOffset, unsigned endOffset, PassRefPtr);
+DocumentMarker(MarkerType, unsigned startOffset, unsigned endOffset, RefPtr&&);
 
 MarkerType type() const { return m_type; }
 unsigned startOffset() const { return m_startOffset; }


Modified: trunk/Source/WebCore/dom/DocumentMarkerController.cpp (198482 => 198483)

--- trunk/Source/WebCore/dom/DocumentMarkerController.cpp	2016-03-21 05:28:21 UTC (rev 198482)
+++ trunk/Source/WebCore/dom/DocumentMarkerController.cpp	2016-03-21 06:05:49 UTC (rev 198483)
@@ -83,9 +83,9 @@
 addMarker(node, DocumentMarker(type, startOffset, startOffset + length));
 }
 
-void DocumentMarkerController::addMarkerToNode(Node* node, unsigned startOffset, unsigned length, DocumentMarker::MarkerType type, PassRefPtr details)
+void DocumentMarkerController::addMarkerToNode(Node* node, unsigned startOffset, unsigned length, DocumentMarker::MarkerType type, RefPtr&& details)
 {
-addMarker(node, DocumentMarker(type, startOffset, startOffset + length, details));
+addMarker(node, DocumentMarker(type, startOffset, startOffset + length, WTFMove(details)));
 }
 
 


Modified: trunk/Source/WebCore/dom/DocumentMarkerController.h (198482 => 198483)

--- trunk/Source/WebCore/dom/DocumentMarkerController.h