[webkit-changes] [205795] branches/safari-602-branch/Source

[bshafiei]

Title: [205795] branches/safari-602-branch/Source








Revision 205795
Author bshaf...@apple.com
Date 2016-09-11 23:54:26 -0700 (Sun, 11 Sep 2016)


Log Message
Versioning.

Modified Paths

branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig (205794 => 205795)

--- branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-09-12 04:03:36 UTC (rev 205794)
+++ branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2016-09-12 06:54:26 UTC (rev 205795)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 2;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig (205794 => 205795)

--- branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig	2016-09-12 04:03:36 UTC (rev 205794)
+++ branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig	2016-09-12 06:54:26 UTC (rev 205795)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 2;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (205794 => 205795)

--- branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-09-12 04:03:36 UTC (rev 205794)
+++ branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-09-12 06:54:26 UTC (rev 205795)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 602;
 MINOR_VERSION = 2;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig (205794 => 205795)

--- branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-09-12 04:03:36 UTC (rev 205794)
+++ branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2016-09-12 06:54:26 UTC (rev 205795)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 2;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig (205794 => 205795)

--- branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-09-12 04:03:36 UTC (rev 205794)
+++ branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig	2016-09-12 06:54:26 UTC (rev 205795)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 602;
 MINOR_VERSION = 2;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205794] trunk/Source

[fpizlo]

Title: [205794] trunk/Source








Revision 205794
Author fpi...@apple.com
Date 2016-09-11 21:03:36 -0700 (Sun, 11 Sep 2016)


Log Message
FastBitVector should have efficient and easy-to-use vector-vector operations
https://bugs.webkit.org/show_bug.cgi?id=161847

Reviewed by Saam Barati.

Source/_javascript_Core:

Adapt existing users of FastBitVector to the new API.

* bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::BytecodeLivenessAnalysis::computeKills):
(JSC::BytecodeLivenessAnalysis::dumpResults):
* bytecode/BytecodeLivenessAnalysisInlines.h:
(JSC::operandThatIsNotAlwaysLiveIsLive):
(JSC::BytecodeLivenessPropagation::stepOverInstruction):
(JSC::BytecodeLivenessPropagation::runLivenessFixpoint):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::validate):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushForTerminal):
* dfg/DFGForAllKills.h:
(JSC::DFG::forAllKilledOperands):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::forAllLocalsLiveInBytecode):
* dfg/DFGLiveCatchVariablePreservationPhase.cpp:
(JSC::DFG::LiveCatchVariablePreservationPhase::willCatchException):
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock):
* dfg/DFGNaturalLoops.cpp:
(JSC::DFG::NaturalLoops::NaturalLoops):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::cleanMustHandleValuesIfNecessary):

Source/WTF:

FastBitVector is a bitvector representation that supports manual dynamic resizing and is
optimized for speed, not space. (BitVector supports automatic dynamic resizing and is
optimized for space, while Bitmap is sized statically and is optimized for both speed and
space.) This change greatly increases the power of FastBitVector. We will use these new
powers for changing the JSC GC to use FastBitVectors to track sets of MarkedBlocks (bug
161581) instead of using a combination of Vectors and doubly-linked lists.

This change splits FastBitVector into two parts:

- A thing that manages the storage of a bitvector: a uint32_t array and a size_t numBits.
  We call this the word view.
- A thing that takes some kind of abstract array of uint32_t's and does bitvector
  operations to it. We call this the FastBitVectorImpl.

FastBitVectorImpl and word views are immutable. The FastBitVector class is a subclass of
FastBitVectorImpl specialized on a word view that owns its words and has additional
support for mutable operations.

Doing this allows us to efficiently support things like this without any unnecessary
memory allocation or copying:

FastBitVector a, b, c; // Assume that there is code to initialize these.
a &= b | ~c;

Previously, this kind of operation would not be efficient, because "~c" would have to
create a whole new FastBitVector. But now, it just returns a FastBitVectorImpl whose
underlying word view bitnots (~) its words on the fly. Using template magic, this can get
pretty complex. For example "b | ~c" returns a FastBitVectorImpl that wraps a word view
whose implementation of WordView::word(size_t index) is something like:

uint32_t word(size_t index) { return b.m_words.word(index) | ~c.m_words.word(index); }

FastBitVectorImpl supports all of the fast bulk bitvector operations, like
forEachSetBit(), bitCount(), etc. So, when you say "a &= b | ~c", the actual
implementation is going to run these bit operations on word granularity directly over the
storage inside a, b, c.

The use of operator overloading is worth explaining a bit. Previously, FastBitVector
avoided operator overloading. For example, the &= operation was called filter(). I think
that this was a pretty good approach at the time. I tried using non-operator methods in
this FastBitVector rewrite, but I found it very odd to say things like:

a.filter(b.bitOr(c.bitNot()));

I think that it's harder to see what is going on here, then using operators, because infix
notation is always better.

* WTF.xcodeproj/project.pbxproj:
* wtf/BitVector.h:
(WTF::BitVector::findBitInWord): Deleted.
* wtf/CMakeLists.txt:
* wtf/Dominators.h:
(WTF::Dominators::NaiveDominators::NaiveDominators):
(WTF::Dominators::NaiveDominators::dominates):
(WTF::Dominators::NaiveDominators::pruneDominators):
* wtf/FastBitVector.cpp: Removed.
* wtf/FastBitVector.h:
(WTF::fastBitVectorArrayLength):
(WTF::FastBitVectorWordView::FastBitVectorWordView):
(WTF::FastBitVectorWordView::numBits):
(WTF::FastBitVectorWordView::word):
(WTF::FastBitVectorWordOwner::FastBitVectorWordOwner):
(WTF::FastBitVectorWordOwner::~FastBitVectorWordOwner):
(WTF::FastBitVectorWordOwner::view):
(WTF::FastBitVectorWordOwner::operator=):
(WTF::FastBitVectorWordOwner::setAll):
(WTF::FastBitVectorWordOwner::clearAll):
(WTF::FastBitVectorWordOwner::set):
(WTF::FastBitVectorWordOwner::numBits):
(WTF::FastBitVectorWordOwner::arrayLength):
(WTF::FastBitVectorWordOwner::resize):
(WTF::FastBitVectorWordOwner::word):
(WTF::FastBitVectorWordOwner::words):
(WTF::FastBitVectorAndWords::FastBitVectorAndWords):
(WTF::FastBitVectorAndWords::view):
(WTF::FastBitVe

[webkit-changes] [205792] trunk/Source/WebInspectorUI

[commit-queue]

Title: [205792] trunk/Source/WebInspectorUI








Revision 205792
Author commit-qu...@webkit.org
Date 2016-09-11 17:03:02 -0700 (Sun, 11 Sep 2016)


Log Message
REGRESSION (r205754): Web Inspector: Cannot click on links to stylesheets in Rules sidebar
https://bugs.webkit.org/show_bug.cgi?id=161838

Patch by Devin Rousso  on 2016-09-11
Reviewed by Brian Burg.

* UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section > .header > textarea):
(.style-declaration-section > .header > .origin):
Added z-index to the non-selector elements of the header.  Also limited the size of the
selector textarea to just the size of the displayed selector text.

* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor):
Fixed invalid enum value for propertyVisibilityMode.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (205791 => 205792)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-09-11 22:30:05 UTC (rev 205791)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-09-12 00:03:02 UTC (rev 205792)
@@ -1,3 +1,20 @@
+2016-09-11  Devin Rousso  
+
+REGRESSION (r205754): Web Inspector: Cannot click on links to stylesheets in Rules sidebar
+https://bugs.webkit.org/show_bug.cgi?id=161838
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/CSSStyleDeclarationSection.css:
+(.style-declaration-section > .header > textarea):
+(.style-declaration-section > .header > .origin):
+Added z-index to the non-selector elements of the header.  Also limited the size of the
+selector textarea to just the size of the displayed selector text.
+
+* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+(WebInspector.CSSStyleDeclarationTextEditor):
+Fixed invalid enum value for propertyVisibilityMode.
+
 2016-09-09  Devin Rousso  
 
 Web Inspector: Command-Z doesn't work when editing CSS selectors in Styles sidebar


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css (205791 => 205792)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css	2016-09-11 22:30:05 UTC (rev 205791)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css	2016-09-12 00:03:02 UTC (rev 205792)
@@ -101,10 +101,8 @@
 right: 0;
 bottom: 0;
 left: 0;
-width: 100%;
-height: 100%;
-margin: 0;
-padding: var(--style-declaration-section-header-padding);
+margin: var(--style-declaration-section-header-padding);
+padding: 0;
 font-family: Menlo, monospace;
 color: black;
 background: transparent;
@@ -134,6 +132,9 @@
 }
 
 .style-declaration-section > .header > .origin {
+position: relative;
+z-index: 1;
+
 line-height: 10px;
 
 color: hsl(0, 0%, 50%);


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (205791 => 205792)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js	2016-09-11 22:30:05 UTC (rev 205791)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js	2016-09-12 00:03:02 UTC (rev 205792)
@@ -37,7 +37,7 @@
 
 this._mouseDownCursorPosition = null;
 
-this._propertyVisibilityMode = WebInspector.CSSStyleDeclarationTextEditor.PropertyVisibilityMode.Shown;
+this._propertyVisibilityMode = WebInspector.CSSStyleDeclarationTextEditor.PropertyVisibilityMode.ShowAll;
 this._showsImplicitProperties = true;
 this._alwaysShowPropertyNames = {};
 this._filterResultPropertyNames = null;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [205791] trunk

[cdumez]

Title: [205791] trunk








Revision 205791
Author cdu...@apple.com
Date 2016-09-11 15:30:05 -0700 (Sun, 11 Sep 2016)


Log Message
HTMLTrackElement.kind's invalid value default should be the metadata state
https://bugs.webkit.org/show_bug.cgi?id=161840

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline existing tests now that more checks are passing.

* web-platform-tests/html/dom/reflection-embedded-expected.txt:
* web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/kind-expected.txt:
* web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/kind-expected.txt:

Source/WebCore:

HTMLTrackElement.kind's invalid value default should be the metadata state,
not the subtitles state:
- https://html.spec.whatwg.org/#attr-track-kind

Chrome agrees with the specification.

No new tests, rebaselined existing tests.

* html/track/TextTrack.cpp:
(WebCore::TextTrack::setKindKeywordIgnoringASCIICase):

LayoutTests:

* media/track/track-kind-expected.txt:
* media/track/track-kind.html:
Update existing test to reflect behavior change.

* media/track/w3c/interfaces/TextTrack/kind.html:
Re-sync test from W3C as it was outdated.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/kind-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/kind-expected.txt
trunk/LayoutTests/media/track/track-kind-expected.txt
trunk/LayoutTests/media/track/track-kind.html
trunk/LayoutTests/media/track/w3c/interfaces/TextTrack/kind.html
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/TextTrack.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (205790 => 205791)

--- trunk/LayoutTests/ChangeLog	2016-09-11 18:11:42 UTC (rev 205790)
+++ trunk/LayoutTests/ChangeLog	2016-09-11 22:30:05 UTC (rev 205791)
@@ -1,3 +1,17 @@
+2016-09-11  Chris Dumez  
+
+HTMLTrackElement.kind's invalid value default should be the metadata state
+https://bugs.webkit.org/show_bug.cgi?id=161840
+
+Reviewed by Eric Carlson.
+
+* media/track/track-kind-expected.txt:
+* media/track/track-kind.html:
+Update existing test to reflect behavior change.
+
+* media/track/w3c/interfaces/TextTrack/kind.html:
+Re-sync test from W3C as it was outdated.
+
 2016-09-11  Gyuyoung Kim  
 
 [EFL] Skip to test some w3c/web-platform-tests


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (205790 => 205791)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-11 18:11:42 UTC (rev 205790)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-11 22:30:05 UTC (rev 205791)
@@ -1,3 +1,16 @@
+2016-09-11  Chris Dumez  
+
+HTMLTrackElement.kind's invalid value default should be the metadata state
+https://bugs.webkit.org/show_bug.cgi?id=161840
+
+Reviewed by Eric Carlson.
+
+Rebaseline existing tests now that more checks are passing.
+
+* web-platform-tests/html/dom/reflection-embedded-expected.txt:
+* web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/kind-expected.txt:
+* web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/kind-expected.txt:
+
 2016-09-09  Jer Noble  
 
 [Media Source] Import updated w3c/web-platform-tests and rebaseline


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205790 => 205791)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2016-09-11 18:11:42 UTC (rev 205790)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt	2016-09-11 22:30:05 UTC (rev 205791)
@@ -11822,73 +11822,73 @@
 PASS track.kind: typeof IDL attribute 
 PASS track.kind: IDL get with DOM attribute unset 
 PASS track.kind: setAttribute() to "" followed by getAttribute() 
-FAIL track.kind: setAttribute() to "" followed by IDL get assert_equals: expected "metadata" but got "subtitles"
+PASS track.kind: setAttribute() to "" followed by IDL get 
 PASS track.kind: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " followed by getAttribute() 
-FAIL track.kind: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " followed by IDL get assert_equals: expected "metadata" but got "subtitles"
+PASS track.kind: setA

[webkit-changes] [205790] trunk/Source/WebCore

[hyatt]

Title: [205790] trunk/Source/WebCore








Revision 205790
Author hy...@apple.com
Date 2016-09-11 11:11:42 -0700 (Sun, 11 Sep 2016)


Log Message
[CSS Parser] Add the main parser implementation
https://bugs.webkit.org/show_bug.cgi?id=161813

Reviewed by Dean Jackson.

This patch adds the main CSSParserImpl that handles stylesheet and rule parsing. All parsing starts with this
class (it will eventually be invoked from the CSSParser). This patch also adds @supports parsing.

* WebCore.xcodeproj/project.pbxproj:
* css/CSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::StyleKeyframe):
* css/CSSKeyframeRule.h:
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleCharset::StyleRuleCharset):
(WebCore::StyleRuleCharset::~StyleRuleCharset):
(WebCore::StyleRuleNamespace::StyleRuleNamespace):
(WebCore::StyleRuleNamespace::~StyleRuleNamespace):
* css/StyleRule.h:
(WebCore::StyleRuleBase::isNamespaceRule):
(isType):
(WebCore::StyleRuleBase::isKeyframesRule): Deleted.
* css/StyleSheetContents.cpp:
(WebCore::traverseSubresourcesInRules):
* css/parser/CSSParserImpl.cpp: Added.
(WebCore::CSSParserImpl::CSSParserImpl):
(WebCore::CSSParserImpl::parseValue):
(WebCore::CSSParserImpl::parseVariableValue):
(WebCore::filterProperties):
(WebCore::createStyleProperties):
(WebCore::CSSParserImpl::parseInlineStyleDeclaration):
(WebCore::CSSParserImpl::parseDeclarationList):
(WebCore::CSSParserImpl::parseRule):
(WebCore::CSSParserImpl::parseStyleSheet):
(WebCore::CSSParserImpl::parsePageSelector):
(WebCore::CSSParserImpl::parseCustomPropertySet):
(WebCore::CSSParserImpl::parseKeyframeKeyList):
(WebCore::CSSParserImpl::supportsDeclaration):
(WebCore::CSSParserImpl::parseDeclarationListForInspector):
(WebCore::CSSParserImpl::parseStyleSheetForInspector):
(WebCore::computeNewAllowedRules):
(WebCore::CSSParserImpl::consumeRuleList):
(WebCore::CSSParserImpl::consumeAtRule):
(WebCore::CSSParserImpl::consumeQualifiedRule):
(WebCore::consumeStringOrURI):
(WebCore::CSSParserImpl::consumeCharsetRule):
(WebCore::CSSParserImpl::consumeImportRule):
(WebCore::CSSParserImpl::consumeNamespaceRule):
(WebCore::CSSParserImpl::consumeMediaRule):
(WebCore::CSSParserImpl::consumeSupportsRule):
(WebCore::CSSParserImpl::consumeViewportRule):
(WebCore::CSSParserImpl::consumeFontFaceRule):
(WebCore::CSSParserImpl::consumeKeyframesRule):
(WebCore::CSSParserImpl::consumePageRule):
(WebCore::CSSParserImpl::consumeKeyframeStyleRule):
(WebCore::observeSelectors):
(WebCore::CSSParserImpl::consumeStyleRule):
(WebCore::CSSParserImpl::consumeDeclarationList):
(WebCore::CSSParserImpl::consumeDeclaration):
(WebCore::CSSParserImpl::consumeVariableValue):
(WebCore::CSSParserImpl::consumeDeclarationValue):
(WebCore::CSSParserImpl::consumeKeyframeKeyList):
* css/parser/CSSParserImpl.h: Added.
* css/parser/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePagePseudoSelector):
* css/parser/CSSParserValues.h:
* css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseValue):
* css/parser/CSSSupportsParser.cpp: Added.
(WebCore::CSSSupportsParser::supportsCondition):
(WebCore::CSSSupportsParser::consumeCondition):
(WebCore::CSSSupportsParser::consumeNegation):
(WebCore::CSSSupportsParser::consumeConditionInParenthesis):
* css/parser/CSSSupportsParser.h: Added.
(WebCore::CSSSupportsParser::CSSSupportsParser):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/css/CSSKeyframeRule.cpp
trunk/Source/WebCore/css/CSSKeyframeRule.h
trunk/Source/WebCore/css/StyleRule.cpp
trunk/Source/WebCore/css/StyleRule.h
trunk/Source/WebCore/css/StyleSheetContents.cpp
trunk/Source/WebCore/css/parser/CSSParserValues.cpp
trunk/Source/WebCore/css/parser/CSSParserValues.h
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp


Added Paths

trunk/Source/WebCore/css/parser/CSSParserImpl.cpp
trunk/Source/WebCore/css/parser/CSSParserImpl.h
trunk/Source/WebCore/css/parser/CSSSupportsParser.cpp
trunk/Source/WebCore/css/parser/CSSSupportsParser.h




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (205789 => 205790)

--- trunk/Source/WebCore/CMakeLists.txt	2016-09-11 14:10:54 UTC (rev 205789)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-09-11 18:11:42 UTC (rev 205790)
@@ -1353,6 +1353,7 @@
 css/parser/CSSParser.cpp
 css/parser/CSSParserFastPaths.cpp
 css/parser/CSSParserIdioms.cpp
+css/parser/CSSParserImpl.cpp
 css/parser/CSSParserObserverWrapper.cpp
 css/parser/CSSParserToken.cpp
 css/parser/CSSParserTokenRange.cpp
@@ -1360,6 +1361,7 @@
 css/parser/CSSPropertyParser.cpp
 css/parser/CSSPropertyParserHelpers.cpp
 css/parser/CSSSelectorParser.cpp
+css/parser/CSSSupportsParser.cpp
 css/parser/CSSTokenizer.cpp
 css/parser/CSSTokenizerInputStream.cpp
 css/parser/MediaQueryBlockWatcher.cpp


Modified: trunk/Source/WebCore/ChangeLog (205789 =>

[webkit-changes] [205789] trunk/LayoutTests

[gyuyoung . kim]

Title: [205789] trunk/LayoutTests








Revision 205789
Author gyuyoung@webkit.org
Date 2016-09-11 07:10:54 -0700 (Sun, 11 Sep 2016)


Log Message
[EFL] Skip to test some w3c/web-platform-tests

Unreviewed EFL gardening.

Some tests of w3c/web-platform-tests have been flaky since r205777.

* platform/efl/TestExpectations

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (205788 => 205789)

--- trunk/LayoutTests/ChangeLog	2016-09-11 07:24:17 UTC (rev 205788)
+++ trunk/LayoutTests/ChangeLog	2016-09-11 14:10:54 UTC (rev 205789)
@@ -1,3 +1,13 @@
+2016-09-11  Gyuyoung Kim  
+
+[EFL] Skip to test some w3c/web-platform-tests
+
+Unreviewed EFL gardening.
+
+Some tests of w3c/web-platform-tests have been flaky since r205777.
+
+* platform/efl/TestExpectations
+
 2016-09-11  Tim Horton  
 
 Candidates that don't end in spaces shouldn't have spaces arbitrarily appended to them


Modified: trunk/LayoutTests/platform/efl/TestExpectations (205788 => 205789)

--- trunk/LayoutTests/platform/efl/TestExpectations	2016-09-11 07:24:17 UTC (rev 205788)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2016-09-11 14:10:54 UTC (rev 205789)
@@ -1566,6 +1566,40 @@
 webkit.org/b/161839 imported/w3c/web-platform-tests/media-source/mediasource-trackdefault.html [ Failure ]
 webkit.org/b/161839 imported/w3c/web-platform-tests/media-source/mediasource-trackdefaultlist.html [ Failure ]
 
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbcursor_advance_index9.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbdatabase_createObjectStore8-parameters.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbdatabase_transaction5.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbfactory_cmp2.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbfactory_open3.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbkeyrange.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_createIndex2.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_delete2.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_delete4.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_delete6.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_deleted.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_get3.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/XMLHttpRequest/overridemimetype-loading-state.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-basic-setrequestheader-and-arguments.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/XMLHttpRequest/send-content-type-charset.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/XMLHttpRequest/send-response-upload-event-progress.htm [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/dom/collections/domstringmap-supported-property-names.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html [ Failure Timeout ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_css.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/dom/nodes/Element-childElementCount-dynamic-add.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/dom/nodes/Element-classlist.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/fetch/api/basic/scheme-blob.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/onexit.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/fallback.basic.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.colour.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.junk.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.reflect.setcontent.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.octal.html [ Skip ]
+webkit.org/b/161839 imported/w3c/web-platform-tests/html/semantics/embedded-cont

[webkit-changes] [205788] trunk

[timothy_horton]

Title: [205788] trunk








Revision 205788
Author timothy_hor...@apple.com
Date 2016-09-11 00:24:17 -0700 (Sun, 11 Sep 2016)


Log Message
Candidates that don't end in spaces shouldn't have spaces arbitrarily appended to them
https://bugs.webkit.org/show_bug.cgi?id=161846


Reviewed by Beth Dakin.

Tests: editing/mac/spelling/accept-candidate-without-adding-space.html,
   editing/mac/spelling/accept-candidate-allows-autocorrect-on-next-word.html

* editing/Editor.cpp:
(WebCore::Editor::handleAcceptedCandidate):
Stop appending a space just because the candidate doesn't end in a space.
There are languages where that doesn't make sense, and the platform
guarantees that candidates will always have spaces if they need them.

Also, adjust the way we compute the AcceptedCandidate document marker range.
There were two problems with the existing code: it expanded outward from
the post-insertion cursor in *both* directions, instead of just backwards,
and it used the length of the replaced text, not the length of the newly
inserted text (more of the confusion mentioned in r205765).

* editing/mac/spelling/accept-candidate-replacing-multiple-words-expected.txt:
* editing/mac/spelling/accept-candidate-replacing-multiple-words.html:
* editing/mac/spelling/accept-candidate-without-crossing-editing-boundary-expected.txt:
* editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:
Update existing tests to put spaces at the end of accepted candidates to make them
more similar to what the OS will return to us.

* editing/mac/spelling/accept-candidate-without-adding-space-expected.txt: Added.
* editing/mac/spelling/accept-candidate-without-adding-space.html: Added.
Add a test where the accepted candidate does *not* have a space at the end,
testing that we don't add one where the candidate didn't contain one.

* editing/mac/spelling/accept-candidate-allows-autocorrect-on-next-word-expected.txt: Added.
* editing/mac/spelling/accept-candidate-allows-autocorrect-on-next-word.html: Added.
Add a test ensuring that the document marker added by accepting a candidate
doesn't overlap the next word and prevent autocorrect from working on it.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/mac/spelling/accept-candidate-replacing-multiple-words-expected.txt
trunk/LayoutTests/editing/mac/spelling/accept-candidate-replacing-multiple-words.html
trunk/LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary-expected.txt
trunk/LayoutTests/editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html
trunk/LayoutTests/editing/mac/spelling/accept-misspelled-candidate-expected.txt
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp


Added Paths

trunk/LayoutTests/editing/mac/spelling/accept-candidate-allows-autocorrect-on-next-word-expected.txt
trunk/LayoutTests/editing/mac/spelling/accept-candidate-allows-autocorrect-on-next-word.html
trunk/LayoutTests/editing/mac/spelling/accept-candidate-without-adding-space-expected.txt
trunk/LayoutTests/editing/mac/spelling/accept-candidate-without-adding-space.html




Diff

Modified: trunk/LayoutTests/ChangeLog (205787 => 205788)

--- trunk/LayoutTests/ChangeLog	2016-09-10 18:08:32 UTC (rev 205787)
+++ trunk/LayoutTests/ChangeLog	2016-09-11 07:24:17 UTC (rev 205788)
@@ -1,3 +1,28 @@
+2016-09-11  Tim Horton  
+
+Candidates that don't end in spaces shouldn't have spaces arbitrarily appended to them
+https://bugs.webkit.org/show_bug.cgi?id=161846
+
+
+Reviewed by Beth Dakin.
+
+* editing/mac/spelling/accept-candidate-replacing-multiple-words-expected.txt:
+* editing/mac/spelling/accept-candidate-replacing-multiple-words.html:
+* editing/mac/spelling/accept-candidate-without-crossing-editing-boundary-expected.txt:
+* editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html:
+Update existing tests to put spaces at the end of accepted candidates to make them
+more similar to what the OS will return to us.
+
+* editing/mac/spelling/accept-candidate-without-adding-space-expected.txt: Added.
+* editing/mac/spelling/accept-candidate-without-adding-space.html: Added.
+Add a test where the accepted candidate does *not* have a space at the end,
+testing that we don't add one where the candidate didn't contain one.
+
+* editing/mac/spelling/accept-candidate-allows-autocorrect-on-next-word-expected.txt: Added.
+* editing/mac/spelling/accept-candidate-allows-autocorrect-on-next-word.html: Added.
+Add a test ensuring that the document marker added by accepting a candidate
+doesn't overlap the next word and prevent autocorrect from working on it.
+
 2016-09-10  Chris Dumez  
 
 It is possible for Document::m_frame pointer to become stale


Added: trunk/LayoutTests/editing/mac/spelling/accept-ca