[webkit-changes] [206247] trunk

[mitz]

Title: [206247] trunk








Revision 206247
Author m...@apple.com
Date 2016-09-21 22:03:01 -0700 (Wed, 21 Sep 2016)


Log Message
[macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
https://bugs.webkit.org/show_bug.cgi?id=162359


Reviewed by Tim Horton.

Source/WebKit2:

Test: added to TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Fixed a bug where
  m_pendingNewlyReachedLayoutMilestones was never initialized.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Added
  m_pendingNewlyReachedLayoutMilestones member variable to this derived class as well.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers): If we have pending milestones, notify
  the WebPageProxy now, after any content size changes have been sent.
(WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone): New override that
  accumulates the milestones into m_pendingNewlyReachedLayoutMilestones and returns true,
  so that the caller won’t notify the WebPageProxy immediately.

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
(TEST):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (206246 => 206247)

--- trunk/Source/WebKit2/ChangeLog	2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Source/WebKit2/ChangeLog	2016-09-22 05:03:01 UTC (rev 206247)
@@ -1,3 +1,25 @@
+2016-09-21  Dan Bernstein  
+
+[macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
+https://bugs.webkit.org/show_bug.cgi?id=162359
+
+
+Reviewed by Tim Horton.
+
+Test: added to TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm
+
+* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Fixed a bug where
+  m_pendingNewlyReachedLayoutMilestones was never initialized.
+
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Added
+  m_pendingNewlyReachedLayoutMilestones member variable to this derived class as well.
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::flushLayers): If we have pending milestones, notify
+  the WebPageProxy now, after any content size changes have been sent.
+(WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone): New override that
+  accumulates the milestones into m_pendingNewlyReachedLayoutMilestones and returns true,
+  so that the caller won’t notify the WebPageProxy immediately.
+
 2016-09-21  Anders Carlsson  
 
 support openPaymentSetup API on ApplePaySession object


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h (206246 => 206247)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h	2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h	2016-09-22 05:03:01 UTC (rev 206247)
@@ -163,7 +163,7 @@
 uint64_t m_currentTransactionID;
 Vector m_pendingCallbackIDs;
 
-WebCore::LayoutMilestones m_pendingNewlyReachedLayoutMilestones;
+WebCore::LayoutMilestones m_pendingNewlyReachedLayoutMilestones { 0 };
 
 WebCore::GraphicsLayer* m_contentLayer;
 WebCore::GraphicsLayer* m_viewOverlayRootLayer;


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h (206246 => 206247)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h	2016-09-22 04:36:22 UTC (rev 206246)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h	2016-09-22 05:03:01 UTC (rev 206247)
@@ -86,6 +86,8 @@
 
 void attachViewOverlayGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*) override;
 
+bool dispatchDidReachLayoutMilestone(WebCore::LayoutMilestones) override;
+
 // WebCore::LayerFlushSchedulerClient
 bool flushLayers() override;
 
@@ -154,6 +156,8 @@
 bool m_isScalingViewToFitDocument { false };
 WebCore::IntSize m_lastViewSizeForScaleToFit;
 WebCore::IntSize m_lastDocumentSizeForScaleToFit;
+
+WebCore::LayoutMilestones m_pendingNewlyReachedLayoutMilestones { 0 };
 };
 
 } // namespace WebKit


Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (206246 => 206247)

--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2016-09-22 04:36:22 UTC (rev 206246)
+++ 

[webkit-changes] [206246] trunk

[cdumez]

Title: [206246] trunk








Revision 206246
Author cdu...@apple.com
Date 2016-09-21 21:36:22 -0700 (Wed, 21 Sep 2016)


Log Message
Fix serialization of bgsound, keygen and track elements
https://bugs.webkit.org/show_bug.cgi?id=162353

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C tests now that more checks are passing.

* web-platform-tests/html/syntax/serializing-html-fragments/outerHTML-expected.txt:
* web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:
* web-platform-tests/html/syntax/serializing-xml-fragments/outerHTML-expected.txt:

Source/WebCore:

Fix serialization of keygen and track elements to match the specification:
- https://html.spec.whatwg.org/#serialising-html-fragments

They are not supposed to have an end tag. Firefox and Chrome agree with
the specification.

No new tests, rebaselined existing tests.

* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::elementCannotHaveEndTag):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/outerHTML-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-xml-fragments/outerHTML-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/MarkupAccumulator.cpp


Added Paths

trunk/LayoutTests/fast/html/image-element-serialization-expected.txt
trunk/LayoutTests/fast/html/image-element-serialization.html




Diff

Added: trunk/LayoutTests/fast/html/image-element-serialization-expected.txt (0 => 206246)

--- trunk/LayoutTests/fast/html/image-element-serialization-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/html/image-element-serialization-expected.txt	2016-09-22 04:36:22 UTC (rev 206246)
@@ -0,0 +1,11 @@
+Test that an  element in HTML has an end tag when serialized.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS image.__proto__ is HTMLUnknownElement.prototype
+PASS div.innerHTML is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/html/image-element-serialization.html (0 => 206246)

--- trunk/LayoutTests/fast/html/image-element-serialization.html	(rev 0)
+++ trunk/LayoutTests/fast/html/image-element-serialization.html	2016-09-22 04:36:22 UTC (rev 206246)
@@ -0,0 +1,16 @@
+
+
+
+
+description("Test that an  element in HTML has an end tag when serialized.");
+
+var div = document.createElement("div");
+var image = document.createElement("image");
+shouldBe("image.__proto__", "HTMLUnknownElement.prototype");
+div.appendChild(image);
+shouldBeEqualToString("div.innerHTML", "");
+

[webkit-changes] [206245] trunk

[keith_miller]

Title: [206245] trunk








Revision 206245
Author keith_mil...@apple.com
Date 2016-09-21 21:32:12 -0700 (Wed, 21 Sep 2016)


Log Message
Fix build for future versions of Clang.
https://bugs.webkit.org/show_bug.cgi?id=162346

Reviewed by Filip Pizlo.

Source/_javascript_Core:

This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.

* runtime/VM.h:
(JSC::VM::setGlobalConstRedeclarationShouldThrow):

Source/WebCore:

This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.

* Configurations/WebCore.unexp:
* dom/Exception.h:
* page/Frame.h:
* platform/cocoa/WebPlaybackSessionModelMediaElement.h:
* platform/cocoa/WebVideoFullscreenModelVideoElement.h:
(WebCore::WebVideoFullscreenModelVideoElement::videoElement):
* platform/graphics/Color.h:
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::rotate):
* platform/mac/WebVideoFullscreenInterfaceMac.h:
* platform/network/ParsedContentRange.h:
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::isValid):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::certificateInfo):
* platform/text/TextStream.h:
(WebCore::TextStream::increaseIndent):
(WebCore::TextStream::decreaseIndent):

Source/WTF:

This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.

* wtf/text/StringImpl.h:

Tools:

* TestWebKitAPI/Counters.cpp:
* TestWebKitAPI/Counters.h:
(DeleterCounter::deleterCount):
(DeleterCounter::TestingScope::TestingScope):
(DeleterCounter::operator()):
* TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.unexp
trunk/Source/WebCore/dom/Exception.h
trunk/Source/WebCore/page/Frame.h
trunk/Source/WebCore/page/MainFrame.h
trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h
trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h
trunk/Source/WebCore/platform/graphics/Color.h
trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h
trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h
trunk/Source/WebCore/platform/network/ParsedContentRange.h
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
trunk/Source/WebCore/platform/text/TextStream.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Counters.cpp
trunk/Tools/TestWebKitAPI/Counters.h
trunk/Tools/TestWebKitAPI/Tests/WTF/HashCountedSet.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (206244 => 206245)

--- trunk/Source/_javascript_Core/ChangeLog	2016-09-22 01:23:26 UTC (rev 206244)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-22 04:32:12 UTC (rev 206245)
@@ -1,3 +1,18 @@
+2016-09-21  Keith Miller  
+
+Fix build for future versions of Clang.
+https://bugs.webkit.org/show_bug.cgi?id=162346
+
+Reviewed by Filip Pizlo.
+
+This fixes issues with the WebCore build where inline
+template-class function definitions are marked as exported. This
+genereates a weak external symobl that our build does not like.
+
+
+* runtime/VM.h:
+(JSC::VM::setGlobalConstRedeclarationShouldThrow):
+
 2016-09-21  Joseph Pecoraro  
 
 Inline function only used in one place


Modified: trunk/Source/_javascript_Core/runtime/VM.h (206244 => 206245)

--- trunk/Source/_javascript_Core/runtime/VM.h	2016-09-22 01:23:26 UTC (rev 206244)
+++ trunk/Source/_javascript_Core/runtime/VM.h	2016-09-22 04:32:12 UTC (rev 206245)
@@ -616,7 +616,7 @@
 
 JS_EXPORT_PRIVATE void queueMicrotask(JSGlobalObject*, PassRefPtr);
 JS_EXPORT_PRIVATE void drainMicrotasks();
-JS_EXPORT_PRIVATE void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
+void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
 ALWAYS_INLINE bool globalConstRedeclarationShouldThrow() const { return m_globalConstRedeclarationShouldThrow; }
 
 inline bool shouldTriggerTermination(ExecState*);


Modified: trunk/Source/WTF/ChangeLog (206244 => 206245)

--- trunk/Source/WTF/ChangeLog	2016-09-22 01:23:26 UTC (rev 206244)
+++ trunk/Source/WTF/ChangeLog	2016-09-22 

[webkit-changes] [206244] trunk/Source

[bfulgham]

Title: [206244] trunk/Source








Revision 206244
Author bfulg...@apple.com
Date 2016-09-21 18:23:26 -0700 (Wed, 21 Sep 2016)


Log Message
Correct uses of 'safeCast'
https://bugs.webkit.org/show_bug.cgi?id=162301


Reviewed by Antti Koivisto.

Source/WebCore:

A number of integer calculations in BitmapImage and PDFDocumentImage
are not properly checked for overflow. Correct this.

Tested by fast/images/large-size-image-crash.html

* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::adjustSize): RELEASE_ASSERT on overflow.
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyMetadataAndNotify):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::didDecodeProperties):
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::ensureFrameAtIndexIsCached):
(WebCore::BitmapImage::frameImageAtIndex):
* platform/graphics/BitmapImage.h:
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::decodedSizeChanged):
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):

Source/WTF:

* wtf/StdLibExtras.h:
(WTF::safeCast): RELEASE_ASSERT on overflow.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StdLibExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/MemoryCache.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (206243 => 206244)

--- trunk/Source/WTF/ChangeLog	2016-09-21 23:50:24 UTC (rev 206243)
+++ trunk/Source/WTF/ChangeLog	2016-09-22 01:23:26 UTC (rev 206244)
@@ -1,3 +1,14 @@
+2016-09-20  Brent Fulgham  
+
+Correct uses of 'safeCast'
+https://bugs.webkit.org/show_bug.cgi?id=162301
+
+
+Reviewed by Antti Koivisto.
+
+* wtf/StdLibExtras.h:
+(WTF::safeCast): RELEASE_ASSERT on overflow.
+
 2016-09-21  Commit Queue  
 
 Unreviewed, rolling out r206222 and r206227.


Modified: trunk/Source/WTF/wtf/StdLibExtras.h (206243 => 206244)

--- trunk/Source/WTF/wtf/StdLibExtras.h	2016-09-21 23:50:24 UTC (rev 206243)
+++ trunk/Source/WTF/wtf/StdLibExtras.h	2016-09-22 01:23:26 UTC (rev 206244)
@@ -159,7 +159,7 @@
 template
 inline ToType safeCast(FromType value)
 {
-ASSERT(isInBounds(value));
+RELEASE_ASSERT(isInBounds(value));
 return static_cast(value);
 }
 


Modified: trunk/Source/WebCore/ChangeLog (206243 => 206244)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 23:50:24 UTC (rev 206243)
+++ trunk/Source/WebCore/ChangeLog	2016-09-22 01:23:26 UTC (rev 206244)
@@ -1,3 +1,30 @@
+2016-09-20  Brent Fulgham  
+
+Correct uses of 'safeCast'
+https://bugs.webkit.org/show_bug.cgi?id=162301
+
+
+Reviewed by Antti Koivisto.
+
+A number of integer calculations in BitmapImage and PDFDocumentImage
+are not properly checked for overflow. Correct this.
+
+Tested by fast/images/large-size-image-crash.html
+
+* loader/cache/MemoryCache.cpp:
+(WebCore::MemoryCache::adjustSize): RELEASE_ASSERT on overflow.
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::destroyMetadataAndNotify):
+(WebCore::BitmapImage::cacheFrame):
+(WebCore::BitmapImage::didDecodeProperties):
+(WebCore::BitmapImage::dataChanged):
+(WebCore::BitmapImage::ensureFrameAtIndexIsCached):
+(WebCore::BitmapImage::frameImageAtIndex):
+* platform/graphics/BitmapImage.h:
+* platform/graphics/cg/PDFDocumentImage.cpp:
+(WebCore::PDFDocumentImage::decodedSizeChanged):
+(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
+
 2016-09-21  Chris Dumez  
 
 Setting HTMLMeterElement's attributes to non-finite values throws wrong exception type


Modified: trunk/Source/WebCore/loader/cache/MemoryCache.cpp (206243 => 206244)

--- trunk/Source/WebCore/loader/cache/MemoryCache.cpp	2016-09-21 23:50:24 UTC (rev 206243)
+++ trunk/Source/WebCore/loader/cache/MemoryCache.cpp	2016-09-22 01:23:26 UTC (rev 206244)
@@ -644,10 +644,10 @@
 void MemoryCache::adjustSize(bool live, int delta)
 {
 if (live) {
-ASSERT(delta >= 0 || ((int)m_liveSize + delta >= 0));
+RELEASE_ASSERT(delta >= 0 || ((int)m_liveSize + delta >= 0));
 m_liveSize += delta;
 } else {
-ASSERT(delta >= 0 || ((int)m_deadSize + delta >= 0));
+RELEASE_ASSERT(delta >= 0 || ((int)m_deadSize + delta >= 0));
 m_deadSize += delta;
 }
 }


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (206243 => 206244)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2016-09-21 23:50:24 UTC (rev 206243)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2016-09-22 01:23:26 UTC (rev 206244)
@@ -1,6 +1,6 @@
 /*
  * Copyright (C) 2006 Samuel Weinig (sam.wei...@gmail.com)
- * Copyright (C) 2004, 2005, 2006, 2008, 2015 Apple Inc. All rights 

[webkit-changes] [206243] trunk

[cdumez]

Title: [206243] trunk








Revision 206243
Author cdu...@apple.com
Date 2016-09-21 16:50:24 -0700 (Wed, 21 Sep 2016)


Log Message
Setting HTMLMeterElement's attributes to non-finite values throws wrong exception type
https://bugs.webkit.org/show_bug.cgi?id=162364

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Merge meter test changes from https://github.com/w3c/web-platform-tests/pull/3791.

* web-platform-tests/html/semantics/forms/the-meter-element/meter-expected.txt:
* web-platform-tests/html/semantics/forms/the-meter-element/meter.html:

Source/WebCore:

Setting HTMLMeterElement's attributes to non-finite values throws wrong exception type.
It should throw a TypeError because their type is 'double' but we throw a
NOT_SUPPORTED_ERR.

Specification:
- https://html.spec.whatwg.org/#htmlmeterelement

Firefox and Chrome agree with the specification.

No new tests, updated existing test.

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::setOptimum):
* html/HTMLMeterElement.h:
* html/HTMLMeterElement.idl:

LayoutTests:

Update existing test to reflect behavior change.

* fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js:
* fast/dom/HTMLMeterElement/set-meter-properties-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js
trunk/LayoutTests/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/meter-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/meter.html
trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/the-meter-element/meter-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMeterElement.cpp
trunk/Source/WebCore/html/HTMLMeterElement.h
trunk/Source/WebCore/html/HTMLMeterElement.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (206242 => 206243)

--- trunk/LayoutTests/ChangeLog	2016-09-21 23:20:01 UTC (rev 206242)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 23:50:24 UTC (rev 206243)
@@ -1,5 +1,17 @@
 2016-09-21  Chris Dumez  
 
+Setting HTMLMeterElement's attributes to non-finite values throws wrong exception type
+https://bugs.webkit.org/show_bug.cgi?id=162364
+
+Reviewed by Darin Adler.
+
+Update existing test to reflect behavior change.
+
+* fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js:
+* fast/dom/HTMLMeterElement/set-meter-properties-expected.txt:
+
+2016-09-21  Chris Dumez  
+
 Fix serialization of HTML Element attributes
 https://bugs.webkit.org/show_bug.cgi?id=162356
 


Modified: trunk/LayoutTests/fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js (206242 => 206243)

--- trunk/LayoutTests/fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js	2016-09-21 23:20:01 UTC (rev 206242)
+++ trunk/LayoutTests/fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js	2016-09-21 23:50:24 UTC (rev 206243)
@@ -77,22 +77,22 @@
 shouldBe("m.optimum", "12.5");
 
 debug("Set value to invalid value");
-shouldThrow('m.value = "value";', '"NotSupportedError (DOM Exception 9): The operation is not supported."');
+shouldThrowErrorName('m.value = "value";', 'TypeError');
 
 debug("Set min to NaN");
-shouldThrow('m.min = NaN;', '"NotSupportedError (DOM Exception 9): The operation is not supported."');
+shouldThrowErrorName('m.min = NaN;', 'TypeError');
 
 debug("Set max to Infinity");
-shouldThrow('m.max = Infinity;', '"NotSupportedError (DOM Exception 9): The operation is not supported."');
+shouldThrowErrorName('m.max = Infinity;', 'TypeError');
 
 debug("Set low to invalid value");
-shouldThrow('m.low = "low";', '"NotSupportedError (DOM Exception 9): The operation is not supported."');
+shouldThrowErrorName('m.low = "low";', 'TypeError');
 
 debug("Set high to NaN");
-shouldThrow('m.high = NaN;', '"NotSupportedError (DOM Exception 9): The operation is not supported."');
+shouldThrowErrorName('m.high = NaN;', 'TypeError');
 
 debug("Set optimum to Infinity");
-shouldThrow('m.optimum = Infinity;', '"NotSupportedError (DOM Exception 9): The operation is not supported."');
+shouldThrowErrorName('m.optimum = Infinity;', 'TypeError');
 
 debug("Set attributes to valid numbers");
 m.setAttribute("min", 0);


Modified: trunk/LayoutTests/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt (206242 => 206243)

--- trunk/LayoutTests/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt	2016-09-21 23:20:01 UTC (rev 206242)
+++ trunk/LayoutTests/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt	2016-09-21 

[webkit-changes] [206242] trunk/Source/WebCore

[andersca]

Title: [206242] trunk/Source/WebCore








Revision 206242
Author ander...@apple.com
Date 2016-09-21 16:20:01 -0700 (Wed, 21 Sep 2016)


Log Message
Fix open source build.

* platform/spi/cocoa/PassKitSPI.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (206241 => 206242)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 23:08:52 UTC (rev 206241)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 23:20:01 UTC (rev 206242)
@@ -1,3 +1,9 @@
+2016-09-21  Anders Carlsson  
+
+Fix open source build.
+
+* platform/spi/cocoa/PassKitSPI.h:
+
 2016-09-21  Chris Dumez  
 
 Fix serialization of HTML Element attributes


Modified: trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h (206241 => 206242)

--- trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h	2016-09-21 23:08:52 UTC (rev 206241)
+++ trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h	2016-09-21 23:20:01 UTC (rev 206242)
@@ -211,6 +211,9 @@
 - (void)paymentAuthorizationViewController:(PKPaymentAuthorizationViewController *)controller didRequestMerchantSession:(void(^)(PKPaymentMerchantSession *, NSError *))sessionBlock;
 @end
 
+@interface PKPassLibrary : NSObject
+@end
+
 NS_ASSUME_NONNULL_END
 
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206241] trunk/Source/WebCore

[andersca]

Title: [206241] trunk/Source/WebCore








Revision 206241
Author ander...@apple.com
Date 2016-09-21 16:08:52 -0700 (Wed, 21 Sep 2016)


Log Message
Fix spelling errors (that were supposed to be part of my previous commit).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206240 => 206241)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 22:52:42 UTC (rev 206240)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 23:08:52 UTC (rev 206241)
@@ -31,7 +31,7 @@
 
 * Modules/applepay/ApplePaySession.cpp:
 (WebCore::ApplePaySession::openPaymentSetup):
-Perform security checks and then call into the PaymentCoordiantor. In its completion handler, we resolve the promise.
+Perform security checks and then call into the PaymentCoordinator. In its completion handler, we resolve the promise.
 
 * Modules/applepay/ApplePaySession.h:
 Add new members.


Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp (206240 => 206241)

--- trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp	2016-09-21 22:52:42 UTC (rev 206240)
+++ trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp	2016-09-21 23:08:52 UTC (rev 206241)
@@ -776,7 +776,7 @@
 }
 
 if (!ScriptController::processingUserGesture()) {
-window.printErrorMessage("Must call ApplePaySession.openPaymemntSetup from a user gesture handler.");
+window.printErrorMessage("Must call ApplePaySession.openPaymentSetup from a user gesture handler.");
 ec = INVALID_ACCESS_ERR;
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206240] trunk

[cdumez]

Title: [206240] trunk








Revision 206240
Author cdu...@apple.com
Date 2016-09-21 15:52:42 -0700 (Wed, 21 Sep 2016)


Log Message
Fix serialization of HTML Element attributes
https://bugs.webkit.org/show_bug.cgi?id=162356

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt:
* web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:

Source/WebCore:

Fix serialization of HTML Element attributes to align with:
- https://html.spec.whatwg.org/#html-fragment-serialisation-algorithm
- https://html.spec.whatwg.org/#escapingString

In particular, we should not escape '<' and '>'.

Firefox and Chrome both match the specification.

Note that we keep escaping '<' and '>' for Element attributes in the
context of XML serialization, as per:
- https://w3c.github.io/DOM-Parsing/#dfn-serializing-an-attribute-value

No new tests, rebaselined existing test.

* editing/MarkupAccumulator.h:

LayoutTests:

Rebaseline test to reflect behavior change.

* editing/pasteboard/paste-noscript-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/paste-noscript-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/MarkupAccumulator.h




Diff

Modified: trunk/LayoutTests/ChangeLog (206239 => 206240)

--- trunk/LayoutTests/ChangeLog	2016-09-21 22:52:37 UTC (rev 206239)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 22:52:42 UTC (rev 206240)
@@ -1,3 +1,14 @@
+2016-09-21  Chris Dumez  
+
+Fix serialization of HTML Element attributes
+https://bugs.webkit.org/show_bug.cgi?id=162356
+
+Reviewed by Alex Christensen.
+
+Rebaseline test to reflect behavior change.
+
+* editing/pasteboard/paste-noscript-expected.txt:
+
 2016-09-21  Matt Baker  
 
 Web Inspector: Improve output of TestHarness.expect* failures


Modified: trunk/LayoutTests/editing/pasteboard/paste-noscript-expected.txt (206239 => 206240)

--- trunk/LayoutTests/editing/pasteboard/paste-noscript-expected.txt	2016-09-21 22:52:37 UTC (rev 206239)
+++ trunk/LayoutTests/editing/pasteboard/paste-noscript-expected.txt	2016-09-21 22:52:42 UTC (rev 206240)
@@ -15,7 +15,7 @@
 Hello
 
 
-
+
 
 This is a formSubmit.
 This is a form

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206239 => 206240)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-21 22:52:37 UTC (rev 206239)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-21 22:52:42 UTC (rev 206240)
@@ -1,5 +1,17 @@
 2016-09-21  Chris Dumez  
 
+Fix serialization of HTML Element attributes
+https://bugs.webkit.org/show_bug.cgi?id=162356
+
+Reviewed by Alex Christensen.
+
+Rebaseline W3C test now that more checks are passing.
+
+* web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt:
+* web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:
+
+2016-09-21  Chris Dumez  
+
 Fix enumeration of properties cross origin
 https://bugs.webkit.org/show_bug.cgi?id=162328
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt (206239 => 206240)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt	2016-09-21 22:52:37 UTC (rev 206239)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt	2016-09-21 22:52:42 UTC (rev 206240)
@@ -10,7 +10,7 @@
 FAIL  assert_equals: naturalWidth expected 512 but got 256
 FAIL  assert_equals: naturalWidth expected 1 but got 256
 FAIL  assert_equals: naturalWidth expected 0 but got 256
-PASS  
-PASS  
-PASS  
+PASS  
+PASS  
+PASS  
   


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt (206239 => 206240)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt	2016-09-21 22:52:37 UTC (rev 206239)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt	2016-09-21 22:52:42 UTC (rev 206240)
@@ -6,8 +6,8 @@
 PASS innerHTML 4  
 PASS innerHTML 5  
 PASS innerHTML 6  
-FAIL innerHTML 7  assert_equals: expected "" but got ""
-FAIL 

[webkit-changes] [206239] trunk/Source/JavaScriptCore

[commit-queue]

Title: [206239] trunk/Source/_javascript_Core








Revision 206239
Author commit-qu...@webkit.org
Date 2016-09-21 15:52:37 -0700 (Wed, 21 Sep 2016)


Log Message
Inline function only used in one place
https://bugs.webkit.org/show_bug.cgi?id=162363

Patch by Joseph Pecoraro  on 2016-09-21
Reviewed by Saam Barati.

* bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForInNode::emitMultiLoopBytecode):
* parser/Nodes.h:
No need for the extra function, it adds no clarification.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/parser/Nodes.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (206238 => 206239)

--- trunk/Source/_javascript_Core/ChangeLog	2016-09-21 22:51:52 UTC (rev 206238)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-21 22:52:37 UTC (rev 206239)
@@ -1,3 +1,16 @@
+2016-09-21  Joseph Pecoraro  
+
+Inline function only used in one place
+https://bugs.webkit.org/show_bug.cgi?id=162363
+
+Reviewed by Saam Barati.
+
+* bytecompiler/NodesCodegen.cpp:
+(JSC::ForInNode::emitBytecode):
+(JSC::ForInNode::emitMultiLoopBytecode):
+* parser/Nodes.h:
+No need for the extra function, it adds no clarification.
+
 2016-09-21  Commit Queue  
 
 Unreviewed, rolling out r206222 and r206227.


Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (206238 => 206239)

--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp	2016-09-21 22:51:52 UTC (rev 206238)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp	2016-09-21 22:52:37 UTC (rev 206239)
@@ -2685,7 +2685,7 @@
 RELEASE_ASSERT_NOT_REACHED();
 }
 
-void ForInNode::emitMultiLoopBytecode(BytecodeGenerator& generator, RegisterID* dst)
+void ForInNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
 {
 if (!m_lexpr->isAssignResolveNode() && !m_lexpr->isAssignmentLocation()) {
 emitThrowReferenceError(generator, ASCIILiteral("Left side of for-in statement is not a reference."));
@@ -2835,11 +2835,6 @@
 generator.emitProfileControlFlow(profilerEndOffset);
 }
 
-void ForInNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
-{
-this->emitMultiLoopBytecode(generator, dst);
-}
-
 // -- ForOfNode 
 void ForOfNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
 {


Modified: trunk/Source/_javascript_Core/parser/Nodes.h (206238 => 206239)

--- trunk/Source/_javascript_Core/parser/Nodes.h	2016-09-21 22:51:52 UTC (rev 206238)
+++ trunk/Source/_javascript_Core/parser/Nodes.h	2016-09-21 22:52:37 UTC (rev 206239)
@@ -1475,7 +1475,6 @@
 private:
 RegisterID* tryGetBoundLocal(BytecodeGenerator&);
 void emitLoopHeader(BytecodeGenerator&, RegisterID* propertyName);
-void emitMultiLoopBytecode(BytecodeGenerator&, RegisterID* dst);
 
 void emitBytecode(BytecodeGenerator&, RegisterID* = 0) override;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206238] trunk/Source

[andersca]

Title: [206238] trunk/Source








Revision 206238
Author ander...@apple.com
Date 2016-09-21 15:51:52 -0700 (Wed, 21 Sep 2016)


Log Message
Source/WebCore:
support openPaymentSetup API on ApplePaySession object
https://bugs.webkit.org/show_bug.cgi?id=162357
rdar://problem/26776939

Reviewed by Tim Horton.

* Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::openPaymentSetup):
Perform security checks and then call into the PaymentCoordiantor. In its completion handler, we resolve the promise.

* Modules/applepay/ApplePaySession.h:
Add new members.

* Modules/applepay/ApplePaySession.idl:
Add openPaymentSetup declaration.

* Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::openPaymentSetup):
Call through to the clients.

* Modules/applepay/PaymentCoordinator.h:
* Modules/applepay/PaymentCoordinatorClient.h:
Add new members.

* loader/EmptyClients.cpp:
Add new stub.

* platform/spi/cocoa/PassKitSPI.h:
Add SPI declaration.

Source/WebKit/mac:
Support openPaymentSetup API on ApplePaySession object
https://bugs.webkit.org/show_bug.cgi?id=162357
rdar://problem/26776939

Reviewed by Tim Horton.

Add openPaymentSetup stub.

* WebCoreSupport/WebPaymentCoordinatorClient.h:
* WebCoreSupport/WebPaymentCoordinatorClient.mm:
(WebPaymentCoordinatorClient::openPaymentSetup):

Source/WebKit2:
support openPaymentSetup API on ApplePaySession object
https://bugs.webkit.org/show_bug.cgi?id=162357
rdar://problem/26776939

Reviewed by Tim Horton.

* UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:
(WebKit::WebPaymentCoordinatorProxy::openPaymentSetup):
Call through to platformOpenPaymentSetup, and in the completion handler, send back a OpenPaymentSetupReply message.

* UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
Add new members.

* UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:
Add OpenPaymentSetup message.

* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup):
Allocate a PKPassLibrary and call openPaymentSetupForMerchantIdentifier:domain:completion: on it.

* WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::generateOpenPaymentSetupReplyID):
New helper function to generate a reply ID.

(WebKit::WebPaymentCoordinator::openPaymentSetup):
Add the completion handler to m_pendingOpenPaymentSetupCallbacks and send a OpenPaymentSetup message to the UI process.

(WebKit::WebPaymentCoordinator::openPaymentSetupReply):
Grab the callback given its ID and invoke it.

* WebProcess/ApplePay/WebPaymentCoordinator.h:
Add new members.

* WebProcess/ApplePay/WebPaymentCoordinator.messages.in:
Add OpenPaymentSetupReply message.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp
trunk/Source/WebCore/Modules/applepay/ApplePaySession.h
trunk/Source/WebCore/Modules/applepay/ApplePaySession.idl
trunk/Source/WebCore/Modules/applepay/PaymentCoordinator.cpp
trunk/Source/WebCore/Modules/applepay/PaymentCoordinator.h
trunk/Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h
trunk/Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp
trunk/Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h
trunk/Source/WebKit2/UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in
trunk/Source/WebKit2/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm
trunk/Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp
trunk/Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.h
trunk/Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.messages.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (206237 => 206238)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 21:40:22 UTC (rev 206237)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 22:51:52 UTC (rev 206238)
@@ -1,3 +1,35 @@
+2016-09-21  Anders Carlsson  
+
+support openPaymentSetup API on ApplePaySession object
+https://bugs.webkit.org/show_bug.cgi?id=162357
+rdar://problem/26776939
+
+Reviewed by Tim Horton.
+
+* Modules/applepay/ApplePaySession.cpp:
+(WebCore::ApplePaySession::openPaymentSetup):
+Perform security checks and then call into the PaymentCoordiantor. In its completion handler, we resolve the promise.
+
+* Modules/applepay/ApplePaySession.h:
+Add new members.
+
+* Modules/applepay/ApplePaySession.idl:
+Add openPaymentSetup declaration.
+
+* Modules/applepay/PaymentCoordinator.cpp:
+(WebCore::PaymentCoordinator::openPaymentSetup):
+Call through to the clients.
+
+* Modules/applepay/PaymentCoordinator.h:
+* 

[webkit-changes] [206237] trunk

[mattbaker]

Title: [206237] trunk








Revision 206237
Author mattba...@apple.com
Date 2016-09-21 14:40:22 -0700 (Wed, 21 Sep 2016)


Log Message
Web Inspector: Improve output of TestHarness.expect* failures
https://bugs.webkit.org/show_bug.cgi?id=162177


Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

This patch adds specific expectation functions to TestHarness, to better
express intent when writing tests, and to allow more details to be logged
in the event of a failure.

For functions taking both `actual` and `expected` parameters, the `actual`
parameter comes first. This convention simplifies the implementation of
TestHarness, improves the readability of tests involving inequalities,
and is consistent with XCTest assertions.

* UserInterface/Test/TestHarness.js:
(TestHarness):
(TestHarness.prototype.expectThat):
(TestHarness.prototype.expectFalse):
(TestHarness.prototype.expectNull):
(TestHarness.prototype.expectNotNull):
(TestHarness.prototype.expectEqual):
(TestHarness.prototype.expectNotEqual):
(TestHarness.prototype.expectShallowEqual):
(TestHarness.prototype.expectNotShallowEqual):
(TestHarness.prototype.expectEqualWithAccuracy):
(TestHarness.prototype.expectLessThan):
(TestHarness.prototype.expectLessThanOrEqual):
(TestHarness.prototype.expectGreaterThan):
(TestHarness.prototype.expectGreaterThanOrEqual):
New expectation functions, all of which call _expect under the hood.

(TestHarness.prototype._expect):
Helper method which calls pass or fail. Creates a message when no user
message is provided, and logs expected and actual values in the event
of a failure.

(TestHarness.prototype._expectationValueAsString):
(TestHarness.prototype._expectationMessageFormat):
Get a message format string for the expectation type. Used to create
pass/fail message when no user message is provided.

(TestHarness.prototype._expectedValueFormat):
Get a format string for displaying the expected value. Used to create
the "Expected: " failure message line.

LayoutTests:

Extend coverage to more TestHarness messages by omitting the optional
`message` parameter when calling expect* functions.

Other improvements:
- expectEqual/expectNotEqual should test WebInspector object instances,
  to cover more TestHarness message formatting cases.
- expectEqual/expectNotEqual should test shallow equal arrays, since the
  test is for strict equality.

* inspector/indexeddb/requestData-expected.txt:
* inspector/unit-tests/number-utilities-expected.txt:
Updated expectations for new TestHarness output.

* inspector/unit-tests/test-harness-expect-functions-expected.txt:
* inspector/unit-tests/test-harness-expect-functions.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/indexeddb/requestData-expected.txt
trunk/LayoutTests/inspector/unit-tests/number-utilities-expected.txt
trunk/LayoutTests/inspector/unit-tests/test-harness-expect-functions-expected.txt
trunk/LayoutTests/inspector/unit-tests/test-harness-expect-functions.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Test/TestHarness.js




Diff

Modified: trunk/LayoutTests/ChangeLog (206236 => 206237)

--- trunk/LayoutTests/ChangeLog	2016-09-21 21:22:00 UTC (rev 206236)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 21:40:22 UTC (rev 206237)
@@ -1,3 +1,27 @@
+2016-09-21  Matt Baker  
+
+Web Inspector: Improve output of TestHarness.expect* failures
+https://bugs.webkit.org/show_bug.cgi?id=162177
+
+
+Reviewed by Joseph Pecoraro.
+
+Extend coverage to more TestHarness messages by omitting the optional
+`message` parameter when calling expect* functions.
+
+Other improvements:
+- expectEqual/expectNotEqual should test WebInspector object instances,
+  to cover more TestHarness message formatting cases.
+- expectEqual/expectNotEqual should test shallow equal arrays, since the
+  test is for strict equality.
+
+* inspector/indexeddb/requestData-expected.txt:
+* inspector/unit-tests/number-utilities-expected.txt:
+Updated expectations for new TestHarness output.
+
+* inspector/unit-tests/test-harness-expect-functions-expected.txt:
+* inspector/unit-tests/test-harness-expect-functions.html:
+
 2016-09-21  Ryan Haddad  
 
 Marking inspector/css/manager-preferredInspectorStyleSheetForFrame.html as flaky on mac.


Modified: trunk/LayoutTests/inspector/indexeddb/requestData-expected.txt (206236 => 206237)

--- trunk/LayoutTests/inspector/indexeddb/requestData-expected.txt	2016-09-21 21:22:00 UTC (rev 206236)
+++ trunk/LayoutTests/inspector/indexeddb/requestData-expected.txt	2016-09-21 21:40:22 UTC (rev 206237)
@@ -41,9 +41,13 @@
 PASS: Key should be ordered by email: 'bea...@webkit.org'
 PASS: Value should be a remote object for: 'Monstrous Beaver'
 FAIL: Primary key should be ordered by email: 2
+Expected: truthy
+Actual: false
 PASS: Key should be 

[webkit-changes] [206236] trunk

[commit-queue]

Title: [206236] trunk








Revision 206236
Author commit-qu...@webkit.org
Date 2016-09-21 14:22:00 -0700 (Wed, 21 Sep 2016)


Log Message
Unreviewed, rolling out r206222 and r206227.
https://bugs.webkit.org/show_bug.cgi?id=162361

"broke the windows build" (Requested by keith_mi_ on #webkit).

Reverted changesets:

"Fix build for future versions of Clang."
https://bugs.webkit.org/show_bug.cgi?id=162346
http://trac.webkit.org/changeset/206222

"Attempt to fix windows build after r206222."
http://trac.webkit.org/changeset/206227

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.unexp
trunk/Source/WebCore/dom/Exception.h
trunk/Source/WebCore/page/Frame.h
trunk/Source/WebCore/page/MainFrame.h
trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h
trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h
trunk/Source/WebCore/platform/graphics/Color.h
trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h
trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h
trunk/Source/WebCore/platform/network/ParsedContentRange.h
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
trunk/Source/WebCore/platform/text/TextStream.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Counters.cpp
trunk/Tools/TestWebKitAPI/Counters.h
trunk/Tools/TestWebKitAPI/Tests/WTF/HashCountedSet.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (206235 => 206236)

--- trunk/Source/_javascript_Core/ChangeLog	2016-09-21 21:16:15 UTC (rev 206235)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-21 21:22:00 UTC (rev 206236)
@@ -1,3 +1,19 @@
+2016-09-21  Commit Queue  
+
+Unreviewed, rolling out r206222 and r206227.
+https://bugs.webkit.org/show_bug.cgi?id=162361
+
+"broke the windows build" (Requested by keith_mi_ on #webkit).
+
+Reverted changesets:
+
+"Fix build for future versions of Clang."
+https://bugs.webkit.org/show_bug.cgi?id=162346
+http://trac.webkit.org/changeset/206222
+
+"Attempt to fix windows build after r206222."
+http://trac.webkit.org/changeset/206227
+
 2016-09-21  Filip Pizlo  
 
 Add a Fence opcode to B3


Modified: trunk/Source/_javascript_Core/runtime/VM.h (206235 => 206236)

--- trunk/Source/_javascript_Core/runtime/VM.h	2016-09-21 21:16:15 UTC (rev 206235)
+++ trunk/Source/_javascript_Core/runtime/VM.h	2016-09-21 21:22:00 UTC (rev 206236)
@@ -616,7 +616,7 @@
 
 JS_EXPORT_PRIVATE void queueMicrotask(JSGlobalObject*, PassRefPtr);
 JS_EXPORT_PRIVATE void drainMicrotasks();
-void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
+JS_EXPORT_PRIVATE void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
 ALWAYS_INLINE bool globalConstRedeclarationShouldThrow() const { return m_globalConstRedeclarationShouldThrow; }
 
 inline bool shouldTriggerTermination(ExecState*);


Modified: trunk/Source/WTF/ChangeLog (206235 => 206236)

--- trunk/Source/WTF/ChangeLog	2016-09-21 21:16:15 UTC (rev 206235)
+++ trunk/Source/WTF/ChangeLog	2016-09-21 21:22:00 UTC (rev 206236)
@@ -1,3 +1,19 @@
+2016-09-21  Commit Queue  
+
+Unreviewed, rolling out r206222 and r206227.
+https://bugs.webkit.org/show_bug.cgi?id=162361
+
+"broke the windows build" (Requested by keith_mi_ on #webkit).
+
+Reverted changesets:
+
+"Fix build for future versions of Clang."
+https://bugs.webkit.org/show_bug.cgi?id=162346
+http://trac.webkit.org/changeset/206222
+
+"Attempt to fix windows build after r206222."
+http://trac.webkit.org/changeset/206227
+
 2016-09-21  Keith Miller  
 
 Fix build for future versions of Clang.


Modified: trunk/Source/WTF/wtf/text/StringImpl.h (206235 => 206236)

--- trunk/Source/WTF/wtf/text/StringImpl.h	2016-09-21 21:16:15 UTC (rev 206235)
+++ trunk/Source/WTF/wtf/text/StringImpl.h	2016-09-21 21:22:00 UTC (rev 206236)
@@ -948,8 +948,8 @@
 
 bool equalIgnoringASCIICase(const StringImpl&, const StringImpl&);
 WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl*, const StringImpl*);
-bool equalIgnoringASCIICase(const StringImpl&, const char*);
-bool equalIgnoringASCIICase(const StringImpl*, const char*);
+WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl&, const char*);
+WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl*, const char*);
 
 WTF_EXPORT_STRING_API bool equalIgnoringASCIICaseNonNull(const 

[webkit-changes] [206235] trunk

[achristensen]

Title: [206235] trunk








Revision 206235
Author achristen...@apple.com
Date 2016-09-21 14:16:15 -0700 (Wed, 21 Sep 2016)


Log Message
URLParser should match URL::parse when parsing data urls with slashes in them
https://bugs.webkit.org/show_bug.cgi?id=162352

Reviewed by Darin Adler.

Source/WebCore:

Covered by new API tests.

* platform/URLParser.cpp:
(WebCore::URLParser::parse):

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206234 => 206235)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 20:53:49 UTC (rev 206234)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 21:16:15 UTC (rev 206235)
@@ -1,3 +1,15 @@
+2016-09-21  Alex Christensen  
+
+URLParser should match URL::parse when parsing data urls with slashes in them
+https://bugs.webkit.org/show_bug.cgi?id=162352
+
+Reviewed by Darin Adler.
+
+Covered by new API tests.
+
+* platform/URLParser.cpp:
+(WebCore::URLParser::parse):
+
 2016-09-21  Per Arne Vollan  
 
 [Win] Null pointer crash under WebCore::CACFLayerTreeHost::create().


Modified: trunk/Source/WebCore/platform/URLParser.cpp (206234 => 206235)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 20:53:49 UTC (rev 206234)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 21:16:15 UTC (rev 206235)
@@ -1430,6 +1430,10 @@
 m_url.m_pathEnd = m_asciiBuffer.size();
 m_url.m_queryEnd = m_url.m_pathEnd;
 state = State::Fragment;
+} else if (*c == '/') {
+m_asciiBuffer.append('/');
+m_url.m_pathAfterLastSlash = m_asciiBuffer.size();
+++c;
 } else {
 utf8PercentEncode(*c, m_asciiBuffer, isInSimpleEncodeSet);
 ++c;


Modified: trunk/Tools/ChangeLog (206234 => 206235)

--- trunk/Tools/ChangeLog	2016-09-21 20:53:49 UTC (rev 206234)
+++ trunk/Tools/ChangeLog	2016-09-21 21:16:15 UTC (rev 206235)
@@ -1,5 +1,15 @@
 2016-09-21  Alex Christensen  
 
+URLParser should match URL::parse when parsing data urls with slashes in them
+https://bugs.webkit.org/show_bug.cgi?id=162352
+
+Reviewed by Darin Adler.
+
+* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+(TestWebKitAPI::TEST_F):
+
+2016-09-21  Alex Christensen  
+
 URLParser should fail when parsing invalid relative URLs with no schemes
 https://bugs.webkit.org/show_bug.cgi?id=162355
 


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (206234 => 206235)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-21 20:53:49 UTC (rev 206234)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-21 21:16:15 UTC (rev 206235)
@@ -220,6 +220,8 @@
 checkURL("notspecial:/a", {"notspecial", "", "", "", 0, "/a", "", "", "notspecial:/a"});
 checkURL("notspecial:", {"notspecial", "", "", "", 0, "", "", "", "notspecial:"});
 checkURL("notspecial:/", {"notspecial", "", "", "", 0, "/", "", "", "notspecial:/"});
+checkURL("data:image/png;base64,encoded-data-follows-here", {"data", "", "", "", 0, "image/png;base64,encoded-data-follows-here", "", "", "data:image/png;base64,encoded-data-follows-here"});
+checkURL("data:image/png;base64,encoded/data-with-slash", {"data", "", "", "", 0, "image/png;base64,encoded/data-with-slash", "", "", "data:image/png;base64,encoded/data-with-slash"});
 
 // This disagrees with the web platform test for http://:@www.example.com but agrees with Chrome and URL::parse,
 // and Firefox fails the web platform test differently. Maybe the web platform test ought to be changed.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206234] trunk/Source/WebCore

[pvollan]

Title: [206234] trunk/Source/WebCore








Revision 206234
Author pvol...@apple.com
Date 2016-09-21 13:53:49 -0700 (Wed, 21 Sep 2016)


Log Message
[Win] Null pointer crash under WebCore::CACFLayerTreeHost::create().
https://bugs.webkit.org/show_bug.cgi?id=162266


Reviewed by Brent Fulgham.

Add null pointer check.

* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206233 => 206234)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 20:47:00 UTC (rev 206233)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 20:53:49 UTC (rev 206234)
@@ -1,3 +1,16 @@
+2016-09-21  Per Arne Vollan  
+
+[Win] Null pointer crash under WebCore::CACFLayerTreeHost::create().
+https://bugs.webkit.org/show_bug.cgi?id=162266
+
+
+Reviewed by Brent Fulgham.
+
+Add null pointer check.
+
+* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
+(WebCore::CACFLayerTreeHost::create):
+
 2016-09-21  Chris Dumez  
 
 Fix enumeration of properties cross origin


Modified: trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp (206233 => 206234)

--- trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp	2016-09-21 20:47:00 UTC (rev 206233)
+++ trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp	2016-09-21 20:53:49 UTC (rev 206234)
@@ -31,6 +31,7 @@
 #include "DefWndProcWindowClass.h"
 #include "FrameView.h"
 #include "LayerChangesFlusher.h"
+#include "Logging.h"
 #include "MainFrame.h"
 #include "PlatformCALayerWin.h"
 #include "PlatformLayer.h"
@@ -117,6 +118,10 @@
 if (!acceleratedCompositingAvailable())
 return nullptr;
 RefPtr host = WKCACFViewLayerTreeHost::create();
+if (!host) {
+LOG_ERROR("Failed to create layer tree host for accelerated compositing.");
+return nullptr;
+}
 host->initialize();
 return host.release();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206233] trunk

[cdumez]

Title: [206233] trunk








Revision 206233
Author cdu...@apple.com
Date 2016-09-21 13:47:00 -0700 (Wed, 21 Sep 2016)


Log Message
Fix enumeration of properties cross origin
https://bugs.webkit.org/show_bug.cgi?id=162328

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

* web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/WebCore:

All cross origin properties for Window / Location are supposed to be not enumerable:
- https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)

Therefore, there should be no properties to iterate on for cross origin Window /
Location objects.

No new tests, rebaselined existing test.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertyNames):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertyNames):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSLocationCustom.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206232 => 206233)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-21 20:40:59 UTC (rev 206232)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-21 20:47:00 UTC (rev 206233)
@@ -1,5 +1,16 @@
 2016-09-21  Chris Dumez  
 
+Fix enumeration of properties cross origin
+https://bugs.webkit.org/show_bug.cgi?id=162328
+
+Reviewed by Darin Adler.
+
+Rebaseline W3C test now that one more check is passing.
+
+* web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
+
+2016-09-21  Chris Dumez  
+
 Object.getOwnPropertyDescriptor() does not work correctly cross origin
 https://bugs.webkit.org/show_bug.cgi?id=162311
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt (206232 => 206233)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt	2016-09-21 20:40:59 UTC (rev 206232)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt	2016-09-21 20:47:00 UTC (rev 206233)
@@ -11,7 +11,7 @@
 PASS [[GetOwnProperty]] - Property descriptors for cross-origin properties should be set up correctly 
 PASS [[Delete]] Should throw on cross-origin objects 
 PASS [[DefineOwnProperty]] Should throw for cross-origin objects 
-FAIL [[Enumerate]] should return an empty iterator assert_unreached: Shouldn't have been able to enumerate href on cross-origin Location Reached unreachable code
+PASS [[Enumerate]] should return an empty iterator 
 PASS [[OwnPropertyKeys]] should return all properties from cross-origin objects 
 PASS A and B jointly observe the same identity for cross-origin Window and Location 
 PASS Cross-origin functions get local Function.prototype 


Modified: trunk/Source/WebCore/ChangeLog (206232 => 206233)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 20:40:59 UTC (rev 206232)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 20:47:00 UTC (rev 206233)
@@ -1,3 +1,23 @@
+2016-09-21  Chris Dumez  
+
+Fix enumeration of properties cross origin
+https://bugs.webkit.org/show_bug.cgi?id=162328
+
+Reviewed by Darin Adler.
+
+All cross origin properties for Window / Location are supposed to be not enumerable:
+- https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)
+
+Therefore, there should be no properties to iterate on for cross origin Window /
+Location objects.
+
+No new tests, rebaselined existing test.
+
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::JSDOMWindow::getOwnPropertyNames):
+* bindings/js/JSLocationCustom.cpp:
+(WebCore::JSLocation::getOwnPropertyNames):
+
 2016-09-21  Alex Christensen  
 
 URLParser should fail when parsing invalid relative URLs with no schemes


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (206232 => 206233)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2016-09-21 20:40:59 UTC (rev 206232)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp	2016-09-21 20:47:00 UTC (rev 206233)
@@ -339,7 +339,8 @@
 {
 JSDOMWindow* thisObject = jsCast(object);
 if (!BindingSecurity::shouldAllowAccessToDOMWindow(exec, thisObject->wrapped(), DoNotReportSecurityError)) {
-addCrossOriginWindowPropertyNames(*exec, propertyNames);
+if (mode.includeDontEnumProperties())
+addCrossOriginWindowPropertyNames(*exec, 

[webkit-changes] [206232] trunk/LayoutTests

[ryanhaddad]

Title: [206232] trunk/LayoutTests








Revision 206232
Author ryanhad...@apple.com
Date 2016-09-21 13:40:59 -0700 (Wed, 21 Sep 2016)


Log Message
Marking inspector/css/manager-preferredInspectorStyleSheetForFrame.html as flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=162305

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (206231 => 206232)

--- trunk/LayoutTests/ChangeLog	2016-09-21 20:19:07 UTC (rev 206231)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 20:40:59 UTC (rev 206232)
@@ -1,3 +1,12 @@
+2016-09-21  Ryan Haddad  
+
+Marking inspector/css/manager-preferredInspectorStyleSheetForFrame.html as flaky on mac.
+https://bugs.webkit.org/show_bug.cgi?id=162305
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2016-09-21  Chris Dumez  
 
 Object.getOwnPropertyDescriptor() does not work correctly cross origin


Modified: trunk/LayoutTests/platform/mac/TestExpectations (206231 => 206232)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-09-21 20:19:07 UTC (rev 206231)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-09-21 20:40:59 UTC (rev 206232)
@@ -1207,7 +1207,6 @@
 webkit.org/b/148636 inspector/css/createStyleSheet.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/css/get-system-fonts.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/css/getAllStyleSheets.html [ Pass Timeout ]
-webkit.org/b/148636 inspector/css/manager-preferredInspectorStyleSheetForFrame.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/css/matched-style-properties.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/css/modify-rule-selector.html [ Pass Timeout ]
 webkit.org/b/148636 inspector/css/pseudo-element-matches-for-pseudo-element-node.html [ Pass Timeout ]
@@ -1239,6 +1238,8 @@
 webkit.org/b/156634 inspector/formatting/formatting-_javascript_.html [ Pass Timeout ]
 webkit.org/b/158948 inspector/timeline [ Pass Timeout ]
 
+webkit.org/b/162305 inspector/css/manager-preferredInspectorStyleSheetForFrame.html [ Pass Failure ]
+
 # Colorspaces on CA OpenGL layers not available in Yosemite
 [ Yosemite ] fast/canvas/webgl/match-page-color-space.html [ Skip ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206231] trunk

[achristensen]

Title: [206231] trunk








Revision 206231
Author achristen...@apple.com
Date 2016-09-21 13:19:07 -0700 (Wed, 21 Sep 2016)


Log Message
URLParser should fail when parsing invalid relative URLs with no schemes
https://bugs.webkit.org/show_bug.cgi?id=162355

Reviewed by Tim Horton.

Source/WebCore:

Covered by new API tests.

* platform/URLParser.cpp:
(WebCore::copyASCIIStringUntil):
When copying from a null String, is8Bit dereferences a null pointer.  We don't want to do that.
(WebCore::URLParser::parse):
What the spec calls a "null" URL matches !url.isValid(), not url.isNull().
The former reflects whether the parsing succeeded, 
the latter whether the contained String (which could be an invalid URL) is null.

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206230 => 206231)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 19:59:47 UTC (rev 206230)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 20:19:07 UTC (rev 206231)
@@ -1,3 +1,20 @@
+2016-09-21  Alex Christensen  
+
+URLParser should fail when parsing invalid relative URLs with no schemes
+https://bugs.webkit.org/show_bug.cgi?id=162355
+
+Reviewed by Tim Horton.
+
+Covered by new API tests.
+
+* platform/URLParser.cpp:
+(WebCore::copyASCIIStringUntil):
+When copying from a null String, is8Bit dereferences a null pointer.  We don't want to do that.
+(WebCore::URLParser::parse):
+What the spec calls a "null" URL matches !url.isValid(), not url.isNull().
+The former reflects whether the parsing succeeded, 
+the latter whether the contained String (which could be an invalid URL) is null.
+
 2016-09-21  Antti Koivisto  
 
 Document::styleResolverChanged simplification


Modified: trunk/Source/WebCore/platform/URLParser.cpp (206230 => 206231)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 19:59:47 UTC (rev 206230)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 20:19:07 UTC (rev 206231)
@@ -705,6 +705,11 @@
 
 inline static void copyASCIIStringUntil(Vector& destination, const String& string, size_t lengthIf8Bit, size_t lengthIf16Bit)
 {
+if (string.isNull()) {
+ASSERT(!lengthIf8Bit);
+ASSERT(!lengthIf16Bit);
+return;
+}
 ASSERT(destination.isEmpty());
 if (string.is8Bit()) {
 RELEASE_ASSERT(lengthIf8Bit <= string.length());
@@ -1069,7 +1074,7 @@
 break;
 case State::NoScheme:
 LOG_STATE("NoScheme");
-if (base.isNull() || (base.m_cannotBeABaseURL && *c != '#'))
+if (!base.isValid() || (base.m_cannotBeABaseURL && *c != '#'))
 return failure(input, length);
 if (base.m_cannotBeABaseURL && *c == '#') {
 copyURLPartsUntil(base, URLPart::QueryEnd);
@@ -1240,7 +1245,7 @@
 ++c;
 break;
 case '?':
-if (!base.isNull() && base.protocolIs("file"))
+if (base.isValid() && base.protocolIs("file"))
 copyURLPartsUntil(base, URLPart::PathEnd);
 m_asciiBuffer.append("///?", 4);
 m_url.m_userStart = m_asciiBuffer.size() - 2;
@@ -1254,7 +1259,7 @@
 ++c;
 break;
 case '#':
-if (!base.isNull() && base.protocolIs("file"))
+if (base.isValid() && base.protocolIs("file"))
 copyURLPartsUntil(base, URLPart::QueryEnd);
 m_asciiBuffer.append("///#", 4);
 m_url.m_userStart = m_asciiBuffer.size() - 2;
@@ -1269,7 +1274,7 @@
 ++c;
 break;
 default:
-if (!base.isNull() && base.protocolIs("file") && shouldCopyFileURL(c))
+if (base.isValid() && base.protocolIs("file") && shouldCopyFileURL(c))
 copyURLPartsUntil(base, URLPart::PathAfterLastSlash);
 else {
 m_asciiBuffer.append("///", 3);
@@ -1299,7 +1304,7 @@
 state = State::FileHost;
 break;
 }
-if (!base.isNull() && base.protocolIs("file")) {
+if (base.isValid() && base.protocolIs("file")) {
 // FIXME: This String copy is unnecessary.
 String basePath = base.path();
 if (basePath.length() >= 2) {
@@ -1459,7 +1464,7 @@
 switch (state) {
 case State::SchemeStart:
 LOG_FINAL_STATE("SchemeStart");
-if (!m_asciiBuffer.size() && !base.isNull())
+if (!m_asciiBuffer.size() && base.isValid())
 return base;
 return failure(input, length);
 case 

[webkit-changes] [206230] trunk/Source/WebCore

[antti]

Title: [206230] trunk/Source/WebCore








Revision 206230
Author an...@apple.com
Date 2016-09-21 12:59:47 -0700 (Wed, 21 Sep 2016)


Log Message
Document::styleResolverChanged simplification
https://bugs.webkit.org/show_bug.cgi?id=162347

Reviewed by Anders Carlsson.

* dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::setParsing):
(WebCore::Document::write):
(WebCore::Document::styleResolverChanged):

- Remove unncessary AnimationUpdateBlock, it is created by recalcStyle.
- Remove explicit setNeedsLayoutAndPrefWidthsRecalc/scheduleRelayout calls, style resolution
  invalidates those as needed.
- Remove evaluateMediaQueryList call, that is done on layout as needed.
- Remove the ancient INSTRUMENT_LAYOUT_SCHEDULING and the related printfs.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206229 => 206230)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 19:42:49 UTC (rev 206229)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 19:59:47 UTC (rev 206230)
@@ -1,3 +1,22 @@
+2016-09-21  Antti Koivisto  
+
+Document::styleResolverChanged simplification
+https://bugs.webkit.org/show_bug.cgi?id=162347
+
+Reviewed by Anders Carlsson.
+
+* dom/Document.cpp:
+(WebCore::Document::implicitClose):
+(WebCore::Document::setParsing):
+(WebCore::Document::write):
+(WebCore::Document::styleResolverChanged):
+
+- Remove unncessary AnimationUpdateBlock, it is created by recalcStyle.
+- Remove explicit setNeedsLayoutAndPrefWidthsRecalc/scheduleRelayout calls, style resolution
+  invalidates those as needed.
+- Remove evaluateMediaQueryList call, that is done on layout as needed.
+- Remove the ancient INSTRUMENT_LAYOUT_SCHEDULING and the related printfs.
+
 2016-09-21  Keith Miller  
 
 Attempt to fix windows build after r206222.


Modified: trunk/Source/WebCore/dom/Document.cpp (206229 => 206230)

--- trunk/Source/WebCore/dom/Document.cpp	2016-09-21 19:42:49 UTC (rev 206229)
+++ trunk/Source/WebCore/dom/Document.cpp	2016-09-21 19:59:47 UTC (rev 206230)
@@ -274,8 +274,6 @@
 
 using namespace HTMLNames;
 
-// #define INSTRUMENT_LAYOUT_SCHEDULING 1
-
 static const unsigned cMaxWriteRecursionDepth = 21;
 
 // DOM Level 2 says (letters added):
@@ -2751,10 +2749,6 @@
 
 if (f)
 f->loader().dispatchOnloadEvents();
-#ifdef INSTRUMENT_LAYOUT_SCHEDULING
-if (!ownerElement())
-printf("onload fired at %lld\n", elapsedTime().count());
-#endif
 
 // An event handler may have removed the frame
 if (!frame()) {
@@ -2824,11 +2818,6 @@
 
 if (!m_bParsing && view() && !view()->needsLayout())
 view()->fireLayoutRelatedMilestonesIfNeeded();
-
-#ifdef INSTRUMENT_LAYOUT_SCHEDULING
-if (!ownerElement() && !m_bParsing)
-printf("Parsing finished at %lld\n", elapsedTime().count());
-#endif
 }
 
 bool Document::shouldScheduleLayout()
@@ -2877,11 +2866,6 @@
 if (m_writeRecursionIsTooDeep)
return;
 
-#ifdef INSTRUMENT_LAYOUT_SCHEDULING
-if (!ownerElement())
-printf("Beginning a document.write at %lld\n", elapsedTime().count());
-#endif
-
 bool hasInsertionPoint = m_parser && m_parser->hasInsertionPoint();
 if (!hasInsertionPoint && (m_ignoreOpensDuringUnloadCount || m_ignoreDestructiveWriteCount))
 return;
@@ -2891,11 +2875,6 @@
 
 ASSERT(m_parser);
 m_parser->insert(text);
-
-#ifdef INSTRUMENT_LAYOUT_SCHEDULING
-if (!ownerElement())
-printf("Ending a document.write at %lld\n", elapsedTime().count());
-#endif
 }
 
 void Document::write(const String& text, Document* ownerDocument)
@@ -3658,11 +3637,6 @@
 }
 m_didCalculateStyleResolver = true;
 
-#ifdef INSTRUMENT_LAYOUT_SCHEDULING
-if (!ownerElement())
-printf("Beginning update of style selector at time %lld.\n", elapsedTime().count());
-#endif
-
 auto styleSheetUpdate = (updateFlag == RecalcStyleIfNeeded || updateFlag == DeferRecalcStyleIfNeeded)
 ? AuthorStyleSheets::OptimizedUpdate
 : AuthorStyleSheets::FullUpdate;
@@ -3679,28 +3653,8 @@
 return;
 }
 
-if (!stylesheetChangeRequiresStyleRecalc)
-return;
-
-// This recalcStyle initiates a new recalc cycle. We need to bracket it to
-// make sure animations get the correct update time
-{
-AnimationUpdateBlock animationUpdateBlock(m_frame ? _frame->animation() : nullptr);
+if (stylesheetChangeRequiresStyleRecalc)
 recalcStyle(Style::Force);
-}
-
-#ifdef INSTRUMENT_LAYOUT_SCHEDULING
-if (!ownerElement())
-printf("Finished update of style selector at time %lld\n", elapsedTime().count());
-#endif
-
-if (renderView()) {
-renderView()->setNeedsLayoutAndPrefWidthsRecalc();
-if (view())
-

[webkit-changes] [206229] trunk/Source

[bshafiei]

Title: [206229] trunk/Source








Revision 206229
Author bshaf...@apple.com
Date 2016-09-21 12:42:49 -0700 (Wed, 21 Sep 2016)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (206228 => 206229)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2016-09-21 19:38:39 UTC (rev 206228)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2016-09-21 19:42:49 UTC (rev 206229)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (206228 => 206229)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2016-09-21 19:38:39 UTC (rev 206228)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2016-09-21 19:42:49 UTC (rev 206229)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (206228 => 206229)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-09-21 19:38:39 UTC (rev 206228)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2016-09-21 19:42:49 UTC (rev 206229)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (206228 => 206229)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2016-09-21 19:38:39 UTC (rev 206228)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2016-09-21 19:42:49 UTC (rev 206229)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (206228 => 206229)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2016-09-21 19:38:39 UTC (rev 206228)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2016-09-21 19:42:49 UTC (rev 206229)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 603;
 MINOR_VERSION = 1;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206228] tags/Safari-603.1.6/

[bshafiei]

Title: [206228] tags/Safari-603.1.6/








Revision 206228
Author bshaf...@apple.com
Date 2016-09-21 12:38:39 -0700 (Wed, 21 Sep 2016)


Log Message
New tag.

Added Paths

tags/Safari-603.1.6/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206227] trunk/Source/WebCore

[keith_miller]

Title: [206227] trunk/Source/WebCore








Revision 206227
Author keith_mil...@apple.com
Date 2016-09-21 12:33:05 -0700 (Wed, 21 Sep 2016)


Log Message
Attempt to fix windows build after r206222.

* page/MainFrame.h:
(WebCore::Frame::isMainFrame):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/MainFrame.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (206226 => 206227)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 19:09:24 UTC (rev 206226)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 19:33:05 UTC (rev 206227)
@@ -1,3 +1,10 @@
+2016-09-21  Keith Miller  
+
+Attempt to fix windows build after r206222.
+
+* page/MainFrame.h:
+(WebCore::Frame::isMainFrame):
+
 2016-09-21  Keith Rollin  
 
 New DocumentLoader logging causes crashes


Modified: trunk/Source/WebCore/page/MainFrame.h (206226 => 206227)

--- trunk/Source/WebCore/page/MainFrame.h	2016-09-21 19:09:24 UTC (rev 206226)
+++ trunk/Source/WebCore/page/MainFrame.h	2016-09-21 19:33:05 UTC (rev 206227)
@@ -89,7 +89,7 @@
 #endif
 };
 
-inline bool Frame::isMainFrame() const
+ALWAYS_INLINE bool Frame::isMainFrame() const
 {
 return this == _mainFrame;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206226] trunk

[fpizlo]

Title: [206226] trunk








Revision 206226
Author fpi...@apple.com
Date 2016-09-21 12:09:24 -0700 (Wed, 21 Sep 2016)


Log Message
Add a Fence opcode to B3
https://bugs.webkit.org/show_bug.cgi?id=162343

Reviewed by Geoffrey Garen.
Source/_javascript_Core:


This adds the most basic fence support to B3. Currently, this is optimal on x86 and correct
on ARM. It also happens to be sufficient and optimal for what we'll do in the concurrent GC.

The idea of Fence is that it can represent any standalone fence instruction by having two
additional params: a read range and a write range. If the write range is empty, this is
taken to be a store-store fence, which turns into zero code on x86 and a cheaper fence on
ARM.

It turns out that this is powerful enough to express store-load and store-store fences. For
load-store and load-load fences, you wouldn't have wanted to use any code on x86 and you
wouldn't have wanted a standalone barrier on ARM. For those cases, you'd want either a
fenced load (load acquire) or a dependency. See bug 162349 and bug 162350, respectively.

This isn't yet optimized for store-store fences on ARM because we don't have the
MacroAssembler support. Also, the support for "dmb ish" is not really what we want (it seems
to use a heavier fence). I don't think that this is urgent because of how the concurrent GC
will use this facility. I've left that to bug 162342.

* CMakeLists.txt:
* _javascript_Core.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerCodeRef.cpp:
(JSC::MacroAssemblerCodeRef::tryToDisassemble):
(JSC::MacroAssemblerCodeRef::disassembly):
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::size): Deleted.
(JSC::MacroAssemblerCodeRef::tryToDisassemble): Deleted.
* b3/B3Compilation.h:
(JSC::B3::Compilation::codeRef):
(JSC::B3::Compilation::disassembly):
(JSC::B3::Compilation::code): Deleted.
* b3/B3Effects.h:
* b3/B3FenceValue.cpp: Added.
(JSC::B3::FenceValue::~FenceValue):
(JSC::B3::FenceValue::cloneImpl):
(JSC::B3::FenceValue::FenceValue):
* b3/B3FenceValue.h: Added.
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
* b3/B3Opcode.cpp:
(WTF::printInternal):
* b3/B3Opcode.h:
* b3/B3Validate.cpp:
* b3/B3Value.cpp:
(JSC::B3::Value::effects):
* b3/air/AirOpcode.opcodes:
* b3/testb3.cpp:
(JSC::B3::checkUsesInstruction):
(JSC::B3::checkDoesNotUseInstruction):
(JSC::B3::testX86MFence):
(JSC::B3::testX86CompilerFence):
(JSC::B3::run):

Websites/webkit.org:


* docs/b3/intermediate-representation.html:

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h
trunk/Source/_javascript_Core/b3/B3Compilation.h
trunk/Source/_javascript_Core/b3/B3Effects.h
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/B3MemoryValue.h
trunk/Source/_javascript_Core/b3/B3Opcode.cpp
trunk/Source/_javascript_Core/b3/B3Opcode.h
trunk/Source/_javascript_Core/b3/B3Validate.cpp
trunk/Source/_javascript_Core/b3/B3Value.cpp
trunk/Source/_javascript_Core/b3/air/AirOpcode.opcodes
trunk/Source/_javascript_Core/b3/testb3.cpp
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/docs/b3/intermediate-representation.html


Added Paths

trunk/Source/_javascript_Core/b3/B3FenceValue.cpp
trunk/Source/_javascript_Core/b3/B3FenceValue.h




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (206225 => 206226)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2016-09-21 18:42:21 UTC (rev 206225)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2016-09-21 19:09:24 UTC (rev 206226)
@@ -125,6 +125,7 @@
 b3/B3DuplicateTails.cpp
 b3/B3Effects.cpp
 b3/B3EliminateCommonSubexpressions.cpp
+b3/B3FenceValue.cpp
 b3/B3FixSSA.cpp
 b3/B3FoldPathConstants.cpp
 b3/B3FrequencyClass.cpp


Modified: trunk/Source/_javascript_Core/ChangeLog (206225 => 206226)

--- trunk/Source/_javascript_Core/ChangeLog	2016-09-21 18:42:21 UTC (rev 206225)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-21 19:09:24 UTC (rev 206226)
@@ -1,3 +1,62 @@
+2016-09-21  Filip Pizlo  
+
+Add a Fence opcode to B3
+https://bugs.webkit.org/show_bug.cgi?id=162343
+
+Reviewed by Geoffrey Garen.
+
+This adds the most basic fence support to B3. Currently, this is optimal on x86 and correct
+on ARM. It also happens to be sufficient and optimal for what we'll do in the concurrent GC.
+
+The idea of Fence is that it can represent any standalone fence instruction by having two
+additional params: a read range and a write range. If the write range is empty, this is
+taken to be a store-store fence, which turns into zero code on x86 and a cheaper fence on
+ARM.
+
+It turns out that this is 

[webkit-changes] [206225] releases/WebKitGTK/webkit-2.14/Source/WebKit2

[gns]

Title: [206225] releases/WebKitGTK/webkit-2.14/Source/WebKit2








Revision 206225
Author g...@gnome.org
Date 2016-09-21 11:42:21 -0700 (Wed, 21 Sep 2016)


Log Message
Merge 206216 - Unreviewed, build fix.

* UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
(WebKit::AcceleratedBackingStoreWayland::paint): fix usage of deviceScaleFactor variable which was
removed.

Modified Paths

releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog (206224 => 206225)

--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog	2016-09-21 18:41:07 UTC (rev 206224)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog	2016-09-21 18:42:21 UTC (rev 206225)
@@ -1,3 +1,11 @@
+2016-09-21  Gustavo Noronha Silva  
+
+Unreviewed, build fix.
+
+* UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
+(WebKit::AcceleratedBackingStoreWayland::paint): fix usage of deviceScaleFactor variable which was
+removed.
+
 2016-09-20  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.14.0 release.


Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp (206224 => 206225)

--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp	2016-09-21 18:41:07 UTC (rev 206224)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp	2016-09-21 18:42:21 UTC (rev 206225)
@@ -117,7 +117,7 @@
 
 // The compositor renders the texture flipped for gdk_cairo_draw_from_gl, fix that here.
 cairo_matrix_t transform;
-cairo_matrix_init(, 1, 0, 0, -1, 0, textureSize.height() / deviceScaleFactor);
+cairo_matrix_init(, 1, 0, 0, -1, 0, textureSize.height() / m_webPage.deviceScaleFactor());
 cairo_transform(cr, );
 
 cairo_rectangle(cr, clipRect.x(), clipRect.y(), clipRect.width(), clipRect.height());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206224] trunk/Source/WebCore

[cdumez]

Title: [206224] trunk/Source/WebCore








Revision 206224
Author cdu...@apple.com
Date 2016-09-21 11:41:07 -0700 (Wed, 21 Sep 2016)


Log Message
New DocumentLoader logging causes crashes
https://bugs.webkit.org/show_bug.cgi?id=162348


Patch by Keith Rollin  on 2016-09-21
Reviewed by Chris Dumez

Check for NULL m_frame before using it.

No new tests -- no tests for logging, though this issue was found by
contentfiltering/block-after-will-send-request-then-allow-unblock.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206223 => 206224)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 18:33:30 UTC (rev 206223)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 18:41:07 UTC (rev 206224)
@@ -1,3 +1,19 @@
+2016-09-21  Keith Rollin  
+
+New DocumentLoader logging causes crashes
+https://bugs.webkit.org/show_bug.cgi?id=162348
+
+
+Reviewed by Chris Dumez
+
+Check for NULL m_frame before using it.
+
+No new tests -- no tests for logging, though this issue was found by
+contentfiltering/block-after-will-send-request-then-allow-unblock.html
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::startLoadingMainResource):
+
 2016-09-21  Alex Christensen  
 
 Optimize URLParser


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (206223 => 206224)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2016-09-21 18:33:30 UTC (rev 206223)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2016-09-21 18:41:07 UTC (rev 206224)
@@ -1474,7 +1474,7 @@
 m_loadingMainResource = true;
 
 if (maybeLoadEmpty()) {
-RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Returning empty document (frame = %p, main = %d)", m_frame, m_frame->isMainFrame());
+RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Returning empty document (frame = %p, main = %d)", m_frame, m_frame ? m_frame->isMainFrame() : false);
 return;
 }
 
@@ -1496,7 +1496,7 @@
 
 // willSendRequest() may lead to our Frame being detached or cancelling the load via nulling the ResourceRequest.
 if (!m_frame || m_request.isNull()) {
-RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Load canceled after willSendRequest (frame = %p, main = %d)", m_frame, m_frame->isMainFrame());
+RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Load canceled after willSendRequest (frame = %p, main = %d)", m_frame, m_frame ? m_frame->isMainFrame() : false);
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206223] trunk/Source/WebCore

[achristensen]

Title: [206223] trunk/Source/WebCore








Revision 206223
Author achristen...@apple.com
Date 2016-09-21 11:33:30 -0700 (Wed, 21 Sep 2016)


Log Message
Optimize URLParser
https://bugs.webkit.org/show_bug.cgi?id=162338

Reviewed by Tim Horton.

No change in behavior. Just a marginal performance improvement.

* platform/URLParser.cpp:
(WebCore::isValidSchemeCharacter):
Added to reduce branches when parsing the scheme of a URL.  Now there is a table lookup instead of many range checks.
(WebCore::URLParser::parse):
Use appendVector, which uses memcpy.
(WebCore::URLParser::parseHostAndPort):
If we know that we are parsing the serialized output of a valid URL, 
we do not need to convert host characters to lower case.
They are already lower case.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206222 => 206223)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 18:24:43 UTC (rev 206222)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 18:33:30 UTC (rev 206223)
@@ -1,3 +1,22 @@
+2016-09-21  Alex Christensen  
+
+Optimize URLParser
+https://bugs.webkit.org/show_bug.cgi?id=162338
+
+Reviewed by Tim Horton.
+
+No change in behavior. Just a marginal performance improvement.
+
+* platform/URLParser.cpp:
+(WebCore::isValidSchemeCharacter):
+Added to reduce branches when parsing the scheme of a URL.  Now there is a table lookup instead of many range checks.
+(WebCore::URLParser::parse):
+Use appendVector, which uses memcpy.
+(WebCore::URLParser::parseHostAndPort):
+If we know that we are parsing the serialized output of a valid URL, 
+we do not need to convert host characters to lower case.
+They are already lower case.
+
 2016-09-21  Keith Miller  
 
 Fix build for future versions of Clang.


Modified: trunk/Source/WebCore/platform/URLParser.cpp (206222 => 206223)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 18:24:43 UTC (rev 206222)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 18:33:30 UTC (rev 206223)
@@ -129,6 +129,7 @@
 InvalidDomain = 0x4,
 QueryPercent = 0x8,
 SlashQuestionOrHash = 0x10,
+Scheme = 0x20,
 };
 
 static const uint8_t characterClassTable[256] = {
@@ -175,21 +176,21 @@
 0, // '('
 0, // ')'
 0, // '*'
-0, // '+'
+Scheme, // '+'
 0, // ','
-0, // '-'
-0, // '.'
+Scheme, // '-'
+Scheme, // '.'
 UserInfo | InvalidDomain | SlashQuestionOrHash, // '/'
-0, // '0'
-0, // '1'
-0, // '2'
-0, // '3'
-0, // '4'
-0, // '5'
-0, // '6'
-0, // '7'
-0, // '8'
-0, // '9'
+Scheme, // '0'
+Scheme, // '1'
+Scheme, // '2'
+Scheme, // '3'
+Scheme, // '4'
+Scheme, // '5'
+Scheme, // '6'
+Scheme, // '7'
+Scheme, // '8'
+Scheme, // '9'
 UserInfo | InvalidDomain, // ':'
 UserInfo, // ';'
 UserInfo | Default | QueryPercent, // '<'
@@ -197,32 +198,32 @@
 UserInfo | Default | QueryPercent, // '>'
 UserInfo | Default | InvalidDomain | SlashQuestionOrHash, // '?'
 UserInfo | InvalidDomain, // '@'
-0, // 'A'
-0, // 'B'
-0, // 'C'
-0, // 'D'
-0, // 'E'
-0, // 'F'
-0, // 'G'
-0, // 'H'
-0, // 'I'
-0, // 'J'
-0, // 'K'
-0, // 'L'
-0, // 'M'
-0, // 'N'
-0, // 'O'
-0, // 'P'
-0, // 'Q'
-0, // 'R'
-0, // 'S'
-0, // 'T'
-0, // 'U'
-0, // 'V'
-0, // 'W'
-0, // 'X'
-0, // 'Y'
-0, // 'Z'
+Scheme, // 'A'
+Scheme, // 'B'
+Scheme, // 'C'
+Scheme, // 'D'
+Scheme, // 'E'
+Scheme, // 'F'
+Scheme, // 'G'
+Scheme, // 'H'
+Scheme, // 'I'
+Scheme, // 'J'
+Scheme, // 'K'
+Scheme, // 'L'
+Scheme, // 'M'
+Scheme, // 'N'
+Scheme, // 'O'
+Scheme, // 'P'
+Scheme, // 'Q'
+Scheme, // 'R'
+Scheme, // 'S'
+Scheme, // 'T'
+Scheme, // 'U'
+Scheme, // 'V'
+Scheme, // 'W'
+Scheme, // 'X'
+Scheme, // 'Y'
+Scheme, // 'Z'
 UserInfo | InvalidDomain, // '['
 UserInfo | InvalidDomain | SlashQuestionOrHash, // '\\'
 UserInfo | InvalidDomain, // ']'
@@ -229,32 +230,32 @@
 UserInfo, // '^'
 0, // '_'
 UserInfo | Default, // '`'
-0, // 'a'
-0, // 'b'
-0, // 'c'
-0, // 'd'
-0, // 'e'
-0, // 'f'
-0, // 'g'
-0, // 'h'
-0, // 'i'
-0, // 'j'
-0, // 'k'
-0, // 'l'
-0, // 'm'
-0, // 'n'
-0, // 'o'
-0, // 'p'
-0, // 'q'
-0, // 'r'
-0, // 's'
-0, // 't'
-0, // 'u'
-0, // 'v'
-0, // 'w'
-0, // 'x'
-0, // 'y'
-0, // 'z'
+Scheme, // 'a'
+Scheme, // 'b'
+Scheme, // 'c'
+Scheme, // 'd'
+Scheme, // 'e'
+Scheme, // 'f'
+Scheme, // 'g'
+Scheme, // 'h'
+Scheme, // 'i'
+Scheme, // 'j'
+   

[webkit-changes] [206222] trunk

[keith_miller]

Title: [206222] trunk








Revision 206222
Author keith_mil...@apple.com
Date 2016-09-21 11:24:43 -0700 (Wed, 21 Sep 2016)


Log Message
Fix build for future versions of Clang.
https://bugs.webkit.org/show_bug.cgi?id=162346

Reviewed by Filip Pizlo.

Source/_javascript_Core:

This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.

* runtime/VM.h:
(JSC::VM::setGlobalConstRedeclarationShouldThrow):

Source/WebCore:

This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.

* Configurations/WebCore.unexp:
* dom/Exception.h:
* page/Frame.h:
* platform/cocoa/WebPlaybackSessionModelMediaElement.h:
* platform/cocoa/WebVideoFullscreenModelVideoElement.h:
(WebCore::WebVideoFullscreenModelVideoElement::videoElement):
* platform/graphics/Color.h:
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::rotate):
* platform/mac/WebVideoFullscreenInterfaceMac.h:
* platform/network/ParsedContentRange.h:
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::isValid):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::certificateInfo):
* platform/text/TextStream.h:
(WebCore::TextStream::increaseIndent):
(WebCore::TextStream::decreaseIndent):

Source/WTF:

This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.

* wtf/text/StringImpl.h:

Tools:

* TestWebKitAPI/Counters.cpp:
* TestWebKitAPI/Counters.h:
(DeleterCounter::deleterCount):
(DeleterCounter::TestingScope::TestingScope):
(DeleterCounter::operator()):
* TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.unexp
trunk/Source/WebCore/dom/Exception.h
trunk/Source/WebCore/page/Frame.h
trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h
trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h
trunk/Source/WebCore/platform/graphics/Color.h
trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h
trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h
trunk/Source/WebCore/platform/network/ParsedContentRange.h
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
trunk/Source/WebCore/platform/text/TextStream.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Counters.cpp
trunk/Tools/TestWebKitAPI/Counters.h
trunk/Tools/TestWebKitAPI/Tests/WTF/HashCountedSet.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (206221 => 206222)

--- trunk/Source/_javascript_Core/ChangeLog	2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-21 18:24:43 UTC (rev 206222)
@@ -1,3 +1,18 @@
+2016-09-21  Keith Miller  
+
+Fix build for future versions of Clang.
+https://bugs.webkit.org/show_bug.cgi?id=162346
+
+Reviewed by Filip Pizlo.
+
+This fixes issues with the WebCore build where inline
+template-class function definitions are marked as exported. This
+genereates a weak external symobl that our build does not like.
+
+
+* runtime/VM.h:
+(JSC::VM::setGlobalConstRedeclarationShouldThrow):
+
 2016-09-21  Chris Dumez  
 
 Object.getOwnPropertyDescriptor() does not work correctly cross origin


Modified: trunk/Source/_javascript_Core/runtime/VM.h (206221 => 206222)

--- trunk/Source/_javascript_Core/runtime/VM.h	2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/_javascript_Core/runtime/VM.h	2016-09-21 18:24:43 UTC (rev 206222)
@@ -616,7 +616,7 @@
 
 JS_EXPORT_PRIVATE void queueMicrotask(JSGlobalObject*, PassRefPtr);
 JS_EXPORT_PRIVATE void drainMicrotasks();
-JS_EXPORT_PRIVATE void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
+void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
 ALWAYS_INLINE bool globalConstRedeclarationShouldThrow() const { return m_globalConstRedeclarationShouldThrow; }
 
 inline bool shouldTriggerTermination(ExecState*);


Modified: trunk/Source/WTF/ChangeLog (206221 => 206222)

--- trunk/Source/WTF/ChangeLog	2016-09-21 18:23:33 UTC (rev 206221)
+++ trunk/Source/WTF/ChangeLog	2016-09-21 18:24:43 UTC 

[webkit-changes] [206221] trunk

[cdumez]

Title: [206221] trunk








Revision 206221
Author cdu...@apple.com
Date 2016-09-21 11:23:33 -0700 (Wed, 21 Sep 2016)


Log Message
Object.getOwnPropertyDescriptor() does not work correctly cross origin
https://bugs.webkit.org/show_bug.cgi?id=162311

Reviewed by Gavin Barraclough.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/_javascript_Core:

Add a CustomGetterSetter field to PropertySlot that gets populated
by getOwnPropertySlot() and use it in getOwnPropertyDescriptor()
to properly populate the descriptor. We used to rely on reifying
the properties and then call getDirect() in order to get the
CustomGetterSetter. However, this hack was insufficient to support
the cross-origin case because we need to control more precisely
the visibility of the getter and the setter. For example, Location's
href property has both a getter and a setter in the same origin
case but only has a setter in the cross-origin case.

In the future, we can extend the use of PropertySlot's
customGetterSetter field to the same origin case and get rid of the
reification + getDirect() hack in getOwnPropertyDescriptor().

* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::customAccessorGetter):
* runtime/PropertySlot.h:

Source/WebCore:

Object.getOwnPropertyDescriptor() does not work correctly cross origin. In particular:
- We return value descriptors for attributes instead of getter/setter descriptors
- attributes / operations are wrongly marked as non-configurable

Corresponding specification:
- https://html.spec.whatwg.org/#crossoriginproperties-(-o-)
- https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)

Test: http/tests/security/cross-origin-descriptors.html

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

Add layout test coverage.

* http/tests/security/cross-origin-descriptors-expected.txt: Added.
* http/tests/security/cross-origin-descriptors.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/PropertySlot.cpp
trunk/Source/_javascript_Core/runtime/PropertySlot.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSLocationCustom.cpp


Added Paths

trunk/LayoutTests/http/tests/security/cross-origin-descriptors-expected.txt
trunk/LayoutTests/http/tests/security/cross-origin-descriptors.html




Diff

Modified: trunk/LayoutTests/ChangeLog (206220 => 206221)

--- trunk/LayoutTests/ChangeLog	2016-09-21 18:04:39 UTC (rev 206220)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 18:23:33 UTC (rev 206221)
@@ -1,3 +1,15 @@
+2016-09-21  Chris Dumez  
+
+Object.getOwnPropertyDescriptor() does not work correctly cross origin
+https://bugs.webkit.org/show_bug.cgi?id=162311
+
+Reviewed by Gavin Barraclough.
+
+Add layout test coverage.
+
+* http/tests/security/cross-origin-descriptors-expected.txt: Added.
+* http/tests/security/cross-origin-descriptors.html: Added.
+
 2016-09-21  Daniel Bates  
 
 REGRESSION (r201090): Setting style.webkitTextSizeAdjust does not change text change on iPad


Added: trunk/LayoutTests/http/tests/security/cross-origin-descriptors-expected.txt (0 => 206221)

--- trunk/LayoutTests/http/tests/security/cross-origin-descriptors-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/cross-origin-descriptors-expected.txt	2016-09-21 18:23:33 UTC (rev 206221)
@@ -0,0 +1,86 @@
+Test the descriptors returns by Object.getOwnPropertyDescriptor() cross origin.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+* Location.href
+PASS descriptor.get is undefined.
+PASS descriptor.set is an instance of Function
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+* Location.replace
+PASS descriptor.value is an instance of Function
+PASS descriptor.writable is false
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+
+* Window.window
+PASS descriptor.get is an instance of Function
+PASS descriptor.set is undefined.
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+* Window.self
+PASS descriptor.get is an instance of Function
+PASS descriptor.set is undefined.
+PASS descriptor.enumerable is false
+PASS descriptor.configurable is true
+* Window.location
+PASS 

[webkit-changes] [206220] trunk/Tools

[achristensen]

Title: [206220] trunk/Tools








Revision 206220
Author achristen...@apple.com
Date 2016-09-21 11:04:39 -0700 (Wed, 21 Sep 2016)


Log Message
Prepare API tests for enabling URLParser by default
https://bugs.webkit.org/show_bug.cgi?id=162341

Reviewed by Tim Horton.

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::checkRelativeURLDifferences):
(TestWebKitAPI::shouldFail):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/Tools/ChangeLog (206219 => 206220)

--- trunk/Tools/ChangeLog	2016-09-21 18:02:52 UTC (rev 206219)
+++ trunk/Tools/ChangeLog	2016-09-21 18:04:39 UTC (rev 206220)
@@ -1,5 +1,19 @@
 2016-09-21  Alex Christensen  
 
+Prepare API tests for enabling URLParser by default
+https://bugs.webkit.org/show_bug.cgi?id=162341
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+(TestWebKitAPI::checkURL):
+(TestWebKitAPI::checkRelativeURL):
+(TestWebKitAPI::checkURLDifferences):
+(TestWebKitAPI::checkRelativeURLDifferences):
+(TestWebKitAPI::shouldFail):
+
+2016-09-21  Alex Christensen  
+
 URLParser: Correctly parse URLs that are just nonspecialscheme:/
 https://bugs.webkit.org/show_bug.cgi?id=162340
 


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (206219 => 206220)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-21 18:02:52 UTC (rev 206219)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-21 18:04:39 UTC (rev 206220)
@@ -59,8 +59,13 @@
 
 static void checkURL(const String& urlString, const ExpectedParts& parts)
 {
-URLParser parser;
-auto url = ""
+bool wasEnabled = URLParser::enabled();
+URLParser::setEnabled(true);
+auto url = "" urlString);
+URLParser::setEnabled(false);
+auto oldURL = URL(URL(), urlString);
+URLParser::setEnabled(wasEnabled);
+
 EXPECT_TRUE(eq(parts.protocol, url.protocol()));
 EXPECT_TRUE(eq(parts.user, url.user()));
 EXPECT_TRUE(eq(parts.password, url.pass()));
@@ -71,7 +76,6 @@
 EXPECT_TRUE(eq(parts.fragment, url.fragmentIdentifier()));
 EXPECT_TRUE(eq(parts.string, url.string()));
 
-auto oldURL = URL(URL(), urlString);
 EXPECT_TRUE(eq(parts.protocol, oldURL.protocol()));
 EXPECT_TRUE(eq(parts.user, oldURL.user()));
 EXPECT_TRUE(eq(parts.password, oldURL.pass()));
@@ -224,11 +228,13 @@
 
 static void checkRelativeURL(const String& urlString, const String& baseURLString, const ExpectedParts& parts)
 {
-URLParser baseParser;
-auto base = baseParser.parse(baseURLString);
+bool wasEnabled = URLParser::enabled();
+URLParser::setEnabled(true);
+auto url = "" baseURLString), urlString);
+URLParser::setEnabled(false);
+auto oldURL = URL(URL(URL(), baseURLString), urlString);
+URLParser::setEnabled(wasEnabled);
 
-URLParser parser;
-auto url = "" base);
 EXPECT_TRUE(eq(parts.protocol, url.protocol()));
 EXPECT_TRUE(eq(parts.user, url.user()));
 EXPECT_TRUE(eq(parts.password, url.pass()));
@@ -239,7 +245,6 @@
 EXPECT_TRUE(eq(parts.fragment, url.fragmentIdentifier()));
 EXPECT_TRUE(eq(parts.string, url.string()));
 
-auto oldURL = URL(URL(URL(), baseURLString), urlString);
 EXPECT_TRUE(eq(parts.protocol, oldURL.protocol()));
 EXPECT_TRUE(eq(parts.user, oldURL.user()));
 EXPECT_TRUE(eq(parts.password, oldURL.pass()));
@@ -314,8 +319,13 @@
 
 static void checkURLDifferences(const String& urlString, const ExpectedParts& partsNew, const ExpectedParts& partsOld)
 {
-URLParser parser;
-auto url = ""
+bool wasEnabled = URLParser::enabled();
+URLParser::setEnabled(true);
+auto url = "" urlString);
+URLParser::setEnabled(false);
+auto oldURL = URL(URL(), urlString);
+URLParser::setEnabled(wasEnabled);
+
 EXPECT_TRUE(eq(partsNew.protocol, url.protocol()));
 EXPECT_TRUE(eq(partsNew.user, url.user()));
 EXPECT_TRUE(eq(partsNew.password, url.pass()));
@@ -326,7 +336,6 @@
 EXPECT_TRUE(eq(partsNew.fragment, url.fragmentIdentifier()));
 EXPECT_TRUE(eq(partsNew.string, url.string()));
 
-auto oldURL = URL(URL(), urlString);
 EXPECT_TRUE(eq(partsOld.protocol, oldURL.protocol()));
 EXPECT_TRUE(eq(partsOld.user, oldURL.user()));
 EXPECT_TRUE(eq(partsOld.password, oldURL.pass()));
@@ -344,11 +353,13 @@
 
 static void checkRelativeURLDifferences(const String& urlString, const String& baseURLString, const ExpectedParts& partsNew, const ExpectedParts& partsOld)
 {
-URLParser baseParser;
-auto base = baseParser.parse(baseURLString);
-
-URLParser parser;
-auto url = "" base);
+bool wasEnabled = URLParser::enabled();
+URLParser::setEnabled(true);
+auto url = "" 

[webkit-changes] [206219] trunk

[achristensen]

Title: [206219] trunk








Revision 206219
Author achristen...@apple.com
Date 2016-09-21 11:02:52 -0700 (Wed, 21 Sep 2016)


Log Message
URLParser: Correctly parse URLs that are just nonspecialscheme:/
https://bugs.webkit.org/show_bug.cgi?id=162340

Reviewed by Tim Horton.

Source/WebCore:

Covered by new API tests.

* platform/URLParser.cpp:
(WebCore::URLParser::parse):
r206162 wasn't quite right.  If a url is just nonspecialscheme:/ then the path should indeed be /

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206218 => 206219)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 18:00:19 UTC (rev 206218)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 18:02:52 UTC (rev 206219)
@@ -1,5 +1,18 @@
 2016-09-21  Alex Christensen  
 
+URLParser: Correctly parse URLs that are just nonspecialscheme:/
+https://bugs.webkit.org/show_bug.cgi?id=162340
+
+Reviewed by Tim Horton.
+
+Covered by new API tests.
+
+* platform/URLParser.cpp:
+(WebCore::URLParser::parse):
+r206162 wasn't quite right.  If a url is just nonspecialscheme:/ then the path should indeed be /
+
+2016-09-21  Alex Christensen  
+
 URLParser: correctly parse relative URLs that are just one character
 https://bugs.webkit.org/show_bug.cgi?id=162344
 


Modified: trunk/Source/WebCore/platform/URLParser.cpp (206218 => 206219)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 18:00:19 UTC (rev 206218)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 18:02:52 UTC (rev 206219)
@@ -1473,11 +1473,15 @@
 break;
 case State::PathOrAuthority:
 LOG_FINAL_STATE("PathOrAuthority");
-m_url.m_userEnd = m_asciiBuffer.size();
-m_url.m_passwordEnd = m_url.m_userEnd;
-m_url.m_hostEnd = m_url.m_userEnd;
-m_url.m_portEnd = m_url.m_userEnd;
-m_url.m_pathAfterLastSlash = m_url.m_userEnd;
+ASSERT(m_url.m_userStart);
+ASSERT(m_url.m_userStart == m_asciiBuffer.size());
+ASSERT(m_asciiBuffer.last() == '/');
+m_url.m_userStart--;
+m_url.m_userEnd = m_url.m_userStart;
+m_url.m_passwordEnd = m_url.m_userStart;
+m_url.m_hostEnd = m_url.m_userStart;
+m_url.m_portEnd = m_url.m_userStart;
+m_url.m_pathAfterLastSlash = m_url.m_userStart + 1;
 m_url.m_pathEnd = m_url.m_pathAfterLastSlash;
 m_url.m_queryEnd = m_url.m_pathAfterLastSlash;
 m_url.m_fragmentEnd = m_url.m_pathAfterLastSlash;


Modified: trunk/Tools/ChangeLog (206218 => 206219)

--- trunk/Tools/ChangeLog	2016-09-21 18:00:19 UTC (rev 206218)
+++ trunk/Tools/ChangeLog	2016-09-21 18:02:52 UTC (rev 206219)
@@ -1,5 +1,15 @@
 2016-09-21  Alex Christensen  
 
+URLParser: Correctly parse URLs that are just nonspecialscheme:/
+https://bugs.webkit.org/show_bug.cgi?id=162340
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+(TestWebKitAPI::TEST_F):
+
+2016-09-21  Alex Christensen  
+
 URLParser: correctly parse relative URLs that are just one character
 https://bugs.webkit.org/show_bug.cgi?id=162344
 


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (206218 => 206219)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-21 18:00:19 UTC (rev 206218)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-21 18:02:52 UTC (rev 206219)
@@ -215,6 +215,7 @@
 checkURL("http://123.256/", {"http", "", "", "123.256", 0, "/", "", "", "http://123.256/"});
 checkURL("notspecial:/a", {"notspecial", "", "", "", 0, "/a", "", "", "notspecial:/a"});
 checkURL("notspecial:", {"notspecial", "", "", "", 0, "", "", "", "notspecial:"});
+checkURL("notspecial:/", {"notspecial", "", "", "", 0, "/", "", "", "notspecial:/"});
 
 // This disagrees with the web platform test for http://:@www.example.com but agrees with Chrome and URL::parse,
 // and Firefox fails the web platform test differently. Maybe the web platform test ought to be changed.
@@ -302,7 +303,10 @@
 checkRelativeURL("i", "sc://ho/pa", {"sc", "", "", "ho", 0, "/i", "", "", "sc://ho/i"});
 checkRelativeURL("!", "sc://ho/pa", {"sc", "", "", "ho", 0, "/!", "", "", "sc://ho/!"});
 checkRelativeURL("!", "sc:/ho/pa", {"sc", "", "", "", 0, "/ho/!", "", "", "sc:/ho/!"});
-
+checkRelativeURL("notspecial:/", "about:blank", {"notspecial", "", "", "", 0, "/", "", "", "notspecial:/"});
+checkRelativeURL("notspecial:/", "http://host", {"notspecial", "", "", "", 0, "/", "", "", "notspecial:/"});
+checkRelativeURL("foo:/", "http://example.org/foo/bar", 

[webkit-changes] [206218] trunk

[achristensen]

Title: [206218] trunk








Revision 206218
Author achristen...@apple.com
Date 2016-09-21 11:00:19 -0700 (Wed, 21 Sep 2016)


Log Message
URLParser: correctly parse relative URLs that are just one character
https://bugs.webkit.org/show_bug.cgi?id=162344

Reviewed by Tim Horton.

Source/WebCore:

Covered by new API tests.

* platform/URLParser.cpp:
(WebCore::URLParser::parse):

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206217 => 206218)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 17:44:43 UTC (rev 206217)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 18:00:19 UTC (rev 206218)
@@ -1,3 +1,15 @@
+2016-09-21  Alex Christensen  
+
+URLParser: correctly parse relative URLs that are just one character
+https://bugs.webkit.org/show_bug.cgi?id=162344
+
+Reviewed by Tim Horton.
+
+Covered by new API tests.
+
+* platform/URLParser.cpp:
+(WebCore::URLParser::parse):
+
 2016-09-21  Daniel Bates  
 
 REGRESSION (r201090): Setting style.webkitTextSizeAdjust does not change text change on iPad


Modified: trunk/Source/WebCore/platform/URLParser.cpp (206217 => 206218)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 17:44:43 UTC (rev 206217)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 18:00:19 UTC (rev 206218)
@@ -998,7 +998,12 @@
 LOG_STATE("SchemeStart");
 if (isASCIIAlpha(*c)) {
 m_asciiBuffer.uncheckedAppend(toASCIILower(*c));
-++c;
+incrementIteratorSkippingTabAndNewLine(c);
+if (c.atEnd()) {
+m_asciiBuffer.clear();
+state = State::NoScheme;
+c = beginAfterControlAndSpace;
+}
 state = State::Scheme;
 } else
 state = State::NoScheme;


Modified: trunk/Tools/ChangeLog (206217 => 206218)

--- trunk/Tools/ChangeLog	2016-09-21 17:44:43 UTC (rev 206217)
+++ trunk/Tools/ChangeLog	2016-09-21 18:00:19 UTC (rev 206218)
@@ -1,3 +1,13 @@
+2016-09-21  Alex Christensen  
+
+URLParser: correctly parse relative URLs that are just one character
+https://bugs.webkit.org/show_bug.cgi?id=162344
+
+Reviewed by Tim Horton.
+
+* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+(TestWebKitAPI::TEST_F):
+
 2016-09-20  Alex Christensen  
 
 Optimize URLParser


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (206217 => 206218)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-21 17:44:43 UTC (rev 206217)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-21 18:00:19 UTC (rev 206218)
@@ -296,6 +296,12 @@
 checkRelativeURL("notspecial:", "about:blank", {"notspecial", "", "", "", 0, "", "", "", "notspecial:"});
 checkRelativeURL("notspecial:", "http://host", {"notspecial", "", "", "", 0, "", "", "", "notspecial:"});
 checkRelativeURL("http:", "http://host", {"http", "", "", "host", 0, "/", "", "", "http://host/"});
+checkRelativeURL("i", "sc:/pa/po", {"sc", "", "", "", 0, "/pa/i", "", "", "sc:/pa/i"});
+checkRelativeURL("i", "sc:/pa/po", {"sc", "", "", "", 0, "/pa/i", "", "", "sc:/pa/i"});
+checkRelativeURL("i\t\n  ", "sc:/pa/po", {"sc", "", "", "", 0, "/pa/i", "", "", "sc:/pa/i"});
+checkRelativeURL("i", "sc://ho/pa", {"sc", "", "", "ho", 0, "/i", "", "", "sc://ho/i"});
+checkRelativeURL("!", "sc://ho/pa", {"sc", "", "", "ho", 0, "/!", "", "", "sc://ho/!"});
+checkRelativeURL("!", "sc:/ho/pa", {"sc", "", "", "", 0, "/ho/!", "", "", "sc:/ho/!"});
 
 // The checking of slashes in SpecialAuthoritySlashes needed to get this to pass contradicts what is in the spec,
 // but it is included in the web platform tests.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206217] trunk

[dbates]

Title: [206217] trunk








Revision 206217
Author dba...@webkit.org
Date 2016-09-21 10:44:43 -0700 (Wed, 21 Sep 2016)


Log Message
REGRESSION (r201090): Setting style.webkitTextSizeAdjust does not change text change on iPad
https://bugs.webkit.org/show_bug.cgi?id=162227


Reviewed by Simon Fraser.

Source/WebCore:

The CSS property -webkit-text-size-adjust should be respected on all iOS devices. Following
r201090 we respect it only on iPhone and in iPhone-apps run on iPad.

Tests: fast/text-autosizing/ios/ipad/programmatic-text-size-adjust.html
   fast/text-autosizing/ios/ipad/text-size-adjust-inline-style.html
   fast/text-autosizing/ios/programmatic-text-size-adjust.html
   fast/text-autosizing/ios/text-size-adjust-inline-style.html
   fast/text-autosizing/text-size-adjust-inline-style.html

* css/parser/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue): Remove unused code to validate -webkit-text-size-adjust.
This code is never used because -webkit-text-size-adjust is a value property (since it accepts a
 as a value and CSSParserFastPaths::isKeywordPropertyID(CSSPropertyWebkitTextSizeAdjust)
returns false). That is, it is not a keyword property.
(WebCore::CSSParser::parseValue): Always enable the -webkit-text-size-adjust CSS property when
building for iOS regardless of whether Settings:textAutosizingEnabled() is enabled.

LayoutTests:

Add tests to ensure setting the CSS property -webkit-text-size-adjust in a stylesheet or
programmatically is respected on iPhone and iPad. Also added a test to ensure that this
CSS property is ignored on macOS by default.

Note that we have existing tests that ensure that -webkit-text-size-adjust is respected
on macOS when the internal setting Settings::textAutosizingEnabled() is enabled.

* fast/text-autosizing/ios/ipad/programmatic-text-size-adjust-expected.txt: Added.
* fast/text-autosizing/ios/ipad/programmatic-text-size-adjust.html: Added.
* fast/text-autosizing/ios/ipad/text-size-adjust-inline-style-expected.html: Added.
* fast/text-autosizing/ios/ipad/text-size-adjust-inline-style.html: Added.
* fast/text-autosizing/ios/programmatic-text-size-adjust-expected.txt: Added.
* fast/text-autosizing/ios/programmatic-text-size-adjust.html: Added.
* fast/text-autosizing/ios/text-size-adjust-inline-style-expected.html: Added.
* fast/text-autosizing/ios/text-size-adjust-inline-style.html: Added.
* fast/text-autosizing/text-size-adjust-inline-style-expected.html: Added.
* fast/text-autosizing/text-size-adjust-inline-style.html: Added.
* platform/mac/TestExpectations: Skip the iOS and iPad tests on Mac. Otherwise, they will fail
because these tests intentionally do not call window.internal.settings.setTextAutosizingEnabled(true)
so as to test the default port behavior. And on Mac automatic text size adjustment is disabled
by default.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSParser.cpp


Added Paths

trunk/LayoutTests/fast/text-autosizing/ios/ipad/
trunk/LayoutTests/fast/text-autosizing/ios/ipad/programmatic-text-size-adjust-expected.txt
trunk/LayoutTests/fast/text-autosizing/ios/ipad/programmatic-text-size-adjust.html
trunk/LayoutTests/fast/text-autosizing/ios/ipad/text-size-adjust-inline-style-expected.html
trunk/LayoutTests/fast/text-autosizing/ios/ipad/text-size-adjust-inline-style.html
trunk/LayoutTests/fast/text-autosizing/ios/programmatic-text-size-adjust-expected.txt
trunk/LayoutTests/fast/text-autosizing/ios/programmatic-text-size-adjust.html
trunk/LayoutTests/fast/text-autosizing/ios/text-size-adjust-inline-style-expected.html
trunk/LayoutTests/fast/text-autosizing/ios/text-size-adjust-inline-style.html
trunk/LayoutTests/fast/text-autosizing/text-size-adjust-inline-style-expected.html
trunk/LayoutTests/fast/text-autosizing/text-size-adjust-inline-style.html




Diff

Modified: trunk/LayoutTests/ChangeLog (206216 => 206217)

--- trunk/LayoutTests/ChangeLog	2016-09-21 17:35:54 UTC (rev 206216)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 17:44:43 UTC (rev 206217)
@@ -1,3 +1,33 @@
+2016-09-21  Daniel Bates  
+
+REGRESSION (r201090): Setting style.webkitTextSizeAdjust does not change text change on iPad
+https://bugs.webkit.org/show_bug.cgi?id=162227
+
+
+Reviewed by Simon Fraser.
+
+Add tests to ensure setting the CSS property -webkit-text-size-adjust in a stylesheet or
+programmatically is respected on iPhone and iPad. Also added a test to ensure that this
+CSS property is ignored on macOS by default.
+
+Note that we have existing tests that ensure that -webkit-text-size-adjust is respected
+on macOS when the internal setting Settings::textAutosizingEnabled() is enabled.
+
+* fast/text-autosizing/ios/ipad/programmatic-text-size-adjust-expected.txt: Added.
+* fast/text-autosizing/ios/ipad/programmatic-text-size-adjust.html: 

[webkit-changes] [206216] trunk/Source/WebKit2

[gns]

Title: [206216] trunk/Source/WebKit2








Revision 206216
Author g...@gnome.org
Date 2016-09-21 10:35:54 -0700 (Wed, 21 Sep 2016)


Log Message
Unreviewed, build fix.

* UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
(WebKit::AcceleratedBackingStoreWayland::paint): fix usage of deviceScaleFactor variable which was
removed.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (206215 => 206216)

--- trunk/Source/WebKit2/ChangeLog	2016-09-21 17:20:44 UTC (rev 206215)
+++ trunk/Source/WebKit2/ChangeLog	2016-09-21 17:35:54 UTC (rev 206216)
@@ -1,3 +1,11 @@
+2016-09-21  Gustavo Noronha Silva  
+
+Unreviewed, build fix.
+
+* UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
+(WebKit::AcceleratedBackingStoreWayland::paint): fix usage of deviceScaleFactor variable which was
+removed.
+
 2016-09-20  Carlos Garcia Campos  
 
 [GTK] Clean up DataObjectGtk handling


Modified: trunk/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp (206215 => 206216)

--- trunk/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp	2016-09-21 17:20:44 UTC (rev 206215)
+++ trunk/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp	2016-09-21 17:35:54 UTC (rev 206216)
@@ -117,7 +117,7 @@
 
 // The compositor renders the texture flipped for gdk_cairo_draw_from_gl, fix that here.
 cairo_matrix_t transform;
-cairo_matrix_init(, 1, 0, 0, -1, 0, textureSize.height() / deviceScaleFactor);
+cairo_matrix_init(, 1, 0, 0, -1, 0, textureSize.height() / m_webPage.deviceScaleFactor());
 cairo_transform(cr, );
 
 cairo_rectangle(cr, clipRect.x(), clipRect.y(), clipRect.width(), clipRect.height());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206215] trunk/LayoutTests

[jer . noble]

Title: [206215] trunk/LayoutTests








Revision 206215
Author jer.no...@apple.com
Date 2016-09-21 10:20:44 -0700 (Wed, 21 Sep 2016)


Log Message
Unreviewed gardening; after r206208, update url-null.html test to reflect current (specced) behavior.

* fast/files/url-null-expected.txt:
* fast/files/url-null.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/files/url-null-expected.txt
trunk/LayoutTests/fast/files/url-null.html




Diff

Modified: trunk/LayoutTests/ChangeLog (206214 => 206215)

--- trunk/LayoutTests/ChangeLog	2016-09-21 17:16:33 UTC (rev 206214)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 17:20:44 UTC (rev 206215)
@@ -1,5 +1,12 @@
 2016-09-21  Jer Noble  
 
+Unreviewed gardening; after r206208, update url-null.html test to reflect current (specced) behavior.
+
+* fast/files/url-null-expected.txt:
+* fast/files/url-null.html:
+
+2016-09-21  Jer Noble  
+
 Unreviewed gardening; mark imported/w3c/web-platform-tests/media-source/ tests as passing by default
 and mark specific tests to skip or fail (rather than vice versa).
 


Modified: trunk/LayoutTests/fast/files/url-null-expected.txt (206214 => 206215)

--- trunk/LayoutTests/fast/files/url-null-expected.txt	2016-09-21 17:16:33 UTC (rev 206214)
+++ trunk/LayoutTests/fast/files/url-null-expected.txt	2016-09-21 17:20:44 UTC (rev 206215)
@@ -2,7 +2,7 @@
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
-PASS URL.createObjectURL(null) is null
+PASS URL.createObjectURL(null) threw exception TypeError: Type error.
 URL.revokeObjectURL(null)
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/fast/files/url-null.html (206214 => 206215)

--- trunk/LayoutTests/fast/files/url-null.html	2016-09-21 17:16:33 UTC (rev 206214)
+++ trunk/LayoutTests/fast/files/url-null.html	2016-09-21 17:20:44 UTC (rev 206215)
@@ -9,7 +9,7 @@
 

[webkit-changes] [206214] trunk/LayoutTests/imported/w3c

[jer . noble]

Title: [206214] trunk/LayoutTests/imported/w3c








Revision 206214
Author jer.no...@apple.com
Date 2016-09-21 10:16:33 -0700 (Wed, 21 Sep 2016)


Log Message
Unreviewed gardening; add some whitespace to expected results.

* web-platform-tests/media-source/URL-createObjectURL-null-expected.txt:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null-expected.txt




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206213 => 206214)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-21 16:28:48 UTC (rev 206213)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-21 17:16:33 UTC (rev 206214)
@@ -1,5 +1,11 @@
 2016-09-21  Jer Noble  
 
+Unreviewed gardening; add some whitespace to expected results.
+
+* web-platform-tests/media-source/URL-createObjectURL-null-expected.txt:
+
+2016-09-21  Jer Noble  
+
 Unreviewed gardening; added test expectations for new tests.
 
 * web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event-expected.txt: Added.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null-expected.txt (206213 => 206214)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null-expected.txt	2016-09-21 16:28:48 UTC (rev 206213)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null-expected.txt	2016-09-21 17:16:33 UTC (rev 206214)
@@ -1,2 +1,3 @@
 
-PASS URL.createObjectURL(null)
+PASS URL.createObjectURL(null) 
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206213] trunk/Source/WebCore

[commit-queue]

Title: [206213] trunk/Source/WebCore








Revision 206213
Author commit-qu...@webkit.org
Date 2016-09-21 09:28:48 -0700 (Wed, 21 Sep 2016)


Log Message
[GTK] Build fails with GSTREAMER_GL enabled
https://bugs.webkit.org/show_bug.cgi?id=162337

Patch by Miguel Gomez  on 2016-09-21
Reviewed by Michael Catanzaro.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext): Remove uneeded const.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206212 => 206213)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 16:26:13 UTC (rev 206212)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 16:28:48 UTC (rev 206213)
@@ -1,3 +1,13 @@
+2016-09-21  Miguel Gomez  
+
+[GTK] Build fails with GSTREAMER_GL enabled
+https://bugs.webkit.org/show_bug.cgi?id=162337
+
+Reviewed by Michael Catanzaro.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext): Remove uneeded const.
+
 2016-09-21  Jer Noble  
 
 REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (206212 => 206213)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2016-09-21 16:26:13 UTC (rev 206212)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2016-09-21 16:28:48 UTC (rev 206213)
@@ -252,7 +252,7 @@
 if (m_glContext)
 return true;
 
-const auto& sharedDisplay = PlatformDisplay::sharedDisplayForCompositing();
+auto& sharedDisplay = PlatformDisplay::sharedDisplayForCompositing();
 if (!m_glDisplay) {
 #if PLATFORM(X11)
 m_glDisplay = GST_GL_DISPLAY(gst_gl_display_x11_new_with_display(downcast(sharedDisplay).native()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206212] trunk/Source/JavaScriptCore

[msaboff]

Title: [206212] trunk/Source/_javascript_Core








Revision 206212
Author msab...@apple.com
Date 2016-09-21 09:26:13 -0700 (Wed, 21 Sep 2016)


Log Message
FTL needs to reserve callee stack space in bytes
https://bugs.webkit.org/show_bug.cgi?id=162324

Reviewed by Geoffrey Garen.

Changed two instances where we call B3::Procedure::requestCallArgAreaSize() with the
number of JSValue sized objects of stack space instead of bytes.  The correct units
to use is bytes.

Renamed both the Air and B3 related callArgAreaSize() to callArgAreaSizeInBytes().

No new tests as this doesn't surface as an issue when arguments are passed on the stack.

* b3/B3Procedure.cpp:
(JSC::B3::Procedure::callArgAreaSizeInBytes):
(JSC::B3::Procedure::requestCallArgAreaSizeInBytes):
(JSC::B3::Procedure::callArgAreaSize): Deleted.
(JSC::B3::Procedure::requestCallArgAreaSize): Deleted.
* b3/B3Procedure.h:
* b3/air/AirAllocateStack.cpp:
(JSC::B3::Air::allocateStack):
* b3/air/AirCCallingConvention.cpp:
(JSC::B3::Air::computeCCallingConvention):
* b3/air/AirCode.h:
(JSC::B3::Air::Code::callArgAreaSizeInBytes):
(JSC::B3::Air::Code::requestCallArgAreaSizeInBytes):
(JSC::B3::Air::Code::callArgAreaSize): Deleted.
(JSC::B3::Air::Code::requestCallArgAreaSize): Deleted.
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3Procedure.cpp
trunk/Source/_javascript_Core/b3/B3Procedure.h
trunk/Source/_javascript_Core/b3/air/AirAllocateStack.cpp
trunk/Source/_javascript_Core/b3/air/AirCCallingConvention.cpp
trunk/Source/_javascript_Core/b3/air/AirCode.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (206211 => 206212)

--- trunk/Source/_javascript_Core/ChangeLog	2016-09-21 16:25:14 UTC (rev 206211)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-21 16:26:13 UTC (rev 206212)
@@ -1,3 +1,38 @@
+2016-09-21  Michael Saboff  
+
+FTL needs to reserve callee stack space in bytes
+https://bugs.webkit.org/show_bug.cgi?id=162324
+
+Reviewed by Geoffrey Garen.
+
+Changed two instances where we call B3::Procedure::requestCallArgAreaSize() with the
+number of JSValue sized objects of stack space instead of bytes.  The correct units
+to use is bytes.
+
+Renamed both the Air and B3 related callArgAreaSize() to callArgAreaSizeInBytes().
+
+No new tests as this doesn't surface as an issue when arguments are passed on the stack.
+
+* b3/B3Procedure.cpp:
+(JSC::B3::Procedure::callArgAreaSizeInBytes):
+(JSC::B3::Procedure::requestCallArgAreaSizeInBytes):
+(JSC::B3::Procedure::callArgAreaSize): Deleted.
+(JSC::B3::Procedure::requestCallArgAreaSize): Deleted.
+* b3/B3Procedure.h:
+* b3/air/AirAllocateStack.cpp:
+(JSC::B3::Air::allocateStack):
+* b3/air/AirCCallingConvention.cpp:
+(JSC::B3::Air::computeCCallingConvention):
+* b3/air/AirCode.h:
+(JSC::B3::Air::Code::callArgAreaSizeInBytes):
+(JSC::B3::Air::Code::requestCallArgAreaSizeInBytes):
+(JSC::B3::Air::Code::callArgAreaSize): Deleted.
+(JSC::B3::Air::Code::requestCallArgAreaSize): Deleted.
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
+(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
+(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
+
 2016-09-21  Csaba Osztrogonác  
 
 [ARM] Unreviewed buildfix after r206136.


Modified: trunk/Source/_javascript_Core/b3/B3Procedure.cpp (206211 => 206212)

--- trunk/Source/_javascript_Core/b3/B3Procedure.cpp	2016-09-21 16:25:14 UTC (rev 206211)
+++ trunk/Source/_javascript_Core/b3/B3Procedure.cpp	2016-09-21 16:26:13 UTC (rev 206212)
@@ -295,14 +295,14 @@
 return result;
 }
 
-unsigned Procedure::callArgAreaSize() const
+unsigned Procedure::callArgAreaSizeInBytes() const
 {
-return code().callArgAreaSize();
+return code().callArgAreaSizeInBytes();
 }
 
-void Procedure::requestCallArgAreaSize(unsigned size)
+void Procedure::requestCallArgAreaSizeInBytes(unsigned size)
 {
-code().requestCallArgAreaSize(size);
+code().requestCallArgAreaSizeInBytes(size);
 }
 
 unsigned Procedure::frameSize() const


Modified: trunk/Source/_javascript_Core/b3/B3Procedure.h (206211 => 206212)

--- trunk/Source/_javascript_Core/b3/B3Procedure.h	2016-09-21 16:25:14 UTC (rev 206211)
+++ trunk/Source/_javascript_Core/b3/B3Procedure.h	2016-09-21 16:26:13 UTC (rev 206212)
@@ -210,8 +210,8 @@
 const Air::Code& code() const { return *m_code; }
 Air::Code& code() { return *m_code; }
 
-unsigned callArgAreaSize() const;
-void requestCallArgAreaSize(unsigned size);
+unsigned 

[webkit-changes] [206211] trunk/Source/WebCore

[jer . noble]

Title: [206211] trunk/Source/WebCore








Revision 206211
Author jer.no...@apple.com
Date 2016-09-21 09:25:14 -0700 (Wed, 21 Sep 2016)


Log Message
REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement
https://bugs.webkit.org/show_bug.cgi?id=162307

Reviewed by Eric Carlson.

The test is crashing when the ScriptExecutionContext is calling stop() on the media element before
it's attached MediaSource has been open()ed, which is a valid state. Removing this ASSERT().

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::detachFromElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206210 => 206211)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 16:16:01 UTC (rev 206210)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 16:25:14 UTC (rev 206211)
@@ -1,3 +1,16 @@
+2016-09-21  Jer Noble  
+
+REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement
+https://bugs.webkit.org/show_bug.cgi?id=162307
+
+Reviewed by Eric Carlson.
+
+The test is crashing when the ScriptExecutionContext is calling stop() on the media element before
+it's attached MediaSource has been open()ed, which is a valid state. Removing this ASSERT().
+
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::detachFromElement):
+
 2016-09-19  Jer Noble  
 
 [media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html


Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (206210 => 206211)

--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp	2016-09-21 16:16:01 UTC (rev 206210)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp	2016-09-21 16:25:14 UTC (rev 206211)
@@ -891,7 +891,6 @@
 void MediaSource::detachFromElement(HTMLMediaElement& element)
 {
 ASSERT_UNUSED(element, m_mediaElement == );
-ASSERT(!isClosed());
 
 // 2.4.2 Detaching from a media element
 // https://rawgit.com/w3c/media-source/45627646344eea0170dd1cbc5a3d508ca751abb8/media-source-respec.html#mediasource-detach






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206210] trunk/LayoutTests

[jer . noble]

Title: [206210] trunk/LayoutTests








Revision 206210
Author jer.no...@apple.com
Date 2016-09-21 09:16:01 -0700 (Wed, 21 Sep 2016)


Log Message
LayoutTests/imported/w3c:
Unreviewed gardening; added test expectations for new tests.

* web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event-expected.txt: Added.
* web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps-expected.txt: Added.

LayoutTests:
Unreviewed gardening; mark imported/w3c/web-platform-tests/media-source/ tests as passing by default
and mark specific tests to skip or fail (rather than vice versa).

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (206209 => 206210)

--- trunk/LayoutTests/ChangeLog	2016-09-21 16:13:57 UTC (rev 206209)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 16:16:01 UTC (rev 206210)
@@ -1,3 +1,10 @@
+2016-09-21  Jer Noble  
+
+Unreviewed gardening; mark imported/w3c/web-platform-tests/media-source/ tests as passing by default
+and mark specific tests to skip or fail (rather than vice versa).
+
+* platform/mac/TestExpectations:
+
 2016-09-19  Jer Noble  
 
 [media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206209 => 206210)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-21 16:13:57 UTC (rev 206209)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-09-21 16:16:01 UTC (rev 206210)
@@ -1,3 +1,10 @@
+2016-09-21  Jer Noble  
+
+Unreviewed gardening; added test expectations for new tests.
+
+* web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event-expected.txt: Added.
+* web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps-expected.txt: Added.
+
 2016-09-21  Youenn Fablet  
 
 [Fetch] Align Accept header default values with fetch spec


Added: trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event-expected.txt (0 => 206210)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event-expected.txt	(rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event-expected.txt	2016-09-21 16:16:01 UTC (rev 206210)
@@ -0,0 +1,3 @@
+
+PASS MediaSource attachment should immediately stop delaying the load event 
+


Added: trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps-expected.txt (0 => 206210)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps-expected.txt	(rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps-expected.txt	2016-09-21 16:16:01 UTC (rev 206210)
@@ -0,0 +1,3 @@
+
+PASS audio/aac : If generate timestamps flag equals true and new mode equals "segments", then throw a TypeError exception and abort these steps.
+PASS audio/mpeg : If generate timestamps flag equals true and new mode equals "segments", then throw a TypeError exception and abort these steps.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (206209 => 206210)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-09-21 16:13:57 UTC (rev 206209)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-09-21 16:16:01 UTC (rev 206210)
@@ -1036,48 +1036,42 @@
 
 # --- Start Media Source Tests ---
 ## --- Start W3C Imported Media Source Tests
-# Passing Media Source tests
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/ [ Skip ]
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-readyState.html [ Pass ]
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-removed.html [ Pass ]
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-updating.html [ Pass ]
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort.html [ Pass ]
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/URL-createObjectURL.html [ Pass ]
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html [ Pass ]
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Pass ]
-[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html [ Pass ]

[webkit-changes] [206209] trunk

[jer . noble]

Title: [206209] trunk








Revision 206209
Author jer.no...@apple.com
Date 2016-09-21 09:13:57 -0700 (Wed, 21 Sep 2016)


Log Message
[media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html
https://bugs.webkit.org/show_bug.cgi?id=162257

Reviewed by Eric Carlson.

Source/WebCore:

Some of the conditions in the track changed methods were reversed, and all failed to schedule
a change event.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::videoTrackSelectedChanged):
(WebCore::SourceBuffer::audioTrackEnabledChanged):
(WebCore::SourceBuffer::textTrackModeChanged):

LayoutTests:

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (206208 => 206209)

--- trunk/LayoutTests/ChangeLog	2016-09-21 16:12:33 UTC (rev 206208)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 16:13:57 UTC (rev 206209)
@@ -1,3 +1,12 @@
+2016-09-19  Jer Noble  
+
+[media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html
+https://bugs.webkit.org/show_bug.cgi?id=162257
+
+Reviewed by Eric Carlson.
+
+* platform/mac/TestExpectations:
+
 2016-09-20  Jer Noble  
 
 [media-source] Fix imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html


Modified: trunk/LayoutTests/platform/mac/TestExpectations (206208 => 206209)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-09-21 16:12:33 UTC (rev 206208)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-09-21 16:13:57 UTC (rev 206209)
@@ -1044,6 +1044,7 @@
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/URL-createObjectURL.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html [ Pass ]
+[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-appendwindow.html [ Pass ]


Modified: trunk/Source/WebCore/ChangeLog (206208 => 206209)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 16:12:33 UTC (rev 206208)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 16:13:57 UTC (rev 206209)
@@ -1,3 +1,18 @@
+2016-09-19  Jer Noble  
+
+[media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html
+https://bugs.webkit.org/show_bug.cgi?id=162257
+
+Reviewed by Eric Carlson.
+
+Some of the conditions in the track changed methods were reversed, and all failed to schedule
+a change event.
+
+* Modules/mediasource/SourceBuffer.cpp:
+(WebCore::SourceBuffer::videoTrackSelectedChanged):
+(WebCore::SourceBuffer::audioTrackEnabledChanged):
+(WebCore::SourceBuffer::textTrackModeChanged):
+
 2016-09-20  Jer Noble  
 
 [media-source] Fix imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html


Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (206208 => 206209)

--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp	2016-09-21 16:12:33 UTC (rev 206208)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp	2016-09-21 16:13:57 UTC (rev 206209)
@@ -1695,7 +1695,7 @@
 // If the selected video track changes, then run the following steps:
 // 1. If the SourceBuffer associated with the previously selected video track is not associated with
 // any other enabled tracks, run the following steps:
-if (track->selected()
+if (!track->selected()
 && (!m_videoTracks || !m_videoTracks->isAnyTrackEnabled())
 && (!m_audioTracks || !m_audioTracks->isAnyTrackEnabled())
 && (!m_textTracks || !m_textTracks->isAnyTrackEnabled())) {
@@ -1702,7 +1702,7 @@
 // 1.1 Remove the SourceBuffer from activeSourceBuffers.
 // 1.2 Queue a task to fire a simple event named removesourcebuffer at activeSourceBuffers
 setActive(false);
-} else if (!track->selected()) {
+} else if (track->selected()) {
 // 2. If the SourceBuffer associated with the newly selected video track is not already in activeSourceBuffers,
 // run the following steps:
 // 2.1 Add the SourceBuffer to activeSourceBuffers.
@@ -1710,6 +1710,9 @@
 setActive(true);
 }
 
+if (m_videoTracks && m_videoTracks->contains(*track))
+m_videoTracks->scheduleChangeEvent();
+
 if 

[webkit-changes] [206208] trunk

[jer . noble]

Title: [206208] trunk








Revision 206208
Author jer.no...@apple.com
Date 2016-09-21 09:12:33 -0700 (Wed, 21 Sep 2016)


Log Message
[media-source] Fix imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html
https://bugs.webkit.org/show_bug.cgi?id=162299

Reviewed by Eric Carlson.

Source/WebCore:

URL.createObjectURL() should not take an optional parameter (nor return an optional String).
(Ref: https://w3c.github.io/FileAPI/#dfn-createObjectURL)

* Modules/mediasource/DOMURLMediaSource.cpp:
(WebCore::DOMURLMediaSource::createObjectURL):
* Modules/mediasource/DOMURLMediaSource.h:
* Modules/mediasource/DOMURLMediaSource.idl:
* Modules/mediasource/MediaSourceRegistry.cpp:
(WebCore::MediaSourceRegistry::registerURL):
* Modules/mediasource/MediaSourceRegistry.h:
* Modules/mediastream/DOMURLMediaStream.cpp:
(WebCore::DOMURLMediaStream::createObjectURL):
* Modules/mediastream/DOMURLMediaStream.h:
* Modules/mediastream/DOMURLMediaStream.idl:
* Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::registerURL):
* Modules/mediastream/MediaStreamRegistry.h:
* fileapi/Blob.cpp:
(WebCore::BlobURLRegistry::registerURL):
* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::createPublicURL):
* html/DOMURL.h:
* html/DOMURL.idl:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSrcObject):
* html/PublicURLManager.cpp:
(WebCore::PublicURLManager::registerURL):
* html/PublicURLManager.h:
* html/URLRegistry.h:

LayoutTests:

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/DOMURLMediaSource.cpp
trunk/Source/WebCore/Modules/mediasource/DOMURLMediaSource.h
trunk/Source/WebCore/Modules/mediasource/DOMURLMediaSource.idl
trunk/Source/WebCore/Modules/mediasource/MediaSourceRegistry.cpp
trunk/Source/WebCore/Modules/mediasource/MediaSourceRegistry.h
trunk/Source/WebCore/Modules/mediastream/DOMURLMediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/DOMURLMediaStream.h
trunk/Source/WebCore/Modules/mediastream/DOMURLMediaStream.idl
trunk/Source/WebCore/Modules/mediastream/MediaStreamRegistry.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamRegistry.h
trunk/Source/WebCore/fileapi/Blob.cpp
trunk/Source/WebCore/html/DOMURL.cpp
trunk/Source/WebCore/html/DOMURL.h
trunk/Source/WebCore/html/DOMURL.idl
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/PublicURLManager.cpp
trunk/Source/WebCore/html/PublicURLManager.h
trunk/Source/WebCore/html/URLRegistry.h




Diff

Modified: trunk/LayoutTests/ChangeLog (206207 => 206208)

--- trunk/LayoutTests/ChangeLog	2016-09-21 12:39:10 UTC (rev 206207)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 16:12:33 UTC (rev 206208)
@@ -1,3 +1,12 @@
+2016-09-20  Jer Noble  
+
+[media-source] Fix imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html
+https://bugs.webkit.org/show_bug.cgi?id=162299
+
+Reviewed by Eric Carlson.
+
+* platform/mac/TestExpectations:
+
 2016-09-21  Youenn Fablet  
 
 [Fetch] Align Accept header default values with fetch spec


Modified: trunk/LayoutTests/platform/mac/TestExpectations (206207 => 206208)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-09-21 12:39:10 UTC (rev 206207)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-09-21 16:12:33 UTC (rev 206208)
@@ -1043,6 +1043,7 @@
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-updating.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/SourceBuffer-abort.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/URL-createObjectURL.html [ Pass ]
+[ Yosemite+ ] imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer.html [ Pass ]
 [ Yosemite+ ] imported/w3c/web-platform-tests/media-source/mediasource-appendwindow.html [ Pass ]


Modified: trunk/Source/WebCore/ChangeLog (206207 => 206208)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 12:39:10 UTC (rev 206207)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 16:12:33 UTC (rev 206208)
@@ -1,3 +1,41 @@
+2016-09-20  Jer Noble  
+
+[media-source] Fix imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html
+https://bugs.webkit.org/show_bug.cgi?id=162299
+
+Reviewed by Eric Carlson.
+
+URL.createObjectURL() should not take an optional parameter (nor return an optional String). 
+(Ref: https://w3c.github.io/FileAPI/#dfn-createObjectURL)
+
+* Modules/mediasource/DOMURLMediaSource.cpp:
+(WebCore::DOMURLMediaSource::createObjectURL):
+* 

[webkit-changes] [206207] trunk/Source/JavaScriptCore

[ossy]

Title: [206207] trunk/Source/_javascript_Core








Revision 206207
Author o...@webkit.org
Date 2016-09-21 05:39:10 -0700 (Wed, 21 Sep 2016)


Log Message
[ARM] Unreviewed buildfix after r206136.

* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchPtr): Added.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (206206 => 206207)

--- trunk/Source/_javascript_Core/ChangeLog	2016-09-21 09:56:16 UTC (rev 206206)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-21 12:39:10 UTC (rev 206207)
@@ -1,3 +1,11 @@
+2016-09-21  Csaba Osztrogonác  
+
+[ARM] Unreviewed buildfix after r206136.
+
+* assembler/MacroAssembler.h:
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::branchPtr): Added.
+
 2016-09-20  Alex Christensen  
 
 Require WTFMove for String::adopt


Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (206206 => 206207)

--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2016-09-21 09:56:16 UTC (rev 206206)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2016-09-21 12:39:10 UTC (rev 206207)
@@ -121,7 +121,7 @@
 using MacroAssemblerBase::and32;
 using MacroAssemblerBase::branchAdd32;
 using MacroAssemblerBase::branchMul32;
-#if CPU(ARM64) || CPU(ARM_THUMB2) || CPU(X86_64)
+#if CPU(ARM64) || CPU(ARM_THUMB2) || CPU(ARM_TRADITIONAL) || CPU(X86_64)
 using MacroAssemblerBase::branchPtr;
 #endif
 using MacroAssemblerBase::branchSub32;


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (206206 => 206207)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2016-09-21 09:56:16 UTC (rev 206206)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2016-09-21 12:39:10 UTC (rev 206207)
@@ -653,6 +653,12 @@
 return branch32(cond, ARMRegisters::S1, right8);
 }
 
+Jump branchPtr(RelationalCondition cond, BaseIndex left, RegisterID right)
+{
+load32(left, ARMRegisters::S1);
+return branch32(cond, ARMRegisters::S1, right);
+}
+
 Jump branch32(RelationalCondition cond, RegisterID left, RegisterID right, int useConstantPool = 0)
 {
 m_assembler.cmp(left, right);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206206] trunk

[commit-queue]

Title: [206206] trunk








Revision 206206
Author commit-qu...@webkit.org
Date 2016-09-21 02:56:16 -0700 (Wed, 21 Sep 2016)


Log Message
[Fetch] Align Accept header default values with fetch spec
https://bugs.webkit.org/show_bug.cgi?id=162260

Patch by Youenn Fablet  on 2016-09-21
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Ensuring Accept and Accept-Language user-specific values are going up to the server.

* web-platform-tests/fetch/api/basic/accept-header-expected.txt:
* web-platform-tests/fetch/api/basic/accept-header-worker-expected.txt:
* web-platform-tests/fetch/api/basic/accept-header.js:
(promise_test):

Source/WebCore:

Covered by existing and updated tests.

To start implementing step 1 to 7 of fetch algorithm, this patch updates Accept header handling.

Default values are set according the spec based on resource type.
Some resource types are not defined in the spec and we keep using existing values.

We check if Accept header is already present in the request. If that is the case, no change is done to that header.

If the Accept header is not set, the default value '*/*' is used.
An Accept header is therefore always set at CachedResourceLoader level.

* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Removing accept initialization.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load): Removing accept header setting.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::accept): Deleted.
(WebCore::CachedResource::setAccept): Deleted.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::acceptHeaderValueFromType): helper routine merging fetch spec and existing WebKit accept values.
(WebCore::CachedResourceLoader::prepareFetch): Should implement step 1 to 7 of https://fetch.spec.whatwg.org/#fetching.
(WebCore::CachedResourceLoader::requestResource): Making use of prepareFetch.
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::CachedSVGDocument): Removing accept initialization.
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript): Removing accept initialization.
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): Removing accept initialization.
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::hasHTTPHeader): Introduced to check for header presence.
* platform/network/ResourceRequestBase.h:

LayoutTests:

* http/tests/misc/resources/image-checks-for-accept.php: Updated according new image Accept header value.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/misc/resources/image-checks-for-accept.php
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header-worker-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
trunk/Source/WebCore/loader/cache/CachedSVGDocument.cpp
trunk/Source/WebCore/loader/cache/CachedScript.cpp
trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp
trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp
trunk/Source/WebCore/platform/network/ResourceRequestBase.h




Diff

Modified: trunk/LayoutTests/ChangeLog (206205 => 206206)

--- trunk/LayoutTests/ChangeLog	2016-09-21 09:48:51 UTC (rev 206205)
+++ trunk/LayoutTests/ChangeLog	2016-09-21 09:56:16 UTC (rev 206206)
@@ -1,3 +1,12 @@
+2016-09-21  Youenn Fablet  
+
+[Fetch] Align Accept header default values with fetch spec
+https://bugs.webkit.org/show_bug.cgi?id=162260
+
+Reviewed by Sam Weinig.
+
+* http/tests/misc/resources/image-checks-for-accept.php: Updated according new image Accept header value.
+
 2016-09-21  Chris Dumez  
 
 Import html/syntax web platform tests


Modified: trunk/LayoutTests/http/tests/misc/resources/image-checks-for-accept.php (206205 => 206206)

--- trunk/LayoutTests/http/tests/misc/resources/image-checks-for-accept.php	2016-09-21 09:48:51 UTC (rev 206205)
+++ trunk/LayoutTests/http/tests/misc/resources/image-checks-for-accept.php	2016-09-21 09:56:16 UTC (rev 206206)
@@ -1,5 +1,5 @@
 -if($_SERVER["HTTP_ACCEPT"] == "*/*" || $_SERVER["HTTP_ACCEPT"] == "image/*" || $_SERVER["HTTP_ACCEPT"] == "image/jpg")
+if($_SERVER["HTTP_ACCEPT"] == "image/png,image/svg+xml,image/*;q=0.8,*/*;q=0.5")
 {
 header("Content-Type: image/jpg");
 header("Cache-Control: no-store");


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206205 => 206206)

--- 

[webkit-changes] [206205] trunk/Source/WebCore

[commit-queue]

Title: [206205] trunk/Source/WebCore








Revision 206205
Author commit-qu...@webkit.org
Date 2016-09-21 02:48:51 -0700 (Wed, 21 Sep 2016)


Log Message
[GTK] Fix build failure of ScrollbarThemeGtk with libc++
https://bugs.webkit.org/show_bug.cgi?id=162302

Patch by Jeremy Huddleston Sequoia  on 2016-09-21
Reviewed by Carlos Garcia Campos.

* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paint): Add missing #include 

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206204 => 206205)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 09:44:06 UTC (rev 206204)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 09:48:51 UTC (rev 206205)
@@ -1,3 +1,13 @@
+2016-09-21  Jeremy Huddleston Sequoia  
+
+[GTK] Fix build failure of ScrollbarThemeGtk with libc++
+https://bugs.webkit.org/show_bug.cgi?id=162302
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/gtk/ScrollbarThemeGtk.cpp:
+(WebCore::ScrollbarThemeGtk::paint): Add missing #include 
+
 2016-09-21  Philippe Normand  
 
 [OpenWebRTC] Miscellaneous fixes


Modified: trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp (206204 => 206205)

--- trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp	2016-09-21 09:44:06 UTC (rev 206204)
+++ trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp	2016-09-21 09:48:51 UTC (rev 206205)
@@ -33,6 +33,7 @@
 #include "RenderThemeGadget.h"
 #include "ScrollView.h"
 #include "Scrollbar.h"
+#include 
 #include 
 
 namespace WebCore {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206204] trunk/Source/WebCore

[philn]

Title: [206204] trunk/Source/WebCore








Revision 206204
Author ph...@webkit.org
Date 2016-09-21 02:44:06 -0700 (Wed, 21 Sep 2016)


Log Message
[OpenWebRTC] Miscellaneous fixes
https://bugs.webkit.org/show_bug.cgi?id=162332

Reviewed by Alejandro G. Castro.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::currentTime): Improved logging.
(WebCore::MediaPlayerPrivateGStreamerOwr::load): Ditto.
(WebCore::MediaPlayerPrivateGStreamerOwr::loadingFailed): Ditto.
(WebCore::MediaPlayerPrivateGStreamerOwr::createGSTAudioSinkBin):
Pre-roll the autoaudiosink, fetch the underlying platform audio
sink and pass it to the OpenWebRTC renderer.
(WebCore::MediaPlayerPrivateGStreamerOwr::maybeHandleChangeMutedState): Improved logging.
(WebCore::MediaPlayerPrivateGStreamerOwr::setSize): Don't configure invalid video renderer.
* platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
(WebCore::RealtimeMediaSourceCenterOwr::createMediaStream): Fix copy-paste error.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp
trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206203 => 206204)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 08:43:23 UTC (rev 206203)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 09:44:06 UTC (rev 206204)
@@ -1,3 +1,22 @@
+2016-09-21  Philippe Normand  
+
+[OpenWebRTC] Miscellaneous fixes
+https://bugs.webkit.org/show_bug.cgi?id=162332
+
+Reviewed by Alejandro G. Castro.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
+(WebCore::MediaPlayerPrivateGStreamerOwr::currentTime): Improved logging.
+(WebCore::MediaPlayerPrivateGStreamerOwr::load): Ditto.
+(WebCore::MediaPlayerPrivateGStreamerOwr::loadingFailed): Ditto.
+(WebCore::MediaPlayerPrivateGStreamerOwr::createGSTAudioSinkBin):
+Pre-roll the autoaudiosink, fetch the underlying platform audio
+sink and pass it to the OpenWebRTC renderer.
+(WebCore::MediaPlayerPrivateGStreamerOwr::maybeHandleChangeMutedState): Improved logging.
+(WebCore::MediaPlayerPrivateGStreamerOwr::setSize): Don't configure invalid video renderer.
+* platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
+(WebCore::RealtimeMediaSourceCenterOwr::createMediaStream): Fix copy-paste error.
+
 2016-09-21  Youenn Fablet  
 
 Refactor CachedResourceLoader::canRequest


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp (206203 => 206204)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp	2016-09-21 08:43:23 UTC (rev 206203)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp	2016-09-21 09:44:06 UTC (rev 206204)
@@ -115,7 +115,7 @@
 if (static_cast(position) != GST_CLOCK_TIME_NONE)
 result = static_cast(position) / GST_SECOND;
 
-GST_DEBUG("Position %" GST_TIME_FORMAT, GST_TIME_ARGS(position));
+GST_LOG("Position %" GST_TIME_FORMAT, GST_TIME_ARGS(position));
 gst_query_unref(query);
 
 return result;
@@ -148,7 +148,7 @@
 if (streamPrivate.hasAudio() && !m_audioSink)
 createGSTAudioSinkBin();
 
-GST_DEBUG("Loading MediaStreamPrivate %p", );
+GST_DEBUG("Loading MediaStreamPrivate %p video: %s, audio: %s", , streamPrivate.hasVideo() ? "yes":"no", streamPrivate.hasAudio() ? "yes":"no");
 
 m_streamPrivate = 
 if (!m_streamPrivate->active()) {
@@ -188,6 +188,7 @@
 void MediaPlayerPrivateGStreamerOwr::loadingFailed(MediaPlayer::NetworkState error)
 {
 if (m_networkState != error) {
+GST_WARNING("Loading failed, error: %d", error);
 m_networkState = error;
 m_player->networkStateChanged();
 }
@@ -259,11 +260,19 @@
 GST_DEBUG("Creating audio sink");
 // FIXME: volume/mute support: https://webkit.org/b/153828.
 
-GRefPtr sink = gst_element_factory_make("autoaudiosink", 0);
+// Pre-roll an autoaudiosink so that the platform audio sink is created and
+// can be retrieved from the autoaudiosink bin.
+GRefPtr sink = gst_element_factory_make("autoaudiosink", nullptr);
 GstChildProxy* childProxy = GST_CHILD_PROXY(sink.get());
-m_audioSink = adoptGRef(GST_ELEMENT(gst_child_proxy_get_child_by_index(childProxy, 0)));
+gst_element_set_state(sink.get(), GST_STATE_READY);
+GRefPtr platformSink = adoptGRef(GST_ELEMENT(gst_child_proxy_get_child_by_index(childProxy, 0)));
+GstElementFactory* factory = gst_element_get_factory(platformSink.get());
+
+// Dispose now un-needed autoaudiosink.
 gst_element_set_state(sink.get(), GST_STATE_NULL);
 
+// Create a fresh new audio sink compatible with the platform.
+m_audioSink = 

[webkit-changes] [206203] trunk/Source/WebCore

[commit-queue]

Title: [206203] trunk/Source/WebCore








Revision 206203
Author commit-qu...@webkit.org
Date 2016-09-21 01:43:23 -0700 (Wed, 21 Sep 2016)


Log Message
Refactor CachedResourceLoader::canRequest
https://bugs.webkit.org/show_bug.cgi?id=162144

Patch by Youenn Fablet  on 2016-09-21
Reviewed by Darin Adler.

Covered by existing tests.

Simplifying CachedResourceLoader::canRequest by doing:
- CSP checks in another method
- Removing Same-Origin type-specific checks by setting FetchOptions::Mode appropriately in resource loader clients
- Moving script specific check in ScriptElement

Note that the last check may affect the loading behavior in the case scripts are enabled when starting the load
of a script, but gets disabled before receiving a redirection for the script load.

* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet): Setting XSLT stylesheet fetch mode to SameOrigin.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScriptWithCache): Returning early if scripts are disabled.
* loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::startPreflight): Bypassing CSP checks.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Bypassing CSP checks as CachedResourceLoader was not
checking them for MainResource.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest): Ditto.
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::preloadIfNeeded): Using new CachedResourceRequest constructor to enable moving the ResourceRequest.
(WebCore::LinkLoader::loadLink): Skipping CSP checks for link prefetch/subresources as CachedResourceLoader was
not checking them for Link Prefetch and Subresource types.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy): Helper routine to check for CSP.
(WebCore::CachedResourceLoader::canRequest): Making use of introduced helper routine.
Simplified same origin check as all requests should have their options set.
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest): More efficient constructor.
* loader/cache/CachedResourceRequest.h:
* loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::load): Setting fetch mode to SameOrigin.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::updateExternalDocument): Ditto.
* xml/XSLImportRule.cpp:
(WebCore::XSLImportRule::loadSheet): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ProcessingInstruction.cpp
trunk/Source/WebCore/dom/ScriptElement.cpp
trunk/Source/WebCore/loader/CrossOriginPreflightChecker.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/loader/LinkLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp
trunk/Source/WebCore/loader/cache/CachedResourceRequest.h
trunk/Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/xml/XSLImportRule.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206202 => 206203)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 07:48:32 UTC (rev 206202)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 08:43:23 UTC (rev 206203)
@@ -1,3 +1,50 @@
+2016-09-21  Youenn Fablet  
+
+Refactor CachedResourceLoader::canRequest
+https://bugs.webkit.org/show_bug.cgi?id=162144
+
+Reviewed by Darin Adler.
+
+Covered by existing tests.
+
+Simplifying CachedResourceLoader::canRequest by doing:
+- CSP checks in another method
+- Removing Same-Origin type-specific checks by setting FetchOptions::Mode appropriately in resource loader clients
+- Moving script specific check in ScriptElement
+
+Note that the last check may affect the loading behavior in the case scripts are enabled when starting the load
+of a script, but gets disabled before receiving a redirection for the script load.
+
+* dom/ProcessingInstruction.cpp:
+(WebCore::ProcessingInstruction::checkStyleSheet): Setting XSLT stylesheet fetch mode to SameOrigin.
+* dom/ScriptElement.cpp:
+(WebCore::ScriptElement::requestScriptWithCache): Returning early if scripts are disabled.
+* loader/CrossOriginPreflightChecker.cpp:
+(WebCore::CrossOriginPreflightChecker::startPreflight): Bypassing CSP checks.
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::startLoadingMainResource): Bypassing CSP checks as CachedResourceLoader was not
+checking them for MainResource.
+* loader/DocumentThreadableLoader.cpp:
+(WebCore::DocumentThreadableLoader::loadRequest): Ditto.
+* 

[webkit-changes] [206202] trunk/Source/WebCore

[commit-queue]

Title: [206202] trunk/Source/WebCore








Revision 206202
Author commit-qu...@webkit.org
Date 2016-09-21 00:48:32 -0700 (Wed, 21 Sep 2016)


Log Message
Build fails with GSTREAMER_GL when both desktop GL and GLES2 are enabled in gst-plugins-bad
https://bugs.webkit.org/show_bug.cgi?id=159562

Patch by Miguel Gomez  on 2016-09-21
Reviewed by Philippe Normand.

Refactor video orientation code so including TextureMapperGL in MediaPlayerPrivateGStreamerBase.h
is not necessary.

Covered by existent tests.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::texMapFlagFromOrientation):
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
(WebCore::MediaPlayerPrivateGStreamerBase::setVideoSourceOrientation):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (206201 => 206202)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 07:14:41 UTC (rev 206201)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 07:48:32 UTC (rev 206202)
@@ -1,3 +1,23 @@
+2016-09-21  Miguel Gomez  
+
+Build fails with GSTREAMER_GL when both desktop GL and GLES2 are enabled in gst-plugins-bad
+https://bugs.webkit.org/show_bug.cgi?id=159562
+
+Reviewed by Philippe Normand.
+
+Refactor video orientation code so including TextureMapperGL in MediaPlayerPrivateGStreamerBase.h
+is not necessary.
+
+Covered by existent tests.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::texMapFlagFromOrientation):
+(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
+(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
+(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
+(WebCore::MediaPlayerPrivateGStreamerBase::setVideoSourceOrientation):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
 2016-09-21  Jeremy Huddleston Sequoia  
 
 [GTK] Fix build failure in clipboard support


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (206201 => 206202)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2016-09-21 07:14:41 UTC (rev 206201)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2016-09-21 07:48:32 UTC (rev 206202)
@@ -103,6 +103,26 @@
 return ABS(a);
 }
 
+#if USE(TEXTURE_MAPPER_GL)
+static inline TextureMapperGL::Flags texMapFlagFromOrientation(const ImageOrientation& orientation)
+{
+switch (orientation) {
+case DefaultImageOrientation:
+return 0;
+case OriginRightTop:
+return TextureMapperGL::ShouldRotateTexture90;
+case OriginBottomRight:
+return TextureMapperGL::ShouldRotateTexture180;
+case OriginLeftBottom:
+return TextureMapperGL::ShouldRotateTexture270;
+default:
+ASSERT_NOT_REACHED();
+}
+
+return 0;
+}
+#endif
+
 #if USE(COORDINATED_GRAPHICS_THREADED) && USE(GSTREAMER_GL)
 class GstVideoFrameHolder : public TextureMapperPlatformLayerBuffer::UnmanagedBufferDataHolder {
 public:
@@ -154,9 +174,6 @@
 , m_drawTimer(RunLoop::main(), this, ::repaint)
 #endif
 , m_usingFallbackVideoSink(false)
-#if USE(TEXTURE_MAPPER_GL)
-, m_textureMapperRotationFlag(0)
-#endif
 {
 g_mutex_init(_sampleMutex);
 #if USE(COORDINATED_GRAPHICS_THREADED)
@@ -486,7 +503,7 @@
 return;
 
 #if USE(GSTREAMER_GL)
-std::unique_ptr frameHolder = std::make_unique(m_sample.get(), m_textureMapperRotationFlag);
+std::unique_ptr frameHolder = std::make_unique(m_sample.get(), texMapFlagFromOrientation(m_videoSourceOrientation));
 if (UNLIKELY(!frameHolder->isValid()))
 return;
 
@@ -509,7 +526,7 @@
 buffer = std::make_unique(WTFMove(texture));
 }
 updateTexture(buffer->textureGL(), videoInfo);
-buffer->setExtraFlags(m_textureMapperRotationFlag | (GST_VIDEO_INFO_HAS_ALPHA() ? TextureMapperGL::ShouldBlend : 0));
+buffer->setExtraFlags(texMapFlagFromOrientation(m_videoSourceOrientation) | (GST_VIDEO_INFO_HAS_ALPHA() ? TextureMapperGL::ShouldBlend : 0));
 m_platformLayerProxy->pushNextBuffer(WTFMove(buffer));
 #endif
 }
@@ -646,7 +663,7 @@
 return;
 
 size = IntSize(GST_VIDEO_INFO_WIDTH(), GST_VIDEO_INFO_HEIGHT());
-flags = m_textureMapperRotationFlag | (GST_VIDEO_INFO_HAS_ALPHA() ? TextureMapperGL::ShouldBlend : 0);
+flags = 

[webkit-changes] [206200] trunk/Source/WebCore

[commit-queue]

Title: [206200] trunk/Source/WebCore








Revision 206200
Author commit-qu...@webkit.org
Date 2016-09-21 00:09:30 -0700 (Wed, 21 Sep 2016)


Log Message
[GTK] Fix build failure in clipboard support
https://bugs.webkit.org/show_bug.cgi?id=162261

Patch by Jeremy Huddleston Sequoia  on 2016-09-21
Reviewed by Carlos Garcia Campos.

* platform/PlatformPasteboard.h: Add missing #include 
* platform/gtk/PasteboardHelper.h: Add missing #include 

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformPasteboard.h
trunk/Source/WebCore/platform/gtk/PasteboardHelper.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (206199 => 206200)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 06:44:04 UTC (rev 206199)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 07:09:30 UTC (rev 206200)
@@ -1,3 +1,13 @@
+2016-09-21  Jeremy Huddleston Sequoia  
+
+[GTK] Fix build failure in clipboard support
+https://bugs.webkit.org/show_bug.cgi?id=162261
+
+Reviewed by Carlos Garcia Campos.
+
+* platform/PlatformPasteboard.h: Add missing #include 
+* platform/gtk/PasteboardHelper.h: Add missing #include 
+
 2016-09-20  Nael Ouedraogo  
 
 VariadicHelper::Result should not include constructor to initialize members


Modified: trunk/Source/WebCore/platform/PlatformPasteboard.h (206199 => 206200)

--- trunk/Source/WebCore/platform/PlatformPasteboard.h	2016-09-21 06:44:04 UTC (rev 206199)
+++ trunk/Source/WebCore/platform/PlatformPasteboard.h	2016-09-21 07:09:30 UTC (rev 206200)
@@ -26,6 +26,7 @@
 #ifndef PlatformPasteboard_h
 #define PlatformPasteboard_h
 
+#include 
 #include 
 #include 
 #include 


Modified: trunk/Source/WebCore/platform/gtk/PasteboardHelper.h (206199 => 206200)

--- trunk/Source/WebCore/platform/gtk/PasteboardHelper.h	2016-09-21 06:44:04 UTC (rev 206199)
+++ trunk/Source/WebCore/platform/gtk/PasteboardHelper.h	2016-09-21 07:09:30 UTC (rev 206200)
@@ -26,6 +26,7 @@
 #define PasteboardHelper_h
 
 #include "GRefPtrGtk.h"
+#include 
 #include 
 #include 
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206199] trunk/Source/WebCore

[nael . ouedraogo]

Title: [206199] trunk/Source/WebCore








Revision 206199
Author nael.ouedra...@crf.canon.fr
Date 2016-09-20 23:44:04 -0700 (Tue, 20 Sep 2016)


Log Message
VariadicHelper::Result should not include constructor to initialize members
https://bugs.webkit.org/show_bug.cgi?id=162298

Reviewed by Darin Adler.

Remove the constructor since member-wise initialization does the same thing.

No new tests required.

* bindings/js/JSDOMBinding.h: Remove useless constructor.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMBinding.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (206198 => 206199)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 06:34:13 UTC (rev 206198)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 06:44:04 UTC (rev 206199)
@@ -1,3 +1,16 @@
+2016-09-20  Nael Ouedraogo  
+
+VariadicHelper::Result should not include constructor to initialize members
+https://bugs.webkit.org/show_bug.cgi?id=162298
+
+Reviewed by Darin Adler.
+
+Remove the constructor since member-wise initialization does the same thing.
+
+No new tests required.
+
+* bindings/js/JSDOMBinding.h: Remove useless constructor.
+
 2016-09-20  Alex Christensen  
 
 Optimize URLParser


Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (206198 => 206199)

--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h	2016-09-21 06:34:13 UTC (rev 206198)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h	2016-09-21 06:44:04 UTC (rev 206199)
@@ -358,11 +358,6 @@
 using Container = Vector;
 
 struct Result {
-Result(size_t argumentIndex, Optional&& arguments)
-: argumentIndex(argumentIndex)
-, arguments(WTFMove(arguments))
-{
-}
 size_t argumentIndex;
 Optional arguments;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [206198] trunk

[achristensen]

Title: [206198] trunk








Revision 206198
Author achristen...@apple.com
Date 2016-09-20 23:34:13 -0700 (Tue, 20 Sep 2016)


Log Message
Optimize URLParser
https://bugs.webkit.org/show_bug.cgi?id=162105

Reviewed by Geoffrey Garen.

Source/WebCore:

Covered by new API tests.
This is about a 5% speedup on my URLParser benchmark.

* platform/URLParser.cpp:
(WebCore::percentEncodeByte):
(WebCore::utf8PercentEncode):
(WebCore::utf8QueryEncode):
(WebCore::encodeQuery):
(WebCore::URLParser::parse):
(WebCore::serializeURLEncodedForm):
(WebCore::percentEncode): Deleted.
(WebCore::utf8PercentEncodeQuery): Deleted.

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (206197 => 206198)

--- trunk/Source/WebCore/ChangeLog	2016-09-21 06:17:13 UTC (rev 206197)
+++ trunk/Source/WebCore/ChangeLog	2016-09-21 06:34:13 UTC (rev 206198)
@@ -1,3 +1,23 @@
+2016-09-20  Alex Christensen  
+
+Optimize URLParser
+https://bugs.webkit.org/show_bug.cgi?id=162105
+
+Reviewed by Geoffrey Garen.
+
+Covered by new API tests.
+This is about a 5% speedup on my URLParser benchmark.
+
+* platform/URLParser.cpp:
+(WebCore::percentEncodeByte):
+(WebCore::utf8PercentEncode):
+(WebCore::utf8QueryEncode):
+(WebCore::encodeQuery):
+(WebCore::URLParser::parse):
+(WebCore::serializeURLEncodedForm):
+(WebCore::percentEncode): Deleted.
+(WebCore::utf8PercentEncodeQuery): Deleted.
+
 2016-09-20  Carlos Garcia Campos  
 
 [GTK] Clean up DataObjectGtk handling


Modified: trunk/Source/WebCore/platform/URLParser.cpp (206197 => 206198)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 06:17:13 UTC (rev 206197)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-09-21 06:34:13 UTC (rev 206198)
@@ -457,7 +457,7 @@
 return !isSlashQuestionOrHash(*iterator);
 }
 
-inline static void percentEncode(uint8_t byte, Vector& buffer)
+inline static void percentEncodeByte(uint8_t byte, Vector& buffer)
 {
 buffer.append('%');
 buffer.append(upperNibbleToASCIIHexDigit(byte));
@@ -464,6 +464,9 @@
 buffer.append(lowerNibbleToASCIIHexDigit(byte));
 }
 
+const char* replacementCharacterUTF8PercentEncoded = "%EF%BF%BD";
+const size_t replacementCharacterUTF8PercentEncodedLength = 9;
+
 template
 inline static void utf8PercentEncode(UChar32 codePoint, Vector& destination, bool(*isInCodeSet)(UChar32))
 {
@@ -472,23 +475,30 @@
 ASSERT_WITH_SECURITY_IMPLICATION(!isInCodeSet(codePoint));
 destination.append(codePoint);
 } else {
-if (isInCodeSet(codePoint)) {
-uint8_t buffer[U8_MAX_LENGTH];
-int32_t offset = 0;
-UBool error = false;
-U8_APPEND(buffer, offset, U8_MAX_LENGTH, codePoint, error);
-// FIXME: Check error.
-for (int32_t i = 0; i < offset; ++i)
-percentEncode(buffer[i], destination);
-} else {
-ASSERT_WITH_MESSAGE(isASCII(codePoint), "isInCodeSet should always return true for non-ASCII characters");
-destination.append(codePoint);
+if (isASCII(codePoint)) {
+if (isInCodeSet(codePoint))
+percentEncodeByte(codePoint, destination);
+else
+destination.append(codePoint);
+return;
 }
+ASSERT_WITH_MESSAGE(isInCodeSet(codePoint), "isInCodeSet should always return true for non-ASCII characters");
+
+if (!U_IS_UNICODE_CHAR(codePoint)) {
+destination.append(replacementCharacterUTF8PercentEncoded, replacementCharacterUTF8PercentEncodedLength);
+return;
+}
+
+uint8_t buffer[U8_MAX_LENGTH];
+int32_t offset = 0;
+U8_APPEND_UNSAFE(buffer, offset, codePoint);
+for (int32_t i = 0; i < offset; ++i)
+percentEncodeByte(buffer[i], destination);
 }
 }
 
 template
-inline static void utf8PercentEncodeQuery(UChar32 codePoint, Vector& destination)
+inline static void utf8QueryEncode(UChar32 codePoint, Vector& destination)
 {
 if (serialized) {
 ASSERT_WITH_SECURITY_IMPLICATION(isASCII(codePoint));
@@ -495,16 +505,26 @@
 ASSERT_WITH_SECURITY_IMPLICATION(!shouldPercentEncodeQueryByte(codePoint));
 destination.append(codePoint);
 } else {
+if (isASCII(codePoint)) {
+if (shouldPercentEncodeQueryByte(codePoint))
+percentEncodeByte(codePoint, destination);
+else
+destination.append(codePoint);
+return;
+}
+
+if (!U_IS_UNICODE_CHAR(codePoint)) {
+

[webkit-changes] [206197] trunk/Source

[carlosgc]

Title: [206197] trunk/Source








Revision 206197
Author carlo...@webkit.org
Date 2016-09-20 23:17:13 -0700 (Tue, 20 Sep 2016)


Log Message
[GTK] Clean up DataObjectGtk handling
https://bugs.webkit.org/show_bug.cgi?id=162267

Reviewed by Michael Catanzaro.

Source/WebCore:

* platform/Pasteboard.h: Use Ref instead of RefPtr for DataObjectGtk member.
* platform/PasteboardStrategy.h: Pass a const reference to DataObjectGtk in write method and return a Ref from read.
* platform/PlatformPasteboard.h: Ditto.
* platform/gtk/DataObjectGtk.h:
(WebCore::DataObjectGtk::image): Use Image instead of GdkPixbuf.
(WebCore::DataObjectGtk::setImage):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::createForDragAndDrop): Use a reference instead of a pointer.
(WebCore::Pasteboard::Pasteboard): Receives a reference, so we can also remove the ASSERT.
(WebCore::Pasteboard::dataObject):
(WebCore::Pasteboard::writeToClipboard): Remove the ShouldIncludeSmartPaste parameter, callers should also update
canSmartPaste property of DataObjectGtk before calling this.
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::write): Do not convert the image the GdkPixbuf, pass the image to the DataObjectGtk instead.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData): Convert the DataObjectGtk image to GdkPixbuf right before
passing it to gtk_selection_data_set_pixbuf().
(WebCore::ClipboardSetData::ClipboardSetData): Use reference instead of pointer.
(WebCore::getClipboardContentsCallback):
(WebCore::clearClipboardContentsCallback): Never clear the saved DataObjectGtk, that was only needed when we had
a global DataObjectGtk associated to a GtkClipboard.
(WebCore::PasteboardHelper::writeClipboardContents): Use TemporaryChange to set the settingClipboardDataObject global.
* platform/gtk/PlatformPasteboardGtk.cpp:
(WebCore::PlatformPasteboard::writeToClipboard):
(WebCore::PlatformPasteboard::readFromClipboard):

Source/WebKit2:

In some cases the ownership of DataObjectGtk instances is not clear enough, and we have hacks to avoid memory
leaks because of that.

* Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::encodeImage): Use Image instead of GdkPixbuf.
(IPC::decodeImage): Ditto.
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
(IPC::encode): Deleted.
(IPC::decode): Deleted.
(IPC::ArgumentCoder::encode): Deleted.
(IPC::ArgumentCoder::decode): Deleted.
* Shared/gtk/ArgumentCodersGtk.h:
* Shared/gtk/PasteboardContent.cpp:
(WebKit::PasteboardContent::PasteboardContent): Add empty constructor that creates a new DataObjectGtk, a
constructor that receives a const reference and another one that takes the ownership of the given DataObjectGtk.
(WebKit::PasteboardContent::encode):
(WebKit::PasteboardContent::decode):
* Shared/gtk/PasteboardContent.h: Use Ref instead of RefPtr for the DataObjectGtk member.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::startDrag): Transfer the DataObjectGtk to the DragAndDropHandler, instead of using DragData.
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction): Instead of sending a DragData object to the web process,
send the DataObjectGtk and DragData members needed as parameters.
(WebKit::WebPageProxy::startDrag): Transfer the received DataObjectGtk to page client, instead of using
DragData. Also notify the web process that drag started.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: Update StartDrag message parameters.
* UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler): Remove unneeded initialization.
(WebKit::DragAndDropHandler::startDrag): Take ownership of the given DataObjectGtk.
* UIProcess/gtk/DragAndDropHandler.h:
* UIProcess/gtk/WebPasteboardProxyGtk.cpp:
(WebKit::WebPasteboardProxy::writeToClipboard):
(WebKit::WebPasteboardProxy::readFromClipboard):
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::writeToClipboard):
(WebKit::WebPlatformStrategies::readFromClipboard):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::convertCairoSurfaceToShareableBitmap):
(WebKit::WebDragClient::startDrag): Do not create a DragData and pass the DataObjectGtk directly to the
message. Also notify the WebPage that drag is about to start.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction): Remove explicit DataObjectGtk derefs and simply create a
DragData using the DataObjectGtk pointer as platform data.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Update PerformDragControllerAction message parameters.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/PasteboardStrategy.h
trunk/Source/WebCore/platform/PlatformPasteboard.h
trunk/Source/WebCore/platform/gtk/DataObjectGtk.h