[webkit-changes] [208138] trunk/LayoutTests

2016-10-30 Thread gyuyoung . kim 
Title: [208138] trunk/LayoutTests








Revision 208138
Author gyuyoung@webkit.org
Date 2016-10-30 22:22:42 -0700 (Sun, 30 Oct 2016)


Log Message
[EFL] Skip media tests because timeout happens on many media tests.

Unreviewed EFL gardening.

Treat the media folder to *Skip* temporarily.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208137 => 208138)

--- trunk/LayoutTests/ChangeLog	2016-10-31 00:48:18 UTC (rev 208137)
+++ trunk/LayoutTests/ChangeLog	2016-10-31 05:22:42 UTC (rev 208138)
@@ -1,3 +1,13 @@
+2016-10-30  Gyuyoung Kim  
+
+[EFL] Skip media tests because timeout happens on many media tests.
+
+Unreviewed EFL gardening.
+
+Treat the media folder to *Skip* temporarily.
+
+* platform/efl/TestExpectations:
+
 2016-10-30  Darin Adler  
 
 Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception


Modified: trunk/LayoutTests/platform/efl/TestExpectations (208137 => 208138)

--- trunk/LayoutTests/platform/efl/TestExpectations	2016-10-31 00:48:18 UTC (rev 208137)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2016-10-31 05:22:42 UTC (rev 208138)
@@ -46,12 +46,6 @@
 # EFL's LayoutTestController does not implement keepWebHistory
 fast/history/window-open.html
 
-# EFL's LayoutTestController does not implement shadowPseudoId
-media/video-volume-slider.html
-
-# BUG: Captions support needed in the media engine (via GTK+)
-media/media-captions.html
-
 # The EFL port has no support for detecting slow unload handlers
 fast/dom/Window/slow-unload-handler.html
 fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
@@ -135,16 +129,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=68278
 http/tests/history/back-with-fragment-change.php
 
-# Failing http tests (via GTK+)
-http/tests/loading/bad-scheme-subframe.html
-http/tests/media/video-play-stall-seek.html
-http/tests/media/video-play-stall.html
-http/tests/media/video-play-waiting.html
-http/tests/security/feed-urls-from-remote.html
-http/tests/media/video-buffered-range-contains-currentTime.html [ Timeout ]
-media/airplay-autoplay.html [ Timeout ]
-media/media-fullscreen-return-to-inline.html [ Timeout ]
-
 # --
 # Tests which need investigation
 # --
@@ -227,9 +211,6 @@
 fast/text/international/bidi-menulist.html
 fast/text/international/pop-up-button-text-alignment-and-direction.html
 
-# BUG: video sizes not being set properly
-media/video-size-intrinsic-scale.html
-
 # BUG: the theme probably has a different thumb value
 fast/forms/range/slider-zoomed.html
 
@@ -566,11 +547,6 @@
 # ENABLE_GAMEPAD not enabled.
 webkit.org/b/134718 gamepad [ Skip ]
 
-# These tests are for an obsolete version of the EME spec.
-media/encrypted-media/encrypted-media-events.html [ WontFix ]
-media/encrypted-media/encrypted-media-not-loaded.html [ WontFix ]
-media/encrypted-media/encrypted-media-syntax.html [ WontFix ]
-
 # No support for Filters Level 2 on EFL yet
 Bug(EFL) css3/filters/backdrop [ Skip ]
 
@@ -580,9 +556,6 @@
 # EFL port doesn't support attachment feature yet. It was added by r180193, r181056, r181114, r181118 and r181418.
 webkit.org/b/141894 fast/attachment [ Skip ]
 
-# EFL port doesn't fully support EME yet.
-webkit.org/b/141959 http/tests/media/clearkey/clear-key-hls-aes128.html [ Crash ]
-
 # Need a new baseline for EFL port. It was added by r72173.
 Bug(EFL) fast/css/line-height-determined-by-primary-font.html [ Failure ]
 
@@ -614,13 +587,6 @@
 webkit.org/b/105870 webaudio/audionode-channel-rules.html [ Pass Crash ]
 webkit.org/b/105870 webaudio/mediastreamaudiosourcenode.html [ Crash Timeout ]
 
-# Media regressions after updating to gstreamer 1.0.
-webkit.org/b/104809 media/video-src.html [ Crash Pass ]
-webkit.org/b/104809 media/video-src-blob.html [ Crash Failure Timeout ]
-webkit.org/b/104809 media/video-src-change.html [ Crash Pass Failure ]
-webkit.org/b/104809 media/remove-from-document.html [ Crash Pass Failure ]
-webkit.org/b/104809 media/video-timeupdate-during-playback.html [ Crash Pass Failure ]
-
 # Sometimes crashes in PlatformContextCairo::drawSurfaceToContext().
 webkit.org/b/116025 compositing/video/video-background-color.html [ Crash Pass Failure ]
 
@@ -774,8 +740,6 @@
 webkit.org/b/131729 http/tests/misc/acid3.html [ Failure Pass ]
 webkit.org/b/131729 http/tests/misc/image-blocked-src-change.html [ Failure Pass ]
 webkit.org/b/131729 http/tests/misc/slow-loading-image-in-pattern.html [ Failure ]
-webkit.org/b/131729 http/tests/media/video-error-abort.html [ Crash Pass ]
-webkit.org/b/131729 http/tests/media/video-redirect.html [ Crash Pass ]
 webkit.org/b/131729 http/tests/security/cross-origin-plugin-private-browsing-toggled.html [ Failure ]
 webkit.org/b/131729 http/tests/security/drag-drop-local-file.html [ Failure ]
 webkit.org/b/131729 http/tests/security/svg-image-wit

[webkit-changes] [208137] trunk/Source/WebCore/ChangeLog

2016-10-30 Thread bfulgham 
Title: [208137] trunk/Source/WebCore/ChangeLog








Revision 208137
Author bfulg...@apple.com
Date 2016-10-30 17:48:18 -0700 (Sun, 30 Oct 2016)


Log Message
Unreviewed fix: Correct ChangeLog after my bad merge.

* ChangeLog

Modified Paths

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (208136 => 208137)

--- trunk/Source/WebCore/ChangeLog	2016-10-30 23:27:43 UTC (rev 208136)
+++ trunk/Source/WebCore/ChangeLog	2016-10-31 00:48:18 UTC (rev 208137)
@@ -1,3 +1,9 @@
+2016-10-30  Brent Fulgham  
+
+Unreviewed fix: Correct ChangeLog after my bad merge.
+
+* ChangeLog
+
 2016-10-30  Darin Adler  
 
 Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
@@ -154,7 +160,7 @@
 and then serialize them. Strip whitepsace from the ends and set that
 as the selector argument.
 
-2016-10-28  Brent Fulgham  
+2016-10-30  Brent Fulgham  
 
 [Win][Direct2D] Correct bookkeeping for begin/end draw pairs
 https://bugs.webkit.org/show_bug.cgi?id=163898
@@ -209,6 +215,1567 @@
 * svg/graphics/SVGImage.cpp:
 (WebCore::SVGImage::nativeImage): Remove unneeded use of RenderTargetScopedDrawing class.
 
+2016-10-30  Dave Hyatt   
+
+[CSS Parser] Clean up the two types of descendant relations in CSSSelector 
+https://bugs.webkit.org/show_bug.cgi?id=164203 
+
+Reviewed by Zalan Bujtas. 
+
+This patch gets rid of the separate boolean for double child and allows it 
+to be a unique relation type. Rename Descendant to DescendantSpace and 
+name the new relation DescendantDoubleChild. 
+
+* css/CSSSelector.cpp: 
+(WebCore::CSSSelector::CSSSelector): 
+(WebCore::CSSSelector::selectorText): 
+* css/CSSSelector.h: 
+(WebCore::CSSSelector::hasDescendantRelation): 
+(WebCore::CSSSelector::hasDescendantOrChildRelation): 
+(WebCore::CSSSelector::CSSSelector): 
+(WebCore::CSSSelector::setDescendantUseDoubleChildSyntax): Deleted. 
+* css/RuleFeature.cpp: 
+(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector): 
+* css/SelectorChecker.cpp: 
+(WebCore::SelectorChecker::matchRecursively): 
+(WebCore::SelectorChecker::determineLinkMatchType): 
+* css/SelectorFilter.cpp: 
+(WebCore::SelectorFilter::collectIdentifierHashes): 
+* css/parser/CSSParserValues.cpp: 
+(WebCore::CSSParserSelector::appendTagHistory): 
+* css/parser/CSSParserValues.h: 
+(WebCore::CSSParserSelector::setDescendantUseDoubleChildSyntax): Deleted. 
+* css/parser/CSSSelectorParser.cpp: 
+(WebCore::isDescendantCombinator): 
+(WebCore::CSSSelectorParser::consumeComplexSelector): 
+(WebCore::CSSSelectorParser::consumeCombinator): 
+* cssjit/SelectorCompiler.cpp: 
+(WebCore::SelectorCompiler::fragmentRelationForSelectorRelation): 
+
+2016-10-30  Frederic Wang   
+
+Unreviewed gardening 
+
+Fix build error on WinCairo. 
+
+* platform/graphics/opentype/OpenTypeMathData.cpp: 
+
+2016-10-30  Frederic Wang   
+
+Use HarfBuzz ot-math API to parse the OpenType MATH table 
+https://bugs.webkit.org/show_bug.cgi?id=162671 
+
+Reviewed by Michael Catanzaro. 
+
+No new tests, already covered by existing tests. 
+
+* platform/graphics/opentype/OpenTypeMathData.cpp: Add alternative implementation relying on 
+HarfBuzz's new OpenType MATH API. 
+* platform/graphics/opentype/OpenTypeMathData.h: Ditto. 
+(WebCore::OpenTypeMathData::hasMathData): 
+(WebCore::OpenTypeMathData::HbFontDeleter::operator()): 
+
+2016-10-29  Dave Hyatt   
+
+[CSS Parser] Support unprefixed image-sets 
+https://bugs.webkit.org/show_bug.cgi?id=164198 
+
+Reviewed by Dean Jackson. 
+
+* css/CSSValueKeywords.in: 
+* css/parser/CSSPropertyParserHelpers.cpp: 
+(WebCore::CSSPropertyParserHelpers::consumeImage): 
+
+2016-10-30  Yusuke Suzuki   
+
+[DOM] Introduce WebCore::jsDynamicDowncast 
+https://bugs.webkit.org/show_bug.cgi?id=164137 
+ 
+Reviewed by Darin Adler. 
+
+In WebCore, we have several extended JSTypes, like JSElementType. 
+For these types, WebCore offers the faster casting function compared 
+to JSC::jsDynamicCast. For example, for JSElementType, we have 
+jsElementCast. 
+
+The problem is that we may fall into the slow code if we choose 
+JSC::jsDynamicCast by accident. Selecting the appropriate function 
+requires special care in the IDL code generator when we would like 
+to use faster casting functions. 
+
+This patch implements a new casting function, WebCore::jsDynamicDowncast. 
+It is a thin wrapper to the JSC::jsDynamicCast. But it selects the 
+faster casting functions correctly

[webkit-changes] [208136] trunk/Source/ThirdParty/ANGLE

2016-10-30 Thread mcatanzaro 
Title: [208136] trunk/Source/ThirdParty/ANGLE








Revision 208136
Author mcatanz...@igalia.com
Date 2016-10-30 16:27:43 -0700 (Sun, 30 Oct 2016)


Log Message
-Wpragmas warning spam from angleutils.h
https://bugs.webkit.org/show_bug.cgi?id=164207

Reviewed by Darin Adler.

Use #pragma clang instead of #pragma GCC since all of the warnings we need to suppress are
Clang-specific warnings. GCC ignores unknown pragmas and does not warn, but it does warn if
any GCC pragma is invalid.

Note that this might still be broken for MSVCC, as MSVCC warns when it sees unknown pragmas.

* changes.diff:
* src/common/angleutils.cpp:
(FormatString):
* src/common/angleutils.h:
(MakeStaticString):
* src/common/debug.cpp:
* src/common/mathutil.cpp:
* src/libANGLE/Caps.cpp:
(gl::TextureCapsMap::get):
(gl::GetExtensionInfoMap):
* src/libANGLE/Device.cpp:
(egl::GetDeviceSet):
* src/libANGLE/Display.cpp:
(egl::Display::getClientExtensionString):
* src/libANGLE/formatutils.cpp:
(gl::GetInternalFormatMap):
(gl::GetAllSizedInternalFormats):
* src/libANGLE/validationES3.cpp:
(gl::IsValidES3CopyTexImageCombination):

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/changes.diff
trunk/Source/ThirdParty/ANGLE/src/common/angleutils.cpp
trunk/Source/ThirdParty/ANGLE/src/common/angleutils.h
trunk/Source/ThirdParty/ANGLE/src/common/debug.cpp
trunk/Source/ThirdParty/ANGLE/src/common/mathutil.cpp
trunk/Source/ThirdParty/ANGLE/src/libANGLE/Caps.cpp
trunk/Source/ThirdParty/ANGLE/src/libANGLE/Device.cpp
trunk/Source/ThirdParty/ANGLE/src/libANGLE/Display.cpp
trunk/Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp
trunk/Source/ThirdParty/ANGLE/src/libANGLE/validationES3.cpp




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (208135 => 208136)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-10-30 22:36:07 UTC (rev 208135)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2016-10-30 23:27:43 UTC (rev 208136)
@@ -1,3 +1,36 @@
+2016-10-30  Michael Catanzaro  
+
+-Wpragmas warning spam from angleutils.h
+https://bugs.webkit.org/show_bug.cgi?id=164207
+
+Reviewed by Darin Adler.
+
+Use #pragma clang instead of #pragma GCC since all of the warnings we need to suppress are
+Clang-specific warnings. GCC ignores unknown pragmas and does not warn, but it does warn if
+any GCC pragma is invalid.
+
+Note that this might still be broken for MSVCC, as MSVCC warns when it sees unknown pragmas.
+
+* changes.diff:
+* src/common/angleutils.cpp:
+(FormatString):
+* src/common/angleutils.h:
+(MakeStaticString):
+* src/common/debug.cpp:
+* src/common/mathutil.cpp:
+* src/libANGLE/Caps.cpp:
+(gl::TextureCapsMap::get):
+(gl::GetExtensionInfoMap):
+* src/libANGLE/Device.cpp:
+(egl::GetDeviceSet):
+* src/libANGLE/Display.cpp:
+(egl::Display::getClientExtensionString):
+* src/libANGLE/formatutils.cpp:
+(gl::GetInternalFormatMap):
+(gl::GetAllSizedInternalFormats):
+* src/libANGLE/validationES3.cpp:
+(gl::IsValidES3CopyTexImageCombination):
+
 2016-10-28  Alex Christensen  
 
 Another build fix.


Modified: trunk/Source/ThirdParty/ANGLE/changes.diff (208135 => 208136)

--- trunk/Source/ThirdParty/ANGLE/changes.diff	2016-10-30 22:36:07 UTC (rev 208135)
+++ trunk/Source/ThirdParty/ANGLE/changes.diff	2016-10-30 23:27:43 UTC (rev 208136)
@@ -135,10 +135,10 @@
  
  std::string FormatString(const char *fmt, va_list vararg)
  {
-+#pragma GCC diagnostic push
-+#pragma GCC diagnostic ignored "-Wexit-time-destructors"
++#pragma clang diagnostic push
++#pragma clang diagnostic ignored "-Wexit-time-destructors"
  static std::vector buffer(512);
-+#pragma GCC diagnostic pop
++#pragma clang diagnostic pop
  
  size_t len = FormatStringIntoVector(fmt, vararg, buffer);
  return std::string(&buffer[0], len);
@@ -150,10 +150,10 @@
  
  inline const char* MakeStaticString(const std::string &str)
  {
-+#pragma GCC diagnostic push
-+#pragma GCC diagnostic ignored "-Wexit-time-destructors"
++#pragma clang diagnostic push
++#pragma clang diagnostic ignored "-Wexit-time-destructors"
  static std::set strings;
-+#pragma GCC diagnostic pop
++#pragma clang diagnostic pop
  std::set::iterator it = strings.find(str);
  if (it != strings.end())
  {
@@ -165,10 +165,10 @@
  {
  if (DebugAnnotationsActive())
  {
-+#pragma GCC diagnostic push
-+#pragma GCC diagnostic ignored "-Wexit-time-destructors"
++#pragma clang diagnostic push
++#pragma clang diagnostic ignored "-Wexit-time-destructors"
  static std::vector buffer(512);
-+#pragma GCC diagnostic pop
++#pragma clang diagnostic pop
  size_t len = FormatStringIntoVector(format, vararg, buffer);
  std::wstring formattedWideMessage(buffer.begin(), buffer.begin() + len);
  
@@ -180,12 +180,12 @@
  // Emax is the maximum allowed biased exponen

[webkit-changes] [208133] trunk/Source/WebCore

2016-10-30 Thread hyatt 
Title: [208133] trunk/Source/WebCore








Revision 208133
Author hy...@apple.com
Date 2016-10-30 15:33:02 -0700 (Sun, 30 Oct 2016)


Log Message
[CSS Parser] Fix nth-child serialization
https://bugs.webkit.org/show_bug.cgi?id=164210

Reviewed by Darin Adler.

Our nth-child serialization preserves what the author originally
typed. Even though this is not spec-compliant (the latest CSS Syntax
spec has a dumbed down serialization process that doesn't preserve what
the author originally typed), I think it's better behavior to preserve
this text.

* css/parser/CSSParserToken.cpp:
(WebCore::CSSParserToken::serialize):
Fix a bug in the serialization of number tokens that started with
a plus sign. Make sure the plus sign is preserved.

* css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumePseudo):
Grab the range of tokens from after the ( and up to the ) or the "of"
and then serialize them. Strip whitepsace from the ends and set that
as the selector argument.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSParserToken.cpp
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208132 => 208133)

--- trunk/Source/WebCore/ChangeLog	2016-10-30 20:48:22 UTC (rev 208132)
+++ trunk/Source/WebCore/ChangeLog	2016-10-30 22:33:02 UTC (rev 208133)
@@ -1,3 +1,27 @@
+2016-10-30  Dave Hyatt  
+
+[CSS Parser] Fix nth-child serialization
+https://bugs.webkit.org/show_bug.cgi?id=164210
+
+Reviewed by Darin Adler.
+
+Our nth-child serialization preserves what the author originally
+typed. Even though this is not spec-compliant (the latest CSS Syntax
+spec has a dumbed down serialization process that doesn't preserve what
+the author originally typed), I think it's better behavior to preserve
+this text.
+
+* css/parser/CSSParserToken.cpp:
+(WebCore::CSSParserToken::serialize):
+Fix a bug in the serialization of number tokens that started with
+a plus sign. Make sure the plus sign is preserved.
+
+* css/parser/CSSSelectorParser.cpp:
+(WebCore::CSSSelectorParser::consumePseudo):
+Grab the range of tokens from after the ( and up to the ) or the "of"
+and then serialize them. Strip whitepsace from the ends and set that
+as the selector argument.
+
 2016-10-28  Brent Fulgham  
 
 [Win][Direct2D] Correct bookkeeping for begin/end draw pairs


Modified: trunk/Source/WebCore/css/parser/CSSParserToken.cpp (208132 => 208133)

--- trunk/Source/WebCore/css/parser/CSSParserToken.cpp	2016-10-30 20:48:22 UTC (rev 208132)
+++ trunk/Source/WebCore/css/parser/CSSParserToken.cpp	2016-10-30 22:33:02 UTC (rev 208133)
@@ -412,6 +412,8 @@
 return builder.append(delimiter());
 case NumberToken:
 // These won't properly preserve the NumericValueType flag
+if (m_numericSign == PlusSign)
+builder.append('+');
 return builder.appendNumber(numericValue());
 case PercentageToken:
 builder.appendNumber(numericValue());


Modified: trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp (208132 => 208133)

--- trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp	2016-10-30 20:48:22 UTC (rev 208132)
+++ trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp	2016-10-30 22:33:02 UTC (rev 208133)
@@ -540,7 +540,9 @@
 block.consumeWhitespace();
 if (token.type() != FunctionToken)
 return nullptr;
-
+
+const auto& argumentStart = block.peek();
+
 if (selector->match() == CSSSelector::PseudoClass) {
 switch (selector->pseudoClassType()) {
 case CSSSelector::PseudoClassNot: {
@@ -560,6 +562,10 @@
 if (!consumeANPlusB(block, ab))
 return nullptr;
 block.consumeWhitespace();
+const auto& argumentEnd = block.peek();
+auto rangeOfANPlusB = block.makeSubRange(&argumentStart, &argumentEnd);
+auto argument = rangeOfANPlusB.serialize();
+selector->setArgument(argument.stripWhiteSpace());
 if (!block.atEnd()) {
 if (block.peek().type() != IdentToken)
 return nullptr;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208132] trunk/Source/WebKit/win

2016-10-30 Thread bfulgham 
Title: [208132] trunk/Source/WebKit/win








Revision 208132
Author bfulg...@apple.com
Date 2016-10-30 13:48:22 -0700 (Sun, 30 Oct 2016)


Log Message
Unreviewed build fix (Direct2D)

* WebView.cpp:
(WebView::paintWithDirect2D): Update for revised GraphicsContext
begin/end draw behavior.

Modified Paths

trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp




Diff

Modified: trunk/Source/WebKit/win/ChangeLog (208131 => 208132)

--- trunk/Source/WebKit/win/ChangeLog	2016-10-30 20:47:16 UTC (rev 208131)
+++ trunk/Source/WebKit/win/ChangeLog	2016-10-30 20:48:22 UTC (rev 208132)
@@ -1,3 +1,11 @@
+2016-10-30  Brent Fulgham  
+
+Unreviewed build fix (Direct2D)
+
+* WebView.cpp:
+(WebView::paintWithDirect2D): Update for revised GraphicsContext
+begin/end draw behavior.
+
 2016-10-28  Darin Adler  
 
 Move all classes in the HTML directory from ExceptionCode to Exception


Modified: trunk/Source/WebKit/win/WebView.cpp (208131 => 208132)

--- trunk/Source/WebKit/win/WebView.cpp	2016-10-30 20:47:16 UTC (rev 208131)
+++ trunk/Source/WebKit/win/WebView.cpp	2016-10-30 20:48:22 UTC (rev 208132)
@@ -197,10 +197,6 @@
 #include 
 #endif
 
-#if USE(DIRECT2D)
-#include 
-#endif
-
 #include 
 #include 
 #include 
@@ -1251,8 +1247,6 @@
 GraphicsContext gc(m_renderTarget.get());
 
 {
-WebCore::RenderTargetScopedDrawing scopedDraw(gc);
-
 m_renderTarget->SetTags(WEBKIT_DRAWING, __LINE__);
 m_renderTarget->Clear();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208131] trunk/Source/WebCore

2016-10-30 Thread bfulgham 
Title: [208131] trunk/Source/WebCore








Revision 208131
Author bfulg...@apple.com
Date 2016-10-30 13:47:16 -0700 (Sun, 30 Oct 2016)


Log Message
[Win][Direct2D] Correct bookkeeping for begin/end draw pairs
https://bugs.webkit.org/show_bug.cgi?id=163898

Reviewed by Darin Adler.

Simon pointed out that GraphicsContext objects are generally only created at
the time we intend to do drawing, so calling 'BeginDraw' as part of object
construction, and 'EndDraw' at time of destruction should be sufficient.

As usual, he was correct.

This patch gets rid of unneeded code and greatly simplifies the Direct2D
drawing path.

Tested by existing layout tests.

* platform/graphics/GraphicsContext.h:
* platform/graphics/win/GradientDirect2D.cpp:
(WebCore::Gradient::fill):Remove unneeded use
of 'RenderTargetScopedDrawing.h'.
* platform/graphics/win/GraphicsContextDirect2D.cpp:
(WebCore::GraphicsContext::releaseWindowsContext): Remove unneeded use
of RenderTargetScopedDrawing class.
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): Enter
the 'BeginDraw' state at object creation.
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): End
draw state at object destruction.
(WebCore::GraphicsContextPlatformPrivate::clip): Remove unneeded call to 'beginDraw'.
(WebCore::GraphicsContextPlatformPrivate::beginDraw): Renamed from 'beginDrawIfNeeded'.
(WebCore::GraphicsContextPlatformPrivate::endDraw): Get rid of draw state flags.
(WebCore::GraphicsContext::beginDraw): Renamed from 'beginDrawIfNeeded'.
(WebCore::GraphicsContext::flush): Added.
(WebCore::GraphicsContext::drawWithoutShadow): Remove unneeded use of
RenderTargetScopedDrawing class.
(WebCore::GraphicsContext::drawWithShadow): Ditto.
(WebCore::GraphicsContext::platformFillRoundedRect): Ditto.
(WebCore::GraphicsContext::fillRectWithRoundedHole): Ditto.
(WebCore::GraphicsContext::didBeginDraw): Deleted.
(WebCore::GraphicsContextPlatformPrivate::beginDrawIfNeeded): Deleted.
(WebCore::GraphicsContext::beginDrawIfNeeded): Deleted.
* platform/graphics/win/GraphicsContextPlatformPrivateDirect2D.h:
(WebCore::GraphicsContextPlatformPrivate::didBeginDraw): Deleted.
* platform/graphics/win/ImageBufferDataDirect2D.cpp:
(WebCore::ImageBufferData::getData): Remove unneeded use of RenderTargetScopedDrawing class.
(WebCore::ImageBufferData::putData):
* platform/graphics/win/ImageBufferDirect2D.cpp:
(WebCore::ImageBuffer::flushContext): Call new GraphicsContext 'flush' command.
(WebCore::ImageBuffer::draw): Remove unneeded use of RenderTargetScopedDrawing class.
* platform/graphics/win/NativeImageDirect2D.cpp: Ditto.
* platform/graphics/win/RenderTargetScopedDrawing.h: Removed.
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImage): Remove unneeded use of RenderTargetScopedDrawing class.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/win/GradientDirect2D.cpp
trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp
trunk/Source/WebCore/platform/graphics/win/GraphicsContextPlatformPrivateDirect2D.h
trunk/Source/WebCore/platform/graphics/win/ImageBufferDataDirect2D.cpp
trunk/Source/WebCore/platform/graphics/win/ImageBufferDirect2D.cpp
trunk/Source/WebCore/platform/graphics/win/NativeImageDirect2D.cpp
trunk/Source/WebCore/svg/graphics/SVGImage.cpp


Removed Paths

trunk/Source/WebCore/platform/graphics/win/RenderTargetScopedDrawing.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (208130 => 208131)

--- trunk/Source/WebCore/ChangeLog	2016-10-30 18:48:09 UTC (rev 208130)
+++ trunk/Source/WebCore/ChangeLog	2016-10-30 20:47:16 UTC (rev 208131)
@@ -1,1585 +1,58 @@
-2016-10-30  Dave Hyatt  
+2016-10-28  Brent Fulgham  
 
-[CSS Parser] Clean up the two types of descendant relations in CSSSelector
-https://bugs.webkit.org/show_bug.cgi?id=164203
+[Win][Direct2D] Correct bookkeeping for begin/end draw pairs
+https://bugs.webkit.org/show_bug.cgi?id=163898
 
-Reviewed by Zalan Bujtas.
-
-This patch gets rid of the separate boolean for double child and allows it
-to be a unique relation type. Rename Descendant to DescendantSpace and
-name the new relation DescendantDoubleChild.
-
-* css/CSSSelector.cpp:
-(WebCore::CSSSelector::CSSSelector):
-(WebCore::CSSSelector::selectorText):
-* css/CSSSelector.h:
-(WebCore::CSSSelector::hasDescendantRelation):
-(WebCore::CSSSelector::hasDescendantOrChildRelation):
-(WebCore::CSSSelector::CSSSelector):
-(WebCore::CSSSelector::setDescendantUseDoubleChildSyntax): Deleted.
-* css/RuleFeature.cpp:
-(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
-* css/SelectorChecker.cpp:
-(WebCore::SelectorChecker::matchRecursively):
-(WebCore::SelectorChecker::determineLinkMatchType):
-* css/SelectorFilter.cpp

[webkit-changes] [208130] trunk/Source/WebCore

2016-10-30 Thread hyatt 
Title: [208130] trunk/Source/WebCore








Revision 208130
Author hy...@apple.com
Date 2016-10-30 11:48:09 -0700 (Sun, 30 Oct 2016)


Log Message
[CSS Parser] Clean up the two types of descendant relations in CSSSelector
https://bugs.webkit.org/show_bug.cgi?id=164203

Reviewed by Zalan Bujtas.

This patch gets rid of the separate boolean for double child and allows it
to be a unique relation type. Rename Descendant to DescendantSpace and
name the new relation DescendantDoubleChild.

* css/CSSSelector.cpp:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
(WebCore::CSSSelector::hasDescendantRelation):
(WebCore::CSSSelector::hasDescendantOrChildRelation):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::setDescendantUseDoubleChildSyntax): Deleted.
* css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::determineLinkMatchType):
* css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectIdentifierHashes):
* css/parser/CSSParserValues.cpp:
(WebCore::CSSParserSelector::appendTagHistory):
* css/parser/CSSParserValues.h:
(WebCore::CSSParserSelector::setDescendantUseDoubleChildSyntax): Deleted.
* css/parser/CSSSelectorParser.cpp:
(WebCore::isDescendantCombinator):
(WebCore::CSSSelectorParser::consumeComplexSelector):
(WebCore::CSSSelectorParser::consumeCombinator):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::fragmentRelationForSelectorRelation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSSelector.cpp
trunk/Source/WebCore/css/CSSSelector.h
trunk/Source/WebCore/css/RuleFeature.cpp
trunk/Source/WebCore/css/SelectorChecker.cpp
trunk/Source/WebCore/css/SelectorFilter.cpp
trunk/Source/WebCore/css/parser/CSSParserValues.cpp
trunk/Source/WebCore/css/parser/CSSParserValues.h
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208129 => 208130)

--- trunk/Source/WebCore/ChangeLog	2016-10-30 16:35:12 UTC (rev 208129)
+++ trunk/Source/WebCore/ChangeLog	2016-10-30 18:48:09 UTC (rev 208130)
@@ -1,3 +1,40 @@
+2016-10-30  Dave Hyatt  
+
+[CSS Parser] Clean up the two types of descendant relations in CSSSelector
+https://bugs.webkit.org/show_bug.cgi?id=164203
+
+Reviewed by Zalan Bujtas.
+
+This patch gets rid of the separate boolean for double child and allows it
+to be a unique relation type. Rename Descendant to DescendantSpace and
+name the new relation DescendantDoubleChild.
+
+* css/CSSSelector.cpp:
+(WebCore::CSSSelector::CSSSelector):
+(WebCore::CSSSelector::selectorText):
+* css/CSSSelector.h:
+(WebCore::CSSSelector::hasDescendantRelation):
+(WebCore::CSSSelector::hasDescendantOrChildRelation):
+(WebCore::CSSSelector::CSSSelector):
+(WebCore::CSSSelector::setDescendantUseDoubleChildSyntax): Deleted.
+* css/RuleFeature.cpp:
+(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
+* css/SelectorChecker.cpp:
+(WebCore::SelectorChecker::matchRecursively):
+(WebCore::SelectorChecker::determineLinkMatchType):
+* css/SelectorFilter.cpp:
+(WebCore::SelectorFilter::collectIdentifierHashes):
+* css/parser/CSSParserValues.cpp:
+(WebCore::CSSParserSelector::appendTagHistory):
+* css/parser/CSSParserValues.h:
+(WebCore::CSSParserSelector::setDescendantUseDoubleChildSyntax): Deleted.
+* css/parser/CSSSelectorParser.cpp:
+(WebCore::isDescendantCombinator):
+(WebCore::CSSSelectorParser::consumeComplexSelector):
+(WebCore::CSSSelectorParser::consumeCombinator):
+* cssjit/SelectorCompiler.cpp:
+(WebCore::SelectorCompiler::fragmentRelationForSelectorRelation):
+
 2016-10-30  Frederic Wang  
 
 Unreviewed gardening


Modified: trunk/Source/WebCore/css/CSSSelector.cpp (208129 => 208130)

--- trunk/Source/WebCore/css/CSSSelector.cpp	2016-10-30 16:35:12 UTC (rev 208129)
+++ trunk/Source/WebCore/css/CSSSelector.cpp	2016-10-30 18:48:09 UTC (rev 208130)
@@ -50,7 +50,7 @@
 static_assert(sizeof(CSSSelector) == sizeof(SameSizeAsCSSSelector), "CSSSelector should remain small.");
 
 CSSSelector::CSSSelector(const QualifiedName& tagQName, bool tagIsForNamespaceRule)
-: m_relation(Descendant)
+: m_relation(DescendantSpace)
 , m_match(Tag)
 , m_pseudoType(0)
 , m_parsedNth(false)
@@ -60,9 +60,6 @@
 , m_hasNameWithCase(false)
 , m_isForPage(false)
 , m_tagIsForNamespaceRule(tagIsForNamespaceRule)
-#if ENABLE(CSS_SELECTORS_LEVEL4)
-, m_descendantDoubleChildSyntax(false)
-#endif
 , m_caseInsensitiveAttributeValueMatching(false)
 #if !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED
 , m_destructorHasBeenCalled(false)
@@ -7

[webkit-changes] [208129] trunk/Source/WebCore

2016-10-30 Thread fred . wang 
Title: [208129] trunk/Source/WebCore








Revision 208129
Author fred.w...@free.fr
Date 2016-10-30 09:35:12 -0700 (Sun, 30 Oct 2016)


Log Message
Unreviewed gardening

Fix build error on WinCairo.

Patch by Frederic Wang  on 2016-10-30

* platform/graphics/opentype/OpenTypeMathData.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208128 => 208129)

--- trunk/Source/WebCore/ChangeLog	2016-10-30 16:18:57 UTC (rev 208128)
+++ trunk/Source/WebCore/ChangeLog	2016-10-30 16:35:12 UTC (rev 208129)
@@ -1,5 +1,13 @@
 2016-10-30  Frederic Wang  
 
+Unreviewed gardening
+
+Fix build error on WinCairo.
+
+* platform/graphics/opentype/OpenTypeMathData.cpp:
+
+2016-10-30  Frederic Wang  
+
 Use HarfBuzz ot-math API to parse the OpenType MATH table
 https://bugs.webkit.org/show_bug.cgi?id=162671
 


Modified: trunk/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp (208128 => 208129)

--- trunk/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp	2016-10-30 16:18:57 UTC (rev 208128)
+++ trunk/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp	2016-10-30 16:35:12 UTC (rev 208129)
@@ -266,7 +266,6 @@
 #else
 OpenTypeMathData::OpenTypeMathData(const FontPlatformData&)
 {
-m_mathBuffer = nullptr;
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208128] trunk

2016-10-30 Thread commit-queue 
Title: [208128] trunk








Revision 208128
Author commit-qu...@webkit.org
Date 2016-10-30 09:18:57 -0700 (Sun, 30 Oct 2016)


Log Message
Use HarfBuzz ot-math API to parse the OpenType MATH table
https://bugs.webkit.org/show_bug.cgi?id=162671

Patch by Frederic Wang  on 2016-10-30
Reviewed by Michael Catanzaro.

.:

* Source/cmake/OptionsGTK.cmake: Enable internal OpenType MATH parsing for HarfBuzz < 1.3.3.

Source/WebCore:

No new tests, already covered by existing tests.

* platform/graphics/opentype/OpenTypeMathData.cpp: Add alternative implementation relying on
HarfBuzz's new OpenType MATH API.
* platform/graphics/opentype/OpenTypeMathData.h: Ditto.
(WebCore::OpenTypeMathData::hasMathData):
(WebCore::OpenTypeMathData::HbFontDeleter::operator()):

Source/WTF:

* wtf/Platform.h: By default, do not enable internal OpenType MATH parsing on GTK.

LayoutTests:

Rebaseline one test for large operators due to small rendering changes.

* platform/gtk/mathml/opentype/opentype-stretchy-expected.png:
* platform/gtk/mathml/opentype/opentype-stretchy-expected.txt:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.png
trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.cpp
trunk/Source/WebCore/platform/graphics/opentype/OpenTypeMathData.h
trunk/Source/cmake/OptionsGTK.cmake




Diff

Modified: trunk/ChangeLog (208127 => 208128)

--- trunk/ChangeLog	2016-10-30 15:56:26 UTC (rev 208127)
+++ trunk/ChangeLog	2016-10-30 16:18:57 UTC (rev 208128)
@@ -1,3 +1,12 @@
+2016-10-30  Frederic Wang  
+
+Use HarfBuzz ot-math API to parse the OpenType MATH table
+https://bugs.webkit.org/show_bug.cgi?id=162671
+
+Reviewed by Michael Catanzaro.
+
+* Source/cmake/OptionsGTK.cmake: Enable internal OpenType MATH parsing for HarfBuzz < 1.3.3.
+
 2016-10-30  Hyowon Kim  
 
 [GTK] Build break by missing geoclue-2.0.


Modified: trunk/LayoutTests/ChangeLog (208127 => 208128)

--- trunk/LayoutTests/ChangeLog	2016-10-30 15:56:26 UTC (rev 208127)
+++ trunk/LayoutTests/ChangeLog	2016-10-30 16:18:57 UTC (rev 208128)
@@ -1,3 +1,15 @@
+2016-10-30  Frederic Wang  
+
+Use HarfBuzz ot-math API to parse the OpenType MATH table
+https://bugs.webkit.org/show_bug.cgi?id=162671
+
+Reviewed by Michael Catanzaro.
+
+Rebaseline one test for large operators due to small rendering changes.
+
+* platform/gtk/mathml/opentype/opentype-stretchy-expected.png:
+* platform/gtk/mathml/opentype/opentype-stretchy-expected.txt:
+
 2016-10-30  Gyuyoung Kim  
 
 [EFL] Remove duplicated media/media-source tests in TestExpectations


Modified: trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.txt (208127 => 208128)

--- trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.txt	2016-10-30 15:56:26 UTC (rev 208127)
+++ trunk/LayoutTests/platform/gtk/mathml/opentype/opentype-stretchy-expected.txt	2016-10-30 16:18:57 UTC (rev 208128)
@@ -1,8 +1,8 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x347
-  RenderBlock {HTML} at (0,0) size 800x347
-RenderBody {BODY} at (8,16) size 784x315
+layer at (0,0) size 800x336
+  RenderBlock {HTML} at (0,0) size 800x336
+RenderBody {BODY} at (8,16) size 784x304
   RenderBlock {P} at (0,0) size 784x34
 RenderMathMLMath {math} at (0,20) size 26x11
   RenderMathMLRow {mrow} at (0,0) size 26x11
@@ -35,10 +35,10 @@
 RenderText {#text} at (0,-3) size 2x0
   text run at (0,-3) width 2: "\x{219F}"
 RenderText {#text} at (0,0) size 0x0
-  RenderBlock {P} at (0,219) size 784x96
-RenderMathMLMath {math} at (0,0) size 94x93
-  RenderMathMLRow {mrow} at (0,0) size 94x93
-RenderMathMLOperator {mo} at (0,0) size 94x93
+  RenderBlock {P} at (0,219) size 784x85
+RenderMathMLMath {math} at (0,0) size 84x82
+  RenderMathMLRow {mrow} at (0,0) size 84x82
+RenderMathMLOperator {mo} at (0,0) size 84x82
   RenderBlock (anonymous) at (0,0) size 10x12
 RenderText {#text} at (0,6) size 10x0
   text run at (0,6) width 10: "\x{2A1B}"


Modified: trunk/Source/WTF/ChangeLog (208127 => 208128)

--- trunk/Source/WTF/ChangeLog	2016-10-30 15:56:26 UTC (rev 208127)
+++ trunk/Source/WTF/ChangeLog	2016-10-30 16:18:57 UTC (rev 208128)
@@ -1,3 +1,12 @@
+2016-10-30  Frederic Wang  
+
+Use HarfBuzz ot-math API to parse the OpenType MATH table
+https://bugs.webkit.org/show_bug.cgi?id=162671
+
+Reviewed by Michael Catanzaro.
+
+*

[webkit-changes] [208126] trunk/LayoutTests

2016-10-30 Thread gyuyoung . kim 
Title: [208126] trunk/LayoutTests








Revision 208126
Author gyuyoung@webkit.org
Date 2016-10-30 08:15:15 -0700 (Sun, 30 Oct 2016)


Log Message
[EFL] Remove duplicated media/media-source tests in TestExpectations

Unreviewed EFL gardening.

Tests of media/media-source have caused timeout on EFL layout test. However
it hasn't been marked to *Skip* because some tests are multiple marked.
So this patch cleans up it, and skip media/media-source for a while.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208125 => 208126)

--- trunk/LayoutTests/ChangeLog	2016-10-30 13:42:39 UTC (rev 208125)
+++ trunk/LayoutTests/ChangeLog	2016-10-30 15:15:15 UTC (rev 208126)
@@ -1,5 +1,17 @@
 2016-10-30  Gyuyoung Kim  
 
+[EFL] Remove duplicated media/media-source tests in TestExpectations
+
+Unreviewed EFL gardening.
+
+Tests of media/media-source have caused timeout on EFL layout test. However
+it hasn't been marked to *Skip* because some tests are multiple marked.
+So this patch cleans up it, and skip media/media-source for a while.
+
+* platform/efl/TestExpectations:
+
+2016-10-30  Gyuyoung Kim  
+
 Unreviewed EFL gardening. Mark some tests to Timeout.
 
 * platform/efl/TestExpectations: Urgent fix to run layout test.


Modified: trunk/LayoutTests/platform/efl/TestExpectations (208125 => 208126)

--- trunk/LayoutTests/platform/efl/TestExpectations	2016-10-30 13:42:39 UTC (rev 208125)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2016-10-30 15:15:15 UTC (rev 208126)
@@ -144,7 +144,6 @@
 http/tests/media/video-buffered-range-contains-currentTime.html [ Timeout ]
 media/airplay-autoplay.html [ Timeout ]
 media/media-fullscreen-return-to-inline.html [ Timeout ]
-media/media-source/media-source-small-gap.html [ Timeout ]
 
 # --
 # Tests which need investigation
@@ -1518,13 +1517,7 @@
 
 # Though MEDIA_SOURCE is enabled, below tests are still failing.
 webkit.org/b/134974 http/tests/media/media-source [ Skip ]
-webkit.org/b/134974 media/media-source/media-source-stpp-crash.html [ Skip ]
-webkit.org/b/134974 media/media-source/media-source-append-failed.html [ Timeout ]
-webkit.org/b/134974 media/media-source/media-source-seek-complete.html [ Timeout ]
-webkit.org/b/134974 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
-webkit.org/b/134974 media/media-source/media-source-duplicate-seeked.html [ Failure ]
-webkit.org/b/134974 media/media-source/media-source-play.html [ Failure ]
-webkit.org/b/134974 media/media-source/media-source-append-buffer-with-append-window.html [ Failure Pass ]
+webkit.org/b/164022 media/media-source [ Skip ]
 
 # Skip imported/w3c/web-platform-tests for a while.
 #webkit.org/b/161839 imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html [ Failure ]
@@ -2670,14 +2663,6 @@
 webkit.org/b/156024 svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml [ Failure ]
 
 # Media tests have been failing since we bumped gstreamer ver.
-webkit.org/b/156969 media/media-source/media-source-canplaythrough.html [ Timeout ]
-webkit.org/b/156969 media/media-source/media-source-end-of-stream-buffered.html [ Timeout ]
-webkit.org/b/156969 media/media-source/media-source-end-of-stream-readyState.html [ Timeout ]
-webkit.org/b/156969 media/media-source/media-source-end-of-stream.html [ Timeout ]
-webkit.org/b/156969 media/media-source/media-source-fudge-factor.html [ Timeout ]
-webkit.org/b/156969 media/media-source/media-source-loadedmetada-with-two-sourcebuffers.html [ Timeout ]
-webkit.org/b/156969 media/media-source/media-source-multiple-initialization-segments.html [ Timeout ]
-webkit.org/b/156969 media/media-source/media-source-remove.html [ Timeout ]
 webkit.org/b/156969 media/track/track-automatic-subtitles.html [ Timeout ]
 webkit.org/b/156969 media/track/track-cues-pause-on-exit.html [ Timeout ]
 webkit.org/b/156969 media/video-controls-toggling.html [ Timeout ]
@@ -2686,17 +2671,6 @@
 webkit.org/b/156969 media/controls-without-preload.html [ Failure ]
 webkit.org/b/156969 media/media-controls-drag-timeline-set-controls-property.html [ Failure ]
 webkit.org/b/156969 media/media-controls-invalid-url.html [ Failure ]
-webkit.org/b/156969 media/media-source/media-source-append-media-segment-without-init.html [ Failure ]
-webkit.org/b/156969 media/media-source/media-source-append-nonsync-sample-after-abort.html [ Failure ]
-webkit.org/b/156969 media/media-source/media-source-duration-after-append.html [ Failure ]
-webkit.org/b/156969 media/media-source/media-source-monitor-source-buffers.html [ Failure ]
-webkit.org/b/156969 media/media-source/media-source-overlapping-append.html [ Failure ]
-webkit.org/b/156969 media/media-source/media-source-overlapping-decodetime.html [ Failure ]
-webkit.org/b/156969 media/media-source/media-so

[webkit-changes] [208125] trunk/Source/WebCore

2016-10-30 Thread hyatt 
Title: [208125] trunk/Source/WebCore








Revision 208125
Author hy...@apple.com
Date 2016-10-30 06:42:39 -0700 (Sun, 30 Oct 2016)


Log Message
[CSS Parser] Support unprefixed image-sets
https://bugs.webkit.org/show_bug.cgi?id=164198

Reviewed by Dean Jackson.

* css/CSSValueKeywords.in:
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208124 => 208125)

--- trunk/Source/WebCore/ChangeLog	2016-10-30 10:03:20 UTC (rev 208124)
+++ trunk/Source/WebCore/ChangeLog	2016-10-30 13:42:39 UTC (rev 208125)
@@ -1,3 +1,14 @@
+2016-10-29  Dave Hyatt  
+
+[CSS Parser] Support unprefixed image-sets
+https://bugs.webkit.org/show_bug.cgi?id=164198
+
+Reviewed by Dean Jackson.
+
+* css/CSSValueKeywords.in:
+* css/parser/CSSPropertyParserHelpers.cpp:
+(WebCore::CSSPropertyParserHelpers::consumeImage):
+
 2016-10-30  Yusuke Suzuki  
 
 [DOM] Introduce WebCore::jsDynamicDowncast


Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (208124 => 208125)

--- trunk/Source/WebCore/css/CSSValueKeywords.in	2016-10-30 10:03:20 UTC (rev 208124)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in	2016-10-30 13:42:39 UTC (rev 208125)
@@ -1150,6 +1150,7 @@
 scale-down
 
 // background-image, etc.
+image-set
 linear-gradient
 radial-gradient
 repeating-linear-gradient


Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (208124 => 208125)

--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-10-30 10:03:20 UTC (rev 208124)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp	2016-10-30 13:42:39 UTC (rev 208125)
@@ -1158,7 +1158,7 @@
 return CSSImageValue::create(completeURL(context, uri));
 if (range.peek().type() == FunctionToken) {
 CSSValueID id = range.peek().functionId();
-if (id == CSSValueWebkitImageSet)
+if (id == CSSValueWebkitImageSet || id == CSSValueImageSet)
 return consumeImageSet(range, context);
 if (generatedImage == ConsumeGeneratedImage::Allow && isGeneratedImage(id))
 return consumeGeneratedImage(range, context);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208123] trunk

2016-10-30 Thread utatane . tea 
Title: [208123] trunk








Revision 208123
Author utatane@gmail.com
Date 2016-10-30 02:14:37 -0700 (Sun, 30 Oct 2016)


Log Message
[JSC] JSON.stringify should handle Proxy which is non JSArray but isArray is true
https://bugs.webkit.org/show_bug.cgi?id=164123

Reviewed by Mark Lam.

JSTests:

* stress/json-stringify-with-non-jsarray-array.js: Added.
(shouldBe):
(shouldBe.JSON.stringify.new.Proxy):

Source/_javascript_Core:

When JSON.stringify encounter the undefined value, the result depends
on the context. If it is produced under the object property context, we ignore
that property. On the other hand, if it is produced under the array element
context, we produce "null".

For example,
// https://tc39.github.io/ecma262/#sec-serializejsonobject section 8.b.
// Skip the property that value is undefined.
JSON.stringify({ value: undefined });  // => "{}"

// https://tc39.github.io/ecma262/#sec-serializejsonarray section 8.b.
// Write "null" when the element is undefined.
JSON.stringify([undefined]);   // => "[null]"

At that time, we decide the context based on the `holder->inherits(JSArray::info())`.
But it is not correct since we have a holder that creates the array element context
but it is not JSArray subtype. ES6 Proxy to an array is one example. In that case,
`isArray(exec, proxy)` returns `true`, but `inherits(JSArray::info())` returns false.
Since we already have this `isArray()` value in Stringifier::Holder, we should reuse
this here. And this is the correct behavior in the ES6 spec.

* runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::isArray):
(JSC::Stringifier::stringify):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::Holder):
(JSC::Stringifier::Holder::appendNextProperty):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSONObject.cpp


Added Paths

trunk/JSTests/stress/json-stringify-with-non-jsarray-array.js




Diff

Modified: trunk/JSTests/ChangeLog (208122 => 208123)

--- trunk/JSTests/ChangeLog	2016-10-30 09:14:03 UTC (rev 208122)
+++ trunk/JSTests/ChangeLog	2016-10-30 09:14:37 UTC (rev 208123)
@@ -1,3 +1,14 @@
+2016-10-29  Yusuke Suzuki  
+
+[JSC] JSON.stringify should handle Proxy which is non JSArray but isArray is true
+https://bugs.webkit.org/show_bug.cgi?id=164123
+
+Reviewed by Mark Lam.
+
+* stress/json-stringify-with-non-jsarray-array.js: Added.
+(shouldBe):
+(shouldBe.JSON.stringify.new.Proxy):
+
 2016-10-29  Saam Barati  
 
 We should have a way of profiling when a get_by_id is pure and to emit a PureGetById in the DFG/FTL


Added: trunk/JSTests/stress/json-stringify-with-non-jsarray-array.js (0 => 208123)

--- trunk/JSTests/stress/json-stringify-with-non-jsarray-array.js	(rev 0)
+++ trunk/JSTests/stress/json-stringify-with-non-jsarray-array.js	2016-10-30 09:14:37 UTC (rev 208123)
@@ -0,0 +1,36 @@
+function shouldBe(actual, expected)
+{
+if (actual !== expected)
+throw new Error(`bad value: ${String(actual)}`);
+}
+
+function shouldThrow(func, errorMessage)
+{
+var errorThrown = false;
+var error = null;
+try {
+func();
+} catch (e) {
+errorThrown = true;
+error = e;
+}
+if (!errorThrown)
+throw new Error('not thrown');
+if (String(error) !== errorMessage)
+throw new Error(`bad error: ${String(error)}`);
+}
+
+shouldBe(JSON.stringify(new Proxy([undefined], {})), `[null]`);
+shouldBe(JSON.stringify(new Proxy([function() { }], {})), `[null]`);
+shouldBe(JSON.stringify(new Proxy({ value: undefined }, {})), `{}`);
+
+shouldThrow(function () {
+let proxy = new Proxy([], {
+get(theTarget, propName) {
+if (propName === 'length')
+throw new Error('ok');
+return 42;
+}
+});
+JSON.stringify(proxy);
+}, `Error: ok`);


Modified: trunk/Source/_javascript_Core/ChangeLog (208122 => 208123)

--- trunk/Source/_javascript_Core/ChangeLog	2016-10-30 09:14:03 UTC (rev 208122)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-30 09:14:37 UTC (rev 208123)
@@ -1,3 +1,38 @@
+2016-10-29  Yusuke Suzuki  
+
+[JSC] JSON.stringify should handle Proxy which is non JSArray but isArray is true
+https://bugs.webkit.org/show_bug.cgi?id=164123
+
+Reviewed by Mark Lam.
+
+When JSON.stringify encounter the undefined value, the result depends
+on the context. If it is produced under the object property context, we ignore
+that property. On the other hand, if it is produced under the array element
+context, we produce "null".
+
+For example,
+// https://tc39.github.io/ecma262/#sec-serializejsonobject section 8.b.
+// Skip the property that value is undefined.
+JSON.stringify({ value: undefined });  // => "{}"
+
+// https://tc39.github.io/ecma262/#se

[webkit-changes] [208122] trunk/LayoutTests

2016-10-30 Thread gyuyoung . kim 
Title: [208122] trunk/LayoutTests








Revision 208122
Author gyuyoung@webkit.org
Date 2016-10-30 02:14:03 -0700 (Sun, 30 Oct 2016)


Log Message
Unreviewed EFL gardening. Mark some tests to Timeout.

* platform/efl/TestExpectations: Urgent fix to run layout test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208121 => 208122)

--- trunk/LayoutTests/ChangeLog	2016-10-30 06:44:32 UTC (rev 208121)
+++ trunk/LayoutTests/ChangeLog	2016-10-30 09:14:03 UTC (rev 208122)
@@ -1,3 +1,9 @@
+2016-10-30  Gyuyoung Kim  
+
+Unreviewed EFL gardening. Mark some tests to Timeout.
+
+* platform/efl/TestExpectations: Urgent fix to run layout test.
+
 2016-10-29  Dean Jackson  
 
 Parse color() function


Modified: trunk/LayoutTests/platform/efl/TestExpectations (208121 => 208122)

--- trunk/LayoutTests/platform/efl/TestExpectations	2016-10-30 06:44:32 UTC (rev 208121)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2016-10-30 09:14:03 UTC (rev 208122)
@@ -2828,3 +2828,43 @@
 
 # webrtc not supported
 imported/w3c/web-platform-tests/webrtc [ Skip ]
+
+accessibility/textarea-selected-text-range.html [ Timeout ]
+crypto/workers/subtle/rsa-generate-key.html [ Timeout ]
+css3/masking/mask-svg-no-fragmentId-tiled.html [ Timeout ]
+css3/masking/mask-svg-no-fragmentId.html [ Timeout ]
+fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html [ Timeout ]
+fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html [ Timeout ]
+fast/history/page-cache-media-source-closed-2.html [ Timeout ]
+fast/history/page-cache-media-source-closed.html [ Timeout ]
+fast/history/page-cache-media-source-opened.html [ Timeout ]
+fast/history/page-cache-removed-source-buffer.html [ Timeout ]
+fast/loader/file-URL-with-port-number.html [ Timeout ]
+http/tests/incremental/slow-utf8-css.html [ Timeout ]
+http/tests/navigation/ping-attribute/anchor-ping-and-follow-redirect-when-sending-ping.html [ Timeout ]
+http/tests/security/video-cross-origin-caching.html [ Timeout ]
+http/tests/xmlhttprequest/on-network-timeout-error-during-preflight.html [ Timeout ]
+http/tests/xmlhttprequest/resetting-timeout-to-zero.html [ Timeout ]
+imported/mozilla/svg/text/textLength-6.svg [ Timeout ]
+media/encrypted-media/encrypted-media-session-lifetime.html [ Timeout ]
+media/encrypted-media/encrypted-media-v2-events.html [ Timeout ]
+media/encrypted-media/encrypted-media-v2-syntax.html [ Timeout ]
+media/media-controls-drag-timeline-set-controls-property.html [ Timeout ]
+media/media-source/media-source-append-buffer-with-append-window.html [ Timeout ]
+media/media-source/media-source-append-media-segment-without-init.html [ Timeout ]
+media/media-source/media-source-append-nonsync-sample-after-abort.html [ Timeout ]
+media/media-source/media-source-duplicate-seeked.html [ Timeout ]
+media/media-source/media-source-duration-after-append.html [ Timeout ]
+media/media-source/media-source-monitor-source-buffers.html [ Timeout ]
+media/media-source/media-source-overlapping-append.html [ Timeout ]
+media/media-source/media-source-overlapping-decodetime.html [ Timeout ]
+media/media-source/media-source-play.html [ Timeout ]
+media/media-source/media-source-sequence-timestamps.html [ Timeout ]
+media/media-source/media-source-timeoffset.html [ Timeout ]
+media/media-source/media-source-track-enabled.html [ Timeout ]
+media/media-source/media-source-tracks.html [ Timeout ]
+media/media-source/media-source-video-playback-quality.html [ Timeout ]
+media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Timeout ]
+media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Timeout ]
+media/muted-video-is-playing-audio.html [ Timeout ]
+svg/animations/animate-linear-discrete-additive.svg [ Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes