[webkit-changes] [216478] trunk

[commit-queue]

Title: [216478] trunk








Revision 216478
Author commit-qu...@webkit.org
Date 2017-05-08 22:25:46 -0700 (Mon, 08 May 2017)


Log Message
Simplify ScrollingStateNode::scrollingStateTreeAsText
https://bugs.webkit.org/show_bug.cgi?id=171802

Patch by Frederic Wang  on 2017-05-08
Reviewed by Simon Fraser.

Source/WebCore:

The following simplifications are performed:
- Rely on TextStream's internal value to manage indentation.
- Use TextStream::dumpProperty and << to print simple properties.
- Try and use TextStream::GroupScope for groups.

No new tests, only minor format changes in the dumped tree.

* page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::dumpProperties):
* page/scrolling/ScrollingStateFixedNode.h:
* page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):
* page/scrolling/ScrollingStateFrameScrollingNode.h:
* page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::dumpProperties):
(WebCore::ScrollingStateNode::dump):
(WebCore::ScrollingStateNode::scrollingStateTreeAsText):
* page/scrolling/ScrollingStateNode.h:
* page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
(WebCore::ScrollingStateOverflowScrollingNode::dumpProperties):
* page/scrolling/ScrollingStateOverflowScrollingNode.h:
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::dumpProperties):
* page/scrolling/ScrollingStateScrollingNode.h:
* page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::dumpProperties):
* page/scrolling/ScrollingStateStickyNode.h:

LayoutTests:

Update references due to minor format changes in text ouput of scrolling state trees.

* fast/scrolling/ios/remove-scrolling-role-expected.txt:
* fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt:
* fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt:
* fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt:
* tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt:
* tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt:
* tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt:
* tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
* tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt:
* tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
* tiled-drawing/scrolling/fixed/four-bars-expected.txt:
* tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt:
* tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
* tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt:
* tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt:
* tiled-drawing/scrolling/fixed/nested-fixed-expected.txt:
* tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt:
* tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
* tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt:
* tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
* tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt:
* tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt:
* tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt:
* tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt:
* tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt:
* tiled-drawing/scrolling/scrolling-tree-slow-scrolling-expected.txt:
* tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt:
* tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt:
* tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/scrolling/ios/remove-scrolling-role-expected.txt
trunk/LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt
trunk/LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt
trunk/LayoutTests/fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/fixed/four-bars-expected.txt
trunk/LayoutTests/tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt

[webkit-changes] [216477] trunk/Source

[commit-queue]

Title: [216477] trunk/Source








Revision 216477
Author commit-qu...@webkit.org
Date 2017-05-08 22:14:32 -0700 (Mon, 08 May 2017)


Log Message
Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing
https://bugs.webkit.org/show_bug.cgi?id=171824

Patch by Youenn Fablet  on 2017-05-08
Reviewed by Alex Christensen.

Source/WebCore:

Refactoring to use more references.
Only behavioral change is the rejection of the getUserMedia promise if either audio or video source creation is
failing. Previously, if audio source creation was failing, the promise would still resolve if video source was
sucessfully created.

* platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::audioFactory):
(WebCore::RealtimeMediaSourceCenter::videoFactory):
(WebCore::RealtimeMediaSourceCenter::audioCaptureDeviceManager):
(WebCore::RealtimeMediaSourceCenter::videoCaptureDeviceManager):
* platform/mediastream/RealtimeMediaSourceCenter.h:
(WebCore::RealtimeMediaSourceCenter::defaultAudioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::defaultVideoFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::defaultAudioCaptureDeviceManager): Deleted.
(WebCore::RealtimeMediaSourceCenter::defaultVideoCaptureDeviceManager): Deleted.
* platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):
(WebCore::RealtimeMediaSourceCenterMac::getMediaStreamDevices):
(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints):
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory):
(WebCore::RealtimeMediaSourceCenterMac::defaultVideoFactory):
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioCaptureDeviceManager):
(WebCore::RealtimeMediaSourceCenterMac::defaultVideoCaptureDeviceManager):
* platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
* platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:
* platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::defaultAudioFactory):
(WebCore::MockRealtimeMediaSourceCenter::defaultVideoFactory):
(WebCore::MockRealtimeMediaSourceCenter::defaultAudioCaptureDeviceManager):
(WebCore::MockRealtimeMediaSourceCenter::defaultVideoCaptureDeviceManager):
* platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit2:

* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.h
trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h
trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (216476 => 216477)

--- trunk/Source/WebCore/CMakeLists.txt	2017-05-09 03:59:50 UTC (rev 216476)
+++ trunk/Source/WebCore/CMakeLists.txt	2017-05-09 05:14:32 UTC (rev 216477)
@@ -2386,6 +2386,7 @@
 platform/graphics/transforms/TransformationMatrix.cpp
 platform/graphics/transforms/TranslateTransformOperation.cpp
 
+platform/mediastream/CaptureDeviceManager.cpp
 platform/mediastream/MediaConstraints.cpp
 platform/mediastream/MediaEndpointConfiguration.cpp
 platform/mediastream/MediaStreamPrivate.cpp


Modified: trunk/Source/WebCore/ChangeLog (216476 => 216477)

--- trunk/Source/WebCore/ChangeLog	2017-05-09 03:59:50 UTC (rev 216476)
+++ trunk/Source/WebCore/ChangeLog	2017-05-09 05:14:32 UTC (rev 216477)
@@ -1,3 +1,42 @@
+2017-05-08  Youenn Fablet  
+
+Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing
+https://bugs.webkit.org/show_bug.cgi?id=171824
+
+Reviewed by Alex Christensen.
+
+Refactoring to use more references.
+Only behavioral change is the rejection of the getUserMedia promise if either audio or video source creation is
+failing. Previously, if audio source creation was failing, the promise would still resolve if video source was
+sucessfully created.
+
+* platform/mediastream/RealtimeMediaSourceCenter.cpp:
+(WebCore::RealtimeMediaSourceCenter::audioFactory):
+(WebCore::RealtimeMediaSourceCenter::videoFactory):
+(WebCore::RealtimeMediaSourceCenter::audioCaptureDeviceManager):
+(WebCore::RealtimeMediaSourceCenter::videoCaptureDeviceManager):
+* 

[webkit-changes] [216475] trunk/Source/WebKit2

[bfulgham]

Title: [216475] trunk/Source/WebKit2








Revision 216475
Author bfulg...@apple.com
Date 2017-05-08 20:24:53 -0700 (Mon, 08 May 2017)


Log Message
REGRESSION(r213564): Flash video playback failures
https://bugs.webkit.org/show_bug.cgi?id=171840


Reviewed by Alexey Proskuryakov.

The sandbox restrictions added in r213564 to prevent access to unused iokit properties
blocked some items needed for Flash video playback. This change relaxes the sandbox
to allow this software to run properly.

* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216474 => 216475)

--- trunk/Source/WebKit2/ChangeLog	2017-05-09 02:46:26 UTC (rev 216474)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-09 03:24:53 UTC (rev 216475)
@@ -1,3 +1,17 @@
+2017-05-08  Brent Fulgham  
+
+REGRESSION(r213564): Flash video playback failures
+https://bugs.webkit.org/show_bug.cgi?id=171840
+
+
+Reviewed by Alexey Proskuryakov.
+
+The sandbox restrictions added in r213564 to prevent access to unused iokit properties
+blocked some items needed for Flash video playback. This change relaxes the sandbox
+to allow this software to run properly.
+
+* PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
+
 2017-05-08  Alex Christensen  
 
 Reduce PassRefPtr use in WebKit2


Modified: trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (216474 => 216475)

--- trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in	2017-05-09 02:46:26 UTC (rev 216474)
+++ trunk/Source/WebKit2/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in	2017-05-09 03:24:53 UTC (rev 216475)
@@ -46,9 +46,10 @@
 (allow iokit-get-properties
 (iokit-property "AllowDisplaySleep")
 (iokit-property "DisplayRouting")
+(iokit-property "DeviceEqID")
 (iokit-property-regex #"^IOAudioControl(ChannelID|ID|SubType|Usage)")
 (iokit-property-regex #"^IOAudioDevice(CanBeDefaults|TransportType)")
-(iokit-property-regex #"^IOAudioEngine(ChannelNames|ClientDescription|CoreAudioPlugIn|Description|Flavor|GlobalUniqueID|OutputChannelLayout|SampleOffset|State)")
+(iokit-property-regex #"^IOAudioEngine(ChannelNames|ClientDescription|CoreAudioPlugIn|(Device)Description|Flavor|GlobalUniqueID|OutputChannelLayout|SampleOffset|State)")
 (iokit-property-regex #"^IOAudioEngineClock(Domain|IsStable)")
 (iokit-property "IOAudioEngineDisableClockBoundsCheck")
 (iokit-property-regex #"^IOAudioEngine(Input|Output)Sample(Latency|Offset)")
@@ -61,9 +62,11 @@
 (iokit-property-regex #"^IOFBCurrentPixelCount(Real)")
 (iokit-property "IOGeneralInterest")
 (iokit-property "IOGLBundleName")
+(iokit-property "IOGVACodec")
 (iokit-property "IOScreenRestoreState")
 (iokit-property "IOVARendererID")
 (iokit-property-regex #"^MetalPlugin(Name|ClassName)")
+(iokit-property "NoAutoRoute")
 (iokit-property "SupportAudioAUUC")
 (iokit-property "board-id")
 (iokit-property "idProduct")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216474] trunk/Source/WebCore

[cdumez]

Title: [216474] trunk/Source/WebCore








Revision 216474
Author cdu...@apple.com
Date 2017-05-08 19:46:26 -0700 (Mon, 08 May 2017)


Log Message
Drop [CEReactions] from CharacterData operations
https://bugs.webkit.org/show_bug.cgi?id=171813

Reviewed by Ryosuke Niwa.

Drop [CEReactions] from CharacterData operations to match the DOM specification:
- https://dom.spec.whatwg.org/#interface-characterdata

I believe WebKit had this because Attr used to have Text child nodes. Therefore, modifying
those Text child nodes via the CharacterData API could modify the value of an attribute,
requiring us to run attributeChangedCallback for Custom Elements. However, as of
r216259>, Attr can no longer have Text child nodes.

I have also verified that Blink does not have [CEReactions] for those methods.

No new tests, no expected Web-facing behavior change.

* dom/CharacterData.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/CharacterData.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (216473 => 216474)

--- trunk/Source/WebCore/ChangeLog	2017-05-09 02:22:45 UTC (rev 216473)
+++ trunk/Source/WebCore/ChangeLog	2017-05-09 02:46:26 UTC (rev 216474)
@@ -1,3 +1,24 @@
+2017-05-08  Chris Dumez  
+
+Drop [CEReactions] from CharacterData operations
+https://bugs.webkit.org/show_bug.cgi?id=171813
+
+Reviewed by Ryosuke Niwa.
+
+Drop [CEReactions] from CharacterData operations to match the DOM specification:
+- https://dom.spec.whatwg.org/#interface-characterdata
+
+I believe WebKit had this because Attr used to have Text child nodes. Therefore, modifying
+those Text child nodes via the CharacterData API could modify the value of an attribute,
+requiring us to run attributeChangedCallback for Custom Elements. However, as of
+, Attr can no longer have Text child nodes.
+
+I have also verified that Blink does not have [CEReactions] for those methods.
+
+No new tests, no expected Web-facing behavior change.
+
+* dom/CharacterData.idl:
+
 2017-05-08  Jeremy Jones  
 
 Remove black background from video layer while in fullscreen.


Modified: trunk/Source/WebCore/dom/CharacterData.idl (216473 => 216474)

--- trunk/Source/WebCore/dom/CharacterData.idl	2017-05-09 02:22:45 UTC (rev 216473)
+++ trunk/Source/WebCore/dom/CharacterData.idl	2017-05-09 02:46:26 UTC (rev 216474)
@@ -18,13 +18,13 @@
  */
 
 interface CharacterData : Node {
-[CEReactions] attribute [TreatNullAs=EmptyString] DOMString data; // FIXME: Not marked as [CEReactions] in the spec.
+attribute [TreatNullAs=EmptyString] DOMString data;
 readonly attribute unsigned long length;
 [MayThrowException] DOMString substringData(unsigned long offset, unsigned long count);
-[CEReactions] void appendData(DOMString data); // FIXME: Not marked as [CEReactions] in the spec.
-[CEReactions, MayThrowException] void insertData(unsigned long offset, DOMString data); // FIXME: Not marked as [CEReactions] in the spec.
-[CEReactions, MayThrowException] void deleteData(unsigned long offset, unsigned long count); // FIXME: Not marked as [CEReactions] in the spec.
-[CEReactions, MayThrowException] void replaceData(unsigned long offset, unsigned long count, DOMString data); // FIXME: Not marked as [CEReactions] in the spec.
+void appendData(DOMString data);
+[MayThrowException] void insertData(unsigned long offset, DOMString data);
+[MayThrowException] void deleteData(unsigned long offset, unsigned long count);
+[MayThrowException] void replaceData(unsigned long offset, unsigned long count, DOMString data);
 };
 
 CharacterData implements ChildNode;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216473] trunk/Source/WebKit2

[achristensen]

Title: [216473] trunk/Source/WebKit2








Revision 216473
Author achristen...@apple.com
Date 2017-05-08 19:22:45 -0700 (Mon, 08 May 2017)


Log Message
Reduce PassRefPtr use in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=171831

Reviewed by Chris Dumez.

* UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupCreateWithIdentifier):
* UIProcess/GenericCallback.h:
(WebKit::GenericCallback::create):
(WebKit::CallbackMap::put):
* UIProcess/StatisticsRequest.cpp:
(WebKit::StatisticsRequest::StatisticsRequest):
* UIProcess/StatisticsRequest.h:
(WebKit::StatisticsRequest::create):
* UIProcess/TextChecker.h:
* UIProcess/TextCheckerCompletion.cpp:
(WebKit::TextCheckerCompletion::create):
* UIProcess/TextCheckerCompletion.h:
* UIProcess/WebColorPicker.h:
(WebKit::WebColorPicker::create):
* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::create):
* UIProcess/WebConnectionToWebProcess.h:
* UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):
* UIProcess/WebContextInjectedBundleClient.h:
* UIProcess/WebContextMenuListenerProxy.h:
(WebKit::WebContextMenuListenerProxy::create):
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::create):
* UIProcess/WebCookieManagerProxy.h:
* UIProcess/WebEditCommandProxy.h:
(WebKit::WebEditCommandProxy::create):
* UIProcess/WebFormSubmissionListenerProxy.h:
(WebKit::WebFormSubmissionListenerProxy::create):
* UIProcess/WebFrameListenerProxy.h:
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::create):
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::create):
* UIProcess/WebFullScreenManagerProxy.h:
* UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::create):
* UIProcess/WebGeolocationManagerProxy.h:
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::create):
(WebKit::WebIconDatabase::iconDataForPageURL):
* UIProcess/WebIconDatabase.h:
* UIProcess/WebMediaSessionFocusManager.cpp:
(WebKit::WebMediaSessionFocusManager::create):
* UIProcess/WebMediaSessionFocusManager.h:
* UIProcess/WebOpenPanelResultListenerProxy.h:
(WebKit::WebOpenPanelResultListenerProxy::create):
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::create):
* UIProcess/WebPageGroup.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::forceRepaint):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToImage):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::drawPagesForPrinting):
(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
* UIProcess/WebPageProxy.h:
* UIProcess/ios/TextCheckerIOS.mm:
(WebKit::TextChecker::requestCheckingOfString):
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::requestCheckingOfString):
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
* UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(-[WKPrintingView _drawPreview:]):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::loadURL):
(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::NetscapePluginStream):
* WebProcess/Plugins/Netscape/NetscapePluginStream.h:
(WebKit::NetscapePluginStream::create):
* WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toFormData):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPageGroup.cpp
trunk/Source/WebKit2/UIProcess/GenericCallback.h
trunk/Source/WebKit2/UIProcess/StatisticsRequest.cpp
trunk/Source/WebKit2/UIProcess/StatisticsRequest.h
trunk/Source/WebKit2/UIProcess/TextChecker.h
trunk/Source/WebKit2/UIProcess/TextCheckerCompletion.cpp
trunk/Source/WebKit2/UIProcess/TextCheckerCompletion.h
trunk/Source/WebKit2/UIProcess/WebColorPicker.h
trunk/Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp
trunk/Source/WebKit2/UIProcess/WebConnectionToWebProcess.h
trunk/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.cpp
trunk/Source/WebKit2/UIProcess/WebContextInjectedBundleClient.h
trunk/Source/WebKit2/UIProcess/WebContextMenuListenerProxy.h
trunk/Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/WebCookieManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebEditCommandProxy.h
trunk/Source/WebKit2/UIProcess/WebFormSubmissionListenerProxy.h
trunk/Source/WebKit2/UIProcess/WebFrameListenerProxy.h
trunk/Source/WebKit2/UIProcess/WebFrameProxy.h
trunk/Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/WebFullScreenManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebGeolocationManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/WebGeolocationManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebIconDatabase.cpp
trunk/Source/WebKit2/UIProcess/WebIconDatabase.h

[webkit-changes] [216472] trunk/Source/WebCore

[commit-queue]

Title: [216472] trunk/Source/WebCore








Revision 216472
Author commit-qu...@webkit.org
Date 2017-05-08 19:00:05 -0700 (Mon, 08 May 2017)


Log Message
Remove black background from video layer while in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=171816

Patch by Jeremy Jones  on 2017-05-08
Reviewed by Eric Carlson.

No new tests because no new behavior in DOM.

This changes the background of the video layer to clear when it goes into fullscreen
and back to black when it returns to inline to better facilitate fullsceen animations.

* platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
(WebCore::VideoFullscreenLayerManager::setVideoLayer):
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216471 => 216472)

--- trunk/Source/WebCore/ChangeLog	2017-05-09 01:53:54 UTC (rev 216471)
+++ trunk/Source/WebCore/ChangeLog	2017-05-09 02:00:05 UTC (rev 216472)
@@ -1,3 +1,19 @@
+2017-05-08  Jeremy Jones  
+
+Remove black background from video layer while in fullscreen.
+https://bugs.webkit.org/show_bug.cgi?id=171816
+
+Reviewed by Eric Carlson.
+
+No new tests because no new behavior in DOM.
+
+This changes the background of the video layer to clear when it goes into fullscreen
+and back to black when it returns to inline to better facilitate fullsceen animations.
+
+* platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
+(WebCore::VideoFullscreenLayerManager::setVideoLayer):
+(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer):
+
 2017-05-08  Said Abou-Hallawa  
 
 The Incomplete asynchronously decoded image frame should be decoded every time it's drawn


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm (216471 => 216472)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm	2017-05-09 01:53:54 UTC (rev 216471)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm	2017-05-09 02:00:05 UTC (rev 216472)
@@ -28,6 +28,7 @@
 
 #if PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE))
 
+#import "Color.h"
 #import "QuartzCoreSPI.h"
 #import "WebCoreCALayerExtras.h"
 #import 
@@ -79,9 +80,11 @@
 if (m_videoFullscreenLayer) {
 [m_videoLayer setFrame:CGRectMake(0, 0, m_videoFullscreenFrame.width(), m_videoFullscreenFrame.height())];
 [m_videoFullscreenLayer insertSublayer:m_videoLayer.get() atIndex:0];
+[m_videoLayer setBackgroundColor:cachedCGColor(Color::transparent)];
 } else {
 [m_videoInlineLayer insertSublayer:m_videoLayer.get() atIndex:0];
 [m_videoLayer setFrame:m_videoInlineLayer.get().bounds];
+[m_videoLayer setBackgroundColor:cachedCGColor(Color::black)];
 }
 }
 
@@ -103,9 +106,11 @@
 if (m_videoFullscreenLayer) {
 [m_videoFullscreenLayer insertSublayer:m_videoLayer.get() atIndex:0];
 [m_videoLayer setFrame:CGRectMake(0, 0, m_videoFullscreenFrame.width(), m_videoFullscreenFrame.height())];
+[m_videoLayer setBackgroundColor:cachedCGColor(Color::transparent)];
 } else if (m_videoInlineLayer) {
 [m_videoLayer setFrame:[m_videoInlineLayer bounds]];
 [m_videoInlineLayer insertSublayer:m_videoLayer.get() atIndex:0];
+[m_videoLayer setBackgroundColor:cachedCGColor(Color::black)];
 } else
 [m_videoLayer removeFromSuperlayer];
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216471] trunk/Source/WebCore

[said]

Title: [216471] trunk/Source/WebCore








Revision 216471
Author s...@apple.com
Date 2017-05-08 18:53:54 -0700 (Mon, 08 May 2017)


Log Message
The Incomplete asynchronously decoded image frame should be decoded every time it's drawn
https://bugs.webkit.org/show_bug.cgi?id=170836

Reviewed by Tim Horton.

The asynchronously decoded image frames has to be cached to prevent flickering,
but we have to keep requesting new decoding for the incomplete frame every time
it's drawn. This is to avoid drawing an incomplete image frame even after all
its encoded data is received.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/ImageFrameCache.cpp:
(WebCore::ImageFrameCache::cacheAsyncFrameNativeImageAtIndex):
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216470 => 216471)

--- trunk/Source/WebCore/ChangeLog	2017-05-09 01:45:20 UTC (rev 216470)
+++ trunk/Source/WebCore/ChangeLog	2017-05-09 01:53:54 UTC (rev 216471)
@@ -1,3 +1,21 @@
+2017-05-08  Said Abou-Hallawa  
+
+The Incomplete asynchronously decoded image frame should be decoded every time it's drawn
+https://bugs.webkit.org/show_bug.cgi?id=170836
+
+Reviewed by Tim Horton.
+
+The asynchronously decoded image frames has to be cached to prevent flickering,
+but we have to keep requesting new decoding for the incomplete frame every time
+it's drawn. This is to avoid drawing an incomplete image frame even after all
+its encoded data is received.
+
+* platform/graphics/BitmapImage.cpp:
+(WebCore::BitmapImage::draw):
+* platform/graphics/ImageFrameCache.cpp:
+(WebCore::ImageFrameCache::cacheAsyncFrameNativeImageAtIndex):
+(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex):
+
 2017-05-08  Wenson Hsieh  
 
 Guard DragController::cleanupAfterSystemDrag to only clear drag state on Mac


Modified: trunk/Source/WebCore/platform/graphics/BitmapImage.cpp (216470 => 216471)

--- trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-05-09 01:45:20 UTC (rev 216470)
+++ trunk/Source/WebCore/platform/graphics/BitmapImage.cpp	2017-05-09 01:53:54 UTC (rev 216471)
@@ -183,10 +183,15 @@
 if (decodingMode == DecodingMode::Asynchronous && shouldUseAsyncDecodingForLargeImages()) {
 ASSERT(!canAnimate() && !m_currentFrame);
 
-if (!frameHasDecodedNativeImageCompatibleWithOptionsAtIndex(m_currentFrame, m_currentSubsamplingLevel, DecodingOptions(sizeForDrawing))
-&& !frameIsBeingDecodedAndIsCompatibleWithOptionsAtIndex(m_currentFrame, DecodingOptions(sizeForDrawing))) {
+bool frameIsCompatible = frameHasDecodedNativeImageCompatibleWithOptionsAtIndex(m_currentFrame, m_currentSubsamplingLevel, DecodingOptions(sizeForDrawing));
+bool frameIsBeingDecoded = frameIsBeingDecodedAndIsCompatibleWithOptionsAtIndex(m_currentFrame, DecodingOptions(sizeForDrawing));
+bool frameIsComplete = frameIsCompleteAtIndex(m_currentFrame);
+
+// If the current frame is incomplete, a new request for decoding this frame has to be made even if
+// it is currently being decoded. New data may have been received since the previous request was made.
+if ((!frameIsCompatible && !frameIsBeingDecoded) || !frameIsComplete) {
 LOG(Images, "BitmapImage::%s - %p - url: %s [requesting large async decoding]", __FUNCTION__, this, sourceURL().string().utf8().data());
-m_source.requestFrameAsyncDecodingAtIndex(0, m_currentSubsamplingLevel, sizeForDrawing);
+frameIsBeingDecoded = m_source.requestFrameAsyncDecodingAtIndex(0, m_currentSubsamplingLevel, sizeForDrawing);
 }
 
 if (!frameHasDecodedNativeImageCompatibleWithOptionsAtIndex(m_currentFrame, m_currentSubsamplingLevel, DecodingMode::Asynchronous)) {
@@ -196,6 +201,7 @@
 }
 
 image = frameImageAtIndex(m_currentFrame);
+ASSERT_IMPLIES(encodedDataStatus() == EncodedDataStatus::Complete, frameIsBeingDecoded || frameIsComplete);
 LOG(Images, "BitmapImage::%s - %p - url: %s [a decoded image frame is available for drawing]", __FUNCTION__, this, sourceURL().string().utf8().data());
 } else {
 StartAnimationStatus status = internalStartAnimation();


Modified: trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp (216470 => 216471)

--- trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp	2017-05-09 01:45:20 UTC (rev 216470)
+++ trunk/Source/WebCore/platform/graphics/ImageFrameCache.cpp	2017-05-09 01:53:54 UTC (rev 216471)
@@ -247,7 +247,7 @@
 return;
 
 ASSERT(index < m_frames.size());
-ASSERT(!frameHasDecodedNativeImageCompatibleWithOptionsAtIndex(index, 

[webkit-changes] [216470] trunk/Source/WebCore

[wenson_hsieh]

Title: [216470] trunk/Source/WebCore








Revision 216470
Author wenson_hs...@apple.com
Date 2017-05-08 18:45:20 -0700 (Mon, 08 May 2017)


Log Message
Guard DragController::cleanupAfterSystemDrag to only clear drag state on Mac
https://bugs.webkit.org/show_bug.cgi?id=171771


Reviewed by Tim Horton.

The call to dragEnded here seems to have been added because a client could override Mac WK1
WebUIDelegate methods to cause this cleanup to never be performed. Since this limitation only
applies to Mac, guard it as such.

* page/mac/DragControllerMac.mm:
(WebCore::DragController::cleanupAfterSystemDrag):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/mac/DragControllerMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216469 => 216470)

--- trunk/Source/WebCore/ChangeLog	2017-05-09 01:41:58 UTC (rev 216469)
+++ trunk/Source/WebCore/ChangeLog	2017-05-09 01:45:20 UTC (rev 216470)
@@ -1,3 +1,18 @@
+2017-05-08  Wenson Hsieh  
+
+Guard DragController::cleanupAfterSystemDrag to only clear drag state on Mac
+https://bugs.webkit.org/show_bug.cgi?id=171771
+
+
+Reviewed by Tim Horton.
+
+The call to dragEnded here seems to have been added because a client could override Mac WK1
+WebUIDelegate methods to cause this cleanup to never be performed. Since this limitation only
+applies to Mac, guard it as such.
+
+* page/mac/DragControllerMac.mm:
+(WebCore::DragController::cleanupAfterSystemDrag):
+
 2017-05-08  Commit Queue  
 
 Unreviewed, rolling out r216262.


Modified: trunk/Source/WebCore/page/mac/DragControllerMac.mm (216469 => 216470)

--- trunk/Source/WebCore/page/mac/DragControllerMac.mm	2017-05-09 01:41:58 UTC (rev 216469)
+++ trunk/Source/WebCore/page/mac/DragControllerMac.mm	2017-05-09 01:45:20 UTC (rev 216470)
@@ -90,6 +90,7 @@
 
 void DragController::cleanupAfterSystemDrag()
 {
+#if PLATFORM(MAC)
 // Drag has ended, dragEnded *should* have been called, however it is possible
 // for the UIDelegate to take over the drag, and fail to send the appropriate
 // drag termination event.  As dragEnded just resets drag variables, we just
@@ -98,6 +99,7 @@
 // is asynchronous.
 if (m_page.mainFrame().view()->platformWidget())
 dragEnded();
+#endif
 }
 
 #if ENABLE(DATA_INTERACTION)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216469] trunk/Source/WebCore

[commit-queue]

Title: [216469] trunk/Source/WebCore








Revision 216469
Author commit-qu...@webkit.org
Date 2017-05-08 18:41:58 -0700 (Mon, 08 May 2017)


Log Message
Unreviewed, rolling out r216262.
https://bugs.webkit.org/show_bug.cgi?id=171842

"It regressed JetStream on iOS by 7%" (Requested by saamyjoon
on #webkit).

Reverted changeset:

"GCController.cpp's collect() should be Async"
https://bugs.webkit.org/show_bug.cgi?id=171708
http://trac.webkit.org/changeset/216262

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/GCController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216468 => 216469)

--- trunk/Source/WebCore/ChangeLog	2017-05-09 01:35:22 UTC (rev 216468)
+++ trunk/Source/WebCore/ChangeLog	2017-05-09 01:41:58 UTC (rev 216469)
@@ -1,3 +1,17 @@
+2017-05-08  Commit Queue  
+
+Unreviewed, rolling out r216262.
+https://bugs.webkit.org/show_bug.cgi?id=171842
+
+"It regressed JetStream on iOS by 7%" (Requested by saamyjoon
+on #webkit).
+
+Reverted changeset:
+
+"GCController.cpp's collect() should be Async"
+https://bugs.webkit.org/show_bug.cgi?id=171708
+http://trac.webkit.org/changeset/216262
+
 2017-05-08  Chris Dumez  
 
 Move offsetParent / offsetLeft / offsetTop / offsetWidth / offsetHeight from Element to HTMLElement


Modified: trunk/Source/WebCore/bindings/js/GCController.cpp (216468 => 216469)

--- trunk/Source/WebCore/bindings/js/GCController.cpp	2017-05-09 01:35:22 UTC (rev 216468)
+++ trunk/Source/WebCore/bindings/js/GCController.cpp	2017-05-09 01:41:58 UTC (rev 216469)
@@ -41,7 +41,7 @@
 static void collect(void*)
 {
 JSLockHolder lock(commonVM());
-commonVM().heap.collectNow(Async, CollectionScope::Full);
+commonVM().heap.collectNow(Sync, CollectionScope::Full);
 }
 
 GCController& GCController::singleton()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216468] trunk/Source/JavaScriptCore

[sbarati]

Title: [216468] trunk/Source/_javascript_Core








Revision 216468
Author sbar...@apple.com
Date 2017-05-08 18:35:22 -0700 (Mon, 08 May 2017)


Log Message
testWasmBoundsCheck and testCallFunctionWithHellaArguments is broken in testb3
https://bugs.webkit.org/show_bug.cgi?id=171392


Reviewed by Keith Miller.

This patch fixes two bugs. The first one is:
Inside testb3, we were using the wrong WasmBoundsCheckValue constructor.
Everything compiled OK because of implicit casting in C. I've changed one
of the constructors to take arguments in a different order so we don't
run into this problem again.

The second bug was that Air::ShufflePair::inst was assuming that a move
from BigImm to its destination is always valid. This is not the case.
For example, the store, `Move BigImm, Addr` is not allowed. I refactored
the code to be correct by emitting more than one instruction when needeed.

When testing my changes, I ran ARM64 testb3 both in debug and
release. I ran into many pre-existing failures. I've opened
a new bug to fix those here: https://bugs.webkit.org/show_bug.cgi?id=171826

* b3/B3WasmBoundsCheckValue.cpp:
(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
* b3/B3WasmBoundsCheckValue.h:
* b3/air/AirEmitShuffle.cpp:
(JSC::B3::Air::ShufflePair::insts):
(JSC::B3::Air::ShufflePair::inst): Deleted.
* b3/air/AirEmitShuffle.h:
* b3/air/AirLowerMacros.cpp:
(JSC::B3::Air::lowerMacros):
* b3/testb3.cpp:
(JSC::B3::testLoadAcq42):
(JSC::B3::testStoreRelAddLoadAcq32):
(JSC::B3::testStoreRelAddLoadAcq8):
(JSC::B3::testStoreRelAddFenceLoadAcq8):
(JSC::B3::testStoreRelAddLoadAcq16):
(JSC::B3::testStoreRelAddLoadAcq64):
(JSC::B3::testSimplePatchpointWithOuputClobbersGPArgs):
(JSC::B3::testCheckMul):
(JSC::B3::testCheckMulMemory):
(JSC::B3::testCheckMul64):
(JSC::B3::testCheckMulFold):
(JSC::B3::testCheckMulFoldFail):
(JSC::B3::testCheckMulArgumentAliasing64):
(JSC::B3::testCheckMulArgumentAliasing32):
(JSC::B3::testCheckMul64SShr):
(JSC::B3::testCallFunctionWithHellaArguments):
(JSC::B3::functionWithHellaArguments2):
(JSC::B3::testCallFunctionWithHellaArguments2):
(JSC::B3::functionWithHellaArguments3):
(JSC::B3::testCallFunctionWithHellaArguments3):
(JSC::B3::testSpillDefSmallerThanUse):
(JSC::B3::testLateRegister):
(JSC::B3::testTerminalPatchpointThatNeedsToBeSpilled):
(JSC::B3::testTerminalPatchpointThatNeedsToBeSpilled2):
(JSC::B3::testMoveConstants):
(JSC::B3::testAtomicWeakCAS):
(JSC::B3::testAtomicStrongCAS):
(JSC::B3::testAtomicXchg):
(JSC::B3::testWasmBoundsCheck):
(JSC::B3::run):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.cpp
trunk/Source/_javascript_Core/b3/B3WasmBoundsCheckValue.h
trunk/Source/_javascript_Core/b3/air/AirEmitShuffle.cpp
trunk/Source/_javascript_Core/b3/air/AirEmitShuffle.h
trunk/Source/_javascript_Core/b3/air/AirLowerMacros.cpp
trunk/Source/_javascript_Core/b3/testb3.cpp
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216467 => 216468)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-09 00:32:33 UTC (rev 216467)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-09 01:35:22 UTC (rev 216468)
@@ -1,3 +1,69 @@
+2017-05-08  Saam Barati  
+
+testWasmBoundsCheck and testCallFunctionWithHellaArguments is broken in testb3
+https://bugs.webkit.org/show_bug.cgi?id=171392
+
+
+Reviewed by Keith Miller.
+
+This patch fixes two bugs. The first one is:
+Inside testb3, we were using the wrong WasmBoundsCheckValue constructor.
+Everything compiled OK because of implicit casting in C. I've changed one
+of the constructors to take arguments in a different order so we don't
+run into this problem again.
+
+The second bug was that Air::ShufflePair::inst was assuming that a move
+from BigImm to its destination is always valid. This is not the case.
+For example, the store, `Move BigImm, Addr` is not allowed. I refactored
+the code to be correct by emitting more than one instruction when needeed.
+
+When testing my changes, I ran ARM64 testb3 both in debug and
+release. I ran into many pre-existing failures. I've opened
+a new bug to fix those here: https://bugs.webkit.org/show_bug.cgi?id=171826
+
+* b3/B3WasmBoundsCheckValue.cpp:
+(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
+* b3/B3WasmBoundsCheckValue.h:
+* b3/air/AirEmitShuffle.cpp:
+(JSC::B3::Air::ShufflePair::insts):
+(JSC::B3::Air::ShufflePair::inst): Deleted.
+* b3/air/AirEmitShuffle.h:
+* b3/air/AirLowerMacros.cpp:
+(JSC::B3::Air::lowerMacros):
+* b3/testb3.cpp:
+(JSC::B3::testLoadAcq42):
+(JSC::B3::testStoreRelAddLoadAcq32):
+

[webkit-changes] [216467] trunk/LayoutTests

[ryanhaddad]

Title: [216467] trunk/LayoutTests








Revision 216467
Author ryanhad...@apple.com
Date 2017-05-08 17:32:33 -0700 (Mon, 08 May 2017)


Log Message
Marked http/tests/security/storage-blocking-loosened-plugin.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=171837

Unreviewed test gardening.

Patch by Matt Lewis  on 2017-05-08

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216466 => 216467)

--- trunk/LayoutTests/ChangeLog	2017-05-09 00:16:18 UTC (rev 216466)
+++ trunk/LayoutTests/ChangeLog	2017-05-09 00:32:33 UTC (rev 216467)
@@ -1,3 +1,12 @@
+2017-05-08  Matt Lewis  
+
+Marked http/tests/security/storage-blocking-loosened-plugin.html as flaky
+https://bugs.webkit.org/show_bug.cgi?id=171837
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2017-05-08  Chris Dumez  
 
 Move offsetParent / offsetLeft / offsetTop / offsetWidth / offsetHeight from Element to HTMLElement


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216466 => 216467)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-09 00:16:18 UTC (rev 216466)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-09 00:32:33 UTC (rev 216467)
@@ -666,3 +666,5 @@
 webkit.org/b/172703 [ Sierra Debug ] webrtc/libwebrtc/descriptionGetters.html [ Pass Failure ]
 
 webkit.org/b/171763 [ Debug ] compositing/tiling/non-active-window-tiles-size.html [ Pass Failure ]
+
+webkit.org/b/171837 [ Debug ] http/tests/security/storage-blocking-loosened-plugin.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216466] trunk

[cdumez]

Title: [216466] trunk








Revision 216466
Author cdu...@apple.com
Date 2017-05-08 17:16:18 -0700 (Mon, 08 May 2017)


Log Message
Move offsetParent / offsetLeft / offsetTop / offsetWidth / offsetHeight from Element to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=171829

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Re-sync Web-Platform-Test after:
- https://github.com/w3c/web-platform-tests/pull/5855

* web-platform-tests/cssom-view/offsetParent_element_test.html:

Source/WebCore:

Move offsetParent / offsetLeft / offsetTop / offsetWidth / offsetHeight from Element to HTMLElement,
as per the specification:
- https://drafts.csswg.org/cssom-view/#extensions-to-the-htmlelement-interface

Both Firefox and Chrome match the specification and also do not have the corresponding API on
SVGElement.

Bug tracking the similar move in Blink (completed over 1 year ago):
- https://bugs.chromium.org/p/chromium/issues/detail?id=463116

Note that for the inner SVG elements like  and  these attributes were returning 0,
because those aren't part of the CSS box model. They did return correct values for the 
element itself, however.

Test: fast/css/htmlelement-offset-properties.html

* dom/Element.idl:
- Drop offset* attributes, now that they are on HTMLElement.

* html/HTMLElement.idl:
- Resync HTMLElement.idl with the specification: https://html.spec.whatwg.org/#htmlelement
  No behavior change besides what's indicated in the Changelog above. Things that do not match
  the spec have been annotated with FIXME comments.
- Add offset* attributes that used to be on Element.

LayoutTests:

* fast/css/htmlelement-offset-properties-expected.txt:
* fast/css/htmlelement-offset-properties.html:
Add layout test coverage.

* editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html:
* fast/css-grid-layout/grid-item-display.html:
* js/dom/dom-static-property-for-in-iteration-expected.txt:
* mathml/presentation/menclose-notation-no-overlap-expected.txt:
* mathml/presentation/menclose-notation-no-overlap.html:
* platform/mac/inspector/model/remote-object-expected.txt:
* svg/dynamic-updates/resources/SVGTestCase.js:
(clickAt):
* svg/text/inline-text-destroy-attributes-crash.xhtml:
Use getClientBoundingRect() instead of offset* properties for non-HTML elements.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
trunk/LayoutTests/fast/css-grid-layout/grid-item-display.html
trunk/LayoutTests/fast/events/drag-and-drop-link.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/offsetParent_element_test.html
trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt
trunk/LayoutTests/mathml/presentation/menclose-notation-no-overlap-expected.txt
trunk/LayoutTests/mathml/presentation/menclose-notation-no-overlap.html
trunk/LayoutTests/platform/mac/inspector/model/remote-object-expected.txt
trunk/LayoutTests/svg/custom/pointer-events-invalid-fill.svg
trunk/LayoutTests/svg/dynamic-updates/resources/SVGTestCase.js
trunk/LayoutTests/svg/text/inline-text-destroy-attributes-crash.xhtml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/html/HTMLElement.idl


Added Paths

trunk/LayoutTests/fast/css/htmlelement-offset-properties-expected.txt
trunk/LayoutTests/fast/css/htmlelement-offset-properties.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216465 => 216466)

--- trunk/LayoutTests/ChangeLog	2017-05-08 23:41:14 UTC (rev 216465)
+++ trunk/LayoutTests/ChangeLog	2017-05-09 00:16:18 UTC (rev 216466)
@@ -1,3 +1,25 @@
+2017-05-08  Chris Dumez  
+
+Move offsetParent / offsetLeft / offsetTop / offsetWidth / offsetHeight from Element to HTMLElement
+https://bugs.webkit.org/show_bug.cgi?id=171829
+
+Reviewed by Simon Fraser.
+
+* fast/css/htmlelement-offset-properties-expected.txt:
+* fast/css/htmlelement-offset-properties.html:
+Add layout test coverage.
+
+* editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html:
+* fast/css-grid-layout/grid-item-display.html:
+* js/dom/dom-static-property-for-in-iteration-expected.txt:
+* mathml/presentation/menclose-notation-no-overlap-expected.txt:
+* mathml/presentation/menclose-notation-no-overlap.html:
+* platform/mac/inspector/model/remote-object-expected.txt:
+* svg/dynamic-updates/resources/SVGTestCase.js:
+(clickAt):
+* svg/text/inline-text-destroy-attributes-crash.xhtml:
+Use getClientBoundingRect() instead of offset* properties for non-HTML elements.
+
 2017-05-08  Matt Lewis  
 
 Marked imported/w3c/web-platform-tests/XMLHttpRequest/timeout-multiple-fetches.html as flaky.


Modified: 

[webkit-changes] [216465] trunk/Source/WebInspectorUI

[bburg]

Title: [216465] trunk/Source/WebInspectorUI








Revision 216465
Author bb...@apple.com
Date 2017-05-08 16:41:14 -0700 (Mon, 08 May 2017)


Log Message
Web Inspector: RTL: box model labels have bad alignment
https://bugs.webkit.org/show_bug.cgi?id=171817

Reviewed by Joseph Pecoraro.

* UserInterface/Views/BoxModelDetailsSectionRow.css:
(.details-section .row.box-model .label):
(body[dir=ltr] .details-section .row.box-model .label):
(body[dir=rtl] .details-section .row.box-model .label):
We can't just use a mirrored leading margin because all the
text here is center-aligned. Just hardcode a reasonable value.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (216464 => 216465)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-05-08 23:39:45 UTC (rev 216464)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-05-08 23:41:14 UTC (rev 216465)
@@ -1,3 +1,17 @@
+2017-05-08  Brian Burg  
+
+Web Inspector: RTL: box model labels have bad alignment
+https://bugs.webkit.org/show_bug.cgi?id=171817
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/BoxModelDetailsSectionRow.css:
+(.details-section .row.box-model .label):
+(body[dir=ltr] .details-section .row.box-model .label):
+(body[dir=rtl] .details-section .row.box-model .label):
+We can't just use a mirrored leading margin because all the
+text here is center-aligned. Just hardcode a reasonable value.
+
 2017-05-08  Joseph Pecoraro  
 
 Web Inspector: Request/Response toggles not working


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css (216464 => 216465)

--- trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css	2017-05-08 23:39:45 UTC (rev 216464)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css	2017-05-08 23:41:14 UTC (rev 216465)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -32,11 +32,17 @@
 .details-section .row.box-model .label {
 position: absolute;
 color: black;
+padding: 0 2px;
+}
+
+body[dir=ltr] .details-section .row.box-model .label {
 margin-left: 3px;
-padding-left: 2px;
-padding-right: 2px;
 }
 
+body[dir=rtl] .details-section .row.box-model .label {
+margin-right: 16px;
+}
+
 .details-section .row.box-model :matches(.position, .margin, .border, .padding, .content) {
 border: 1px solid grey;
 background-color: white;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216464] trunk/LayoutTests

[ryanhaddad]

Title: [216464] trunk/LayoutTests








Revision 216464
Author ryanhad...@apple.com
Date 2017-05-08 16:39:45 -0700 (Mon, 08 May 2017)


Log Message
Marked imported/w3c/web-platform-tests/XMLHttpRequest/timeout-multiple-fetches.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169637

Unreviewed test gardening.

Patch by Matt Lewis  on 2017-05-08

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216463 => 216464)

--- trunk/LayoutTests/ChangeLog	2017-05-08 23:31:56 UTC (rev 216463)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 23:39:45 UTC (rev 216464)
@@ -1,3 +1,12 @@
+2017-05-08  Matt Lewis  
+
+Marked imported/w3c/web-platform-tests/XMLHttpRequest/timeout-multiple-fetches.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=169637
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2017-05-08  Jonathan Bedard  
 
 Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216463 => 216464)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-08 23:31:56 UTC (rev 216463)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-08 23:39:45 UTC (rev 216464)
@@ -1971,3 +1971,5 @@
 webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]
 
 webkit.org/b/171830 [ Debug ] http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]
+
+webkit.org/b/169637 imported/w3c/web-platform-tests/XMLHttpRequest/timeout-multiple-fetches.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216463] trunk/Source

[commit-queue]

Title: [216463] trunk/Source








Revision 216463
Author commit-qu...@webkit.org
Date 2017-05-08 16:31:56 -0700 (Mon, 08 May 2017)


Log Message
Add support for reading and writing settings from UIProcess audio capture
https://bugs.webkit.org/show_bug.cgi?id=171633

Patch by Youenn Fablet  on 2017-05-08
Reviewed by Eric Carlson.

Source/WebCore:

Covered by manual testing and existing test sets.

Moving success/failure callbacks for applyConstraints.
Making main RealtimeMediaSource::applyConstraints virtual so that WebProcess source proxies can implement it by
doing an IPC call directly. Doing so for UIProcess CoreAudioCaptureSource.

Adding support for volume to CoreAudioCaptureSource by applying gain post-capturing.
Adding support for toggling echo cancellation in CoreAudioCaptureSource.
Adding support to change echo cancellation and sample rate by scheduling a reconfiguration of the audio unit.
To do so, we stop producing data, delete the audio unit and restart producing data.
Removing CoreAudioCaptureSource::supportedConstraints as it is redundant with
RealtimeMediaSourceSettings::supportedConstraints.

Setting sample rate only to the following values: 8000, 16000, 32000, 44100, 48000.

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::applyConstraints):
* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::applyConstraints):
* platform/mediastream/MediaStreamTrackPrivate.h:
* platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::applyConstraints):
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/RealtimeMediaSourceSettings.h:
(WebCore::RealtimeMediaSourceSettings::supportedConstraints):
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::~CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::processMicrophoneSamples):
(WebCore::CoreAudioCaptureSource::cleanupAudioUnit):
(WebCore::CoreAudioCaptureSource::createAudioUnit):
(WebCore::CoreAudioCaptureSource::configureAudioUnit):
(WebCore::CoreAudioCaptureSource::startProducingData):
(WebCore::CoreAudioCaptureSource::capabilities):
(WebCore::CoreAudioCaptureSource::settings):
(WebCore::CoreAudioCaptureSource::applySampleRate):
(WebCore::CoreAudioCaptureSource::applyEchoCancellation):
(WebCore::CoreAudioCaptureSource::scheduleReconfiguration):
(WebCore::CoreAudioCaptureSource::cleanupAudioUnits): Deleted.
(WebCore::CoreAudioCaptureSource::setupAudioUnits): Deleted.
* platform/mediastream/mac/CoreAudioCaptureSource.h:

Source/WebKit2:

* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::applyConstraints):
* UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
* UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::setSettings):
(WebKit::UserMediaCaptureManager::Source::applyConstraintsSucceeded):
(WebKit::UserMediaCaptureManager::Source::applyConstraintsFailed):
(WebKit::UserMediaCaptureManager::createCaptureSource):
(WebKit::UserMediaCaptureManager::sourceSettingsChanged):
(WebKit::UserMediaCaptureManager::applyConstraints):
(WebKit::UserMediaCaptureManager::applyConstraintsSucceeded):
(WebKit::UserMediaCaptureManager::applyConstraintsFailed):
(WebKit::UserMediaCaptureManager::Source::setMuted): Deleted.
(WebKit::UserMediaCaptureManager::Source::setEnabled): Deleted.
* WebProcess/cocoa/UserMediaCaptureManager.h:
* WebProcess/cocoa/UserMediaCaptureManager.messages.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.h
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h
trunk/Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in
trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.cpp
trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.h
trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.messages.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (216462 => 216463)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 23:15:00 UTC (rev 216462)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 23:31:56 UTC (rev 216463)
@@ -1,3 +1,51 @@
+2017-05-08  Youenn Fablet  
+
+Add 

[webkit-changes] [216462] trunk

[jbedard]

Title: [216462] trunk








Revision 216462
Author jbed...@apple.com
Date 2017-05-08 16:15:00 -0700 (Mon, 08 May 2017)


Log Message
Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
https://bugs.webkit.org/show_bug.cgi?id=169421


Reviewed by Tim Horton.

Tools:

* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(createBitmapContextFromWebView): Implement for IOSurface.
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.

LayoutTests:

* platform/ios-device/TestExpectations: Mark compositing tests as failures, this
is due to a bug tracked in https://bugs.webkit.org/show_bug.cgi?id=170772.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-device/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm
trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (216461 => 216462)

--- trunk/LayoutTests/ChangeLog	2017-05-08 23:12:29 UTC (rev 216461)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 23:15:00 UTC (rev 216462)
@@ -1,3 +1,14 @@
+2017-05-08  Jonathan Bedard  
+
+Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
+https://bugs.webkit.org/show_bug.cgi?id=169421
+
+
+Reviewed by Tim Horton.
+
+* platform/ios-device/TestExpectations: Mark compositing tests as failures, this
+is due to a bug tracked in https://bugs.webkit.org/show_bug.cgi?id=170772.
+
 2017-05-08  Chris Dumez  
 
 Drop non-standard document.implementation.createCSSStyleSheet() API


Modified: trunk/LayoutTests/platform/ios-device/TestExpectations (216461 => 216462)

--- trunk/LayoutTests/platform/ios-device/TestExpectations	2017-05-08 23:12:29 UTC (rev 216461)
+++ trunk/LayoutTests/platform/ios-device/TestExpectations	2017-05-08 23:15:00 UTC (rev 216462)
@@ -3,3 +3,10 @@
 # See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
 #
 
+# https://bugs.webkit.org/show_bug.cgi?id=170772
+compositing/geometry/clipped-out-perspective.html [ ImageOnlyFailure ]
+compositing/hidpi-subpixel-transform-origin.html [ ImageOnlyFailure ]
+compositing/regions/position-layer-inside-region-overflow-hidden.html [ ImageOnlyFailure ]
+compositing/regions/position-layers-inside-region-overflow-hidden.html [ ImageOnlyFailure ]
+compositing/regions/position-layers-inside-regions-overflow-hidden.html [ ImageOnlyFailure ]
+


Modified: trunk/Tools/ChangeLog (216461 => 216462)

--- trunk/Tools/ChangeLog	2017-05-08 23:12:29 UTC (rev 216461)
+++ trunk/Tools/ChangeLog	2017-05-08 23:15:00 UTC (rev 216462)
@@ -1,5 +1,18 @@
 2017-05-08  Jonathan Bedard  
 
+Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
+https://bugs.webkit.org/show_bug.cgi?id=169421
+
+
+Reviewed by Tim Horton.
+
+* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
+(createBitmapContextFromWebView): Implement for IOSurface.
+* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
+(WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
+
+2017-05-08  Jonathan Bedard  
+
 buildbot: Cleanup simulators after running tests
 https://bugs.webkit.org/show_bug.cgi?id=171679
 


Modified: trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm (216461 => 216462)

--- trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm	2017-05-08 23:12:29 UTC (rev 216461)
+++ trunk/Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm	2017-05-08 23:15:00 UTC (rev 216462)
@@ -38,6 +38,10 @@
 #import 
 #import 
 #import 
+#import 
+#import 
+#import 
+#import 
 #import 
 #import 
 #import 
@@ -56,16 +60,32 @@
 WebThreadLock();
 [CATransaction flush];
 
-#if USE(IOSURFACE)
-return nullptr;
-#else
 CGFloat deviceScaleFactor = 2; // FIXME: hardcode 2x for now. In future we could respect 1x and 3x as we do on Mac.
-CATransform3D transform = CATransform3DMakeScale(deviceScaleFactor, deviceScaleFactor, 1);
 
 CGSize viewSize = [[mainFrame webView] frame].size;
 int bufferWidth = ceil(viewSize.width * deviceScaleFactor);
 int bufferHeight = ceil(viewSize.height * deviceScaleFactor);
 
+#if USE(IOSURFACE)
+WebCore::FloatSize snapshotSize(viewSize);
+snapshotSize.scale(deviceScaleFactor);
+
+WebCore::IOSurface::Format snapshotFormat = WebCore::screenSupportsExtendedColor() ? WebCore::IOSurface::Format::RGB10 : WebCore::IOSurface::Format::RGBA;
+auto surface = WebCore::IOSurface::create(WebCore::expandedIntSize(snapshotSize), WebCore::sRGBColorSpaceRef(), snapshotFormat);
+RetainPtr cgImage = surface->createImage();
+
+void* bitmapBuffer = nullptr;
+size_t bitmapRowBytes = 0;
+auto bitmapContext = createBitmapContext(bufferWidth, 

[webkit-changes] [216461] trunk/Source/WebInspectorUI

[commit-queue]

Title: [216461] trunk/Source/WebInspectorUI








Revision 216461
Author commit-qu...@webkit.org
Date 2017-05-08 16:12:29 -0700 (Mon, 08 May 2017)


Log Message
Web Inspector: Request/Response toggles not working
https://bugs.webkit.org/show_bug.cgi?id=171833


Patch by Joseph Pecoraro  on 2017-05-08
Reviewed by Brian Burg.

* UserInterface/Views/HierarchicalPathNavigationItem.js:
(WebInspector.HierarchicalPathNavigationItem.set components.let.componentsEqual):
(WebInspector.HierarchicalPathNavigationItem.prototype.set components):
If the new components being set were shallowly equal, then they wouldn't
actually be updated even if ultimately they are different. In this case
the Path Components with values "request" / "response" would not update
between different resources because the path components had equivalent
simple values. Provide a different discriminator (comparisonData) which
can be an object so these path components compare as necessarily different.

* UserInterface/Views/HeapSnapshotClusterContentView.js:
(WebInspector.HeapSnapshotClusterContentView.createPathComponent):
(WebInspector.HeapSnapshotClusterContentView):
* UserInterface/Views/ResourceClusterContentView.js:
(WebInspector.ResourceClusterContentView.createPathComponent):
(WebInspector.ResourceClusterContentView):
(WebInspector.ResourceClusterContentView.prototype._resourceTypeDidChange):
* UserInterface/Views/SVGImageResourceClusterContentView.js:
(WebInspector.SVGImageResourceClusterContentView):
* UserInterface/Views/ScriptClusterTimelineView.js:
(WebInspector.ScriptClusterTimelineView.createPathComponent):
(WebInspector.ScriptClusterTimelineView):
Provide comparisonData for path components cases that would need it.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotClusterContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/HierarchicalPathNavigationItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/SVGImageResourceClusterContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ScriptClusterTimelineView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (216460 => 216461)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-05-08 22:51:11 UTC (rev 216460)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-05-08 23:12:29 UTC (rev 216461)
@@ -1,3 +1,35 @@
+2017-05-08  Joseph Pecoraro  
+
+Web Inspector: Request/Response toggles not working
+https://bugs.webkit.org/show_bug.cgi?id=171833
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/HierarchicalPathNavigationItem.js:
+(WebInspector.HierarchicalPathNavigationItem.set components.let.componentsEqual):
+(WebInspector.HierarchicalPathNavigationItem.prototype.set components):
+If the new components being set were shallowly equal, then they wouldn't
+actually be updated even if ultimately they are different. In this case
+the Path Components with values "request" / "response" would not update
+between different resources because the path components had equivalent
+simple values. Provide a different discriminator (comparisonData) which
+can be an object so these path components compare as necessarily different.
+
+* UserInterface/Views/HeapSnapshotClusterContentView.js:
+(WebInspector.HeapSnapshotClusterContentView.createPathComponent):
+(WebInspector.HeapSnapshotClusterContentView):
+* UserInterface/Views/ResourceClusterContentView.js:
+(WebInspector.ResourceClusterContentView.createPathComponent):
+(WebInspector.ResourceClusterContentView):
+(WebInspector.ResourceClusterContentView.prototype._resourceTypeDidChange):
+* UserInterface/Views/SVGImageResourceClusterContentView.js:
+(WebInspector.SVGImageResourceClusterContentView):
+* UserInterface/Views/ScriptClusterTimelineView.js:
+(WebInspector.ScriptClusterTimelineView.createPathComponent):
+(WebInspector.ScriptClusterTimelineView):
+Provide comparisonData for path components cases that would need it.
+
 2017-05-08  Chris Dumez  
 
 Drop non-standard Element.scrollByLines() / scrollByPages()


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotClusterContentView.js (216460 => 216461)

--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotClusterContentView.js	2017-05-08 22:51:11 UTC (rev 216460)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotClusterContentView.js	2017-05-08 23:12:29 UTC (rev 216461)
@@ -37,6 +37,7 @@
 {
 let pathComponent = new WebInspector.HierarchicalPathComponent(displayName, className, identifier, false, true);
 

[webkit-changes] [216460] trunk/Source/JavaScriptCore

[fpizlo]

Title: [216460] trunk/Source/_javascript_Core








Revision 216460
Author fpi...@apple.com
Date 2017-05-08 15:51:11 -0700 (Mon, 08 May 2017)


Log Message
Expose a function to get proxy targets
https://bugs.webkit.org/show_bug.cgi?id=171797


Reviewed by Mark Lam.

This exposes a new private API function, JSObjectGetProxyTarget(), that gets the target of a
proxy. It works with both ProxyObject and JSProxy, but it's primarily intended for use with
JSProxy.

* API/JSObjectRef.cpp:
(JSObjectGetProxyTarget):
* API/JSObjectRefPrivate.h:
* API/tests/JSObjectGetProxyTargetTest.cpp: Added.
(testJSObjectGetProxyTarget):
* API/tests/JSObjectGetProxyTargetTest.h: Added.
* API/tests/testapi.c:
(main):
* _javascript_Core.xcodeproj/project.pbxproj:
* runtime/ProxyObject.h:
* shell/PlatformWin.cmake: 

Modified Paths

trunk/Source/_javascript_Core/API/JSObjectRef.cpp
trunk/Source/_javascript_Core/API/JSObjectRefPrivate.h
trunk/Source/_javascript_Core/API/tests/testapi.c
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/runtime/ProxyObject.h
trunk/Source/_javascript_Core/shell/PlatformWin.cmake


Added Paths

trunk/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.cpp
trunk/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.h




Diff

Modified: trunk/Source/_javascript_Core/API/JSObjectRef.cpp (216459 => 216460)

--- trunk/Source/_javascript_Core/API/JSObjectRef.cpp	2017-05-08 22:24:29 UTC (rev 216459)
+++ trunk/Source/_javascript_Core/API/JSObjectRef.cpp	2017-05-08 22:51:11 UTC (rev 216460)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006, 2007, 2008, 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2006-2017 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Kelvin W Sherlock (ksherl...@gmail.com)
  *
  * Redistribution and use in source and binary forms, with or without
@@ -52,6 +52,7 @@
 #include "ObjectConstructor.h"
 #include "ObjectPrototype.h"
 #include "PropertyNameArray.h"
+#include "ProxyObject.h"
 #include "RegExpConstructor.h"
 
 #if ENABLE(REMOTE_INSPECTOR)
@@ -675,3 +676,18 @@
 JSLockHolder locker(propertyNames->vm());
 propertyNames->add(propertyName->identifier(propertyNames->vm()));
 }
+
+JSObjectRef JSObjectGetProxyTarget(JSObjectRef objectRef)
+{
+JSObject* object = toJS(objectRef);
+if (!object)
+return nullptr;
+VM& vm = *object->vm();
+JSLockHolder locker(vm);
+JSObject* result = nullptr;
+if (JSProxy* proxy = jsDynamicCast(vm, object))
+result = proxy->target();
+else if (ProxyObject* proxy = jsDynamicCast(vm, object))
+result = proxy->target();
+return toRef(result);
+}


Modified: trunk/Source/_javascript_Core/API/JSObjectRefPrivate.h (216459 => 216460)

--- trunk/Source/_javascript_Core/API/JSObjectRefPrivate.h	2017-05-08 22:24:29 UTC (rev 216459)
+++ trunk/Source/_javascript_Core/API/JSObjectRefPrivate.h	2017-05-08 22:51:11 UTC (rev 216460)
@@ -67,6 +67,8 @@
  */
 JS_EXPORT bool JSObjectDeletePrivateProperty(JSContextRef ctx, JSObjectRef object, JSStringRef propertyName);
 
+JS_EXPORT JSObjectRef JSObjectGetProxyTarget(JSObjectRef);
+
 #ifdef __cplusplus
 }
 #endif


Added: trunk/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.cpp (0 => 216460)

--- trunk/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.cpp	(rev 0)
+++ trunk/Source/_javascript_Core/API/tests/JSObjectGetProxyTargetTest.cpp	2017-05-08 22:51:11 UTC (rev 216460)
@@ -0,0 +1,89 @@
+/*
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include 

[webkit-changes] [216459] trunk

[mark . lam]

Title: [216459] trunk








Revision 216459
Author mark@apple.com
Date 2017-05-08 15:24:29 -0700 (Mon, 08 May 2017)


Log Message
op_throw_static_error's use of its first operand should be reflected in DFG BytecodeUseDef as well.
https://bugs.webkit.org/show_bug.cgi?id=171786


Reviewed by Saam Barati.

JSTests:

* stress/bug-171786.js: Added.

Source/_javascript_Core:

* bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper::dumpBytecode):
- Fix BytecodeDumper to dump op_throw_static_error correctly.  Previously,
  it was expecting op1 to always be a constant.  r206870 changed it to take a
  variable string as well.

* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
- Fix the bug.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- Move the Phantom of op1 after the ThrowStaticError node, because technically,
  the ThrowStaticError represents op_throw_static_error, and op_throw_static_error
  uses op1.  In practice, this probably doesn't matter, but let's have the code
  accurately communicate the behavior we're expecting.

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeDumper.cpp
trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp


Added Paths

trunk/JSTests/stress/bug-171786.js




Diff

Modified: trunk/JSTests/ChangeLog (216458 => 216459)

--- trunk/JSTests/ChangeLog	2017-05-08 22:17:59 UTC (rev 216458)
+++ trunk/JSTests/ChangeLog	2017-05-08 22:24:29 UTC (rev 216459)
@@ -1,3 +1,13 @@
+2017-05-08  Mark Lam  
+
+op_throw_static_error's use of its first operand should be reflected in DFG BytecodeUseDef as well.
+https://bugs.webkit.org/show_bug.cgi?id=171786
+
+
+Reviewed by Saam Barati.
+
+* stress/bug-171786.js: Added.
+
 2017-05-06  Oleksandr Skachkov  
 
 [ES6] Arrow function. Issue in access to this after eval('super()') within constructor


Added: trunk/JSTests/stress/bug-171786.js (0 => 216459)

--- trunk/JSTests/stress/bug-171786.js	(rev 0)
+++ trunk/JSTests/stress/bug-171786.js	2017-05-08 22:24:29 UTC (rev 216459)
@@ -0,0 +1,15 @@
+
+function foo(i, x) {
+return String.prototype.big.call(x);
+}
+noInline(foo);
+
+for (var i = 0; i < 1000; i++) {
+try {
+if (i < 200)
+foo(i, "hello");
+else
+foo(i, undefined);
+} catch(e) {
+}
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (216458 => 216459)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-08 22:17:59 UTC (rev 216458)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-08 22:24:29 UTC (rev 216459)
@@ -1,3 +1,28 @@
+2017-05-08  Mark Lam  
+
+op_throw_static_error's use of its first operand should be reflected in DFG BytecodeUseDef as well.
+https://bugs.webkit.org/show_bug.cgi?id=171786
+
+
+Reviewed by Saam Barati.
+
+* bytecode/BytecodeDumper.cpp:
+(JSC::BytecodeDumper::dumpBytecode):
+- Fix BytecodeDumper to dump op_throw_static_error correctly.  Previously,
+  it was expecting op1 to always be a constant.  r206870 changed it to take a
+  variable string as well.
+
+* bytecode/BytecodeUseDef.h:
+(JSC::computeUsesForBytecodeOffset):
+- Fix the bug.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+- Move the Phantom of op1 after the ThrowStaticError node, because technically,
+  the ThrowStaticError represents op_throw_static_error, and op_throw_static_error
+  uses op1.  In practice, this probably doesn't matter, but let's have the code
+  accurately communicate the behavior we're expecting.
+
 2017-05-08  JF Bastien  
 
 WebAssembly: don't just emit extended offset adds for patch


Modified: trunk/Source/_javascript_Core/bytecode/BytecodeDumper.cpp (216458 => 216459)

--- trunk/Source/_javascript_Core/bytecode/BytecodeDumper.cpp	2017-05-08 22:17:59 UTC (rev 216458)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeDumper.cpp	2017-05-08 22:24:29 UTC (rev 216459)
@@ -1543,10 +1543,10 @@
 break;
 }
 case op_throw_static_error: {
-int k0 = (++it)->u.operand;
+int r0 = (++it)->u.operand;
 ErrorType k1 = static_cast((++it)->u.unsignedValue);
 printLocationAndOp(out, location, it, "throw_static_error");
-out.printf("%s, ", constantName(k0).data());
+out.printf("%s, ", registerName(r0).data());
 out.print(k1);
 break;
 }


Modified: trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h (216458 => 216459)

--- trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h	2017-05-08 22:17:59 UTC (rev 216458)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h	2017-05-08 22:24:29 UTC (rev 216459)
@@ 

[webkit-changes] [216458] trunk

[cdumez]

Title: [216458] trunk








Revision 216458
Author cdu...@apple.com
Date 2017-05-08 15:17:59 -0700 (Mon, 08 May 2017)


Log Message
Drop non-standard document.implementation.createCSSStyleSheet() API
https://bugs.webkit.org/show_bug.cgi?id=171825

Reviewed by Simon Fraser.

Source/WebCore:

Drop non-standard document.implementation.createCSSStyleSheet() API.

This was never-implemented by Firefox and they actually rejected implementing it:
- Drop non-standard document.implementation.createCSSStyleSheet() API

Blink dropped this API back in 2014 after getting UseCounter data showing this was not used:
- https://bugs.chromium.org/p/chromium/issues/detail?id=363561
- https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/uDjkuGA9gQs/zytnzJ6WryYJ

The API is not useful in its current state because even though
document.implementation.createCSSStyleSheet() allows you to create a stylesheet, there is
currently no way to associate it with the document.

Test: fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html

* dom/DOMImplementation.idl:

LayoutTests:

* fast/css/DOMImplementation.createCSSStyleSheet-obsolete-expected.txt:
* fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html:
Add layout test coverage.

* fast/dom/StyleSheet/gc-parent-rule-expected.txt:
* fast/dom/StyleSheet/gc-parent-rule.html:
* fast/dom/StyleSheet/gc-parent-stylesheet-expected.txt:
* fast/dom/StyleSheet/gc-parent-stylesheet.html:
Add utility functions to construct a CSSStyleSheet object and use it instead
of document.implementation.createCSSStyleSheet().

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-rule-expected.txt
trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-rule.html
trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-stylesheet-expected.txt
trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-stylesheet.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMImplementation.idl


Added Paths

trunk/LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete-expected.txt
trunk/LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216457 => 216458)

--- trunk/LayoutTests/ChangeLog	2017-05-08 22:16:27 UTC (rev 216457)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 22:17:59 UTC (rev 216458)
@@ -1,3 +1,21 @@
+2017-05-08  Chris Dumez  
+
+Drop non-standard document.implementation.createCSSStyleSheet() API
+https://bugs.webkit.org/show_bug.cgi?id=171825
+
+Reviewed by Simon Fraser.
+
+* fast/css/DOMImplementation.createCSSStyleSheet-obsolete-expected.txt:
+* fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html:
+Add layout test coverage.
+
+* fast/dom/StyleSheet/gc-parent-rule-expected.txt:
+* fast/dom/StyleSheet/gc-parent-rule.html:
+* fast/dom/StyleSheet/gc-parent-stylesheet-expected.txt:
+* fast/dom/StyleSheet/gc-parent-stylesheet.html:
+Add utility functions to construct a CSSStyleSheet object and use it instead
+of document.implementation.createCSSStyleSheet().
+
 2017-05-08  Joanmarie Diggs  
 
 AX: don't expose empty roledescription


Added: trunk/LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete-expected.txt (0 => 216458)

--- trunk/LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete-expected.txt	2017-05-08 22:17:59 UTC (rev 216458)
@@ -0,0 +1,3 @@
+
+PASS DOMImplementation.createCSSStyleSheet should not exist 
+


Added: trunk/LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html (0 => 216458)

--- trunk/LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html	(rev 0)
+++ trunk/LayoutTests/fast/css/DOMImplementation.createCSSStyleSheet-obsolete.html	2017-05-08 22:17:59 UTC (rev 216458)
@@ -0,0 +1,12 @@
+
+
+
+
+test(function() {
+assert_equals(document.implementation.createCSSStyleSheet, undefined);
+}, "DOMImplementation.createCSSStyleSheet should not exist");
+
+
+


Modified: trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-rule-expected.txt (216457 => 216458)

--- trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-rule-expected.txt	2017-05-08 22:16:27 UTC (rev 216457)
+++ trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-rule-expected.txt	2017-05-08 22:17:59 UTC (rev 216458)
@@ -3,6 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+PASS sheet.__proto__ is CSSStyleSheet.prototype
 PASS rule.parentRule.foo is "bar"
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-rule.html (216457 => 216458)

--- trunk/LayoutTests/fast/dom/StyleSheet/gc-parent-rule.html	2017-05-08 22:16:27 UTC (rev 216457)
+++ 

[webkit-changes] [216456] trunk

[cdumez]

Title: [216456] trunk








Revision 216456
Author cdu...@apple.com
Date 2017-05-08 15:15:14 -0700 (Mon, 08 May 2017)


Log Message
Drop non-standard Element.scrollByLines() / scrollByPages()
https://bugs.webkit.org/show_bug.cgi?id=171820

Reviewed by Simon Fraser.

Source/WebCore:

Drop non-standard Element.scrollByLines() / scrollByPages().

Those were added a very long time ago (https://trac.webkit.org/changeset/7901/webkit)
for Safari RSS but does not seem to be used anymore.

Blink has already dropped it without issue back in 2014:
- https://bugs.chromium.org/p/chromium/issues/detail?id=398356

Their UseCounter data showed no usage:
- https://www.chromestatus.com/metrics/feature/timeline/popularity/390

Test: fast/css/element-scrollByLines-scrollByPages-obsolete.html

* dom/Element.idl:

Source/WebInspectorUI:

Drop non-standard Element.scrollByLines() / scrollByPages() from
WebInspector code.

* UserInterface/Models/NativeFunctionParameters.js:

LayoutTests:

* LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete-expected.txt:
* LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete.html:
Add layout test coverage.

* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
* fast/events/scroll-event-does-not-bubble.html:
* fast/layers/scroll-overflow-no-layer-expected.txt: Renamed from LayoutTests/fast/layers/scrollByLines-overflow-no-layer-expected.txt.
* fast/layers/scroll-overflow-no-layer.html: Renamed from LayoutTests/fast/layers/scrollByLines-overflow-no-layer.html.
Update existing tests to stop relying on the API.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
trunk/LayoutTests/fast/events/scroll-event-does-not-bubble.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js


Added Paths

trunk/LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete-expected.txt
trunk/LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete.html
trunk/LayoutTests/fast/layers/scroll-overflow-no-layer-expected.txt
trunk/LayoutTests/fast/layers/scroll-overflow-no-layer.html


Removed Paths

trunk/LayoutTests/fast/layers/scrollByLines-overflow-no-layer-expected.txt
trunk/LayoutTests/fast/layers/scrollByLines-overflow-no-layer.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216455 => 216456)

--- trunk/LayoutTests/ChangeLog	2017-05-08 22:12:39 UTC (rev 216455)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 22:15:14 UTC (rev 216456)
@@ -1,3 +1,21 @@
+2017-05-08  Chris Dumez  
+
+Drop non-standard Element.scrollByLines() / scrollByPages()
+https://bugs.webkit.org/show_bug.cgi?id=171820
+
+Reviewed by Simon Fraser.
+
+* LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete-expected.txt:
+* LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete.html:
+Add layout test coverage.
+
+* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+* fast/events/scroll-event-does-not-bubble.html:
+* fast/layers/scroll-overflow-no-layer-expected.txt: Renamed from LayoutTests/fast/layers/scrollByLines-overflow-no-layer-expected.txt.
+* fast/layers/scroll-overflow-no-layer.html: Renamed from LayoutTests/fast/layers/scrollByLines-overflow-no-layer.html.
+Update existing tests to stop relying on the API.
+
 2017-05-08  Matt Lewis  
 
 Marked http/tests/websocket/tests/hybi/workers/close.html is flaky.


Added: trunk/LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete-expected.txt (0 => 216456)

--- trunk/LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete-expected.txt	2017-05-08 22:15:14 UTC (rev 216456)
@@ -0,0 +1,4 @@
+
+PASS Element.scrollByLines 
+PASS Element.scrollByPages 
+


Added: trunk/LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete.html (0 => 216456)

--- trunk/LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete.html	(rev 0)
+++ trunk/LayoutTests/fast/css/element-scrollByLines-scrollByPages-obsolete.html	2017-05-08 22:15:14 UTC (rev 216456)
@@ -0,0 +1,18 @@
+
+
+
+
+test(function() {
+assert_equals(document.body.scrollByLines, undefined);
+assert_equals(Element.prototype.scrollByLines, undefined);
+}, "Element.scrollByLines");
+
+test(function() {
+assert_equals(document.body.scrollByPages, undefined);
+assert_equals(Element.prototype.scrollByPages, undefined);
+}, 

[webkit-changes] [216455] trunk/Source/WebCore

[commit-queue]

Title: [216455] trunk/Source/WebCore








Revision 216455
Author commit-qu...@webkit.org
Date 2017-05-08 15:12:39 -0700 (Mon, 08 May 2017)


Log Message
CoreAudioSharedUnit should own its configuration parameters
https://bugs.webkit.org/show_bug.cgi?id=171812

Patch by Youenn Fablet  on 2017-05-08
Reviewed by Eric Carlson.

Covered by manual tests.

Add sampleRate, volume and echoCancellation parameters to the shared audio unit.
Set default values when creating the shared audio unit and use those for the creation of new sources.
Add support for volume.
Add support for disabling echo cancellation.
Check valid sample rates when trying to apply a sample rate.

* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioSharedUnit::volume):
(WebCore::CoreAudioSharedUnit::sampleRate):
(WebCore::CoreAudioSharedUnit::enableEchoCancellation):
(WebCore::CoreAudioSharedUnit::setVolume):
(WebCore::CoreAudioSharedUnit::setSampleRate):
(WebCore::CoreAudioSharedUnit::setEnableEchoCancellation):
(WebCore::CoreAudioSharedUnit::CoreAudioSharedUnit):
(WebCore::CoreAudioSharedUnit::setupAudioUnits):
(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):
(WebCore::CoreAudioSharedUnit::configureSpeakerProc):
(WebCore::CoreAudioSharedUnit::processMicrophoneSamples):
(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::applySampleRate):
(WebCore::CoreAudioCaptureSource::applyEchoCancellation):
* platform/mediastream/mac/CoreAudioCaptureSource.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (216454 => 216455)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 21:51:27 UTC (rev 216454)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 22:12:39 UTC (rev 216455)
@@ -1,3 +1,36 @@
+2017-05-08  Youenn Fablet  
+
+CoreAudioSharedUnit should own its configuration parameters
+https://bugs.webkit.org/show_bug.cgi?id=171812
+
+Reviewed by Eric Carlson.
+
+Covered by manual tests.
+
+Add sampleRate, volume and echoCancellation parameters to the shared audio unit.
+Set default values when creating the shared audio unit and use those for the creation of new sources.
+Add support for volume.
+Add support for disabling echo cancellation.
+Check valid sample rates when trying to apply a sample rate.
+
+* platform/mediastream/RealtimeMediaSource.h:
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioSharedUnit::volume):
+(WebCore::CoreAudioSharedUnit::sampleRate):
+(WebCore::CoreAudioSharedUnit::enableEchoCancellation):
+(WebCore::CoreAudioSharedUnit::setVolume):
+(WebCore::CoreAudioSharedUnit::setSampleRate):
+(WebCore::CoreAudioSharedUnit::setEnableEchoCancellation):
+(WebCore::CoreAudioSharedUnit::CoreAudioSharedUnit):
+(WebCore::CoreAudioSharedUnit::setupAudioUnits):
+(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):
+(WebCore::CoreAudioSharedUnit::configureSpeakerProc):
+(WebCore::CoreAudioSharedUnit::processMicrophoneSamples):
+(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
+(WebCore::CoreAudioCaptureSource::applySampleRate):
+(WebCore::CoreAudioCaptureSource::applyEchoCancellation):
+* platform/mediastream/mac/CoreAudioCaptureSource.h:
+
 2017-05-08  Joanmarie Diggs  
 
 AX: Setting aria-orientation="horizontal" on a listbox is being overridden on the Mac


Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h (216454 => 216455)

--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h	2017-05-08 21:51:27 UTC (rev 216454)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h	2017-05-08 22:12:39 UTC (rev 216455)
@@ -215,6 +215,10 @@
 
 void notifyMutedObservers() const;
 
+void initializeVolume(double volume) { m_volume = volume; }
+void initializeSampleRate(int sampleRate) { m_sampleRate = sampleRate; }
+void initializeEchoCancellation(bool echoCancellation) { m_echoCancellation = echoCancellation; }
+
 bool m_muted { false };
 bool m_enabled { true };
 


Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (216454 => 216455)

--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2017-05-08 21:51:27 UTC (rev 216454)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2017-05-08 22:12:39 UTC (rev 216455)
@@ -80,6 +80,7 @@
 class CoreAudioSharedUnit {
 public:
 static CoreAudioSharedUnit& singleton();
+CoreAudioSharedUnit();
 
  

[webkit-changes] [216454] trunk/LayoutTests

[ryanhaddad]

Title: [216454] trunk/LayoutTests








Revision 216454
Author ryanhad...@apple.com
Date 2017-05-08 14:51:27 -0700 (Mon, 08 May 2017)


Log Message
Marked http/tests/websocket/tests/hybi/workers/close.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=171830

Unreviewed test gardening.

Patch by Matt Lewis  on 2017-05-08

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216453 => 216454)

--- trunk/LayoutTests/ChangeLog	2017-05-08 21:50:54 UTC (rev 216453)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 21:51:27 UTC (rev 216454)
@@ -1,3 +1,12 @@
+2017-05-08  Matt Lewis  
+
+Marked http/tests/websocket/tests/hybi/workers/close.html is flaky.
+https://bugs.webkit.org/show_bug.cgi?id=171830
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2017-05-08  Ryan Haddad  
 
 Mark media/modern-media-controls/status-label/status-label-font.html as flaky on mac-wk1.


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216453 => 216454)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-08 21:50:54 UTC (rev 216453)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-08 21:51:27 UTC (rev 216454)
@@ -1970,3 +1970,4 @@
 
 webkit.org/b/171638 [ Release ] http/tests/xmlhttprequest/methods.html [ Pass Timeout ]
 
+webkit.org/b/171830 [ Debug ] http/tests/websocket/tests/hybi/workers/close.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216453] trunk/LayoutTests

[ryanhaddad]

Title: [216453] trunk/LayoutTests








Revision 216453
Author ryanhad...@apple.com
Date 2017-05-08 14:50:54 -0700 (Mon, 08 May 2017)


Log Message
Mark media/modern-media-controls/status-label/status-label-font.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=171828

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216452 => 216453)

--- trunk/LayoutTests/ChangeLog	2017-05-08 20:51:42 UTC (rev 216452)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 21:50:54 UTC (rev 216453)
@@ -1,3 +1,12 @@
+2017-05-08  Ryan Haddad  
+
+Mark media/modern-media-controls/status-label/status-label-font.html as flaky on mac-wk1.
+https://bugs.webkit.org/show_bug.cgi?id=171828
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2017-05-08  Joanmarie Diggs  
 
 AX: Setting aria-orientation="horizontal" on a listbox is being overridden on the Mac


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (216452 => 216453)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-08 20:51:42 UTC (rev 216452)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-08 21:50:54 UTC (rev 216453)
@@ -350,6 +350,7 @@
 webkit.org/b/167477 [ Debug ] media/modern-media-controls/play-pause-button/play-pause-button.html [ Pass Timeout ]
 webkit.org/b/171245 [ Debug ] media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Pass Timeout ]
 webkit.org/b/171629 media/modern-media-controls/slider/slider-styles.html [ Pass Timeout ]
+webkit.org/b/171828 media/modern-media-controls/status-label/status-label-font.html [ Pass Timeout ]
 webkit.org/b/167475 [ Debug ] media/modern-media-controls/volume-slider/volume-slider-value.html [ Pass Timeout ]
 webkit.org/b/170682 [ Debug ] media/modern-media-controls/volume-up-support/volume-up-support.html [ Pass Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216451] trunk/Source/WebInspectorUI

[mattbaker]

Title: [216451] trunk/Source/WebInspectorUI








Revision 216451
Author mattba...@apple.com
Date 2017-05-08 13:49:23 -0700 (Mon, 08 May 2017)


Log Message
Web Inspector: Make it easy to dynamically show/hide a SettingsView
https://bugs.webkit.org/show_bug.cgi?id=171765


Reviewed by Brian Burg.

This patch adds SettingsTabContentView.prototype.setSettingsViewVisible,
for dynamically showing/hiding a child view (and its NavigationBar item).
The following new behavior is relevant when more that one child SettingsView
exist in the Settings tab:
 - Hiding the selected view will cause a new view to become selected.
   The previous visible view is selected, if it exists. Otherwise the
   next visible view is used.
 - Showing a view when no views are selected cause the view to be selected.

As the Settings tab currently has only one child view, the behavior above
was tested by adding a handful of vanilla SettingsView objects to the tab
and toggling their visibility.

* UserInterface/Views/NavigationBar.js:
Simplify overloaded parameter `navigationItemOrIdentifierOrIndex`, which
is used in a few places and is always an instance of NavigationItem.

(WebInspector.NavigationBar):
(WebInspector.NavigationBar.prototype.removeNavigationItem):
(WebInspector.NavigationBar.prototype.get selectedNavigationItem):
(WebInspector.NavigationBar.prototype.set selectedNavigationItem):
(WebInspector.NavigationBar.prototype.findNavigationItem):
Lookup a navigation item by its identifier.
(WebInspector.NavigationBar.prototype._findNavigationItem): Deleted.
Replaced overloaded private method with new public method.

* UserInterface/Views/NavigationItem.js:
Cleanup.
(WebInspector.NavigationItem):
(WebInspector.NavigationItem.prototype.get identifier):
(WebInspector.NavigationItem.prototype.get element):
(WebInspector.NavigationItem.prototype.get minimumWidth):
(WebInspector.NavigationItem.prototype.get parentNavigationBar):

* UserInterface/Views/SettingsTabContentView.css:
Use `visibility: hidden` instead of `display: none` when hiding the
NavigationBar, so that the selected view's top position stays the same.

(.content-view.settings):
(.content-view.settings .navigation-bar.invisible):

* UserInterface/Views/SettingsTabContentView.js:
(WebInspector.SettingsTabContentView):
Switch to an array of SettingsViews instead of a map. Fast lookup isn't
a concern due to the small number of items, and having indices simplifies
traversing the previous/next items in `setSettingsViewVisible`.

(WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
Rename `page` to `settingsView`.
(WebInspector.SettingsTabContentView.prototype.addSettingsView):
(WebInspector.SettingsTabContentView.prototype.setSettingsViewVisible):
Shows/hides the specified view. Hiding the selected SettingsView will
cause another visible view to become selected, if one exists.

(WebInspector.SettingsTabContentView.prototype._updateNavigationBarVisibility):
Helper for updating navigation bar visibility after making a change
to the navigation items.

(WebInspector.SettingsTabContentView.prototype._navigationItemSelected):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js
trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (216450 => 216451)

--- trunk/Source/WebInspectorUI/ChangeLog	2017-05-08 20:36:31 UTC (rev 216450)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-05-08 20:49:23 UTC (rev 216451)
@@ -1,3 +1,71 @@
+2017-05-08  Matt Baker  
+
+Web Inspector: Make it easy to dynamically show/hide a SettingsView
+https://bugs.webkit.org/show_bug.cgi?id=171765
+
+
+Reviewed by Brian Burg.
+
+This patch adds SettingsTabContentView.prototype.setSettingsViewVisible,
+for dynamically showing/hiding a child view (and its NavigationBar item).
+The following new behavior is relevant when more that one child SettingsView
+exist in the Settings tab:
+ - Hiding the selected view will cause a new view to become selected.
+   The previous visible view is selected, if it exists. Otherwise the
+   next visible view is used.
+ - Showing a view when no views are selected cause the view to be selected.
+
+As the Settings tab currently has only one child view, the behavior above
+was tested by adding a handful of vanilla SettingsView objects to the tab
+and toggling their visibility.
+
+* UserInterface/Views/NavigationBar.js:
+Simplify overloaded parameter `navigationItemOrIdentifierOrIndex`, which
+is used in a few places and is always an instance of NavigationItem.
+
+(WebInspector.NavigationBar):
+

[webkit-changes] [216450] trunk

[commit-queue]

Title: [216450] trunk








Revision 216450
Author commit-qu...@webkit.org
Date 2017-05-08 13:36:31 -0700 (Mon, 08 May 2017)


Log Message
[CG] To decode an image frame asynchronously, pass the native size of the image to CGImageSourceCreateThumbnailAtIndex() if it's smaller than the sizeForDrawing
https://bugs.webkit.org/show_bug.cgi?id=170864
Source/WebCore:

Patch by Said Abou-Hallawa  on 2017-05-08
Reviewed by Simon Fraser.

Tests: Existing tests were modified to test this patch.

The maxPixelSize was omitted when calling CGImageSourceCreateThumbnailAtIndex()
for the nativeSize image or when areaOf(nativeSize) < areaOf(sizeForDrawing).
The assumption was if we don't pass maxPixelSize, CG will create an image with the
nativeSize regardless how big this size is. It turns out this is wrong. CG has an
optimization to return a scaled down image if areaOf(nativeSize) is greater than
some maximum value.

This is not what we want for asynchronously image decoding. We want the decoded
frame to have the size we ask for, not some scaled down frame. The fix is to pass
always maxPixelSize to CGImageSourceCreateThumbnailAtIndex(). maxPixelSize will be
equal to maxDimension(sizeForDrawing) if sizeForDrawing is valid it is less than
maxDimension(nativeSize). Otherwise it will be equal to maxDimension(nativeSize).

* platform/graphics/DecodingOptions.h:
* platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::appendImageSourceOption):
(WebCore::appendImageSourceOptions):
(WebCore::imageSourceAsyncOptions):
(WebCore::ImageDecoder::createFrameImageAtIndex):

LayoutTests:

Patch by Said Abou-Hallawa  on 2017-05-08
Reviewed by Simon Fraser.

* fast/images/async-image-background-image-repeated-expected.html:
* fast/images/async-image-background-image-repeated.html:
* fast/images/resources/sprite-sheet-red-green-blue.png:
* fast/images/sprite-sheet-image-draw-expected.html:
* fast/images/sprite-sheet-image-draw.html:
Change the sprite image to be 200x33100 instead of 200x2100 and use it in drawing.
If the maxPixelSize is not passed to CGImageSourceCreateThumbnailAtIndex(), the
decoded farme of this image will be 30x5000 pixels (15% of the original size).

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/images/async-image-background-image-repeated-expected.html
trunk/LayoutTests/fast/images/async-image-background-image-repeated.html
trunk/LayoutTests/fast/images/resources/sprite-sheet-red-green-blue.png
trunk/LayoutTests/fast/images/sprite-sheet-image-draw-expected.html
trunk/LayoutTests/fast/images/sprite-sheet-image-draw.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/DecodingOptions.h
trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (216449 => 216450)

--- trunk/LayoutTests/ChangeLog	2017-05-08 20:25:46 UTC (rev 216449)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 20:36:31 UTC (rev 216450)
@@ -1,3 +1,19 @@
+2017-05-08  Said Abou-Hallawa  
+
+[CG] To decode an image frame asynchronously, pass the native size of the image to CGImageSourceCreateThumbnailAtIndex() if it's smaller than the sizeForDrawing
+https://bugs.webkit.org/show_bug.cgi?id=170864
+
+Reviewed by Simon Fraser.
+
+* fast/images/async-image-background-image-repeated-expected.html:
+* fast/images/async-image-background-image-repeated.html:
+* fast/images/resources/sprite-sheet-red-green-blue.png:
+* fast/images/sprite-sheet-image-draw-expected.html:
+* fast/images/sprite-sheet-image-draw.html:
+Change the sprite image to be 200x33100 instead of 200x2100 and use it in drawing.
+If the maxPixelSize is not passed to CGImageSourceCreateThumbnailAtIndex(), the
+decoded farme of this image will be 30x5000 pixels (15% of the original size).
+
 2017-05-08  Beth Dakin  
 
 WebKit should default to using sRGB with NSColor conversion instead of device 


Modified: trunk/LayoutTests/fast/images/async-image-background-image-repeated-expected.html (216449 => 216450)

--- trunk/LayoutTests/fast/images/async-image-background-image-repeated-expected.html	2017-05-08 20:25:46 UTC (rev 216449)
+++ trunk/LayoutTests/fast/images/async-image-background-image-repeated-expected.html	2017-05-08 20:36:31 UTC (rev 216450)
@@ -2,8 +2,9 @@
 
 
 .box {
-height: 100px;
+height: 50px;
 display: inline-block;
+zoom: 2;
 }
 .green-box {
 width: 100px;
@@ -30,17 +31,6 @@
 blue 87.5%
 );
 }
-@media (-webkit-min-device-pixel-ratio: 2) {
-.box {
-height: 

[webkit-changes] [216449] trunk

[bdakin]

Title: [216449] trunk








Revision 216449
Author bda...@apple.com
Date 2017-05-08 13:25:46 -0700 (Mon, 08 May 2017)


Log Message
WebKit should default to using sRGB with NSColor conversion instead of device 
color space
https://bugs.webkit.org/show_bug.cgi?id=171745
-and corresponding-
rdar://problem/28314183

Reviewed by Tim Horton.

Source/WebCore:

* platform/graphics/mac/ColorMac.mm:
(WebCore::makeRGBAFromNSColor):
(WebCore::nsColor):

LayoutTests:

* editing/mac/attributed-string/anchor-element-expected.txt:
* editing/mac/attributed-string/basic-expected.txt:
* editing/mac/attributed-string/comment-cdata-section-expected.txt:
* editing/mac/attributed-string/font-size-expected.txt:
* editing/mac/attributed-string/font-style-variant-effect-expected.txt:
* editing/mac/attributed-string/font-weight-expected.txt:
* editing/mac/attributed-string/letter-spacing-expected.txt:
* editing/mac/attributed-string/text-decorations-expected.txt:
* editing/mac/attributed-string/vertical-align-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/mac/attributed-string/anchor-element-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/basic-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/font-size-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/font-style-variant-effect-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/font-weight-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/letter-spacing-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/text-decorations-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/vertical-align-expected.txt
trunk/LayoutTests/platform/mac-elcapitan/editing/mac/attributed-string/font-style-variant-effect-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/ColorMac.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (216448 => 216449)

--- trunk/LayoutTests/ChangeLog	2017-05-08 20:11:29 UTC (rev 216448)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 20:25:46 UTC (rev 216449)
@@ -1,3 +1,23 @@
+2017-05-08  Beth Dakin  
+
+WebKit should default to using sRGB with NSColor conversion instead of device 
+color space
+https://bugs.webkit.org/show_bug.cgi?id=171745
+-and corresponding-
+rdar://problem/28314183
+
+Reviewed by Tim Horton.
+
+* editing/mac/attributed-string/anchor-element-expected.txt:
+* editing/mac/attributed-string/basic-expected.txt:
+* editing/mac/attributed-string/comment-cdata-section-expected.txt:
+* editing/mac/attributed-string/font-size-expected.txt:
+* editing/mac/attributed-string/font-style-variant-effect-expected.txt:
+* editing/mac/attributed-string/font-weight-expected.txt:
+* editing/mac/attributed-string/letter-spacing-expected.txt:
+* editing/mac/attributed-string/text-decorations-expected.txt:
+* editing/mac/attributed-string/vertical-align-expected.txt:
+
 2017-05-04  Jiewen Tan  
 
 Search events should not fire synchronously for search type input elements with incremental attribute set


Modified: trunk/LayoutTests/editing/mac/attributed-string/anchor-element-expected.txt (216448 => 216449)

--- trunk/LayoutTests/editing/mac/attributed-string/anchor-element-expected.txt	2017-05-08 20:11:29 UTC (rev 216448)
+++ trunk/LayoutTests/editing/mac/attributed-string/anchor-element-expected.txt	2017-05-08 20:25:46 UTC (rev 216449)
@@ -34,6 +34,6 @@
 [ ]
 NSFont: Times-Roman 16.00 pt.
 NSKern: 0pt
-NSStrokeColor: NSDeviceRGBColorSpace 0 0 0 1
+NSStrokeColor: NSCustomColorSpace sRGB IEC61966-2.1 colorspace 0 0 0 1
 NSStrokeWidth: 0
 


Modified: trunk/LayoutTests/editing/mac/attributed-string/basic-expected.txt (216448 => 216449)

--- trunk/LayoutTests/editing/mac/attributed-string/basic-expected.txt	2017-05-08 20:11:29 UTC (rev 216448)
+++ trunk/LayoutTests/editing/mac/attributed-string/basic-expected.txt	2017-05-08 20:25:46 UTC (rev 216449)
@@ -27,19 +27,19 @@
 [hello ]
 NSFont: Times-Roman 16.00 pt.
 NSKern: 0pt
-NSStrokeColor: NSDeviceRGBColorSpace 0 0 0 1
+NSStrokeColor: NSCustomColorSpace sRGB IEC61966-2.1 colorspace 0 0 0 1
 NSStrokeWidth: 0
 [world]
 NSBackgroundColor: rgba(255, 2295, 1530, 6) (IEC6)
-NSColor: #ff (NSDeviceRGBColorSpace)
+NSColor: rgba(255, 2295, 1530, 6) (IEC6)
 NSFont: Times-Bold 16.00 pt.
 NSKern: 0pt
-NSStrokeColor: NSDeviceRGBColorSpace 1 1 1 1
+NSStrokeColor: NSCustomColorSpace sRGB IEC61966-2.1 colorspace 1 1 1 1
 NSStrokeWidth: 0
 [ ]
 NSFont: Times-Roman 16.00 pt.
 NSKern: 0pt
-NSStrokeColor: NSDeviceRGBColorSpace 0 0 0 1
+NSStrokeColor: NSCustomColorSpace sRGB IEC61966-2.1 colorspace 0 0 0 1
 NSStrokeWidth: 0
 [WebKit]
 NSColor: rgba(255, 2295, 1530, 6) 

[webkit-changes] [216448] trunk/Source

[achristensen]

Title: [216448] trunk/Source








Revision 216448
Author achristen...@apple.com
Date 2017-05-08 13:11:29 -0700 (Mon, 08 May 2017)


Log Message
Reduce PassRefPtr use
https://bugs.webkit.org/show_bug.cgi?id=171809

Reviewed by Chris Dumez.

Source/WebCore:

* platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::createCompatibleLayerOrTakeFromPool):
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::TileCoverageMap):
* platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::TileGrid):
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::create):
(PlatformCALayerCocoa::clone):
(PlatformCALayerCocoa::animationForKey):
(PlatformCALayerCocoa::createCompatibleLayer):

Source/WebKit2:

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::setInitializationReply):
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::destroyPlugin):
(WebKit::WebProcessConnection::createPlugin):
* PluginProcess/WebProcessConnection.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runOpenPanel):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerUndoStep):
* WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::getOrCreate):
* WebProcess/WebPage/VisitedLinkTableController.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::hitTest):
(WebKit::WebFrame::createSelectionSnapshot):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebOpenPanelResultListener.cpp:
(WebKit::WebOpenPanelResultListener::create):
(WebKit::WebOpenPanelResultListener::WebOpenPanelResultListener):
* WebProcess/WebPage/WebOpenPanelResultListener.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::unapplyEditCommand):
(WebKit::WebPage::reapplyEditCommand):
* WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::create):
* WebProcess/WebPage/WebPageGroupProxy.h:
* WebProcess/WebPage/WebUndoStep.cpp:
(WebKit::WebUndoStep::create):
* WebProcess/WebPage/WebUndoStep.h:
(WebKit::WebUndoStep::step):
(WebKit::WebUndoStep::WebUndoStep):
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::create):
(WebKit::PlatformCALayerRemote::clone):
(WebKit::PlatformCALayerRemote::animationForKey):
(WebKit::PlatformCALayerRemote::createCompatibleLayer):
* WebProcess/WebPage/mac/PlatformCALayerRemote.h:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::create):
(WebKit::PlatformCALayerRemoteCustom::clone):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp
trunk/Source/WebCore/platform/graphics/ca/PlatformCALayer.h
trunk/Source/WebCore/platform/graphics/ca/TileCoverageMap.cpp
trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp
trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.h
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h
trunk/Source/WebKit2/WebProcess/WebPage/WebOpenPanelResultListener.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebOpenPanelResultListener.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.h
trunk/Source/WebKit2/WebProcess/WebPage/WebUndoStep.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebUndoStep.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (216447 => 216448)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 20:07:28 UTC (rev 216447)
+++ trunk/Source/WebCore/ChangeLog	

[webkit-changes] [216447] trunk/Tools

[jbedard]

Title: [216447] trunk/Tools








Revision 216447
Author jbed...@apple.com
Date 2017-05-08 13:07:28 -0700 (Mon, 08 May 2017)


Log Message
buildbot: Cleanup simulators after running tests
https://bugs.webkit.org/show_bug.cgi?id=171679

Reviewed by Aakash Jain.

simctl is partitioned for each user. Since kill-old-processes
is run as root, we need to specify the buildbot user when tearing
down simulators between steps.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(KillOldProcesses): Pass buildbot user to kill-old-processes.
* BuildSlaveSupport/kill-old-processes:
(main): Specify the user for simctl if one has been provided.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/BuildSlaveSupport/kill-old-processes
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (216446 => 216447)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-05-08 20:03:46 UTC (rev 216446)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2017-05-08 20:07:28 UTC (rev 216447)
@@ -150,7 +150,7 @@
 name = "kill old processes"
 description = ["killing old processes"]
 descriptionDone = ["killed old processes"]
-command = ["python", "./Tools/BuildSlaveSupport/kill-old-processes"]
+command = ["python", "./Tools/BuildSlaveSupport/kill-old-processes", "buildbot"]
 
 class CleanBuildIfScheduled(shell.Compile):
 name = "delete WebKitBuild directory"


Modified: trunk/Tools/BuildSlaveSupport/kill-old-processes (216446 => 216447)

--- trunk/Tools/BuildSlaveSupport/kill-old-processes	2017-05-08 20:03:46 UTC (rev 216446)
+++ trunk/Tools/BuildSlaveSupport/kill-old-processes	2017-05-08 20:07:28 UTC (rev 216447)
@@ -26,7 +26,7 @@
 import os, sys
 
 
-def main():
+def main(user=None):
 tasksToKillWin = [
 "cl.exe",
 "devenv.com",
@@ -113,7 +113,10 @@
 for task in tasksToKill + tasksToKillMac:
 os.system("killall -9 -v -m " + task)
 # Shutdown any simulators
-os.system("xcrun simctl shutdown booted")
+if os.geteuid() == 0 and user:
+os.system("sudo -u {} xcrun simctl shutdown booted".format(user))
+else:
+os.system("xcrun simctl shutdown booted")
 # Kill all instances of python executing run-webkit-tests
 os.system("ps aux | grep -E '.+/Python .+(run_webkit_tests|run-webkit-tests|mod_pywebsocket)' | grep -v grep | awk '{print $2}' | xargs kill")
 elif sys.platform == 'cygwin' or sys.platform == 'win32':
@@ -129,4 +132,5 @@
 
 
 if __name__ == '__main__':
-sys.exit(main())
+user = sys.argv[1] if len(sys.argv) > 1 else None
+sys.exit(main(user))


Modified: trunk/Tools/ChangeLog (216446 => 216447)

--- trunk/Tools/ChangeLog	2017-05-08 20:03:46 UTC (rev 216446)
+++ trunk/Tools/ChangeLog	2017-05-08 20:07:28 UTC (rev 216447)
@@ -1,3 +1,19 @@
+2017-05-08  Jonathan Bedard  
+
+buildbot: Cleanup simulators after running tests
+https://bugs.webkit.org/show_bug.cgi?id=171679
+
+Reviewed by Aakash Jain.
+
+simctl is partitioned for each user. Since kill-old-processes
+is run as root, we need to specify the buildbot user when tearing
+down simulators between steps.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+(KillOldProcesses): Pass buildbot user to kill-old-processes.
+* BuildSlaveSupport/kill-old-processes:
+(main): Specify the user for simctl if one has been provided.
+
 2017-05-08  Carlos Alberto Lopez Perez  
 
 REGRESSION(r216179): [GTK] Script install-dependencies misses liborc






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216446] trunk/Source

[jer . noble]

Title: [216446] trunk/Source








Revision 216446
Author jer.no...@apple.com
Date 2017-05-08 13:03:46 -0700 (Mon, 08 May 2017)


Log Message
[Mac] Audio capture fails when shouldCaptureAudioInUIProcess is set.
https://bugs.webkit.org/show_bug.cgi?id=171710

Reviewed by Eric Carlson.

Source/WebCore:

Both the shouldCaptureAudioInUIProcess setting and useAVFoundationAudioCapture setting were trying to set
the audio factory for RealtimeMediaSourceCenter, and were stomping on each others' changes. Change the way
the useAVFoundationAudioCapture works so that it only affects the defaultAudioFactory, allowing that default
to be overridden by the shuoldCaptureAudioInUIProcess setting when it calls setAudioFactory().

* page/Settings.cpp:
(WebCore::Settings::setUseAVFoundationAudioCapture):
* platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::audioFactory):
(WebCore::RealtimeMediaSourceCenter::videoFactory):
(WebCore::RealtimeMediaSourceCenter::audioCaptureDeviceManager):
(WebCore::RealtimeMediaSourceCenter::videoCaptureDeviceManager):
* platform/mediastream/RealtimeMediaSourceCenter.h:
(WebCore::RealtimeMediaSourceCenter::audioFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::videoFactory): Deleted.
(WebCore::RealtimeMediaSourceCenter::audioCaptureDeviceManager): Deleted.
(WebCore::RealtimeMediaSourceCenter::videoCaptureDeviceManager): Deleted.
* platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::setUseAVFoundationAudioCapture):
(WebCore::RealtimeMediaSourceCenterMac::singleton):
(WebCore::RealtimeMediaSourceCenter::platformCenter):
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory):
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioCaptureDeviceManager):
* platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:

Source/WebKit2:

RealtimeMediaSourceCenterMac's setUseAVFoundationAudioCapture() is now accessed via a singleton.

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.h
trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp
trunk/Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216445 => 216446)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 19:57:21 UTC (rev 216445)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 20:03:46 UTC (rev 216446)
@@ -1,3 +1,35 @@
+2017-05-08  Jer Noble  
+
+[Mac] Audio capture fails when shouldCaptureAudioInUIProcess is set.
+https://bugs.webkit.org/show_bug.cgi?id=171710
+
+Reviewed by Eric Carlson.
+
+Both the shouldCaptureAudioInUIProcess setting and useAVFoundationAudioCapture setting were trying to set
+the audio factory for RealtimeMediaSourceCenter, and were stomping on each others' changes. Change the way
+the useAVFoundationAudioCapture works so that it only affects the defaultAudioFactory, allowing that default
+to be overridden by the shuoldCaptureAudioInUIProcess setting when it calls setAudioFactory().
+
+* page/Settings.cpp:
+(WebCore::Settings::setUseAVFoundationAudioCapture):
+* platform/mediastream/RealtimeMediaSourceCenter.cpp:
+(WebCore::RealtimeMediaSourceCenter::audioFactory):
+(WebCore::RealtimeMediaSourceCenter::videoFactory):
+(WebCore::RealtimeMediaSourceCenter::audioCaptureDeviceManager):
+(WebCore::RealtimeMediaSourceCenter::videoCaptureDeviceManager):
+* platform/mediastream/RealtimeMediaSourceCenter.h:
+(WebCore::RealtimeMediaSourceCenter::audioFactory): Deleted.
+(WebCore::RealtimeMediaSourceCenter::videoFactory): Deleted.
+(WebCore::RealtimeMediaSourceCenter::audioCaptureDeviceManager): Deleted.
+(WebCore::RealtimeMediaSourceCenter::videoCaptureDeviceManager): Deleted.
+* platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
+(WebCore::RealtimeMediaSourceCenterMac::setUseAVFoundationAudioCapture):
+(WebCore::RealtimeMediaSourceCenterMac::singleton):
+(WebCore::RealtimeMediaSourceCenter::platformCenter):
+(WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory):
+(WebCore::RealtimeMediaSourceCenterMac::defaultAudioCaptureDeviceManager):
+* platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
+
 2017-05-04  Jiewen Tan  
 
 Search events should not fire synchronously for search type input elements with incremental attribute set


Modified: trunk/Source/WebCore/page/Settings.cpp 

[webkit-changes] [216445] trunk/Source/WebKit2

[aestes]

Title: [216445] trunk/Source/WebKit2








Revision 216445
Author aes...@apple.com
Date 2017-05-08 12:57:21 -0700 (Mon, 08 May 2017)


Log Message
[macOS] com.macromedia.Flash Player ESR.plugin.sb is installed outside of PlugInSandboxProfiles
https://bugs.webkit.org/show_bug.cgi?id=171774

Reviewed by Dan Bernstein.

* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216444 => 216445)

--- trunk/Source/WebKit2/ChangeLog	2017-05-08 19:50:51 UTC (rev 216444)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-08 19:57:21 UTC (rev 216445)
@@ -1,3 +1,12 @@
+2017-05-08  Andy Estes  
+
+[macOS] com.macromedia.Flash Player ESR.plugin.sb is installed outside of PlugInSandboxProfiles
+https://bugs.webkit.org/show_bug.cgi?id=171774
+
+Reviewed by Dan Bernstein.
+
+* WebKit2.xcodeproj/project.pbxproj:
+
 2017-05-08  Youenn Fablet  
 
 Clean UserMediaCaptureManager::capabilities return value


Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (216444 => 216445)

--- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2017-05-08 19:50:51 UTC (rev 216444)
+++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj	2017-05-08 19:57:21 UTC (rev 216445)
@@ -1203,7 +1203,6 @@
 		75A8D2C9187CCFAF00C39C9E /* WKWebsiteDataStore.mm in Sources */ = {isa = PBXBuildFile; fileRef = 75A8D2C5187CCF9F00C39C9E /* WKWebsiteDataStore.mm */; };
 		75A8D2D6187D1C0E00C39C9E /* WKWebsiteDataStoreInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 75A8D2D4187D1C0100C39C9E /* WKWebsiteDataStoreInternal.h */; };
 		762B748D120BC75C00819339 /* WKPreferencesRefPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = 762B7484120BBA2D00819339 /* WKPreferencesRefPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		7A5E394A1D5BD8BE00B4B7CE /* com.macromedia.Flash Player ESR.plugin.sb in Resources */ = {isa = PBXBuildFile; fileRef = 7A5E39491D5BD8A700B4B7CE /* com.macromedia.Flash Player ESR.plugin.sb */; };
 		7A772C8D1DDD4A25000F34F1 /* com.apple.WebKit.plugin-common.sb in Copy Plug-in Sandbox Profiles */ = {isa = PBXBuildFile; fileRef = 7A1506721DD56298001F4B58 /* com.apple.WebKit.plugin-common.sb */; };
 		7A791EFA1C7CFCF100C4C52B /* WebResourceLoadStatisticsStoreMessageReceiver.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 7A791EF91C7CFB3700C4C52B /* WebResourceLoadStatisticsStoreMessageReceiver.cpp */; };
 		7A791EFB1C7CFD0100C4C52B /* WebResourceLoadStatisticsStoreMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = 7A791EF81C7CFB1000C4C52B /* WebResourceLoadStatisticsStoreMessages.h */; };
@@ -1429,6 +1428,7 @@
 		9F54F8951648AE0F007DF81A /* PluginProcessManagerMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 9F54F8941648AE0E007DF81A /* PluginProcessManagerMac.mm */; };
 		9FB5F394169E6A80002C25BF /* WKContextPrivateMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 9FB5F392169E6A80002C25BF /* WKContextPrivateMac.mm */; };
 		9FB5F395169E6A80002C25BF /* WKContextPrivateMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 9FB5F393169E6A80002C25BF /* WKContextPrivateMac.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		A102A7081EC0EEE900D81D82 /* com.macromedia.Flash Player ESR.plugin.sb in Copy Plug-in Sandbox Profiles */ = {isa = PBXBuildFile; fileRef = 7A5E39491D5BD8A700B4B7CE /* com.macromedia.Flash Player ESR.plugin.sb */; };
 		A115DC71191D82D700DA8072 /* _WKWebViewPrintFormatter.mm in Sources */ = {isa = PBXBuildFile; fileRef = A115DC6D191D82AB00DA8072 /* _WKWebViewPrintFormatter.mm */; };
 		A115DC72191D82DA00DA8072 /* _WKWebViewPrintFormatter.h in Headers */ = {isa = PBXBuildFile; fileRef = A115DC6E191D82AB00DA8072 /* _WKWebViewPrintFormatter.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		A118A9EE1907AD6F00F7C92B /* QuickLookDocumentData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A118A9EC1907AD6F00F7C92B /* QuickLookDocumentData.cpp */; };
@@ -2167,6 +2167,7 @@
 			dstPath = PlugInSandboxProfiles;
 			dstSubfolderSpec = 7;
 			files = (
+A102A7081EC0EEE900D81D82 /* com.macromedia.Flash Player ESR.plugin.sb in Copy Plug-in Sandbox Profiles */,
 E19BDA86193665E300B97F57 /* com.apple.appstore.CodeRedeemerNetscapePlugin.sb in Copy Plug-in Sandbox Profiles */,
 7CB16FEF1724BA23007A0A95 /* com.apple.ist.ds.appleconnect.webplugin.sb in Copy Plug-in Sandbox Profiles */,
 7CB16FF01724BA24007A0A95 /* com.apple.QuickTime Plugin.plugin.sb in Copy Plug-in Sandbox Profiles */,
@@ -9382,7 +9383,6 @@
 E115C716190F8A2500ECC516 /* com.apple.WebKit.Databases.sb in Resources */,
 E17AE2C316B9C63A001C42F1 /* com.apple.WebKit.NetworkProcess.sb in Resources */,
 E11D35AE16B63D1B006D23D7 /* com.apple.WebProcess.sb in Resources */,
-7A5E394A1D5BD8BE00B4B7CE /* com.macromedia.Flash Player ESR.plugin.sb in Resources */,
 6BE969C11E54D452008B7483 /* 

[webkit-changes] [216444] trunk/Source/WTF

[mark . lam]

Title: [216444] trunk/Source/WTF








Revision 216444
Author mark@apple.com
Date 2017-05-08 12:50:51 -0700 (Mon, 08 May 2017)


Log Message
Speculative Windows build fix after r216428.
https://bugs.webkit.org/show_bug.cgi?id=171776

Not reviewed.

* wtf/StackTrace.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/StackTrace.h




Diff

Modified: trunk/Source/WTF/ChangeLog (216443 => 216444)

--- trunk/Source/WTF/ChangeLog	2017-05-08 19:17:29 UTC (rev 216443)
+++ trunk/Source/WTF/ChangeLog	2017-05-08 19:50:51 UTC (rev 216444)
@@ -1,5 +1,14 @@
 2017-05-08  Mark Lam  
 
+Speculative Windows build fix after r216428.
+https://bugs.webkit.org/show_bug.cgi?id=171776
+
+Not reviewed.
+
+* wtf/StackTrace.h:
+
+2017-05-08  Mark Lam  
+
 Introduce ExceptionScope::assertNoException() and releaseAssertNoException().
 https://bugs.webkit.org/show_bug.cgi?id=171776
 


Modified: trunk/Source/WTF/wtf/StackTrace.h (216443 => 216444)

--- trunk/Source/WTF/wtf/StackTrace.h	2017-05-08 19:17:29 UTC (rev 216443)
+++ trunk/Source/WTF/wtf/StackTrace.h	2017-05-08 19:50:51 UTC (rev 216444)
@@ -36,7 +36,7 @@
 class StackTrace {
 WTF_MAKE_FAST_ALLOCATED;
 public:
-static StackTrace* captureStackTrace(int maxFrames, int framesToSkip = 0);
+WTF_EXPORT_PRIVATE static StackTrace* captureStackTrace(int maxFrames, int framesToSkip = 0);
 
 // Borrowed stack trace.
 StackTrace(void** stack, int size)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216443] trunk

[jiewen_tan]

Title: [216443] trunk








Revision 216443
Author jiewen_...@apple.com
Date 2017-05-08 12:17:29 -0700 (Mon, 08 May 2017)


Log Message
Search events should not fire synchronously for search type input elements with incremental attribute set
https://bugs.webkit.org/show_bug.cgi?id=171376


Reviewed by Chris Dumez.

Source/WebCore:

For some reasons, we fire search events immediately for search type input elements with incremental
attribute set only when the length of the input equals to zero. This behaviour should be prevented
as event listeners in the middle might perform unexpectedly.

Test: fast/forms/search/search-incremental-crash.html

* html/SearchInputType.cpp:
(WebCore::SearchInputType::startSearchEventTimer):

LayoutTests:

* fast/forms/search/search-incremental-crash-expected.txt: Added.
* fast/forms/search/search-incremental-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/SearchInputType.cpp


Added Paths

trunk/LayoutTests/fast/forms/search/search-incremental-crash-expected.txt
trunk/LayoutTests/fast/forms/search/search-incremental-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216442 => 216443)

--- trunk/LayoutTests/ChangeLog	2017-05-08 18:58:09 UTC (rev 216442)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 19:17:29 UTC (rev 216443)
@@ -1,3 +1,14 @@
+2017-05-04  Jiewen Tan  
+
+Search events should not fire synchronously for search type input elements with incremental attribute set
+https://bugs.webkit.org/show_bug.cgi?id=171376
+
+
+Reviewed by Chris Dumez.
+
+* fast/forms/search/search-incremental-crash-expected.txt: Added.
+* fast/forms/search/search-incremental-crash.html: Added.
+
 2017-05-08  Zalan Bujtas  
 
 Text overlaps on http://www.duden.de/rechtschreibung/Acre


Added: trunk/LayoutTests/fast/forms/search/search-incremental-crash-expected.txt (0 => 216443)

--- trunk/LayoutTests/fast/forms/search/search-incremental-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/search/search-incremental-crash-expected.txt	2017-05-08 19:17:29 UTC (rev 216443)
@@ -0,0 +1 @@
+ Test passes if WebKit doesn't crash.


Added: trunk/LayoutTests/fast/forms/search/search-incremental-crash.html (0 => 216443)

--- trunk/LayoutTests/fast/forms/search/search-incremental-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/search/search-incremental-crash.html	2017-05-08 19:17:29 UTC (rev 216443)
@@ -0,0 +1,28 @@
+
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var runcount = 0;
+function go() {
+runcount++;
+if (runcount > 2)
+return;
+
+i.type = "foo";
+i.select();
+i.type = "search";
+
+document._onsearch_ = document.body.onload;
+
+document.execCommand("insertHTML", false, "");
+}
+
+
+
+
+Test passes if WebKit doesn't crash.
+
+
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (216442 => 216443)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 18:58:09 UTC (rev 216442)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 19:17:29 UTC (rev 216443)
@@ -1,3 +1,20 @@
+2017-05-04  Jiewen Tan  
+
+Search events should not fire synchronously for search type input elements with incremental attribute set
+https://bugs.webkit.org/show_bug.cgi?id=171376
+
+
+Reviewed by Chris Dumez.
+
+For some reasons, we fire search events immediately for search type input elements with incremental
+attribute set only when the length of the input equals to zero. This behaviour should be prevented
+as event listeners in the middle might perform unexpectedly.
+
+Test: fast/forms/search/search-incremental-crash.html
+
+* html/SearchInputType.cpp:
+(WebCore::SearchInputType::startSearchEventTimer):
+
 2017-05-08  Zalan Bujtas  
 
 Text overlaps on http://www.duden.de/rechtschreibung/Acre


Modified: trunk/Source/WebCore/html/SearchInputType.cpp (216442 => 216443)

--- trunk/Source/WebCore/html/SearchInputType.cpp	2017-05-08 18:58:09 UTC (rev 216442)
+++ trunk/Source/WebCore/html/SearchInputType.cpp	2017-05-08 19:17:29 UTC (rev 216443)
@@ -161,8 +161,7 @@
 unsigned length = element().innerTextValue().length();
 
 if (!length) {
-stopSearchEventTimer();
-element().onSearch();
+m_searchEventTimer.startOneShot(0_ms);
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216442] trunk/Source/WebKit2

[commit-queue]

Title: [216442] trunk/Source/WebKit2








Revision 216442
Author commit-qu...@webkit.org
Date 2017-05-08 11:58:09 -0700 (Mon, 08 May 2017)


Log Message
Clean UserMediaCaptureManager::capabilities return value
https://bugs.webkit.org/show_bug.cgi?id=171808

Patch by Youenn Fablet  on 2017-05-08
Reviewed by Eric Carlson.

* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::capabilities):
* WebProcess/cocoa/UserMediaCaptureManager.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.cpp
trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216441 => 216442)

--- trunk/Source/WebKit2/ChangeLog	2017-05-08 18:40:46 UTC (rev 216441)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-08 18:58:09 UTC (rev 216442)
@@ -1,3 +1,14 @@
+2017-05-08  Youenn Fablet  
+
+Clean UserMediaCaptureManager::capabilities return value
+https://bugs.webkit.org/show_bug.cgi?id=171808
+
+Reviewed by Eric Carlson.
+
+* WebProcess/cocoa/UserMediaCaptureManager.cpp:
+(WebKit::UserMediaCaptureManager::capabilities):
+* WebProcess/cocoa/UserMediaCaptureManager.h:
+
 2017-05-08  Chris Dumez  
 
 Move 'style' from Element to HTMLElement / SVGElement and make it settable


Modified: trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.cpp (216441 => 216442)

--- trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.cpp	2017-05-08 18:40:46 UTC (rev 216441)
+++ trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.cpp	2017-05-08 18:58:09 UTC (rev 216442)
@@ -257,11 +257,11 @@
 m_process.send(Messages::UserMediaCaptureManagerProxy::StopProducingData(id), 0);
 }
 
-WebCore::RealtimeMediaSourceCapabilities&& UserMediaCaptureManager::capabilities(uint64_t id)
+WebCore::RealtimeMediaSourceCapabilities UserMediaCaptureManager::capabilities(uint64_t id)
 {
 WebCore::RealtimeMediaSourceCapabilities capabilities;
 m_process.sendSync(Messages::UserMediaCaptureManagerProxy::Capabilities(id), Messages::UserMediaCaptureManagerProxy::Capabilities::Reply(capabilities), 0);
-return WTFMove(capabilities);
+return capabilities;
 }
 
 void UserMediaCaptureManager::setMuted(uint64_t id, bool muted)


Modified: trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.h (216441 => 216442)

--- trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.h	2017-05-08 18:40:46 UTC (rev 216441)
+++ trunk/Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.h	2017-05-08 18:58:09 UTC (rev 216442)
@@ -72,7 +72,7 @@
 
 void startProducingData(uint64_t);
 void stopProducingData(uint64_t);
-WebCore::RealtimeMediaSourceCapabilities&& capabilities(uint64_t);
+WebCore::RealtimeMediaSourceCapabilities capabilities(uint64_t);
 void setMuted(uint64_t, bool);
 void setEnabled(uint64_t, bool);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216441] branches/safari-604.1.21-branch/

[matthew_hanson]

Title: [216441] branches/safari-604.1.21-branch/








Revision 216441
Author matthew_han...@apple.com
Date 2017-05-08 11:40:46 -0700 (Mon, 08 May 2017)


Log Message
New Branch.

Added Paths

branches/safari-604.1.21-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216440] trunk

[zalan]

Title: [216440] trunk








Revision 216440
Author za...@apple.com
Date 2017-05-08 11:38:20 -0700 (Mon, 08 May 2017)


Log Message
Text overlaps on http://www.duden.de/rechtschreibung/Acre
https://bugs.webkit.org/show_bug.cgi?id=171796


Reviewed by Simon Fraser.

Source/WebCore:

Simple line layout pre-measures space using the primary font,
even if the space glyph requires a fallback font (and even if the string does not have a space in it at all).
When this width gets cached (see WidthCache) we might end up using it later during normal line layout and
it could produce incorrect layout.
This patch removes the space width caching from Simple line layout, since Font already caches it.

Test: fast/text/simple-line-layout-fallback-space-glyph.html

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::createLineRuns):
* rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):
* rendering/SimpleLineLayoutTextFragmentIterator.h:

LayoutTests:

* fast/text/simple-line-layout-fallback-space-glyph-expected.html: Added.
* fast/text/simple-line-layout-fallback-space-glyph.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp
trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp
trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h


Added Paths

trunk/LayoutTests/fast/text/simple-line-layout-fallback-space-glyph-expected.html
trunk/LayoutTests/fast/text/simple-line-layout-fallback-space-glyph.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216439 => 216440)

--- trunk/LayoutTests/ChangeLog	2017-05-08 18:28:23 UTC (rev 216439)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 18:38:20 UTC (rev 216440)
@@ -1,3 +1,14 @@
+2017-05-08  Zalan Bujtas  
+
+Text overlaps on http://www.duden.de/rechtschreibung/Acre
+https://bugs.webkit.org/show_bug.cgi?id=171796
+
+
+Reviewed by Simon Fraser.
+
+* fast/text/simple-line-layout-fallback-space-glyph-expected.html: Added.
+* fast/text/simple-line-layout-fallback-space-glyph.html: Added.
+
 2017-05-08  Michael Catanzaro  
 
 Unreviewed, rolling out r216419.


Added: trunk/LayoutTests/fast/text/simple-line-layout-fallback-space-glyph-expected.html (0 => 216440)

--- trunk/LayoutTests/fast/text/simple-line-layout-fallback-space-glyph-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/simple-line-layout-fallback-space-glyph-expected.html	2017-05-08 18:38:20 UTC (rev 216440)
@@ -0,0 +1,27 @@
+
+
+
+This tests simple line layout when space glyph needs a fallback font.
+
+
+@font-face{
+  font-family: Icons;
+  src: url("data:application/font-woff;base64,d09GRgABACMIAAsANjgAAQBHU1VCAAABCDsAAABUIIwleU9TLzIAAAFEQwAAAFZ31mFeY21hcYgAAAHRAAAEtCqjz5ZnbHlmAAADXAAAG3wAACmcLoh/CWhlYWQAAB7YMwAAADYMlCVQaGhlYQAAHwwgJAi8A41obXR4AAAfLH0AAADYtO7/6mxvY2EAAB+sbgAAAG7wjuYKbWF4cAAAIBwfIAFQASNuYW1lAAAgPXwAAAKptA53+HBvc3QAACG4AAABTwAAAg6HyA5QeJxjYGRgYOBiMGCwY2DKSSzJY+BzcfMJYZBiYGGAAJA8MpsxJzM9kYEDxgPKsYBpDiBmg4gCAClZBUgAeJxjYGSOYpzAwMrAwFTFtIeBgaEHQjM+YDBkZAKKMrAyM2AFAWmuKQwOipb//zMH/c9iiGI+wSgMFGYEyQEA5SEMAwB4nN3Uu24TQRTG8f849hKbxCQshPtlDLtDuJpLQJT0kXiDVLwHr5CQKhQBS0ikQEmXJm0UISEKBEKiSe02wkSCJnxzDmWK1Ozo5293NZZn95wx0ALG5LY0oTFF0Bmho7vB7o/RsftNdnVdc1VnRXwal+MgblUb1Wa1Uxd1v15J7dRNZeql+bQwWw7DwQFo3mJc1bx1m9c6ZB553hGOoN+utZ4HGo9sPD5k5HkNrbmpJys4xjhtrf+4xgSTdDVOMMU0Jyk5xWlmOMNZzulrxZFW8X8fE/mj8e7f1ZNcP5d7IS46vV/iksu9E1+53D9x2eW+iqtOdSC+caoI8a1TbYgDpyoRt1zut2rdqW5UG87ON11eabXjVFfqllN9qQtn532nqlOvONWf1HbqBFLXqSdIpSNnz6lPSPNOHUNacO
 odZkunLmKIUz8xDE6dFb6+MHCesDdn4ALh53MDF5XvDVwijGoDl5XPDFxRvjRoB4bRwOiFKT8Y6Cm3DVxTfjRwXfnJ6IUpv5m8l8Pou9EDKX8YuKHcNXo45Z6Bm8p9A7eUf0z+jwi/2gbuKDsG7ionDdxTJgN95ZqB+8ovBu3rsP/awEPlZ4N2evg9Y2DuLylUmKB4nKV6CZhcxX3nq6p39+t3dL+ju6en72M0M+rp6VNz9Uij0Wh0DDpGCB0IkNAxGilCkpEQljgssTYYRxA5ISB/MRhDCMbExtiOl29jEsdOHLK7Bu9GIRHr7Gfn4xNfNsZrfASYfrP/et0zyAR/WZyZ7npV/6r6V72q//H7VzWDGWb+bbSf+JgYU2CYrGXyQjKVy1crtXq5ml7IlWzHgITQaiCOoEptCJVstM/U3R9pJrLVdNp7XII0rdmTtvqAakOimXtXexU0vdR62Kr7oo1PHPKyh6AZwzCIockNeBNjwdPUkGNDwqfyKFepo1opjmx0A3/5Ms9HOZV353gesZzORnmcErjXLvMq0DnEQR1iaRtmgSfehv4n5Zn12PUhgSYtng6y8TaP32uXPV6Up8fgTwUOSgujUY7uHNee4/qFOQqoxWoU5Wni8UPrOfdd6LLYW2dhUmhQoGTgqfKXX2tVU4ZXzfH193jmUYtdHNW994Y5QmOdpS9NpwMc6GTRn7SYei+9OJ7Hzksq3jx7Ft78qoX0Vtf5QCqs8fvWl/K95M28RWyt9GuvcZuF9y25zsI+CB9IXZjTNnzz1XN6/25UP8wefSDxpDf85cuttQYqB7P+ntCecptIF59fXKfUwjp98I46H2KfL9HR1PfN4NdsvvjBIrGwTieuntP7JaL6YeTkg4XnqPD+/YSpfI8SYfc8YvvNWns3/xzZCTYiw6ymc7JURC0DbNOiJeA1FEP1Uq0O/7QcBEvRg1K52ijKpVO8AP+0WK82EDUmMGObrMv80yObHh6
 

[webkit-changes] [216439] trunk/Source/WebCore

[cdumez]

Title: [216439] trunk/Source/WebCore








Revision 216439
Author cdu...@apple.com
Date 2017-05-08 11:28:23 -0700 (Mon, 08 May 2017)


Log Message
Refactor ImageInputType::width() / height() for clarity
https://bugs.webkit.org/show_bug.cgi?id=171810

Reviewed by Zalan Bujtas.

Refactor ImageInputType::width() / height() for clarity.

* html/ImageInputType.cpp:
(WebCore::ImageInputType::height):
(WebCore::ImageInputType::width):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/ImageInputType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216438 => 216439)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 18:19:31 UTC (rev 216438)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 18:28:23 UTC (rev 216439)
@@ -1,3 +1,16 @@
+2017-05-08  Chris Dumez  
+
+Refactor ImageInputType::width() / height() for clarity
+https://bugs.webkit.org/show_bug.cgi?id=171810
+
+Reviewed by Zalan Bujtas.
+
+Refactor ImageInputType::width() / height() for clarity.
+
+* html/ImageInputType.cpp:
+(WebCore::ImageInputType::height):
+(WebCore::ImageInputType::width):
+
 2017-05-08  Zalan Bujtas  
 
 Bail out of simple line layout when hyphen needs a fallback font.


Modified: trunk/Source/WebCore/html/ImageInputType.cpp (216438 => 216439)

--- trunk/Source/WebCore/html/ImageInputType.cpp	2017-05-08 18:19:31 UTC (rev 216438)
+++ trunk/Source/WebCore/html/ImageInputType.cpp	2017-05-08 18:28:23 UTC (rev 216439)
@@ -179,19 +179,19 @@
 
 element->document().updateLayout();
 
-if (!element->renderer()) {
-// Check the attribute first for an explicit pixel value.
-if (auto optionalHeight = parseHTMLNonNegativeInteger(element->attributeWithoutSynchronization(heightAttr)))
-return optionalHeight.value();
+if (auto* renderer = element->renderer())
+return adjustForAbsoluteZoom(downcast(*renderer).contentHeight(), *renderer);
 
-// If the image is available, use its height.
-HTMLImageLoader* imageLoader = element->imageLoader();
-if (imageLoader && imageLoader->image())
-return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).height().toUnsigned();
-}
+// Check the attribute first for an explicit pixel value.
+if (auto optionalHeight = parseHTMLNonNegativeInteger(element->attributeWithoutSynchronization(heightAttr)))
+return optionalHeight.value();
 
-RenderBox* box = element->renderBox();
-return box ? adjustForAbsoluteZoom(box->contentHeight(), *box) : 0;
+// If the image is available, use its height.
+auto* imageLoader = element->imageLoader();
+if (imageLoader && imageLoader->image())
+return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).height().toUnsigned();
+
+return 0;
 }
 
 unsigned ImageInputType::width() const
@@ -200,19 +200,19 @@
 
 element->document().updateLayout();
 
-if (!element->renderer()) {
-// Check the attribute first for an explicit pixel value.
-if (auto optionalWidth = parseHTMLNonNegativeInteger(element->attributeWithoutSynchronization(widthAttr)))
-return optionalWidth.value();
+if (auto* renderer = element->renderer())
+return adjustForAbsoluteZoom(downcast(*renderer).contentWidth(), *renderer);
 
-// If the image is available, use its width.
-HTMLImageLoader* imageLoader = element->imageLoader();
-if (imageLoader && imageLoader->image())
-return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).width().toUnsigned();
-}
+// Check the attribute first for an explicit pixel value.
+if (auto optionalWidth = parseHTMLNonNegativeInteger(element->attributeWithoutSynchronization(widthAttr)))
+return optionalWidth.value();
 
-RenderBox* box = element->renderBox();
-return box ? adjustForAbsoluteZoom(box->contentWidth(), *box) : 0;
+// If the image is available, use its width.
+auto* imageLoader = element->imageLoader();
+if (imageLoader && imageLoader->image())
+return imageLoader->image()->imageSizeForRenderer(element->renderer(), 1).width().toUnsigned();
+
+return 0;
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216438] trunk/Source/WebCore

[zalan]

Title: [216438] trunk/Source/WebCore








Revision 216438
Author za...@apple.com
Date 2017-05-08 11:19:31 -0700 (Mon, 08 May 2017)


Log Message
Bail out of simple line layout when hyphen needs a fallback font.
https://bugs.webkit.org/show_bug.cgi?id=171811

Reviewed by Antti Koivisto.

With hyphen: auto is set, we don't know if the hypen string is going to be used, until
after we started laying out the content and figured that the text overflows the line.
However it's too late to bail out of simple line layout at this point, so let's just
pre-check if the hyphen string needs a fallback font.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForStyle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216437 => 216438)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 18:13:52 UTC (rev 216437)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 18:19:31 UTC (rev 216438)
@@ -1,3 +1,18 @@
+2017-05-08  Zalan Bujtas  
+
+Bail out of simple line layout when hyphen needs a fallback font.
+https://bugs.webkit.org/show_bug.cgi?id=171811
+
+Reviewed by Antti Koivisto.
+
+With hyphen: auto is set, we don't know if the hypen string is going to be used, until
+after we started laying out the content and figured that the text overflows the line.
+However it's too late to bail out of simple line layout at this point, so let's just
+pre-check if the hyphen string needs a fallback font.
+
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::canUseForStyle):
+
 2017-05-08  Youenn Fablet  
 
 TURNS gathering is not working properly


Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (216437 => 216438)

--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2017-05-08 18:13:52 UTC (rev 216437)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2017-05-08 18:19:31 UTC (rev 216438)
@@ -241,6 +241,11 @@
 if (style.trailingWord() != TrailingWord::Auto)
 SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonAutoTrailingWord, reasons, includeReasons);
 #endif
+if (style.hyphens() == HyphensAuto) {
+auto textReasons = canUseForText(style.hyphenString(), style.fontCascade(), std::nullopt, false, includeReasons);
+if (textReasons != NoReason)
+SET_REASON_AND_RETURN_IF_NEEDED(textReasons, reasons, includeReasons);
+}
 return reasons;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216436] trunk/Source

[commit-queue]

Title: [216436] trunk/Source








Revision 216436
Author commit-qu...@webkit.org
Date 2017-05-08 10:39:37 -0700 (Mon, 08 May 2017)


Log Message
TURNS gathering is not working properly
https://bugs.webkit.org/show_bug.cgi?id=171747

Patch by Youenn Fablet  on 2017-05-08
Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

* Source/webrtc/base/openssladapter.cc: Adding support for SNI in case of TLS ice candidate gathering.

Source/WebCore:

Covered by manual tests.

* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::configurationFromMediaEndpointConfiguration): Reveting TURNS ice server skipping.

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/openssladapter.cc
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (216435 => 216436)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-05-08 17:39:20 UTC (rev 216435)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2017-05-08 17:39:37 UTC (rev 216436)
@@ -1,3 +1,12 @@
+2017-05-08  Youenn Fablet  
+
+TURNS gathering is not working properly
+https://bugs.webkit.org/show_bug.cgi?id=171747
+
+Reviewed by Eric Carlson.
+
+* Source/webrtc/base/openssladapter.cc: Adding support for SNI in case of TLS ice candidate gathering.
+
 2017-04-29  Dan Bernstein  
 
 [Xcode] libwebrtc SRCROOT includes examples


Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/openssladapter.cc (216435 => 216436)

--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/openssladapter.cc	2017-05-08 17:39:20 UTC (rev 216435)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/base/openssladapter.cc	2017-05-08 17:39:37 UTC (rev 216436)
@@ -332,6 +332,11 @@
   }
 
   SSL_set_app_data(ssl_, this);
+  // WEBKIT Changes - Start
+  if (ssl_host_name_.length()) {
+SSL_set_tlsext_host_name(ssl_, ssl_host_name_.c_str());
+  }
+  // WEBKIT Changes - End
 
   SSL_set_bio(ssl_, bio, bio);
   SSL_set_mode(ssl_, SSL_MODE_ENABLE_PARTIAL_WRITE |


Modified: trunk/Source/WebCore/ChangeLog (216435 => 216436)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 17:39:20 UTC (rev 216435)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 17:39:37 UTC (rev 216436)
@@ -1,3 +1,15 @@
+2017-05-08  Youenn Fablet  
+
+TURNS gathering is not working properly
+https://bugs.webkit.org/show_bug.cgi?id=171747
+
+Reviewed by Eric Carlson.
+
+Covered by manual tests.
+
+* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
+(WebCore::configurationFromMediaEndpointConfiguration): Reveting TURNS ice server skipping.
+
 2017-05-08  Michael Catanzaro  
 
 Unreviewed, rolling out r216419.


Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp (216435 => 216436)

--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp	2017-05-08 17:39:20 UTC (rev 216435)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp	2017-05-08 17:39:37 UTC (rev 216436)
@@ -88,14 +88,9 @@
 webrtc::PeerConnectionInterface::IceServer iceServer;
 iceServer.username = server.username.utf8().data();
 iceServer.password = server.credential.utf8().data();
-for (auto& url : server.urls) {
-// FIXME: If TURNS is failing, the whole ICE candidate gathering is failing.
-// We should fix that and reactivate TURNS gathering.
-if (!url.protocolIs("turns"))
-iceServer.urls.push_back({ url.string().utf8().data() });
-}
-if (iceServer.urls.size())
-rtcConfiguration.servers.push_back(WTFMove(iceServer));
+for (auto& url : server.urls)
+iceServer.urls.push_back({ url.string().utf8().data() });
+rtcConfiguration.servers.push_back(WTFMove(iceServer));
 }
 
 rtcConfiguration.ice_candidate_pool_size = configuration.iceCandidatePoolSize;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216435] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216435] releases/WebKitGTK/webkit-2.16








Revision 216435
Author carlo...@webkit.org
Date 2017-05-08 10:39:20 -0700 (Mon, 08 May 2017)


Log Message
Merge r216431 - ComposedTreeIterator does not traverse all slotted children if the traversal root is a slot element.
https://bugs.webkit.org/show_bug.cgi?id=171375


Reviewed by Zalan Bujtas.

Source/WebCore:

We were hitting an assert when using details element with a flow thread. The root cause for this turned
out to be that we only traversed the first slotted child if the traversal root was a slot element.

Test: fast/html/details-flow-thread.html

* dom/ComposedTreeIterator.cpp:
(WebCore::ComposedTreeIterator::traverseNextLeavingContext):

Try to traverse to the next slotted child before testing if we at the end of the current context.

LayoutTests:

* fast/html/details-flow-thread-expected.txt: Added.
* fast/html/details-flow-thread.html: Added.
* fast/shadow-dom/composed-tree-slots-expected.txt:
* fast/shadow-dom/composed-tree-slots.html:

Expand the test so it also prints out slot subtrees using slots as traversal roots.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/shadow-dom/composed-tree-slots-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/shadow-dom/composed-tree-slots.html
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/dom/ComposedTreeIterator.cpp


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/fast/html/details-flow-thread-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/html/details-flow-thread.html




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216434 => 216435)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 17:37:38 UTC (rev 216434)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 17:39:20 UTC (rev 216435)
@@ -1,3 +1,18 @@
+2017-05-08  Antti Koivisto  
+
+ComposedTreeIterator does not traverse all slotted children if the traversal root is a slot element.
+https://bugs.webkit.org/show_bug.cgi?id=171375
+
+
+Reviewed by Zalan Bujtas.
+
+* fast/html/details-flow-thread-expected.txt: Added.
+* fast/html/details-flow-thread.html: Added.
+* fast/shadow-dom/composed-tree-slots-expected.txt:
+* fast/shadow-dom/composed-tree-slots.html:
+
+Expand the test so it also prints out slot subtrees using slots as traversal roots.
+
 2017-05-05  Carlos Garcia Campos  
 
 Unreviewed GTK+ gardening. Rebaseline fast/repaint/mutate-non-visible.html.


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/html/details-flow-thread-expected.txt (0 => 216435)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/html/details-flow-thread-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/html/details-flow-thread-expected.txt	2017-05-08 17:39:20 UTC (rev 216435)
@@ -0,0 +1 @@
+This test passes if it doesn't assert


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/html/details-flow-thread.html (0 => 216435)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/html/details-flow-thread.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/html/details-flow-thread.html	2017-05-08 17:39:20 UTC (rev 216435)
@@ -0,0 +1,26 @@
+
+details div { -webkit-flow-into: bar; }
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function gc() {
+if (window.GCController)
+return GCController.collect();
+var a;
+for (var i=0; i<100; i++)
+a = new Uint8Array(1024*1024);
+}
+
+function go() {
+details.offsetLeft;
+details.open = false;
+div.innerHTML = "This test passes if it doesn't assert";
+gc();
+}
+
+
+
+
+foo


Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/shadow-dom/composed-tree-slots-expected.txt (216434 => 216435)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/shadow-dom/composed-tree-slots-expected.txt	2017-05-08 17:37:38 UTC (rev 216434)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/shadow-dom/composed-tree-slots-expected.txt	2017-05-08 17:39:20 UTC (rev 216435)
@@ -2,18 +2,27 @@
 Test 1
   div (shadow root)
 slot
+Slot trees:
 
+
 Test 2
   div (shadow root)
 slot
   #text
+Slot trees:
+  #text
 
+
 Test 3
   div (shadow root)
 slot
   #text
   div
+Slot trees:
+  #text
+  div
 
+
 Test 4
   div (shadow root)
 slot
@@ -21,13 +30,21 @@
 #text
   div
 #text
+Slot trees:
+  div
+#text
+  div
+#text
 
+
 Test 5
   div (shadow root)
 div
   slot
 #text
+Slot trees:
 
+
 Test 6
   div (shadow root)
 div
@@ -34,7 +51,10 @@
   slot
 #text
 #text
+Slot trees:
+  #text
 
+
 Test 7
   div (shadow root)
 div
@@ -42,7 +62,11 @@
 #text
 div
 #text
+Slot 

[webkit-changes] [216434] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216434] releases/WebKitGTK/webkit-2.16








Revision 216434
Author carlo...@webkit.org
Date 2017-05-08 10:37:38 -0700 (Mon, 08 May 2017)


Log Message
Merge r215614 - [cmake] WTF target should not have wtf and subdirectries in public interface
https://bugs.webkit.org/show_bug.cgi?id=171115

Reviewed by Michael Catanzaro.

In r209665 WEBCORE_FRAMEWORK macro started to export INCLUDE_DIRECTORIES of
targets as their public interface, so that linked targets can use them
implicitly without copying directory lists around. This matches existing
practice for all targets except WTF, headers from which are always included
with full path starting from "r209665 it became possible to include headers from wtf or its
subdirectories in CMake builds without using "

Modified Paths

releases/WebKitGTK/webkit-2.16/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WTF/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WTF/wtf/CMakeLists.txt
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/cmake/WebKitMacros.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.16/ChangeLog (216433 => 216434)

--- releases/WebKitGTK/webkit-2.16/ChangeLog	2017-05-08 17:36:42 UTC (rev 216433)
+++ releases/WebKitGTK/webkit-2.16/ChangeLog	2017-05-08 17:37:38 UTC (rev 216434)
@@ -1,3 +1,23 @@
+2017-04-21  Konstantin Tokarev  
+
+[cmake] WTF target should not have wtf and subdirectries in public interface
+https://bugs.webkit.org/show_bug.cgi?id=171115
+
+Reviewed by Michael Catanzaro.
+
+In r209665 WEBCORE_FRAMEWORK macro started to export INCLUDE_DIRECTORIES of
+targets as their public interface, so that linked targets can use them
+implicitly without copying directory lists around. This matches existing
+practice for all targets except WTF, headers from which are always included
+with full path starting from " 2017-04-08  Ting-Wei Lan  
 
 Elftoolchain ar doesn't support response files


Modified: releases/WebKitGTK/webkit-2.16/Source/WTF/ChangeLog (216433 => 216434)

--- releases/WebKitGTK/webkit-2.16/Source/WTF/ChangeLog	2017-05-08 17:36:42 UTC (rev 216433)
+++ releases/WebKitGTK/webkit-2.16/Source/WTF/ChangeLog	2017-05-08 17:37:38 UTC (rev 216434)
@@ -1,3 +1,23 @@
+2017-04-21  Konstantin Tokarev  
+
+[cmake] WTF target should not have wtf and subdirectries in public interface
+https://bugs.webkit.org/show_bug.cgi?id=171115
+
+Reviewed by Michael Catanzaro.
+
+In r209665 WEBCORE_FRAMEWORK macro started to export INCLUDE_DIRECTORIES of
+targets as their public interface, so that linked targets can use them
+implicitly without copying directory lists around. This matches existing
+practice for all targets except WTF, headers from which are always included
+with full path starting from " 2017-04-10  Thorsten Glaser  
 
 [GTK] Fix x32 build


Modified: releases/WebKitGTK/webkit-2.16/Source/WTF/wtf/CMakeLists.txt (216433 => 216434)

--- releases/WebKitGTK/webkit-2.16/Source/WTF/wtf/CMakeLists.txt	2017-05-08 17:36:42 UTC (rev 216433)
+++ releases/WebKitGTK/webkit-2.16/Source/WTF/wtf/CMakeLists.txt	2017-05-08 17:37:38 UTC (rev 216434)
@@ -272,6 +272,12 @@
 set(WTF_INCLUDE_DIRECTORIES
 "${BMALLOC_DIR}"
 "${WTF_DIR}"
+"${CMAKE_BINARY_DIR}"
+"${DERIVED_SOURCES_DIR}"
+"${THIRDPARTY_DIR}"
+)
+
+set(WTF_PRIVATE_INCLUDE_DIRECTORIES
 "${WTF_DIR}/wtf"
 "${WTF_DIR}/wtf/dtoa"
 "${WTF_DIR}/wtf/persistence"
@@ -279,9 +285,6 @@
 "${WTF_DIR}/wtf/text/icu"
 "${WTF_DIR}/wtf/threads"
 "${WTF_DIR}/wtf/unicode"
-"${THIRDPARTY_DIR}"
-"${CMAKE_BINARY_DIR}"
-"${DERIVED_SOURCES_DIR}"
 )
 
 set(WTF_LIBRARIES


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216433 => 216434)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 17:36:42 UTC (rev 216433)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 17:37:38 UTC (rev 216434)
@@ -1,3 +1,23 @@
+2017-04-21  Konstantin Tokarev  
+
+[cmake] WTF target should not have wtf and subdirectries in public interface
+https://bugs.webkit.org/show_bug.cgi?id=171115
+
+Reviewed by Michael Catanzaro.
+
+In r209665 WEBCORE_FRAMEWORK macro started to export INCLUDE_DIRECTORIES of
+targets as their public interface, so that linked targets can use them
+implicitly without copying directory lists around. This matches existing
+practice for all targets except WTF, headers from which are always included
+with full path starting from " 2017-05-05  Zalan Bujtas  
 
 Renderers being destroyed should not be added to AX's deferred list.


Modified: releases/WebKitGTK/webkit-2.16/Source/cmake/WebKitMacros.cmake (216433 => 216434)

--- 

[webkit-changes] [216432] trunk/Source/WebCore

[commit-queue]

Title: [216432] trunk/Source/WebCore








Revision 216432
Author commit-qu...@webkit.org
Date 2017-05-08 10:31:54 -0700 (Mon, 08 May 2017)


Log Message
CoreAudioCaptureSource should not modify its shared unit if already started/stopped
https://bugs.webkit.org/show_bug.cgi?id=171804

Patch by Youenn Fablet  on 2017-05-08
Reviewed by Jer Noble.

Manual testing only since CoreAudioSharedUnit is not mocked.

* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::startProducingData): Exit early if source is already started.
(WebCore::CoreAudioCaptureSource::stopProducingData): Exit early if source is already stopped.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216431 => 216432)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 17:20:54 UTC (rev 216431)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 17:31:54 UTC (rev 216432)
@@ -1,3 +1,16 @@
+2017-05-08  Youenn Fablet  
+
+CoreAudioCaptureSource should not modify its shared unit if already started/stopped
+https://bugs.webkit.org/show_bug.cgi?id=171804
+
+Reviewed by Jer Noble.
+
+Manual testing only since CoreAudioSharedUnit is not mocked.
+
+* platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+(WebCore::CoreAudioCaptureSource::startProducingData): Exit early if source is already started.
+(WebCore::CoreAudioCaptureSource::stopProducingData): Exit early if source is already stopped.
+
 2017-05-08  Antti Koivisto  
 
 ComposedTreeIterator does not traverse all slotted children if the traversal root is a slot element.


Modified: trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp (216431 => 216432)

--- trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2017-05-08 17:20:54 UTC (rev 216431)
+++ trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp	2017-05-08 17:31:54 UTC (rev 216432)
@@ -622,6 +622,9 @@
 
 void CoreAudioCaptureSource::startProducingData()
 {
+if (m_isProducingData)
+return;
+
 #if PLATFORM(IOS)
 coreAudioCaptureSourceFactory().setActiveSource(*this);
 #endif
@@ -640,6 +643,9 @@
 
 void CoreAudioCaptureSource::stopProducingData()
 {
+if (!m_isProducingData)
+return;
+
 CoreAudioSharedUnit::singleton().stopProducingData();
 m_isProducingData = false;
 m_muted = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216431] trunk

[antti]

Title: [216431] trunk








Revision 216431
Author an...@apple.com
Date 2017-05-08 10:20:54 -0700 (Mon, 08 May 2017)


Log Message
ComposedTreeIterator does not traverse all slotted children if the traversal root is a slot element.
https://bugs.webkit.org/show_bug.cgi?id=171375


Reviewed by Zalan Bujtas.

Source/WebCore:

We were hitting an assert when using details element with a flow thread. The root cause for this turned
out to be that we only traversed the first slotted child if the traversal root was a slot element.

Test: fast/html/details-flow-thread.html

* dom/ComposedTreeIterator.cpp:
(WebCore::ComposedTreeIterator::traverseNextLeavingContext):

Try to traverse to the next slotted child before testing if we at the end of the current context.

LayoutTests:

* fast/html/details-flow-thread-expected.txt: Added.
* fast/html/details-flow-thread.html: Added.
* fast/shadow-dom/composed-tree-slots-expected.txt:
* fast/shadow-dom/composed-tree-slots.html:

Expand the test so it also prints out slot subtrees using slots as traversal roots.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/shadow-dom/composed-tree-slots-expected.txt
trunk/LayoutTests/fast/shadow-dom/composed-tree-slots.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ComposedTreeIterator.cpp


Added Paths

trunk/LayoutTests/fast/html/details-flow-thread-expected.txt
trunk/LayoutTests/fast/html/details-flow-thread.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216430 => 216431)

--- trunk/LayoutTests/ChangeLog	2017-05-08 17:06:29 UTC (rev 216430)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 17:20:54 UTC (rev 216431)
@@ -1,3 +1,18 @@
+2017-05-08  Antti Koivisto  
+
+ComposedTreeIterator does not traverse all slotted children if the traversal root is a slot element.
+https://bugs.webkit.org/show_bug.cgi?id=171375
+
+
+Reviewed by Zalan Bujtas.
+
+* fast/html/details-flow-thread-expected.txt: Added.
+* fast/html/details-flow-thread.html: Added.
+* fast/shadow-dom/composed-tree-slots-expected.txt:
+* fast/shadow-dom/composed-tree-slots.html:
+
+Expand the test so it also prints out slot subtrees using slots as traversal roots.
+
 2017-05-08  Chris Dumez  
 
 Move 'style' from Element to HTMLElement / SVGElement and make it settable


Added: trunk/LayoutTests/fast/html/details-flow-thread-expected.txt (0 => 216431)

--- trunk/LayoutTests/fast/html/details-flow-thread-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/html/details-flow-thread-expected.txt	2017-05-08 17:20:54 UTC (rev 216431)
@@ -0,0 +1 @@
+This test passes if it doesn't assert


Added: trunk/LayoutTests/fast/html/details-flow-thread.html (0 => 216431)

--- trunk/LayoutTests/fast/html/details-flow-thread.html	(rev 0)
+++ trunk/LayoutTests/fast/html/details-flow-thread.html	2017-05-08 17:20:54 UTC (rev 216431)
@@ -0,0 +1,26 @@
+
+details div { -webkit-flow-into: bar; }
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function gc() {
+if (window.GCController)
+return GCController.collect();
+var a;
+for (var i=0; i<100; i++)
+a = new Uint8Array(1024*1024);
+}
+
+function go() {
+details.offsetLeft;
+details.open = false;
+div.innerHTML = "This test passes if it doesn't assert";
+gc();
+}
+
+
+
+
+foo


Modified: trunk/LayoutTests/fast/shadow-dom/composed-tree-slots-expected.txt (216430 => 216431)

--- trunk/LayoutTests/fast/shadow-dom/composed-tree-slots-expected.txt	2017-05-08 17:06:29 UTC (rev 216430)
+++ trunk/LayoutTests/fast/shadow-dom/composed-tree-slots-expected.txt	2017-05-08 17:20:54 UTC (rev 216431)
@@ -2,18 +2,27 @@
 Test 1
   div (shadow root)
 slot
+Slot trees:
 
+
 Test 2
   div (shadow root)
 slot
   #text
+Slot trees:
+  #text
 
+
 Test 3
   div (shadow root)
 slot
   #text
   div
+Slot trees:
+  #text
+  div
 
+
 Test 4
   div (shadow root)
 slot
@@ -21,13 +30,21 @@
 #text
   div
 #text
+Slot trees:
+  div
+#text
+  div
+#text
 
+
 Test 5
   div (shadow root)
 div
   slot
 #text
+Slot trees:
 
+
 Test 6
   div (shadow root)
 div
@@ -34,7 +51,10 @@
   slot
 #text
 #text
+Slot trees:
+  #text
 
+
 Test 7
   div (shadow root)
 div
@@ -42,7 +62,11 @@
 #text
 div
 #text
+Slot trees:
+  #text
+  div
 
+
 Test 8
   div (shadow root)
 div
@@ -52,24 +76,41 @@
 div
   #text
 #text
+Slot trees:
+  div
+#text
+  div
+#text
 
+
 Test 9
   div (shadow root)
 slot
   slot-default
 #text
+Slot trees:
+  slot-default
+#text
 
+
 Test 10
   div (shadow root)
 slot
   #text
+Slot trees:
+  #text
 
+
 Test 11
   div (shadow root)
 slot
   #text
   div
+Slot trees:
+  #text
+  div
 
+
 Test 12
   div (shadow root)
 slot
@@ -77,7 +118,13 @@
  

[webkit-changes] [216430] trunk/Source/JavaScriptCore

[jfbastien]

Title: [216430] trunk/Source/_javascript_Core








Revision 216430
Author jfbast...@apple.com
Date 2017-05-08 10:06:29 -0700 (Mon, 08 May 2017)


Log Message
WebAssembly: don't just emit extended offset adds for patch
https://bugs.webkit.org/show_bug.cgi?id=171799

Reviewed by Mark Lam.

It isn't necessary to restrict.

* b3/air/AirLowerStackArgs.cpp:
(JSC::B3::Air::lowerStackArgs):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirLowerStackArgs.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (216429 => 216430)

--- trunk/Source/_javascript_Core/ChangeLog	2017-05-08 16:58:13 UTC (rev 216429)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-05-08 17:06:29 UTC (rev 216430)
@@ -1,3 +1,15 @@
+2017-05-08  JF Bastien  
+
+WebAssembly: don't just emit extended offset adds for patch
+https://bugs.webkit.org/show_bug.cgi?id=171799
+
+Reviewed by Mark Lam.
+
+It isn't necessary to restrict.
+
+* b3/air/AirLowerStackArgs.cpp:
+(JSC::B3::Air::lowerStackArgs):
+
 2017-05-08  Mark Lam  
 
 Introduce ExceptionScope::assertNoException() and releaseAssertNoException().


Modified: trunk/Source/_javascript_Core/b3/air/AirLowerStackArgs.cpp (216429 => 216430)

--- trunk/Source/_javascript_Core/b3/air/AirLowerStackArgs.cpp	2017-05-08 16:58:13 UTC (rev 216429)
+++ trunk/Source/_javascript_Core/b3/air/AirLowerStackArgs.cpp	2017-05-08 17:06:29 UTC (rev 216430)
@@ -70,7 +70,6 @@
 
 for (unsigned instIndex = 0; instIndex < block->size(); ++instIndex) {
 Inst& inst = block->at(instIndex);
-bool isPatch = inst.kind.opcode == Patch;
 
 inst.forEachArg(
 [&] (Arg& arg, Arg::Role role, Bank, Width width) {
@@ -77,7 +76,7 @@
 auto stackAddr = [&] (Value::OffsetType offsetFromFP) -> Arg {
 int32_t offsetFromSP = offsetFromFP + code.frameSize();
 
-if (isPatch && inst.admitsExtendedOffsetAddr(arg)) {
+if (inst.admitsExtendedOffsetAddr(arg)) {
 // Stackmaps and patchpoints expect addr inputs relative to SP or FP only. We might as well
 // not even bother generating an addr with valid form for these opcodes since extended offset
 // addr is always valid.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216429] releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

[carlosgc]

Title: [216429] releases/WebKitGTK/webkit-2.16/Source/_javascript_Core








Revision 216429
Author carlo...@webkit.org
Date 2017-05-08 09:58:13 -0700 (Mon, 08 May 2017)


Log Message
Merge r214969 - Do not use BLX for immediates (ARM-32)

https://bugs.webkit.org/show_bug.cgi?id=170351

Patch by Guilherme Iscaro  on 2017-04-05
Reviewed by Mark Lam.

Currently the offline asm generator for 32-bit ARM code translates the
'call' meta-instruction (which may be found in LowLevelInterpreter.asm
and friends) to the ARM's BLX instrunction. The BLX instruction may be
used for labels (immediates) and registers and one side effect of BLX
is that it may switch the processor's instruction set.
A 'BLX register' instruction will change/remain the processor state to
ARM if the  register_bit[0] is set to 0 or change/remain to Thumb if
register_bit[0] is set to 1. However, a 'BLX label' instruction will
always switch the processor state. It switches ARM to thumb and vice-versa.
This behaviour is unwanted, since the C++ code and the offlineasm generated code
are both compiled using the same instruction set, thus a instruction
set change will likely produce a crash. In order to fix the problem the
BL instruction can be used for labels. It will branch just like BLX,
but it won't change the instruction set. It's important to note that
Darwin is not affected by this problem, thus to minimize the impact of
this change the BL instruction will only be used on non-darwin targets.

BLX reference: http://infocenter.arm.com/help/topic/com.arm.doc.dui0489i/CIHBJCDC.html?resultof=%22%62%6c%78%22%20

* offlineasm/arm.rb:

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/offlineasm/arm.rb




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog (216428 => 216429)

--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-05-08 16:56:32 UTC (rev 216428)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-05-08 16:58:13 UTC (rev 216429)
@@ -1,3 +1,32 @@
+2017-04-05  Guilherme Iscaro  
+
+Do not use BLX for immediates (ARM-32)
+
+https://bugs.webkit.org/show_bug.cgi?id=170351
+
+Reviewed by Mark Lam.
+
+Currently the offline asm generator for 32-bit ARM code translates the
+'call' meta-instruction (which may be found in LowLevelInterpreter.asm
+and friends) to the ARM's BLX instrunction. The BLX instruction may be
+used for labels (immediates) and registers and one side effect of BLX
+is that it may switch the processor's instruction set.
+A 'BLX register' instruction will change/remain the processor state to
+ARM if the  register_bit[0] is set to 0 or change/remain to Thumb if
+register_bit[0] is set to 1. However, a 'BLX label' instruction will
+always switch the processor state. It switches ARM to thumb and vice-versa.
+This behaviour is unwanted, since the C++ code and the offlineasm generated code
+are both compiled using the same instruction set, thus a instruction
+set change will likely produce a crash. In order to fix the problem the
+BL instruction can be used for labels. It will branch just like BLX,
+but it won't change the instruction set. It's important to note that
+Darwin is not affected by this problem, thus to minimize the impact of
+this change the BL instruction will only be used on non-darwin targets.
+
+BLX reference: http://infocenter.arm.com/help/topic/com.arm.doc.dui0489i/CIHBJCDC.html?resultof=%22%62%6c%78%22%20
+
+* offlineasm/arm.rb:
+
 2017-05-04  Konstantin Tokarev  
 
 Fix compilation with ICU 59.1


Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/offlineasm/arm.rb (216428 => 216429)

--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/offlineasm/arm.rb	2017-05-08 16:56:32 UTC (rev 216428)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/offlineasm/arm.rb	2017-05-08 16:58:13 UTC (rev 216429)
@@ -94,6 +94,7 @@
 ARM_EXTRA_GPRS = [SpecialRegister.new("r6"), SpecialRegister.new("r10"), SpecialRegister.new("r12")]
 ARM_EXTRA_FPRS = [SpecialRegister.new("d7")]
 ARM_SCRATCH_FPR = SpecialRegister.new("d6")
+OS_DARWIN = ((RUBY_PLATFORM =~ /darwin/i) != nil)
 
 def armMoveImmediate(value, register)
 # Currently we only handle the simple cases, and fall back to mov/movt for the complex ones.
@@ -568,7 +569,11 @@
 end
 when "call"
 if operands[0].label?
-$asm.puts "blx #{operands[0].asmLabel}"
+if OS_DARWIN
+$asm.puts "blx #{operands[0].asmLabel}"
+else
+$asm.puts "bl #{operands[0].asmLabel}"
+end
 else
 $asm.puts "blx 

[webkit-changes] [216428] trunk/Source

[mark . lam]

Title: [216428] trunk/Source








Revision 216428
Author mark@apple.com
Date 2017-05-08 09:56:32 -0700 (Mon, 08 May 2017)


Log Message
Introduce ExceptionScope::assertNoException() and releaseAssertNoException().
https://bugs.webkit.org/show_bug.cgi?id=171776

Reviewed by Keith Miller.

Source/_javascript_Core:

Instead of ASSERT(!scope.exception()), we can now do scope.assertNoException().
Ditto for RELEASE_ASSERT and scope.releaseAssertNoException().  

The advantage of using ExceptionScope::assertNoException() and
releaseAssertNoException() is that if the assertion fails, these utility
functions will print the stack trace for where the unexpected exception is
detected as well as where the unexpected exception was thrown from.  This makes
it much easier to debug the source of unhandled exceptions.

* debugger/Debugger.cpp:
(JSC::Debugger::pauseIfNeeded):
* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::eval):
(JSC::notifyDebuggerOfUnwinding):
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::debug):
* interpreter/ShadowChicken.cpp:
(JSC::ShadowChicken::functionsOnStack):
* jsc.cpp:
(GlobalObject::moduleLoaderResolve):
(GlobalObject::moduleLoaderFetch):
(functionGenerateHeapSnapshot):
(functionSamplingProfilerStackTraces):
(box):
(runWithScripts):
* runtime/AbstractModuleRecord.cpp:
(JSC::AbstractModuleRecord::finishCreation):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::tryInitializeSpeciesWatchpoint):
* runtime/Completion.cpp:
(JSC::rejectPromise):
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::sanitizedToString):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
* runtime/ExceptionScope.cpp:
(JSC::ExceptionScope::unexpectedExceptionMessage):
* runtime/ExceptionScope.h:
(JSC::ExceptionScope::assertNoException):
(JSC::ExceptionScope::releaseAssertNoException):
(JSC::ExceptionScope::unexpectedExceptionMessage):
* runtime/GenericArgumentsInlines.h:
(JSC::GenericArguments::defineOwnProperty):
* runtime/IntlCollator.cpp:
(JSC::IntlCollator::createCollator):
(JSC::IntlCollator::resolvedOptions):
* runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::resolvedOptions):
(JSC::IntlDateTimeFormat::format):
* runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::createNumberFormat):
(JSC::IntlNumberFormat::resolvedOptions):
* runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitiveByIndex):
* runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncIncludes):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncHostPromiseRejectionTracker):
* runtime/JSModuleEnvironment.cpp:
(JSC::JSModuleEnvironment::getOwnPropertySlot):
* runtime/JSModuleLoader.cpp:
(JSC::JSModuleLoader::finishCreation):
* runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::finishCreation):
* runtime/JSONObject.cpp:
(JSC::Stringifier::toJSON):
* runtime/JSObject.cpp:
(JSC::JSObject::ordinaryToPrimitive):
* runtime/JSPropertyNameEnumerator.h:
(JSC::propertyNameEnumerator):
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptors):
(JSC::objectConstructorDefineProperty):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncHasOwnProperty):
* runtime/ProgramExecutable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
* runtime/ReflectObject.cpp:
(JSC::reflectObjectDefineProperty):
* runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::nameFromCallee):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncRepeatCharacter):
* runtime/TemplateRegistry.cpp:
(JSC::TemplateRegistry::getTemplateObject):
* runtime/VM.cpp:
(JSC::VM::throwException):
* runtime/VM.h:
(JSC::VM::nativeStackTraceOfLastThrow):
(JSC::VM::clearException):
* wasm/WasmB3IRGenerator.cpp:
* wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::create):

Source/WebCore:

No new tests because there's no behavior change in functionality.  We're only
refactoring the code to use the new assertion utility function.

* Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::QuickTimePluginReplacement::installReplacement):
* bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::getJSArrayFromJSON):
(WebCore::getStringFromJSON):
(WebCore::getBooleanFromJSON):
* bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::JSCustomElementRegistry::whenDefined):
* bindings/js/JSDOMExceptionHandling.cpp:
(WebCore::propagateExceptionSlowPath):
(WebCore::throwNotSupportedError):
(WebCore::throwInvalidStateError):
(WebCore::throwSecurityError):
(WebCore::throwDOMSyntaxError):
(WebCore::throwDataCloneError):
(WebCore::throwIndexSizeError):
(WebCore::throwTypeMismatchError):
* bindings/js/JSDOMGlobalObject.cpp:

[webkit-changes] [216427] trunk/Tools

[carlosgc]

Title: [216427] trunk/Tools








Revision 216427
Author carlo...@webkit.org
Date 2017-05-08 09:55:31 -0700 (Mon, 08 May 2017)


Log Message
Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.

Glib uses now Unicode quotes in error messages.

* TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
(testWebKitConsoleMessageNetworkError):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp




Diff

Modified: trunk/Tools/ChangeLog (216426 => 216427)

--- trunk/Tools/ChangeLog	2017-05-08 16:50:46 UTC (rev 216426)
+++ trunk/Tools/ChangeLog	2017-05-08 16:55:31 UTC (rev 216427)
@@ -1,5 +1,14 @@
 2017-05-08  Carlos Garcia Campos  
 
+Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
+
+Glib uses now Unicode quotes in error messages.
+
+* TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
+(testWebKitConsoleMessageNetworkError):
+
+2017-05-08  Carlos Garcia Campos  
+
 Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/_javascript_-dialogs after r215404.
 
 Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp (216426 => 216427)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp	2017-05-08 16:50:46 UTC (rev 216426)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp	2017-05-08 16:55:31 UTC (rev 216427)
@@ -127,7 +127,7 @@
 static void testWebKitConsoleMessageNetworkError(ConsoleMessageTest* test, gconstpointer)
 {
 ConsoleMessageTest::ConsoleMessage referenceMessage = { ConsoleMessageTest::MessageSource::Network, ConsoleMessageTest::MessageLevel::Error,
-"Failed to load resource: The resource at '/org/webkit/webkit2gtk/tests/not-found.css' does not exist", 0, "resource:///org/webkit/webkit2gtk/tests/not-found.css" };
+"Failed to load resource: The resource at “/org/webkit/webkit2gtk/tests/not-found.css” does not exist", 0, "resource:///org/webkit/webkit2gtk/tests/not-found.css" };
 test->loadHtml("", "resource:///org/webkit/webkit2gtk/tests/");
 test->waitUntilConsoleMessageReceived();
 g_assert(test->m_consoleMessage == referenceMessage);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216426] trunk

[cdumez]

Title: [216426] trunk








Revision 216426
Author cdu...@apple.com
Date 2017-05-08 09:50:46 -0700 (Mon, 08 May 2017)


Log Message
Move 'style' from Element to HTMLElement / SVGElement and make it settable
https://bugs.webkit.org/show_bug.cgi?id=171795

Reviewed by Alex Christensen.

Source/WebCore:

Move 'style' from Element to HTMLElement / SVGElement and make it settable
as per:
- https://drafts.csswg.org/cssom/#the-elementcssinlinestyle-interface

Both Firefox and Chrome already match the specification (both for the
property location and having it settable).

Test: fast/css/Element-style.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* css/ElementCSSInlineStyle.idl: Added.
* css/PropertySetCSSStyleDeclaration.h:
* css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::ensureCSSStyleDeclaration):
(WebCore::MutableStyleProperties::ensureInlineCSSStyleDeclaration):
* css/StyleProperties.h:
* dom/Attr.cpp:
(WebCore::Attr::style):
* dom/Document.cpp:
(WebCore::Document::createCSSStyleDeclaration):
* dom/Element.cpp:
* dom/Element.h:
* dom/Element.idl:
* dom/StyledElement.cpp:
(WebCore::StyledElement::cssomStyle):
* dom/StyledElement.h:
* editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* html/HTMLElement.idl:

* html/ImageInputType.cpp:
(WebCore::ImageInputType::height):
(WebCore::ImageInputType::width):
Fix bug that was found by fast/forms/input-width-height-attributes-without-renderer-loaded-image.html.
That test relied on setting HTMLElement.style which did not work until now. Call updateLayout()
*before* doing the renderer check.

* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
* inspector/InspectorCSSAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::create):
(WebCore::InspectorStyle::InspectorStyle):
(WebCore::InspectorStyle::extractSourceData):
(WebCore::InspectorStyle::setText):
(WebCore::InspectorStyleSheet::inspectorStyleForId):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
(WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
(WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady):
(WebCore::InspectorStyleSheetForInlineStyle::inlineStyle):
* inspector/InspectorStyleSheet.h:
* svg/SVGElement.idl:

Source/WebKit/mac:

Build fix.

* DOM/DOMElement.mm:
(-[DOMElement style]):
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldApplyStyle):
* WebView/WebFrame.mm:
(-[WebFrame _typingStyle]):

Source/WebKit2:

Build fix.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldApplyStyle):

LayoutTests:

* accessibility/roles-exposed.html:
Add null check for element.style.

* fast/css/Element-style-expected.txt: Added.
* fast/css/Element-style.html: Added.
Add layout test coverage.

* fast/forms/input-width-height-attributes-without-renderer-loaded-image-expected.txt:
Rebaseline test that was setting HTMLElement.style which was a no-op until this patch. Now that it actually
does something, the input element actually looses its renderer. This found a bug which I fixed in this
patch.

* js/dom/dom-static-property-for-in-iteration-expected.txt:
Rebaseline as property enumeration order has changed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/roles-exposed.html
trunk/LayoutTests/fast/forms/input-width-height-attributes-without-renderer-loaded-image-expected.txt
trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.h
trunk/Source/WebCore/css/StyleProperties.cpp
trunk/Source/WebCore/css/StyleProperties.h
trunk/Source/WebCore/dom/Attr.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/dom/StyledElement.cpp
trunk/Source/WebCore/dom/StyledElement.h
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
trunk/Source/WebCore/html/HTMLElement.idl
trunk/Source/WebCore/html/ImageInputType.cpp
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
trunk/Source/WebCore/inspector/InspectorCSSAgent.h
trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp

[webkit-changes] [216424] releases/WebKitGTK/webkit-2.16/Tools

[carlosgc]

Title: [216424] releases/WebKitGTK/webkit-2.16/Tools








Revision 216424
Author carlo...@webkit.org
Date 2017-05-08 09:42:39 -0700 (Mon, 08 May 2017)


Log Message
Merge r216423 - Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/_javascript_-dialogs after r215404.

Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
characters to the input. Also fix typo in the function name.

* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewJavaScriptDialogs):

Modified Paths

releases/WebKitGTK/webkit-2.16/Tools/ChangeLog
releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Tools/ChangeLog (216423 => 216424)

--- releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 16:40:44 UTC (rev 216423)
+++ releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 16:42:39 UTC (rev 216424)
@@ -1,3 +1,14 @@
+2017-05-08  Carlos Garcia Campos  
+
+Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/_javascript_-dialogs after r215404.
+
+Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
+should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
+characters to the input. Also fix typo in the function name.
+
+* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
+(testWebViewJavaScriptDialogs):
+
 2017-05-04  Mark Lam  
 
 DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.


Modified: releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp (216423 => 216424)

--- releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp	2017-05-08 16:40:44 UTC (rev 216423)
+++ releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp	2017-05-08 16:42:39 UTC (rev 216424)
@@ -298,11 +298,11 @@
 return m_mouseTargetHitTestResult.get();
 }
 
-void simulateUserInterqaction()
+void simulateUserInteraction()
 {
-mouseMoveTo(1, 1);
-keyStroke(GDK_KEY_Down);
-keyStroke(GDK_KEY_Up);
+runJavaScriptAndWaitUntilFinished("document.getElementById('testInput').focus()", nullptr);
+keyStroke(GDK_KEY_a);
+keyStroke(GDK_KEY_b);
 while (gtk_events_pending())
 gtk_main_iteration();
 }
@@ -535,7 +535,7 @@
 static const char* jsConfirmFormat = "do { confirmed = confirm('%s'); } while (!confirmed); alert('confirmed');";
 static const char* jsPromptFormat = "alert(prompt('%s', 'default'));";
 static const char* htmlOnBeforeUnloadFormat =
-"function beforeUnloadHandler() { return \"%s\"; }";
+"function beforeUnloadHandler() { return \"%s\"; }";
 
 test->m_scriptDialogType = WEBKIT_SCRIPT_DIALOG_ALERT;
 GUniquePtr alertDialogMessage(g_strdup_printf(jsAlertFormat, kAlertDialogMessage));
@@ -568,7 +568,7 @@
 
 // Reload should trigger onbeforeunload.
 #if 0
-test->simulateUserInterqaction();
+test->simulateUserInteraction();
 // FIXME: reloading HTML data doesn't emit finished load event.
 // See https://bugs.webkit.org/show_bug.cgi?id=139089.
 test->m_scriptDialogConfirmed = false;
@@ -578,7 +578,7 @@
 #endif
 
 // Navigation should trigger onbeforeunload.
-test->simulateUserInterqaction();
+test->simulateUserInteraction();
 test->m_scriptDialogConfirmed = false;
 test->loadHtml("", nullptr);
 test->waitUntilLoadFinished();
@@ -588,7 +588,7 @@
 test->m_scriptDialogConfirmed = false;
 test->loadHtml(beforeUnloadDialogHTML.get(), nullptr);
 test->waitUntilLoadFinished();
-test->simulateUserInterqaction();
+test->simulateUserInteraction();
 test->tryCloseAndWaitUntilClosed();
 g_assert(test->m_scriptDialogConfirmed);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216423] trunk/Tools

[carlosgc]

Title: [216423] trunk/Tools








Revision 216423
Author carlo...@webkit.org
Date 2017-05-08 09:40:44 -0700 (Mon, 08 May 2017)


Log Message
Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/_javascript_-dialogs after r215404.

Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
characters to the input. Also fix typo in the function name.

* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewJavaScriptDialogs):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp




Diff

Modified: trunk/Tools/ChangeLog (216422 => 216423)

--- trunk/Tools/ChangeLog	2017-05-08 15:58:40 UTC (rev 216422)
+++ trunk/Tools/ChangeLog	2017-05-08 16:40:44 UTC (rev 216423)
@@ -1,3 +1,14 @@
+2017-05-08  Carlos Garcia Campos  
+
+Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/_javascript_-dialogs after r215404.
+
+Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
+should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
+characters to the input. Also fix typo in the function name.
+
+* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
+(testWebViewJavaScriptDialogs):
+
 2017-05-07  Michael Catanzaro  
 
 [GTK] Cannot sign in with new Google sign-in page


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp (216422 => 216423)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp	2017-05-08 15:58:40 UTC (rev 216422)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp	2017-05-08 16:40:44 UTC (rev 216423)
@@ -298,11 +298,11 @@
 return m_mouseTargetHitTestResult.get();
 }
 
-void simulateUserInterqaction()
+void simulateUserInteraction()
 {
-mouseMoveTo(1, 1);
-keyStroke(GDK_KEY_Down);
-keyStroke(GDK_KEY_Up);
+runJavaScriptAndWaitUntilFinished("document.getElementById('testInput').focus()", nullptr);
+keyStroke(GDK_KEY_a);
+keyStroke(GDK_KEY_b);
 while (gtk_events_pending())
 gtk_main_iteration();
 }
@@ -535,7 +535,7 @@
 static const char* jsConfirmFormat = "do { confirmed = confirm('%s'); } while (!confirmed); alert('confirmed');";
 static const char* jsPromptFormat = "alert(prompt('%s', 'default'));";
 static const char* htmlOnBeforeUnloadFormat =
-"function beforeUnloadHandler() { return \"%s\"; }";
+"function beforeUnloadHandler() { return \"%s\"; }";
 
 test->m_scriptDialogType = WEBKIT_SCRIPT_DIALOG_ALERT;
 GUniquePtr alertDialogMessage(g_strdup_printf(jsAlertFormat, kAlertDialogMessage));
@@ -568,7 +568,7 @@
 
 // Reload should trigger onbeforeunload.
 #if 0
-test->simulateUserInterqaction();
+test->simulateUserInteraction();
 // FIXME: reloading HTML data doesn't emit finished load event.
 // See https://bugs.webkit.org/show_bug.cgi?id=139089.
 test->m_scriptDialogConfirmed = false;
@@ -578,7 +578,7 @@
 #endif
 
 // Navigation should trigger onbeforeunload.
-test->simulateUserInterqaction();
+test->simulateUserInteraction();
 test->m_scriptDialogConfirmed = false;
 test->loadHtml("", nullptr);
 test->waitUntilLoadFinished();
@@ -588,7 +588,7 @@
 test->m_scriptDialogConfirmed = false;
 test->loadHtml(beforeUnloadDialogHTML.get(), nullptr);
 test->waitUntilLoadFinished();
-test->simulateUserInterqaction();
+test->simulateUserInteraction();
 test->tryCloseAndWaitUntilClosed();
 g_assert(test->m_scriptDialogConfirmed);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216422] releases/WebKitGTK/webkit-2.16/LayoutTests

[carlosgc]

Title: [216422] releases/WebKitGTK/webkit-2.16/LayoutTests








Revision 216422
Author carlo...@webkit.org
Date 2017-05-08 08:58:40 -0700 (Mon, 08 May 2017)


Log Message
Unreviewed GTK+ gardening. Rebaseline fast/repaint/mutate-non-visible.html.

* platform/gtk/fast/repaint/mutate-non-visible-expected.txt: Added.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/fast/repaint/mutate-non-visible-expected.txt




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216421 => 216422)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 15:55:03 UTC (rev 216421)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 15:58:40 UTC (rev 216422)
@@ -1,3 +1,9 @@
+2017-05-05  Carlos Garcia Campos  
+
+Unreviewed GTK+ gardening. Rebaseline fast/repaint/mutate-non-visible.html.
+
+* platform/gtk/fast/repaint/mutate-non-visible-expected.txt: Added.
+
 2017-05-08  Carlos Garcia Campos  
 
 Unreviewed. Skip hls tests crashing with GST 1.8.


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/fast/repaint/mutate-non-visible-expected.txt (0 => 216422)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/fast/repaint/mutate-non-visible-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/fast/repaint/mutate-non-visible-expected.txt	2017-05-08 15:58:40 UTC (rev 216422)
@@ -0,0 +1,7 @@
+Test repaint-only style changes in non-visible elements don't trigger repaints.
+(repaint rects
+  (rect 10 27 100 100)
+  (rect 10 27 100 100)
+  (rect 10 27 100 100)
+)
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216421] releases/WebKitGTK/webkit-2.16/LayoutTests

[carlosgc]

Title: [216421] releases/WebKitGTK/webkit-2.16/LayoutTests








Revision 216421
Author carlo...@webkit.org
Date 2017-05-08 08:55:03 -0700 (Mon, 08 May 2017)


Log Message
Unreviewed. Skip hls tests crashing with GST 1.8.

* platform/gtk/TestExpectations:

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216420 => 216421)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 15:47:54 UTC (rev 216420)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 15:55:03 UTC (rev 216421)
@@ -1,3 +1,9 @@
+2017-05-08  Carlos Garcia Campos  
+
+Unreviewed. Skip hls tests crashing with GST 1.8.
+
+* platform/gtk/TestExpectations:
+
 2017-05-05  Zalan Bujtas  
 
 Renderers being destroyed should not be added to AX's deferred list.


Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/TestExpectations (216420 => 216421)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/TestExpectations	2017-05-08 15:47:54 UTC (rev 216420)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/platform/gtk/TestExpectations	2017-05-08 15:55:03 UTC (rev 216421)
@@ -834,6 +834,12 @@
 # We don't have LastResource font.
 fast/text/font-weight-download-2.html [ Failure ]
 
+# Tests crashing with GST < 1.10
+http/tests/media/hls/hls-audio-tracks-has-audio.html [ Skip ]
+http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Skip ]
+http/tests/media/hls/hls-audio-tracks.html [ Skip ]
+http/tests/media/hls/video-duration-accessibility.html [ Skip ]
+
 #
 # End of Expected failures
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216420] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216420] releases/WebKitGTK/webkit-2.16








Revision 216420
Author carlo...@webkit.org
Date 2017-05-08 08:47:54 -0700 (Mon, 08 May 2017)


Log Message
Merge r216307 - Renderers being destroyed should not be added to AX's deferred list.
https://bugs.webkit.org/show_bug.cgi?id=171768


Reviewed by Simon Fraser.

Source/WebCore:

In certain cases, when custom scrollbars are present, while destroying the scrollbars' block parent, we
  - first remove the block from the AX's deferred list (AXObjectCache::remove)
  - destroy the render layer that owns the custom scrollbars (RenderLayer::destroyLayer)
  - detach the scrollbars from the parent (block) (RenderObject::removeFromParent)
- clean up the block's lines (RenderBlock::deleteLines)
  - push the block back to the AX's deferred list (AXObjectCache::recomputeDeferredIsIgnored)
At this point no one will remove the current block from AX's deferred list.

Test: accessibility/crash-when-renderers-are-added-back-to-deferred-list.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::recomputeDeferredIsIgnored):
(WebCore::AXObjectCache::deferTextChanged):

LayoutTests:

* accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt: Added.
* accessibility/crash-when-renderers-are-added-back-to-deferred-list.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/accessibility/AXObjectCache.cpp


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216419 => 216420)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 15:33:47 UTC (rev 216419)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 15:47:54 UTC (rev 216420)
@@ -1,3 +1,14 @@
+2017-05-05  Zalan Bujtas  
+
+Renderers being destroyed should not be added to AX's deferred list.
+https://bugs.webkit.org/show_bug.cgi?id=171768
+
+
+Reviewed by Simon Fraser.
+
+* accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt: Added.
+* accessibility/crash-when-renderers-are-added-back-to-deferred-list.html: Added.
+
 2017-05-05  Dean Jackson  
 
 Restrict SVG filters to accessible security origins


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt (0 => 216420)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list-expected.txt	2017-05-08 15:47:54 UTC (rev 216420)
@@ -0,0 +1 @@
+PASS if no crash or assert.


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html (0 => 216420)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/accessibility/crash-when-renderers-are-added-back-to-deferred-list.html	2017-05-08 15:47:54 UTC (rev 216420)
@@ -0,0 +1,26 @@
+
+
+
+This tests that accessibility ignores elements that are being destroyed
+
+if (window.accessibilityController)
+accessibilityController.accessibleElementById("foo");
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+::-webkit-scrollbar-corner {
+border: 1px solid green;
+}
+
+
+
+PASS if no crash or assert.
+
+
+document.body.offsetHeight;
+foo.style.display = "none";
+document.body.offsetHeight;
+
+
+


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216419 => 216420)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 15:33:47 UTC (rev 216419)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 15:47:54 UTC (rev 216420)
@@ -1,3 +1,25 @@
+2017-05-05  Zalan Bujtas  
+
+Renderers being destroyed should not be added to AX's deferred list.
+https://bugs.webkit.org/show_bug.cgi?id=171768
+
+
+Reviewed by Simon Fraser.
+
+In certain cases, when custom scrollbars are present, while destroying the scrollbars' block parent, we
+  - first remove the block from the AX's deferred list (AXObjectCache::remove)
+  - destroy the render layer that owns the custom scrollbars (RenderLayer::destroyLayer) 
+  - detach the scrollbars from the parent (block) (RenderObject::removeFromParent)
+- clean up the block's lines 

[webkit-changes] [216419] trunk

[zalan]

Title: [216419] trunk








Revision 216419
Author za...@apple.com
Date 2017-05-08 08:33:47 -0700 (Mon, 08 May 2017)


Log Message
Ensure clean tree before AX cache update.
https://bugs.webkit.org/show_bug.cgi?id=171546


Source/WebCore:

While updating an accessibility object state, we might
perform unintentional style updates. This style update could
end up destroying renderes that are still referenced by function calls
on the callstack.
To avoid that, AXObjectCache should operate on a clean tree only.

Reviewed by Chris Fleizach.

Test: accessibility/crash-when-render-tree-is-not-clean.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::handleAriaModalChange):
(WebCore::AXObjectCache::labelChanged):
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleAriaRoleChanged):
(WebCore::AXObjectCache::handleAriaModalChange):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::selectedChildrenChanged):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
* dom/Element.cpp:
(WebCore::Element::attributeChanged):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):

LayoutTests:

Reviewed by Chris Fleizach.

* accessibility/crash-when-render-tree-is-not-clean.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/html/HTMLInputElement.cpp


Added Paths

trunk/LayoutTests/accessibility/crash-when-render-tree-is-not-clean-expected.txt
trunk/LayoutTests/accessibility/crash-when-render-tree-is-not-clean.html




Diff

Modified: trunk/LayoutTests/ChangeLog (216418 => 216419)

--- trunk/LayoutTests/ChangeLog	2017-05-08 15:26:38 UTC (rev 216418)
+++ trunk/LayoutTests/ChangeLog	2017-05-08 15:33:47 UTC (rev 216419)
@@ -1,3 +1,13 @@
+2017-05-06  Zalan Bujtas  
+
+Ensure clean tree before AX cache update.
+https://bugs.webkit.org/show_bug.cgi?id=171546
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/crash-when-render-tree-is-not-clean.html: Added.
+
 2017-05-08  Myles C. Maxfield  
 
 Unprefix unicode-bidi CSS values


Added: trunk/LayoutTests/accessibility/crash-when-render-tree-is-not-clean-expected.txt (0 => 216419)

--- trunk/LayoutTests/accessibility/crash-when-render-tree-is-not-clean-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/crash-when-render-tree-is-not-clean-expected.txt	2017-05-08 15:33:47 UTC (rev 216419)
@@ -0,0 +1,2 @@
+Pass if no crash or assert.
+


Added: trunk/LayoutTests/accessibility/crash-when-render-tree-is-not-clean.html (0 => 216419)

--- trunk/LayoutTests/accessibility/crash-when-render-tree-is-not-clean.html	(rev 0)
+++ trunk/LayoutTests/accessibility/crash-when-render-tree-is-not-clean.html	2017-05-08 15:33:47 UTC (rev 216419)
@@ -0,0 +1,20 @@
+
+
+
+This tests that we properly update the tree before updating accessibility cache.
+
+if (window.accessibilityController)
+accessibilityController.accessibleElementById("outer");
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+Pass if no crash or assert.
+foobar
+
+  inner.style.display = "none";
+  outer.setAttribute("aria-labeledby", "inner");
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (216418 => 216419)

--- trunk/Source/WebCore/ChangeLog	2017-05-08 15:26:38 UTC (rev 216418)
+++ trunk/Source/WebCore/ChangeLog	2017-05-08 15:33:47 UTC (rev 216419)
@@ -1,3 +1,43 @@
+2017-05-06  Zalan Bujtas  
+
+Ensure clean tree before AX cache update.
+https://bugs.webkit.org/show_bug.cgi?id=171546
+
+
+While updating an accessibility object state, we might
+perform unintentional style updates. This style update could
+end up destroying renderes that are still referenced by function calls 
+on the callstack.
+To avoid that, AXObjectCache should operate on a clean tree only. 
+
+Reviewed by Chris Fleizach.
+
+Test: accessibility/crash-when-render-tree-is-not-clean.html
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::checkedStateChanged):
+(WebCore::AXObjectCache::selectedChildrenChanged):
+

[webkit-changes] [216417] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216417] releases/WebKitGTK/webkit-2.16








Revision 216417
Author carlo...@webkit.org
Date 2017-05-08 07:24:57 -0700 (Mon, 08 May 2017)


Log Message
Merge r216294 - Restrict SVG filters to accessible security origins
https://bugs.webkit.org/show_bug.cgi?id=118689


Reviewed by Brent Fulgham.

Source/WebCore:

Certain SVG filters should only be allowed to operate
on content that is has SecurityOrigin access to. Implement
this by including a flag in PaintInfo and LayerPaintingInfo,
and have RenderWidget make sure the documents have acceptable
SecurityOrigins as it goes to paint.

This could be used as the first step in a "safe painting"
strategy, allowing some content to be rendered into a
canvas or via the element() CSS function... but it is only
a small first step.

Test: http/tests/css/filters-on-iframes.html

* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
* platform/ScrollView.h:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::paint):
* platform/Scrollbar.h:
* platform/Widget.h:
* platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::shouldBeRestrictedBySecurityOrigin):
* platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::hasFilterThatShouldBeRestrictedBySecurityOrigin):
* platform/graphics/filters/FilterOperations.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
* rendering/FilterEffectRenderer.h:
* rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
* rendering/RenderLayer.h:
* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::paint):
* rendering/RenderScrollbar.h:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paintContents):

Source/WebKit2:

Update parameter lists.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):
* WebProcess/Plugins/PluginView.h:

LayoutTests:

Add a test that shows safe frames, unsafe frames, and
then a safe frame that itself has an unsafe frame, to
show that the security requirements are being forwarded
down the tree.

* http/tests/css/filters-on-iframes-expected.html: Added.
* http/tests/css/filters-on-iframes.html: Added.
* http/tests/css/resources/blank.html: Added.
* http/tests/css/resources/references-external.html: Added.
* http/tests/css/resources/solid-red.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/page/FrameView.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/page/FrameView.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/ScrollView.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/ScrollView.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/Scrollbar.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/Scrollbar.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/Widget.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/filters/FilterOperation.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/filters/FilterOperations.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/filters/FilterOperations.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/WidgetGtk.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/mac/WidgetMac.mm
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/win/WidgetWin.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/FilterEffectRenderer.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/FilterEffectRenderer.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/PaintInfo.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderLayer.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderLayer.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderScrollbar.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderScrollbar.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderWidget.cpp
releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
releases/WebKitGTK/webkit-2.16/Source/WebKit2/WebProcess/Plugins/PluginView.h


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/css/filters-on-iframes-expected.html
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/css/filters-on-iframes.html
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/css/resources/blank.html
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/css/resources/references-external.html
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/css/resources/solid-red.html




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216416 => 216417)

[webkit-changes] [216416] releases/WebKitGTK/webkit-2.16/Source/WebCore

[carlosgc]

Title: [216416] releases/WebKitGTK/webkit-2.16/Source/WebCore








Revision 216416
Author carlo...@webkit.org
Date 2017-05-08 07:06:29 -0700 (Mon, 08 May 2017)


Log Message
Merge r216253 - ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() in WebCore::FrameView::layout(bool)
https://bugs.webkit.org/show_bug.cgi?id=171717

Reviewed by Brent Fulgham.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):

Don't allow frame load to complete in the middle of a render tree update. Instead delay the check.

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216415 => 216416)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 14:05:16 UTC (rev 216415)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 14:06:29 UTC (rev 216416)
@@ -1,3 +1,15 @@
+2017-05-05  Antti Koivisto  
+
+ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() in WebCore::FrameView::layout(bool)
+https://bugs.webkit.org/show_bug.cgi?id=171717
+
+Reviewed by Brent Fulgham.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::checkCompleted):
+
+Don't allow frame load to complete in the middle of a render tree update. Instead delay the check.
+
 2017-05-04  Mark Lam  
 
 DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/loader/FrameLoader.cpp (216415 => 216416)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/loader/FrameLoader.cpp	2017-05-08 14:05:16 UTC (rev 216415)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/loader/FrameLoader.cpp	2017-05-08 14:06:29 UTC (rev 216416)
@@ -775,6 +775,13 @@
 if (m_isComplete)
 return;
 
+// FIXME: It would be better if resource loads were kicked off after render tree update (or didn't complete synchronously).
+//https://bugs.webkit.org/show_bug.cgi?id=171729
+if (m_frame.document()->inRenderTreeUpdate()) {
+scheduleCheckCompleted();
+return;
+}
+
 // Are we still parsing?
 if (m_frame.document()->parsing())
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216415] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216415] releases/WebKitGTK/webkit-2.16








Revision 216415
Author carlo...@webkit.org
Date 2017-05-08 07:05:16 -0700 (Mon, 08 May 2017)


Log Message
Merge r216246 - DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
https://bugs.webkit.org/show_bug.cgi?id=171716


Reviewed by Saam Barati.

Source/WebCore:

No new tests.  This issue was caught by existing tests.

IDBRequest::setResult() needs to acquire the JSLock before calling toJS() (which
does JS conversion and therefore, potentially JS allocations).

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):

Tools:

setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
does JS conversion and therefore, potentially JS allocations) and accessing
methods of internal JS data structures (which may do JS invocation, etc).

* DumpRenderTree/TestRunner.cpp:
(setAudioResultCallback):

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/Modules/indexeddb/IDBRequest.cpp
releases/WebKitGTK/webkit-2.16/Tools/ChangeLog
releases/WebKitGTK/webkit-2.16/Tools/DumpRenderTree/TestRunner.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216414 => 216415)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 14:03:51 UTC (rev 216414)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 14:05:16 UTC (rev 216415)
@@ -1,3 +1,20 @@
+2017-05-04  Mark Lam  
+
+DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
+https://bugs.webkit.org/show_bug.cgi?id=171716
+
+
+Reviewed by Saam Barati.
+
+No new tests.  This issue was caught by existing tests.
+
+IDBRequest::setResult() needs to acquire the JSLock before calling toJS() (which
+does JS conversion and therefore, potentially JS allocations).
+
+* Modules/indexeddb/IDBRequest.cpp:
+(WebCore::IDBRequest::setResult):
+(WebCore::IDBRequest::setResultToStructuredClone):
+
 2017-05-05  Carlos Garcia Campos  
 
 [GStreamer] Do not report more errors after the first one


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (216414 => 216415)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2017-05-08 14:03:51 UTC (rev 216414)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2017-05-08 14:05:16 UTC (rev 216415)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015, 2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -370,7 +370,9 @@
 
 // FIXME: This conversion should be done lazily, when script needs the JSValues, so that global object
 // of the IDBRequest wrapper can be used, rather than the lexicalGlobalObject.
-m_result = Result { JSC::Strong { context->vm(), toJS(*state, *jsCast(state->lexicalGlobalObject()), keyData) } };
+VM& vm = context->vm();
+JSLockHolder lock(vm);
+m_result = Result { JSC::Strong { vm, toJS(*state, *jsCast(state->lexicalGlobalObject()), keyData) } };
 }
 
 void IDBRequest::setResult(const Vector& keyDatas)
@@ -387,8 +389,9 @@
 
 // FIXME: This conversion should be done lazily, when script needs the JSValues, so that global object
 // of the IDBRequest wrapper can be used, rather than the lexicalGlobalObject.
-Locker locker(context->vm().apiLock());
-m_result = Result { JSC::Strong { context->vm(), toJS(*state, *jsCast(state->lexicalGlobalObject()), keyDatas) } };
+VM& vm = context->vm();
+JSLockHolder lock(vm);
+m_result = Result { JSC::Strong { vm, toJS(*state, *jsCast(state->lexicalGlobalObject()), keyDatas) } };
 }
 
 void IDBRequest::setResult(const Vector& values)
@@ -405,8 +408,9 @@
 
 // FIXME: This conversion should be done lazily, when script needs the JSValues, so that global object
 // of the IDBRequest wrapper can be used, rather than the lexicalGlobalObject.
-Locker locker(context->vm().apiLock());
-m_result = Result { JSC::Strong { context->vm(), toJS(*state, *jsCast(state->lexicalGlobalObject()), values) } };
+VM& vm = context->vm();
+JSLockHolder lock(vm);
+m_result = Result { JSC::Strong { vm, toJS(*state, *jsCast(state->lexicalGlobalObject()), values) } };
 }
 
 void IDBRequest::setResult(uint64_t number)
@@ -436,7 +440,9 @@
 
 // FIXME: This conversion should be done lazily, when script needs the JSValues, so that global object
 

[webkit-changes] [216414] releases/WebKitGTK/webkit-2.16/Tools

[carlosgc]

Title: [216414] releases/WebKitGTK/webkit-2.16/Tools








Revision 216414
Author carlo...@webkit.org
Date 2017-05-08 07:03:51 -0700 (Mon, 08 May 2017)


Log Message
Merge r216241 - [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
https://bugs.webkit.org/show_bug.cgi?id=171724

Reviewed by Michael Catanzaro.

It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.

* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::timeoutSource):

Modified Paths

releases/WebKitGTK/webkit-2.16/Tools/ChangeLog
releases/WebKitGTK/webkit-2.16/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Tools/ChangeLog (216413 => 216414)

--- releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 13:59:35 UTC (rev 216413)
+++ releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 14:03:51 UTC (rev 216414)
@@ -1,3 +1,15 @@
+2017-05-05  Carlos Garcia Campos  
+
+[GTK] TestController timeout source callback should return G_SOURCE_REMOVE
+https://bugs.webkit.org/show_bug.cgi?id=171724
+
+Reviewed by Michael Catanzaro.
+
+It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
+
+* WebKitTestRunner/gtk/TestControllerGtk.cpp:
+(WTR::timeoutSource):
+
 2017-05-04  Konstantin Tokarev  
 
 Fix compilation with ICU 59.1


Modified: releases/WebKitGTK/webkit-2.16/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (216413 => 216414)

--- releases/WebKitGTK/webkit-2.16/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp	2017-05-08 13:59:35 UTC (rev 216413)
+++ releases/WebKitGTK/webkit-2.16/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp	2017-05-08 14:03:51 UTC (rev 216414)
@@ -48,7 +48,7 @@
 g_source_set_ready_time(static_cast(userData), -1);
 fprintf(stderr, "FAIL: TestControllerRunLoop timed out.\n");
 RunLoop::main().stop();
-return G_SOURCE_CONTINUE;
+return G_SOURCE_REMOVE;
 }, source.get(), nullptr);
 g_source_attach(source.get(), nullptr);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216413] releases/WebKitGTK/webkit-2.16/Source/WebCore

[carlosgc]

Title: [216413] releases/WebKitGTK/webkit-2.16/Source/WebCore








Revision 216413
Author carlo...@webkit.org
Date 2017-05-08 06:59:35 -0700 (Mon, 08 May 2017)


Log Message
Merge r216240 - [GStreamer] Do not report more errors after the first one
https://bugs.webkit.org/show_bug.cgi?id=171722

Reviewed by Xabier Rodriguez-Calvar.

We can receive several error messages for the same error from different elements. That's not expected by the
media source selection algorithm implementation. I don't know if didn't happen with previous versions of GST,
but since the upgrade to 1.10.4 several tests are failing because of this.

Fixes: media/video-error-does-not-exist.html
   media/video-load-networkState.html
   media/video-source-error.html
   media/video-source-none-supported.html
   media/video-source-moved.html

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Return early also when an error already occured.

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216412 => 216413)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:58:28 UTC (rev 216412)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:59:35 UTC (rev 216413)
@@ -1,5 +1,25 @@
 2017-05-05  Carlos Garcia Campos  
 
+[GStreamer] Do not report more errors after the first one
+https://bugs.webkit.org/show_bug.cgi?id=171722
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+We can receive several error messages for the same error from different elements. That's not expected by the
+media source selection algorithm implementation. I don't know if didn't happen with previous versions of GST,
+but since the upgrade to 1.10.4 several tests are failing because of this.
+
+Fixes: media/video-error-does-not-exist.html
+   media/video-load-networkState.html
+   media/video-source-error.html
+   media/video-source-none-supported.html
+   media/video-source-moved.html
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Return early also when an error already occured.
+
+2017-05-05  Carlos Garcia Campos  
+
 [GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
 https://bugs.webkit.org/show_bug.cgi?id=171721
 


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (216412 => 216413)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2017-05-08 13:58:28 UTC (rev 216412)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2017-05-08 13:59:35 UTC (rev 216413)
@@ -937,10 +937,8 @@
 GST_DEBUG("Message %s received from element %s", GST_MESSAGE_TYPE_NAME(message), GST_MESSAGE_SRC_NAME(message));
 switch (GST_MESSAGE_TYPE(message)) {
 case GST_MESSAGE_ERROR:
-if (m_resetPipeline)
+if (m_resetPipeline || m_missingPluginsCallback || m_errorOccured)
 break;
-if (m_missingPluginsCallback)
-break;
 gst_message_parse_error(message, (), ());
 GST_ERROR("Error %d: %s (url="" err->code, err->message, m_url.string().utf8().data());
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216412] releases/WebKitGTK/webkit-2.16/Source/WebCore

[carlosgc]

Title: [216412] releases/WebKitGTK/webkit-2.16/Source/WebCore








Revision 216412
Author carlo...@webkit.org
Date 2017-05-08 06:58:28 -0700 (Mon, 08 May 2017)


Log Message
Merge r216239 - [GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
https://bugs.webkit.org/show_bug.cgi?id=171721

Reviewed by Xabier Rodriguez-Calvar.

We are checking the GError only comparing the code, and ignoring the domain in some cases. Use g_error_matches()
in those cases instead of only checking the code.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216411 => 216412)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:54:49 UTC (rev 216411)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:58:28 UTC (rev 216412)
@@ -1,3 +1,16 @@
+2017-05-05  Carlos Garcia Campos  
+
+[GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
+https://bugs.webkit.org/show_bug.cgi?id=171721
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+We are checking the GError only comparing the code, and ignoring the domain in some cases. Use g_error_matches()
+in those cases instead of only checking the code.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
+
 2017-05-04  Antti Koivisto  
 
 REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (216411 => 216412)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2017-05-08 13:54:49 UTC (rev 216411)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2017-05-08 13:58:28 UTC (rev 216412)
@@ -947,20 +947,19 @@
 GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_ALL, "webkit-video.error");
 
 error = MediaPlayer::Empty;
-if (err->code == GST_STREAM_ERROR_CODEC_NOT_FOUND
-|| err->code == GST_STREAM_ERROR_WRONG_TYPE
-|| err->code == GST_STREAM_ERROR_FAILED
-|| err->code == GST_CORE_ERROR_MISSING_PLUGIN
-|| err->code == GST_RESOURCE_ERROR_NOT_FOUND)
+if (g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_CODEC_NOT_FOUND)
+|| g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_WRONG_TYPE)
+|| g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_FAILED)
+|| g_error_matches(err.get(), GST_CORE_ERROR, GST_CORE_ERROR_MISSING_PLUGIN)
+|| g_error_matches(err.get(), GST_RESOURCE_ERROR, GST_RESOURCE_ERROR_NOT_FOUND))
 error = MediaPlayer::FormatError;
-else if (err->domain == GST_STREAM_ERROR) {
+else if (g_error_matches(err.get(), GST_STREAM_ERROR, GST_STREAM_ERROR_TYPE_NOT_FOUND)) {
 // Let the mediaPlayerClient handle the stream error, in
 // this case the HTMLMediaElement will emit a stalled
 // event.
-if (err->code == GST_STREAM_ERROR_TYPE_NOT_FOUND) {
-GST_ERROR("Decode error, let the Media element emit a stalled event.");
-break;
-}
+GST_ERROR("Decode error, let the Media element emit a stalled event.");
+break;
+} else if (err->domain == GST_STREAM_ERROR) {
 error = MediaPlayer::DecodeError;
 attemptNextLocation = true;
 } else if (err->domain == GST_RESOURCE_ERROR)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216411] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216411] releases/WebKitGTK/webkit-2.16








Revision 216411
Author carlo...@webkit.org
Date 2017-05-08 06:54:49 -0700 (Mon, 08 May 2017)


Log Message
Merge r216204 - REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned
https://bugs.webkit.org/show_bug.cgi?id=171250


Reviewed by Geoffrey Garen.

Source/WebCore:

We were mapping unknown properties to 'all' animation. With this patch we ignore them instead.
The patch also implements roundtripping of unknown properties via CSSOM, matching Blink and Gecko.

Test: transitions/transition-unknown-property-ignore.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::createTransitionPropertyValue):

Return the correct name for unknown properties.

* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationProperty):

Map any unknown property to AnimateUnknownProperty mode instead of falling back to the default of AnimateAll.
Save the unknown property name so we can roundtrip it properly.

* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):

Ignore AnimateUnknownProperty like AnimateNone.

* platform/animation/Animation.h:
(WebCore::Animation::unknownProperty):
(WebCore::Animation::setUnknownProperty):

LayoutTests:

* transitions/transition-unknown-property-ignore-expected.txt: Added.
* transitions/transition-unknown-property-ignore.html: Added.
* transitions/transitions-parsing-expected.txt:
* transitions/transitions-parsing.html:

Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transitions-parsing-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transitions-parsing.html
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/css/CSSToStyleMap.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/page/animation/CompositeAnimation.cpp
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/animation/Animation.h


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transition-unknown-property-ignore-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transition-unknown-property-ignore.html




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216410 => 216411)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:44:59 UTC (rev 216410)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:54:49 UTC (rev 216411)
@@ -1,3 +1,18 @@
+2017-05-04  Antti Koivisto  
+
+REGRESSION (Safari 10.1): When 'transition' contains -ms-transform, transform-origin is also transitioned
+https://bugs.webkit.org/show_bug.cgi?id=171250
+
+
+Reviewed by Geoffrey Garen.
+
+* transitions/transition-unknown-property-ignore-expected.txt: Added.
+* transitions/transition-unknown-property-ignore.html: Added.
+* transitions/transitions-parsing-expected.txt:
+* transitions/transitions-parsing.html:
+
+Update the roundtrip expectations for unknown properties. The new results match Blink and Gecko.
+
 2017-05-04  Dave Hyatt  
 
 REGRESSION(STP): rgb() with calc() containing variables doesn't work


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transition-unknown-property-ignore-expected.txt (0 => 216411)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transition-unknown-property-ignore-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transition-unknown-property-ignore-expected.txt	2017-05-08 13:54:49 UTC (rev 216411)
@@ -0,0 +1,5 @@
+
+
+Transitioning properties:
+transform
+


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transition-unknown-property-ignore.html (0 => 216411)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transition-unknown-property-ignore.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/transitions/transition-unknown-property-ignore.html	2017-05-08 13:54:49 UTC (rev 216411)
@@ -0,0 +1,44 @@
+
+.container {
+transition: -ms-transform 0.1s ease, transform 0.1s ease;
+transform-origin: 100% 100%;
+}
+
+.container-transform {
+transform: scale3d(1.3, 1.3, 1);
+transform-origin: 0% 0%;
+}
+
+.box {
+width: 100px;
+height: 100px;
+background-color: red;
+}
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function test() {
+document.querySelector(".container")._ontransitionend_ = (ev) => {
+log.innerHTML += ev.propertyName +"
";
+if (window.testRunner)
+setTimeout(() => testRunner.notifyDone(), 

[webkit-changes] [216410] releases/WebKitGTK/webkit-2.16/Source/WebCore

[carlosgc]

Title: [216410] releases/WebKitGTK/webkit-2.16/Source/WebCore








Revision 216410
Author carlo...@webkit.org
Date 2017-05-08 06:44:59 -0700 (Mon, 08 May 2017)


Log Message
Merge r216196 - Should never hit layout while updating the render tree.
https://bugs.webkit.org/show_bug.cgi?id=171643

Reviewed by Antti Koivisto.

Laying out a half-baked render tree is not a great idea. Especially considering
that layout (sadly) can mutate the render tree.

* page/FrameView.cpp:
(WebCore::FrameView::layout):

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/page/FrameView.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216409 => 216410)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:40:44 UTC (rev 216409)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:44:59 UTC (rev 216410)
@@ -1,3 +1,16 @@
+2017-05-04  Zalan Bujtas  
+
+Should never hit layout while updating the render tree.
+https://bugs.webkit.org/show_bug.cgi?id=171643
+
+Reviewed by Antti Koivisto.
+
+Laying out a half-baked render tree is not a great idea. Especially considering
+that layout (sadly) can mutate the render tree.  
+
+* page/FrameView.cpp:
+(WebCore::FrameView::layout):
+
 2017-05-04  Dave Hyatt  
 
 REGRESSION(STP): rgb() with calc() containing variables doesn't work


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/page/FrameView.cpp (216409 => 216410)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/page/FrameView.cpp	2017-05-08 13:40:44 UTC (rev 216409)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/page/FrameView.cpp	2017-05-08 13:44:59 UTC (rev 216410)
@@ -1284,6 +1284,8 @@
 
 void FrameView::layout(bool allowSubtree)
 {
+ASSERT_WITH_SECURITY_IMPLICATION(!frame().document()->inRenderTreeUpdate());
+
 LOG(Layout, "FrameView %p (%dx%d) layout, main frameview %d, allowSubtree=%d", this, size().width(), size().height(), frame().isMainFrame(), allowSubtree);
 if (isInRenderTreeLayout()) {
 LOG(Layout, "  in layout, bailing");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216409] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216409] releases/WebKitGTK/webkit-2.16








Revision 216409
Author carlo...@webkit.org
Date 2017-05-08 06:40:44 -0700 (Mon, 08 May 2017)


Log Message
Merge r216188 - REGRESSION(STP): rgb() with calc() containing variables doesn't work
https://bugs.webkit.org/show_bug.cgi?id=169939

Reviewed by Zalan Bujtas.

Source/WebCore:

Added new test in fast/css/variables.

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcExpressionNodeParser::parseValue):
Treat floats in calcs as integers when we can.

LayoutTests:

* fast/css/variables/calc-float-to-int-expected.html: Added.
* fast/css/variables/calc-float-to-int.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/css/CSSCalculationValue.cpp


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/fast/css/variables/calc-float-to-int-expected.html
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/css/variables/calc-float-to-int.html




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216408 => 216409)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:39:28 UTC (rev 216408)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:40:44 UTC (rev 216409)
@@ -1,3 +1,13 @@
+2017-05-04  Dave Hyatt  
+
+REGRESSION(STP): rgb() with calc() containing variables doesn't work
+https://bugs.webkit.org/show_bug.cgi?id=169939
+
+Reviewed by Zalan Bujtas.
+
+* fast/css/variables/calc-float-to-int-expected.html: Added.
+* fast/css/variables/calc-float-to-int.html: Added.
+
 2017-05-03  Zalan Bujtas  
 
 SearchInputType could end up with a mismatched renderer.


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/css/variables/calc-float-to-int-expected.html (0 => 216409)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/css/variables/calc-float-to-int-expected.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/css/variables/calc-float-to-int-expected.html	2017-05-08 13:40:44 UTC (rev 216409)
@@ -0,0 +1,13 @@
+
+
+
+body {
+background: rgb(0, 255, 0);
+height: 100vh;
+margin: 0;
+}
+
+
+
+
+


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/css/variables/calc-float-to-int.html (0 => 216409)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/css/variables/calc-float-to-int.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/css/variables/calc-float-to-int.html	2017-05-08 13:40:44 UTC (rev 216409)
@@ -0,0 +1,19 @@
+
+
+
+html {
+background: red;
+}
+
+body {
+--color: 1.0;
+background: red;
+background: rgb(0, calc(255 * var(--color)), 0);
+height: 100vh;
+margin: 0;
+}
+
+
+
+
+


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216408 => 216409)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:39:28 UTC (rev 216408)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:40:44 UTC (rev 216409)
@@ -1,3 +1,16 @@
+2017-05-04  Dave Hyatt  
+
+REGRESSION(STP): rgb() with calc() containing variables doesn't work
+https://bugs.webkit.org/show_bug.cgi?id=169939
+
+Reviewed by Zalan Bujtas.
+
+Added new test in fast/css/variables.
+
+* css/CSSCalculationValue.cpp:
+(WebCore::CSSCalcExpressionNodeParser::parseValue):
+Treat floats in calcs as integers when we can.
+
 2017-05-03  Zalan Bujtas  
 
 SearchInputType could end up with a mismatched renderer.


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/css/CSSCalculationValue.cpp (216408 => 216409)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/css/CSSCalculationValue.cpp	2017-05-08 13:39:28 UTC (rev 216408)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/css/CSSCalculationValue.cpp	2017-05-08 13:40:44 UTC (rev 216409)
@@ -598,7 +598,8 @@
 if (unitCategory(type) == CalcOther)
 return false;
 
-result->value = CSSCalcPrimitiveValue::create(CSSPrimitiveValue::create(token.numericValue(), type), token.numericValueType() == IntegerValueType);
+bool isInteger = token.numericValueType() == IntegerValueType || (token.numericValueType() == NumberValueType && token.numericValue() == trunc(token.numericValue()));
+result->value = CSSCalcPrimitiveValue::create(CSSPrimitiveValue::create(token.numericValue(), type), isInteger);
 
 return true;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216408] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216408] releases/WebKitGTK/webkit-2.16








Revision 216408
Author carlo...@webkit.org
Date 2017-05-08 06:39:28 -0700 (Mon, 08 May 2017)


Log Message
Merge r216187 - Fix compilation with ICU 59.1
https://bugs.webkit.org/show_bug.cgi?id=171612

Reviewed by Mark Lam.

ICU 59.1 has broken source compatibility. Now it defines UChar as
char16_t, which does not allow automatic type conversion from unsigned
short in C++ code.

Source/_javascript_Core:

* API/JSStringRef.cpp:
(JSStringCreateWithCharacters):
(JSStringCreateWithCharactersNoCopy):
(JSStringGetCharactersPtr):
* runtime/DateConversion.cpp:
(JSC::formatDateTime):

Source/WebKit2:

* Shared/API/c/WKString.cpp:
(WKStringGetCharacters):

Tools:

* TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/API/JSStringRef.cpp
releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/DateConversion.cpp
releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebKit2/Shared/API/c/WKString.cpp
releases/WebKitGTK/webkit-2.16/Tools/ChangeLog
releases/WebKitGTK/webkit-2.16/Tools/TestRunnerShared/UIScriptContext/UIScriptContext.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/API/JSStringRef.cpp (216407 => 216408)

--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/API/JSStringRef.cpp	2017-05-08 13:33:51 UTC (rev 216407)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/API/JSStringRef.cpp	2017-05-08 13:39:28 UTC (rev 216408)
@@ -37,7 +37,7 @@
 JSStringRef JSStringCreateWithCharacters(const JSChar* chars, size_t numChars)
 {
 initializeThreading();
-return ::create(chars, numChars).leakRef();
+return ::create(reinterpret_cast(chars), numChars).leakRef();
 }
 
 JSStringRef JSStringCreateWithUTF8CString(const char* string)
@@ -62,7 +62,7 @@
 JSStringRef JSStringCreateWithCharactersNoCopy(const JSChar* chars, size_t numChars)
 {
 initializeThreading();
-return OpaqueJSString::create(StringImpl::createWithoutCopying(chars, numChars)).leakRef();
+return OpaqueJSString::create(StringImpl::createWithoutCopying(reinterpret_cast(chars), numChars)).leakRef();
 }
 
 JSStringRef JSStringRetain(JSStringRef string)
@@ -87,7 +87,7 @@
 {
 if (!string)
 return nullptr;
-return string->characters();
+return reinterpret_cast(string->characters());
 }
 
 size_t JSStringGetMaximumUTF8CStringSize(JSStringRef string)


Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog (216407 => 216408)

--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-05-08 13:33:51 UTC (rev 216407)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-05-08 13:39:28 UTC (rev 216408)
@@ -1,3 +1,21 @@
+2017-05-04  Konstantin Tokarev  
+
+Fix compilation with ICU 59.1
+https://bugs.webkit.org/show_bug.cgi?id=171612
+
+Reviewed by Mark Lam.
+
+ICU 59.1 has broken source compatibility. Now it defines UChar as
+char16_t, which does not allow automatic type conversion from unsigned
+short in C++ code.
+
+* API/JSStringRef.cpp:
+(JSStringCreateWithCharacters):
+(JSStringCreateWithCharactersNoCopy):
+(JSStringGetCharactersPtr):
+* runtime/DateConversion.cpp:
+(JSC::formatDateTime):
+
 2017-04-19  Yusuke Suzuki  
 
 r211670 broke double to int conversion.


Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/DateConversion.cpp (216407 => 216408)

--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/DateConversion.cpp	2017-05-08 13:33:51 UTC (rev 216407)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/DateConversion.cpp	2017-05-08 13:39:28 UTC (rev 216408)
@@ -107,7 +107,8 @@
 #if OS(WINDOWS)
 TIME_ZONE_INFORMATION timeZoneInformation;
 GetTimeZoneInformation();
-const WCHAR* timeZoneName = t.isDST() ? timeZoneInformation.DaylightName : timeZoneInformation.StandardName;
+const WCHAR* winTimeZoneName = t.isDST() ? timeZoneInformation.DaylightName : timeZoneInformation.StandardName;
+String timeZoneName(reinterpret_cast(winTimeZoneName));
 #else
 struct tm gtm = t;
 char timeZoneName[70];
@@ -115,11 +116,7 @@
 #endif
 if (timeZoneName[0]) {
 builder.appendLiteral(" (");
-#if OS(WINDOWS)
-builder.append(String(timeZoneName));
-#else
 builder.append(timeZoneName);
-#endif
 builder.append(')');
 }
 }


Modified: releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog (216407 => 216408)

--- releases/WebKitGTK/webkit-2.16/Source/WebKit2/ChangeLog	

[webkit-changes] [216407] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216407] releases/WebKitGTK/webkit-2.16








Revision 216407
Author carlo...@webkit.org
Date 2017-05-08 06:33:51 -0700 (Mon, 08 May 2017)


Log Message
Merge r216159 - SearchInputType could end up with a mismatched renderer.
https://bugs.webkit.org/show_bug.cgi?id=171547


Reviewed by Antti Koivisto.

Source/WebCore:

Normally we've got the correct renderer by the time we call into SearchInputType.
However, since HTMLInputElement::updateType() eagerly updates the type while the associated renderers are done lazily
(so we don't get them updated until after the next tree update), we could actually end up
with a mismatched renderer (e.g. through form submission).

Test: fast/forms/change-input-type-and-submit-form-crash.html

* html/SearchInputType.cpp:
(WebCore::SearchInputType::addSearchResult):
(WebCore::SearchInputType::didSetValueByUserEdit):

LayoutTests:

* fast/forms/change-input-type-and-submit-form-crash-expected.txt: Added.
* fast/forms/change-input-type-and-submit-form-crash.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/html/SearchInputType.cpp


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/fast/forms/change-input-type-and-submit-form-crash-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216406 => 216407)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:32:50 UTC (rev 216406)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:33:51 UTC (rev 216407)
@@ -1,3 +1,14 @@
+2017-05-03  Zalan Bujtas  
+
+SearchInputType could end up with a mismatched renderer.
+https://bugs.webkit.org/show_bug.cgi?id=171547
+
+
+Reviewed by Antti Koivisto.
+
+* fast/forms/change-input-type-and-submit-form-crash-expected.txt: Added.
+* fast/forms/change-input-type-and-submit-form-crash.html: Added.
+
 2017-05-03  Daniel Bates  
 
 Detach frame from document when entering page cache


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/forms/change-input-type-and-submit-form-crash-expected.txt (0 => 216407)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/forms/change-input-type-and-submit-form-crash-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/forms/change-input-type-and-submit-form-crash-expected.txt	2017-05-08 13:33:51 UTC (rev 216407)
@@ -0,0 +1,2 @@
+PASS if no crash or assert.
+


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html (0 => 216407)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/forms/change-input-type-and-submit-form-crash.html	2017-05-08 13:33:51 UTC (rev 216407)
@@ -0,0 +1,19 @@
+
+
+
+This tests that submitting a form soon after changing the input type is ok.
+
+
+PASS if no crash or assert.
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+document.body.offsetHeight;
+inputToChange.value = "1";
+inputToChange.type = "search";
+formToSubmit.submit();
+
+
+


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216406 => 216407)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:32:50 UTC (rev 216406)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:33:51 UTC (rev 216407)
@@ -1,3 +1,22 @@
+2017-05-03  Zalan Bujtas  
+
+SearchInputType could end up with a mismatched renderer.
+https://bugs.webkit.org/show_bug.cgi?id=171547
+
+
+Reviewed by Antti Koivisto.
+
+Normally we've got the correct renderer by the time we call into SearchInputType.
+However, since HTMLInputElement::updateType() eagerly updates the type while the associated renderers are done lazily
+(so we don't get them updated until after the next tree update), we could actually end up
+with a mismatched renderer (e.g. through form submission).
+
+Test: fast/forms/change-input-type-and-submit-form-crash.html
+
+* html/SearchInputType.cpp:
+(WebCore::SearchInputType::addSearchResult):
+(WebCore::SearchInputType::didSetValueByUserEdit):
+
 2017-05-07  Michael Catanzaro  
 
 [GTK] Cannot sign in with new Google sign-in page


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/html/SearchInputType.cpp (216406 => 216407)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/html/SearchInputType.cpp	2017-05-08 13:32:50 UTC (rev 216406)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/html/SearchInputType.cpp	2017-05-08 13:33:51 UTC (rev 216407)
@@ -55,8 +55,11 

[webkit-changes] [216406] releases/WebKitGTK/webkit-2.16/Tools

[carlosgc]

Title: [216406] releases/WebKitGTK/webkit-2.16/Tools








Revision 216406
Author carlo...@webkit.org
Date 2017-05-08 06:32:50 -0700 (Mon, 08 May 2017)


Log Message
Merge r216350 - [GTK] Cannot sign in with new Google sign-in page
https://bugs.webkit.org/show_bug.cgi?id=171770

Unreviewed. This just adds a test.

* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):

Modified Paths

releases/WebKitGTK/webkit-2.16/Tools/ChangeLog
releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Tools/ChangeLog (216405 => 216406)

--- releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 13:32:45 UTC (rev 216405)
+++ releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 13:32:50 UTC (rev 216406)
@@ -1,3 +1,13 @@
+2017-05-07  Michael Catanzaro  
+
+[GTK] Cannot sign in with new Google sign-in page
+https://bugs.webkit.org/show_bug.cgi?id=171770
+
+Unreviewed. This just adds a test.
+
+* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+(TestWebKitAPI::TEST):
+
 2017-05-03  Michael Catanzaro  
 
 YouTube user agent quirk breaks new YouTube


Modified: releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (216405 => 216406)

--- releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp	2017-05-08 13:32:45 UTC (rev 216405)
+++ releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp	2017-05-08 13:32:50 UTC (rev 216406)
@@ -87,6 +87,10 @@
 uaString = standardUserAgentForURL(URL(ParsedURLString, "http://www.googleblog.com/"));
 EXPECT_FALSE(uaString.contains("Firefox"));
 
+// Nor should it affect accounts.google.com due to bug #171770.
+uaString = standardUserAgentForURL(URL(ParsedURLString, "http://accounts.google.com/"));
+EXPECT_FALSE(uaString.contains("Firefox"));
+
 assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.com/");
 assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
 assertUserAgentForURLHasChromeBrowserQuirk("http://www.slack.com/");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216405] releases/WebKitGTK/webkit-2.16/Source/WebCore

[carlosgc]

Title: [216405] releases/WebKitGTK/webkit-2.16/Source/WebCore








Revision 216405
Author carlo...@webkit.org
Date 2017-05-08 06:32:45 -0700 (Mon, 08 May 2017)


Log Message
Merge r216343 - [GTK] Cannot sign in with new Google sign-in page
https://bugs.webkit.org/show_bug.cgi?id=171770

Reviewed by Carlos Garcia Campos.

Google's new authentication page does not work with the Firefox user
agent that's required to make various Google websites work. Special-case
accounts.google.com so that it receives our standard user agent.

* platform/UserAgentQuirks.cpp:
(WebCore::isGoogle):
(WebCore::urlRequiresFirefoxBrowser):

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216404 => 216405)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:32:39 UTC (rev 216404)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:32:45 UTC (rev 216405)
@@ -1,3 +1,18 @@
+2017-05-07  Michael Catanzaro  
+
+[GTK] Cannot sign in with new Google sign-in page
+https://bugs.webkit.org/show_bug.cgi?id=171770
+
+Reviewed by Carlos Garcia Campos.
+
+Google's new authentication page does not work with the Firefox user
+agent that's required to make various Google websites work. Special-case
+accounts.google.com so that it receives our standard user agent.
+
+* platform/UserAgentQuirks.cpp:
+(WebCore::isGoogle):
+(WebCore::urlRequiresFirefoxBrowser):
+
 2017-05-03  Michael Catanzaro  
 
 YouTube user agent quirk breaks new YouTube


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp (216404 => 216405)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp	2017-05-08 13:32:39 UTC (rev 216404)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp	2017-05-08 13:32:45 UTC (rev 216405)
@@ -41,8 +41,9 @@
 // Our Google UA is *very* complicated to get right. Read
 // https://webkit.org/b/142074 carefully before changing. Test that Earth
 // view is available in Google Maps. Test Google Calendar. Test downloading
-// the Hangouts browser plugin. Change platformVersionForUAString() to
-// return "FreeBSD amd64" and test Maps and Calendar again.
+// the Hangouts browser plugin. Test logging out and logging in to a Google
+// account. Change platformVersionForUAString() to return "FreeBSD amd64"
+// and test everything again.
 if (baseDomain.startsWith("google."))
 return true;
 if (baseDomain == "gstatic.com")
@@ -75,7 +76,7 @@
 
 static bool urlRequiresFirefoxBrowser(const URL& url)
 {
-return isGoogle(url);
+return isGoogle(url) && url.host() != "accounts.google.com";
 }
 
 static bool urlRequiresMacintoshPlatform(const URL& url)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216404] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216404] releases/WebKitGTK/webkit-2.16








Revision 216404
Author carlo...@webkit.org
Date 2017-05-08 06:32:39 -0700 (Mon, 08 May 2017)


Log Message
Merge r216139 - YouTube user agent quirk breaks new YouTube
https://bugs.webkit.org/show_bug.cgi?id=171603

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
have to remove this quirk.

Note this does not affect Safari as Apple ports don't use our user agent quirks.

* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):

Tools:

Remove the YouTube quirk test.

* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp
releases/WebKitGTK/webkit-2.16/Tools/ChangeLog
releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216403 => 216404)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:22:32 UTC (rev 216403)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:32:39 UTC (rev 216404)
@@ -1,3 +1,19 @@
+2017-05-03  Michael Catanzaro  
+
+YouTube user agent quirk breaks new YouTube
+https://bugs.webkit.org/show_bug.cgi?id=171603
+
+Reviewed by Carlos Garcia Campos.
+
+Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
+attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
+have to remove this quirk.
+
+Note this does not affect Safari as Apple ports don't use our user agent quirks.
+
+* platform/UserAgentQuirks.cpp:
+(WebCore::urlRequiresChromeBrowser):
+
 2017-05-03  Zalan Bujtas  
 
 RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp (216403 => 216404)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp	2017-05-08 13:22:32 UTC (rev 216403)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/UserAgentQuirks.cpp	2017-05-08 13:32:39 UTC (rev 216404)
@@ -66,10 +66,6 @@
 if (baseDomain == "typekit.net" || baseDomain == "typekit.com")
 return true;
 
-// Needed for YouTube 360 with WebKitGTK+ and WPE (requires ENABLE_MEDIA_SOURCE).
-if (baseDomain == "youtube.com")
-return true;
-
 // Slack completely blocks users with WebKitGTK+'s standard user agent.
 if (baseDomain == "slack.com")
 return true;


Modified: releases/WebKitGTK/webkit-2.16/Tools/ChangeLog (216403 => 216404)

--- releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 13:22:32 UTC (rev 216403)
+++ releases/WebKitGTK/webkit-2.16/Tools/ChangeLog	2017-05-08 13:32:39 UTC (rev 216404)
@@ -1,3 +1,15 @@
+2017-05-03  Michael Catanzaro  
+
+YouTube user agent quirk breaks new YouTube
+https://bugs.webkit.org/show_bug.cgi?id=171603
+
+Reviewed by Carlos Garcia Campos.
+
+Remove the YouTube quirk test.
+
+* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+(TestWebKitAPI::TEST):
+
 2017-04-25  Alex Christensen  
 
 REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set


Modified: releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (216403 => 216404)

--- releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp	2017-05-08 13:22:32 UTC (rev 216403)
+++ releases/WebKitGTK/webkit-2.16/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp	2017-05-08 13:32:39 UTC (rev 216404)
@@ -89,7 +89,6 @@
 
 assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.com/");
 assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
-assertUserAgentForURLHasChromeBrowserQuirk("http://www.youtube.com/");
 assertUserAgentForURLHasChromeBrowserQuirk("http://www.slack.com/");
 
 assertUserAgentForURLHasFirefoxBrowserQuirk("http://www.google.com/");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216403] releases/WebKitGTK/webkit-2.16/Source/WebCore

[carlosgc]

Title: [216403] releases/WebKitGTK/webkit-2.16/Source/WebCore








Revision 216403
Author carlo...@webkit.org
Date 2017-05-08 06:22:32 -0700 (Mon, 08 May 2017)


Log Message
Merge r216131 - RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=171608

Reviewed by Simon Fraser.

isTextField() is true for any generic single line text control.

* rendering/RenderObject.h:
(WebCore::RenderObject::isSearchField):
* rendering/RenderSearchField.h:

Modified Paths

releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderObject.h
releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderSearchField.h




Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (216402 => 216403)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:14:54 UTC (rev 216402)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog	2017-05-08 13:22:32 UTC (rev 216403)
@@ -1,3 +1,16 @@
+2017-05-03  Zalan Bujtas  
+
+RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
+https://bugs.webkit.org/show_bug.cgi?id=171608
+
+Reviewed by Simon Fraser.
+
+isTextField() is true for any generic single line text control.
+
+* rendering/RenderObject.h:
+(WebCore::RenderObject::isSearchField):
+* rendering/RenderSearchField.h:
+
 2017-05-03  Daniel Bates  
 
 Abandon the current load once the provisional loader detaches from the frame


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderObject.h (216402 => 216403)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderObject.h	2017-05-08 13:14:54 UTC (rev 216402)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderObject.h	2017-05-08 13:22:32 UTC (rev 216403)
@@ -266,6 +266,7 @@
 virtual bool isTextControl() const { return false; }
 virtual bool isTextArea() const { return false; }
 virtual bool isTextField() const { return false; }
+virtual bool isSearchField() const { return false; }
 virtual bool isTextControlInnerBlock() const { return false; }
 virtual bool isVideo() const { return false; }
 virtual bool isWidget() const { return false; }


Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderSearchField.h (216402 => 216403)

--- releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderSearchField.h	2017-05-08 13:14:54 UTC (rev 216402)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/rendering/RenderSearchField.h	2017-05-08 13:22:32 UTC (rev 216403)
@@ -45,6 +45,8 @@
 void hidePopup();
 
 private:
+bool isSearchField() const final { return true; }
+
 void willBeDestroyed() override;
 void centerContainerIfNeeded(RenderBox*) const override;
 LayoutUnit computeControlLogicalHeight(LayoutUnit lineHeight, LayoutUnit nonContentHeight) const override;
@@ -92,4 +94,4 @@
 
 } // namespace WebCore
 
-SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderSearchField, isTextField())
+SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT(RenderSearchField, isSearchField())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216402] releases/WebKitGTK/webkit-2.16/LayoutTests

[carlosgc]

Title: [216402] releases/WebKitGTK/webkit-2.16/LayoutTests








Revision 216402
Author carlo...@webkit.org
Date 2017-05-08 06:14:54 -0700 (Mon, 08 May 2017)


Log Message
Merge r216126 - Detach frame from document when entering page cache
https://bugs.webkit.org/show_bug.cgi?id=166774


Reviewed by Chris Dumez.

* TestExpectations: Unskip tests.
* fast/history/page-cache-after-window-open-expected.txt: Update expected result.
* fast/history/page-cache-after-window-open.html: Ditto.
* fast/history/page-cache-with-opener-expected.txt: Ditto.
* fast/history/page-cache-with-opener.html: Update test given its new expected behavior.
* fast/history/resources/page-cache-window-with-opener.html: Ditto.
* http/tests/security/xss-DENIED-click-and-form-submission-from-inactive-domwindow-expected.txt: Added.
* http/tests/security/xss-DENIED-click-and-form-submission-from-inactive-domwindow.html: Added.
* http/tests/security/xss-DENIED-script-inject-into-inactive-window-expected.txt: Added.
* http/tests/security/xss-DENIED-script-inject-into-inactive-window.html: Added.
* http/tests/security/xss-DENIED-script-inject-into-inactive-window2-expected.txt: Added.
* http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html: Added.
* http/tests/security/xss-DENIED-script-inject-into-inactive-window3-expected.txt: Added.
* http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/LayoutTests/TestExpectations
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/history/page-cache-after-window-open-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/history/page-cache-after-window-open.html
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/history/page-cache-with-opener-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/history/page-cache-with-opener.html
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/history/resources/page-cache-window-with-opener.html


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/security/xss-DENIED-click-and-form-submission-from-inactive-domwindow-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/security/xss-DENIED-click-and-form-submission-from-inactive-domwindow.html
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window.html
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216401 => 216402)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:10:28 UTC (rev 216401)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:14:54 UTC (rev 216402)
@@ -1,5 +1,28 @@
 2017-05-03  Daniel Bates  
 
+Detach frame from document when entering page cache
+https://bugs.webkit.org/show_bug.cgi?id=166774
+
+
+Reviewed by Chris Dumez.
+
+* TestExpectations: Unskip tests.
+* fast/history/page-cache-after-window-open-expected.txt: Update expected result.
+* fast/history/page-cache-after-window-open.html: Ditto.
+* fast/history/page-cache-with-opener-expected.txt: Ditto.
+* fast/history/page-cache-with-opener.html: Update test given its new expected behavior.
+* fast/history/resources/page-cache-window-with-opener.html: Ditto.
+* http/tests/security/xss-DENIED-click-and-form-submission-from-inactive-domwindow-expected.txt: Added.
+* http/tests/security/xss-DENIED-click-and-form-submission-from-inactive-domwindow.html: Added.
+* http/tests/security/xss-DENIED-script-inject-into-inactive-window-expected.txt: Added.
+* http/tests/security/xss-DENIED-script-inject-into-inactive-window.html: Added.
+* http/tests/security/xss-DENIED-script-inject-into-inactive-window2-expected.txt: Added.
+* http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html: Added.
+* http/tests/security/xss-DENIED-script-inject-into-inactive-window3-expected.txt: Added.
+* http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html: Added.
+
+2017-05-03  Daniel Bates  
+
 Abandon the current load once the provisional loader detaches from the frame
 https://bugs.webkit.org/show_bug.cgi?id=171577
 


Modified: 

[webkit-changes] [216401] releases/WebKitGTK/webkit-2.16

[carlosgc]

Title: [216401] releases/WebKitGTK/webkit-2.16








Revision 216401
Author carlo...@webkit.org
Date 2017-05-08 06:10:28 -0700 (Mon, 08 May 2017)


Log Message
Merge r216120 - Abandon the current load once the provisional loader detaches from the frame
https://bugs.webkit.org/show_bug.cgi?id=171577


Source/WebCore:

Reviewed by Brent Fulgham and Brady Eidson.

We detach all child frames as part of setting our document loader to the provisional
document loader when committing a load for a frame. Detaching child frames invokes
the unload event handler on the child frames that can run arbitrary _javascript_ script.
Among other things, such script can initiate a new load in the frame whose current
load is being committed. We should stop processing the current load as soon as we
detect that updating our document loader has started a new provisional load.

Test: fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):

LayoutTests:

Reviewed by Brent Fulgham.

* fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-expected.txt: Added.
* fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html: Added.

Modified Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.16/Source/WebCore/loader/FrameLoader.cpp


Added Paths

releases/WebKitGTK/webkit-2.16/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-expected.txt
releases/WebKitGTK/webkit-2.16/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html




Diff

Modified: releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog (216400 => 216401)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:05:10 UTC (rev 216400)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/ChangeLog	2017-05-08 13:10:28 UTC (rev 216401)
@@ -1,3 +1,14 @@
+2017-05-03  Daniel Bates  
+
+Abandon the current load once the provisional loader detaches from the frame
+https://bugs.webkit.org/show_bug.cgi?id=171577
+
+
+Reviewed by Brent Fulgham.
+
+* fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-expected.txt: Added.
+* fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html: Added.
+
 2017-05-01  Chris Dumez  
 
 Documents created using DOMParser.parseFromString should inherit their context document's origin / URL


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-expected.txt (0 => 216401)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-expected.txt	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-expected.txt	2017-05-08 13:10:28 UTC (rev 216401)
@@ -0,0 +1,6 @@
+
+
+
+Frame: '-->'
+
+PASS did not crash.


Added: releases/WebKitGTK/webkit-2.16/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html (0 => 216401)

--- releases/WebKitGTK/webkit-2.16/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html	(rev 0)
+++ releases/WebKitGTK/webkit-2.16/LayoutTests/fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash.html	2017-05-08 13:10:28 UTC (rev 216401)
@@ -0,0 +1,21 @@
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.dumpChildFramesAsText();
+testRunner.waitUntilDone();
+}
+var parentFrame = document.body.appendChild(document.createElement("iframe"));
+parentFrame.src = ""
+
+var childFrame = parentFrame.contentDocument.body.appendChild(document.createElement("iframe"));
+childFrame.contentWindow._onunload_ = function () {
+var link = parentFrame.contentDocument.createElement("a");
+link.href = "" did not crash.