[webkit-changes] [216855] trunk/Websites/webkit.org

[jcraig]

Title: [216855] trunk/Websites/webkit.org








Revision 216855
Author jcr...@apple.com
Date 2017-05-14 22:00:08 -0700 (Sun, 14 May 2017)


Log Message
2017-05-14  James Craig  

AX: All the articles on the WebKit blog are called 'Clickable Link' by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=172096


Unreviewed. Fixing broken link titles for screen readers.

* wp-content/themes/webkit/loop.php: Adding relevant link label for accessibility.

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/themes/webkit/loop.php




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (216854 => 216855)

--- trunk/Websites/webkit.org/ChangeLog	2017-05-15 03:45:30 UTC (rev 216854)
+++ trunk/Websites/webkit.org/ChangeLog	2017-05-15 05:00:08 UTC (rev 216855)
@@ -1,3 +1,13 @@
+2017-05-14  James Craig  
+
+AX: All the articles on the WebKit blog are called "Clickable Link" by VoiceOver
+https://bugs.webkit.org/show_bug.cgi?id=172096
+
+
+Unreviewed. Fixing broken link titles for screen readers.
+
+* wp-content/themes/webkit/loop.php: Adding relevant link label for accessibility.
+
 2017-05-08  James Craig  
 
 More demo files for prefers-reduced-motion post


Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/loop.php (216854 => 216855)

--- trunk/Websites/webkit.org/wp-content/themes/webkit/loop.php	2017-05-15 03:45:30 UTC (rev 216854)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/loop.php	2017-05-15 05:00:08 UTC (rev 216855)
@@ -12,7 +12,7 @@
 $classes[] = 'third-tile';
 ?>
 >
-">Clickable link
+">
 
 >
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216854] tags/Safari-604.1.22.0.1/Source/WebCore

[bshafiei]

Title: [216854] tags/Safari-604.1.22.0.1/Source/WebCore








Revision 216854
Author bshaf...@apple.com
Date 2017-05-14 20:45:30 -0700 (Sun, 14 May 2017)


Log Message
Merged r216807.  rdar://problem/32169232

Modified Paths

tags/Safari-604.1.22.0.1/Source/WebCore/ChangeLog
tags/Safari-604.1.22.0.1/Source/WebCore/platform/mac/DragImageMac.mm
tags/Safari-604.1.22.0.1/Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h




Diff

Modified: tags/Safari-604.1.22.0.1/Source/WebCore/ChangeLog (216853 => 216854)

--- tags/Safari-604.1.22.0.1/Source/WebCore/ChangeLog	2017-05-15 03:44:31 UTC (rev 216853)
+++ tags/Safari-604.1.22.0.1/Source/WebCore/ChangeLog	2017-05-15 03:45:30 UTC (rev 216854)
@@ -1,3 +1,19 @@
+2017-05-14  Babak Shafiei  
+
+Merge r216807.
+
+2017-05-12  Timothy Horton  
+
+Don't use LinkPresentation URL shortening if it's not available
+https://bugs.webkit.org/show_bug.cgi?id=172064
+
+
+Rubber-stamped by Wenson Hsieh.
+
+* platform/mac/DragImageMac.mm:
+(WebCore::LinkImageLayout::LinkImageLayout):
+* platform/spi/cocoa/LinkPresentationSPI.h:
+
 2017-05-10  Andy Estes  
 
 REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html


Modified: tags/Safari-604.1.22.0.1/Source/WebCore/platform/mac/DragImageMac.mm (216853 => 216854)

--- tags/Safari-604.1.22.0.1/Source/WebCore/platform/mac/DragImageMac.mm	2017-05-15 03:44:31 UTC (rev 216853)
+++ tags/Safari-604.1.22.0.1/Source/WebCore/platform/mac/DragImageMac.mm	2017-05-15 03:45:30 UTC (rev 216854)
@@ -45,7 +45,7 @@
 #import "URL.h"
 #import 
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
 SOFT_LINK_PRIVATE_FRAMEWORK(LinkPresentation)
 #endif
 
@@ -196,7 +196,7 @@
 NSURL *cocoaURL = url;
 NSString *absoluteURLString = [cocoaURL absoluteString];
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
 LinkPresentationLibrary();
 NSString *domain = [cocoaURL _lp_simplifiedDisplayString];
 #else


Modified: tags/Safari-604.1.22.0.1/Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h (216853 => 216854)

--- tags/Safari-604.1.22.0.1/Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h	2017-05-15 03:44:31 UTC (rev 216853)
+++ tags/Safari-604.1.22.0.1/Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h	2017-05-15 03:45:30 UTC (rev 216854)
@@ -23,7 +23,7 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
 
 #if USE(APPLE_INTERNAL_SDK)
 
@@ -37,4 +37,4 @@
 
 #endif
 
-#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
+#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216853] tags/Safari-604.1.22.0.1/Source

[bshafiei]

Title: [216853] tags/Safari-604.1.22.0.1/Source








Revision 216853
Author bshaf...@apple.com
Date 2017-05-14 20:44:31 -0700 (Sun, 14 May 2017)


Log Message
Versioning.

Modified Paths

tags/Safari-604.1.22.0.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-604.1.22.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-604.1.22.0.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-604.1.22.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-604.1.22.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-604.1.22.0.1/Source/WebKit/mac/Configurations/Version.xcconfig
tags/Safari-604.1.22.0.1/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-604.1.22.0.1/Source/_javascript_Core/Configurations/Version.xcconfig (216852 => 216853)

--- tags/Safari-604.1.22.0.1/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-15 03:42:03 UTC (rev 216852)
+++ tags/Safari-604.1.22.0.1/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-15 03:44:31 UTC (rev 216853)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.22.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (216852 => 216853)

--- tags/Safari-604.1.22.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-15 03:42:03 UTC (rev 216852)
+++ tags/Safari-604.1.22.0.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-15 03:44:31 UTC (rev 216853)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.22.0.1/Source/WebCore/Configurations/Version.xcconfig (216852 => 216853)

--- tags/Safari-604.1.22.0.1/Source/WebCore/Configurations/Version.xcconfig	2017-05-15 03:42:03 UTC (rev 216852)
+++ tags/Safari-604.1.22.0.1/Source/WebCore/Configurations/Version.xcconfig	2017-05-15 03:44:31 UTC (rev 216853)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.22.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig (216852 => 216853)

--- tags/Safari-604.1.22.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-15 03:42:03 UTC (rev 216852)
+++ tags/Safari-604.1.22.0.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-15 03:44:31 UTC (rev 216853)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-604.1.22.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig (216852 => 216853)

--- tags/Safari-604.1.22.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-15 03:42:03 UTC (rev 216852)
+++ tags/Safari-604.1.22.0.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-15 03:44:31 UTC (rev 216853)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 22;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-604.1.22.0.1/Source/WebKit/mac/Configurations/Version.xcconfig (216852 => 216853)

--- tags/Safari-604.1.22.0.1/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-15 03:42:03 UTC (rev 216852)
+++ tags/Safari-604.1.22.0.1/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-15 03:44:31 

[webkit-changes] [216852] tags/Safari-604.1.22.0.1/

[bshafiei]

Title: [216852] tags/Safari-604.1.22.0.1/








Revision 216852
Author bshaf...@apple.com
Date 2017-05-14 20:42:03 -0700 (Sun, 14 May 2017)


Log Message
New tag.

Added Paths

tags/Safari-604.1.22.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216851] trunk

[weinig]

Title: [216851] trunk








Revision 216851
Author wei...@apple.com
Date 2017-05-14 18:09:48 -0700 (Sun, 14 May 2017)


Log Message
[WebIDL/DOM] Remove need for custom bindings for HTMLAllCollection and bring up to spec
https://bugs.webkit.org/show_bug.cgi?id=172095

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt:
Update results.

Source/WebCore:

- Adds support for the legacycaller WebIDL special annotation.
- Updates implementation of HTMLAllCollection to match the current HTML spec.

Test: fast/dom/document-all.html

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSHTMLAllCollectionCustom.cpp: Removed.
Removed JSHTMLAllCollectionCustom.cpp

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateInterface):
(AddLegacyCallerOperationIfNeeded):
Before code generation, clone all the legacycaller operations and put them
in their own set, so they can form an overload set.

(AddStringifierOperationIfNeeded):
Use IDLParser::cloneType as the FIXME suggested.

(GenerateHeader):
Group call related functionality together and use new IsCallable predicate.

(GenerateOverloadedFunctionOrConstructor):
Generalize a little bit to allow the function being overloaded to be an overloaded legacycaller.

(GenerateImplementation):
Add call to generate the legacycaller code.

(GenerateLegacyCallerDefinitions):
(GenerateLegacyCallerDefinition):
Generate the legacycaller definition, using GenerateArgumentsCountCheck, GenerateParametersCheck
and GenerateImplementationFunctionCall to do all the heavy lifting.

(IsCallable):
Add helper predicate for both custom calls and legacycaller.

* bindings/scripts/IDLParser.pm:
(cloneType):.
(cloneArgument):.
(cloneOperation):
Add cloning functions for IDLArgument and IDLOperation, and make IDLType's
clone feasible for calling outside the package by removing the unneeded 
self parameter.

* bindings/scripts/test/JS/JSTestObj.cpp
* bindings/scripts/test/JS/JSTestObj.h
* bindings/scripts/test/TestObj.idl:
Add testing of legacycaller overloading.

* dom/Document.cpp:
(WebCore::Document::allFilteredByName):
* dom/Document.h:
Add new collection access for the HTMLAllNamedSubCollection.

* html/CachedHTMLCollection.h:
(WebCore::nameShouldBeVisibleInDocumentAll):
Update list of tags to match the current spec.

* html/CollectionType.h:
Add new type for HTMLAllNamedSubCollection.

* html/GenericCachedHTMLCollection.cpp:
(WebCore::GenericCachedHTMLCollection::elementMatches):
Specify that DocumentAllNamedItems does not want
the default elementMatches.
 
* html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::namedOrIndexedItemOrItems):
(WebCore::HTMLAllCollection::namedItemOrItems):
(WebCore::HTMLAllNamedSubCollection::~HTMLAllNamedSubCollection):
(WebCore::HTMLAllNamedSubCollection::elementMatches):
* html/HTMLAllCollection.h:
Move implementations from the custom binding, and re-implement to
match the spec. Alternate names to item/namedItem were needed to not
shadow the existing ones in HTMLCollection. HTMLAllNamedSubCollection
is a simple HTMLCollection that matches on a name, following the rules
of document.all about which tags can have name attributes.

* html/HTMLAllCollection.idl:
Remove custom annotations and add legacycaller which is now supported.

* html/HTMLCollection.cpp:
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::~HTMLCollection):
Add DocumentAllNamedItems.

LayoutTests:

* fast/dom/collection-null-like-arguments-expected.txt:
Update results.

* fast/dom/document-all-expected.txt: Added.
* fast/dom/document-all.html: Added.
New test that covers a bunch of missing coverage.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/collection-null-like-arguments-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/html/CachedHTMLCollection.h
trunk/Source/WebCore/html/CollectionType.h
trunk/Source/WebCore/html/GenericCachedHTMLCollection.cpp
trunk/Source/WebCore/html/HTMLAllCollection.cpp
trunk/Source/WebCore/html/HTMLAllCollection.h
trunk/Source/WebCore/html/HTMLAllCollection.idl
trunk/Source/WebCore/html/HTMLCollection.cpp


Added Paths

[webkit-changes] [216850] trunk/Source/WebKit2

[commit-queue]

Title: [216850] trunk/Source/WebKit2








Revision 216850
Author commit-qu...@webkit.org
Date 2017-05-14 17:46:51 -0700 (Sun, 14 May 2017)


Log Message
[CoordinatedGraphics] Remove unused files and lines
https://bugs.webkit.org/show_bug.cgi?id=172080

Patch by Daewoong Jang  on 2017-05-14
Reviewed by Darin Adler.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: Removed.
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h: Removed.
* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Removed.
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h: Removed.
* UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h: Removed.
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in: Removed.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp


Removed Paths

trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h
trunk/Source/WebKit2/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp
trunk/Source/WebKit2/Shared/CoordinatedGraphics/WebCoordinatedSurface.h
trunk/Source/WebKit2/UIProcess/CoordinatedGraphics/
trunk/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216849 => 216850)

--- trunk/Source/WebKit2/ChangeLog	2017-05-14 21:16:42 UTC (rev 216849)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-15 00:46:51 UTC (rev 216850)
@@ -1,3 +1,19 @@
+2017-05-14  Daewoong Jang  
+
+[CoordinatedGraphics] Remove unused files and lines
+https://bugs.webkit.org/show_bug.cgi?id=172080
+
+Reviewed by Darin Adler.
+
+* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: Removed.
+* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h: Removed.
+* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Removed.
+* Shared/CoordinatedGraphics/WebCoordinatedSurface.h: Removed.
+* UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h: Removed.
+* UIProcess/WebPageProxy.h:
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
+* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in: Removed.
+
 2017-05-14  Andreas Kling  
 
 Always reset the assisted node when the main frame commits a new load.


Deleted: trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp (216849 => 216850)

--- trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp	2017-05-14 21:16:42 UTC (rev 216849)
+++ trunk/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp	2017-05-15 00:46:51 UTC (rev 216850)
@@ -1,936 +0,0 @@
-/*
- * Copyright (C) 2011 Apple Inc. All rights reserved.
- * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
- * Copyright (C) 2012 Company 100, Inc.
- * Copyright (C) 2017 Sony Interactive Entertainment Inc.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "CoordinatedGraphicsArgumentCoders.h"
-
-#if USE(COORDINATED_GRAPHICS)
-#include "WebCoordinatedSurface.h"
-#include "WebCoreArgumentCoders.h"
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 

[webkit-changes] [216849] trunk/Source/WebCore

[zalan]

Title: [216849] trunk/Source/WebCore








Revision 216849
Author za...@apple.com
Date 2017-05-14 14:16:42 -0700 (Sun, 14 May 2017)


Log Message
Remove unused lambda in TextFragmentIterator::TextFragment::split() and cleanup dependencies.
https://bugs.webkit.org/show_bug.cgi?id=172089

Reviewed by David Kilzer.

* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
* rendering/SimpleLineLayoutTextFragmentIterator.h:
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::splitWithHyphen):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/SimpleLineLayout.cpp
trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (216848 => 216849)

--- trunk/Source/WebCore/ChangeLog	2017-05-14 20:10:23 UTC (rev 216848)
+++ trunk/Source/WebCore/ChangeLog	2017-05-14 21:16:42 UTC (rev 216849)
@@ -1,3 +1,16 @@
+2017-05-14  Zalan Bujtas  
+
+Remove unused lambda in TextFragmentIterator::TextFragment::split() and cleanup dependencies.
+https://bugs.webkit.org/show_bug.cgi?id=172089
+
+Reviewed by David Kilzer.
+
+* rendering/SimpleLineLayout.cpp:
+(WebCore::SimpleLineLayout::splitFragmentToFitLine):
+* rendering/SimpleLineLayoutTextFragmentIterator.h:
+(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::split):
+(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragment::splitWithHyphen):
+
 2017-05-13  David Kilzer  
 
 Unused lambda in JSWebKitSubtleCrypto::wrapKey()


Modified: trunk/Source/WebCore/rendering/SimpleLineLayout.cpp (216848 => 216849)

--- trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2017-05-14 20:10:23 UTC (rev 216848)
+++ trunk/Source/WebCore/rendering/SimpleLineLayout.cpp	2017-05-14 21:16:42 UTC (rev 216849)
@@ -696,8 +696,8 @@
 auto rightSideWidth = fragmentToSplit.width() - splitFragmentData.width;
 if (rightSideWidth < 2 * availableWidth)
 rightSideWidth = textFragmentIterator.textWidth(splitFragmentData.position, fragmentToSplit.end(), 0);
-return hyphenPosition ? fragmentToSplit.splitWithHyphen(splitFragmentData.position, splitFragmentData.width, rightSideWidth, textFragmentIterator) :
-fragmentToSplit.split(splitFragmentData.position, splitFragmentData.width, rightSideWidth, textFragmentIterator);
+return hyphenPosition ? fragmentToSplit.splitWithHyphen(splitFragmentData.position, textFragmentIterator.style().hyphenStringWidth,
+splitFragmentData.width, rightSideWidth) : fragmentToSplit.split(splitFragmentData.position, splitFragmentData.width, rightSideWidth);
 }
 
 enum PreWrapLineBreakRule { Preserve, Ignore };


Modified: trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h (216848 => 216849)

--- trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h	2017-05-14 20:10:23 UTC (rev 216848)
+++ trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.h	2017-05-14 21:16:42 UTC (rev 216849)
@@ -69,8 +69,8 @@
 bool hasHyphen() const { return m_hasHyphen; }
 
 bool isEmpty() const { return start() == end() && !isLineBreak(); }
-TextFragment split(unsigned splitPosition, float leftSideWidth, float rightSideWidth, const TextFragmentIterator&);
-TextFragment splitWithHyphen(unsigned hyphenPosition, float leftSideWidth, float rightSideWidth, const TextFragmentIterator&);
+TextFragment split(unsigned splitPosition, float leftSideWidth, float rightSideWidth);
+TextFragment splitWithHyphen(unsigned hyphenPosition, float hyphenStringWidth, float leftSideWidth, float rightSideWidth);
 bool operator==(const TextFragment& other) const
 {
 return m_start == other.m_start
@@ -143,10 +143,9 @@
 bool m_atEndOfSegment { false };
 };
 
-inline TextFragmentIterator::TextFragment TextFragmentIterator::TextFragment::split(unsigned splitPosition, float leftSideWidth,
-float rightSideWidth, const TextFragmentIterator& textFragmentIterator)
+inline TextFragmentIterator::TextFragment TextFragmentIterator::TextFragment::split(unsigned splitPosition, float leftSideWidth, float rightSideWidth)
 {
-auto updateFragmentProperties = [] (TextFragment& fragment, unsigned start, unsigned end, float width)
+auto updateFragmentProperties = [] (TextFragment& fragment, unsigned start, unsigned end, float width)
 {
 fragment.m_start = start;
 fragment.m_end = end;
@@ -162,13 +161,12 @@
 return rightSide;
 }
 
-inline TextFragmentIterator::TextFragment TextFragmentIterator::TextFragment::splitWithHyphen(unsigned hyphenPosition, float leftSideWidth,
-float rightSideWidth, const TextFragmentIterator& textFragmentIterator)
+inline TextFragmentIterator::TextFragment 

[webkit-changes] [216848] branches/safari-604.1.21-branch/Source

[jmarcell]

Title: [216848] branches/safari-604.1.21-branch/Source








Revision 216848
Author jmarc...@apple.com
Date 2017-05-14 13:10:23 -0700 (Sun, 14 May 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig (216847 => 216848)

--- branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-14 19:27:45 UTC (rev 216847)
+++ branches/safari-604.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-05-14 20:10:23 UTC (rev 216848)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (216847 => 216848)

--- branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-14 19:27:45 UTC (rev 216847)
+++ branches/safari-604.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-05-14 20:10:23 UTC (rev 216848)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig (216847 => 216848)

--- branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig	2017-05-14 19:27:45 UTC (rev 216847)
+++ branches/safari-604.1.21-branch/Source/WebCore/Configurations/Version.xcconfig	2017-05-14 20:10:23 UTC (rev 216848)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (216847 => 216848)

--- branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-14 19:27:45 UTC (rev 216847)
+++ branches/safari-604.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-05-14 20:10:23 UTC (rev 216848)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (216847 => 216848)

--- branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-14 19:27:45 UTC (rev 216847)
+++ branches/safari-604.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-05-14 20:10:23 UTC (rev 216848)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig (216847 => 216848)

--- branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-14 19:27:45 UTC (rev 216847)
+++ branches/safari-604.1.21-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2017-05-14 20:10:23 UTC (rev 216848)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig (216847 => 216848)

--- branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-05-14 19:27:45 UTC (rev 216847)
+++ branches/safari-604.1.21-branch/Source/WebKit2/Configurations/Version.xcconfig	2017-05-14 20:10:23 UTC (rev 216848)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
 TINY_VERSION = 21;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___

[webkit-changes] [216847] trunk/Source/WebKit2

[akling]

Title: [216847] trunk/Source/WebKit2








Revision 216847
Author akl...@apple.com
Date 2017-05-14 12:27:45 -0700 (Sun, 14 May 2017)


Log Message
Always reset the assisted node when the main frame commits a new load.
https://bugs.webkit.org/show_bug.cgi?id=172088

Reviewed by Antti Koivisto.

WebPage::m_assistedNode could extend the lifetime of the document it pointed into
if the main frame was navigated while the assisted node was in one of its subframes.
The life-supported document wouldn't be reachable from _javascript_ but nevertheless
would consume memory and other resources.

This patch fixes the issue by always clearing WebPage::m_assistedNode when the main
frame commits a new load.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::resetAssistedNodeForFrame):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216846 => 216847)

--- trunk/Source/WebKit2/ChangeLog	2017-05-14 17:43:39 UTC (rev 216846)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-14 19:27:45 UTC (rev 216847)
@@ -1,3 +1,21 @@
+2017-05-14  Andreas Kling  
+
+Always reset the assisted node when the main frame commits a new load.
+https://bugs.webkit.org/show_bug.cgi?id=172088
+
+Reviewed by Antti Koivisto.
+
+WebPage::m_assistedNode could extend the lifetime of the document it pointed into
+if the main frame was navigated while the assisted node was in one of its subframes.
+The life-supported document wouldn't be reachable from _javascript_ but nevertheless
+would consume memory and other resources.
+
+This patch fixes the issue by always clearing WebPage::m_assistedNode when the main
+frame commits a new load.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::resetAssistedNodeForFrame):
+
 2017-05-14  Csaba Osztrogonác  
 
 Unreviewed Mac cmake buildfix after r216690, just for fun.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (216846 => 216847)

--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2017-05-14 17:43:39 UTC (rev 216846)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2017-05-14 19:27:45 UTC (rev 216847)
@@ -5100,7 +5100,7 @@
 {
 if (!m_assistedNode)
 return;
-if (m_assistedNode->document().frame() == frame->coreFrame()) {
+if (frame->isMainFrame() || m_assistedNode->document().frame() == frame->coreFrame()) {
 #if PLATFORM(IOS)
 send(Messages::WebPageProxy::StopAssistingNode());
 #elif PLATFORM(MAC)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216846] trunk/LayoutTests

[ddkilzer]

Title: [216846] trunk/LayoutTests








Revision 216846
Author ddkil...@apple.com
Date 2017-05-14 10:43:39 -0700 (Sun, 14 May 2017)


Log Message
[iOS/macOS Debug WK2] LayoutTests/imported/w3c/web-platform-tests/webrtc/interfaces.html is a flaky crash due to assertion failure



Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
- Mark test as flaky crash on Debug WK2 builds.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216845 => 216846)

--- trunk/LayoutTests/ChangeLog	2017-05-14 16:36:36 UTC (rev 216845)
+++ trunk/LayoutTests/ChangeLog	2017-05-14 17:43:39 UTC (rev 216846)
@@ -1,5 +1,17 @@
 2017-05-14  David Kilzer  
 
+[iOS/macOS Debug WK2] LayoutTests/imported/w3c/web-platform-tests/webrtc/interfaces.html is a flaky crash due to assertion failure
+
+
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+- Mark test as flaky crash on Debug WK2 builds.
+
+2017-05-14  David Kilzer  
+
 [macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
 
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (216845 => 216846)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-14 16:36:36 UTC (rev 216845)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-05-14 17:43:39 UTC (rev 216846)
@@ -1984,3 +1984,5 @@
 webkit.org/b/171951 [ Debug ] fast/hidpi/filters-and-image-buffer-resolution.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/171957 [ Debug ] fast/animation/request-animation-frame-time-unit.html [ Pass Failure ]
+
+webkit.org/b/172094 [ Debug ] imported/w3c/web-platform-tests/webrtc/interfaces.html [ Pass Crash ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (216845 => 216846)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-14 16:36:36 UTC (rev 216845)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-05-14 17:43:39 UTC (rev 216846)
@@ -324,6 +324,8 @@
 # Video fullscreen is not implemented for mac wk2 in webkittestrunner
 media/media-fullscreen-loop-inline.html [ Skip ]
 
+webkit.org/b/172094 [ Debug ] imported/w3c/web-platform-tests/webrtc/interfaces.html [ Pass Crash ]
+
 ### END OF (1) Classified failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216845] tags/Safari-604.1.21.3/

[matthew_hanson]

Title: [216845] tags/Safari-604.1.21.3/








Revision 216845
Author matthew_han...@apple.com
Date 2017-05-14 09:36:36 -0700 (Sun, 14 May 2017)


Log Message
Tag Safari-604.1.21.3.

Added Paths

tags/Safari-604.1.21.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216844] trunk/Source/WebKit2

[ossy]

Title: [216844] trunk/Source/WebKit2








Revision 216844
Author o...@webkit.org
Date 2017-05-14 06:27:10 -0700 (Sun, 14 May 2017)


Log Message
Unreviewed Mac cmake buildfix after r216690, just for fun.

* PlatformMac.cmake:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformMac.cmake




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216843 => 216844)

--- trunk/Source/WebKit2/ChangeLog	2017-05-14 11:28:21 UTC (rev 216843)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-14 13:27:10 UTC (rev 216844)
@@ -1,3 +1,9 @@
+2017-05-14  Csaba Osztrogonác  
+
+Unreviewed Mac cmake buildfix after r216690, just for fun.
+
+* PlatformMac.cmake:
+
 2017-05-14  David Kilzer  
 
 Fix unused lambdas in WebKit2


Modified: trunk/Source/WebKit2/PlatformMac.cmake (216843 => 216844)

--- trunk/Source/WebKit2/PlatformMac.cmake	2017-05-14 11:28:21 UTC (rev 216843)
+++ trunk/Source/WebKit2/PlatformMac.cmake	2017-05-14 13:27:10 UTC (rev 216844)
@@ -265,6 +265,7 @@
 UIProcess/Cocoa/WebPasteboardProxyCocoa.mm
 UIProcess/Cocoa/WebProcessPoolCocoa.mm
 UIProcess/Cocoa/WebProcessProxyCocoa.mm
+UIProcess/Cocoa/WebResourceLoadStatisticsManagerCocoa.mm
 UIProcess/Cocoa/WebResourceLoadStatisticsStoreCocoa.mm
 UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm
 UIProcess/Cocoa/WebViewImpl.mm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216843] trunk/LayoutTests

[ddkilzer]

Title: [216843] trunk/LayoutTests








Revision 216843
Author ddkil...@apple.com
Date 2017-05-14 04:28:21 -0700 (Sun, 14 May 2017)


Log Message
[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)


Unreviewed test gardening.

* platform/ios-wk1/TestExpectations:
- This only times out on Release builds.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216842 => 216843)

--- trunk/LayoutTests/ChangeLog	2017-05-14 11:16:38 UTC (rev 216842)
+++ trunk/LayoutTests/ChangeLog	2017-05-14 11:28:21 UTC (rev 216843)
@@ -5,6 +5,16 @@
 
 Unreviewed test gardening.
 
+* platform/ios-wk1/TestExpectations:
+- This only times out on Release builds.
+
+2017-05-14  David Kilzer  
+
+[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
+
+
+Unreviewed test gardening.
+
 See also Bug 169211 for a similar GTK WK1 timeout.
 
 * platform/ios-wk1/TestExpectations:


Modified: trunk/LayoutTests/platform/ios-wk1/TestExpectations (216842 => 216843)

--- trunk/LayoutTests/platform/ios-wk1/TestExpectations	2017-05-14 11:16:38 UTC (rev 216842)
+++ trunk/LayoutTests/platform/ios-wk1/TestExpectations	2017-05-14 11:28:21 UTC (rev 216843)
@@ -1887,4 +1887,4 @@
 # This was a WK2-only fix.
 http/tests/css/filters-on-iframes.html [ Skip ]
 
-webkit.org/b/172092 fast/parser/adoption-agency-unload-iframe-4.html [ Timeout ]
+webkit.org/b/172092 [ Release ] fast/parser/adoption-agency-unload-iframe-4.html [ Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216842] trunk/LayoutTests

[ddkilzer]

Title: [216842] trunk/LayoutTests








Revision 216842
Author ddkil...@apple.com
Date 2017-05-14 04:16:38 -0700 (Sun, 14 May 2017)


Log Message
[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)


Unreviewed test gardening.

See also Bug 169211 for a similar GTK WK1 timeout.

* platform/ios-wk1/TestExpectations:
- Mark as always timing out on all builds.
* platform/mac-wk1/TestExpectations:
- Mark flaky on Debug builds.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (216841 => 216842)

--- trunk/LayoutTests/ChangeLog	2017-05-14 10:41:40 UTC (rev 216841)
+++ trunk/LayoutTests/ChangeLog	2017-05-14 11:16:38 UTC (rev 216842)
@@ -1,3 +1,17 @@
+2017-05-14  David Kilzer  
+
+[macOS Debug WK1] fast/parser/adoption-agency-unload-iframe-4.html is a flaky timeout (always on iOS 10 Release WK1)
+
+
+Unreviewed test gardening.
+
+See also Bug 169211 for a similar GTK WK1 timeout.
+
+* platform/ios-wk1/TestExpectations:
+- Mark as always timing out on all builds.
+* platform/mac-wk1/TestExpectations:
+- Mark flaky on Debug builds.
+
 2017-05-13  Eric Carlson  
 
 [MediaStream] deviceId constraint doesn't work with getUserMedia


Modified: trunk/LayoutTests/platform/ios-wk1/TestExpectations (216841 => 216842)

--- trunk/LayoutTests/platform/ios-wk1/TestExpectations	2017-05-14 10:41:40 UTC (rev 216841)
+++ trunk/LayoutTests/platform/ios-wk1/TestExpectations	2017-05-14 11:16:38 UTC (rev 216842)
@@ -1886,3 +1886,5 @@
 
 # This was a WK2-only fix.
 http/tests/css/filters-on-iframes.html [ Skip ]
+
+webkit.org/b/172092 fast/parser/adoption-agency-unload-iframe-4.html [ Timeout ]


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (216841 => 216842)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-14 10:41:40 UTC (rev 216841)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-05-14 11:16:38 UTC (rev 216842)
@@ -60,6 +60,8 @@
 
 webkit.org/b/155067 storage/indexeddb/transaction-abort-private.html [ Pass Crash ]
 
+webkit.org/b/172092 [ Debug ] fast/parser/adoption-agency-unload-iframe-4.html [ Pass Timeout ]
+
 ### END OF (1) Failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216841] trunk/Source/WebKit2

[ddkilzer]

Title: [216841] trunk/Source/WebKit2








Revision 216841
Author ddkil...@apple.com
Date 2017-05-14 03:41:40 -0700 (Sun, 14 May 2017)


Log Message
Fix unused lambdas in WebKit2


Reviewed by Chris Dumez.

Fixes unused lambda warnings found with newer clang.

* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
* NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::Statistics::initialize):
- Use UNUSED_PARAM() to silence unused lambda warning since
  'startTime' is used in Debug builds.

* NetworkProcess/capture/NetworkCaptureManager.cpp:
(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
- Remove unused 'this' from lambda capture.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
- Use UNUSED_PARAM() to silence unused lambda warning since
  'taskIdentifier' is used in Debug builds.

* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate):
- Remove unused 'this' from lambda captures.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
- Remove unused 'fetchOptions' from lambda capture.
(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):
- Remove unused 'this' from lambda capture.

* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::forceRepaintIfNeeded):
- Remove unused 'this' from lambda capture.

* WebProcess/cocoa/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::didExitFullscreen):
- Remove unused 'this' from nested lambda captures.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStatistics.cpp
trunk/Source/WebKit2/NetworkProcess/capture/NetworkCaptureManager.cpp
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm
trunk/Source/WebKit2/WebProcess/cocoa/WebVideoFullscreenManager.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (216840 => 216841)

--- trunk/Source/WebKit2/ChangeLog	2017-05-14 08:18:51 UTC (rev 216840)
+++ trunk/Source/WebKit2/ChangeLog	2017-05-14 10:41:40 UTC (rev 216841)
@@ -1,3 +1,50 @@
+2017-05-14  David Kilzer  
+
+Fix unused lambdas in WebKit2
+
+
+Reviewed by Chris Dumez.
+
+Fixes unused lambda warnings found with newer clang.
+
+* NetworkProcess/cache/NetworkCache.cpp:
+(WebKit::NetworkCache::Cache::retrieve):
+* NetworkProcess/cache/NetworkCacheStatistics.cpp:
+(WebKit::NetworkCache::Statistics::initialize):
+- Use UNUSED_PARAM() to silence unused lambda warning since
+  'startTime' is used in Debug builds.
+
+* NetworkProcess/capture/NetworkCaptureManager.cpp:
+(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
+- Remove unused 'this' from lambda capture.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
+(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):
+(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
+(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
+- Use UNUSED_PARAM() to silence unused lambda warning since
+  'taskIdentifier' is used in Debug builds.
+
+* UIProcess/WebResourceLoadStatisticsStore.cpp:
+(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
+(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate):
+- Remove unused 'this' from lambda captures.
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::fetchData):
+- Remove unused 'fetchOptions' from lambda capture.
+(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):
+- Remove unused 'this' from lambda capture.
+
+* UIProcess/mac/ViewGestureControllerMac.mm:
+(WebKit::ViewGestureController::forceRepaintIfNeeded):
+- Remove unused 'this' from lambda capture.
+
+* WebProcess/cocoa/WebVideoFullscreenManager.mm:
+(WebKit::WebVideoFullscreenManager::didExitFullscreen):
+- Remove unused 'this' 

[webkit-changes] [216840] trunk/Websites/perf.webkit.org

[rniwa]

Title: [216840] trunk/Websites/perf.webkit.org








Revision 216840
Author rn...@webkit.org
Date 2017-05-14 01:18:51 -0700 (Sun, 14 May 2017)


Log Message
Build fix. Added a missing null check.

* public/v3/pages/analysis-task-page.js:
(AnalysisTaskConfiguratorPane.prototype.setTestGroups):

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (216839 => 216840)

--- trunk/Websites/perf.webkit.org/ChangeLog	2017-05-14 07:31:49 UTC (rev 216839)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2017-05-14 08:18:51 UTC (rev 216840)
@@ -1,3 +1,10 @@
+2017-05-14  Ryosuke Niwa  
+
+Build fix. Added a missing null check.
+
+* public/v3/pages/analysis-task-page.js:
+(AnalysisTaskConfiguratorPane.prototype.setTestGroups):
+
 2017-05-11  Ryosuke Niwa  
 
 Remove the code for old syncing script configuration in BuildbotSyncer


Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js (216839 => 216840)

--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js	2017-05-14 07:31:49 UTC (rev 216839)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js	2017-05-14 08:18:51 UTC (rev 216840)
@@ -153,7 +153,7 @@
 {
 this._currentGroup = currentGroup;
 const form = this.part('form');
-if (!form.hasCommitSets())
+if (!form.hasCommitSets() && currentGroup)
 form.setConfigurations(currentGroup.test(), currentGroup.platform(), currentGroup.repetitionCount(), currentGroup.requestedCommitSets());
 this.enqueueToRender();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [216839] trunk

[cdumez]

Title: [216839] trunk








Revision 216839
Author cdu...@apple.com
Date 2017-05-14 00:31:49 -0700 (Sun, 14 May 2017)


Log Message
Drop PassRefPtr class from WTF
https://bugs.webkit.org/show_bug.cgi?id=172091

Reviewed by Alex Christensen.

Source/WTF:

Drop PassRefPtr class from WTF as it is no longer used or needed.
Also drop RefPtr::release() for the same reasons.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/CrossThreadCopier.cpp:
* wtf/CrossThreadCopier.h:
* wtf/Forward.h:
* wtf/PassRefPtr.h: Removed.
* wtf/RefPtr.h:
(WTF::refIfNotNull):
(WTF::derefIfNotNull):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::release): Deleted.
* wtf/SizeLimits.cpp:
* wtf/Vector.h:

Tools:

Drop API test coverage.

* TestWebKitAPI/Tests/WTF/Ref.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::passWithPassRefPtr): Deleted.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WTF/wtf/CrossThreadCopier.cpp
trunk/Source/WTF/wtf/CrossThreadCopier.h
trunk/Source/WTF/wtf/Forward.h
trunk/Source/WTF/wtf/RefPtr.h
trunk/Source/WTF/wtf/SizeLimits.cpp
trunk/Source/WTF/wtf/Vector.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Ref.cpp


Removed Paths

trunk/Source/WTF/wtf/PassRefPtr.h




Diff

Modified: trunk/Source/WTF/ChangeLog (216838 => 216839)

--- trunk/Source/WTF/ChangeLog	2017-05-14 06:05:17 UTC (rev 216838)
+++ trunk/Source/WTF/ChangeLog	2017-05-14 07:31:49 UTC (rev 216839)
@@ -1,3 +1,27 @@
+2017-05-14  Chris Dumez  
+
+Drop PassRefPtr class from WTF
+https://bugs.webkit.org/show_bug.cgi?id=172091
+
+Reviewed by Alex Christensen.
+
+Drop PassRefPtr class from WTF as it is no longer used or needed.
+Also drop RefPtr::release() for the same reasons.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/CMakeLists.txt:
+* wtf/CrossThreadCopier.cpp:
+* wtf/CrossThreadCopier.h:
+* wtf/Forward.h:
+* wtf/PassRefPtr.h: Removed.
+* wtf/RefPtr.h:
+(WTF::refIfNotNull):
+(WTF::derefIfNotNull):
+(WTF::RefPtr::RefPtr):
+(WTF::RefPtr::release): Deleted.
+* wtf/SizeLimits.cpp:
+* wtf/Vector.h:
+
 2017-05-13  Chris Dumez  
 
 Stop using RefPtr::release()


Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (216838 => 216839)

--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2017-05-14 06:05:17 UTC (rev 216838)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2017-05-14 07:31:49 UTC (rev 216839)
@@ -444,7 +444,6 @@
 		A8A472E5151A825B004123FF /* PageReservation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PageReservation.h; sourceTree = ""; };
 		A8A472E6151A825B004123FF /* ParallelJobs.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ParallelJobs.h; sourceTree = ""; };
 		A8A472E9151A825B004123FF /* ParallelJobsLibdispatch.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ParallelJobsLibdispatch.h; sourceTree = ""; };
-		A8A472ED151A825B004123FF /* PassRefPtr.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PassRefPtr.h; sourceTree = ""; };
 		A8A472FB151A825B004123FF /* RandomNumber.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RandomNumber.cpp; sourceTree = ""; };
 		A8A472FC151A825B004123FF /* RandomNumber.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RandomNumber.h; sourceTree = ""; };
 		A8A472FD151A825B004123FF /* RandomNumberSeed.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RandomNumberSeed.h; sourceTree = ""; };
@@ -877,7 +876,6 @@
 0FEB3DD01BB7366B009D7AAD /* ParallelVectorIterator.h */,
 0F824A641B7443A0002E345D /* ParkingLot.cpp */,
 0F824A651B7443A0002E345D /* ParkingLot.h */,
-A8A472ED151A825B004123FF /* PassRefPtr.h */,
 A876DBD7151816E500DADB95 /* Platform.h */,
 E3200AB41E9A536D003B59D2 /* PlatformRegisters.h */,
 DCEE21FE1CEA7551000C2396 /* PlatformUserPreferredLanguages.h */,


Modified: trunk/Source/WTF/wtf/CMakeLists.txt (216838 => 216839)

--- trunk/Source/WTF/wtf/CMakeLists.txt	2017-05-14 06:05:17 UTC (rev 216838)
+++ trunk/Source/WTF/wtf/CMakeLists.txt	2017-05-14 07:31:49 UTC (rev 216839)
@@ -95,7 +95,6 @@
 ParallelJobsOpenMP.h
 ParallelVectorIterator.h
 ParkingLot.h
-PassRefPtr.h
 Platform.h
 PlatformRegisters.h
 PrintStream.h


Modified: trunk/Source/WTF/wtf/CrossThreadCopier.cpp (216838 => 216839)

--- trunk/Source/WTF/wtf/CrossThreadCopier.cpp	2017-05-14 06:05:17 UTC (rev 216838)
+++ trunk/Source/WTF/wtf/CrossThreadCopier.cpp	2017-05-14 07:31:49 UTC (rev 216839)
@@ -43,17 +43,12 @@
 };
 
 COMPILE_ASSERT((std::is_same<
-PassRefPtr,
-   

[webkit-changes] [216838] trunk/Source/WebCore

[ddkilzer]

Title: [216838] trunk/Source/WebCore








Revision 216838
Author ddkil...@apple.com
Date 2017-05-13 23:05:17 -0700 (Sat, 13 May 2017)


Log Message
Unused lambda in JSWebKitSubtleCrypto::wrapKey()


Reviewed by Chris Dumez.

Fixes the following warning with newer clang:

Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp:594:35: error: lambda capture 'keyFormat' is not used [-Werror,-Wunused-lambda-capture]
auto exportSuccessCallback = [keyFormat, algorithm, parameters, wrappingKey, wrapper](const Vector& exportedKeyData) mutable {
  ^

* bindings/js/JSWebKitSubtleCryptoCustom.cpp:
(WebCore::JSWebKitSubtleCrypto::wrapKey): Remove unused lambda.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (216837 => 216838)

--- trunk/Source/WebCore/ChangeLog	2017-05-14 05:37:52 UTC (rev 216837)
+++ trunk/Source/WebCore/ChangeLog	2017-05-14 06:05:17 UTC (rev 216838)
@@ -1,3 +1,19 @@
+2017-05-13  David Kilzer  
+
+Unused lambda in JSWebKitSubtleCrypto::wrapKey()
+
+
+Reviewed by Chris Dumez.
+
+Fixes the following warning with newer clang:
+
+Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp:594:35: error: lambda capture 'keyFormat' is not used [-Werror,-Wunused-lambda-capture]
+auto exportSuccessCallback = [keyFormat, algorithm, parameters, wrappingKey, wrapper](const Vector& exportedKeyData) mutable {
+  ^
+
+* bindings/js/JSWebKitSubtleCryptoCustom.cpp:
+(WebCore::JSWebKitSubtleCrypto::wrapKey): Remove unused lambda.
+
 2017-05-13  Eric Carlson  
 
 [MediaStream] deviceId constraint doesn't work with getUserMedia


Modified: trunk/Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp (216837 => 216838)

--- trunk/Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp	2017-05-14 05:37:52 UTC (rev 216837)
+++ trunk/Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp	2017-05-14 06:05:17 UTC (rev 216838)
@@ -591,7 +591,7 @@
 RefPtr wrapper = createDeferredPromise(state, domWindow());
 auto promise = wrapper->promise();
 
-auto exportSuccessCallback = [keyFormat, algorithm, parameters, wrappingKey, wrapper](const Vector& exportedKeyData) mutable {
+auto exportSuccessCallback = [algorithm, parameters, wrappingKey, wrapper](const Vector& exportedKeyData) mutable {
 auto encryptSuccessCallback = [wrapper](const Vector& encryptedData) mutable {
 fulfillPromiseWithArrayBuffer(wrapper.releaseNonNull(), encryptedData.data(), encryptedData.size());
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes