[webkit-changes] [220125] trunk/Tools
Title: [220125] trunk/Tools Revision 220125 Author o...@webkit.org Date 2017-08-01 23:45:23 -0700 (Tue, 01 Aug 2017) Log Message Enabling uploading archives to S3 https://bugs.webkit.org/show_bug.cgi?id=174198 Unreviewed unit test fix after r219235. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py (220124 => 220125) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2017-08-02 06:40:39 UTC (rev 220124) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py 2017-08-02 06:45:23 UTC (rev 220125) @@ -406,12 +406,12 @@ expected_build_steps = { 'Apple Win 7 Debug (Tests)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile', 'download-built-product', 'extract-built-product', 'jscore-test', 'layout-test', 'run-api-tests', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand'], 'Apple Win 7 Release (Tests)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile', 'download-built-product', 'extract-built-product', 'jscore-test', 'layout-test', 'run-api-tests', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand'], -'Apple Win Debug (Build)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile', 'compile-webkit', 'archive-built-product', 'upload', 'trigger'], -'Apple Win Release (Build)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile', 'compile-webkit', 'archive-built-product', 'upload', 'trigger'], +'Apple Win Debug (Build)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'], +'Apple Win Release (Build)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'], 'Apple El Capitan 32-bit JSC (BuildAndTest)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'webkit-32bit-jsc-test'], 'Apple El Capitan CMake Debug (Build)' :['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit'], -'Apple El Capitan Debug (Build)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'archive-built-product', 'upload', 'trigger'], +'Apple El Capitan Debug (Build)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'archive-built-product', 'upload', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'], 'Apple El Capitan Debug JSC (Tests)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'jscore-test'], 'Apple El Capitan Debug Test262 (Tests)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'test262-test'], 'Apple El Capitan Debug WK1 (Tests)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'layout-test', 'run-api-tests', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand'], @@ -418,7 +418,7 @@ 'Apple El Capitan Debug WK2 (Tests)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'layout-test', 'run-api-tests', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand'], 'Apple El Capitan LLINT CLoop (BuildAndTest)' : ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'compile-webkit', 'webkit-jsc-cloop-test'], 'Apple El Capitan Release (32-bit Build)' : ['config
[webkit-changes] [220124] trunk/Source/WebCore
Title: [220124] trunk/Source/WebCore Revision 220124 Author commit-qu...@webkit.org Date 2017-08-01 23:40:39 -0700 (Tue, 01 Aug 2017) Log Message CFString leak dragging an image - allocation under PlatformPasteboard::writeObjectRepresentations https://bugs.webkit.org/show_bug.cgi?id=175064 Patch by Joseph Pecoraro on 2017-08-01 Reviewed by Tim Horton. * platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::writeObjectRepresentations): Adopt a created string into the RetainPtr. * platform/ios/WebItemProviderPasteboard.h: * platform/ios/WebItemProviderPasteboard.mm: (-[WebItemProviderRegistrationInfoList dealloc]): Release suggestedName and switch from -strong to -copy. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm Diff Modified: trunk/Source/WebCore/ChangeLog (220123 => 220124) --- trunk/Source/WebCore/ChangeLog 2017-08-02 06:36:55 UTC (rev 220123) +++ trunk/Source/WebCore/ChangeLog 2017-08-02 06:40:39 UTC (rev 220124) @@ -1,3 +1,19 @@ +2017-08-01 Joseph Pecoraro + +CFString leak dragging an image - allocation under PlatformPasteboard::writeObjectRepresentations +https://bugs.webkit.org/show_bug.cgi?id=175064 + +Reviewed by Tim Horton. + +* platform/ios/PlatformPasteboardIOS.mm: +(WebCore::PlatformPasteboard::writeObjectRepresentations): +Adopt a created string into the RetainPtr. + +* platform/ios/WebItemProviderPasteboard.h: +* platform/ios/WebItemProviderPasteboard.mm: +(-[WebItemProviderRegistrationInfoList dealloc]): +Release suggestedName and switch from -strong to -copy. + 2017-08-01 Chris Dumez Unreviewed, update Beacon API status to "In Development". Modified: trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm (220123 => 220124) --- trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm 2017-08-02 06:36:55 UTC (rev 220123) +++ trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm 2017-08-02 06:40:39 UTC (rev 220124) @@ -295,7 +295,7 @@ if (pasteboardImage.resourceData && !pasteboardImage.resourceMIMEType.isEmpty()) { auto utiOrMIMEType = pasteboardImage.resourceMIMEType.createCFString(); if (!UTTypeIsDeclared(utiOrMIMEType.get())) -utiOrMIMEType = UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType, utiOrMIMEType.get(), nil); +utiOrMIMEType = adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType, utiOrMIMEType.get(), nil)); auto imageData = pasteboardImage.resourceData->createNSData(); [itemsToRegister addData:imageData.get() forType:(NSString *)utiOrMIMEType.get()]; Modified: trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h (220123 => 220124) --- trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h 2017-08-02 06:36:55 UTC (rev 220123) +++ trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.h 2017-08-02 06:40:39 UTC (rev 220124) @@ -61,7 +61,7 @@ - (void)addData:(NSData *)data forType:(NSString *)typeIdentifier; @property (nonatomic) CGSize estimatedDisplayedSize; -@property (nonatomic, strong) NSString *suggestedName; +@property (nonatomic, copy) NSString *suggestedName; - (NSUInteger)numberOfItems; - (nullable WebItemProviderRegistrationInfo *)itemAtIndex:(NSUInteger)index; Modified: trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm (220123 => 220124) --- trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm 2017-08-02 06:36:55 UTC (rev 220123) +++ trunk/Source/WebCore/platform/ios/WebItemProviderPasteboard.mm 2017-08-02 06:40:39 UTC (rev 220124) @@ -116,6 +116,12 @@ return self; } +- (void)dealloc +{ +[_suggestedName release]; +[super dealloc]; +} + - (void)addData:(NSData *)data forType:(NSString *)typeIdentifier { [_items addObject:[[[WebItemProviderRegistrationInfo alloc] initWithRepresentingObject:nil typeIdentifier:typeIdentifier data:data] autorelease]]; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220123] trunk/Tools
Title: [220123] trunk/Tools Revision 220123 Author o...@webkit.org Date 2017-08-01 23:36:55 -0700 (Tue, 01 Aug 2017) Log Message Fix JSCOnly ARM buildbots after r220047 https://bugs.webkit.org/show_bug.cgi?id=174993 Unreviewed fix after r220087. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (BuildAndRemoteJSCTestsFactory.__init__): Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (220122 => 220123) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2017-08-02 04:47:45 UTC (rev 220122) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2017-08-02 06:36:55 UTC (rev 220123) @@ -957,7 +957,7 @@ class BuildAndRemoteJSCTestsFactory(Factory): def __init__(self, platform, configuration, architectures, triggers=None, additionalArguments=None, SVNMirror=None): Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, SVNMirror) -self.addStep(CompileJSCOnly()) +self.addStep(CompileJSCOnly(timeout=60*60)) self.addStep(RunRemoteJavaScriptCoreTests(timeout=60*60)) Modified: trunk/Tools/ChangeLog (220122 => 220123) --- trunk/Tools/ChangeLog 2017-08-02 04:47:45 UTC (rev 220122) +++ trunk/Tools/ChangeLog 2017-08-02 06:36:55 UTC (rev 220123) @@ -1,3 +1,13 @@ +2017-08-01 Csaba Osztrogonác + +Fix JSCOnly ARM buildbots after r220047 +https://bugs.webkit.org/show_bug.cgi?id=174993 + +Unreviewed fix after r220087. + +* BuildSlaveSupport/build.webkit.org-config/master.cfg: +(BuildAndRemoteJSCTestsFactory.__init__): + 2017-08-01 Chris Dumez Add initial support for navigator.sendBeacon ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220122] trunk/Source/WebCore
Title: [220122] trunk/Source/WebCore Revision 220122 Author cdu...@apple.com Date 2017-08-01 21:47:45 -0700 (Tue, 01 Aug 2017) Log Message Unreviewed, update Beacon API status to "In Development". * features.json: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/features.json Diff Modified: trunk/Source/WebCore/ChangeLog (220121 => 220122) --- trunk/Source/WebCore/ChangeLog 2017-08-02 04:44:23 UTC (rev 220121) +++ trunk/Source/WebCore/ChangeLog 2017-08-02 04:47:45 UTC (rev 220122) @@ -1,5 +1,11 @@ 2017-08-01 Chris Dumez +Unreviewed, update Beacon API status to "In Development". + +* features.json: + +2017-08-01 Chris Dumez + Add initial support for navigator.sendBeacon https://bugs.webkit.org/show_bug.cgi?id=175007 Modified: trunk/Source/WebCore/features.json (220121 => 220122) --- trunk/Source/WebCore/features.json 2017-08-02 04:44:23 UTC (rev 220121) +++ trunk/Source/WebCore/features.json 2017-08-02 04:47:45 UTC (rev 220122) @@ -14,7 +14,7 @@ { "name": "Beacon API", "status": { -"status": "Under Consideration", +"status": "In Development", "enabled-by-default": false }, "url": "https://www.w3.org/TR/beacon/", @@ -23,9 +23,9 @@ "category": "webapps", "description": "Schedules asynchronous and non-blocking data delivery while the current page is unloading to mitigate resource contention for other time-critical requests.", "contact": { -"name": "Jonathan Davis", -"email": "web-evangel...@apple.com", -"twitter": "@jonathandavis" +"name": "Chris Dumez", +"email": "cdu...@apple.com", +"twitter": "@chris_dumez" } }, { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220120] trunk/Tools
Title: [220120] trunk/Tools Revision 220120 Author aakash_j...@apple.com Date 2017-08-01 20:22:15 -0700 (Tue, 01 Aug 2017) Log Message Update Bot Watcher's Dashboard for Buildbot 0.9 https://bugs.webkit.org/show_bug.cgi?id=174777 Reviewed by Daniel Bates. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed. (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store in a dictionary. (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support builder name in the build url. See . * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: (isMultiCodebaseGotRevisionProperty): Adapting to new data format. (parseRevisionProperty): Ditto. (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI. (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types have changed in Buildbot 0.9. (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format. (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, one for build information, another for step information of that build. We need to wait until data from both REST API calls are available. (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data. (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property. (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot. (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now. (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format. (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data. (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format. (BuildbotQueue.prototype.get allIterationsURL): Ditto. (BuildbotQueue.prototype.get overviewURL): Ditto. (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9. (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from Buildbot 0.8 or 0.9. (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format. (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed. (BuildbotQueue.prototype.getIterationID): Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID. (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. Therefore we are fetching information for fixed number of build. Also iterating the loop incrementally since the build data is already reverse sorted. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag. Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (220119 => 220120) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2017-08-02 03:09:57 UTC (rev 220119) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2017-08-02
[webkit-changes] [220117] trunk/Source/WebCore
Title: [220117] trunk/Source/WebCore Revision 220117 Author commit-qu...@webkit.org Date 2017-08-01 18:08:48 -0700 (Tue, 01 Aug 2017) Log Message [WinCairo] Implement Font::platformBoundsForGlyph https://bugs.webkit.org/show_bug.cgi?id=174813 Patch by Fujii Hironori on 2017-08-01 Reviewed by Alex Christensen. Test: fast/text/emphasis.html * platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::Font::platformBoundsForGlyph): Implemented by copying the code from Font::boundsForGDIGlyph(). Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (220116 => 220117) --- trunk/Source/WebCore/ChangeLog 2017-08-02 00:36:05 UTC (rev 220116) +++ trunk/Source/WebCore/ChangeLog 2017-08-02 01:08:48 UTC (rev 220117) @@ -1,3 +1,16 @@ +2017-08-01 Fujii Hironori + +[WinCairo] Implement Font::platformBoundsForGlyph +https://bugs.webkit.org/show_bug.cgi?id=174813 + +Reviewed by Alex Christensen. + +Test: fast/text/emphasis.html + +* platform/graphics/win/SimpleFontDataCairoWin.cpp: +(WebCore::Font::platformBoundsForGlyph): Implemented by copying +the code from Font::boundsForGDIGlyph(). + 2017-08-01 Zalan Bujtas REGRESSION (r217197): New Yorker website hangs for a long time on load, lots of blank tiles Modified: trunk/Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp (220116 => 220117) --- trunk/Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp 2017-08-02 00:36:05 UTC (rev 220116) +++ trunk/Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp 2017-08-02 01:08:48 UTC (rev 220117) @@ -109,8 +109,20 @@ { if (m_platformData.useGDI()) return boundsForGDIGlyph(glyph); -//FIXME: Implement this -return FloatRect(); + +HWndDC dc(0); +SaveDC(dc); +auto scaledFont = m_platformData.scaledFont(); +cairo_win32_scaled_font_select_font(scaledFont, dc); + +GLYPHMETRICS gdiMetrics; +static const MAT2 identity = { 0, 1, 0, 0, 0, 0, 0, 1 }; +GetGlyphOutline(dc, glyph, GGO_METRICS | GGO_GLYPH_INDEX, &gdiMetrics, 0, 0, &identity); + +cairo_win32_scaled_font_done_font(scaledFont); +RestoreDC(dc, -1); +return FloatRect(gdiMetrics.gmptGlyphOrigin.x, -gdiMetrics.gmptGlyphOrigin.y, +gdiMetrics.gmBlackBoxX + m_syntheticBoldOffset, gdiMetrics.gmBlackBoxY); } float Font::platformWidthForGlyph(Glyph glyph) const ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220116] trunk/LayoutTests
Title: [220116] trunk/LayoutTests Revision 220116 Author jlew...@apple.com Date 2017-08-01 17:36:05 -0700 (Tue, 01 Aug 2017) Log Message Added expectations files for El Capitan. https://bugs.webkit.org/show_bug.cgi?id=175061 Unreviewed test gardening. * platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Added. * platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Added. * platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt: Added. * platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Added. * platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt: Added. * platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt: Added. * platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt: Added. * platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/ trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/ trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/ trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/ trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (220115 => 220116) --- trunk/LayoutTests/ChangeLog 2017-08-01 23:31:47 UTC (rev 220115) +++ trunk/LayoutTests/ChangeLog 2017-08-02 00:36:05 UTC (rev 220116) @@ -1,3 +1,19 @@ +2017-08-01 Matt Lewis + +Added expectations files for El Capitan. +https://bugs.webkit.org/show_bug.cgi?id=175061 + +Unreviewed test gardening. + +* platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt: Added. +* platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt: Added. +* platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any-expected.txt: Added. +* platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker-expected.txt: Added. +* platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any-expected.txt: Added. +* platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker-expected.txt: Added. +* platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any-expected.txt: Added. +* platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker-expected.txt: Added. + 2017-08-01 Devin Rousso Web Inspector: create Recording tab for displaying recordings Added: trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt (0 => 220116) --- trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt (rev 0) +++ trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt 2017-08-02 00:36:05 UTC (rev 220116) @@ -0,0 +1,6 @@ + +PASS Fetch ../resources/top.txt with no-cors mode +PASS Fetch http://localhost:8800/fetch/api/resources/top.txt with no-cors mode +PASS Fetch https://localhost:9443/fetch/api/resources/top.txt with no-cors mode +PASS Fetch http://localhost:8801/fetch/api/resources/top.txt with no-cors mode + Added: trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt (0 => 220116) --- trunk/LayoutTests/platform/mac-elcapitan/imported/w3c/web-platform
[webkit-changes] [220115] trunk/Source/WebKit
Title: [220115] trunk/Source/WebKit Revision 220115 Author bb...@apple.com Date 2017-08-01 16:31:47 -0700 (Tue, 01 Aug 2017) Log Message Web Automation: add event to notify service when a page's main frame window object has cleared https://bugs.webkit.org/show_bug.cgi?id=174987 Reviewed by Carlos Garcia Campos. * UIProcess/Automation/Automation.json: Add new event. * UIProcess/Automation/WebAutomationSession.h: * UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::navigationOccurredForFrame): (WebKit::WebAutomationSession::willClosePage): When a WebPage navigates or closes, send the browsingContextCleared event. Any element handles for elements in the browsing context are no longer valid. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Add a new hook into the active automation session so it is notified when a page closes. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Automation/Automation.json trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (220114 => 220115) --- trunk/Source/WebKit/ChangeLog 2017-08-01 23:00:46 UTC (rev 220114) +++ trunk/Source/WebKit/ChangeLog 2017-08-01 23:31:47 UTC (rev 220115) @@ -1,3 +1,24 @@ +2017-08-01 Brian Burg + +Web Automation: add event to notify service when a page's main frame window object has cleared +https://bugs.webkit.org/show_bug.cgi?id=174987 + + +Reviewed by Carlos Garcia Campos. + +* UIProcess/Automation/Automation.json: Add new event. + +* UIProcess/Automation/WebAutomationSession.h: +* UIProcess/Automation/WebAutomationSession.cpp: +(WebKit::WebAutomationSession::navigationOccurredForFrame): +(WebKit::WebAutomationSession::willClosePage): +When a WebPage navigates or closes, send the browsingContextCleared event. +Any element handles for elements in the browsing context are no longer valid. + +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::close): +Add a new hook into the active automation session so it is notified when a page closes. + 2017-08-01 Brady Eidson API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug.. Modified: trunk/Source/WebKit/UIProcess/Automation/Automation.json (220114 => 220115) --- trunk/Source/WebKit/UIProcess/Automation/Automation.json 2017-08-01 23:00:46 UTC (rev 220114) +++ trunk/Source/WebKit/UIProcess/Automation/Automation.json 2017-08-01 23:31:47 UTC (rev 220115) @@ -521,6 +521,13 @@ { "name": "browsingContextHandle", "$ref": "BrowsingContextHandle", "description": "The handle for the browsing context." }, { "name": "selectionCancelled", "type": "boolean", "description": "If true, the chooser was dismissed because file selection was cancelled." } ] +}, +{ +"name": "browsingContextCleared", +"description": "Fired when the specified browsing context has navigated or closed. Existing element references from the browsing context are no longer valid.", +"parameters": [ +{ "name": "browsingContextHandle", "$ref": "BrowsingContextHandle" } +] } ] } Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (220114 => 220115) --- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2017-08-01 23:00:46 UTC (rev 220114) +++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2017-08-01 23:31:47 UTC (rev 220115) @@ -499,6 +499,7 @@ m_loadTimer.stop(); callback->sendSuccess(InspectorObject::create()); } +m_domainNotifier->browsingContextCleared(handleForWebPageProxy(*frame.page())); } else { if (auto callback = m_pendingNavigationInBrowsingContextCallbacksPerFrame.take(frame.frameID())) { m_loadTimer.stop(); @@ -519,6 +520,12 @@ callback->sendSuccess(InspectorObject::create()); } +void WebAutomationSession::willClosePage(const WebPageProxy& page) +{ +String handle = handleForWebPageProxy(page); +m_domainNotifier->browsingContextCleared(handle); +} + void WebAutomationSession::handleRunOpenPanel(const WebPageProxy& page, const WebFrameProxy&, const API::OpenPanelParameters& parameters, WebOpenPanelResultListenerProxy& resultListener) { if (!m_filesToSelectForFileUpload.size()) { Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.h (220114 => 220115) --- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.h 2017-08-01 23:00:46 UTC (rev 220114) +++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.h 2017-08-01 23:31:47 UTC (rev 220115) @@ -96,6 +96,7 @@ void navigationOccurredForFrame(const WebFrameP
[webkit-changes] [220113] trunk/Source/WebCore/PAL
Title: [220113] trunk/Source/WebCore/PAL Revision 220113 Author commit-qu...@webkit.org Date 2017-08-01 15:33:18 -0700 (Tue, 01 Aug 2017) Log Message [PAL][Win] Copy forwarding headers https://bugs.webkit.org/show_bug.cgi?id=175012 Patch by Yoshiaki Jitsukawa on 2017-08-01 Reviewed by Myles C. Maxfield. * pal/PlatformAppleWin.cmake: Added. * pal/PlatformWin.cmake: * pal/PlatformWinCairo.cmake: Added. Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/PlatformWin.cmake Added Paths trunk/Source/WebCore/PAL/pal/PlatformAppleWin.cmake trunk/Source/WebCore/PAL/pal/PlatformWinCairo.cmake Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (220112 => 220113) --- trunk/Source/WebCore/PAL/ChangeLog 2017-08-01 21:42:28 UTC (rev 220112) +++ trunk/Source/WebCore/PAL/ChangeLog 2017-08-01 22:33:18 UTC (rev 220113) @@ -1,3 +1,14 @@ +2017-08-01 Yoshiaki Jitsukawa + +[PAL][Win] Copy forwarding headers +https://bugs.webkit.org/show_bug.cgi?id=175012 + +Reviewed by Myles C. Maxfield. + +* pal/PlatformAppleWin.cmake: Added. +* pal/PlatformWin.cmake: +* pal/PlatformWinCairo.cmake: Added. + 2017-07-26 Brian Burg Remove WEB_TIMING feature flag Added: trunk/Source/WebCore/PAL/pal/PlatformAppleWin.cmake (0 => 220113) --- trunk/Source/WebCore/PAL/pal/PlatformAppleWin.cmake (rev 0) +++ trunk/Source/WebCore/PAL/pal/PlatformAppleWin.cmake 2017-08-01 22:33:18 UTC (rev 220113) @@ -0,0 +1,8 @@ +list(APPEND PAL_FORWARDING_HEADERS_DIRECTORIES +) + +if (${USE_DIRECT2D}) +else () +list(APPEND PAL_FORWARDING_HEADERS_DIRECTORIES +) +endif () Modified: trunk/Source/WebCore/PAL/pal/PlatformWin.cmake (220112 => 220113) --- trunk/Source/WebCore/PAL/pal/PlatformWin.cmake 2017-08-01 21:42:28 UTC (rev 220112) +++ trunk/Source/WebCore/PAL/pal/PlatformWin.cmake 2017-08-01 22:33:18 UTC (rev 220113) @@ -11,10 +11,21 @@ "${CMAKE_BINARY_DIR}/../include/private" ) +list(APPEND PAL_FORWARDING_HEADERS_DIRECTORIES .) + +if (${WTF_PLATFORM_WIN_CAIRO}) +include(PlatformWinCairo.cmake) +else () +include(PlatformAppleWin.cmake) +endif () + set(PAL_OUTPUT_NAME PAL${DEBUG_SUFFIX}) file(MAKE_DIRECTORY ${FORWARDING_HEADERS_DIR}/WebCore/pal) -file(GLOB _files_PAL "${PAL_DIR}/pal/*.h") -foreach (_file ${_files_PAL}) -file(COPY ${_file} DESTINATION ${FORWARDING_HEADERS_DIR}/WebCore/pal/) +foreach (_directory ${PAL_FORWARDING_HEADERS_DIRECTORIES}) +file(MAKE_DIRECTORY ${FORWARDING_HEADERS_DIR}/WebCore/pal/${_directory}) +file(GLOB _files "${PAL_DIR}/pal/${_directory}/*.h") +foreach (_file ${_files}) +file(COPY ${_file} DESTINATION ${FORWARDING_HEADERS_DIR}/WebCore/pal/${_directory}) +endforeach () endforeach () Added: trunk/Source/WebCore/PAL/pal/PlatformWinCairo.cmake (0 => 220113) --- trunk/Source/WebCore/PAL/pal/PlatformWinCairo.cmake (rev 0) +++ trunk/Source/WebCore/PAL/pal/PlatformWinCairo.cmake 2017-08-01 22:33:18 UTC (rev 220113) @@ -0,0 +1,2 @@ +list(APPEND PAL_FORWARDING_HEADERS_DIRECTORIES +) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220112] trunk
Title: [220112] trunk Revision 220112 Author za...@apple.com Date 2017-08-01 14:42:28 -0700 (Tue, 01 Aug 2017) Log Message REGRESSION (r217197): New Yorker website hangs for a long time on load, lots of blank tiles https://bugs.webkit.org/show_bug.cgi?id=175009 Reviewed by Simon Fraser. Source/WebCore: This patch ensures that we report the desktop, non-frame-flattened frame size for media queries in subframes. Some websites don't expect the iframes to be expanded to the size of the content and when the media query callback mutates the content (triggering frame resize), they might end up getting into a never ending layout. Test: fast/frames/flattening/media-query-growing-content.html * css/MediaQueryEvaluator.cpp: (WebCore::orientationEvaluate): (WebCore::aspectRatioEvaluate): (WebCore::heightEvaluate): (WebCore::widthEvaluate): * page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::layoutSizeForMediaQuery const): (WebCore::FrameView::evaluateMediaQueryList): * page/FrameView.h: LayoutTests: * fast/frames/flattening/media-query-growing-content-expected.txt: Added. * fast/frames/flattening/media-query-growing-content.html: Added. * fast/frames/flattening/resources/media-query-min-height-with-flattening.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/MediaQueryEvaluator.cpp trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h Added Paths trunk/LayoutTests/fast/frames/flattening/media-query-growing-content-expected.txt trunk/LayoutTests/fast/frames/flattening/media-query-growing-content.html trunk/LayoutTests/fast/frames/flattening/resources/media-query-min-height-with-flattening.html Diff Modified: trunk/LayoutTests/ChangeLog (220111 => 220112) --- trunk/LayoutTests/ChangeLog 2017-08-01 21:02:37 UTC (rev 220111) +++ trunk/LayoutTests/ChangeLog 2017-08-01 21:42:28 UTC (rev 220112) @@ -1,3 +1,15 @@ +2017-08-01 Zalan Bujtas + +REGRESSION (r217197): New Yorker website hangs for a long time on load, lots of blank tiles +https://bugs.webkit.org/show_bug.cgi?id=175009 + + +Reviewed by Simon Fraser. + +* fast/frames/flattening/media-query-growing-content-expected.txt: Added. +* fast/frames/flattening/media-query-growing-content.html: Added. +* fast/frames/flattening/resources/media-query-min-height-with-flattening.html: Added. + 2017-08-01 Youenn Fablet Layout tests with 'https' suffix should be run over HTTPS Added: trunk/LayoutTests/fast/frames/flattening/media-query-growing-content-expected.txt (0 => 220112) --- trunk/LayoutTests/fast/frames/flattening/media-query-growing-content-expected.txt (rev 0) +++ trunk/LayoutTests/fast/frames/flattening/media-query-growing-content-expected.txt 2017-08-01 21:42:28 UTC (rev 220112) @@ -0,0 +1,2 @@ + + Added: trunk/LayoutTests/fast/frames/flattening/media-query-growing-content.html (0 => 220112) --- trunk/LayoutTests/fast/frames/flattening/media-query-growing-content.html (rev 0) +++ trunk/LayoutTests/fast/frames/flattening/media-query-growing-content.html 2017-08-01 21:42:28 UTC (rev 220112) @@ -0,0 +1,25 @@ + + + +This tests that media query can't get into an ever-growing cycle. + +if (window.testRunner) +testRunner.dumpAsText(); +if (window.internals) +internals.settings.setFrameFlattening("FullyEnabled"); + +function runTest() { +if (window.testRunner) { +testRunner.waitUntilDone(); +setTimeout(function() { +testRunner.notifyDone(); +}, 50); +} +} + + + + + + Added: trunk/LayoutTests/fast/frames/flattening/resources/media-query-min-height-with-flattening.html (0 => 220112) --- trunk/LayoutTests/fast/frames/flattening/resources/media-query-min-height-with-flattening.html (rev 0) +++ trunk/LayoutTests/fast/frames/flattening/resources/media-query-min-height-with-flattening.html 2017-08-01 21:42:28 UTC (rev 220112) @@ -0,0 +1,34 @@ + +div { +width: 200px; +height: 600px; +} + + + +var counter = 0; +window.matchMedia('(min-height: 200px)').addListener(function(changed) { +++counter; +setTimeout(function() { +growingDiv.innerText = growingDiv.innerText + ' media query callback '; +parent.document.getElementById("testResult").innerText = counter; +}, 0); +}); + +window.matchMedia('(min-width: 600px)').addListener(function(changed) { +++counter; +setTimeout(function() { +growingDiv.innerText = growingDiv.innerText + ' media query callback '; +parent.document.getElementById("testResult").innerText = counter; +}, 0); +}); + +window.matchMedia('(min-aspect-ratio: 1/1)').addListener(function(changed) { +++counter; +setTimeout(function() { +growingDiv.innerText = growingDiv.innerText + ' media query callback '; +parent.document.getElementById("te
[webkit-changes] [220111] trunk
Title: [220111] trunk Revision 220111 Author commit-qu...@webkit.org Date 2017-08-01 14:02:37 -0700 (Tue, 01 Aug 2017) Log Message Layout tests with 'https' suffix should be run over HTTPS https://bugs.webkit.org/show_bug.cgi?id=174992 Patch by Youenn Fablet on 2017-08-01 Reviewed by Chris Dumez. Tools: Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them. This covers WPT tests, WPT WebKit tests and HTTP layout tests. Covered by corresponding unit tests. * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: (run_server): * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: (base_http_url): (base_https_url): (base_url): Deleted. * Scripts/webkitpy/port/base.py: (Port.to.web_platform_test_server_base_http_url): (Port.to): (Port.to.web_platform_test_server_base_https_url): (Port.to.web_platform_test_server_base_url): Deleted. * Scripts/webkitpy/port/driver.py: (Driver.__init__): (Driver.wpt_test_path_to_uri): (Driver): (Driver.http_test_path_to_uri): (Driver.test_to_uri): (Driver.uri_to_test): * Scripts/webkitpy/port/driver_unittest.py: (DriverTest.test_test_to_uri): (DriverTest.test_uri_to_test): LayoutTests: Updating test to allow display insecure content as otherwise the test would not complete now that it is run over HTTPS. Adding WK1 expected files as the warning message is not printed. * http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: * http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html: * platform/ios-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Added. * platform/mac-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py trunk/Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py trunk/Tools/Scripts/webkitpy/port/base.py trunk/Tools/Scripts/webkitpy/port/driver.py trunk/Tools/Scripts/webkitpy/port/driver_unittest.py Added Paths trunk/LayoutTests/platform/ios-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt trunk/LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/ trunk/LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/ trunk/LayoutTests/platform/mac-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (220110 => 220111) --- trunk/LayoutTests/ChangeLog 2017-08-01 20:47:21 UTC (rev 220110) +++ trunk/LayoutTests/ChangeLog 2017-08-01 21:02:37 UTC (rev 220111) @@ -1,3 +1,18 @@ +2017-08-01 Youenn Fablet + +Layout tests with 'https' suffix should be run over HTTPS +https://bugs.webkit.org/show_bug.cgi?id=174992 + +Reviewed by Chris Dumez. + +Updating test to allow display insecure content as otherwise the test would not complete now that it is run over HTTPS. +Adding WK1 expected files as the warning message is not printed. + +* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: +* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html: +* platform/ios-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Added. +* platform/mac-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt: Added. + 2017-08-01 Matt Lewis Marked imported/w3c/IndexedDB-private-browsing/idbfactory_open.html as flaky. Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt (220110 => 220111) --- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt 2017-08-01 20:47:21 UTC (rev 220110) +++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https-expected.txt 2017-08-01 21:02:37 UTC (rev 220111) @@ -1,5 +1,7 @@ +CONSOLE MESSAGE: line 1: The page at about:srcdoc was allowed to display insecure content from http://localhost:8000/security/resources/post-origin-to-parent.html. + PASS Same-host frames are upgraded. PASS Cross-host frames are upgraded. PASS Upgrade policy does NOT cascade to nested, cross-host frames. Modified: trunk/LayoutTests/http/tes
[webkit-changes] [220110] trunk/LayoutTests
Title: [220110] trunk/LayoutTests Revision 220110 Author jlew...@apple.com Date 2017-08-01 13:47:21 -0700 (Tue, 01 Aug 2017) Log Message Marked imported/w3c/IndexedDB-private-browsing/idbfactory_open.html as flaky. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (220109 => 220110) --- trunk/LayoutTests/ChangeLog 2017-08-01 20:00:49 UTC (rev 220109) +++ trunk/LayoutTests/ChangeLog 2017-08-01 20:47:21 UTC (rev 220110) @@ -1,3 +1,12 @@ +2017-08-01 Matt Lewis + +Marked imported/w3c/IndexedDB-private-browsing/idbfactory_open.html as flaky. + + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2017-08-01 Zan Dobersek [WebCrypto] Add PKCS#8 import test that covers `parameters` and `publicKey` values in ECPrivateKey Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (220109 => 220110) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-08-01 20:00:49 UTC (rev 220109) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-08-01 20:47:21 UTC (rev 220110) @@ -1955,4 +1955,5 @@ webkit.org/b/171985 [ Release ] workers/bomb.html [ Pass Timeout ] # +imported/w3c/IndexedDB-private-browsing/idbfactory_open.html [ Pass Crash ] webkit.org/b/174949 imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220108] trunk/LayoutTests
Title: [220108] trunk/LayoutTests Revision 220108 Author zandober...@gmail.com Date 2017-08-01 12:18:11 -0700 (Tue, 01 Aug 2017) Log Message [WebCrypto] Add PKCS#8 import test that covers `parameters` and `publicKey` values in ECPrivateKey https://bugs.webkit.org/show_bug.cgi?id=174420 Reviewed by Darin Adler. Add test cases that cover testing of the optional ECParameters and publicKey bit string attributes in the ECPrivateKey ASN.1 structure that's embedded in the PKCS#8 PrivateKeyInfo ASN.1 structure. Per the spec, if the ECParameters attribute in the ECPrivateKey structure is present, the relevant curve object identifier should match the same curve identifier that's used in the ECParameters attribute of the AlgorithmIdentifier structure in PrivateKeyInfo. Both of these should of course match the curve that was specified for the import operation. For the publicKey bit string, the data contained there should be properly formatted for the specific curve, meaning it should be of proper curve-specific size and that it should use 0x04 as the leading byte, signalling an uncompressed EC point. On top of that the public key should have a valid value that positions it on the specified elliptic curve. These cases are covered for PKCS#8 key imports for P-256 and P-384 curves and for both ECDH and ECDSA algorithms in the newly-introduced tests. They are skipped on all platforms since no implementation in WebKit can pass them yet. * TestExpectations: * crypto/subtle/ecdh-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey-expected.txt: Added. * crypto/subtle/ecdh-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey.html: Added. * crypto/subtle/ecdh-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey-expected.txt: Added. * crypto/subtle/ecdh-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey.html: Added. * crypto/subtle/ecdsa-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey-expected.txt: Added. * crypto/subtle/ecdsa-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey.html: Added. * crypto/subtle/ecdsa-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey-expected.txt: Added. * crypto/subtle/ecdsa-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Added Paths trunk/LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey-expected.txt trunk/LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey.html trunk/LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey-expected.txt trunk/LayoutTests/crypto/subtle/ecdh-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey.html trunk/LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey-expected.txt trunk/LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey.html trunk/LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey-expected.txt trunk/LayoutTests/crypto/subtle/ecdsa-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey.html Diff Modified: trunk/LayoutTests/ChangeLog (220107 => 220108) --- trunk/LayoutTests/ChangeLog 2017-08-01 19:03:59 UTC (rev 220107) +++ trunk/LayoutTests/ChangeLog 2017-08-01 19:18:11 UTC (rev 220108) @@ -1,3 +1,38 @@ +2017-08-01 Zan Dobersek + +[WebCrypto] Add PKCS#8 import test that covers `parameters` and `publicKey` values in ECPrivateKey +https://bugs.webkit.org/show_bug.cgi?id=174420 + +Reviewed by Darin Adler. + +Add test cases that cover testing of the optional ECParameters and publicKey bit string +attributes in the ECPrivateKey ASN.1 structure that's embedded in the PKCS#8 PrivateKeyInfo +ASN.1 structure. + +Per the spec, if the ECParameters attribute in the ECPrivateKey structure is present, the +relevant curve object identifier should match the same curve identifier that's used in the +ECParameters attribute of the AlgorithmIdentifier structure in PrivateKeyInfo. Both of these +should of course match the curve that was specified for the import operation. + +For the publicKey bit string, the data contained there should be properly formatted for +the specific curve, meaning it should be of proper curve-specific size and that it should +use 0x04 as the leading byte, signalling an uncompressed EC point. On top of that the public +key should have a valid value that positions it on the specified elliptic curve. + +These cases are covered for PKCS#8 key imports for P-256 and P-384 curves and for both ECDH +and ECDSA algorithms in the newly-introduced tests. They are skipped on all platforms since +no implementation in WebKit can
[webkit-changes] [220107] trunk
Title: [220107] trunk Revision 220107 Author beid...@apple.com Date 2017-08-01 12:03:59 -0700 (Tue, 01 Aug 2017) Log Message API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug.. https://bugs.webkit.org/show_bug.cgi?id=175030 Reviewed by Andy Estes. Source/WebKit: * UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm: (WebKit::WebURLSchemeHandlerCocoa::platformTaskCompleted): Release the API wrapped on the next spin of the runloop. Tools: * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm Diff Modified: trunk/Source/WebKit/ChangeLog (220106 => 220107) --- trunk/Source/WebKit/ChangeLog 2017-08-01 18:50:45 UTC (rev 220106) +++ trunk/Source/WebKit/ChangeLog 2017-08-01 19:03:59 UTC (rev 220107) @@ -1,5 +1,16 @@ 2017-08-01 Brady Eidson +API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug.. +https://bugs.webkit.org/show_bug.cgi?id=175030 + +Reviewed by Andy Estes. + +* UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm: +(WebKit::WebURLSchemeHandlerCocoa::platformTaskCompleted): Release the API wrapped on the next + spin of the runloop. + +2017-08-01 Brady Eidson + Part 2 of: Rename DatabaseProcess to StorageProcess. https://bugs.webkit.org/show_bug.cgi?id=174880 Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm (220106 => 220107) --- trunk/Source/WebKit/UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm 2017-08-01 18:50:45 UTC (rev 220106) +++ trunk/Source/WebKit/UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm 2017-08-01 19:03:59 UTC (rev 220107) @@ -32,6 +32,7 @@ #import "WKURLSchemeTaskInternal.h" #import "WKWebViewInternal.h" #import "WebURLSchemeTask.h" +#import using namespace WebCore; @@ -79,7 +80,9 @@ void WebURLSchemeHandlerCocoa::platformTaskCompleted(WebURLSchemeTask& task) { #if WK_API_ENABLED -m_apiTasks.remove(task.identifier()); +// Release the last reference to this API task on the next spin of the runloop. +RunLoop::main().dispatch([takenTask = m_apiTasks.take(task.identifier())] { +}); #else UNUSED_PARAM(task); #endif Modified: trunk/Tools/ChangeLog (220106 => 220107) --- trunk/Tools/ChangeLog 2017-08-01 18:50:45 UTC (rev 220106) +++ trunk/Tools/ChangeLog 2017-08-01 19:03:59 UTC (rev 220107) @@ -1,5 +1,15 @@ 2017-08-01 Brady Eidson +API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug.. +https://bugs.webkit.org/show_bug.cgi?id=175030 + +Reviewed by Andy Estes. + +* TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: +(-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor. + +2017-08-01 Brady Eidson + Part 2 of: Rename DatabaseProcess to StorageProcess. https://bugs.webkit.org/show_bug.cgi?id=174880 Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm (220106 => 220107) --- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm 2017-08-01 18:50:45 UTC (rev 220106) +++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm 2017-08-01 19:03:59 UTC (rev 220107) @@ -312,7 +312,7 @@ [task didFinish]; break; case Command::Error: -[task didFailWithError:[[[NSError alloc] init] autorelease]]; +[task didFailWithError:[NSError errorWithDomain:@"WebKit" code:1 userInfo:nil]]; break; } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220106] trunk/Source/WebCore
Title: [220106] trunk/Source/WebCore Revision 220106 Author jlew...@apple.com Date 2017-08-01 11:50:45 -0700 (Tue, 01 Aug 2017) Log Message Unreviewed, rolling out r220089. This caused multiple crashes on macOS Debug testers. Reverted changeset: "Use LazyNeverDestroyed instead of DEFINE_GLOBAL for QualifiedName" https://bugs.webkit.org/show_bug.cgi?id=175010 http://trac.webkit.org/changeset/220089 Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/DOMAllInOne.cpp trunk/Source/WebCore/dom/QualifiedName.cpp trunk/Source/WebCore/dom/QualifiedName.h Diff Modified: trunk/Source/WebCore/ChangeLog (220105 => 220106) --- trunk/Source/WebCore/ChangeLog 2017-08-01 18:18:03 UTC (rev 220105) +++ trunk/Source/WebCore/ChangeLog 2017-08-01 18:50:45 UTC (rev 220106) @@ -1,3 +1,16 @@ +2017-08-01 Matt Lewis + +Unreviewed, rolling out r220089. + +This caused multiple crashes on macOS Debug testers. + +Reverted changeset: + +"Use LazyNeverDestroyed instead of DEFINE_GLOBAL for +QualifiedName" +https://bugs.webkit.org/show_bug.cgi?id=175010 +http://trac.webkit.org/changeset/220089 + 2017-08-01 Sam Weinig [WebIDL] Swap a custom attribute for a custom mark function for HTMLTemplateElement Modified: trunk/Source/WebCore/dom/DOMAllInOne.cpp (220105 => 220106) --- trunk/Source/WebCore/dom/DOMAllInOne.cpp 2017-08-01 18:18:03 UTC (rev 220105) +++ trunk/Source/WebCore/dom/DOMAllInOne.cpp 2017-08-01 18:50:45 UTC (rev 220106) @@ -118,7 +118,9 @@ #include "ProcessingInstruction.cpp" #include "ProgressEvent.cpp" #include "PseudoElement.cpp" -#include "QualifiedName.cpp" +// Build error if adding QualifiedName.cpp to DOMAllInOne.cpp +// https://bugs.webkit.org/show_bug.cgi?id=146586 +// #include "QualifiedName.cpp" #include "RadioButtonGroups.cpp" #include "Range.cpp" #include "RejectedPromiseTracker.cpp" Modified: trunk/Source/WebCore/dom/QualifiedName.cpp (220105 => 220106) --- trunk/Source/WebCore/dom/QualifiedName.cpp 2017-08-01 18:18:03 UTC (rev 220105) +++ trunk/Source/WebCore/dom/QualifiedName.cpp 2017-08-01 18:50:45 UTC (rev 220106) @@ -18,11 +18,19 @@ */ #include "config.h" + +#ifdef SKIP_STATIC_CONSTRUCTORS_ON_GCC +#define WEBCORE_QUALIFIEDNAME_HIDE_GLOBALS 1 +#else +#define QNAME_DEFAULT_CONSTRUCTOR +#endif + #include "QualifiedName.h" - #include "QualifiedNameCache.h" #include "ThreadGlobalData.h" #include +#include +#include namespace WebCore { @@ -37,7 +45,7 @@ } // Global init routines -LazyNeverDestroyed anyName; +DEFINE_GLOBAL(QualifiedName, anyName, nullAtom(), starAtom(), starAtom()) void QualifiedName::init() { @@ -45,8 +53,9 @@ if (initialized) return; +// Use placement new to initialize the globals. AtomicString::init(); -anyName.construct(nullAtom(), starAtom(), starAtom()); +new (NotNull, (void*)&anyName) QualifiedName(nullAtom(), starAtom(), starAtom()); initialized = true; } Modified: trunk/Source/WebCore/dom/QualifiedName.h (220105 => 220106) --- trunk/Source/WebCore/dom/QualifiedName.h 2017-08-01 18:18:03 UTC (rev 220105) +++ trunk/Source/WebCore/dom/QualifiedName.h 2017-08-01 18:50:45 UTC (rev 220106) @@ -21,7 +21,6 @@ #pragma once #include -#include #include namespace WebCore { @@ -105,8 +104,10 @@ RefPtr m_impl; }; -extern LazyNeverDestroyed anyName; +#ifndef WEBCORE_QUALIFIEDNAME_HIDE_GLOBALS +extern const QualifiedName anyName; inline const QualifiedName& anyQName() { return anyName; } +#endif const QualifiedName& nullQName(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220105] trunk
Title: [220105] trunk Revision 220105 Author beid...@apple.com Date 2017-08-01 11:18:03 -0700 (Tue, 01 Aug 2017) Log Message Part 2 of: Rename DatabaseProcess to StorageProcess. https://bugs.webkit.org/show_bug.cgi?id=174880 Reviewed by Andy Estes. Source/WebKit: Rename some more variables, classes, etc. to reflect the change. * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles): * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::grantSandboxExtensionsToStorageProcessForBlobs): (WebKit::NetworkProcess::didGrantSandboxExtensionsToStorageProcessForBlobs): (WebKit::NetworkProcess::grantSandboxExtensionsToDatabaseProcessForBlobs): Deleted. (WebKit::NetworkProcess::didGrantSandboxExtensionsToDatabaseProcessForBlobs): Deleted. * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * Shared/ProcessExecutablePath.h: * Shared/gtk/ProcessExecutablePathGtk.cpp: (WebKit::executablePathOfStorageProcess): (WebKit::executablePathOfDatabaseProcess): Deleted. * Shared/wpe/ProcessExecutablePathWPE.cpp: (WebKit::executablePathOfStorageProcess): (WebKit::executablePathOfDatabaseProcess): Deleted. * StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp: (WebKit::WebIDBConnectionToClient::putOrAdd): * StorageProcess/StorageProcess.cpp: (WebKit::StorageProcess::initializeWebsiteDataStore): (WebKit::StorageProcess::postStorageTask): (WebKit::StorageProcess::performNextStorageTask): (WebKit::StorageProcess::createStorageToWebProcessConnection): (WebKit::StorageProcess::fetchWebsiteData): (WebKit::StorageProcess::postDatabaseTask): Deleted. (WebKit::StorageProcess::performNextDatabaseTask): Deleted. (WebKit::StorageProcess::createDatabaseToWebProcessConnection): Deleted. * StorageProcess/StorageProcess.h: * StorageProcess/StorageProcess.messages.in: * StorageProcess/mac/StorageProcessMac.mm: (WebKit::StorageProcess::initializeProcessName): * UIProcess/API/C/WKContext.cpp: (WKContextGetDatabaseProcessIdentifier): * UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _terminateStorageProcess]): (-[WKProcessPool _storageProcessIdentifier]): (-[WKProcessPool _terminateDatabaseProcess]): Deleted. (-[WKProcessPool _databaseProcessIdentifier]): Deleted. * UIProcess/API/Cocoa/WKProcessPoolPrivate.h: * UIProcess/ChildProcessProxy.cpp: (WebKit::ChildProcessProxy::getLaunchOptions): * UIProcess/Launcher/ProcessLauncher.h: * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: (WebKit::ProcessLauncher::launchProcess): * UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::serviceName): * UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp: (WebKit::ProcessLauncher::launchProcess): * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::grantSandboxExtensionsToStorageProcessForBlobs): (WebKit::NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs): Deleted. * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/Storage/StorageProcessProxy.cpp: (WebKit::StorageProcessProxy::getLaunchOptions): (WebKit::StorageProcessProxy::getStorageProcessConnection): (WebKit::StorageProcessProxy::didClose): (WebKit::StorageProcessProxy::didCreateStorageToWebProcessConnection): (WebKit::StorageProcessProxy::didFinishLaunching): (WebKit::StorageProcessProxy::getDatabaseProcessConnection): Deleted. (WebKit::StorageProcessProxy::didCreateDatabaseToWebProcessConnection): Deleted. * UIProcess/Storage/StorageProcessProxy.h: * UIProcess/Storage/StorageProcessProxy.messages.in: * UIProcess/WebContextClient.cpp: (WebKit::WebContextClient::storageProcessDidCrash): (WebKit::WebContextClient::databaseProcessDidCrash): Deleted. * UIProcess/WebContextClient.h: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureStorageProcessAndWebsiteDataStore): (WebKit::WebProcessPool::getStorageProcessConnection): (WebKit::WebProcessPool::storageProcessCrashed): (WebKit::WebProcessPool::pageAddedToProcess): (WebKit::WebProcessPool::storageProcessIdentifier): (WebKit::WebProcessPool::terminateStorageProcess): (WebKit::WebProcessPool::ensureDatabaseProcessAndWebsiteDataStore): Deleted. (WebKit::WebProcessPool::getDatabaseProcessConnection): Deleted. (WebKit::WebProcessPool::databaseProcessCrashed): Deleted. (WebKit::WebProcessPool::databaseProcessIdentifier): Deleted. (WebKit::WebProcessPool::terminateDatabaseProcess): Deleted. * UIProcess/WebProcessPool.h: (WebKit::WebProcessPool::sendToStorageProcessRelaunchingIfNecessary): (WebKit::WebProcessPool::sendToDatabaseProcessRelaunchingIfNecessary): Deleted. * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getStorageProcessConnection): (WebKit::WebProcessProxy::getDatabaseProcessConnection): Deleted. * UIProcess/WebProcessProxy.h: * UIProcess/WebProcessProxy.messages.in: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::fetchDataAndApply): (WebKit::WebsiteDataStore::removeData): (WebKit::Website
[webkit-changes] [220104] trunk/LayoutTests
Title: [220104] trunk/LayoutTests Revision 220104 Author commit-qu...@webkit.org Date 2017-08-01 09:42:18 -0700 (Tue, 01 Aug 2017) Log Message [GTK] Layout test fast/forms/content-with-margins-inside-button.html is failing https://bugs.webkit.org/show_bug.cgi?id=174610 Patch by Ms2ger on 2017-08-01 Reviewed by Darin Adler. Use an explicit text color for content-with-margins-inside-button.html. This makes the test pass in the GTK port. I also changed the formatting of the CSS to make it more readable. * fast/forms/content-with-margins-inside-button-expected.html: * fast/forms/content-with-margins-inside-button.html: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/content-with-margins-inside-button-expected.html trunk/LayoutTests/fast/forms/content-with-margins-inside-button.html trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (220103 => 220104) --- trunk/LayoutTests/ChangeLog 2017-08-01 16:24:20 UTC (rev 220103) +++ trunk/LayoutTests/ChangeLog 2017-08-01 16:42:18 UTC (rev 220104) @@ -1,5 +1,22 @@ 2017-08-01 Ms2ger +[GTK] Layout test fast/forms/content-with-margins-inside-button.html is failing +https://bugs.webkit.org/show_bug.cgi?id=174610 + +Reviewed by Darin Adler. + +Use an explicit text color for content-with-margins-inside-button.html. + +This makes the test pass in the GTK port. + +I also changed the formatting of the CSS to make it more readable. + +* fast/forms/content-with-margins-inside-button-expected.html: +* fast/forms/content-with-margins-inside-button.html: +* platform/gtk/TestExpectations: + +2017-08-01 Ms2ger + Remove obsolete failure expectations for wpt XHR tests. https://bugs.webkit.org/show_bug.cgi?id=175024 Modified: trunk/LayoutTests/fast/forms/content-with-margins-inside-button-expected.html (220103 => 220104) --- trunk/LayoutTests/fast/forms/content-with-margins-inside-button-expected.html 2017-08-01 16:24:20 UTC (rev 220103) +++ trunk/LayoutTests/fast/forms/content-with-margins-inside-button-expected.html 2017-08-01 16:42:18 UTC (rev 220104) @@ -6,7 +6,16 @@ margin-bottom: 100px; } - .outer { text-align:center; float: left; background-color: #cc; border:1px solid black; padding:0; font-family: Times; font-size:16px } + .outer { +float: left; +background-color: #cc; +border: 1px solid black; +padding: 0; +font-family: Times; +font-size: 16px; +color: black; +text-align: center; + } -Content \ No newline at end of file +Content Modified: trunk/LayoutTests/fast/forms/content-with-margins-inside-button.html (220103 => 220104) --- trunk/LayoutTests/fast/forms/content-with-margins-inside-button.html 2017-08-01 16:24:20 UTC (rev 220103) +++ trunk/LayoutTests/fast/forms/content-with-margins-inside-button.html 2017-08-01 16:42:18 UTC (rev 220104) @@ -6,7 +6,16 @@ margin-bottom: 100px; } - button { float:left; margin:0; background-color: #cc; border:1px solid black; padding:0; font-family: Times; font-size:16px } + button { +float: left; +background-color: #cc; +border: 1px solid black; +padding: 0; +font-family: Times; +font-size: 16px; +color: black; +margin: 0; + } -Content \ No newline at end of file +Content Modified: trunk/LayoutTests/platform/gtk/TestExpectations (220103 => 220104) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:24:20 UTC (rev 220103) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:42:18 UTC (rev 220104) @@ -3405,8 +3405,6 @@ webkit.org/b/174609 accessibility/presentation-role-iframe.html [ Failure ] -webkit.org/b/174610 fast/forms/content-with-margins-inside-button.html [ Failure ] - # # End of non-crashing, non-flaky tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220103] trunk/LayoutTests
Title: [220103] trunk/LayoutTests Revision 220103 Author commit-qu...@webkit.org Date 2017-08-01 09:24:20 -0700 (Tue, 01 Aug 2017) Log Message Remove obsolete failure expectations for wpt XHR tests. https://bugs.webkit.org/show_bug.cgi?id=175024 Patch by Ms2ger on 2017-08-01 Reviewed by Darin Adler. * TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (220102 => 220103) --- trunk/LayoutTests/ChangeLog 2017-08-01 16:22:25 UTC (rev 220102) +++ trunk/LayoutTests/ChangeLog 2017-08-01 16:24:20 UTC (rev 220103) @@ -1,5 +1,15 @@ 2017-08-01 Ms2ger +Remove obsolete failure expectations for wpt XHR tests. +https://bugs.webkit.org/show_bug.cgi?id=175024 + +Reviewed by Darin Adler. + +* TestExpectations: +* platform/gtk/TestExpectations: + +2017-08-01 Ms2ger + Remove obsolete failure expectations for style-01.html. https://bugs.webkit.org/show_bug.cgi?id=175026 Modified: trunk/LayoutTests/TestExpectations (220102 => 220103) --- trunk/LayoutTests/TestExpectations 2017-08-01 16:22:25 UTC (rev 220102) +++ trunk/LayoutTests/TestExpectations 2017-08-01 16:24:20 UTC (rev 220103) @@ -1157,7 +1157,6 @@ webkit.org/b/169264 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-samedoc.html [ Failure ] imported/w3c/web-platform-tests/XMLHttpRequest/open-url-redirected-worker-origin.htm [ Failure Pass ] -imported/w3c/web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-synconmain.html [ Failure ] imported/w3c/web-platform-tests/cssom/MediaList.html [ Failure ] imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/007.html [ Failure ] imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html [ Failure ] Modified: trunk/LayoutTests/platform/gtk/TestExpectations (220102 => 220103) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:22:25 UTC (rev 220102) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:24:20 UTC (rev 220103) @@ -3033,13 +3033,10 @@ # web-platform-tests XHR tests imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders.htm [ Failure ] -imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-chunked-trailer.htm [ Failure ] imported/w3c/web-platform-tests/XMLHttpRequest/headers-normalize-response.htm [ Failure ] -imported/w3c/web-platform-tests/XMLHttpRequest/send-accept-language.htm [ Failure ] imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async.htm [ Failure ] imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head.htm [ Failure ] imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect.htm [ Failure ] -imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm [ Failure ] imported/w3c/web-platform-tests/XMLHttpRequest/status-async.htm [ Failure ] imported/w3c/web-platform-tests/XMLHttpRequest/status-basic.htm [ Failure ] imported/w3c/web-platform-tests/XMLHttpRequest/status-error.htm [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220102] trunk/LayoutTests
Title: [220102] trunk/LayoutTests Revision 220102 Author commit-qu...@webkit.org Date 2017-08-01 09:22:25 -0700 (Tue, 01 Aug 2017) Log Message Remove obsolete failure expectations for style-01.html. https://bugs.webkit.org/show_bug.cgi?id=175026 Patch by Ms2ger on 2017-08-01 Reviewed by Darin Adler. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (220101 => 220102) --- trunk/LayoutTests/ChangeLog 2017-08-01 16:20:34 UTC (rev 220101) +++ trunk/LayoutTests/ChangeLog 2017-08-01 16:22:25 UTC (rev 220102) @@ -1,5 +1,14 @@ 2017-08-01 Ms2ger +Remove obsolete failure expectations for style-01.html. +https://bugs.webkit.org/show_bug.cgi?id=175026 + +Reviewed by Darin Adler. + +* TestExpectations: + +2017-08-01 Ms2ger + Remove obsolete failure expectation for Document-characterSet-normalization.html. https://bugs.webkit.org/show_bug.cgi?id=175022 Modified: trunk/LayoutTests/TestExpectations (220101 => 220102) --- trunk/LayoutTests/TestExpectations 2017-08-01 16:20:34 UTC (rev 220101) +++ trunk/LayoutTests/TestExpectations 2017-08-01 16:22:25 UTC (rev 220102) @@ -554,7 +554,6 @@ imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-between-Rs.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs.html [ ImageOnlyFailure ] -imported/w3c/web-platform-tests/html/dom/elements/global-attributes/style-01.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html [ Failure Timeout ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220101] trunk/LayoutTests
Title: [220101] trunk/LayoutTests Revision 220101 Author commit-qu...@webkit.org Date 2017-08-01 09:20:34 -0700 (Tue, 01 Aug 2017) Log Message Remove obsolete failure expectation for Document-characterSet-normalization.html. https://bugs.webkit.org/show_bug.cgi?id=175022 Patch by Ms2ger on 2017-08-01 Reviewed by Sam Weinig. The expectations were updated in r204605. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (220100 => 220101) --- trunk/LayoutTests/ChangeLog 2017-08-01 16:18:43 UTC (rev 220100) +++ trunk/LayoutTests/ChangeLog 2017-08-01 16:20:34 UTC (rev 220101) @@ -1,5 +1,16 @@ 2017-08-01 Ms2ger +Remove obsolete failure expectation for Document-characterSet-normalization.html. +https://bugs.webkit.org/show_bug.cgi?id=175022 + +Reviewed by Sam Weinig. + +The expectations were updated in r204605. + +* platform/gtk/TestExpectations: + +2017-08-01 Ms2ger + Remove obsolete failure expectation for regional-indicators.html. https://bugs.webkit.org/show_bug.cgi?id=175021 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (220100 => 220101) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:18:43 UTC (rev 220100) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:20:34 UTC (rev 220101) @@ -3124,7 +3124,6 @@ webkit.org/b/94952 platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html [ Failure ] -webkit.org/b/153707 imported/w3c/web-platform-tests/dom/nodes/Document-characterSet-normalization.html [ Failure ] webkit.org/b/153707 imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.html [ Failure ] webkit.org/b/153707 imported/w3c/web-platform-tests/html/dom/interfaces.html [ Failure ] webkit.org/b/153707 imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220100] trunk/LayoutTests
Title: [220100] trunk/LayoutTests Revision 220100 Author commit-qu...@webkit.org Date 2017-08-01 09:18:43 -0700 (Tue, 01 Aug 2017) Log Message Remove obsolete failure expectation for regional-indicators.html. https://bugs.webkit.org/show_bug.cgi?id=175021 Patch by Ms2ger on 2017-08-01 Reviewed by Sam Weinig. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (220099 => 220100) --- trunk/LayoutTests/ChangeLog 2017-08-01 16:16:26 UTC (rev 220099) +++ trunk/LayoutTests/ChangeLog 2017-08-01 16:18:43 UTC (rev 220100) @@ -1,5 +1,14 @@ 2017-08-01 Ms2ger +Remove obsolete failure expectation for regional-indicators.html. +https://bugs.webkit.org/show_bug.cgi?id=175021 + +Reviewed by Sam Weinig. + +* platform/gtk/TestExpectations: + +2017-08-01 Ms2ger + REGRESSION(r205909): Layout test editing/pasteboard/image-in-iframe.html is failing https://bugs.webkit.org/show_bug.cgi?id=163185 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (220099 => 220100) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:16:26 UTC (rev 220099) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:18:43 UTC (rev 220100) @@ -3312,7 +3312,6 @@ webkit.org/b/168719 fast/css/paint-order-shadow.html [ ImageOnlyFailure ] -webkit.org/b/169075 editing/selection/regional-indicators.html [ Failure ] webkit.org/b/169075 editing/deleting/skip-virama-001.html [ Failure ] webkit.org/b/169909 fast/css-generated-content/initial-letter-pagination-raised-rl.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220099] trunk/LayoutTests
Title: [220099] trunk/LayoutTests Revision 220099 Author commit-qu...@webkit.org Date 2017-08-01 09:16:26 -0700 (Tue, 01 Aug 2017) Log Message REGRESSION(r205909): Layout test editing/pasteboard/image-in-iframe.html is failing https://bugs.webkit.org/show_bug.cgi?id=163185 Patch by Ms2ger on 2017-08-01 Reviewed by Sam Weinig. Remove obsolete failure expectation for image-in-iframe.html. The bug was fixed in r212428. (The test was also broken by both landings for bug 170956, until r216174 fixed it again.) * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (220098 => 220099) --- trunk/LayoutTests/ChangeLog 2017-08-01 16:13:55 UTC (rev 220098) +++ trunk/LayoutTests/ChangeLog 2017-08-01 16:16:26 UTC (rev 220099) @@ -1,3 +1,17 @@ +2017-08-01 Ms2ger + +REGRESSION(r205909): Layout test editing/pasteboard/image-in-iframe.html is failing +https://bugs.webkit.org/show_bug.cgi?id=163185 + +Reviewed by Sam Weinig. + +Remove obsolete failure expectation for image-in-iframe.html. + +The bug was fixed in r212428. (The test was also broken by both landings for +bug 170956, until r216174 fixed it again.) + +* platform/gtk/TestExpectations: + 2017-08-01 Darin Adler REGRESSION (r220052): http/tests/media/video-play-stall.html times out Modified: trunk/LayoutTests/platform/gtk/TestExpectations (220098 => 220099) --- trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:13:55 UTC (rev 220098) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-08-01 16:16:26 UTC (rev 220099) @@ -3163,8 +3163,6 @@ webkit.org/b/163184 editing/pasteboard/copy-standalone-image.html [ ImageOnlyFailure ] -webkit.org/b/163185 editing/pasteboard/image-in-iframe.html [ Failure ] - webkit.org/b/163186 editing/pasteboard/onpaste-text-html.html [ Failure ] # Failing since a new URLParser has been enabled on r207162 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220098] trunk/LayoutTests
Title: [220098] trunk/LayoutTests Revision 220098 Author da...@apple.com Date 2017-08-01 09:13:55 -0700 (Tue, 01 Aug 2017) Log Message REGRESSION (r220052): http/tests/media/video-play-stall.html times out https://bugs.webkit.org/show_bug.cgi?id=174988 Reviewed by Sam Weinig. * TestExpectations: Stop skipping this test. * http/tests/media/video-play-stall.html: Use a 0-duration timeout to sidestep an issue where the test runner never thinks the test is done because of the stalled media loading, and times out. The behaviors here aren't great, but there is no reason to think that this confused state has any effect on web browsing; just on our test runners in a test that intentionally has a still loading video in it. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/http/tests/media/video-play-stall.html Diff Modified: trunk/LayoutTests/ChangeLog (220097 => 220098) --- trunk/LayoutTests/ChangeLog 2017-08-01 15:56:20 UTC (rev 220097) +++ trunk/LayoutTests/ChangeLog 2017-08-01 16:13:55 UTC (rev 220098) @@ -1,3 +1,18 @@ +2017-08-01 Darin Adler + +REGRESSION (r220052): http/tests/media/video-play-stall.html times out +https://bugs.webkit.org/show_bug.cgi?id=174988 + +Reviewed by Sam Weinig. + +* TestExpectations: Stop skipping this test. + +* http/tests/media/video-play-stall.html: Use a 0-duration timeout to sidestep an +issue where the test runner never thinks the test is done because of the stalled +media loading, and times out. The behaviors here aren't great, but there is no +reason to think that this confused state has any effect on web browsing; just on +our test runners in a test that intentionally has a still loading video in it. + 2017-08-01 Ms2ger Correct the line numbers in GTK's scheme-about.any-expected.txt. Modified: trunk/LayoutTests/TestExpectations (220097 => 220098) --- trunk/LayoutTests/TestExpectations 2017-08-01 15:56:20 UTC (rev 220097) +++ trunk/LayoutTests/TestExpectations 2017-08-01 16:13:55 UTC (rev 220098) @@ -1398,5 +1398,3 @@ webkit.org/b/172514 [ Debug ] imported/w3c/web-platform-tests/innerText/getter.html [ Skip ] webkit.org/b/17 imported/w3c/web-platform-tests/dom/nodes/Document-constructor-svg.svg [ Skip ] - -webkit.org/b/174988 http/tests/media/video-play-stall.html [ Skip ] Modified: trunk/LayoutTests/http/tests/media/video-play-stall.html (220097 => 220098) --- trunk/LayoutTests/http/tests/media/video-play-stall.html 2017-08-01 15:56:20 UTC (rev 220097) +++ trunk/LayoutTests/http/tests/media/video-play-stall.html 2017-08-01 16:13:55 UTC (rev 220098) @@ -38,7 +38,7 @@ - + Test that a stalled event is sent when media loading stalls. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220097] trunk/Source/bmalloc
Title: [220097] trunk/Source/bmalloc Revision 220097 Author commit-qu...@webkit.org Date 2017-08-01 08:56:20 -0700 (Tue, 01 Aug 2017) Log Message Implement __builtin_clzl for MSVC https://bugs.webkit.org/show_bug.cgi?id=174232 Patch by Daewoong Jang on 2017-08-01 Reviewed by Geoffrey Garen. * bmalloc/Algorithm.h: (bmalloc::clzl): (bmalloc::clzl<1>): (bmalloc::__builtin_clzl): * bmalloc/BPlatform.h: Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/Algorithm.h trunk/Source/bmalloc/bmalloc/BPlatform.h Diff Modified: trunk/Source/bmalloc/ChangeLog (220096 => 220097) --- trunk/Source/bmalloc/ChangeLog 2017-08-01 14:32:36 UTC (rev 220096) +++ trunk/Source/bmalloc/ChangeLog 2017-08-01 15:56:20 UTC (rev 220097) @@ -1,3 +1,16 @@ +2017-08-01 Daewoong Jang + +Implement __builtin_clzl for MSVC +https://bugs.webkit.org/show_bug.cgi?id=174232 + +Reviewed by Geoffrey Garen. + +* bmalloc/Algorithm.h: +(bmalloc::clzl): +(bmalloc::clzl<1>): +(bmalloc::__builtin_clzl): +* bmalloc/BPlatform.h: + 2017-07-31 Mark Lam Fixed some comment typos. Modified: trunk/Source/bmalloc/bmalloc/Algorithm.h (220096 => 220097) --- trunk/Source/bmalloc/bmalloc/Algorithm.h 2017-08-01 14:32:36 UTC (rev 220096) +++ trunk/Source/bmalloc/bmalloc/Algorithm.h 2017-08-01 15:56:20 UTC (rev 220097) @@ -26,7 +26,6 @@ #ifndef Algorithm_h #define Algorithm_h -#include "Algorithm.h" #include "BAssert.h" #include #include @@ -137,6 +136,23 @@ return sizeof(T) * 8; } +#if BOS(WINDOWS) +template __forceinline constexpr unsigned long clzl(unsigned long value) +{ +return value & (1UL << (bitCount() - 1)) ? 0 : 1 + clzl(value << 1); +} + +template<> __forceinline constexpr unsigned long clzl<1>(unsigned long value) +{ +return 0; +} + +__forceinline constexpr unsigned long __builtin_clzl(unsigned long value) +{ +return value == 0 ? 32 : clzl()>(value); +} +#endif + inline constexpr unsigned long log2(unsigned long value) { return bitCount() - 1 - __builtin_clzl(value); Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (220096 => 220097) --- trunk/Source/bmalloc/bmalloc/BPlatform.h 2017-08-01 14:32:36 UTC (rev 220096) +++ trunk/Source/bmalloc/bmalloc/BPlatform.h 2017-08-01 15:56:20 UTC (rev 220097) @@ -42,6 +42,10 @@ #define BOS_UNIX 1 #endif +#if defined(WIN32) || defined(_WIN32) +#define BOS_WINDOWS 1 +#endif + #if BOS(DARWIN) && ((defined(TARGET_OS_EMBEDDED) && TARGET_OS_EMBEDDED) \ || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) \ || (defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR)) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220095] trunk/Source/WebCore
Title: [220095] trunk/Source/WebCore Revision 220095 Author commit-qu...@webkit.org Date 2017-08-01 07:23:29 -0700 (Tue, 01 Aug 2017) Log Message [WebIDL] Swap a custom attribute for a custom mark function for HTMLTemplateElement https://bugs.webkit.org/show_bug.cgi?id=175006 Patch by Sam Weinig on 2017-08-01 Reviewed by Chris Dumez. Use the standard way of augmenting GC, visitAdditionalChildren, rather than using a private name to create ownership. * bindings/js/JSHTMLTemplateElementCustom.cpp: (WebCore::JSHTMLTemplateElement::visitAdditionalChildren): (WebCore::JSHTMLTemplateElement::content const): Deleted. * html/HTMLTemplateElement.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp trunk/Source/WebCore/html/HTMLTemplateElement.idl Diff Modified: trunk/Source/WebCore/ChangeLog (220094 => 220095) --- trunk/Source/WebCore/ChangeLog 2017-08-01 14:19:31 UTC (rev 220094) +++ trunk/Source/WebCore/ChangeLog 2017-08-01 14:23:29 UTC (rev 220095) @@ -1,3 +1,18 @@ +2017-08-01 Sam Weinig + +[WebIDL] Swap a custom attribute for a custom mark function for HTMLTemplateElement +https://bugs.webkit.org/show_bug.cgi?id=175006 + +Reviewed by Chris Dumez. + +Use the standard way of augmenting GC, visitAdditionalChildren, rather +than using a private name to create ownership. + +* bindings/js/JSHTMLTemplateElementCustom.cpp: +(WebCore::JSHTMLTemplateElement::visitAdditionalChildren): +(WebCore::JSHTMLTemplateElement::content const): Deleted. +* html/HTMLTemplateElement.idl: + 2017-08-01 Zan Dobersek [GCrypt] Gather crypto constants in a single location Modified: trunk/Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp (220094 => 220095) --- trunk/Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp 2017-08-01 14:19:31 UTC (rev 220094) +++ trunk/Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp 2017-08-01 14:23:29 UTC (rev 220095) @@ -31,24 +31,15 @@ #include "config.h" #include "JSHTMLTemplateElement.h" -#include "HTMLTemplateElement.h" #include "JSDocumentFragment.h" -#include -#include using namespace JSC; namespace WebCore { -JSValue JSHTMLTemplateElement::content(ExecState& state) const +void JSHTMLTemplateElement::visitAdditionalChildren(JSC::SlotVisitor& visitor) { -JSLockHolder lock(&state); - -auto wrapper = wrap(&state, globalObject(), wrapped().content()); - -PrivateName propertyName; -const_cast(this)->putDirect(globalObject()->vm(), propertyName, wrapper); -return wrapper; +visitor.addOpaqueRoot(root(&wrapped().content())); } } // namespace WebCore Modified: trunk/Source/WebCore/html/HTMLTemplateElement.idl (220094 => 220095) --- trunk/Source/WebCore/html/HTMLTemplateElement.idl 2017-08-01 14:19:31 UTC (rev 220094) +++ trunk/Source/WebCore/html/HTMLTemplateElement.idl 2017-08-01 14:23:29 UTC (rev 220095) @@ -28,7 +28,8 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -interface HTMLTemplateElement : HTMLElement { -[Custom] readonly attribute DocumentFragment content; +[ +JSCustomMarkFunction, +] interface HTMLTemplateElement : HTMLElement { +readonly attribute DocumentFragment content; }; - ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220093] trunk/LayoutTests
Title: [220093] trunk/LayoutTests Revision 220093 Author commit-qu...@webkit.org Date 2017-08-01 06:13:43 -0700 (Tue, 01 Aug 2017) Log Message Correct the line numbers in GTK's scheme-about.any-expected.txt. https://bugs.webkit.org/show_bug.cgi?id=175017 Patch by Ms2ger on 2017-08-01 Reviewed by Sam Weinig. The code fix landed in r220050. * platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (220092 => 220093) --- trunk/LayoutTests/ChangeLog 2017-08-01 11:49:51 UTC (rev 220092) +++ trunk/LayoutTests/ChangeLog 2017-08-01 13:13:43 UTC (rev 220093) @@ -1,3 +1,14 @@ +2017-08-01 Ms2ger + +Correct the line numbers in GTK's scheme-about.any-expected.txt. +https://bugs.webkit.org/show_bug.cgi?id=175017 + +Reviewed by Sam Weinig. + +The code fix landed in r220050. + +* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt: + 2017-07-31 Ms2ger Remove some obsolete expected failures blamed on the threaded compositor. Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt (220092 => 220093) --- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt 2017-08-01 11:49:51 UTC (rev 220092) +++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt 2017-08-01 13:13:43 UTC (rev 220093) @@ -1,9 +1,9 @@ -CONSOLE MESSAGE: line 1: Fetch API cannot load about:blank. Cross origin requests are only supported for HTTP. +CONSOLE MESSAGE: line 10: Fetch API cannot load about:blank. Cross origin requests are only supported for HTTP. CONSOLE MESSAGE: Fetch API cannot load about:blank. The URL can’t be shown -CONSOLE MESSAGE: line 1: Fetch API cannot load about:blank. Cross origin requests are only supported for HTTP. -CONSOLE MESSAGE: line 1: Fetch API cannot load about:invalid.com. Cross origin requests are only supported for HTTP. -CONSOLE MESSAGE: line 1: Fetch API cannot load about:config. Cross origin requests are only supported for HTTP. -CONSOLE MESSAGE: line 1: Fetch API cannot load about:unicorn. Cross origin requests are only supported for HTTP. +CONSOLE MESSAGE: line 10: Fetch API cannot load about:blank. Cross origin requests are only supported for HTTP. +CONSOLE MESSAGE: line 27: Fetch API cannot load about:invalid.com. Cross origin requests are only supported for HTTP. +CONSOLE MESSAGE: line 27: Fetch API cannot load about:config. Cross origin requests are only supported for HTTP. +CONSOLE MESSAGE: line 27: Fetch API cannot load about:unicorn. Cross origin requests are only supported for HTTP. FAIL Fetching about:blank (GET) is OK promise_test: Unhandled rejection with value: object "TypeError: Type error" FAIL Fetching about:blank (PUT) is OK promise_test: Unhandled rejection with value: object "TypeError: Type error" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [220092] trunk/Source/WebCore
Title: [220092] trunk/Source/WebCore Revision 220092 Author zandober...@gmail.com Date 2017-08-01 04:49:51 -0700 (Tue, 01 Aug 2017) Log Message [GCrypt] Gather crypto constants in a single location https://bugs.webkit.org/show_bug.cgi?id=174091 Reviewed by Jiewen Tan. Gather common constants used across the libgcrypt-specific Web Crypto implementations in a single place -- in the GCryptUtilities.h header, inside the CryptoConstants namespace. The various ASN.1 object identifiers and other helper values are placed inside, in the std::array container. Additionally, CryptoConstants::matches() helper function is provided. It compares the provided data-and-size pair with the given std::array container and returns true if the std::memcmp() call returns 0. Changes in CryptoKeyEC and CryptoKeyRSA consist mostly of switching to the use of CryptoConstants::matches() and the CryptoConstants data arrays, as well as some whitespace cleanup. Additionallity in CryptoKeyEC, the helper functions covering various curve attributes are reordered, renamed and reorganized for simplicity. No new tests -- no changes in behavior. * crypto/gcrypt/CryptoKeyECGCrypt.cpp: (WebCore::curveIdentifier): (WebCore::curveSize): (WebCore::curveUncompressedFieldElementSize): (WebCore::curveUncompressedPointSize): (WebCore::CryptoKeyEC::platformImportRaw): (WebCore::CryptoKeyEC::platformImportJWKPublic): (WebCore::CryptoKeyEC::platformImportJWKPrivate): (WebCore::supportedAlgorithmIdentifier): (WebCore::curveForIdentifier): (WebCore::CryptoKeyEC::platformImportSpki): (WebCore::CryptoKeyEC::platformExportRaw): (WebCore::CryptoKeyEC::platformAddFieldElements): (WebCore::CryptoKeyEC::platformExportSpki): (WebCore::CryptoKeyEC::platformExportPkcs8): (WebCore::uncompressedPointSizeForCurve): Deleted. (WebCore::uncompressedFieldElementSizeForCurve): Deleted. * crypto/gcrypt/CryptoKeyRSAGCrypt.cpp: (WebCore::supportedAlgorithmIdentifier): (WebCore::CryptoKeyRSA::importPkcs8): (WebCore::CryptoKeyRSA::exportSpki): (WebCore::CryptoKeyRSA::exportPkcs8): * crypto/gcrypt/GCryptUtilities.h: (WebCore::CryptoConstants::matches): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp trunk/Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp trunk/Source/WebCore/crypto/gcrypt/GCryptUtilities.h Diff Modified: trunk/Source/WebCore/ChangeLog (220091 => 220092) --- trunk/Source/WebCore/ChangeLog 2017-08-01 08:08:56 UTC (rev 220091) +++ trunk/Source/WebCore/ChangeLog 2017-08-01 11:49:51 UTC (rev 220092) @@ -1,3 +1,54 @@ +2017-08-01 Zan Dobersek + +[GCrypt] Gather crypto constants in a single location +https://bugs.webkit.org/show_bug.cgi?id=174091 + +Reviewed by Jiewen Tan. + +Gather common constants used across the libgcrypt-specific Web Crypto +implementations in a single place -- in the GCryptUtilities.h header, +inside the CryptoConstants namespace. The various ASN.1 object identifiers +and other helper values are placed inside, in the std::array +container. + +Additionally, CryptoConstants::matches() helper function is provided. It +compares the provided data-and-size pair with the given std::array +container and returns true if the std::memcmp() call returns 0. + +Changes in CryptoKeyEC and CryptoKeyRSA consist mostly of switching to the +use of CryptoConstants::matches() and the CryptoConstants data arrays, as +well as some whitespace cleanup. + +Additionallity in CryptoKeyEC, the helper functions covering various curve +attributes are reordered, renamed and reorganized for simplicity. + +No new tests -- no changes in behavior. + +* crypto/gcrypt/CryptoKeyECGCrypt.cpp: +(WebCore::curveIdentifier): +(WebCore::curveSize): +(WebCore::curveUncompressedFieldElementSize): +(WebCore::curveUncompressedPointSize): +(WebCore::CryptoKeyEC::platformImportRaw): +(WebCore::CryptoKeyEC::platformImportJWKPublic): +(WebCore::CryptoKeyEC::platformImportJWKPrivate): +(WebCore::supportedAlgorithmIdentifier): +(WebCore::curveForIdentifier): +(WebCore::CryptoKeyEC::platformImportSpki): +(WebCore::CryptoKeyEC::platformExportRaw): +(WebCore::CryptoKeyEC::platformAddFieldElements): +(WebCore::CryptoKeyEC::platformExportSpki): +(WebCore::CryptoKeyEC::platformExportPkcs8): +(WebCore::uncompressedPointSizeForCurve): Deleted. +(WebCore::uncompressedFieldElementSizeForCurve): Deleted. +* crypto/gcrypt/CryptoKeyRSAGCrypt.cpp: +(WebCore::supportedAlgorithmIdentifier): +(WebCore::CryptoKeyRSA::importPkcs8): +(WebCore::CryptoKeyRSA::exportSpki): +(WebCore::CryptoKeyRSA::exportPkcs8): +* crypto/gcrypt/GCryptUtilities.h: +(WebCore::CryptoConstants::matches): + 2017-07-31 Fujii Hironori
[webkit-changes] [220091] trunk
Title: [220091] trunk Revision 220091 Author mcatanz...@igalia.com Date 2017-08-01 01:08:56 -0700 (Tue, 01 Aug 2017) Log Message [CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later https://bugs.webkit.org/show_bug.cgi?id=174855 Reviewed by Carlos Garcia Campos. .: Create derived sources directories in WebKitCommon.cmake instead of WebKitFS.cmake, which is too soon. I tried changing the include order, but other stuff in WebKitFS.cmake really is needed before including the port options file. * Source/cmake/WebKitCommon.cmake: * Source/cmake/WebKitFS.cmake: Source/WebDriver: Don't create derived sources directory here anymore. * PlatformGTK.cmake: Source/WebKit: Don't create derived sources directory here anymore. * PlatformGTK.cmake: * PlatformMac.cmake: * PlatformWPE.cmake: Modified Paths trunk/ChangeLog trunk/Source/WebDriver/ChangeLog trunk/Source/WebDriver/PlatformGTK.cmake trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformGTK.cmake trunk/Source/WebKit/PlatformMac.cmake trunk/Source/WebKit/PlatformWPE.cmake trunk/Source/cmake/WebKitCommon.cmake trunk/Source/cmake/WebKitFS.cmake Diff Modified: trunk/ChangeLog (220090 => 220091) --- trunk/ChangeLog 2017-08-01 06:42:51 UTC (rev 220090) +++ trunk/ChangeLog 2017-08-01 08:08:56 UTC (rev 220091) @@ -1,3 +1,17 @@ +2017-08-01 Michael Catanzaro + +[CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later +https://bugs.webkit.org/show_bug.cgi?id=174855 + +Reviewed by Carlos Garcia Campos. + +Create derived sources directories in WebKitCommon.cmake instead of WebKitFS.cmake, which is +too soon. I tried changing the include order, but other stuff in WebKitFS.cmake really is +needed before including the port options file. + +* Source/cmake/WebKitCommon.cmake: +* Source/cmake/WebKitFS.cmake: + 2017-07-29 Yusuke Suzuki Unreviewed, build fix for GTK and WPE about StorageProcess renaming Modified: trunk/Source/WebDriver/ChangeLog (220090 => 220091) --- trunk/Source/WebDriver/ChangeLog 2017-08-01 06:42:51 UTC (rev 220090) +++ trunk/Source/WebDriver/ChangeLog 2017-08-01 08:08:56 UTC (rev 220091) @@ -1,3 +1,14 @@ +2017-08-01 Michael Catanzaro + +[CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later +https://bugs.webkit.org/show_bug.cgi?id=174855 + +Reviewed by Carlos Garcia Campos. + +Don't create derived sources directory here anymore. + +* PlatformGTK.cmake: + 2017-07-26 Carlos Garcia Campos Unreviewed. Fix GTK distcheck. Modified: trunk/Source/WebDriver/PlatformGTK.cmake (220090 => 220091) --- trunk/Source/WebDriver/PlatformGTK.cmake 2017-08-01 06:42:51 UTC (rev 220090) +++ trunk/Source/WebDriver/PlatformGTK.cmake 2017-08-01 08:08:56 UTC (rev 220091) @@ -1,5 +1,3 @@ -file(MAKE_DIRECTORY ${DERIVED_SOURCES_WEBDRIVER_DIR}) - set(WebDriver_Process_OUTPUT_NAME WebKitWebDriver) add_definitions(-DLIBEXECDIR="${CMAKE_INSTALL_FULL_LIBEXECDIR}") Modified: trunk/Source/WebKit/ChangeLog (220090 => 220091) --- trunk/Source/WebKit/ChangeLog 2017-08-01 06:42:51 UTC (rev 220090) +++ trunk/Source/WebKit/ChangeLog 2017-08-01 08:08:56 UTC (rev 220091) @@ -1,3 +1,16 @@ +2017-08-01 Michael Catanzaro + +[CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later +https://bugs.webkit.org/show_bug.cgi?id=174855 + +Reviewed by Carlos Garcia Campos. + +Don't create derived sources directory here anymore. + +* PlatformGTK.cmake: +* PlatformMac.cmake: +* PlatformWPE.cmake: + 2017-07-31 Daniel Bates WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction() may not be able to Modified: trunk/Source/WebKit/PlatformGTK.cmake (220090 => 220091) --- trunk/Source/WebKit/PlatformGTK.cmake 2017-08-01 06:42:51 UTC (rev 220090) +++ trunk/Source/WebKit/PlatformGTK.cmake 2017-08-01 08:08:56 UTC (rev 220091) @@ -4,7 +4,6 @@ set(WebKit2_PluginProcess_OUTPUT_NAME WebKitPluginProcess) set(WebKit2_StorageProcess_OUTPUT_NAME WebKitDatabaseProcess) -file(MAKE_DIRECTORY ${DERIVED_SOURCES_WEBKIT2_DIR}) file(MAKE_DIRECTORY ${DERIVED_SOURCES_WEBKIT2GTK_API_DIR}) file(MAKE_DIRECTORY ${FORWARDING_HEADERS_WEBKIT2GTK_DIR}) file(MAKE_DIRECTORY ${FORWARDING_HEADERS_WEBKIT2GTK_EXTENSION_DIR}) Modified: trunk/Source/WebKit/PlatformMac.cmake (220090 => 220091) --- trunk/Source/WebKit/PlatformMac.cmake 2017-08-01 06:42:51 UTC (rev 220090) +++ trunk/Source/WebKit/PlatformMac.cmake 2017-08-01 08:08:56 UTC (rev 220091) @@ -383,8 +383,6 @@ WebProcess/mac/SecItemShimLibrary.mm ) -file(MAKE_DIRECTORY ${DERIVED_SOURCES_WEBKIT2_DIR}) - list(APPEND WebKit2_INCLUDE_DIRECTORIES "${PAL_DIR}" "${WEBKIT2_DIR}/NetworkProcess/cocoa" Modified: trunk/Source/WebKit/PlatformWPE.cmake (220090 => 220091) --- trunk/