[webkit-changes] [227191] trunk/LayoutTests

[fred . wang]

Title: [227191] trunk/LayoutTests








Revision 227191
Author fred.w...@free.fr
Date 2018-01-18 23:03:50 -0800 (Thu, 18 Jan 2018)


Log Message
Move helper files for iOS touch gestures into LayoutTests/resources
https://bugs.webkit.org/show_bug.cgi?id=181798

Patch by Frederic Wang  on 2018-01-18
Reviewed by Wenson Hsieh.

* fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html: Change URL of
basic-gestures.js ; remove gesture-helpers.js it seems unused and has the wrong URL anyway.
* fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html: Change URL
of basic-gestures.js.
* fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html: Ditto.
* fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html: Ditto.
* fast/events/touch/ios/long-press-then-drag-to-select-text.html: Ditto.
* fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html: Ditto.
* fast/events/touch/ios/long-press-to-select-and-tap-to-clear.html: Ditto.
* fast/events/touch/ios/long-press-to-select-text.html: Ditto.
* resources/basic-gestures.js: Renamed from LayoutTests/fast/events/touch/ios/resources/basic-gestures.js.
* resources/ui-debugging.js: Renamed from LayoutTests/fast/events/touch/ios/resources/ui-debugging.js.
Note that this file was introduced in r222517 but seems unused for now.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html
trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html
trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html
trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html
trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-to-select-text.html
trunk/LayoutTests/fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html
trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-and-tap-to-clear.html
trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text.html


Added Paths

trunk/LayoutTests/resources/basic-gestures.js
trunk/LayoutTests/resources/ui-debugging.js


Removed Paths

trunk/LayoutTests/fast/events/touch/ios/resources/




Diff

Modified: trunk/LayoutTests/ChangeLog (227190 => 227191)

--- trunk/LayoutTests/ChangeLog	2018-01-19 06:33:11 UTC (rev 227190)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 07:03:50 UTC (rev 227191)
@@ -1,3 +1,24 @@
+2018-01-18  Frederic Wang  
+
+Move helper files for iOS touch gestures into LayoutTests/resources
+https://bugs.webkit.org/show_bug.cgi?id=181798
+
+Reviewed by Wenson Hsieh.
+
+* fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html: Change URL of
+basic-gestures.js ; remove gesture-helpers.js it seems unused and has the wrong URL anyway.
+* fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html: Change URL
+of basic-gestures.js.
+* fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html: Ditto.
+* fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html: Ditto.
+* fast/events/touch/ios/long-press-then-drag-to-select-text.html: Ditto.
+* fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html: Ditto.
+* fast/events/touch/ios/long-press-to-select-and-tap-to-clear.html: Ditto.
+* fast/events/touch/ios/long-press-to-select-text.html: Ditto.
+* resources/basic-gestures.js: Renamed from LayoutTests/fast/events/touch/ios/resources/basic-gestures.js.
+* resources/ui-debugging.js: Renamed from LayoutTests/fast/events/touch/ios/resources/ui-debugging.js.
+Note that this file was introduced in r222517 but seems unused for now.
+
 2018-01-18  Ryan Haddad  
 
 Mark platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html as flaky.


Modified: trunk/LayoutTests/fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html (227190 => 227191)

--- trunk/LayoutTests/fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html	2018-01-19 06:33:11 UTC (rev 227190)
+++ trunk/LayoutTests/fast/events/touch/ios/drag-to-autoscroll-in-single-line-editable.html	2018-01-19 07:03:50 UTC (rev 227191)
@@ -2,8 +2,7 @@
 
 
 
-

[webkit-changes] [227189] trunk/LayoutTests

[ryanhaddad]

Title: [227189] trunk/LayoutTests








Revision 227189
Author ryanhad...@apple.com
Date 2018-01-18 22:17:19 -0800 (Thu, 18 Jan 2018)


Log Message
Mark platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=180171

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227188 => 227189)

--- trunk/LayoutTests/ChangeLog	2018-01-19 06:11:01 UTC (rev 227188)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 06:17:19 UTC (rev 227189)
@@ -1,5 +1,14 @@
 2018-01-18  Ryan Haddad  
 
+Mark platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=180171
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2018-01-18  Ryan Haddad  
+
 Mark inspector/debugger/breakpoint-action-log.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=181839
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (227188 => 227189)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-01-19 06:11:01 UTC (rev 227188)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-01-19 06:17:19 UTC (rev 227189)
@@ -1783,3 +1783,5 @@
 webkit.org/b/181830 [ Debug ] media/video-main-content-allow-then-deny.html [ Pass Failure ]
 
 webkit.org/b/173928 storage/websql/database-lock-after-reload.html [ Pass Failure ]
+
+webkit.org/b/180171 [ HighSierra ] platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html [ Pass Failure Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227188] trunk/LayoutTests

[ryanhaddad]

Title: [227188] trunk/LayoutTests








Revision 227188
Author ryanhad...@apple.com
Date 2018-01-18 22:11:01 -0800 (Thu, 18 Jan 2018)


Log Message
Mark inspector/debugger/breakpoint-action-log.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=181839

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227187 => 227188)

--- trunk/LayoutTests/ChangeLog	2018-01-19 06:04:53 UTC (rev 227187)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 06:11:01 UTC (rev 227188)
@@ -1,5 +1,14 @@
 2018-01-18  Ryan Haddad  
 
+Mark inspector/debugger/breakpoint-action-log.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=181839
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2018-01-18  Ryan Haddad  
+
 Mark storage/websql/database-lock-after-reload.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=173928
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (227187 => 227188)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-01-19 06:04:53 UTC (rev 227187)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-01-19 06:11:01 UTC (rev 227188)
@@ -872,3 +872,4 @@
 webkit.org/b/181750 imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html [ Pass Failure ]
 webkit.org/b/181750 imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Pass Failure ]
 
+webkit.org/b/181839 [ Debug ] inspector/debugger/breakpoint-action-log.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227187] trunk/LayoutTests

[ryanhaddad]

Title: [227187] trunk/LayoutTests








Revision 227187
Author ryanhad...@apple.com
Date 2018-01-18 22:04:53 -0800 (Thu, 18 Jan 2018)


Log Message
Mark storage/websql/database-lock-after-reload.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173928

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227186 => 227187)

--- trunk/LayoutTests/ChangeLog	2018-01-19 06:04:51 UTC (rev 227186)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 06:04:53 UTC (rev 227187)
@@ -1,5 +1,14 @@
 2018-01-18  Ryan Haddad  
 
+Mark storage/websql/database-lock-after-reload.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=173928
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2018-01-18  Ryan Haddad  
+
 Mark imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=172243
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (227186 => 227187)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-01-19 06:04:51 UTC (rev 227186)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-01-19 06:04:53 UTC (rev 227187)
@@ -1781,3 +1781,5 @@
 webkit.org/b/180260 [ HighSierra ] http/wpt/resource-timing/rt-resources-per-worker.html [ Pass Failure ]
 
 webkit.org/b/181830 [ Debug ] media/video-main-content-allow-then-deny.html [ Pass Failure ]
+
+webkit.org/b/173928 storage/websql/database-lock-after-reload.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227186] trunk/LayoutTests

[ryanhaddad]

Title: [227186] trunk/LayoutTests








Revision 227186
Author ryanhad...@apple.com
Date 2018-01-18 22:04:51 -0800 (Thu, 18 Jan 2018)


Log Message
Mark imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172243

Unreviewed test gardening.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227185 => 227186)

--- trunk/LayoutTests/ChangeLog	2018-01-19 05:55:15 UTC (rev 227185)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 06:04:51 UTC (rev 227186)
@@ -1,5 +1,14 @@
 2018-01-18  Ryan Haddad  
 
+Mark imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=172243
+
+Unreviewed test gardening.
+
+* TestExpectations:
+
+2018-01-18  Ryan Haddad  
+
 Mark js/slow-stress/Int32Array-alloc-huge-long-lived.html as slow on iOS.
 https://bugs.webkit.org/show_bug.cgi?id=181838
 


Modified: trunk/LayoutTests/TestExpectations (227185 => 227186)

--- trunk/LayoutTests/TestExpectations	2018-01-19 05:55:15 UTC (rev 227185)
+++ trunk/LayoutTests/TestExpectations	2018-01-19 06:04:51 UTC (rev 227186)
@@ -1685,3 +1685,4 @@
 
 media/event-queue-crash.html [ DumpJSConsoleLogInStdErr ]
 
+webkit.org/b/172243 imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227183] trunk/LayoutTests

[ryanhaddad]

Title: [227183] trunk/LayoutTests








Revision 227183
Author ryanhad...@apple.com
Date 2018-01-18 20:55:46 -0800 (Thu, 18 Jan 2018)


Log Message
Mark media/W3C/video/networkState/networkState_during_loadstart.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179643

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227182 => 227183)

--- trunk/LayoutTests/ChangeLog	2018-01-19 04:46:45 UTC (rev 227182)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 04:55:46 UTC (rev 227183)
@@ -1,5 +1,14 @@
 2018-01-18  Ryan Haddad  
 
+Mark media/W3C/video/networkState/networkState_during_loadstart.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=179643
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
+2018-01-18  Ryan Haddad  
+
 Mark media/video-main-content-allow-then-deny.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=181830
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (227182 => 227183)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-01-19 04:46:45 UTC (rev 227182)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-01-19 04:55:46 UTC (rev 227183)
@@ -487,3 +487,4 @@
 
 webkit.org/b/180997 svg/animations/smil-leak-element-instances-noBaseValRef.svg [ Pass Failure ]
 
+webkit.org/b/179643 media/W3C/video/networkState/networkState_during_loadstart.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227182] trunk/Websites/perf.webkit.org

[rniwa]

Title: [227182] trunk/Websites/perf.webkit.org








Revision 227182
Author rn...@webkit.org
Date 2018-01-18 20:46:45 -0800 (Thu, 18 Jan 2018)


Log Message
Charts can be empty when values are all identical
https://bugs.webkit.org/show_bug.cgi?id=181828

Reviewed by Alexey Proskuryakov.

Fixed the bug that when SampleVarianceUpperTriangularMatrix can store -Infinity as the initial cost
of some entries when the sample standard deviation between two points turns out to be 0,
and cause splitIntoSegmentsUntilGoodEnough to return undefiend because no segmentation has a finite cost.

Also fixed the bug that the time series chart fails to show any data points when all data points have
identical values as the entire y-coordinate gets collapsed to an empty value range by adjusting the max value
when min & max values are identical.

* public/v3/components/time-series-chart.js:
(TimeSeriesChart.prototype._ensureValueRangeCache): Raise the max slightly when min & max are identical
to avoid the chart becoming empty. Otherwise valueDiff in _computeVerticalRenderingMetrics becomes 0
and value-to-y-coordinate conversion always results in NaN.
* public/shared/statistics.js:
(Statistics..SampleVarianceUpperTriangularMatrix):
* unit-tests/statistics-tests.js: Added a test case.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/shared/statistics.js
trunk/Websites/perf.webkit.org/public/v3/components/time-series-chart.js
trunk/Websites/perf.webkit.org/unit-tests/statistics-tests.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (227181 => 227182)

--- trunk/Websites/perf.webkit.org/ChangeLog	2018-01-19 04:33:17 UTC (rev 227181)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2018-01-19 04:46:45 UTC (rev 227182)
@@ -1,5 +1,28 @@
 2018-01-18  Ryosuke Niwa  
 
+Charts can be empty when values are all identical
+https://bugs.webkit.org/show_bug.cgi?id=181828
+
+Reviewed by Alexey Proskuryakov.
+
+Fixed the bug that when SampleVarianceUpperTriangularMatrix can store -Infinity as the initial cost
+of some entries when the sample standard deviation between two points turns out to be 0,
+and cause splitIntoSegmentsUntilGoodEnough to return undefiend because no segmentation has a finite cost.
+
+Also fixed the bug that the time series chart fails to show any data points when all data points have
+identical values as the entire y-coordinate gets collapsed to an empty value range by adjusting the max value
+when min & max values are identical.
+
+* public/v3/components/time-series-chart.js:
+(TimeSeriesChart.prototype._ensureValueRangeCache): Raise the max slightly when min & max are identical
+to avoid the chart becoming empty. Otherwise valueDiff in _computeVerticalRenderingMetrics becomes 0
+and value-to-y-coordinate conversion always results in NaN.
+* public/shared/statistics.js:
+(Statistics..SampleVarianceUpperTriangularMatrix):
+* unit-tests/statistics-tests.js: Added a test case.
+
+2018-01-18  Ryosuke Niwa  
+
 Don't fetch more than two builds to check duplicity of builds in ReportProcessor
 https://bugs.webkit.org/show_bug.cgi?id=181786
 


Modified: trunk/Websites/perf.webkit.org/public/shared/statistics.js (227181 => 227182)

--- trunk/Websites/perf.webkit.org/public/shared/statistics.js	2018-01-19 04:33:17 UTC (rev 227181)
+++ trunk/Websites/perf.webkit.org/public/shared/statistics.js	2018-01-19 04:46:45 UTC (rev 227182)
@@ -394,7 +394,7 @@
 squareSum += currentValue * currentValue;
 var sampleSize = j - i + 1;
 var stdev = Statistics.sampleStandardDeviation(sampleSize, sum, squareSum);
-costMatrix[i][j - i - 1] = sampleSize * Math.log1p(stdev * stdev - 1);
+costMatrix[i][j - i - 1] = stdev > 0 ? sampleSize * Math.log(stdev * stdev) : 0;
 }
 }
 this.costMatrix = costMatrix;


Modified: trunk/Websites/perf.webkit.org/public/v3/components/time-series-chart.js (227181 => 227182)

--- trunk/Websites/perf.webkit.org/public/v3/components/time-series-chart.js	2018-01-19 04:33:17 UTC (rev 227181)
+++ trunk/Websites/perf.webkit.org/public/v3/components/time-series-chart.js	2018-01-19 04:46:45 UTC (rev 227182)
@@ -585,6 +585,8 @@
 max = (max === undefined) ? maxCandidate : Math.max(max, maxCandidate);
 }
 }
+if (min == max)
+max = max * 1.1;
 this._valueRangeCache = [min, max];
 Instrumentation.endMeasuringTime('TimeSeriesChart', 'valueRangeCache');
 


Modified: trunk/Websites/perf.webkit.org/unit-tests/statistics-tests.js (227181 => 227182)

--- trunk/Websites/perf.webkit.org/unit-tests/statistics-tests.js	2018-01-19 04:33:17 UTC (rev 227181)
+++ trunk/Websites/perf.webkit.org/unit-tests/statistics-tests.js	2018-01-19 

[webkit-changes] [227181] trunk/LayoutTests

[ryanhaddad]

Title: [227181] trunk/LayoutTests








Revision 227181
Author ryanhad...@apple.com
Date 2018-01-18 20:33:17 -0800 (Thu, 18 Jan 2018)


Log Message
Mark media/video-main-content-allow-then-deny.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=181830

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227180 => 227181)

--- trunk/LayoutTests/ChangeLog	2018-01-19 04:29:33 UTC (rev 227180)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 04:33:17 UTC (rev 227181)
@@ -1,5 +1,14 @@
 2018-01-18  Ryan Haddad  
 
+Mark media/video-main-content-allow-then-deny.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=181830
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2018-01-18  Ryan Haddad  
+
 Update TestExpectations for fast/multicol/spanner-crash-when-adding-summary.html.
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (227180 => 227181)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-01-19 04:29:33 UTC (rev 227180)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-01-19 04:33:17 UTC (rev 227181)
@@ -1780,3 +1780,4 @@
 
 webkit.org/b/180260 [ HighSierra ] http/wpt/resource-timing/rt-resources-per-worker.html [ Pass Failure ]
 
+webkit.org/b/181830 [ Debug ] media/video-main-content-allow-then-deny.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227180] trunk/LayoutTests

[ryanhaddad]

Title: [227180] trunk/LayoutTests








Revision 227180
Author ryanhad...@apple.com
Date 2018-01-18 20:29:33 -0800 (Thu, 18 Jan 2018)


Log Message
Update TestExpectations for fast/multicol/spanner-crash-when-adding-summary.html.

Unreviewed test gardening.

* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227179 => 227180)

--- trunk/LayoutTests/ChangeLog	2018-01-19 04:25:52 UTC (rev 227179)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 04:29:33 UTC (rev 227180)
@@ -1,5 +1,14 @@
 2018-01-18  Ryan Haddad  
 
+Update TestExpectations for fast/multicol/spanner-crash-when-adding-summary.html.
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+* platform/mac/TestExpectations:
+
+2018-01-18  Ryan Haddad  
+
 Mark imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=181499
 


Modified: trunk/LayoutTests/platform/ios/TestExpectations (227179 => 227180)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-01-19 04:25:52 UTC (rev 227179)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-01-19 04:29:33 UTC (rev 227180)
@@ -3052,7 +3052,7 @@
 
 webkit.org/b/172052 [ Release ] imported/w3c/web-platform-tests/html/webappapis/timers/type-long-setinterval.html [ Pass Failure ]
 
-webkit.org/b/176878 [ Debug ] fast/multicol/spanner-crash-when-adding-summary.html [ Crash ]
+webkit.org/b/176878 [ Debug ] fast/multicol/spanner-crash-when-adding-summary.html [ Skip ]
 
 #  REGRESSION (iOS 11): LayoutTest fast/events/ios/before-input-events-prevent-candidate-insertion.html is timing out
 fast/events/ios/before-input-events-prevent-candidate-insertion.html [ Timeout ]


Modified: trunk/LayoutTests/platform/mac/TestExpectations (227179 => 227180)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-01-19 04:25:52 UTC (rev 227179)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-01-19 04:29:33 UTC (rev 227180)
@@ -1581,7 +1581,7 @@
 
 webkit.org/b/172052 [ Debug ] imported/w3c/web-platform-tests/html/webappapis/timers/type-long-setinterval.html [ Pass Failure ]
 
-webkit.org/b/176878 [ Debug ] fast/multicol/spanner-crash-when-adding-summary.html [ Crash ]
+webkit.org/b/176878 [ Debug ] fast/multicol/spanner-crash-when-adding-summary.html [ Skip ]
 
 #  REGRESSION? (FontParser-195): svg/W3C-SVG-1.1/fonts-elem-* and svg/W3C-SVG-1.1/text-intro-* tests failing
 [ HighSierra+ ] svg/W3C-SVG-1.1/fonts-elem-01-t.svg [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227179] trunk/LayoutTests

[ryanhaddad]

Title: [227179] trunk/LayoutTests








Revision 227179
Author ryanhad...@apple.com
Date 2018-01-18 20:25:52 -0800 (Thu, 18 Jan 2018)


Log Message
Mark imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=181499

Unreviewed test gardening.

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227178 => 227179)

--- trunk/LayoutTests/ChangeLog	2018-01-19 03:45:22 UTC (rev 227178)
+++ trunk/LayoutTests/ChangeLog	2018-01-19 04:25:52 UTC (rev 227179)
@@ -1,3 +1,12 @@
+2018-01-18  Ryan Haddad  
+
+Mark imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=181499
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+
 2018-01-18  Chris Dumez  
 
 We should be able to terminate service workers that are unresponsive


Modified: trunk/LayoutTests/platform/ios/TestExpectations (227178 => 227179)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-01-19 03:45:22 UTC (rev 227178)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-01-19 04:25:52 UTC (rev 227179)
@@ -3296,3 +3296,5 @@
 webkit.org/b/180062 fast/text/user-installed-fonts/shadow-postscript.html [ ImageOnlyFailure ]
 webkit.org/b/180062 fast/text/user-installed-fonts/shadow.html [ ImageOnlyFailure ]
 webkit.org/b/180062 fast/text/user-installed-fonts/shadow-postscript-family.html [ ImageOnlyFailure ]
+
+webkit.org/b/181499 [ Release ] imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227178] branches/safari-605-branch/Source/WebCore

[jmarcell]

Title: [227178] branches/safari-605-branch/Source/WebCore








Revision 227178
Author jmarc...@apple.com
Date 2018-01-18 19:45:22 -0800 (Thu, 18 Jan 2018)


Log Message
Cherry-pick r227147. rdar://problem/36429159

Modified Paths

branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/css/parser/CSSParser.cpp




Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (227177 => 227178)

--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-19 03:21:21 UTC (rev 227177)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-19 03:45:22 UTC (rev 227178)
@@ -1,3 +1,21 @@
+2018-01-18  Jason Marcell  
+
+Cherry-pick r227147. rdar://problem/36429159
+
+2018-01-18  Antti Koivisto  
+
+REGRESSION(r225650): The scores of MotionMark tests Multiply and Leaves dropped by 8%
+https://bugs.webkit.org/show_bug.cgi?id=181460
+
+
+Reviewed by Ryosuke Niwa.
+
+* css/parser/CSSParser.cpp:
+(WebCore::CSSParserContext::CSSParserContext):
+
+Don't do the expensive security origin test if the supplied sheet base URL is null. This
+is true for rules coming from the same document.
+
 2018-01-17  Jason Marcell  
 
 Cherry-pick r227121. rdar://problem/36609529


Modified: branches/safari-605-branch/Source/WebCore/css/parser/CSSParser.cpp (227177 => 227178)

--- branches/safari-605-branch/Source/WebCore/css/parser/CSSParser.cpp	2018-01-19 03:21:21 UTC (rev 227177)
+++ branches/safari-605-branch/Source/WebCore/css/parser/CSSParser.cpp	2018-01-19 03:45:22 UTC (rev 227178)
@@ -78,8 +78,9 @@
 , mode(document.inQuirksMode() ? HTMLQuirksMode : HTMLStandardMode)
 , isHTMLDocument(document.isHTMLDocument())
 , cssGridLayoutEnabled(document.isCSSGridLayoutEnabled())
-, hasDocumentSecurityOrigin(document.securityOrigin().canRequest(baseURL))
+, hasDocumentSecurityOrigin(sheetBaseURL.isNull() || document.securityOrigin().canRequest(baseURL))
 {
+
 needsSiteSpecificQuirks = document.settings().needsSiteSpecificQuirks();
 enforcesCSSMIMETypeInNoQuirksMode = document.settings().enforceCSSMIMETypeInNoQuirksMode();
 useLegacyBackgroundSizeShorthandBehavior = document.settings().useLegacyBackgroundSizeShorthandBehavior();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227177] branches/safari-605-branch

[jmarcell]

Title: [227177] branches/safari-605-branch








Revision 227177
Author jmarc...@apple.com
Date 2018-01-18 19:21:21 -0800 (Thu, 18 Jan 2018)


Log Message
Cherry-pick r226956. rdar://problem/36598688

Modified Paths

branches/safari-605-branch/Source/_javascript_Core/ChangeLog
branches/safari-605-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp
branches/safari-605-branch/Source/_javascript_Core/bytecode/CodeBlock.h
branches/safari-605-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp
branches/safari-605-branch/Source/_javascript_Core/runtime/JSGlobalObject.h
branches/safari-605-branch/Source/WTF/ChangeLog
branches/safari-605-branch/Source/WTF/wtf/PoisonedUniquePtr.h
branches/safari-605-branch/Tools/ChangeLog
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp




Diff

Modified: branches/safari-605-branch/Source/_javascript_Core/ChangeLog (227176 => 227177)

--- branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-19 01:35:06 UTC (rev 227176)
+++ branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-19 03:21:21 UTC (rev 227177)
@@ -1,5 +1,27 @@
 2018-01-18  Jason Marcell  
 
+Cherry-pick r226956. rdar://problem/36598688
+
+2018-01-15  JF Bastien  
+
+Remove makePoisonedUnique
+https://bugs.webkit.org/show_bug.cgi?id=181630
+
+
+Reviewed by Mark Lam.
+
+I added a conversion from std::unique_ptr, so we can just use
+std::make_unique and it'll auto-poison when converted.
+
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::makePoisonedUnique): Deleted.
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::init):
+* runtime/JSGlobalObject.h:
+(JSC::JSGlobalObject::makePoisonedUnique): Deleted.
+
+2018-01-18  Jason Marcell  
+
 Cherry-pick r227165. rdar://problem/36628552
 
 2018-01-18  Michael Saboff  


Modified: branches/safari-605-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp (227176 => 227177)

--- branches/safari-605-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp	2018-01-19 01:35:06 UTC (rev 227176)
+++ branches/safari-605-branch/Source/_javascript_Core/bytecode/CodeBlock.cpp	2018-01-19 03:21:21 UTC (rev 227177)
@@ -329,8 +329,8 @@
 , m_optimizationDelayCounter(0)
 , m_reoptimizationRetryCounter(0)
 , m_creationTime(MonotonicTime::now())
-, m_unconditionalFinalizer(makePoisonedUnique(*this))
-, m_weakReferenceHarvester(makePoisonedUnique(*this))
+, m_unconditionalFinalizer(std::make_unique(*this))
+, m_weakReferenceHarvester(std::make_unique(*this))
 {
 m_visitWeaklyHasBeenCalled = false;
 
@@ -389,8 +389,8 @@
 , m_optimizationDelayCounter(0)
 , m_reoptimizationRetryCounter(0)
 , m_creationTime(MonotonicTime::now())
-, m_unconditionalFinalizer(makePoisonedUnique(*this))
-, m_weakReferenceHarvester(makePoisonedUnique(*this))
+, m_unconditionalFinalizer(std::make_unique(*this))
+, m_weakReferenceHarvester(std::make_unique(*this))
 {
 m_visitWeaklyHasBeenCalled = false;
 


Modified: branches/safari-605-branch/Source/_javascript_Core/bytecode/CodeBlock.h (227176 => 227177)

--- branches/safari-605-branch/Source/_javascript_Core/bytecode/CodeBlock.h	2018-01-19 01:35:06 UTC (rev 227176)
+++ branches/safari-605-branch/Source/_javascript_Core/bytecode/CodeBlock.h	2018-01-19 03:21:21 UTC (rev 227177)
@@ -955,12 +955,6 @@
 void insertBasicBlockBoundariesForControlFlowProfiler(RefCountedArray&);
 void ensureCatchLivenessIsComputedForBytecodeOffsetSlow(unsigned);
 
-template
-static PoisonedUniquePtr makePoisonedUnique(Arguments&&... arguments)
-{
-return WTF::makePoisonedUnique(std::forward(arguments)...);
-}
-
 WriteBarrier m_unlinkedCode;
 int m_numParameters;
 int m_numberOfArgumentsToSkip { 0 };


Modified: branches/safari-605-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp (227176 => 227177)

--- branches/safari-605-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-19 01:35:06 UTC (rev 227176)
+++ branches/safari-605-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2018-01-19 03:21:21 UTC (rev 227177)
@@ -394,8 +394,8 @@
 m_debugger = 0;
 
 #if ENABLE(REMOTE_INSPECTOR)
-m_inspectorController = makePoisonedUnique(*this);
-m_inspectorDebuggable = makePoisonedUnique(*this);
+m_inspectorController = std::make_unique(*this);
+m_inspectorDebuggable = std::make_unique(*this);
 m_inspectorDebuggable->init();
 m_consoleClient = m_inspectorController->consoleClient();
 #endif
@@ -1009,63 +1009,63 @@
 
 {
 ObjectPropertyCondition condition = 

[webkit-changes] [227173] tags/Safari-605.1.24/

[jmarcell]

Title: [227173] tags/Safari-605.1.24/








Revision 227173
Author jmarc...@apple.com
Date 2018-01-18 16:51:48 -0800 (Thu, 18 Jan 2018)


Log Message
Tag Safari-605.1.24.

Added Paths

tags/Safari-605.1.24/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227172] trunk/Source/WebKitLegacy/mac

[ap]

Title: [227172] trunk/Source/WebKitLegacy/mac








Revision 227172
Author a...@apple.com
Date 2018-01-18 16:43:56 -0800 (Thu, 18 Jan 2018)


Log Message
Build fix, remove a call to -[NSWindow setOneShot:]
https://bugs.webkit.org/show_bug.cgi?id=181809

Reviewed by Tim Horton.

* WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _buildUI]):

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (227171 => 227172)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-01-19 00:25:48 UTC (rev 227171)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-01-19 00:43:56 UTC (rev 227172)
@@ -1,3 +1,13 @@
+2018-01-18  Alexey Proskuryakov  
+
+Build fix, remove a call to -[NSWindow setOneShot:]
+https://bugs.webkit.org/show_bug.cgi?id=181809
+
+Reviewed by Tim Horton.
+
+* WebView/WebTextCompletionController.mm:
+(-[WebTextCompletionController _buildUI]):
+
 2018-01-18  Ryan Haddad  
 
 Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm (227171 => 227172)

--- trunk/Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm	2018-01-19 00:25:48 UTC (rev 227171)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm	2018-01-19 00:43:56 UTC (rev 227172)
@@ -117,7 +117,9 @@
 [_popupWindow setContentView:scrollView];
 [scrollView release];
 [_popupWindow setHasShadow:YES];
+#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101400
 [_popupWindow setOneShot:YES];
+#endif
 [_popupWindow _setForceActiveControls:YES];
 [_popupWindow setReleasedWhenClosed:NO];
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227171] trunk/Tools

[commit-queue]

Title: [227171] trunk/Tools








Revision 227171
Author commit-qu...@webkit.org
Date 2018-01-18 16:25:48 -0800 (Thu, 18 Jan 2018)


Log Message
[WinCairo] Pass correct url for http test to test driver.
https://bugs.webkit.org/show_bug.cgi?id=181814

Patch by Basuke Suzuki  on 2018-01-18
Reviewed by Alex Christensen.

* Scripts/webkitpy/port/driver.py:
(Driver):
(Driver.http_test_path_to_uri):
(Driver.is_secure_path):
(Driver.http_base_url):
(Driver.uri_to_test):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/driver.py




Diff

Modified: trunk/Tools/ChangeLog (227170 => 227171)

--- trunk/Tools/ChangeLog	2018-01-19 00:19:00 UTC (rev 227170)
+++ trunk/Tools/ChangeLog	2018-01-19 00:25:48 UTC (rev 227171)
@@ -1,3 +1,17 @@
+2018-01-18  Basuke Suzuki  
+
+[WinCairo] Pass correct url for http test to test driver.
+https://bugs.webkit.org/show_bug.cgi?id=181814
+
+Reviewed by Alex Christensen.
+
+* Scripts/webkitpy/port/driver.py:
+(Driver):
+(Driver.http_test_path_to_uri):
+(Driver.is_secure_path):
+(Driver.http_base_url):
+(Driver.uri_to_test):
+
 2018-01-18  Ryan Haddad  
 
 Unreviewed, update the triggerable name for 'sierra-release-perf-tests'


Modified: trunk/Tools/Scripts/webkitpy/port/driver.py (227170 => 227171)

--- trunk/Tools/Scripts/webkitpy/port/driver.py	2018-01-19 00:19:00 UTC (rev 227170)
+++ trunk/Tools/Scripts/webkitpy/port/driver.py	2018-01-19 00:25:48 UTC (rev 227171)
@@ -35,6 +35,7 @@
 import time
 import os
 
+from os.path import normpath
 from webkitpy.common.system import path
 from webkitpy.common.system.profiler import ProfilerFactory
 
@@ -253,10 +254,10 @@
 return shlex.split(self._port.get_option('wrapper')) + wrapper_arguments
 return wrapper_arguments
 
-HTTP_DIR = "http/tests/"
-HTTP_LOCAL_DIR = "http/tests/local/"
-WEBKIT_SPECIFIC_WEB_PLATFORM_TEST_SUBDIR = "http/wpt/"
-WEBKIT_WEB_PLATFORM_TEST_SERVER_ROUTE = "WebKit/"
+HTTP_DIR = normpath("http/tests") + os.sep
+HTTP_LOCAL_DIR = normpath("http/tests/local") + os.sep
+WEBKIT_SPECIFIC_WEB_PLATFORM_TEST_SUBDIR = normpath("http/wpt") + os.sep
+WEBKIT_WEB_PLATFORM_TEST_SERVER_ROUTE = normpath("WebKit") + os.sep
 
 def is_http_test(self, test_name):
 return test_name.startswith(self.HTTP_DIR) and not test_name.startswith(self.HTTP_LOCAL_DIR)
@@ -271,8 +272,15 @@
 return self.web_platform_test_server_base_https_url + path if ".https." in path else self.web_platform_test_server_base_http_url + path
 
 def http_test_path_to_uri(self, path):
-return "https://127.0.0.1:8443/" + path if path.startswith("ssl") or ".https." in path else "http://127.0.0.1:8000/" + path
+path = path.replace(os.sep, '/')
+return self.http_base_url(secure=self.is_secure_path(path)) + path
 
+def is_secure_path(self, path):
+return path.startswith("ssl") or ".https." in path
+
+def http_base_url(self, secure=None):
+return "%s://127.0.0.1:%d/" % (('https', 8443) if secure else ('http', 8000))
+
 def test_to_uri(self, test_name):
 """Convert a test name to a URI."""
 if self.is_web_platform_test(test_name):
@@ -307,9 +315,9 @@
 if uri.startswith(self.web_platform_test_server_base_https_url):
 return uri.replace(self.web_platform_test_server_base_https_url, self.web_platform_test_server_doc_root)
 if uri.startswith("http://"):
-return uri.replace('http://127.0.0.1:8000/', self.HTTP_DIR)
+return uri.replace(self.http_base_url(secure=False), self.HTTP_DIR)
 if uri.startswith("https://"):
-return uri.replace('https://127.0.0.1:8443/', self.HTTP_DIR)
+return uri.replace(self.http_base_url(secure=True), self.HTTP_DIR)
 raise NotImplementedError('unknown url type: %s' % uri)
 
 def has_crashed(self):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227170] trunk/Tools

[ryanhaddad]

Title: [227170] trunk/Tools








Revision 227170
Author ryanhad...@apple.com
Date 2018-01-18 16:19:00 -0800 (Thu, 18 Jan 2018)


Log Message
Unreviewed, update the triggerable name for 'sierra-release-perf-tests'

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (227169 => 227170)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-01-19 00:07:01 UTC (rev 227169)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-01-19 00:19:00 UTC (rev 227170)
@@ -381,7 +381,7 @@
 { "type": "Triggerable", "name": "sierra-debug-tests-wk2",
   "builderNames": ["Apple Sierra Debug WK2 (Tests)"]
 },
-{ "type": "Triggerable", "name": "sierra-release-perf",
+{ "type": "Triggerable", "name": "sierra-release-perf-tests",
   "builderNames": ["Apple Sierra Release WK2 (Perf)"]
 },
 { "type": "Triggerable", "name": "sierra-debug-tests-test262",


Modified: trunk/Tools/ChangeLog (227169 => 227170)

--- trunk/Tools/ChangeLog	2018-01-19 00:07:01 UTC (rev 227169)
+++ trunk/Tools/ChangeLog	2018-01-19 00:19:00 UTC (rev 227170)
@@ -1,3 +1,9 @@
+2018-01-18  Ryan Haddad  
+
+Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2018-01-18  Dan Bernstein  
 
 [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227168] trunk/Source/JavaScriptCore

[jfbastien]

Title: [227168] trunk/Source/_javascript_Core








Revision 227168
Author jfbast...@apple.com
Date 2018-01-18 15:53:23 -0800 (Thu, 18 Jan 2018)


Log Message
Set the minimum executable allocator size properly
https://bugs.webkit.org/show_bug.cgi?id=181816


Reviewed by Saam Barati.

Executable allocator expects at least two page size's worth of
allocation in certain conditions, and that causes some tests to
now fail because they ask for less. Set that minimum correctly. We
were already rounding up to a page size, so having a minimum of 2
page sizes is fine.

* jit/ExecutableAllocator.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227167 => 227168)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-18 23:39:27 UTC (rev 227167)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-18 23:53:23 UTC (rev 227168)
@@ -1,3 +1,20 @@
+2018-01-18  JF Bastien  
+
+Set the minimum executable allocator size properly
+https://bugs.webkit.org/show_bug.cgi?id=181816
+
+
+Reviewed by Saam Barati.
+
+Executable allocator expects at least two page size's worth of
+allocation in certain conditions, and that causes some tests to
+now fail because they ask for less. Set that minimum correctly. We
+were already rounding up to a page size, so having a minimum of 2
+page sizes is fine.
+
+* jit/ExecutableAllocator.cpp:
+(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
+
 2018-01-18  Michael Saboff  
 
 Unreviewed build fix for Windows


Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp (227167 => 227168)

--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp	2018-01-18 23:39:27 UTC (rev 227167)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp	2018-01-18 23:53:23 UTC (rev 227168)
@@ -121,7 +121,7 @@
 reservationSize = Options::jitMemoryReservationSize();
 else
 reservationSize = fixedExecutableMemoryPoolSize;
-reservationSize = roundUpToMultipleOf(pageSize(), reservationSize);
+reservationSize = std::max(roundUpToMultipleOf(pageSize(), reservationSize), pageSize() * 2);
 m_reservation = PageReservation::reserveWithGuardPages(reservationSize, OSAllocator::JSJITCodePages, EXECUTABLE_POOL_WRITABLE, true);
 if (m_reservation) {
 ASSERT(m_reservation.size() == reservationSize);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227167] trunk/Source

[ryanhaddad]

Title: [227167] trunk/Source








Revision 227167
Author ryanhad...@apple.com
Date 2018-01-18 15:39:27 -0800 (Thu, 18 Jan 2018)


Log Message
Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.

Source/WebKit:

* UIProcess/ios/WKPDFPageNumberIndicator.mm:
(-[WKPDFPageNumberIndicator _makeRoundedCorners]):

Source/WebKitLegacy/mac:

* Carbon/HIWebView.mm:
(overrideCGContext):
(restoreCGContext):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm
trunk/Source/WebKitLegacy/mac/Carbon/HIWebView.mm
trunk/Source/WebKitLegacy/mac/ChangeLog




Diff

Modified: trunk/Source/WebKit/ChangeLog (227166 => 227167)

--- trunk/Source/WebKit/ChangeLog	2018-01-18 23:01:46 UTC (rev 227166)
+++ trunk/Source/WebKit/ChangeLog	2018-01-18 23:39:27 UTC (rev 227167)
@@ -1,3 +1,10 @@
+2018-01-18  Ryan Haddad  
+
+Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
+
+* UIProcess/ios/WKPDFPageNumberIndicator.mm:
+(-[WKPDFPageNumberIndicator _makeRoundedCorners]):
+
 2018-01-18  Youenn Fablet  
 
 Do not go to the storage process when loading a main resource if there is no service worker registered


Modified: trunk/Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm (227166 => 227167)

--- trunk/Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm	2018-01-18 23:01:46 UTC (rev 227166)
+++ trunk/Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm	2018-01-18 23:39:27 UTC (rev 227167)
@@ -183,7 +183,10 @@
 CGContextSaveGState(context);
 CGContextAddRect(context, cornerImageBounds);
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 UIBezierPath *cornerPath = [UIBezierPath bezierPathWithRoundedRect:cornerImageBounds byRoundingCorners:(UIRectCorner)UIAllCorners cornerRadii:CGSizeMake(indicatorCornerRadius, indicatorCornerRadius)];
+#pragma clang diagnostic pop
 CGContextAddPath(context, [cornerPath CGPath]);
 CGContextEOClip(context);
 CGContextFillRect(context, cornerImageBounds);


Modified: trunk/Source/WebKitLegacy/mac/Carbon/HIWebView.mm (227166 => 227167)

--- trunk/Source/WebKitLegacy/mac/Carbon/HIWebView.mm	2018-01-18 23:01:46 UTC (rev 227166)
+++ trunk/Source/WebKitLegacy/mac/Carbon/HIWebView.mm	2018-01-18 23:39:27 UTC (rev 227167)
@@ -288,9 +288,9 @@
 
 static CGContextRef overrideCGContext(NSWindow *window, CGContextRef context)
 {
-NSWindowGraphicsContext *graphicsContext = (NSWindowGraphicsContext *)window.graphicsContext;
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
+NSWindowGraphicsContext *graphicsContext = (NSWindowGraphicsContext *)window.graphicsContext;
 CGContextRef savedContext = (CGContextRef)graphicsContext.graphicsPort;
 #pragma clang diagnostic pop
 CGContextRetain(savedContext);
@@ -300,7 +300,10 @@
 
 static void restoreCGContext(NSWindow *window, CGContextRef savedContext)
 {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 NSWindowGraphicsContext *graphicsContext = (NSWindowGraphicsContext *)window.graphicsContext;
+#pragma clang diagnostic pop
 [graphicsContext _web_setGraphicsPort:savedContext];
 CGContextRelease(savedContext);
 }


Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (227166 => 227167)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2018-01-18 23:01:46 UTC (rev 227166)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2018-01-18 23:39:27 UTC (rev 227167)
@@ -1,3 +1,11 @@
+2018-01-18  Ryan Haddad  
+
+Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
+
+* Carbon/HIWebView.mm:
+(overrideCGContext):
+(restoreCGContext):
+
 2018-01-18  Dan Bernstein  
 
 [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227166] trunk/Websites/perf.webkit.org

[rniwa]

Title: [227166] trunk/Websites/perf.webkit.org








Revision 227166
Author rn...@webkit.org
Date 2018-01-18 15:01:46 -0800 (Thu, 18 Jan 2018)


Log Message
Don't fetch more than two builds to check duplicity of builds in ReportProcessor
https://bugs.webkit.org/show_bug.cgi?id=181786

Reviewed by Wenson Hsieh.

Limit the number of builds to check to avoid using a lot of memory with a long delay.

* public/include/report-processor.php:
(ReportProcessor::resolve_build_id): 

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/public/include/report-processor.php




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (227165 => 227166)

--- trunk/Websites/perf.webkit.org/ChangeLog	2018-01-18 22:43:01 UTC (rev 227165)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2018-01-18 23:01:46 UTC (rev 227166)
@@ -1,3 +1,15 @@
+2018-01-18  Ryosuke Niwa  
+
+Don't fetch more than two builds to check duplicity of builds in ReportProcessor
+https://bugs.webkit.org/show_bug.cgi?id=181786
+
+Reviewed by Wenson Hsieh.
+
+Limit the number of builds to check to avoid using a lot of memory with a long delay.
+
+* public/include/report-processor.php:
+(ReportProcessor::resolve_build_id): 
+
 2018-01-17  Ryosuke Niwa  
 
 Rename config.json to config.json.sample


Modified: trunk/Websites/perf.webkit.org/public/include/report-processor.php (227165 => 227166)

--- trunk/Websites/perf.webkit.org/public/include/report-processor.php	2018-01-18 22:43:01 UTC (rev 227165)
+++ trunk/Websites/perf.webkit.org/public/include/report-processor.php	2018-01-18 23:01:46 UTC (rev 227166)
@@ -130,7 +130,7 @@
 private function resolve_build_id(&$build_data, $revisions, $build_request_id) {
 // FIXME: This code has a race condition. See .
 $results = $this->db->query_and_fetch_all("SELECT build_id, build_slave FROM builds
-WHERE build_builder = $1 AND build_number = $2 AND build_time <= $3 AND build_time + interval '1 day' > $3",
+WHERE build_builder = $1 AND build_number = $2 AND build_time <= $3 AND build_time + interval '1 day' > $3 LIMIT 2",
 array($build_data['builder'], $build_data['number'], $build_data['time']));
 if ($results) {
 $first_result = $results[0];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227165] trunk/Source/JavaScriptCore

[msaboff]

Title: [227165] trunk/Source/_javascript_Core








Revision 227165
Author msab...@apple.com
Date 2018-01-18 14:43:01 -0800 (Thu, 18 Jan 2018)


Log Message
2018-01-18  Michael Saboff  

Unreviewed build fix for Windows

* interpreter/FrameTracers.h:
(JSC::assertStackPointerIsAligned): Can't use gcc style inlined assembly
on Windows.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/FrameTracers.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227164 => 227165)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-18 21:51:45 UTC (rev 227164)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-18 22:43:01 UTC (rev 227165)
@@ -1,3 +1,11 @@
+2018-01-18  Michael Saboff  
+
+Unreviewed build fix for Windows
+
+* interpreter/FrameTracers.h:
+(JSC::assertStackPointerIsAligned): Can't use gcc style inlined assembly
+on Windows.
+
 2018-01-18  Mark Lam  
 
 Poisons should be initialized after Options are initialized.


Modified: trunk/Source/_javascript_Core/interpreter/FrameTracers.h (227164 => 227165)

--- trunk/Source/_javascript_Core/interpreter/FrameTracers.h	2018-01-18 21:51:45 UTC (rev 227164)
+++ trunk/Source/_javascript_Core/interpreter/FrameTracers.h	2018-01-18 22:43:01 UTC (rev 227165)
@@ -72,7 +72,7 @@
 ALWAYS_INLINE static void assertStackPointerIsAligned()
 {
 #ifndef NDEBUG
-#if CPU(X86)
+#if CPU(X86) && !OS(WINDOWS)
 uintptr_t stackPointer;
 
 asm("movl %%esp,%0" : "=r"(stackPointer));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227164] tags/Safari-605.1.23.1/Source/JavaScriptCore

[jmarcell]

Title: [227164] tags/Safari-605.1.23.1/Source/_javascript_Core








Revision 227164
Author jmarc...@apple.com
Date 2018-01-18 13:51:45 -0800 (Thu, 18 Jan 2018)


Log Message
Cherry-pick r227152. rdar://problem/36628594

Modified Paths

tags/Safari-605.1.23.1/Source/_javascript_Core/ChangeLog
tags/Safari-605.1.23.1/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
tags/Safari-605.1.23.1/Source/_javascript_Core/interpreter/FrameTracers.h
tags/Safari-605.1.23.1/Source/_javascript_Core/jit/ThunkGenerators.cpp
tags/Safari-605.1.23.1/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm




Diff

Modified: tags/Safari-605.1.23.1/Source/_javascript_Core/ChangeLog (227163 => 227164)

--- tags/Safari-605.1.23.1/Source/_javascript_Core/ChangeLog	2018-01-18 21:51:42 UTC (rev 227163)
+++ tags/Safari-605.1.23.1/Source/_javascript_Core/ChangeLog	2018-01-18 21:51:45 UTC (rev 227164)
@@ -1,3 +1,31 @@
+2018-01-18  Jason Marcell  
+
+Cherry-pick r227152. rdar://problem/36628594
+
+2018-01-18  Michael Saboff  
+
+REGRESSION (r226068): [X86] Crash in _javascript_Core ShadowChicken when handling exceptions
+https://bugs.webkit.org/show_bug.cgi?id=181802
+
+Reviewed by Filip Pizlo.
+
+There where a few places where the stack isn't properly aligned for X86 when we call into C++ code.
+Two places are where we call into exception handling code, the LLInt and from nativeForGenerator.
+The other place was when we call into the operationOSRWriteBarrier().
+
+Added an assert check that the stack is aligned on X86 platforms in the native call tracing code.
+This helped find the other cases beyond the original problem.
+
+* dfg/DFGOSRExitCompilerCommon.cpp:
+(JSC::DFG::osrWriteBarrier):
+* interpreter/FrameTracers.h:
+(JSC::assertStackPointerIsAligned):
+(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
+(JSC::NativeCallFrameTracerWithRestore::NativeCallFrameTracerWithRestore):
+* jit/ThunkGenerators.cpp:
+(JSC::nativeForGenerator):
+* llint/LowLevelInterpreter32_64.asm:
+
 2018-01-12  Jason Marcell  
 
 Apply patch. rdar://problem/36303061


Modified: tags/Safari-605.1.23.1/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp (227163 => 227164)

--- tags/Safari-605.1.23.1/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp	2018-01-18 21:51:42 UTC (rev 227163)
+++ tags/Safari-605.1.23.1/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp	2018-01-18 21:51:45 UTC (rev 227164)
@@ -258,7 +258,7 @@
 
 // We need these extra slots because setupArgumentsWithExecState will use poke on x86.
 #if CPU(X86)
-jit.subPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 3), MacroAssembler::stackPointerRegister);
+jit.subPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 4), MacroAssembler::stackPointerRegister);
 #endif
 
 jit.setupArgumentsWithExecState(owner);
@@ -266,7 +266,7 @@
 jit.call(scratch);
 
 #if CPU(X86)
-jit.addPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 3), MacroAssembler::stackPointerRegister);
+jit.addPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 4), MacroAssembler::stackPointerRegister);
 #endif
 
 ownerIsRememberedOrInEden.link();


Modified: tags/Safari-605.1.23.1/Source/_javascript_Core/interpreter/FrameTracers.h (227163 => 227164)

--- tags/Safari-605.1.23.1/Source/_javascript_Core/interpreter/FrameTracers.h	2018-01-18 21:51:42 UTC (rev 227163)
+++ tags/Safari-605.1.23.1/Source/_javascript_Core/interpreter/FrameTracers.h	2018-01-18 21:51:45 UTC (rev 227164)
@@ -26,6 +26,7 @@
 #pragma once
 
 #include "CatchScope.h"
+#include "StackAlignment.h"
 #include "VM.h"
 
 namespace JSC {
@@ -68,6 +69,18 @@
 CallFrame* oldCallFrame;
 };
 
+ALWAYS_INLINE static void assertStackPointerIsAligned()
+{
+#ifndef NDEBUG
+#if CPU(X86)
+uintptr_t stackPointer;
+
+asm("movl %%esp,%0" : "=r"(stackPointer));
+ASSERT(!(stackPointer % stackAlignmentBytes()));
+#endif
+#endif
+}
+
 class NativeCallFrameTracer {
 public:
 ALWAYS_INLINE NativeCallFrameTracer(VM* vm, CallFrame* callFrame)
@@ -75,6 +88,7 @@
 ASSERT(vm);
 ASSERT(callFrame);
 ASSERT(reinterpret_cast(callFrame) < reinterpret_cast(vm->topEntryFrame));
+assertStackPointerIsAligned();
 vm->topCallFrame = callFrame;
 }
 };
@@ -86,6 +100,7 @@
 {
 ASSERT(vm);
 ASSERT(callFrame);
+assertStackPointerIsAligned();
 m_savedTopEntryFrame = vm->topEntryFrame;
 m_savedTopCallFrame = vm->topCallFrame;
 vm->topEntryFrame = EntryFrame;


Modified: tags/Safari-605.1.23.1/Source/_javascript_Core/jit/ThunkGenerators.cpp (227163 => 227164)

--- tags/Safari-605.1.23.1/Source/_javascript_Core/jit/ThunkGenerators.cpp	2018-01-18 21:51:42 UTC (rev 

[webkit-changes] [227163] tags/Safari-605.1.23.1/Source

[jmarcell]

Title: [227163] tags/Safari-605.1.23.1/Source








Revision 227163
Author jmarc...@apple.com
Date 2018-01-18 13:51:42 -0800 (Thu, 18 Jan 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-605.1.23.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-605.1.23.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-605.1.23.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-605.1.23.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-605.1.23.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-605.1.23.1/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-605.1.23.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-605.1.23.1/Source/_javascript_Core/Configurations/Version.xcconfig (227162 => 227163)

--- tags/Safari-605.1.23.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-18 21:20:08 UTC (rev 227162)
+++ tags/Safari-605.1.23.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-01-18 21:51:42 UTC (rev 227163)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-605.1.23.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (227162 => 227163)

--- tags/Safari-605.1.23.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-18 21:20:08 UTC (rev 227162)
+++ tags/Safari-605.1.23.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-01-18 21:51:42 UTC (rev 227163)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-605.1.23.1/Source/WebCore/Configurations/Version.xcconfig (227162 => 227163)

--- tags/Safari-605.1.23.1/Source/WebCore/Configurations/Version.xcconfig	2018-01-18 21:20:08 UTC (rev 227162)
+++ tags/Safari-605.1.23.1/Source/WebCore/Configurations/Version.xcconfig	2018-01-18 21:51:42 UTC (rev 227163)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-605.1.23.1/Source/WebCore/PAL/Configurations/Version.xcconfig (227162 => 227163)

--- tags/Safari-605.1.23.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-18 21:20:08 UTC (rev 227162)
+++ tags/Safari-605.1.23.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-01-18 21:51:42 UTC (rev 227163)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-605.1.23.1/Source/WebInspectorUI/Configurations/Version.xcconfig (227162 => 227163)

--- tags/Safari-605.1.23.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-18 21:20:08 UTC (rev 227162)
+++ tags/Safari-605.1.23.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-01-18 21:51:42 UTC (rev 227163)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 23;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-605.1.23.1/Source/WebKit/Configurations/Version.xcconfig (227162 => 227163)

--- tags/Safari-605.1.23.1/Source/WebKit/Configurations/Version.xcconfig	2018-01-18 21:20:08 UTC (rev 227162)
+++ tags/Safari-605.1.23.1/Source/WebKit/Configurations/Version.xcconfig	2018-01-18 21:51:42 UTC (rev 227163)
@@ -24,9 

[webkit-changes] [227162] branches/safari-605-branch/Source/JavaScriptCore

[jmarcell]

Title: [227162] branches/safari-605-branch/Source/_javascript_Core








Revision 227162
Author jmarc...@apple.com
Date 2018-01-18 13:20:08 -0800 (Thu, 18 Jan 2018)


Log Message
Cherry-pick r227152. rdar://problem/36628552

Modified Paths

branches/safari-605-branch/Source/_javascript_Core/ChangeLog
branches/safari-605-branch/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp
branches/safari-605-branch/Source/_javascript_Core/interpreter/FrameTracers.h
branches/safari-605-branch/Source/_javascript_Core/jit/ThunkGenerators.cpp
branches/safari-605-branch/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm




Diff

Modified: branches/safari-605-branch/Source/_javascript_Core/ChangeLog (227161 => 227162)

--- branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-18 21:12:55 UTC (rev 227161)
+++ branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-18 21:20:08 UTC (rev 227162)
@@ -1,3 +1,31 @@
+2018-01-18  Jason Marcell  
+
+Cherry-pick r227152. rdar://problem/36628552
+
+2018-01-18  Michael Saboff  
+
+REGRESSION (r226068): [X86] Crash in _javascript_Core ShadowChicken when handling exceptions
+https://bugs.webkit.org/show_bug.cgi?id=181802
+
+Reviewed by Filip Pizlo.
+
+There where a few places where the stack isn't properly aligned for X86 when we call into C++ code.
+Two places are where we call into exception handling code, the LLInt and from nativeForGenerator.
+The other place was when we call into the operationOSRWriteBarrier().
+
+Added an assert check that the stack is aligned on X86 platforms in the native call tracing code.
+This helped find the other cases beyond the original problem.
+
+* dfg/DFGOSRExitCompilerCommon.cpp:
+(JSC::DFG::osrWriteBarrier):
+* interpreter/FrameTracers.h:
+(JSC::assertStackPointerIsAligned):
+(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
+(JSC::NativeCallFrameTracerWithRestore::NativeCallFrameTracerWithRestore):
+* jit/ThunkGenerators.cpp:
+(JSC::nativeForGenerator):
+* llint/LowLevelInterpreter32_64.asm:
+
 2018-01-17  Jason Marcell  
 
 Cherry-pick r227104. rdar://problem/36609536


Modified: branches/safari-605-branch/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp (227161 => 227162)

--- branches/safari-605-branch/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp	2018-01-18 21:12:55 UTC (rev 227161)
+++ branches/safari-605-branch/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp	2018-01-18 21:20:08 UTC (rev 227162)
@@ -258,7 +258,7 @@
 
 // We need these extra slots because setupArgumentsWithExecState will use poke on x86.
 #if CPU(X86)
-jit.subPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 3), MacroAssembler::stackPointerRegister);
+jit.subPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 4), MacroAssembler::stackPointerRegister);
 #endif
 
 jit.setupArgumentsWithExecState(owner);
@@ -266,7 +266,7 @@
 jit.call(scratch);
 
 #if CPU(X86)
-jit.addPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 3), MacroAssembler::stackPointerRegister);
+jit.addPtr(MacroAssembler::TrustedImm32(sizeof(void*) * 4), MacroAssembler::stackPointerRegister);
 #endif
 
 ownerIsRememberedOrInEden.link();


Modified: branches/safari-605-branch/Source/_javascript_Core/interpreter/FrameTracers.h (227161 => 227162)

--- branches/safari-605-branch/Source/_javascript_Core/interpreter/FrameTracers.h	2018-01-18 21:12:55 UTC (rev 227161)
+++ branches/safari-605-branch/Source/_javascript_Core/interpreter/FrameTracers.h	2018-01-18 21:20:08 UTC (rev 227162)
@@ -26,6 +26,7 @@
 #pragma once
 
 #include "CatchScope.h"
+#include "StackAlignment.h"
 #include "VM.h"
 
 namespace JSC {
@@ -68,6 +69,18 @@
 CallFrame* oldCallFrame;
 };
 
+ALWAYS_INLINE static void assertStackPointerIsAligned()
+{
+#ifndef NDEBUG
+#if CPU(X86)
+uintptr_t stackPointer;
+
+asm("movl %%esp,%0" : "=r"(stackPointer));
+ASSERT(!(stackPointer % stackAlignmentBytes()));
+#endif
+#endif
+}
+
 class NativeCallFrameTracer {
 public:
 ALWAYS_INLINE NativeCallFrameTracer(VM* vm, CallFrame* callFrame)
@@ -75,6 +88,7 @@
 ASSERT(vm);
 ASSERT(callFrame);
 ASSERT(reinterpret_cast(callFrame) < reinterpret_cast(vm->topEntryFrame));
+assertStackPointerIsAligned();
 vm->topCallFrame = callFrame;
 }
 };
@@ -86,6 +100,7 @@
 {
 ASSERT(vm);
 ASSERT(callFrame);
+assertStackPointerIsAligned();
 m_savedTopEntryFrame = vm->topEntryFrame;
 m_savedTopCallFrame = vm->topCallFrame;
 vm->topEntryFrame = EntryFrame;


Modified: branches/safari-605-branch/Source/_javascript_Core/jit/ThunkGenerators.cpp (227161 => 227162)

--- 

[webkit-changes] [227161] trunk/Source

[commit-queue]

Title: [227161] trunk/Source








Revision 227161
Author commit-qu...@webkit.org
Date 2018-01-18 13:12:55 -0800 (Thu, 18 Jan 2018)


Log Message
Do not go to the storage process when loading a main resource if there is no service worker registered
https://bugs.webkit.org/show_bug.cgi?id=181395

Patch by Youenn Fablet  on 2018-01-18
Reviewed by Chris Dumez.

Source/WebCore:

No observable behavior change.
Instead of creating a connection to know whether there is a potential service worker,
Ask the service worker provider that will use the connection if needed.
Otherwise, it will use a default value provided by the UIProcess.

Tested by cleaning all service workers and checking the computed value of the default value,
then observing whether pages registering service workers work well.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
* workers/service/ServiceWorkerProvider.cpp:
(WebCore::ServiceWorkerProvider::mayHaveServiceWorkerRegisteredForOrigin):
* workers/service/ServiceWorkerProvider.h:

Source/WebKit:

Add a new web process creation parameter to know whether there is any service worker registered at web process creation time.
If there is none, the web process will then start to load HTTP resources from the network.
The connection to the storage process is then executed when receiving the first bytes of the main resource.
This connection is needed as other web processes may create service workers at any given time.
If there is one registered service worker, the web process will wait for its connection to the storage process to be active.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/ServiceWorkerProcessProxy.cpp:
(WebKit::ServiceWorkerProcessProxy::hasRegisteredServiceWorkers):
* UIProcess/ServiceWorkerProcessProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession):
* WebProcess/Storage/WebServiceWorkerProvider.h:
* WebProcess/Storage/WebToStorageProcessConnection.h:
(WebKit::WebToStorageProcessConnection::existingServiceWorkerConnectionForSession):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerProvider.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerProvider.h
trunk/Source/WebCore/workers/service/server/RegistrationDatabase.cpp
trunk/Source/WebCore/workers/service/server/RegistrationDatabase.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp
trunk/Source/WebKit/UIProcess/ServiceWorkerProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp
trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.h
trunk/Source/WebKit/WebProcess/Storage/WebToStorageProcessConnection.h
trunk/Source/WebKit/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (227160 => 227161)

--- trunk/Source/WebCore/ChangeLog	2018-01-18 21:08:52 UTC (rev 227160)
+++ trunk/Source/WebCore/ChangeLog	2018-01-18 21:12:55 UTC (rev 227161)
@@ -1,3 +1,24 @@
+2018-01-18  Youenn Fablet  
+
+Do not go to the storage process when loading a main resource if there is no service worker registered
+https://bugs.webkit.org/show_bug.cgi?id=181395
+
+Reviewed by Chris Dumez.
+
+No observable behavior change.
+Instead of creating a connection to know whether there is a potential service worker,
+Ask the service worker provider that will use the connection if needed.
+Otherwise, it will use a default value provided by the UIProcess.
+
+Tested by cleaning all service workers and checking the computed value of the default value,
+then observing whether pages registering service workers work well.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::startLoadingMainResource):
+* workers/service/ServiceWorkerProvider.cpp:
+(WebCore::ServiceWorkerProvider::mayHaveServiceWorkerRegisteredForOrigin):
+* workers/service/ServiceWorkerProvider.h:
+
 2018-01-18  Dan Bernstein  
 
 [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (227160 => 227161)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2018-01-18 21:08:52 UTC (rev 227160)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2018-01-18 21:12:55 UTC 

[webkit-changes] [227160] tags/Safari-605.1.23.1/

[jmarcell]

Title: [227160] tags/Safari-605.1.23.1/








Revision 227160
Author jmarc...@apple.com
Date 2018-01-18 13:08:52 -0800 (Thu, 18 Jan 2018)


Log Message
New tag.

Added Paths

tags/Safari-605.1.23.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227157] trunk/Source/WebKit

[cdumez]

Title: [227157] trunk/Source/WebKit








Revision 227157
Author cdu...@apple.com
Date 2018-01-18 12:10:58 -0800 (Thu, 18 Jan 2018)


Log Message
Regression(r223149): WebProcessProxy::didClose() no longer refs WebPageProxy objects
https://bugs.webkit.org/show_bug.cgi?id=181771


Reviewed by Brady Eidson.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
Use copyToVectorOf() to maintain pre-r223149 behavior
and ref the pages.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (227156 => 227157)

--- trunk/Source/WebKit/ChangeLog	2018-01-18 19:49:51 UTC (rev 227156)
+++ trunk/Source/WebKit/ChangeLog	2018-01-18 20:10:58 UTC (rev 227157)
@@ -1,3 +1,16 @@
+2018-01-18  Chris Dumez  
+
+Regression(r223149): WebProcessProxy::didClose() no longer refs WebPageProxy objects
+https://bugs.webkit.org/show_bug.cgi?id=181771
+
+
+Reviewed by Brady Eidson.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::didClose):
+Use copyToVectorOf() to maintain pre-r223149 behavior
+and ref the pages.
+
 2018-01-18  Dan Bernstein  
 
 [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions


Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (227156 => 227157)

--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2018-01-18 19:49:51 UTC (rev 227156)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2018-01-18 20:10:58 UTC (rev 227157)
@@ -628,7 +628,7 @@
 
 webConnection()->didClose();
 
-auto pages = copyToVector(m_pageMap.values());
+auto pages = copyToVectorOf(m_pageMap.values());
 
 shutDown();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227156] trunk

[mitz]

Title: [227156] trunk








Revision 227156
Author m...@apple.com
Date 2018-01-18 11:49:51 -0800 (Thu, 18 Jan 2018)


Log Message
[Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
https://bugs.webkit.org/show_bug.cgi?id=181803

Reviewed by Tim Horton.

Source/bmalloc:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.

Source/_javascript_Core:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.
* Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
* Configurations/Version.xcconfig: Updated.
* Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
  useful for defining settings that depend on the target macOS version.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.

Source/ThirdParty/libwebrtc:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.
* Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
  useful for defining settings that depend on the target macOS version.
* Configurations/opus.xcconfig: Adopted macOSTargetConditionals helper.

Source/WebCore:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.
* Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
* Configurations/Version.xcconfig: Updated.
* Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
  useful for defining settings that depend on the target macOS version.

Source/WebCore/PAL:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.
* Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
* Configurations/Version.xcconfig: Updated.
* Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
  useful for defining settings that depend on the target macOS version.

Source/WebInspectorUI:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.
* Configurations/Version.xcconfig: Ditto.

Source/WebKit:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.
* Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
* Configurations/Version.xcconfig: Updated.
* Configurations/macOSTargetConditionals.xcconfig: Added.  Defines helper build settings
  useful for defining settings that depend on the target macOS version.

Source/WebKitLegacy/mac:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Ditto.
* Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
* Configurations/Version.xcconfig: Updated.
* Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
  useful for defining settings that depend on the target macOS version.

Source/WTF:

* Configurations/Base.xcconfig: Updated.
* Configurations/DebugRelease.xcconfig: Updated.

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
* ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
* ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
* MiniBrowser/Configurations/Base.xcconfig: Ditto.
* MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
* TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
* TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
  helpers.
* TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
  settings useful for defining settings that depend on the target macOS version.
* WebKitTestRunner/Configurations/Base.xcconfig: Updated.
* WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/_javascript_Core/Configurations/DebugRelease.xcconfig
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/DebugRelease.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Configurations/Base.xcconfig
trunk/Source/WTF/Configurations/DebugRelease.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/Base.xcconfig
trunk/Source/WebCore/Configurations/DebugRelease.xcconfig

[webkit-changes] [227154] trunk/Tools

[lingcherd_ho]

Title: [227154] trunk/Tools








Revision 227154
Author lingcherd...@apple.com
Date 2018-01-18 11:01:26 -0800 (Thu, 18 Jan 2018)


Log Message
Remove Opensource El Capitan queues from buildbot
https://bugs.webkit.org/show_bug.cgi?id=181712

Reviewed by Aakash Jain.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (227153 => 227154)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-01-18 18:46:43 UTC (rev 227153)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-01-18 19:01:26 UTC (rev 227154)
@@ -1,25 +1,6 @@
 {
 "slaves": [ { "name": "test-slave", "platform": "*" },
 
-{ "name": "bot123", "platform": "mac-elcapitan" },
-{ "name": "bot126", "platform": "mac-elcapitan" },
-{ "name": "bot133", "platform": "mac-elcapitan" },
-{ "name": "bot145", "platform": "mac-elcapitan" },
-{ "name": "bot162", "platform": "mac-elcapitan" },
-{ "name": "bot165", "platform": "mac-elcapitan" },
-{ "name": "bot169", "platform": "mac-elcapitan" },
-{ "name": "bot170", "platform": "mac-elcapitan" },
-{ "name": "bot173", "platform": "mac-elcapitan" },
-{ "name": "bot174", "platform": "mac-elcapitan" },
-{ "name": "bot208", "platform": "mac-elcapitan" },
-{ "name": "bot209", "platform": "mac-elcapitan" },
-{ "name": "bot210", "platform": "mac-elcapitan" },
-{ "name": "bot415", "platform": "mac-elcapitan" },
-{ "name": "bot416", "platform": "mac-elcapitan" },
-{ "name": "bot417", "platform": "mac-elcapitan" },
-{ "name": "bot418", "platform": "mac-elcapitan" },
-{ "name": "bot419", "platform": "mac-elcapitan" },
-
 { "name": "bot121", "platform": "mac-highsierra" },
 { "name": "bot155", "platform": "mac-highsierra" },
 { "name": "bot153", "platform": "mac-highsierra" },
@@ -185,70 +166,15 @@
   "platform": "mac-sierra", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["bot600"]
 },
-{ "name": "Apple El Capitan Debug (Build)", "type": "Build", "builddir": "elcapitan-debug",
-  "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],
-  "triggers": ["elcapitan-debug-tests-jsc", "elcapitan-debug-tests-test262", "elcapitan-debug-tests-wk1", "elcapitan-debug-tests-wk2"],
-  "slavenames": ["bot415", "bot416"]
-},
-{ "name": "Apple El Capitan CMake Debug (Build)", "type": "Build", "builddir": "elcapitan-cmake-debug",
-  "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],
-  "additionalArguments": ["--cmake", "--verbose"],
-  "slavenames": ["bot170"]
-},
-{ "name": "Apple El Capitan Debug JSC (Tests)", "type": "TestJSC", "builddir": "elcapitan-debug-tests-jsc",
-  "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],
-  "slavenames": ["bot210"]
-},
-{ "name": "Apple El Capitan Debug WK1 (Tests)", "type": "TestWebKit1AllButJSC", "builddir": "elcapitan-debug-tests-wk1",
-  "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],
-  "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout"],
-  "slavenames": ["bot133", "bot145"]
-},
-{ "name": "Apple El Capitan Debug WK2 (Tests)", "type": "TestAllButJSC", "builddir": "elcapitan-debug-tests-wk2",
-  "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],
-  "additionalArguments": ["--no-retry-failures", "--no-sample-on-timeout"],
-  "slavenames": ["bot162", "bot165"]
-},
 { "name": "Apple Sierra Debug Test262 (Tests)", "type": "Test262", "builddir": 

[webkit-changes] [227153] trunk

[cdumez]

Title: [227153] trunk








Revision 227153
Author cdu...@apple.com
Date 2018-01-18 10:46:43 -0800 (Thu, 18 Jan 2018)


Log Message
Service Workers restored from persistent storage have 'redundant' state
https://bugs.webkit.org/show_bug.cgi?id=181749


Reviewed by Youenn Fablet.

Source/WebCore:

Tested by new API test.

* workers/service/server/SWServer.cpp:
(WebCore::SWServer::installContextData):
Make sure the SWServerWorker's state is set to "activated" after it is assigned to
the registrations' active slot. Otherwise, it stays in its default state (redundant).

Source/WebKit:

Allow service workers to intercept custom protocol loads as this is useful for
API testing.

* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
* WebProcess/Network/WebLoaderStrategy.h:

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (227152 => 227153)

--- trunk/Source/WebCore/ChangeLog	2018-01-18 18:44:30 UTC (rev 227152)
+++ trunk/Source/WebCore/ChangeLog	2018-01-18 18:46:43 UTC (rev 227153)
@@ -1,3 +1,18 @@
+2018-01-18  Chris Dumez  
+
+Service Workers restored from persistent storage have 'redundant' state
+https://bugs.webkit.org/show_bug.cgi?id=181749
+
+
+Reviewed by Youenn Fablet.
+
+Tested by new API test.
+
+* workers/service/server/SWServer.cpp:
+(WebCore::SWServer::installContextData):
+Make sure the SWServerWorker's state is set to "activated" after it is assigned to
+the registrations' active slot. Otherwise, it stays in its default state (redundant).
+
 2018-01-18  Antti Koivisto  
 
 REGRESSION(r225650): The scores of MotionMark tests Multiply and Leaves dropped by 8%


Modified: trunk/Source/WebCore/workers/service/server/SWServer.cpp (227152 => 227153)

--- trunk/Source/WebCore/workers/service/server/SWServer.cpp	2018-01-18 18:44:30 UTC (rev 227152)
+++ trunk/Source/WebCore/workers/service/server/SWServer.cpp	2018-01-18 18:46:43 UTC (rev 227153)
@@ -490,6 +490,7 @@
 // as it is unlikely they will be needed immediately.
 if (data.loadedFromDisk) {
 registration->updateRegistrationState(ServiceWorkerRegistrationState::Active, worker.ptr());
+worker->setState(ServiceWorkerState::Activated);
 return;
 }
 


Modified: trunk/Source/WebKit/ChangeLog (227152 => 227153)

--- trunk/Source/WebKit/ChangeLog	2018-01-18 18:44:30 UTC (rev 227152)
+++ trunk/Source/WebKit/ChangeLog	2018-01-18 18:46:43 UTC (rev 227153)
@@ -1,3 +1,19 @@
+2018-01-18  Chris Dumez  
+
+Service Workers restored from persistent storage have 'redundant' state
+https://bugs.webkit.org/show_bug.cgi?id=181749
+
+
+Reviewed by Youenn Fablet.
+
+Allow service workers to intercept custom protocol loads as this is useful for
+API testing.
+
+* WebProcess/Network/WebLoaderStrategy.cpp:
+(WebKit::WebLoaderStrategy::scheduleLoad):
+(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
+* WebProcess/Network/WebLoaderStrategy.h:
+
 2018-01-18  Brent Fulgham  
 
 REGRESSION(r225858): Sandbox violations due to blocked access to Spotlight search preferences


Modified: trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp (227152 => 227153)

--- trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2018-01-18 18:44:30 UTC (rev 227152)
+++ trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2018-01-18 18:46:43 UTC (rev 227153)
@@ -208,23 +208,12 @@
 }
 #endif
 
-auto* webFrameLoaderClient = toWebFrameLoaderClient(resourceLoader.frameLoader()->client());
-auto* webFrame = webFrameLoaderClient ? webFrameLoaderClient->webFrame() : nullptr;
-auto* webPage = webFrame ? webFrame->page() : nullptr;
-if (webPage) {
-if (auto* handler = webPage->urlSchemeHandlerForScheme(resourceLoader.request().url().protocol().toStringWithoutCopying())) {
-LOG(NetworkScheduling, "(WebProcess) WebLoaderStrategy::scheduleLoad, URL '%s' will be handled by a UIProcess URL scheme handler.", resourceLoader.url().string().utf8().data());
-RELEASE_LOG_IF_ALLOWED(resourceLoader, "scheduleLoad: URL will be handled by a UIProcess URL scheme handler (frame = %p, resourceID = %" PRIu64 ")", resourceLoader.frame(), identifier);
-
-

[webkit-changes] [227150] trunk/Tools

[ryanhaddad]

Title: [227150] trunk/Tools








Revision 227150
Author ryanhad...@apple.com
Date 2018-01-18 10:31:42 -0800 (Thu, 18 Jan 2018)


Log Message
Add triggers for Sierra test262 and perf queues
https://bugs.webkit.org/show_bug.cgi?id=181799

Reviewed by Aakash Jain.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (227149 => 227150)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-01-18 18:15:07 UTC (rev 227149)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2018-01-18 18:31:42 UTC (rev 227150)
@@ -153,7 +153,7 @@
 },
 { "name": "Apple Sierra Debug (Build)", "type": "Build", "builddir": "sierra-debug",
   "platform": "mac-sierra", "configuration": "debug", "architectures": ["x86_64"],
-  "triggers": ["sierra-debug-tests-wk1", "sierra-debug-tests-wk2"],
+  "triggers": ["sierra-debug-tests-wk1", "sierra-debug-tests-wk2", "sierra-debug-tests-test262"],
   "slavenames": ["bot439", "bot698"]
 },
 { "name": "Apple Sierra Debug WK1 (Tests)", "type": "TestWebKit1AllButJSC", "builddir": "sierra-debug-tests-wk1",
@@ -168,7 +168,7 @@
 },
 { "name": "Apple Sierra Release (Build)", "type": "Build", "builddir": "sierra-release",
   "platform": "mac-sierra", "configuration": "release", "architectures": ["x86_64"],
-  "triggers": ["sierra-release-tests-wk1", "sierra-release-tests-wk2"],
+  "triggers": ["sierra-release-tests-wk1", "sierra-release-tests-wk2", "sierra-release-tests-test262", "sierra-release-perf-tests"],
   "slavenames": ["bot443", "bot699"]
 },
 { "name": "Apple Sierra Release WK1 (Tests)", "type": "TestWebKit1AllButJSC", "builddir": "sierra-release-tests-wk1",


Modified: trunk/Tools/ChangeLog (227149 => 227150)

--- trunk/Tools/ChangeLog	2018-01-18 18:15:07 UTC (rev 227149)
+++ trunk/Tools/ChangeLog	2018-01-18 18:31:42 UTC (rev 227150)
@@ -1,3 +1,12 @@
+2018-01-18  Ryan Haddad  
+
+Add triggers for Sierra test262 and perf queues
+https://bugs.webkit.org/show_bug.cgi?id=181799
+
+Reviewed by Aakash Jain.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2018-01-18  Wenson Hsieh  
 
 [iOS] Specify -[NSURL _title] for the associated URL when copying an image element






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227149] branches/safari-605-branch/Source/WebKit

[jmarcell]

Title: [227149] branches/safari-605-branch/Source/WebKit








Revision 227149
Author jmarc...@apple.com
Date 2018-01-18 10:15:07 -0800 (Thu, 18 Jan 2018)


Log Message
Cherry-pick r227146. rdar://problem/36624319

Modified Paths

branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: branches/safari-605-branch/Source/WebKit/ChangeLog (227148 => 227149)

--- branches/safari-605-branch/Source/WebKit/ChangeLog	2018-01-18 18:12:58 UTC (rev 227148)
+++ branches/safari-605-branch/Source/WebKit/ChangeLog	2018-01-18 18:15:07 UTC (rev 227149)
@@ -1,3 +1,18 @@
+2018-01-18  Jason Marcell  
+
+Cherry-pick r227146. rdar://problem/36624319
+
+2018-01-18  Brent Fulgham  
+
+REGRESSION(r225858): Sandbox violations due to blocked access to Spotlight search preferences
+https://bugs.webkit.org/show_bug.cgi?id=181797
+
+
+Reviewed by Eric Carlson.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Add the read permission for
+'com.apple.lookup.shared' to support DataDetectors.
+
 2018-01-17  Jason Marcell  
 
 Cherry-pick r227103. rdar://problem/36598105


Modified: branches/safari-605-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (227148 => 227149)

--- branches/safari-605-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2018-01-18 18:12:58 UTC (rev 227148)
+++ branches/safari-605-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2018-01-18 18:15:07 UTC (rev 227149)
@@ -146,7 +146,9 @@
 ;  Weather(1038) deny file-read-data ~/Library/Preferences/com.apple.keyboard.plist
 "com.apple.keyboard"
 ; 
-"com.apple.Preferences")
+"com.apple.Preferences"
+"com.apple.lookup.shared" ; Needed for DataDetector (Spotlight) support
+)
 
 ;;  Need read access to /var/mobile/Library/Fonts to all apps
 (allow file-read*






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227146] trunk/Source/WebKit

[bfulgham]

Title: [227146] trunk/Source/WebKit








Revision 227146
Author bfulg...@apple.com
Date 2018-01-18 09:49:44 -0800 (Thu, 18 Jan 2018)


Log Message
REGRESSION(r225858): Sandbox violations due to blocked access to Spotlight search preferences
https://bugs.webkit.org/show_bug.cgi?id=181797


Reviewed by Eric Carlson.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Add the read permission for
'com.apple.lookup.shared' to support DataDetectors.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (227145 => 227146)

--- trunk/Source/WebKit/ChangeLog	2018-01-18 17:37:28 UTC (rev 227145)
+++ trunk/Source/WebKit/ChangeLog	2018-01-18 17:49:44 UTC (rev 227146)
@@ -1,3 +1,14 @@
+2018-01-18  Brent Fulgham  
+
+REGRESSION(r225858): Sandbox violations due to blocked access to Spotlight search preferences
+https://bugs.webkit.org/show_bug.cgi?id=181797
+
+
+Reviewed by Eric Carlson.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Add the read permission for
+'com.apple.lookup.shared' to support DataDetectors.
+
 2018-01-17  John Wilander  
 
 Resource Load Statistics: Block cookies for prevalent resources without user interaction


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (227145 => 227146)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2018-01-18 17:37:28 UTC (rev 227145)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2018-01-18 17:49:44 UTC (rev 227146)
@@ -135,7 +135,9 @@
 ;  Weather(1038) deny file-read-data ~/Library/Preferences/com.apple.keyboard.plist
 "com.apple.keyboard"
 ; 
-"com.apple.Preferences")
+"com.apple.Preferences"
+"com.apple.lookup.shared" ; Needed for DataDetector (Spotlight) support
+)
 
 ;;  Need read access to /var/mobile/Library/Fonts to all apps
 (allow file-read*






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227147] trunk/Source/WebCore

[antti]

Title: [227147] trunk/Source/WebCore








Revision 227147
Author an...@apple.com
Date 2018-01-18 09:50:00 -0800 (Thu, 18 Jan 2018)


Log Message
REGRESSION(r225650): The scores of MotionMark tests Multiply and Leaves dropped by 8%
https://bugs.webkit.org/show_bug.cgi?id=181460


Reviewed by Ryosuke Niwa.

* css/parser/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):

Don't do the expensive security origin test if the supplied sheet base URL is null. This
is true for rules coming from the same document.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSParser.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (227146 => 227147)

--- trunk/Source/WebCore/ChangeLog	2018-01-18 17:49:44 UTC (rev 227146)
+++ trunk/Source/WebCore/ChangeLog	2018-01-18 17:50:00 UTC (rev 227147)
@@ -1,5 +1,19 @@
 2018-01-18  Antti Koivisto  
 
+REGRESSION(r225650): The scores of MotionMark tests Multiply and Leaves dropped by 8%
+https://bugs.webkit.org/show_bug.cgi?id=181460
+
+
+Reviewed by Ryosuke Niwa.
+
+* css/parser/CSSParser.cpp:
+(WebCore::CSSParserContext::CSSParserContext):
+
+Don't do the expensive security origin test if the supplied sheet base URL is null. This
+is true for rules coming from the same document.
+
+2018-01-18  Antti Koivisto  
+
 REGRESSION (r223604): Setting :before/after pseudo element on  asserts
 https://bugs.webkit.org/show_bug.cgi?id=181795
 


Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (227146 => 227147)

--- trunk/Source/WebCore/css/parser/CSSParser.cpp	2018-01-18 17:49:44 UTC (rev 227146)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp	2018-01-18 17:50:00 UTC (rev 227147)
@@ -78,8 +78,9 @@
 , mode(document.inQuirksMode() ? HTMLQuirksMode : HTMLStandardMode)
 , isHTMLDocument(document.isHTMLDocument())
 , cssGridLayoutEnabled(document.isCSSGridLayoutEnabled())
-, hasDocumentSecurityOrigin(document.securityOrigin().canRequest(baseURL))
+, hasDocumentSecurityOrigin(sheetBaseURL.isNull() || document.securityOrigin().canRequest(baseURL))
 {
+
 needsSiteSpecificQuirks = document.settings().needsSiteSpecificQuirks();
 enforcesCSSMIMETypeInNoQuirksMode = document.settings().enforceCSSMIMETypeInNoQuirksMode();
 useLegacyBackgroundSizeShorthandBehavior = document.settings().useLegacyBackgroundSizeShorthandBehavior();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227144] trunk

[cfleizach]

Title: [227144] trunk








Revision 227144
Author cfleiz...@apple.com
Date 2018-01-18 09:26:23 -0800 (Thu, 18 Jan 2018)


Log Message
AX: Aria-activedescendant not supported
https://bugs.webkit.org/show_bug.cgi?id=161734


Reviewed by Joanmarie Diggs.

Source/WebCore:

When a combo-box owns/controls a list/listbox/grid/tree, the owned element needs to check the active-descendant of the combobox when
checking if it has selected children.
The target of the selection change notification should also be the owned element in these cases.

Test: accessibility/aria-combobox-controlling-list.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectedListItem):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::targetElementForActiveDescendant const):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::canHaveSelectedChildren const):
(WebCore::AccessibilityRenderObject::selectedChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

* accessibility/aria-combobox-control-owns-elements-expected.txt: Added.
* accessibility/aria-combobox-control-owns-elements.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/lists-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h
trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm


Added Paths

trunk/LayoutTests/accessibility/aria-combobox-control-owns-elements-expected.txt
trunk/LayoutTests/accessibility/aria-combobox-control-owns-elements.html




Diff

Modified: trunk/LayoutTests/ChangeLog (227143 => 227144)

--- trunk/LayoutTests/ChangeLog	2018-01-18 16:52:35 UTC (rev 227143)
+++ trunk/LayoutTests/ChangeLog	2018-01-18 17:26:23 UTC (rev 227144)
@@ -1,3 +1,14 @@
+2018-01-18  Chris Fleizach  
+
+AX: Aria-activedescendant not supported
+https://bugs.webkit.org/show_bug.cgi?id=161734
+
+
+Reviewed by Joanmarie Diggs.
+
+* accessibility/aria-combobox-control-owns-elements-expected.txt: Added.
+* accessibility/aria-combobox-control-owns-elements.html: Added.
+
 2018-01-18  Per Arne Vollan  
 
 Mark fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html as failing on Windows.


Added: trunk/LayoutTests/accessibility/aria-combobox-control-owns-elements-expected.txt (0 => 227144)

--- trunk/LayoutTests/accessibility/aria-combobox-control-owns-elements-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/aria-combobox-control-owns-elements-expected.txt	2018-01-18 17:26:23 UTC (rev 227144)
@@ -0,0 +1,36 @@
+
+item1
+item2
+
+item1
+item2
+
+cell1
+
+treeitem1
+treeitem2
+This tests variations of the comboboxes and elements it can control and own. Then verifies the active-descendant is reflected correctly.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS list.selectedChildrenCount is 0
+PASS list.selectedChildrenCount is 1
+PASS list.selectedChildAtIndex(0).isEqual(listitem1) is true
+PASS listbox.selectedChildrenCount is 0
+PASS listbox.selectedChildrenCount is 1
+PASS listbox.selectedChildAtIndex(0).isEqual(option2_1) is true
+PASS grid.selectedChildrenCount is 0
+PASS grid.selectedChildrenCount is 1
+PASS grid.selectedChildAtIndex(0).isEqual(row3_1) is true
+PASS tree.selectedChildrenCount is 0
+PASS tree.selectedChildrenCount is 1
+PASS tree.selectedChildAtIndex(0).isEqual(treeitem4_1) is true
+Received AXSelectedChildrenChanged for List1
+Received AXSelectedChildrenChanged for Listbox2
+Received AXSelectedRowsChanged for Grid3
+Received AXSelectedRowsChanged for Tree4
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/aria-combobox-control-owns-elements.html (0 => 227144)

--- trunk/LayoutTests/accessibility/aria-combobox-control-owns-elements.html	(rev 0)
+++ trunk/LayoutTests/accessibility/aria-combobox-control-owns-elements.html	2018-01-18 17:26:23 UTC (rev 227144)
@@ -0,0 +1,107 @@
+
+
+
+
+
+
+
+
+

+
item1
+
item2
+
+
+
+
+

+

[webkit-changes] [227143] trunk/LayoutTests

[pvollan]

Title: [227143] trunk/LayoutTests








Revision 227143
Author pvol...@apple.com
Date 2018-01-18 08:52:35 -0800 (Thu, 18 Jan 2018)


Log Message
Mark fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=181662

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227142 => 227143)

--- trunk/LayoutTests/ChangeLog	2018-01-18 16:46:12 UTC (rev 227142)
+++ trunk/LayoutTests/ChangeLog	2018-01-18 16:52:35 UTC (rev 227143)
@@ -1,3 +1,12 @@
+2018-01-18  Per Arne Vollan  
+
+Mark fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html as failing on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=181662
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2018-01-17  Per Arne Vollan  
 
 REGRESSION (r224780): Text stroke not applied to video captions.


Modified: trunk/LayoutTests/platform/win/TestExpectations (227142 => 227143)

--- trunk/LayoutTests/platform/win/TestExpectations	2018-01-18 16:46:12 UTC (rev 227142)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-01-18 16:52:35 UTC (rev 227143)
@@ -3844,3 +3844,6 @@
 webkit.org/b/181346 mathml/opentype/opentype-stretchy-horizontal.html [ Failure ]
 
 webkit.org/b/181501 accessibility/table-header-calculation-for-header-rows.html [ Failure ]
+
+webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html [ Failure ]
+webkit.org/b/181662 fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227142] trunk

[mitz]

Title: [227142] trunk








Revision 227142
Author m...@apple.com
Date 2018-01-18 08:46:12 -0800 (Thu, 18 Jan 2018)


Log Message
[Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
https://bugs.webkit.org/show_bug.cgi?id=181784

Reviewed by Anders Carlsson.

* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
* WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.

Modified Paths

trunk/ChangeLog
trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme
trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme




Diff

Modified: trunk/ChangeLog (227141 => 227142)

--- trunk/ChangeLog	2018-01-18 16:13:16 UTC (rev 227141)
+++ trunk/ChangeLog	2018-01-18 16:46:12 UTC (rev 227142)
@@ -1,3 +1,13 @@
+2018-01-18  Dan Bernstein  
+
+[Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
+https://bugs.webkit.org/show_bug.cgi?id=181784
+
+Reviewed by Anders Carlsson.
+
+* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
+* WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
+
 2018-01-17  Michael Catanzaro  
 
 WEBKIT_FRAMEWORK should not modify file-global include directories


Modified: trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme (227141 => 227142)

--- trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme	2018-01-18 16:13:16 UTC (rev 227141)
+++ trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme	2018-01-18 16:46:12 UTC (rev 227142)
@@ -4,24 +4,6 @@
   parallelizeBuildables = "NO"
   buildImplicitDependencies = "YES">
-  
- 
-
-   
-  
-  
-   
-
- 
-  
   
   buildForTesting = "YES"


Modified: trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme (227141 => 227142)

--- trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme	2018-01-18 16:13:16 UTC (rev 227141)
+++ trunk/WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme	2018-01-18 16:46:12 UTC (rev 227142)
@@ -4,24 +4,6 @@
   parallelizeBuildables = "NO"
   buildImplicitDependencies = "YES">
-  
- 
-
-   
-  
-  
-   
-
- 
-  
   
   buildForTesting = "YES"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227141] trunk

[pvollan]

Title: [227141] trunk








Revision 227141
Author pvol...@apple.com
Date 2018-01-18 08:13:16 -0800 (Thu, 18 Jan 2018)


Log Message
REGRESSION (r224780): Text stroke not applied to video captions.
https://bugs.webkit.org/show_bug.cgi?id=181743


Reviewed by Simon Fraser.

Source/WebCore:

Tests: media/track/track-css-visible-stroke-expected.html
   media/track/track-css-visible-stroke.html

After r224780, it is no longer possible to mix text stroke styles with webkit
legacy text stroke styles.

* css/StyleResolver.cpp:
(WebCore::isValidCueStyleProperty):
* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS const):

LayoutTests:

* media/track/track-css-stroke-cues-expected.txt:
* media/track/track-css-stroke-cues.html:
* media/track/track-css-visible-stroke-expected.html: Added.
* media/track/track-css-visible-stroke.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-css-stroke-cues-expected.txt
trunk/LayoutTests/media/track/track-css-stroke-cues.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp


Added Paths

trunk/LayoutTests/media/track/track-css-visible-stroke-expected.html
trunk/LayoutTests/media/track/track-css-visible-stroke.html




Diff

Modified: trunk/LayoutTests/ChangeLog (227140 => 227141)

--- trunk/LayoutTests/ChangeLog	2018-01-18 15:42:08 UTC (rev 227140)
+++ trunk/LayoutTests/ChangeLog	2018-01-18 16:13:16 UTC (rev 227141)
@@ -1,3 +1,16 @@
+2018-01-17  Per Arne Vollan  
+
+REGRESSION (r224780): Text stroke not applied to video captions.
+https://bugs.webkit.org/show_bug.cgi?id=181743
+
+
+Reviewed by Simon Fraser.
+
+* media/track/track-css-stroke-cues-expected.txt:
+* media/track/track-css-stroke-cues.html:
+* media/track/track-css-visible-stroke-expected.html: Added.
+* media/track/track-css-visible-stroke.html: Added.
+
 2018-01-18  Andy Estes  
 
 [Payment Request] Support a default shipping address for Apple Pay


Modified: trunk/LayoutTests/media/track/track-css-stroke-cues-expected.txt (227140 => 227141)

--- trunk/LayoutTests/media/track/track-css-stroke-cues-expected.txt	2018-01-18 15:42:08 UTC (rev 227140)
+++ trunk/LayoutTests/media/track/track-css-stroke-cues-expected.txt	2018-01-18 16:13:16 UTC (rev 227141)
@@ -2,8 +2,8 @@
 Test that style to all cues is applied correctly.
 EVENT(canplaythrough)
 EVENT(seeked)
-EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).webkitTextStrokeWidth == '4px') OK
-EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).webkitTextStrokeColor == 'rgb(0, 0, 0)') OK
+EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeWidth == '4px') OK
+EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeColor == 'rgb(0, 0, 0)') OK
 EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).paintOrder == 'stroke') OK
 EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinejoin == 'round') OK
 EXPECTED (getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinecap == 'round') OK


Modified: trunk/LayoutTests/media/track/track-css-stroke-cues.html (227140 => 227141)

--- trunk/LayoutTests/media/track/track-css-stroke-cues.html	2018-01-18 15:42:08 UTC (rev 227140)
+++ trunk/LayoutTests/media/track/track-css-stroke-cues.html	2018-01-18 16:13:16 UTC (rev 227141)
@@ -9,7 +9,7 @@
 
 
 
-video::cue { -webkit-text-stroke: 4px black; paint-order: stroke; stroke-linecap: round; stroke-linejoin: round;}
+video::cue { stroke-width: 4px; stroke-color: black; paint-order: stroke; stroke-linecap: round; stroke-linejoin: round;}
 
 
 
@@ -17,8 +17,8 @@
 
 function seeked()
 {
-testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).webkitTextStrokeWidth", "4px");
-testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).webkitTextStrokeColor", "rgb(0, 0, 0)");
+testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeWidth", "4px");
+testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeColor", "rgb(0, 0, 0)");
 testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).paintOrder", "stroke");
 testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinejoin", "round");
 testExpected("getComputedStyle(textTrackDisplayElement(video, 'cue')).strokeLinecap", "round");


Added: trunk/LayoutTests/media/track/track-css-visible-stroke-expected.html (0 => 227141)

--- trunk/LayoutTests/media/track/track-css-visible-stroke-expected.html	(rev 0)
+++ 

[webkit-changes] [227140] trunk

[aestes]

Title: [227140] trunk








Revision 227140
Author aes...@apple.com
Date 2018-01-18 07:42:08 -0800 (Thu, 18 Jan 2018)


Log Message
[Payment Request] Support a default shipping address for Apple Pay
https://bugs.webkit.org/show_bug.cgi?id=181754


Reviewed by Brady Eidson.

Source/WebCore:

Move shippingContact from ApplePayPaymentRequest to ApplePayRequestBase. This allows
merchants to specify a default shipping address when using Apple Pay with Payment Request.

This also fixes a bug found during testing where
+[NSPersonNameComponentsFormatter localizedStringFromPersonNameComponents:style:options:]
would throw an exception when passed a nil NSPersonNameComponents.

Test: http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html

* Modules/applepay/ApplePayPaymentRequest.h:
* Modules/applepay/ApplePayPaymentRequest.idl:
* Modules/applepay/ApplePayRequestBase.cpp:
(WebCore::convertAndValidate):
* Modules/applepay/ApplePayRequestBase.h:
* Modules/applepay/ApplePayRequestBase.idl:
* Modules/applepay/ApplePaySession.cpp:
(WebCore::convertAndValidate):
* Modules/applepay/ApplePaySessionPaymentRequest.h:
(WebCore::ApplePaySessionPaymentRequest::version const):
(WebCore::ApplePaySessionPaymentRequest::setVersion):
* Modules/applepay/cocoa/PaymentContactCocoa.mm:
(WebCore::convert):
* Modules/applepay/paymentrequest/ApplePayRequest.idl:
* testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeMerchantValidation):
* testing/MockPaymentCoordinator.h:

LayoutTests:

* http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt: Added.
* http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h
trunk/Source/WebCore/Modules/applepay/ApplePayPaymentRequest.idl
trunk/Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp
trunk/Source/WebCore/Modules/applepay/ApplePayRequestBase.h
trunk/Source/WebCore/Modules/applepay/ApplePayRequestBase.idl
trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp
trunk/Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h
trunk/Source/WebCore/Modules/applepay/cocoa/PaymentContactCocoa.mm
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayRequest.idl
trunk/Source/WebCore/testing/MockPaymentCoordinator.cpp
trunk/Source/WebCore/testing/MockPaymentCoordinator.h


Added Paths

trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt
trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html




Diff

Modified: trunk/LayoutTests/ChangeLog (227139 => 227140)

--- trunk/LayoutTests/ChangeLog	2018-01-18 14:33:32 UTC (rev 227139)
+++ trunk/LayoutTests/ChangeLog	2018-01-18 15:42:08 UTC (rev 227140)
@@ -1,3 +1,14 @@
+2018-01-18  Andy Estes  
+
+[Payment Request] Support a default shipping address for Apple Pay
+https://bugs.webkit.org/show_bug.cgi?id=181754
+
+
+Reviewed by Brady Eidson.
+
+* http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt: Added.
+* http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html: Added.
+
 2018-01-18  Ali Juma  
 
 imported/w3c/web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page.html is flaky


Added: trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt (0 => 227140)

--- trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https-expected.txt	2018-01-18 15:42:08 UTC (rev 227140)
@@ -0,0 +1,62 @@
+Test ApplePayRequest.shippingContact.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Test setting a default shipping contact in a version 2 request.
+PASS paymentResponse.details.shippingContact.phoneNumber is expectedPhoneNumber
+PASS paymentResponse.details.shippingContact.emailAddress is expectedEmailAddress
+PASS paymentResponse.details.shippingContact.givenName is expectedGivenName
+PASS paymentResponse.details.shippingContact.familyName is expectedFamilyName
+PASS paymentResponse.details.shippingContact.phoneticGivenName is undefined.
+PASS paymentResponse.details.shippingContact.phoneticFamilyName is undefined.
+PASS paymentResponse.details.shippingContact.addressLines is expectedAddressLines
+PASS paymentResponse.details.shippingContact.subLocality is expectedSubLocality
+PASS paymentResponse.details.shippingContact.locality is expectedLocality
+PASS paymentResponse.details.shippingContact.postalCode is expectedPostalCode
+PASS paymentResponse.details.shippingContact.subAdministrativeArea is expectedSubAdministrativeArea
+PASS 

[webkit-changes] [227138] trunk/WebDriverTests

[carlosgc]

Title: [227138] trunk/WebDriverTests








Revision 227138
Author carlo...@webkit.org
Date 2018-01-18 02:11:12 -0800 (Thu, 18 Jan 2018)


Log Message
Unreviewed. Update Selenium WebDriver imported tests.

* imported/selenium/importer.json:
* imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py:
(reset_timeouts):

Modified Paths

trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/imported/selenium/importer.json
trunk/WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py




Diff

Modified: trunk/WebDriverTests/ChangeLog (227137 => 227138)

--- trunk/WebDriverTests/ChangeLog	2018-01-18 08:33:14 UTC (rev 227137)
+++ trunk/WebDriverTests/ChangeLog	2018-01-18 10:11:12 UTC (rev 227138)
@@ -1,3 +1,11 @@
+2018-01-18  Carlos Garcia Campos  
+
+Unreviewed. Update Selenium WebDriver imported tests.
+
+* imported/selenium/importer.json:
+* imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py:
+(reset_timeouts):
+
 2018-01-17  Carlos Garcia Campos  
 
 WebDriver: ignore the driver in selenium test names when getting expectations


Modified: trunk/WebDriverTests/imported/selenium/importer.json (227137 => 227138)

--- trunk/WebDriverTests/imported/selenium/importer.json	2018-01-18 08:33:14 UTC (rev 227137)
+++ trunk/WebDriverTests/imported/selenium/importer.json	2018-01-18 10:11:12 UTC (rev 227138)
@@ -1,6 +1,6 @@
 {
 "repository": "https://github.com/SeleniumHQ/selenium.git",
-"revision": "c5e4a585f1e3c4b3468ec93ab50d3668d47aef1b",
+"revision": "569520625c9719e2f3e8669b638981e0c690a7d8",
 "paths_to_import": [
 "common",
 "py/conftest.py",


Modified: trunk/WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py (227137 => 227138)

--- trunk/WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py	2018-01-18 08:33:14 UTC (rev 227137)
+++ trunk/WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py	2018-01-18 10:11:12 UTC (rev 227138)
@@ -23,6 +23,13 @@
 from selenium.webdriver.remote.webelement import WebElement
 
 
+@pytest.fixture(autouse=True)
+def reset_timeouts(driver):
+driver.set_script_timeout(0)
+yield
+driver.set_script_timeout(30)
+
+
 def testShouldNotTimeoutIfCallbackInvokedImmediately(driver, pages):
 pages.load("ajaxy_page.html")
 result = driver.execute_async_script("arguments[arguments.length - 1](123);")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227137] trunk/LayoutTests

[jer . noble]

Title: [227137] trunk/LayoutTests








Revision 227137
Author jer.no...@apple.com
Date 2018-01-18 00:33:14 -0800 (Thu, 18 Jan 2018)


Log Message
Layout Test http/tests/images/image-supports-video.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=181008


Reviewed by Youenn Fablet.

Send a "Cache-control: nocache" header from the HTTP server when the image resource is
requested.

* http/tests/resources/redirect-to-video-if-accepted.php:
* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/resources/redirect-to-video-if-accepted.php
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227136 => 227137)

--- trunk/LayoutTests/ChangeLog	2018-01-18 08:27:27 UTC (rev 227136)
+++ trunk/LayoutTests/ChangeLog	2018-01-18 08:33:14 UTC (rev 227137)
@@ -1,3 +1,17 @@
+2018-01-18  Jer Noble  
+
+Layout Test http/tests/images/image-supports-video.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=181008
+
+
+Reviewed by Youenn Fablet.
+
+Send a "Cache-control: nocache" header from the HTTP server when the image resource is
+requested.
+
+* http/tests/resources/redirect-to-video-if-accepted.php:
+* platform/mac-wk1/TestExpectations:
+
 2018-01-17  Jer Noble  
 
 WebVTT served via HLS never results in cues


Modified: trunk/LayoutTests/http/tests/resources/redirect-to-video-if-accepted.php (227136 => 227137)

--- trunk/LayoutTests/http/tests/resources/redirect-to-video-if-accepted.php	2018-01-18 08:27:27 UTC (rev 227136)
+++ trunk/LayoutTests/http/tests/resources/redirect-to-video-if-accepted.php	2018-01-18 08:33:14 UTC (rev 227137)
@@ -2,6 +2,7 @@
 if (strpos($_SERVER['HTTP_ACCEPT'], 'video/*') !== false) {
 header('HTTP/1.1 301 Moved Permanently');
 header('Location: ' . $_GET['video']);
+header('Cache-Control: no-cache, must-revalidate');
 return;
 }
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (227136 => 227137)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-01-18 08:27:27 UTC (rev 227136)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-01-18 08:33:14 UTC (rev 227137)
@@ -485,7 +485,5 @@
 # User-installed fonts test infrastructure is not present in WK1
 webkit.org/b/180062 fast/text/user-installed-fonts [ ImageOnlyFailure ]
 
-webkit.org/b/181008 http/tests/images/image-supports-video.html [ Pass Failure ]
-
 webkit.org/b/180997 svg/animations/smil-leak-element-instances-noBaseValRef.svg [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227136] trunk/Source/JavaScriptCore

[commit-queue]

Title: [227136] trunk/Source/_javascript_Core








Revision 227136
Author commit-qu...@webkit.org
Date 2018-01-18 00:27:27 -0800 (Thu, 18 Jan 2018)


Log Message
Unreviewed, rolling out r227096.
https://bugs.webkit.org/show_bug.cgi?id=181788

"it caused a 15% octane regression" (Requested by saamyjoon on
#webkit).

Reverted changeset:

"Support MultiGetByOffset in the DFG"
https://bugs.webkit.org/show_bug.cgi?id=181466
https://trac.webkit.org/changeset/227096

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227135 => 227136)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-18 08:24:46 UTC (rev 227135)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-18 08:27:27 UTC (rev 227136)
@@ -1,3 +1,17 @@
+2018-01-18  Commit Queue  
+
+Unreviewed, rolling out r227096.
+https://bugs.webkit.org/show_bug.cgi?id=181788
+
+"it caused a 15% octane regression" (Requested by saamyjoon on
+#webkit).
+
+Reverted changeset:
+
+"Support MultiGetByOffset in the DFG"
+https://bugs.webkit.org/show_bug.cgi?id=181466
+https://trac.webkit.org/changeset/227096
+
 2018-01-17  Yusuke Suzuki  
 
 [DFG][FTL] Introduce PhantomNewRegexp and RegExpExecNonGlobalOrSticky


Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (227135 => 227136)

--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2018-01-18 08:24:46 UTC (rev 227135)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h	2018-01-18 08:27:27 UTC (rev 227136)
@@ -2886,6 +2886,10 @@
 // contradiction then there must always be a contradiction even if subsequent passes don't
 // realize it. This is the case here.
 
+// Ordinarily you have to be careful with calling setFoundConstants()
+// because of the effect on compile times, but this node is FTL-only.
+m_state.setFoundConstants(true);
+
 UniquedStringImpl* uid = m_graph.identifiers()[node->multiGetByOffsetData().identifierNumber];
 
 AbstractValue base = forNode(node->child1());
@@ -2894,10 +2898,8 @@
 for (const MultiGetByOffsetCase& getCase : node->multiGetByOffsetData().cases) {
 RegisteredStructureSet set = getCase.set();
 set.filter(base);
-if (set.isEmpty()) {
-m_state.setFoundConstants(true);
+if (set.isEmpty())
 continue;
-}
 baseSet.merge(set);
 
 switch (getCase.method().kind()) {


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (227135 => 227136)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-18 08:24:46 UTC (rev 227135)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-18 08:27:27 UTC (rev 227136)
@@ -3933,7 +3933,8 @@
 }
 
 if (getByIdStatus.numVariants() > 1) {
-if (getByIdStatus.makesCalls() || !m_graph.supportsMultiGetByOffset(currentCodeOrigin()) || !Options::usePolymorphicAccessInlining()) {
+if (getByIdStatus.makesCalls() || !isFTL(m_graph.m_plan.mode)
+|| !Options::usePolymorphicAccessInlining()) {
 set(VirtualRegister(destinationOperand),
 addToGraph(getById, OpInfo(identifierNumber), OpInfo(prediction), base));
 return;


Modified: trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp (227135 => 227136)

--- trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp	2018-01-18 08:24:46 UTC (rev 227135)
+++ trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp	2018-01-18 08:27:27 UTC (rev 227136)
@@ -522,7 +522,7 @@
 break;
 }
 
-if (!m_graph.supportsMultiGetByOffset(node->origin.semantic))
+if (!isFTL(m_graph.m_plan.mode))
 break;
 
 MultiGetByOffsetData* data = ""


Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.h (227135 => 227136)

--- trunk/Source/_javascript_Core/dfg/DFGGraph.h	2018-01-18 08:24:46 UTC (rev 227135)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.h	2018-01-18 08:27:27 UTC (rev 227136)
@@ -970,17 +970,6 @@
 return result;
 }
 
-bool supportsMultiGetByOffset(CodeOrigin origin)
-{
-if (!is64Bit())
-return false;
-if (isFTL(m_plan.mode))
-return true;
-// We want to ensure we get polyvariant profiling data from the GetById. This allows
-// the same get_by_id inlined into two separate functions to get 

[webkit-changes] [227135] trunk

[wenson_hsieh]

Title: [227135] trunk








Revision 227135
Author wenson_hs...@apple.com
Date 2018-01-18 00:24:46 -0800 (Thu, 18 Jan 2018)


Log Message
[iOS] Specify -[NSURL _title] for the associated URL when copying an image element
https://bugs.webkit.org/show_bug.cgi?id=181783


Reviewed by Ryosuke Niwa.

Source/WebCore:

Always specify the -[NSURL _title] to be either the title specified in a PasteboardImage's inner PasteboardURL,
or if no title is specified, fall back to the user-visible URL string. This is because at least one internal
client always tries to use the -_title property to determine the title of a pasted URL, or if none is specified,
the -suggestedName. Since we need to set suggestedName to the preferred file name of the copied image and we
don't want the suggested name to become the title of the link, we need to explicitly set the link title.

In doing so, this patch also fixes a bug wherein we forget to set the _title of the NSURL we're registering to
an NSItemProvider.

Tests:  ActionSheetTests.CopyImageElementWithHREFAndTitle (new)
ActionSheetTests.CopyImageElementWithHREF (modified)

* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write):

Tools:

Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
copying an image contains a relevant title.

* TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/ios/DataInteractionSimulator.mm:
* TestWebKitAPI/ios/UIKitSPI.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm
trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (227134 => 227135)

--- trunk/Source/WebCore/ChangeLog	2018-01-18 07:30:51 UTC (rev 227134)
+++ trunk/Source/WebCore/ChangeLog	2018-01-18 08:24:46 UTC (rev 227135)
@@ -1,3 +1,26 @@
+2018-01-18  Wenson Hsieh  
+
+[iOS] Specify -[NSURL _title] for the associated URL when copying an image element
+https://bugs.webkit.org/show_bug.cgi?id=181783
+
+
+Reviewed by Ryosuke Niwa.
+
+Always specify the -[NSURL _title] to be either the title specified in a PasteboardImage's inner PasteboardURL,
+or if no title is specified, fall back to the user-visible URL string. This is because at least one internal
+client always tries to use the -_title property to determine the title of a pasted URL, or if none is specified,
+the -suggestedName. Since we need to set suggestedName to the preferred file name of the copied image and we
+don't want the suggested name to become the title of the link, we need to explicitly set the link title.
+
+In doing so, this patch also fixes a bug wherein we forget to set the _title of the NSURL we're registering to
+an NSItemProvider.
+
+Tests:  ActionSheetTests.CopyImageElementWithHREFAndTitle (new)
+ActionSheetTests.CopyImageElementWithHREF (modified)
+
+* platform/ios/PlatformPasteboardIOS.mm:
+(WebCore::PlatformPasteboard::write):
+
 2018-01-17  Jer Noble  
 
 WebVTT served via HLS never results in cues


Modified: trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm (227134 => 227135)

--- trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm	2018-01-18 07:30:51 UTC (rev 227134)
+++ trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm	2018-01-18 08:24:46 UTC (rev 227135)
@@ -32,6 +32,7 @@
 #import "SharedBuffer.h"
 #import "URL.h"
 #import "UTIUtilities.h"
+#import "WebCoreNSURLExtras.h"
 #import "WebItemProviderPasteboard.h"
 #import 
 #import 
@@ -346,9 +347,10 @@
 // FIXME: When writing a PasteboardImage, we currently always place the image data at a higer fidelity than the
 // associated image URL. However, in the case of an image enclosed by an anchor, we might want to consider the
 // the URL (i.e. the anchor's href attribute) to be a higher fidelity representation.
-if (!pasteboardImage.url.url.isEmpty()) {
-if (NSURL *nsURL = pasteboardImage.url.url)
-[representationsToRegister addRepresentingObject:nsURL];
+auto& pasteboardURL = pasteboardImage.url;
+if (NSURL *nsURL = pasteboardURL.url) {
+nsURL._title = pasteboardURL.title.isEmpty() ? userVisibleString(pasteboardURL.url) : (NSString *)pasteboardURL.title;
+[representationsToRegister addRepresentingObject:nsURL];
 }
 
 registerItemToPasteboard(representationsToRegister.get(), m_pasteboard.get());


Modified: trunk/Tools/ChangeLog (227134 => 227135)

--- trunk/Tools/ChangeLog	2018-01-18 07:30:51 UTC (rev 227134)
+++ trunk/Tools/ChangeLog	2018-01-18 08:24:46 UTC (rev 227135)
@@ -1,3 +1,19 @@
+2018-01-18  Wenson Hsieh  
+
+[iOS] Specify -[NSURL _title] for the associated URL when