[webkit-changes] [227406] trunk/Tools

[carlosgc]

Title: [227406] trunk/Tools








Revision 227406
Author carlo...@webkit.org
Date 2018-01-22 23:11:37 -0800 (Mon, 22 Jan 2018)


Log Message
Unreviewed. Add test case for slow in test_expectations.py.

I forgot to also check slow tests in test_expectations.py unit tests.

* Scripts/webkitpy/common/test_expectations_unittest.py:
(assert_slow):
(test_build_type):
(test_slow):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/test_expectations_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (227405 => 227406)

--- trunk/Tools/ChangeLog	2018-01-23 06:50:39 UTC (rev 227405)
+++ trunk/Tools/ChangeLog	2018-01-23 07:11:37 UTC (rev 227406)
@@ -1,5 +1,16 @@
 2018-01-22  Carlos Garcia Campos  
 
+Unreviewed. Add test case for slow in test_expectations.py.
+
+I forgot to also check slow tests in test_expectations.py unit tests.
+
+* Scripts/webkitpy/common/test_expectations_unittest.py:
+(assert_slow):
+(test_build_type):
+(test_slow):
+
+2018-01-22  Carlos Garcia Campos  
+
 Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
 
 * TestWebKitAPI/glib/TestExpectations.json:


Modified: trunk/Tools/Scripts/webkitpy/common/test_expectations_unittest.py (227405 => 227406)

--- trunk/Tools/Scripts/webkitpy/common/test_expectations_unittest.py	2018-01-23 06:50:39 UTC (rev 227405)
+++ trunk/Tools/Scripts/webkitpy/common/test_expectations_unittest.py	2018-01-23 07:11:37 UTC (rev 227406)
@@ -163,6 +163,28 @@
 }
 }"""
 
+SLOW = """
+{
+"TestCookieManager": {
+"expected": {"all": {"slow": true}},
+"subtests": {
+"/webkit2/WebKitCookieManager/persistent-storage": {
+"expected": {"wpe": {"status": ["FAIL"], "slow": false, "bug": "1234"}}
+}
+}
+},
+"TestWebKit": {
+"subtests": {
+"WebKit.MouseMoveAfterCrash": {
+"expected": {"all": {"status": ["FAIL"], "slow": true, "bug": "1234"}}
+},
+"WebKit.WKConnection": {
+"expected": {"gtk": {"status": ["CRASH"], "bug": "1234"}}
+}
+}
+}
+}"""
+
 def assert_exp(self, test, subtest, result):
 self.assertIn(result, self.expectations.get_expectation(test, subtest))
 
@@ -175,6 +197,9 @@
 def assert_skip(self, test, subtest, result):
 self.assertEqual(self.expectations.is_skip(test, subtest), result)
 
+def assert_slow(self, test, subtest, result):
+self.assertEqual(self.expectations.is_slow(test, subtest), result)
+
 def test_basic(self):
 self.expectations = MockTestExpectations('gtk', self.BASIC)
 self.assert_exp('imported/w3c/webdriver/tests/test5.py', 'test5_two', 'PASS')
@@ -252,3 +277,19 @@
 self.expectations = MockTestExpectations('wpe', self.BUILD_TYPE, 'Debug')
 self.assert_skip('TestWebViewEditor', None, True)
 self.assert_skip('TestWebViewEditor', '/webkit2/WebKitWebView/editable/editable', True)
+
+def test_slow(self):
+self.expectations = MockTestExpectations('gtk', self.SLOW)
+self.assert_slow('TestCookieManager', '/webkit2/WebKitCookieManager/basic', True)
+self.assert_slow('TestCookieManager', '/webkit2/WebKitCookieManager/persistent-storage', True)
+self.assert_slow('TestWebKit', 'WebKit.WKView', False)
+self.assert_slow('TestWebKit', 'WebKit.MouseMoveAfterCrash', True)
+self.assert_exp('TestWebKit', 'WebKit.MouseMoveAfterCrash', 'FAIL')
+self.assert_slow('TestWebKit', 'WebKit.WKConnection', False)
+
+self.expectations = MockTestExpectations('wpe', self.SLOW)
+self.assert_slow('TestCookieManager', '/webkit2/WebKitCookieManager/basic', True)
+self.assert_slow('TestCookieManager', '/webkit2/WebKitCookieManager/persistent-storage', False)
+self.assert_slow('TestWebKit', 'WebKit.WKView', False)
+self.assert_slow('TestWebKit', 'WebKit.MouseMoveAfterCrash', True)
+self.assert_slow('TestWebKit', 'WebKit.WKConnection', False)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227405] trunk/Tools

[carlosgc]

Title: [227405] trunk/Tools








Revision 227405
Author carlo...@webkit.org
Date 2018-01-22 22:50:39 -0800 (Mon, 22 Jan 2018)


Log Message
Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.

* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (227404 => 227405)

--- trunk/Tools/ChangeLog	2018-01-23 06:42:54 UTC (rev 227404)
+++ trunk/Tools/ChangeLog	2018-01-23 06:50:39 UTC (rev 227405)
@@ -1,3 +1,9 @@
+2018-01-22  Carlos Garcia Campos  
+
+Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
 2018-01-22  Ryosuke Niwa  
 
 Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (227404 => 227405)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2018-01-23 06:42:54 UTC (rev 227404)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2018-01-23 06:50:39 UTC (rev 227405)
@@ -108,6 +108,9 @@
 "WTF_Lock.ContendedLongSection": {
 "expected": {"all": {"slow": true}}
 },
+"WTF_Lock.ManyContendedShortSections": {
+"expected": {"all": {"slow": true}}
+},
 "WTF_WordLock.ContendedShortSection": {
 "expected": {"all": {"slow": true}}
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227403] branches/safari-605-branch/Source/WebKitLegacy/mac

[jmarcell]

Title: [227403] branches/safari-605-branch/Source/WebKitLegacy/mac








Revision 227403
Author jmarc...@apple.com
Date 2018-01-22 22:42:50 -0800 (Mon, 22 Jan 2018)


Log Message
Cherry-pick r227371. rdar://problem/36763183

Modified Paths

branches/safari-605-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-605-branch/Source/WebKitLegacy/mac/WebView/WebView.mm




Diff

Modified: branches/safari-605-branch/Source/WebKitLegacy/mac/ChangeLog (227402 => 227403)

--- branches/safari-605-branch/Source/WebKitLegacy/mac/ChangeLog	2018-01-23 06:42:47 UTC (rev 227402)
+++ branches/safari-605-branch/Source/WebKitLegacy/mac/ChangeLog	2018-01-23 06:42:50 UTC (rev 227403)
@@ -1,5 +1,28 @@
 2018-01-22  Jason Marcell  
 
+Cherry-pick r227371. rdar://problem/36763183
+
+2018-01-22  Wenson Hsieh  
+
+WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
+https://bugs.webkit.org/show_bug.cgi?id=181960
+
+
+Reviewed by Tim Horton.
+
+Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
+a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
+path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
+
+This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
+RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
+RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
+
+* WebView/WebView.mm:
+(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
+
+2018-01-22  Jason Marcell  
+
 Cherry-pick r227282. rdar://problem/36746077
 
 2018-01-21  Ryosuke Niwa  


Modified: branches/safari-605-branch/Source/WebKitLegacy/mac/WebView/WebView.mm (227402 => 227403)

--- branches/safari-605-branch/Source/WebKitLegacy/mac/WebView/WebView.mm	2018-01-23 06:42:47 UTC (rev 227402)
+++ branches/safari-605-branch/Source/WebKitLegacy/mac/WebView/WebView.mm	2018-01-23 06:42:50 UTC (rev 227403)
@@ -1759,6 +1759,8 @@
 
 SecurityPolicy::setLocalLoadPolicy(SecurityPolicy::AllowLocalLoadsForLocalAndSubstituteData);
 
+RuntimeEnabledFeatures::sharedFeatures().setAttachmentElementEnabled(self.preferences.attachmentElementEnabled);
+
 return self;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227402] branches/safari-605-branch

[jmarcell]

Title: [227402] branches/safari-605-branch








Revision 227402
Author jmarc...@apple.com
Date 2018-01-22 22:42:47 -0800 (Mon, 22 Jan 2018)


Log Message
Cherry-pick r227370. rdar://problem/36763189

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/Source/WebInspectorUI/ChangeLog
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js


Added Paths

branches/safari-605-branch/LayoutTests/inspector/css/modify-css-property-expected.txt
branches/safari-605-branch/LayoutTests/inspector/css/modify-css-property.html




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (227401 => 227402)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-01-23 06:42:43 UTC (rev 227401)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-01-23 06:42:47 UTC (rev 227402)
@@ -1,5 +1,20 @@
 2018-01-22  Jason Marcell  
 
+Cherry-pick r227370. rdar://problem/36763189
+
+2018-01-22  Nikita Vasilyev  
+
+Web Inspector: Styles Redesign: data corruption when updating values quickly
+https://bugs.webkit.org/show_bug.cgi?id=179461
+
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/css/modify-css-property-expected.txt: Added.
+* inspector/css/modify-css-property.html: Added.
+
+2018-01-22  Jason Marcell  
+
 Cherry-pick r227277. rdar://problem/36763214
 
 2018-01-21  Andy Estes  


Added: branches/safari-605-branch/LayoutTests/inspector/css/modify-css-property-expected.txt (0 => 227402)

--- branches/safari-605-branch/LayoutTests/inspector/css/modify-css-property-expected.txt	(rev 0)
+++ branches/safari-605-branch/LayoutTests/inspector/css/modify-css-property-expected.txt	2018-01-23 06:42:47 UTC (rev 227402)
@@ -0,0 +1,18 @@
+Testing that CSSStyleDeclaration update immediately after modifying its properties when it is not locked.
+
+
+== Running test suite: ModifyCSSProperty
+-- Running test case: Update value when CSSStyleDeclaration is not locked
+PASS: "font-size" property value should update immediately.
+PASS: Style declaration text should stay unchanged.
+
+-- Running test case: Update value when CSSStyleDeclaration is locked
+PASS: "font-size" property value should update immediately.
+PASS: Style declaration text should update immediately.
+
+-- Running test case: Update inline style value when CSSStyleDeclaration locked and not locked
+PASS: Style declaration text should update immediately.
+PASS: Style declaration text should stay "width: 64px".
+PASS: "width" property value should update to "200px".
+PASS: Inline style declaration text should update when not locked.
+


Added: branches/safari-605-branch/LayoutTests/inspector/css/modify-css-property.html (0 => 227402)

--- branches/safari-605-branch/LayoutTests/inspector/css/modify-css-property.html	(rev 0)
+++ branches/safari-605-branch/LayoutTests/inspector/css/modify-css-property.html	2018-01-23 06:42:47 UTC (rev 227402)
@@ -0,0 +1,166 @@
+
+
+
+
+function makeNarrow() {
+document.getElementById("x").style.width = "50px";
+}
+
+function makeWide() {
+document.getElementById("x").style.width = "200px";
+}
+
+function test() {
+let nodeStyles = null;
+let suite = InspectorTest.createAsyncSuite("ModifyCSSProperty");
+
+suite.addTestCase({
+name: "Update value when CSSStyleDeclaration is not locked",
+test(resolve, reject) {
+let getMatchedStyleDeclaration = () => {
+for (let rule of nodeStyles.matchedRules) {
+if (rule.selectorText === ".rule-b")
+return rule.style;
+}
+};
+
+let getProperty = (propertyName) => {
+let styleDeclaration = getMatchedStyleDeclaration();
+for (let property of styleDeclaration.properties) {
+if (property.name === propertyName)
+return property;
+}
+};
+
+let styleDeclaration = getMatchedStyleDeclaration();
+styleDeclaration.locked = false;
+getProperty("font-size").rawValue = "11px";
+getProperty("font-size").rawValue = "10px";
+
+InspectorTest.expectEqual(getProperty("font-size").rawValue, "10px", `"font-size" property value should update immediately.`);
+
+InspectorTest.expectEqual(styleDeclaration.text, 

[webkit-changes] [227404] branches/safari-605-branch

[jmarcell]

Title: [227404] branches/safari-605-branch








Revision 227404
Author jmarc...@apple.com
Date 2018-01-22 22:42:54 -0800 (Mon, 22 Jan 2018)


Log Message
Cherry-pick r227351. rdar://problem/36746029

Modified Paths

branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
branches/safari-605-branch/Source/WebCore/editing/markup.cpp
branches/safari-605-branch/Source/WebCore/editing/markup.h
branches/safari-605-branch/Tools/ChangeLog
branches/safari-605-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm




Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (227403 => 227404)

--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-23 06:42:50 UTC (rev 227403)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-23 06:42:54 UTC (rev 227404)
@@ -1,5 +1,43 @@
 2018-01-22  Jason Marcell  
 
+Cherry-pick r227351. rdar://problem/36746029
+
+2018-01-22  Ryosuke Niwa  
+
+Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
+https://bugs.webkit.org/show_bug.cgi?id=181616
+
+
+Reviewed by Wenson Hsieh.
+
+The bug was caused by WebContentReader::readHTML and WebContentMarkupReader::readHTML not sanitizing plain HTML string
+as done for web archives even when custom pasteboard data is enabled. Fixed the bug by doing the sanitization.
+
+Unfortunately, we can't make file URLs available in this case because WebContent process doesn't have sandbox extensions
+to access local files referenced by the HTML source in the clipboard, and we can't make WebContent process request for
+a sandbox extension¸on an arbitrary local file, as it would defeat the whole point of sandboxing.
+
+Instead, we strip away all HTML attributes referencing a URL whose scheme is not HTTP, HTTPS, or data when sanitizing
+text/html from the clipboard to avoid exposing local file paths, which can reveal privacy & security sensitive data
+such as the user's full name, and the location of private containers of other applications in the system.
+
+Tests: PasteHTML.DoesNotSanitizeHTMLWhenCustomPasteboardDataIsDisabled
+   PasteHTML.DoesNotStripFileURLsWhenCustomPasteboardDataIsDisabled
+   PasteHTML.ExposesHTMLTypeInDataTransfer
+   PasteHTML.KeepsHTTPURLs
+   PasteHTML.SanitizesHTML
+   PasteHTML.StripsFileURLs
+
+* editing/cocoa/WebContentReaderCocoa.mm:
+(WebCore::WebContentReader::readHTML): Fixed the bug by sanitizing the markup, and stripping away file URLs.
+(WebCore::WebContentMarkupReader::readHTML): Ditto.
+* editing/markup.cpp:
+(WebCore::removeSubresourceURLAttributes): Added.
+(WebCore::sanitizeMarkup): Added.
+* editing/markup.h:
+
+2018-01-22  Jason Marcell  
+
 Cherry-pick r227357. rdar://problem/36763204
 
 2018-01-22  Per Arne Vollan  


Modified: branches/safari-605-branch/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm (227403 => 227404)

--- branches/safari-605-branch/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm	2018-01-23 06:42:50 UTC (rev 227403)
+++ branches/safari-605-branch/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm	2018-01-23 06:42:54 UTC (rev 227404)
@@ -175,7 +175,7 @@
 };
 
 
-static bool shouldConvertToBlob(const URL& url)
+static bool shouldReplaceSubresourceURL(const URL& url)
 {
 return !(url.protocolIsInHTTPFamily() || url.protocolIsData());
 }
@@ -224,7 +224,7 @@
 HashMap urlToBlobMap;
 for (const Ref& subresource : subresources) {
 auto& url = ""
-if (shouldConvertToBlob(url))
+if (shouldReplaceSubresourceURL(url))
 urlToBlobMap.set(url.string(), Blob::create(subresource->data(), subresource->mimeType()));
 }
 
@@ -376,7 +376,7 @@
 HashMap blobURLMap;
 for (const Ref& subresource : markupAndArchive.archive->subresources()) {
 auto& subresourceURL = subresource->url();
-if (!shouldConvertToBlob(subresourceURL))
+if (!shouldReplaceSubresourceURL(subresourceURL))
 continue;
 auto blob = Blob::create(subresource->data(), subresource->mimeType());
 String blobURL = DOMURL::createObjectURL(destinationDocument, blob);
@@ -394,7 +394,7 @@
 continue;
 
 auto subframeURL = subframeMainResource->url();
-if (!shouldConvertToBlob(subframeURL))
+if (!shouldReplaceSubresourceURL(subframeURL))
 continue;
 
 MarkupAndArchive subframeContent 

[webkit-changes] [227401] branches/safari-605-branch/Source/WebKit

[jmarcell]

Title: [227401] branches/safari-605-branch/Source/WebKit








Revision 227401
Author jmarc...@apple.com
Date 2018-01-22 22:42:43 -0800 (Mon, 22 Jan 2018)


Log Message
Cherry-pick r227358. rdar://problem/36763023

Modified Paths

branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp




Diff

Modified: branches/safari-605-branch/Source/WebKit/ChangeLog (227400 => 227401)

--- branches/safari-605-branch/Source/WebKit/ChangeLog	2018-01-23 06:42:41 UTC (rev 227400)
+++ branches/safari-605-branch/Source/WebKit/ChangeLog	2018-01-23 06:42:43 UTC (rev 227401)
@@ -1,5 +1,22 @@
 2018-01-22  Jason Marcell  
 
+Cherry-pick r227358. rdar://problem/36763023
+
+2018-01-22  Youenn Fablet  
+
+SW: Make sure ServiceWorker loading and requests are correctly cleared by ITP
+https://bugs.webkit.org/show_bug.cgi?id=181942
+
+
+Reviewed by Chris Dumez.
+
+Add ServiceWorkerRegistrations and DOMCache as persistent data to be cleared according ITP decisions.
+
+* UIProcess/WebResourceLoadStatisticsStore.cpp:
+(WebKit::WebResourceLoadStatisticsStore::monitoredDataTypes):
+
+2018-01-22  Jason Marcell  
+
 Cherry-pick r227340. rdar://problem/36746140
 
 2018-01-22  Brady Eidson  


Modified: branches/safari-605-branch/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp (227400 => 227401)

--- branches/safari-605-branch/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp	2018-01-23 06:42:41 UTC (rev 227400)
+++ branches/safari-605-branch/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp	2018-01-23 06:42:43 UTC (rev 227401)
@@ -59,6 +59,7 @@
 {
 static NeverDestroyed dataTypes(std::initializer_list({
 WebsiteDataType::Cookies,
+WebsiteDataType::DOMCache,
 WebsiteDataType::IndexedDBDatabases,
 WebsiteDataType::LocalStorage,
 WebsiteDataType::MediaKeys,
@@ -68,6 +69,9 @@
 #endif
 WebsiteDataType::SearchFieldRecentSearches,
 WebsiteDataType::SessionStorage,
+#if ENABLE(SERVICE_WORKER)
+WebsiteDataType::ServiceWorkerRegistrations,
+#endif
 WebsiteDataType::WebSQLDatabases,
 }));
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227397] branches/safari-605-branch/Source

[jmarcell]

Title: [227397] branches/safari-605-branch/Source








Revision 227397
Author jmarc...@apple.com
Date 2018-01-22 22:42:29 -0800 (Mon, 22 Jan 2018)


Log Message
Cherry-pick r227340. rdar://problem/36746140

Modified Paths

branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-605-branch/Source/WebCore/dom/MessagePort.h
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannel.cpp
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannel.h
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelProvider.h
branches/safari-605-branch/Source/WebCore/dom/messageports/MessagePortChannelRegistry.h
branches/safari-605-branch/Source/WebCore/dom/messageports/MessageWithMessagePorts.h
branches/safari-605-branch/Source/WebKit/CMakeLists.txt
branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-605-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp
branches/safari-605-branch/Source/WebKit/UIProcess/WebProcessProxy.h
branches/safari-605-branch/Source/WebKit/UIProcess/WebProcessProxy.messages.in
branches/safari-605-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj
branches/safari-605-branch/Source/WebKit/WebProcess/WebProcess.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/WebProcess.h
branches/safari-605-branch/Source/WebKit/WebProcess/WebProcess.messages.in


Added Paths

branches/safari-605-branch/Source/WebKit/UIProcess/UIMessagePortChannelProvider.cpp
branches/safari-605-branch/Source/WebKit/UIProcess/UIMessagePortChannelProvider.h
branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h




Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (227396 => 227397)

--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-23 05:36:42 UTC (rev 227396)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-23 06:42:29 UTC (rev 227397)
@@ -1,5 +1,35 @@
 2018-01-22  Jason Marcell  
 
+Cherry-pick r227340. rdar://problem/36746140
+
+2018-01-22  Brady Eidson  
+
+In WebKit2, make the MessagePortChannelRegistry live in the UI process.
+https://bugs.webkit.org/show_bug.cgi?id=181922
+
+Reviewed by Andy Estes.
+
+No new tests (Refactor, no behavior change)
+
+Add encoder/decoders and EXPORT a whole bunch of stuff.
+
+* WebCore.xcodeproj/project.pbxproj:
+
+* dom/MessagePort.h:
+
+* dom/messageports/MessagePortChannel.cpp:
+(WebCore::MessagePortChannel::processForPort):
+* dom/messageports/MessagePortChannel.h:
+
+* dom/messageports/MessagePortChannelProvider.h:
+* dom/messageports/MessagePortChannelRegistry.h:
+
+* dom/messageports/MessageWithMessagePorts.h:
+(WebCore::MessageWithMessagePorts::encode const):
+(WebCore::MessageWithMessagePorts::decode):
+
+2018-01-22  Jason Marcell  
+
 Cherry-pick r227275. rdar://problem/36745983
 
 2018-01-20  Brady Eidson  


Modified: branches/safari-605-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj (227396 => 227397)

--- branches/safari-605-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-01-23 05:36:42 UTC (rev 227396)
+++ branches/safari-605-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2018-01-23 06:42:29 UTC (rev 227397)
@@ -1405,7 +1405,7 @@
 		51A052561058874000CC9E95 /* ProtectionSpaceHash.h in Headers */ = {isa = PBXBuildFile; fileRef = 51A052551058874000CC9E95 /* ProtectionSpaceHash.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		51A4BB0A1954D61600FA5C2E /* Gamepad.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51A4BB071954D61600FA5C2E /* Gamepad.cpp */; };
 		51A4BB101954D62700FA5C2E /* NavigatorGamepad.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51A4BB0D1954D62700FA5C2E /* NavigatorGamepad.cpp */; };
-		51A748E32005D0E80075BA68 /* MessageWithMessagePorts.h in Headers */ = {isa = PBXBuildFile; fileRef = 51A748E02005D0E00075BA68 /* MessageWithMessagePorts.h */; };
+		51A748E32005D0E80075BA68 /* MessageWithMessagePorts.h in Headers */ = {isa = PBXBuildFile; fileRef = 51A748E02005D0E00075BA68 /* MessageWithMessagePorts.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		51A748E62006004F0075BA68 /* MessagePortChannelProviderImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = 51A748E5200600210075BA68 /* MessagePortChannelProviderImpl.h */; };
 		51A9D9E9195B931F001B2B5C /* GamepadManager.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 51A9D9E7195B931F001B2B5C /* GamepadManager.cpp */; };
 		51A9D9EA195B931F001B2B5C /* GamepadManager.h in 

[webkit-changes] [227400] branches/safari-605-branch/Source/WebCore

[jmarcell]

Title: [227400] branches/safari-605-branch/Source/WebCore








Revision 227400
Author jmarc...@apple.com
Date 2018-01-22 22:42:41 -0800 (Mon, 22 Jan 2018)


Log Message
Cherry-pick r227357. rdar://problem/36763204

Modified Paths

branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/platform/win/PopupMenuWin.cpp




Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (227399 => 227400)

--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-23 06:42:38 UTC (rev 227399)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-23 06:42:41 UTC (rev 227400)
@@ -1,5 +1,32 @@
 2018-01-22  Jason Marcell  
 
+Cherry-pick r227357. rdar://problem/36763204
+
+2018-01-22  Per Arne Vollan  
+
+[Win] Null pointer crash under WebCore::RenderStyle::colorIncludingFallback.
+https://bugs.webkit.org/show_bug.cgi?id=181801
+
+
+Reviewed by Brent Fulgham.
+
+Do not paint synchronously when popup items have been added or changed while the popup is visible.
+If new popup items have been added after the popup was shown, a synchronous paint operation will
+possibly access their style before it is ready, leading to a null pointer crash. The invalidated
+area will be painted asynchronously.
+
+No new tests. To reproduce this crash, it is necessary to open a popup with _javascript_, add new
+popup items, and then end the test. Opening the popup can be done by sending a mousedown event
+with the eventsender. However, on Windows the mousedown event is sent synchronously, and will
+block as long as the popup is open and running the popup event loop. This means no JS can be
+executed until the popup is closed, causing the test to always time out before new popup items
+can be added. I have verified the fix with a manual test case.
+
+* platform/win/PopupMenuWin.cpp:
+(WebCore::PopupMenuWin::updateFromElement):
+
+2018-01-22  Jason Marcell  
+
 Cherry-pick r227353. rdar://problem/36763011
 
 2018-01-22  Chris Dumez  


Modified: branches/safari-605-branch/Source/WebCore/platform/win/PopupMenuWin.cpp (227399 => 227400)

--- branches/safari-605-branch/Source/WebCore/platform/win/PopupMenuWin.cpp	2018-01-23 06:42:38 UTC (rev 227399)
+++ branches/safari-605-branch/Source/WebCore/platform/win/PopupMenuWin.cpp	2018-01-23 06:42:41 UTC (rev 227400)
@@ -572,8 +572,7 @@
 m_focusedIndex = client()->selectedIndex();
 
 ::InvalidateRect(m_popup, 0, TRUE);
-if (!scrollToRevealSelection())
-::UpdateWindow(m_popup);
+scrollToRevealSelection();
 }
 
 const int separatorPadding = 4;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227398] branches/safari-605-branch

[jmarcell]

Title: [227398] branches/safari-605-branch








Revision 227398
Author jmarc...@apple.com
Date 2018-01-22 22:42:36 -0800 (Mon, 22 Jan 2018)


Log Message
Cherry-pick r227277. rdar://problem/36763214

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/LayoutTests/platform/ios-wk2/TestExpectations
branches/safari-605-branch/LayoutTests/platform/mac-wk2/TestExpectations
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp


Added Paths

branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/rejects_if_not_active.https-expected.txt
branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/rejects_if_not_active.https.html
branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/resources/page1.html
branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/resources/page2.html




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (227397 => 227398)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-01-23 06:42:29 UTC (rev 227397)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-01-23 06:42:36 UTC (rev 227398)
@@ -1,5 +1,27 @@
 2018-01-22  Jason Marcell  
 
+Cherry-pick r227277. rdar://problem/36763214
+
+2018-01-21  Andy Estes  
+
+[ios] LayoutTest imported/w3c/web-platform-tests/payment-request/rejects_if_not_active.https.html is crashing in JSC::JSONParse
+https://bugs.webkit.org/show_bug.cgi?id=177832
+
+
+Reviewed by Tim Horton.
+
+Made a copy of imported/w3c/web-platform-tests/payment-request/rejects_if_not_active.https.html
+and modified it to handle Apple Pay and user gesture requirements.
+
+* http/tests/paymentrequest/rejects_if_not_active.https-expected.txt: Added.
+* http/tests/paymentrequest/rejects_if_not_active.https.html: Added.
+* http/tests/paymentrequest/resources/page1.html: Added.
+* http/tests/paymentrequest/resources/page2.html: Added.
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
+2018-01-22  Jason Marcell  
+
 Cherry-pick r227338. rdar://problem/36746095
 
 2018-01-22  Andy Estes  


Added: branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/rejects_if_not_active.https-expected.txt (0 => 227398)

--- branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/rejects_if_not_active.https-expected.txt	(rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/rejects_if_not_active.https-expected.txt	2018-01-23 06:42:36 UTC (rev 227398)
@@ -0,0 +1,5 @@
+
+PASS PaymentRequest.show() aborts if the document is not active 
+PASS PaymentRequest.show() aborts if the document is active, but not fully active 
+PASS If a payment request is showing, but its document is navigated away (so no longer fully active), the payment request aborts. 
+


Added: branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/rejects_if_not_active.https.html (0 => 227398)

--- branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/rejects_if_not_active.https.html	(rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/paymentrequest/rejects_if_not_active.https.html	2018-01-23 06:42:36 UTC (rev 227398)
@@ -0,0 +1,178 @@
+
+
+PaymentRequest show() rejects if doc is not fully active
+
+