[webkit-changes] [229791] trunk/Source/JavaScriptCore
Title: [229791] trunk/Source/_javascript_Core Revision 229791 Author m...@apple.com Date 2018-03-20 23:44:12 -0700 (Tue, 20 Mar 2018) Log Message [Xcode] JSVALUE_MODEL is unused https://bugs.webkit.org/show_bug.cgi?id=183809 Reviewed by Tim Horton. * Configurations/_javascript_Core.xcconfig: Removed the unused definition. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (229790 => 229791) --- trunk/Source/_javascript_Core/ChangeLog 2018-03-21 06:26:49 UTC (rev 229790) +++ trunk/Source/_javascript_Core/ChangeLog 2018-03-21 06:44:12 UTC (rev 229791) @@ -1,3 +1,12 @@ +2018-03-20 Dan Bernstein + +[Xcode] JSVALUE_MODEL is unused +https://bugs.webkit.org/show_bug.cgi?id=183809 + +Reviewed by Tim Horton. + +* Configurations/_javascript_Core.xcconfig: Removed the unused definition. + 2018-03-20 Tim Horton Update the install name for _javascript_Core when built with WK_ALTERNATE_FRAMEWORKS_DIR Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (229790 => 229791) --- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2018-03-21 06:26:49 UTC (rev 229790) +++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2018-03-21 06:44:12 UTC (rev 229791) @@ -24,16 +24,6 @@ #include "FeatureDefines.xcconfig" #include "Version.xcconfig" -JSVALUE_MODEL = $(JSVALUE_MODEL_$(CURRENT_ARCH)); -JSVALUE_MODEL_ = UNKNOWN_JSVALUE_MODEL; -JSVALUE_MODEL_armv7 = 32_64; -JSVALUE_MODEL_armv7k = 32_64; -JSVALUE_MODEL_armv7s = 32_64; -JSVALUE_MODEL_arm64 = 64; -JSVALUE_MODEL_arm64e = 64; -JSVALUE_MODEL_i386 = 32_64; -JSVALUE_MODEL_x86_64 = 64; - // Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols. OTHER_LDFLAGS_HIDE_SYMBOLS = -Wl,-unexported_symbol,__ZTISt9bad_alloc -Wl,-unexported_symbol,__ZTISt9exception -Wl,-unexported_symbol,__ZTSSt9bad_alloc -Wl,-unexported_symbol,__ZTSSt9exception -Wl,-unexported_symbol,__ZdlPvS_ -Wl,-unexported_symbol,__ZnwmPv -Wl,-unexported_symbol,__ZNKSt3__18functionIFvvEEclEv -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC1EOS2_ -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEEC2EOS2_ -Wl,-unexported_symbol,__ZNKSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEEclES3_S5_ -Wl,-unexported_symbol,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED1Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvRN3JSC17BytecodeGeneratorEPNS1_10RegisterIDEEED2Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEED1Ev -Wl,-unexported_symbol,__ZNSt3__18functionIFvvEED2Ev -Wl,-unexported_symbol,__ZTVNSt3__117bad_function_callE; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229790] trunk/Source
Title: [229790] trunk/Source Revision 229790 Author timothy_hor...@apple.com Date 2018-03-20 23:26:49 -0700 (Tue, 20 Mar 2018) Log Message Introduce HAVE_MEDIA_PLAYER and HAVE_CORE_VIDEO https://bugs.webkit.org/show_bug.cgi?id=183803 Reviewed by Sam Weinig. Source/WebCore: * platform/audio/ios/MediaSessionManagerIOS.mm: (WebCore::MediaSessionManageriOS::configureWireLessTargetMonitoring): (WebCore::MediaSessionManageriOS::updateNowPlayingInfo): (-[WebMediaSessionHelper initWithCallback:]): (-[WebMediaSessionHelper dealloc]): (-[WebMediaSessionHelper hasWirelessTargetsAvailable]): * platform/cocoa/CoreVideoSoftLink.cpp: * platform/cocoa/CoreVideoSoftLink.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame const): (WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage): * platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm: (WebCore::MediaSampleAVFObjC::getRGBAImageData const): * platform/graphics/cv/PixelBufferConformerCV.cpp: * platform/graphics/cv/PixelBufferConformerCV.h: * platform/graphics/cv/TextureCacheCV.h: * platform/graphics/cv/TextureCacheCV.mm: * platform/graphics/cv/VideoTextureCopierCV.cpp: * platform/graphics/cv/VideoTextureCopierCV.h: Make it possible to disable our dependency on MediaPlayer and CoreVideo. Source/WTF: * wtf/Platform.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp trunk/Source/WebCore/platform/cocoa/CoreVideoSoftLink.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm trunk/Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.cpp trunk/Source/WebCore/platform/graphics/cv/PixelBufferConformerCV.h trunk/Source/WebCore/platform/graphics/cv/TextureCacheCV.h trunk/Source/WebCore/platform/graphics/cv/TextureCacheCV.mm trunk/Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp trunk/Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.h Diff Modified: trunk/Source/WTF/ChangeLog (229789 => 229790) --- trunk/Source/WTF/ChangeLog 2018-03-21 06:26:26 UTC (rev 229789) +++ trunk/Source/WTF/ChangeLog 2018-03-21 06:26:49 UTC (rev 229790) @@ -1,3 +1,13 @@ +2018-03-20 Tim Horton + +Introduce HAVE_MEDIA_PLAYER and HAVE_CORE_VIDEO +https://bugs.webkit.org/show_bug.cgi?id=183803 + + +Reviewed by Sam Weinig. + +* wtf/Platform.h: + 2018-03-20 Brian Burg SLEEP_THREAD_FOR_DEBUGGER should not use fancy number literals Modified: trunk/Source/WTF/wtf/Platform.h (229789 => 229790) --- trunk/Source/WTF/wtf/Platform.h 2018-03-21 06:26:26 UTC (rev 229789) +++ trunk/Source/WTF/wtf/Platform.h 2018-03-21 06:26:49 UTC (rev 229790) @@ -1124,9 +1124,14 @@ #if PLATFORM(IOS) || PLATFORM(MAC) #define USE_COREMEDIA 1 +#define USE_VIDEOTOOLBOX 1 + +#if !ENABLE(MINIMAL_SIMULATOR) #define HAVE_AVFOUNDATION_VIDEO_OUTPUT 1 -#define USE_VIDEOTOOLBOX 1 +#define HAVE_CORE_VIDEO 1 +#define HAVE_MEDIA_PLAYER 1 #endif +#endif #if PLATFORM(IOS) || PLATFORM(MAC) || (OS(WINDOWS) && USE(CG)) #define HAVE_AVFOUNDATION_MEDIA_SELECTION_GROUP 1 Modified: trunk/Source/WebCore/ChangeLog (229789 => 229790) --- trunk/Source/WebCore/ChangeLog 2018-03-21 06:26:26 UTC (rev 229789) +++ trunk/Source/WebCore/ChangeLog 2018-03-21 06:26:49 UTC (rev 229790) @@ -1,5 +1,36 @@ 2018-03-20 Tim Horton +Introduce HAVE_MEDIA_PLAYER and HAVE_CORE_VIDEO +https://bugs.webkit.org/show_bug.cgi?id=183803 + + +Reviewed by Sam Weinig. + +* platform/audio/ios/MediaSessionManagerIOS.mm: +(WebCore::MediaSessionManageriOS::configureWireLessTargetMonitoring): +(WebCore::MediaSessionManageriOS::updateNowPlayingInfo): +(-[WebMediaSessionHelper initWithCallback:]): +(-[WebMediaSessionHelper dealloc]): +(-[WebMediaSessionHelper hasWirelessTargetsAvailable]): +* platform/cocoa/CoreVideoSoftLink.cpp: +* platform/cocoa/CoreVideoSoftLink.h: +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: +(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): +(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame const): +(WebCore::MediaPlayerPrivateAVFoundationObjC::updateLastImage): +* platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm: +(WebCor
[webkit-changes] [229789] trunk/Source/JavaScriptCore
Title: [229789] trunk/Source/_javascript_Core
Revision 229789
Author timothy_hor...@apple.com
Date 2018-03-20 23:26:26 -0700 (Tue, 20 Mar 2018)
Log Message
Update the install name for _javascript_Core when built with WK_ALTERNATE_FRAMEWORKS_DIR
https://bugs.webkit.org/show_bug.cgi?id=183808
Reviewed by Dan Bernstein.
* Configurations/_javascript_Core.xcconfig:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (229788 => 229789)
--- trunk/Source/_javascript_Core/ChangeLog 2018-03-21 05:17:02 UTC (rev 229788)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-03-21 06:26:26 UTC (rev 229789)
@@ -1,5 +1,15 @@
2018-03-20 Tim Horton
+Update the install name for _javascript_Core when built with WK_ALTERNATE_FRAMEWORKS_DIR
+https://bugs.webkit.org/show_bug.cgi?id=183808
+
+
+Reviewed by Dan Bernstein.
+
+* Configurations/_javascript_Core.xcconfig:
+
+2018-03-20 Tim Horton
+
Enable the minimal simulator feature flag when appropriate
https://bugs.webkit.org/show_bug.cgi?id=183807
Modified: trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig (229788 => 229789)
--- trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2018-03-21 05:17:02 UTC (rev 229788)
+++ trunk/Source/_javascript_Core/Configurations/_javascript_Core.xcconfig 2018-03-21 06:26:26 UTC (rev 229789)
@@ -52,7 +52,9 @@
HEADER_SEARCH_PATHS = "${BUILT_PRODUCTS_DIR}/DerivedSources/_javascript_Core" $(HEADER_SEARCH_PATHS);
INFOPLIST_FILE = Info.plist;
INSTALL_PATH = $(_javascript_CORE_FRAMEWORKS_DIR);
-DYLIB_INSTALL_NAME_BASE = $(NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR);
+DYLIB_INSTALL_NAME_BASE = $(DYLIB_INSTALL_NAME_BASE_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
+DYLIB_INSTALL_NAME_BASE_NO = $(NORMAL_JAVASCRIPTCORE_FRAMEWORKS_DIR)
+DYLIB_INSTALL_NAME_BASE_YES = $(DYLIB_INSTALL_NAME_BASE);
PRODUCT_NAME = _javascript_Core;
PRODUCT_BUNDLE_IDENTIFIER = com.apple.$(PRODUCT_NAME:rfc1034identifier);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229788] trunk
Title: [229788] trunk Revision 229788 Author timothy_hor...@apple.com Date 2018-03-20 22:17:02 -0700 (Tue, 20 Mar 2018) Log Message Enable the minimal simulator feature flag when appropriate https://bugs.webkit.org/show_bug.cgi?id=183807 Reviewed by Dan Bernstein. * .../Configurations/FeatureDefines.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (229787 => 229788) --- trunk/Source/_javascript_Core/ChangeLog 2018-03-21 04:47:45 UTC (rev 229787) +++ trunk/Source/_javascript_Core/ChangeLog 2018-03-21 05:17:02 UTC (rev 229788) @@ -1,3 +1,12 @@ +2018-03-20 Tim Horton + +Enable the minimal simulator feature flag when appropriate +https://bugs.webkit.org/show_bug.cgi?id=183807 + +Reviewed by Dan Bernstein. + +* Configurations/FeatureDefines.xcconfig: + 2018-03-20 Saam Barati We need to do proper bookkeeping of exitOK when inserting constants when sinking NewArrayBuffer Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (229787 => 229788) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2018-03-21 04:47:45 UTC (rev 229787) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2018-03-21 05:17:02 UTC (rev 229788) @@ -264,6 +264,9 @@ ENABLE_MHTML = ; +ENABLE_MINIMAL_SIMULATOR = $(ENABLE_MINIMAL_SIMULATOR_$(WK_PLATFORM_NAME)); +ENABLE_MINIMAL_SIMULATOR_iphoneminimalsimulator = ENABLE_MINIMAL_SIMULATOR; + ENABLE_MOUSE_CURSOR_SCALE = $(ENABLE_MOUSE_CURSOR_SCALE_$(WK_PLATFORM_NAME)); ENABLE_MOUSE_CURSOR_SCALE_macosx = ENABLE_MOUSE_CURSOR_SCALE; @@ -382,4 +385,4 @@ ENABLE_XSLT = ENABLE_XSLT; -FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_ANIMATIONS_LEVEL_2) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXTRA_ZOOM_MODE) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FUL LSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_COLOR_POPOVER) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_JS_ASYNC_ITERATION) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_SUBTLE_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(E
[webkit-changes] [229787] trunk/Source/WebInspectorUI
Title: [229787] trunk/Source/WebInspectorUI
Revision 229787
Author nvasil...@apple.com
Date 2018-03-20 21:47:45 -0700 (Tue, 20 Mar 2018)
Log Message
Web Inspector: Styles: Loses focus when editing a property while page is being loaded
https://bugs.webkit.org/show_bug.cgi?id=182619
Reviewed by Matt Baker.
Adding or removing a stylesheet causes SpreadsheetRulesStyleDetailsPanel to refresh, triggering a layout
of all SpreadsheetCSSStyleDeclarationSection child views. This resets the focus, selection, and
auto-completion state.
This patch prevents SpreadsheetCSSStyleDeclarationSection from performing a layout when a property is being edited.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
Allow re-layout after creating a blank CSS property and pasting CSS code.
- _pendingAddBlankPropertyIndexOffset is a number after pasting CSS rules.
- _propertyPendingStartEditing is a property model after creating a new property.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (229786 => 229787)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-03-21 04:42:32 UTC (rev 229786)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-03-21 04:47:45 UTC (rev 229787)
@@ -1,3 +1,23 @@
+2018-03-20 Nikita Vasilyev
+
+Web Inspector: Styles: Loses focus when editing a property while page is being loaded
+https://bugs.webkit.org/show_bug.cgi?id=182619
+
+
+Reviewed by Matt Baker.
+
+Adding or removing a stylesheet causes SpreadsheetRulesStyleDetailsPanel to refresh, triggering a layout
+of all SpreadsheetCSSStyleDeclarationSection child views. This resets the focus, selection, and
+auto-completion state.
+
+This patch prevents SpreadsheetCSSStyleDeclarationSection from performing a layout when a property is being edited.
+
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
+(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
+Allow re-layout after creating a blank CSS property and pasting CSS code.
+- _pendingAddBlankPropertyIndexOffset is a number after pasting CSS rules.
+- _propertyPendingStartEditing is a property model after creating a new property.
+
2018-03-20 Devin Rousso
Web Inspector: Session dividers are not added when Console tab is not visible
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js (229786 => 229787)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2018-03-21 04:42:32 UTC (rev 229786)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2018-03-21 04:47:45 UTC (rev 229787)
@@ -62,6 +62,11 @@
layout()
{
+// Prevent layout of properties when one of them is being edited. A full layout resets
+// the focus, text selection, and completion state .
+if (this.editing && !this._propertyPendingStartEditing && isNaN(this._pendingAddBlankPropertyIndexOffset))
+return;
+
super.layout();
this.element.removeChildren();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229786] trunk/Tools
Title: [229786] trunk/Tools Revision 229786 Author za...@apple.com Date 2018-03-20 21:42:32 -0700 (Tue, 20 Mar 2018) Log Message [LayoutReloaded] Disconnect Display.Box from Layout.Box https://bugs.webkit.org/show_bug.cgi?id=183805 Reviewed by Antti Koivisto. Display.Box is only accessed through the FormattingState. * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js: (BlockFormattingContext): (BlockFormattingContext.prototype.layout): (BlockFormattingContext.prototype._placeInFlowPositionedChildren): (BlockFormattingContext.prototype._layoutOutOfFlowDescendants): (BlockFormattingContext.prototype._adjustBottomWithFIXME): (BlockFormattingContext.prototype._computeOutOfFlowPosition): * LayoutReloaded/FormattingContext/FormattingContext.js: (FormattingContext): (FormattingContext.prototype.formattingRoot): (FormattingContext.prototype.formattingState): (FormattingContext.prototype.layoutState): (FormattingContext.prototype._toAbsolutePosition): (FormattingContext.prototype._toRootAbsolutePosition): (FormattingContext.prototype._addToLayoutQueue): (FormattingContext.prototype.displayBox): (FormattingContext.prototype._outOfFlowDescendants): (FormattingContext.prototype.rootContainer): Deleted. (FormattingContext.prototype.layoutContext): Deleted. * LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js: (InlineFormattingContext): (InlineFormattingContext.prototype.layout): (InlineFormattingContext.prototype._initializeLine): * LayoutReloaded/FormattingState/BlockFormattingState.js: (BlockFormattingState): * LayoutReloaded/FormattingState/FormattingState.js: (FormattingState): (FormattingState.prototype.formattingRoot): (FormattingState.prototype.layoutState): (FormattingState.prototype.createDisplayBox): (FormattingState.prototype.displayBoxMap): (FormattingState.prototype.displayBox): (FormattingState.prototype.layoutContext): Deleted. * LayoutReloaded/FormattingState/InlineFormattingState.js: (InlineFormattingState): * LayoutReloaded/Layout.js: (layout): * LayoutReloaded/LayoutReloaded.xcworkspace/contents.xcworkspacedata: * LayoutReloaded/LayoutState.js: Renamed from Tools/LayoutReloaded/LayoutContext.js. (LayoutState): (LayoutState.prototype.layout): (LayoutState.prototype._createFormattingState): (LayoutState.prototype.formattingStates): (LayoutState.prototype.initialDisplayBox): * LayoutReloaded/LayoutTree/Box.js: (Layout.Box.prototype.isOutOfFlowPositioned): (Layout.Box.prototype.containingBlock): (Layout.Box.prototype.setDisplayBox): Deleted. (Layout.Box.prototype.displayBox): Deleted. * LayoutReloaded/Utils.js: (Utils.layoutTreeDump): (Utils._findDisplayBox): (Utils._dumpBox): (Utils._dumpTree): * LayoutReloaded/misc/headers/BlockFormattingContext.h: * LayoutReloaded/misc/headers/FormattingContext.h: * LayoutReloaded/misc/headers/LayoutContext.h: * LayoutReloaded/test/index.html: Modified Paths trunk/Tools/ChangeLog trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js trunk/Tools/LayoutReloaded/FormattingState/BlockFormattingState.js trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js trunk/Tools/LayoutReloaded/FormattingState/InlineFormattingState.js trunk/Tools/LayoutReloaded/Layout.js trunk/Tools/LayoutReloaded/LayoutReloaded.xcworkspace/contents.xcworkspacedata trunk/Tools/LayoutReloaded/LayoutTree/Box.js trunk/Tools/LayoutReloaded/Utils.js trunk/Tools/LayoutReloaded/misc/headers/BlockFormattingContext.h trunk/Tools/LayoutReloaded/misc/headers/FormattingContext.h trunk/Tools/LayoutReloaded/misc/headers/LayoutContext.h trunk/Tools/LayoutReloaded/test/index.html Added Paths trunk/Tools/LayoutReloaded/LayoutState.js Removed Paths trunk/Tools/LayoutReloaded/LayoutContext.js Diff Modified: trunk/Tools/ChangeLog (229785 => 229786) --- trunk/Tools/ChangeLog 2018-03-21 03:40:17 UTC (rev 229785) +++ trunk/Tools/ChangeLog 2018-03-21 04:42:32 UTC (rev 229786) @@ -1,3 +1,71 @@ +2018-03-20 Zalan Bujtas + +[LayoutReloaded] Disconnect Display.Box from Layout.Box +https://bugs.webkit.org/show_bug.cgi?id=183805 + +Reviewed by Antti Koivisto. + +Display.Box is only accessed through the FormattingState. + +* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js: +(BlockFormattingContext): +(BlockFormattingContext.prototype.layout): +(BlockFormattingContext.prototype._placeInFlowPositionedChildren): +(BlockFormattingContext.prototype._layoutOutOfFlowDescendants): +(BlockFormattingContext.prototype._adjustBottomWithFIXME): +(BlockFormattingContext.prototype._computeOutOfFlowPosition): +* LayoutReloaded/FormattingContext/FormattingContext.js: +(FormattingContext): +(FormattingContext.prototype.formattingRoot): +
[webkit-changes] [229784] trunk
Title: [229784] trunk
Revision 229784
Author rn...@webkit.org
Date 2018-03-20 19:52:20 -0700 (Tue, 20 Mar 2018)
Log Message
Expose content attributes on _WKLinkIconParameters
https://bugs.webkit.org/show_bug.cgi?id=183768
Reviewed by Alex Christensen.
Source/WebCore:
Collect a vector of content attributes upon finding touch and fav-icons in order to expose it in a WebKit API.
Tests: IconLoading.DefaultFavicon
* html/LinkIconCollector.cpp:
(WebCore::LinkIconCollector::iconsOfTypes): Collect attributes.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startIconLoading): Use an empty vector for /favicon.ico.
* platform/LinkIcon.h:
(WebCore::LinkIcon::encode const): Encode the vector of content attributes.
(WebCore::LinkIcon::decode): Ditto for decoding.
Source/WebKit:
Added _WKLinkIconParameters.attributes to expose content attributes of a link element
which defined a favicon, touch icon, or pre-compressed touch icon.
* UIProcess/API/Cocoa/_WKLinkIconParameters.h:
(_WKLinkIconParameters.attributes): Added.
* UIProcess/API/Cocoa/_WKLinkIconParameters.mm:
(_WKLinkIconParameters._attributes): Added.
(-[_WKLinkIconParameters _initWithLinkIcon:]): Convert the hash map from WebCore to a NSDictionary.
(-[_WKLinkIconParameters attributes]): Added.
Tools:
Expanded the basic test case for _WKLinkIconParameters's properties including newly added "attributes".
* TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
(IconLoading.DefaultFavicon):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/LinkIconCollector.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/platform/LinkIcon.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKLinkIconParameters.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKLinkIconParameters.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (229783 => 229784)
--- trunk/Source/WebCore/ChangeLog 2018-03-21 02:28:29 UTC (rev 229783)
+++ trunk/Source/WebCore/ChangeLog 2018-03-21 02:52:20 UTC (rev 229784)
@@ -1,3 +1,22 @@
+2018-03-19 Ryosuke Niwa
+
+Expose content attributes on _WKLinkIconParameters
+https://bugs.webkit.org/show_bug.cgi?id=183768
+
+Reviewed by Alex Christensen.
+
+Collect a vector of content attributes upon finding touch and fav-icons in order to expose it in a WebKit API.
+
+Tests: IconLoading.DefaultFavicon
+
+* html/LinkIconCollector.cpp:
+(WebCore::LinkIconCollector::iconsOfTypes): Collect attributes.
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::startIconLoading): Use an empty vector for /favicon.ico.
+* platform/LinkIcon.h:
+(WebCore::LinkIcon::encode const): Encode the vector of content attributes.
+(WebCore::LinkIcon::decode): Ditto for decoding.
+
2018-03-20 Zalan Bujtas
RenderTreeNeedsLayoutChecker fails with absolutely positioned svg and
Modified: trunk/Source/WebCore/html/LinkIconCollector.cpp (229783 => 229784)
--- trunk/Source/WebCore/html/LinkIconCollector.cpp 2018-03-21 02:28:29 UTC (rev 229783)
+++ trunk/Source/WebCore/html/LinkIconCollector.cpp 2018-03-21 02:52:20 UTC (rev 229784)
@@ -104,7 +104,14 @@
iconSize = size;
}
-icons.append({ url, iconType, linkElement.type(), iconSize });
+Vector> attributes;
+if (linkElement.hasAttributes()) {
+attributes.reserveCapacity(linkElement.attributeCount());
+for (const Attribute& attribute : linkElement.attributesIterator())
+attributes.uncheckedAppend({ attribute.localName(), attribute.value() });
+}
+
+icons.append({ url, iconType, linkElement.type(), iconSize, WTFMove(attributes) });
}
std::sort(icons.begin(), icons.end(), [](auto& a, auto& b) {
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (229783 => 229784)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2018-03-21 02:28:29 UTC (rev 229783)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2018-03-21 02:52:20 UTC (rev 229784)
@@ -1870,7 +1870,7 @@
auto findResult = m_linkIcons.findMatching([](auto& icon) { return icon.type == LinkIconType::Favicon; });
if (findResult == notFound)
-m_linkIcons.append({ document->completeURL(ASCIILiteral("/favicon.ico")), LinkIconType::Favicon, String(), std::nullopt });
+m_linkIcons.append({ document->completeURL(ASCIILiteral("/favicon.ico")), LinkIconType::Favicon, String(), std::nullopt, { } });
if (!m_linkIcons.size())
return;
Modified: trunk/Source/WebCore/platform/LinkIcon.h (229783 => 229784)
--- trunk/Source/WebCore/platform/LinkIcon.h 2018-03-21 02:28:29 UTC (rev 229783)
+++ trunk/Source/WebCore/platform/LinkIcon.h 2018-03-21 02:52:20 UTC (rev 229784)
@@ -27,6 +27,7 @@
#include "LinkIconType.h"
#include "URL.h"
+#include
#include
#in
[webkit-changes] [229783] trunk
Title: [229783] trunk Revision 229783 Author wenson_hs...@apple.com Date 2018-03-20 19:28:29 -0700 (Tue, 20 Mar 2018) Log Message Add AssistedNodeInformation plumbing for form control placeholder text and label text https://bugs.webkit.org/show_bug.cgi?id=183802 Reviewed by Tim Horton. Source/WebKit: Surfaces some additional information about the currently focused element to the input delegate in the UI process. See comments below for more details. Test: WebKit.FocusedElementInfo * Shared/AssistedNodeInformation.cpp: (WebKit::AssistedNodeInformation::encode const): (WebKit::AssistedNodeInformation::decode): * Shared/AssistedNodeInformation.h: Add `placeholder` and `label` to AssistedNodeInformation, which capture the value of the placeholder attribute and the text of the first associated label element for the focused form control. Also add boilerplate encoder/ decoder support for these members. * UIProcess/API/Cocoa/_WKFocusedElementInfo.h: Augment _WKFocusedElementInfo to include placeholder and label. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKFocusedElementInfo initWithAssistedNodeInformation:isUserInitiated:userObject:]): (-[WKFocusedElementInfo label]): (-[WKFocusedElementInfo placeholder]): * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getAssistedNodeInformation): For input elements and textareas, set the placeholder to the value of the placeholder attribute. For all elements with associated labels, grab the inner text of the first label that is not empty, ignoring all labels that are `display: none` (i.e. not being rendered). Tools: Adds a new API test to exercise new placeholder and label SPI on _WKFocusedFormElement. * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm: (-[InputDelegate _webView:focusShouldStartInputSession:]): (-[InputDelegate shouldStartInputSessionHandler]): (-[InputDelegate setShouldStartInputSessionHandler:]): (TEST): (-[FormSubmissionDelegate webView:startURLSchemeTask:]): Deleted. (-[FormSubmissionDelegate webView:stopURLSchemeTask:]): Deleted. (-[FormSubmissionDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]): Deleted. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/AssistedNodeInformation.cpp trunk/Source/WebKit/Shared/AssistedNodeInformation.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKFocusedElementInfo.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm Diff Modified: trunk/Source/WebKit/ChangeLog (229782 => 229783) --- trunk/Source/WebKit/ChangeLog 2018-03-21 01:31:09 UTC (rev 229782) +++ trunk/Source/WebKit/ChangeLog 2018-03-21 02:28:29 UTC (rev 229783) @@ -1,3 +1,40 @@ +2018-03-20 Wenson Hsieh + +Add AssistedNodeInformation plumbing for form control placeholder text and label text +https://bugs.webkit.org/show_bug.cgi?id=183802 + + +Reviewed by Tim Horton. + +Surfaces some additional information about the currently focused element to the input delegate in the UI process. +See comments below for more details. + +Test: WebKit.FocusedElementInfo + +* Shared/AssistedNodeInformation.cpp: +(WebKit::AssistedNodeInformation::encode const): +(WebKit::AssistedNodeInformation::decode): +* Shared/AssistedNodeInformation.h: + +Add `placeholder` and `label` to AssistedNodeInformation, which capture the value of the placeholder attribute +and the text of the first associated label element for the focused form control. Also add boilerplate encoder/ +decoder support for these members. + +* UIProcess/API/Cocoa/_WKFocusedElementInfo.h: + +Augment _WKFocusedElementInfo to include placeholder and label. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKFocusedElementInfo initWithAssistedNodeInformation:isUserInitiated:userObject:]): +(-[WKFocusedElementInfo label]): +(-[WKFocusedElementInfo placeholder]): +* WebProcess/WebPage/ios/WebPageIOS.mm: +(WebKit::WebPage::getAssistedNodeInformation): + +For input elements and textareas, set the placeholder to the value of the placeholder attribute. For all +elements with associated labels, grab the inner text of the first label that is not empty, ignoring all labels +that are `display: none` (i.e. not being rendered). + 2018-03-20 Brady Eidson First piece of process swapping on navigation. Modified: trunk/Source/WebKit/Shared/AssistedNodeInformation.cpp (229782 => 229783) --- trunk/Source/WebKit/Shared/AssistedNodeInformation.cpp 2018-03-21 01:31:09 UTC (rev 229782) +++ trunk/Source/WebKit/Shared/AssistedNodeInformation.cpp 2018-03-21 02:28:29 UTC (rev 229783) @@ -89,6 +89,8 @@ encoder << acceptsAutofilledLoginCredentials; encoder << representingPageURL; encoder
[webkit-changes] [229782] trunk
Title: [229782] trunk
Revision 229782
Author za...@apple.com
Date 2018-03-20 18:31:09 -0700 (Tue, 20 Mar 2018)
Log Message
RenderTreeNeedsLayoutChecker fails with absolutely positioned svg and
https://bugs.webkit.org/show_bug.cgi?id=183718
Reviewed by Antti Koivisto.
Source/WebCore:
This patch ensures after resolving the style for an SVG element with a corresponding element (),
we adjust this style for the cloned SVG element too.
Test: svg/in-html/path-with-absolute-positioned-svg-and-use-crash.html
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustSVGElementStyle):
(WebCore::StyleResolver::adjustRenderStyle):
* css/StyleResolver.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::resolveCustomStyle):
LayoutTests:
* svg/in-html/path-with-absolute-positioned-svg-and-use-crash-expected.txt: Added.
* svg/in-html/path-with-absolute-positioned-svg-and-use-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/css/StyleResolver.h
trunk/Source/WebCore/svg/SVGElement.cpp
Added Paths
trunk/LayoutTests/svg/in-html/path-with-absolute-positioned-svg-and-use-crash-expected.txt
trunk/LayoutTests/svg/in-html/path-with-absolute-positioned-svg-and-use-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (229781 => 229782)
--- trunk/LayoutTests/ChangeLog 2018-03-21 01:09:36 UTC (rev 229781)
+++ trunk/LayoutTests/ChangeLog 2018-03-21 01:31:09 UTC (rev 229782)
@@ -1,3 +1,13 @@
+2018-03-20 Zalan Bujtas
+
+RenderTreeNeedsLayoutChecker fails with absolutely positioned svg and
+https://bugs.webkit.org/show_bug.cgi?id=183718
+
+Reviewed by Antti Koivisto.
+
+* svg/in-html/path-with-absolute-positioned-svg-and-use-crash-expected.txt: Added.
+* svg/in-html/path-with-absolute-positioned-svg-and-use-crash.html: Added.
+
2018-03-20 Ryan Haddad
Mark http/tests/appcache/abort-cache-onprogress.html as flaky.
Added: trunk/LayoutTests/svg/in-html/path-with-absolute-positioned-svg-and-use-crash-expected.txt (0 => 229782)
--- trunk/LayoutTests/svg/in-html/path-with-absolute-positioned-svg-and-use-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/in-html/path-with-absolute-positioned-svg-and-use-crash-expected.txt 2018-03-21 01:31:09 UTC (rev 229782)
@@ -0,0 +1 @@
+PASS if no crash.
Added: trunk/LayoutTests/svg/in-html/path-with-absolute-positioned-svg-and-use-crash.html (0 => 229782)
--- trunk/LayoutTests/svg/in-html/path-with-absolute-positioned-svg-and-use-crash.html (rev 0)
+++ trunk/LayoutTests/svg/in-html/path-with-absolute-positioned-svg-and-use-crash.html 2018-03-21 01:31:09 UTC (rev 229782)
@@ -0,0 +1,23 @@
+
+
+
+
+.c3 {
+}
+
+
+PASS if no crash.
+
+
+
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+document.body.offsetTop;
+document.styleSheets[0].insertRule('.c3 { border: 5px solid red; } ', '.c3');
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (229781 => 229782)
--- trunk/Source/WebCore/ChangeLog 2018-03-21 01:09:36 UTC (rev 229781)
+++ trunk/Source/WebCore/ChangeLog 2018-03-21 01:31:09 UTC (rev 229782)
@@ -1,3 +1,22 @@
+2018-03-20 Zalan Bujtas
+
+RenderTreeNeedsLayoutChecker fails with absolutely positioned svg and
+https://bugs.webkit.org/show_bug.cgi?id=183718
+
+Reviewed by Antti Koivisto.
+
+This patch ensures after resolving the style for an SVG element with a corresponding element (),
+we adjust this style for the cloned SVG element too.
+
+Test: svg/in-html/path-with-absolute-positioned-svg-and-use-crash.html
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::adjustSVGElementStyle):
+(WebCore::StyleResolver::adjustRenderStyle):
+* css/StyleResolver.h:
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::resolveCustomStyle):
+
2018-03-20 Brady Eidson
First piece of process swapping on navigation.
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (229781 => 229782)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2018-03-21 01:09:36 UTC (rev 229781)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2018-03-21 01:31:09 UTC (rev 229782)
@@ -810,6 +810,23 @@
style.setDisplay(NONE);
}
+void StyleResolver::adjustSVGElementStyle(const SVGElement& svgElement, RenderStyle& style)
+{
+// Only the root element in an SVG document fragment tree honors css position
+auto isPositioningAllowed = svgElement.hasTagName(SVGNames::svgTag) && svgElement.parentNode() && !svgElement.parentNode()->isSVGElement() && !svgElement.correspondingElement();
+if (!isPositioningAllowed)
+style.setPosition(RenderStyle::initialPosition());
+
+// RenderSVGRoot handles zooming for the whole SVG subtree, so foreignObject content should
+// not be scaled again.
+if (svgElement.hasTagName(SVGNames::foreignObjectTag))
+style.setEffecti
[webkit-changes] [229781] trunk/Tools
Title: [229781] trunk/Tools
Revision 229781
Author commit-qu...@webkit.org
Date 2018-03-20 18:09:36 -0700 (Tue, 20 Mar 2018)
Log Message
[WinCairo] Fix to run-webkit-httpd from native Windows.
https://bugs.webkit.org/show_bug.cgi?id=183605
Patch by Basuke Suzuki on 2018-03-20
Reviewed by Daniel Bates.
This fix is to run Apache HTTP server from native Windows. The environment is different
from cygwin, which is used for AppleWin, in following points:
- A temporary file behaves differently. It cannot reopen by anybody when indicated as
delete on close. To solve this situation, filesystem.mkdtemp() is used instead.
- It's not unix so that `tail` command is not available. Replaced with python equivalent
function.
* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.mkdtemp.TemporaryDirectory.__init__):
(FileSystem.mkdtemp.TemporaryDirectory.__exit__): The existing contents would be deleted.
(FileSystem.mkdtemp):
* Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
(parse_args):
(run_server):
(run_server_with_log_file):
(follow_file):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/filesystem.py
trunk/Tools/Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py
Diff
Modified: trunk/Tools/ChangeLog (229780 => 229781)
--- trunk/Tools/ChangeLog 2018-03-21 00:36:13 UTC (rev 229780)
+++ trunk/Tools/ChangeLog 2018-03-21 01:09:36 UTC (rev 229781)
@@ -1,3 +1,27 @@
+2018-03-20 Basuke Suzuki
+
+[WinCairo] Fix to run-webkit-httpd from native Windows.
+https://bugs.webkit.org/show_bug.cgi?id=183605
+
+Reviewed by Daniel Bates.
+
+This fix is to run Apache HTTP server from native Windows. The environment is different
+from cygwin, which is used for AppleWin, in following points:
+- A temporary file behaves differently. It cannot reopen by anybody when indicated as
+ delete on close. To solve this situation, filesystem.mkdtemp() is used instead.
+- It's not unix so that `tail` command is not available. Replaced with python equivalent
+ function.
+
+* Scripts/webkitpy/common/system/filesystem.py:
+(FileSystem.mkdtemp.TemporaryDirectory.__init__):
+(FileSystem.mkdtemp.TemporaryDirectory.__exit__): The existing contents would be deleted.
+(FileSystem.mkdtemp):
+* Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
+(parse_args):
+(run_server):
+(run_server_with_log_file):
+(follow_file):
+
2018-03-20 Brady Eidson
First piece of process swapping on navigation.
Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem.py (229780 => 229781)
--- trunk/Tools/Scripts/webkitpy/common/system/filesystem.py 2018-03-21 00:36:13 UTC (rev 229780)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem.py 2018-03-21 01:09:36 UTC (rev 229781)
@@ -176,7 +176,8 @@
methods. If you need a string, coerce the object to a string and go from there.
"""
class TemporaryDirectory(object):
-def __init__(self, **kwargs):
+def __init__(self, filesystem, **kwargs):
+self._filesystem = filesystem
self._kwargs = kwargs
self._directory_path = tempfile.mkdtemp(**self._kwargs)
@@ -187,14 +188,11 @@
return self._directory_path
def __exit__(self, type, value, traceback):
-# Only self-delete if necessary.
+if self._filesystem.exists(self._directory_path):
+self._filesystem.rmtree(self._directory_path)
-# FIXME: Should we delete non-empty directories?
-if os.path.exists(self._directory_path):
-os.rmdir(self._directory_path)
+return TemporaryDirectory(self, **kwargs)
-return TemporaryDirectory(**kwargs)
-
def maybe_make_directory(self, *path):
"""Create the specified directory if it doesn't already exist."""
try:
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py (229780 => 229781)
--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py 2018-03-21 00:36:13 UTC (rev 229780)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py 2018-03-21 01:09:36 UTC (rev 229781)
@@ -32,11 +32,12 @@
import optparse
import subprocess
import sys
-import tempfile
+import time
from webkitpy.common.host import Host
from webkitpy.layout_tests.servers import web_platform_test_server
from webkitpy.layout_tests.run_webkit_tests import EXCEPTIONAL_EXIT_STATUS
+from webkitpy.port import platform_options
def parse_args(args):
@@ -47,6 +48,11 @@
parser.add_option("--no-wpt", help="Do not start web-platform-tests server", action="" default=True, dest="web_platform_test_server")
parser.add_option("-D", "--additional-dir", help="Additional directory and alias", action="" default=
[webkit-changes] [229779] trunk/LayoutTests
Title: [229779] trunk/LayoutTests Revision 229779 Author ryanhad...@apple.com Date 2018-03-20 17:36:11 -0700 (Tue, 20 Mar 2018) Log Message Mark http/wpt/webrtc/third-party-frame-ice-candidate-filtering.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=183801 Unreviewed test gardening. * platform/wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (229778 => 229779) --- trunk/LayoutTests/ChangeLog 2018-03-21 00:05:58 UTC (rev 229778) +++ trunk/LayoutTests/ChangeLog 2018-03-21 00:36:11 UTC (rev 229779) @@ -1,3 +1,12 @@ +2018-03-20 Ryan Haddad + +Mark http/wpt/webrtc/third-party-frame-ice-candidate-filtering.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=183801 + +Unreviewed test gardening. + +* platform/wk2/TestExpectations: + 2018-03-20 Chris Dumez Unreviewed, rolling out r229726 and r229763. Modified: trunk/LayoutTests/platform/wk2/TestExpectations (229778 => 229779) --- trunk/LayoutTests/platform/wk2/TestExpectations 2018-03-21 00:05:58 UTC (rev 229778) +++ trunk/LayoutTests/platform/wk2/TestExpectations 2018-03-21 00:36:11 UTC (rev 229779) @@ -725,3 +725,5 @@ webkit.org/b/183139 fast/events/blur-focus-window-should-blur-focus-element.html webkit.org/b/183140 fast/selectors/querySelector-window-inactive.html +webkit.org/b/183801 http/wpt/webrtc/third-party-frame-ice-candidate-filtering.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229780] trunk/LayoutTests
Title: [229780] trunk/LayoutTests Revision 229780 Author ryanhad...@apple.com Date 2018-03-20 17:36:13 -0700 (Tue, 20 Mar 2018) Log Message Mark http/tests/appcache/abort-cache-onprogress.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=183684 Unreviewed test gardening. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (229779 => 229780) --- trunk/LayoutTests/ChangeLog 2018-03-21 00:36:11 UTC (rev 229779) +++ trunk/LayoutTests/ChangeLog 2018-03-21 00:36:13 UTC (rev 229780) @@ -1,5 +1,14 @@ 2018-03-20 Ryan Haddad +Mark http/tests/appcache/abort-cache-onprogress.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=183684 + +Unreviewed test gardening. + +* TestExpectations: + +2018-03-20 Ryan Haddad + Mark http/wpt/webrtc/third-party-frame-ice-candidate-filtering.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=183801 Modified: trunk/LayoutTests/TestExpectations (229779 => 229780) --- trunk/LayoutTests/TestExpectations 2018-03-21 00:36:11 UTC (rev 229779) +++ trunk/LayoutTests/TestExpectations 2018-03-21 00:36:13 UTC (rev 229780) @@ -944,6 +944,8 @@ webkit.org/b/141370 http/tests/security/appcache-in-private-browsing.html [ Pass Failure ] +webkit.org/b/183684 http/tests/appcache/abort-cache-onprogress.html [ Pass Failure ] + # The current expectations for this test only make sense for WebKit on iOS; other platforms can have very different behaviors. webkit.org/b/141488 fast/replaced/pdf-as-object-and-embed.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229778] trunk
Title: [229778] trunk Revision 229778 Author beid...@apple.com Date 2018-03-20 17:05:58 -0700 (Tue, 20 Mar 2018) Log Message First piece of process swapping on navigation. https://bugs.webkit.org/show_bug.cgi?id=183665 Reviewed by Andy Estes. Source/WebCore: Covered by API test(s) This patch: - A new PolicyAction::Suspend for future use in this feature - Makes sure that loads triggered as part of a process swap do *not* re-consult the policy delegate * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::continueAfterContentPolicy): * loader/FrameLoadRequest.h: (WebCore::FrameLoadRequest::setShouldCheckNavigationPolicy): (WebCore::FrameLoadRequest::shouldCheckNavigationPolicy const): * loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): * loader/FrameLoader.h: * loader/FrameLoaderTypes.h: Add a new Policy type "Suspend" to be used in the future by the process-swap-on-navigation mechanism. * loader/PolicyChecker.cpp: (WebCore::PolicyChecker::checkNavigationPolicy): (WebCore::PolicyChecker::checkNewWindowPolicy): Source/WebKit: This patch adds the first pieces of the following feature: "When a navigation originating inside a WKWebView goes to a different origin, swap to a new WebProcess for that navigation" There are significant bugs to be resolved and significant optimizations to be made. Which is why the feature is disabled by default. Besides the core logic implementing the feature, this patch does a lot of related work such as: - Removing some now-invalid ASSERTs - Adding some ASSERTs - Update various switch states to handle the new "Suspend" policy and "NavigationSwap" process termination reason * NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse): * NetworkProcess/capture/NetworkDataTaskReplay.cpp: (WebKit::NetworkCapture::NetworkDataTaskReplay::didReceiveResponse): * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (toNSURLSessionResponseDisposition): * Platform/Logging.h: * Shared/LoadParameters.cpp: (WebKit::LoadParameters::encode const): (WebKit::LoadParameters::decode): * Shared/LoadParameters.h: * Shared/ProcessTerminationReason.h: Add "NavigationSwap" as a process termination reason. * UIProcess/API/APINavigation.h: * UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::copy): * UIProcess/API/C/WKAPICast.h: (WebKit::toAPI): * UIProcess/Cocoa/NavigationState.mm: (WebKit::wkProcessTerminationReason): * UIProcess/WebFramePolicyListenerProxy.cpp: (WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy): * UIProcess/WebFramePolicyListenerProxy.h: (WebKit::WebFramePolicyListenerProxy::create): (WebKit::WebFramePolicyListenerProxy::policyListenerType const): * UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::setUpPolicyListenerProxy): (WebKit::WebFrameProxy::activePolicyListenerProxy): * UIProcess/WebFrameProxy.h: * UIProcess/WebNavigationState.cpp: (WebKit::WebNavigationState::navigation): (WebKit::WebNavigationState::takeNavigation): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess): (WebKit::WebPageProxy::attachToProcessForNavigation): Pretend that the existing process terminated using the new "NavigationSwap" reason, then manually start the next load. (WebKit::WebPageProxy::loadRequest): (WebKit::WebPageProxy::loadRequestWithNavigation): (WebKit::WebPageProxy::receivedPolicyDecision): (WebKit::WebPageProxy::continueNavigationInNewProcess): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForResponse): (WebKit::WebPageProxy::processDidTerminate): (WebKit::WebPageProxy::resetState): (WebKit::WebPageProxy::resetStateAfterProcessExited): * UIProcess/WebPageProxy.h: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): Determine which process should be used for a proposed navigation, creating a new one if necessary. * UIProcess/WebProcessPool.h: * UIProcess/WebStorage/StorageManager.cpp: (WebKit::StorageManager::SessionStorageNamespace::setAllowedConnection): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::loadRequest): Tools: Expose the "swaps processes on navigation" setting in MiniBrowser UI for testing: * MiniBrowser/mac/AppDelegate.m: (defaultConfiguration): * MiniBrowser/mac/SettingsController.h: * MiniBrowser/mac/SettingsController.m: (-[SettingsController _populateMenu]): (-[SettingsController validateMenuItem:]): (-[SettingsController processSwapOnNavigationEnabled]): (-[SettingsController toggleProcessSwapOnNavigation:]): Makes sure the current behavior is tested: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Added. (-[PSONNavigationDelegate webView:didFinishNavigation:]): (-[PSONScheme webView:startURLSchemeTask:]): (-[PSONScheme webView:stopURLSchemeTask:]): (TEST): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/
[webkit-changes] [229777] tags/Safari-606.1.10/
Title: [229777] tags/Safari-606.1.10/ Revision 229777 Author jmarc...@apple.com Date 2018-03-20 16:10:36 -0700 (Tue, 20 Mar 2018) Log Message Tag Safari-606.1.10. Added Paths tags/Safari-606.1.10/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229776] trunk
Title: [229776] trunk
Revision 229776
Author cdu...@apple.com
Date 2018-03-20 15:54:21 -0700 (Tue, 20 Mar 2018)
Log Message
QuickLook.NavigationDelegate API test is failing on iOS with async policy delegates
https://bugs.webkit.org/show_bug.cgi?id=183791
Reviewed by Alex Christensen.
Source/WebCore:
Update PreviewLoader to not send data (or call finishFinishLoading) until
the resource response has been processed.
* loader/ios/PreviewLoader.mm:
(-[WebPreviewLoader _sendDidReceiveResponseIfNecessary]):
(-[WebPreviewLoader connection:didReceiveData:lengthReceived:]):
(-[WebPreviewLoader connectionDidFinishLoading:]):
Tools:
Add API test coverage.
* TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
(-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
(-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
(-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]):
(TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ios/PreviewLoader.mm
trunk/Source/WebCore/platform/SharedBuffer.h
trunk/Source/WebCore/platform/cocoa/SharedBufferCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (229775 => 229776)
--- trunk/Source/WebCore/ChangeLog 2018-03-20 21:59:33 UTC (rev 229775)
+++ trunk/Source/WebCore/ChangeLog 2018-03-20 22:54:21 UTC (rev 229776)
@@ -1,3 +1,18 @@
+2018-03-20 Chris Dumez
+
+QuickLook.NavigationDelegate API test is failing on iOS with async policy delegates
+https://bugs.webkit.org/show_bug.cgi?id=183791
+
+Reviewed by Alex Christensen.
+
+Update PreviewLoader to not send data (or call finishFinishLoading) until
+the resource response has been processed.
+
+* loader/ios/PreviewLoader.mm:
+(-[WebPreviewLoader _sendDidReceiveResponseIfNecessary]):
+(-[WebPreviewLoader connection:didReceiveData:lengthReceived:]):
+(-[WebPreviewLoader connectionDidFinishLoading:]):
+
2018-03-20 Antoine Quint
[Web Animations] Update the timing model when pending tasks schedule changes
Modified: trunk/Source/WebCore/loader/ios/PreviewLoader.mm (229775 => 229776)
--- trunk/Source/WebCore/loader/ios/PreviewLoader.mm 2018-03-20 21:59:33 UTC (rev 229775)
+++ trunk/Source/WebCore/loader/ios/PreviewLoader.mm 2018-03-20 22:54:21 UTC (rev 229776)
@@ -48,6 +48,10 @@
std::unique_ptr _converter;
RetainPtr _bufferedDataArray;
BOOL _hasSentDidReceiveResponse;
+BOOL _hasProcessedResponse;
+RefPtr _bufferedData;
+long long _lengthReceived;
+BOOL _needsToCallDidFinishLoading;
}
- (instancetype)initWithResourceLoader:(ResourceLoader&)resourceLoader resourceResponse:(const ResourceResponse&)resourceResponse;
@@ -130,7 +134,26 @@
_resourceLoader->documentLoader()->setPreviewConverter(WTFMove(_converter));
_hasSentDidReceiveResponse = YES;
-_resourceLoader->didReceiveResponse(response, nullptr);
+_hasProcessedResponse = NO;
+_resourceLoader->didReceiveResponse(response, [self, retainedSelf = retainPtr(self)] {
+_hasProcessedResponse = YES;
+
+if (_resourceLoader->reachedTerminalState())
+return;
+
+if (auto bufferedData = WTFMove(_bufferedData)) {
+_resourceLoader->didReceiveData(bufferedData->data(), bufferedData->size(), _lengthReceived, DataPayloadBytes);
+_lengthReceived = 0;
+}
+
+if (_resourceLoader->reachedTerminalState())
+return;
+
+if (_needsToCallDidFinishLoading) {
+_needsToCallDidFinishLoading = NO;
+_resourceLoader->didFinishLoading(NetworkLoadMetrics { });
+}
+});
}
- (void)connection:(NSURLConnection *)connection didReceiveData:(NSData *)data lengthReceived:(long long)lengthReceived
@@ -141,10 +164,23 @@
[self _sendDidReceiveResponseIfNecessary];
+auto dataLength = data.length;
+
// QuickLook code sends us a nil data at times. The check below is the same as the one in
// ResourceHandleMac.cpp added for a different bug.
-if (auto dataLength = data.length)
+if (!dataLength)
+return;
+
+if (_hasProcessedResponse) {
_resourceLoader->didReceiveData(reinterpret_cast(data.bytes), dataLength, lengthReceived, DataPayloadBytes);
+return;
+}
+
+if (!_bufferedData)
+_bufferedData = SharedBuffer::create(data);
+else
+_bufferedData->append(data);
+_lengthReceived += lengthReceived;
}
- (void)connectionDidFinishLoading:(NSURLConnection *)connection
@@ -155,8 +191,12 @@
ASSERT(_hasSentDidReceiveResponse);
-NetworkLoadMetrics emptyMetrics;
-_resourceLoader->didFinishLoading(emptyMetrics);
+if (!_hasProcessedResponse
[webkit-changes] [229775] trunk
Title: [229775] trunk
Revision 229775
Author sbar...@apple.com
Date 2018-03-20 14:59:33 -0700 (Tue, 20 Mar 2018)
Log Message
We need to do proper bookkeeping of exitOK when inserting constants when sinking NewArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=183795
Reviewed by JF Bastien.
JSTests:
* stress/sink-phantom-new-array-buffer-exit-ok.js: Added.
(foo):
(bar):
Source/_javascript_Core:
We were just assuming that the constants we were inserting were
always exitOK=true. However, this breaks validation. The exitOK
we emit for the constants in the NewArrayBuffer should respect
the current exit state of the IR we've emitted. This is just IR
bookkeeping since JSConstant is a non-exiting node.
* dfg/DFGArgumentsEliminationPhase.cpp:
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp
Added Paths
trunk/JSTests/stress/sink-phantom-new-array-buffer-exit-ok.js
Diff
Modified: trunk/JSTests/ChangeLog (229774 => 229775)
--- trunk/JSTests/ChangeLog 2018-03-20 21:53:38 UTC (rev 229774)
+++ trunk/JSTests/ChangeLog 2018-03-20 21:59:33 UTC (rev 229775)
@@ -1,3 +1,15 @@
+2018-03-20 Saam Barati
+
+We need to do proper bookkeeping of exitOK when inserting constants when sinking NewArrayBuffer
+https://bugs.webkit.org/show_bug.cgi?id=183795
+
+
+Reviewed by JF Bastien.
+
+* stress/sink-phantom-new-array-buffer-exit-ok.js: Added.
+(foo):
+(bar):
+
2018-03-16 Yusuke Suzuki
[DFG][FTL] Add vectorLengthHint for NewArray
Added: trunk/JSTests/stress/sink-phantom-new-array-buffer-exit-ok.js (0 => 229775)
--- trunk/JSTests/stress/sink-phantom-new-array-buffer-exit-ok.js (rev 0)
+++ trunk/JSTests/stress/sink-phantom-new-array-buffer-exit-ok.js 2018-03-20 21:59:33 UTC (rev 229775)
@@ -0,0 +1,8 @@
+function foo() {
+}
+function bar() {
+foo(...[42]);
+}
+for (var i = 0; i < 40; i++) {
+bar();
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (229774 => 229775)
--- trunk/Source/_javascript_Core/ChangeLog 2018-03-20 21:53:38 UTC (rev 229774)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-03-20 21:59:33 UTC (rev 229775)
@@ -1,3 +1,19 @@
+2018-03-20 Saam Barati
+
+We need to do proper bookkeeping of exitOK when inserting constants when sinking NewArrayBuffer
+https://bugs.webkit.org/show_bug.cgi?id=183795
+
+
+Reviewed by JF Bastien.
+
+We were just assuming that the constants we were inserting were
+always exitOK=true. However, this breaks validation. The exitOK
+we emit for the constants in the NewArrayBuffer should respect
+the current exit state of the IR we've emitted. This is just IR
+bookkeeping since JSConstant is a non-exiting node.
+
+* dfg/DFGArgumentsEliminationPhase.cpp:
+
2018-03-20 Guillaume Emont
MIPS+Armv7 builds are broken since r229391
Modified: trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp (229774 => 229775)
--- trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp 2018-03-20 21:53:38 UTC (rev 229774)
+++ trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp 2018-03-20 21:59:33 UTC (rev 229775)
@@ -919,7 +919,6 @@
}
if (candidate->op() == PhantomNewArrayBuffer) {
-bool canExit = true;
auto* array = candidate->castOperand();
for (unsigned index = 0; index < array->length(); ++index) {
JSValue constant;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229774] trunk/Source/WebKit
Title: [229774] trunk/Source/WebKit
Revision 229774
Author you...@apple.com
Date 2018-03-20 14:53:38 -0700 (Tue, 20 Mar 2018)
Log Message
ServiceWorkerClientFetch::didReceiveData should check for m_encodedDataLength
https://bugs.webkit.org/show_bug.cgi?id=183668
Reviewed by Chris Dumez.
Crash happens when releasing a RefPtr buffer that is null.
It happens because ServiceWorkerClientFetch can call m_loader->didReceiveBuffer at two different places.
Either when receiving an IPC call or as part of completion handler for the response validation check.
At each call site, we release the buffer to pass it to the loader and we set m_encodedLength to zero.
The fix is to add the m_encodedLength check like done in the case of response validation check completion handler.
* WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didReceiveData):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (229773 => 229774)
--- trunk/Source/WebKit/ChangeLog 2018-03-20 21:21:06 UTC (rev 229773)
+++ trunk/Source/WebKit/ChangeLog 2018-03-20 21:53:38 UTC (rev 229774)
@@ -1,3 +1,19 @@
+2018-03-20 Youenn Fablet
+
+ServiceWorkerClientFetch::didReceiveData should check for m_encodedDataLength
+https://bugs.webkit.org/show_bug.cgi?id=183668
+
+Reviewed by Chris Dumez.
+
+Crash happens when releasing a RefPtr buffer that is null.
+It happens because ServiceWorkerClientFetch can call m_loader->didReceiveBuffer at two different places.
+Either when receiving an IPC call or as part of completion handler for the response validation check.
+At each call site, we release the buffer to pass it to the loader and we set m_encodedLength to zero.
+The fix is to add the m_encodedLength check like done in the case of response validation check completion handler.
+
+* WebProcess/Storage/ServiceWorkerClientFetch.cpp:
+(WebKit::ServiceWorkerClientFetch::didReceiveData):
+
2018-03-20 Jeff Miller
Expose aggressiveTileRetentionEnabled in WKPreferences SPI to match C SPI
Modified: trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp (229773 => 229774)
--- trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp 2018-03-20 21:21:06 UTC (rev 229773)
+++ trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp 2018-03-20 21:53:38 UTC (rev 229774)
@@ -175,7 +175,7 @@
return;
callOnMainThread([this, protectedThis = makeRef(*this)] {
-if (!m_loader)
+if (!m_loader || !m_encodedDataLength)
return;
m_loader->didReceiveBuffer(m_buffer.releaseNonNull(), m_encodedDataLength, DataPayloadBytes);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229773] trunk/Source/WebKit
Title: [229773] trunk/Source/WebKit
Revision 229773
Author je...@apple.com
Date 2018-03-20 14:21:06 -0700 (Tue, 20 Mar 2018)
Log Message
Expose aggressiveTileRetentionEnabled in WKPreferences SPI to match C SPI
https://bugs.webkit.org/show_bug.cgi?id=183790
Reviewed by Alex Christensen.
Expose this property on macOS only.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setAggressiveTileRetentionEnabled:]):
(-[WKPreferences _aggressiveTileRetentionEnabled]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (229772 => 229773)
--- trunk/Source/WebKit/ChangeLog 2018-03-20 20:37:46 UTC (rev 229772)
+++ trunk/Source/WebKit/ChangeLog 2018-03-20 21:21:06 UTC (rev 229773)
@@ -1,3 +1,17 @@
+2018-03-20 Jeff Miller
+
+Expose aggressiveTileRetentionEnabled in WKPreferences SPI to match C SPI
+https://bugs.webkit.org/show_bug.cgi?id=183790
+
+Reviewed by Alex Christensen.
+
+Expose this property on macOS only.
+
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _setAggressiveTileRetentionEnabled:]):
+(-[WKPreferences _aggressiveTileRetentionEnabled]):
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
2018-03-20 Tim Horton
Add and adopt WK_PLATFORM_NAME and adjust default feature defines
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (229772 => 229773)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-03-20 20:37:46 UTC (rev 229772)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-03-20 21:21:06 UTC (rev 229773)
@@ -1202,6 +1202,16 @@
return _preferences->webAudioEnabled();
}
+- (void)_setAggressiveTileRetentionEnabled:(BOOL)enabled
+{
+_preferences->setAggressiveTileRetentionEnabled(enabled);
+}
+
+- (BOOL)_aggressiveTileRetentionEnabled
+{
+return _preferences->aggressiveTileRetentionEnabled();
+}
+
#endif // PLATFORM(MAC)
- (BOOL)_javaScriptCanAccessClipboard
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (229772 => 229773)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2018-03-20 20:37:46 UTC (rev 229772)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2018-03-20 21:21:06 UTC (rev 229773)
@@ -180,6 +180,7 @@
@property (nonatomic, setter=_setUseGiantTiles:) BOOL _useGiantTiles WK_API_AVAILABLE(macosx(WK_MAC_TBA));
@property (nonatomic, setter=_setWantsBalancedSetDefersLoadingBehavior:) BOOL _wantsBalancedSetDefersLoadingBehavior WK_API_AVAILABLE(macosx(WK_MAC_TBA));
@property (nonatomic, setter=_setWebAudioEnabled:) BOOL _webAudioEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
+@property (nonatomic, setter=_setAggressiveTileRetentionEnabled:) BOOL _aggressiveTileRetentionEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA));
#endif
@end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229771] trunk
Title: [229771] trunk
Revision 229771
Author commit-qu...@webkit.org
Date 2018-03-20 13:29:57 -0700 (Tue, 20 Mar 2018)
Log Message
[Web Animations] Update the timing model when pending tasks schedule changes
https://bugs.webkit.org/show_bug.cgi?id=183785
Patch by Antoine Quint on 2018-03-20
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Record a progression now that we correctly invalidate effects as their pending play
or pause task schedule changes. Setting an animation's effect resets pending tasks.
* web-platform-tests/web-animations/interfaces/Animation/effect-expected.txt:
Source/WebCore:
Changing the time at which a pending play or pause task is scheduled changes the pending
state of the animation and thus should notify that the timing model has changed and invalidate
the effect.
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::setTimeToRunPendingPlayTask):
(WebCore::WebAnimation::setTimeToRunPendingPauseTask):
(WebCore::WebAnimation::updatePendingTasks):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/effect-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/WebAnimation.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (229770 => 229771)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-03-20 20:26:17 UTC (rev 229770)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-03-20 20:29:57 UTC (rev 229771)
@@ -1,3 +1,15 @@
+2018-03-20 Antoine Quint
+
+[Web Animations] Update the timing model when pending tasks schedule changes
+https://bugs.webkit.org/show_bug.cgi?id=183785
+
+Reviewed by Dean Jackson.
+
+Record a progression now that we correctly invalidate effects as their pending play
+or pause task schedule changes. Setting an animation's effect resets pending tasks.
+
+* web-platform-tests/web-animations/interfaces/Animation/effect-expected.txt:
+
2018-03-16 Claudio Saavedra
Unreviewed rebaseline
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/effect-expected.txt (229770 => 229771)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/effect-expected.txt 2018-03-20 20:26:17 UTC (rev 229770)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/effect-expected.txt 2018-03-20 20:29:57 UTC (rev 229771)
@@ -1,4 +1,4 @@
PASS effect is set correctly.
-FAIL Clearing and setting Animation.effect should update the computed style of the target element assert_equals: animation no longer has an effect expected "auto" but got "100px"
+PASS Clearing and setting Animation.effect should update the computed style of the target element
Modified: trunk/Source/WebCore/ChangeLog (229770 => 229771)
--- trunk/Source/WebCore/ChangeLog 2018-03-20 20:26:17 UTC (rev 229770)
+++ trunk/Source/WebCore/ChangeLog 2018-03-20 20:29:57 UTC (rev 229771)
@@ -1,3 +1,19 @@
+2018-03-20 Antoine Quint
+
+[Web Animations] Update the timing model when pending tasks schedule changes
+https://bugs.webkit.org/show_bug.cgi?id=183785
+
+Reviewed by Dean Jackson.
+
+Changing the time at which a pending play or pause task is scheduled changes the pending
+state of the animation and thus should notify that the timing model has changed and invalidate
+the effect.
+
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::setTimeToRunPendingPlayTask):
+(WebCore::WebAnimation::setTimeToRunPendingPauseTask):
+(WebCore::WebAnimation::updatePendingTasks):
+
2018-03-20 Tim Horton
Add and adopt WK_PLATFORM_NAME and adjust default feature defines
Modified: trunk/Source/WebCore/animation/WebAnimation.cpp (229770 => 229771)
--- trunk/Source/WebCore/animation/WebAnimation.cpp 2018-03-20 20:26:17 UTC (rev 229770)
+++ trunk/Source/WebCore/animation/WebAnimation.cpp 2018-03-20 20:29:57 UTC (rev 229771)
@@ -784,6 +784,9 @@
void WebAnimation::setTimeToRunPendingPlayTask(TimeToRunPendingTask timeToRunPendingTask)
{
+if (m_timeToRunPendingPlayTask == timeToRunPendingTask)
+return;
+
m_timeToRunPendingPlayTask = timeToRunPendingTask;
updatePendingTasks();
}
@@ -909,6 +912,9 @@
void WebAnimation::setTimeToRunPendingPauseTask(TimeToRunPendingTask timeToRunPendingTask)
{
+if (m_timeToRunPendingPauseTask == timeToRunPendingTask)
+return;
+
m_timeToRunPendingPauseTask = timeToRunPendingTask;
updatePendingTasks();
}
@@ -964,6 +970,8 @@
});
}
}
+
+timingModelDidChange();
}
Seconds WebAnimation::timeToNextRequiredTick(Seconds timelineTime) const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229770] trunk/Source/WTF
Title: [229770] trunk/Source/WTF
Revision 229770
Author bb...@apple.com
Date 2018-03-20 13:26:17 -0700 (Tue, 20 Mar 2018)
Log Message
SLEEP_THREAD_FOR_DEBUGGER should not use fancy number literals
https://bugs.webkit.org/show_bug.cgi?id=183792
Reviewed by Timothy Hatcher.
* wtf/DebugUtilities.h: Remove the '_s' since this won't
compile when included by files compiled as Objective-C++.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/DebugUtilities.h
Diff
Modified: trunk/Source/WTF/ChangeLog (229769 => 229770)
--- trunk/Source/WTF/ChangeLog 2018-03-20 18:25:16 UTC (rev 229769)
+++ trunk/Source/WTF/ChangeLog 2018-03-20 20:26:17 UTC (rev 229770)
@@ -1,3 +1,13 @@
+2018-03-20 Brian Burg
+
+SLEEP_THREAD_FOR_DEBUGGER should not use fancy number literals
+https://bugs.webkit.org/show_bug.cgi?id=183792
+
+Reviewed by Timothy Hatcher.
+
+* wtf/DebugUtilities.h: Remove the '_s' since this won't
+compile when included by files compiled as Objective-C++.
+
2018-03-20 Tim Horton
Add and adopt WK_PLATFORM_NAME and adjust default feature defines
Modified: trunk/Source/WTF/wtf/DebugUtilities.h (229769 => 229770)
--- trunk/Source/WTF/wtf/DebugUtilities.h 2018-03-20 18:25:16 UTC (rev 229769)
+++ trunk/Source/WTF/wtf/DebugUtilities.h 2018-03-20 20:26:17 UTC (rev 229770)
@@ -32,7 +32,7 @@
#define SLEEP_THREAD_FOR_DEBUGGER() \
do { \
do { \
-sleep(1_s); \
+sleep(1); \
if (WTFIsDebuggerAttached()) \
break; \
} while (1); \
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229769] tags/Safari-606.1.7.2/Source/WTF
Title: [229769] tags/Safari-606.1.7.2/Source/WTF Revision 229769 Author jmarc...@apple.com Date 2018-03-20 11:25:16 -0700 (Tue, 20 Mar 2018) Log Message Cherry-pick r229301. rdar://problem/38422294 Modified Paths tags/Safari-606.1.7.2/Source/WTF/ChangeLog tags/Safari-606.1.7.2/Source/WTF/wtf/OSAllocatorPosix.cpp Diff Modified: tags/Safari-606.1.7.2/Source/WTF/ChangeLog (229768 => 229769) --- tags/Safari-606.1.7.2/Source/WTF/ChangeLog 2018-03-20 18:18:37 UTC (rev 229768) +++ tags/Safari-606.1.7.2/Source/WTF/ChangeLog 2018-03-20 18:25:16 UTC (rev 229769) @@ -1,3 +1,19 @@ +2018-03-20 Jason Marcell + +Cherry-pick r229301. rdar://problem/38422294 + +2018-03-05 Michael Saboff + +Start using MAP_JIT for macOS +https://bugs.webkit.org/show_bug.cgi?id=183353 + +Reviewed by Filip Pizlo. + +Unify setting this flag for both iOS and macOS. + +* wtf/OSAllocatorPosix.cpp: +(WTF::OSAllocator::reserveAndCommit): + 2018-03-02 Yusuke Suzuki [WTF] Remove RunLoop and RunLoop::Timer's interface using double as seconds Modified: tags/Safari-606.1.7.2/Source/WTF/wtf/OSAllocatorPosix.cpp (229768 => 229769) --- tags/Safari-606.1.7.2/Source/WTF/wtf/OSAllocatorPosix.cpp 2018-03-20 18:18:37 UTC (rev 229768) +++ tags/Safari-606.1.7.2/Source/WTF/wtf/OSAllocatorPosix.cpp 2018-03-20 18:25:16 UTC (rev 229769) @@ -71,7 +71,7 @@ protection |= PROT_EXEC; int flags = MAP_PRIVATE | MAP_ANON; -#if PLATFORM(IOS) +#if OS(DARWIN) if (executable) flags |= MAP_JIT; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229767] trunk/Source/JavaScriptCore
Title: [229767] trunk/Source/_javascript_Core Revision 229767 Author mark@apple.com Date 2018-03-20 11:10:16 -0700 (Tue, 20 Mar 2018) Log Message Improve FunctionPtr and use it in the JIT CallRecord. https://bugs.webkit.org/show_bug.cgi?id=183756 Reviewed by JF Bastien. 1. FunctionPtr hold a C/C++ function pointer by default. Change its default PtrTag to reflect that. 2. Delete the FunctionPtr::value() method. It is effectively a duplicate of executableAddress(). 3. Fix the FunctionPtr constructor that takes arbitrary pointers to be able to take "any" pointer. "any" in this case means that the pointer may not be typed as a C/C++ function to the C++ compiler (due to upstream casting or usage of void* as a storage type), but it is still expected to be pointing to a C/C++ function. 4. Added a FunctionPtr constructor that takes another FunctionPtr. This is a convenience constructor that lets us retag the underlying pointer. The other FunctionPtr is still expected to point to a C/C++ function. 5. Added PtrTag assertion placeholder functions to be implemented later. 6. Change the JIT CallRecord to embed a FunctionPtr callee instead of a void* to pointer. This improves type safety, and assists in getting pointer tagging right later. 7. Added versions of JIT callOperations methods that will take a PtrTag. This is preparation for more more pointer tagging work later. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::linkCall): * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::linkCall): * assembler/MacroAssemblerCodeRef.h: (JSC::FunctionPtr::FunctionPtr): (JSC::FunctionPtr::operator bool const): (JSC::FunctionPtr::operator! const): (JSC::ReturnAddressPtr::ReturnAddressPtr): (JSC::MacroAssemblerCodePtr::retagged const): (JSC::MacroAssemblerCodeRef::retaggedCode const): (JSC::FunctionPtr::value const): Deleted. * assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::linkCall): * assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::linkCall): * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::callWithSlowPathReturnType): (JSC::MacroAssemblerX86_64::linkCall): * bytecode/AccessCase.cpp: (JSC::AccessCase::generateImpl): * ftl/FTLSlowPathCall.cpp: (JSC::FTL::SlowPathCallContext::makeCall): * ftl/FTLSlowPathCall.h: (JSC::FTL::callOperation): * ftl/FTLThunks.cpp: (JSC::FTL::osrExitGenerationThunkGenerator): (JSC::FTL::lazySlowPathGenerationThunkGenerator): (JSC::FTL::slowPathCallThunkGenerator): * jit/JIT.cpp: (JSC::JIT::link): (JSC::JIT::privateCompileExceptionHandlers): * jit/JIT.h: (JSC::CallRecord::CallRecord): (JSC::JIT::appendCall): (JSC::JIT::appendCallWithSlowPathReturnType): (JSC::JIT::callOperation): (JSC::JIT::callOperationWithProfile): (JSC::JIT::callOperationWithResult): (JSC::JIT::callOperationNoExceptionCheck): (JSC::JIT::callOperationWithCallFrameRollbackOnException): * jit/JITArithmetic.cpp: (JSC::JIT::emitMathICFast): (JSC::JIT::emitMathICSlow): * jit/JITInlines.h: (JSC::JIT::emitNakedCall): (JSC::JIT::emitNakedTailCall): (JSC::JIT::appendCallWithExceptionCheck): (JSC::JIT::appendCallWithExceptionCheckAndSlowPathReturnType): (JSC::JIT::appendCallWithCallFrameRollbackOnException): (JSC::JIT::appendCallWithExceptionCheckSetJSValueResult): (JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile): * jit/JITPropertyAccess.cpp: (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::privateCompileGetByValWithCachedId): (JSC::JIT::privateCompilePutByVal): (JSC::JIT::privateCompilePutByValWithCachedId): * jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emitSlow_op_put_by_val): * jit/Repatch.cpp: (JSC::linkPolymorphicCall): * jit/SlowPathCall.h: (JSC::JITSlowPathCall::JITSlowPathCall): (JSC::JITSlowPathCall::call): * jit/ThunkGenerators.cpp: (JSC::nativeForGenerator): * runtime/PtrTag.h: (JSC::nextPtrTagID): (JSC::assertIsCFunctionPtr): (JSC::assertIsNullOrCFunctionPtr): (JSC::assertIsNotTagged): (JSC::assertIsTagged): (JSC::assertIsNullOrTagged): (JSC::assertIsTaggedWith): (JSC::assertIsNullOrTaggedWith): (JSC::uniquePtrTagID): Deleted. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h trunk/Source/_javascript_Core/bytecode/AccessCase.cpp trunk/Source/_javascript_Core/ftl/FTLSlowPathCall.cpp trunk/Source/_javascript_Core/ftl/FTLSlowPathCall.h trunk/Source/_javascript_Core/ftl/FTLThunks.cpp trunk/Source/_javascript_Core/jit/JIT.cpp trunk/Source/_javascript_Core/jit/JIT.h trunk/Source/_javascript_Core/jit/JITArithmetic.cpp trunk/Source/_javascript_Core/jit/JITInlines.h trunk/Source/_javascript_Core/jit/JITProper
[webkit-changes] [229766] trunk/Source/JavaScriptCore
Title: [229766] trunk/Source/_javascript_Core
Revision 229766
Author commit-qu...@webkit.org
Date 2018-03-20 10:53:59 -0700 (Tue, 20 Mar 2018)
Log Message
[MIPS] Optimize generated JIT code for loads/stores
https://bugs.webkit.org/show_bug.cgi?id=183243
Patch by Stanislav Ocovaj on 2018-03-20
Reviewed by Yusuke Suzuki.
JIT generates three MIPS instructions for a load/store from/to an absolute address:
lui adrTmpReg, address >> 16
ori adrTmpReg, address & 0x
lw dataReg, 0(adrTmpReg)
Since load/store instructions on MIPS have a 16-bit offset, lower 16 bits of the address can
be encoded into the load/store and ori instruction can be removed:
lui adrTmpReg, (address + 0x8000) >> 16
lw dataReg, (address & 0x)(adrTmpReg)
Also, in loads/stores with BaseIndex address, the left shift can be omitted if address.scale is 0.
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::add32):
(JSC::MacroAssemblerMIPS::add64):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::convertibleLoadPtr):
(JSC::MacroAssemblerMIPS::load8):
(JSC::MacroAssemblerMIPS::load8SignedExtendTo32):
(JSC::MacroAssemblerMIPS::load32):
(JSC::MacroAssemblerMIPS::store8):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::branchTest8):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::loadDouble):
(JSC::MacroAssemblerMIPS::storeDouble):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (229765 => 229766)
--- trunk/Source/_javascript_Core/ChangeLog 2018-03-20 17:10:16 UTC (rev 229765)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-03-20 17:53:59 UTC (rev 229766)
@@ -1,3 +1,40 @@
+2018-03-20 Stanislav Ocovaj
+
+[MIPS] Optimize generated JIT code for loads/stores
+https://bugs.webkit.org/show_bug.cgi?id=183243
+
+Reviewed by Yusuke Suzuki.
+
+JIT generates three MIPS instructions for a load/store from/to an absolute address:
+
+ lui adrTmpReg, address >> 16
+ ori adrTmpReg, address & 0x
+ lw dataReg, 0(adrTmpReg)
+
+Since load/store instructions on MIPS have a 16-bit offset, lower 16 bits of the address can
+be encoded into the load/store and ori instruction can be removed:
+
+ lui adrTmpReg, (address + 0x8000) >> 16
+ lw dataReg, (address & 0x)(adrTmpReg)
+
+Also, in loads/stores with BaseIndex address, the left shift can be omitted if address.scale is 0.
+
+* assembler/MacroAssemblerMIPS.h:
+(JSC::MacroAssemblerMIPS::add32):
+(JSC::MacroAssemblerMIPS::add64):
+(JSC::MacroAssemblerMIPS::or32):
+(JSC::MacroAssemblerMIPS::sub32):
+(JSC::MacroAssemblerMIPS::convertibleLoadPtr):
+(JSC::MacroAssemblerMIPS::load8):
+(JSC::MacroAssemblerMIPS::load8SignedExtendTo32):
+(JSC::MacroAssemblerMIPS::load32):
+(JSC::MacroAssemblerMIPS::store8):
+(JSC::MacroAssemblerMIPS::store32):
+(JSC::MacroAssemblerMIPS::branchTest8):
+(JSC::MacroAssemblerMIPS::branchAdd32):
+(JSC::MacroAssemblerMIPS::loadDouble):
+(JSC::MacroAssemblerMIPS::storeDouble):
+
2018-03-16 Yusuke Suzuki
[DFG][FTL] Add vectorLengthHint for NewArray
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h (229765 => 229766)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h 2018-03-20 17:10:16 UTC (rev 229765)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h 2018-03-20 17:53:59 UTC (rev 229766)
@@ -235,26 +235,56 @@
void add32(TrustedImm32 imm, AbsoluteAddress address)
{
-/*
- li addrTemp, address
- li immTemp, imm
- lw cmpTemp, 0(addrTemp)
- addu dataTemp, cmpTemp, immTemp
- sw dataTemp, 0(addrTemp)
-*/
-move(TrustedImmPtr(address.m_ptr), addrTempRegister);
-m_assembler.lw(cmpTempRegister, addrTempRegister, 0);
-if (imm.m_value >= -32768 && imm.m_value <= 32767 && !m_fixedWidth)
-m_assembler.addiu(dataTempRegister, cmpTempRegister, imm.m_value);
-else {
+if (!m_fixedWidth) {
+uintptr_t adr = reinterpret_cast(address.m_ptr);
+m_assembler.lui(addrTempRegister, (adr + 0x8000) >> 16);
+m_assembler.lw(cmpTempRegister, addrTempRegister, adr & 0x);
+if (imm.m_value >= -32768 && imm.m_value <= 32767)
+m_assembler.addiu(dataTempRegister, cmpTempRegister, imm.m_value);
+else {
+move(imm, immTempRegister);
+m_assembler.addu(dataTempRegister, cmpTempRegister, immTempRegister);
+}
+m_assembler.sw(dataTempRegister, addrTempRegister, adr & 0x);
+} else {
+/*
+ li addrTemp, address
+
[webkit-changes] [229764] trunk
Title: [229764] trunk Revision 229764 Author cdu...@apple.com Date 2018-03-20 10:08:05 -0700 (Tue, 20 Mar 2018) Log Message Unreviewed, rolling out r229726 and r229763. Caused some API test failures on iOS Reverted changesets: "Make policy decisions asynchronous" https://bugs.webkit.org/show_bug.cgi?id=180568 https://trac.webkit.org/changeset/229726 "Rebaseline three webarchive tests for WK2 after r229726." https://bugs.webkit.org/show_bug.cgi?id=180568 https://trac.webkit.org/changeset/229763 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-main-frame-expected.txt trunk/LayoutTests/platform/ios/http/tests/loading/simple-subframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt trunk/LayoutTests/platform/wk2/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm Added Paths trunk/LayoutTests/platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt Removed Paths trunk/LayoutTests/platform/mac-wk2/http/tests/loading/ trunk/LayoutTests/platform/wk2/fast/ trunk/LayoutTests/platform/wk2/http/tests/contentdispositionattachmentsandbox/ trunk/LayoutTests/platform/wk2/http/tests/contentextensions/ trunk/LayoutTests/platform/wk2/http/tests/loading/bad-server-subframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/loading/redirect-with-no-location-crash-expected.txt trunk/LayoutTests/platform/wk2/http/tests/loading/server-redirect-for-provisional-load-caching-expected.txt trunk/LayoutTests/platform/wk2/http/tests/loading/slow-parsing-subframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt trunk/LayoutTests/platform/wk2/http/tests/misc/window-dot-stop-expected.txt trunk/LayoutTests/platform/wk2/http/tests/navigation/ trunk/LayoutTests/platform/wk2/http/tests/security/XFrameOptions/ trunk/LayoutTests/platform/wk2/http/tests/security/blocked-on-redirect-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/contentSecurityPolicy/ trunk/LayoutTests/platform/wk2/http/tests/security/http-0.9/ trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/about-blank-iframe-in-main-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/data-url-script-in-iframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/empty-url-plugin-in-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-css-with-secure-cookies-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-form-in-iframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-form-in-main-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/_javascript_-url-form-in-main-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-block-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt trunk/LayoutTests/platform/wk2/http/tests/security/xssAuditor/ trunk/LayoutTests/platform/wk2/inspector/page/frameSched
[webkit-changes] [229765] tags/Safari-606.1.7.2/Source
Title: [229765] tags/Safari-606.1.7.2/Source Revision 229765 Author jmarc...@apple.com Date 2018-03-20 10:10:16 -0700 (Tue, 20 Mar 2018) Log Message Versioning. Modified Paths tags/Safari-606.1.7.2/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-606.1.7.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-606.1.7.2/Source/WebCore/Configurations/Version.xcconfig tags/Safari-606.1.7.2/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-606.1.7.2/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-606.1.7.2/Source/WebKit/Configurations/Version.xcconfig tags/Safari-606.1.7.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-606.1.7.2/Source/_javascript_Core/Configurations/Version.xcconfig (229764 => 229765) --- tags/Safari-606.1.7.2/Source/_javascript_Core/Configurations/Version.xcconfig 2018-03-20 17:08:05 UTC (rev 229764) +++ tags/Safari-606.1.7.2/Source/_javascript_Core/Configurations/Version.xcconfig 2018-03-20 17:10:16 UTC (rev 229765) @@ -24,7 +24,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-606.1.7.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (229764 => 229765) --- tags/Safari-606.1.7.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-03-20 17:08:05 UTC (rev 229764) +++ tags/Safari-606.1.7.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-03-20 17:10:16 UTC (rev 229765) @@ -24,7 +24,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-606.1.7.2/Source/WebCore/Configurations/Version.xcconfig (229764 => 229765) --- tags/Safari-606.1.7.2/Source/WebCore/Configurations/Version.xcconfig 2018-03-20 17:08:05 UTC (rev 229764) +++ tags/Safari-606.1.7.2/Source/WebCore/Configurations/Version.xcconfig 2018-03-20 17:10:16 UTC (rev 229765) @@ -24,7 +24,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-606.1.7.2/Source/WebCore/PAL/Configurations/Version.xcconfig (229764 => 229765) --- tags/Safari-606.1.7.2/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-03-20 17:08:05 UTC (rev 229764) +++ tags/Safari-606.1.7.2/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-03-20 17:10:16 UTC (rev 229765) @@ -24,7 +24,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-606.1.7.2/Source/WebInspectorUI/Configurations/Version.xcconfig (229764 => 229765) --- tags/Safari-606.1.7.2/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-03-20 17:08:05 UTC (rev 229764) +++ tags/Safari-606.1.7.2/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-03-20 17:10:16 UTC (rev 229765) @@ -1,7 +1,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-606.1.7.2/Source/WebKit/Configurations/Version.xcconfig (229764 => 229765) --- tags/Safari-606.1.7.2/Source/WebKit/Configurations/Version.xcconfig 2018-03-20 17:08:05 UTC (rev 229764) +++ tags/Safari-606.1.7.2/Source/WebKit/Configurations/Version.xcconfig 2018-03-20 17:10:16 UTC (rev 229765) @@ -24,7 +24,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: tags/Safari-606.1.7.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (229764 => 229765) --- tags/Safari-606.1.7.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-03-20 17:08:05 UTC (rev 229764) +++ tags/Safari-606.1.7.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-03-20 17:10:16 UTC (rev 229765) @@ -24,7 +24,7 @@ MAJOR_VERSION = 606; MINOR_VERSION = 1; TINY_VERSION = 7; -MICRO_VERSION = 1; +MICRO_VERSION = 2; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229763] trunk/LayoutTests
Title: [229763] trunk/LayoutTests Revision 229763 Author ryanhad...@apple.com Date 2018-03-20 09:52:00 -0700 (Tue, 20 Mar 2018) Log Message Rebaseline three webarchive tests for WK2 after r229726. https://bugs.webkit.org/show_bug.cgi?id=180568 Unreviewed test gardening. * platform/wk2/webarchive/loading/missing-data-expected.txt: Added. * platform/wk2/webarchive/loading/object-expected.txt: Added. * platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/wk2/webarchive/loading/missing-data-expected.txt trunk/LayoutTests/platform/wk2/webarchive/loading/object-expected.txt trunk/LayoutTests/platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (229762 => 229763) --- trunk/LayoutTests/ChangeLog 2018-03-20 16:25:32 UTC (rev 229762) +++ trunk/LayoutTests/ChangeLog 2018-03-20 16:52:00 UTC (rev 229763) @@ -1,5 +1,16 @@ 2018-03-20 Ryan Haddad +Rebaseline three webarchive tests for WK2 after r229726. +https://bugs.webkit.org/show_bug.cgi?id=180568 + +Unreviewed test gardening. + +* platform/wk2/webarchive/loading/missing-data-expected.txt: Added. +* platform/wk2/webarchive/loading/object-expected.txt: Added. +* platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt: Added. + +2018-03-20 Ryan Haddad + Rebaseline three forms tests after r229730. Unreviewed test gardening. Added: trunk/LayoutTests/platform/wk2/webarchive/loading/missing-data-expected.txt (0 => 229763) --- trunk/LayoutTests/platform/wk2/webarchive/loading/missing-data-expected.txt (rev 0) +++ trunk/LayoutTests/platform/wk2/webarchive/loading/missing-data-expected.txt 2018-03-20 16:52:00 UTC (rev 229763) @@ -0,0 +1,11 @@ +main frame - didStartProvisionalLoadForFrame +main frame - didCommitLoadForFrame +main frame - didFinishDocumentLoadForFrame +main frame - didHandleOnloadEventsForFrame +frame "-->" - didStartProvisionalLoadForFrame +frame "-->" - didCommitLoadForFrame +frame "-->" - didFinishDocumentLoadForFrame +frame "-->" - didHandleOnloadEventsForFrame +frame "-->" - didFinishLoadForFrame +main frame - didFinishLoadForFrame + Added: trunk/LayoutTests/platform/wk2/webarchive/loading/object-expected.txt (0 => 229763) --- trunk/LayoutTests/platform/wk2/webarchive/loading/object-expected.txt (rev 0) +++ trunk/LayoutTests/platform/wk2/webarchive/loading/object-expected.txt 2018-03-20 16:52:00 UTC (rev 229763) @@ -0,0 +1,18 @@ +main frame - didStartProvisionalLoadForFrame +main frame - didCommitLoadForFrame +main frame - willPerformClientRedirectToURL: resources/object.webarchive +main frame - didFinishDocumentLoadForFrame +main frame - didFinishLoadForFrame +main frame - didStartProvisionalLoadForFrame +main frame - didCancelClientRedirectForFrame +main frame - didCommitLoadForFrame +main frame - didFinishDocumentLoadForFrame +frame "-->" - didStartProvisionalLoadForFrame +frame "-->" - didCommitLoadForFrame +frame "-->" - didFinishDocumentLoadForFrame +frame "-->" - didHandleOnloadEventsForFrame +main frame - didHandleOnloadEventsForFrame +frame "-->" - didFinishLoadForFrame +main frame - didFinishLoadForFrame +Loading this webarchive with an object should not crash. + Added: trunk/LayoutTests/platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt (0 => 229763) --- trunk/LayoutTests/platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt (rev 0) +++ trunk/LayoutTests/platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt 2018-03-20 16:52:00 UTC (rev 229763) @@ -0,0 +1,18 @@ +main frame - didStartProvisionalLoadForFrame +main frame - didCommitLoadForFrame +main frame - didFinishDocumentLoadForFrame +test-loading-archive-subresource-null-mimetype.html - didFinishLoading +frame "-->" - didStartProvisionalLoadForFrame +resources/subresource-null-mimetype.webarchive - willSendRequest redirectResponse (null) +resources/subresource-null-mimetype.webarchive - didReceiveResponse +frame "-->" - didCommitLoadForFrame +test.png - willSendRequest redirectResponse (null) +frame "-->" - didFinishDocumentLoadForFrame +resources/subresource-null-mimetype.webarchive - didFinishLoading +test.png - didReceiveResponse +test.png - didFinishLoading +frame "-->" - didHandleOnloadEventsForFrame +main frame - didHandleOnloadEventsForFrame +frame "-->" - didFinishLoadForFrame +main frame - didFinishLoadForFrame + This tests that doing a normal load of a webarchive with a null mimetype for a subresource does not crash. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webk
[webkit-changes] [229761] trunk/LayoutTests
Title: [229761] trunk/LayoutTests
Revision 229761
Author ryanhad...@apple.com
Date 2018-03-20 09:25:30 -0700 (Tue, 20 Mar 2018)
Log Message
Rebaseline a test after the case of the 'Strong Password' localized string was changed in r229724.
Unreviewed test gardening.
* platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
* platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (229760 => 229761)
--- trunk/LayoutTests/ChangeLog 2018-03-20 16:25:27 UTC (rev 229760)
+++ trunk/LayoutTests/ChangeLog 2018-03-20 16:25:30 UTC (rev 229761)
@@ -1,5 +1,14 @@
2018-03-20 Ryan Haddad
+Rebaseline a test after the case of the 'Strong Password' localized string was changed in r229724.
+
+Unreviewed test gardening.
+
+* platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
+* platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
+
+2018-03-20 Ryan Haddad
+
Skip http/tests/storageAccess/grant-storage-access-under-opener.html on iOS debug.
https://bugs.webkit.org/show_bug.cgi?id=183714
Modified: trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt (229760 => 229761)
--- trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt 2018-03-20 16:25:27 UTC (rev 229760)
+++ trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt 2018-03-20 16:25:30 UTC (rev 229761)
@@ -9,45 +9,45 @@
RenderBlock {DIV} at (0,36) size 784x46
RenderTextControl {INPUT} at (2,2) size 153x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
RenderFlexibleBox {DIV} at (6,2) size 141x15
-RenderBlock {DIV} at (0,1) size 47x12
-RenderBlock {DIV} at (46,0) size 94x14
- RenderText {#text} at (6,0) size 88x14
-text run at (6,0) width 88: "strong password"
+RenderBlock {DIV} at (0,1) size 46x12
+RenderBlock {DIV} at (45,0) size 95x14
+ RenderText {#text} at (6,0) size 89x14
+text run at (6,0) width 89: "Strong Password"
RenderText {#text} at (157,0) size 4x19
text run at (157,0) width 4: " "
RenderTextControl {INPUT} at (163,2) size 153x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
RenderFlexibleBox {DIV} at (6,2) size 141x15
-RenderBlock {DIV} at (0,1) size 47x12
-RenderBlock {DIV} at (46,0) size 94x14
- RenderText {#text} at (6,0) size 88x14
-text run at (6,0) width 88: "strong password"
+RenderBlock {DIV} at (0,1) size 46x12
+RenderBlock {DIV} at (45,0) size 95x14
+ RenderText {#text} at (6,0) size 89x14
+text run at (6,0) width 89: "Strong Password"
RenderText {#text} at (318,0) size 4x19
text run at (318,0) width 4: " "
RenderTextControl {INPUT} at (322,2) size 313x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
RenderFlexibleBox {DIV} at (6,2) size 301x15
-RenderBlock {DIV} at (0,1) size 207x12
-RenderBlock {DIV} at (206,0) size 94x14
- RenderText {#text} at (6,0) size 88x14
-text run at (6,0) width 88: "strong password"
+RenderBlock {DIV} at (0,1) size 206x12
+RenderBlock {DIV} at (205,0) size 95x14
+ RenderText {#text} at (6,0) size 89x14
+text run at (6,0) width 89: "Strong Password"
RenderText {#text} at (635,0) size 4x19
text run at (635,0) width 4: " "
RenderTextControl {INPUT} at (2,25) size 153x20 [bgcolor=#FAFFBD] [border: (1px solid #4C4C4C)]
RenderFlexibleBox {DIV} at (6,2) size 141x15
-RenderBlock {DIV} at (0,1) size 47x12
-RenderBlock {DIV} at (46,0) size 94x14
- RenderText {#text} at (6,0) size 88x14
-text run at (6,0) width 88: "strong password"
-layer at (17,57) size 47x12 backgroundClip at (17,57) size 46x12 clip at (17,57) size 46x12 scrollWidth 284
- RenderBlock {DIV} at (0,0) size 47x12 [color=#0099]
+RenderBlock {DIV} at (0,1) size 46x12
+RenderBlock {DIV} at (45,0) size 95x14
+ RenderText {#text} at (6,0) size 89x14
+text run at (6,0) width 89: "Strong Password"
+layer at (17,57) size 46x12 backgroundClip at (17,57) size 45x12 clip at (17,57) size 45x12 scrollWidt
[webkit-changes] [229760] trunk/LayoutTests
Title: [229760] trunk/LayoutTests Revision 229760 Author ryanhad...@apple.com Date 2018-03-20 09:25:27 -0700 (Tue, 20 Mar 2018) Log Message Skip http/tests/storageAccess/grant-storage-access-under-opener.html on iOS debug. https://bugs.webkit.org/show_bug.cgi?id=183714 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (229759 => 229760) --- trunk/LayoutTests/ChangeLog 2018-03-20 16:18:56 UTC (rev 229759) +++ trunk/LayoutTests/ChangeLog 2018-03-20 16:25:27 UTC (rev 229760) @@ -1,3 +1,12 @@ +2018-03-20 Ryan Haddad + +Skip http/tests/storageAccess/grant-storage-access-under-opener.html on iOS debug. +https://bugs.webkit.org/show_bug.cgi?id=183714 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2018-03-19 Brady Eidson Add a layout test verifying AppCache resource fetches have the document's cookie in place. Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (229759 => 229760) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2018-03-20 16:18:56 UTC (rev 229759) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2018-03-20 16:25:27 UTC (rev 229760) @@ -1318,3 +1318,5 @@ webkit.org/b/182144 [ Debug ] webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Skip ] webkit.org/b/182849 imported/w3c/web-platform-tests/XMLHttpRequest/event-upload-progress-crossorigin.htm [ Pass Failure ] + +webkit.org/b/183714 [ Debug ] http/tests/storageAccess/grant-storage-access-under-opener.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229762] trunk/LayoutTests
Title: [229762] trunk/LayoutTests
Revision 229762
Author ryanhad...@apple.com
Date 2018-03-20 09:25:32 -0700 (Tue, 20 Mar 2018)
Log Message
Rebaseline three forms tests after r229730.
Unreviewed test gardening.
* platform/mac/fast/forms/basic-selects-expected.txt:
* platform/mac/fast/forms/disabled-select-change-index-expected.txt:
* platform/mac/fast/forms/select-disabled-appearance-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (229761 => 229762)
--- trunk/LayoutTests/ChangeLog 2018-03-20 16:25:30 UTC (rev 229761)
+++ trunk/LayoutTests/ChangeLog 2018-03-20 16:25:32 UTC (rev 229762)
@@ -1,5 +1,15 @@
2018-03-20 Ryan Haddad
+Rebaseline three forms tests after r229730.
+
+Unreviewed test gardening.
+
+* platform/mac/fast/forms/basic-selects-expected.txt:
+* platform/mac/fast/forms/disabled-select-change-index-expected.txt:
+* platform/mac/fast/forms/select-disabled-appearance-expected.txt:
+
+2018-03-20 Ryan Haddad
+
Rebaseline a test after the case of the 'Strong Password' localized string was changed in r229724.
Unreviewed test gardening.
Modified: trunk/LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt (229761 => 229762)
--- trunk/LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt 2018-03-20 16:25:30 UTC (rev 229761)
+++ trunk/LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt 2018-03-20 16:25:32 UTC (rev 229762)
@@ -28,7 +28,7 @@
text run at (8,2) width 17: "foo"
RenderText {#text} at (193,40) size 8x18
text run at (193,40) width 8: "a"
-RenderMenuList {SELECT} at (202,41) size 50x18 [color=#808080] [bgcolor=#FF]
+RenderMenuList {SELECT} at (202,41) size 50x18 [color=#7F7F7F] [bgcolor=#FF]
RenderBlock (anonymous) at (0,0) size 49x18
RenderText at (8,2) size 17x13
text run at (8,2) width 17: "foo"
@@ -44,7 +44,7 @@
text run at (8,2) width 17: "foo"
RenderText {#text} at (250,78) size 8x18
text run at (250,78) width 8: "a"
-RenderMenuList {SELECT} at (259,79) size 50x18 [color=#808080] [bgcolor=#FF]
+RenderMenuList {SELECT} at (259,79) size 50x18 [color=#7F7F7F] [bgcolor=#FF]
RenderBlock (anonymous) at (0,0) size 49x18
RenderText at (8,2) size 18x13
text run at (8,2) width 18: "bar"
@@ -60,7 +60,7 @@
text run at (8,2) width 17: "foo"
RenderText {#text} at (494,116) size 8x18
text run at (494,116) width 8: "a"
-RenderMenuList {SELECT} at (503,117) size 49x18 [color=#808080] [bgcolor=#FF]
+RenderMenuList {SELECT} at (503,117) size 49x18 [color=#7F7F7F] [bgcolor=#FF]
RenderBlock (anonymous) at (0,0) size 48x18
RenderText at (8,2) size 17x13
text run at (8,2) width 17: "foo"
@@ -108,7 +108,7 @@
text run at (8,2) width 17: "foo"
RenderText {#text} at (543,248) size 8x18
text run at (543,248) width 8: "a"
-RenderMenuList {SELECT} at (552,249) size 49x18 [color=#808080] [bgcolor=#FF]
+RenderMenuList {SELECT} at (552,249) size 49x18 [color=#7F7F7F] [bgcolor=#FF]
RenderBlock (anonymous) at (0,0) size 48x18
RenderText at (8,2) size 17x13
text run at (8,2) width 17: "foo"
Modified: trunk/LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt (229761 => 229762)
--- trunk/LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt 2018-03-20 16:25:30 UTC (rev 229761)
+++ trunk/LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt 2018-03-20 16:25:32 UTC (rev 229762)
@@ -3,12 +3,12 @@
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
- RenderMenuList {SELECT} at (2,2) size 60x18 [color=#808080] [bgcolor=#FF]
+ RenderMenuList {SELECT} at (2,2) size 60x18 [color=#7F7F7F] [bgcolor=#FF]
RenderBlock (anonymous) at (0,0) size 60x18
RenderText at (8,2) size 29x13
text run at (8,2) width 29: "PASS"
RenderBR {BR} at (64,15) size 0x0
- RenderMenuList {SELECT} at (2,24) size 60x18 [color=#808080] [bgcolor=#FF]
+ RenderMenuList {SELECT} at (2,24) size 60x18 [color=#7F7F7F] [bgcolor=#FF]
RenderBlock (anonymous) at (0,0) size 60x18
RenderText at (8,2) size 29x13
text run at (8,2) width 29: "PASS"
Modified: trunk/LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.txt (229761 =>
[webkit-changes] [229759] tags/Safari-606.1.7.2/
Title: [229759] tags/Safari-606.1.7.2/ Revision 229759 Author jmarc...@apple.com Date 2018-03-20 09:18:56 -0700 (Tue, 20 Mar 2018) Log Message New tag. Added Paths tags/Safari-606.1.7.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229758] trunk/Tools
Title: [229758] trunk/Tools Revision 229758 Author za...@apple.com Date 2018-03-20 09:14:28 -0700 (Tue, 20 Mar 2018) Log Message [LayoutReloaded] Move Display.Box handling from FormattingContext to FormattingState https://bugs.webkit.org/show_bug.cgi?id=183779 Reviewed by Antti Koivisto. * LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js: (BlockFormattingContext.prototype._computeStaticPosition): (BlockFormattingContext.prototype._computeOutOfFlowWidth): (BlockFormattingContext.prototype._computeFloatingWidth): (BlockFormattingContext.prototype._computeInFlowWidth): (BlockFormattingContext.prototype._computeOutOfFlowHeight): (BlockFormattingContext.prototype._computeFloatingHeight): (BlockFormattingContext.prototype._computeInFlowHeight): (BlockFormattingContext.prototype._horizontalConstraint): (BlockFormattingContext.prototype._contentHeight): (BlockFormattingContext.prototype._adjustBottomWithFIXME): (BlockFormattingContext.prototype._computeInFlowPositionedPosition): (BlockFormattingContext.prototype._computeOutOfFlowPosition): * LayoutReloaded/FormattingContext/FloatingContext.js: (FloatingContext.prototype.computePosition): (FloatingContext.prototype._positionForClear): (FloatingContext.prototype._computePositionToAvoidIntrudingFloats): (FloatingContext.prototype._availableSpace): (FloatingContext.prototype._adjustedFloatingPosition): * LayoutReloaded/FormattingContext/FormattingContext.js: (FormattingContext): (FormattingContext.prototype.absoluteMarginBox): (FormattingContext.prototype.absoluteBorderBox): (FormattingContext.prototype.absolutePaddingBox): (FormattingContext.prototype.absoluteContentBox): (FormattingContext.prototype._toAbsolutePosition): (FormattingContext.prototype._toRootAbsolutePosition): (FormattingContext.prototype._addToLayoutQueue): (FormattingContext.prototype.displayBox): (FormattingContext.prototype._createDisplayBox): Deleted. (FormattingContext.prototype.toDisplayBox): Deleted. (FormattingContext.prototype.toLayoutBox): Deleted. * LayoutReloaded/FormattingState/FormattingState.js: (FormattingState): (FormattingState.prototype.createDisplayBox): (FormattingState.prototype.displayBox): Modified Paths trunk/Tools/ChangeLog trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js trunk/Tools/LayoutReloaded/FormattingContext/FloatingContext.js trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js Diff Modified: trunk/Tools/ChangeLog (229757 => 229758) --- trunk/Tools/ChangeLog 2018-03-20 15:34:30 UTC (rev 229757) +++ trunk/Tools/ChangeLog 2018-03-20 16:14:28 UTC (rev 229758) @@ -1,5 +1,49 @@ 2018-03-20 Zalan Bujtas +[LayoutReloaded] Move Display.Box handling from FormattingContext to FormattingState +https://bugs.webkit.org/show_bug.cgi?id=183779 + +Reviewed by Antti Koivisto. + +* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js: +(BlockFormattingContext.prototype._computeStaticPosition): +(BlockFormattingContext.prototype._computeOutOfFlowWidth): +(BlockFormattingContext.prototype._computeFloatingWidth): +(BlockFormattingContext.prototype._computeInFlowWidth): +(BlockFormattingContext.prototype._computeOutOfFlowHeight): +(BlockFormattingContext.prototype._computeFloatingHeight): +(BlockFormattingContext.prototype._computeInFlowHeight): +(BlockFormattingContext.prototype._horizontalConstraint): +(BlockFormattingContext.prototype._contentHeight): +(BlockFormattingContext.prototype._adjustBottomWithFIXME): +(BlockFormattingContext.prototype._computeInFlowPositionedPosition): +(BlockFormattingContext.prototype._computeOutOfFlowPosition): +* LayoutReloaded/FormattingContext/FloatingContext.js: +(FloatingContext.prototype.computePosition): +(FloatingContext.prototype._positionForClear): +(FloatingContext.prototype._computePositionToAvoidIntrudingFloats): +(FloatingContext.prototype._availableSpace): +(FloatingContext.prototype._adjustedFloatingPosition): +* LayoutReloaded/FormattingContext/FormattingContext.js: +(FormattingContext): +(FormattingContext.prototype.absoluteMarginBox): +(FormattingContext.prototype.absoluteBorderBox): +(FormattingContext.prototype.absolutePaddingBox): +(FormattingContext.prototype.absoluteContentBox): +(FormattingContext.prototype._toAbsolutePosition): +(FormattingContext.prototype._toRootAbsolutePosition): +(FormattingContext.prototype._addToLayoutQueue): +(FormattingContext.prototype.displayBox): +(FormattingContext.prototype._createDisplayBox): Deleted. +(FormattingContext.prototype.toDisplayBox): Deleted. +(FormattingContext.prototype.toLayoutBox): Deleted. +* LayoutReloaded/Formatting
[webkit-changes] [229757] trunk/Source/WebKit
Title: [229757] trunk/Source/WebKit Revision 229757 Author bfulg...@apple.com Date 2018-03-20 08:34:30 -0700 (Tue, 20 Mar 2018) Log Message [iOS] Grant IOKit preference access for the Home button https://bugs.webkit.org/show_bug.cgi?id=183754 Reviewed by Eric Carlson. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Diff Modified: trunk/Source/WebKit/ChangeLog (229756 => 229757) --- trunk/Source/WebKit/ChangeLog 2018-03-20 15:21:32 UTC (rev 229756) +++ trunk/Source/WebKit/ChangeLog 2018-03-20 15:34:30 UTC (rev 229757) @@ -1,3 +1,13 @@ +2018-03-20 Brent Fulgham + +[iOS] Grant IOKit preference access for the Home button +https://bugs.webkit.org/show_bug.cgi?id=183754 + + +Reviewed by Eric Carlson. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: + 2018-03-20 Wenson Hsieh [Extra zoom mode] Adopt updated input view controller machinery for text input Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (229756 => 229757) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2018-03-20 15:21:32 UTC (rev 229756) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2018-03-20 15:34:30 UTC (rev 229757) @@ -194,6 +194,11 @@ (allow iokit-get-properties (iokit-property "client"))) +;; Home Button +(with-filter (iokit-registry-entry-class "IOPlatformDevice") +(allow iokit-get-properties +(iokit-property "home-button-type"))) + ;; Common preferences read by UIKit. (mobile-preferences-read "com.apple.Accessibility" "com.apple.UIKit" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229752] branches/safari-605-branch
Title: [229752] branches/safari-605-branch
Revision 229752
Author jmarc...@apple.com
Date 2018-03-20 08:21:19 -0700 (Tue, 20 Mar 2018)
Log Message
Cherry-pick r229614. rdar://problem/38651603
Modified Paths
branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/dom/MessagePort.cpp
Added Paths
branches/safari-605-branch/LayoutTests/http/tests/workers/resources/messageport-echo-worker.js
branches/safari-605-branch/LayoutTests/http/tests/workers/worker-messageport-expected.txt
branches/safari-605-branch/LayoutTests/http/tests/workers/worker-messageport.html
Diff
Modified: branches/safari-605-branch/LayoutTests/ChangeLog (229751 => 229752)
--- branches/safari-605-branch/LayoutTests/ChangeLog 2018-03-20 15:21:15 UTC (rev 229751)
+++ branches/safari-605-branch/LayoutTests/ChangeLog 2018-03-20 15:21:19 UTC (rev 229752)
@@ -1,5 +1,20 @@
2018-03-20 Jason Marcell
+Cherry-pick r229614. rdar://problem/38651603
+
+2018-03-14 Youenn Fablet
+
+MessagePort should remove its listeners when being closed
+https://bugs.webkit.org/show_bug.cgi?id=183644
+
+Reviewed by Chris Dumez.
+
+* http/tests/workers/resources/messageport-echo-worker.js: Added.
+* http/tests/workers/worker-messageport-expected.txt: Added.
+* http/tests/workers/worker-messageport.html: Added.
+
+2018-03-20 Jason Marcell
+
Cherry-pick r229505. rdar://problem/38651624
2018-03-09 Zalan Bujtas
Added: branches/safari-605-branch/LayoutTests/http/tests/workers/resources/messageport-echo-worker.js (0 => 229752)
--- branches/safari-605-branch/LayoutTests/http/tests/workers/resources/messageport-echo-worker.js (rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/workers/resources/messageport-echo-worker.js 2018-03-20 15:21:19 UTC (rev 229752)
@@ -0,0 +1,13 @@
+self.addEventListener("message", (event) => {
+if (!event.ports || !event.ports.length) {
+self.postMessage("FAIL: Message did not have a MessagePort");
+return;
+}
+event.ports[0]._onmessage_ = echoBack;
+event.ports[0].start();
+self.postMessage("ready");
+});
+
+function echoBack(event) {
+self.postMessage("MessagePort echo: " + event.data);
+}
Added: branches/safari-605-branch/LayoutTests/http/tests/workers/worker-messageport-expected.txt (0 => 229752)
--- branches/safari-605-branch/LayoutTests/http/tests/workers/worker-messageport-expected.txt (rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/workers/worker-messageport-expected.txt 2018-03-20 15:21:19 UTC (rev 229752)
@@ -0,0 +1 @@
+PASS
Added: branches/safari-605-branch/LayoutTests/http/tests/workers/worker-messageport.html (0 => 229752)
--- branches/safari-605-branch/LayoutTests/http/tests/workers/worker-messageport.html (rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/workers/worker-messageport.html 2018-03-20 15:21:19 UTC (rev 229752)
@@ -0,0 +1,32 @@
+
+
+Test postMessage and garbage collection.
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+var worker = new Worker('resources/messageport-echo-worker.js');
+
+worker._onmessage_ = (event) => {
+if (event.data ="" "ready") {
+worker.terminate();
+setTimeout(() => {
+document.body.innerHTML = "PASS";
+if (window.testRunner)
+testRunner.notifyDone();
+}, 0);
+}
+}
+
+var channel = new MessageChannel();
+channel.port1._onmessage_ = function(event) {
+}
+
+worker.postMessage("Here is your port", [channel.port2]);
+
+
+
+
Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (229751 => 229752)
--- branches/safari-605-branch/Source/WebCore/ChangeLog 2018-03-20 15:21:15 UTC (rev 229751)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog 2018-03-20 15:21:19 UTC (rev 229752)
@@ -1,5 +1,22 @@
2018-03-20 Jason Marcell
+Cherry-pick r229614. rdar://problem/38651603
+
+2018-03-14 Youenn Fablet
+
+MessagePort should remove its listeners when being closed
+https://bugs.webkit.org/show_bug.cgi?id=183644
+
+Reviewed by Chris Dumez.
+
+Test: http/tests/workers/worker-messageport.html
+
+* dom/MessagePort.cpp:
+(WebCore::MessagePort::close):
+(WebCore::MessagePort::contextDestroyed):
+
+2018-03-20 Jason Marcell
+
Cherry-pick r229505. rdar://problem/38651624
2018-03-09 Zalan Bujtas
Modified: branches/safari-605-branch/Source/WebCore/dom/MessagePort.cpp (229751 => 229752)
--- branches/safari-605-branch/Source/WebCore/dom/MessagePort.cpp 2018-03-20 15:21:15 UTC (rev 229751)
+++ branches/safari-605-branch/Source/WebCore/dom/MessagePort.cpp 2018-03-20 15:21:19 UTC (rev 229752)
@@ -217,12 +217
[webkit-changes] [229755] branches/safari-605-branch/LayoutTests
Title: [229755] branches/safari-605-branch/LayoutTests
Revision 229755
Author jmarc...@apple.com
Date 2018-03-20 08:21:29 -0700 (Tue, 20 Mar 2018)
Log Message
Cherry-pick r229733. rdar://problem/38651613
Modified Paths
branches/safari-605-branch/LayoutTests/ChangeLog
Added Paths
branches/safari-605-branch/LayoutTests/http/tests/appcache/document-cookie-expected.txt
branches/safari-605-branch/LayoutTests/http/tests/appcache/document-cookie.php
branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/cookie-protected-script.php
branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/document-cookie.manifest
Diff
Modified: branches/safari-605-branch/LayoutTests/ChangeLog (229754 => 229755)
--- branches/safari-605-branch/LayoutTests/ChangeLog 2018-03-20 15:21:26 UTC (rev 229754)
+++ branches/safari-605-branch/LayoutTests/ChangeLog 2018-03-20 15:21:29 UTC (rev 229755)
@@ -1,5 +1,21 @@
2018-03-20 Jason Marcell
+Cherry-pick r229733. rdar://problem/38651613
+
+2018-03-19 Brady Eidson
+
+Add a layout test verifying AppCache resource fetches have the document's cookie in place.
+https://bugs.webkit.org/show_bug.cgi?id=183757
+
+Reviewed by Alex Christensen.
+
+* http/tests/appcache/document-cookie-expected.txt: Added.
+* http/tests/appcache/document-cookie.php: Added.
+* http/tests/appcache/resources/cookie-protected-script.php: Added.
+* http/tests/appcache/resources/document-cookie.manifest: Added.
+
+2018-03-20 Jason Marcell
+
Cherry-pick r229691. rdar://problem/38651615
2018-03-16 Youenn Fablet
Added: branches/safari-605-branch/LayoutTests/http/tests/appcache/document-cookie-expected.txt (0 => 229755)
--- branches/safari-605-branch/LayoutTests/http/tests/appcache/document-cookie-expected.txt (rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/appcache/document-cookie-expected.txt 2018-03-20 15:21:29 UTC (rev 229755)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead.
+This tests that cookies set on the main document are used when accessing resources in the manifest.
+PASSED: Cookie is set to 'bar'
Added: branches/safari-605-branch/LayoutTests/http/tests/appcache/document-cookie.php (0 => 229755)
--- branches/safari-605-branch/LayoutTests/http/tests/appcache/document-cookie.php (rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/appcache/document-cookie.php 2018-03-20 15:21:29 UTC (rev 229755)
@@ -0,0 +1,28 @@
+
+
+
+This tests that cookies set on the main document are used when accessing resources in the manifest.
+Not run yet
+
+if (window.testRunner) {
+testRunner.dumpAsText()
+testRunner.waitUntilDone();
+}
+
+function dynamicScriptLoad() {
+ var script = document.createElement("script");
+ script.type = "text/_javascript_";
+ script.src = ""
+ document.getElementsByTagName("head")[0].appendChild(script);
+}
+
+function cached()
+{
+ setTimeout("dynamicScriptLoad();", 0);
+}
+
+applicationCache.addEventListener('cached', cached, false);
+
+
Added: branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/cookie-protected-script.php (0 => 229755)
--- branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/cookie-protected-script.php (rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/cookie-protected-script.php 2018-03-20 15:21:29 UTC (rev 229755)
@@ -0,0 +1,18 @@
+';";
+}
+
+?>
+
+if (cookieVal == "bar")
+ document.getElementById("result").innerHTML = "PASSED: Cookie is set to 'bar'";
+else
+ document.getElementById("result").innerHTML = "FAILED: Cookie should be 'bar', is set to '" + cookieVal + "'";
+
+if (window.testRunner)
+ testRunner.notifyDone();
Added: branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/document-cookie.manifest (0 => 229755)
--- branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/document-cookie.manifest (rev 0)
+++ branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/document-cookie.manifest 2018-03-20 15:21:29 UTC (rev 229755)
@@ -0,0 +1,4 @@
+CACHE MANIFEST
+/appcache/resources/cookie-protected-script.php
+NETWORK:
+/favicon.ico
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229753] branches/safari-605-branch/Source
Title: [229753] branches/safari-605-branch/Source
Revision 229753
Author jmarc...@apple.com
Date 2018-03-20 08:21:22 -0700 (Tue, 20 Mar 2018)
Log Message
Cherry-pick r229643. rdar://problem/38651639
Modified Paths
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/page/DiagnosticLoggingKeys.cpp
branches/safari-605-branch/Source/WebCore/page/DiagnosticLoggingKeys.h
branches/safari-605-branch/Source/WebCore/platform/network/cf/ResourceError.h
branches/safari-605-branch/Source/WebCore/platform/network/mac/ResourceErrorMac.mm
branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-605-branch/Source/WebKit/UIProcess/WebPageProxy.h
Diff
Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (229752 => 229753)
--- branches/safari-605-branch/Source/WebCore/ChangeLog 2018-03-20 15:21:19 UTC (rev 229752)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog 2018-03-20 15:21:22 UTC (rev 229753)
@@ -1,5 +1,48 @@
2018-03-20 Jason Marcell
+Cherry-pick r229643. rdar://problem/38651639
+
+2018-03-15 Keith Rollin
+
+Telemetry for stalled webpage loads
+https://bugs.webkit.org/show_bug.cgi?id=183221
+
+
+Reviewed by Chris Dumez.
+
+Add telemetry for page loads, tracking the pages that succeed, fail,
+or are canceled. This information will be used to track the overall
+health of our page loading as time goes on.
+
+No new tests -- no new/changed user-level functionality.
+
+* page/DiagnosticLoggingKeys.cpp:
+(WebCore::DiagnosticLoggingKeys::telemetryPageLoadKey):
+(WebCore::DiagnosticLoggingKeys::timedOutKey):
+(WebCore::DiagnosticLoggingKeys::canceledLessThan2SecondsKey):
+(WebCore::DiagnosticLoggingKeys::canceledLessThan5SecondsKey):
+(WebCore::DiagnosticLoggingKeys::canceledLessThan20SecondsKey):
+(WebCore::DiagnosticLoggingKeys::canceledMoreThan20SecondsKey):
+(WebCore::DiagnosticLoggingKeys::failedLessThan2SecondsKey):
+(WebCore::DiagnosticLoggingKeys::failedLessThan5SecondsKey):
+(WebCore::DiagnosticLoggingKeys::failedLessThan20SecondsKey):
+(WebCore::DiagnosticLoggingKeys::failedMoreThan20SecondsKey):
+(WebCore::DiagnosticLoggingKeys::occurredKey):
+(WebCore::DiagnosticLoggingKeys::succeededLessThan2SecondsKey):
+(WebCore::DiagnosticLoggingKeys::succeededLessThan5SecondsKey):
+(WebCore::DiagnosticLoggingKeys::succeededLessThan20SecondsKey):
+(WebCore::DiagnosticLoggingKeys::succeededMoreThan20SecondsKey):
+* page/DiagnosticLoggingKeys.h:
+* platform/network/cf/ResourceError.h:
+(WebCore::ResourceError::ResourceError):
+* platform/network/mac/ResourceErrorMac.mm:
+(WebCore::ResourceError::ResourceError):
+(WebCore::ResourceError::getNSURLErrorDomain const):
+(WebCore::ResourceError::getCFErrorDomainCFNetwork const):
+(WebCore::ResourceError::mapPlatformError):
+
+2018-03-20 Jason Marcell
+
Cherry-pick r229614. rdar://problem/38651603
2018-03-14 Youenn Fablet
Modified: branches/safari-605-branch/Source/WebCore/page/DiagnosticLoggingKeys.cpp (229752 => 229753)
--- branches/safari-605-branch/Source/WebCore/page/DiagnosticLoggingKeys.cpp 2018-03-20 15:21:19 UTC (rev 229752)
+++ branches/safari-605-branch/Source/WebCore/page/DiagnosticLoggingKeys.cpp 2018-03-20 15:21:22 UTC (rev 229753)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2018 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -565,6 +565,81 @@
return ASCIILiteral("synchronousMessageFailed");
}
+String DiagnosticLoggingKeys::telemetryPageLoadKey()
+{
+return ASCIILiteral("telemetryPageLoad");
+}
+
+String DiagnosticLoggingKeys::timedOutKey()
+{
+return ASCIILiteral("timedOut");
+}
+
+String DiagnosticLoggingKeys::canceledLessThan2SecondsKey()
+{
+return ASCIILiteral("canceledLessThan2Seconds");
+}
+
+String DiagnosticLoggingKeys::canceledLessThan5SecondsKey()
+{
+return ASCIILiteral("canceledLessThan5Seconds");
+}
+
+String DiagnosticLoggingKeys::canceledLessThan20SecondsKey()
+{
+return ASCIILiteral("canceledLessThan20Seconds");
+}
+
+String DiagnosticLoggingKeys::canceledMoreThan20SecondsKey()
+{
+return ASCIILiteral("canceledMoreThan20Seconds");
+}
+
+String DiagnosticLoggingKeys::failedLessThan2SecondsKey()
+{
+return ASCIILiteral("failedLessThan2Seconds");
+}
+
+String DiagnosticLoggingKeys::failedLessThan5SecondsKey()
+{
+return ASCIILiteral("failedLessThan5Seconds")
[webkit-changes] [229756] branches/safari-605-branch/Source/WebCore
Title: [229756] branches/safari-605-branch/Source/WebCore
Revision 229756
Author jmarc...@apple.com
Date 2018-03-20 08:21:32 -0700 (Tue, 20 Mar 2018)
Log Message
Apply patch. rdar://problem/38651613
Modified Paths
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
branches/safari-605-branch/Source/WebCore/loader/appcache/ApplicationCacheGroup.h
Diff
Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (229755 => 229756)
--- branches/safari-605-branch/Source/WebCore/ChangeLog 2018-03-20 15:21:29 UTC (rev 229755)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog 2018-03-20 15:21:32 UTC (rev 229756)
@@ -1,5 +1,27 @@
2018-03-20 Jason Marcell
+Apply patch. rdar://problem/38651613
+
+2018-03-20 Youenn Fablet
+
+REGRESSION (iOS 11.3): WKWebView does not send cookies for cache manifest request.
+rdar://problem/38505756.
+
+Reviewed by Brady Eidson
+
+Covered by tests added in https://bugs.webkit.org/show_bug.cgi?id=183716
+and https://bugs.webkit.org/show_bug.cgi?id=183757
+
+Get the document cookie when trying to load the cache manifest.
+Use that cookie for the cache manifest and all cached resource.
+
+* loader/appcache/ApplicationCacheGroup.cpp:
+(WebCore::ApplicationCacheGroup::update):
+(WebCore::ApplicationCacheGroup::createResourceHandle):
+* loader/appcache/ApplicationCacheGroup.h:
+
+2018-03-20 Jason Marcell
+
Cherry-pick r229643. rdar://problem/38651639
2018-03-15 Keith Rollin
Modified: branches/safari-605-branch/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp (229755 => 229756)
--- branches/safari-605-branch/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp 2018-03-20 15:21:29 UTC (rev 229755)
+++ branches/safari-605-branch/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp 2018-03-20 15:21:32 UTC (rev 229756)
@@ -442,6 +442,12 @@
ASSERT(!m_currentResource);
ASSERT(m_completionType == None);
+if (auto* document = m_frame->document()) {
+auto documentCookie = document->cookie();
+ if (!documentCookie.hasException())
+ m_cookieStringFromDocument = documentCookie.releaseReturnValue();
+}
+
// FIXME: Handle defer loading
m_manifestHandle = createResourceHandle(m_manifestURL, m_newestCache ? m_newestCache->manifestResource() : 0);
}
@@ -465,6 +471,9 @@
m_frame->loader().applyUserAgentIfNeeded(request);
request.setHTTPHeaderField(HTTPHeaderName::CacheControl, "max-age=0");
+if (!m_cookieStringFromDocument.isEmpty())
+request.setHTTPHeaderField(HTTPHeaderName::Cookie, m_cookieStringFromDocument);
+
if (newestCachedResource) {
const String& lastModified = newestCachedResource->response().httpHeaderField(HTTPHeaderName::LastModified);
const String& eTag = newestCachedResource->response().httpHeaderField(HTTPHeaderName::ETag);
Modified: branches/safari-605-branch/Source/WebCore/loader/appcache/ApplicationCacheGroup.h (229755 => 229756)
--- branches/safari-605-branch/Source/WebCore/loader/appcache/ApplicationCacheGroup.h 2018-03-20 15:21:29 UTC (rev 229755)
+++ branches/safari-605-branch/Source/WebCore/loader/appcache/ApplicationCacheGroup.h 2018-03-20 15:21:32 UTC (rev 229756)
@@ -201,6 +201,7 @@
bool m_originQuotaExceededPreviously { false };
friend class ChromeClientCallbackTimer;
+String m_cookieStringFromDocument;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [229754] branches/safari-605-branch/LayoutTests
Title: [229754] branches/safari-605-branch/LayoutTests Revision 229754 Author jmarc...@apple.com Date 2018-03-20 08:21:26 -0700 (Tue, 20 Mar 2018) Log Message Cherry-pick r229691. rdar://problem/38651615 Modified Paths branches/safari-605-branch/LayoutTests/ChangeLog Added Paths branches/safari-605-branch/LayoutTests/http/tests/appcache/appcache-cookies-expected.txt branches/safari-605-branch/LayoutTests/http/tests/appcache/appcache-cookies.html branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/appcache-cookies-test.html branches/safari-605-branch/LayoutTests/http/tests/appcache/resources/manifest-if-cookie.php Diff Modified: branches/safari-605-branch/LayoutTests/ChangeLog (229753 => 229754) --- branches/safari-605-branch/LayoutTests/ChangeLog 2018-03-20 15:21:22 UTC (rev 229753) +++ branches/safari-605-branch/LayoutTests/ChangeLog 2018-03-20 15:21:26 UTC (rev 229754) @@ -1,5 +1,21 @@ 2018-03-20 Jason Marcell +Cherry-pick r229691. rdar://problem/38651615 + +2018-03-16 Youenn Fablet + +Add a test verifying that an AppCache manifest request includes credentials +https://bugs.webkit.org/show_bug.cgi?id=183716 + +Reviewed by Chris Dumez. + +* http/tests/appcache/appcache-cookies-expected.txt: Added. +* http/tests/appcache/appcache-cookies.html: Added. +* http/tests/appcache/resources/appcache-cookies-test.html: Added. +* http/tests/appcache/resources/manifest-if-cookie.php: Added. + +2018-03-20 Jason Marcell + Cherry-pick r229614. rdar://problem/38651603 2018-03-14 Youenn Fablet Added: branches/safari-605-branch/LayoutTests/http/tests/appcache/appcache-cookies-expected.txt (0 => 229754) --- branches/safari-605-branch/LayoutTests/http/tests/appcache/appcache-cookies-expected.txt (rev 0) +++ branches/safari-605-branch/LayoutTests/http/tests/appcache/appcache-cookies-expected.txt 2018-03-20 15:21:26 UTC (rev 229754) @@ -0,0 +1,2 @@ +CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead. +PASS Added: branches/safari-605-branch/LayoutTests/http/tests/appcache/appcache-cookies.html (0 => 229754) --- branches/safari-605-branch/LayoutTests/http/tests/appcache/appcache-cookies.html (rev 0) +++ branches/safari-605-branch/LayoutTests/http/tests/appcache/appcache-cookies.html 2018-03-20 15:21:26 UTC (rev 229754) @@ -0,0 +1,19 @@ + + + + + +