[webkit-changes] [237673] branches/safari-606.3.4.2-branch/
Title: [237673] branches/safari-606.3.4.2-branch/ Revision 237673 Author bshaf...@apple.com Date 2018-10-31 21:30:38 -0700 (Wed, 31 Oct 2018) Log Message New branch. Added Paths branches/safari-606.3.4.2-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237672] branches/safari-606.3.4.1-branch/
Title: [237672] branches/safari-606.3.4.1-branch/ Revision 237672 Author bshaf...@apple.com Date 2018-10-31 21:30:22 -0700 (Wed, 31 Oct 2018) Log Message New branch. Added Paths branches/safari-606.3.4.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237671] branches/safari-606.3.4.0-branch/
Title: [237671] branches/safari-606.3.4.0-branch/ Revision 237671 Author bshaf...@apple.com Date 2018-10-31 21:18:03 -0700 (Wed, 31 Oct 2018) Log Message New branch. Added Paths branches/safari-606.3.4.0-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237670] trunk
Title: [237670] trunk Revision 237670 Author drou...@apple.com Date 2018-10-31 21:13:41 -0700 (Wed, 31 Oct 2018) Log Message Web Inspector: Canvas: create a setting for auto-recording newly created contexts https://bugs.webkit.org/show_bug.cgi?id=190856 Reviewed by Brian Burg. Source/_javascript_Core: * inspector/protocol/Canvas.json: Add `setRecordingAutoCaptureFrameCount` command for setting the number of frames to record immediately after a context is created. * inspector/protocol/Recording.json: Add `creation` value for `Initiator` enum. Source/WebCore: Test: inspector/canvas/setRecordingAutoCaptureFrameCount.html * inspector/agents/InspectorCanvasAgent.h: (WebCore::InspectorCanvasAgent::RecordingOptions): Added. * inspector/agents/InspectorCanvasAgent.cpp: (WebCore::InspectorCanvasAgent::enable): (WebCore::InspectorCanvasAgent::disable): (WebCore::InspectorCanvasAgent::setRecordingAutoCaptureFrameCount): Added. (WebCore::InspectorCanvasAgent::startRecording): (WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext): (WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame): (WebCore::InspectorCanvasAgent::consoleStartRecordingCanvas): (WebCore::InspectorCanvasAgent::startRecording): Added. Unify the different functions that are able to start a recording to use a single path. * inspector/InspectorCanvas.h: * inspector/InspectorCanvas.cpp: (WebCore::InspectorCanvas::resetRecordingData): (WebCore::InspectorCanvas::recordAction): (WebCore::InspectorCanvas::setFrameCount): Added. (WebCore::InspectorCanvas::overFrameCount const): Added. Source/WebInspectorUI: * UserInterface/Controllers/CanvasManager.js: (WI.CanvasManager.supportsRecordingAutoCapture): Added. (WI.CanvasManager.prototype.setRecordingAutoCaptureFrameCount): Added. * UserInterface/Models/Canvas.js: (WI.Canvas.prototype.startRecording): (WI.Canvas.prototype.recordingStarted): (WI.Canvas.prototype.recordingFinished): * UserInterface/Models/Recording.js: * UserInterface/Views/CanvasOverviewContentView.js: (WI.CanvasOverviewContentView): (WI.CanvasOverviewContentView.prototype.get navigationItems): (WI.CanvasOverviewContentView.prototype.initialLayout): Added. (WI.CanvasOverviewContentView.prototype.attached): (WI.CanvasOverviewContentView.prototype.detached): (WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount): Added. (WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize): Added. (WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureInput): Added. (WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureCheckedDidChange): Added. (WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureEnabledChanged): Added. (WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged): Added. * UserInterface/Views/CanvasOverviewContentView.css: (.navigation-bar > .item.canvas-recording-auto-capture > label): Added. (.navigation-bar > .item.canvas-recording-auto-capture > label > input): Added. (.navigation-bar > .item.canvas-recording-auto-capture > label > input::-webkit-inner-spin-button): Added. (.popover-content > .tree-outline .item.recording > .icon): Deleted. (.popover-content > .tree-outline .item.recording:hover): Deleted. (.popover-content > .tree-outline .item.recording:hover > .icon): Deleted. Drive-by: removed unused CSS rules. * UserInterface/Views/CanvasContentView.js: (WI.CanvasContentView.prototype.initialLayout): (WI.CanvasContentView.prototype._updateProgressView): (WI.CanvasContentView.prototype._updateViewRelatedItems): * UserInterface/Views/CanvasTabContentView.js: (WI.CanvasTabContentView.prototype._recordingImportedOrStopped): * UserInterface/Views/CheckboxNavigationItem.js: (WI.CheckboxNavigationItem): (WI.CheckboxNavigationItem.prototype._handleLabelClick): Added. * UserInterface/Base/Setting.js: * Localizations/en.lproj/localizedStrings.js: LayoutTests: * inspector/canvas/resources/recording-utilities.js: (TestPage.registerInitializer.window.startRecording): (TestPage.registerInitializer.handleRecordingProgress): * inspector/canvas/recording-2d.html: * inspector/canvas/recording-bitmaprenderer.html: * inspector/canvas/recording-webgl-snapshots.html: * inspector/canvas/recording-webgl.html: * inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt: Added. * inspector/canvas/setRecordingAutoCaptureFrameCount.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/canvas/recording-2d.html trunk/LayoutTests/inspector/canvas/recording-bitmaprenderer.html trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html trunk/LayoutTests/inspector/canvas/recording-webgl.html trunk/LayoutTests/inspector/canvas/resources/recording-utilities.js trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/protocol/Canvas.json trunk/Source/_javascript_Core/inspector/protocol/Recording.json trunk/Source/WebCore/ChangeLog
[webkit-changes] [237669] trunk/Source
Title: [237669] trunk/Source Revision 237669 Author drou...@apple.com Date 2018-10-31 21:12:59 -0700 (Wed, 31 Oct 2018) Log Message Web Inspector: display low-power enter/exit events in Timelines and Network node waterfalls https://bugs.webkit.org/show_bug.cgi?id=190641 Reviewed by Joseph Pecoraro. Source/_javascript_Core: * inspector/protocol/DOM.json: Add `videoLowPowerChanged` event that is fired when `InspectorDOMAgent` is able to determine whether a video element's low power state has changed. Source/WebCore: No new tests, as low power mode is indeterminate. Should not affect functionality. * inspector/agents/InspectorDOMAgent.h: * inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::addEventListenersToNode): (WebCore::InspectorDOMAgent::mediaMetricsTimerFired): Added. Source/WebInspectorUI: * UserInterface/Protocol/DOMObserver.js: (WI.DOMObserver.prototype.videoLowPowerChanged): Added. * UserInterface/Controllers/DOMManager.js: (WI.DOMManager.prototype.videoLowPowerChanged): Added. * UserInterface/Models/DOMNode.js: (WI.DOMNode): (WI.DOMNode.prototype.get lowPowerRanges): Added. (WI.DOMNode.prototype.videoLowPowerChanged): Added. (WI.DOMNode.prototype.canEnterLowPowerMode): Added. * UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView.prototype._populateDomainCell): (WI.NetworkTableContentView.prototype._tryLinkResourceToDOMNode): (WI.NetworkTableContentView.prototype._handleNodeLowPowerChanged): Added. * UserInterface/Views/NetworkTableContentView.css: (.network-table :not(.header) .cell.waterfall .waterfall-container > .area): (.network-table :not(.header) .cell.waterfall .waterfall-container > .area.dom-fullscreen): Added. (.network-table :not(.header) .cell.waterfall .waterfall-container > .area.low-power): Added. (.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-fullscreen): Deleted. * UserInterface/Views/DOMNodeEventsContentView.js: (WI.DOMNodeEventsContentView): (WI.DOMNodeEventsContentView.prototype.initialLayout): (WI.DOMNodeEventsContentView.prototype.closed): Deleted. (WI.DOMNodeEventsContentView.prototype._handleDOMNodeDidFireEvent): Deleted. * UserInterface/Views/DOMEventsBreakdownView.js: (WI.DOMEventsBreakdownView): (WI.DOMEventsBreakdownView.prototype.initialLayout): (WI.DOMEventsBreakdownView.prototype.layout): Added. (WI.DOMEventsBreakdownView.prototype._handleDOMNodeDidFireEvent): Added. (WI.DOMEventsBreakdownView.prototype._handleDOMNodeLowPowerChanged): Added. (WI.DOMEventsBreakdownView.prototype.addEvent): Deleted. (WI.DOMEventsBreakdownView.prototype._populateTable.percentOfTotalTime): Deleted. (WI.DOMEventsBreakdownView.prototype._populateTable): Deleted. * UserInterface/Views/DOMEventsBreakdownView.css: (.dom-events-breakdown .graph > .area): Added. (.dom-events-breakdown .graph > .area.fullscreen): (.dom-events-breakdown .graph > .area.low-power): Added. * Localizations/en.lproj/localizedStrings.js: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/inspector/protocol/DOM.json trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js trunk/Source/WebInspectorUI/UserInterface/Protocol/DOMObserver.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMEventsBreakdownView.css trunk/Source/WebInspectorUI/UserInterface/Views/DOMEventsBreakdownView.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeEventsContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js Diff Modified: trunk/Source/_javascript_Core/ChangeLog (237668 => 237669) --- trunk/Source/_javascript_Core/ChangeLog 2018-11-01 04:08:19 UTC (rev 237668) +++ trunk/Source/_javascript_Core/ChangeLog 2018-11-01 04:12:59 UTC (rev 237669) @@ -1,3 +1,15 @@ +2018-10-31 Devin Rousso + +Web Inspector: display low-power enter/exit events in Timelines and Network node waterfalls +https://bugs.webkit.org/show_bug.cgi?id=190641 + + +Reviewed by Joseph Pecoraro. + +* inspector/protocol/DOM.json: +Add `videoLowPowerChanged` event that is fired when `InspectorDOMAgent` is able to determine +whether a video element's low power state has changed. + 2018-10-31 Tadeu Zagallo Adjust inlining threshold for new bytecode format Modified: trunk/Source/_javascript_Core/inspector/protocol/DOM.json (237668 => 237669) --- trunk/Source/_javascript_Core/inspector/protocol/DOM.json 2018-11-01 04:08:19 UTC (rev 237668) +++
[webkit-changes] [237668] trunk/Tools
Title: [237668] trunk/Tools
Revision 237668
Author justin_mich...@apple.com
Date 2018-10-31 21:08:19 -0700 (Wed, 31 Oct 2018)
Log Message
Add Justin Michaud to the list of WebKit Committers
https://bugs.webkit.org/show_bug.cgi?id=191142
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (237667 => 237668)
--- trunk/Tools/ChangeLog 2018-11-01 02:11:21 UTC (rev 237667)
+++ trunk/Tools/ChangeLog 2018-11-01 04:08:19 UTC (rev 237668)
@@ -1,3 +1,10 @@
+2018-10-31 Justin Michaud
+
+Add Justin Michaud to the list of WebKit Committers
+https://bugs.webkit.org/show_bug.cgi?id=191142
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2018-10-31 Guillaume Emont
Don't run JIT tests on 32-bit platforms
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (237667 => 237668)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2018-11-01 02:11:21 UTC (rev 237667)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2018-11-01 04:08:19 UTC (rev 237668)
@@ -1535,9 +1535,9 @@
"status" : "committer"
},
"David Fenton" : {
-"aliases" : [
-"Dawei Fenton"
- ],
+ "aliases" : [
+ "Dawei Fenton"
+ ],
"emails" : [
"david_fen...@apple.com",
"realda...@apple.com"
@@ -3313,7 +3313,8 @@
"Justin Michaud" : {
"emails" : [
"justin_mich...@apple.com"
- ]
+ ],
+ "status" : "committer"
},
"Justin Novosad" : {
"emails" : [
@@ -4553,7 +4554,7 @@
],
"status" : "committer"
},
- "Pablo Saavedra Rodi\u00F1o" : {
+ "Pablo Saavedra Rodi\u00f1o" : {
"emails" : [
"psaave...@igalia.com"
]
@@ -6161,4 +6162,4 @@
],
"status" : "reviewer"
}
-}
+}
\ No newline at end of file
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237667] trunk/Source/WebKit
Title: [237667] trunk/Source/WebKit Revision 237667 Author wenson_hs...@apple.com Date 2018-10-31 19:11:21 -0700 (Wed, 31 Oct 2018) Log Message API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13 https://bugs.webkit.org/show_bug.cgi?id=191114 Reviewed by Dean Jackson. Followup to r237648: also make sure that we insecurely unarchive NSFileWrapper on platforms that don't support secure archiving of file wrappers. * UIProcess/API/Cocoa/APIAttachmentCocoa.mm: (API::Attachment::updateFromSerializedRepresentation): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm Diff Modified: trunk/Source/WebKit/ChangeLog (237666 => 237667) --- trunk/Source/WebKit/ChangeLog 2018-11-01 01:18:46 UTC (rev 237666) +++ trunk/Source/WebKit/ChangeLog 2018-11-01 02:11:21 UTC (rev 237667) @@ -1,3 +1,17 @@ +2018-10-31 Wenson Hsieh + +API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13 +https://bugs.webkit.org/show_bug.cgi?id=191114 + + +Reviewed by Dean Jackson. + +Followup to r237648: also make sure that we insecurely unarchive NSFileWrapper on platforms that don't support +secure archiving of file wrappers. + +* UIProcess/API/Cocoa/APIAttachmentCocoa.mm: +(API::Attachment::updateFromSerializedRepresentation): + 2018-10-31 Dean Jackson Forward original fragment identifier into System Preview Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm (237666 => 237667) --- trunk/Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm 2018-11-01 01:18:46 UTC (rev 237666) +++ trunk/Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm 2018-11-01 02:11:21 UTC (rev 237667) @@ -155,8 +155,13 @@ if (!serializedData) return; +#if CAN_SECURELY_ARCHIVE_FILE_WRAPPER NSFileWrapper *fileWrapper = unarchivedObjectOfClassesFromData(m_webPage->pageClient().serializableFileWrapperClasses(), serializedData.get()); -if (!fileWrapper) +#else +NSFileWrapper *fileWrapper = insecurelyUnarchiveObjectFromData(serializedData.get()); +#endif + +if (![fileWrapper isKindOfClass:NSFileWrapper.class]) return; setFileWrapperAndUpdateContentType(fileWrapper, contentType); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237665] trunk
Title: [237665] trunk Revision 237665 Author drou...@apple.com Date 2018-10-31 18:18:07 -0700 (Wed, 31 Oct 2018) Log Message Web Inspector: Audit: save imported audits across WebInspector sessions https://bugs.webkit.org/show_bug.cgi?id=190858 Reviewed by Brian Burg. Source/WebInspectorUI: * UserInterface/Base/ObjectStore.js: Added. (WI.ObjectStore): (WI.ObjectStore.supported): (WI.ObjectStore._open): (WI.ObjectStore.get _databaseName): (WI.ObjectStore.prototype.associateObject): (WI.ObjectStore.prototype.async getAll): (WI.ObjectStore.prototype.async add): (WI.ObjectStore.prototype.async addObject): (WI.ObjectStore.prototype.async delete): (WI.ObjectStore.prototype.async deleteObject): (WI.ObjectStore.prototype._resolveKeyPath): (WI.ObjectStore.prototype.async _operation.listener): (WI.ObjectStore.prototype.async _operation): Wrapper for a global `IndexedDB` instance for all of WebInspector (per level). Instances of `WI.ObjectStore` are able to control a given `IDBObjectStore` using a promise-based API. *NOTE*: due to the constraint that `IDBObjectStore`s are only able to be created when the owner `IndexedDB` is "upgrade"d, all `WI.ObjectStore` must be declared before the database is opened for the first time. Additionally, any time a new `WI.ObjectStore` is added, the `version` needs to be incremented to ensure that the "upgrade" event fires. To use any of the `*Object` functions, one must implement a `toJSON` on the object provided. This is so that `WI.ObjectStore` is able to add the resulting identifier value to the owner object while storing its `toJSON` value in the IndexedDB (e.g. for objects that have cycles). * UserInterface/Controllers/AuditManager.js: (WI.AuditManager.prototype.import): (WI.AuditManager.prototype.loadStoredTests): Added. (WI.AuditManager.prototype.removeTest): Added. (WI.AuditManager.prototype._addTest): * UserInterface/Views/AuditTabContentView.js: (WI.AuditTabContentView.prototype.initialLayout): Added. Attempt to load stored audits when the Audit tab is first shown (lazy-load). * UserInterface/Views/AuditNavigationSidebarPanel.js: (WI.AuditNavigationSidebarPanel.prototype.initialLayout): (WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved): Added. * UserInterface/Views/AuditTreeElement.js: (WI.AuditTreeElement.prototype.ondelete): Only allow top-level audits to be deleted, as that is what matches the `WI.ObjectStore`. * UserInterface/Main.html: * UserInterface/Test.html: LayoutTests: * inspector/unit-tests/objectStore/add-expected.txt: Added. * inspector/unit-tests/objectStore/add.html: Added. * inspector/unit-tests/objectStore/addObject-expected.txt: Added. * inspector/unit-tests/objectStore/addObject.html: Added. * inspector/unit-tests/objectStore/basic-expected.txt: Added. * inspector/unit-tests/objectStore/basic.html: Added. * inspector/unit-tests/objectStore/delete-expected.txt: Added. * inspector/unit-tests/objectStore/delete.html: Added. * inspector/unit-tests/objectStore/deleteObject-expected.txt: Added. * inspector/unit-tests/objectStore/deleteObject.html: Added. * inspector/unit-tests/objectStore/resources/objectStore-utilities.js: Added. (TestPage.registerInitializer.InspectorTest.ObjectStore.TestObject): (TestPage.registerInitializer.InspectorTest.ObjectStore.TestObject.prototype.toJSON): (TestPage.registerInitializer.InspectorTest.ObjectStore.createSuite): (TestPage.registerInitializer.InspectorTest.ObjectStore.createObjectStore): (TestPage.registerInitializer.InspectorTest.ObjectStore.add): (TestPage.registerInitializer.InspectorTest.ObjectStore.addObject): (TestPage.registerInitializer.InspectorTest.ObjectStore.delete): (TestPage.registerInitializer.InspectorTest.ObjectStore.deleteObject): (TestPage.registerInitializer.InspectorTest.ObjectStore.logValues): (TestPage.registerInitializer.InspectorTest.ObjectStore.wrapTest): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js trunk/Source/WebInspectorUI/UserInterface/Main.html trunk/Source/WebInspectorUI/UserInterface/Test.html trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/AuditTabContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js Added Paths trunk/LayoutTests/inspector/unit-tests/objectStore/ trunk/LayoutTests/inspector/unit-tests/objectStore/add-expected.txt trunk/LayoutTests/inspector/unit-tests/objectStore/add.html trunk/LayoutTests/inspector/unit-tests/objectStore/addObject-expected.txt trunk/LayoutTests/inspector/unit-tests/objectStore/addObject.html trunk/LayoutTests/inspector/unit-tests/objectStore/basic-expected.txt trunk/LayoutTests/inspector/unit-tests/objectStore/basic.html trunk/LayoutTests/inspector/unit-tests/objectStore/delete-expected.txt trunk/LayoutTests/inspector/unit-tests/objectStore/delete.html
[webkit-changes] [237666] trunk/Source/WebKitLegacy/win
Title: [237666] trunk/Source/WebKitLegacy/win
Revision 237666
Author hironori.fu...@sony.com
Date 2018-10-31 18:18:46 -0700 (Wed, 31 Oct 2018)
Log Message
[Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=191105
Reviewed by Brent Fulgham.
* DOMHTMLClasses.h:
(DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
instead of own setNodeValue.
Modified Paths
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/DOMHTMLClasses.h
Diff
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (237665 => 237666)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-01 01:18:07 UTC (rev 237665)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2018-11-01 01:18:46 UTC (rev 237666)
@@ -1,3 +1,14 @@
+2018-10-31 Fujii Hironori
+
+[Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
+https://bugs.webkit.org/show_bug.cgi?id=191105
+
+Reviewed by Brent Fulgham.
+
+* DOMHTMLClasses.h:
+(DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
+instead of own setNodeValue.
+
2018-10-25 Antoine Quint
[Web Animations] Turn Web Animations CSS Integration off by default
Modified: trunk/Source/WebKitLegacy/win/DOMHTMLClasses.h (237665 => 237666)
--- trunk/Source/WebKitLegacy/win/DOMHTMLClasses.h 2018-11-01 01:18:07 UTC (rev 237665)
+++ trunk/Source/WebKitLegacy/win/DOMHTMLClasses.h 2018-11-01 01:18:46 UTC (rev 237666)
@@ -227,7 +227,7 @@
virtual HRESULT STDMETHODCALLTYPE setNodeValue(_In_ BSTR value)
{
-return setNodeValue(value);
+return DOMDocument::setNodeValue(value);
}
virtual HRESULT STDMETHODCALLTYPE nodeType(_Out_ unsigned short* result)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237664] trunk/Source/WebKit
Title: [237664] trunk/Source/WebKit
Revision 237664
Author d...@apple.com
Date 2018-10-31 18:03:09 -0700 (Wed, 31 Oct 2018)
Log Message
Forward original fragment identifier into System Preview
https://bugs.webkit.org/show_bug.cgi?id=191141
Reviewed by Wenson Hsieh.
If the URL used by the page includes a fragment identifier, use
it when telling QuickLook to open a local file.
* UIProcess/Cocoa/DownloadClient.mm:
(WebKit::DownloadClient::didFinish): Append original fragment identifier
to the destination URL.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (237663 => 237664)
--- trunk/Source/WebKit/ChangeLog 2018-11-01 00:39:38 UTC (rev 237663)
+++ trunk/Source/WebKit/ChangeLog 2018-11-01 01:03:09 UTC (rev 237664)
@@ -1,3 +1,18 @@
+2018-10-31 Dean Jackson
+
+Forward original fragment identifier into System Preview
+https://bugs.webkit.org/show_bug.cgi?id=191141
+
+
+Reviewed by Wenson Hsieh.
+
+If the URL used by the page includes a fragment identifier, use
+it when telling QuickLook to open a local file.
+
+* UIProcess/Cocoa/DownloadClient.mm:
+(WebKit::DownloadClient::didFinish): Append original fragment identifier
+to the destination URL.
+
2018-10-31 Zalan Bujtas
[iOS] Do not paint tap highlight unless it is above a certain threshold
Modified: trunk/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm (237663 => 237664)
--- trunk/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm 2018-11-01 00:39:38 UTC (rev 237663)
+++ trunk/Source/WebKit/UIProcess/Cocoa/DownloadClient.mm 2018-11-01 01:03:09 UTC (rev 237664)
@@ -212,8 +212,10 @@
#if USE(SYSTEM_PREVIEW)
if (downloadProxy.isSystemPreviewDownload()) {
if (auto* webPage = downloadProxy.originatingPage()) {
-NSURL *destinationURL = [NSURL fileURLWithPath:(NSString *)downloadProxy.destinationFilename()];
-webPage->systemPreviewController()->finish(WebCore::URL(destinationURL));
+WebCore::URL destinationURL = WebCore::URL::fileURLWithFileSystemPath(downloadProxy.destinationFilename());
+if (!destinationURL.fragmentIdentifier().length())
+destinationURL.setFragmentIdentifier(downloadProxy.request().url().fragmentIdentifier());
+webPage->systemPreviewController()->finish(destinationURL);
}
releaseActivityTokenIfNecessary(downloadProxy);
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237663] tags/Safari-607.1.12/
Title: [237663] tags/Safari-607.1.12/ Revision 237663 Author kocsen_ch...@apple.com Date 2018-10-31 17:39:38 -0700 (Wed, 31 Oct 2018) Log Message Tag Safari-607.1.12. Added Paths tags/Safari-607.1.12/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237662] trunk/Source
Title: [237662] trunk/Source Revision 237662 Author kocsen_ch...@apple.com Date 2018-10-31 17:39:16 -0700 (Wed, 31 Oct 2018) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (237661 => 237662) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-01 00:37:37 UTC (rev 237661) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2018-11-01 00:39:16 UTC (rev 237662) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (237661 => 237662) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-01 00:37:37 UTC (rev 237661) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2018-11-01 00:39:16 UTC (rev 237662) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (237661 => 237662) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2018-11-01 00:37:37 UTC (rev 237661) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2018-11-01 00:39:16 UTC (rev 237662) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (237661 => 237662) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-01 00:37:37 UTC (rev 237661) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2018-11-01 00:39:16 UTC (rev 237662) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (237661 => 237662) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-01 00:37:37 UTC (rev 237661) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2018-11-01 00:39:16 UTC (rev 237662) @@ -1,6 +1,6 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (237661 => 237662) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2018-11-01 00:37:37 UTC (rev 237661) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2018-11-01 00:39:16 UTC (rev 237662) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (237661 => 237662) --- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-01 00:37:37 UTC (rev 237661) +++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2018-11-01 00:39:16 UTC (rev 237662) @@ -23,7 +23,7 @@ MAJOR_VERSION = 607; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237661] trunk/Source/WebInspectorUI
Title: [237661] trunk/Source/WebInspectorUI Revision 237661 Author commit-qu...@webkit.org Date 2018-10-31 17:37:37 -0700 (Wed, 31 Oct 2018) Log Message Web Inspector: Move a few remaining global WI settings to WI.settings https://bugs.webkit.org/show_bug.cgi?id=191137 Patch by Joseph Pecoraro on 2018-10-31 Reviewed by Brian Burg. Move and better name some of the WI.settings created in Main.js to WI.settings, alongside other global settings. * UserInterface/Base/Main.js: (WI.loaded): Move settings, and register for settings changes in contentLoaded. * UserInterface/Base/Setting.js: New settings, and sort values. * UserInterface/Test/Test.js: (WI.loaded): Update setting values for tests. * UserInterface/Controllers/NetworkManager.js: (WI.NetworkManager.prototype.initializeTarget): * UserInterface/Controllers/RuntimeManager.js: (WI.RuntimeManager.prototype.initializeTarget): * UserInterface/Models/DOMNode.js: (WI.DOMNode.prototype.get children): (WI.DOMNode.prototype.get nextSibling): (WI.DOMNode.prototype.get previousSibling): (WI.DOMNode.prototype.get childNodeCount): * UserInterface/Protocol/Target.js: (WI.Target.prototype.initialize): * UserInterface/Views/DOMTreeContentView.js: (WI.DOMTreeContentView): (WI.DOMTreeContentView.prototype.closed): (WI.DOMTreeContentView.prototype._togglePaintFlashing): (WI.DOMTreeContentView.prototype._showPaintRectsSettingChanged): (WI.DOMTreeContentView.prototype._showShadowDOMSettingChanged): (WI.DOMTreeContentView.prototype._toggleShowsShadowDOMSetting): * UserInterface/Views/DOMTreeOutline.js: (WI.DOMTreeOutline): (WI.DOMTreeOutline.prototype.close): (WI.DOMTreeOutline.prototype._revealAndSelectNode): * UserInterface/Views/LayerTreeDetailsSidebarPanel.js: (WI.LayerTreeDetailsSidebarPanel.prototype.initialLayout): (WI.LayerTreeDetailsSidebarPanel.prototype._updateDisplayWithLayers): * UserInterface/Views/Layers3DContentView.js: (WI.Layers3DContentView): (WI.Layers3DContentView.prototype.closed): (WI.Layers3DContentView.prototype._showPaintRectsSettingChanged): (WI.Layers3DContentView.prototype._togglePaintFlashing): * UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView): (WI.NetworkTableContentView.prototype.closed): (WI.NetworkTableContentView.prototype._resourceCachingDisabledSettingChanged): (WI.NetworkTableContentView.prototype._toggleDisableResourceCache): * UserInterface/Views/ScriptContentView.js: (WI.ScriptContentView): (WI.ScriptContentView.prototype.closed): (WI.ScriptContentView.prototype._contentDidPopulate): (WI.ScriptContentView.prototype._enableControlFlowProfilerSettingChanged): (WI.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged): * UserInterface/Views/SourceCodeTextEditor.js: (WI.SourceCodeTextEditor.prototype.shown): (WI.SourceCodeTextEditor.prototype._proceedPopulateWithContent): (WI.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState): (WI.SourceCodeTextEditor.prototype.set _basicBlockAnnotatorEnabled): * UserInterface/Views/TextResourceContentView.js: (WI.TextResourceContentView): (WI.TextResourceContentView.prototype.closed): (WI.TextResourceContentView.prototype._contentDidPopulate): (WI.TextResourceContentView.prototype._enableControlFlowProfilerSettingChanged): (WI.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged): Renamed setting. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Base/Main.js trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js trunk/Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js trunk/Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js trunk/Source/WebInspectorUI/UserInterface/Protocol/Target.js trunk/Source/WebInspectorUI/UserInterface/Test/Test.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (237660 => 237661) --- trunk/Source/WebInspectorUI/ChangeLog 2018-10-31 23:57:30 UTC (rev 237660) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-01 00:37:37 UTC (rev 237661) @@ -1,3 +1,78 @@ +2018-10-31 Joseph Pecoraro + +Web Inspector: Move a few remaining global WI settings to WI.settings +https://bugs.webkit.org/show_bug.cgi?id=191137 + +Reviewed by Brian Burg. + +Move and better name some of the WI.settings created in Main.js +to WI.settings, alongside
[webkit-changes] [237660] trunk/Source/WebInspectorUI
Title: [237660] trunk/Source/WebInspectorUI
Revision 237660
Author drou...@apple.com
Date 2018-10-31 16:57:30 -0700 (Wed, 31 Oct 2018)
Log Message
Web Inspector: Styles: missing contextmenu items for links
https://bugs.webkit.org/show_bug.cgi?id=191021
Reviewed by Joseph Pecoraro.
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._handleLinkContextMenu): Added.
If the token is subtype of "link", add contextmenu items to the wrapper element.
* UserInterface/Views/ContextMenuUtilities.js:
(WI.appendContextMenuItemsForURL.showResourceWithOptions):
(WI.appendContextMenuItemsForURL):
Drive-by: don't assume that `options` will be provided.
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (237659 => 237660)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-10-31 22:52:11 UTC (rev 237659)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-31 23:57:30 UTC (rev 237660)
@@ -1,3 +1,22 @@
+2018-10-31 Devin Rousso
+
+Web Inspector: Styles: missing contextmenu items for links
+https://bugs.webkit.org/show_bug.cgi?id=191021
+
+Reviewed by Joseph Pecoraro.
+
+* UserInterface/Views/SpreadsheetStyleProperty.js:
+(WI.SpreadsheetStyleProperty.prototype._renderValue):
+(WI.SpreadsheetStyleProperty.prototype._handleLinkContextMenu): Added.
+If the token is subtype of "link", add contextmenu items to the wrapper element.
+
+* UserInterface/Views/ContextMenuUtilities.js:
+(WI.appendContextMenuItemsForURL.showResourceWithOptions):
+(WI.appendContextMenuItemsForURL):
+Drive-by: don't assume that `options` will be provided.
+
+* Localizations/en.lproj/localizedStrings.js:
+
2018-10-31 Nikita Vasilyev
Web Inspector: Styles: implement copying and deletion of multiple properties
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (237659 => 237660)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2018-10-31 22:52:11 UTC (rev 237659)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2018-10-31 23:57:30 UTC (rev 237660)
@@ -240,7 +240,7 @@
localizedStrings["Cookies"] = "Cookies";
localizedStrings["Copy"] = "Copy";
localizedStrings["Copy Action"] = "Copy Action";
-localizedStrings["Copy Link Address"] = "Copy Link Address";
+localizedStrings["Copy Link"] = "Copy Link";
localizedStrings["Copy Path to Property"] = "Copy Path to Property";
localizedStrings["Copy Row"] = "Copy Row";
localizedStrings["Copy Selected"] = "Copy Selected";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js (237659 => 237660)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2018-10-31 22:52:11 UTC (rev 237659)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2018-10-31 23:57:30 UTC (rev 237660)
@@ -80,25 +80,26 @@
}
};
-WI.appendContextMenuItemsForURL = function(contextMenu, url, options)
+WI.appendContextMenuItemsForURL = function(contextMenu, url, options = {})
{
if (!url)
return;
-let {sourceCode, location, frame} = options;
function showResourceWithOptions(options) {
-if (location)
-WI.showSourceCodeLocation(location, options);
-else if (sourceCode)
-WI.showSourceCode(sourceCode, options);
+if (options.location)
+WI.showSourceCodeLocation(options.location, options);
+else if (options.sourceCode)
+WI.showSourceCode(options.sourceCode, options);
else
-WI.openURL(url, frame, options);
+WI.openURL(url, options.frame, options);
}
-contextMenu.appendItem(WI.UIString("Open in New Tab"), () => {
-const frame = null;
-WI.openURL(url, frame, {alwaysOpenExternally: true});
-});
+if (!url.startsWith("_javascript_:") && !url.startsWith("data:")) {
+contextMenu.appendItem(WI.UIString("Open in New Tab"), () => {
+const frame = null;
+WI.openURL(url, frame, {alwaysOpenExternally: true});
+});
+}
if (WI.networkManager.resourceForURL(url)) {
if (!WI.isShowingResourcesTab()) {
@@ -113,7 +114,9 @@
}
}
-contextMenu.appendItem(WI.UIString("Copy Link Address"), () => {
+contextMenu.appendSeparator();
+
+contextMenu.appendItem(WI.UIString("Copy Link"), () => {
InspectorFrontendHost.copyText(url);
});
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
[webkit-changes] [237659] trunk/Source/WebInspectorUI
Title: [237659] trunk/Source/WebInspectorUI Revision 237659 Author nvasil...@apple.com Date 2018-10-31 15:52:11 -0700 (Wed, 31 Oct 2018) Log Message Web Inspector: Styles: implement copying and deletion of multiple properties https://bugs.webkit.org/show_bug.cgi?id=191037 Reviewed by Brian Burg. This patch should only work with "Enable Selection of Multiple Properties" checked. It shouldn't introduce any changes when this setting is unchecked. Mousedown on a property (1) and moving the mouse cursor to another property (2) should select properties 1, 2, and all properties between them until mouseup is fired. Once selected: - Pressing Command-C should copy the selected properties. - Pressing Delete should remove the properties. * UserInterface/Models/CSSProperty.js: (WI.CSSProperty.prototype.get formattedText): * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css: (.spreadsheet-style-declaration-editor): (.multiple-properties-selection .spreadsheet-style-declaration-editor .property): (.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)): (.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected): (.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected:focus): (@media (prefers-dark-interface)): * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js: (WI.SpreadsheetCSSStyleDeclarationEditor): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.deselectProperties): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyBlur): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseEnter): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseLeave): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown): (WI.SpreadsheetCSSStyleDeclarationEditor.prototype._hasSelectedProperties): Property selection is defined as two numbers: anchorIndex and focusIndex. The property with focusIndex is actually focused. The focus outline is replaced by a more subtle left blue border. * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css: (.spreadsheet-css-declaration.selecting,): * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: (WI.SpreadsheetCSSStyleDeclarationSection): (WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyBlur): (WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseEnter): (WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseLeave): (WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown): (WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowMouseUp): (WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick): * UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty): Implement copying the same way it's done for DataGrid: by adding copyHandler property to the focused element. Add `tabIndex=-1` so the property element can be focused. (WI.SpreadsheetStyleProperty.prototype.get property): (WI.SpreadsheetStyleProperty.prototype.get selected): (WI.SpreadsheetStyleProperty.prototype.set selected): (WI.SpreadsheetStyleProperty.prototype.remove): (WI.SpreadsheetStyleProperty.prototype.updateStatus): (WI.SpreadsheetStyleProperty.prototype.handleCopyEvent): (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit): (WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur): (WI.SpreadsheetStyleProperty.prototype._handleNamePaste): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (237658 => 237659) --- trunk/Source/WebInspectorUI/ChangeLog 2018-10-31 22:44:27 UTC (rev 237658) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-31 22:52:11 UTC (rev 237659) @@ -1,3 +1,70 @@ +2018-10-31 Nikita Vasilyev + +Web Inspector: Styles: implement copying and deletion of multiple properties +https://bugs.webkit.org/show_bug.cgi?id=191037 + + +Reviewed by Brian Burg. + +This patch should only work with "Enable Selection of Multiple Properties" checked. It shouldn't
[webkit-changes] [237658] trunk/Source/WebKit
Title: [237658] trunk/Source/WebKit
Revision 237658
Author za...@apple.com
Date 2018-10-31 15:44:27 -0700 (Wed, 31 Oct 2018)
Log Message
[iOS] Do not paint tap highlight unless it is above a certain threshold
https://bugs.webkit.org/show_bug.cgi?id=191134
Flashing a large portion of the screen on every tap looks unpleasant.
This patch impoves the existing heuristic by adding area check and a % threshold.
Reviewed by Tim Horton.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showTapHighlight]):
(highlightedQuadsAreSmallerThanRect): Deleted.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (237657 => 237658)
--- trunk/Source/WebKit/ChangeLog 2018-10-31 22:05:51 UTC (rev 237657)
+++ trunk/Source/WebKit/ChangeLog 2018-10-31 22:44:27 UTC (rev 237658)
@@ -1,3 +1,18 @@
+2018-10-31 Zalan Bujtas
+
+[iOS] Do not paint tap highlight unless it is above a certain threshold
+https://bugs.webkit.org/show_bug.cgi?id=191134
+
+
+Flashing a large portion of the screen on every tap looks unpleasant.
+This patch impoves the existing heuristic by adding area check and a % threshold.
+
+Reviewed by Tim Horton.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _showTapHighlight]):
+(highlightedQuadsAreSmallerThanRect): Deleted.
+
2018-10-31 Wenson Hsieh
API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (237657 => 237658)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-10-31 22:05:51 UTC (rev 237657)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-10-31 22:44:27 UTC (rev 237658)
@@ -1151,16 +1151,6 @@
}
#endif
-static inline bool highlightedQuadsAreSmallerThanRect(const Vector& quads, const FloatRect& rect)
-{
-for (size_t i = 0; i < quads.size(); ++i) {
-FloatRect boundingBox = quads[i].boundingBox();
-if (boundingBox.width() > rect.width() || boundingBox.height() > rect.height())
-return false;
-}
-return true;
-}
-
static NSValue *nsSizeForTapHighlightBorderRadius(WebCore::IntSize borderRadius, CGFloat borderRadiusScale)
{
return [NSValue valueWithCGSize:CGSizeMake((borderRadius.width() * borderRadiusScale) + minimumTapHighlightRadius, (borderRadius.height() * borderRadiusScale) + minimumTapHighlightRadius)];
@@ -1223,7 +1213,19 @@
- (void)_showTapHighlight
{
-if (!highlightedQuadsAreSmallerThanRect(_tapHighlightInformation.quads, _page->unobscuredContentRect()) && !_showDebugTapHighlightsForFastClicking)
+auto shouldPaintTapHighlight = [&](const FloatRect& rect) {
+static const float highlightPaintThreshold = 0.3; // 30%
+float highlightArea = 0;
+for (auto highlightQuad : _tapHighlightInformation.quads) {
+auto boundingBox = highlightQuad.boundingBox();
+highlightArea += boundingBox.area();
+if (boundingBox.width() > (rect.width() * highlightPaintThreshold) || boundingBox.height() > (rect.height() * highlightPaintThreshold))
+return false;
+}
+return highlightArea < rect.area() * highlightPaintThreshold;
+};
+
+if (!shouldPaintTapHighlight(_page->unobscuredContentRect()) && !_showDebugTapHighlightsForFastClicking)
return;
if (!_highlightView) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237657] trunk
Title: [237657] trunk
Revision 237657
Author ab...@igalia.com
Date 2018-10-31 15:05:51 -0700 (Wed, 31 Oct 2018)
Log Message
[MSE] Use tolerance when growing the coded frame group
https://bugs.webkit.org/show_bug.cgi?id=190085
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-source/media-source-append-acb-tolerance.html
This patch introduces a millisecond tolerance in the range of
potential frames that should be erased frame from the track buffer
when the coded frame group is growing.
This is necessary because some files have imprecise overlapping
timestamps (especially WebM files).
This fixes a stall when seeking back and forth in YouTube with WebM
video.
A test case simulating the problem with video/mock using timestamps
similar to those of a typical 30 fps WebM video is also added.
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
LayoutTests:
A test simulating unordered appends with imprecise timestamps,
overlapping <1ms (replicating a typical WebM 30fps video file) is
added.
* media/media-source/media-source-append-acb-tolerance.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
Added Paths
trunk/LayoutTests/media/media-source/media-source-append-acb-tolerance-expected.txt
trunk/LayoutTests/media/media-source/media-source-append-acb-tolerance.html
Diff
Modified: trunk/LayoutTests/ChangeLog (237656 => 237657)
--- trunk/LayoutTests/ChangeLog 2018-10-31 22:00:34 UTC (rev 237656)
+++ trunk/LayoutTests/ChangeLog 2018-10-31 22:05:51 UTC (rev 237657)
@@ -1,3 +1,16 @@
+2018-10-31 Alicia Boya GarcĂa
+
+[MSE] Use tolerance when growing the coded frame group
+https://bugs.webkit.org/show_bug.cgi?id=190085
+
+Reviewed by Jer Noble.
+
+A test simulating unordered appends with imprecise timestamps,
+overlapping <1ms (replicating a typical WebM 30fps video file) is
+added.
+
+* media/media-source/media-source-append-acb-tolerance.html: Added.
+
2018-10-31 Devin Rousso
Web Inspector: Audit: attempt to re-link DOM nodes for imported results
Added: trunk/LayoutTests/media/media-source/media-source-append-acb-tolerance-expected.txt (0 => 237657)
--- trunk/LayoutTests/media/media-source/media-source-append-acb-tolerance-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-append-acb-tolerance-expected.txt 2018-10-31 22:05:51 UTC (rev 237657)
@@ -0,0 +1,466 @@
+
+EXPECTED (source.readyState == 'closed') OK
+EVENT(sourceopen)
+RUN(sourceBuffer = source.addSourceBuffer("video/mock; codecs=mock"))
+RUN(sourceBuffer.appendBuffer(initSegment))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(impreciseSampleRun(0, 5)))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(impreciseSampleRun(10, 15)))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(impreciseSampleRun(5, 10)))
+EVENT(updateend)
+EXPECTED (bufferedSamples.length == '450') OK
+EXPECTED (enqueuedSamples.length == '450') OK
+{PTS({0/100 = 0.00}), DTS({0/100 = 0.00}), duration({3/100 = 0.03}), flags(1), generation(0)}
+{PTS({33000/100 = 0.033000}), DTS({33000/100 = 0.033000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({67000/100 = 0.067000}), DTS({67000/100 = 0.067000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({10/100 = 0.10}), DTS({10/100 = 0.10}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({133000/100 = 0.133000}), DTS({133000/100 = 0.133000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({167000/100 = 0.167000}), DTS({167000/100 = 0.167000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({20/100 = 0.20}), DTS({20/100 = 0.20}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({233000/100 = 0.233000}), DTS({233000/100 = 0.233000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({267000/100 = 0.267000}), DTS({267000/100 = 0.267000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({30/100 = 0.30}), DTS({30/100 = 0.30}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({333000/100 = 0.333000}), DTS({333000/100 = 0.333000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({367000/100 = 0.367000}), DTS({367000/100 = 0.367000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({40/100 = 0.40}), DTS({40/100 = 0.40}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({433000/100 = 0.433000}), DTS({433000/100 = 0.433000}), duration({3/100 = 0.03}), flags(0), generation(0)}
+{PTS({467000/100 =
[webkit-changes] [237656] trunk
Title: [237656] trunk
Revision 237656
Author drou...@apple.com
Date 2018-10-31 15:00:34 -0700 (Wed, 31 Oct 2018)
Log Message
Web Inspector: Audit: attempt to re-link DOM nodes for imported results
https://bugs.webkit.org/show_bug.cgi?id=191044
Reviewed by Brian Burg.
Source/WebInspectorUI:
When importing a `WI.AuditTestCaseResult`, attempt to `querySelector` for each item in
`data.domNodes`. If a node is found, replace it with that node and show a tree instead.
* UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase.async fromPayload): Added.
(WI.AuditTestCase.fromPayload): Deleted.
* UserInterface/Models/AuditTestGroup.js:
(WI.AuditTestGroup.async fromPayload): Added.
(WI.AuditTestGroup.fromPayload): Deleted.
* UserInterface/Models/AuditTestCaseResult.js:
(WI.AuditTestCaseResult.async fromPayload): Added.
(WI.AuditTestCaseResult.fromPayload): Deleted.
* UserInterface/Models/AuditTestGroupResult.js:
(WI.AuditTestGroupResult.async fromPayload): Added.
(WI.AuditTestGroupResult.fromPayload): Deleted.
* UserInterface/Controllers/AuditManager.js:
(WI.AuditManager.prototype.import):
LayoutTests:
* inspector/model/auditTestCase.html:
* inspector/model/auditTestCaseResult.html:
* inspector/model/auditTestGroup.html:
* inspector/model/auditTestGroupResult.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/model/auditTestCase.html
trunk/LayoutTests/inspector/model/auditTestCaseResult.html
trunk/LayoutTests/inspector/model/auditTestGroup.html
trunk/LayoutTests/inspector/model/auditTestGroupResult.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/AuditTestCase.js
trunk/Source/WebInspectorUI/UserInterface/Models/AuditTestCaseResult.js
trunk/Source/WebInspectorUI/UserInterface/Models/AuditTestGroup.js
trunk/Source/WebInspectorUI/UserInterface/Models/AuditTestGroupResult.js
Diff
Modified: trunk/LayoutTests/ChangeLog (237655 => 237656)
--- trunk/LayoutTests/ChangeLog 2018-10-31 21:52:07 UTC (rev 237655)
+++ trunk/LayoutTests/ChangeLog 2018-10-31 22:00:34 UTC (rev 237656)
@@ -1,3 +1,16 @@
+2018-10-31 Devin Rousso
+
+Web Inspector: Audit: attempt to re-link DOM nodes for imported results
+https://bugs.webkit.org/show_bug.cgi?id=191044
+
+
+Reviewed by Brian Burg.
+
+* inspector/model/auditTestCase.html:
+* inspector/model/auditTestCaseResult.html:
+* inspector/model/auditTestGroup.html:
+* inspector/model/auditTestGroupResult.html:
+
2018-10-31 Jer Noble
MediaSource.isTypeSupported('video/mp4; codecs="hvc1.1.6.L60.B0') is inproperly rejected
Modified: trunk/LayoutTests/inspector/model/auditTestCase.html (237655 => 237656)
--- trunk/LayoutTests/inspector/model/auditTestCase.html 2018-10-31 21:52:07 UTC (rev 237655)
+++ trunk/LayoutTests/inspector/model/auditTestCase.html 2018-10-31 22:00:34 UTC (rev 237656)
@@ -11,7 +11,7 @@
suite.addTestCase({
name,
async test() {
-let object = WI.AuditTestCase.fromPayload(payload);
+let object = await WI.AuditTestCase.fromPayload(payload);
InspectorTest.log(object ? JSON.stringify(object, null, 2) : object);
},
});
Modified: trunk/LayoutTests/inspector/model/auditTestCaseResult.html (237655 => 237656)
--- trunk/LayoutTests/inspector/model/auditTestCaseResult.html 2018-10-31 21:52:07 UTC (rev 237655)
+++ trunk/LayoutTests/inspector/model/auditTestCaseResult.html 2018-10-31 22:00:34 UTC (rev 237656)
@@ -11,7 +11,7 @@
suite.addTestCase({
name,
async test() {
-let object = WI.AuditTestCaseResult.fromPayload(payload);
+let object = await WI.AuditTestCaseResult.fromPayload(payload);
InspectorTest.log(object ? JSON.stringify(object, null, 2) : object);
},
});
Modified: trunk/LayoutTests/inspector/model/auditTestGroup.html (237655 => 237656)
--- trunk/LayoutTests/inspector/model/auditTestGroup.html 2018-10-31 21:52:07 UTC (rev 237655)
+++ trunk/LayoutTests/inspector/model/auditTestGroup.html 2018-10-31 22:00:34 UTC (rev 237656)
@@ -11,7 +11,7 @@
suite.addTestCase({
name,
async test() {
-let object = WI.AuditTestGroup.fromPayload(payload);
+let object = await WI.AuditTestGroup.fromPayload(payload);
InspectorTest.log(object ? JSON.stringify(object, null, 2) : object);
},
});
Modified: trunk/LayoutTests/inspector/model/auditTestGroupResult.html (237655 => 237656)
--- trunk/LayoutTests/inspector/model/auditTestGroupResult.html 2018-10-31 21:52:07 UTC (rev 237655)
+++ trunk/LayoutTests/inspector/model/auditTestGroupResult.html 2018-10-31 22:00:34 UTC (rev 237656)
@@ -11,7 +11,7 @@
suite.addTestCase({
name,
[webkit-changes] [237655] trunk
Title: [237655] trunk
Revision 237655
Author jer.no...@apple.com
Date 2018-10-31 14:52:07 -0700 (Wed, 31 Oct 2018)
Log Message
MediaSource.isTypeSupported('video/mp4; codecs="hvc1.1.6.L60.B0') is inproperly rejected
https://bugs.webkit.org/show_bug.cgi?id=191129
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-istypesupported-case-sensitive.html
According to RFC 2045: "All media type values, subtype values, and parameter names as
defined are case-insensitive. However, parameter values are case-sensitive unless otherwise
specified for the specific parameter." So rather than fold the entire ContentType into lower-
case, leave the original string intact and require clients to enforce case-insensitivity.
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported):
LayoutTests:
* media/media-source/media-source-istypesupported-case-sensitive-expected.txt: Added.
* media/media-source/media-source-istypesupported-case-sensitive.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
Added Paths
trunk/LayoutTests/media/media-source/media-source-istypesupported-case-sensitive-expected.txt
trunk/LayoutTests/media/media-source/media-source-istypesupported-case-sensitive.html
Diff
Modified: trunk/LayoutTests/ChangeLog (237654 => 237655)
--- trunk/LayoutTests/ChangeLog 2018-10-31 21:51:20 UTC (rev 237654)
+++ trunk/LayoutTests/ChangeLog 2018-10-31 21:52:07 UTC (rev 237655)
@@ -1,3 +1,13 @@
+2018-10-31 Jer Noble
+
+MediaSource.isTypeSupported('video/mp4; codecs="hvc1.1.6.L60.B0') is inproperly rejected
+https://bugs.webkit.org/show_bug.cgi?id=191129
+
+Reviewed by Eric Carlson.
+
+* media/media-source/media-source-istypesupported-case-sensitive-expected.txt: Added.
+* media/media-source/media-source-istypesupported-case-sensitive.html: Added.
+
2018-10-31 Alicia Boya GarcĂa
[MSE] WebKit tests: Use fixed point in makeASample()
Added: trunk/LayoutTests/media/media-source/media-source-istypesupported-case-sensitive-expected.txt (0 => 237655)
--- trunk/LayoutTests/media/media-source/media-source-istypesupported-case-sensitive-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-istypesupported-case-sensitive-expected.txt 2018-10-31 21:52:07 UTC (rev 237655)
@@ -0,0 +1,7 @@
+
+EXPECTED (MediaSource.isTypeSupported("video/mock; codecs=mock") == 'true') OK
+EXPECTED (MediaSource.isTypeSupported("video/MOCK; codecs=mock") == 'true') OK
+EXPECTED (MediaSource.isTypeSupported("video/mock; codecs=MOCK") == 'false') OK
+EXPECTED (MediaSource.isTypeSupported("video/MOCK; codecs=MOCK") == 'false') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/media-source/media-source-istypesupported-case-sensitive.html (0 => 237655)
--- trunk/LayoutTests/media/media-source/media-source-istypesupported-case-sensitive.html (rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-istypesupported-case-sensitive.html 2018-10-31 21:52:07 UTC (rev 237655)
@@ -0,0 +1,30 @@
+
+
+
+mock-media-source
+
+var source;
+var sourceBuffer;
+
+if (window.internals)
+internals.initializeMockMediaSource();
+
+function runTest() {
+findMediaElement();
+
+source = new MediaSource();
+testExpected('MediaSource.isTypeSupported("video/mock; codecs=mock")', true);
+testExpected('MediaSource.isTypeSupported("video/MOCK; codecs=mock")', true);
+testExpected('MediaSource.isTypeSupported("video/mock; codecs=MOCK")', false);
+testExpected('MediaSource.isTypeSupported("video/MOCK; codecs=MOCK")', false);
+endTest();
+}
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (237654 => 237655)
--- trunk/Source/WebCore/ChangeLog 2018-10-31 21:51:20 UTC (rev 237654)
+++ trunk/Source/WebCore/ChangeLog 2018-10-31 21:52:07 UTC (rev 237655)
@@ -1,5 +1,22 @@
2018-10-31 Jer Noble
+MediaSource.isTypeSupported('video/mp4; codecs="hvc1.1.6.L60.B0') is inproperly rejected
+https://bugs.webkit.org/show_bug.cgi?id=191129
+
+Reviewed by Eric Carlson.
+
+Test: media/media-source/media-source-istypesupported-case-sensitive.html
+
+According to RFC 2045: "All media type values, subtype values, and parameter names as
+defined are case-insensitive. However, parameter values are case-sensitive unless otherwise
+specified for the specific parameter." So rather than fold the entire ContentType into lower-
+case, leave the original string intact and require clients to enforce case-insensitivity.
+
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::isTypeSupported):
+
+2018-10-31 Jer Noble
+
Unreivewed build fix; fix the non-HAVE_AVCONTENTKEYSESSION builds by adding guards around
[webkit-changes] [237654] trunk/Source/WebCore
Title: [237654] trunk/Source/WebCore
Revision 237654
Author jer.no...@apple.com
Date 2018-10-31 14:51:20 -0700 (Wed, 31 Oct 2018)
Log Message
Unreivewed build fix; fix the non-HAVE_AVCONTENTKEYSESSION builds by adding guards around
access of m_cdmInstance.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (237653 => 237654)
--- trunk/Source/WebCore/ChangeLog 2018-10-31 21:48:01 UTC (rev 237653)
+++ trunk/Source/WebCore/ChangeLog 2018-10-31 21:51:20 UTC (rev 237654)
@@ -1,3 +1,11 @@
+2018-10-31 Jer Noble
+
+Unreivewed build fix; fix the non-HAVE_AVCONTENTKEYSESSION builds by adding guards around
+access of m_cdmInstance.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):
+
2018-10-31 YUHAN WU
MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (237653 => 237654)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-10-31 21:48:01 UTC (rev 237653)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-10-31 21:51:20 UTC (rev 237654)
@@ -2487,6 +2487,7 @@
void MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance(CDMInstance&)
{
+#if HAVE(AVCONTENTKEYSESSION)
if (!m_keyID || !m_cdmInstance)
return;
@@ -2503,6 +2504,7 @@
[request finishLoading];
}
setWaitingForKey(false);
+#endif
}
void MediaPlayerPrivateAVFoundationObjC::setWaitingForKey(bool waitingForKey)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237653] trunk/Source/WebInspectorUI
Title: [237653] trunk/Source/WebInspectorUI Revision 237653 Author joep...@webkit.org Date 2018-10-31 14:48:01 -0700 (Wed, 31 Oct 2018) Log Message Follow-up review comment to r237652. Reviewed by Brian Burg. * UserInterface/Controllers/DebuggerManager.js: (WI.DebuggerManager): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (237652 => 237653) --- trunk/Source/WebInspectorUI/ChangeLog 2018-10-31 21:19:11 UTC (rev 237652) +++ trunk/Source/WebInspectorUI/ChangeLog 2018-10-31 21:48:01 UTC (rev 237653) @@ -1,5 +1,14 @@ 2018-10-31 Joseph Pecoraro +Follow-up review comment to r237652. + +Reviewed by Brian Burg. + +* UserInterface/Controllers/DebuggerManager.js: +(WI.DebuggerManager): + +2018-10-31 Joseph Pecoraro + Web Inspector: Separate target initialization from frontend initialization https://bugs.webkit.org/show_bug.cgi?id=191052 Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (237652 => 237653) --- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2018-10-31 21:19:11 UTC (rev 237652) +++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2018-10-31 21:48:01 UTC (rev 237653) @@ -43,7 +43,7 @@ WI.targetManager.addEventListener(WI.TargetManager.Event.TargetRemoved, this._targetRemoved, this); -WI.settings.pauseForInternalScripts.addEventListener(WI.Setting.Event.Changed, this._pauseForInternalScriptsDidChange); +WI.settings.pauseForInternalScripts.addEventListener(WI.Setting.Event.Changed, this._pauseForInternalScriptsDidChange, this); WI.Frame.addEventListener(WI.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237652] trunk/Source/WebInspectorUI
Title: [237652] trunk/Source/WebInspectorUI Revision 237652 Author joep...@webkit.org Date 2018-10-31 14:19:11 -0700 (Wed, 31 Oct 2018) Log Message Web Inspector: Separate target initialization from frontend initialization https://bugs.webkit.org/show_bug.cgi?id=191052 Reviewed by Brian Burg. * UserInterface/Base/Main.js: (WI.loaded): (WI.performOneTimeFrontendInitializationsUsingTarget): Create the targets after the rest of frontend initialization. This is a step toward a frontend opening and being told about multiple targets instead of knowing in advance a single target it is connected to. All backend messages during frontend initialization now happen with an explicit target. * UserInterface/Controllers/ApplicationCacheManager.js: (WI.ApplicationCacheManager): (WI.ApplicationCacheManager.prototype.initializeTarget): (WI.ApplicationCacheManager.prototype.initialize): * UserInterface/Controllers/CSSManager.js: (WI.CSSManager): (WI.CSSManager.prototype.initializeTarget): * UserInterface/Controllers/CanvasManager.js: (WI.CanvasManager): (WI.CanvasManager.prototype.initializeTarget): * UserInterface/Controllers/ConsoleManager.js: (WI.ConsoleManager): (WI.ConsoleManager.prototype.initializeLogChannels): * UserInterface/Controllers/DOMManager.js: (WI.DOMManager): (WI.DOMManager.prototype.initializeTarget): * UserInterface/Controllers/DOMStorageManager.js: (WI.DOMStorageManager): (WI.DOMStorageManager.prototype.initializeTarget): * UserInterface/Controllers/DatabaseManager.js: (WI.DatabaseManager): (WI.DatabaseManager.prototype.initializeTarget): * UserInterface/Controllers/DebuggerManager.js: (WI.DebuggerManager): (WI.DebuggerManager.prototype.initializeTarget): (WI.DebuggerManager.restoreBreakpointsSoon): Deleted. * UserInterface/Controllers/HeapManager.js: (WI.HeapManager.prototype.initializeTarget): * UserInterface/Controllers/IndexedDBManager.js: (WI.IndexedDBManager): (WI.IndexedDBManager.prototype.initializeTarget): * UserInterface/Controllers/LayerTreeManager.js: (WI.LayerTreeManager.prototype.initializeTarget): * UserInterface/Controllers/MemoryManager.js: (WI.MemoryManager.prototype.initializeTarget): * UserInterface/Controllers/NetworkManager.js: (WI.NetworkManager): (WI.NetworkManager.prototype.initializeTarget): * UserInterface/Controllers/RuntimeManager.js: (WI.RuntimeManager): (WI.RuntimeManager.prototype.initializeTarget): * UserInterface/Controllers/TargetManager.js: (WI.TargetManager): (WI.TargetManager.prototype.initializeTargetsWithMainTarget): * UserInterface/Controllers/TimelineManager.js: (WI.TimelineManager): (WI.TimelineManager.prototype.initializeTarget): (WI.TimelineManager.prototype.set enabledTimelineTypes): (WI.TimelineManager.prototype._updateAutoCaptureInstruments): * UserInterface/Controllers/WorkerManager.js: (WI.WorkerManager): (WI.WorkerManager.prototype.initializeTarget): Move Target initialization out of the constructor into a top level `initializeTarget` function. This will be expected to be called by any target that the frontend connects to. (WI.DebuggerManager.prototype._pauseForInternalScriptsDidChange): Drive-by fix. Update all targets if the setting changes. (WI.WorkerManager.prototype.workerCreated): Call initialize on the new target. * UserInterface/Models/CSSCompletions.js: (WI.CSSCompletions.initializeCSSCompletions): (WI.CSSCompletions.requestCSSCompletions): Deleted. Rename requestCSSCompletions to initializeCSSCompletions to try and standardize on "initialize" being used for most frontend one time initialization tasks. This being one such operation that only needs to be performed once on a target that supports it. * UserInterface/Protocol/Target.js: (WI.Target): (WI.Target.prototype.initialize): Perform explicit target initialization, such as initializing the state of all backend domains / agents. This is done by asking each of the managers to do initialization work for this target. (WI.Target.prototype.get ApplicationCacheAgent): (WI.Target.prototype.get CSSAgent): (WI.Target.prototype.get CanvasAgent): (WI.Target.prototype.get ConsoleAgent): (WI.Target.prototype.get DOMAgent): (WI.Target.prototype.get DOMDebuggerAgent): (WI.Target.prototype.get DOMStorageAgent): (WI.Target.prototype.get DatabaseAgent): (WI.Target.prototype.get DebuggerAgent): (WI.Target.prototype.get HeapAgent): (WI.Target.prototype.get IndexedDBAgent): (WI.Target.prototype.get InspectorAgent): (WI.Target.prototype.get LayerTreeAgent): (WI.Target.prototype.get MemoryAgent): (WI.Target.prototype.get NetworkAgent): (WI.Target.prototype.get PageAgent): (WI.Target.prototype.get RecordingAgent): (WI.Target.prototype.get RuntimeAgent): (WI.Target.prototype.get ScriptProfilerAgent): (WI.Target.prototype.get ServiceWorkerAgent): (WI.Target.prototype.get TargetAgent): (WI.Target.prototype.get TimelineAgent): (WI.Target.prototype.get WorkerAgent): Accessors for all of the agents on a Target. * UserInterface/Protocol/WorkerTarget.js: (WI.WorkerTarget): This is now automatically done
[webkit-changes] [237651] trunk/LayoutTests
Title: [237651] trunk/LayoutTests Revision 237651 Author ab...@igalia.com Date 2018-10-31 14:04:07 -0700 (Wed, 31 Oct 2018) Log Message [MSE] WebKit tests: Use fixed point in makeASample() https://bugs.webkit.org/show_bug.cgi?id=191128 Reviewed by Jer Noble. This patch modifies the utility function makeASample() so as to accept time values in arbitrary time scales. Previously makeASample() accepted optionally a time scale, but still required to receive all time values as seconds, therefore requiring a division at call time in order to use the function, which could cause rounding errors (see https://bugs.webkit.org/show_bug.cgi?id=190085#c20). * media/media-source/media-source-append-acb-no-frame-lost-expected.txt: * media/media-source/media-source-append-acb-no-frame-lost.html: * media/media-source/media-source-append-buffer-with-append-window.html: * media/media-source/media-source-append-media-segment-without-init.html: * media/media-source/media-source-append-nonsync-sample-after-abort.html: * media/media-source/media-source-append-out-of-order.html: * media/media-source/media-source-append-overlapping-dts-expected.txt: * media/media-source/media-source-append-overlapping-dts.html: * media/media-source/media-source-canplaythrough.html: * media/media-source/media-source-duplicate-seeked.html: * media/media-source/media-source-duration-after-append.html: * media/media-source/media-source-end-of-stream-buffered.html: * media/media-source/media-source-end-of-stream-readyState.html: * media/media-source/media-source-fastseek.html: * media/media-source/media-source-fudge-factor.html: * media/media-source/media-source-monitor-source-buffers.html: * media/media-source/media-source-overlapping-append-buffered.html: * media/media-source/media-source-overlapping-append-expected.txt: * media/media-source/media-source-overlapping-append.html: * media/media-source/media-source-overlapping-decodetime-expected.txt: * media/media-source/media-source-overlapping-decodetime.html: * media/media-source/media-source-play.html: * media/media-source/media-source-range-end-frame-not-removed-expected.txt: * media/media-source/media-source-range-end-frame-not-removed.html: * media/media-source/media-source-range-start-frame-replaced-expected.txt: * media/media-source/media-source-range-start-frame-replaced.html: * media/media-source/media-source-remove-decodeorder-crash.html: * media/media-source/media-source-remove-too-much.html: * media/media-source/media-source-remove.html: * media/media-source/media-source-restrictions.html: * media/media-source/media-source-sample-wrong-track-id.html: * media/media-source/media-source-seek-back-expected.txt: * media/media-source/media-source-seek-back.html: * media/media-source/media-source-seek-complete.html: * media/media-source/media-source-sequence-timestamps-expected.txt: * media/media-source/media-source-sequence-timestamps.html: * media/media-source/media-source-small-gap.html: * media/media-source/media-source-timeoffset-expected.txt: * media/media-source/media-source-timeoffset.html: * media/media-source/media-source-timestampoffset-rounding-error.html: * media/media-source/media-source-timestampoffset-then-zero-expected.txt: * media/media-source/media-source-timestampoffset-then-zero.html: * media/media-source/media-source-video-playback-quality.html: * media/media-source/mock-media-source.js: (makeASample): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/media-source/media-source-append-acb-no-frame-lost-expected.txt trunk/LayoutTests/media/media-source/media-source-append-acb-no-frame-lost.html trunk/LayoutTests/media/media-source/media-source-append-buffer-with-append-window.html trunk/LayoutTests/media/media-source/media-source-append-media-segment-without-init.html trunk/LayoutTests/media/media-source/media-source-append-nonsync-sample-after-abort.html trunk/LayoutTests/media/media-source/media-source-append-out-of-order.html trunk/LayoutTests/media/media-source/media-source-append-overlapping-dts-expected.txt trunk/LayoutTests/media/media-source/media-source-append-overlapping-dts.html trunk/LayoutTests/media/media-source/media-source-canplaythrough.html trunk/LayoutTests/media/media-source/media-source-duplicate-seeked.html trunk/LayoutTests/media/media-source/media-source-duration-after-append.html trunk/LayoutTests/media/media-source/media-source-end-of-stream-buffered.html trunk/LayoutTests/media/media-source/media-source-end-of-stream-readyState.html trunk/LayoutTests/media/media-source/media-source-fastseek.html trunk/LayoutTests/media/media-source/media-source-fudge-factor.html trunk/LayoutTests/media/media-source/media-source-monitor-source-buffers.html trunk/LayoutTests/media/media-source/media-source-overlapping-append-buffered.html trunk/LayoutTests/media/media-source/media-source-overlapping-append-expected.txt trunk/LayoutTests/media/media-source/media-source-overlapping-append.html
[webkit-changes] [237650] trunk
Title: [237650] trunk
Revision 237650
Author commit-qu...@webkit.org
Date 2018-10-31 13:26:57 -0700 (Wed, 31 Oct 2018)
Log Message
MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778
Patch by YUHAN WU on 2018-10-31
Reviewed by Youenn Fablet.
Source/WebCore:
Add a include to fix the unified build error.
No tests since no new functionality.
* Modules/webgpu/WebGPUDevice.cpp:
LayoutTests:
Increase the timer of recording to 2 seconds until we support timeslice in order to reduce flakiness.
* http/wpt/mediarecorder/MediaRecorder-dataavailable.html:
* http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-dataavailable.html
trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (237649 => 237650)
--- trunk/LayoutTests/ChangeLog 2018-10-31 20:23:38 UTC (rev 237649)
+++ trunk/LayoutTests/ChangeLog 2018-10-31 20:26:57 UTC (rev 237650)
@@ -1,3 +1,16 @@
+2018-10-31 YUHAN WU
+
+MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
+https://bugs.webkit.org/show_bug.cgi?id=190778
+
+
+Reviewed by Youenn Fablet.
+
+Increase the timer of recording to 2 seconds until we support timeslice in order to reduce flakiness.
+
+* http/wpt/mediarecorder/MediaRecorder-dataavailable.html:
+* http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:
+
2018-10-31 Zach Li
Add credit card autofill button
Modified: trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-dataavailable.html (237649 => 237650)
--- trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-dataavailable.html 2018-10-31 20:23:38 UTC (rev 237649)
+++ trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-dataavailable.html 2018-10-31 20:26:57 UTC (rev 237650)
@@ -44,7 +44,7 @@
drawSomethingOnCanvas();
setTimeout(() => {
recorder.stop();
-}, 500)
+}, 2000)
}, 'MediaRecorder will fire a dataavailable event with a blob data for a video-only stream when stop() is called');
async_test(t => {
@@ -65,7 +65,7 @@
setTimeout(() => {
recorder.stop();
osc.stop();
-}, 500);
+}, 2000);
}, 'MediaRecorder will fire a dataavailable event with a blob data for a audio-only stream when stop() is called');
async_test(t => {
@@ -93,7 +93,7 @@
setTimeout(() => {
recorder.stop();
osc.stop();
-}, 500);
+}, 2000);
}, 'MediaRecorder will fire a dataavailable event with a blob data for a video-audio stream when stop() is called');
Modified: trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html (237649 => 237650)
--- trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html 2018-10-31 20:23:38 UTC (rev 237649)
+++ trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html 2018-10-31 20:26:57 UTC (rev 237650)
@@ -41,7 +41,7 @@
drawSomethingOnCanvas();
setTimeout(() => {
recorder.stop();
-}, 500);
+}, 2000);
}, 'MediaRecorder will fire a dataavailable event which only contains video buffers for a video-only stream when stop() is called');
async_test(t => {
@@ -66,7 +66,7 @@
setTimeout(() => {
recorder.stop();
osc.stop();
-}, 500);
+}, 2000);
}, 'MediaRecorder will fire a dataavailable event which only contains audio buffers for a audio-only stream when stop() is called');
async_test(t => {
@@ -98,7 +98,7 @@
setTimeout(() => {
recorder.stop();
osc.stop();
-}, 500);
+}, 2000);
}, 'MediaRecorder will fire a dataavailable event which only contains both video and audio buffers when stop() is called');
Modified: trunk/Source/WebCore/ChangeLog (237649 => 237650)
--- trunk/Source/WebCore/ChangeLog 2018-10-31 20:23:38 UTC (rev 237649)
+++ trunk/Source/WebCore/ChangeLog 2018-10-31 20:26:57 UTC (rev 237650)
@@ -1,3 +1,17 @@
+2018-10-31 YUHAN WU
+
+MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
+https://bugs.webkit.org/show_bug.cgi?id=190778
+
+
+Reviewed by Youenn Fablet.
+
+Add a include to fix the unified build error.
+
+No tests since no new functionality.
+
+* Modules/webgpu/WebGPUDevice.cpp:
+
2018-10-26 Jer Noble
[EME][Cocoa] Cannot play unmuxed video and audio fMP4 streams encrypted with different keys via MSE
Modified:
[webkit-changes] [237649] trunk/Source/WebCore
Title: [237649] trunk/Source/WebCore Revision 237649 Author jer.no...@apple.com Date 2018-10-31 13:23:38 -0700 (Wed, 31 Oct 2018) Log Message [EME][Cocoa] Cannot play unmuxed video and audio fMP4 streams encrypted with different keys via MSE https://bugs.webkit.org/show_bug.cgi?id=190946 Reviewed by Eric Carlson. Use separate AVContentKeySessions per CDMInstanceSession (rather than one AVContentKeySession per CDMInstance). - Add a mechanism for sending a message out from platform/CDMInstance to MediaKeySession without requiring MediaKeySession to send a callback first. - Move all the AVContentKeySession delegate methods from CDMInstanceFairPlayStreamingAVFObjC to CDMInstanceSessionFairPlayStreamingAVFObjC. - Add a mechanism for requesting the correct CDMInstanceSession for a given KeyID. - Support key renewal through a "renew" message. - Remember the keyID in SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID() and ask for the correct CDMInstanceSession for that keyID in attemptToDecrypt(). - Pass the CDMInstance down from MediaPlayerPrivateMediaSourceAVFObjC -> SourceBufferPrivateAVFObjC. * Modules/encryptedmedia/MediaKeySession.cpp: (WebCore::MediaKeySession::sendMessage): * Modules/encryptedmedia/MediaKeySession.h: * platform/encryptedmedia/CDMInstanceSession.h: * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (-[WebCoreFPSContentKeySessionDelegate initWithParent:]): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::createSession): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForKeyIDs const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::CDMInstanceSessionFairPlayStreamingAVFObjC): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::~CDMInstanceSessionFairPlayStreamingAVFObjC): (WebCore::keyIDsForRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyIDs): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::closeSession): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didFailToProvideRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestDidSucceed): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::nextRequest): (WebCore::requestStatusToCDMStatus): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession): * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): (WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceAttached): (WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceDetached): (WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance): * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceAttached): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceDetached): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::attemptToDecryptWithInstance): (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::waitingForKey const): * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: * platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: (WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer): (WebCore::MediaSourcePrivateAVFObjC::cdmInstanceAttached): (WebCore::MediaSourcePrivateAVFObjC::cdmInstanceDetached): (WebCore::MediaSourcePrivateAVFObjC::attemptToDecryptWithInstance): (WebCore::MediaSourcePrivateAVFObjC::waitingForKey const): (WebCore::MediaSourcePrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged): * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID): (WebCore::SourceBufferPrivateAVFObjC::destroyParser): (WebCore::SourceBufferPrivateAVFObjC::setCDMInstance):
[webkit-changes] [237648] trunk/Source/WebKit
Title: [237648] trunk/Source/WebKit
Revision 237648
Author wenson_hs...@apple.com
Date 2018-10-31 13:16:49 -0700 (Wed, 31 Oct 2018)
Log Message
API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
https://bugs.webkit.org/show_bug.cgi?id=191114
Reviewed by Dean Jackson.
On macOS 10.12, we don't attempt secure archival at all because SECURE_ARCHIVER_API is turned off, and on macOS
10.14, NSFileWrapper supports secure coding. However, on macOS 10.13, SECURE_ARCHIVER_API is on despite
NSFileWrapper not being securely codable, so we're unable to serialize attachment data.
To fix this, we only use the secure archiver on ≥ macOS 10.14 and ≥ iOS 12.
* UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
(API::Attachment::createSerializedRepresentation const):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (237647 => 237648)
--- trunk/Source/WebKit/ChangeLog 2018-10-31 20:08:43 UTC (rev 237647)
+++ trunk/Source/WebKit/ChangeLog 2018-10-31 20:16:49 UTC (rev 237648)
@@ -1,3 +1,20 @@
+2018-10-31 Wenson Hsieh
+
+API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
+https://bugs.webkit.org/show_bug.cgi?id=191114
+
+
+Reviewed by Dean Jackson.
+
+On macOS 10.12, we don't attempt secure archival at all because SECURE_ARCHIVER_API is turned off, and on macOS
+10.14, NSFileWrapper supports secure coding. However, on macOS 10.13, SECURE_ARCHIVER_API is on despite
+NSFileWrapper not being securely codable, so we're unable to serialize attachment data.
+
+To fix this, we only use the secure archiver on ≥ macOS 10.14 and ≥ iOS 12.
+
+* UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
+(API::Attachment::createSerializedRepresentation const):
+
2018-10-31 Zach Li
Add credit card autofill button
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm (237647 => 237648)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm 2018-10-31 20:08:43 UTC (rev 237647)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm 2018-10-31 20:16:49 UTC (rev 237648)
@@ -36,6 +36,8 @@
#endif
#import
+#define CAN_SECURELY_ARCHIVE_FILE_WRAPPER (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 12)
+
namespace API {
static WTF::String mimeTypeInferredFromFileExtension(const API::Attachment& attachment)
@@ -132,7 +134,12 @@
if (!m_fileWrapper || !m_webPage)
return nullptr;
+#if CAN_SECURELY_ARCHIVE_FILE_WRAPPER
NSData *serializedData = securelyArchivedDataWithRootObject(m_fileWrapper.get());
+#else
+NSData *serializedData = insecurelyArchivedDataWithRootObject(m_fileWrapper.get());
+#endif
+
if (!serializedData)
return nullptr;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237647] trunk
Title: [237647] trunk Revision 237647 Author commit-qu...@webkit.org Date 2018-10-31 13:08:43 -0700 (Wed, 31 Oct 2018) Log Message Add credit card autofill button https://bugs.webkit.org/show_bug.cgi?id=191051 Patch by Zach Li on 2018-10-31 Reviewed by Wenson Hsieh. Source/WebCore: Test: fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): * css/html.css: (input::-webkit-credit-card-auto-fill-button): Add credit card autofill button. (input::-webkit-credit-card-auto-fill-button:hover): (input::-webkit-credit-card-auto-fill-button:active): * html/HTMLTextFormControlElement.h: * html/TextFieldInputType.cpp: (WebCore::autoFillButtonTypeToAccessibilityLabel): (WebCore::autoFillButtonTypeToAutoFillButtonText): (WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName): (WebCore::isAutoFillButtonTypeChanged): * platform/LocalizedStrings.cpp: (WebCore::AXAutoFillCreditCardLabel): * platform/LocalizedStrings.h: * testing/Internals.cpp: (WebCore::toAutoFillButtonType): (WebCore::toInternalsAutoFillButtonType): * testing/Internals.h: * testing/Internals.idl: Source/WebKit: * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm: (toAutoFillButtonType): (toWKAutoFillButtonType): * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h: Introduce a new button type for credit card autofill. * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (toAutoFillButtonType): (toWKAutoFillButtonType): * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: LayoutTests: * fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added. * fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html: Added. * fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt: * fast/forms/auto-fill-button/last-auto-fill-button-type.html: * platform/ios-simulator/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added. * platform/mac/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.png: Added. * platform/win/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt trunk/LayoutTests/fast/forms/auto-fill-button/last-auto-fill-button-type.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm trunk/Source/WebCore/css/html.css trunk/Source/WebCore/html/HTMLTextFormControlElement.h trunk/Source/WebCore/html/TextFieldInputType.cpp trunk/Source/WebCore/platform/LocalizedStrings.cpp trunk/Source/WebCore/platform/LocalizedStrings.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h Added Paths trunk/LayoutTests/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt trunk/LayoutTests/fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html trunk/LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button/ trunk/LayoutTests/platform/ios-simulator/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt trunk/LayoutTests/platform/mac/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.png trunk/LayoutTests/platform/win/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (237646 => 237647) --- trunk/LayoutTests/ChangeLog 2018-10-31 20:05:46 UTC (rev 237646) +++ trunk/LayoutTests/ChangeLog 2018-10-31 20:08:43 UTC (rev 237647) @@ -1,3 +1,19 @@ +2018-10-31 Zach Li + +Add credit card autofill button +https://bugs.webkit.org/show_bug.cgi?id=191051 + + +Reviewed by Wenson Hsieh. + +* fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added. +* fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html: Added. +* fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt: +* fast/forms/auto-fill-button/last-auto-fill-button-type.html: +* platform/ios-simulator/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added. +* platform/mac/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.png: Added. +* platform/win/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added. + 2018-10-31
[webkit-changes] [237646] trunk/LayoutTests/imported/w3c
Title: [237646] trunk/LayoutTests/imported/w3c Revision 237646 Author cdu...@apple.com Date 2018-10-31 13:05:46 -0700 (Wed, 31 Oct 2018) Log Message Resync XHR Web Platform Tests from upstream 44dd29fb0d https://bugs.webkit.org/show_bug.cgi?id=191116 Reviewed by Youenn Fablet. * web-platform-tests/xhr/getallresponseheaders-expected.txt: * web-platform-tests/xhr/getallresponseheaders.htm: * web-platform-tests/xhr/getresponseheader.any-expected.txt: * web-platform-tests/xhr/getresponseheader.any.js: (forEach.testValues.async_test.t.client.onload.t.step_func_done): (async_test.t.client.onload.t.step_func_done): Deleted. * web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: * web-platform-tests/xhr/resources/header-content-length-twice.asis: Added. * web-platform-tests/xhr/resources/headers-double-empty.asis: Added. * web-platform-tests/xhr/resources/headers-some-are-empty.asis: Added. * web-platform-tests/xhr/resources/w3c-import.log: * web-platform-tests/xhr/setrequestheader-combining.window-expected.txt: Added. * web-platform-tests/xhr/setrequestheader-combining.window.html: Added. * web-platform-tests/xhr/setrequestheader-combining.window.js: Added. (test): * web-platform-tests/xhr/w3c-import.log: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/getresponseheader.any.js trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/resources/w3c-import.log trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/w3c-import.log Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/resources/header-content-length-twice.asis trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/resources/headers-double-empty.asis trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/resources/headers-some-are-empty.asis trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/setrequestheader-combining.window-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/setrequestheader-combining.window.html trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/setrequestheader-combining.window.js Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (237645 => 237646) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-31 18:44:11 UTC (rev 237645) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-31 20:05:46 UTC (rev 237646) @@ -1,3 +1,27 @@ +2018-10-31 Chris Dumez + +Resync XHR Web Platform Tests from upstream 44dd29fb0d +https://bugs.webkit.org/show_bug.cgi?id=191116 + +Reviewed by Youenn Fablet. + +* web-platform-tests/xhr/getallresponseheaders-expected.txt: +* web-platform-tests/xhr/getallresponseheaders.htm: +* web-platform-tests/xhr/getresponseheader.any-expected.txt: +* web-platform-tests/xhr/getresponseheader.any.js: +(forEach.testValues.async_test.t.client.onload.t.step_func_done): +(async_test.t.client.onload.t.step_func_done): Deleted. +* web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: +* web-platform-tests/xhr/resources/header-content-length-twice.asis: Added. +* web-platform-tests/xhr/resources/headers-double-empty.asis: Added. +* web-platform-tests/xhr/resources/headers-some-are-empty.asis: Added. +* web-platform-tests/xhr/resources/w3c-import.log: +* web-platform-tests/xhr/setrequestheader-combining.window-expected.txt: Added. +* web-platform-tests/xhr/setrequestheader-combining.window.html: Added. +* web-platform-tests/xhr/setrequestheader-combining.window.js: Added. +(test): +* web-platform-tests/xhr/w3c-import.log: + 2018-10-31 YUHAN WU MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt (237645 => 237646) --- trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt 2018-10-31 18:44:11 UTC (rev 237645) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt 2018-10-31 20:05:46 UTC (rev 237646) @@ -3,4 +3,7 @@ PASS XMLHttpRequest: getAllResponseHeaders() 1 PASS XMLHttpRequest: getAllResponseHeaders() 2 PASS XMLHttpRequest: getAllResponseHeaders() 3 +PASS XMLHttpRequest: getAllResponseHeaders() 4 +FAIL XMLHttpRequest: getAllResponseHeaders() 5 assert_equals: expected "heya: , \v\f, 1, , , 2\r\n" but got "heya: , , 1, , , 2\r\n" +PASS XMLHttpRequest: getAllResponseHeaders() 6 Modified:
[webkit-changes] [237645] trunk/Source/JavaScriptCore
Title: [237645] trunk/Source/_javascript_Core Revision 237645 Author tzaga...@apple.com Date 2018-10-31 11:44:11 -0700 (Wed, 31 Oct 2018) Log Message Adjust inlining threshold for new bytecode format https://bugs.webkit.org/show_bug.cgi?id=191115 Reviewed by Saam Barati. The new format reduced the number of operands for many opcodes, which changed inlining decisions and impacted performance negatively. * runtime/Options.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/Options.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (237644 => 237645) --- trunk/Source/_javascript_Core/ChangeLog 2018-10-31 18:25:54 UTC (rev 237644) +++ trunk/Source/_javascript_Core/ChangeLog 2018-10-31 18:44:11 UTC (rev 237645) @@ -1,5 +1,17 @@ 2018-10-31 Tadeu Zagallo +Adjust inlining threshold for new bytecode format +https://bugs.webkit.org/show_bug.cgi?id=191115 + +Reviewed by Saam Barati. + +The new format reduced the number of operands for many opcodes, which +changed inlining decisions and impacted performance negatively. + +* runtime/Options.h: + +2018-10-31 Tadeu Zagallo + REGRESSION(r237547): Exception handlers should be aware of wide opcodes https://bugs.webkit.org/show_bug.cgi?id=191108 Modified: trunk/Source/_javascript_Core/runtime/Options.h (237644 => 237645) --- trunk/Source/_javascript_Core/runtime/Options.h 2018-10-31 18:25:54 UTC (rev 237644) +++ trunk/Source/_javascript_Core/runtime/Options.h 2018-10-31 18:44:11 UTC (rev 237645) @@ -303,7 +303,7 @@ \ v(unsigned, maximumOptimizationCandidateInstructionCount, 10, Normal, nullptr) \ \ -v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 190, Normal, nullptr) \ +v(unsigned, maximumFunctionForCallInlineCandidateInstructionCount, 120, Normal, nullptr) \ v(unsigned, maximumFunctionForClosureCallInlineCandidateInstructionCount, 100, Normal, nullptr) \ v(unsigned, maximumFunctionForConstructInlineCandidateInstructionCount, 100, Normal, nullptr) \ \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237644] trunk
Title: [237644] trunk
Revision 237644
Author drou...@apple.com
Date 2018-10-31 11:25:54 -0700 (Wed, 31 Oct 2018)
Log Message
Web Inspector: Audit: show metadata for results
https://bugs.webkit.org/show_bug.cgi?id=190853
Reviewed by Brian Burg.
Source/WebInspectorUI:
* UserInterface/Models/AuditTestCase.js:
(WI.AuditTestCase.prototype.async run):
Capture timestamps around the `RunetimeAgent.evaluate` call, as well as the URL of the page.
* UserInterface/Models/AuditTestCaseResult.js:
(WI.AuditTestCaseResult):
(WI.AuditTestCaseResult.fromPayload):
(WI.AuditTestCaseResult.prototype.get metadata): Added.
(WI.AuditTestCaseResult.prototype.toJSON):
* UserInterface/Views/AuditTestCaseContentView.js:
(WI.AuditTestCaseContentView.prototype.initialLayout):
(WI.AuditTestCaseContentView.prototype.layout):
* UserInterface/Views/AuditTestCaseContentView.css:
(.content-view.audit-test-case > header h1): Added.
(.content-view.audit-test-case > header h1 > img): Added.
(.content-view.audit-test-case > header > .metadata): Added.
(.content-view.audit-test-case > header > .metadata > .source > time): Added.
(.content-view.audit-test-case > header > .metadata > .source > a): Added.
(.content-view.audit-test-case > header > .metadata > .duration): Added.
(.content-view.audit-test-case > header > h1): Deleted.
(.content-view.audit-test-case > header > h1 > img): Deleted.
Display any metadata information where the `WI.ScopeBar` is for `WI.AuditTestGroupContentView`s.
* UserInterface/Views/AuditTestContentView.css:
(.content-view.audit-test > header):
(.content-view.audit-test > header > .information): Added.
* UserInterface/Views/AuditTestGroupContentView.css:
(.content-view.audit-test-group > header):
(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .information): Deleted.
Move common CSS rules to common parent class.
* UserInterface/Base/Utilities.js:
LayoutTests:
* inspector/model/auditTestCaseResult-expected.txt:
* inspector/model/auditTestCaseResult.html:
* inspector/model/auditTestGroupResult-expected.txt:
* inspector/model/auditTestGroupResult.html:
* inspector/unit-tests/string-utilities-expected.txt:
* inspector/unit-tests/string-utilities.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/model/auditTestCaseResult-expected.txt
trunk/LayoutTests/inspector/model/auditTestCaseResult.html
trunk/LayoutTests/inspector/model/auditTestGroupResult-expected.txt
trunk/LayoutTests/inspector/model/auditTestGroupResult.html
trunk/LayoutTests/inspector/unit-tests/string-utilities-expected.txt
trunk/LayoutTests/inspector/unit-tests/string-utilities.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js
trunk/Source/WebInspectorUI/UserInterface/Models/AuditTestCase.js
trunk/Source/WebInspectorUI/UserInterface/Models/AuditTestCaseResult.js
trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.css
trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestCaseContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.css
trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css
Diff
Modified: trunk/LayoutTests/ChangeLog (237643 => 237644)
--- trunk/LayoutTests/ChangeLog 2018-10-31 17:26:49 UTC (rev 237643)
+++ trunk/LayoutTests/ChangeLog 2018-10-31 18:25:54 UTC (rev 237644)
@@ -1,3 +1,18 @@
+2018-10-31 Devin Rousso
+
+Web Inspector: Audit: show metadata for results
+https://bugs.webkit.org/show_bug.cgi?id=190853
+
+
+Reviewed by Brian Burg.
+
+* inspector/model/auditTestCaseResult-expected.txt:
+* inspector/model/auditTestCaseResult.html:
+* inspector/model/auditTestGroupResult-expected.txt:
+* inspector/model/auditTestGroupResult.html:
+* inspector/unit-tests/string-utilities-expected.txt:
+* inspector/unit-tests/string-utilities.html:
+
2018-10-31 Eric Carlson
[MediaStream] Don't reveal device IDs until the user has granted permission to capture
Modified: trunk/LayoutTests/inspector/model/auditTestCaseResult-expected.txt (237643 => 237644)
--- trunk/LayoutTests/inspector/model/auditTestCaseResult-expected.txt 2018-10-31 17:26:49 UTC (rev 237643)
+++ trunk/LayoutTests/inspector/model/auditTestCaseResult-expected.txt 2018-10-31 18:25:54 UTC (rev 237644)
@@ -52,6 +52,11 @@
"errors": [
"validWithValidSubOptionals test result error"
]
+ },
+ "metadata": {
+"startTimestamp": "0001-01-01T00:00:00.000Z",
+"endTimestamp": "0002-01-01T00:00:00.000Z",
+"url": "validWithValidSubOptionals test result url"
}
}
Modified: trunk/LayoutTests/inspector/model/auditTestCaseResult.html (237643 => 237644)
--- trunk/LayoutTests/inspector/model/auditTestCaseResult.html 2018-10-31 17:26:49 UTC (rev 237643)
+++ trunk/LayoutTests/inspector/model/auditTestCaseResult.html 2018-10-31 18:25:54 UTC (rev 237644)
[webkit-changes] [237643] trunk
Title: [237643] trunk Revision 237643 Author eric.carl...@apple.com Date 2018-10-31 10:26:49 -0700 (Wed, 31 Oct 2018) Log Message [MediaStream] Don't reveal device IDs until the user has granted permission to capture https://bugs.webkit.org/show_bug.cgi?id=191112 Reviewed by Youenn Fablet. Source/WebCore: No new tests, existing tests updated. * Modules/mediastream/MediaDevicesRequest.cpp: (WebCore::MediaDevicesRequest::start): Don't reveal device ID or group ID until the user has granted permssion to capture. LayoutTests: * TestExpectations: Skip http/tests/media/media-stream/enumerate-devices-source-id-persistent.html and http/tests/media/media-stream/enumerate-devices-source-id.html for now, they don't make sense with these changes and will be updated to pass in a future patch. * fast/mediastream/MediaStreamTrack-getCapabilities.html: * fast/mediastream/get-user-media-device-id-expected.txt: * fast/mediastream/get-user-media-device-id.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html trunk/LayoutTests/fast/mediastream/get-user-media-device-id-expected.txt trunk/LayoutTests/fast/mediastream/get-user-media-device-id.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp Diff Modified: trunk/LayoutTests/ChangeLog (237642 => 237643) --- trunk/LayoutTests/ChangeLog 2018-10-31 17:19:27 UTC (rev 237642) +++ trunk/LayoutTests/ChangeLog 2018-10-31 17:26:49 UTC (rev 237643) @@ -1,3 +1,18 @@ +2018-10-31 Eric Carlson + +[MediaStream] Don't reveal device IDs until the user has granted permission to capture +https://bugs.webkit.org/show_bug.cgi?id=191112 + + +Reviewed by Youenn Fablet. + +* TestExpectations: Skip http/tests/media/media-stream/enumerate-devices-source-id-persistent.html +and http/tests/media/media-stream/enumerate-devices-source-id.html for now, they don't make sense +with these changes and will be updated to pass in a future patch. +* fast/mediastream/MediaStreamTrack-getCapabilities.html: +* fast/mediastream/get-user-media-device-id-expected.txt: +* fast/mediastream/get-user-media-device-id.html: + 2018-10-31 YUHAN WU MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called Modified: trunk/LayoutTests/TestExpectations (237642 => 237643) --- trunk/LayoutTests/TestExpectations 2018-10-31 17:19:27 UTC (rev 237642) +++ trunk/LayoutTests/TestExpectations 2018-10-31 17:26:49 UTC (rev 237643) @@ -2904,3 +2904,7 @@ fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext.html [ Skip ] fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html [ Skip ] fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element.html [ Skip ] + +# FIXME: The behavior of navigator.mediaDevices.enumerateDevices is in flux, skip these tests for now. +http/tests/media/media-stream/enumerate-devices-source-id-persistent.html [ Skip ] +http/tests/media/media-stream/enumerate-devices-source-id.html [ Skip ] Modified: trunk/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html (237642 => 237643) --- trunk/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html 2018-10-31 17:19:27 UTC (rev 237642) +++ trunk/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html 2018-10-31 17:26:49 UTC (rev 237643) @@ -2,11 +2,13 @@
[webkit-changes] [237642] trunk
Title: [237642] trunk Revision 237642 Author commit-qu...@webkit.org Date 2018-10-31 10:19:27 -0700 (Wed, 31 Oct 2018) Log Message MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called https://bugs.webkit.org/show_bug.cgi?id=190778 Patch by YUHAN WU on 2018-10-31 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: * web-platform-tests/mediacapture-record/BlobEvent-constructor-expected.txt: * web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution-expected.txt: Added. * web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html: Added. * web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt: * web-platform-tests/mediacapture-record/MediaRecorder-stop.html: * web-platform-tests/mediacapture-record/support/MediaRecorder-iframe.html: Added. Source/WebCore: Implement _javascript_ dispatch event dataavailable and _javascript_ exposed method stop(). Implement a mock string as the output buffer of MediaRecorder. Remove the declaration of timecode in BlobEvent since it has not been implemented in MediaRecorder and MediaRecorderPrivate. Tests: http/wpt/mediarecorder/MediaRecorder-dataavailable.html http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html imported/w3c/web-platform-tests/mediacapture-record/support/MediaRecorder-iframe.html * CMakeLists.txt: * Modules/mediarecorder/BlobEvent.cpp: Added. (WebCore::BlobEvent::create): (WebCore::BlobEvent::BlobEvent): (WebCore::BlobEvent::eventInterface const): * Modules/mediarecorder/BlobEvent.h: * Modules/mediarecorder/BlobEvent.idl: * Modules/mediarecorder/MediaRecorder.cpp: (WebCore::MediaRecorder::MediaRecorder): (WebCore::MediaRecorder::~MediaRecorder): (WebCore::MediaRecorder::stop): (WebCore::MediaRecorder::startRecording): (WebCore::MediaRecorder::stopRecording): (WebCore::MediaRecorder::stopRecordingInternal): (WebCore::MediaRecorder::didAddOrRemoveTrack): (WebCore::MediaRecorder::trackEnded): (WebCore::MediaRecorder::sampleBufferUpdated): (WebCore::MediaRecorder::audioSamplesAvailable): (WebCore::MediaRecorder::scheduleDeferredTask): * Modules/mediarecorder/MediaRecorder.h: * Modules/mediarecorder/MediaRecorder.idl: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * dom/EventNames.h: * dom/EventNames.in: * platform/mediarecorder/MediaRecorderPrivate.h: Added. * platform/mediarecorder/MediaRecorderPrivateMock.cpp: Added. (WebCore::MediaRecorderPrivateMock::sampleBufferUpdated): (WebCore::MediaRecorderPrivateMock::audioSamplesAvailable): (WebCore::MediaRecorderPrivateMock::generateMockString): (WebCore::MediaRecorderPrivateMock::fetchData): * platform/mediarecorder/MediaRecorderPrivateMock.h: Added. LayoutTests: These tests are used to check if MediaRecorder can generate both video and audio buffers through mock source. * http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt: Added. * http/wpt/mediarecorder/MediaRecorder-dataavailable.html: Added. * http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt: Added. * http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html: Added. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/BlobEvent-constructor-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop.html trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediarecorder/BlobEvent.h trunk/Source/WebCore/Modules/mediarecorder/BlobEvent.idl trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.h trunk/Source/WebCore/Modules/mediarecorder/MediaRecorder.idl trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/EventNames.h trunk/Source/WebCore/dom/EventNames.in Added Paths trunk/LayoutTests/http/wpt/mediarecorder/ trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-dataavailable.html trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt trunk/LayoutTests/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html trunk/LayoutTests/imported/w3c/web-platform-tests/mediacapture-record/support/
[webkit-changes] [237641] trunk
Title: [237641] trunk
Revision 237641
Author tzaga...@apple.com
Date 2018-10-31 09:39:06 -0700 (Wed, 31 Oct 2018)
Log Message
REGRESSION(r237547): Exception handlers should be aware of wide opcodes
https://bugs.webkit.org/show_bug.cgi?id=191108
Reviewed by Saam Barati.
JSTests:
* stress/wide-op_catch.js: Added.
(catch):
Source/_javascript_Core:
When linking the handler, we need to check whether the target op_catch is
wide or narrow in order to chose the right code pointer for the handler.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
Added Paths
trunk/JSTests/stress/wide-op_catch.js
Diff
Modified: trunk/JSTests/ChangeLog (237640 => 237641)
--- trunk/JSTests/ChangeLog 2018-10-31 16:33:01 UTC (rev 237640)
+++ trunk/JSTests/ChangeLog 2018-10-31 16:39:06 UTC (rev 237641)
@@ -1,3 +1,14 @@
+2018-10-31 Tadeu Zagallo
+
+REGRESSION(r237547): Exception handlers should be aware of wide opcodes
+https://bugs.webkit.org/show_bug.cgi?id=191108
+
+
+Reviewed by Saam Barati.
+
+* stress/wide-op_catch.js: Added.
+(catch):
+
2018-10-29 Mark Lam
Correctly detect string overflow when using the 'Function' constructor.
Added: trunk/JSTests/stress/wide-op_catch.js (0 => 237641)
--- trunk/JSTests/stress/wide-op_catch.js (rev 0)
+++ trunk/JSTests/stress/wide-op_catch.js 2018-10-31 16:39:06 UTC (rev 237641)
@@ -0,0 +1,257 @@
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try { } catch (e) { }
+try {
[webkit-changes] [237639] trunk
Title: [237639] trunk
Revision 237639
Author cdu...@apple.com
Date 2018-10-31 09:23:27 -0700 (Wed, 31 Oct 2018)
Log Message
[PSON] When process-swapping for a POST request the HTTP body gets dropped
https://bugs.webkit.org/show_bug.cgi?id=191046
Reviewed by Alex Christensen.
Source/WebKit:
For performance reasons, the ResourceRequest IPC encoder does not encode the request's HTTP body (aka form data).
When we decide to process-swap for a POST request in WebPageProxy::decidePolicyForNavigationAction(), the request
we pass the new WebProcess thus no longer has a HTTP body and the load will likely fail in the new process.
To address the issue, we now pass the request body along with the request when sending the DecidePolicyForNavigationActionAsync
/ DecidePolicyForNavigationActionSync IPC from the WebProcess to the UIProcess. No action is needed for the
LoadRequest IPC to the new WebProcess since the LoadParameters' IPC encoder takes care of encoding the request's
body already.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
LayoutTests:
Add layout test coverage.
* http/tests/misc/form-post-textplain-cross-site-expected.txt: Added.
* http/tests/misc/form-post-textplain-cross-site.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/misc/form-post-textplain-expected.txt
trunk/LayoutTests/http/tests/misc/resources/form-post-textplain.php
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
Added Paths
trunk/LayoutTests/http/tests/misc/form-post-textplain-cross-site-expected.txt
trunk/LayoutTests/http/tests/misc/form-post-textplain-cross-site.html
Diff
Modified: trunk/LayoutTests/ChangeLog (237638 => 237639)
--- trunk/LayoutTests/ChangeLog 2018-10-31 16:09:07 UTC (rev 237638)
+++ trunk/LayoutTests/ChangeLog 2018-10-31 16:23:27 UTC (rev 237639)
@@ -1,3 +1,16 @@
+2018-10-31 Chris Dumez
+
+[PSON] When process-swapping for a POST request the HTTP body gets dropped
+https://bugs.webkit.org/show_bug.cgi?id=191046
+
+
+Reviewed by Alex Christensen.
+
+Add layout test coverage.
+
+* http/tests/misc/form-post-textplain-cross-site-expected.txt: Added.
+* http/tests/misc/form-post-textplain-cross-site.html: Added.
+
2018-10-30 David Kilzer
XSLTProcessor should limit max transform depth
Added: trunk/LayoutTests/http/tests/misc/form-post-textplain-cross-site-expected.txt (0 => 237639)
--- trunk/LayoutTests/http/tests/misc/form-post-textplain-cross-site-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/misc/form-post-textplain-cross-site-expected.txt 2018-10-31 16:23:27 UTC (rev 237639)
@@ -0,0 +1,5 @@
+This test makes sure that forms POSTed with a content-type of text/plain actually send data in text/plain
+
+SUCCESS: Content-type is text/plain.
+
+SUCCESS
Added: trunk/LayoutTests/http/tests/misc/form-post-textplain-cross-site.html (0 => 237639)
--- trunk/LayoutTests/http/tests/misc/form-post-textplain-cross-site.html (rev 0)
+++ trunk/LayoutTests/http/tests/misc/form-post-textplain-cross-site.html 2018-10-31 16:23:27 UTC (rev 237639)
@@ -0,0 +1,25 @@
+
+
+Regression test for bug 20795 and 100445
+
+
+
+This is a test for https://bugs.webkit.org/show_bug.cgi?id=191046, it makes sure that
+forms POSTed with a content-type of text/plain actually send data in text/plain when cross-site.
+
+
+
+
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+document.f.submit();
+
+
+
Modified: trunk/LayoutTests/http/tests/misc/form-post-textplain-expected.txt (237638 => 237639)
--- trunk/LayoutTests/http/tests/misc/form-post-textplain-expected.txt 2018-10-31 16:09:07 UTC (rev 237638)
+++ trunk/LayoutTests/http/tests/misc/form-post-textplain-expected.txt 2018-10-31 16:23:27 UTC (rev 237639)
@@ -1,4 +1,4 @@
-This is a test for 20795 and 100445, it makes sure that forms POSTed with a content-type of text/plain actually send data in text/plain
+This test makes sure that forms POSTed with a content-type of text/plain actually send data in text/plain
SUCCESS: Content-type is text/plain.
Modified: trunk/LayoutTests/http/tests/misc/resources/form-post-textplain.php (237638 => 237639)
--- trunk/LayoutTests/http/tests/misc/resources/form-post-textplain.php 2018-10-31 16:09:07 UTC (rev 237638)
+++ trunk/LayoutTests/http/tests/misc/resources/form-post-textplain.php 2018-10-31 16:23:27 UTC (rev 237639)
@@
[webkit-changes] [237637] trunk/Source/WebCore
Title: [237637] trunk/Source/WebCore
Revision 237637
Author csaave...@igalia.com
Date 2018-10-31 08:19:24 -0700 (Wed, 31 Oct 2018)
Log Message
[GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
https://bugs.webkit.org/show_bug.cgi?id=191110
Reviewed by Michael Catanzaro.
Covered by existing tests.
Turns out that this method is expected to reject domains that
are not registrable. Also sync with the Mac implementation in
that given domains that are not all ASCII should be returned
back as is. This fixes the remaining Public Suffix API tests.
* platform/soup/PublicSuffixSoup.cpp:
(WebCore::topPrivatelyControlledDomain):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (237636 => 237637)
--- trunk/Source/WebCore/ChangeLog 2018-10-31 15:08:26 UTC (rev 237636)
+++ trunk/Source/WebCore/ChangeLog 2018-10-31 15:19:24 UTC (rev 237637)
@@ -1,3 +1,20 @@
+2018-10-31 Claudio Saavedra
+
+[GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
+https://bugs.webkit.org/show_bug.cgi?id=191110
+
+Reviewed by Michael Catanzaro.
+
+Covered by existing tests.
+
+Turns out that this method is expected to reject domains that
+are not registrable. Also sync with the Mac implementation in
+that given domains that are not all ASCII should be returned
+back as is. This fixes the remaining Public Suffix API tests.
+
+* platform/soup/PublicSuffixSoup.cpp:
+(WebCore::topPrivatelyControlledDomain):
+
2018-10-31 Antti Koivisto
Remove LayerFlushScheduler
Modified: trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp (237636 => 237637)
--- trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp 2018-10-31 15:08:26 UTC (rev 237636)
+++ trunk/Source/WebCore/platform/soup/PublicSuffixSoup.cpp 2018-10-31 15:19:24 UTC (rev 237637)
@@ -45,6 +45,8 @@
{
if (domain.isEmpty())
return String();
+if (!domain.isAllASCII())
+return domain;
String lowercaseDomain = domain.convertToASCIILowercase();
@@ -57,10 +59,10 @@
if (const char* baseDomain = soup_tld_get_base_domain(domainUTF8.data(), ()))
return String::fromUTF8(baseDomain);
-if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_INVALID_HOSTNAME) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NOT_ENOUGH_DOMAINS))
+if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_INVALID_HOSTNAME) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NOT_ENOUGH_DOMAINS) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NO_BASE_DOMAIN))
return String();
-if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_IS_IP_ADDRESS) || g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_NO_BASE_DOMAIN))
+if (g_error_matches(error.get(), SOUP_TLD_ERROR, SOUP_TLD_ERROR_IS_IP_ADDRESS))
return domain;
ASSERT_NOT_REACHED();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237636] trunk/Source
Title: [237636] trunk/Source Revision 237636 Author an...@apple.com Date 2018-10-31 08:08:26 -0700 (Wed, 31 Oct 2018) Log Message Remove LayerFlushScheduler https://bugs.webkit.org/show_bug.cgi?id=191103 Reviewed by Anders Carlsson. Source/WebCore: It is only used in WK1. * SourcesCocoa.txt: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/ca/LayerFlushScheduler.cpp: Removed. * platform/graphics/ca/LayerFlushScheduler.h: Removed. * platform/graphics/ca/LayerFlushSchedulerClient.h: Removed. * platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Removed. Source/WebKitLegacy/mac: Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove all the virtual cruft. * WebView/WebViewData.h: (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted. (): Deleted. * WebView/WebViewData.mm: (currentRunLoop): (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler): (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): (WebViewLayerFlushScheduler::schedule): (WebViewLayerFlushScheduler::invalidate): (WebViewLayerFlushScheduler::layerFlushCallback): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformAppleWin.cmake trunk/Source/WebCore/PlatformMac.cmake trunk/Source/WebCore/SourcesCocoa.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/RuntimeApplicationChecks.h trunk/Source/WebCore/platform/ios/wak/WebCoreThreadInternal.h trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebView/WebViewData.h trunk/Source/WebKitLegacy/mac/WebView/WebViewData.mm Removed Paths trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h trunk/Source/WebCore/platform/graphics/ca/LayerFlushSchedulerClient.h trunk/Source/WebCore/platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (237635 => 237636) --- trunk/Source/WebCore/ChangeLog 2018-10-31 14:21:57 UTC (rev 237635) +++ trunk/Source/WebCore/ChangeLog 2018-10-31 15:08:26 UTC (rev 237636) @@ -1,3 +1,19 @@ +2018-10-31 Antti Koivisto + +Remove LayerFlushScheduler +https://bugs.webkit.org/show_bug.cgi?id=191103 + +Reviewed by Anders Carlsson. + +It is only used in WK1. + +* SourcesCocoa.txt: +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/ca/LayerFlushScheduler.cpp: Removed. +* platform/graphics/ca/LayerFlushScheduler.h: Removed. +* platform/graphics/ca/LayerFlushSchedulerClient.h: Removed. +* platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Removed. + 2018-10-31 Zalan Bujtas Missing from r237634 Modified: trunk/Source/WebCore/PlatformAppleWin.cmake (237635 => 237636) --- trunk/Source/WebCore/PlatformAppleWin.cmake 2018-10-31 14:21:57 UTC (rev 237635) +++ trunk/Source/WebCore/PlatformAppleWin.cmake 2018-10-31 15:08:26 UTC (rev 237636) @@ -92,7 +92,6 @@ page/win/FrameCGWin.cpp platform/graphics/ca/GraphicsLayerCA.cpp -platform/graphics/ca/LayerFlushScheduler.cpp platform/graphics/ca/LayerPool.cpp platform/graphics/ca/PlatformCALayer.cpp platform/graphics/ca/TileController.cpp Modified: trunk/Source/WebCore/PlatformMac.cmake (237635 => 237636) --- trunk/Source/WebCore/PlatformMac.cmake 2018-10-31 14:21:57 UTC (rev 237635) +++ trunk/Source/WebCore/PlatformMac.cmake 2018-10-31 15:08:26 UTC (rev 237636) @@ -256,7 +256,6 @@ platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm platform/graphics/ca/GraphicsLayerCA.cpp -platform/graphics/ca/LayerFlushScheduler.cpp platform/graphics/ca/LayerPool.cpp platform/graphics/ca/PlatformCAAnimation.cpp platform/graphics/ca/PlatformCALayer.cpp @@ -265,7 +264,6 @@ platform/graphics/ca/TileGrid.cpp platform/graphics/ca/TransformationMatrixCA.cpp -platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm Modified: trunk/Source/WebCore/SourcesCocoa.txt (237635 => 237636) --- trunk/Source/WebCore/SourcesCocoa.txt 2018-10-31 14:21:57 UTC (rev 237635) +++ trunk/Source/WebCore/SourcesCocoa.txt 2018-10-31 15:08:26 UTC (rev 237636) @@ -255,7 +255,6 @@ platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm @no-unify platform/graphics/ca/GraphicsLayerCA.cpp -platform/graphics/ca/LayerFlushScheduler.cpp platform/graphics/ca/LayerPool.cpp platform/graphics/ca/PlatformCAAnimation.cpp platform/graphics/ca/PlatformCALayer.cpp @@ -263,7 +262,6 @@ platform/graphics/ca/TileCoverageMap.cpp platform/graphics/ca/TileGrid.cpp platform/graphics/ca/TransformationMatrixCA.cpp
[webkit-changes] [237635] trunk/Source/WebCore
Title: [237635] trunk/Source/WebCore
Revision 237635
Author za...@apple.com
Date 2018-10-31 07:21:57 -0700 (Wed, 31 Oct 2018)
Log Message
Missing from r237634
* layout/inlineformatting/InlineFormattingState.cpp:
(WebCore::Layout::InlineFormattingState::formattingContext):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (237634 => 237635)
--- trunk/Source/WebCore/ChangeLog 2018-10-31 13:51:56 UTC (rev 237634)
+++ trunk/Source/WebCore/ChangeLog 2018-10-31 14:21:57 UTC (rev 237635)
@@ -1,5 +1,12 @@
2018-10-31 Zalan Bujtas
+Missing from r237634
+
+* layout/inlineformatting/InlineFormattingState.cpp:
+(WebCore::Layout::InlineFormattingState::formattingContext):
+
+2018-10-31 Zalan Bujtas
+
[LFC] Do not pass LayoutState& to compute* and layout* functions
https://bugs.webkit.org/show_bug.cgi?id=191100
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.cpp (237634 => 237635)
--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.cpp 2018-10-31 13:51:56 UTC (rev 237634)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.cpp 2018-10-31 14:21:57 UTC (rev 237635)
@@ -47,7 +47,7 @@
std::unique_ptr InlineFormattingState::formattingContext(const Box& formattingContextRoot)
{
ASSERT(formattingContextRoot.establishesInlineFormattingContext());
-return std::make_unique(formattingContextRoot, this);
+return std::make_unique(formattingContextRoot, *this);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237634] trunk/Source/WebCore
Title: [237634] trunk/Source/WebCore Revision 237634 Author za...@apple.com Date 2018-10-31 06:51:56 -0700 (Wed, 31 Oct 2018) Log Message [LFC] Do not pass LayoutState& to compute* and layout* functions https://bugs.webkit.org/show_bug.cgi?id=191100 Reviewed by Antti Koivisto. Reduce noise by removing LayoutState& parameter where possible. * layout/FormattingContext.cpp: (WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const): (WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const): (WebCore::Layout::FormattingContext::computeBorderAndPadding const): (WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const): (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const): (WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const): * layout/FormattingContext.h: * layout/FormattingContextGeometry.cpp: (WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth): * layout/LayoutFormattingState.cpp: (WebCore::Layout::LayoutState::layoutFormattingContextSubtree): * layout/blockformatting/BlockFormattingContext.cpp: (WebCore::Layout::BlockFormattingContext::layout const): (WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const): (WebCore::Layout::BlockFormattingContext::computeStaticPosition const): (WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const): (WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const): (WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const): (WebCore::Layout::BlockFormattingContext::computeFloatingPosition const): (WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const): (WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const): (WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const): (WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const): (WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const): (WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const): * layout/blockformatting/BlockFormattingContext.h: * layout/inlineformatting/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::layout const): (WebCore::Layout::InlineFormattingContext::initializeNewLine const): (WebCore::Layout::InlineFormattingContext::layoutInlineContent const): (WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const): (WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const): (WebCore::Layout::InlineFormattingContext::computeFloatPosition const): (WebCore::Layout::InlineFormattingContext::computeStaticPosition const): (WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const): (WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const): * layout/inlineformatting/InlineFormattingContext.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/FormattingContext.cpp trunk/Source/WebCore/layout/FormattingContext.h trunk/Source/WebCore/layout/FormattingContextGeometry.cpp trunk/Source/WebCore/layout/LayoutFormattingState.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.h Diff Modified: trunk/Source/WebCore/ChangeLog (237633 => 237634) --- trunk/Source/WebCore/ChangeLog 2018-10-31 13:50:05 UTC (rev 237633) +++ trunk/Source/WebCore/ChangeLog 2018-10-31 13:51:56 UTC (rev 237634) @@ -1,5 +1,53 @@ 2018-10-31 Zalan Bujtas +[LFC] Do not pass LayoutState& to compute* and layout* functions +https://bugs.webkit.org/show_bug.cgi?id=191100 + +Reviewed by Antti Koivisto. + +Reduce noise by removing LayoutState& parameter where possible. + +* layout/FormattingContext.cpp: +(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const): +(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const): +(WebCore::Layout::FormattingContext::computeBorderAndPadding const): +(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const): +(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const): +(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const): +* layout/FormattingContext.h: +* layout/FormattingContextGeometry.cpp: +(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth): +* layout/LayoutFormattingState.cpp: +(WebCore::Layout::LayoutState::layoutFormattingContextSubtree): +* layout/blockformatting/BlockFormattingContext.cpp: +(WebCore::Layout::BlockFormattingContext::layout const): +
[webkit-changes] [237633] trunk/Source/WebCore
Title: [237633] trunk/Source/WebCore Revision 237633 Author za...@apple.com Date 2018-10-31 06:50:05 -0700 (Wed, 31 Oct 2018) Log Message [LFC] FormattingContext class should take FormattingState& https://bugs.webkit.org/show_bug.cgi?id=191099 Reviewed by Antti Koivisto. This is in preparation for not passing LayoutState& into every layout functions. FormattingContext has FormattingState now and LayoutState can be acquired through FormattingState. LayoutState <- FormattingState <- FormattingContext * layout/FormattingContext.cpp: (WebCore::Layout::FormattingContext::FormattingContext): (WebCore::Layout::FormattingContext::formattingState const): (WebCore::Layout::FormattingContext::layoutState const): * layout/FormattingContext.h: * layout/FormattingState.cpp: (WebCore::Layout::FormattingState::FormattingState): * layout/FormattingState.h: (WebCore::Layout::FormattingState::layoutState const): * layout/LayoutFormattingState.h: * layout/blockformatting/BlockFormattingContext.cpp: (WebCore::Layout::BlockFormattingContext::BlockFormattingContext): * layout/blockformatting/BlockFormattingContext.h: * layout/blockformatting/BlockFormattingState.cpp: (WebCore::Layout::BlockFormattingState::BlockFormattingState): (WebCore::Layout::BlockFormattingState::formattingContext): (WebCore::Layout::BlockFormattingState::formattingContext const): Deleted. * layout/blockformatting/BlockFormattingState.h: * layout/inlineformatting/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::InlineFormattingContext): * layout/inlineformatting/InlineFormattingContext.h: * layout/inlineformatting/InlineFormattingState.cpp: (WebCore::Layout::InlineFormattingState::InlineFormattingState): (WebCore::Layout::InlineFormattingState::formattingContext): (WebCore::Layout::InlineFormattingState::formattingContext const): Deleted. * layout/inlineformatting/InlineFormattingState.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/FormattingContext.cpp trunk/Source/WebCore/layout/FormattingContext.h trunk/Source/WebCore/layout/FormattingState.cpp trunk/Source/WebCore/layout/FormattingState.h trunk/Source/WebCore/layout/LayoutFormattingState.h trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h trunk/Source/WebCore/layout/blockformatting/BlockFormattingState.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingState.h trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.h trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.cpp trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.h Diff Modified: trunk/Source/WebCore/ChangeLog (237632 => 237633) --- trunk/Source/WebCore/ChangeLog 2018-10-31 13:43:03 UTC (rev 237632) +++ trunk/Source/WebCore/ChangeLog 2018-10-31 13:50:05 UTC (rev 237633) @@ -1,5 +1,43 @@ 2018-10-31 Zalan Bujtas +[LFC] FormattingContext class should take FormattingState& +https://bugs.webkit.org/show_bug.cgi?id=191099 + +Reviewed by Antti Koivisto. + +This is in preparation for not passing LayoutState& into every layout functions. +FormattingContext has FormattingState now and LayoutState can be acquired through FormattingState. +LayoutState <- FormattingState <- FormattingContext + +* layout/FormattingContext.cpp: +(WebCore::Layout::FormattingContext::FormattingContext): +(WebCore::Layout::FormattingContext::formattingState const): +(WebCore::Layout::FormattingContext::layoutState const): +* layout/FormattingContext.h: +* layout/FormattingState.cpp: +(WebCore::Layout::FormattingState::FormattingState): +* layout/FormattingState.h: +(WebCore::Layout::FormattingState::layoutState const): +* layout/LayoutFormattingState.h: +* layout/blockformatting/BlockFormattingContext.cpp: +(WebCore::Layout::BlockFormattingContext::BlockFormattingContext): +* layout/blockformatting/BlockFormattingContext.h: +* layout/blockformatting/BlockFormattingState.cpp: +(WebCore::Layout::BlockFormattingState::BlockFormattingState): +(WebCore::Layout::BlockFormattingState::formattingContext): +(WebCore::Layout::BlockFormattingState::formattingContext const): Deleted. +* layout/blockformatting/BlockFormattingState.h: +* layout/inlineformatting/InlineFormattingContext.cpp: +(WebCore::Layout::InlineFormattingContext::InlineFormattingContext): +* layout/inlineformatting/InlineFormattingContext.h: +* layout/inlineformatting/InlineFormattingState.cpp: +(WebCore::Layout::InlineFormattingState::InlineFormattingState): +(WebCore::Layout::InlineFormattingState::formattingContext): +(WebCore::Layout::InlineFormattingState::formattingContext
[webkit-changes] [237632] trunk/Source/WebCore
Title: [237632] trunk/Source/WebCore Revision 237632 Author za...@apple.com Date 2018-10-31 06:43:03 -0700 (Wed, 31 Oct 2018) Log Message [LFC] The *FormattingState class should provide the *FormattingContext. https://bugs.webkit.org/show_bug.cgi?id=191089 Reviewed by Antti Koivisto. BlockFormattingState provides the BlockFormattingContext object, while InlineFormattingState provides the InlineFormattingContext. * layout/FormattingContext.cpp: (WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const): * layout/FormattingState.h: * layout/LayoutFormattingState.cpp: (WebCore::Layout::LayoutState::layoutFormattingContextSubtree): (WebCore::Layout::LayoutState::formattingContext const): Deleted. * layout/LayoutFormattingState.h: * layout/blockformatting/BlockFormattingContext.cpp: (WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const): (WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const): * layout/blockformatting/BlockFormattingState.cpp: (WebCore::Layout::BlockFormattingState::formattingContext const): * layout/blockformatting/BlockFormattingState.h: * layout/inlineformatting/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const): * layout/inlineformatting/InlineFormattingState.cpp: (WebCore::Layout::InlineFormattingState::formattingContext const): * layout/inlineformatting/InlineFormattingState.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/FormattingContext.cpp trunk/Source/WebCore/layout/FormattingState.h trunk/Source/WebCore/layout/LayoutFormattingState.cpp trunk/Source/WebCore/layout/LayoutFormattingState.h trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingState.cpp trunk/Source/WebCore/layout/blockformatting/BlockFormattingState.h trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.cpp trunk/Source/WebCore/layout/inlineformatting/InlineFormattingState.h Diff Modified: trunk/Source/WebCore/ChangeLog (237631 => 237632) --- trunk/Source/WebCore/ChangeLog 2018-10-31 13:37:58 UTC (rev 237631) +++ trunk/Source/WebCore/ChangeLog 2018-10-31 13:43:03 UTC (rev 237632) @@ -1,5 +1,33 @@ 2018-10-31 Zalan Bujtas +[LFC] The *FormattingState class should provide the *FormattingContext. +https://bugs.webkit.org/show_bug.cgi?id=191089 + +Reviewed by Antti Koivisto. + +BlockFormattingState provides the BlockFormattingContext object, while InlineFormattingState provides the InlineFormattingContext. + +* layout/FormattingContext.cpp: +(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const): +* layout/FormattingState.h: +* layout/LayoutFormattingState.cpp: +(WebCore::Layout::LayoutState::layoutFormattingContextSubtree): +(WebCore::Layout::LayoutState::formattingContext const): Deleted. +* layout/LayoutFormattingState.h: +* layout/blockformatting/BlockFormattingContext.cpp: +(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const): +(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const): +* layout/blockformatting/BlockFormattingState.cpp: +(WebCore::Layout::BlockFormattingState::formattingContext const): +* layout/blockformatting/BlockFormattingState.h: +* layout/inlineformatting/InlineFormattingContext.cpp: +(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const): +* layout/inlineformatting/InlineFormattingState.cpp: +(WebCore::Layout::InlineFormattingState::formattingContext const): +* layout/inlineformatting/InlineFormattingState.h: + +2018-10-31 Zalan Bujtas + [LFC] Rename LayoutContext to LayoutState https://bugs.webkit.org/show_bug.cgi?id=191080 Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (237631 => 237632) --- trunk/Source/WebCore/layout/FormattingContext.cpp 2018-10-31 13:37:58 UTC (rev 237631) +++ trunk/Source/WebCore/layout/FormattingContext.cpp 2018-10-31 13:43:03 UTC (rev 237632) @@ -29,6 +29,7 @@ #if ENABLE(LAYOUT_FORMATTING_CONTEXT) #include "DisplayBox.h" +#include "FormattingState.h" #include "LayoutBox.h" #include "LayoutContainer.h" #include "LayoutDescendantIterator.h" @@ -147,13 +148,12 @@ auto& layoutBox = *outOfFlowBox; ASSERT(layoutBox.establishesFormattingContext()); -auto formattingContext = layoutState.formattingContext(layoutBox); computeBorderAndPadding(layoutState, layoutBox); computeOutOfFlowHorizontalGeometry(layoutState, layoutBox); auto& formattingState = layoutState.createFormattingStateForFormattingRootIfNeeded(layoutBox); -formattingContext->layout(layoutState, formattingState); +
[webkit-changes] [237630] trunk/Source/JavaScriptCore
Title: [237630] trunk/Source/_javascript_Core
Revision 237630
Author commit-qu...@webkit.org
Date 2018-10-31 03:10:45 -0700 (Wed, 31 Oct 2018)
Log Message
Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSignalHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=191063
Patch by Jim Mason on 2018-10-31
Reviewed by Yusuke Suzuki.
* wasm/WasmFaultSignalHandler.cpp:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmFaultSignalHandler.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (237629 => 237630)
--- trunk/Source/_javascript_Core/ChangeLog 2018-10-31 09:56:48 UTC (rev 237629)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-10-31 10:10:45 UTC (rev 237630)
@@ -1,3 +1,12 @@
+2018-10-31 Jim Mason
+
+Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSignalHandler.cpp
+https://bugs.webkit.org/show_bug.cgi?id=191063
+
+Reviewed by Yusuke Suzuki.
+
+* wasm/WasmFaultSignalHandler.cpp:
+
2018-10-30 Yusuke Suzuki
[JSC][LLInt] Compact LLInt ASM code by removing unnecessary instructions
Modified: trunk/Source/_javascript_Core/wasm/WasmFaultSignalHandler.cpp (237629 => 237630)
--- trunk/Source/_javascript_Core/wasm/WasmFaultSignalHandler.cpp 2018-10-31 09:56:48 UTC (rev 237629)
+++ trunk/Source/_javascript_Core/wasm/WasmFaultSignalHandler.cpp 2018-10-31 10:10:45 UTC (rev 237630)
@@ -50,10 +50,10 @@
static Lock codeLocationsLock;
static LazyNeverDestroyed>> codeLocations; // (start, end)
+static bool fastHandlerInstalled { false };
+
#if ENABLE(WEBASSEMBLY_FAST_MEMORY)
-static bool fastHandlerInstalled { false };
-
static SignalAction trapHandler(Signal, SigInfo& sigInfo, PlatformRegisters& context)
{
auto instructionPointer = MachineContext::instructionPointer(context);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [237629] trunk/Source/WebKit
Title: [237629] trunk/Source/WebKit
Revision 237629
Author an...@apple.com
Date 2018-10-31 02:56:48 -0700 (Wed, 31 Oct 2018)
Log Message
Stop using LayerFlushScheduler in WK2
https://bugs.webkit.org/show_bug.cgi?id=191065
Reviewed by Tim Horton.
Code gets more understandable when TiledCoreAnimationDrawingArea simply uses RunLoopObserver
directly for flush scheduling. LayerFlushScheduler can be later moved to WK1.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
(WebKit::TiledCoreAnimationDrawingArea::layerFlushRunLoopCallback):
(WebKit::TiledCoreAnimationDrawingArea::invalidateLayerFlushRunLoopObserver):
(WebKit::TiledCoreAnimationDrawingArea::scheduleLayerFlushRunLoopObserver):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (237628 => 237629)
--- trunk/Source/WebKit/ChangeLog 2018-10-31 07:29:19 UTC (rev 237628)
+++ trunk/Source/WebKit/ChangeLog 2018-10-31 09:56:48 UTC (rev 237629)
@@ -1,3 +1,24 @@
+2018-10-31 Antti Koivisto
+
+Stop using LayerFlushScheduler in WK2
+https://bugs.webkit.org/show_bug.cgi?id=191065
+
+Reviewed by Tim Horton.
+
+Code gets more understandable when TiledCoreAnimationDrawingArea simply uses RunLoopObserver
+directly for flush scheduling. LayerFlushScheduler can be later moved to WK1.
+
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
+* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
+(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
+(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
+(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):
+(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
+(WebKit::TiledCoreAnimationDrawingArea::layerFlushRunLoopCallback):
+(WebKit::TiledCoreAnimationDrawingArea::invalidateLayerFlushRunLoopObserver):
+(WebKit::TiledCoreAnimationDrawingArea::scheduleLayerFlushRunLoopObserver):
+
2018-10-31 Claudio Saavedra
[WPE][GTK] Certificates loaded from the cache don't include the certificate chain
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h (237628 => 237629)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h 2018-10-31 07:29:19 UTC (rev 237628)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h 2018-10-31 09:56:48 UTC (rev 237629)
@@ -31,8 +31,6 @@
#include "DrawingArea.h"
#include "LayerTreeContext.h"
#include
-#include
-#include
#include
#include
#include
@@ -43,6 +41,7 @@
namespace WebCore {
class FrameView;
class PlatformCALayer;
+class RunLoopObserver;
class TiledBacking;
}
@@ -50,7 +49,7 @@
class LayerHostingContext;
-class TiledCoreAnimationDrawingArea : public DrawingArea, WebCore::LayerFlushSchedulerClient {
+class TiledCoreAnimationDrawingArea : public DrawingArea {
public:
TiledCoreAnimationDrawingArea(WebPage&, const WebPageCreationParameters&);
virtual ~TiledCoreAnimationDrawingArea();
@@ -88,8 +87,7 @@
bool dispatchDidReachLayoutMilestone(WebCore::LayoutMilestones) override;
-// WebCore::LayerFlushSchedulerClient
-bool flushLayers() override;
+bool flushLayers();
// Message handlers.
void updateGeometry(const WebCore::IntSize& viewSize, bool flushSynchronously, const WTF::MachSendRight& fencePort) override;
@@ -127,8 +125,11 @@
void sendPendingNewlyReachedLayoutMilestones();
+void layerFlushRunLoopCallback();
+void invalidateLayerFlushRunLoopObserver();
+void scheduleLayerFlushRunLoopObserver();
+
bool m_layerTreeStateIsFrozen;
-WebCore::LayerFlushScheduler m_layerFlushScheduler;
std::unique_ptr m_layerHostingContext;
@@ -164,6 +165,8 @@
WebCore::LayoutMilestones m_pendingNewlyReachedLayoutMilestones { 0 };
Vector m_pendingCallbackIDs;
+
+std::unique_ptr m_layerFlushRunLoopObserver;
};
} // namespace WebKit
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (237628 => 237629)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2018-10-31 07:29:19 UTC (rev 237628)
+++
[webkit-changes] [237628] trunk/Source/WebKit
Title: [237628] trunk/Source/WebKit
Revision 237628
Author csaave...@igalia.com
Date 2018-10-31 00:29:19 -0700 (Wed, 31 Oct 2018)
Log Message
[WPE][GTK] Certificates loaded from the cache don't include the certificate chain
https://bugs.webkit.org/show_bug.cgi?id=190956
Reviewed by Youenn Fablet.
Similarly to what was done for the IPC coders, serialize
the entire certificate chain in the cache coder. Bump
the cache version due to the caching format changes.
* NetworkProcess/cache/NetworkCacheCoders.h: Add GRefPtr coders.
* NetworkProcess/cache/NetworkCacheCodersSoup.cpp:
(WTF::Persistence::certificatesDataListFromCertificateInfo):
(WTF::Persistence::certificateFromCertificatesDataList): Helpers.
(WTF::Persistence::Coder::encode):
(WTF::Persistence::Coder::decode):
(WTF::Persistence::Coder>::encode):
(WTF::Persistence::Coder>::decode):
* NetworkProcess/cache/NetworkCacheStorage.h: Bump the cache version.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (237627 => 237628)
--- trunk/Source/WebKit/ChangeLog 2018-10-31 06:14:04 UTC (rev 237627)
+++ trunk/Source/WebKit/ChangeLog 2018-10-31 07:29:19 UTC (rev 237628)
@@ -1,3 +1,24 @@
+2018-10-31 Claudio Saavedra
+
+[WPE][GTK] Certificates loaded from the cache don't include the certificate chain
+https://bugs.webkit.org/show_bug.cgi?id=190956
+
+Reviewed by Youenn Fablet.
+
+Similarly to what was done for the IPC coders, serialize
+the entire certificate chain in the cache coder. Bump
+the cache version due to the caching format changes.
+
+* NetworkProcess/cache/NetworkCacheCoders.h: Add GRefPtr coders.
+* NetworkProcess/cache/NetworkCacheCodersSoup.cpp:
+(WTF::Persistence::certificatesDataListFromCertificateInfo):
+(WTF::Persistence::certificateFromCertificatesDataList): Helpers.
+(WTF::Persistence::Coder::encode):
+(WTF::Persistence::Coder::decode):
+(WTF::Persistence::Coder>::encode):
+(WTF::Persistence::Coder>::decode):
+* NetworkProcess/cache/NetworkCacheStorage.h: Bump the cache version.
+
2018-10-30 Wenson Hsieh
[Cocoa] Attachment dropped from one web view to another is missing its file wrapper
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h (237627 => 237628)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h 2018-10-31 06:14:04 UTC (rev 237627)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h 2018-10-31 07:29:19 UTC (rev 237628)
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2010, 2014-2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2018 Igalia S.L.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -50,5 +51,12 @@
static bool decode(Decoder&, WebCore::HTTPHeaderMap&);
};
+#if USE(GLIB)
+template<> struct Coder> {
+static void encode(Encoder&, const GRefPtr&);
+static bool decode(Decoder&, GRefPtr&);
+};
+#endif
+
}
}
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp (237627 => 237628)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp 2018-10-31 06:14:04 UTC (rev 237627)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCodersSoup.cpp 2018-10-31 07:29:19 UTC (rev 237628)
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2011, 2014-2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2018 Igalia S.L.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -29,55 +30,65 @@
namespace WTF {
namespace Persistence {
-void Coder::encode(Encoder& encoder, const WebCore::CertificateInfo& certificateInfo)
+
+static Vector> certificatesDataListFromCertificateInfo(const WebCore::CertificateInfo )
{
-if (!certificateInfo.certificate()) {
-encoder << false;
-return;
+auto* certificate = certificateInfo.certificate();
+if (!certificate)
+return { };
+
+Vector> certificatesDataList;
+for (; certificate; certificate = g_tls_certificate_get_issuer(certificate)) {
+GByteArray* certificateData = nullptr;
+g_object_get(G_OBJECT(certificate), "certificate", , nullptr);
+
+if (!certificateData) {
+certificatesDataList.clear();
+break;
+}
+certificatesDataList.append(adoptGRef(certificateData));
}
-GByteArray* certificateData = 0;
-g_object_get(G_OBJECT(certificateInfo.certificate()), "certificate", , NULL);
-if (!certificateData) {
-encoder << false;
-return;
+// Reverse so that the list starts from the rootmost certificate.
+
[webkit-changes] [237627] trunk/Source/JavaScriptCore
Title: [237627] trunk/Source/_javascript_Core Revision 237627 Author yusukesuz...@slowstart.org Date 2018-10-30 23:14:04 -0700 (Tue, 30 Oct 2018) Log Message [JSC][LLInt] Compact LLInt ASM code by removing unnecessary instructions https://bugs.webkit.org/show_bug.cgi?id=191092 Reviewed by Saam Barati. Looking through LLIntAssembly.h, we can find several inefficiencies. This patch fixes the following things to tighten LLInt ASM code. 1. Remove unnecessary load instructions. Use jmp with BaseIndex directly. 2. Introduce strength reduction for mul instructions in offlineasm layer. This is now critical since mul instruction is executed in `metadata` operation in LLInt. If the given immediate is a power of two, we convert it to lshift instruction. * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: * offlineasm/arm64.rb: * offlineasm/instructions.rb: * offlineasm/x86.rb: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm trunk/Source/_javascript_Core/offlineasm/arm64.rb trunk/Source/_javascript_Core/offlineasm/instructions.rb trunk/Source/_javascript_Core/offlineasm/x86.rb Diff Modified: trunk/Source/_javascript_Core/ChangeLog (237626 => 237627) --- trunk/Source/_javascript_Core/ChangeLog 2018-10-31 05:45:07 UTC (rev 237626) +++ trunk/Source/_javascript_Core/ChangeLog 2018-10-31 06:14:04 UTC (rev 237627) @@ -1,3 +1,24 @@ +2018-10-30 Yusuke Suzuki + +[JSC][LLInt] Compact LLInt ASM code by removing unnecessary instructions +https://bugs.webkit.org/show_bug.cgi?id=191092 + +Reviewed by Saam Barati. + +Looking through LLIntAssembly.h, we can find several inefficiencies. This patch fixes the +following things to tighten LLInt ASM code. + +1. Remove unnecessary load instructions. Use jmp with BaseIndex directly. +2. Introduce strength reduction for mul instructions in offlineasm layer. This is now critical +since mul instruction is executed in `metadata` operation in LLInt. If the given immediate is +a power of two, we convert it to lshift instruction. + +* llint/LowLevelInterpreter32_64.asm: +* llint/LowLevelInterpreter64.asm: +* offlineasm/arm64.rb: +* offlineasm/instructions.rb: +* offlineasm/x86.rb: + 2018-10-30 Don Olmstead [PlayStation] Enable _javascript_Core Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (237626 => 237627) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2018-10-31 05:45:07 UTC (rev 237626) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2018-10-31 06:14:04 UTC (rev 237627) @@ -26,15 +26,13 @@ macro nextInstruction() loadb [PC], t0 leap _g_opcodeMap, t1 -loadp [t1, t0, 4], t2 -jmp t2, BytecodePtrTag +jmp [t1, t0, 4], BytecodePtrTag end macro nextInstructionWide() loadi 1[PC], t0 leap _g_opcodeMapWide, t1 -loadp [t1, t0, 4], t2 -jmp t2, BytecodePtrTag +jmp [t1, t0, 4], BytecodePtrTag end macro getuOperandNarrow(op, field, dst) Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (237626 => 237627) --- trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm 2018-10-31 05:45:07 UTC (rev 237626) +++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm 2018-10-31 06:14:04 UTC (rev 237627) @@ -28,15 +28,13 @@ macro nextInstruction() loadb [PB, PC, 1], t0 leap _g_opcodeMap, t1 -loadp [t1, t0, PtrSize], t2 -jmp t2, BytecodePtrTag +jmp [t1, t0, PtrSize], BytecodePtrTag end macro nextInstructionWide() loadi 1[PB, PC, 1], t0 leap _g_opcodeMapWide, t1 -loadp [t1, t0, PtrSize], t2 -jmp t2, BytecodePtrTag +jmp [t1, t0, PtrSize], BytecodePtrTag end macro getuOperandNarrow(op, field, dst) @@ -437,17 +435,30 @@ # Index and value must be different registers. Index may be clobbered. macro loadConstantOrVariable(size, index, value) -size(FirstConstantRegisterIndexNarrow, FirstConstantRegisterIndexWide, macro (FirstConstantRegisterIndex) -bpgteq index, FirstConstantRegisterIndex, .constant +macro loadNarrow() +bpgteq index, FirstConstantRegisterIndexNarrow, .constant loadq [cfr, index, 8], value jmp .done .constant: loadp CodeBlock[cfr], value loadp CodeBlock::m_constantRegisters + VectorBufferOffset[value], value -subp FirstConstantRegisterIndex, index +loadq -(FirstConstantRegisterIndexNarrow * 8)[value, index, 8], value +.done: +end + +macro loadWide() +bpgteq index, FirstConstantRegisterIndexWide, .constant +loadq [cfr, index, 8], value +jmp .done +.constant: +loadp CodeBlock[cfr], value +loadp CodeBlock::m_constantRegisters + VectorBufferOffset[value], value +
