[webkit-changes] [244537] trunk

2019-04-22 Thread zalan
Title: [244537] trunk








Revision 244537
Author za...@apple.com
Date 2019-04-22 18:36:39 -0700 (Mon, 22 Apr 2019)


Log Message
[ContentChangeObserver] Some dropdown menus may close without user gesture on americanexpress.com
https://bugs.webkit.org/show_bug.cgi?id=197175


Reviewed by Simon Fraser.

Source/WebKit:

Do not generate additional synthetic mouse events (e.g. mouseout in this case) when the content handles the click event. This helps cases when the synthetic mouseout ended up dismissing the dropdown menus.
However it won't regress cases like youtube.com, where sending mouseout is required to have the control bar dismissed on play.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::completeSyntheticClick):

LayoutTests:

* fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented-expected.txt: Added.
* fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm


Added Paths

trunk/LayoutTests/fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented-expected.txt
trunk/LayoutTests/fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented.html




Diff

Modified: trunk/LayoutTests/ChangeLog (244536 => 244537)

--- trunk/LayoutTests/ChangeLog	2019-04-23 01:18:12 UTC (rev 244536)
+++ trunk/LayoutTests/ChangeLog	2019-04-23 01:36:39 UTC (rev 244537)
@@ -1,3 +1,14 @@
+2019-04-22  Zalan Bujtas  
+
+[ContentChangeObserver] Some dropdown menus may close without user gesture on americanexpress.com
+https://bugs.webkit.org/show_bug.cgi?id=197175
+
+
+Reviewed by Simon Fraser.
+
+* fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented-expected.txt: Added.
+* fast/events/touch/ios/content-observation/mouse-out-event-should-not-fire-on-click-when-default-prevented.html: Added.
+
 2019-04-22  Justin Fan  
 
 [WebGPU] Move swap chain methods from GPUDevice to GPUCanvasContext


Modified: trunk/LayoutTests/fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html (244536 => 244537)

--- trunk/LayoutTests/fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html	2019-04-23 01:18:12 UTC (rev 244536)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html	2019-04-23 01:36:39 UTC (rev 244537)
@@ -35,7 +35,7 @@
 
 
 
-PASS if 'mouseout' text is shown below.
+PASS if 'mouseout' text is shown below.