[webkit-changes] [247893] trunk/Source/WebCore

2019-07-27 Thread sbarati 
Title: [247893] trunk/Source/WebCore








Revision 247893
Author sbar...@apple.com
Date 2019-07-27 18:31:48 -0700 (Sat, 27 Jul 2019)


Log Message
[WHLSL] Remove UnnamedType copy/move constructors and mark classes as final
https://bugs.webkit.org/show_bug.cgi?id=200188

Reviewed by Myles C. Maxfield.

Since they are ref counted, you should make taking a ref to them
instead of moving or copying them. This patch encodes that by deleting
the relevant copy/move constructors and assignment operators.

* Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
* Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
(WebCore::WHLSL::AST::ArrayType::ArrayType): Deleted.
(WebCore::WHLSL::AST::ArrayType::create): Deleted.
(WebCore::WHLSL::AST::ArrayType::type const): Deleted.
(WebCore::WHLSL::AST::ArrayType::type): Deleted.
(WebCore::WHLSL::AST::ArrayType::numElements const): Deleted.
* Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
(WebCore::WHLSL::AST::PointerType::PointerType): Deleted.
(WebCore::WHLSL::AST::PointerType::create): Deleted.
* Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
* Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
(WebCore::WHLSL::AST::TypeReference::TypeReference): Deleted.
(WebCore::WHLSL::AST::TypeReference::create): Deleted.
(WebCore::WHLSL::AST::TypeReference::name): Deleted.
(WebCore::WHLSL::AST::TypeReference::typeArguments): Deleted.
(WebCore::WHLSL::AST::TypeReference::maybeResolvedType const): Deleted.
(WebCore::WHLSL::AST::TypeReference::resolvedType const): Deleted.
(WebCore::WHLSL::AST::TypeReference::setResolvedType): Deleted.
* Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayType.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLPointerType.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (247892 => 247893)

--- trunk/Source/WebCore/ChangeLog	2019-07-28 00:47:00 UTC (rev 247892)
+++ trunk/Source/WebCore/ChangeLog	2019-07-28 01:31:48 UTC (rev 247893)
@@ -1,3 +1,35 @@
+2019-07-27  Saam Barati  
+
+[WHLSL] Remove UnnamedType copy/move constructors and mark classes as final
+https://bugs.webkit.org/show_bug.cgi?id=200188
+
+Reviewed by Myles C. Maxfield.
+
+Since they are ref counted, you should make taking a ref to them
+instead of moving or copying them. This patch encodes that by deleting
+the relevant copy/move constructors and assignment operators.
+
+* Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
+* Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
+(WebCore::WHLSL::AST::ArrayType::ArrayType): Deleted.
+(WebCore::WHLSL::AST::ArrayType::create): Deleted.
+(WebCore::WHLSL::AST::ArrayType::type const): Deleted.
+(WebCore::WHLSL::AST::ArrayType::type): Deleted.
+(WebCore::WHLSL::AST::ArrayType::numElements const): Deleted.
+* Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
+(WebCore::WHLSL::AST::PointerType::PointerType): Deleted.
+(WebCore::WHLSL::AST::PointerType::create): Deleted.
+* Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
+* Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
+(WebCore::WHLSL::AST::TypeReference::TypeReference): Deleted.
+(WebCore::WHLSL::AST::TypeReference::create): Deleted.
+(WebCore::WHLSL::AST::TypeReference::name): Deleted.
+(WebCore::WHLSL::AST::TypeReference::typeArguments): Deleted.
+(WebCore::WHLSL::AST::TypeReference::maybeResolvedType const): Deleted.
+(WebCore::WHLSL::AST::TypeReference::resolvedType const): Deleted.
+(WebCore::WHLSL::AST::TypeReference::setResolvedType): Deleted.
+* Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
+
 2019-07-27  Justin Fan  
 
 [WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implementation


Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h (247892 => 247893)

--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h	2019-07-28 00:47:00 UTC (rev 247892)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h	2019-07-28 01:31:48 UTC (rev 247893)
@@ -30,6 +30,8 @@
 #include "WHLSLCodeLocation.h"
 #include "WHLSLReferenceType.h"
 #include 
+#include 
+#include 
 #include 
 #include 
 
@@ -41,6 +43,8 @@
 
 class ArrayReferenceType : public ReferenceType {
 WTF_MAKE_FAST_ALLOCATED;
+WTF_MAKE_NONCOPYABLE(ArrayReferenceType);
+WTF_MAKE_NONMOVABLE(ArrayReferenceType);
 using Base = ReferenceType;
 
 ArrayReferenceType(CodeLocation location, AddressSpace addressSpace, Ref elementType)
@@ -55,8 +59,6 @@
 
 virtual ~ArrayReferenceType() = default;

[webkit-changes] [247892] trunk/Source/WebCore

2019-07-27 Thread justin_fan 
Title: [247892] trunk/Source/WebCore








Revision 247892
Author justin_...@apple.com
Date 2019-07-27 17:47:00 -0700 (Sat, 27 Jul 2019)


Log Message
[WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implementation
https://bugs.webkit.org/show_bug.cgi?id=200097

Reviewed by Myles C. Maxfield.

Remove passing around a functionName in GPUComputePipeline creation in favor of setting it on the GPUErrorScopes.
Also, WebGPU objects no longer create new Ref<>s unless object creation succeeds.

No new tests. Covered by existing tests.

* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::createBuffer const):
(WebCore::WebGPUDevice::createBufferMapped const):
(WebCore::WebGPUDevice::createComputePipeline const):
* platform/graphics/gpu/GPUBuffer.h:
* platform/graphics/gpu/GPUComputePipeline.h:
* platform/graphics/gpu/GPUDevice.cpp:
(WebCore::GPUDevice::tryCreateBuffer):
(WebCore::GPUDevice::tryCreateComputePipeline const):
* platform/graphics/gpu/GPUDevice.h:
* platform/graphics/gpu/GPUErrorScopes.cpp:
(WebCore::GPUErrorScopes::generatePrefixedError): Only validaton errors have messages right now.
* platform/graphics/gpu/GPUErrorScopes.h:
* platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
(WebCore::GPUBuffer::validateBufferUsage):
(WebCore::GPUBuffer::tryCreate):
(WebCore::GPUBuffer::GPUBuffer):
* platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:
(WebCore::trySetMetalFunctions):
(WebCore::trySetFunctions):
(WebCore::convertComputePipelineDescriptor):
(WebCore::tryCreateMTLComputePipelineState):
(WebCore::GPUComputePipeline::tryCreate):
(WebCore::GPUComputePipeline::GPUComputePipeline):
* platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::trySetMetalFunctions):
(WebCore::trySetFunctions):

These classes were made RefCounted in a previous patch; remove their move ctors to fix build.
* Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
* Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
* Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
* Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
* Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
* Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLArrayType.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLPointerType.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h
trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h
trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUBuffer.h
trunk/Source/WebCore/platform/graphics/gpu/GPUComputePipeline.h
trunk/Source/WebCore/platform/graphics/gpu/GPUDevice.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUDevice.h
trunk/Source/WebCore/platform/graphics/gpu/GPUErrorScopes.cpp
trunk/Source/WebCore/platform/graphics/gpu/GPUErrorScopes.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (247891 => 247892)

--- trunk/Source/WebCore/ChangeLog	2019-07-28 00:42:36 UTC (rev 247891)
+++ trunk/Source/WebCore/ChangeLog	2019-07-28 00:47:00 UTC (rev 247892)
@@ -1,3 +1,51 @@
+2019-07-27  Justin Fan  
+
+[WebGPU] Update GPUComputePipeline errors to match GPURenderPipeline implementation
+https://bugs.webkit.org/show_bug.cgi?id=200097
+
+Reviewed by Myles C. Maxfield.
+
+Remove passing around a functionName in GPUComputePipeline creation in favor of setting it on the GPUErrorScopes.
+Also, WebGPU objects no longer create new Ref<>s unless object creation succeeds.
+
+No new tests. Covered by existing tests.
+
+* Modules/webgpu/WebGPUDevice.cpp:
+(WebCore::WebGPUDevice::createBuffer const):
+(WebCore::WebGPUDevice::createBufferMapped const):
+(WebCore::WebGPUDevice::createComputePipeline const):
+* platform/graphics/gpu/GPUBuffer.h:
+* platform/graphics/gpu/GPUComputePipeline.h:
+* platform/graphics/gpu/GPUDevice.cpp:
+(WebCore::GPUDevice::tryCreateBuffer):
+(WebCore::GPUDevice::tryCreateComputePipeline const):
+* platform/graphics/gpu/GPUDevice.h:
+* platform/graphics/gpu/GPUErrorScopes.cpp:
+(WebCore::GPUErrorScopes::generatePrefixedError): Only validaton errors have messages right now.
+* platform/graphics/gpu/GPUErrorScopes.h:
+* platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
+(WebCore::GPUBuffer::validateBufferUsage):
+(WebCore::GPUBuffer::tryCreate):
+(WebCore::GPUBuffer::GPUBuffer):
+* platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:
+(WebCore::trySetMetalFunctions):
+(WebCore::trySetFu

[webkit-changes] [247891] trunk

2019-07-27 Thread commit-queue 
Title: [247891] trunk








Revision 247891
Author commit-qu...@webkit.org
Date 2019-07-27 17:42:36 -0700 (Sat, 27 Jul 2019)


Log Message
Expose the aria-label attribute for  elements.
https://bugs.webkit.org/show_bug.cgi?id=200169


Patch by Andres Gonzalez  on 2019-07-27
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/ios-simulator/media-with-aria-label.html
   accessibility/media-with-aria-label.html

We now expose the  element to accessibility clients as long as auto-play is not enabled.
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsWebInteractiveVideo]):

LayoutTests:

* accessibility/ios-simulator/media-with-aria-label-expected.txt: Added.
* accessibility/ios-simulator/media-with-aria-label.html: Added.
* accessibility/media-with-aria-label-expected.txt: Added.
* accessibility/media-with-aria-label.html: Added.
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm


Added Paths

trunk/LayoutTests/accessibility/ios-simulator/media-with-aria-label-expected.txt
trunk/LayoutTests/accessibility/ios-simulator/media-with-aria-label.html
trunk/LayoutTests/accessibility/media-with-aria-label-expected.txt
trunk/LayoutTests/accessibility/media-with-aria-label.html




Diff

Modified: trunk/LayoutTests/ChangeLog (247890 => 247891)

--- trunk/LayoutTests/ChangeLog	2019-07-27 13:41:51 UTC (rev 247890)
+++ trunk/LayoutTests/ChangeLog	2019-07-28 00:42:36 UTC (rev 247891)
@@ -1,3 +1,17 @@
+2019-07-27  Andres Gonzalez  
+
+Expose the aria-label attribute for  elements.
+https://bugs.webkit.org/show_bug.cgi?id=200169
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/ios-simulator/media-with-aria-label-expected.txt: Added.
+* accessibility/ios-simulator/media-with-aria-label.html: Added.
+* accessibility/media-with-aria-label-expected.txt: Added.
+* accessibility/media-with-aria-label.html: Added.
+* platform/win/TestExpectations:
+
 2019-07-26  Ryosuke Niwa  
 
 Moving right by word boundary right before an object element followed by a br element hangs


Added: trunk/LayoutTests/accessibility/ios-simulator/media-with-aria-label-expected.txt (0 => 247891)

--- trunk/LayoutTests/accessibility/ios-simulator/media-with-aria-label-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/media-with-aria-label-expected.txt	2019-07-28 00:42:36 UTC (rev 247891)
@@ -0,0 +1,13 @@
+ 
+
+This tests ensures that aria-label is conveyed for video and audio elements.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS video1.description is 'AXLabel: Video One, indefinite time'
+PASS audio1.description is 'AXLabel: Audio One, 0 seconds, indefinite time'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/ios-simulator/media-with-aria-label.html (0 => 247891)

--- trunk/LayoutTests/accessibility/ios-simulator/media-with-aria-label.html	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/media-with-aria-label.html	2019-07-28 00:42:36 UTC (rev 247891)
@@ -0,0 +1,29 @@
+
+
+
+
+
+
+
+
+

+
+
+
+

+

+
+