[webkit-changes] [252232] releases/Apple
Title: [252232] releases/Apple Revision 252232 Author m...@apple.com Date 2019-11-07 20:02:47 -0800 (Thu, 07 Nov 2019) Log Message Added a tag for iOS 13.2.2. Added Paths releases/Apple/iOS 13.2.2/ releases/Apple/iOS 13.2.2/ANGLE/ releases/Apple/iOS 13.2.2/_javascript_Core/ releases/Apple/iOS 13.2.2/WTF/ releases/Apple/iOS 13.2.2/WebCore/ releases/Apple/iOS 13.2.2/WebKit/ releases/Apple/iOS 13.2.2/WebKitLegacy/ releases/Apple/iOS 13.2.2/bmalloc/ releases/Apple/iOS 13.2.2/libwebrtc/ Diff Index: releases/Apple/iOS 13.2.2/ANGLE === --- tags/Safari-608.3.10.0.4/Source/ThirdParty/ANGLE 2019-11-08 03:55:47 UTC (rev 252231) +++ releases/Apple/iOS 13.2.2/ANGLE 2019-11-08 04:02:47 UTC (rev 252232) Property changes: releases/Apple/iOS 13.2.2/ANGLE Added: allow-tabs +true \ No newline at end of property Added: svn:mergeinfo +/trunk/Source/ThirdParty/ANGLE:53455,248143,248162 \ No newline at end of property Index: releases/Apple/iOS 13.2.2/_javascript_Core === --- tags/Safari-608.3.10.0.4/Source/_javascript_Core 2019-11-08 03:55:47 UTC (rev 252231) +++ releases/Apple/iOS 13.2.2/_javascript_Core 2019-11-08 04:02:47 UTC (rev 252232) Property changes: releases/Apple/iOS 13.2.2/_javascript_Core Added: svn:mergeinfo +/trunk/Source/_javascript_Core:53455,248143,248162 \ No newline at end of property Index: releases/Apple/iOS 13.2.2/WTF === --- tags/Safari-608.3.10.0.4/Source/WTF 2019-11-08 03:55:47 UTC (rev 252231) +++ releases/Apple/iOS 13.2.2/WTF 2019-11-08 04:02:47 UTC (rev 252232) Property changes: releases/Apple/iOS 13.2.2/WTF Added: svn:mergeinfo +/trunk/Source/WTF:53455,248143,248162 \ No newline at end of property Index: releases/Apple/iOS 13.2.2/bmalloc === --- tags/Safari-608.3.10.0.4/Source/bmalloc 2019-11-08 03:55:47 UTC (rev 252231) +++ releases/Apple/iOS 13.2.2/bmalloc 2019-11-08 04:02:47 UTC (rev 252232) Property changes: releases/Apple/iOS 13.2.2/bmalloc Added: svn:mergeinfo +/trunk/Source/bmalloc:53455,248143,248162 \ No newline at end of property Index: releases/Apple/iOS 13.2.2/libwebrtc === --- tags/Safari-608.3.10.0.4/Source/ThirdParty/libwebrtc 2019-11-08 03:55:47 UTC (rev 252231) +++ releases/Apple/iOS 13.2.2/libwebrtc 2019-11-08 04:02:47 UTC (rev 252232) Property changes: releases/Apple/iOS 13.2.2/libwebrtc Added: svn:mergeinfo +/trunk/Source/ThirdParty/libwebrtc:53455,248143,248162 \ No newline at end of property ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252231] trunk/Source/JavaScriptCore
Title: [252231] trunk/Source/_javascript_Core
Revision 252231
Author tzaga...@apple.com
Date 2019-11-07 19:55:47 -0800 (Thu, 07 Nov 2019)
Log Message
Use fewer virtual registers in Wasm LLInt
https://bugs.webkit.org/show_bug.cgi?id=203861
Reviewed by Saam Barati.
Reduce the number of virtual registers in two ways:
- Re-use arguments for result values (e.g. the result of add lhs, rhs should go in lhs, not a new virtual register)
- Re-use the argument register space for return values that should be placed in registers
* bytecode/BytecodeList.rb:
* generator/Wasm.rb:
* llint/WebAssembly.asm:
* wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::callInformationFor):
(JSC::Wasm::LLIntGenerator::addReturn):
(JSC::Wasm::LLIntGenerator::addRefIsNull):
(JSC::Wasm::LLIntGenerator::addTableGet):
(JSC::Wasm::LLIntGenerator::addTableGrow):
(JSC::Wasm::LLIntGenerator::addGrowMemory):
(JSC::Wasm::LLIntGenerator::addSelect):
(JSC::Wasm::LLIntGenerator::load):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeList.rb
trunk/Source/_javascript_Core/generator/Wasm.rb
trunk/Source/_javascript_Core/llint/WebAssembly.asm
trunk/Source/_javascript_Core/wasm/WasmLLIntGenerator.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (252230 => 252231)
--- trunk/Source/_javascript_Core/ChangeLog 2019-11-08 02:52:40 UTC (rev 252230)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-11-08 03:55:47 UTC (rev 252231)
@@ -1,3 +1,27 @@
+2019-11-07 Tadeu Zagallo
+
+Use fewer virtual registers in Wasm LLInt
+https://bugs.webkit.org/show_bug.cgi?id=203861
+
+Reviewed by Saam Barati.
+
+Reduce the number of virtual registers in two ways:
+- Re-use arguments for result values (e.g. the result of add lhs, rhs should go in lhs, not a new virtual register)
+- Re-use the argument register space for return values that should be placed in registers
+
+* bytecode/BytecodeList.rb:
+* generator/Wasm.rb:
+* llint/WebAssembly.asm:
+* wasm/WasmLLIntGenerator.cpp:
+(JSC::Wasm::LLIntGenerator::callInformationFor):
+(JSC::Wasm::LLIntGenerator::addReturn):
+(JSC::Wasm::LLIntGenerator::addRefIsNull):
+(JSC::Wasm::LLIntGenerator::addTableGet):
+(JSC::Wasm::LLIntGenerator::addTableGrow):
+(JSC::Wasm::LLIntGenerator::addGrowMemory):
+(JSC::Wasm::LLIntGenerator::addSelect):
+(JSC::Wasm::LLIntGenerator::load):
+
2019-11-07 Robin Morisset
Split ArithProfile into a Unary and a Binary version
Modified: trunk/Source/_javascript_Core/bytecode/BytecodeList.rb (252230 => 252231)
--- trunk/Source/_javascript_Core/bytecode/BytecodeList.rb 2019-11-08 02:52:40 UTC (rev 252230)
+++ trunk/Source/_javascript_Core/bytecode/BytecodeList.rb 2019-11-08 03:55:47 UTC (rev 252231)
@@ -1287,10 +1287,7 @@
targetLabel: WasmBoundLabel,
}
-op :ret,
-args: {
-stackOffset: unsigned,
-}
+op :ret
op :switch,
args: {
Modified: trunk/Source/_javascript_Core/generator/Wasm.rb (252230 => 252231)
--- trunk/Source/_javascript_Core/generator/Wasm.rb 2019-11-08 02:52:40 UTC (rev 252230)
+++ trunk/Source/_javascript_Core/generator/Wasm.rb 2019-11-08 03:55:47 UTC (rev 252231)
@@ -58,7 +58,7 @@
template<>
auto LLIntGenerator::addOp<#{op_type(op)}>(ExpressionType lhs, ExpressionType rhs, ExpressionType& result) -> PartialResult
{
-result = newTemporary();
+result = lhs;
#{op.capitalized_name}::emit(this, result, lhs, rhs);
return { };
}
@@ -70,7 +70,7 @@
template<>
auto LLIntGenerator::addOp<#{op_type(op)}>(ExpressionType operand, ExpressionType& result) -> PartialResult
{
-result = newTemporary();
+result = operand;
#{op.capitalized_name}::emit(this, result, operand);
return { };
}
Modified: trunk/Source/_javascript_Core/llint/WebAssembly.asm (252230 => 252231)
--- trunk/Source/_javascript_Core/llint/WebAssembly.asm 2019-11-08 02:52:40 UTC (rev 252230)
+++ trunk/Source/_javascript_Core/llint/WebAssembly.asm 2019-11-08 03:55:47 UTC (rev 252231)
@@ -604,16 +604,11 @@
unprefixedWasmOp(wasm_ret, WasmRet, macro(ctx)
checkSwitchToJITForEpilogue()
-wgetu(ctx, m_stackOffset, ws1)
-lshifti 3, ws1
-negi ws1
-sxi2q ws1, ws1
-addp cfr, ws1
forEachArgumentGPR(macro (offset, gpr)
-loadq offset[ws1], gpr
+loadq -offset - 8 - CalleeSaveSpaceAsVirtualRegisters * 8[cfr], gpr
end)
forEachArgumentFPR(macro (offset, fpr)
-loadd offset[ws1], fpr
+loadd -offset - 8 - CalleeSaveSpaceAsVirtualRegisters * 8[cfr], fpr
end)
doReturn()
end)
Modified: trunk/Source/_javascript_Core/wasm/WasmLLIntGenerator.cpp (252230 => 252231)
--- trunk/Source/_javascript_Core/wasm/WasmLLIntGenerator.cpp 2019-11-08 02:52:40 UTC (rev 252230)
+++ trunk/Source/_javascript_Core/wasm/WasmLLIntGenerator.cpp 2019-11-08 03:55:47 UTC (rev
[webkit-changes] [252230] trunk
Title: [252230] trunk Revision 252230 Author commit-qu...@webkit.org Date 2019-11-07 18:52:40 -0800 (Thu, 07 Nov 2019) Log Message Default NamepaceURI must be gotten from the topmost parent before the SVG https://bugs.webkit.org/show_bug.cgi?id=203868 Patch by Said Abou-Hallawa on 2019-11-07 Reviewed by Ryosuke Niwa. Source/WebCore: Ensure that we don't cross boundaries from HTML to SVG when traversing the tree of nodes upward. We need to stop at the foreignObject if it is one of the ancestors of the contextElement. Tests: svg/foreignObject/foreign-object-dynamic-parsing.svg * html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::HTMLTableCellElement): This assertion should not fire if the tag has a prefix like or where 'h' is a defined namespace. * xml/parser/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::parseDocumentFragment): Stop at the first SVG ancestor when calculating the defaultNamespaceURI. * xml/parser/XMLDocumentParser.h: * xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::startElementNs): We need to special case setting the namespaceURI of the SVGElmenets. The defaultNamespaceURI can be wrong for them if the context element is an HTML element, for example, and the innerHTML is set to something like: ''. LayoutTests: * svg/foreignObject/foreign-object-dynamic-parsing-expected.svg: Added. * svg/foreignObject/foreign-object-dynamic-parsing.svg: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLTableCellElement.cpp trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp trunk/Source/WebCore/xml/parser/XMLDocumentParser.h trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Added Paths trunk/LayoutTests/svg/foreignObject/foreign-object-dynamic-parsing-expected.svg trunk/LayoutTests/svg/foreignObject/foreign-object-dynamic-parsing.svg Diff Modified: trunk/LayoutTests/ChangeLog (252229 => 252230) --- trunk/LayoutTests/ChangeLog 2019-11-08 02:46:09 UTC (rev 252229) +++ trunk/LayoutTests/ChangeLog 2019-11-08 02:52:40 UTC (rev 252230) @@ -1,3 +1,13 @@ +2019-11-07 Said Abou-Hallawa + +Default NamepaceURI must be gotten from the topmost parent before the SVG +https://bugs.webkit.org/show_bug.cgi?id=203868 + +Reviewed by Ryosuke Niwa. + +* svg/foreignObject/foreign-object-dynamic-parsing-expected.svg: Added. +* svg/foreignObject/foreign-object-dynamic-parsing.svg: Added. + 2019-11-07 Chris Dumez TestController may reuse a view that used window.open(), which prevents process-swapping and causes flakiness Added: trunk/LayoutTests/svg/foreignObject/foreign-object-dynamic-parsing-expected.svg (0 => 252230) --- trunk/LayoutTests/svg/foreignObject/foreign-object-dynamic-parsing-expected.svg (rev 0) +++ trunk/LayoutTests/svg/foreignObject/foreign-object-dynamic-parsing-expected.svg 2019-11-08 02:52:40 UTC (rev 252230) @@ -0,0 +1,34 @@ + + + +ABC + + + +A +B +C + + + + + + + +DEF + + + +D +E +F + + + + + + + + + + Added: trunk/LayoutTests/svg/foreignObject/foreign-object-dynamic-parsing.svg (0 => 252230) --- trunk/LayoutTests/svg/foreignObject/foreign-object-dynamic-parsing.svg (rev 0) +++ trunk/LayoutTests/svg/foreignObject/foreign-object-dynamic-parsing.svg 2019-11-08 02:52:40 UTC (rev 252230) @@ -0,0 +1,72 @@ + +ABC" + +"" + +"" + +"
" + +" A " + +"B " + +
[webkit-changes] [252228] trunk
Title: [252228] trunk Revision 252228 Author cdu...@apple.com Date 2019-11-07 18:45:05 -0800 (Thu, 07 Nov 2019) Log Message TestController may reuse a view that used window.open(), which prevents process-swapping and causes flakiness https://bugs.webkit.org/show_bug.cgi?id=203981 Reviewed by Ryosuke Niwa. Tools: Stop reusing WebViews that have created other WebViews (via window.open()) since this prevents process-swapping and may therefore cause flakiness (see Bug 203965). * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::ensureViewSupportsOptionsForTest): * WebKitTestRunner/TestController.h: LayoutTests: Drop temporary flakiness workaround that was landed in r252214. * http/tests/inspector/target/target-events-for-provisional-page.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/target/target-events-for-provisional-page.html trunk/LayoutTests/platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-expected.txt trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/TestController.cpp trunk/Tools/WebKitTestRunner/TestController.h Diff Modified: trunk/LayoutTests/ChangeLog (252227 => 252228) --- trunk/LayoutTests/ChangeLog 2019-11-08 02:35:32 UTC (rev 252227) +++ trunk/LayoutTests/ChangeLog 2019-11-08 02:45:05 UTC (rev 252228) @@ -1,3 +1,14 @@ +2019-11-07 Chris Dumez + +TestController may reuse a view that used window.open(), which prevents process-swapping and causes flakiness +https://bugs.webkit.org/show_bug.cgi?id=203981 + +Reviewed by Ryosuke Niwa. + +Drop temporary flakiness workaround that was landed in r252214. + +* http/tests/inspector/target/target-events-for-provisional-page.html: + 2019-11-07 Justin Fan [WebGL] Fixing WebGL tests: Add new baselines for iOS bots Modified: trunk/LayoutTests/http/tests/inspector/target/target-events-for-provisional-page.html (252227 => 252228) --- trunk/LayoutTests/http/tests/inspector/target/target-events-for-provisional-page.html 2019-11-08 02:35:32 UTC (rev 252227) +++ trunk/LayoutTests/http/tests/inspector/target/target-events-for-provisional-page.html 2019-11-08 02:45:05 UTC (rev 252228) @@ -1,4 +1,4 @@ - + Modified: trunk/LayoutTests/platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-expected.txt (252227 => 252228) --- trunk/LayoutTests/platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-expected.txt 2019-11-08 02:35:32 UTC (rev 252227) +++ trunk/LayoutTests/platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-expected.txt 2019-11-08 02:45:05 UTC (rev 252228) @@ -2,6 +2,7 @@ frame "" - didStartProvisionalLoadForFrame frame "" - didCommitLoadForFrame CONSOLE MESSAGE: Blocked mixed content http://127.0.0.1:8000/security/mixedContent/resources/script.js because 'block-all-mixed-content' appears in the Content Security Policy. +CONSOLE MESSAGE: Blocked mixed content http://127.0.0.1:8000/security/mixedContent/resources/script.js because 'block-all-mixed-content' appears in the Content Security Policy. frame "" - didFinishDocumentLoadForFrame frame "" - didHandleOnloadEventsForFrame main frame - didHandleOnloadEventsForFrame Modified: trunk/Tools/ChangeLog (252227 => 252228) --- trunk/Tools/ChangeLog 2019-11-08 02:35:32 UTC (rev 252227) +++ trunk/Tools/ChangeLog 2019-11-08 02:45:05 UTC (rev 252228) @@ -1,3 +1,18 @@ +2019-11-07 Chris Dumez + +TestController may reuse a view that used window.open(), which prevents process-swapping and causes flakiness +https://bugs.webkit.org/show_bug.cgi?id=203981 + +Reviewed by Ryosuke Niwa. + +Stop reusing WebViews that have created other WebViews (via window.open()) since this prevents process-swapping +and may therefore cause flakiness (see Bug 203965). + +* WebKitTestRunner/TestController.cpp: +(WTR::TestController::createOtherPage): +(WTR::TestController::ensureViewSupportsOptionsForTest): +* WebKitTestRunner/TestController.h: + 2019-11-07 Aakash Jain [ews] rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (252227 => 252228) --- trunk/Tools/WebKitTestRunner/TestController.cpp 2019-11-08 02:35:32 UTC (rev 252227) +++ trunk/Tools/WebKitTestRunner/TestController.cpp 2019-11-08 02:45:05 UTC (rev 252228) @@ -314,6 +314,8 @@ if (!m_currentInvocation->canOpenWindows()) return nullptr; +m_createdOtherPage = true; + PlatformWebView* view = platformCreateOtherPage(parentView, configuration, parentView->options()); WKPageRef newPage = view->page(); @@ -767,7 +769,9 @@ auto options = test.options(); if (m_mainWebView) { -if
[webkit-changes] [252227] trunk/Source/WebCore
Title: [252227] trunk/Source/WebCore Revision 252227 Author cdu...@apple.com Date 2019-11-07 18:35:32 -0800 (Thu, 07 Nov 2019) Log Message Use ActiveDOMObject::queueTaskKeepingObjectAlive() in DOMCache https://bugs.webkit.org/show_bug.cgi?id=203985 Reviewed by Ryosuke Niwa. Use ActiveDOMObject::queueTaskKeepingObjectAlive() in DOMCache and drop DOMCache::enqueueTask(). * Modules/cache/DOMCache.cpp: (WebCore::DOMCache::match): (WebCore::DOMCache::matchAll): (WebCore::DOMCache::addAll): (WebCore::DOMCache::putWithResponseData): (WebCore::DOMCache::put): (WebCore::DOMCache::remove): (WebCore::DOMCache::keys): (WebCore::DOMCache::enqueueTask): Deleted. * Modules/cache/DOMCache.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/cache/DOMCache.cpp trunk/Source/WebCore/Modules/cache/DOMCache.h Diff Modified: trunk/Source/WebCore/ChangeLog (252226 => 252227) --- trunk/Source/WebCore/ChangeLog 2019-11-08 01:38:26 UTC (rev 252226) +++ trunk/Source/WebCore/ChangeLog 2019-11-08 02:35:32 UTC (rev 252227) @@ -1,3 +1,23 @@ +2019-11-07 Chris Dumez + +Use ActiveDOMObject::queueTaskKeepingObjectAlive() in DOMCache +https://bugs.webkit.org/show_bug.cgi?id=203985 + +Reviewed by Ryosuke Niwa. + +Use ActiveDOMObject::queueTaskKeepingObjectAlive() in DOMCache and drop DOMCache::enqueueTask(). + +* Modules/cache/DOMCache.cpp: +(WebCore::DOMCache::match): +(WebCore::DOMCache::matchAll): +(WebCore::DOMCache::addAll): +(WebCore::DOMCache::putWithResponseData): +(WebCore::DOMCache::put): +(WebCore::DOMCache::remove): +(WebCore::DOMCache::keys): +(WebCore::DOMCache::enqueueTask): Deleted. +* Modules/cache/DOMCache.h: + 2019-11-07 Kenneth Russell Please support WEBGL_compressed_texture_etc1 extension (and possibly WEBGL_compressed_texture_etc too) Modified: trunk/Source/WebCore/Modules/cache/DOMCache.cpp (252226 => 252227) --- trunk/Source/WebCore/Modules/cache/DOMCache.cpp 2019-11-08 01:38:26 UTC (rev 252226) +++ trunk/Source/WebCore/Modules/cache/DOMCache.cpp 2019-11-08 02:35:32 UTC (rev 252227) @@ -59,7 +59,7 @@ void DOMCache::match(RequestInfo&& info, CacheQueryOptions&& options, Ref&& promise) { doMatch(WTFMove(info), WTFMove(options), [this, protectedThis = makeRef(*this), promise = WTFMove(promise)](ExceptionOr>&& result) mutable { -enqueueTask([promise = WTFMove(promise), result = WTFMove(result)]() mutable { +queueTaskKeepingObjectAlive(*this, TaskSource::DOMManipulation, [promise = WTFMove(promise), result = WTFMove(result)]() mutable { if (result.hasException()) { promise->reject(result.releaseException()); return; @@ -123,7 +123,7 @@ if (!request) { retrieveRecords(URL { }, [this, promise = WTFMove(promise)](Optional&& exception) mutable { -enqueueTask([this, promise = WTFMove(promise), exception = WTFMove(exception)]() mutable { +queueTaskKeepingObjectAlive(*this, TaskSource::DOMManipulation, [this, promise = WTFMove(promise), exception = WTFMove(exception)]() mutable { if (exception) { promise.reject(WTFMove(exception.value())); return; @@ -134,7 +134,7 @@ return; } queryCache(request.releaseNonNull(), WTFMove(options), [this, promise = WTFMove(promise)](ExceptionOr>&& result) mutable { -enqueueTask([this, promise = WTFMove(promise), result = WTFMove(result)]() mutable { +queueTaskKeepingObjectAlive(*this, TaskSource::DOMManipulation, [this, promise = WTFMove(promise), result = WTFMove(result)]() mutable { if (result.hasException()) { promise.reject(result.releaseException()); return; @@ -242,13 +242,13 @@ auto taskHandler = FetchTasksHandler::create(*this, [this, protectedThis = makeRef(*this), promise = WTFMove(promise)](ExceptionOr>&& result) mutable { if (result.hasException()) { -enqueueTask([promise = WTFMove(promise), exception = result.releaseException()]() mutable { +queueTaskKeepingObjectAlive(*this, TaskSource::DOMManipulation, [promise = WTFMove(promise), exception = result.releaseException()]() mutable { promise.reject(WTFMove(exception)); }); return; } batchPutOperation(result.releaseReturnValue(), [this, protectedThis = WTFMove(protectedThis), promise = WTFMove(promise)](ExceptionOr&& result) mutable { -enqueueTask([promise = WTFMove(promise), result = WTFMove(result)]() mutable { +queueTaskKeepingObjectAlive(*this, TaskSource::DOMManipulation, [promise = WTFMove(promise), result = WTFMove(result)]() mutable { promise.settle(WTFMove(result)); }); }); @@ -313,7 +313,7 @@ void
[webkit-changes] [252225] trunk/LayoutTests
Title: [252225] trunk/LayoutTests Revision 252225 Author justin_...@apple.com Date 2019-11-07 17:35:31 -0800 (Thu, 07 Nov 2019) Log Message [WebGL] Fixing WebGL tests: Add new baselines for iOS bots https://bugs.webkit.org/show_bug.cgi?id=203938 Unreviewed test expectation gardening. Follow-up to https://bugs.webkit.org/show_bug.cgi?id=203908. New baselines for iOS tests generated from simulator. * TestExpectations: * platform/ios/TestExpectations: * platform/ios/webgl/1.0.3/conformance/extensions/get-extension-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/extensions/webgl-draw-buffers-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/more/functions/readPixelsBadArgs-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/more/functions/texImage2DHTML-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/more/functions/texSubImage2DHTML-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added. * platform/ios/webgl/1.0.3/conformance/textures/texture-npot-video-expected.txt: Added. * platform/ios/webgl/2.0.0/conformance/extensions/angle-instanced-arrays-expected.txt: Added. * platform/ios/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations Added Paths trunk/LayoutTests/platform/ios/webgl/1.0.3/ trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/ trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/ trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/get-extension-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/extensions/webgl-draw-buffers-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/ trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/functions/ trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/functions/readPixelsBadArgs-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/functions/texImage2DHTML-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/more/functions/texSubImage2DHTML-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/renderbuffers/ trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/textures/ trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats-expected.txt trunk/LayoutTests/platform/ios/webgl/1.0.3/conformance/textures/texture-npot-video-expected.txt trunk/LayoutTests/platform/ios/webgl/2.0.0/conformance/extensions/ trunk/LayoutTests/platform/ios/webgl/2.0.0/conformance/extensions/angle-instanced-arrays-expected.txt trunk/LayoutTests/platform/ios/webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (252224 => 252225) --- trunk/LayoutTests/ChangeLog 2019-11-08 01:29:07 UTC (rev 252224) +++ trunk/LayoutTests/ChangeLog 2019-11-08 01:35:31 UTC (rev 252225) @@ -1,5 +1,30 @@ 2019-11-07 Justin Fan +[WebGL] Fixing WebGL tests: Add new baselines for iOS bots +https://bugs.webkit.org/show_bug.cgi?id=203938 + +Unreviewed test expectation gardening. + +Follow-up to https://bugs.webkit.org/show_bug.cgi?id=203908. +New baselines for iOS tests generated from simulator. + +* TestExpectations: +* platform/ios/TestExpectations: +* platform/ios/webgl/1.0.3/conformance/extensions/get-extension-expected.txt: Added. +* platform/ios/webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt: Added. +* platform/ios/webgl/1.0.3/conformance/extensions/webgl-compressed-texture-size-limit-expected.txt: Added. +* platform/ios/webgl/1.0.3/conformance/extensions/webgl-draw-buffers-expected.txt: Added. +* platform/ios/webgl/1.0.3/conformance/more/functions/readPixelsBadArgs-expected.txt: Added. +* platform/ios/webgl/1.0.3/conformance/more/functions/texImage2DHTML-expected.txt: Added. +* platform/ios/webgl/1.0.3/conformance/more/functions/texSubImage2DHTML-expected.txt: Added. +* platform/ios/webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added. +*
[webkit-changes] [252226] trunk/Source/WebCore
Title: [252226] trunk/Source/WebCore Revision 252226 Author commit-qu...@webkit.org Date 2019-11-07 17:38:26 -0800 (Thu, 07 Nov 2019) Log Message Please support WEBGL_compressed_texture_etc1 extension (and possibly WEBGL_compressed_texture_etc too) https://bugs.webkit.org/show_bug.cgi?id=197900 Patch by Kenneth Russell on 2019-11-07 Reviewed by Dean Jackson. Support the ETC1 and ETC2 compressed texture formats in WebKit's WebGL implementation. Tested by changing the code to allocate an OpenGL ES 3.0 context for WebGL, and running in the iOS Simulator. The WebGL conformance tests webgl-compressed-texture-etc.html and webgl-compressed-texture-etc1.html all pass with these changes. When an ANGLE backend is supported on iOS, these extensions will automatically be supported, and some of the new validation code can be removed. * CMakeLists.txt: * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSDOMConvertWebGL.cpp: (WebCore::convertToJSValue): * html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getExtension): (WebCore::WebGL2RenderingContext::getSupportedExtensions): * html/canvas/WebGLCompressedTextureETC.cpp: Added. (WebCore::WebGLCompressedTextureETC::WebGLCompressedTextureETC): (WebCore::WebGLCompressedTextureETC::getName const): (WebCore::WebGLCompressedTextureETC::supported): * html/canvas/WebGLCompressedTextureETC.h: Added. * html/canvas/WebGLCompressedTextureETC.idl: Added. * html/canvas/WebGLCompressedTextureETC1.cpp: Added. (WebCore::WebGLCompressedTextureETC1::WebGLCompressedTextureETC1): (WebCore::WebGLCompressedTextureETC1::getName const): (WebCore::WebGLCompressedTextureETC1::supported): * html/canvas/WebGLCompressedTextureETC1.h: Added. * html/canvas/WebGLCompressedTextureETC1.idl: Added. * html/canvas/WebGLExtension.h: * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions): * html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::extensionIsEnabled): (WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData): (WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions): (WebCore::WebGLRenderingContextBase::validateCompressedTexSubDimensions): * html/canvas/WebGLRenderingContextBase.h: * platform/graphics/Extensions3D.h: * platform/graphics/cocoa/GraphicsContext3DCocoa.mm: (WebCore::GraphicsContext3D::GraphicsContext3D): * platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supportsExtension): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources-input.xcfilelist trunk/Source/WebCore/DerivedSources-output.xcfilelist trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGLExtension.h trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h trunk/Source/WebCore/platform/graphics/Extensions3D.h trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp Added Paths trunk/Source/WebCore/html/canvas/WebGLCompressedTextureETC.cpp trunk/Source/WebCore/html/canvas/WebGLCompressedTextureETC.h trunk/Source/WebCore/html/canvas/WebGLCompressedTextureETC.idl trunk/Source/WebCore/html/canvas/WebGLCompressedTextureETC1.cpp trunk/Source/WebCore/html/canvas/WebGLCompressedTextureETC1.h trunk/Source/WebCore/html/canvas/WebGLCompressedTextureETC1.idl Diff Modified: trunk/Source/WebCore/CMakeLists.txt (252225 => 252226) --- trunk/Source/WebCore/CMakeLists.txt 2019-11-08 01:35:31 UTC (rev 252225) +++ trunk/Source/WebCore/CMakeLists.txt 2019-11-08 01:38:26 UTC (rev 252226) @@ -1314,6 +1314,8 @@ html/canvas/WebGLBuffer.cpp html/canvas/WebGLCompressedTextureASTC.cpp html/canvas/WebGLCompressedTextureATC.cpp +html/canvas/WebGLCompressedTextureETC.cpp +html/canvas/WebGLCompressedTextureETC1.cpp html/canvas/WebGLCompressedTexturePVRTC.cpp html/canvas/WebGLCompressedTextureS3TC.cpp html/canvas/WebGLContextEvent.cpp @@ -1363,6 +1365,8 @@ html/canvas/WebGLBuffer.idl html/canvas/WebGLCompressedTextureASTC.idl html/canvas/WebGLCompressedTextureATC.idl +html/canvas/WebGLCompressedTextureETC.idl +html/canvas/WebGLCompressedTextureETC1.idl html/canvas/WebGLCompressedTexturePVRTC.idl html/canvas/WebGLCompressedTextureS3TC.idl html/canvas/WebGLContextAttributes.idl Modified:
[webkit-changes] [252224] trunk/Source/bmalloc
Title: [252224] trunk/Source/bmalloc Revision 252224 Author ysuz...@apple.com Date 2019-11-07 17:29:07 -0800 (Thu, 07 Nov 2019) Log Message [bmalloc] Bug fix for wait time when it's in mini mode. https://bugs.webkit.org/show_bug.cgi?id=203121 Reviewed by Saam Barati. Basuke pointed out that we never changed m_waitTime in scavenger when we are in iOS and mini-mode. So previously, we are always executing scavenger for each 10ms in mini-mode. After fixing it, we found that this unintentional behavior was better policy for RAMification. In this patch, we explicitly use the old behavior, "scavenge for each 10ms" in iOS mini-mode. We should revisit scavenger's behavior in the future to explore further better behavior. * bmalloc/Scavenger.cpp: (bmalloc::Scavenger::threadRunLoop): Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/Scavenger.cpp Diff Modified: trunk/Source/bmalloc/ChangeLog (252223 => 252224) --- trunk/Source/bmalloc/ChangeLog 2019-11-08 01:18:14 UTC (rev 252223) +++ trunk/Source/bmalloc/ChangeLog 2019-11-08 01:29:07 UTC (rev 252224) @@ -1,3 +1,19 @@ +2019-11-07 Basuke Suzuki and Yusuke Suzuki + +[bmalloc] Bug fix for wait time when it's in mini mode. +https://bugs.webkit.org/show_bug.cgi?id=203121 + +Reviewed by Saam Barati. + +Basuke pointed out that we never changed m_waitTime in scavenger when we are in iOS and mini-mode. +So previously, we are always executing scavenger for each 10ms in mini-mode. After fixing it, we +found that this unintentional behavior was better policy for RAMification. +In this patch, we explicitly use the old behavior, "scavenge for each 10ms" in iOS mini-mode. +We should revisit scavenger's behavior in the future to explore further better behavior. + +* bmalloc/Scavenger.cpp: +(bmalloc::Scavenger::threadRunLoop): + 2019-11-06 Yusuke Suzuki Unreviewed, roll-out r251268 due to RAMification regression Modified: trunk/Source/bmalloc/bmalloc/Scavenger.cpp (252223 => 252224) --- trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2019-11-08 01:18:14 UTC (rev 252223) +++ trunk/Source/bmalloc/bmalloc/Scavenger.cpp 2019-11-08 01:29:07 UTC (rev 252224) @@ -495,15 +495,11 @@ static_cast(std::chrono::duration_cast(timeSpentScavenging).count()) / 1000); } -std::chrono::milliseconds newWaitTime; - -if (m_isInMiniMode) { -timeSpentScavenging *= 50; -newWaitTime = std::chrono::duration_cast(timeSpentScavenging); -newWaitTime = std::min(std::max(newWaitTime, std::chrono::milliseconds(25)), std::chrono::milliseconds(500)); -} else { +// FIXME: We need to investigate mini-mode's adjustment. +// https://bugs.webkit.org/show_bug.cgi?id=203987 +if (!m_isInMiniMode) { timeSpentScavenging *= 150; -newWaitTime = std::chrono::duration_cast(timeSpentScavenging); +std::chrono::milliseconds newWaitTime = std::chrono::duration_cast(timeSpentScavenging); m_waitTime = std::min(std::max(newWaitTime, std::chrono::milliseconds(100)), std::chrono::milliseconds(1)); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252223] trunk/Source/WebKit
Title: [252223] trunk/Source/WebKit Revision 252223 Author timothy_hor...@apple.com Date 2019-11-07 17:18:14 -0800 (Thu, 07 Nov 2019) Log Message Remove an unused icon resource https://bugs.webkit.org/show_bug.cgi?id=203983 Reviewed by Wenson Hsieh. * Resources/mac/mediaIcon.pdf: Removed. * WebKit.xcodeproj/project.pbxproj: This file has not been used in years. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Removed Paths trunk/Source/WebKit/Resources/mac/ Diff Modified: trunk/Source/WebKit/ChangeLog (25 => 252223) --- trunk/Source/WebKit/ChangeLog 2019-11-08 01:15:24 UTC (rev 25) +++ trunk/Source/WebKit/ChangeLog 2019-11-08 01:18:14 UTC (rev 252223) @@ -1,3 +1,14 @@ +2019-11-07 Tim Horton + +Remove an unused icon resource +https://bugs.webkit.org/show_bug.cgi?id=203983 + +Reviewed by Wenson Hsieh. + +* Resources/mac/mediaIcon.pdf: Removed. +* WebKit.xcodeproj/project.pbxproj: +This file has not been used in years. + 2019-11-07 Per Arne Vollan [iOS] Add logging and telemetry to more mach lookup rules Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (25 => 252223) --- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2019-11-08 01:15:24 UTC (rev 25) +++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2019-11-08 01:18:14 UTC (rev 252223) @@ -1305,7 +1305,6 @@ 939F401C19FB0BBC002B2B42 /* WKActionMenuTypes.h in Headers */ = {isa = PBXBuildFile; fileRef = 939F401B19FB0BBC002B2B42 /* WKActionMenuTypes.h */; settings = {ATTRIBUTES = (Private, ); }; }; 93A253ED1C922E1E00F9F68D /* WKPreviewActionItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 93A253EC1C922E1E00F9F68D /* WKPreviewActionItem.h */; settings = {ATTRIBUTES = (Public, ); }; }; 93A253F31C92411200F9F68D /* WKPreviewActionItemIdentifiers.h in Headers */ = {isa = PBXBuildFile; fileRef = 93A253F21C92411200F9F68D /* WKPreviewActionItemIdentifiers.h */; settings = {ATTRIBUTES = (Public, ); }; }; - 93A2A3461D246125002B59D3 /* mediaIcon.pdf in Resources */ = {isa = PBXBuildFile; fileRef = 93A2A3451D246125002B59D3 /* mediaIcon.pdf */; }; 93A88B331BC6E9CD00ABA5C2 /* WebHitTestResultData.h in Headers */ = {isa = PBXBuildFile; fileRef = 93A88B311BC6E9C000ABA5C2 /* WebHitTestResultData.h */; }; 93A88B3B1BC710D900ABA5C2 /* _WKHitTestResultInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 93A88B3A1BC710D900ABA5C2 /* _WKHitTestResultInternal.h */; }; 93A88B461BC8829300ABA5C2 /* APIHitTestResult.h in Headers */ = {isa = PBXBuildFile; fileRef = 93A88B431BC8828C00ABA5C2 /* APIHitTestResult.h */; }; @@ -3998,7 +3997,6 @@ 93A253EE1C922E8E00F9F68D /* WKPreviewActionItem.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKPreviewActionItem.mm; sourceTree = ""; }; 93A253F21C92411200F9F68D /* WKPreviewActionItemIdentifiers.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKPreviewActionItemIdentifiers.h; sourceTree = ""; }; 93A253F41C92413200F9F68D /* WKPreviewActionItemIdentifiers.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WKPreviewActionItemIdentifiers.mm; sourceTree = ""; }; - 93A2A3451D246125002B59D3 /* mediaIcon.pdf */ = {isa = PBXFileReference; lastKnownFileType = image.pdf; path = mediaIcon.pdf; sourceTree = ""; }; 93A88B2E1BC6E98F00ABA5C2 /* WebHitTestResultData.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebHitTestResultData.mm; sourceTree = ""; }; 93A88B311BC6E9C000ABA5C2 /* WebHitTestResultData.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebHitTestResultData.h; sourceTree = ""; }; 93A88B341BC6EABA00ABA5C2 /* WebHitTestResultData.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebHitTestResultData.cpp; sourceTree = ""; }; @@ -4953,7 +4951,6 @@ isa = PBXGroup; children = ( 372887982000AA3700F4EF5D /* ios */, -37F8C94F1AE22BD8007DAB9E /* mac */, 7CB16FE11724B9B5007A0A95 /* PlugInSandboxProfiles */, 6BE969BF1E54D452008B7483 /* ResourceLoadStatistics */, A78CCDD5193AC9E3005ECC25 /* SandboxProfiles */, @@ -6647,15 +6644,6 @@ path = Cocoa; sourceTree = ""; }; - 37F8C94F1AE22BD8007DAB9E /* mac */ = { - isa = PBXGroup; - children = ( -93A2A3451D246125002B59D3 /* mediaIcon.pdf */, - ); - name = mac; - path = Resources/mac; - sourceTree = ""; - }; 413075971DE84ED70039EC69 /* webrtc */ = { isa = PBXGroup; children = ( @@ -10753,7 +10741,6 @@ 587743A621C30BBE00AE9084 /* HTTPSUpgradeList.db in Resources */, 8DC2EF530486A6940098B216 /* InfoPlist.strings in Resources */, 3FB08E431F60B240005E5312 /* iOS.xcassets in Resources */, -93A2A3461D246125002B59D3 /*
[webkit-changes] [252221] trunk
Title: [252221] trunk Revision 252221 Author rn...@webkit.org Date 2019-11-07 17:13:19 -0800 (Thu, 07 Nov 2019) Log Message WindowEventLoop should be shared among similar origin documents https://bugs.webkit.org/show_bug.cgi?id=203882 Reviewed by Wenson Hsieh. Source/WebCore: Made WindowEventLoop shared across similar origin documents. Also added internals.queueTask to directly test the event loop behavior since implicitly testing it via other features has been very cumbersome. This will help test other features that use the HTML5 event loop as well. Tests: http/tests/eventloop/queue-task-across-cross-site-frames.html http/tests/eventloop/queue-task-across-frames.html * dom/Document.cpp: (WebCore::Document::eventLoop): Use WindowEventLoop::ensureForRegistrableDomain. * dom/WindowEventLoop.cpp: (WebCore::WindowEventLoop::ensureForRegistrableDomain): Added. Replaces create, and returns an existing WindowEventLoop if the RegistrableDomain matches. (WebCore::WindowEventLoop::WindowEventLoop): Added. (WebCore::WindowEventLoop::~WindowEventLoop): Added. Removes itself from the map. * dom/WindowEventLoop.h: * testing/Internals.cpp: (WebCore::Internals::queueTask): Added. * testing/Internals.h: * testing/Internals.idl: LayoutTests: Added some tests to make sure the event loop is shared among similar origin documents. * http/tests/eventloop: Added. * http/tests/eventloop/queue-task-across-cross-site-frames-expected.txt: Added. * http/tests/eventloop/queue-task-across-cross-site-frames.html: Added. * http/tests/eventloop/queue-task-across-frames-expected.txt: Added. * http/tests/eventloop/queue-task-across-frames.html: Added. * http/tests/eventloop/resources: Added. * http/tests/eventloop/resources/eventloop-helper.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/WindowEventLoop.cpp trunk/Source/WebCore/dom/WindowEventLoop.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl Added Paths trunk/LayoutTests/http/tests/eventloop/ trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames-expected.txt trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html trunk/LayoutTests/http/tests/eventloop/queue-task-across-frames-expected.txt trunk/LayoutTests/http/tests/eventloop/queue-task-across-frames.html trunk/LayoutTests/http/tests/eventloop/resources/ trunk/LayoutTests/http/tests/eventloop/resources/eventloop-helper.html Diff Modified: trunk/LayoutTests/ChangeLog (252220 => 252221) --- trunk/LayoutTests/ChangeLog 2019-11-08 01:08:11 UTC (rev 252220) +++ trunk/LayoutTests/ChangeLog 2019-11-08 01:13:19 UTC (rev 252221) @@ -1,3 +1,20 @@ +2019-11-07 Ryosuke Niwa + +WindowEventLoop should be shared among similar origin documents +https://bugs.webkit.org/show_bug.cgi?id=203882 + +Reviewed by Wenson Hsieh. + +Added some tests to make sure the event loop is shared among similar origin documents. + +* http/tests/eventloop: Added. +* http/tests/eventloop/queue-task-across-cross-site-frames-expected.txt: Added. +* http/tests/eventloop/queue-task-across-cross-site-frames.html: Added. +* http/tests/eventloop/queue-task-across-frames-expected.txt: Added. +* http/tests/eventloop/queue-task-across-frames.html: Added. +* http/tests/eventloop/resources: Added. +* http/tests/eventloop/resources/eventloop-helper.html: Added. + 2019-11-07 youenn fablet Layout Test http/tests/appcache/remove-cache.html is a flaky failure Added: trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames-expected.txt (0 => 252221) --- trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames-expected.txt 2019-11-08 01:13:19 UTC (rev 252221) @@ -0,0 +1,11 @@ +This tests the order by which tasks are scheduled across documents that are not similar origins. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS logs.join(", ") is "1, 2, 3, 4, 5" +PASS crossOriginLogs.join(", ") is "10, 11, 12" +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html (0 => 252221) --- trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html (rev 0) +++ trunk/LayoutTests/http/tests/eventloop/queue-task-across-cross-site-frames.html 2019-11-08 01:13:19 UTC (rev 252221) @@ -0,0 +1,86 @@ + + + + + +description('This tests the order by which tasks are scheduled across documents that are not similar origins.'); + +if (!window.internals) +testFailed('This test relies on window.internals'); +else { +
[webkit-changes] [252222] trunk/LayoutTests
Title: [25] trunk/LayoutTests Revision 25 Author justin_...@apple.com Date 2019-11-07 17:15:24 -0800 (Thu, 07 Nov 2019) Log Message webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky https://bugs.webkit.org/show_bug.cgi?id=203984 Unreviewed test expectation addition. Skip context-release-upon-reload.html on High Sierra WK1 debug bots. * platform/mac-highsierra-wk1/TestExpectations: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (252221 => 25) --- trunk/LayoutTests/ChangeLog 2019-11-08 01:13:19 UTC (rev 252221) +++ trunk/LayoutTests/ChangeLog 2019-11-08 01:15:24 UTC (rev 25) @@ -1,3 +1,14 @@ +2019-11-07 Justin Fan + +webgl/1.0.3/conformance/context/context-release-upon-reload.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=203984 + +Unreviewed test expectation addition. + +Skip context-release-upon-reload.html on High Sierra WK1 debug bots. + +* platform/mac-highsierra-wk1/TestExpectations: Added. + 2019-11-07 Ryosuke Niwa WindowEventLoop should be shared among similar origin documents Added: trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations (0 => 25) --- trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations (rev 0) +++ trunk/LayoutTests/platform/mac-highsierra-wk1/TestExpectations 2019-11-08 01:15:24 UTC (rev 25) @@ -0,0 +1,6 @@ +# These are the layout test expectations for Apple's Mac port of WebKit Legacy +# +# See http://trac.webkit.org/wiki/TestExpectations for more information on this file. +# + +webkit.org/b/203984 [ Debug ] webgl/1.0.3/conformance/context/context-release-upon-reload.html [ Skip ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252220] tags/Safari-609.1.10.1/Source
Title: [252220] tags/Safari-609.1.10.1/Source Revision 252220 Author alanc...@apple.com Date 2019-11-07 17:08:11 -0800 (Thu, 07 Nov 2019) Log Message Versioning. Modified Paths tags/Safari-609.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-609.1.10.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-609.1.10.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-609.1.10.1/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-609.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-609.1.10.1/Source/WebKit/Configurations/Version.xcconfig tags/Safari-609.1.10.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-609.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig (252219 => 252220) --- tags/Safari-609.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig 2019-11-08 01:04:20 UTC (rev 252219) +++ tags/Safari-609.1.10.1/Source/_javascript_Core/Configurations/Version.xcconfig 2019-11-08 01:08:11 UTC (rev 252220) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-609.1.10.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (252219 => 252220) --- tags/Safari-609.1.10.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-11-08 01:04:20 UTC (rev 252219) +++ tags/Safari-609.1.10.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-11-08 01:08:11 UTC (rev 252220) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-609.1.10.1/Source/WebCore/Configurations/Version.xcconfig (252219 => 252220) --- tags/Safari-609.1.10.1/Source/WebCore/Configurations/Version.xcconfig 2019-11-08 01:04:20 UTC (rev 252219) +++ tags/Safari-609.1.10.1/Source/WebCore/Configurations/Version.xcconfig 2019-11-08 01:08:11 UTC (rev 252220) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-609.1.10.1/Source/WebCore/PAL/Configurations/Version.xcconfig (252219 => 252220) --- tags/Safari-609.1.10.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-11-08 01:04:20 UTC (rev 252219) +++ tags/Safari-609.1.10.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-11-08 01:08:11 UTC (rev 252220) @@ -24,9 +24,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-609.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig (252219 => 252220) --- tags/Safari-609.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-11-08 01:04:20 UTC (rev 252219) +++ tags/Safari-609.1.10.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-11-08 01:08:11 UTC (rev 252220) @@ -1,9 +1,9 @@ MAJOR_VERSION = 609; MINOR_VERSION = 1; TINY_VERSION = 10; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-609.1.10.1/Source/WebKit/Configurations/Version.xcconfig (252219 => 252220) --- tags/Safari-609.1.10.1/Source/WebKit/Configurations/Version.xcconfig 2019-11-08 01:04:20 UTC (rev 252219) +++ tags/Safari-609.1.10.1/Source/WebKit/Configurations/Version.xcconfig 2019-11-08 01:08:11 UTC (rev 252220) @@ -24,9
[webkit-changes] [252218] trunk/Source/WebCore
Title: [252218] trunk/Source/WebCore Revision 252218 Author cdu...@apple.com Date 2019-11-07 16:57:59 -0800 (Thu, 07 Nov 2019) Log Message Drop GenericEventQueue class now that it is unused https://bugs.webkit.org/show_bug.cgi?id=203980 Reviewed by Ryosuke Niwa. Drop GenericEventQueue class now that it is unused. All users have been ported to the HTML event loop. MainThreadGenericEventQueue remains for now but will get dropped in a follow-up patch, once it is no longer used. * dom/GenericEventQueue.cpp: (WebCore::MainThreadGenericEventQueue::MainThreadGenericEventQueue): (WebCore::MainThreadGenericEventQueue::enqueueEvent): (WebCore::MainThreadGenericEventQueue::dispatchOneEvent): (WebCore::MainThreadGenericEventQueue::close): (WebCore::MainThreadGenericEventQueue::cancelAllEvents): (WebCore::MainThreadGenericEventQueue::hasPendingEvents const): (WebCore::MainThreadGenericEventQueue::hasPendingEventsOfType const): (WebCore::MainThreadGenericEventQueue::setPaused): (WebCore::MainThreadGenericEventQueue::suspend): (WebCore::MainThreadGenericEventQueue::resume): (WebCore::MainThreadGenericEventQueue::rescheduleAllEventsIfNeeded): (WebCore::MainThreadGenericEventQueue::stop): (WebCore::MainThreadGenericEventQueue::activeDOMObjectName const): (WebCore::TaskQueueConstructor::construct): Deleted. (WebCore::TaskQueueConstructor::construct): Deleted. (WebCore::GenericEventQueueBase::GenericEventQueueBase): Deleted. (WebCore::GenericEventQueueBase::enqueueEvent): Deleted. (WebCore::GenericEventQueueBase::dispatchOneEvent): Deleted. (WebCore::GenericEventQueueBase::close): Deleted. (WebCore::GenericEventQueueBase::cancelAllEvents): Deleted. (WebCore::GenericEventQueueBase::hasPendingEvents const): Deleted. (WebCore::GenericEventQueueBase::hasPendingEventsOfType const): Deleted. (WebCore::GenericEventQueueBase::setPaused): Deleted. (WebCore::GenericEventQueueBase::suspend): Deleted. (WebCore::GenericEventQueueBase::resume): Deleted. (WebCore::GenericEventQueueBase::rescheduleAllEventsIfNeeded): Deleted. (WebCore::GenericEventQueueBase::stop): Deleted. (WebCore::GenericEventQueueBase::activeDOMObjectName const): Deleted. (WebCore::GenericEventQueue::create): Deleted. * dom/GenericEventQueue.h: (WebCore::GenericEventQueueBase::isSuspended const): Deleted. (WebCore::GenericEventQueueBase::isSuspendedOrPausedByClient const): Deleted. (WebCore::MainThreadGenericEventQueue::MainThreadGenericEventQueue): Deleted. (WebCore::GenericEventQueue::GenericEventQueue): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/GenericEventQueue.cpp trunk/Source/WebCore/dom/GenericEventQueue.h Diff Modified: trunk/Source/WebCore/ChangeLog (252217 => 252218) --- trunk/Source/WebCore/ChangeLog 2019-11-08 00:52:28 UTC (rev 252217) +++ trunk/Source/WebCore/ChangeLog 2019-11-08 00:57:59 UTC (rev 252218) @@ -1,5 +1,52 @@ 2019-11-07 Chris Dumez +Drop GenericEventQueue class now that it is unused +https://bugs.webkit.org/show_bug.cgi?id=203980 + +Reviewed by Ryosuke Niwa. + +Drop GenericEventQueue class now that it is unused. All users have been ported to the HTML +event loop. MainThreadGenericEventQueue remains for now but will get dropped in a follow-up +patch, once it is no longer used. + +* dom/GenericEventQueue.cpp: +(WebCore::MainThreadGenericEventQueue::MainThreadGenericEventQueue): +(WebCore::MainThreadGenericEventQueue::enqueueEvent): +(WebCore::MainThreadGenericEventQueue::dispatchOneEvent): +(WebCore::MainThreadGenericEventQueue::close): +(WebCore::MainThreadGenericEventQueue::cancelAllEvents): +(WebCore::MainThreadGenericEventQueue::hasPendingEvents const): +(WebCore::MainThreadGenericEventQueue::hasPendingEventsOfType const): +(WebCore::MainThreadGenericEventQueue::setPaused): +(WebCore::MainThreadGenericEventQueue::suspend): +(WebCore::MainThreadGenericEventQueue::resume): +(WebCore::MainThreadGenericEventQueue::rescheduleAllEventsIfNeeded): +(WebCore::MainThreadGenericEventQueue::stop): +(WebCore::MainThreadGenericEventQueue::activeDOMObjectName const): +(WebCore::TaskQueueConstructor::construct): Deleted. +(WebCore::TaskQueueConstructor::construct): Deleted. +(WebCore::GenericEventQueueBase::GenericEventQueueBase): Deleted. +(WebCore::GenericEventQueueBase::enqueueEvent): Deleted. +(WebCore::GenericEventQueueBase::dispatchOneEvent): Deleted. +(WebCore::GenericEventQueueBase::close): Deleted. +(WebCore::GenericEventQueueBase::cancelAllEvents): Deleted. +(WebCore::GenericEventQueueBase::hasPendingEvents const): Deleted. +(WebCore::GenericEventQueueBase::hasPendingEventsOfType const): Deleted. +(WebCore::GenericEventQueueBase::setPaused): Deleted. +(WebCore::GenericEventQueueBase::suspend): Deleted. +
[webkit-changes] [252219] tags/Safari-609.1.10.1/
Title: [252219] tags/Safari-609.1.10.1/ Revision 252219 Author alanc...@apple.com Date 2019-11-07 17:04:20 -0800 (Thu, 07 Nov 2019) Log Message New tag. Added Paths tags/Safari-609.1.10.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252217] trunk/LayoutTests
Title: [252217] trunk/LayoutTests Revision 252217 Author you...@apple.com Date 2019-11-07 16:52:28 -0800 (Thu, 07 Nov 2019) Log Message Layout Test http/tests/appcache/remove-cache.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=199124 Reviewed by Chris Dumez. The flakiness probably comes from the use of a setTimeout that might kick in while in most runs, it never kicks in. When the timer kicks in, the test is reloaded, which triggers a new console log line. The current console lines do not bring more values than what the test checks with appcache events. Removing console log lines from the expected file will fix the flakiness. * TestExpectations: * http/tests/appcache/remove-cache-expected.txt: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/http/tests/appcache/remove-cache-expected.txt trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (252216 => 252217) --- trunk/LayoutTests/ChangeLog 2019-11-08 00:37:52 UTC (rev 252216) +++ trunk/LayoutTests/ChangeLog 2019-11-08 00:52:28 UTC (rev 252217) @@ -1,3 +1,20 @@ +2019-11-07 youenn fablet + +Layout Test http/tests/appcache/remove-cache.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=199124 + + +Reviewed by Chris Dumez. + +The flakiness probably comes from the use of a setTimeout that might kick in while in most runs, it never kicks in. +When the timer kicks in, the test is reloaded, which triggers a new console log line. +The current console lines do not bring more values than what the test checks with appcache events. +Removing console log lines from the expected file will fix the flakiness. + +* TestExpectations: +* http/tests/appcache/remove-cache-expected.txt: +* platform/mac/TestExpectations: + 2019-11-07 Yury Semikhatsky Web Inspector: http/tests/inspector/target/target-events-for-provisional-page.html is flaky when running with other tests Modified: trunk/LayoutTests/TestExpectations (252216 => 252217) --- trunk/LayoutTests/TestExpectations 2019-11-08 00:37:52 UTC (rev 252216) +++ trunk/LayoutTests/TestExpectations 2019-11-08 00:52:28 UTC (rev 252217) @@ -2105,6 +2105,8 @@ webkit.org/b/158085 http/tests/css/shared-stylesheet-mutation.html [ Pass Failure ] +http/tests/appcache/remove-cache.html [ DumpJSConsoleLogInStdErr ] + # PiP tests are only relevant on macOS Sierra and newer. media/click-placeholder-not-pausing.html [ WontFix ] media/controls/picture-in-picture.html [ WontFix ] Modified: trunk/LayoutTests/http/tests/appcache/remove-cache-expected.txt (252216 => 252217) --- trunk/LayoutTests/http/tests/appcache/remove-cache-expected.txt 2019-11-08 00:37:52 UTC (rev 252216) +++ trunk/LayoutTests/http/tests/appcache/remove-cache-expected.txt 2019-11-08 00:52:28 UTC (rev 252217) @@ -1,10 +1,3 @@ -CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead. -CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead. -CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead. -CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response. -CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead. -CONSOLE MESSAGE: Application Cache manifest could not be fetched, because the manifest had a 404 response. -CONSOLE MESSAGE: line 1: ApplicationCache is deprecated. Please use ServiceWorkers instead. Test that a 404 response for manifest results in cache removal. Frame 1: Manifest is still available, so a new master resource is added to the cache. Modified: trunk/LayoutTests/platform/mac/TestExpectations (252216 => 252217) --- trunk/LayoutTests/platform/mac/TestExpectations 2019-11-08 00:37:52 UTC (rev 252216) +++ trunk/LayoutTests/platform/mac/TestExpectations 2019-11-08 00:52:28 UTC (rev 252217) @@ -1944,8 +1944,6 @@ webkit.org/b/181837 [ Release ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Pass Failure ] -webkit.org/b/199124 http/tests/appcache/remove-cache.html [ Pass Failure ] - # rdar://55405851 ([ macOS ] Layout tests webgpu/*-triangle-strip.html are flaky failures. (201827)) webkit.org/b/201827 webgpu/blend-color-triangle-strip.html [ Pass ImageOnlyFailure ] webkit.org/b/201827 webgpu/blend-triangle-strip.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252216] trunk/Source/JavaScriptCore
Title: [252216] trunk/Source/_javascript_Core Revision 252216 Author tzaga...@apple.com Date 2019-11-07 16:37:52 -0800 (Thu, 07 Nov 2019) Log Message [WebAssembly] Inspector's DebuggerCallFrame should be aware of Wasm frames https://bugs.webkit.org/show_bug.cgi?id=203925 Reviewed by Mark Lam. The DebuggerCallFrame checks for CallFrame::codeBlock to determine if it the current frame is a valid JS frame, but since the Wasm interpreter stores the Wasm::FunctionCodeBlock to this slot, that check is not sufficient. Add an extra check for CalleeBits::isWasm. * debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::sourceIDForCallFrame): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (252215 => 252216) --- trunk/Source/_javascript_Core/ChangeLog 2019-11-07 23:56:04 UTC (rev 252215) +++ trunk/Source/_javascript_Core/ChangeLog 2019-11-08 00:37:52 UTC (rev 252216) @@ -1,3 +1,17 @@ +2019-11-07 Tadeu Zagallo + +[WebAssembly] Inspector's DebuggerCallFrame should be aware of Wasm frames +https://bugs.webkit.org/show_bug.cgi?id=203925 + +Reviewed by Mark Lam. + +The DebuggerCallFrame checks for CallFrame::codeBlock to determine if it the current frame is a +valid JS frame, but since the Wasm interpreter stores the Wasm::FunctionCodeBlock to this slot, +that check is not sufficient. Add an extra check for CalleeBits::isWasm. + +* debugger/DebuggerCallFrame.cpp: +(JSC::DebuggerCallFrame::sourceIDForCallFrame): + 2019-11-07 Devin Rousso Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is timing out Modified: trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp (252215 => 252216) --- trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp 2019-11-07 23:56:04 UTC (rev 252215) +++ trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.cpp 2019-11-08 00:37:52 UTC (rev 252216) @@ -320,7 +320,7 @@ if (!callFrame) return noSourceID; CodeBlock* codeBlock = callFrame->codeBlock(); -if (!codeBlock) +if (!codeBlock || callFrame->callee().isWasm()) return noSourceID; return codeBlock->ownerExecutable()->sourceID(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252215] tags/Safari-608.4.9.1.2/
Title: [252215] tags/Safari-608.4.9.1.2/ Revision 252215 Author alanc...@apple.com Date 2019-11-07 15:56:04 -0800 (Thu, 07 Nov 2019) Log Message Tag Safari-608.4.9.1.2. Added Paths tags/Safari-608.4.9.1.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252214] trunk/LayoutTests
Title: [252214] trunk/LayoutTests Revision 252214 Author yu...@chromium.org Date 2019-11-07 15:44:55 -0800 (Thu, 07 Nov 2019) Log Message Web Inspector: http/tests/inspector/target/target-events-for-provisional-page.html is flaky when running with other tests https://bugs.webkit.org/show_bug.cgi?id=203965 Reviewed by Devin Rousso. Enforce enableProcessSwapOnWindowOpen=true for the test so that it PSON is enabled regardless of other tests that may run before (the test may reuse Page instance from the previous test on which Page::openedByDOMWithOpener==true). * http/tests/inspector/target/target-events-for-provisional-page.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/target/target-events-for-provisional-page.html Diff Modified: trunk/LayoutTests/ChangeLog (252213 => 252214) --- trunk/LayoutTests/ChangeLog 2019-11-07 23:39:56 UTC (rev 252213) +++ trunk/LayoutTests/ChangeLog 2019-11-07 23:44:55 UTC (rev 252214) @@ -1,3 +1,17 @@ +2019-11-07 Yury Semikhatsky + +Web Inspector: http/tests/inspector/target/target-events-for-provisional-page.html is flaky when running with other tests +https://bugs.webkit.org/show_bug.cgi?id=203965 + + +Reviewed by Devin Rousso. + +Enforce enableProcessSwapOnWindowOpen=true for the test so that it PSON is enabled regardless of other tests +that may run before (the test may reuse Page instance from the previous test on which +Page::openedByDOMWithOpener==true). + +* http/tests/inspector/target/target-events-for-provisional-page.html: + 2019-11-07 Kate Cheney Many resourceLoadStatistics tests and storageAccess tests using the ITP Modified: trunk/LayoutTests/http/tests/inspector/target/target-events-for-provisional-page.html (252213 => 252214) --- trunk/LayoutTests/http/tests/inspector/target/target-events-for-provisional-page.html 2019-11-07 23:39:56 UTC (rev 252213) +++ trunk/LayoutTests/http/tests/inspector/target/target-events-for-provisional-page.html 2019-11-07 23:44:55 UTC (rev 252214) @@ -1,4 +1,4 @@ - + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252213] trunk/Source/WebInspectorUI
Title: [252213] trunk/Source/WebInspectorUI Revision 252213 Author drou...@apple.com Date 2019-11-07 15:39:56 -0800 (Thu, 07 Nov 2019) Log Message Web Inspector: REGRESSION(r251958): console prompt is automatically focused when page is reloaded https://bugs.webkit.org/show_bug.cgi?id=203932 Reviewed by Timothy Hatcher. * UserInterface/Base/Main.js: (WI._restoreCookieForOpenTabs): Only attempt to autofocus when Web Inspector is first opened. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Base/Main.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (252212 => 252213) --- trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 23:24:35 UTC (rev 252212) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 23:39:56 UTC (rev 252213) @@ -1,5 +1,16 @@ 2019-11-07 Devin Rousso +Web Inspector: REGRESSION(r251958): console prompt is automatically focused when page is reloaded +https://bugs.webkit.org/show_bug.cgi?id=203932 + +Reviewed by Timothy Hatcher. + +* UserInterface/Base/Main.js: +(WI._restoreCookieForOpenTabs): +Only attempt to autofocus when Web Inspector is first opened. + +2019-11-07 Devin Rousso + Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is timing out https://bugs.webkit.org/show_bug.cgi?id=202934 Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (252212 => 252213) --- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-11-07 23:24:35 UTC (rev 252212) +++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-11-07 23:39:56 UTC (rev 252213) @@ -1571,13 +1571,16 @@ tabContentView.restoreStateFromCookie(restorationType); } -window.requestAnimationFrame(() => { -if (WI.isContentAreaFocused() || WI.isShowingTimelineTab() || WI.isShowingAuditTab()) -return; +// Only attempt to autofocus when Web Inspector is first opened. +if (WI._didAutofocusConsolePrompt === undefined) { +window.requestAnimationFrame(() => { +if (WI.isContentAreaFocused() || WI.isShowingTimelineTab() || WI.isShowingAuditTab()) +return; -WI.quickConsole.prompt.focus(); -WI._didAutofocusConsolePrompt = true; -}); +WI.quickConsole.prompt.focus(); +WI._didAutofocusConsolePrompt = true; +}); +} }; WI._saveCookieForOpenTabs = function() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252212] trunk/Source/WebCore
Title: [252212] trunk/Source/WebCore Revision 252212 Author cdu...@apple.com Date 2019-11-07 15:24:35 -0800 (Thu, 07 Nov 2019) Log Message Port Worker to the HTML5 event loop https://bugs.webkit.org/show_bug.cgi?id=203919 Reviewed by Ryosuke Niwa. * dom/ActiveDOMObject.h: * workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::terminate): (WebCore::Worker::hasPendingActivity const): (WebCore::Worker::notifyFinished): (WebCore::Worker::dispatchEvent): (WebCore::Worker::enqueueEvent): Deleted. * workers/Worker.h: * workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ActiveDOMObject.h trunk/Source/WebCore/workers/Worker.cpp trunk/Source/WebCore/workers/Worker.h trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (252211 => 252212) --- trunk/Source/WebCore/ChangeLog 2019-11-07 23:20:01 UTC (rev 252211) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 23:24:35 UTC (rev 252212) @@ -1,5 +1,25 @@ 2019-11-07 Chris Dumez +Port Worker to the HTML5 event loop +https://bugs.webkit.org/show_bug.cgi?id=203919 + +Reviewed by Ryosuke Niwa. + +* dom/ActiveDOMObject.h: +* workers/Worker.cpp: +(WebCore::Worker::Worker): +(WebCore::Worker::terminate): +(WebCore::Worker::hasPendingActivity const): +(WebCore::Worker::notifyFinished): +(WebCore::Worker::dispatchEvent): +(WebCore::Worker::enqueueEvent): Deleted. +* workers/Worker.h: +* workers/WorkerMessagingProxy.cpp: +(WebCore::WorkerMessagingProxy::postMessageToWorkerObject): +(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject): + +2019-11-07 Chris Dumez + Port MessagePort to the HTML5 event loop https://bugs.webkit.org/show_bug.cgi?id=203960 Modified: trunk/Source/WebCore/dom/ActiveDOMObject.h (252211 => 252212) --- trunk/Source/WebCore/dom/ActiveDOMObject.h 2019-11-07 23:20:01 UTC (rev 252211) +++ trunk/Source/WebCore/dom/ActiveDOMObject.h 2019-11-07 23:24:35 UTC (rev 252212) @@ -113,12 +113,6 @@ bool isContextStopped() const; bool isAllowedToRunScript() const; -protected: -explicit ActiveDOMObject(ScriptExecutionContext*); -explicit ActiveDOMObject(Document*); -explicit ActiveDOMObject(Document&); -virtual ~ActiveDOMObject(); - template static void queueTaskKeepingObjectAlive(T& object, TaskSource source, Function&& task) { @@ -136,6 +130,12 @@ }); } +protected: +explicit ActiveDOMObject(ScriptExecutionContext*); +explicit ActiveDOMObject(Document*); +explicit ActiveDOMObject(Document&); +virtual ~ActiveDOMObject(); + private: enum CheckedScriptExecutionContextType { CheckedScriptExecutionContext }; ActiveDOMObject(ScriptExecutionContext*, CheckedScriptExecutionContextType); Modified: trunk/Source/WebCore/workers/Worker.cpp (252211 => 252212) --- trunk/Source/WebCore/workers/Worker.cpp 2019-11-07 23:20:01 UTC (rev 252211) +++ trunk/Source/WebCore/workers/Worker.cpp 2019-11-07 23:24:35 UTC (rev 252212) @@ -69,7 +69,6 @@ , m_identifier("worker:" + Inspector::IdentifiersFactory::createIdentifier()) , m_contextProxy(WorkerGlobalScopeProxy::create(*this)) , m_runtimeFlags(runtimeFlags) -, m_eventQueue(GenericEventQueue::create(*this)) { static bool addedListener; if (!addedListener) { @@ -147,7 +146,7 @@ void Worker::terminate() { m_contextProxy.terminateWorkerGlobalScope(); -m_eventQueue->cancelAllEvents(); +m_wasTerminated = true; } const char* Worker::activeDOMObjectName() const @@ -178,7 +177,7 @@ bool Worker::hasPendingActivity() const { -return m_contextProxy.hasPendingActivity() || ActiveDOMObject::hasPendingActivity() || m_eventQueue->hasPendingEvents(); +return m_contextProxy.hasPendingActivity() || ActiveDOMObject::hasPendingActivity(); } void Worker::notifyNetworkStateChange(bool isOnLine) @@ -206,7 +205,7 @@ return; if (m_scriptLoader->failed()) { -enqueueEvent(Event::create(eventNames().errorEvent, Event::CanBubble::No, Event::IsCancelable::Yes)); +queueTaskToDispatchEvent(*this, TaskSource::DOMManipulation, Event::create(eventNames().errorEvent, Event::CanBubble::No, Event::IsCancelable::Yes)); return; } @@ -216,14 +215,10 @@ InspectorInstrumentation::scriptImported(*context, m_scriptLoader->identifier(), m_scriptLoader->script()); } -void Worker::enqueueEvent(Ref&& event) -{ -m_eventQueue->enqueueEvent(WTFMove(event)); -} - void Worker::dispatchEvent(Event& event) { -RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(!m_eventQueue->isSuspended()); +if (m_wasTerminated) +return; AbstractWorker::dispatchEvent(event); if (is(event)
[webkit-changes] [252211] trunk/Source/WebKit
Title: [252211] trunk/Source/WebKit Revision 252211 Author pvol...@apple.com Date 2019-11-07 15:20:01 -0800 (Thu, 07 Nov 2019) Log Message [iOS] Add logging and telemetry to more mach lookup rules https://bugs.webkit.org/show_bug.cgi?id=203978 Reviewed by Brent Fulgham. Add logging and telemetry to help determine if mach lookup of these services can be denied in the WebContent process. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Diff Modified: trunk/Source/WebKit/ChangeLog (252210 => 252211) --- trunk/Source/WebKit/ChangeLog 2019-11-07 23:16:39 UTC (rev 252210) +++ trunk/Source/WebKit/ChangeLog 2019-11-07 23:20:01 UTC (rev 252211) @@ -1,3 +1,14 @@ +2019-11-07 Per Arne Vollan + +[iOS] Add logging and telemetry to more mach lookup rules +https://bugs.webkit.org/show_bug.cgi?id=203978 + +Reviewed by Brent Fulgham. + +Add logging and telemetry to help determine if mach lookup of these services can be denied in the WebContent process. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: + 2019-11-07 Alex Christensen Re-enable NSURLSession isolation after r252116 Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (252210 => 252211) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2019-11-07 23:16:39 UTC (rev 252210) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2019-11-07 23:20:01 UTC (rev 252211) @@ -122,7 +122,8 @@ (define-once (play-audio) (allow mach-lookup - (global-name "com.apple.audio.AURemoteIOServer") + (global-name "com.apple.audio.AURemoteIOServer")) +(allow mach-lookup (with report) (with telemetry) (xpc-service-name "com.apple.audio.toolbox.reporting.service"))) (define-once (play-media . filters) @@ -201,6 +202,8 @@ "com.apple.mobileipod") (allow mach-lookup (global-name "com.apple.mediaremoted.xpc")) +(allow mach-lookup (with report) (with telemetry) +(xpc-service-name "com.apple.MediaPlayer.RemotePlayerService")) ) (define-once (media-capture-support) @@ -627,7 +630,8 @@ (allow ipc-posix-shm-read* (ipc-posix-name-prefix "apple.cfprefs.")) -(allow mach-lookup +(allow mach-lookup (with report) (with telemetry) +(global-name "com.apple.lsd.open") (global-name "com.apple.lsd.mapdb")) ;; @@ -643,6 +647,9 @@ (deny ipc-posix-sem-create ipc-posix-sem-post ipc-posix-sem-unlink ipc-posix-sem-wait) (allow ipc-posix-sem-open)) +(allow mach-lookup (with report) (with telemetry) +(global-name "com.apple.runningboard")) + (allow system-sched (require-entitlement "com.apple.private.kernel.override-cpumon")) @@ -653,6 +660,9 @@ (allow sysctl-read sysctl-write (sysctl-name "vm.footprint_suspend"))) +(allow mach-lookup (with report) (with telemetry) + (global-name "com.apple.system.logger")) + (allow file-read-metadata network-outbound (literal "/private/var/run/syslog")) @@ -661,6 +671,9 @@ (allow ipc-posix-shm-read* (ipc-posix-name "apple.shm.notification_center")) +(allow mach-lookup (with report) (with telemetry) +(global-name "com.apple.diagnosticd")) + (logd-diagnostic-client) (managed-configuration-read-public) @@ -717,7 +730,7 @@ (speech-synthesis-and-voiceover) -(allow mach-lookup +(allow mach-lookup (with report) (with telemetry) (global-name "com.apple.audio.AudioComponentRegistrar")) ;; Permit reading assets via MobileAsset framework. @@ -761,7 +774,7 @@ ;; LaunchServices app icons (allow file-read* (well-known-system-group-container-subpath "/systemgroup.com.apple.lsd.iconscache")) -(allow mach-lookup +(allow mach-lookup (with report) (with telemetry) (xpc-service-name "com.apple.iconservices") (global-name "com.apple.iconservices")) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252210] trunk/LayoutTests
Title: [252210] trunk/LayoutTests Revision 252210 Author katherine_che...@apple.com Date 2019-11-07 15:16:39 -0800 (Thu, 07 Nov 2019) Log Message Many resourceLoadStatistics tests and storageAccess tests using the ITP Database redirect to the corresponding memory store test after setting a cookie https://bugs.webkit.org/show_bug.cgi?id=203958 Reviewed by John Wilander. This patch fixes incorrect redirects in some ITP database store tests. They should redirect back to themselves as opposed to corresponding memory store tests to be sure they are testing the correct functionality. * http/tests/resourceLoadStatistics/add-blocking-to-redirect-database.html: * http/tests/resourceLoadStatistics/blocking-in-web-worker-script-import-database.html: * http/tests/resourceLoadStatistics/cookie-deletion-database.html: * http/tests/resourceLoadStatistics/cookies-with-and-without-user-interaction-database.html: * http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations-database.html: * http/tests/resourceLoadStatistics/downgraded-referrer-for-navigation-with-link-query-from-prevalent-resource-database.html: * http/tests/resourceLoadStatistics/grandfathering-database.html: * http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context-database.html: * http/tests/resourceLoadStatistics/ping-to-prevalent-resource-database.html: * http/tests/storageAccess/deny-due-to-no-interaction-under-general-third-party-cookie-blocking-database.html: * http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-database.html: * http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-database.html: * http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral-database.html: * http/tests/storageAccess/has-storage-access-under-general-third-party-cookie-blocking-with-cookie-database.html: * http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access-database.html: * http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access-database.html: * http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access-database.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/resourceLoadStatistics/add-blocking-to-redirect-database.html trunk/LayoutTests/http/tests/resourceLoadStatistics/blocking-in-web-worker-script-import-database.html trunk/LayoutTests/http/tests/resourceLoadStatistics/cookie-deletion-database.html trunk/LayoutTests/http/tests/resourceLoadStatistics/cookies-with-and-without-user-interaction-database.html trunk/LayoutTests/http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations-database.html trunk/LayoutTests/http/tests/resourceLoadStatistics/downgraded-referrer-for-navigation-with-link-query-from-prevalent-resource-database.html trunk/LayoutTests/http/tests/resourceLoadStatistics/grandfathering-database.html trunk/LayoutTests/http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context-database.html trunk/LayoutTests/http/tests/resourceLoadStatistics/ping-to-prevalent-resource-database.html trunk/LayoutTests/http/tests/storageAccess/deny-due-to-no-interaction-under-general-third-party-cookie-blocking-database.html trunk/LayoutTests/http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking-database.html trunk/LayoutTests/http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-database.html trunk/LayoutTests/http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral-database.html trunk/LayoutTests/http/tests/storageAccess/has-storage-access-under-general-third-party-cookie-blocking-with-cookie-database.html trunk/LayoutTests/http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access-database.html trunk/LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access-database.html trunk/LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access-database.html Diff Modified: trunk/LayoutTests/ChangeLog (252209 => 252210) --- trunk/LayoutTests/ChangeLog 2019-11-07 23:16:07 UTC (rev 252209) +++ trunk/LayoutTests/ChangeLog 2019-11-07 23:16:39 UTC (rev 252210) @@ -1,3 +1,36 @@ +2019-11-07 Kate Cheney + + Many resourceLoadStatistics tests and storageAccess tests using the ITP + Database redirect to the corresponding memory store test after setting + a cookie + https://bugs.webkit.org/show_bug.cgi?id=203958 + + +Reviewed by John Wilander. + +This patch fixes incorrect redirects in some ITP database store tests. +They should redirect back to themselves as opposed to corresponding +memory store tests to be sure
[webkit-changes] [252209] trunk/Source/WebCore
Title: [252209] trunk/Source/WebCore Revision 252209 Author cdu...@apple.com Date 2019-11-07 15:16:07 -0800 (Thu, 07 Nov 2019) Log Message Port MessagePort to the HTML5 event loop https://bugs.webkit.org/show_bug.cgi?id=203960 Reviewed by Ryosuke Niwa. * dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::close): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::dispatchEvent): * dom/MessagePort.h: * dom/TaskSource.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/MessagePort.cpp trunk/Source/WebCore/dom/MessagePort.h trunk/Source/WebCore/dom/TaskSource.h Diff Modified: trunk/Source/WebCore/ChangeLog (252208 => 252209) --- trunk/Source/WebCore/ChangeLog 2019-11-07 23:01:20 UTC (rev 252208) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 23:16:07 UTC (rev 252209) @@ -1,3 +1,18 @@ +2019-11-07 Chris Dumez + +Port MessagePort to the HTML5 event loop +https://bugs.webkit.org/show_bug.cgi?id=203960 + +Reviewed by Ryosuke Niwa. + +* dom/MessagePort.cpp: +(WebCore::MessagePort::MessagePort): +(WebCore::MessagePort::close): +(WebCore::MessagePort::dispatchMessages): +(WebCore::MessagePort::dispatchEvent): +* dom/MessagePort.h: +* dom/TaskSource.h: + 2019-11-07 Antti Koivisto Factor matched declarations cache into a class Modified: trunk/Source/WebCore/dom/MessagePort.cpp (252208 => 252209) --- trunk/Source/WebCore/dom/MessagePort.cpp 2019-11-07 23:01:20 UTC (rev 252208) +++ trunk/Source/WebCore/dom/MessagePort.cpp 2019-11-07 23:16:07 UTC (rev 252209) @@ -98,7 +98,6 @@ : ActiveDOMObject() , m_identifier(local) , m_remoteIdentifier(remote) -, m_eventQueue(GenericEventQueue::create(*this)) { LOG(MessagePorts, "Created MessagePort %s (%p) in process %" PRIu64, m_identifier.logString().utf8().data(), this, Process::identifier().toUInt64()); @@ -235,7 +234,6 @@ } removeAllEventListeners(); -m_eventQueue->close(); } void MessagePort::contextDestroyed() @@ -277,7 +275,8 @@ if (contextIsWorker && downcast(*m_scriptExecutionContext).isClosing()) return; auto ports = MessagePort::entanglePorts(*m_scriptExecutionContext, WTFMove(message.transferredPorts)); -m_eventQueue->enqueueEvent(MessageEvent::create(WTFMove(ports), message.message.releaseNonNull())); +// Per specification, each MessagePort object has a task source called the port message queue. +queueTaskToDispatchEvent(*this, TaskSource::PostedMessageQueue, MessageEvent::create(WTFMove(ports), message.message.releaseNonNull())); } }; @@ -284,6 +283,14 @@ MessagePortChannelProvider::fromContext(*m_scriptExecutionContext).takeAllMessagesForPort(m_identifier, WTFMove(messagesTakenHandler)); } +void MessagePort::dispatchEvent(Event& event) +{ +if (m_closed) +return; + +EventTarget::dispatchEvent(event); +} + void MessagePort::updateActivity(MessagePortChannelProvider::HasActivity hasActivity) { bool hasHadLocalActivity = m_hasHadLocalActivitySinceLastCheck; Modified: trunk/Source/WebCore/dom/MessagePort.h (252208 => 252209) --- trunk/Source/WebCore/dom/MessagePort.h 2019-11-07 23:01:20 UTC (rev 252208) +++ trunk/Source/WebCore/dom/MessagePort.h 2019-11-07 23:16:07 UTC (rev 252209) @@ -29,7 +29,6 @@ #include "ActiveDOMObject.h" #include "EventTarget.h" #include "ExceptionOr.h" -#include "GenericEventQueue.h" #include "MessagePortChannel.h" #include "MessagePortIdentifier.h" #include "MessageWithMessagePorts.h" @@ -96,6 +95,8 @@ void refEventTarget() final { ref(); } void derefEventTarget() final { deref(); } +void dispatchEvent(Event&) final; + private: explicit MessagePort(ScriptExecutionContext&, const MessagePortIdentifier& local, const MessagePortIdentifier& remote); @@ -126,7 +127,6 @@ MessagePortIdentifier m_remoteIdentifier; mutable std::atomic m_refCount { 1 }; -UniqueRef m_eventQueue; }; } // namespace WebCore Modified: trunk/Source/WebCore/dom/TaskSource.h (252208 => 252209) --- trunk/Source/WebCore/dom/TaskSource.h 2019-11-07 23:01:20 UTC (rev 252208) +++ trunk/Source/WebCore/dom/TaskSource.h 2019-11-07 23:16:07 UTC (rev 252209) @@ -33,6 +33,7 @@ FontLoading, IdleTask, Networking, +PostedMessageQueue, UserInteraction }; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252208] trunk/Source/WebCore
Title: [252208] trunk/Source/WebCore Revision 252208 Author an...@apple.com Date 2019-11-07 15:01:20 -0800 (Thu, 07 Nov 2019) Log Message Factor matched declarations cache into a class https://bugs.webkit.org/show_bug.cgi?id=203972 Reviewed by Zalan Bujtas. Move the code out from StyleResolver and rename "matched properties cache" -> "matched declarations cache" to better describe it. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * css/ElementRuleCollector.cpp: (WebCore::ElementRuleCollector::declarationsForOrigin): Add a helper. (WebCore::ElementRuleCollector::transferMatchedRules): Reserve vector capacity before adding rules. (WebCore::ElementRuleCollector::addMatchedProperties): * css/ElementRuleCollector.h: (WebCore::MatchResult::operator== const): (WebCore::MatchResult::operator!= const): Remove the unneeded inline capacity so we can just use MatchResult itself in the cache. * css/RuleSet.cpp: (WebCore::RuleSet::addChildRules): * css/StyleResolver.cpp: (WebCore::StyleResolver::StyleResolver): (WebCore::StyleResolver::invalidateMatchedDeclarationsCache): (WebCore::StyleResolver::clearCachedDeclarationsAffectedByViewportUnits): (WebCore::StyleResolver::applyMatchedProperties): (WebCore::StyleResolver::sweepMatchedPropertiesCache): Deleted. (WebCore::StyleResolver::computeMatchedPropertiesHash): Deleted. (WebCore::StyleResolver::findFromMatchedPropertiesCache): Deleted. (WebCore::StyleResolver::addToMatchedPropertiesCache): Deleted. (WebCore::StyleResolver::invalidateMatchedPropertiesCache): Deleted. (WebCore::StyleResolver::clearCachedPropertiesAffectedByViewportUnits): Deleted. (WebCore::isCacheableInMatchedPropertiesCache): Deleted. * css/StyleResolver.h: (WebCore::StyleResolver::MatchedPropertiesCacheItem::MatchedPropertiesCacheItem): Deleted. * dom/Document.cpp: (WebCore::Document::invalidateMatchedPropertiesCacheAndForceStyleRecalc): (WebCore::Document::updateViewportUnitsOnResize): * page/Page.cpp: (WebCore::Page::updateStyleAfterChangeInEnvironment): * style/MatchedDeclarationsCache.cpp: Added. (WebCore::Style::MatchedDeclarationsCache::MatchedDeclarationsCache): (WebCore::Style::MatchedDeclarationsCache::isCacheable): (WebCore::Style::MatchedDeclarationsCache::computeHash): (WebCore::Style::MatchedDeclarationsCache::find): (WebCore::Style::MatchedDeclarationsCache::add): (WebCore::Style::MatchedDeclarationsCache::invalidate): (WebCore::Style::MatchedDeclarationsCache::clearEntriesAffectedByViewportUnits): (WebCore::Style::MatchedDeclarationsCache::sweep): * style/MatchedDeclarationsCache.h: Added. * style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/css/ElementRuleCollector.cpp trunk/Source/WebCore/css/ElementRuleCollector.h trunk/Source/WebCore/css/RuleSet.cpp trunk/Source/WebCore/css/StyleResolver.cpp trunk/Source/WebCore/css/StyleResolver.h trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/style/StyleTreeResolver.cpp Added Paths trunk/Source/WebCore/style/MatchedDeclarationsCache.cpp trunk/Source/WebCore/style/MatchedDeclarationsCache.h Diff Modified: trunk/Source/WebCore/ChangeLog (252207 => 252208) --- trunk/Source/WebCore/ChangeLog 2019-11-07 22:53:47 UTC (rev 252207) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 23:01:20 UTC (rev 252208) @@ -1,3 +1,65 @@ +2019-11-07 Antti Koivisto + +Factor matched declarations cache into a class +https://bugs.webkit.org/show_bug.cgi?id=203972 + +Reviewed by Zalan Bujtas. + +Move the code out from StyleResolver and rename "matched properties cache" -> "matched declarations cache" +to better describe it. + +* Sources.txt: +* WebCore.xcodeproj/project.pbxproj: +* css/ElementRuleCollector.cpp: +(WebCore::ElementRuleCollector::declarationsForOrigin): + +Add a helper. + +(WebCore::ElementRuleCollector::transferMatchedRules): + +Reserve vector capacity before adding rules. + +(WebCore::ElementRuleCollector::addMatchedProperties): +* css/ElementRuleCollector.h: +(WebCore::MatchResult::operator== const): +(WebCore::MatchResult::operator!= const): + +Remove the unneeded inline capacity so we can just use MatchResult itself in the cache. + +* css/RuleSet.cpp: +(WebCore::RuleSet::addChildRules): +* css/StyleResolver.cpp: +(WebCore::StyleResolver::StyleResolver): +(WebCore::StyleResolver::invalidateMatchedDeclarationsCache): +(WebCore::StyleResolver::clearCachedDeclarationsAffectedByViewportUnits): +(WebCore::StyleResolver::applyMatchedProperties): +(WebCore::StyleResolver::sweepMatchedPropertiesCache): Deleted. +(WebCore::StyleResolver::computeMatchedPropertiesHash): Deleted. +
[webkit-changes] [252207] trunk/Source/WebCore
Title: [252207] trunk/Source/WebCore Revision 252207 Author eric.carl...@apple.com Date 2019-11-07 14:53:47 -0800 (Thu, 07 Nov 2019) Log Message UserMediaController::from(document) can return nullptr https://bugs.webkit.org/show_bug.cgi?id=203977 Reviewed by Jer Noble. * Modules/mediastream/MediaDevices.cpp: (WebCore::MediaDevices::stop): NULL-check the UserMediaController. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (252206 => 252207) --- trunk/Source/WebCore/ChangeLog 2019-11-07 22:36:45 UTC (rev 252206) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 22:53:47 UTC (rev 252207) @@ -1,3 +1,14 @@ +2019-11-07 Eric Carlson + +UserMediaController::from(document) can return nullptr +https://bugs.webkit.org/show_bug.cgi?id=203977 + + +Reviewed by Jer Noble. + +* Modules/mediastream/MediaDevices.cpp: +(WebCore::MediaDevices::stop): NULL-check the UserMediaController. + 2019-11-07 Chris Dumez Port ServiceWorkerContainer to the HTML5 event loop Modified: trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp (252206 => 252207) --- trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp 2019-11-07 22:36:45 UTC (rev 252206) +++ trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp 2019-11-07 22:53:47 UTC (rev 252207) @@ -75,7 +75,8 @@ { if (m_deviceChangeToken) { auto* controller = UserMediaController::from(document()->page()); -controller->removeDeviceChangeObserver(m_deviceChangeToken); +if (controller) +controller->removeDeviceChangeObserver(m_deviceChangeToken); } m_devices.clear(); m_scheduledEventTimer.stop(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252206] trunk/Source/WebCore
Title: [252206] trunk/Source/WebCore Revision 252206 Author cdu...@apple.com Date 2019-11-07 14:36:45 -0800 (Thu, 07 Nov 2019) Log Message Port ServiceWorkerContainer to the HTML5 event loop https://bugs.webkit.org/show_bug.cgi?id=203963 Reviewed by Ryosuke Niwa. * workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::ServiceWorkerContainer): (WebCore::ServiceWorkerContainer::startMessages): (WebCore::ServiceWorkerContainer::postMessage): * workers/service/ServiceWorkerContainer.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h Diff Modified: trunk/Source/WebCore/ChangeLog (252205 => 252206) --- trunk/Source/WebCore/ChangeLog 2019-11-07 22:18:37 UTC (rev 252205) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 22:36:45 UTC (rev 252206) @@ -1,3 +1,16 @@ +2019-11-07 Chris Dumez + +Port ServiceWorkerContainer to the HTML5 event loop +https://bugs.webkit.org/show_bug.cgi?id=203963 + +Reviewed by Ryosuke Niwa. + +* workers/service/ServiceWorkerContainer.cpp: +(WebCore::ServiceWorkerContainer::ServiceWorkerContainer): +(WebCore::ServiceWorkerContainer::startMessages): +(WebCore::ServiceWorkerContainer::postMessage): +* workers/service/ServiceWorkerContainer.h: + 2019-11-06 Ryosuke Niwa Integrate scroll event into HTML5 event loop Modified: trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp (252205 => 252206) --- trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp 2019-11-07 22:18:37 UTC (rev 252205) +++ trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp 2019-11-07 22:36:45 UTC (rev 252206) @@ -73,13 +73,12 @@ ServiceWorkerContainer::ServiceWorkerContainer(ScriptExecutionContext* context, NavigatorBase& navigator) : ActiveDOMObject(context) , m_navigator(navigator) -, m_messageQueue(GenericEventQueue::create(*this)) { suspendIfNeeded(); // We should queue messages until the DOMContentLoaded event has fired or startMessages() has been called. if (is(context) && downcast(*context).parsing()) -m_messageQueue->setPaused(true); +m_shouldDeferMessageEvents = true; } ServiceWorkerContainer::~ServiceWorkerContainer() @@ -314,7 +313,10 @@ void ServiceWorkerContainer::startMessages() { -m_messageQueue->setPaused(false); +m_shouldDeferMessageEvents = false; +auto deferredMessageEvents = WTFMove(m_deferredMessageEvents); +for (auto& messageEvent : deferredMessageEvents) +queueTaskToDispatchEvent(*this, TaskSource::DOMManipulation, WTFMove(messageEvent)); } void ServiceWorkerContainer::jobFailedWithException(ServiceWorkerJob& job, const Exception& exception) @@ -404,8 +406,12 @@ MessageEventSource source = RefPtr { ServiceWorker::getOrCreate(context, WTFMove(sourceData)) }; auto messageEvent = MessageEvent::create(MessagePort::entanglePorts(context, WTFMove(message.transferredPorts)), message.message.releaseNonNull(), sourceOrigin, { }, WTFMove(source)); - -m_messageQueue->enqueueEvent(WTFMove(messageEvent)); +if (m_shouldDeferMessageEvents) +m_deferredMessageEvents.append(WTFMove(messageEvent)); +else { +ASSERT(m_deferredMessageEvents.isEmpty()); +queueTaskToDispatchEvent(*this, TaskSource::DOMManipulation, WTFMove(messageEvent)); +} } void ServiceWorkerContainer::notifyRegistrationIsSettled(const ServiceWorkerRegistrationKey& registrationKey) Modified: trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h (252205 => 252206) --- trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h 2019-11-07 22:18:37 UTC (rev 252205) +++ trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h 2019-11-07 22:36:45 UTC (rev 252206) @@ -29,7 +29,6 @@ #include "ActiveDOMObject.h" #include "EventTarget.h" -#include "GenericEventQueue.h" #include "IDLTypes.h" #include "SWClientConnection.h" #include "SWServer.h" @@ -142,7 +141,8 @@ uint64_t m_lastOngoingSettledRegistrationIdentifier { 0 }; HashMap m_ongoingSettledRegistrations; -UniqueRef m_messageQueue; +bool m_shouldDeferMessageEvents { false }; +Vector> m_deferredMessageEvents; }; } // namespace WebCore ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252205] trunk
Title: [252205] trunk Revision 252205 Author rn...@webkit.org Date 2019-11-07 14:18:37 -0800 (Thu, 07 Nov 2019) Log Message Integrate scroll event into HTML5 event loop https://bugs.webkit.org/show_bug.cgi?id=203839 Reviewed by Simon Fraser. Source/WebCore: Dispatch scroll events on each pending scroll event targets inside the update-the-rendering step of the event loop as specified in the HTML5 and CSSOM View Module specifications: https://html.spec.whatwg.org/multipage/webappapis.html#update-the-rendering https://drafts.csswg.org/cssom-view/#run-the-scroll-steps The new behavior also matches that of Chrome and Firefox. Like resize event, the current visual viewport specification does not specify when scroll event is dispatched on visualViewport interface: https://github.com/WICG/visual-viewport/issues/66 For now, we always dispatch upon it after dispatching on all pending scroll event targets. Tests: fast/events/scroll-multiple-elements-in-rendering-update.html fast/events/scroll-subframe-in-rendering-update.html fast/visual-viewport/visual-viewport-scroll-after-resize-in-subframe.html * dom/Document.cpp: (WebCore::Document::addPendingScrollEventTarget): Added. (WebCore::Document::setNeedsVisualViewportScrollEvent): Added. (WebCore::Document::runScrollSteps): Added. This implements run the scroll steps in CSS OM View. * dom/Document.h: * dom/DocumentEventQueue.cpp: (WebCore::DocumentEventQueue::enqueueOrDispatchScrollEvent): Deleted. (WebCore::DocumentEventQueue::enqueueScrollEvent): Deleted. * dom/DocumentEventQueue.h: * page/EventHandler.cpp: (WebCore::EventHandler::sendScrollEvent): * page/Page.cpp: (WebCore::Page::updateRendering): Invoke runScrollSteps on each document in the frame tree order. * page/VisualViewport.cpp: (WebCore::VisualViewport::update): (WebCore::VisualViewport::enqueueScrollEvent): Deleted. * page/VisualViewport.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollTo): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::scrollTo): LayoutTests: Added tests to test the timing at which scroll events are fired across multiple elements and documents, and with visualViewport, and updated the existing tests to work with the new timing. * editing/selection/overflow-scroll-while-selecting-text.html: * fast/events/scroll-multiple-elements-in-rendering-update-expected.txt: Added. * fast/events/scroll-multiple-elements-in-rendering-update.html: Added. * fast/events/scroll-subframe-in-rendering-update-expected.txt: Added. * fast/events/scroll-subframe-in-rendering-update.html: Added. * fast/scrolling/programmatic-scroll-to-negative-offset.html: * fast/shadow-dom/trusted-event-scoped-flags.html: * fast/visual-viewport/visual-viewport-scroll-after-resize-in-subframe-expected.txt: Added. * fast/visual-viewport/visual-viewport-scroll-after-resize-in-subframe.html: Added. * tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/selection/overflow-scroll-while-selecting-text.html trunk/LayoutTests/fast/scrolling/programmatic-scroll-to-negative-offset.html trunk/LayoutTests/fast/shadow-dom/trusted-event-scoped-flags.html trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/DocumentEventQueue.cpp trunk/Source/WebCore/dom/DocumentEventQueue.h trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/VisualViewport.cpp trunk/Source/WebCore/page/VisualViewport.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderListBox.cpp Added Paths trunk/LayoutTests/fast/events/scroll-subframe-in-rendering-update-expected.txt trunk/LayoutTests/fast/events/scroll-subframe-in-rendering-update.html trunk/LayoutTests/fast/visual-viewport/visual-viewport-scroll-after-resize-in-subframe-expected.txt trunk/LayoutTests/fast/visual-viewport/visual-viewport-scroll-after-resize-in-subframe.html Diff Modified: trunk/LayoutTests/ChangeLog (252204 => 252205) --- trunk/LayoutTests/ChangeLog 2019-11-07 21:34:15 UTC (rev 252204) +++ trunk/LayoutTests/ChangeLog 2019-11-07 22:18:37 UTC (rev 252205) @@ -1,3 +1,25 @@ +2019-11-06 Ryosuke Niwa + +Integrate scroll event into HTML5 event loop +https://bugs.webkit.org/show_bug.cgi?id=203839 + + +Reviewed by Simon Fraser. + +Added tests to test the timing at which scroll events are fired across multiple elements and documents, +and with visualViewport, and updated the existing tests to work with the new timing. + +* editing/selection/overflow-scroll-while-selecting-text.html: +* fast/events/scroll-multiple-elements-in-rendering-update-expected.txt: Added. +* fast/events/scroll-multiple-elements-in-rendering-update.html: Added. +*
[webkit-changes] [252204] trunk/LayoutTests
Title: [252204] trunk/LayoutTests Revision 252204 Author justin_...@apple.com Date 2019-11-07 13:34:15 -0800 (Thu, 07 Nov 2019) Log Message REGRESSION: r252121 introduced timeout in webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html https://bugs.webkit.org/show_bug.cgi?id=203949 Unreviewed test expectation gardening. shader-with-non-reserved-words takes dozens of minutes to pass. Skip everywhere. * platform/gtk/TestExpectations: * platform/ios-simulator-wk2/TestExpectations: * platform/mac/TestExpectations: * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (252203 => 252204) --- trunk/LayoutTests/ChangeLog 2019-11-07 21:07:42 UTC (rev 252203) +++ trunk/LayoutTests/ChangeLog 2019-11-07 21:34:15 UTC (rev 252204) @@ -1,3 +1,17 @@ +2019-11-07 Justin Fan + +REGRESSION: r252121 introduced timeout in webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html +https://bugs.webkit.org/show_bug.cgi?id=203949 + +Unreviewed test expectation gardening. + +shader-with-non-reserved-words takes dozens of minutes to pass. Skip everywhere. + +* platform/gtk/TestExpectations: +* platform/ios-simulator-wk2/TestExpectations: +* platform/mac/TestExpectations: +* platform/wpe/TestExpectations: + 2019-11-07 Devin Rousso Web Inspector: REGRESSION(r250087): inspector/model/remote-object.html is timing out Modified: trunk/LayoutTests/platform/gtk/TestExpectations (252203 => 252204) --- trunk/LayoutTests/platform/gtk/TestExpectations 2019-11-07 21:07:42 UTC (rev 252203) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2019-11-07 21:34:15 UTC (rev 252204) @@ -473,7 +473,6 @@ webkit.org/b/169917 webgl/1.0.3/conformance/context/context-creation-and-destruction.html [ Pass Timeout ] webkit.org/b/169917 webgl/1.0.3/conformance/extensions/oes-texture-float-with-video.html [ Timeout ] webkit.org/b/169917 webgl/1.0.3/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Slow ] -webkit.org/b/169917 webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ] webkit.org/b/169917 webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Slow ] webkit.org/b/169917 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html [ Timeout ] webkit.org/b/169917 webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba.html [ Timeout ] Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (252203 => 252204) --- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2019-11-07 21:07:42 UTC (rev 252203) +++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations 2019-11-07 21:34:15 UTC (rev 252204) @@ -18,8 +18,6 @@ webkit.org/b/173178 [ Release ] svg/animations/svglength-element-removed-crash.svg [ Skip ] -webkit.org/b/174100 webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html [ Skip ] - webkit.org/b/173010 js/slow-stress/Int32Array-alloc-huge.html [ Pass Timeout ] webkit.org/b/174183 animations/resume-after-page-cache.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac/TestExpectations (252203 => 252204) --- trunk/LayoutTests/platform/mac/TestExpectations 2019-11-07 21:07:42 UTC (rev 252203) +++ trunk/LayoutTests/platform/mac/TestExpectations 2019-11-07 21:34:15 UTC (rev 252204) @@ -398,8 +398,6 @@ webgl/1.0.3/conformance/context/context-creation-and-destruction.html [ Pass Timeout ] webgl/1.0.3/conformance/rendering/multisample-corruption.html [ Pass Timeout ] -webkit.org/b/124935 [ Debug ] webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ] - # Skip 1.0.3 tests that pass in conformance suite but timeout in TestRunner webgl/1.0.3/conformance/more/glsl [ Skip ] webgl/1.0.3/conformance/more/conformance [ Skip ] Modified: trunk/LayoutTests/platform/wpe/TestExpectations (252203 => 252204) --- trunk/LayoutTests/platform/wpe/TestExpectations 2019-11-07 21:07:42 UTC (rev 252203) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2019-11-07 21:34:15 UTC (rev 252204) @@ -1072,7 +1072,6 @@ webkit.org/b/159754 workers/bomb.html [ Skip ] webkit.org/b/169917 webgl/1.0.3/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Slow ] -webkit.org/b/169917 webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ] webkit.org/b/169917 webgl/1.0.3/conformance/uniforms/gl-uniform-arrays.html [ Slow ] webkit.org/b/169917 webgl/1.0.3/conformance/uniforms/out-of-bounds-uniform-array-access.html [ Slow ] webkit.org/b/169917 webgl/1.0.3/conformance/glsl/bugs/temp-expressions-should-not-crash.html [ Slow ]
[webkit-changes] [252203] trunk/LayoutTests
Title: [252203] trunk/LayoutTests Revision 252203 Author simon.fra...@apple.com Date 2019-11-07 13:07:42 -0800 (Thu, 07 Nov 2019) Log Message REGRESSION (r252161): 3 transitions/ tests time-out https://bugs.webkit.org/show_bug.cgi?id=203966 Reviewed by Dean Jackson. Fix the shadow parsing code to deal with non-integral values. * legacy-animation-engine/transitions/resources/transition-test-helpers.js: (isShadow): * transitions/resources/transition-test-helpers.js: (isShadow): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/legacy-animation-engine/transitions/resources/transition-test-helpers.js trunk/LayoutTests/legacy-animation-engine/transitions/transition-to-from-auto-expected.txt trunk/LayoutTests/transitions/resources/transition-test-helpers.js Diff Modified: trunk/LayoutTests/ChangeLog (252202 => 252203) --- trunk/LayoutTests/ChangeLog 2019-11-07 20:36:51 UTC (rev 252202) +++ trunk/LayoutTests/ChangeLog 2019-11-07 21:07:42 UTC (rev 252203) @@ -107,6 +107,20 @@ * platform/ios/TestExpectations: +2019-11-07 Simon Fraser + +REGRESSION (r252161): 3 transitions/ tests time-out +https://bugs.webkit.org/show_bug.cgi?id=203966 + +Reviewed by Dean Jackson. + +Fix the shadow parsing code to deal with non-integral values. + +* legacy-animation-engine/transitions/resources/transition-test-helpers.js: +(isShadow): +* transitions/resources/transition-test-helpers.js: +(isShadow): + 2019-11-06 Nikita Vasilyev Web Inspector: Display color picker for p3 colors Modified: trunk/LayoutTests/legacy-animation-engine/transitions/resources/transition-test-helpers.js (252202 => 252203) --- trunk/LayoutTests/legacy-animation-engine/transitions/resources/transition-test-helpers.js 2019-11-07 20:36:51 UTC (rev 252202) +++ trunk/LayoutTests/legacy-animation-engine/transitions/resources/transition-test-helpers.js 2019-11-07 21:07:42 UTC (rev 252203) @@ -40,7 +40,7 @@ function isShadow(property) { - return (property == '-webkit-box-shadow' || property == 'text-shadow'); +return (property == '-webkit-box-shadow' || property == 'box-shadow' || property == 'text-shadow'); } function getShadowXY(cssValue) @@ -47,9 +47,10 @@ { var text = cssValue.cssText; // Shadow cssText looks like "rgb(0, 0, 255) 0px -3px 10px 0px" -var shadowPositionRegExp = /\)\s*(-?\d+)px\s*(-?\d+)px/; +var shadowPositionRegExp = /\)\s*(-?\d+\.?\d*)px\s*(-?\d+\.?\d*)px/; var result = shadowPositionRegExp.exec(text); -return [parseInt(result[1]), parseInt(result[2])]; +console.log(text, result); +return [parseFloat(result[1]), parseFloat(result[2])]; } function compareRGB(rgb, expected, tolerance) Modified: trunk/LayoutTests/legacy-animation-engine/transitions/transition-to-from-auto-expected.txt (252202 => 252203) --- trunk/LayoutTests/legacy-animation-engine/transitions/transition-to-from-auto-expected.txt 2019-11-07 20:36:51 UTC (rev 252202) +++ trunk/LayoutTests/legacy-animation-engine/transitions/transition-to-from-auto-expected.txt 2019-11-07 21:07:42 UTC (rev 252203) @@ -1,5 +1,5 @@ -CONSOLE MESSAGE: line 371: Failed to pause 'left' transition on element 'test1' -CONSOLE MESSAGE: line 371: Failed to pause 'left' transition on element 'test2' +CONSOLE MESSAGE: line 372: Failed to pause 'left' transition on element 'test1' +CONSOLE MESSAGE: line 372: Failed to pause 'left' transition on element 'test2' PASS - "left" property for "test1" element at 1s saw something close to: 0 PASS - "left" property for "test2" element at 1s saw something close to: 100 PASS - "left" property for "test3" element at 1s saw something close to: 50 Modified: trunk/LayoutTests/transitions/resources/transition-test-helpers.js (252202 => 252203) --- trunk/LayoutTests/transitions/resources/transition-test-helpers.js 2019-11-07 20:36:51 UTC (rev 252202) +++ trunk/LayoutTests/transitions/resources/transition-test-helpers.js 2019-11-07 21:07:42 UTC (rev 252203) @@ -40,7 +40,7 @@ function isShadow(property) { - return (property == '-webkit-box-shadow' || property == 'text-shadow'); + return (property == '-webkit-box-shadow' || property == 'box-shadow' || property == 'text-shadow'); } function getShadowXY(cssValue) @@ -47,9 +47,10 @@ { var text = cssValue.cssText; // Shadow cssText looks like "rgb(0, 0, 255) 0px -3px 10px 0px" -var shadowPositionRegExp = /\)\s*(-?\d+)px\s*(-?\d+)px/; +var shadowPositionRegExp = /\)\s*(-?\d+\.?\d*)px\s*(-?\d+\.?\d*)px/; var result = shadowPositionRegExp.exec(text); -return [parseInt(result[1]), parseInt(result[2])]; +console.log(text, result); +return [parseFloat(result[1]), parseFloat(result[2])]; } function compareRGB(rgb, expected, tolerance) @@ -304,6 +305,7 @@ // arbitrarily pick shadow-x and shadow-y if (isShadow) { var shadowXY =
[webkit-changes] [252201] trunk/Source/WebInspectorUI
Title: [252201] trunk/Source/WebInspectorUI Revision 252201 Author drou...@apple.com Date 2019-11-07 12:31:44 -0800 (Thu, 07 Nov 2019) Log Message Web Inspector: REGRESSION(r249451): missing "Reveal in DOM Tree" on nodes logged to the console https://bugs.webkit.org/show_bug.cgi?id=203836 Reviewed by Timothy Hatcher. * UserInterface/Views/ContextMenuUtilities.js: (WI.appendContextMenuItemsForDOMNode): * UserInterface/Views/DOMTreeOutline.js: (WI.DOMTreeOutline.prototype.populateContextMenu): DOM trees in the console are marked as being non-editable, which is intended to prevent modifications (e.g. changing an attribute) from being made in the console as the DOM tree there is not hooked up to the associated DOM agent. In r249451 however, this guard was over expanded to include non-editing actions, like "Reveal in DOM Tree" and DOM breakpoints. * UserInterface/Views/LogContentView.js: (WI.LogContentView.prototype._handleContextMenuEvent): Drive-by: add a separator before "Copy Selected" so it doesn't end up in the same group as any "Collapse All" from a `WI.TreeOutline`. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (252200 => 252201) --- trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 20:17:59 UTC (rev 252200) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 20:31:44 UTC (rev 252201) @@ -1,5 +1,26 @@ 2019-11-07 Devin Rousso +Web Inspector: REGRESSION(r249451): missing "Reveal in DOM Tree" on nodes logged to the console +https://bugs.webkit.org/show_bug.cgi?id=203836 + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/ContextMenuUtilities.js: +(WI.appendContextMenuItemsForDOMNode): +* UserInterface/Views/DOMTreeOutline.js: +(WI.DOMTreeOutline.prototype.populateContextMenu): +DOM trees in the console are marked as being non-editable, which is intended to prevent +modifications (e.g. changing an attribute) from being made in the console as the DOM tree +there is not hooked up to the associated DOM agent. In r249451 however, this guard was over +expanded to include non-editing actions, like "Reveal in DOM Tree" and DOM breakpoints. + +* UserInterface/Views/LogContentView.js: +(WI.LogContentView.prototype._handleContextMenuEvent): +Drive-by: add a separator before "Copy Selected" so it doesn't end up in the same group as + any "Collapse All" from a `WI.TreeOutline`. + +2019-11-07 Devin Rousso + Web Inspector: Local Resource Overrides: automatically show a file picker when attempting to create an override for non-text resources https://bugs.webkit.org/show_bug.cgi?id=203917 Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js (252200 => 252201) --- trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2019-11-07 20:17:59 UTC (rev 252200) +++ trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2019-11-07 20:31:44 UTC (rev 252201) @@ -226,7 +226,7 @@ contextMenu.appendSeparator(); -if (!options.disallowEditing) { +if (!options.usingLocalDOMNode) { if (domNode.isCustomElement()) { contextMenu.appendItem(WI.UIString("Jump to Definition"), () => { function didGetFunctionDetails(error, response) { @@ -260,7 +260,7 @@ contextMenu.appendSeparator(); } -if (WI.cssManager.canForcePseudoClasses() && domNode.attached) { +if (!options.disallowEditing && WI.cssManager.canForcePseudoClasses() && domNode.attached) { contextMenu.appendSeparator(); let pseudoSubMenu = contextMenu.appendSubMenuItem(WI.UIString("Forced Pseudo-Classes", "A context menu item to force (override) a DOM node's pseudo-classes")); Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js (252200 => 252201) --- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2019-11-07 20:17:59 UTC (rev 252200) +++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2019-11-07 20:31:44 UTC (rev 252201) @@ -295,6 +295,7 @@ let options = { disallowEditing: !this._editable, +usingLocalDOMNode: this._usingLocalDOMNode, excludeRevealElement: this._excludeRevealElementContextMenu, copySubMenu: subMenus.copy, }; Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (252200 => 252201) --- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2019-11-07 20:17:59 UTC (rev 252200) +++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2019-11-07 20:31:44 UTC (rev
[webkit-changes] [252200] trunk/Source/WebInspectorUI
Title: [252200] trunk/Source/WebInspectorUI Revision 252200 Author drou...@apple.com Date 2019-11-07 12:17:59 -0800 (Thu, 07 Nov 2019) Log Message Web Inspector: Local Resource Overrides: automatically show a file picker when attempting to create an override for non-text resources https://bugs.webkit.org/show_bug.cgi?id=203917 Reviewed by Timothy Hatcher. Since there's no way to edit non-text resources (e.g. images, fonts, etc.) in Web Inspector, when creating a local override for non-text resources, default to showing a file picker and creating a local override from the content and MIME type of whatever file is chosen. Still provide a way (shift-click) to create a local override for non-text resources from the resource's contents, as that can be useful if the user just wants to change some headers. * UserInterface/Models/Resource.js: (WI.Resource.prototype.async createLocalResourceOverride): * UserInterface/Views/ResourceContentView.js: (WI.ResourceContentView): (WI.ResourceContentView.prototype.get createLocalResourceOverrideTooltip): Added. (WI.ResourceContentView.prototype.requestLocalResourceOverrideInitialContent): Added. (WI.ResourceContentView.prototype.async _getContentForLocalResourceOverrideFromFile): Added. (WI.ResourceContentView.prototype._handleCreateLocalResourceOverride): (WI.ResourceContentView.prototype._handleImportLocalResourceOverride): (WI.ResourceContentView.prototype.localResourceOverrideInitialContent): Deleted. (WI.ResourceContentView.prototype.async _handleCreateLocalResourceOverride): Deleted. * UserInterface/Views/TextResourceContentView.js: (WI.TextResourceContentView.prototype.get createLocalResourceOverrideTooltip): Added. (WI.TextResourceContentView.prototype.requestLocalResourceOverrideInitialContent): Added. (WI.TextResourceContentView.prototype.localResourceOverrideInitialContent): Deleted. * Localizations/en.lproj/localizedStrings.js: Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js trunk/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (252199 => 252200) --- trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 20:02:22 UTC (rev 252199) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 20:17:59 UTC (rev 252200) @@ -1,5 +1,39 @@ 2019-11-07 Devin Rousso +Web Inspector: Local Resource Overrides: automatically show a file picker when attempting to create an override for non-text resources +https://bugs.webkit.org/show_bug.cgi?id=203917 + +Reviewed by Timothy Hatcher. + +Since there's no way to edit non-text resources (e.g. images, fonts, etc.) in Web Inspector, +when creating a local override for non-text resources, default to showing a file picker and +creating a local override from the content and MIME type of whatever file is chosen. + +Still provide a way (shift-click) to create a local override for non-text resources from the +resource's contents, as that can be useful if the user just wants to change some headers. + +* UserInterface/Models/Resource.js: +(WI.Resource.prototype.async createLocalResourceOverride): + +* UserInterface/Views/ResourceContentView.js: +(WI.ResourceContentView): +(WI.ResourceContentView.prototype.get createLocalResourceOverrideTooltip): Added. +(WI.ResourceContentView.prototype.requestLocalResourceOverrideInitialContent): Added. +(WI.ResourceContentView.prototype.async _getContentForLocalResourceOverrideFromFile): Added. +(WI.ResourceContentView.prototype._handleCreateLocalResourceOverride): +(WI.ResourceContentView.prototype._handleImportLocalResourceOverride): +(WI.ResourceContentView.prototype.localResourceOverrideInitialContent): Deleted. +(WI.ResourceContentView.prototype.async _handleCreateLocalResourceOverride): Deleted. + +* UserInterface/Views/TextResourceContentView.js: +(WI.TextResourceContentView.prototype.get createLocalResourceOverrideTooltip): Added. +(WI.TextResourceContentView.prototype.requestLocalResourceOverrideInitialContent): Added. +(WI.TextResourceContentView.prototype.localResourceOverrideInitialContent): Deleted. + +* Localizations/en.lproj/localizedStrings.js: + +2019-11-07 Devin Rousso + Web Inspector: Timelines: add a marker for when a stop was requested https://bugs.webkit.org/show_bug.cgi?id=203935 Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (252199 => 252200) --- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-11-07 20:02:22 UTC (rev 252199) +++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-11-07
[webkit-changes] [252199] trunk/Source/WebInspectorUI
Title: [252199] trunk/Source/WebInspectorUI Revision 252199 Author drou...@apple.com Date 2019-11-07 12:02:22 -0800 (Thu, 07 Nov 2019) Log Message Web Inspector: Timelines: add a marker for when a stop was requested https://bugs.webkit.org/show_bug.cgi?id=203935 Reviewed by Timothy Hatcher. After r244195, the Web Inspector frontend doesn't stop updating the current time marker until after it receives all of the corresponding `*.trackingComplete` events. This means that sometimes, the current time marker can move far past the time at which the stop was requested, such as if there's a blocking script. We should indicate where the stop was requested, as that is often right after a particular issue is reproduced during a timeline recording, rather than have the user try to figure out where they stopped. Only keep a marker for the last stop request, and hide the marker once capturing resumes. It's still useful to have the current time marker continue updating, as we should show all the information we have about captured things, such as blocking scripts. * UserInterface/Views/TimelineOverview.js: (WI.TimelineOverview): (WI.TimelineOverview.prototype._handleTimelineCapturingStateChanged): * UserInterface/Models/TimelineMarker.js: * UserInterface/Views/TimelineRuler.js: (WI.TimelineRuler.prototype.addMarker): * UserInterface/Views/TimelineRuler.css: (.timeline-ruler > .markers > .marker.stopping-time): Added. (.timeline-ruler > .markers > .marker.current-time): (.timeline-ruler > .markers > .marker:matches(.stopping-time, .current-time)::after): Added. (@media (prefers-color-scheme: dark) .timeline-ruler > .markers > .marker.stopping-time): Added. (.timeline-ruler > .markers > .marker.current-time::after): Deleted. Make the current time marker always on top (`z-index`). * Localizations/en.lproj/localizedStrings.js: Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Models/TimelineMarker.js trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (252198 => 252199) --- trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 19:59:31 UTC (rev 252198) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 20:02:22 UTC (rev 252199) @@ -1,5 +1,43 @@ 2019-11-07 Devin Rousso +Web Inspector: Timelines: add a marker for when a stop was requested +https://bugs.webkit.org/show_bug.cgi?id=203935 + +Reviewed by Timothy Hatcher. + +After r244195, the Web Inspector frontend doesn't stop updating the current time marker +until after it receives all of the corresponding `*.trackingComplete` events. This means +that sometimes, the current time marker can move far past the time at which the stop was +requested, such as if there's a blocking script. + +We should indicate where the stop was requested, as that is often right after a particular +issue is reproduced during a timeline recording, rather than have the user try to figure out +where they stopped. + +Only keep a marker for the last stop request, and hide the marker once capturing resumes. + +It's still useful to have the current time marker continue updating, as we should show all +the information we have about captured things, such as blocking scripts. + +* UserInterface/Views/TimelineOverview.js: +(WI.TimelineOverview): +(WI.TimelineOverview.prototype._handleTimelineCapturingStateChanged): + +* UserInterface/Models/TimelineMarker.js: +* UserInterface/Views/TimelineRuler.js: +(WI.TimelineRuler.prototype.addMarker): +* UserInterface/Views/TimelineRuler.css: +(.timeline-ruler > .markers > .marker.stopping-time): Added. +(.timeline-ruler > .markers > .marker.current-time): +(.timeline-ruler > .markers > .marker:matches(.stopping-time, .current-time)::after): Added. +(@media (prefers-color-scheme: dark) .timeline-ruler > .markers > .marker.stopping-time): Added. +(.timeline-ruler > .markers > .marker.current-time::after): Deleted. +Make the current time marker always on top (`z-index`). + +* Localizations/en.lproj/localizedStrings.js: + +2019-11-07 Devin Rousso + Web Inspector: REGRESSION(r251958): automatic console prompt focusing prevents any "space" shortcuts from working https://bugs.webkit.org/show_bug.cgi?id=203939 Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (252198 => 252199) --- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-11-07 19:59:31 UTC (rev 252198) +++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-11-07
[webkit-changes] [252198] trunk/Source/WebInspectorUI
Title: [252198] trunk/Source/WebInspectorUI Revision 252198 Author drou...@apple.com Date 2019-11-07 11:59:31 -0800 (Thu, 07 Nov 2019) Log Message Web Inspector: REGRESSION(r251958): automatic console prompt focusing prevents any "space" shortcuts from working https://bugs.webkit.org/show_bug.cgi?id=203939 Reviewed by Timothy Hatcher. * UserInterface/Base/Main.js: (WI.isShowingTimelineTab): Added. (WI.isShowingAuditTab): Added. (WI._restoreCookieForOpenTabs): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Base/Main.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (252197 => 252198) --- trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 19:46:41 UTC (rev 252197) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 19:59:31 UTC (rev 252198) @@ -1,5 +1,17 @@ 2019-11-07 Devin Rousso +Web Inspector: REGRESSION(r251958): automatic console prompt focusing prevents any "space" shortcuts from working +https://bugs.webkit.org/show_bug.cgi?id=203939 + +Reviewed by Timothy Hatcher. + +* UserInterface/Base/Main.js: +(WI.isShowingTimelineTab): Added. +(WI.isShowingAuditTab): Added. +(WI._restoreCookieForOpenTabs): + +2019-11-07 Devin Rousso + Web Inspector: Uncaught Exception: Unable to get object details - GlobalObject https://bugs.webkit.org/show_bug.cgi?id=203930 Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (252197 => 252198) --- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-11-07 19:46:41 UTC (rev 252197) +++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-11-07 19:59:31 UTC (rev 252198) @@ -1086,6 +1086,16 @@ WI.tabBrowser.showTabForContentView(tabContentView); }; +WI.isShowingTimelineTab = function() +{ +return WI.tabBrowser.selectedTabContentView instanceof WI.TimelineTabContentView; +}; + +WI.isShowingAuditTab = function() +{ +return WI.tabBrowser.selectedTabContentView instanceof WI.AuditTabContentView; +} + WI.showLayersTab = function(options = {}) { let tabContentView = WI.tabBrowser.bestTabContentViewForClass(WI.LayersTabContentView); @@ -1562,7 +1572,7 @@ } window.requestAnimationFrame(() => { -if (WI.isContentAreaFocused()) +if (WI.isContentAreaFocused() || WI.isShowingTimelineTab() || WI.isShowingAuditTab()) return; WI.quickConsole.prompt.focus(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252197] trunk/Source/WebInspectorUI
Title: [252197] trunk/Source/WebInspectorUI Revision 252197 Author drou...@apple.com Date 2019-11-07 11:46:41 -0800 (Thu, 07 Nov 2019) Log Message Web Inspector: Uncaught Exception: Unable to get object details - GlobalObject https://bugs.webkit.org/show_bug.cgi?id=203930 In r248286, calls to `Heap.snapshot`, `Heap.getPreview`, and `Heap.getRemoteObject` were moved to the `WI.HeapManager` instead of being inside view code. During this move, extra `WI.reportInternalError` calls were added, which wasn't entirely correct as it is fully possible (and expected) that any of these commands are invoked with old heap snapshot nodes that may no longer exist. As such, calling any error an "internal error" isn't strictly correct, and instead should just be a log. Also, the frontend code that calls these commands is able to handle errors, again because it is expected. Reviewed by Brian Burg. * UserInterface/Controllers/HeapManager.js: (WI.HeapManager.prototype.snapshot): (WI.HeapManager.prototype.getPreview): (WI.HeapManager.prototype.getRemoteObject): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/HeapManager.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (252196 => 252197) --- trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 19:42:10 UTC (rev 252196) +++ trunk/Source/WebInspectorUI/ChangeLog 2019-11-07 19:46:41 UTC (rev 252197) @@ -1,3 +1,24 @@ +2019-11-07 Devin Rousso + +Web Inspector: Uncaught Exception: Unable to get object details - GlobalObject +https://bugs.webkit.org/show_bug.cgi?id=203930 + + +In r248286, calls to `Heap.snapshot`, `Heap.getPreview`, and `Heap.getRemoteObject` were +moved to the `WI.HeapManager` instead of being inside view code. During this move, extra +`WI.reportInternalError` calls were added, which wasn't entirely correct as it is fully +possible (and expected) that any of these commands are invoked with old heap snapshot nodes +that may no longer exist. As such, calling any error an "internal error" isn't strictly +correct, and instead should just be a log. Also, the frontend code that calls these commands +is able to handle errors, again because it is expected. + +Reviewed by Brian Burg. + +* UserInterface/Controllers/HeapManager.js: +(WI.HeapManager.prototype.snapshot): +(WI.HeapManager.prototype.getPreview): +(WI.HeapManager.prototype.getRemoteObject): + 2019-11-06 Nikita Vasilyev Web Inspector: Display color picker for p3 colors Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/HeapManager.js (252196 => 252197) --- trunk/Source/WebInspectorUI/UserInterface/Controllers/HeapManager.js 2019-11-07 19:42:10 UTC (rev 252196) +++ trunk/Source/WebInspectorUI/UserInterface/Controllers/HeapManager.js 2019-11-07 19:46:41 UTC (rev 252197) @@ -90,7 +90,7 @@ let target = WI.assumingMainTarget(); target.HeapAgent.snapshot((error, timestamp, snapshotStringData) => { if (error) -WI.reportInternalError(error); +console.error(error); callback(error, timestamp, snapshotStringData); }); } @@ -103,7 +103,7 @@ let target = WI.assumingMainTarget(); target.HeapAgent.getPreview(node.id, (error, string, functionDetails, preview) => { if (error) -WI.reportInternalError(error); +console.error(error); callback(error, string, functionDetails, preview); }); } @@ -116,7 +116,7 @@ let target = WI.assumingMainTarget(); target.HeapAgent.getRemoteObject(node.id, objectGroup, (error, result) => { if (error) -WI.reportInternalError(error); +console.error(error); callback(error, result); }); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252196] trunk
Title: [252196] trunk Revision 252196 Author commit-qu...@webkit.org Date 2019-11-07 11:42:10 -0800 (Thu, 07 Nov 2019) Log Message JSTests: didPassSomeTestsSilenty is misspelled in standalone-pre.js https://bugs.webkit.org/show_bug.cgi?id=203948 Patch by Tuomas Karkkainen on 2019-11-07 Reviewed by Yusuke Suzuki. * stress/resources/standalone-pre.js: LayoutTests: didPassSomeTestsSilenty and didFaileSomeTests are misspelled in standalone-pre.js https://bugs.webkit.org/show_bug.cgi?id=203948 Patch by Tuomas Karkkainen on 2019-11-07 Reviewed by Yusuke Suzuki. * resources/standalone-pre.js: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/stress/resources/standalone-pre.js trunk/LayoutTests/ChangeLog trunk/LayoutTests/resources/standalone-pre.js Diff Modified: trunk/JSTests/ChangeLog (252195 => 252196) --- trunk/JSTests/ChangeLog 2019-11-07 19:24:54 UTC (rev 252195) +++ trunk/JSTests/ChangeLog 2019-11-07 19:42:10 UTC (rev 252196) @@ -1,3 +1,12 @@ +2019-11-07 Tuomas Karkkainen + +didPassSomeTestsSilenty is misspelled in standalone-pre.js +https://bugs.webkit.org/show_bug.cgi?id=203948 + +Reviewed by Yusuke Suzuki. + +* stress/resources/standalone-pre.js: + 2019-11-07 Ross Kirsling Unskip test262 tests for async-iteration Modified: trunk/JSTests/stress/resources/standalone-pre.js (252195 => 252196) --- trunk/JSTests/stress/resources/standalone-pre.js 2019-11-07 19:24:54 UTC (rev 252195) +++ trunk/JSTests/stress/resources/standalone-pre.js 2019-11-07 19:42:10 UTC (rev 252196) @@ -10,7 +10,7 @@ var throwOnFirstFail = true; var silentTestPass, didPassSomeTestsSilently, didFailSomeTests, successfullyParsed; silentTestPass = false; -didPassSomeTestsSilenty = false; +didPassSomeTestsSilently = false; didFailSomeTests = false; function description(msg) Modified: trunk/LayoutTests/ChangeLog (252195 => 252196) --- trunk/LayoutTests/ChangeLog 2019-11-07 19:24:54 UTC (rev 252195) +++ trunk/LayoutTests/ChangeLog 2019-11-07 19:42:10 UTC (rev 252196) @@ -1,3 +1,12 @@ +2019-11-07 Tuomas Karkkainen + +didPassSomeTestsSilenty and didFaileSomeTests are misspelled in standalone-pre.js +https://bugs.webkit.org/show_bug.cgi?id=203948 + +Reviewed by Yusuke Suzuki. + +* resources/standalone-pre.js: + 2019-11-07 Alex Christensen Re-enable NSURLSession isolation after r252116 Modified: trunk/LayoutTests/resources/standalone-pre.js (252195 => 252196) --- trunk/LayoutTests/resources/standalone-pre.js 2019-11-07 19:24:54 UTC (rev 252195) +++ trunk/LayoutTests/resources/standalone-pre.js 2019-11-07 19:42:10 UTC (rev 252196) @@ -10,8 +10,8 @@ var silentTestPass, didPassSomeTestsSilently, didFailSomeTests, successfullyParsed; silentTestPass = false; -didPassSomeTestsSilenty = false; -didFaileSomeTests = false; +didPassSomeTestsSilently = false; +didFailSomeTests = false; function description(msg) { ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252195] trunk/JSTests
Title: [252195] trunk/JSTests Revision 252195 Author ross.kirsl...@sony.com Date 2019-11-07 11:24:54 -0800 (Thu, 07 Nov 2019) Log Message Unskip test262 tests for async-iteration https://bugs.webkit.org/show_bug.cgi?id=203921 Reviewed by Keith Miller. This should have been done two years ago, it seems. * test262/config.yaml: * test262/expectations.yaml: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262/config.yaml trunk/JSTests/test262/expectations.yaml Diff Modified: trunk/JSTests/ChangeLog (252194 => 252195) --- trunk/JSTests/ChangeLog 2019-11-07 19:16:29 UTC (rev 252194) +++ trunk/JSTests/ChangeLog 2019-11-07 19:24:54 UTC (rev 252195) @@ -1,3 +1,15 @@ +2019-11-07 Ross Kirsling + +Unskip test262 tests for async-iteration +https://bugs.webkit.org/show_bug.cgi?id=203921 + +Reviewed by Keith Miller. + +This should have been done two years ago, it seems. + +* test262/config.yaml: +* test262/expectations.yaml: + 2019-11-07 Alexey Shvayka [[HasProperty]] result of Proxy in prototype chain is ignored Modified: trunk/JSTests/test262/config.yaml (252194 => 252195) --- trunk/JSTests/test262/config.yaml 2019-11-07 19:16:29 UTC (rev 252194) +++ trunk/JSTests/test262/config.yaml 2019-11-07 19:24:54 UTC (rev 252195) @@ -9,8 +9,6 @@ features: - SharedArrayBuffer - Atomics -# https://bugs.webkit.org/show_bug.cgi?id=166693 -- async-iteration # https://bugs.webkit.org/show_bug.cgi?id=174931 - regexp-lookbehind Modified: trunk/JSTests/test262/expectations.yaml (252194 => 252195) --- trunk/JSTests/test262/expectations.yaml 2019-11-07 19:16:29 UTC (rev 252194) +++ trunk/JSTests/test262/expectations.yaml 2019-11-07 19:24:54 UTC (rev 252195) @@ -735,6 +735,9 @@ test/built-ins/AsyncFunction/proto-from-ctor-realm.js: default: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object AsyncFunction]», «[object AsyncFunction]») to be true' strict mode: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object AsyncFunction]», «[object AsyncFunction]») to be true' +test/built-ins/AsyncGeneratorFunction/proto-from-ctor-realm.js: + default: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object AsyncGeneratorFunction]», «[object AsyncGeneratorFunction]») to be true' + strict mode: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object AsyncGeneratorFunction]», «[object AsyncGeneratorFunction]») to be true' test/built-ins/BigInt/constructor-integer.js: default: 'RangeError: Not safe integer' strict mode: 'RangeError: Not safe integer' @@ -897,6 +900,9 @@ test/built-ins/Function/prototype/toString/AsyncFunction.js: default: "SyntaxError: Unexpected token ';'. Expected a ')' or a ',' after a parameter declaration." strict mode: "SyntaxError: Unexpected token ';'. Expected a ')' or a ',' after a parameter declaration." +test/built-ins/Function/prototype/toString/AsyncGenerator.js: + default: "SyntaxError: Unexpected token ';'. Expected a ')' or a ',' after a parameter declaration." + strict mode: "SyntaxError: Unexpected token ';'. Expected a ')' or a ',' after a parameter declaration." test/built-ins/Function/prototype/toString/Function.js: default: "SyntaxError: Unexpected token ';'. Expected a ')' or a ',' after a parameter declaration." strict mode: "SyntaxError: Unexpected token ';'. Expected a ')' or a ',' after a parameter declaration." @@ -912,6 +918,27 @@ test/built-ins/Function/prototype/toString/async-function-_expression_.js: default: "Test262Error: Conforms to NativeFunction Syntax: 'async function F( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ }'.(async function /* a */ F /* b */ ( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ })" strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'async function F( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ }'.(async function /* a */ F /* b */ ( /* c */ x /* d */ , /* e */ y /* f */ ) /* g */ { /* h */ ; /* i */ ; /* j */ })" +test/built-ins/Function/prototype/toString/async-generator-declaration.js: + default: "Test262Error: Conforms to NativeFunction Syntax: 'async function* f( /* e */ x /* f */ , /* g */ y /* h */ ) /* i */ { /* j */ ; /* k */ ; /* l */ }'.(async /* a */ function /* b */ * /* c */ f /* d */ ( /* e */ x /* f */ , /* g */ y /* h */ ) /* i */ { /* j */ ; /* k */ ; /* l */ })" + strict mode: "Test262Error: Conforms to NativeFunction Syntax: 'async function* f( /* e */ x /* f */ , /* g */ y /* h */ ) /* i */ { /* j */ ; /* k */ ; /* l */ }'.(async /* a */ function /* b */ * /* c */ f /* d */ ( /* e */ x /* f */ , /* g */ y /* h */ ) /* i */ { /* j */ ; /* k */ ; /* l */ })" +test/built-ins/Function/prototype/toString/async-generator-_expression_.js: + default: "Test262Error: Conforms to
[webkit-changes] [252194] branches/safari-608-branch/Source
Title: [252194] branches/safari-608-branch/Source Revision 252194 Author alanc...@apple.com Date 2019-11-07 11:16:29 -0800 (Thu, 07 Nov 2019) Log Message Cherry-pick r252175. rdar://problem/56971561 AX: WKWebView does not shift Accessibility Focus for Catalyst (203798) https://bugs.webkit.org/show_bug.cgi?id=203798 Patch by Eric Liang on 2019-11-06 Reviewed by Chris Fleizach. Source/WebCore: Changed to use the new cocoa directory instead of macOS only * accessibility/mac/AXObjectCacheMac.mm: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Source/WebCore/PAL: Changed the path of NSAccessibilitySPI from Mac to Cocoa * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/NSAccessibilitySPI.h: Renamed from Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h. Source/WebKit: Added the code to register/unregister remote UI Process identifier on the host app. This is used so that the host app can appear as the sender for notifications sent from its web processes. Unfortunately this has to be done in WebKit: in accessibility bundles the swizzled code is not called because of bundle loading time. Added AppKit softlink for Mac catalyst. * SourcesCocoa.txt: * UIProcess/Cocoa/WebViewImpl.mm: * UIProcess/ios/AppKitSoftLink.h: Added. * UIProcess/ios/AppKitSoftLink.mm: Added. * UIProcess/ios/ViewGestureControllerIOS.mm: (-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]): * UIProcess/ios/WKContentView.mm: (-[WKContentView _updateRemoteAccessibilityRegistration:]): (-[WKContentView _accessibilityRegisterUIProcessTokens]): (-[WKContentView _processDidExit]): * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: * WebProcess/WebPage/mac/WebPageMac.mm: * WebProcess/cocoa/WebProcessCocoa.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252175 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-608-branch/Source/WebCore/ChangeLog branches/safari-608-branch/Source/WebCore/PAL/ChangeLog branches/safari-608-branch/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj branches/safari-608-branch/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm branches/safari-608-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm branches/safari-608-branch/Source/WebKit/ChangeLog branches/safari-608-branch/Source/WebKit/SourcesCocoa.txt branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm branches/safari-608-branch/Source/WebKit/UIProcess/ios/WKContentView.mm branches/safari-608-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm branches/safari-608-branch/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm branches/safari-608-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Added Paths branches/safari-608-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAccessibilitySPI.h branches/safari-608-branch/Source/WebKit/UIProcess/ios/AppKitSoftLink.h branches/safari-608-branch/Source/WebKit/UIProcess/ios/AppKitSoftLink.mm Removed Paths branches/safari-608-branch/Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h Diff Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (252193 => 252194) --- branches/safari-608-branch/Source/WebCore/ChangeLog 2019-11-07 19:12:28 UTC (rev 252193) +++ branches/safari-608-branch/Source/WebCore/ChangeLog 2019-11-07 19:16:29 UTC (rev 252194) @@ -1,3 +1,62 @@ +2019-11-07 Alan Coon + +Cherry-pick r252175. rdar://problem/56971561 + +AX: WKWebView does not shift Accessibility Focus for Catalyst (203798) +https://bugs.webkit.org/show_bug.cgi?id=203798 + +Patch by Eric Liang on 2019-11-06 +Reviewed by Chris Fleizach. + +Source/WebCore: + +Changed to use the new cocoa directory instead of macOS only + +* accessibility/mac/AXObjectCacheMac.mm: +* accessibility/mac/WebAccessibilityObjectWrapperMac.mm: + +Source/WebCore/PAL: + +Changed the path of NSAccessibilitySPI from Mac to Cocoa + +* PAL.xcodeproj/project.pbxproj: +* pal/spi/cocoa/NSAccessibilitySPI.h: Renamed from Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h. + +Source/WebKit: + +Added the code to register/unregister remote UI Process identifier on the host app. +This is used so that the host app can appear as the sender for notifications sent from its web processes. Unfortunately this has to be done in WebKit: in accessibility bundles the swizzled code is not called because of bundle loading time. +Added AppKit softlink for Mac catalyst. + +* SourcesCocoa.txt: +* UIProcess/Cocoa/WebViewImpl.mm: +* UIProcess/ios/AppKitSoftLink.h: Added. +* UIProcess/ios/AppKitSoftLink.mm: Added. +*
[webkit-changes] [252193] branches/safari-608.4.9.1-branch/Source
Title: [252193] branches/safari-608.4.9.1-branch/Source Revision 252193 Author alanc...@apple.com Date 2019-11-07 11:12:28 -0800 (Thu, 07 Nov 2019) Log Message Cherry-pick r252175. rdar://problem/56971561 AX: WKWebView does not shift Accessibility Focus for Catalyst (203798) https://bugs.webkit.org/show_bug.cgi?id=203798 Patch by Eric Liang on 2019-11-06 Reviewed by Chris Fleizach. Source/WebCore: Changed to use the new cocoa directory instead of macOS only * accessibility/mac/AXObjectCacheMac.mm: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Source/WebCore/PAL: Changed the path of NSAccessibilitySPI from Mac to Cocoa * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/NSAccessibilitySPI.h: Renamed from Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h. Source/WebKit: Added the code to register/unregister remote UI Process identifier on the host app. This is used so that the host app can appear as the sender for notifications sent from its web processes. Unfortunately this has to be done in WebKit: in accessibility bundles the swizzled code is not called because of bundle loading time. Added AppKit softlink for Mac catalyst. * SourcesCocoa.txt: * UIProcess/Cocoa/WebViewImpl.mm: * UIProcess/ios/AppKitSoftLink.h: Added. * UIProcess/ios/AppKitSoftLink.mm: Added. * UIProcess/ios/ViewGestureControllerIOS.mm: (-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]): * UIProcess/ios/WKContentView.mm: (-[WKContentView _updateRemoteAccessibilityRegistration:]): (-[WKContentView _accessibilityRegisterUIProcessTokens]): (-[WKContentView _processDidExit]): * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: * WebProcess/WebPage/mac/WebPageMac.mm: * WebProcess/cocoa/WebProcessCocoa.mm: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252175 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-608.4.9.1-branch/Source/WebCore/ChangeLog branches/safari-608.4.9.1-branch/Source/WebCore/PAL/ChangeLog branches/safari-608.4.9.1-branch/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj branches/safari-608.4.9.1-branch/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm branches/safari-608.4.9.1-branch/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm branches/safari-608.4.9.1-branch/Source/WebKit/ChangeLog branches/safari-608.4.9.1-branch/Source/WebKit/SourcesCocoa.txt branches/safari-608.4.9.1-branch/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm branches/safari-608.4.9.1-branch/Source/WebKit/UIProcess/ios/WKContentView.mm branches/safari-608.4.9.1-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj branches/safari-608.4.9.1-branch/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm branches/safari-608.4.9.1-branch/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm branches/safari-608.4.9.1-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Added Paths branches/safari-608.4.9.1-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAccessibilitySPI.h branches/safari-608.4.9.1-branch/Source/WebKit/UIProcess/ios/AppKitSoftLink.h branches/safari-608.4.9.1-branch/Source/WebKit/UIProcess/ios/AppKitSoftLink.mm Removed Paths branches/safari-608.4.9.1-branch/Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h Diff Modified: branches/safari-608.4.9.1-branch/Source/WebCore/ChangeLog (252192 => 252193) --- branches/safari-608.4.9.1-branch/Source/WebCore/ChangeLog 2019-11-07 19:10:01 UTC (rev 252192) +++ branches/safari-608.4.9.1-branch/Source/WebCore/ChangeLog 2019-11-07 19:12:28 UTC (rev 252193) @@ -1,3 +1,62 @@ +2019-11-07 Alan Coon + +Cherry-pick r252175. rdar://problem/56971561 + +AX: WKWebView does not shift Accessibility Focus for Catalyst (203798) +https://bugs.webkit.org/show_bug.cgi?id=203798 + +Patch by Eric Liang on 2019-11-06 +Reviewed by Chris Fleizach. + +Source/WebCore: + +Changed to use the new cocoa directory instead of macOS only + +* accessibility/mac/AXObjectCacheMac.mm: +* accessibility/mac/WebAccessibilityObjectWrapperMac.mm: + +Source/WebCore/PAL: + +Changed the path of NSAccessibilitySPI from Mac to Cocoa + +* PAL.xcodeproj/project.pbxproj: +* pal/spi/cocoa/NSAccessibilitySPI.h: Renamed from Source/WebCore/PAL/pal/spi/mac/NSAccessibilitySPI.h. + +Source/WebKit: + +Added the code to register/unregister remote UI Process identifier on the host app. +This is used so that the host app can appear as the sender for notifications sent from its web processes. Unfortunately this has to be done in WebKit: in accessibility bundles the swizzled code is not called because of bundle loading time. +Added AppKit softlink for Mac catalyst. + +* SourcesCocoa.txt: +* UIProcess/Cocoa/WebViewImpl.mm: +*
[webkit-changes] [252192] branches/safari-608.4.9.1-branch/Source
Title: [252192] branches/safari-608.4.9.1-branch/Source Revision 252192 Author alanc...@apple.com Date 2019-11-07 11:10:01 -0800 (Thu, 07 Nov 2019) Log Message Versioning. Modified Paths branches/safari-608.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-608.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-608.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-608.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-608.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-608.4.9.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-608.4.9.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-608.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (252191 => 252192) --- branches/safari-608.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2019-11-07 18:31:31 UTC (rev 252191) +++ branches/safari-608.4.9.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2019-11-07 19:10:01 UTC (rev 252192) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (252191 => 252192) --- branches/safari-608.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-11-07 18:31:31 UTC (rev 252191) +++ branches/safari-608.4.9.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2019-11-07 19:10:01 UTC (rev 252192) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig (252191 => 252192) --- branches/safari-608.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig 2019-11-07 18:31:31 UTC (rev 252191) +++ branches/safari-608.4.9.1-branch/Source/WebCore/Configurations/Version.xcconfig 2019-11-07 19:10:01 UTC (rev 252192) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (252191 => 252192) --- branches/safari-608.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-11-07 18:31:31 UTC (rev 252191) +++ branches/safari-608.4.9.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2019-11-07 19:10:01 UTC (rev 252192) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-608.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (252191 => 252192) --- branches/safari-608.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-11-07 18:31:31 UTC (rev 252191) +++ branches/safari-608.4.9.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2019-11-07 19:10:01 UTC (rev 252192) @@ -2,7 +2,7 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: branches/safari-608.4.9.1-branch/Source/WebKit/Configurations/Version.xcconfig (252191 => 252192) --- branches/safari-608.4.9.1-branch/Source/WebKit/Configurations/Version.xcconfig 2019-11-07 18:31:31 UTC (rev 252191) +++ branches/safari-608.4.9.1-branch/Source/WebKit/Configurations/Version.xcconfig 2019-11-07 19:10:01 UTC (rev 252192) @@ -25,7 +25,7 @@ MINOR_VERSION = 4; TINY_VERSION = 9; MICRO_VERSION = 1; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified:
[webkit-changes] [252191] trunk
Title: [252191] trunk Revision 252191 Author commit-qu...@webkit.org Date 2019-11-07 10:31:31 -0800 (Thu, 07 Nov 2019) Log Message [[HasProperty]] result of Proxy in prototype chain is ignored https://bugs.webkit.org/show_bug.cgi?id=203560 Patch by Alexey Shvayka on 2019-11-07 Reviewed by Ross Kirsling. JSTests: * stress/proxy-get-prototype-of.js: Correct Proxy "has" trap test. * test262/expectations.yaml: Mark 6 test cases as passing. Source/_javascript_Core: Before this change, when [[HasProperty]] was called on ordinary object with Proxy in prototype chain, falsy result of Proxy's "has" trap was ignored and prototype chain was inspected further. According to spec, OrdinaryHasProperty unconditionally returns result of parent's [[HasProperty]] call. (step 5.a of https://tc39.es/ecma262/#sec-ordinaryhasproperty) * runtime/JSObjectInlines.h: (JSC::JSObject::getPropertySlot): (JSC::JSObject::getNonIndexPropertySlot): * runtime/ProxyObject.cpp: (JSC::ProxyObject::performHasProperty): Walk the prototype chain in performDefaultHasProperty. Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/stress/proxy-get-prototype-of.js trunk/JSTests/test262/expectations.yaml trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSObjectInlines.h trunk/Source/_javascript_Core/runtime/ProxyObject.cpp Diff Modified: trunk/JSTests/ChangeLog (252190 => 252191) --- trunk/JSTests/ChangeLog 2019-11-07 18:30:55 UTC (rev 252190) +++ trunk/JSTests/ChangeLog 2019-11-07 18:31:31 UTC (rev 252191) @@ -1,3 +1,13 @@ +2019-11-07 Alexey Shvayka + +[[HasProperty]] result of Proxy in prototype chain is ignored +https://bugs.webkit.org/show_bug.cgi?id=203560 + +Reviewed by Ross Kirsling. + +* stress/proxy-get-prototype-of.js: Correct Proxy "has" trap test. +* test262/expectations.yaml: Mark 6 test cases as passing. + 2019-11-06 Mark Lam JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut() should fire its watchpoint as the last step. Modified: trunk/JSTests/stress/proxy-get-prototype-of.js (252190 => 252191) --- trunk/JSTests/stress/proxy-get-prototype-of.js 2019-11-07 18:30:55 UTC (rev 252190) +++ trunk/JSTests/stress/proxy-get-prototype-of.js 2019-11-07 18:31:31 UTC (rev 252191) @@ -389,7 +389,6 @@ let called = false; let handler = { getPrototypeOf: function(theTarget) { -assert(theTarget === target); called = true; return proto; }, @@ -400,9 +399,8 @@ let proxy = new Proxy(target, handler); for (let i = 0; i < 500; i++) { -let result = "x" in proxy; -assert(called); -called = false; +let result = 1 in proxy; +assert(!called); } } Modified: trunk/JSTests/test262/expectations.yaml (252190 => 252191) --- trunk/JSTests/test262/expectations.yaml 2019-11-07 18:30:55 UTC (rev 252190) +++ trunk/JSTests/test262/expectations.yaml 2019-11-07 18:31:31 UTC (rev 252191) @@ -633,12 +633,6 @@ test/built-ins/Array/prototype/filter/target-array-with-non-writable-property.js: default: 'TypeError: Attempted to assign to readonly property.' strict mode: 'TypeError: Attempted to assign to readonly property.' -test/built-ins/Array/prototype/indexOf/calls-only-has-on-prototype-after-length-zeroed.js: - default: 'Test262Error: [[GetPrototypeOf]] trap called' - strict mode: 'Test262Error: [[GetPrototypeOf]] trap called' -test/built-ins/Array/prototype/lastIndexOf/calls-only-has-on-prototype-after-length-zeroed.js: - default: 'Test262Error: [[GetPrototypeOf]] trap called' - strict mode: 'Test262Error: [[GetPrototypeOf]] trap called' test/built-ins/Array/prototype/map/target-array-with-non-writable-property.js: default: 'TypeError: Attempted to assign to readonly property.' strict mode: 'TypeError: Attempted to assign to readonly property.' @@ -664,8 +658,8 @@ default: 'Test262Error: Length is 2**53 - 1 Expected a TypeError to be thrown but no exception was thrown at all' strict mode: 'Test262Error: Length is 2**53 - 1 Expected a TypeError to be thrown but no exception was thrown at all' test/built-ins/Array/prototype/reverse/length-exceeding-integer-limit-with-proxy.js: - default: 'Test262Error: Expected a StopReverse but got a Test262Error' - strict mode: 'Test262Error: Expected a StopReverse but got a Test262Error' + default: 'Test262Error: Expected [Get:length, Has:0, Get:0, Has:4294967294, Delete:0, Set:4294967294, GetOwnPropertyDescriptor:4294967294, DefineProperty:4294967294, Has:1, Has:4294967293, Delete:1, Delete:4294967293, Has:2, Get:2, Has:4294967292, Delete:2, Set:4294967292, GetOwnPropertyDescriptor:4294967292, DefineProperty:4294967292, Has:3, Has:4294967291, Delete:3, Delete:4294967291, Has:4, Get:4] and [Get:length, Has:0, Get:0, Has:9007199254740990, Get:9007199254740990, Set:0, GetOwnPropertyDescriptor:0, DefineProperty:0, Set:9007199254740990,
[webkit-changes] [252190] trunk/Tools
Title: [252190] trunk/Tools Revision 252190 Author aakash_j...@apple.com Date 2019-11-07 10:30:55 -0800 (Thu, 07 Nov 2019) Log Message [ews] rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch https://bugs.webkit.org/show_bug.cgi?id=203959 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/ews-build/steps.py: (RunJSCTestsWithoutPatch): Renamed. * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests. Modified Paths trunk/Tools/BuildSlaveSupport/ews-build/steps.py trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (252189 => 252190) --- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-07 18:03:15 UTC (rev 252189) +++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-07 18:30:55 UTC (rev 252190) @@ -967,12 +967,12 @@ self.build.buildFinished([message], SUCCESS) else: self.setProperty('patchFailedTests', True) -self.build.addStepsAfterCurrentStep([UnApplyPatchIfRequired(), CompileJSCToT(), RunJavaScriptCoreTestsToT()]) +self.build.addStepsAfterCurrentStep([UnApplyPatchIfRequired(), CompileJSCToT(), RunJSCTestsWithoutPatch()]) return rc -class RunJavaScriptCoreTestsToT(RunJavaScriptCoreTests): -name = 'jscore-test-tot' +class RunJSCTestsWithoutPatch(RunJavaScriptCoreTests): +name = 'jscore-test-without-patch' jsonFileName = 'jsc_results.json' def evaluateCommand(self, cmd): Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (252189 => 252190) --- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-11-07 18:03:15 UTC (rev 252189) +++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2019-11-07 18:30:55 UTC (rev 252190) @@ -39,7 +39,7 @@ CompileJSC, CompileJSCToT, CompileWebKit, CompileWebKitToT, ConfigureBuild, DownloadBuiltProduct, DownloadBuiltProductFromMaster, ExtractBuiltProduct, ExtractTestResults, InstallGtkDependencies, InstallWpeDependencies, KillOldProcesses, PrintConfiguration, ReRunAPITests, ReRunJavaScriptCoreTests, ReRunWebKitTests, RunAPITests, RunAPITestsWithoutPatch, - RunBindingsTests, RunBuildWebKitOrgUnitTests, RunEWSBuildbotCheckConfig, RunEWSUnitTests, RunJavaScriptCoreTests, RunJavaScriptCoreTestsToT, RunWebKit1Tests, + RunBindingsTests, RunBuildWebKitOrgUnitTests, RunEWSBuildbotCheckConfig, RunEWSUnitTests, RunJavaScriptCoreTests, RunJSCTestsWithoutPatch, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyTests, RunWebKitTests, RunWebKitTestsWithoutPatch, TestWithFailureCount, Trigger, TransferToS3, UnApplyPatchIfRequired, UpdateWorkingDirectory, UploadBuiltProduct, UploadTestResults, ValidatePatch) @@ -1085,7 +1085,7 @@ return self.runStep() -class TestRunJavaScriptCoreTestsToT(BuildStepMixinAdditions, unittest.TestCase): +class TestRunJSCTestsWithoutPatch(BuildStepMixinAdditions, unittest.TestCase): def setUp(self): self.longMessage = True self.jsonFileName = 'jsc_results.json' @@ -1095,7 +1095,7 @@ return self.tearDownBuildStep() def test_success(self): -self.setupStep(RunJavaScriptCoreTestsToT()) +self.setupStep(RunJSCTestsWithoutPatch()) self.setProperty('fullPlatform', 'jsc-only') self.setProperty('configuration', 'release') self.expectRemoteCommands( @@ -1110,7 +1110,7 @@ return self.runStep() def test_failure(self): -self.setupStep(RunJavaScriptCoreTestsToT()) +self.setupStep(RunJSCTestsWithoutPatch()) self.setProperty('fullPlatform', 'jsc-only') self.setProperty('configuration', 'debug') self.expectRemoteCommands( Modified: trunk/Tools/ChangeLog (252189 => 252190) --- trunk/Tools/ChangeLog 2019-11-07 18:03:15 UTC (rev 252189) +++ trunk/Tools/ChangeLog 2019-11-07 18:30:55 UTC (rev 252190) @@ -1,3 +1,14 @@ +2019-11-07 Aakash Jain + +[ews] rename RunJavaScriptCoreTestsToT to RunJSCTestsWithoutPatch +https://bugs.webkit.org/show_bug.cgi?id=203959 + +Reviewed by Alexey Proskuryakov. + +* BuildSlaveSupport/ews-build/steps.py: +(RunJSCTestsWithoutPatch): Renamed. +* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests. + 2019-11-07 Alex Christensen Re-enable NSURLSession isolation after r252116 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252189] trunk/Source/WebCore
Title: [252189] trunk/Source/WebCore Revision 252189 Author za...@apple.com Date 2019-11-07 10:03:15 -0800 (Thu, 07 Nov 2019) Log Message [LFC][MarginCollapsing] Drag anonymous block level boxes into margin collapsing https://bugs.webkit.org/show_bug.cgi?id=203927 Reviewed by Antti Koivisto. We've been ignoring anonymous block level boxes in the context of margin collapsing. Now with IFC, we can't really do that anymore. This patch removes the early bailout on anon boxes and addresses the fallout. * layout/MarginTypes.h: * layout/blockformatting/BlockMarginCollapse.cpp: (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore const): (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter const): (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore const): (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginAfter const): (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter const): (WebCore::Layout::BlockFormattingContext::MarginCollapse::updateMarginAfterForPreviousSibling): (WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginAfter const): (WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore): (WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeIgnoringCollapsingThrough): (WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/MarginTypes.h trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (252188 => 252189) --- trunk/Source/WebCore/ChangeLog 2019-11-07 17:31:16 UTC (rev 252188) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 18:03:15 UTC (rev 252189) @@ -1,3 +1,27 @@ +2019-11-07 Zalan Bujtas + +[LFC][MarginCollapsing] Drag anonymous block level boxes into margin collapsing +https://bugs.webkit.org/show_bug.cgi?id=203927 + + +Reviewed by Antti Koivisto. + +We've been ignoring anonymous block level boxes in the context of margin collapsing. Now with IFC, we can't really do that anymore. +This patch removes the early bailout on anon boxes and addresses the fallout. + +* layout/MarginTypes.h: +* layout/blockformatting/BlockMarginCollapse.cpp: +(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithParentMarginBefore const): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithPreviousSiblingMarginAfter const): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeCollapsesWithFirstInFlowChildMarginBefore const): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithParentMarginAfter const): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginAfterCollapsesWithLastInFlowChildMarginAfter const): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::updateMarginAfterForPreviousSibling): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeMarginAfter const): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::estimatedMarginBefore): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBeforeIgnoringCollapsingThrough): +(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedVerticalValues): + 2019-11-07 Alex Christensen Re-enable NSURLSession isolation after r252116 Modified: trunk/Source/WebCore/layout/MarginTypes.h (252188 => 252189) --- trunk/Source/WebCore/layout/MarginTypes.h 2019-11-07 17:31:16 UTC (rev 252188) +++ trunk/Source/WebCore/layout/MarginTypes.h 2019-11-07 18:03:15 UTC (rev 252189) @@ -82,6 +82,12 @@ bool isCollapsedThrough { false }; }; +// FIXME: This structure might need to change to indicate that the cached value is not necessarily the same as the box's computed margin value. +// This only matters in case of collapse through margins when they collapse into another sibling box. +// <- the second div's before/after marings collapse through and the same time they collapse into +// the first div. When the parent computes its before margin, it should see the second div's collapsed through margin as the value to collapse width (adjoining margin value). +// So while the first div's before margin is not 10px, the cached value is 10px so that when we compute the parent's margin we just need to check the fist +// inflow child's cached margin value. struct PositiveAndNegativeVerticalMargin { struct Values { bool isNonZero() const { return positive.valueOr(0) || negative.valueOr(0); } Modified:
[webkit-changes] [252186] releases/WebKitGTK/webkit-2.26/Source
Title: [252186] releases/WebKitGTK/webkit-2.26/Source Revision 252186 Author ape...@igalia.com Date 2019-11-07 09:30:08 -0800 (Thu, 07 Nov 2019) Log Message Unreviewed build fixed for non-unified builds. Source/WebCore: No new tests needed. * Modules/indexeddb/shared/IDBGetAllRecordsData.cpp: Add missing inclusion of the wtf/text/StringConcatenateNumbers.h header. * Modules/indexeddb/shared/IDBIterateCursorData.cpp: Ditto. * page/DOMWindowExtension.cpp: Add missing inclusion of the Document.h header. * platform/glib/UserAgentGLib.cpp: Add missing inclusion of the HTTPParsers.h header. Source/WebKit: * NetworkProcess/NetworkConnectionToWebProcess.cpp: Add missin inclusion of the Logging.h header Modified Paths releases/WebKitGTK/webkit-2.26/Source/WebCore/ChangeLog releases/WebKitGTK/webkit-2.26/Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.cpp releases/WebKitGTK/webkit-2.26/Source/WebCore/Modules/indexeddb/shared/IDBIterateCursorData.cpp releases/WebKitGTK/webkit-2.26/Source/WebCore/page/DOMWindowExtension.cpp releases/WebKitGTK/webkit-2.26/Source/WebCore/platform/glib/UserAgentGLib.cpp releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog releases/WebKitGTK/webkit-2.26/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp Diff Modified: releases/WebKitGTK/webkit-2.26/Source/WebCore/ChangeLog (252185 => 252186) --- releases/WebKitGTK/webkit-2.26/Source/WebCore/ChangeLog 2019-11-07 17:05:18 UTC (rev 252185) +++ releases/WebKitGTK/webkit-2.26/Source/WebCore/ChangeLog 2019-11-07 17:30:08 UTC (rev 252186) @@ -1,3 +1,15 @@ +2019-11-07 Adrian Perez de Castro + +Unreviewed build fixed for non-unified builds. + +No new tests needed. + +* Modules/indexeddb/shared/IDBGetAllRecordsData.cpp: Add missing inclusion of the +wtf/text/StringConcatenateNumbers.h header. +* Modules/indexeddb/shared/IDBIterateCursorData.cpp: Ditto. +* page/DOMWindowExtension.cpp: Add missing inclusion of the Document.h header. +* platform/glib/UserAgentGLib.cpp: Add missing inclusion of the HTTPParsers.h header. + 2019-10-14 Carlos Garcia Campos [GTK] White pages in AC mode: Cannot get default EGL display: EGL_BAD_PARAMETER Modified: releases/WebKitGTK/webkit-2.26/Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.cpp (252185 => 252186) --- releases/WebKitGTK/webkit-2.26/Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.cpp 2019-11-07 17:05:18 UTC (rev 252185) +++ releases/WebKitGTK/webkit-2.26/Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.cpp 2019-11-07 17:30:08 UTC (rev 252186) @@ -29,6 +29,7 @@ #if ENABLE(INDEXED_DATABASE) #include "IDBKeyRangeData.h" +#include namespace WebCore { Modified: releases/WebKitGTK/webkit-2.26/Source/WebCore/Modules/indexeddb/shared/IDBIterateCursorData.cpp (252185 => 252186) --- releases/WebKitGTK/webkit-2.26/Source/WebCore/Modules/indexeddb/shared/IDBIterateCursorData.cpp 2019-11-07 17:05:18 UTC (rev 252185) +++ releases/WebKitGTK/webkit-2.26/Source/WebCore/Modules/indexeddb/shared/IDBIterateCursorData.cpp 2019-11-07 17:30:08 UTC (rev 252186) @@ -28,6 +28,8 @@ #if ENABLE(INDEXED_DATABASE) +#include + namespace WebCore { IDBIterateCursorData IDBIterateCursorData::isolatedCopy() const Modified: releases/WebKitGTK/webkit-2.26/Source/WebCore/page/DOMWindowExtension.cpp (252185 => 252186) --- releases/WebKitGTK/webkit-2.26/Source/WebCore/page/DOMWindowExtension.cpp 2019-11-07 17:05:18 UTC (rev 252185) +++ releases/WebKitGTK/webkit-2.26/Source/WebCore/page/DOMWindowExtension.cpp 2019-11-07 17:30:08 UTC (rev 252186) @@ -28,6 +28,7 @@ #include "DOMWindow.h" #include "DOMWrapperWorld.h" +#include "Document.h" #include "Frame.h" #include "FrameLoader.h" #include "FrameLoaderClient.h" Modified: releases/WebKitGTK/webkit-2.26/Source/WebCore/platform/glib/UserAgentGLib.cpp (252185 => 252186) --- releases/WebKitGTK/webkit-2.26/Source/WebCore/platform/glib/UserAgentGLib.cpp 2019-11-07 17:05:18 UTC (rev 252185) +++ releases/WebKitGTK/webkit-2.26/Source/WebCore/platform/glib/UserAgentGLib.cpp 2019-11-07 17:30:08 UTC (rev 252186) @@ -27,6 +27,7 @@ #include "config.h" #include "UserAgent.h" +#include "HTTPParsers.h" #include "UserAgentQuirks.h" #include #include Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog (252185 => 252186) --- releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog 2019-11-07 17:05:18 UTC (rev 252185) +++ releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog 2019-11-07 17:30:08 UTC (rev 252186) @@ -1,3 +1,9 @@ +2019-11-07 Adrian Perez de Castro + +Unreviewed build fixed for non-unified builds. + +* NetworkProcess/NetworkConnectionToWebProcess.cpp: Add missin inclusion of the Logging.h header + 2019-11-06 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.26.2 release Modified:
[webkit-changes] [252187] releases/WebKitGTK/webkit-2.26
Title: [252187] releases/WebKitGTK/webkit-2.26 Revision 252187 Author ape...@igalia.com Date 2019-11-07 09:30:14 -0800 (Thu, 07 Nov 2019) Log Message Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.2 release .: * Source/cmake/OptionsWPE.cmake: Bump version numbers. Source/WebKit: * wpe/NEWS: Add release notes for 2.26.2. Modified Paths releases/WebKitGTK/webkit-2.26/ChangeLog releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog releases/WebKitGTK/webkit-2.26/Source/WebKit/wpe/NEWS releases/WebKitGTK/webkit-2.26/Source/cmake/OptionsWPE.cmake Diff Modified: releases/WebKitGTK/webkit-2.26/ChangeLog (252186 => 252187) --- releases/WebKitGTK/webkit-2.26/ChangeLog 2019-11-07 17:30:08 UTC (rev 252186) +++ releases/WebKitGTK/webkit-2.26/ChangeLog 2019-11-07 17:30:14 UTC (rev 252187) @@ -1,3 +1,9 @@ +2019-11-07 Adrian Perez de Castro + +Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.2 release + +* Source/cmake/OptionsWPE.cmake: Bump version numbers. + 2019-11-06 Carlos Garcia Campos Unreviewed. Update OptionsGTK.cmake and NEWS for 2.26.2 release Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog (252186 => 252187) --- releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog 2019-11-07 17:30:08 UTC (rev 252186) +++ releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog 2019-11-07 17:30:14 UTC (rev 252187) @@ -1,5 +1,11 @@ 2019-11-07 Adrian Perez de Castro +Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.2 release + +* wpe/NEWS: Add release notes for 2.26.2. + +2019-11-07 Adrian Perez de Castro + Unreviewed build fixed for non-unified builds. * NetworkProcess/NetworkConnectionToWebProcess.cpp: Add missin inclusion of the Logging.h header Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/wpe/NEWS (252186 => 252187) --- releases/WebKitGTK/webkit-2.26/Source/WebKit/wpe/NEWS 2019-11-07 17:30:08 UTC (rev 252186) +++ releases/WebKitGTK/webkit-2.26/Source/WebKit/wpe/NEWS 2019-11-07 17:30:14 UTC (rev 252187) @@ -1,4 +1,18 @@ = +WPE WebKit 2.26.2 += + +What's new in WPE WebKit 2.26.2? + + - Improve performance of querying system fallback fonts. + - Don't use prgname in dbus-proxy socket path. + - Fix thread-safety issues in image decoders. + - Fix the build with WebDriver disabled. + - Disable accelerated compositing when we fail to initialize the EGL dispaly under Wayland. + - Fill the objects category in emoji picker. + - Fix several crashes and rendering issues. + += WPE WebKit 2.26.1 = Modified: releases/WebKitGTK/webkit-2.26/Source/cmake/OptionsWPE.cmake (252186 => 252187) --- releases/WebKitGTK/webkit-2.26/Source/cmake/OptionsWPE.cmake 2019-11-07 17:30:08 UTC (rev 252186) +++ releases/WebKitGTK/webkit-2.26/Source/cmake/OptionsWPE.cmake 2019-11-07 17:30:14 UTC (rev 252187) @@ -1,10 +1,10 @@ include(GNUInstallDirs) include(VersioningUtils) -SET_PROJECT_VERSION(2 26 1) +SET_PROJECT_VERSION(2 26 2) set(WPE_API_VERSION 1.0) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 8 2 5) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 8 3 5) # These are shared variables, but we special case their definition so that we can use the # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252188] releases/WPE WebKit/webkit-2.26.2/
Title: [252188] releases/WPE WebKit/webkit-2.26.2/ Revision 252188 Author ape...@igalia.com Date 2019-11-07 09:31:16 -0800 (Thu, 07 Nov 2019) Log Message WPE WebKit 2.26.2 Added Paths releases/WPE WebKit/webkit-2.26.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252185] trunk
Title: [252185] trunk Revision 252185 Author achristen...@apple.com Date 2019-11-07 09:05:18 -0800 (Thu, 07 Nov 2019) Log Message Re-enable NSURLSession isolation after r252116 https://bugs.webkit.org/show_bug.cgi?id=203934 Reviewed by Chris Dumez. Source/WebCore: * platform/network/StoredCredentialsPolicy.h: Source/WebKit: r252116 was a rollout of r248640, which introduced cases where data tasks from different NSURLSessions which can have the same task identifiers were put into the same maps. This key collision caused data from the wrong tasks to be sent to NetworkResourceLoader, causing rare and strange loading bugs. In order to prevent insertion into wrong maps again, I made a new abstraction, SessionWrapper, which wraps a NSURLSession, its delegate, and all maps that are scoped to that NSURLSession. Along the way I found a few other places where we had made similar mistakes. Covered by an API test which would've failed before r252116 because it exercises the key collision condition, and by tests which were skipped in r252116 and I now unskipped. * NetworkProcess/Downloads/cocoa/DownloadCocoa.mm: (WebKit::Download::resume): * NetworkProcess/cocoa/NetworkDataTaskCocoa.h: * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): (WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa): * NetworkProcess/cocoa/NetworkSessionCocoa.h: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate initWithSessionWrapper:withCredentials:]): (-[WKNetworkSessionDelegate sessionInvalidated]): (-[WKNetworkSessionDelegate existingTask:]): (-[WKNetworkSessionDelegate sessionCocoa]): (-[WKNetworkSessionDelegate URLSession:didBecomeInvalidWithError:]): (-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]): (-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]): (-[WKNetworkSessionDelegate URLSession:dataTask:willCacheResponse:completionHandler:]): (processServerTrustEvaluation): (-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]): (-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]): (-[WKNetworkSessionDelegate URLSession:downloadTask:didFinishDownloadingToURL:]): (-[WKNetworkSessionDelegate URLSession:downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]): (-[WKNetworkSessionDelegate URLSession:dataTask:didBecomeDownloadTask:]): (-[WKNetworkSessionDelegate existingWebSocketTask:]): (WebKit::SessionWrapper::initialize): (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): (WebKit::NetworkSessionCocoa::initializeEphemeralStatelessSession): (WebKit::NetworkSessionCocoa::sessionWrapperForTask): (WebKit::NetworkSessionCocoa::isolatedSession): (WebKit::NetworkSessionCocoa::invalidateAndCancel): (WebKit::NetworkSessionCocoa::continueDidReceiveChallenge): (WebKit::NetworkSessionCocoa::createWebSocketTask): (WebKit::NetworkSessionCocoa::addWebSocketTask): (WebKit::NetworkSessionCocoa::removeWebSocketTask): (-[WKNetworkSessionDelegate initWithNetworkSession:withCredentials:]): Deleted. (WebKit::NetworkSessionCocoa::initializeEphemeralStatelessCookielessSession): Deleted. (WebKit::NetworkSessionCocoa::session): Deleted. (WebKit::NetworkSessionCocoa::dataTaskForIdentifier): Deleted. (WebKit::NetworkSessionCocoa::downloadTaskWithResumeData): Deleted. (WebKit::NetworkSessionCocoa::addDownloadID): Deleted. (WebKit::NetworkSessionCocoa::downloadID): Deleted. (WebKit::NetworkSessionCocoa::takeDownloadID): Deleted. (WebKit::NetworkSessionCocoa::webSocketDataTaskForIdentifier): Deleted. * UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _logUserInteraction:completionHandler:]): * UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h: Tools: * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm: (-[DataTaskIdentifierCollisionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): (-[DataTaskIdentifierCollisionDelegate waitForMessages:]): (-[DataTaskIdentifierCollisionDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]): (TEST): LayoutTests: * platform/wk2/TestExpectations: Re-enable skipped tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/StoredCredentialsPolicy.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp trunk/Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp trunk/Source/WebKit/NetworkProcess/NetworkDataTask.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
[webkit-changes] [252184] trunk/Tools
Title: [252184] trunk/Tools Revision 252184 Author commit-qu...@webkit.org Date 2019-11-07 08:32:03 -0800 (Thu, 07 Nov 2019) Log Message Add support for remotes file for EWS builders https://bugs.webkit.org/show_bug.cgi?id=203899 Patch by Paulo Matos on 2019-11-07 Reviewed by Aakash Jain. Require to support builders that cross-compile and run tests on native machines through the use of --remote-config-file. * BuildSlaveSupport/ews-build/factories.py: (Factory.__init__): (StyleFactory.__init__): (WatchListFactory.__init__): * BuildSlaveSupport/ews-build/loadConfig.py: (loadBuilderConfig): * BuildSlaveSupport/ews-build/steps.py: (ConfigureBuild.__init__): (ConfigureBuild.start): (RunJavaScriptCoreTests.start): * BuildSlaveSupport/ews-build/steps_unittest.py: (TestRunJavaScriptCoreTests.test_remote_success): Modified Paths trunk/Tools/BuildSlaveSupport/ews-build/factories.py trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py trunk/Tools/BuildSlaveSupport/ews-build/steps.py trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/ews-build/factories.py (252183 => 252184) --- trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2019-11-07 14:55:13 UTC (rev 252183) +++ trunk/Tools/BuildSlaveSupport/ews-build/factories.py 2019-11-07 16:32:03 UTC (rev 252184) @@ -33,9 +33,9 @@ class Factory(factory.BuildFactory): -def __init__(self, platform, configuration=None, architectures=None, buildOnly=True, triggers=None, additionalArguments=None, checkRelevance=False, **kwargs): +def __init__(self, platform, configuration=None, architectures=None, buildOnly=True, triggers=None, remotes=None, additionalArguments=None, checkRelevance=False, **kwargs): factory.BuildFactory.__init__(self) -self.addStep(ConfigureBuild(platform, configuration, architectures, buildOnly, triggers, additionalArguments)) +self.addStep(ConfigureBuild(platform, configuration, architectures, buildOnly, triggers, remotes, additionalArguments)) if checkRelevance: self.addStep(CheckPatchRelevance()) self.addStep(ValidatePatch()) @@ -49,9 +49,9 @@ class StyleFactory(factory.BuildFactory): -def __init__(self, platform, configuration=None, architectures=None, triggers=None, additionalArguments=None, **kwargs): +def __init__(self, platform, configuration=None, architectures=None, triggers=None, remotes=None, additionalArguments=None, **kwargs): factory.BuildFactory.__init__(self) -self.addStep(ConfigureBuild(platform, configuration, architectures, False, triggers, additionalArguments)) +self.addStep(ConfigureBuild(platform, configuration, architectures, False, triggers, remotes, additionalArguments)) self.addStep(ValidatePatch()) self.addStep(PrintConfiguration()) self.addStep(CheckOutSource()) @@ -61,9 +61,9 @@ class WatchListFactory(factory.BuildFactory): -def __init__(self, platform, configuration=None, architectures=None, triggers=None, additionalArguments=None, **kwargs): +def __init__(self, platform, configuration=None, architectures=None, triggers=None, remotes=None, additionalArguments=None, **kwargs): factory.BuildFactory.__init__(self) -self.addStep(ConfigureBuild(platform, configuration, architectures, False, triggers, additionalArguments)) +self.addStep(ConfigureBuild(platform, configuration, architectures, False, triggers, remotes, additionalArguments)) self.addStep(ValidatePatch()) self.addStep(PrintConfiguration()) self.addStep(CheckOutSource()) Modified: trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py (252183 => 252184) --- trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-11-07 14:55:13 UTC (rev 252183) +++ trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py 2019-11-07 16:32:03 UTC (rev 252184) @@ -65,7 +65,7 @@ if 'icon' in builder: del builder['icon'] factorykwargs = {} -for key in ['platform', 'configuration', 'architectures', 'triggers', 'additionalArguments', 'runTests']: +for key in ['platform', 'configuration', 'architectures', 'triggers', 'remotes', 'additionalArguments', 'runTests']: value = builder.pop(key, None) if value: factorykwargs[key] = value Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (252183 => 252184) --- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-07 14:55:13 UTC (rev 252183) +++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-11-07 16:32:03 UTC (rev 252184) @@ -49,7 +49,7 @@ description = ['configuring build'] descriptionDone = ['Configured build'] -def __init__(self, platform, configuration, architectures, buildOnly, triggers, additionalArguments): +def __init__(self, platform, configuration, architectures, buildOnly, triggers, remotes, additionalArguments):
[webkit-changes] [252183] trunk/Source/WebKit
Title: [252183] trunk/Source/WebKit Revision 252183 Author commit-qu...@webkit.org Date 2019-11-07 06:55:13 -0800 (Thu, 07 Nov 2019) Log Message ASSERTION FAILED: m_clientCounts.contains(contextId) in WebKit::VideoFullscreenManagerProxy::removeClientForContext(uint64_t) https://bugs.webkit.org/show_bug.cgi?id=203918 Patch by Peng Liu on 2019-11-07 Reviewed by Jer Noble. Postpone the transition to exit fullscreen of a video element before the previous transition of fullscreen mode change is completed. Fix a flakey layout test (media/video-autoplay.html). No new test is needed. * WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm Diff Modified: trunk/Source/WebKit/ChangeLog (252182 => 252183) --- trunk/Source/WebKit/ChangeLog 2019-11-07 14:15:45 UTC (rev 252182) +++ trunk/Source/WebKit/ChangeLog 2019-11-07 14:55:13 UTC (rev 252183) @@ -1,3 +1,18 @@ +2019-11-07 Peng Liu + +ASSERTION FAILED: m_clientCounts.contains(contextId) in WebKit::VideoFullscreenManagerProxy::removeClientForContext(uint64_t) +https://bugs.webkit.org/show_bug.cgi?id=203918 + +Reviewed by Jer Noble. + +Postpone the transition to exit fullscreen of a video element +before the previous transition of fullscreen mode change is completed. + +Fix a flakey layout test (media/video-autoplay.html). No new test is needed. + +* WebProcess/cocoa/VideoFullscreenManager.mm: +(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement): + 2019-11-07 Carlos Garcia Campos WebDriver: correctly handle errors when focusing element before sending key events Modified: trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm (252182 => 252183) --- trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm 2019-11-07 14:15:45 UTC (rev 252182) +++ trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm 2019-11-07 14:55:13 UTC (rev 252183) @@ -299,7 +299,7 @@ interface.setTargetIsFullscreen(false); -if (interface.animationState() == VideoFullscreenInterfaceContext::AnimationType::FromFullscreen) +if (interface.animationState() != VideoFullscreenInterfaceContext::AnimationType::None) return; interface.setAnimationState(VideoFullscreenInterfaceContext::AnimationType::FromFullscreen); m_page->send(Messages::VideoFullscreenManagerProxy::ExitFullscreen(contextId, inlineVideoFrame(videoElement))); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [252182] trunk/Source/WebCore
Title: [252182] trunk/Source/WebCore Revision 252182 Author andresg...@apple.com Date 2019-11-07 06:15:45 -0800 (Thu, 07 Nov 2019) Log Message Rename AXIsolatedTreeNode to AXIsolatedObject for consistency with AXCoreObject and AccessibilityObject. https://bugs.webkit.org/show_bug.cgi?id=203913 Reviewed by Chris Fleizach. No new tests needed, no new functionality. - Renamed AXIsolatedTreeNode as AXIsolatedObject. - This makes the naming consistent with AXCoreObject and AccessibilityObject. - Some code cleanup in WebAccessibilityObjectWrapperBase.h. * accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::createIsolatedAccessibilityTreeHierarchy): (WebCore::AXObjectCache::generateIsolatedAccessibilityTree): * accessibility/AXObjectCache.h: * accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::nodeInTreeForID): (WebCore::AXIsolatedTree::nodeForID const): (WebCore::AXIsolatedTree::focusedUIElement): (WebCore::AXIsolatedTree::rootNode): (WebCore::AXIsolatedTree::setRoot): (WebCore::AXIsolatedTree::appendNodeChanges): (WebCore::AXIsolatedTree::applyPendingChanges): * accessibility/isolatedtree/AXIsolatedTree.h: * accessibility/isolatedtree/AXIsolatedTreeNode.cpp: (WebCore::AXIsolatedObject::AXIsolatedObject): (WebCore::AXIsolatedObject::create): (WebCore::AXIsolatedObject::initializeAttributeData): (WebCore::AXIsolatedObject::setProperty): (WebCore::AXIsolatedObject::appendChild): (WebCore::AXIsolatedObject::setParent): (WebCore::AXIsolatedObject::setTreeIdentifier): (WebCore::AXIsolatedObject::children): (WebCore::AXIsolatedObject::focusedUIElement const): (WebCore::AXIsolatedObject::parentObjectUnignored const): (WebCore::AXIsolatedObject::accessibilityHitTest const): (WebCore::AXIsolatedObject::tree const): (WebCore::AXIsolatedObject::rectAttributeValue const): (WebCore::AXIsolatedObject::doubleAttributeValue const): (WebCore::AXIsolatedObject::unsignedAttributeValue const): (WebCore::AXIsolatedObject::boolAttributeValue const): (WebCore::AXIsolatedObject::stringAttributeValue const): (WebCore::AXIsolatedObject::intAttributeValue const): (WebCore::AXIsolatedObject::updateBackingStore): (WebCore::AXIsolatedTreeNode::AXIsolatedTreeNode): Deleted. (WebCore::AXIsolatedTreeNode::create): Deleted. (WebCore::AXIsolatedTreeNode::initializeAttributeData): Deleted. (WebCore::AXIsolatedTreeNode::setProperty): Deleted. (WebCore::AXIsolatedTreeNode::appendChild): Deleted. (WebCore::AXIsolatedTreeNode::setParent): Deleted. (WebCore::AXIsolatedTreeNode::setTreeIdentifier): Deleted. (WebCore::AXIsolatedTreeNode::children): Deleted. (WebCore::AXIsolatedTreeNode::focusedUIElement const): Deleted. (WebCore::AXIsolatedTreeNode::parentObjectUnignored const): Deleted. (WebCore::AXIsolatedTreeNode::accessibilityHitTest const): Deleted. (WebCore::AXIsolatedTreeNode::tree const): Deleted. (WebCore::AXIsolatedTreeNode::rectAttributeValue const): Deleted. (WebCore::AXIsolatedTreeNode::doubleAttributeValue const): Deleted. (WebCore::AXIsolatedTreeNode::unsignedAttributeValue const): Deleted. (WebCore::AXIsolatedTreeNode::boolAttributeValue const): Deleted. (WebCore::AXIsolatedTreeNode::stringAttributeValue const): Deleted. (WebCore::AXIsolatedTreeNode::intAttributeValue const): Deleted. (WebCore::AXIsolatedTreeNode::updateBackingStore): Deleted. * accessibility/isolatedtree/AXIsolatedTreeNode.h: * accessibility/mac/WebAccessibilityObjectWrapperBase.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AXObjectCache.h trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h Diff Modified: trunk/Source/WebCore/ChangeLog (252181 => 252182) --- trunk/Source/WebCore/ChangeLog 2019-11-07 13:21:57 UTC (rev 252181) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 14:15:45 UTC (rev 252182) @@ -1,5 +1,73 @@ 2019-11-07 Andres Gonzalez +Rename AXIsolatedTreeNode to AXIsolatedObject for consistency with AXCoreObject and AccessibilityObject. +https://bugs.webkit.org/show_bug.cgi?id=203913 + +Reviewed by Chris Fleizach. + +No new tests needed, no new functionality. + +- Renamed AXIsolatedTreeNode as AXIsolatedObject. +- This makes the naming consistent with AXCoreObject and AccessibilityObject. +- Some code cleanup in WebAccessibilityObjectWrapperBase.h. + +* accessibility/AXObjectCache.cpp: +(WebCore::AXObjectCache::createIsolatedAccessibilityTreeHierarchy): +(WebCore::AXObjectCache::generateIsolatedAccessibilityTree): +* accessibility/AXObjectCache.h: +* accessibility/isolatedtree/AXIsolatedTree.cpp: +
[webkit-changes] [252181] trunk/Source/WebCore
Title: [252181] trunk/Source/WebCore Revision 252181 Author andresg...@apple.com Date 2019-11-07 05:21:57 -0800 (Thu, 07 Nov 2019) Log Message Implement AXIsolatedTreeNode::roleDescription. https://bugs.webkit.org/show_bug.cgi?id=203863 Reviewed by Chris Fleizach. No new tests needed, no new functionality. AccessibilityObjectWrapper cannot call any of the AX.*Text functions to retrieve localized role descriptions, because when running on the secondary thread, those AtomStrings are not accessible. Moreover, some of the special cases require access to DOM objects that are not available in the secondary thread. Therefore, added AXCoreObject::rolePlatformDescription that runs in the main thread to initialize the corresponding attribute in AXIsolatedTreeNode. rolePlatformString, createPlatformRoleMap, roleToPlatformString, ariaLandmarkRoleDescription, are helper functions. The platform functions allow to customize the behavior of roleDescription in each platform. The platform overrides are implemented for mac. Other platforms are pending. * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::rolePlatformString const): (WebCore::AccessibilityObject::rolePlatformDescription const): (WebCore::AccessibilityObject::ariaLandmarkRoleDescription const): (WebCore::AccessibilityObject::roleDescription const): (WebCore::Accessibility::createPlatformRoleMap): (WebCore::Accessibility::roleToPlatformString): * accessibility/AccessibilityObject.h: * accessibility/AccessibilityObjectInterface.h: * accessibility/isolatedtree/AXIsolatedTreeNode.cpp: (WebCore::AXIsolatedTreeNode::initializeAttributeData): * accessibility/isolatedtree/AXIsolatedTreeNode.h: * accessibility/mac/AccessibilityObjectMac.mm: (WebCore::AccessibilityObject::rolePlatformString const): (WebCore::AccessibilityObject::rolePlatformDescription const): (WebCore::Accessibility::createPlatformRoleMap): * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (-[WebAccessibilityObjectWrapperBase accessibilityObject]): (-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]): Implementation moved to AccessibilityObject. * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper role]): Special cases moved to rolePlatformString. (-[WebAccessibilityObjectWrapper roleDescription]): (createAccessibilityRoleMap): Deleted, became Accessibility::createPlatformRoleMap. (roleValueToNSString): Deleted, became Accessibility::roleToPlatformString. * platform/LocalizedStrings.cpp: (WebCore::AXARIAContentGroupText): (WebCore::AXHorizontalRuleDescriptionText): (WebCore::AXMarkText): * platform/LocalizedStrings.h: * platform/cocoa/LocalizedStringsCocoa.mm: (WebCore::AXARIAContentGroupText): Deleted, moved to LocalizedStrings.cpp. (WebCore::AXHorizontalRuleDescriptionText): Deleted, moved to LocalizedStrings.cpp. (WebCore::AXMarkText): Deleted, moved to LocalizedStrings.cpp. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm trunk/Source/WebCore/platform/LocalizedStrings.cpp trunk/Source/WebCore/platform/LocalizedStrings.h trunk/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm Diff Modified: trunk/Source/WebCore/ChangeLog (252180 => 252181) --- trunk/Source/WebCore/ChangeLog 2019-11-07 12:09:12 UTC (rev 252180) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 13:21:57 UTC (rev 252181) @@ -1,3 +1,60 @@ +2019-11-07 Andres Gonzalez + +Implement AXIsolatedTreeNode::roleDescription. +https://bugs.webkit.org/show_bug.cgi?id=203863 + + +Reviewed by Chris Fleizach. + +No new tests needed, no new functionality. + +AccessibilityObjectWrapper cannot call any of the AX.*Text functions to +retrieve localized role descriptions, because when running on the +secondary thread, those AtomStrings are not accessible. Moreover, some +of the special cases require access to DOM objects that are not +available in the secondary thread. Therefore, added +AXCoreObject::rolePlatformDescription that runs in the main thread to +initialize the corresponding attribute in AXIsolatedTreeNode. +rolePlatformString, createPlatformRoleMap, roleToPlatformString, +ariaLandmarkRoleDescription, are helper functions. The platform +functions allow to customize the behavior of roleDescription in each +platform. The platform overrides are implemented for mac. Other +platforms are
[webkit-changes] [252180] trunk
Title: [252180] trunk Revision 252180 Author carlo...@webkit.org Date 2019-11-07 04:09:12 -0800 (Thu, 07 Nov 2019) Log Message WebDriver: correctly handle errors when focusing element before sending key events https://bugs.webkit.org/show_bug.cgi?id=203945 Reviewed by Carlos Alberto Lopez Perez. Source/WebDriver: We are throwing an exception that is not correctly handled. Fixes: imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_not_a_focusable_element imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_display_none imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_visibility_hidden imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_hidden imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_disabled * Session.cpp: (WebDriver::Session::elementSendKeys): Raise ElementNotInteractable error when element is not focusable. Source/WebKit: Handle ElementNotInteractable _javascript_ exception to generate the appropriate Automation error. * WebProcess/Automation/WebAutomationSessionProxy.cpp: (WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction): WebDriverTests: Remove expectations for tests that are now passing. * TestExpectations.json: Modified Paths trunk/Source/WebDriver/ChangeLog trunk/Source/WebDriver/Session.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp trunk/WebDriverTests/ChangeLog trunk/WebDriverTests/TestExpectations.json Diff Modified: trunk/Source/WebDriver/ChangeLog (252179 => 252180) --- trunk/Source/WebDriver/ChangeLog 2019-11-07 09:52:27 UTC (rev 252179) +++ trunk/Source/WebDriver/ChangeLog 2019-11-07 12:09:12 UTC (rev 252180) @@ -1,3 +1,21 @@ +2019-11-07 Carlos Garcia Campos + +WebDriver: correctly handle errors when focusing element before sending key events +https://bugs.webkit.org/show_bug.cgi?id=203945 + +Reviewed by Carlos Alberto Lopez Perez. + +We are throwing an exception that is not correctly handled. + +Fixes: imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_not_a_focusable_element + imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_display_none + imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_visibility_hidden + imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_hidden + imported/w3c/webdriver/tests/element_send_keys/interactability.py::test_disabled + +* Session.cpp: +(WebDriver::Session::elementSendKeys): Raise ElementNotInteractable error when element is not focusable. + 2019-08-18 Yusuke Suzuki [WTF] Add makeUnique, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part Modified: trunk/Source/WebDriver/Session.cpp (252179 => 252180) --- trunk/Source/WebDriver/Session.cpp 2019-11-07 09:52:27 UTC (rev 252179) +++ trunk/Source/WebDriver/Session.cpp 2019-11-07 12:09:12 UTC (rev 252180) @@ -1756,11 +1756,13 @@ "prevActiveElement.blur();" "element.focus();" "let tagName = element.tagName.toUpperCase();" +"if (tagName === 'BODY' || element === document.documentElement)" +"return;" "let isTextElement = tagName === 'TEXTAREA' || (tagName === 'INPUT' && element.type === 'text');" "if (isTextElement && element.selectionEnd == 0)" "element.setSelectionRange(element.value.length, element.value.length);" "if (element != doc.activeElement)" -"throw new Error('cannot focus element');" +"throw {name: 'ElementNotInteractable', message: 'Element is not focusable.'};" "}"; RefPtr arguments = JSON::Array::create(); Modified: trunk/Source/WebKit/ChangeLog (252179 => 252180) --- trunk/Source/WebKit/ChangeLog 2019-11-07 09:52:27 UTC (rev 252179) +++ trunk/Source/WebKit/ChangeLog 2019-11-07 12:09:12 UTC (rev 252180) @@ -1,3 +1,15 @@ +2019-11-07 Carlos Garcia Campos + +WebDriver: correctly handle errors when focusing element before sending key events +https://bugs.webkit.org/show_bug.cgi?id=203945 + +Reviewed by Carlos Alberto Lopez Perez. + +Handle ElementNotInteractable _javascript_ exception to generate the appropriate Automation error. + +* WebProcess/Automation/WebAutomationSessionProxy.cpp: +(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction): + 2019-11-06 Eric Liang AX: WKWebView does not shift Accessibility Focus for Catalyst (203798) Modified: trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp (252179 => 252180) --- trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp 2019-11-07
[webkit-changes] [252179] trunk/Source/WebCore
Title: [252179] trunk/Source/WebCore Revision 252179 Author commit-qu...@webkit.org Date 2019-11-07 01:52:27 -0800 (Thu, 07 Nov 2019) Log Message Indentation in ThreadGlobalData.h is incorrect https://bugs.webkit.org/show_bug.cgi?id=203895 Patch by Chris Lord on 2019-11-07 Reviewed by Žan Doberšek. No new tests -- no change in behavior. * platform/ThreadGlobalData.h: (WebCore::ThreadGlobalData::ThreadGlobalData::cachedResourceRequestInitiators): (WebCore::ThreadGlobalData::ThreadGlobalData::eventNames): (WebCore::ThreadGlobalData::ThreadGlobalData::threadTimers): (WebCore::ThreadGlobalData::ThreadGlobalData::qualifiedNameCache): (WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterICU): (WebCore::ThreadGlobalData::ThreadGlobalData::currentState const): (WebCore::ThreadGlobalData::ThreadGlobalData::setCurrentState): (WebCore::ThreadGlobalData::ThreadGlobalData::isInRemoveAllEventListeners const): (WebCore::ThreadGlobalData::ThreadGlobalData::setIsInRemoveAllEventListeners): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ThreadGlobalData.h Diff Modified: trunk/Source/WebCore/ChangeLog (252178 => 252179) --- trunk/Source/WebCore/ChangeLog 2019-11-07 08:06:07 UTC (rev 252178) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 09:52:27 UTC (rev 252179) @@ -1,3 +1,23 @@ +2019-11-07 Chris Lord + +Indentation in ThreadGlobalData.h is incorrect +https://bugs.webkit.org/show_bug.cgi?id=203895 + +Reviewed by Žan Doberšek. + +No new tests -- no change in behavior. + +* platform/ThreadGlobalData.h: +(WebCore::ThreadGlobalData::ThreadGlobalData::cachedResourceRequestInitiators): +(WebCore::ThreadGlobalData::ThreadGlobalData::eventNames): +(WebCore::ThreadGlobalData::ThreadGlobalData::threadTimers): +(WebCore::ThreadGlobalData::ThreadGlobalData::qualifiedNameCache): +(WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterICU): +(WebCore::ThreadGlobalData::ThreadGlobalData::currentState const): +(WebCore::ThreadGlobalData::ThreadGlobalData::setCurrentState): +(WebCore::ThreadGlobalData::ThreadGlobalData::isInRemoveAllEventListeners const): +(WebCore::ThreadGlobalData::ThreadGlobalData::setIsInRemoveAllEventListeners): + 2019-11-05 Sergio Villar Senin VRDisplay should not prevent entering the back/forward cache Modified: trunk/Source/WebCore/platform/ThreadGlobalData.h (252178 => 252179) --- trunk/Source/WebCore/platform/ThreadGlobalData.h 2019-11-07 08:06:07 UTC (rev 252178) +++ trunk/Source/WebCore/platform/ThreadGlobalData.h 2019-11-07 09:52:27 UTC (rev 252179) @@ -37,59 +37,59 @@ namespace WebCore { -class QualifiedNameCache; -class ThreadTimers; +class QualifiedNameCache; +class ThreadTimers; -struct CachedResourceRequestInitiators; -struct EventNames; -struct ICUConverterWrapper; +struct CachedResourceRequestInitiators; +struct EventNames; +struct ICUConverterWrapper; #if USE(WEB_THREAD) -class ThreadGlobalData : public ThreadSafeRefCounted { +class ThreadGlobalData : public ThreadSafeRefCounted { #else -class ThreadGlobalData { +class ThreadGlobalData { #endif -WTF_MAKE_NONCOPYABLE(ThreadGlobalData); -WTF_MAKE_FAST_ALLOCATED; -public: -WEBCORE_EXPORT ThreadGlobalData(); -WEBCORE_EXPORT ~ThreadGlobalData(); -void destroy(); // called on workers to clean up the ThreadGlobalData before the thread exits. +WTF_MAKE_NONCOPYABLE(ThreadGlobalData); +WTF_MAKE_FAST_ALLOCATED; +public: +WEBCORE_EXPORT ThreadGlobalData(); +WEBCORE_EXPORT ~ThreadGlobalData(); +void destroy(); // called on workers to clean up the ThreadGlobalData before the thread exits. -const CachedResourceRequestInitiators& cachedResourceRequestInitiators() { return *m_cachedResourceRequestInitiators; } -EventNames& eventNames() { return *m_eventNames; } -ThreadTimers& threadTimers() { return *m_threadTimers; } -QualifiedNameCache& qualifiedNameCache() { return *m_qualifiedNameCache; } +const CachedResourceRequestInitiators& cachedResourceRequestInitiators() { return *m_cachedResourceRequestInitiators; } +EventNames& eventNames() { return *m_eventNames; } +ThreadTimers& threadTimers() { return *m_threadTimers; } +QualifiedNameCache& qualifiedNameCache() { return *m_qualifiedNameCache; } -ICUConverterWrapper& cachedConverterICU() { return *m_cachedConverterICU; } +ICUConverterWrapper& cachedConverterICU() { return *m_cachedConverterICU; } -JSC::JSGlobalObject* currentState() const { return m_currentState; } -void setCurrentState(JSC::JSGlobalObject* state) { m_currentState = state; } +JSC::JSGlobalObject* currentState() const { return m_currentState; } +void setCurrentState(JSC::JSGlobalObject* state) { m_currentState = state; } #if USE(WEB_THREAD) -void
[webkit-changes] [252178] trunk/Source/WebCore
Title: [252178] trunk/Source/WebCore Revision 252178 Author svil...@igalia.com Date 2019-11-07 00:06:07 -0800 (Thu, 07 Nov 2019) Log Message VRDisplay should not prevent entering the back/forward cache https://bugs.webkit.org/show_bug.cgi?id=203105 Reviewed by Chris Dumez. VRDisplay schedules asynchronous execution of events using the WindowEventLoop instead of synchronously firing them. WindowEventLoop does correctly suspend while in cache. Apart from that suspend()/resume() were implemented by forcing m_scriptedAnimationController to suspend the VR request animation frame machinery while in cache. Last but not least, stopPresenting() is now also called on suspension. No new tests were added as there is no testing machinery for WebVR so far. It's unclear how this unreleased feature will evolve as it's being replaced by WebXR. * Modules/webvr/VRDisplay.cpp: (WebCore::VRDisplay::dispatchVRDisplayEventInWindowEventLoop): (WebCore::VRDisplay::platformDisplayConnected): Use dispatchVRDisplayEventInWindowEventLoop. (WebCore::VRDisplay::platformDisplayDisconnected): Ditto. (WebCore::VRDisplay::platformDisplayMounted): Ditto. (WebCore::VRDisplay::platformDisplayUnmounted): Ditto. (WebCore::VRDisplay::suspend): Added. (WebCore::VRDisplay::resume): Added. (WebCore::VRDisplay::stop): Call stopPresenting(). (WebCore::VRDisplay::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted. * Modules/webvr/VRDisplay.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp trunk/Source/WebCore/Modules/webvr/VRDisplay.h Diff Modified: trunk/Source/WebCore/ChangeLog (252177 => 252178) --- trunk/Source/WebCore/ChangeLog 2019-11-07 07:27:52 UTC (rev 252177) +++ trunk/Source/WebCore/ChangeLog 2019-11-07 08:06:07 UTC (rev 252178) @@ -1,3 +1,33 @@ +2019-11-05 Sergio Villar Senin + +VRDisplay should not prevent entering the back/forward cache +https://bugs.webkit.org/show_bug.cgi?id=203105 + +Reviewed by Chris Dumez. + +VRDisplay schedules asynchronous execution of events using the WindowEventLoop instead of +synchronously firing them. WindowEventLoop does correctly suspend while in cache. + +Apart from that suspend()/resume() were implemented by forcing m_scriptedAnimationController +to suspend the VR request animation frame machinery while in cache. + +Last but not least, stopPresenting() is now also called on suspension. + +No new tests were added as there is no testing machinery for WebVR so far. It's unclear how +this unreleased feature will evolve as it's being replaced by WebXR. + +* Modules/webvr/VRDisplay.cpp: +(WebCore::VRDisplay::dispatchVRDisplayEventInWindowEventLoop): +(WebCore::VRDisplay::platformDisplayConnected): Use dispatchVRDisplayEventInWindowEventLoop. +(WebCore::VRDisplay::platformDisplayDisconnected): Ditto. +(WebCore::VRDisplay::platformDisplayMounted): Ditto. +(WebCore::VRDisplay::platformDisplayUnmounted): Ditto. +(WebCore::VRDisplay::suspend): Added. +(WebCore::VRDisplay::resume): Added. +(WebCore::VRDisplay::stop): Call stopPresenting(). +(WebCore::VRDisplay::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted. +* Modules/webvr/VRDisplay.h: + 2019-11-06 Devin Rousso Remove unimplemented property error log in when getting a property value from a computed style Modified: trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp (252177 => 252178) --- trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp 2019-11-07 07:27:52 UTC (rev 252177) +++ trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp 2019-11-07 08:06:07 UTC (rev 252178) @@ -43,6 +43,7 @@ #include "VRPlatformDisplay.h" #include "VRPose.h" #include "VRStageParameters.h" +#include "WindowEventLoop.h" #include namespace WebCore { @@ -209,24 +210,38 @@ { } +// Use a EventLoop instead of dispatching events synchronously because the +// EventLoop correctly suspends when in the cache. This way VRDisplay does no +// longer prevent caching in the back/forward cache. +void VRDisplay::dispatchVRDisplayEventInEventLoop(const AtomString& eventName, Optional&& reason) +{ +auto event = VRDisplayEvent::create(eventName, makeRefPtr(this), WTFMove(reason)); +queueTaskKeepingObjectAlive(*this, TaskSource::UserInteraction, [this, event = WTFMove(event)]() mutable { +if (!document()) +return; +if (auto* window = document()->domWindow()) +window->dispatchEvent(event); +}); +} + void VRDisplay::platformDisplayConnected() { -document()->domWindow()->dispatchEvent(VRDisplayEvent::create(eventNames().vrdisplayconnectEvent, makeRefPtr(this), WTF::nullopt)); +dispatchVRDisplayEventInEventLoop(eventNames().vrdisplayconnectEvent, WTF::nullopt); } void VRDisplay::platformDisplayDisconnected() { -
