[webkit-changes] [253094] trunk/Source/WebCore
Title: [253094] trunk/Source/WebCore
Revision 253094
Author dba...@webkit.org
Date 2019-12-03 22:30:19 -0800 (Tue, 03 Dec 2019)
Log Message
Remove unused DragController::client()
https://bugs.webkit.org/show_bug.cgi?id=204837
Reviewed by Wenson Hsieh.
It has never been used since its inception in r19039. Moreover it exposes DragController's
internals, which diminishes its encapsulation capabilities.
* page/DragController.h:
(WebCore::DragController::client const): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DragController.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (253093 => 253094)
--- trunk/Source/WebCore/ChangeLog 2019-12-04 05:48:46 UTC (rev 253093)
+++ trunk/Source/WebCore/ChangeLog 2019-12-04 06:30:19 UTC (rev 253094)
@@ -1,3 +1,16 @@
+2019-12-03 Daniel Bates
+
+Remove unused DragController::client()
+https://bugs.webkit.org/show_bug.cgi?id=204837
+
+Reviewed by Wenson Hsieh.
+
+It has never been used since its inception in r19039. Moreover it exposes DragController's
+internals, which diminishes its encapsulation capabilities.
+
+* page/DragController.h:
+(WebCore::DragController::client const): Deleted.
+
2019-12-03 Megan Gardner
Add disabled highlight API skeleton
Modified: trunk/Source/WebCore/page/DragController.h (253093 => 253094)
--- trunk/Source/WebCore/page/DragController.h 2019-12-04 05:48:46 UTC (rev 253093)
+++ trunk/Source/WebCore/page/DragController.h 2019-12-04 06:30:19 UTC (rev 253094)
@@ -59,8 +59,6 @@
static std::unique_ptr create(Page&, DragClient&);
static DragOperation platformGenericDragOperation();
-DragClient& client() const { return m_client; }
-
WEBCORE_EXPORT DragOperation dragEntered(const DragData&);
WEBCORE_EXPORT void dragExited(const DragData&);
WEBCORE_EXPORT DragOperation dragUpdated(const DragData&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253093] trunk
Title: [253093] trunk Revision 253093 Author megan_gard...@apple.com Date 2019-12-03 21:48:46 -0800 (Tue, 03 Dec 2019) Log Message Add disabled highlight API skeleton https://bugs.webkit.org/show_bug.cgi?id=204809 Reviewed by Ryosuke Niwa. Source/WebCore: Beginning implementation of https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/highlight/explainer.md Spec not written yet, starting from the explainer for now. Test: highlight/highlight-interfaces.html * CMakeLists.txt: * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * Modules/highlight/HighlightMap.cpp: Added. (WebCore::HighlightMap::addHighlightGroup): (WebCore::HighlightMap::addFromMapLike): (WebCore::HighlightMap::remove): (WebCore::HighlightMap::namedItem const): (WebCore::HighlightMap::setNamedItem): (WebCore::HighlightMap::deleteNamedProperty): (WebCore::HighlightMap::set): * Modules/highlight/HighlightMap.h: Added. (WebCore::HighlightMap::create): (WebCore::HighlightMap::synchronizeBackingMap): (WebCore::HighlightMap::backingMap): (WebCore::HighlightMap::clear): * Modules/highlight/HighlightMap.idl: Added. * Modules/highlight/HighlightRangeGroup.cpp: Added. (WebCore::HighlightRangeGroup::HighlightRangeGroup): (WebCore::HighlightRangeGroup::create): (WebCore::HighlightRangeGroup::addRange): (WebCore::HighlightRangeGroup::removeRange): (WebCore::HighlightRangeGroup::Iterator::Iterator): (WebCore::HighlightRangeGroup::Iterator::next): * Modules/highlight/HighlightRangeGroup.h: Added. (WebCore::HighlightRangeGroup::createIterator): * Modules/highlight/HighlightRangeGroup.idl: Added. * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * bindings/js/WebCoreBuiltinNames.h: * css/DOMCSSNamespace.cpp: (WebCore::DOMCSSNamespace::highlights): * css/DOMCSSNamespace.h: * css/DOMCSSNamespace.idl: * dom/Document.cpp: (WebCore::Document::highlightMap): * dom/Document.h: * dom/Range.idl: * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setHighlightAPIEnabled): (WebCore::RuntimeEnabledFeatures::highlightAPIEnabled const): Source/WebKit: * Shared/WebPreferences.yaml: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetHighlightAPIEnabled): (WKPreferencesGetHighlightAPIEnabled): * UIProcess/API/C/WKPreferencesRefPrivate.h: Source/WebKitLegacy/mac: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences highlightAPIEnabled]): (-[WebPreferences setHighlightAPIEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Tools: * DumpRenderTree/mac/DumpRenderTree.mm: (enableExperimentalFeatures): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): LayoutTests: * highlight/highlight-interfaces-expected.txt: Added. * highlight/highlight-interfaces.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources-input.xcfilelist trunk/Source/WebCore/DerivedSources-output.xcfilelist trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Sources.txt trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h trunk/Source/WebCore/css/DOMCSSNamespace.cpp trunk/Source/WebCore/css/DOMCSSNamespace.h trunk/Source/WebCore/css/DOMCSSNamespace.idl trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/page/RuntimeEnabledFeatures.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferences.yaml trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebView.mm trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/WebKitTestRunner/TestController.cpp Added Paths trunk/LayoutTests/highlight/ trunk/LayoutTests/highlight/highlight-interfaces-expected.txt trunk/LayoutTests/highlight/highlight-interfaces.html trunk/Source/WebCore/Modules/highlight/ trunk/Source/WebCore/Modules/highlight/HighlightMap.cpp trunk/Source/WebCore/Modules/highlight/HighlightMap.h trunk/Source/WebCore/Modules/highlight/HighlightMap.idl trunk/Source/WebCore/Modules/highlight/HighlightRangeGroup.cpp trunk/Source/WebCore/Modules/highlight/HighlightRangeGroup.h trunk/Source/WebCore/Modules/highlight/HighlightRangeGroup.idl Diff Modified: trunk/LayoutTests/ChangeLog (253092 => 253093) --- trunk/LayoutTests/ChangeLog 2019-12-04 05:30:59 UTC (rev 253092) +++ trunk/LayoutTests/ChangeLog 2019-12-04 05:48:46 UTC (rev 253093) @@ -1,3 +1,13 @@ +2019-12-03 Megan Gardner + +
[webkit-changes] [253092] trunk/LayoutTests/imported/w3c
Title: [253092] trunk/LayoutTests/imported/w3c Revision 253092 Author simon.fra...@apple.com Date 2019-12-03 21:30:59 -0800 (Tue, 03 Dec 2019) Log Message Update css/css-values WPT https://bugs.webkit.org/show_bug.cgi?id=204835 Reviewed by Zalan Bujtas. Update css/css-values to WPT 3f1485cc2793f55236076dfffc3c3fa69315e101. * web-platform-tests/css/css-values/animations/calc-interpolation-expected.txt: Added. * web-platform-tests/css/css-values/animations/calc-interpolation.html: Added. * web-platform-tests/css/css-values/animations/w3c-import.log: Added. * web-platform-tests/css/css-values/minmax-length-percent-serialize.html: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/minmax-length-percent-serialize-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/minmax-length-percent-serialize.html Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/animations/ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/animations/calc-interpolation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/animations/calc-interpolation.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/animations/w3c-import.log Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (253091 => 253092) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-12-04 05:22:03 UTC (rev 253091) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-12-04 05:30:59 UTC (rev 253092) @@ -1,3 +1,17 @@ +2019-12-03 Simon Fraser + +Update css/css-values WPT +https://bugs.webkit.org/show_bug.cgi?id=204835 + +Reviewed by Zalan Bujtas. + +Update css/css-values to WPT 3f1485cc2793f55236076dfffc3c3fa69315e101. + +* web-platform-tests/css/css-values/animations/calc-interpolation-expected.txt: Added. +* web-platform-tests/css/css-values/animations/calc-interpolation.html: Added. +* web-platform-tests/css/css-values/animations/w3c-import.log: Added. +* web-platform-tests/css/css-values/minmax-length-percent-serialize.html: + 2019-12-03 Yusuke Suzuki Adopt the new WebAssembly.Global system Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/animations/calc-interpolation-expected.txt (0 => 253092) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/animations/calc-interpolation-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/animations/calc-interpolation-expected.txt 2019-12-04 05:30:59 UTC (rev 253092) @@ -0,0 +1,114 @@ + +FAIL CSS Transitions: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (-0.25) should be [-10px] assert_equals: expected "- 10px " but got "0px " +PASS CSS Transitions: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0) should be [0px] +PASS CSS Transitions: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0.25) should be [10px] +PASS CSS Transitions: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0.5) should be [20px] +PASS CSS Transitions: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0.75) should be [30px] +PASS CSS Transitions: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (1) should be [40px] +FAIL CSS Transitions: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (1.25) should be [50px] assert_equals: expected "50px " but got "40px " +FAIL CSS Transitions with transition: all: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (-0.25) should be [-10px] assert_equals: expected "- 10px " but got "0px " +PASS CSS Transitions with transition: all: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0) should be [0px] +PASS CSS Transitions with transition: all: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0.25) should be [10px] +PASS CSS Transitions with transition: all: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0.5) should be [20px] +PASS CSS Transitions with transition: all: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0.75) should be [30px] +PASS CSS Transitions with transition: all: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (1) should be [40px] +FAIL CSS Transitions with transition: all: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (1.25) should be [50px] assert_equals: expected "50px " but got "40px " +FAIL CSS Animations: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (-0.25) should be [-10px] assert_equals: expected "- 10px " but got "0px " +PASS CSS Animations: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0) should be [0px] +PASS CSS Animations: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0.25) should be [10px] +PASS CSS Animations: property from [calc(50% - 25px)] to [calc(100% - 10px)] at (0.5) should be [20px]
[webkit-changes] [253091] trunk
Title: [253091] trunk
Revision 253091
Author rn...@webkit.org
Date 2019-12-03 21:22:03 -0800 (Tue, 03 Dec 2019)
Log Message
Perform microtask checkpoint after each task as spec'ed
https://bugs.webkit.org/show_bug.cgi?id=204546
Reviewed by Chris Dumez.
Source/WebCore:
This patch makes EventLoop perform a microtask checkpoint after each task as spec'ed:
https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-model
and removes the timer in MicrotaskQueue.
Because we always perform a microtask checkpoint after executing _javascript_ in
JSExecState::didLeaveScriptContext, there isn't a good way of testing this code change
from the existing API and the infrastructure. This patch, therefore, also introduces
internals.queueMicrotaskInTask, which schedules a new task within which a new microtask
to invoke the callback is scheduled.
This patch also stops including Microtasks.h from most places as only event loop
implementations need to access MicrotaskQueue object now after r252820.
Test: http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task.html
* animation/DocumentTimeline.cpp:
* animation/WebAnimation.cpp:
* bindings/js/JSExecState.cpp:
* dom/CustomElementReactionQueue.cpp:
* dom/Document.cpp:
* dom/EventLoop.cpp:
(WebCore::EventLoop::queueMicrotask):
(WebCore::EventLoop::run):
* dom/Microtasks.cpp:
(WebCore::MicrotaskQueue::MicrotaskQueue):
(WebCore::MicrotaskQueue::append):
(WebCore::MicrotaskQueue::timerFired): Deleted.
* dom/Microtasks.h:
* dom/MutationObserver.cpp:
* testing/Internals.cpp:
(WebCore::taskSourceFromString): Extracted from Internals::queueTask.
(WebCore::Internals::queueTask):
(WebCore::Internals::queueMicrotaskInTask): Added.
* testing/Internals.h:
* testing/Internals.idl:
* workers/WorkerGlobalScope.cpp:
* workers/service/SWClientConnection.cpp:
LayoutTests:
Added a regresion test using newly added internals methods.
* http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task-expected.txt: Added.
* http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/DocumentTimeline.cpp
trunk/Source/WebCore/animation/WebAnimation.cpp
trunk/Source/WebCore/bindings/js/JSExecState.cpp
trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/EventLoop.cpp
trunk/Source/WebCore/dom/Microtasks.cpp
trunk/Source/WebCore/dom/Microtasks.h
trunk/Source/WebCore/dom/MutationObserver.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/workers/WorkerGlobalScope.cpp
trunk/Source/WebCore/workers/service/SWClientConnection.cpp
Added Paths
trunk/LayoutTests/http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task-expected.txt
trunk/LayoutTests/http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task.html
Diff
Modified: trunk/LayoutTests/ChangeLog (253090 => 253091)
--- trunk/LayoutTests/ChangeLog 2019-12-04 04:28:10 UTC (rev 253090)
+++ trunk/LayoutTests/ChangeLog 2019-12-04 05:22:03 UTC (rev 253091)
@@ -1,3 +1,16 @@
+2019-11-23 Ryosuke Niwa
+
+Perform microtask checkpoint after each task as spec'ed
+https://bugs.webkit.org/show_bug.cgi?id=204546
+
+
+Reviewed by Chris Dumez.
+
+Added a regresion test using newly added internals methods.
+
+* http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task-expected.txt: Added.
+* http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task.html: Added.
+
2019-12-03 Simon Fraser
Unreviewed test gardening.
Added: trunk/LayoutTests/http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task-expected.txt (0 => 253091)
--- trunk/LayoutTests/http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task-expected.txt 2019-12-04 05:22:03 UTC (rev 253091)
@@ -0,0 +1,10 @@
+A microtask checkpoint should be performed after executing each task.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS logs.join(", ") is "1.task, 2.microtask, 3.microtask, 4.task"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task.html (0 => 253091)
--- trunk/LayoutTests/http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task.html (rev 0)
+++ trunk/LayoutTests/http/tests/eventloop/perform-microtask-checkpoint-at-end-of-task.html 2019-12-04 05:22:03 UTC (rev 253091)
@@ -0,0 +1,38 @@
+
+
+
+
+
+description('A microtask checkpoint should be performed after executing each task.');
+
+const logs = [];
+
+if (!window.internals)
+testFailed('This test requires
[webkit-changes] [253090] trunk
Title: [253090] trunk Revision 253090 Author rn...@webkit.org Date 2019-12-03 20:28:10 -0800 (Tue, 03 Dec 2019) Log Message Replace customJavaScriptUserAgentAsSiteSpecificQuirks with customUserAgentAsSiteSpecificQuirks https://bugs.webkit.org/show_bug.cgi?id=204824 Reviewed by Brent Fulgham. Source/WebCore: This patch renames customJavaScriptUserAgentAsSiteSpecificQuirks to customUserAgentAsSiteSpecificQuirks, and make it apply to network requests as well as _javascript_ API. Tests: WebKit.WebsitePoliciesCustomUserAgentAsSiteSpecificQuirksDisabled WebKit.WebsitePoliciesCustomUserAgentAsSiteSpecificQuirks * loader/DocumentLoader.h: (WebCore::DocumentLoader::setCustomUserAgentAsSiteSpecificQuirks): Renamed from setCustomJavaScriptUserAgentAsSiteSpecificQuirks. (WebCore::DocumentLoader::customUserAgentAsSiteSpecificQuirks const): Renamed from customJavaScriptUserAgentAsSiteSpecificQuirks. * loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent const): (WebCore::FrameLoader::userAgentForJavaScript const): Deleted. * loader/FrameLoader.h: * page/Navigator.cpp: (WebCore::Navigator::userAgent const): * page/Quirks.cpp: (WebCore::Quirks::shouldOpenAsAboutBlank const): Source/WebKit: This patch replaces _WKWebsitePolicies's customJavaScriptUserAgentAsSiteSpecificQuirks with customUserAgentAsSiteSpecificQuirks and makes it apply to network requests as well as JS API. * Shared/WebsitePoliciesData.cpp: (WebKit::WebsitePoliciesData::encode const): (WebKit::WebsitePoliciesData::decode): (WebKit::WebsitePoliciesData::applyToDocumentLoader): * Shared/WebsitePoliciesData.h: * UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::copy const): (API::WebsitePolicies::data): * UIProcess/API/APIWebsitePolicies.h: * UIProcess/API/Cocoa/WKWebpagePreferences.mm: (-[WKWebpagePreferences _setCustomUserAgentAsSiteSpecificQuirks:]): Renamed from _setCustomJavaScriptUserAgentAsSiteSpecificQuirks. (-[WKWebpagePreferences _customUserAgentAsSiteSpecificQuirks]): Renamed from _customJavaScriptUserAgentAsSiteSpecificQuirks. * UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h: * UIProcess/API/Cocoa/_WKWebsitePolicies.h: * UIProcess/API/Cocoa/_WKWebsitePolicies.mm: (-[_WKWebsitePolicies setCustomUserAgentAsSiteSpecificQuirks:]): Renamed from setCustomJavaScriptUserAgentAsSiteSpecificQuirks. (-[_WKWebsitePolicies customUserAgentAsSiteSpecificQuirks]): Renamed from customJavaScriptUserAgentAsSiteSpecificQuirks. Tools: Replaced WebKit.WebsitePoliciesCustomJavaScriptUserAgent and WebKit.WebsitePoliciesCustomUserAgents with WebKit.WebsitePoliciesCustomUserAgentAsSiteSpecificQuirksDisabled, which tests that the UA string specified by customUserAgentAsSiteSpecificQuirks is not used when site specific quirks is disabled, and WebKit.WebsitePoliciesCustomUserAgentAsSiteSpecificQuirks, which tests that new property sets UA string for both network requests and JS API. * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm: (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentLoader.h trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/loader/FrameLoader.h trunk/Source/WebCore/page/Navigator.cpp trunk/Source/WebCore/page/Quirks.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebsitePoliciesData.cpp trunk/Source/WebKit/Shared/WebsitePoliciesData.h trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm Diff Modified: trunk/Source/WebCore/ChangeLog (253089 => 253090) --- trunk/Source/WebCore/ChangeLog 2019-12-04 04:11:21 UTC (rev 253089) +++ trunk/Source/WebCore/ChangeLog 2019-12-04 04:28:10 UTC (rev 253090) @@ -1,3 +1,28 @@ +2019-12-03 Ryosuke Niwa + +Replace customJavaScriptUserAgentAsSiteSpecificQuirks with customUserAgentAsSiteSpecificQuirks +https://bugs.webkit.org/show_bug.cgi?id=204824 + +Reviewed by Brent Fulgham. + +This patch renames customJavaScriptUserAgentAsSiteSpecificQuirks to customUserAgentAsSiteSpecificQuirks, +and make it apply to network requests as well as _javascript_ API. + +Tests: WebKit.WebsitePoliciesCustomUserAgentAsSiteSpecificQuirksDisabled + WebKit.WebsitePoliciesCustomUserAgentAsSiteSpecificQuirks + +* loader/DocumentLoader.h: +(WebCore::DocumentLoader::setCustomUserAgentAsSiteSpecificQuirks): Renamed from setCustomJavaScriptUserAgentAsSiteSpecificQuirks. +(WebCore::DocumentLoader::customUserAgentAsSiteSpecificQuirks const): Renamed from
[webkit-changes] [253089] trunk/LayoutTests
Title: [253089] trunk/LayoutTests
Revision 253089
Author simon.fra...@apple.com
Date 2019-12-03 20:11:21 -0800 (Tue, 03 Dec 2019)
Log Message
Unreviewed test gardening.
Update legacy-animation-engine/fast/css/calc-with-angle-time-frequency.html to match fast/css/calc-with-angle-time-frequency.html
for new calc() behavior.
* legacy-animation-engine/fast/css/calc-with-angle-time-frequency-expected.txt:
* legacy-animation-engine/fast/css/calc-with-angle-time-frequency.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/legacy-animation-engine/fast/css/calc-with-angle-time-frequency-expected.txt
trunk/LayoutTests/legacy-animation-engine/fast/css/calc-with-angle-time-frequency.html
Diff
Modified: trunk/LayoutTests/ChangeLog (253088 => 253089)
--- trunk/LayoutTests/ChangeLog 2019-12-04 03:44:53 UTC (rev 253088)
+++ trunk/LayoutTests/ChangeLog 2019-12-04 04:11:21 UTC (rev 253089)
@@ -1,3 +1,13 @@
+2019-12-03 Simon Fraser
+
+Unreviewed test gardening.
+
+Update legacy-animation-engine/fast/css/calc-with-angle-time-frequency.html to match fast/css/calc-with-angle-time-frequency.html
+for new calc() behavior.
+
+* legacy-animation-engine/fast/css/calc-with-angle-time-frequency-expected.txt:
+* legacy-animation-engine/fast/css/calc-with-angle-time-frequency.html:
+
2019-12-03 John Wilander
Resource Load Statistics (experimental): Delete non-cookie website data after 7 days of no user interaction
Modified: trunk/LayoutTests/legacy-animation-engine/fast/css/calc-with-angle-time-frequency-expected.txt (253088 => 253089)
--- trunk/LayoutTests/legacy-animation-engine/fast/css/calc-with-angle-time-frequency-expected.txt 2019-12-04 03:44:53 UTC (rev 253088)
+++ trunk/LayoutTests/legacy-animation-engine/fast/css/calc-with-angle-time-frequency-expected.txt 2019-12-04 04:11:21 UTC (rev 253089)
@@ -7,13 +7,13 @@
PASS testDiv.style['-webkit-filter'] is "hue-rotate(calc(150deg))"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-filter') is "hue-rotate(150deg)"
testDiv.style['-webkit-filter'] = 'hue-rotate(calc(300rad/2))'
-FAIL testDiv.style['-webkit-filter'] should be hue-rotate(calc(150rad)). Was hue-rotate(calc(8594.366926962348deg)).
+PASS testDiv.style['-webkit-filter'] is "hue-rotate(calc(8594.366926962348deg))"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-filter') is "hue-rotate(8594.366926962348deg)"
testDiv.style['-webkit-filter'] = 'hue-rotate(calc(300grad/2))'
-FAIL testDiv.style['-webkit-filter'] should be hue-rotate(calc(150grad)). Was hue-rotate(calc(135deg)).
+PASS testDiv.style['-webkit-filter'] is "hue-rotate(calc(135deg))"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-filter') is "hue-rotate(135deg)"
testDiv.style['-webkit-filter'] = 'hue-rotate(calc(3turn/2))'
-FAIL testDiv.style['-webkit-filter'] should be hue-rotate(calc(1.5turn)). Was hue-rotate(calc(540deg)).
+PASS testDiv.style['-webkit-filter'] is "hue-rotate(calc(540deg))"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-filter') is "hue-rotate(540deg)"
testDiv.style['-webkit-filter'] = 'hue-rotate(calc(1turn + 10deg))'
PASS testDiv.style['-webkit-filter'] is "hue-rotate(calc(370deg))"
@@ -22,13 +22,13 @@
PASS testDiv.style['-webkit-filter'] is "hue-rotate(calc(330deg))"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-filter') is "hue-rotate(330deg)"
testDiv.style['-webkit-filter'] = 'hue-rotate(calc(2turn + 1turn))'
-FAIL testDiv.style['-webkit-filter'] should be hue-rotate(calc(3turn)). Was hue-rotate(calc(1080deg)).
+PASS testDiv.style['-webkit-filter'] is "hue-rotate(calc(1080deg))"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-filter') is "hue-rotate(1080deg)"
testDiv.style['transition-delay'] = 'calc(300ms/2)'
PASS testDiv.style['transition-delay'] is "calc(150ms)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "0.15s"
testDiv.style['transition-delay'] = 'calc(300s/2)'
-FAIL testDiv.style['transition-delay'] should be calc(150s). Was calc(15ms).
+PASS testDiv.style['transition-delay'] is "calc(15ms)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "150s"
testDiv.style['transition-delay'] = 'calc(10s + 100ms)'
PASS testDiv.style['transition-delay'] is "calc(10100ms)"
@@ -37,7 +37,7 @@
PASS testDiv.style['transition-delay'] is "calc(10100ms)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "10.1s"
testDiv.style['transition-delay'] = 'calc(4s + 1s)'
-FAIL testDiv.style['transition-delay'] should be calc(5s). Was calc(5000ms).
+PASS testDiv.style['transition-delay'] is "calc(5000ms)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "5s"
testDiv.style['transition-delay'] = 'calc(4ms + 1ms)'
PASS testDiv.style['transition-delay'] is "calc(5ms)"
Modified:
[webkit-changes] [253088] trunk
Title: [253088] trunk
Revision 253088
Author andresg...@apple.com
Date 2019-12-03 19:44:53 -0800 (Tue, 03 Dec 2019)
Log Message
Focus tracking support in the accessibility isolatedtree.
https://bugs.webkit.org/show_bug.cgi?id=204535
Reviewed by Chris Fleizach.
Source/WebCore:
The AXIsolatedTree focused object is now set during the tree generation.
It is updated on handleFocusedUIElementChanged.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::focusedObject):
(WebCore::AXObjectCache::isolatedTreeFocusedObject):
(WebCore::AXObjectCache::setIsolatedTreeFocusedObject):
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::isolatedTreeRootObject):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::createIsolatedTreeHierarchy):
(WebCore::AXObjectCache::generateIsolatedTree):
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::focusedUIElement const):
Source/WebKit:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKAccessibilityFocusedObject):
Tools:
FocusElement can run on the secondary AXThread.
* WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::focusedElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (253087 => 253088)
--- trunk/Source/WebCore/ChangeLog 2019-12-04 03:31:32 UTC (rev 253087)
+++ trunk/Source/WebCore/ChangeLog 2019-12-04 03:44:53 UTC (rev 253088)
@@ -1,3 +1,27 @@
+2019-12-03 Andres Gonzalez
+
+Focus tracking support in the accessibility isolatedtree.
+https://bugs.webkit.org/show_bug.cgi?id=204535
+
+Reviewed by Chris Fleizach.
+
+The AXIsolatedTree focused object is now set during the tree generation.
+It is updated on handleFocusedUIElementChanged.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::focusedImageMapUIElement):
+(WebCore::AXObjectCache::focusedObject):
+(WebCore::AXObjectCache::isolatedTreeFocusedObject):
+(WebCore::AXObjectCache::setIsolatedTreeFocusedObject):
+(WebCore::AXObjectCache::focusedUIElementForPage):
+(WebCore::AXObjectCache::isolatedTreeRootObject):
+(WebCore::AXObjectCache::handleFocusedUIElementChanged):
+(WebCore::AXObjectCache::createIsolatedTreeHierarchy):
+(WebCore::AXObjectCache::generateIsolatedTree):
+* accessibility/AXObjectCache.h:
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::focusedUIElement const):
+
2019-12-03 Ryosuke Niwa
Use the event loop instead of DocumentEventQueue and WorkerEventQueue
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (253087 => 253088)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2019-12-04 03:31:32 UTC (rev 253087)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2019-12-04 03:44:53 UTC (rev 253088)
@@ -348,34 +348,88 @@
return nullptr;
}
-
-AXCoreObject* AXObjectCache::focusedUIElementForPage(const Page* page)
+
+AXCoreObject* AXObjectCache::focusedObject(Document& document)
{
-if (!gAccessibilityEnabled)
-return nullptr;
-
-// get the focused node in the page
-Document* focusedDocument = page->focusController().focusedOrMainFrame().document();
-Element* focusedElement = focusedDocument->focusedElement();
+Element* focusedElement = document.focusedElement();
if (is(focusedElement))
return focusedImageMapUIElement(downcast(focusedElement));
-AXCoreObject* obj = focusedDocument->axObjectCache()->getOrCreate(focusedElement ? static_cast(focusedElement) : focusedDocument);
-if (!obj)
+auto* axObjectCache = document.axObjectCache();
+if (!axObjectCache)
return nullptr;
-if (obj->shouldFocusActiveDescendant()) {
-if (AXCoreObject* descendant = obj->activeDescendant())
-obj = descendant;
+AXCoreObject* focus = axObjectCache->getOrCreate(focusedElement ? focusedElement : static_cast());
+if (!focus)
+return nullptr;
+
+if (focus->shouldFocusActiveDescendant()) {
+if (auto* descendant = focus->activeDescendant())
+focus = descendant;
}
// the HTML element, for example, is focusable but has an AX object that is ignored
-if (obj->accessibilityIsIgnored())
-obj = obj->parentObjectUnignored();
+if
[webkit-changes] [253087] trunk/Source/WebInspectorUI
Title: [253087] trunk/Source/WebInspectorUI
Revision 253087
Author drou...@apple.com
Date 2019-12-03 19:31:32 -0800 (Tue, 03 Dec 2019)
Log Message
Web Inspector: prefer non-blackboxed scripts when showing a source code location link
https://bugs.webkit.org/show_bug.cgi?id=204811
Reviewed by Timothy Hatcher.
* UserInterface/Models/StackTrace.js:
(WI.StackTrace.prototype.get firstNonNativeNonAnonymousNotBlackboxedCallFrame): Added.
(WI.StackTrace.prototype.get firstNonNativeCallFrame): Deleted.
(WI.StackTrace.prototype.get firstNonNativeNonAnonymousCallFrame): Deleted.
Include logic to skip call frames that are blackboxed, unless there are no non-blackboxed
call frames, in which case fall back to the first non-native non-anonymous call frame.
Drive-by: remove unused function.
* UserInterface/Views/ConsoleMessageView.js:
(WI.ConsoleMessageView.prototype.render):
(WI.ConsoleMessageView.prototype.clearSessionState): Added.
(WI.ConsoleMessageView.prototype._appendLocationLink):
(WI.ConsoleMessageView.prototype._handleDebuggerBlackboxChanged): Added.
(WI.ConsoleMessageView.prototype.clearSavedVariableState): Deleted.
* UserInterface/Views/LogContentView.js:
(WI.LogContentView.prototype._sessionStarted):
(WI.LogContentView.prototype._logCleared):
Listen for changes to the debugger blackbox to re-render the location link.
* UserInterface/Views/StackTraceView.js:
(WI.StackTraceView):
* UserInterface/Views/CallFrameView.js:
(WI.CallFrameView):
* UserInterface/Views/CallFrameView.css:
(.call-frame.blackboxed > .title, .call-frame.blackboxed:not(:hover, :focus) > .subtitle): Added.
Add a constructor option to control whether blackboxed frames are indicated visually.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js
trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameView.css
trunk/Source/WebInspectorUI/UserInterface/Views/CallFrameView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js
trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/StackTraceView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (253086 => 253087)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-12-04 03:30:05 UTC (rev 253086)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-12-04 03:31:32 UTC (rev 253087)
@@ -1,5 +1,39 @@
2019-12-03 Devin Rousso
+Web Inspector: prefer non-blackboxed scripts when showing a source code location link
+https://bugs.webkit.org/show_bug.cgi?id=204811
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Models/StackTrace.js:
+(WI.StackTrace.prototype.get firstNonNativeNonAnonymousNotBlackboxedCallFrame): Added.
+(WI.StackTrace.prototype.get firstNonNativeCallFrame): Deleted.
+(WI.StackTrace.prototype.get firstNonNativeNonAnonymousCallFrame): Deleted.
+Include logic to skip call frames that are blackboxed, unless there are no non-blackboxed
+call frames, in which case fall back to the first non-native non-anonymous call frame.
+Drive-by: remove unused function.
+
+* UserInterface/Views/ConsoleMessageView.js:
+(WI.ConsoleMessageView.prototype.render):
+(WI.ConsoleMessageView.prototype.clearSessionState): Added.
+(WI.ConsoleMessageView.prototype._appendLocationLink):
+(WI.ConsoleMessageView.prototype._handleDebuggerBlackboxChanged): Added.
+(WI.ConsoleMessageView.prototype.clearSavedVariableState): Deleted.
+* UserInterface/Views/LogContentView.js:
+(WI.LogContentView.prototype._sessionStarted):
+(WI.LogContentView.prototype._logCleared):
+Listen for changes to the debugger blackbox to re-render the location link.
+
+* UserInterface/Views/StackTraceView.js:
+(WI.StackTraceView):
+* UserInterface/Views/CallFrameView.js:
+(WI.CallFrameView):
+* UserInterface/Views/CallFrameView.css:
+(.call-frame.blackboxed > .title, .call-frame.blackboxed:not(:hover, :focus) > .subtitle): Added.
+Add a constructor option to control whether blackboxed frames are indicated visually.
+
+2019-12-03 Devin Rousso
+
Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'navigationItem.parentNavigationBar')
https://bugs.webkit.org/show_bug.cgi?id=204830
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js (253086 => 253087)
--- trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js 2019-12-04 03:30:05 UTC (rev 253086)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js 2019-12-04 03:31:32 UTC (rev 253087)
@@ -140,38 +140,35 @@
// Public
-get callFrames()
-{
-return this._callFrames;
-}
+get callFrames() { return this._callFrames; }
+get topCallFrameIsBoundary() { return this._topCallFrameIsBoundary; }
+get truncated() { return
[webkit-changes] [253086] trunk/Source/WebCore
Title: [253086] trunk/Source/WebCore Revision 253086 Author rn...@webkit.org Date 2019-12-03 19:30:05 -0800 (Tue, 03 Dec 2019) Log Message Use the event loop instead of DocumentEventQueue and WorkerEventQueue https://bugs.webkit.org/show_bug.cgi?id=204447 * page/PointerCaptureController.cpp: (WebCore::PointerCaptureController::elementWasRemoved): Fixed a typo. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/PointerCaptureController.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (253085 => 253086) --- trunk/Source/WebCore/ChangeLog 2019-12-04 03:26:33 UTC (rev 253085) +++ trunk/Source/WebCore/ChangeLog 2019-12-04 03:30:05 UTC (rev 253086) @@ -1,3 +1,11 @@ +2019-12-03 Ryosuke Niwa + +Use the event loop instead of DocumentEventQueue and WorkerEventQueue +https://bugs.webkit.org/show_bug.cgi?id=204447 + +* page/PointerCaptureController.cpp: +(WebCore::PointerCaptureController::elementWasRemoved): Fixed a typo. + 2019-12-03 John Wilander Resource Load Statistics (experimental): Delete non-cookie website data after 7 days of no user interaction Modified: trunk/Source/WebCore/page/PointerCaptureController.cpp (253085 => 253086) --- trunk/Source/WebCore/page/PointerCaptureController.cpp 2019-12-04 03:26:33 UTC (rev 253085) +++ trunk/Source/WebCore/page/PointerCaptureController.cpp 2019-12-04 03:30:05 UTC (rev 253086) @@ -150,7 +150,7 @@ auto pointerId = static_cast(keyAndValue.key); auto pointerType = capturingData.pointerType; releasePointerCapture(, pointerId); -// FIXME: Spec doesn't specify which task soruce to use. +// FIXME: Spec doesn't specify which task source to use. element.document().queueTaskToDispatchEvent(TaskSource::UserInteraction, PointerEvent::create(eventNames().lostpointercaptureEvent, pointerId, pointerType)); return; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253085] trunk/Source/WebInspectorUI
Title: [253085] trunk/Source/WebInspectorUI
Revision 253085
Author drou...@apple.com
Date 2019-12-03 19:26:33 -0800 (Tue, 03 Dec 2019)
Log Message
Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'navigationItem.parentNavigationBar')
https://bugs.webkit.org/show_bug.cgi?id=204830
Reviewed by Timothy Hatcher.
* UserInterface/Controllers/CSSManager.js:
(WI.CSSManager.prototype._mainResourceDidChange):
When the main resource changes, make sure to clear the `_forcedAppearance` member variable.
This way, when the main `WI.DOMTreeContentView` reloads, it isn't left in an unknown state.
* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView):
(WI.DOMTreeContentView.prototype._defaultAppearanceDidChange):
(WI.DOMTreeContentView.prototype._toggleAppearance):
Always create the Force Appearance navigation item, rather than destroying and recreating it
each time the page navigates. Instead, just update the tooltip (which was all that really
changed) whenever the default appearance changes. Depending on the timing of events during a
page navigation, `_forceAppearanceButtonNavigationItem` could be `null`.
* UserInterface/Views/ActivateButtonNavigationItem.js:
(WI.ActivateButtonNavigationItem.prototype.set defaultToolTip): Added.
(WI.ActivateButtonNavigationItem.prototype.set activatedToolTip): Added.
Allow the various tooltips to be updated after creation.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js
trunk/Source/WebInspectorUI/UserInterface/Views/ActivateButtonNavigationItem.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (253084 => 253085)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-12-04 03:06:02 UTC (rev 253084)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-12-04 03:26:33 UTC (rev 253085)
@@ -1,5 +1,31 @@
2019-12-03 Devin Rousso
+Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'navigationItem.parentNavigationBar')
+https://bugs.webkit.org/show_bug.cgi?id=204830
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Controllers/CSSManager.js:
+(WI.CSSManager.prototype._mainResourceDidChange):
+When the main resource changes, make sure to clear the `_forcedAppearance` member variable.
+This way, when the main `WI.DOMTreeContentView` reloads, it isn't left in an unknown state.
+
+* UserInterface/Views/DOMTreeContentView.js:
+(WI.DOMTreeContentView):
+(WI.DOMTreeContentView.prototype._defaultAppearanceDidChange):
+(WI.DOMTreeContentView.prototype._toggleAppearance):
+Always create the Force Appearance navigation item, rather than destroying and recreating it
+each time the page navigates. Instead, just update the tooltip (which was all that really
+changed) whenever the default appearance changes. Depending on the timing of events during a
+page navigation, `_forceAppearanceButtonNavigationItem` could be `null`.
+
+* UserInterface/Views/ActivateButtonNavigationItem.js:
+(WI.ActivateButtonNavigationItem.prototype.set defaultToolTip): Added.
+(WI.ActivateButtonNavigationItem.prototype.set activatedToolTip): Added.
+Allow the various tooltips to be updated after creation.
+
+2019-12-03 Devin Rousso
+
Web Inspector: Timelines: stopping time marker is permanently removed when the current recording is cleared
https://bugs.webkit.org/show_bug.cgi?id=204827
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js (253084 => 253085)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js 2019-12-04 03:06:02 UTC (rev 253084)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js 2019-12-04 03:26:33 UTC (rev 253085)
@@ -533,6 +533,7 @@
this._styleSheetIdentifierMap.clear();
this._styleSheetFrameURLMap.clear();
this._modifiedStyles.clear();
+this._forcedAppearance = null;
this._nodeStylesMap = {};
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ActivateButtonNavigationItem.js (253084 => 253085)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ActivateButtonNavigationItem.js 2019-12-04 03:06:02 UTC (rev 253084)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ActivateButtonNavigationItem.js 2019-12-04 03:26:33 UTC (rev 253085)
@@ -41,11 +41,27 @@
return this._defaultToolTip;
}
+set defaultToolTip(defaultToolTip)
+{
+this._defaultToolTip = defaultToolTip;
+
+if (!this.activated)
+this.tooltip = this._defaultToolTip;
+}
+
get activatedToolTip()
{
return this._activatedToolTip;
}
+set activatedToolTip(activatedToolTip)
+{
+this._activatedToolTip = activatedToolTip;
+
+if (this.activated)
+
[webkit-changes] [253084] trunk/Source/WebInspectorUI
Title: [253084] trunk/Source/WebInspectorUI
Revision 253084
Author drou...@apple.com
Date 2019-12-03 19:06:02 -0800 (Tue, 03 Dec 2019)
Log Message
Web Inspector: Timelines: stopping time marker is permanently removed when the current recording is cleared
https://bugs.webkit.org/show_bug.cgi?id=204827
Reviewed by Timothy Hatcher.
* UserInterface/Views/TimelineOverview.js:
(WI.TimelineOverview.prototype._recordingReset):
Re-add the marker (and ensure that it's hidden) when the active recording is reset.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (253083 => 253084)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-12-04 03:04:19 UTC (rev 253083)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-12-04 03:06:02 UTC (rev 253084)
@@ -1,3 +1,14 @@
+2019-12-03 Devin Rousso
+
+Web Inspector: Timelines: stopping time marker is permanently removed when the current recording is cleared
+https://bugs.webkit.org/show_bug.cgi?id=204827
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Views/TimelineOverview.js:
+(WI.TimelineOverview.prototype._recordingReset):
+Re-add the marker (and ensure that it's hidden) when the active recording is reset.
+
2019-12-02 Nikita Vasilyev
Web Inspector: Provide UI to convert between sRGB and p3 color spaces
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (253083 => 253084)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2019-12-04 03:04:19 UTC (rev 253083)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2019-12-04 03:06:02 UTC (rev 253084)
@@ -816,7 +816,13 @@
_recordingReset(event)
{
this._timelineRuler.clearMarkers();
+
this._timelineRuler.addMarker(this._currentTimeMarker);
+
+if (this._stoppingTimeMarker) {
+this._stoppingTimeMarker.time = -1; // Hide the marker.
+this._timelineRuler.addMarker(this._stoppingTimeMarker);
+}
}
_canShowTimelineType(type)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253083] trunk/Source/JavaScriptCore
Title: [253083] trunk/Source/_javascript_Core Revision 253083 Author sbar...@apple.com Date 2019-12-03 19:04:19 -0800 (Tue, 03 Dec 2019) Log Message Remove "patch" struct from StructureStubInfo because it adds unnecessary padding https://bugs.webkit.org/show_bug.cgi?id=204392 Reviewed by Tadeu Zagallo. By doing this, we reduce the size of StructureStubInfo from 120 bytes to 112 bytes. * bytecode/AccessCase.cpp: (JSC::AccessCase::generateWithGuard): (JSC::AccessCase::generateImpl): * bytecode/GetterSetterAccessCase.cpp: (JSC::GetterSetterAccessCase::emitDOMJITGetter): * bytecode/InlineAccess.cpp: (JSC::linkCodeInline): (JSC::InlineAccess::generateSelfPropertyAccess): (JSC::getScratchRegister): (JSC::InlineAccess::generateSelfPropertyReplace): (JSC::InlineAccess::generateArrayLength): (JSC::InlineAccess::generateStringLength): (JSC::InlineAccess::generateSelfInAccess): (JSC::InlineAccess::rewireStubAsJump): * bytecode/PolymorphicAccess.cpp: (JSC::PolymorphicAccess::regenerate): * bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::inlineSize const): (JSC::StructureStubInfo::patchableJump): (JSC::StructureStubInfo::valueRegs const): (JSC::StructureStubInfo::propertyRegs const): (JSC::StructureStubInfo::baseRegs const): (JSC::StructureStubInfo::baseGPR const): Deleted. (JSC::StructureStubInfo::slowPathCallLocation): Deleted. (JSC::StructureStubInfo::doneLocation): Deleted. (JSC::StructureStubInfo::slowPathStartLocation): Deleted. * dfg/DFGOSRExitCompilerCommon.cpp: (JSC::DFG::callerReturnPC): * jit/JITInlineCacheGenerator.cpp: (JSC::JITInlineCacheGenerator::JITInlineCacheGenerator): (JSC::JITInlineCacheGenerator::finalize): (JSC::JITByIdGenerator::JITByIdGenerator): (JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator): (JSC::JITPutByIdGenerator::JITPutByIdGenerator): (JSC::JITInstanceOfGenerator::JITInstanceOfGenerator): (JSC::JITGetByValGenerator::JITGetByValGenerator): * jit/Repatch.cpp: (JSC::tryCacheGetBy): (JSC::repatchGetBy): (JSC::repatchArrayGetByVal): (JSC::tryCachePutByID): (JSC::repatchPutByID): (JSC::tryCacheInByID): (JSC::repatchInByID): (JSC::repatchInstanceOf): (JSC::resetGetBy): (JSC::resetPutByID): (JSC::resetPatchableJump): (JSC::resetInByID): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/AccessCase.cpp trunk/Source/_javascript_Core/bytecode/GetterSetterAccessCase.cpp trunk/Source/_javascript_Core/bytecode/InlineAccess.cpp trunk/Source/_javascript_Core/bytecode/PolymorphicAccess.cpp trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h trunk/Source/_javascript_Core/dfg/DFGOSRExitCompilerCommon.cpp trunk/Source/_javascript_Core/jit/JITInlineCacheGenerator.cpp trunk/Source/_javascript_Core/jit/Repatch.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (253082 => 253083) --- trunk/Source/_javascript_Core/ChangeLog 2019-12-04 02:41:49 UTC (rev 253082) +++ trunk/Source/_javascript_Core/ChangeLog 2019-12-04 03:04:19 UTC (rev 253083) @@ -1,3 +1,63 @@ +2019-12-03 Saam Barati + +Remove "patch" struct from StructureStubInfo because it adds unnecessary padding +https://bugs.webkit.org/show_bug.cgi?id=204392 + +Reviewed by Tadeu Zagallo. + +By doing this, we reduce the size of StructureStubInfo from 120 bytes to 112 +bytes. + +* bytecode/AccessCase.cpp: +(JSC::AccessCase::generateWithGuard): +(JSC::AccessCase::generateImpl): +* bytecode/GetterSetterAccessCase.cpp: +(JSC::GetterSetterAccessCase::emitDOMJITGetter): +* bytecode/InlineAccess.cpp: +(JSC::linkCodeInline): +(JSC::InlineAccess::generateSelfPropertyAccess): +(JSC::getScratchRegister): +(JSC::InlineAccess::generateSelfPropertyReplace): +(JSC::InlineAccess::generateArrayLength): +(JSC::InlineAccess::generateStringLength): +(JSC::InlineAccess::generateSelfInAccess): +(JSC::InlineAccess::rewireStubAsJump): +* bytecode/PolymorphicAccess.cpp: +(JSC::PolymorphicAccess::regenerate): +* bytecode/StructureStubInfo.h: +(JSC::StructureStubInfo::inlineSize const): +(JSC::StructureStubInfo::patchableJump): +(JSC::StructureStubInfo::valueRegs const): +(JSC::StructureStubInfo::propertyRegs const): +(JSC::StructureStubInfo::baseRegs const): +(JSC::StructureStubInfo::baseGPR const): Deleted. +(JSC::StructureStubInfo::slowPathCallLocation): Deleted. +(JSC::StructureStubInfo::doneLocation): Deleted. +(JSC::StructureStubInfo::slowPathStartLocation): Deleted. +* dfg/DFGOSRExitCompilerCommon.cpp: +(JSC::DFG::callerReturnPC): +* jit/JITInlineCacheGenerator.cpp: +(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator): +(JSC::JITInlineCacheGenerator::finalize): +(JSC::JITByIdGenerator::JITByIdGenerator): +(JSC::JITGetByIdWithThisGenerator::JITGetByIdWithThisGenerator): +
[webkit-changes] [253082] trunk
Title: [253082] trunk Revision 253082 Author wilan...@apple.com Date 2019-12-03 18:41:49 -0800 (Tue, 03 Dec 2019) Log Message Resource Load Statistics (experimental): Delete non-cookie website data after 7 days of no user interaction https://bugs.webkit.org/show_bug.cgi?id=204779 Reviewed by Alex Christensen. Source/WebCore: Trackers are continuing to move cross-site tracking IDs into first-party storage. This change ages out script-writable non-cookie website data in alignment with the 7-day cap on client-side cookies. Tests: http/tests/resourceLoadStatistics/website-data-removal-for-site-with-user-interaction-database.html http/tests/resourceLoadStatistics/website-data-removal-for-site-with-user-interaction.html http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-database.html http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction.html * page/Settings.yaml: New experimental feature, off by default. * platform/network/NetworkStorageSession.h: Added a boolean enum WebCore::FirstPartyWebsiteDataRemovalMode. Source/WebKit: Trackers are continuing to move cross-site tracking IDs into first-party storage. This change ages out script-writable non-cookie website data in alignment with the 7-day cap on client-side cookies. * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: (WebKit::ResourceLoadStatisticsDatabaseStore::shouldRemoveAllButCookiesFor const): Now makes use of the set WebCore::FirstPartyWebsiteDataRemovalMode. * NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp: (WebKit::ResourceLoadStatisticsMemoryStore::shouldRemoveAllButCookiesFor const): Now makes use of the set WebCore::FirstPartyWebsiteDataRemovalMode. * NetworkProcess/Classifier/ResourceLoadStatisticsStore.h: (WebKit::ResourceLoadStatisticsStore::setFirstPartyWebsiteDataRemovalMode): (WebKit::ResourceLoadStatisticsStore::firstPartyWebsiteDataRemovalMode const): * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::setFirstPartyWebsiteDataRemovalMode): * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h: * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::setFirstPartyWebsiteDataRemovalModeForTesting): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::setResourceLoadStatisticsEnabled): (WebKit::NetworkSession::recreateResourceLoadStatisticStore): (WebKit::NetworkSession::forwardResourceLoadStatisticsSettings): New convenience function to avoid code duplication in NetworkSession::setResourceLoadStatisticsEnabled() and NetworkSession::forwardResourceLoadStatisticsSettings(). * NetworkProcess/NetworkSession.h: * NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::encode const): (WebKit::NetworkSessionCreationParameters::decode): * NetworkProcess/NetworkSessionCreationParameters.h: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): * Scripts/webkit/messages.py: Makes sure the WebCore::FirstPartyWebsiteDataRemovalMode is found in WebCore/NetworkStorageSession.h. * Shared/WebPreferences.yaml: New experimental feature, off by default. * UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreSetResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting): (WKWebsiteDataStoreStatisticsResetToConsistentState): * UIProcess/API/C/WKWebsiteDataStoreRef.h: * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::setFirstPartyWebsiteDataRemovalModeForTesting): * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::ensureNetworkProcess): * UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters): * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::setResourceLoadStatisticsFirstPartyWebsiteDataRemovalModeForTesting): * UIProcess/WebsiteData/WebsiteDataStore.h: Tools: These changes are test infrastructure so that TestRunner can control the new setting. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode): (WTR::TestRunner::statisticsCallDidSetFirstPartyWebsiteDataRemovalModeCallback): * WebKitTestRunner/InjectedBundle/TestRunner.h: * WebKitTestRunner/TestController.cpp: (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode): * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): (WTR::TestInvocation::didSetFirstPartyWebsiteDataRemovalMode): * WebKitTestRunner/TestInvocation.h:
[webkit-changes] [253081] trunk/Source/WebCore
Title: [253081] trunk/Source/WebCore
Revision 253081
Author commit-qu...@webkit.org
Date 2019-12-03 18:36:54 -0800 (Tue, 03 Dec 2019)
Log Message
The animation of returning to inline from PiP targets wrong destination rectangle
https://bugs.webkit.org/show_bug.cgi?id=204819
Patch by Peng Liu on 2019-12-03
Reviewed by Jer Noble.
We have to force AVPlayerViewController's view (which is hidden when it is returning to inline in another tab) to run layout
after we set its target size and position to make sure all layers inside the view have the correct information.
Otherwise, the return to inline animation will be incorrect.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::preparedToReturnToInline):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (253080 => 253081)
--- trunk/Source/WebCore/ChangeLog 2019-12-04 02:33:05 UTC (rev 253080)
+++ trunk/Source/WebCore/ChangeLog 2019-12-04 02:36:54 UTC (rev 253081)
@@ -1,3 +1,17 @@
+2019-12-03 Peng Liu
+
+The animation of returning to inline from PiP targets wrong destination rectangle
+https://bugs.webkit.org/show_bug.cgi?id=204819
+
+Reviewed by Jer Noble.
+
+We have to force AVPlayerViewController's view (which is hidden when it is returning to inline in another tab) to run layout
+after we set its target size and position to make sure all layers inside the view have the correct information.
+Otherwise, the return to inline animation will be incorrect.
+
+* platform/ios/VideoFullscreenInterfaceAVKit.mm:
+(VideoFullscreenInterfaceAVKit::preparedToReturnToInline):
+
2019-12-03 Doug Kelly
Assertion when encountering U_OTHER_NEUTRAL in createBidiRunsForLine at end of run
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (253080 => 253081)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2019-12-04 02:33:05 UTC (rev 253080)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2019-12-04 02:36:54 UTC (rev 253081)
@@ -958,6 +958,8 @@
{
LOG(Fullscreen, "VideoFullscreenInterfaceAVKit::preparedToReturnToInline(%p) - visible(%s)", this, boolString(visible));
setInlineRect(inlineRect, visible);
+[[m_playerViewController view] setNeedsLayout];
+[[m_playerViewController view] layoutIfNeeded];
if (m_prepareToInlineCallback) {
WTF::Function callback = WTFMove(m_prepareToInlineCallback);
callback(visible);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253080] trunk/Source/JavaScriptCore
Title: [253080] trunk/Source/_javascript_Core
Revision 253080
Author ysuz...@apple.com
Date 2019-12-03 18:33:05 -0800 (Tue, 03 Dec 2019)
Log Message
Unreviewed, fix build failure
https://bugs.webkit.org/show_bug.cgi?id=186552
* wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::getGlobal):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::setGlobal):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (253079 => 253080)
--- trunk/Source/_javascript_Core/ChangeLog 2019-12-04 02:22:35 UTC (rev 253079)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-12-04 02:33:05 UTC (rev 253080)
@@ -1,5 +1,15 @@
2019-12-03 Yusuke Suzuki
+Unreviewed, fix build failure
+https://bugs.webkit.org/show_bug.cgi?id=186552
+
+* wasm/WasmAirIRGenerator.cpp:
+(JSC::Wasm::AirIRGenerator::getGlobal):
+* wasm/WasmB3IRGenerator.cpp:
+(JSC::Wasm::B3IRGenerator::setGlobal):
+
+2019-12-03 Yusuke Suzuki
+
[JSC] Remove WebAssemblyToJSCallee
https://bugs.webkit.org/show_bug.cgi?id=204808
Modified: trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp (253079 => 253080)
--- trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp 2019-12-04 02:22:35 UTC (rev 253079)
+++ trunk/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp 2019-12-04 02:33:05 UTC (rev 253080)
@@ -1224,7 +1224,7 @@
}
break;
case Wasm::GlobalInformation::BindingMode::Portable:
-ASSERT(global.mutability == Mutable);
+ASSERT(global.mutability == Wasm::GlobalInformation::Mutability::Mutable);
if (Arg::isValidAddrForm(offset, B3::Width64))
append(Move, Arg::addr(temp, offset), temp);
else {
@@ -1264,7 +1264,7 @@
emitWriteBarrierForJSWrapper();
break;
case Wasm::GlobalInformation::BindingMode::Portable:
-ASSERT(global.mutability == Mutable);
+ASSERT(global.mutability == Wasm::GlobalInformation::Mutability::Mutable);
if (Arg::isValidAddrForm(offset, B3::Width64))
append(Move, Arg::addr(temp, offset), temp);
else {
Modified: trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp (253079 => 253080)
--- trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp 2019-12-04 02:22:35 UTC (rev 253079)
+++ trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp 2019-12-04 02:33:05 UTC (rev 253080)
@@ -818,7 +818,7 @@
result = m_currentBlock->appendNew(m_proc, Load, toB3Type(global.type), origin(), globalsArray, safeCast(index * sizeof(Register)));
break;
case Wasm::GlobalInformation::BindingMode::Portable: {
-ASSERT(global.mutability == Mutable);
+ASSERT(global.mutability == Wasm::GlobalInformation::Mutability::Mutable);
Value* pointer = m_currentBlock->appendNew(m_proc, Load, B3::Int64, origin(), globalsArray, safeCast(index * sizeof(Register)));
result = m_currentBlock->appendNew(m_proc, Load, toB3Type(global.type), origin(), pointer);
break;
@@ -839,7 +839,7 @@
emitWriteBarrierForJSWrapper();
break;
case Wasm::GlobalInformation::BindingMode::Portable: {
-ASSERT(global.mutability == Mutable);
+ASSERT(global.mutability == Wasm::GlobalInformation::Mutability::Mutable);
Value* pointer = m_currentBlock->appendNew(m_proc, Load, B3::Int64, origin(), globalsArray, safeCast(index * sizeof(Register)));
m_currentBlock->appendNew(m_proc, Store, origin(), value, pointer);
// We emit a write-barrier onto JSWebAssemblyGlobal, not JSWebAssemblyInstance.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253078] tags/Safari-609.1.11/Source/WebCore
Title: [253078] tags/Safari-609.1.11/Source/WebCore
Revision 253078
Author alanc...@apple.com
Date 2019-12-03 18:10:34 -0800 (Tue, 03 Dec 2019)
Log Message
Cherry-pick r253062. rdar://problem/57576474
Experimental support for HDR media query
https://bugs.webkit.org/show_bug.cgi?id=204422
Reviewed by Eric Carlson.
Follow-up to r252762 for platforms that don't have MediaToolbox.framework.
* platform/ios/PlatformScreenIOS.mm:
(WebCore::screenSupportsHighDynamicRange):
* platform/mac/PlatformScreenMac.mm:
(WebCore::collectScreenProperties):
(WebCore::screenSupportsHighDynamicRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
tags/Safari-609.1.11/Source/WebCore/ChangeLog
tags/Safari-609.1.11/Source/WebCore/platform/ios/PlatformScreenIOS.mm
tags/Safari-609.1.11/Source/WebCore/platform/mac/PlatformScreenMac.mm
Diff
Modified: tags/Safari-609.1.11/Source/WebCore/ChangeLog (253077 => 253078)
--- tags/Safari-609.1.11/Source/WebCore/ChangeLog 2019-12-04 02:10:29 UTC (rev 253077)
+++ tags/Safari-609.1.11/Source/WebCore/ChangeLog 2019-12-04 02:10:34 UTC (rev 253078)
@@ -1,5 +1,42 @@
2019-12-03 Kocsen Chung
+Cherry-pick r253062. rdar://problem/57576474
+
+Experimental support for HDR media query
+https://bugs.webkit.org/show_bug.cgi?id=204422
+
+
+Reviewed by Eric Carlson.
+
+Follow-up to r252762 for platforms that don't have MediaToolbox.framework.
+
+* platform/ios/PlatformScreenIOS.mm:
+(WebCore::screenSupportsHighDynamicRange):
+* platform/mac/PlatformScreenMac.mm:
+(WebCore::collectScreenProperties):
+(WebCore::screenSupportsHighDynamicRange):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-12-03 Jer Noble
+
+Experimental support for HDR media query
+https://bugs.webkit.org/show_bug.cgi?id=204422
+
+
+Reviewed by Eric Carlson.
+
+Follow-up to r252762 for platforms that don't have MediaToolbox.framework.
+
+* platform/ios/PlatformScreenIOS.mm:
+(WebCore::screenSupportsHighDynamicRange):
+* platform/mac/PlatformScreenMac.mm:
+(WebCore::collectScreenProperties):
+(WebCore::screenSupportsHighDynamicRange):
+
+2019-12-03 Kocsen Chung
+
Cherry-pick r252881. rdar://problem/57487005
Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad)
Modified: tags/Safari-609.1.11/Source/WebCore/platform/ios/PlatformScreenIOS.mm (253077 => 253078)
--- tags/Safari-609.1.11/Source/WebCore/platform/ios/PlatformScreenIOS.mm 2019-12-04 02:10:29 UTC (rev 253077)
+++ tags/Safari-609.1.11/Source/WebCore/platform/ios/PlatformScreenIOS.mm 2019-12-04 02:10:34 UTC (rev 253078)
@@ -75,7 +75,7 @@
bool screenSupportsHighDynamicRange(Widget*)
{
#if USE(MEDIATOOLBOX)
-if (PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
return PAL::softLink_MediaToolbox_MTShouldPlayHDRVideo(nullptr);
#endif
return false;
Modified: tags/Safari-609.1.11/Source/WebCore/platform/mac/PlatformScreenMac.mm (253077 => 253078)
--- tags/Safari-609.1.11/Source/WebCore/platform/mac/PlatformScreenMac.mm 2019-12-04 02:10:29 UTC (rev 253077)
+++ tags/Safari-609.1.11/Source/WebCore/platform/mac/PlatformScreenMac.mm 2019-12-04 02:10:34 UTC (rev 253078)
@@ -135,7 +135,7 @@
bool screenSupportsHighDynamicRange = false;
#if USE(MEDIATOOLBOX)
-if (PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
screenSupportsHighDynamicRange = PAL::softLink_MediaToolbox_MTShouldPlayHDRVideo((__bridge CFArrayRef)@[ @(displayID) ]);
#endif
@@ -365,7 +365,7 @@
ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
#if USE(MEDIATOOLBOX)
-if (PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo()) {
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo()) {
auto displayID = WebCore::displayID(screen(widget));
return PAL::softLink_MediaToolbox_MTShouldPlayHDRVideo((__bridge CFArrayRef)@[ @(displayID) ]);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253077] tags/Safari-609.1.11/Source/WebCore
Title: [253077] tags/Safari-609.1.11/Source/WebCore Revision 253077 Author alanc...@apple.com Date 2019-12-03 18:10:29 -0800 (Tue, 03 Dec 2019) Log Message Cherry-pick r252881. rdar://problem/57487005 Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad) https://bugs.webkit.org/show_bug.cgi?id=204593 Reviewed by Antti Koivisto. After r252761, we no longer triggers a fragment scrolling as a part of style resolution. Consequently, there is no need for Document::needsStyleRecalc() to return true even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets. No new tests since there shouldn't really be any observable behavior difference. * dom/Document.cpp: (WebCore::Document::needsStyleRecalc const): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252881 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths tags/Safari-609.1.11/Source/WebCore/ChangeLog tags/Safari-609.1.11/Source/WebCore/dom/Document.cpp Diff Modified: tags/Safari-609.1.11/Source/WebCore/ChangeLog (253076 => 253077) --- tags/Safari-609.1.11/Source/WebCore/ChangeLog 2019-12-04 02:04:01 UTC (rev 253076) +++ tags/Safari-609.1.11/Source/WebCore/ChangeLog 2019-12-04 02:10:29 UTC (rev 253077) @@ -1,3 +1,40 @@ +2019-12-03 Kocsen Chung + +Cherry-pick r252881. rdar://problem/57487005 + +Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad) +https://bugs.webkit.org/show_bug.cgi?id=204593 + +Reviewed by Antti Koivisto. + +After r252761, we no longer triggers a fragment scrolling as a part of style resolution. +Consequently, there is no need for Document::needsStyleRecalc() to return true +even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets. + +No new tests since there shouldn't really be any observable behavior difference. + +* dom/Document.cpp: +(WebCore::Document::needsStyleRecalc const): + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252881 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2019-11-26 Ryosuke Niwa + +Document::needsStyleRecalc() shouldn't return true for fragment scrolling (m_gotoAnchorNeededAfterStylesheetsLoad) +https://bugs.webkit.org/show_bug.cgi?id=204593 + +Reviewed by Antti Koivisto. + +After r252761, we no longer triggers a fragment scrolling as a part of style resolution. +Consequently, there is no need for Document::needsStyleRecalc() to return true +even when m_gotoAnchorNeededAfterStylesheetsLoad is set and there are no more pending stylesheets. + +No new tests since there shouldn't really be any observable behavior difference. + +* dom/Document.cpp: +(WebCore::Document::needsStyleRecalc const): + 2019-12-03 Alan Coon Cherry-pick r252956. rdar://problem/57438874 Modified: tags/Safari-609.1.11/Source/WebCore/dom/Document.cpp (253076 => 253077) --- tags/Safari-609.1.11/Source/WebCore/dom/Document.cpp 2019-12-04 02:04:01 UTC (rev 253076) +++ tags/Safari-609.1.11/Source/WebCore/dom/Document.cpp 2019-12-04 02:10:29 UTC (rev 253077) @@ -2029,10 +2029,6 @@ if (styleScope().hasPendingUpdate()) return true; -// Ensure this happens eventually as it is currently in resolveStyle. This can be removed if the code moves. -if (m_gotoAnchorNeededAfterStylesheetsLoad && !styleScope().hasPendingSheets()) -return true; - return false; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253076] trunk/Source/WebKit
Title: [253076] trunk/Source/WebKit Revision 253076 Author cdu...@apple.com Date 2019-12-03 18:04:01 -0800 (Tue, 03 Dec 2019) Log Message [iOS] Unable to interact with the view after a back swipe until lifting the finger off the screen https://bugs.webkit.org/show_bug.cgi?id=204821 Reviewed by Tim Horton. If you swipe back on iOS and then put your finger on the screen before the view gesture snapshot is taken down, your gestures will not be recognized, even after the snapshot is taken down, until after you lift your finger off the screen and back on. This makes MobileSafari look more unresponsive than it needs to be. To address the issue, disable user interactions for the snapshot view, so that interactions go through to the actual view underneath. * UIProcess/ios/ViewGestureControllerIOS.mm: (WebKit::ViewGestureController::beginSwipeGesture): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm Diff Modified: trunk/Source/WebKit/ChangeLog (253075 => 253076) --- trunk/Source/WebKit/ChangeLog 2019-12-04 01:42:51 UTC (rev 253075) +++ trunk/Source/WebKit/ChangeLog 2019-12-04 02:04:01 UTC (rev 253076) @@ -1,5 +1,22 @@ 2019-12-03 Chris Dumez +[iOS] Unable to interact with the view after a back swipe until lifting the finger off the screen +https://bugs.webkit.org/show_bug.cgi?id=204821 + +Reviewed by Tim Horton. + +If you swipe back on iOS and then put your finger on the screen before the view gesture snapshot is taken down, +your gestures will not be recognized, even after the snapshot is taken down, until after you lift your finger +off the screen and back on. This makes MobileSafari look more unresponsive than it needs to be. + +To address the issue, disable user interactions for the snapshot view, so that interactions go through to the +actual view underneath. + +* UIProcess/ios/ViewGestureControllerIOS.mm: +(WebKit::ViewGestureController::beginSwipeGesture): + +2019-12-03 Chris Dumez + Use a 3 second timeout for the view gesture snapshot on macOS https://bugs.webkit.org/show_bug.cgi?id=204818 Modified: trunk/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm (253075 => 253076) --- trunk/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm 2019-12-04 01:42:51 UTC (rev 253075) +++ trunk/Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm 2019-12-04 02:04:01 UTC (rev 253076) @@ -201,6 +201,11 @@ RetainPtr snapshotViewController = adoptNS([[UIViewController alloc] init]); m_snapshotView = adoptNS([[UIView alloc] initWithFrame:liveSwipeViewFrame]); + +// Disabling user interaction on the snapshot view lets the gestures go through the snapshot view, to the +// actual underlying view. +[m_snapshotView setUserInteractionEnabled:NO]; + [m_snapshotView layer].name = @"SwipeSnapshot"; RetainPtr backgroundColor = [UIColor whiteColor]; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253075] trunk/Source/JavaScriptCore
Title: [253075] trunk/Source/_javascript_Core Revision 253075 Author ysuz...@apple.com Date 2019-12-03 17:42:51 -0800 (Tue, 03 Dec 2019) Log Message [JSC] Remove WebAssemblyToJSCallee https://bugs.webkit.org/show_bug.cgi?id=204808 Reviewed by Tadeu Zagallo. This patch drops WebAssemblyToJSCallee. It was originally required to put small cell to retrieve VM from callee. But now this limitation is removed. We can just put JSWebAssemblyModule in callee place instead. * _javascript_Core.xcodeproj/project.pbxproj: * Sources.txt: * interpreter/CallFrame.cpp: (JSC::CallFrame::isAnyWasmCallee): * interpreter/StackVisitor.cpp: (JSC::StackVisitor::Frame::calleeSaveRegistersForUnwinding): * jit/Repatch.cpp: (JSC::webAssemblyOwner): (JSC::linkFor): (JSC::linkPolymorphicCall): * runtime/JSCast.h: * runtime/JSCell.cpp: * runtime/JSCellInlines.h: (JSC::isWebAssemblyModule): (JSC::isWebAssemblyToJSCallee): Deleted. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildren): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::webAssemblyWrapperFunctionStructure const): (JSC::JSGlobalObject::webAssemblyToJSCalleeStructure const): Deleted. * runtime/JSType.cpp: (WTF::printInternal): * runtime/JSType.h: * wasm/WasmOperations.cpp: (JSC::Wasm::operationWasmToJSException): * wasm/js/JSWebAssemblyInstance.cpp: (JSC::JSWebAssemblyInstance::finishCreation): (JSC::JSWebAssemblyInstance::visitChildren): * wasm/js/JSWebAssemblyInstance.h: * wasm/js/JSWebAssemblyModule.cpp: (JSC::JSWebAssemblyModule::createStructure): (JSC::JSWebAssemblyModule::finishCreation): (JSC::JSWebAssemblyModule::visitChildren): (JSC::JSWebAssemblyModule::callee const): Deleted. * wasm/js/JSWebAssemblyModule.h: * wasm/js/WasmToJS.cpp: (JSC::Wasm::handleBadI64Use): (JSC::Wasm::wasmToJS): * wasm/js/WebAssemblyToJSCallee.cpp: Removed. * wasm/js/WebAssemblyToJSCallee.h: Removed. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/Sources.txt trunk/Source/_javascript_Core/interpreter/CallFrame.cpp trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp trunk/Source/_javascript_Core/jit/Repatch.cpp trunk/Source/_javascript_Core/runtime/JSCast.h trunk/Source/_javascript_Core/runtime/JSCell.cpp trunk/Source/_javascript_Core/runtime/JSCellInlines.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h trunk/Source/_javascript_Core/runtime/JSType.cpp trunk/Source/_javascript_Core/runtime/JSType.h trunk/Source/_javascript_Core/wasm/WasmOperations.cpp trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyInstance.cpp trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyInstance.h trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyModule.cpp trunk/Source/_javascript_Core/wasm/js/JSWebAssemblyModule.h trunk/Source/_javascript_Core/wasm/js/WasmToJS.cpp Removed Paths trunk/Source/_javascript_Core/wasm/js/WebAssemblyToJSCallee.cpp trunk/Source/_javascript_Core/wasm/js/WebAssemblyToJSCallee.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (253074 => 253075) --- trunk/Source/_javascript_Core/ChangeLog 2019-12-04 01:36:56 UTC (rev 253074) +++ trunk/Source/_javascript_Core/ChangeLog 2019-12-04 01:42:51 UTC (rev 253075) @@ -1,5 +1,57 @@ 2019-12-03 Yusuke Suzuki +[JSC] Remove WebAssemblyToJSCallee +https://bugs.webkit.org/show_bug.cgi?id=204808 + +Reviewed by Tadeu Zagallo. + +This patch drops WebAssemblyToJSCallee. It was originally required to put small cell to retrieve VM from callee. +But now this limitation is removed. We can just put JSWebAssemblyModule in callee place instead. + +* _javascript_Core.xcodeproj/project.pbxproj: +* Sources.txt: +* interpreter/CallFrame.cpp: +(JSC::CallFrame::isAnyWasmCallee): +* interpreter/StackVisitor.cpp: +(JSC::StackVisitor::Frame::calleeSaveRegistersForUnwinding): +* jit/Repatch.cpp: +(JSC::webAssemblyOwner): +(JSC::linkFor): +(JSC::linkPolymorphicCall): +* runtime/JSCast.h: +* runtime/JSCell.cpp: +* runtime/JSCellInlines.h: +(JSC::isWebAssemblyModule): +(JSC::isWebAssemblyToJSCallee): Deleted. +* runtime/JSGlobalObject.cpp: +(JSC::JSGlobalObject::init): +(JSC::JSGlobalObject::visitChildren): +* runtime/JSGlobalObject.h: +(JSC::JSGlobalObject::webAssemblyWrapperFunctionStructure const): +(JSC::JSGlobalObject::webAssemblyToJSCalleeStructure const): Deleted. +* runtime/JSType.cpp: +(WTF::printInternal): +* runtime/JSType.h: +* wasm/WasmOperations.cpp: +(JSC::Wasm::operationWasmToJSException): +* wasm/js/JSWebAssemblyInstance.cpp: +(JSC::JSWebAssemblyInstance::finishCreation): +(JSC::JSWebAssemblyInstance::visitChildren): +*
[webkit-changes] [253073] trunk/Tools
Title: [253073] trunk/Tools Revision 253073 Author jbed...@apple.com Date 2019-12-03 17:33:33 -0800 (Tue, 03 Dec 2019) Log Message Python 3: Add support in webkitpy.bindings https://bugs.webkit.org/show_bug.cgi?id=204783 Reviewed by Stephanie Lewis. Allow Tools/Scripts/run-bindings-tests to support Python 3. * Scripts/webkitpy/bindings/main.py: (BindingsTests.generate_supplemental_dependency): Encode unicode strings before writing to file as bytes. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/bindings/main.py Diff Modified: trunk/Tools/ChangeLog (253072 => 253073) --- trunk/Tools/ChangeLog 2019-12-04 01:27:00 UTC (rev 253072) +++ trunk/Tools/ChangeLog 2019-12-04 01:33:33 UTC (rev 253073) @@ -1,5 +1,18 @@ 2019-12-03 Jonathan Bedard +Python 3: Add support in webkitpy.bindings +https://bugs.webkit.org/show_bug.cgi?id=204783 + +Reviewed by Stephanie Lewis. + +Allow Tools/Scripts/run-bindings-tests to support Python 3. + +* Scripts/webkitpy/bindings/main.py: +(BindingsTests.generate_supplemental_dependency): Encode unicode strings before +writing to file as bytes. + +2019-12-03 Jonathan Bedard + results.webkit.org: Sort out certificates on Catalina https://bugs.webkit.org/show_bug.cgi?id=202837 Modified: trunk/Tools/Scripts/webkitpy/bindings/main.py (253072 => 253073) --- trunk/Tools/Scripts/webkitpy/bindings/main.py 2019-12-04 01:27:00 UTC (rev 253072) +++ trunk/Tools/Scripts/webkitpy/bindings/main.py 2019-12-04 01:33:33 UTC (rev 253073) @@ -32,6 +32,7 @@ import tempfile from webkitpy.common.checkout.scm.detection import detect_scm_system from webkitpy.common.system.executive import ScriptError +from webkitpy.common.unicode_compatibility import encode_if_necessary class BindingsTests: @@ -76,7 +77,7 @@ (name, extension) = os.path.splitext(input_file) if extension != '.idl': continue -os.write(idl_files_list[0], os.path.join(input_directory, input_file) + "\n") +os.write(idl_files_list[0], encode_if_necessary(os.path.join(input_directory, input_file) + "\n")) os.close(idl_files_list[0]) cmd = ['perl', '-w', ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253072] trunk/Source/WTF
Title: [253072] trunk/Source/WTF Revision 253072 Author commit-qu...@webkit.org Date 2019-12-03 17:27:00 -0800 (Tue, 03 Dec 2019) Log Message Enable security assertions on all ASAN builds https://bugs.webkit.org/show_bug.cgi?id=204802 Patch by Sunny He on 2019-12-03 Reviewed by Ryosuke Niwa. * wtf/FeatureDefines.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/FeatureDefines.h Diff Modified: trunk/Source/WTF/ChangeLog (253071 => 253072) --- trunk/Source/WTF/ChangeLog 2019-12-04 00:34:42 UTC (rev 253071) +++ trunk/Source/WTF/ChangeLog 2019-12-04 01:27:00 UTC (rev 253072) @@ -1,3 +1,12 @@ +2019-12-03 Sunny He + +Enable security assertions on all ASAN builds +https://bugs.webkit.org/show_bug.cgi?id=204802 + +Reviewed by Ryosuke Niwa. + +* wtf/FeatureDefines.h: + 2019-12-03 Christopher Reid Regular _expression_ hangs in Safari only Modified: trunk/Source/WTF/wtf/FeatureDefines.h (253071 => 253072) --- trunk/Source/WTF/wtf/FeatureDefines.h 2019-12-04 00:34:42 UTC (rev 253071) +++ trunk/Source/WTF/wtf/FeatureDefines.h 2019-12-04 01:27:00 UTC (rev 253072) @@ -663,6 +663,13 @@ #define ENABLE_RUBBER_BANDING 0 #endif +#if !defined(ENABLE_SECURITY_ASSERTIONS) +/* Enable security assertions on all ASAN builds and debug builds. */ +#if ASAN_ENABLED || !defined(NDEBUG) +#define ENABLE_SECURITY_ASSERTIONS 1 +#endif +#endif + #if !defined(ENABLE_SMOOTH_SCROLLING) #define ENABLE_SMOOTH_SCROLLING 0 #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253071] trunk/Source/WebKit
Title: [253071] trunk/Source/WebKit
Revision 253071
Author cdu...@apple.com
Date 2019-12-03 16:34:42 -0800 (Tue, 03 Dec 2019)
Log Message
Use a 3 second timeout for the view gesture snapshot on macOS
https://bugs.webkit.org/show_bug.cgi?id=204818
Reviewed by Tim Horton.
Use a 3 second timeout for the view gesture snapshot on macOS, for consistency with iOS.
It used to be 5 seconds on macOS.
* UIProcess/ViewGestureController.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ViewGestureController.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (253070 => 253071)
--- trunk/Source/WebKit/ChangeLog 2019-12-04 00:16:40 UTC (rev 253070)
+++ trunk/Source/WebKit/ChangeLog 2019-12-04 00:34:42 UTC (rev 253071)
@@ -1,5 +1,17 @@
2019-12-03 Chris Dumez
+Use a 3 second timeout for the view gesture snapshot on macOS
+https://bugs.webkit.org/show_bug.cgi?id=204818
+
+Reviewed by Tim Horton.
+
+Use a 3 second timeout for the view gesture snapshot on macOS, for consistency with iOS.
+It used to be 5 seconds on macOS.
+
+* UIProcess/ViewGestureController.cpp:
+
+2019-12-03 Chris Dumez
+
REGRESSION (r252778): ASSERT(!m_networkLoad); in ~SpeculativeLoad()
https://bugs.webkit.org/show_bug.cgi?id=204813
Modified: trunk/Source/WebKit/UIProcess/ViewGestureController.cpp (253070 => 253071)
--- trunk/Source/WebKit/UIProcess/ViewGestureController.cpp 2019-12-04 00:16:40 UTC (rev 253070)
+++ trunk/Source/WebKit/UIProcess/ViewGestureController.cpp 2019-12-04 00:34:42 UTC (rev 253071)
@@ -52,12 +52,7 @@
static const Seconds swipeSnapshotRemovalWatchdogAfterFirstVisuallyNonEmptyLayoutDuration { 3_s };
static const Seconds swipeSnapshotRemovalActiveLoadMonitoringInterval { 250_ms };
-
-#if !PLATFORM(IOS_FAMILY)
-static const Seconds swipeSnapshotRemovalWatchdogDuration = 5_s;
-#else
static const Seconds swipeSnapshotRemovalWatchdogDuration = 3_s;
-#endif
#if !PLATFORM(IOS_FAMILY)
static const float minimumHorizontalSwipeDistance = 15;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253070] trunk/LayoutTests
Title: [253070] trunk/LayoutTests Revision 253070 Author tsav...@apple.com Date 2019-12-03 16:16:40 -0800 (Tue, 03 Dec 2019) Log Message 6 fast/text/emoji-gender are expected to fail on Catalina 10.15.1 and newer https://bugs.webkit.org/show_bug.cgi?id=204820 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (253069 => 253070) --- trunk/LayoutTests/ChangeLog 2019-12-03 23:59:19 UTC (rev 253069) +++ trunk/LayoutTests/ChangeLog 2019-12-04 00:16:40 UTC (rev 253070) @@ -1,3 +1,12 @@ +2019-12-03 Truitt Savell + +6 fast/text/emoji-gender are expected to fail on Catalina 10.15.1 and newer +https://bugs.webkit.org/show_bug.cgi?id=204820 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2019-12-03 Doug Kelly Assertion when encountering U_OTHER_NEUTRAL in createBidiRunsForLine at end of run Modified: trunk/LayoutTests/platform/mac/TestExpectations (253069 => 253070) --- trunk/LayoutTests/platform/mac/TestExpectations 2019-12-03 23:59:19 UTC (rev 253069) +++ trunk/LayoutTests/platform/mac/TestExpectations 2019-12-04 00:16:40 UTC (rev 253070) @@ -1954,4 +1954,11 @@ # rdar://54275897 ([ macOS ] Add support for batched key requests) platform/mac/media/encrypted-media/fps-multiple-pssh.html [ Skip ] -webkit.org/b/204756 imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/204756 imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker.html [ Pass Failure ] + +webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-3.html [ ImageOnlyFailure ] +webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-4.html [ ImageOnlyFailure ] +webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-5.html [ ImageOnlyFailure ] +webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-6.html [ ImageOnlyFailure ] +webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-8.html [ ImageOnlyFailure ] +webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-9.html [ ImageOnlyFailure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253069] trunk/Tools
Title: [253069] trunk/Tools
Revision 253069
Author jbed...@apple.com
Date 2019-12-03 15:59:19 -0800 (Tue, 03 Dec 2019)
Log Message
results.webkit.org: Sort out certificates on Catalina
https://bugs.webkit.org/show_bug.cgi?id=202837
Unreviewed infrastructure repair.
Reverting the active parts of r250997 now that the certificates are sorted out.
* Scripts/webkitpy/results/upload.py:
(Upload.upload):
(Upload.upload_archive):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/results/upload.py
Diff
Modified: trunk/Tools/ChangeLog (253068 => 253069)
--- trunk/Tools/ChangeLog 2019-12-03 23:41:26 UTC (rev 253068)
+++ trunk/Tools/ChangeLog 2019-12-03 23:59:19 UTC (rev 253069)
@@ -1,5 +1,18 @@
2019-12-03 Jonathan Bedard
+results.webkit.org: Sort out certificates on Catalina
+https://bugs.webkit.org/show_bug.cgi?id=202837
+
+Unreviewed infrastructure repair.
+
+Reverting the active parts of r250997 now that the certificates are sorted out.
+
+* Scripts/webkitpy/results/upload.py:
+(Upload.upload):
+(Upload.upload_archive):
+
+2019-12-03 Jonathan Bedard
+
results.webkit.org: Decrease ttl for archives
https://bugs.webkit.org/show_bug.cgi?id=204806
Modified: trunk/Tools/Scripts/webkitpy/results/upload.py (253068 => 253069)
--- trunk/Tools/Scripts/webkitpy/results/upload.py 2019-12-03 23:41:26 UTC (rev 253068)
+++ trunk/Tools/Scripts/webkitpy/results/upload.py 2019-12-03 23:59:19 UTC (rev 253069)
@@ -184,7 +184,6 @@
'{}{}'.format(hostname, self.UPLOAD_ENDPOINT),
headers={'Content-type': 'application/json'},
data=""
-verify=False,
)
except requests.exceptions.ConnectionError:
log_line_func(' ' * 4 + 'Failed to upload to {}, results server not online'.format(hostname))
@@ -222,7 +221,6 @@
'{}{}'.format(hostname, self.ARCHIVE_UPLOAD_ENDPOINT),
data=""
files=dict(file=archive),
-verify=False,
)
except requests.exceptions.ConnectionError:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253068] trunk
Title: [253068] trunk Revision 253068 Author commit-qu...@webkit.org Date 2019-12-03 15:41:26 -0800 (Tue, 03 Dec 2019) Log Message Assertion when encountering U_OTHER_NEUTRAL in createBidiRunsForLine at end of run https://bugs.webkit.org/show_bug.cgi?id=204485 Patch by Doug Kelly on 2019-12-03 Reviewed by Ryosuke Niwa. Source/WebCore: Comment out the assert for the default case when setting direction at the end of a bidirectional run. The current algorithm may not fully support UAX #9, but this assert also isn't helpful in development. Test: fast/text/international/unicode-bidi-other-neutrals.html * platform/text/BidiResolver.h: (WebCore::DerivedClass>::createBidiRunsForLine): LayoutTests: Add a simple test case which illustrates a neutral at the end of a Unicode bidirectional run. * fast/text/international/unicode-bidi-other-neutrals-expected.html: Added. * fast/text/international/unicode-bidi-other-neutrals.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/text/BidiResolver.h Added Paths trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html Diff Modified: trunk/LayoutTests/ChangeLog (253067 => 253068) --- trunk/LayoutTests/ChangeLog 2019-12-03 23:34:03 UTC (rev 253067) +++ trunk/LayoutTests/ChangeLog 2019-12-03 23:41:26 UTC (rev 253068) @@ -1,3 +1,16 @@ +2019-12-03 Doug Kelly + +Assertion when encountering U_OTHER_NEUTRAL in createBidiRunsForLine at end of run +https://bugs.webkit.org/show_bug.cgi?id=204485 + +Reviewed by Ryosuke Niwa. + +Add a simple test case which illustrates a neutral at the end of a +Unicode bidirectional run. + +* fast/text/international/unicode-bidi-other-neutrals-expected.html: Added. +* fast/text/international/unicode-bidi-other-neutrals.html: Added. + 2019-12-03 Wenson Hsieh fast/events/touch/ios/passive-by-default-on-document-and-window.html is a flaky failure Added: trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html (0 => 253068) --- trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html (rev 0) +++ trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals-expected.html 2019-12-03 23:41:26 UTC (rev 253068) @@ -0,0 +1,10 @@ + + + + + + +a +b + + Added: trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html (0 => 253068) --- trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html (rev 0) +++ trunk/LayoutTests/fast/text/international/unicode-bidi-other-neutrals.html 2019-12-03 23:41:26 UTC (rev 253068) @@ -0,0 +1,10 @@ + + + + + + +a +b + + Modified: trunk/Source/WebCore/ChangeLog (253067 => 253068) --- trunk/Source/WebCore/ChangeLog 2019-12-03 23:34:03 UTC (rev 253067) +++ trunk/Source/WebCore/ChangeLog 2019-12-03 23:41:26 UTC (rev 253068) @@ -1,3 +1,19 @@ +2019-12-03 Doug Kelly + +Assertion when encountering U_OTHER_NEUTRAL in createBidiRunsForLine at end of run +https://bugs.webkit.org/show_bug.cgi?id=204485 + +Reviewed by Ryosuke Niwa. + +Comment out the assert for the default case when setting direction at +the end of a bidirectional run. The current algorithm may not fully +support UAX #9, but this assert also isn't helpful in development. + +Test: fast/text/international/unicode-bidi-other-neutrals.html + +* platform/text/BidiResolver.h: +(WebCore::DerivedClass>::createBidiRunsForLine): + 2019-12-03 Jer Noble Adopt AVContentKeyReportGroup Modified: trunk/Source/WebCore/platform/text/BidiResolver.h (253067 => 253068) --- trunk/Source/WebCore/platform/text/BidiResolver.h 2019-12-03 23:34:03 UTC (rev 253067) +++ trunk/Source/WebCore/platform/text/BidiResolver.h 2019-12-03 23:41:26 UTC (rev 253068) @@ -896,7 +896,8 @@ m_direction = m_status.lastStrong == U_LEFT_TO_RIGHT ? U_LEFT_TO_RIGHT : U_EUROPEAN_NUMBER; break; default: -ASSERT_NOT_REACHED(); +// FIXME: handle neutrals in this case. See https://bugs.webkit.org/show_bug.cgi?id=204817 +break; } appendRun(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253067] trunk/LayoutTests/imported/w3c
Title: [253067] trunk/LayoutTests/imported/w3c
Revision 253067
Author commit-qu...@webkit.org
Date 2019-12-03 15:34:03 -0800 (Tue, 03 Dec 2019)
Log Message
Re-sync web-platform-tests/html/webappapis/scripting/events from upstream
https://bugs.webkit.org/show_bug.cgi?id=204814
Patch by Alexey Shvayka on 2019-12-03
Reviewed by Ryosuke Niwa.
Re-sync web-platform-tests/html/webappapis/scripting/events from upstream 033bf248c8fa.
Basically, this patch syncs https://github.com/web-platform-tests/wpt/pull/20421 and also
unskips "event-handler-processing-algorithm-error" directory as it is already synced.
* resources/import-expectations.json:
* web-platform-tests/html/webappapis/scripting/events/*: Updated.
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/import-expectations.json
trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-onresize-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-onresize.html
trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/w3c-import.log
Added Paths
trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-handleEvent-ignored-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-handleEvent-ignored.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (253066 => 253067)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-12-03 23:25:05 UTC (rev 253066)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-12-03 23:34:03 UTC (rev 253067)
@@ -1,3 +1,17 @@
+2019-12-03 Alexey Shvayka
+
+Re-sync web-platform-tests/html/webappapis/scripting/events from upstream
+https://bugs.webkit.org/show_bug.cgi?id=204814
+
+Reviewed by Ryosuke Niwa.
+
+Re-sync web-platform-tests/html/webappapis/scripting/events from upstream 033bf248c8fa.
+Basically, this patch syncs https://github.com/web-platform-tests/wpt/pull/20421 and also
+unskips "event-handler-processing-algorithm-error" directory as it is already synced.
+
+* resources/import-expectations.json:
+* web-platform-tests/html/webappapis/scripting/events/*: Updated.
+
2019-12-03 Zan Dobersek
Implement createImageBitmap(OffscreenCanvas)
Modified: trunk/LayoutTests/imported/w3c/resources/import-expectations.json (253066 => 253067)
--- trunk/LayoutTests/imported/w3c/resources/import-expectations.json 2019-12-03 23:25:05 UTC (rev 253066)
+++ trunk/LayoutTests/imported/w3c/resources/import-expectations.json 2019-12-03 23:34:03 UTC (rev 253067)
@@ -272,7 +272,6 @@
"web-platform-tests/html/webappapis/dynamic-markup-insertion": "import",
"web-platform-tests/html/webappapis/idle-callbacks": "skip",
"web-platform-tests/html/webappapis/scripting/event-loops/microtask_after_raf.html": "skip",
-"web-platform-tests/html/webappapis/scripting/events/event-handler-processing-algorithm-error": "skip",
"web-platform-tests/html/webappapis/scripting/processing-model-2/unhandled-promise-rejections": "skip",
"web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin": "import",
"web-platform-tests/http": "skip",
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-handleEvent-ignored-expected.txt (0 => 253067)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-handleEvent-ignored-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-handleEvent-ignored-expected.txt 2019-12-03 23:34:03 UTC (rev 253067)
@@ -0,0 +1,4 @@
+
+FAIL plain object "mouseenter" handler assert_unreached: "handleEvent" property should not be looked up Reached unreachable code
+FAIL non-callable "message" handler that is instance of Function assert_unreached: "handleEvent" property should not be looked up Reached unreachable code
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-handleEvent-ignored.html (0 => 253067)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-handleEvent-ignored.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-handleEvent-ignored.html 2019-12-03 23:34:03 UTC (rev 253067)
@@ -0,0 +1,38 @@
+
+
+"handleEvent" property of EventHandler should be ignored
+
+
+"use strict";
+
+test(t => {
+ const handler = Object.create(null, {
+handleEvent: {
+ get: t.unreached_func('"handleEvent" property should not be looked up'),
+},
+ });
+
+ const el = document.createElement("div");
+ el._onmouseenter_ = handler;
+ el.dispatchEvent(new
[webkit-changes] [253066] trunk/Tools
Title: [253066] trunk/Tools
Revision 253066
Author jbed...@apple.com
Date 2019-12-03 15:25:05 -0800 (Tue, 03 Dec 2019)
Log Message
results.webkit.org: Decrease ttl for archives
https://bugs.webkit.org/show_bug.cgi?id=204806
Reviewed by Aakash Jain.
Make the ttl on the archive tables shorter, drop the existing table and create new ones
with a shorter ttl.
* resultsdbpy/resultsdbpy/model/archive_context.py:
(ArchiveContext.ArchiveMetaDataByCommit): Define new ArchiveMetaDataByCommit table.
(ArchiveContext.ArchiveChunks): Ditto.
* resultsdbpy/resultsdbpy/model/model.py:
(Model.__init__): Add archive ttl, 8 weeks by default.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py
trunk/Tools/resultsdbpy/resultsdbpy/model/model.py
Diff
Modified: trunk/Tools/ChangeLog (253065 => 253066)
--- trunk/Tools/ChangeLog 2019-12-03 23:17:44 UTC (rev 253065)
+++ trunk/Tools/ChangeLog 2019-12-03 23:25:05 UTC (rev 253066)
@@ -1,3 +1,20 @@
+2019-12-03 Jonathan Bedard
+
+results.webkit.org: Decrease ttl for archives
+https://bugs.webkit.org/show_bug.cgi?id=204806
+
+
+Reviewed by Aakash Jain.
+
+Make the ttl on the archive tables shorter, drop the existing table and create new ones
+with a shorter ttl.
+
+* resultsdbpy/resultsdbpy/model/archive_context.py:
+(ArchiveContext.ArchiveMetaDataByCommit): Define new ArchiveMetaDataByCommit table.
+(ArchiveContext.ArchiveChunks): Ditto.
+* resultsdbpy/resultsdbpy/model/model.py:
+(Model.__init__): Add archive ttl, 8 weeks by default.
+
2019-12-03 Christopher Reid
Regular _expression_ hangs in Safari only
Modified: trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py (253065 => 253066)
--- trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py 2019-12-03 23:17:44 UTC (rev 253065)
+++ trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py 2019-12-03 23:25:05 UTC (rev 253066)
@@ -52,7 +52,7 @@
MEMORY_LIMIT = 2 * 1024 * 1024 * 1024 # Don't allow more than 2 gigs of archives in memory at one time
class ArchiveMetaDataByCommit(ClusteredByConfiguration):
-__table_name__ = 'archive_metadata_by_commit'
+__table_name__ = 'archive_metadata_by_commit_01'
suite = columns.Text(partition_key=True, required=True)
branch = columns.Text(partition_key=True, required=True)
uuid = columns.BigInt(primary_key=True, required=True, clustering_order='DESC')
@@ -72,7 +72,7 @@
# According to https://cwiki.apache.org/confluence/display/CASSANDRA2/CassandraLimitations, we should shard
# large data blobs.
class ArchiveChunks(Model):
-__table_name__ = 'archive_chunks'
+__table_name__ = 'archive_chunks_01'
digest = columns.Text(partition_key=True, required=True)
index = columns.Integer(primary_key=True, required=True)
chunk = columns.Blob(required=True)
Modified: trunk/Tools/resultsdbpy/resultsdbpy/model/model.py (253065 => 253066)
--- trunk/Tools/resultsdbpy/resultsdbpy/model/model.py 2019-12-03 23:17:44 UTC (rev 253065)
+++ trunk/Tools/resultsdbpy/resultsdbpy/model/model.py 2019-12-03 23:25:05 UTC (rev 253066)
@@ -38,10 +38,13 @@
TTL_WEEK = 7 * TTL_DAY
TTL_YEAR = 365 * TTL_DAY
-def __init__(self, redis, cassandra, repositories=[], default_ttl_seconds=TTL_YEAR * 5, async_processing=False):
+def __init__(self, redis, cassandra, repositories=[], default_ttl_seconds=TTL_YEAR * 5, archive_ttl_seconds=TTL_WEEK * 8, async_processing=False):
if default_ttl_seconds is not None and default_ttl_seconds < 4 * self.TTL_WEEK:
raise ValueError('TTL must be at least 4 weeks')
+if archive_ttl_seconds is not None and archive_ttl_seconds < 2 * self.TTL_WEEK:
+raise ValueError('Archive TTL must be at least 2 weeks')
self.default_ttl_seconds = default_ttl_seconds
+self.archive_ttl_seconds = archive_ttl_seconds or default_ttl_seconds
self._async_processing = async_processing
self.redis = redis
@@ -84,7 +87,7 @@
self.archive_context = ArchiveContext(
configuration_context=self.configuration_context,
commit_context=self.commit_context,
-ttl_seconds=self.default_ttl_seconds,
+ttl_seconds=self.archive_ttl_seconds,
)
def do_work(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253065] trunk/Source/WebKit
Title: [253065] trunk/Source/WebKit
Revision 253065
Author cdu...@apple.com
Date 2019-12-03 15:17:44 -0800 (Tue, 03 Dec 2019)
Log Message
REGRESSION (r252778): ASSERT(!m_networkLoad); in ~SpeculativeLoad()
https://bugs.webkit.org/show_bug.cgi?id=204813
Reviewed by Antti Koivisto.
After r252778, SpeculativeLoadManager::revalidateSubresource() may delay the revalidation until we receive
the response for the main resource. We can hit the assertion in the SpeculativeLoad destructor if a speculative
revalidation for the SAME resource gets scheduled while we're waiting for the main resource response. When we
eventually receive the main resource response, we would call revalidateSubresource() again, which would create
a SpeculativeLoad and try to add it to m_pendingPreloads. Because m_pendingPreloads would already contain a
preload for this same resource, the SpeculativeLoad would not get added to the map and it would get destroyed
right away, before completing (thus hitting the assert). This unnecessary creation of the SpeculativeLoad is
inefficient and it is thus best to avoid it.
To address the issue, when we receive the response, we now make sure that m_pendingPreloads does not already
contain a preload for this resource before calling revalidateSubresource() again, similarly to what was
already done at the beginning of SpeculativeLoadManager::preloadEntry().
No new tests, unknown how to reproduce.
* NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateSubresource):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (253064 => 253065)
--- trunk/Source/WebKit/ChangeLog 2019-12-03 23:03:58 UTC (rev 253064)
+++ trunk/Source/WebKit/ChangeLog 2019-12-03 23:17:44 UTC (rev 253065)
@@ -1,3 +1,29 @@
+2019-12-03 Chris Dumez
+
+REGRESSION (r252778): ASSERT(!m_networkLoad); in ~SpeculativeLoad()
+https://bugs.webkit.org/show_bug.cgi?id=204813
+
+
+Reviewed by Antti Koivisto.
+
+After r252778, SpeculativeLoadManager::revalidateSubresource() may delay the revalidation until we receive
+the response for the main resource. We can hit the assertion in the SpeculativeLoad destructor if a speculative
+revalidation for the SAME resource gets scheduled while we're waiting for the main resource response. When we
+eventually receive the main resource response, we would call revalidateSubresource() again, which would create
+a SpeculativeLoad and try to add it to m_pendingPreloads. Because m_pendingPreloads would already contain a
+preload for this same resource, the SpeculativeLoad would not get added to the map and it would get destroyed
+right away, before completing (thus hitting the assert). This unnecessary creation of the SpeculativeLoad is
+inefficient and it is thus best to avoid it.
+
+To address the issue, when we receive the response, we now make sure that m_pendingPreloads does not already
+contain a preload for this resource before calling revalidateSubresource() again, similarly to what was
+already done at the beginning of SpeculativeLoadManager::preloadEntry().
+
+No new tests, unknown how to reproduce.
+
+* NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
+(WebKit::NetworkCache::SpeculativeLoadManager::revalidateSubresource):
+
2019-12-03 Eric Carlson
Add a runtime setting for media in the GPU process
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp (253064 => 253065)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp 2019-12-03 23:03:58 UTC (rev 253064)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp 2019-12-03 23:17:44 UTC (rev 253065)
@@ -486,6 +486,9 @@
if (pendingLoad && !pendingLoad->didReceiveMainResourceResponse() && subresourceInfo.isFirstParty()) {
preconnectForSubresource(subresourceInfo, entry.get(), frameID);
pendingLoad->addPostMainResourceResponseTask([this, subresourceInfo, entry = WTFMove(entry), frameID]() mutable {
+if (m_pendingPreloads.contains(subresourceInfo.key()))
+return;
+
revalidateSubresource(subresourceInfo, WTFMove(entry), frameID);
});
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253064] trunk/Source/WebCore
Title: [253064] trunk/Source/WebCore Revision 253064 Author jer.no...@apple.com Date 2019-12-03 15:03:58 -0800 (Tue, 03 Dec 2019) Log Message Adopt AVContentKeyReportGroup https://bugs.webkit.org/show_bug.cgi?id=204765 Reviewed by Eric Carlson. Source/WebCore: Adopt a new class, AVContentKeyReportGroup, which allows muliple MediaKeySessions to share an AVContentKeySession, while allowing independent expiration and persistent key usage tokens. However, this has to be runtime detected, so that existing usage of AVContentKeySession continues to work on platform versions without report group support. * WebCore.xcodeproj/project.pbxproj: * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: * platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (-[WebCoreFPSContentKeySessionDelegate initWithParent:]): (-[WebCoreFPSContentKeySessionDelegate contentKeySession:contentProtectionSessionIdentifierDidChangeForKeyGroup:]): (-[WebCoreFPSContentKeySessionDelegate contentKeySession:contentProtectionSessionIdentifierDidChangeForReportGroup:]): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::ensureSession): (WebCore::groupForRequest): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequests): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRenewingRequest): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvidePersistableRequest): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::didFailToProvideRequest): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::requestDidSucceed): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::shouldRetryRequestForReason): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionIdentifierChanged): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::groupSessionIdentifierChanged): (WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForGroup const): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::CDMInstanceSessionFairPlayStreamingAVFObjC): (WebCore::initTypeForRequest): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::groupSessionIdentifierChanged): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSessionOrGroup): (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession): Deleted. Source/WebCore/PAL: * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: * pal/spi/mac/AVFoundationSPI.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm trunk/Source/WebCore/PAL/pal/spi/mac/AVFoundationSPI.h trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm Diff Modified: trunk/Source/WebCore/ChangeLog (253063 => 253064) --- trunk/Source/WebCore/ChangeLog 2019-12-03 22:56:46 UTC (rev 253063) +++ trunk/Source/WebCore/ChangeLog 2019-12-03 23:03:58 UTC (rev 253064) @@ -1,3 +1,42 @@ +2019-12-03 Jer Noble + +Adopt AVContentKeyReportGroup +https://bugs.webkit.org/show_bug.cgi?id=204765 + +Reviewed by Eric Carlson. + +Adopt a new class, AVContentKeyReportGroup, which allows muliple MediaKeySessions to share +an AVContentKeySession, while allowing independent expiration and persistent key usage +tokens. However, this has to be runtime detected, so that existing usage of +AVContentKeySession continues to work on platform versions without report group support. + +* WebCore.xcodeproj/project.pbxproj: +* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h: +* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: +(-[WebCoreFPSContentKeySessionDelegate initWithParent:]): +(-[WebCoreFPSContentKeySessionDelegate contentKeySession:contentProtectionSessionIdentifierDidChangeForKeyGroup:]): +(-[WebCoreFPSContentKeySessionDelegate contentKeySession:contentProtectionSessionIdentifierDidChangeForReportGroup:]): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::CDMInstanceFairPlayStreamingAVFObjC): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::ensureSession): +(WebCore::groupForRequest): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequests): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRenewingRequest): +(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvidePersistableRequest): +
[webkit-changes] [253063] trunk/Source
Title: [253063] trunk/Source
Revision 253063
Author eric.carl...@apple.com
Date 2019-12-03 14:56:46 -0800 (Tue, 03 Dec 2019)
Log Message
Add a runtime setting for media in the GPU process
https://bugs.webkit.org/show_bug.cgi?id=204801
Reviewed by Jer Noble.
Source/WebCore:
* page/Settings.yaml:
Source/WebKit:
* Shared/WebPreferences.yaml:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Source/WebKitLegacy/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences outOfProcessMediaEnabled]):
(-[WebPreferences setOutOfProcessMediaEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.yaml
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (253062 => 253063)
--- trunk/Source/WebCore/ChangeLog 2019-12-03 22:35:42 UTC (rev 253062)
+++ trunk/Source/WebCore/ChangeLog 2019-12-03 22:56:46 UTC (rev 253063)
@@ -1,3 +1,13 @@
+2019-12-03 Eric Carlson
+
+Add a runtime setting for media in the GPU process
+https://bugs.webkit.org/show_bug.cgi?id=204801
+
+
+Reviewed by Jer Noble.
+
+* page/Settings.yaml:
+
2019-12-03 Jer Noble
Experimental support for HDR media query
Modified: trunk/Source/WebCore/page/Settings.yaml (253062 => 253063)
--- trunk/Source/WebCore/page/Settings.yaml 2019-12-03 22:35:42 UTC (rev 253062)
+++ trunk/Source/WebCore/page/Settings.yaml 2019-12-03 22:56:46 UTC (rev 253063)
@@ -320,6 +320,9 @@
genericCueAPIEnabled:
initial: false
conditional: VIDEO_TRACK
+outOfProcessMediaEnabled:
+initial: false
+conditional: VIDEO
scrollingCoordinatorEnabled:
initial: false
scrollingTreeIncludesFrames:
Modified: trunk/Source/WebKit/ChangeLog (253062 => 253063)
--- trunk/Source/WebKit/ChangeLog 2019-12-03 22:35:42 UTC (rev 253062)
+++ trunk/Source/WebKit/ChangeLog 2019-12-03 22:56:46 UTC (rev 253063)
@@ -1,3 +1,15 @@
+2019-12-03 Eric Carlson
+
+Add a runtime setting for media in the GPU process
+https://bugs.webkit.org/show_bug.cgi?id=204801
+
+
+Reviewed by Jer Noble.
+
+* Shared/WebPreferences.yaml:
+* WebProcess/InjectedBundle/InjectedBundle.cpp:
+(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+
2019-12-03 Per Arne Vollan
Unreviewed assertion fix for older macOS versions after r253011.
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (253062 => 253063)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-12-03 22:35:42 UTC (rev 253062)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-12-03 22:56:46 UTC (rev 253063)
@@ -1837,6 +1837,15 @@
humanReadableName: "Remote Playback API"
humanReadableDescription: "Enable Remote Playback API"
+OutOfProcessMediaEnabled:
+type: bool
+defaultValue: false
+condition: ENABLE(VIDEO)
+humanReadableName: "Media in GPU process"
+humanReadableDescription: "Do all media loading and playback in the GPU process"
+category: experimental
+webcoreName: outOfProcessMediaEnabled
+
# Deprecated
ICECandidateFilteringEnabled:
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp (253062 => 253063)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp 2019-12-03 22:35:42 UTC (rev 253062)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp 2019-12-03 22:56:46 UTC (rev 253063)
@@ -247,6 +247,15 @@
}
#endif
+#if ENABLE(VIDEO)
+if (preference == "WebKitOutOfProcessMediaEnabled") {
+WebPreferencesStore::overrideBoolValueForKey(WebPreferencesKey::imageControlsEnabledKey(), enabled);
+for (auto* page : pages)
+page->settings().setOutOfProcessMediaEnabled(enabled);
+return;
+}
+#endif
+
if (preference == "WebKitIsSecureContextAttributeEnabled") {
WebPreferencesStore::overrideBoolValueForKey(WebPreferencesKey::isSecureContextAttributeEnabledKey(), enabled);
RuntimeEnabledFeatures::sharedFeatures().setIsSecureContextAttributeEnabled(enabled);
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (253062 => 253063)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2019-12-03 22:35:42 UTC (rev 253062)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2019-12-03 22:56:46 UTC (rev 253063)
@@ -1,3 +1,20 @@
+2019-12-03 Eric Carlson
+
+Add a runtime setting for media in the
[webkit-changes] [253062] trunk/Source/WebCore
Title: [253062] trunk/Source/WebCore
Revision 253062
Author jer.no...@apple.com
Date 2019-12-03 14:35:42 -0800 (Tue, 03 Dec 2019)
Log Message
Experimental support for HDR media query
https://bugs.webkit.org/show_bug.cgi?id=204422
Reviewed by Eric Carlson.
Follow-up to r252762 for platforms that don't have MediaToolbox.framework.
* platform/ios/PlatformScreenIOS.mm:
(WebCore::screenSupportsHighDynamicRange):
* platform/mac/PlatformScreenMac.mm:
(WebCore::collectScreenProperties):
(WebCore::screenSupportsHighDynamicRange):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm
trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (253061 => 253062)
--- trunk/Source/WebCore/ChangeLog 2019-12-03 22:07:14 UTC (rev 253061)
+++ trunk/Source/WebCore/ChangeLog 2019-12-03 22:35:42 UTC (rev 253062)
@@ -1,3 +1,19 @@
+2019-12-03 Jer Noble
+
+Experimental support for HDR media query
+https://bugs.webkit.org/show_bug.cgi?id=204422
+
+
+Reviewed by Eric Carlson.
+
+Follow-up to r252762 for platforms that don't have MediaToolbox.framework.
+
+* platform/ios/PlatformScreenIOS.mm:
+(WebCore::screenSupportsHighDynamicRange):
+* platform/mac/PlatformScreenMac.mm:
+(WebCore::collectScreenProperties):
+(WebCore::screenSupportsHighDynamicRange):
+
2019-12-03 Tim Horton
Start adding encoding support for DisplayList and some DisplayListItems
Modified: trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm (253061 => 253062)
--- trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm 2019-12-03 22:07:14 UTC (rev 253061)
+++ trunk/Source/WebCore/platform/ios/PlatformScreenIOS.mm 2019-12-03 22:35:42 UTC (rev 253062)
@@ -75,7 +75,7 @@
bool screenSupportsHighDynamicRange(Widget*)
{
#if USE(MEDIATOOLBOX)
-if (PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
return PAL::softLink_MediaToolbox_MTShouldPlayHDRVideo(nullptr);
#endif
return false;
Modified: trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm (253061 => 253062)
--- trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm 2019-12-03 22:07:14 UTC (rev 253061)
+++ trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm 2019-12-03 22:35:42 UTC (rev 253062)
@@ -135,7 +135,7 @@
bool screenSupportsHighDynamicRange = false;
#if USE(MEDIATOOLBOX)
-if (PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
screenSupportsHighDynamicRange = PAL::softLink_MediaToolbox_MTShouldPlayHDRVideo((__bridge CFArrayRef)@[ @(displayID) ]);
#endif
@@ -365,7 +365,7 @@
ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
#if USE(MEDIATOOLBOX)
-if (PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo()) {
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo()) {
auto displayID = WebCore::displayID(screen(widget));
return PAL::softLink_MediaToolbox_MTShouldPlayHDRVideo((__bridge CFArrayRef)@[ @(displayID) ]);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253060] trunk/Tools
Title: [253060] trunk/Tools Revision 253060 Author jbed...@apple.com Date 2019-12-03 12:34:59 -0800 (Tue, 03 Dec 2019) Log Message https://bugs.webkit.org/show_bug.cgi?id=204804 Reviewed by Tim Horton. * Scripts/webkitpy/port/mac.py: (MacCatalystPort): (MacCatalystPort._build_driver_flags): Add SDKVARIANT=iosmac to build flags. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/mac.py Diff Modified: trunk/Tools/ChangeLog (253059 => 253060) --- trunk/Tools/ChangeLog 2019-12-03 20:12:59 UTC (rev 253059) +++ trunk/Tools/ChangeLog 2019-12-03 20:34:59 UTC (rev 253060) @@ -1,3 +1,14 @@ +2019-12-03 Jonathan Bedard + +https://bugs.webkit.org/show_bug.cgi?id=204804 + + +Reviewed by Tim Horton. + +* Scripts/webkitpy/port/mac.py: +(MacCatalystPort): +(MacCatalystPort._build_driver_flags): Add SDKVARIANT=iosmac to build flags. + 2019-12-03 Antoine Quint [Web Animations] Add a runtime flag for Web Animations composite operations Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (253059 => 253060) --- trunk/Tools/Scripts/webkitpy/port/mac.py 2019-12-03 20:12:59 UTC (rev 253059) +++ trunk/Tools/Scripts/webkitpy/port/mac.py 2019-12-03 20:34:59 UTC (rev 253060) @@ -292,3 +292,6 @@ def __init__(self, *args, **kwargs): super(MacCatalystPort, self).__init__(*args, **kwargs) self._config = Config(self._executive, self._filesystem, MacCatalystPort.port_name) + +def _build_driver_flags(self): +return ['SDK_VARIANT=iosmac'] + super(MacCatalystPort, self)._build_driver_flags() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253059] trunk/Source/WebKit
Title: [253059] trunk/Source/WebKit
Revision 253059
Author pvol...@apple.com
Date 2019-12-03 12:12:59 -0800 (Tue, 03 Dec 2019)
Log Message
Unreviewed assertion fix for older macOS versions after r253011.
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
* UIProcess/UserMediaPermissionRequestManagerProxy.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (253058 => 253059)
--- trunk/Source/WebKit/ChangeLog 2019-12-03 20:06:51 UTC (rev 253058)
+++ trunk/Source/WebKit/ChangeLog 2019-12-03 20:12:59 UTC (rev 253059)
@@ -1,3 +1,11 @@
+2019-12-03 Per Arne Vollan
+
+Unreviewed assertion fix for older macOS versions after r253011.
+
+* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
+* UIProcess/UserMediaPermissionRequestManagerProxy.h:
+
2019-12-03 Antoine Quint
[Web Animations] Add a runtime flag for Web Animations composite operations
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (253058 => 253059)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2019-12-03 20:06:51 UTC (rev 253058)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2019-12-03 20:12:59 UTC (rev 253059)
@@ -241,7 +241,7 @@
++m_hasPendingCapture;
SandboxExtension::Handle handle;
-#if PLATFORM(COCOA)
+#if HAVE(SANDBOX_ISSUE_MACH_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN)
if (!m_hasCreatedSandboxExtensionForTCCD) {
SandboxExtension::createHandleForMachLookup("com.apple.tccd", m_page.process().connection()->getAuditToken(), handle);
m_hasCreatedSandboxExtensionForTCCD = true;
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h (253058 => 253059)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h 2019-12-03 20:06:51 UTC (rev 253058)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h 2019-12-03 20:12:59 UTC (rev 253059)
@@ -154,7 +154,7 @@
const void* m_logIdentifier;
#endif
bool m_hasFilteredDeviceList { false };
-#if PLATFORM(COCOA)
+#if HAVE(SANDBOX_ISSUE_MACH_EXTENSION_TO_PROCESS_BY_AUDIT_TOKEN)
bool m_hasCreatedSandboxExtensionForTCCD { false };
#endif
uint64_t m_hasPendingCapture { 0 };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253058] trunk/Source/WebCore
Title: [253058] trunk/Source/WebCore
Revision 253058
Author timothy_hor...@apple.com
Date 2019-12-03 12:06:51 -0800 (Tue, 03 Dec 2019)
Log Message
Start adding encoding support for DisplayList and some DisplayListItems
https://bugs.webkit.org/show_bug.cgi?id=204740
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContextStateChange::changesFromState const):
* platform/graphics/GraphicsContext.h:
Remove GraphicsContextState::NoChange, which is not needed with OptionSet
and in fact causes assertions to fire.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (253057 => 253058)
--- trunk/Source/WebCore/ChangeLog 2019-12-03 19:33:25 UTC (rev 253057)
+++ trunk/Source/WebCore/ChangeLog 2019-12-03 20:06:51 UTC (rev 253058)
@@ -1,3 +1,14 @@
+2019-12-03 Tim Horton
+
+Start adding encoding support for DisplayList and some DisplayListItems
+https://bugs.webkit.org/show_bug.cgi?id=204740
+
+* platform/graphics/GraphicsContext.cpp:
+(WebCore::GraphicsContextStateChange::changesFromState const):
+* platform/graphics/GraphicsContext.h:
+Remove GraphicsContextState::NoChange, which is not needed with OptionSet
+and in fact causes assertions to fire.
+
2019-12-03 Antoine Quint
[Web Animations] Add a runtime flag for Web Animations composite operations
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (253057 => 253058)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2019-12-03 19:33:25 UTC (rev 253057)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2019-12-03 20:06:51 UTC (rev 253058)
@@ -77,7 +77,7 @@
GraphicsContextState::StateChangeFlags GraphicsContextStateChange::changesFromState(const GraphicsContextState& state) const
{
-GraphicsContextState::StateChangeFlags changeFlags = GraphicsContextState::NoChange;
+GraphicsContextState::StateChangeFlags changeFlags;
CHECK_FOR_CHANGED_PROPERTY(StrokeGradientChange, strokeGradient);
CHECK_FOR_CHANGED_PROPERTY(StrokePatternChange, strokePattern);
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (253057 => 253058)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2019-12-03 19:33:25 UTC (rev 253057)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2019-12-03 20:06:51 UTC (rev 253058)
@@ -146,7 +146,6 @@
}
enum Change : uint32_t {
-NoChange= 0,
StrokeGradientChange= 1 << 1,
StrokePatternChange = 1 << 2,
FillGradientChange = 1 << 3,
@@ -228,7 +227,7 @@
void dump(WTF::TextStream&) const;
GraphicsContextState m_state;
-GraphicsContextState::StateChangeFlags m_changeFlags { GraphicsContextState::NoChange };
+GraphicsContextState::StateChangeFlags m_changeFlags;
};
WTF::TextStream& operator<<(WTF::TextStream&, const GraphicsContextStateChange&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [253057] tags/Safari-609.1.11/Source/WebCore
Title: [253057] tags/Safari-609.1.11/Source/WebCore
Revision 253057
Author alanc...@apple.com
Date 2019-12-03 11:33:25 -0800 (Tue, 03 Dec 2019)
Log Message
Cherry-pick r252956. rdar://problem/57438874
MockAudioSharedUnit should reset its last render time on start/stop/reconfigure
https://bugs.webkit.org/show_bug.cgi?id=204600
Reviewed by Eric Carlson.
MockAudioSharedUnit was not resetting its last render time on stop/start/reconfigure.
If stopping for a long time and then restarting, the unit would flood the audio pipe with lots of data
and confuse the pipe.
Remove some member variables inherited from MockRealtimeAudioSource which are no longer needed.
Covered by imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html being no longer flaky.
* platform/mediastream/mac/MockAudioSharedUnit.h:
* platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedUnit::reconfigureAudioUnit):
(WebCore::MockAudioSharedUnit::startInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
tags/Safari-609.1.11/Source/WebCore/ChangeLog
tags/Safari-609.1.11/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h
tags/Safari-609.1.11/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
Diff
Modified: tags/Safari-609.1.11/Source/WebCore/ChangeLog (253056 => 253057)
--- tags/Safari-609.1.11/Source/WebCore/ChangeLog 2019-12-03 19:28:31 UTC (rev 253056)
+++ tags/Safari-609.1.11/Source/WebCore/ChangeLog 2019-12-03 19:33:25 UTC (rev 253057)
@@ -1,3 +1,48 @@
+2019-12-03 Alan Coon
+
+Cherry-pick r252956. rdar://problem/57438874
+
+MockAudioSharedUnit should reset its last render time on start/stop/reconfigure
+https://bugs.webkit.org/show_bug.cgi?id=204600
+
+
+Reviewed by Eric Carlson.
+
+MockAudioSharedUnit was not resetting its last render time on stop/start/reconfigure.
+If stopping for a long time and then restarting, the unit would flood the audio pipe with lots of data
+and confuse the pipe.
+Remove some member variables inherited from MockRealtimeAudioSource which are no longer needed.
+
+Covered by imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html being no longer flaky.
+
+* platform/mediastream/mac/MockAudioSharedUnit.h:
+* platform/mediastream/mac/MockAudioSharedUnit.mm:
+(WebCore::MockAudioSharedUnit::reconfigureAudioUnit):
+(WebCore::MockAudioSharedUnit::startInternal):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-11-30 youenn fablet
+
+MockAudioSharedUnit should reset its last render time on start/stop/reconfigure
+https://bugs.webkit.org/show_bug.cgi?id=204600
+
+
+Reviewed by Eric Carlson.
+
+MockAudioSharedUnit was not resetting its last render time on stop/start/reconfigure.
+If stopping for a long time and then restarting, the unit would flood the audio pipe with lots of data
+and confuse the pipe.
+Remove some member variables inherited from MockRealtimeAudioSource which are no longer needed.
+
+Covered by imported/w3c/web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.https.html being no longer flaky.
+
+* platform/mediastream/mac/MockAudioSharedUnit.h:
+* platform/mediastream/mac/MockAudioSharedUnit.mm:
+(WebCore::MockAudioSharedUnit::reconfigureAudioUnit):
+(WebCore::MockAudioSharedUnit::startInternal):
+
2019-12-02 Alan Coon
Cherry-pick r252935. rdar://problem/45311541
Modified: tags/Safari-609.1.11/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h (253056 => 253057)
--- tags/Safari-609.1.11/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h 2019-12-03 19:28:31 UTC (rev 253056)
+++ tags/Safari-609.1.11/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h 2019-12-03 19:33:25 UTC (rev 253057)
@@ -82,9 +82,7 @@
bool m_hasAudioUnit { false };
RunLoop::Timer m_timer;
-MonotonicTime m_startTime { MonotonicTime::nan() };
MonotonicTime m_lastRenderTime { MonotonicTime::nan() };
-Seconds m_elapsedTime { 0_s };
MonotonicTime m_delayUntil;
Ref m_workQueue;
Modified: tags/Safari-609.1.11/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm (253056 => 253057)
--- tags/Safari-609.1.11/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm 2019-12-03 19:28:31 UTC (rev 253056)
+++ tags/Safari-609.1.11/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm 2019-12-03 19:33:25 UTC (rev 253057)
@@ -128,11 +128,11 @@
return 0;
m_timer.stop();
-m_startTime = MonotonicTime::nan();
+m_lastRenderTime =
[webkit-changes] [253056] trunk
Title: [253056] trunk Revision 253056 Author commit-qu...@webkit.org Date 2019-12-03 11:28:31 -0800 (Tue, 03 Dec 2019) Log Message [Web Animations] Add a runtime flag for Web Animations composite operations https://bugs.webkit.org/show_bug.cgi?id=204718 Patch by Antoine Quint on 2019-12-03 Reviewed by Dean Jackson. Source/WebCore: While we support parsing and output of composite modes via KeyframeEffect::getKeyframes(), we don't support them for blending properties. We now have a runtime flag for that feature so that we can continue working on it but not necessarily expose the feature by default. * animation/KeyframeEffect.cpp: (WebCore::processKeyframeLikeObject): (WebCore::processIterableKeyframes): (WebCore::processPropertyIndexedKeyframes): (WebCore::KeyframeEffect::getKeyframes): * animation/KeyframeEffect.idl: * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebAnimationsCompositeOperationsEnabled): (WebCore::RuntimeEnabledFeatures::webAnimationsCompositeOperationsEnabled const): Source/WebKit: * Shared/WebPreferences.yaml: Source/WebKitLegacy/mac: * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (-[WebPreferences webAnimationsCompositeOperationsEnabled]): (-[WebPreferences setWebAnimationsCompositeOperationsEnabled:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Source/WebKitLegacy/win: * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::setWebAnimationsCompositeOperationsEnabled): (WebPreferences::webAnimationsCompositeOperationsEnabled): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): Tools: * DumpRenderTree/mac/DumpRenderTree.mm: (enableExperimentalFeatures): * DumpRenderTree/win/DumpRenderTree.cpp: (enableExperimentalFeatures): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/KeyframeEffect.cpp trunk/Source/WebCore/animation/KeyframeEffect.idl trunk/Source/WebCore/page/RuntimeEnabledFeatures.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferences.yaml trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h trunk/Source/WebKitLegacy/mac/WebView/WebView.mm trunk/Source/WebKitLegacy/win/ChangeLog trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl trunk/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h trunk/Source/WebKitLegacy/win/WebPreferences.cpp trunk/Source/WebKitLegacy/win/WebPreferences.h trunk/Source/WebKitLegacy/win/WebView.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (253055 => 253056) --- trunk/Source/WebCore/ChangeLog 2019-12-03 19:08:40 UTC (rev 253055) +++ trunk/Source/WebCore/ChangeLog 2019-12-03 19:28:31 UTC (rev 253056) @@ -1,3 +1,23 @@ +2019-12-03 Antoine Quint + +[Web Animations] Add a runtime flag for Web Animations composite operations +https://bugs.webkit.org/show_bug.cgi?id=204718 + +Reviewed by Dean Jackson. + +While we support parsing and output of composite modes via KeyframeEffect::getKeyframes(), we don't support them for blending properties. +We now have a runtime flag for that feature so that we can continue working on it but not necessarily expose the feature by default. + +* animation/KeyframeEffect.cpp: +(WebCore::processKeyframeLikeObject): +(WebCore::processIterableKeyframes): +(WebCore::processPropertyIndexedKeyframes): +(WebCore::KeyframeEffect::getKeyframes): +* animation/KeyframeEffect.idl: +* page/RuntimeEnabledFeatures.h: +(WebCore::RuntimeEnabledFeatures::setWebAnimationsCompositeOperationsEnabled): +(WebCore::RuntimeEnabledFeatures::webAnimationsCompositeOperationsEnabled const): + 2019-12-03 Joonghun Park Unreviewed. Remove build warning below since r252987. Modified: trunk/Source/WebCore/animation/KeyframeEffect.cpp (253055 => 253056) --- trunk/Source/WebCore/animation/KeyframeEffect.cpp 2019-12-03 19:08:40 UTC (rev 253055) +++ trunk/Source/WebCore/animation/KeyframeEffect.cpp 2019-12-03 19:28:31 UTC (rev 253056) @@ -49,6 +49,7 @@ #include "RenderBoxModelObject.h" #include "RenderElement.h" #include "RenderStyle.h" +#include "RuntimeEnabledFeatures.h" #include "StylePendingResources.h" #include "StyleResolver.h" #include "TimingFunction.h" @@ -196,7 +197,8 @@ else baseProperties.offset = nullptr; baseProperties.easing = baseKeyframe.easing; -baseProperties.composite = baseKeyframe.composite; +if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCompositeOperationsEnabled()) +
[webkit-changes] [253055] trunk/Source/WebKit
Title: [253055] trunk/Source/WebKit
Revision 253055
Author you...@apple.com
Date 2019-12-03 11:08:40 -0800 (Tue, 03 Dec 2019)
Log Message
UserMediaCaptureManager should have independent capture factories
https://bugs.webkit.org/show_bug.cgi?id=204786
Reviewed by Eric Carlson.
Refactor the code to make UserMediaCaptureManager have 3 different factories.
This allows having 3 potential active sources which are used on iOS.
We cannot test right now on iOS as audio capture in UIProcess is not yet ready.
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::Source):
(WebKit::UserMediaCaptureManager::Source::~Source):
(WebKit::UserMediaCaptureManager::UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::~UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::initialize):
(WebKit::UserMediaCaptureManager::createCaptureSource):
(WebKit::UserMediaCaptureManager::AudioFactory::setAudioCapturePageState):
(WebKit::UserMediaCaptureManager::VideoFactory::setVideoCapturePageState):
(WebKit::UserMediaCaptureManager::setAudioCapturePageState): Deleted.
(WebKit::UserMediaCaptureManager::setVideoCapturePageState): Deleted.
* WebProcess/cocoa/UserMediaCaptureManager.h:
(WebKit::UserMediaCaptureManager::AudioFactory::AudioFactory):
(WebKit::UserMediaCaptureManager::VideoFactory::VideoFactory):
(WebKit::UserMediaCaptureManager::DisplayFactory::DisplayFactory):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (253054 => 253055)
--- trunk/Source/WebKit/ChangeLog 2019-12-03 18:39:36 UTC (rev 253054)
+++ trunk/Source/WebKit/ChangeLog 2019-12-03 19:08:40 UTC (rev 253055)
@@ -1,3 +1,30 @@
+2019-12-03 Youenn Fablet
+
+UserMediaCaptureManager should have independent capture factories
+https://bugs.webkit.org/show_bug.cgi?id=204786
+
+Reviewed by Eric Carlson.
+
+Refactor the code to make UserMediaCaptureManager have 3 different factories.
+This allows having 3 potential active sources which are used on iOS.
+We cannot test right now on iOS as audio capture in UIProcess is not yet ready.
+
+* WebProcess/cocoa/UserMediaCaptureManager.cpp:
+(WebKit::UserMediaCaptureManager::Source::Source):
+(WebKit::UserMediaCaptureManager::Source::~Source):
+(WebKit::UserMediaCaptureManager::UserMediaCaptureManager):
+(WebKit::UserMediaCaptureManager::~UserMediaCaptureManager):
+(WebKit::UserMediaCaptureManager::initialize):
+(WebKit::UserMediaCaptureManager::createCaptureSource):
+(WebKit::UserMediaCaptureManager::AudioFactory::setAudioCapturePageState):
+(WebKit::UserMediaCaptureManager::VideoFactory::setVideoCapturePageState):
+(WebKit::UserMediaCaptureManager::setAudioCapturePageState): Deleted.
+(WebKit::UserMediaCaptureManager::setVideoCapturePageState): Deleted.
+* WebProcess/cocoa/UserMediaCaptureManager.h:
+(WebKit::UserMediaCaptureManager::AudioFactory::AudioFactory):
+(WebKit::UserMediaCaptureManager::VideoFactory::VideoFactory):
+(WebKit::UserMediaCaptureManager::DisplayFactory::DisplayFactory):
+
2019-12-03 Chris Dumez
PageConfiguration::pluginClient should use a smart pointer
Modified: trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp (253054 => 253055)
--- trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp 2019-12-03 18:39:36 UTC (rev 253054)
+++ trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp 2019-12-03 19:08:40 UTC (rev 253055)
@@ -62,19 +62,45 @@
, m_manager(manager)
, m_deviceType(deviceType)
{
-ASSERT(deviceType != CaptureDevice::DeviceType::Unknown);
-if (type == Type::Audio)
+switch (m_deviceType) {
+case CaptureDevice::DeviceType::Microphone:
m_ringBuffer = makeUnique(makeUniqueRef(nullptr));
+#if PLATFORM(IOS_FAMILY)
+RealtimeMediaSourceCenter::singleton().audioCaptureFactory().setActiveSource(*this);
+#endif
+break;
+case CaptureDevice::DeviceType::Camera:
+#if PLATFORM(IOS_FAMILY)
+RealtimeMediaSourceCenter::singleton().videoCaptureFactory().setActiveSource(*this);
+#endif
+break;
+case CaptureDevice::DeviceType::Screen:
+case CaptureDevice::DeviceType::Window:
+break;
+case CaptureDevice::DeviceType::Unknown:
+ASSERT_NOT_REACHED();
+}
}
~Source()
{
-if (type() == Type::Audio)
+switch (m_deviceType) {
+case CaptureDevice::DeviceType::Microphone:
storage().invalidate();
-else if (type() == Type::Video) {
#if PLATFORM(IOS_FAMILY)
+RealtimeMediaSourceCenter::singleton().audioCaptureFactory().unsetActiveSource(*this);
[webkit-changes] [253054] trunk/LayoutTests
Title: [253054] trunk/LayoutTests
Revision 253054
Author wenson_hs...@apple.com
Date 2019-12-03 10:39:36 -0800 (Tue, 03 Dec 2019)
Log Message
fast/events/touch/ios/passive-by-default-on-document-and-window.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=204797
Reviewed by Tim Horton.
Fix the layout test by waiting for touchend events before finishing the test, such that passive touchend events
that were queued up via `EventDispatcher::touchEvent` have a chance to be dispatched to the page. Also, make the
test a bit more modern by replacing the UI script in the test with a call to a UIHelper method.
* fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt:
* fast/events/touch/ios/passive-by-default-on-document-and-window.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt
trunk/LayoutTests/fast/events/touch/ios/passive-by-default-on-document-and-window.html
Diff
Modified: trunk/LayoutTests/ChangeLog (253053 => 253054)
--- trunk/LayoutTests/ChangeLog 2019-12-03 18:24:48 UTC (rev 253053)
+++ trunk/LayoutTests/ChangeLog 2019-12-03 18:39:36 UTC (rev 253054)
@@ -1,3 +1,18 @@
+2019-12-03 Wenson Hsieh
+
+fast/events/touch/ios/passive-by-default-on-document-and-window.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=204797
+
+
+Reviewed by Tim Horton.
+
+Fix the layout test by waiting for touchend events before finishing the test, such that passive touchend events
+that were queued up via `EventDispatcher::touchEvent` have a chance to be dispatched to the page. Also, make the
+test a bit more modern by replacing the UI script in the test with a call to a UIHelper method.
+
+* fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt:
+* fast/events/touch/ios/passive-by-default-on-document-and-window.html:
+
2019-12-03 youenn fablet
Add support for camera rotation when capturing in UIProcess
Modified: trunk/LayoutTests/fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt (253053 => 253054)
--- trunk/LayoutTests/fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt 2019-12-03 18:24:48 UTC (rev 253053)
+++ trunk/LayoutTests/fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt 2019-12-03 18:39:36 UTC (rev 253054)
@@ -1,9 +1,18 @@
-touchstart on body - cancelable: false defaultPrevented: false
-touchstart on documentElement - cancelable: false defaultPrevented: false
-touchstart on document - cancelable: false defaultPrevented: false
-touchstart on window - cancelable: false defaultPrevented: false
-touchend on body - cancelable: false defaultPrevented: false
-touchend on documentElement - cancelable: false defaultPrevented: false
-touchend on document - cancelable: false defaultPrevented: false
-touchend on window - cancelable: false defaultPrevented: false
-Done
+This test verifies that touchstart and touchend event listeners are passive by default on document, window, documentElement, and body. This test requires WebKitTestRunner.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS touchstart on body - cancelable: false defaultPrevented: false
+PASS touchstart on documentElement - cancelable: false defaultPrevented: false
+PASS touchstart on document - cancelable: false defaultPrevented: false
+PASS touchstart on window - cancelable: false defaultPrevented: false
+PASS touchend on body - cancelable: false defaultPrevented: false
+PASS touchend on documentElement - cancelable: false defaultPrevented: false
+PASS touchend on document - cancelable: false defaultPrevented: false
+PASS touchend on window - cancelable: false defaultPrevented: false
+PASS touchEndEventCount became 4
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: trunk/LayoutTests/fast/events/touch/ios/passive-by-default-on-document-and-window.html (253053 => 253054)
--- trunk/LayoutTests/fast/events/touch/ios/passive-by-default-on-document-and-window.html 2019-12-03 18:24:48 UTC (rev 253053)
+++ trunk/LayoutTests/fast/events/touch/ios/passive-by-default-on-document-and-window.html 2019-12-03 18:39:36 UTC (rev 253054)
@@ -1,50 +1,42 @@
+