[webkit-changes] [253739] trunk/Source

[drousso]

Title: [253739] trunk/Source








Revision 253739
Author drou...@apple.com
Date 2019-12-18 23:35:28 -0800 (Wed, 18 Dec 2019)


Log Message
Web Inspector: Elements: restrict showing paint flashing and compositing borders to the Web Inspector session
https://bugs.webkit.org/show_bug.cgi?id=205201

Reviewed by Timothy Hatcher.

We often get bugs from users who turn on paint flashing or compositing borders, close Web
Inspector, reopen Web Inspector, and are then surprised when the page flashes red or these
borders exist all over the page.

Given that the dark mode and print styles toggles are limited to the Web Inspector session,
we should make these have the same behavior.

Source/_javascript_Core:

* inspector/protocol/Page.json:
Allow Web Inspector to override the `showDebugBorders` and `showRepaintCounter` settings via
the `inspectorOverride` key, rather than setting them manually via a special `Page` command.

Source/WebCore:

* page/Settings.yaml:
* inspector/agents/InspectorPageAgent.h:
* inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCompositingBordersVisible): Deleted.
(WebCore::InspectorPageAgent::setCompositingBordersVisible): Deleted.
Allow Web Inspector to override the `showDebugBorders` and `showRepaintCounter` settings via
the `inspectorOverride` key, rather than setting them manually via a special `Page` command.

Source/WebInspectorUI:

* UserInterface/Base/Main.js:
(WI.initializeTarget):
* UserInterface/Base/Setting.js:
* UserInterface/Controllers/LayerTreeManager.js:
(WI.LayerTreeManager): Added.
(WI.LayerTreeManager.prototype.initializeTarget):
(WI.LayerTreeManager.supportsShowingPaintRects): Added.
(WI.LayerTreeManager.supportsVisibleCompositingBorders): Added.
(WI.LayerTreeManager.prototype.get showPaintRects): Added.
(WI.LayerTreeManager.prototype.set showPaintRects): Added.
(WI.LayerTreeManager.prototype.get compositingBordersVisible): Added.
(WI.LayerTreeManager.prototype.set compositingBordersVisible): Added.
(WI.LayerTreeManager.prototype.updateCompositingBordersVisibleFromPageIfNeeded): Added.
Use `WI.LayerTreeManager` to control the state of paint flashing and compositing borders, as
they're both related to the concept of layers.

* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView):
(WI.DOMTreeContentView.prototype.shown):
(WI.DOMTreeContentView.prototype.closed):
(WI.DOMTreeContentView.prototype.attached): Added.
(WI.DOMTreeContentView.prototype.detached): Added.
(WI.DOMTreeContentView.prototype._handleCompositingBordersVisibleChanged): Added.
(WI.DOMTreeContentView.prototype._handleCompositingBordersButtonClicked): Added.
(WI.DOMTreeContentView.prototype._handleShowPaintRectsChanged): Added.
(WI.DOMTreeContentView.prototype._handlePaingFlashingButtonClicked): Added.
(WI.DOMTreeContentView.prototype._toggleCompositingBorders): Deleted.
(WI.DOMTreeContentView.prototype._togglePaintFlashing): Deleted.
(WI.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings): Deleted.
(WI.DOMTreeContentView.prototype._showPaintRectsSettingChanged): Deleted.

* UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.shown):
(WI.Layers3DContentView.prototype.hidden):
(WI.Layers3DContentView.prototype.attached): Added.
(WI.Layers3DContentView.prototype.detached): Added.
(WI.Layers3DContentView.prototype._handleCompositingBordersVisibleChanged): Added.
(WI.Layers3DContentView.prototype._handleCompositingBordersButtonClicked): Added.
(WI.Layers3DContentView.prototype._handleShowPaintRectsChanged): Added.
(WI.Layers3DContentView.prototype._handlePaingFlashingButtonClicked): Added.
(WI.Layers3DContentView.prototype.closed): Deleted.
(WI.Layers3DContentView.prototype._showPaintRectsSettingChanged): Deleted.
(WI.Layers3DContentView.prototype._togglePaintFlashing): Deleted.
(WI.Layers3DContentView.prototype._updateCompositingBordersButtonState): Deleted.
(WI.Layers3DContentView.prototype._toggleCompositingBorders): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/protocol/Page.json
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorPageAgent.h
trunk/Source/WebCore/page/Settings.yaml
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/LayerTreeManager.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (253738 => 253739)

--- trunk/Source/_javascript_Core/ChangeLog	2019-12-19 06:35:37 UTC (rev 253738)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-12-19 07:35:28 UTC (rev 253739)
@@ -1,3 +1,21 @@
+2019-12-18  Devin Rousso  
+
+Web 

[webkit-changes] [253737] releases/Apple/Safari Technology Preview

[mitz]

Title: [253737] releases/Apple/Safari Technology Preview








Revision 253737
Author m...@apple.com
Date 2019-12-18 22:18:59 -0800 (Wed, 18 Dec 2019)


Log Message
Added a tag for Safari Technology Preview release 97.

Added Paths

releases/Apple/Safari Technology Preview/Safari Technology Preview 97/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/ANGLE/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/_javascript_Core/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WTF/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WebCore/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WebInspectorUI/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WebKit/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WebKitLegacy/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/bmalloc/
releases/Apple/Safari Technology Preview/Safari Technology Preview 97/libwebrtc/




Diff
Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/ANGLE
===
--- tags/Safari-609.1.11.4/Source/ThirdParty/ANGLE	2019-12-19 05:27:27 UTC (rev 253736)
+++ releases/Apple/Safari Technology Preview/Safari Technology Preview 97/ANGLE	2019-12-19 06:18:59 UTC (rev 253737)

Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/_javascript_Core
===
--- tags/Safari-609.1.11.4/Source/_javascript_Core	2019-12-19 05:27:27 UTC (rev 253736)
+++ releases/Apple/Safari Technology Preview/Safari Technology Preview 97/_javascript_Core	2019-12-19 06:18:59 UTC (rev 253737)

Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WTF
===
--- tags/Safari-609.1.11.4/Source/WTF	2019-12-19 05:27:27 UTC (rev 253736)
+++ releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WTF	2019-12-19 06:18:59 UTC (rev 253737)

Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WebInspectorUI
===
--- tags/Safari-609.1.11.4/Source/WebInspectorUI	2019-12-19 05:27:27 UTC (rev 253736)
+++ releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WebInspectorUI	2019-12-19 06:18:59 UTC (rev 253737)

Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/bmalloc
===
--- tags/Safari-609.1.11.4/Source/bmalloc	2019-12-19 05:27:27 UTC (rev 253736)
+++ releases/Apple/Safari Technology Preview/Safari Technology Preview 97/bmalloc	2019-12-19 06:18:59 UTC (rev 253737)

Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/libwebrtc
===
--- tags/Safari-609.1.11.4/Source/ThirdParty/libwebrtc	2019-12-19 05:27:27 UTC (rev 253736)
+++ releases/Apple/Safari Technology Preview/Safari Technology Preview 97/libwebrtc	2019-12-19 06:18:59 UTC (rev 253737)

Property changes: releases/Apple/Safari Technology Preview/Safari Technology Preview 97/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253736] trunk

[commit-queue]

Title: [253736] trunk








Revision 253736
Author commit-qu...@webkit.org
Date 2019-12-18 21:27:27 -0800 (Wed, 18 Dec 2019)


Log Message
Unreviewed, rolling out r253646.
https://bugs.webkit.org/show_bug.cgi?id=205433

"We think this may have caused a membuster regression, so
rolling it out." (Requested by nham on #webkit).

Reverted changeset:

"Navigation from empty page doesn't use cached web process"
https://bugs.webkit.org/show_bug.cgi?id=205015
https://trac.webkit.org/changeset/253646

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (253735 => 253736)

--- trunk/Source/WebKit/ChangeLog	2019-12-19 03:16:23 UTC (rev 253735)
+++ trunk/Source/WebKit/ChangeLog	2019-12-19 05:27:27 UTC (rev 253736)
@@ -1,3 +1,17 @@
+2019-12-18  Commit Queue  
+
+Unreviewed, rolling out r253646.
+https://bugs.webkit.org/show_bug.cgi?id=205433
+
+"We think this may have caused a membuster regression, so
+rolling it out." (Requested by nham on #webkit).
+
+Reverted changeset:
+
+"Navigation from empty page doesn't use cached web process"
+https://bugs.webkit.org/show_bug.cgi?id=205015
+https://trac.webkit.org/changeset/253646
+
 2019-12-18  Alex Christensen  
 
 Add SPI WKWebView._updateWebpagePreferences to replace _updateWebsitePolicies


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h (253735 => 253736)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h	2019-12-19 03:16:23 UTC (rev 253735)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h	2019-12-19 05:27:27 UTC (rev 253736)
@@ -59,6 +59,4 @@
 @property (nonatomic, readonly) BOOL _hasServiceWorkerForegroundActivityForTesting;
 - (void)_setAssertionStateForTesting:(int)state;
 
-- (void)_ensureRunningProcessForTesting;
-
 @end


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm (253735 => 253736)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm	2019-12-19 03:16:23 UTC (rev 253735)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm	2019-12-19 05:27:27 UTC (rev 253736)
@@ -202,9 +202,4 @@
 #endif
 }
 
-- (void)_ensureRunningProcessForTesting
-{
-_page->ensureRunningProcess();
-}
-
 @end


Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (253735 => 253736)

--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2019-12-19 03:16:23 UTC (rev 253735)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2019-12-19 05:27:27 UTC (rev 253736)
@@ -2183,6 +2183,11 @@
 if (m_automationSession)
 return completionHandler(WTFMove(sourceProcess), nullptr, "An automation session is active"_s);
 
+if (!sourceProcess->hasCommittedAnyProvisionalLoads()) {
+tryPrewarmWithDomainInformation(sourceProcess, targetRegistrableDomain);
+return completionHandler(WTFMove(sourceProcess), nullptr, "Process has not yet committed any provisional loads"_s);
+}
+
 // FIXME: We should support process swap when a window has been opened via window.open() without 'noopener'.
 // The issue is that the opener has a handle to the WindowProxy.
 if (navigation.openedByDOMWithOpener() && !m_configuration->processSwapsOnWindowOpenWithOpener())
@@ -2218,16 +2223,6 @@
 if (navigation.treatAsSameOriginNavigation())
 return completionHandler(WTFMove(sourceProcess), nullptr, "The treatAsSameOriginNavigation flag is set"_s);
 
-if (!sourceProcess->hasCommittedAnyProvisionalLoads()) {
-if (auto process = webProcessCache().takeProcess(targetRegistrableDomain, dataStore)) {
-RELEASE_LOG(ProcessSwapping, "(ProcessSwapping) Reusing a previously cached process with pid %i in place of pid %i that hasn't committed any provisional loads", process->processIdentifier(), sourceProcess->processIdentifier());
-return completionHandler(process.releaseNonNull(), nullptr, "Reusing cached process in place of process that hasn't committed any loads"_s);
-}
-
-tryPrewarmWithDomainInformation(sourceProcess, targetRegistrableDomain);
-return completionHandler(WTFMove(sourceProcess), nullptr, "Process has not yet committed any provisional loads"_s);
-}
-
 URL sourceURL;
 if (page.isPageOpenedByDOMShowingInitialEmptyDocument() && !navigation.requesterOrigin().isEmpty())
 sourceURL = URL { URL(), navigation.requesterOrigin().toString() };


Modified: trunk/Tools/ChangeLog (253735 => 253736)

--- trunk/Tools/ChangeLog	2019-12-19 03:16:23 UTC (rev 253735)
+++ trunk/Tools/ChangeLog	2019-12-19 05:27:27 UTC (rev 253736)
@@ -1,3 +1,17 @@
+2019-12-18  Commit Queue  
+
+Unreviewed, rolling 

[webkit-changes] [253735] trunk/LayoutTests

[rniwa]

Title: [253735] trunk/LayoutTests








Revision 253735
Author rn...@webkit.org
Date 2019-12-18 19:16:23 -0800 (Wed, 18 Dec 2019)


Log Message
REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=205364


Reviewed by Simon Fraser.

Fix the test by waiting for rAF and avoid running checkForScroll more than once.

* platform/mac-wk2/TestExpectations: Removed the flaky expectation.
* tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html




Diff

Modified: trunk/LayoutTests/ChangeLog (253734 => 253735)

--- trunk/LayoutTests/ChangeLog	2019-12-19 03:12:54 UTC (rev 253734)
+++ trunk/LayoutTests/ChangeLog	2019-12-19 03:16:23 UTC (rev 253735)
@@ -1,5 +1,18 @@
 2019-12-18  Ryosuke Niwa  
 
+REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html is a flakey failure
+https://bugs.webkit.org/show_bug.cgi?id=205364
+
+
+Reviewed by Simon Fraser.
+
+Fix the test by waiting for rAF and avoid running checkForScroll more than once.
+
+* platform/mac-wk2/TestExpectations: Removed the flaky expectation.
+* tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html:
+
+2019-12-18  Ryosuke Niwa  
+
 REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html is a flakey failure
 https://bugs.webkit.org/show_bug.cgi?id=205363
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (253734 => 253735)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2019-12-19 03:12:54 UTC (rev 253734)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2019-12-19 03:16:23 UTC (rev 253735)
@@ -925,6 +925,4 @@
 
 webkit.org/b/205301 [ Mojave+ ] inspector/canvas/requestShaderSource-webgpu.html [ Pass Failure ]
 
-webkit.org/b/205364 tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html [ Pass Failure ]
-
 wbekit.org/b/205365 [ Mojave+ Debug ] fast/mediastream/captureStream/canvas2d-heavy-drawing.html [ Pass Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html (253734 => 253735)

--- trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html	2019-12-19 03:12:54 UTC (rev 253734)
+++ trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html	2019-12-19 03:16:23 UTC (rev 253735)
@@ -53,8 +53,13 @@
 checkForScroll();
 }
 
+let didCheckForScroll = false;
 function checkForScroll()
 {
+if (didCheckForScroll)
+return;
+didCheckForScroll = true;
+
 // The div should not have scrolled at all.
 var pageScrollPositionAfter = document.scrollingElement.scrollTop;
 var divScrollPositionAfter = divTarget.scrollTop;
@@ -92,7 +97,9 @@
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'none', 'begin');
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -4, 'none', 'continue');
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, 'none', 'end');
-eventSender.callAfterScrollingCompletes(checkForScroll);
+eventSender.callAfterScrollingCompletes(() => {
+requestAnimationFrame(checkForScroll);
+});
 // We should finish via the scroll event; this will fire in the case of failure when the page doesn't scroll.
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253734] trunk/LayoutTests

[rniwa]

Title: [253734] trunk/LayoutTests








Revision 253734
Author rn...@webkit.org
Date 2019-12-18 19:12:54 -0800 (Wed, 18 Dec 2019)


Log Message
REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=205363


Reviewed by Wenson Hsieh.

Fix the test by waiting for rAF and avoid running checkForScroll more than once.

* platform/mac-wk2/TestExpectations:
* tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (253733 => 253734)

--- trunk/LayoutTests/ChangeLog	2019-12-19 02:38:47 UTC (rev 253733)
+++ trunk/LayoutTests/ChangeLog	2019-12-19 03:12:54 UTC (rev 253734)
@@ -1,3 +1,16 @@
+2019-12-18  Ryosuke Niwa  
+
+REGRESSION: [ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html is a flakey failure
+https://bugs.webkit.org/show_bug.cgi?id=205363
+
+
+Reviewed by Wenson Hsieh.
+
+Fix the test by waiting for rAF and avoid running checkForScroll more than once.
+
+* platform/mac-wk2/TestExpectations:
+* tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html:
+
 2019-12-18  Antoine Quint  
 
 Animations stop if new tab opened (and closed)


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (253733 => 253734)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2019-12-19 02:38:47 UTC (rev 253733)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2019-12-19 03:12:54 UTC (rev 253734)
@@ -659,8 +659,6 @@
 
 webkit.org/b/171837 [ Debug ] http/tests/security/storage-blocking-loosened-plugin.html [ Pass Failure ]
 
-webkit.org/b/171935 tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html [ Pass Failure ]
-
 webkit.org/b/171939 [ Sierra Release ] media/track/track-cue-rendering-on-resize.html [ Pass Timeout ]
 
 webkit.org/b/171947 [ Sierra Release ] transitions/extra-transition.html [ Pass Failure ]


Modified: trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html (253733 => 253734)

--- trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html	2019-12-19 02:38:47 UTC (rev 253733)
+++ trunk/LayoutTests/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html	2019-12-19 03:12:54 UTC (rev 253734)
@@ -47,8 +47,13 @@
 checkForScroll();
 }
 
+let didCheckForScroll = false;
 function checkForScroll()
 {
+if (didCheckForScroll)
+return;
+didCheckForScroll = true;
+
 // The select should not have scrolled at all.
 var pageScrollPositionAfter = document.scrollingElement.scrollTop;
 var selectScrollPositionAfter = selectTarget.scrollTop;
@@ -85,7 +90,9 @@
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -1, 'none', 'begin');
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, -4, 'none', 'continue');
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, 'none', 'end');
-eventSender.callAfterScrollingCompletes(checkForScroll);
+eventSender.callAfterScrollingCompletes(() => {
+requestAnimationFrame(checkForScroll);
+});
 
 // We should finish via the scroll event; this will fire in the case of failure when the page doesn't scroll.
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253733] trunk

[commit-queue]

Title: [253733] trunk








Revision 253733
Author commit-qu...@webkit.org
Date 2019-12-18 18:38:47 -0800 (Wed, 18 Dec 2019)


Log Message
Add SPI WKWebView._updateWebpagePreferences to replace _updateWebsitePolicies
https://bugs.webkit.org/show_bug.cgi?id=205427

Patch by Alex Christensen  on 2019-12-18
Reviewed by Wenson Hsieh.

Source/WebKit:

This blocks the removal of _WKWebsitePolicies.
This change is verified by an API test.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateWebsitePolicies:]):
(-[WKWebView _updateWebpagePreferences:]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (253732 => 253733)

--- trunk/Source/WebKit/ChangeLog	2019-12-19 02:38:15 UTC (rev 253732)
+++ trunk/Source/WebKit/ChangeLog	2019-12-19 02:38:47 UTC (rev 253733)
@@ -1,3 +1,18 @@
+2019-12-18  Alex Christensen  
+
+Add SPI WKWebView._updateWebpagePreferences to replace _updateWebsitePolicies
+https://bugs.webkit.org/show_bug.cgi?id=205427
+
+Reviewed by Wenson Hsieh.
+
+This blocks the removal of _WKWebsitePolicies.
+This change is verified by an API test.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _updateWebsitePolicies:]):
+(-[WKWebView _updateWebpagePreferences:]):
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
 2019-12-18  Tim Horton  
 
 macCatalyst: Cursor should update when the platform deems it necessary


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (253732 => 253733)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2019-12-19 02:38:15 UTC (rev 253732)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2019-12-19 02:38:47 UTC (rev 253733)
@@ -2070,7 +2070,12 @@
 
 - (void)_updateWebsitePolicies:(_WKWebsitePolicies *)websitePolicies
 {
-auto data = ""
+[self _updateWebpagePreferences:websitePolicies.webpagePreferences];
+}
+
+- (void)_updateWebpagePreferences:(WKWebpagePreferences *)webpagePreferences
+{
+auto data = ""
 if (data.websiteDataStoreParameters)
 [NSException raise:NSInvalidArgumentException format:@"Updating WKWebsiteDataStore is only supported during decidePolicyForNavigationAction."];
 _page->updateWebsitePolicies(WTFMove(data));


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h (253732 => 253733)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h	2019-12-19 02:38:15 UTC (rev 253732)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h	2019-12-19 02:38:47 UTC (rev 253733)
@@ -104,6 +104,7 @@
 #endif
 
 @class WKBrowsingContextHandle;
+@class WKWebpagePreferences;
 @class _WKApplicationManifest;
 @class _WKFrameHandle;
 @class _WKHitTestResult;
@@ -187,6 +188,7 @@
 - (void)_close;
 
 - (void)_updateWebsitePolicies:(_WKWebsitePolicies *)websitePolicies WK_API_AVAILABLE(macos(10.13), ios(11.0));
+- (void)_updateWebpagePreferences:(WKWebpagePreferences *)webpagePreferences WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 - (void)_evaluateJavaScriptWithoutUserGesture:(NSString *)_javascript_String completionHandler:(void (^)(id, NSError *))completionHandler WK_API_AVAILABLE(macos(10.13), ios(11.0));
 


Modified: trunk/Tools/ChangeLog (253732 => 253733)

--- trunk/Tools/ChangeLog	2019-12-19 02:38:15 UTC (rev 253732)
+++ trunk/Tools/ChangeLog	2019-12-19 02:38:47 UTC (rev 253733)
@@ -1,3 +1,13 @@
+2019-12-18  Alex Christensen  
+
+Add SPI WKWebView._updateWebpagePreferences to replace _updateWebsitePolicies
+https://bugs.webkit.org/show_bug.cgi?id=205427
+
+Reviewed by Wenson Hsieh.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
+(TEST):
+
 2019-12-18  Jonathan Bedard  
 
 test-lldb-webkit: Run in CI (Follow-up fix)


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm (253732 => 253733)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm	2019-12-19 02:38:15 UTC (rev 253732)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm	2019-12-19 02:38:47 UTC (rev 253733)
@@ -742,9 +742,9 @@
 
 [webView stringByEvaluatingJavaScript:@"pauseVideo()"];
 
-policies = [[[_WKWebsitePolicies alloc] init] autorelease];
-policies.autoplayPolicy = _WKWebsiteAutoplayPolicyDeny;
-[webView _updateWebsitePolicies:policies];
+WKWebpagePreferences *preferences = [[[WKWebpagePreferences alloc] init] autorelease];
+preferences._autoplayPolicy = _WKWebsiteAutoplayPolicyDeny;
+[webView _updateWebpagePreferences:preferences];
 
 // A script should no longer be able to autoplay media.
 receivedAutoplayEvent = WTF::nullopt;

[webkit-changes] [253732] trunk/Source/WTF

[ysuzuki]

Title: [253732] trunk/Source/WTF








Revision 253732
Author ysuz...@apple.com
Date 2019-12-18 18:38:15 -0800 (Wed, 18 Dec 2019)


Log Message
Unreviewed, build fix after r253730
https://bugs.webkit.org/show_bug.cgi?id=204398

Thread::destructTLS is always required in POSIX environments

* wtf/Threading.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Threading.h




Diff

Modified: trunk/Source/WTF/ChangeLog (253731 => 253732)

--- trunk/Source/WTF/ChangeLog	2019-12-19 02:21:35 UTC (rev 253731)
+++ trunk/Source/WTF/ChangeLog	2019-12-19 02:38:15 UTC (rev 253732)
@@ -1,3 +1,12 @@
+2019-12-18  Yusuke Suzuki  
+
+Unreviewed, build fix after r253730
+https://bugs.webkit.org/show_bug.cgi?id=204398
+
+Thread::destructTLS is always required in POSIX environments
+
+* wtf/Threading.h:
+
 2019-12-18  Fujii Hironori  
 
 [Win] Use thread_local to hold Ref in the thread rather than using FLS


Modified: trunk/Source/WTF/wtf/Threading.h (253731 => 253732)

--- trunk/Source/WTF/wtf/Threading.h	2019-12-19 02:21:35 UTC (rev 253731)
+++ trunk/Source/WTF/wtf/Threading.h	2019-12-19 02:38:15 UTC (rev 253732)
@@ -281,7 +281,7 @@
 // One time initialization for this class as a whole.
 // This method must be called before initializeTLS() and it is not thread-safe.
 static void initializeTLSKey();
-
+#endif
 // This thread-specific destructor is called 2 times when thread terminates:
 // - first, when all the other thread-specific destructors are called, it simply remembers it was 'destroyed once'
 // and (1) re-sets itself into the thread-specific slot or (2) constructs thread local value to call it again later.
@@ -288,7 +288,6 @@
 // - second, after all thread-specific destructors were invoked, it gets called again - this time, we deref the
 // Thread in the TLS, completing the cleanup.
 static void destructTLS(void* data);
-#endif
 
 // Creates and puts an instance of Thread into thread-specific storage.
 static Thread& initializeTLS(Ref&&);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253731] trunk/Source

[timothy_horton]

Title: [253731] trunk/Source








Revision 253731
Author timothy_hor...@apple.com
Date 2019-12-18 18:21:35 -0800 (Wed, 18 Dec 2019)


Log Message
macCatalyst: Cursor should update when the platform deems it necessary
https://bugs.webkit.org/show_bug.cgi?id=205429


Reviewed by Wenson Hsieh.

* Shared/ios/InteractionInformationAtPosition.h:
* Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::positionInformation):
Expose the current cursor and caret size on position information so
that macCatalyst UIKit can retrieve it out-of-band (in addition to
setting it when we do a hit-test, like in r253636).

* page/EventHandler.h:
Expose selectCursor for WebKit's use.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h
trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (253730 => 253731)

--- trunk/Source/WebCore/ChangeLog	2019-12-19 02:01:22 UTC (rev 253730)
+++ trunk/Source/WebCore/ChangeLog	2019-12-19 02:21:35 UTC (rev 253731)
@@ -1,3 +1,14 @@
+2019-12-18  Tim Horton  
+
+macCatalyst: Cursor should update when the platform deems it necessary
+https://bugs.webkit.org/show_bug.cgi?id=205429
+
+
+Reviewed by Wenson Hsieh.
+
+* page/EventHandler.h:
+Expose selectCursor for WebKit's use.
+
 2019-12-18  Antoine Quint  
 
 Animations stop if new tab opened (and closed)


Modified: trunk/Source/WebCore/page/EventHandler.h (253730 => 253731)

--- trunk/Source/WebCore/page/EventHandler.h	2019-12-19 02:01:22 UTC (rev 253730)
+++ trunk/Source/WebCore/page/EventHandler.h	2019-12-19 02:21:35 UTC (rev 253731)
@@ -341,6 +341,8 @@
 WEBCORE_EXPORT void cancelSelectionAutoscroll();
 #endif
 
+WEBCORE_EXPORT Optional selectCursor(const HitTestResult&, bool shiftKey);
+
 private:
 #if ENABLE(DRAG_SUPPORT)
 static DragState& dragState();
@@ -371,7 +373,6 @@
 
 bool internalKeyEvent(const PlatformKeyboardEvent&);
 
-Optional selectCursor(const HitTestResult&, bool shiftKey);
 void updateCursor(FrameView&, const HitTestResult&, bool shiftKey);
 
 void hoverTimerFired();


Modified: trunk/Source/WebKit/ChangeLog (253730 => 253731)

--- trunk/Source/WebKit/ChangeLog	2019-12-19 02:01:22 UTC (rev 253730)
+++ trunk/Source/WebKit/ChangeLog	2019-12-19 02:21:35 UTC (rev 253731)
@@ -1,3 +1,21 @@
+2019-12-18  Tim Horton  
+
+macCatalyst: Cursor should update when the platform deems it necessary
+https://bugs.webkit.org/show_bug.cgi?id=205429
+
+
+Reviewed by Wenson Hsieh.
+
+* Shared/ios/InteractionInformationAtPosition.h:
+* Shared/ios/InteractionInformationAtPosition.mm:
+(WebKit::InteractionInformationAtPosition::encode const):
+(WebKit::InteractionInformationAtPosition::decode):
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::positionInformation):
+Expose the current cursor and caret size on position information so
+that macCatalyst UIKit can retrieve it out-of-band (in addition to
+setting it when we do a hit-test, like in r253636.
+
 2019-12-18  Alex Christensen  
 
 Add ObjC version of WKBundleFrameIsMainFrame


Modified: trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h (253730 => 253731)

--- trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h	2019-12-19 02:01:22 UTC (rev 253730)
+++ trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h	2019-12-19 02:21:35 UTC (rev 253731)
@@ -30,6 +30,7 @@
 #include "ArgumentCoders.h"
 #include "InteractionInformationRequest.h"
 #include "ShareableBitmap.h"
+#include 
 #include 
 #include 
 #include 
@@ -83,6 +84,10 @@
 String textBefore;
 String textAfter;
 
+float caretHeight { 0 };
+
+Optional cursor;
+
 WebCore::TextIndicatorData linkIndicator;
 #if ENABLE(DATA_DETECTION)
 String dataDetectorIdentifier;


Modified: trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm (253730 => 253731)

--- trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm	2019-12-19 02:01:22 UTC (rev 253730)
+++ trunk/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm	2019-12-19 02:21:35 UTC (rev 253731)
@@ -68,6 +68,8 @@
 #endif
 encoder << textBefore;
 encoder << textAfter;
+encoder << caretHeight;
+encoder << cursor;
 encoder << linkIndicator;
 
 ShareableBitmap::Handle handle;
@@ -158,6 +160,12 @@
 
 if (!decoder.decode(result.textAfter))
 return false;
+
+if (!decoder.decode(result.caretHeight))
+return false;
+
+if 

[webkit-changes] [253730] trunk/Source/WTF

[Hironori . Fujii]

Title: [253730] trunk/Source/WTF








Revision 253730
Author hironori.fu...@sony.com
Date 2019-12-18 18:01:22 -0800 (Wed, 18 Dec 2019)


Log Message
[Win] Use thread_local to hold Ref in the thread rather than using FLS
https://bugs.webkit.org/show_bug.cgi?id=204398

Reviewed by Yusuke Suzuki.

Use thread_local which is faster than FLS.

* wtf/Threading.cpp:
(WTF::initializeThreading):
* wtf/Threading.h:
(WTF::Thread::current):
* wtf/ThreadingPrimitives.h: Deleted threadSpecificKeyCreate and
related functions which aren't used now in Windows port. Deleted
THREAD_SPECIFIC_CALL macro which isn't used now.
* wtf/win/ThreadingWin.cpp: Added a thread_local variable s_threadHolder.
(WTF::Thread::ThreadHolder::~ThreadHolder): Added.
(WTF::Thread::currentMayBeNull):
(WTF::Thread::initializeTLS): Store a reference of Thread into s_threadHolder.
(WTF::Thread::initializeTLSKey): Deleted.
(WTF::Thread::destructTLS): Deleted.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Threading.cpp
trunk/Source/WTF/wtf/Threading.h
trunk/Source/WTF/wtf/ThreadingPrimitives.h
trunk/Source/WTF/wtf/win/ThreadingWin.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (253729 => 253730)

--- trunk/Source/WTF/ChangeLog	2019-12-19 00:35:24 UTC (rev 253729)
+++ trunk/Source/WTF/ChangeLog	2019-12-19 02:01:22 UTC (rev 253730)
@@ -1,3 +1,26 @@
+2019-12-18  Fujii Hironori  
+
+[Win] Use thread_local to hold Ref in the thread rather than using FLS
+https://bugs.webkit.org/show_bug.cgi?id=204398
+
+Reviewed by Yusuke Suzuki.
+
+Use thread_local which is faster than FLS.
+
+* wtf/Threading.cpp:
+(WTF::initializeThreading):
+* wtf/Threading.h:
+(WTF::Thread::current):
+* wtf/ThreadingPrimitives.h: Deleted threadSpecificKeyCreate and
+related functions which aren't used now in Windows port. Deleted
+THREAD_SPECIFIC_CALL macro which isn't used now.
+* wtf/win/ThreadingWin.cpp: Added a thread_local variable s_threadHolder.
+(WTF::Thread::ThreadHolder::~ThreadHolder): Added.
+(WTF::Thread::currentMayBeNull):
+(WTF::Thread::initializeTLS): Store a reference of Thread into s_threadHolder.
+(WTF::Thread::initializeTLSKey): Deleted.
+(WTF::Thread::destructTLS): Deleted.
+
 2019-12-18  Ben Nham  
 
 Add network loading signposts


Modified: trunk/Source/WTF/wtf/Threading.cpp (253729 => 253730)

--- trunk/Source/WTF/wtf/Threading.cpp	2019-12-19 00:35:24 UTC (rev 253729)
+++ trunk/Source/WTF/wtf/Threading.cpp	2019-12-19 02:01:22 UTC (rev 253730)
@@ -323,7 +323,7 @@
 out.print("Thread:", RawPointer(this));
 }
 
-#if !HAVE(FAST_TLS)
+#if !HAVE(FAST_TLS) && !OS(WINDOWS)
 ThreadSpecificKey Thread::s_key = InvalidThreadSpecificKey;
 #endif
 
@@ -332,7 +332,7 @@
 static std::once_flag onceKey;
 std::call_once(onceKey, [] {
 initializeRandomNumberGenerator();
-#if !HAVE(FAST_TLS)
+#if !HAVE(FAST_TLS) && !OS(WINDOWS)
 Thread::initializeTLSKey();
 #endif
 initializeDates();


Modified: trunk/Source/WTF/wtf/Threading.h (253729 => 253730)

--- trunk/Source/WTF/wtf/Threading.h	2019-12-19 00:35:24 UTC (rev 253729)
+++ trunk/Source/WTF/wtf/Threading.h	2019-12-19 02:01:22 UTC (rev 253730)
@@ -127,6 +127,8 @@
 };
 
 SpecificStorage& specificStorage() { return m_specificStorage; };
+
+class ThreadHolder;
 #endif
 
 WTF_EXPORT_PRIVATE void changePriority(int);
@@ -271,16 +273,21 @@
 ThreadGroupAddResult addToThreadGroup(const AbstractLocker& threadGroupLocker, ThreadGroup&);
 void removeFromThreadGroup(const AbstractLocker& threadGroupLocker, ThreadGroup&);
 
-// The Thread instance is ref'ed and held in thread-specific storage. It will be deref'ed by destructTLS at thread destruction time.
-// For pthread, it employs pthreads-specific 2-pass destruction to reliably remove Thread.
-// For Windows, we use thread_local to defer thread TLS destruction. It assumes regular ThreadSpecific
-// types don't use multiple-pass destruction.
+// For pthread, the Thread instance is ref'ed and held in thread-specific storage. It will be deref'ed by destructTLS at thread destruction time.
+// It employs pthreads-specific 2-pass destruction to reliably remove Thread.
 
-#if !HAVE(FAST_TLS)
+#if !HAVE(FAST_TLS) && !OS(WINDOWS)
 static WTF_EXPORT_PRIVATE ThreadSpecificKey s_key;
 // One time initialization for this class as a whole.
 // This method must be called before initializeTLS() and it is not thread-safe.
 static void initializeTLSKey();
+
+// This thread-specific destructor is called 2 times when thread terminates:
+// - first, when all the other thread-specific destructors are called, it simply remembers it was 'destroyed once'
+// and (1) re-sets itself into the thread-specific slot or (2) constructs thread local value to call it again later.
+// - second, after all thread-specific destructors were invoked, it 

[webkit-changes] [253729] trunk/Tools

[jbedard]

Title: [253729] trunk/Tools








Revision 253729
Author jbed...@apple.com
Date 2019-12-18 16:35:24 -0800 (Wed, 18 Dec 2019)


Log Message
test-lldb-webkit: Run in CI (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=205315

Unreviewed follow-up fix.

* BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunWebKitPyTests.start): Call method of parent class to avoid infinite recursion.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (253728 => 253729)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py	2019-12-19 00:30:46 UTC (rev 253728)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py	2019-12-19 00:35:24 UTC (rev 253729)
@@ -641,10 +641,9 @@
 
 def start(self):
 self.slaveEnvironment[RESULTS_SERVER_API_KEY] = os.getenv(RESULTS_SERVER_API_KEY)
+return RunPythonTests.start(self)
 
-return RunWebKitPyTests.start(self)
 
-
 class RunLLDBWebKitTests(RunPythonTests):
 name = "lldb-webkit-test"
 description = ["lldb-webkit-tests running"]


Modified: trunk/Tools/ChangeLog (253728 => 253729)

--- trunk/Tools/ChangeLog	2019-12-19 00:30:46 UTC (rev 253728)
+++ trunk/Tools/ChangeLog	2019-12-19 00:35:24 UTC (rev 253729)
@@ -1,3 +1,13 @@
+2019-12-18  Jonathan Bedard  
+
+test-lldb-webkit: Run in CI (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=205315
+
+Unreviewed follow-up fix.
+
+* BuildSlaveSupport/build.webkit.org-config/steps.py:
+(RunWebKitPyTests.start): Call method of parent class to avoid infinite recursion.
+
 2019-12-18  Alex Christensen  
 
 Add ObjC version of WKBundleFrameIsMainFrame






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253728] trunk

[commit-queue]

Title: [253728] trunk








Revision 253728
Author commit-qu...@webkit.org
Date 2019-12-18 16:30:46 -0800 (Wed, 18 Dec 2019)


Log Message
Animations stop if new tab opened (and closed)
https://bugs.webkit.org/show_bug.cgi?id=202360


Patch by Antoine Quint  on 2019-12-18
Reviewed by Dean Jackson.

Source/WebCore:

In the case where we would have a fill-forwards software animation when an animation that could be
accelerated started, we would fail to start an accelerated animation because we had no composited
renderer. However, we would still advertise a state of "running accelerated" and the DocumentTimeline
would not schedule ticks to run the animation in software.

We now only schedule accelerated animations once their delay phase is over and the animation is in its
"active" phase, which helps to only schedule accelerated animations once they actually have an effect
that is worth accelerating, and reset pending accelerated actions in case we try to start an accelerated
animation but fail to because we don't have a composited renderer.

Test: webanimations/animation-of-accelerated-property-after-non-accelerated-property.html

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::updateAcceleratedAnimationState):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
* animation/KeyframeEffect.h:

LayoutTests:

Add a ref test that checks that an element with a software animation followed by an animation of a property
that can be accelerated yields animations in both cases.

Also, somehow, the WPT test dom/events/Event-dispatch-on-disabled-elements.html seems to now pass an extra
test that would fail on iOS and now behaves like macOS, so we remove that platform-specific expectation.

* platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt
* webanimations/animation-of-accelerated-property-after-non-accelerated-property-expected.html: Added.
* webanimations/animation-of-accelerated-property-after-non-accelerated-property.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp
trunk/Source/WebCore/animation/KeyframeEffect.h


Added Paths

trunk/LayoutTests/webanimations/animation-of-accelerated-property-after-non-accelerated-property-expected.html
trunk/LayoutTests/webanimations/animation-of-accelerated-property-after-non-accelerated-property.html


Removed Paths

trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (253727 => 253728)

--- trunk/LayoutTests/ChangeLog	2019-12-18 23:57:14 UTC (rev 253727)
+++ trunk/LayoutTests/ChangeLog	2019-12-19 00:30:46 UTC (rev 253728)
@@ -1,3 +1,21 @@
+2019-12-18  Antoine Quint  
+
+Animations stop if new tab opened (and closed)
+https://bugs.webkit.org/show_bug.cgi?id=202360
+
+
+Reviewed by Dean Jackson.
+
+Add a ref test that checks that an element with a software animation followed by an animation of a property
+that can be accelerated yields animations in both cases. 
+
+Also, somehow, the WPT test dom/events/Event-dispatch-on-disabled-elements.html seems to now pass an extra
+test that would fail on iOS and now behaves like macOS, so we remove that platform-specific expectation.
+
+* platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt
+* webanimations/animation-of-accelerated-property-after-non-accelerated-property-expected.html: Added.
+* webanimations/animation-of-accelerated-property-after-non-accelerated-property.html: Added.
+
 2019-12-18  Yury Semikhatsky  
 
 Web Inspector: Runtime.enable reports duplicates (non existent) contexts


Deleted: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt (253727 => 253728)

--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt	2019-12-18 23:57:14 UTC (rev 253727)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt	2019-12-19 00:30:46 UTC (rev 253728)
@@ -1,12 +0,0 @@
- 
-
-PASS Can dispatch untrusted 'click' Events at disabled HTML elements. 
-PASS Can dispatch untrusted Events at disabled HTML elements. 
-PASS Can dispatch CustomEvents at disabled HTML elements. 
-PASS Calling click() on disabled elements must not dispatch events. 
-PASS CSS Transitions transitionrun, transitionstart, transitionend events fire on disabled form elements 
-PASS CSS Transitions transitioncancel event fires on disabled form elements 
-PASS CSS Animation animationstart, animationiteration, animationend fire on disabled form elements 
-PASS CSS Animation's animationcancel event fires on 

[webkit-changes] [253727] branches/safari-608-branch/Source/WebCore/loader/FrameLoader.cpp

[alancoon]

Title: [253727] branches/safari-608-branch/Source/WebCore/loader/FrameLoader.cpp








Revision 253727
Author alanc...@apple.com
Date 2019-12-18 15:57:14 -0800 (Wed, 18 Dec 2019)


Log Message
Fix merge conflict resolution. rdar://problem/58049166

Modified Paths

branches/safari-608-branch/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: branches/safari-608-branch/Source/WebCore/loader/FrameLoader.cpp (253726 => 253727)

--- branches/safari-608-branch/Source/WebCore/loader/FrameLoader.cpp	2019-12-18 23:47:55 UTC (rev 253726)
+++ branches/safari-608-branch/Source/WebCore/loader/FrameLoader.cpp	2019-12-18 23:57:14 UTC (rev 253727)
@@ -397,10 +397,8 @@
 
 Ref protect(m_frame);
 
-if (m_frame.script().executeIfJavaScriptURL(frameRequest.resourceRequest().url(), ().securityOrigin(), frameRequest.shouldReplaceDocumentIfJavaScriptURL())) {
-m_quickRedirectComing = false;
+if (m_frame.script().executeIfJavaScriptURL(frameRequest.resourceRequest().url(), ().securityOrigin(), frameRequest.shouldReplaceDocumentIfJavaScriptURL()))
 return;
-}
 
 if (frameRequest.frameName().isEmpty())
 frameRequest.setFrameName(m_frame.document()->baseTarget());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253726] branches/safari-609.1.13-branch

[alancoon]

Title: [253726] branches/safari-609.1.13-branch








Revision 253726
Author alanc...@apple.com
Date 2019-12-18 15:47:55 -0800 (Wed, 18 Dec 2019)


Log Message
Revert r253493. rdar://problem/58028534

Modified Paths

branches/safari-609.1.13-branch/LayoutTests/ChangeLog
branches/safari-609.1.13-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-609.1.13-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3-expected.txt
branches/safari-609.1.13-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-expected.txt
branches/safari-609.1.13-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-609.1.13-branch/Source/WebCore/ChangeLog
branches/safari-609.1.13-branch/Source/WebCore/html/HTMLFormElement.cpp
branches/safari-609.1.13-branch/Source/WebCore/html/HTMLFormElement.h
branches/safari-609.1.13-branch/Source/WebCore/loader/FormSubmission.h
branches/safari-609.1.13-branch/Source/WebCore/loader/NavigationScheduler.cpp




Diff

Modified: branches/safari-609.1.13-branch/LayoutTests/ChangeLog (253725 => 253726)

--- branches/safari-609.1.13-branch/LayoutTests/ChangeLog	2019-12-18 23:21:55 UTC (rev 253725)
+++ branches/safari-609.1.13-branch/LayoutTests/ChangeLog	2019-12-18 23:47:55 UTC (rev 253726)
@@ -1,3 +1,7 @@
+2019-12-18  Alan Coon  
+
+Revert r253493. rdar://problem/58028534
+
 2019-12-14  Per Arne Vollan  
 
 [iOS] Deny mach lookup access to "*.viewservice" in the WebContent process


Modified: branches/safari-609.1.13-branch/LayoutTests/imported/w3c/ChangeLog (253725 => 253726)

--- branches/safari-609.1.13-branch/LayoutTests/imported/w3c/ChangeLog	2019-12-18 23:21:55 UTC (rev 253725)
+++ branches/safari-609.1.13-branch/LayoutTests/imported/w3c/ChangeLog	2019-12-18 23:47:55 UTC (rev 253726)
@@ -1,3 +1,7 @@
+2019-12-18  Alan Coon  
+
+Revert r253493. rdar://problem/58028534
+
 2019-12-13  Chris Dumez  
 
 Implement PostMessageOptions for postMessage


Modified: branches/safari-609.1.13-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3-expected.txt (253725 => 253726)

--- branches/safari-609.1.13-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3-expected.txt	2019-12-18 23:21:55 UTC (rev 253725)
+++ branches/safari-609.1.13-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3-expected.txt	2019-12-18 23:47:55 UTC (rev 253726)
@@ -4,5 +4,5 @@
 
 submit
 
-PASS  should have the same double-submit protection as  
+FAIL  should have the same double-submit protection as  assert_unreached: Frame1 should not get navigated by this test. Reached unreachable code
 


Modified: branches/safari-609.1.13-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-expected.txt (253725 => 253726)

--- branches/safari-609.1.13-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-expected.txt	2019-12-18 23:21:55 UTC (rev 253725)
+++ branches/safari-609.1.13-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-expected.txt	2019-12-18 23:47:55 UTC (rev 253726)
@@ -4,5 +4,5 @@
 
 
 
-PASS default submit action should supersede onclick submit() 
+FAIL default submit action should supersede onclick submit() assert_unreached: Frame1 should not get navigated by this test. Reached unreachable code
 


Modified: branches/safari-609.1.13-branch/LayoutTests/platform/mac/TestExpectations (253725 => 253726)

--- branches/safari-609.1.13-branch/LayoutTests/platform/mac/TestExpectations	2019-12-18 23:21:55 UTC (rev 253725)
+++ branches/safari-609.1.13-branch/LayoutTests/platform/mac/TestExpectations	2019-12-18 23:47:55 UTC (rev 253726)
@@ -1961,3 +1961,4 @@
 webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-8.html [ ImageOnlyFailure ]
 webkit.org/b/204820 [ Catalina+ ] fast/text/emoji-gender-9.html [ ImageOnlyFailure ]
 
+webkit.org/b/205164 imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3.html [ Pass Failure ]
\ No newline at end of file


Modified: branches/safari-609.1.13-branch/Source/WebCore/ChangeLog (253725 => 253726)

--- branches/safari-609.1.13-branch/Source/WebCore/ChangeLog	2019-12-18 23:21:55 UTC (rev 253725)
+++ branches/safari-609.1.13-branch/Source/WebCore/ChangeLog	2019-12-18 23:47:55 UTC (rev 253726)
@@ -1,3 +1,7 @@
+2019-12-18  Alan Coon  
+
+Revert r253493. rdar://problem/58028534
+
 2019-12-16  Alan Coon  
 
 Revert r253499. rdar://problem/57990824
@@ -1959,99 +1963,22 @@
 Implementation of the  quirk includes zeroing its height. This has no layout or rendering effects,
 it exists purely to maintain render tree dump output for tests.
 
-

[webkit-changes] [253725] tags/Safari-609.1.12.3/Source

[alancoon]

Title: [253725] tags/Safari-609.1.12.3/Source








Revision 253725
Author alanc...@apple.com
Date 2019-12-18 15:21:55 -0800 (Wed, 18 Dec 2019)


Log Message
Versioning.

Modified Paths

tags/Safari-609.1.12.3/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-609.1.12.3/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
tags/Safari-609.1.12.3/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-609.1.12.3/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-609.1.12.3/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-609.1.12.3/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-609.1.12.3/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-609.1.12.3/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-609.1.12.3/Source/_javascript_Core/Configurations/Version.xcconfig (253724 => 253725)

--- tags/Safari-609.1.12.3/Source/_javascript_Core/Configurations/Version.xcconfig	2019-12-18 23:17:51 UTC (rev 253724)
+++ tags/Safari-609.1.12.3/Source/_javascript_Core/Configurations/Version.xcconfig	2019-12-18 23:21:55 UTC (rev 253725)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.3/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (253724 => 253725)

--- tags/Safari-609.1.12.3/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2019-12-18 23:17:51 UTC (rev 253724)
+++ tags/Safari-609.1.12.3/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2019-12-18 23:21:55 UTC (rev 253725)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.3/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (253724 => 253725)

--- tags/Safari-609.1.12.3/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-12-18 23:17:51 UTC (rev 253724)
+++ tags/Safari-609.1.12.3/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-12-18 23:21:55 UTC (rev 253725)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.3/Source/WebCore/Configurations/Version.xcconfig (253724 => 253725)

--- tags/Safari-609.1.12.3/Source/WebCore/Configurations/Version.xcconfig	2019-12-18 23:17:51 UTC (rev 253724)
+++ tags/Safari-609.1.12.3/Source/WebCore/Configurations/Version.xcconfig	2019-12-18 23:21:55 UTC (rev 253725)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.3/Source/WebCore/PAL/Configurations/Version.xcconfig (253724 => 253725)

--- tags/Safari-609.1.12.3/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-12-18 23:17:51 UTC (rev 253724)
+++ tags/Safari-609.1.12.3/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-12-18 23:21:55 UTC (rev 253725)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.3/Source/WebInspectorUI/Configurations/Version.xcconfig (253724 => 253725)

--- tags/Safari-609.1.12.3/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-12-18 23:17:51 UTC (rev 253724)
+++ tags/Safari-609.1.12.3/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-12-18 23:21:55 UTC (rev 253725)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.3/Source/WebKit/Configurations/Version.xcconfig (253724 => 253725)

--- tags/Safari-609.1.12.3/Source/WebKit/Configurations/Version.xcconfig	2019-12-18 23:17:51 UTC (rev 253724)
+++ tags/Safari-609.1.12.3/Source/WebKit/Configurations/Version.xcconfig	2019-12-18 23:21:55 UTC (rev 253725)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.3/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (253724 => 253725)

--- tags/Safari-609.1.12.3/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-12-18 23:17:51 UTC (rev 

[webkit-changes] [253724] tags/Safari-609.1.12.3/

[alancoon]

Title: [253724] tags/Safari-609.1.12.3/








Revision 253724
Author alanc...@apple.com
Date 2019-12-18 15:17:51 -0800 (Wed, 18 Dec 2019)


Log Message
New tag.

Added Paths

tags/Safari-609.1.12.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253723] trunk

[achristensen]

Title: [253723] trunk








Revision 253723
Author achristen...@apple.com
Date 2019-12-18 14:52:03 -0800 (Wed, 18 Dec 2019)


Log Message
Add ObjC version of WKBundleFrameIsMainFrame
https://bugs.webkit.org/show_bug.cgi?id=205415

Reviewed by Brian Weinstein.

Source/WebKit:

I need this for rdar://problem/57132290
Covered by API tests.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame isMainFrame]):
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
(-[UserContentWorldRemoteObject didObserveMainFrame]):
(-[UserContentWorldRemoteObject didObserveSubframe]):
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/UserContentWorldPlugIn.mm:
(-[UserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
* TestWebKitAPI/Tests/WebKitCocoa/UserContentWorldProtocol.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h
trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm
trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserContentWorldPlugIn.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UserContentWorldProtocol.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (253722 => 253723)

--- trunk/Source/WebKit/ChangeLog	2019-12-18 22:29:38 UTC (rev 253722)
+++ trunk/Source/WebKit/ChangeLog	2019-12-18 22:52:03 UTC (rev 253723)
@@ -1,3 +1,18 @@
+2019-12-18  Alex Christensen  
+
+Add ObjC version of WKBundleFrameIsMainFrame
+https://bugs.webkit.org/show_bug.cgi?id=205415
+
+Reviewed by Brian Weinstein.
+
+I need this for rdar://problem/57132290
+Covered by API tests.
+
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
+(-[WKWebProcessPlugInFrame isMainFrame]):
+* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
+
 2019-12-18  Eric Carlson  
 
 Remove more unused MediaPlayer methods


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h (253722 => 253723)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h	2019-12-18 22:29:38 UTC (rev 253722)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h	2019-12-18 22:52:03 UTC (rev 253723)
@@ -41,6 +41,7 @@
 @property (nonatomic, readonly) NSURL *URL;
 @property (nonatomic, readonly) NSArray *childFrames;
 @property (nonatomic, readonly) BOOL containsAnyFormElements;
+@property (nonatomic, readonly) BOOL isMainFrame;
 
 @property (nonatomic, readonly) _WKFrameHandle *handle;
 


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm (253722 => 253723)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm	2019-12-18 22:29:38 UTC (rev 253722)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm	2019-12-18 22:52:03 UTC (rev 253723)
@@ -99,6 +99,11 @@
 return !!_frame->containsAnyFormElements();
 }
 
+- (BOOL)isMainFrame
+{
+return !!_frame->isMainFrame();
+}
+
 - (_WKFrameHandle *)handle
 {
 return wrapper(API::FrameHandle::create(_frame->frameID()));


Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h (253722 => 253723)

--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h	2019-12-18 22:29:38 UTC (rev 253722)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h	2019-12-18 22:52:03 UTC (rev 253723)
@@ -27,7 +27,7 @@
 #import 
 #import 
 
-@class WKWebProcessPlugInBrowsingContextController;
+@class WKWebProcessPlugInBrowserContextController;
 @class WKWebProcessPlugInFrame;
 @class WKWebProcessPlugInScriptWorld;
 


Modified: trunk/Tools/ChangeLog (253722 => 253723)

--- trunk/Tools/ChangeLog	2019-12-18 22:29:38 UTC (rev 253722)
+++ trunk/Tools/ChangeLog	2019-12-18 22:52:03 UTC (rev 253723)
@@ -1,3 +1,18 @@
+2019-12-18  Alex Christensen  
+
+Add ObjC version of WKBundleFrameIsMainFrame
+https://bugs.webkit.org/show_bug.cgi?id=205415
+
+Reviewed by Brian Weinstein.
+
+* TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
+(-[UserContentWorldRemoteObject didObserveMainFrame]):
+(-[UserContentWorldRemoteObject didObserveSubframe]):
+(TEST):
+* TestWebKitAPI/Tests/WebKitCocoa/UserContentWorldPlugIn.mm:
+(-[UserContentWorldPlugIn 

[webkit-changes] [253722] trunk/Source

[eric . carlson]

Title: [253722] trunk/Source








Revision 253722
Author eric.carl...@apple.com
Date 2019-12-18 14:29:38 -0800 (Wed, 18 Dec 2019)


Log Message
Remove more unused MediaPlayer methods
https://bugs.webkit.org/show_bug.cgi?id=205405


Reviewed by Jer Noble.

Source/WebCore:

No new tests, this just removes unused code.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerIsInMediaDocument const): Deleted.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::inMediaDocument const): Deleted.
(WebCore::MediaPlayer::handlePlaybackCommand): Deleted.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerPlatformVolumeConfigurationRequired const):
(WebCore::MediaPlayerClient::mediaPlayerHandlePlaybackCommand): Deleted.
(WebCore::MediaPlayerClient::mediaPlayerIsInMediaDocument const): Deleted.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::requestedRate const): Deleted.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::metaDataAvailable const):
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::platformPlay):

Source/WebKit:

* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerHandlePlaybackCommand): Deleted.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerIsInMediaDocument const): Deleted.
* GPUProcess/media/RemoteMediaPlayerProxy.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (253721 => 253722)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 22:22:24 UTC (rev 253721)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 22:29:38 UTC (rev 253722)
@@ -1,3 +1,30 @@
+2019-12-18  Eric Carlson  
+
+Remove more unused MediaPlayer methods
+https://bugs.webkit.org/show_bug.cgi?id=205405
+
+
+Reviewed by Jer Noble.
+
+No new tests, this just removes unused code.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::mediaPlayerIsInMediaDocument const): Deleted.
+* html/HTMLMediaElement.h:
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::inMediaDocument const): Deleted.
+(WebCore::MediaPlayer::handlePlaybackCommand): Deleted.
+* platform/graphics/MediaPlayer.h:
+(WebCore::MediaPlayerClient::mediaPlayerPlatformVolumeConfigurationRequired const):
+(WebCore::MediaPlayerClient::mediaPlayerHandlePlaybackCommand): Deleted.
+(WebCore::MediaPlayerClient::mediaPlayerIsInMediaDocument const): Deleted.
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+(WebCore::MediaPlayerPrivateAVFoundation::requestedRate const): Deleted.
+* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
+(WebCore::MediaPlayerPrivateAVFoundation::metaDataAvailable const):
+* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
+(WebCore::MediaPlayerPrivateAVFoundationCF::platformPlay):
+
 2019-12-18  Yury Semikhatsky  
 
 Web Inspector: Runtime.enable reports duplicates (non existent) contexts


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (253721 => 253722)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2019-12-18 22:22:24 UTC (rev 253721)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2019-12-18 22:29:38 UTC (rev 253722)
@@ -7152,11 +7152,6 @@
 }
 #endif
 
-bool HTMLMediaElement::mediaPlayerIsInMediaDocument() const
-{
-return document().isMediaDocument();
-}
-
 void HTMLMediaElement::mediaPlayerEngineFailedToLoad() const
 {
 if (!m_player)


Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (253721 => 253722)

--- trunk/Source/WebCore/html/HTMLMediaElement.h	2019-12-18 22:22:24 UTC (rev 253721)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h	2019-12-18 22:29:38 UTC (rev 253722)
@@ -733,7 +733,6 @@
 
 void mediaPlayerActiveSourceBuffersChanged() override;
 
-void mediaPlayerHandlePlaybackCommand(PlatformMediaSession::RemoteControlCommandType command) override { didReceiveRemoteControlCommand(command, nullptr); }
 String sourceApplicationIdentifier() const override;
 String mediaPlayerSourceApplicationIdentifier() const 

[webkit-changes] [253721] trunk/Tools

[jbedard]

Title: [253721] trunk/Tools








Revision 253721
Author jbed...@apple.com
Date 2019-12-18 14:22:24 -0800 (Wed, 18 Dec 2019)


Log Message
results.webkit.org: Serve files in uploaded archive
https://bugs.webkit.org/show_bug.cgi?id=201654

Reviewed by Stephanie Lewis.

* resultsdbpy/resultsdbpy/controller/configuration.py:
(Configuration.to_query): Conver a configuration object to a query string.
* resultsdbpy/resultsdbpy/controller/configuration_unittest.py:
(ConfigurationUnittest):
(ConfigurationUnittest.test_to_query):
* resultsdbpy/resultsdbpy/flask_support/util.py:
(query_as_string): Convert the current query to a string.
* resultsdbpy/resultsdbpy/model/archive_context.py:
(ArchiveContext._files_for_archive): Python's shutil creates archives which
don't have have a root directory.
(ArchiveContext.file): We need to add query parameters to relative links
In the returned file.
* resultsdbpy/resultsdbpy/view/archive_view.py: Added.
(ArchiveView):
(ArchiveView.__init__):
(ArchiveView.list): Return html which lists and links to the provided paths.
(ArchiveView.extract): Endpoint which extracts a file from an archive matching
the provided arguments.
* resultsdbpy/resultsdbpy/view/archive_view_unittest.py: Added.
(ArchiveViewUnittest):
(ArchiveViewUnittest.register_archive):
(ArchiveViewUnittest.test_directory):
(ArchiveViewUnittest.test_file):
* resultsdbpy/resultsdbpy/view/templates/archive_list.html: Added.
* resultsdbpy/resultsdbpy/view/view_routes.py:
(ViewRoutes.__init__): Add archive endpoints.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/controller/configuration.py
trunk/Tools/resultsdbpy/resultsdbpy/controller/configuration_unittest.py
trunk/Tools/resultsdbpy/resultsdbpy/flask_support/util.py
trunk/Tools/resultsdbpy/resultsdbpy/model/archive_context.py
trunk/Tools/resultsdbpy/resultsdbpy/view/view_routes.py


Added Paths

trunk/Tools/resultsdbpy/resultsdbpy/view/archive_view.py
trunk/Tools/resultsdbpy/resultsdbpy/view/archive_view_unittest.py
trunk/Tools/resultsdbpy/resultsdbpy/view/templates/archive_list.html




Diff

Modified: trunk/Tools/ChangeLog (253720 => 253721)

--- trunk/Tools/ChangeLog	2019-12-18 22:20:55 UTC (rev 253720)
+++ trunk/Tools/ChangeLog	2019-12-18 22:22:24 UTC (rev 253721)
@@ -1,3 +1,37 @@
+2019-12-18  Jonathan Bedard  
+
+results.webkit.org: Serve files in uploaded archive
+https://bugs.webkit.org/show_bug.cgi?id=201654
+
+Reviewed by Stephanie Lewis.
+
+* resultsdbpy/resultsdbpy/controller/configuration.py:
+(Configuration.to_query): Conver a configuration object to a query string.
+* resultsdbpy/resultsdbpy/controller/configuration_unittest.py:
+(ConfigurationUnittest):
+(ConfigurationUnittest.test_to_query):
+* resultsdbpy/resultsdbpy/flask_support/util.py:
+(query_as_string): Convert the current query to a string.
+* resultsdbpy/resultsdbpy/model/archive_context.py:
+(ArchiveContext._files_for_archive): Python's shutil creates archives which
+don't have have a root directory.
+(ArchiveContext.file): We need to add query parameters to relative links
+In the returned file.
+* resultsdbpy/resultsdbpy/view/archive_view.py: Added.
+(ArchiveView):
+(ArchiveView.__init__):
+(ArchiveView.list): Return html which lists and links to the provided paths.
+(ArchiveView.extract): Endpoint which extracts a file from an archive matching
+the provided arguments.
+* resultsdbpy/resultsdbpy/view/archive_view_unittest.py: Added.
+(ArchiveViewUnittest):
+(ArchiveViewUnittest.register_archive):
+(ArchiveViewUnittest.test_directory):
+(ArchiveViewUnittest.test_file):
+* resultsdbpy/resultsdbpy/view/templates/archive_list.html: Added.
+* resultsdbpy/resultsdbpy/view/view_routes.py:
+(ViewRoutes.__init__): Add archive endpoints.
+
 2019-12-18  Matt Lewis  
 
 Update WebGL bot hostname


Modified: trunk/Tools/resultsdbpy/resultsdbpy/controller/configuration.py (253720 => 253721)

--- trunk/Tools/resultsdbpy/resultsdbpy/controller/configuration.py	2019-12-18 22:20:55 UTC (rev 253720)
+++ trunk/Tools/resultsdbpy/resultsdbpy/controller/configuration.py	2019-12-18 22:22:24 UTC (rev 253721)
@@ -184,6 +184,23 @@
 def to_json(self, pretty_print=False):
 return json.dumps(self, cls=self.Encoder, sort_keys=pretty_print, indent=4 if pretty_print else None)
 
+def to_query(self):
+query = ''
+for member in self.REQUIRED_MEMBERS + self.OPTIONAL_MEMBERS + self.FILTERING_MEMBERS:
+value = getattr(self, member)
+if value is None:
+continue
+
+if member == 'version':
+query += f'{member}={self.integer_to_version(value)}&'
+elif member == 'is_simulator':
+query += f"{member}={'True' if value else 'False'}&"
+

[webkit-changes] [253720] branches/safari-608-branch/Source/WebCore

[alancoon]

Title: [253720] branches/safari-608-branch/Source/WebCore








Revision 253720
Author alanc...@apple.com
Date 2019-12-18 14:20:55 -0800 (Wed, 18 Dec 2019)


Log Message
Cherry-pick r253654. rdar://problem/58049166

executeIfJavaScriptURL should check requester's security origin
https://bugs.webkit.org/show_bug.cgi?id=205324

Reviewed by Brent Fulgham.

Don't execute the _javascript_ in ScriptController::executeIfJavaScriptURL if the security origin
of the current document is no longer accessible from the request originator's security origin.

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL): Added a check.
* bindings/js/ScriptController.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected): Pass around the security origin of the requester.
(WebCore::FrameLoader::submitForm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/bindings/js/ScriptController.cpp
branches/safari-608-branch/Source/WebCore/bindings/js/ScriptController.h
branches/safari-608-branch/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (253719 => 253720)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-12-18 22:05:47 UTC (rev 253719)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-12-18 22:20:55 UTC (rev 253720)
@@ -1,5 +1,43 @@
 2019-12-18  Dan Robson  
 
+Cherry-pick r253654. rdar://problem/58049166
+
+executeIfJavaScriptURL should check requester's security origin
+https://bugs.webkit.org/show_bug.cgi?id=205324
+
+Reviewed by Brent Fulgham.
+
+Don't execute the _javascript_ in ScriptController::executeIfJavaScriptURL if the security origin
+of the current document is no longer accessible from the request originator's security origin.
+
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::executeIfJavaScriptURL): Added a check.
+* bindings/js/ScriptController.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::urlSelected): Pass around the security origin of the requester.
+(WebCore::FrameLoader::submitForm):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-12-17  Ryosuke Niwa  
+
+executeIfJavaScriptURL should check requester's security origin
+https://bugs.webkit.org/show_bug.cgi?id=205324
+
+Reviewed by Brent Fulgham.
+
+Don't execute the _javascript_ in ScriptController::executeIfJavaScriptURL if the security origin
+of the current document is no longer accessible from the request originator's security origin.
+
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::executeIfJavaScriptURL): Added a check.
+* bindings/js/ScriptController.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::urlSelected): Pass around the security origin of the requester.
+(WebCore::FrameLoader::submitForm):
+
+2019-12-18  Dan Robson  
+
 Cherry-pick r253662. rdar://problem/58049156
 
 Limit URL to reasonable size


Modified: branches/safari-608-branch/Source/WebCore/bindings/js/ScriptController.cpp (253719 => 253720)

--- branches/safari-608-branch/Source/WebCore/bindings/js/ScriptController.cpp	2019-12-18 22:05:47 UTC (rev 253719)
+++ branches/safari-608-branch/Source/WebCore/bindings/js/ScriptController.cpp	2019-12-18 22:20:55 UTC (rev 253720)
@@ -615,11 +615,14 @@
 return evaluate(sourceCode, exceptionDetails);
 }
 
-bool ScriptController::executeIfJavaScriptURL(const URL& url, ShouldReplaceDocumentIfJavaScriptURL shouldReplaceDocumentIfJavaScriptURL)
+bool ScriptController::executeIfJavaScriptURL(const URL& url, RefPtr requesterSecurityOrigin, ShouldReplaceDocumentIfJavaScriptURL shouldReplaceDocumentIfJavaScriptURL)
 {
 if (!WTF::protocolIsJavaScript(url))
 return false;
 
+if (requesterSecurityOrigin && !requesterSecurityOrigin->canAccess(m_frame.document()->securityOrigin()))
+return true;
+
 if (!m_frame.page() || !m_frame.document()->contentSecurityPolicy()->allowJavaScriptURLs(m_frame.document()->url(), eventHandlerPosition().m_line))
 return true;
 


Modified: branches/safari-608-branch/Source/WebCore/bindings/js/ScriptController.h (253719 => 253720)

--- branches/safari-608-branch/Source/WebCore/bindings/js/ScriptController.h	2019-12-18 22:05:47 UTC (rev 253719)
+++ branches/safari-608-branch/Source/WebCore/bindings/js/ScriptController.h	2019-12-18 22:20:55 UTC (rev 253720)
@@ -27,6 +27,7 @@
 #include <_javascript_Core/JSBase.h>
 #include <_javascript_Core/Strong.h>
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -96,7 +97,7 @@
 bool 

[webkit-changes] [253719] trunk/Tools

[jlewis3]

Title: [253719] trunk/Tools








Revision 253719
Author jlew...@apple.com
Date 2019-12-18 14:05:47 -0800 (Wed, 18 Dec 2019)


Log Message
Update WebGL bot hostname
https://bugs.webkit.org/show_bug.cgi?id=205349

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/build.webkit.org-config/config.json: Changed hostname
to bring it in line with non standard testers.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (253718 => 253719)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2019-12-18 22:05:27 UTC (rev 253718)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2019-12-18 22:05:47 UTC (rev 253719)
@@ -14,7 +14,7 @@
 { "name": "bot247", "platform": "mac-catalina" },
 { "name": "bot248", "platform": "mac-catalina" },
 { "name": "bot121", "platform": "mac-catalina" },
-{ "name": "bot659", "platform": "mac-catalina" },
+{ "name": "bot302", "platform": "mac-catalina" },
 { "name": "bot301", "platform": "mac-catalina" },
 
 { "name": "bot132", "platform": "mac-mojave" },
@@ -119,7 +119,7 @@
 { "name": "Apple-Catalina-Debug-WK2-WebGL-Tests", "type": "TestAllButJSC", "builddir": "catalina-debug-tests-wk2-webgl",
   "platform": "mac-catalina", "configuration": "debug", "architectures": ["x86_64"],
   "additionalArguments": ["--no-retry-failures", "--webgl-test-suite"],
-  "slavenames": ["bot659"]
+  "slavenames": ["bot302"]
 },
 { "name": "Apple-Catalina-Debug-WK2-GPUProcess-Tests", "type": "TestAllButJSC", "builddir": "catalina-debug-tests-wk2-gpuprocess",
   "platform": "mac-catalina", "configuration": "debug", "architectures": ["x86_64"],


Modified: trunk/Tools/ChangeLog (253718 => 253719)

--- trunk/Tools/ChangeLog	2019-12-18 22:05:27 UTC (rev 253718)
+++ trunk/Tools/ChangeLog	2019-12-18 22:05:47 UTC (rev 253719)
@@ -1,3 +1,13 @@
+2019-12-18  Matt Lewis  
+
+Update WebGL bot hostname
+https://bugs.webkit.org/show_bug.cgi?id=205349
+
+Reviewed by Jonathan Bedard.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json: Changed hostname 
+to bring it in line with non standard testers.
+
 2019-12-18  Jonathan Bedard  
 
 GPU-Process: Bring up automated tester 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253718] trunk

[yurys]

Title: [253718] trunk








Revision 253718
Author yu...@chromium.org
Date 2019-12-18 14:05:27 -0800 (Wed, 18 Dec 2019)


Log Message
Web Inspector: Runtime.enable reports duplicates (non existent) contexts
https://bugs.webkit.org/show_bug.cgi?id=204859

Reviewed by Devin Rousso.

Source/WebCore:

Do not report main world context as non-main world one when Runtime.enable is called.

Test: inspector/runtime/executionContextCreated-onEnable.html

* inspector/agents/page/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):

Source/WebInspectorUI:

Assert that all contexts added to the list are unique.

* UserInterface/Models/ExecutionContextList.js:
(WI.ExecutionContextList.prototype.add):

LayoutTests:

Test that only existing contexts are reported.

* http/tests/inspector/resources/stable-id-map.js: Added.
(TestPage.registerInitializer.window.StableIdMap):
(TestPage.registerInitializer.window.StableIdMap.prototype.get size):
(TestPage.registerInitializer.window.StableIdMap.prototype.get let):
(TestPage.registerInitializer):
* http/tests/inspector/target/provisional-load-cancels-previous-load.html:
* inspector/runtime/executionContextCreated-onEnable-expected.txt: Added.
* inspector/runtime/executionContextCreated-onEnable.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load-expected.txt
trunk/LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/page/PageRuntimeAgent.cpp
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/ExecutionContextList.js


Added Paths

trunk/LayoutTests/http/tests/inspector/resources/stable-id-map.js
trunk/LayoutTests/inspector/runtime/executionContextCreated-onEnable-expected.txt
trunk/LayoutTests/inspector/runtime/executionContextCreated-onEnable.html




Diff

Modified: trunk/LayoutTests/ChangeLog (253717 => 253718)

--- trunk/LayoutTests/ChangeLog	2019-12-18 22:03:54 UTC (rev 253717)
+++ trunk/LayoutTests/ChangeLog	2019-12-18 22:05:27 UTC (rev 253718)
@@ -1,3 +1,21 @@
+2019-12-18  Yury Semikhatsky  
+
+Web Inspector: Runtime.enable reports duplicates (non existent) contexts
+https://bugs.webkit.org/show_bug.cgi?id=204859
+
+Reviewed by Devin Rousso.
+
+Test that only existing contexts are reported.
+
+* http/tests/inspector/resources/stable-id-map.js: Added.
+(TestPage.registerInitializer.window.StableIdMap):
+(TestPage.registerInitializer.window.StableIdMap.prototype.get size):
+(TestPage.registerInitializer.window.StableIdMap.prototype.get let):
+(TestPage.registerInitializer):
+* http/tests/inspector/target/provisional-load-cancels-previous-load.html:
+* inspector/runtime/executionContextCreated-onEnable-expected.txt: Added.
+* inspector/runtime/executionContextCreated-onEnable.html: Added.
+
 2019-12-18  youenn fablet  
 
 Add support for Audio Capture in GPUProcess


Added: trunk/LayoutTests/http/tests/inspector/resources/stable-id-map.js (0 => 253718)

--- trunk/LayoutTests/http/tests/inspector/resources/stable-id-map.js	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/resources/stable-id-map.js	2019-12-18 22:05:27 UTC (rev 253718)
@@ -0,0 +1,52 @@
+/*
+ * Copyright (C) 2019 Microsoft Corporation. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Microsoft Corporation nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * 

[webkit-changes] [253717] trunk/Source/WebCore

[antti]

Title: [253717] trunk/Source/WebCore








Revision 253717
Author an...@apple.com
Date 2019-12-18 14:03:54 -0800 (Wed, 18 Dec 2019)


Log Message
Optimize Style::Invalidator for multiple RuleSet case
https://bugs.webkit.org/show_bug.cgi?id=205406

Reviewed by Zalan Bujtas.

* style/StyleInvalidator.cpp:
(WebCore::Style::m_dirtiesAllStyle):
(WebCore::Style::Invalidator::Invalidator):
(WebCore::Style::Invalidator::collectRuleInformation):

Collect bunch of bits so we don't need to traverse again.

(WebCore::Style::Invalidator::invalidateIfNeeded):

Bail out when we find a reson to invalidate.

(WebCore::Style::Invalidator::invalidateStyle):
(WebCore::Style::Invalidator::invalidateInShadowTreeIfNeeded):
* style/StyleInvalidator.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleInvalidator.cpp
trunk/Source/WebCore/style/StyleInvalidator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (253716 => 253717)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 21:47:05 UTC (rev 253716)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 22:03:54 UTC (rev 253717)
@@ -1,3 +1,25 @@
+2019-12-18  Antti Koivisto  
+
+Optimize Style::Invalidator for multiple RuleSet case
+https://bugs.webkit.org/show_bug.cgi?id=205406
+
+Reviewed by Zalan Bujtas.
+
+* style/StyleInvalidator.cpp:
+(WebCore::Style::m_dirtiesAllStyle):
+(WebCore::Style::Invalidator::Invalidator):
+(WebCore::Style::Invalidator::collectRuleInformation):
+
+Collect bunch of bits so we don't need to traverse again.
+
+(WebCore::Style::Invalidator::invalidateIfNeeded):
+
+Bail out when we find a reson to invalidate.
+
+(WebCore::Style::Invalidator::invalidateStyle):
+(WebCore::Style::Invalidator::invalidateInShadowTreeIfNeeded):
+* style/StyleInvalidator.h:
+
 2019-12-18  Andres Gonzalez  
 
 AXIsolatedObject support for spin button increment/decrementButton.


Modified: trunk/Source/WebCore/style/StyleInvalidator.cpp (253716 => 253717)

--- trunk/Source/WebCore/style/StyleInvalidator.cpp	2019-12-18 21:47:05 UTC (rev 253716)
+++ trunk/Source/WebCore/style/StyleInvalidator.cpp	2019-12-18 22:03:54 UTC (rev 253717)
@@ -93,26 +93,38 @@
 m_ownedRuleSet->disableAutoShrinkToFit();
 for (auto& sheet : sheets)
 m_ownedRuleSet->addRulesFromSheet(*sheet, mediaQueryEvaluator);
+
+m_ruleInformation = collectRuleInformation();
 }
 
 Invalidator::Invalidator(const Vector& ruleSets)
 : m_ruleSets(ruleSets)
+, m_ruleInformation(collectRuleInformation())
 {
 ASSERT(m_ruleSets.size());
 }
 
+Invalidator::RuleInformation Invalidator::collectRuleInformation()
+{
+RuleInformation information;
+for (auto* ruleSet : m_ruleSets) {
+if (!ruleSet->slottedPseudoElementRules().isEmpty())
+information.hasSlottedPseudoElementRules = true;
+if (!ruleSet->hostPseudoClassRules().isEmpty())
+information.hasHostPseudoClassRules = true;
+if (ruleSet->hasShadowPseudoElementRules())
+information.hasShadowPseudoElementRules = true;
+if (!ruleSet->partPseudoElementRules().isEmpty())
+information.hasPartPseudoElementRules = true;
+}
+return information;
+}
+
 Invalidator::CheckDescendants Invalidator::invalidateIfNeeded(Element& element, const SelectorFilter* filter)
 {
 invalidateInShadowTreeIfNeeded(element);
 
-bool shouldCheckForSlots = [&] {
-for (auto* ruleSet : m_ruleSets) {
-if (!ruleSet->slottedPseudoElementRules().isEmpty() && !m_didInvalidateHostChildren)
-return true;
-}
-return false;
-}();
-
+bool shouldCheckForSlots = m_ruleInformation.hasSlottedPseudoElementRules && !m_didInvalidateHostChildren;
 if (shouldCheckForSlots && is(element)) {
 auto* containingShadowRoot = element.containingShadowRoot();
 if (containingShadowRoot && containingShadowRoot->host()) {
@@ -129,8 +141,10 @@
 ElementRuleCollector ruleCollector(element, *ruleSet, filter);
 ruleCollector.setMode(SelectorChecker::Mode::CollectingRulesIgnoringVirtualPseudoElements);
 
-if (ruleCollector.matchesAnyAuthorRules())
+if (ruleCollector.matchesAnyAuthorRules()) {
 element.invalidateStyleInternal();
+break;
+}
 }
 
 return CheckDescendants::Yes;
@@ -200,10 +214,8 @@
 {
 ASSERT(!m_dirtiesAllStyle);
 
-for (auto* ruleSet : m_ruleSets) {
-if (!ruleSet->hostPseudoClassRules().isEmpty() && shadowRoot.host())
-shadowRoot.host()->invalidateStyleInternal();
-}
+if (m_ruleInformation.hasHostPseudoClassRules && shadowRoot.host())
+shadowRoot.host()->invalidateStyleInternal();
 
 for (auto& child : childrenOfType(shadowRoot)) {
 SelectorFilter filter;
@@ -297,17 +309,13 @@
 if (!shadowRoot)
 return;
 
+// FIXME: 

[webkit-changes] [253716] trunk/Source/WebCore

[andresg_22]

Title: [253716] trunk/Source/WebCore








Revision 253716
Author andresg...@apple.com
Date 2019-12-18 13:47:05 -0800 (Wed, 18 Dec 2019)


Log Message
AXIsolatedObject support for spin button increment/decrementButton.
https://bugs.webkit.org/show_bug.cgi?id=205356

Reviewed by Chris Fleizach.

Several LayoutTests exercise this functionality.

- Exposed increment/decrementButton in AXCoreObject in order to
properly support it in AXIsolatedObject.
- Used AXCoreObject::increment/decrementButton in the wrapper instead
of downcasting to an implementation class, which does not work for an
isolated object.
- Implemented AXIsolatedObject::isDetachedFromParent.
- Fixed initialization of AXIsolatedObject::m_parent and m_id.

* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityObjectInterface.h:
* accessibility/AccessibilitySpinButton.h:
* accessibility/isolatedtree/AXIsolatedTreeNode.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::isDetachedFromParent):
(WebCore::AXIsolatedObject::isAccessibilityScrollView const):
* accessibility/isolatedtree/AXIsolatedTreeNode.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h
trunk/Source/WebCore/accessibility/AccessibilitySpinButton.h
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (253715 => 253716)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 21:44:01 UTC (rev 253715)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 21:47:05 UTC (rev 253716)
@@ -1,3 +1,31 @@
+2019-12-18  Andres Gonzalez  
+
+AXIsolatedObject support for spin button increment/decrementButton.
+https://bugs.webkit.org/show_bug.cgi?id=205356
+
+Reviewed by Chris Fleizach.
+
+Several LayoutTests exercise this functionality.
+
+- Exposed increment/decrementButton in AXCoreObject in order to
+properly support it in AXIsolatedObject.
+- Used AXCoreObject::increment/decrementButton in the wrapper instead
+of downcasting to an implementation class, which does not work for an
+isolated object.
+- Implemented AXIsolatedObject::isDetachedFromParent.
+- Fixed initialization of AXIsolatedObject::m_parent and m_id.
+
+* accessibility/AccessibilityObject.h:
+* accessibility/AccessibilityObjectInterface.h:
+* accessibility/AccessibilitySpinButton.h:
+* accessibility/isolatedtree/AXIsolatedTreeNode.cpp:
+(WebCore::AXIsolatedObject::initializeAttributeData):
+(WebCore::AXIsolatedObject::isDetachedFromParent):
+(WebCore::AXIsolatedObject::isAccessibilityScrollView const):
+* accessibility/isolatedtree/AXIsolatedTreeNode.h:
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
 2019-12-18  Zalan Bujtas  
 
 [LFC][IFC] LineLayoutContext::m_uncommittedList is not always a continuous list of runs


Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (253715 => 253716)

--- trunk/Source/WebCore/accessibility/AccessibilityObject.h	2019-12-18 21:44:01 UTC (rev 253715)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h	2019-12-18 21:47:05 UTC (rev 253716)
@@ -164,6 +164,8 @@
 bool isMenuListPopup() const override { return false; }
 bool isMenuListOption() const override { return false; }
 bool isNativeSpinButton() const override { return false; }
+AXCoreObject* incrementButton() override { return nullptr; }
+AXCoreObject* decrementButton() override { return nullptr; }
 bool isSpinButtonPart() const override { return false; }
 bool isMockObject() const override { return false; }
 virtual bool isMediaControlLabel() const { return false; }


Modified: trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h (253715 => 253716)

--- trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h	2019-12-18 21:44:01 UTC (rev 253715)
+++ trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h	2019-12-18 21:47:05 UTC (rev 253716)
@@ -535,9 +535,14 @@
 virtual bool isMenuList() const = 0;
 virtual bool isMenuListPopup() const = 0;
 virtual bool isMenuListOption() const = 0;
+
+// Native spin buttons.
 bool isSpinButton() const { return roleValue() == AccessibilityRole::SpinButton; }
 virtual bool isNativeSpinButton() const = 0;
+virtual AXCoreObject* incrementButton() = 0;
+virtual AXCoreObject* decrementButton() = 0;
 virtual bool isSpinButtonPart() const = 0;
+
 virtual bool 

[webkit-changes] [253713] branches/safari-608-branch

[alancoon]

Title: [253713] branches/safari-608-branch








Revision 253713
Author alanc...@apple.com
Date 2019-12-18 13:43:56 -0800 (Wed, 18 Dec 2019)


Log Message
Cherry-pick r253563. rdar://problem/58049160

Consider top-level context whose origin is unique as insecure
https://bugs.webkit.org/show_bug.cgi?id=205111
Source/WebCore:

Reviewed by Brent Fulgham.

Tests: http/tests/security/top-level-unique-origin.https.html
   http/tests/security/top-level-unique-origin2.https.html

* dom/Document.cpp:
(WebCore::Document::isSecureContext const):
There is no guarantee that top level unique origin contexts like data URL are SecureContext.
This patch makes them no longer SecureContext.
This helps getting closer to https://w3c.github.io/webappsec-secure-contexts/#is-url-trustworthy
which identifies all unique origins as "Not Trustworthy".
Child unique origin contexts will stay SecureContext if their parents are.

Tools:



Reviewed by Brent Fulgham.

* TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
(TEST):
Disable secure context checks so that loading directly about:blank from the API test
can call DeviceOrientationEvent.requestPermission() successfully.

LayoutTests:

Reviewed by Brent Fulgham.

* http/tests/security/top-level-unique-origin.https-expected.txt: Added.
* http/tests/security/top-level-unique-origin.https.html: Added.
* http/tests/security/top-level-unique-origin2.https-expected.txt: Added.
* http/tests/security/top-level-unique-origin2.https.html: Added.
* platform/win/TestExpectations: Skipping second test as timing out in windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/platform/win/TestExpectations
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/dom/Document.cpp
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm


Added Paths

branches/safari-608-branch/LayoutTests/http/tests/security/top-level-unique-origin.https-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/security/top-level-unique-origin.https.html
branches/safari-608-branch/LayoutTests/http/tests/security/top-level-unique-origin2.https-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/security/top-level-unique-origin2.https.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (253712 => 253713)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-12-18 21:43:50 UTC (rev 253712)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-12-18 21:43:56 UTC (rev 253713)
@@ -1,5 +1,63 @@
 2019-12-18  Dan Robson  
 
+Cherry-pick r253563. rdar://problem/58049160
+
+Consider top-level context whose origin is unique as insecure
+https://bugs.webkit.org/show_bug.cgi?id=205111
+Source/WebCore:
+
+Reviewed by Brent Fulgham.
+
+Tests: http/tests/security/top-level-unique-origin.https.html
+   http/tests/security/top-level-unique-origin2.https.html
+
+* dom/Document.cpp:
+(WebCore::Document::isSecureContext const):
+There is no guarantee that top level unique origin contexts like data URL are SecureContext.
+This patch makes them no longer SecureContext.
+This helps getting closer to https://w3c.github.io/webappsec-secure-contexts/#is-url-trustworthy
+which identifies all unique origins as "Not Trustworthy".
+Child unique origin contexts will stay SecureContext if their parents are.
+
+Tools:
+
+
+
+Reviewed by Brent Fulgham.
+
+* TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
+(TEST):
+Disable secure context checks so that loading directly about:blank from the API test
+can call DeviceOrientationEvent.requestPermission() successfully.
+
+LayoutTests:
+
+Reviewed by Brent Fulgham.
+
+* http/tests/security/top-level-unique-origin.https-expected.txt: Added.
+* http/tests/security/top-level-unique-origin.https.html: Added.
+* http/tests/security/top-level-unique-origin2.https-expected.txt: Added.
+* http/tests/security/top-level-unique-origin2.https.html: Added.
+* platform/win/TestExpectations: Skipping second test as timing out in windows.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-12-16  youenn fablet  
+
+Consider top-level context whose origin is unique as insecure
+https://bugs.webkit.org/show_bug.cgi?id=205111
+
+Reviewed by Brent Fulgham.
+
+* http/tests/security/top-level-unique-origin.https-expected.txt: Added.
+* http/tests/security/top-level-unique-origin.https.html: Added.
+  

[webkit-changes] [253714] branches/safari-608-branch/Source/WebCore

[alancoon]

Title: [253714] branches/safari-608-branch/Source/WebCore








Revision 253714
Author alanc...@apple.com
Date 2019-12-18 13:43:58 -0800 (Wed, 18 Dec 2019)


Log Message
Cherry-pick r253653. rdar://problem/58049166

Document::setFocusedElement should not set m_focusedElement to an element in another document
https://bugs.webkit.org/show_bug.cgi?id=205325

Reviewed by Wenson Hsieh.

Added an early exit for when the newly focused element had moved
while blurring the previously focused element.

* dom/Document.cpp:
(WebCore::Document::setFocusedElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/dom/Document.cpp




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (253713 => 253714)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-12-18 21:43:56 UTC (rev 253713)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-12-18 21:43:58 UTC (rev 253714)
@@ -1,5 +1,36 @@
 2019-12-18  Dan Robson  
 
+Cherry-pick r253653. rdar://problem/58049166
+
+Document::setFocusedElement should not set m_focusedElement to an element in another document
+https://bugs.webkit.org/show_bug.cgi?id=205325
+
+Reviewed by Wenson Hsieh.
+
+Added an early exit for when the newly focused element had moved
+while blurring the previously focused element.
+
+* dom/Document.cpp:
+(WebCore::Document::setFocusedElement):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-12-16  Ryosuke Niwa  
+
+Document::setFocusedElement should not set m_focusedElement to an element in another document
+https://bugs.webkit.org/show_bug.cgi?id=205325
+
+Reviewed by Wenson Hsieh.
+
+Added an early exit for when the newly focused element had moved
+while blurring the previously focused element.
+
+* dom/Document.cpp:
+(WebCore::Document::setFocusedElement):
+
+2019-12-18  Dan Robson  
+
 Cherry-pick r253563. rdar://problem/58049160
 
 Consider top-level context whose origin is unique as insecure


Modified: branches/safari-608-branch/Source/WebCore/dom/Document.cpp (253713 => 253714)

--- branches/safari-608-branch/Source/WebCore/dom/Document.cpp	2019-12-18 21:43:56 UTC (rev 253713)
+++ branches/safari-608-branch/Source/WebCore/dom/Document.cpp	2019-12-18 21:43:58 UTC (rev 253714)
@@ -4181,6 +4181,11 @@
 }
 
 if (newFocusedElement && newFocusedElement->isFocusable()) {
+if (>document() != this) {
+// Bluring oldFocusedElement may have moved newFocusedElement across documents.
+focusChangeBlocked = true;
+goto SetFocusedNodeDone;
+}
 if (newFocusedElement->isRootEditableElement() && !acceptsEditingFocus(*newFocusedElement)) {
 // delegate blocks focus change
 focusChangeBlocked = true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253715] branches/safari-608-branch/Source/WebCore

[alancoon]

Title: [253715] branches/safari-608-branch/Source/WebCore








Revision 253715
Author alanc...@apple.com
Date 2019-12-18 13:44:01 -0800 (Wed, 18 Dec 2019)


Log Message
Cherry-pick r253662. rdar://problem/58049156

Limit URL to reasonable size
https://bugs.webkit.org/show_bug.cgi?id=203825


Reviewed by Ryosuke Niwa.

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canDisplay const): Place an upper bound on the amount of
memory a URL may consume.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/page/SecurityOrigin.cpp




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (253714 => 253715)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2019-12-18 21:43:58 UTC (rev 253714)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2019-12-18 21:44:01 UTC (rev 253715)
@@ -1,5 +1,33 @@
 2019-12-18  Dan Robson  
 
+Cherry-pick r253662. rdar://problem/58049156
+
+Limit URL to reasonable size
+https://bugs.webkit.org/show_bug.cgi?id=203825
+
+
+Reviewed by Ryosuke Niwa.
+
+* page/SecurityOrigin.cpp:
+(WebCore::SecurityOrigin::canDisplay const): Place an upper bound on the amount of
+memory a URL may consume.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-12-17  Brent Fulgham  
+
+Limit URL to reasonable size
+https://bugs.webkit.org/show_bug.cgi?id=203825
+
+
+Reviewed by Ryosuke Niwa.
+
+* page/SecurityOrigin.cpp:
+(WebCore::SecurityOrigin::canDisplay const): Place an upper bound on the amount of
+memory a URL may consume.
+
+2019-12-18  Dan Robson  
+
 Cherry-pick r253653. rdar://problem/58049166
 
 Document::setFocusedElement should not set m_focusedElement to an element in another document


Modified: branches/safari-608-branch/Source/WebCore/page/SecurityOrigin.cpp (253714 => 253715)

--- branches/safari-608-branch/Source/WebCore/page/SecurityOrigin.cpp	2019-12-18 21:43:58 UTC (rev 253714)
+++ branches/safari-608-branch/Source/WebCore/page/SecurityOrigin.cpp	2019-12-18 21:44:01 UTC (rev 253715)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2007-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2007-2019 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -45,6 +45,8 @@
 
 namespace WebCore {
 
+constexpr unsigned maximumURLSize = 0x8000;
+
 static bool schemeRequiresHost(const URL& url)
 {
 // We expect URLs with these schemes to have authority components. If the
@@ -356,6 +358,9 @@
 if (m_universalAccess)
 return true;
 
+if (url.pathEnd() > maximumURLSize)
+return false;
+
 #if !PLATFORM(IOS_FAMILY)
 if (m_data.protocol == "file" && url.isLocalFile() && !FileSystem::filesHaveSameVolume(m_filePath, url.fileSystemPath()))
 return false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253712] branches/safari-608-branch

[alancoon]

Title: [253712] branches/safari-608-branch








Revision 253712
Author alanc...@apple.com
Date 2019-12-18 13:43:50 -0800 (Wed, 18 Dec 2019)


Log Message
Cherry-pick r253544. rdar://problem/58049164

SecurityOrigin should be unique for null blob URLs that have been unregistered
https://bugs.webkit.org/show_bug.cgi?id=205169

Reviewed by Darin Adler.

Source/WebCore:

In case we cannot retrieve a cached origin for a null origin, just create a unique one.
This is better than having an origin with an empty host and empty scheme.

Test: http/tests/security/blob-null-url-location-origin.html

* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
(WebCore::ThreadableBlobRegistry::getCachedOrigin):

LayoutTests:

* http/tests/security/blob-null-url-location-origin-expected.txt: Added.
* http/tests/security/blob-null-url-location-origin.html: Added.
* platform/win/TestExpectations: Skipping test as timing out in windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/platform/win/TestExpectations
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/fileapi/ThreadableBlobRegistry.cpp


Added Paths

branches/safari-608-branch/LayoutTests/http/tests/security/blob-null-url-location-origin-expected.txt
branches/safari-608-branch/LayoutTests/http/tests/security/blob-null-url-location-origin.html




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (253711 => 253712)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-12-18 21:28:55 UTC (rev 253711)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-12-18 21:43:50 UTC (rev 253712)
@@ -1,3 +1,43 @@
+2019-12-18  Dan Robson  
+
+Cherry-pick r253544. rdar://problem/58049164
+
+SecurityOrigin should be unique for null blob URLs that have been unregistered
+https://bugs.webkit.org/show_bug.cgi?id=205169
+
+Reviewed by Darin Adler.
+
+Source/WebCore:
+
+In case we cannot retrieve a cached origin for a null origin, just create a unique one.
+This is better than having an origin with an empty host and empty scheme.
+
+Test: http/tests/security/blob-null-url-location-origin.html
+
+* fileapi/ThreadableBlobRegistry.cpp:
+(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
+(WebCore::ThreadableBlobRegistry::getCachedOrigin):
+
+LayoutTests:
+
+* http/tests/security/blob-null-url-location-origin-expected.txt: Added.
+* http/tests/security/blob-null-url-location-origin.html: Added.
+* platform/win/TestExpectations: Skipping test as timing out in windows.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-12-16  youenn fablet  
+
+SecurityOrigin should be unique for null blob URLs that have been unregistered
+https://bugs.webkit.org/show_bug.cgi?id=205169
+
+Reviewed by Darin Adler.
+
+* http/tests/security/blob-null-url-location-origin-expected.txt: Added.
+* http/tests/security/blob-null-url-location-origin.html: Added.
+* platform/win/TestExpectations: Skipping test as timing out in windows.
+
 2019-11-18  Alan Coon  
 
 Apply patch. rdar://problem/57283569


Added: branches/safari-608-branch/LayoutTests/http/tests/security/blob-null-url-location-origin-expected.txt (0 => 253712)

--- branches/safari-608-branch/LayoutTests/http/tests/security/blob-null-url-location-origin-expected.txt	(rev 0)
+++ branches/safari-608-branch/LayoutTests/http/tests/security/blob-null-url-location-origin-expected.txt	2019-12-18 21:43:50 UTC (rev 253712)
@@ -0,0 +1,5 @@
+CONSOLE MESSAGE: line 1: data URL frame loaded
+CONSOLE MESSAGE: line 1: blob popup opened
+CONSOLE MESSAGE: line 1: blob popup loadednull
+CONSOLE MESSAGE: line 1: blob popup message posted
+PASS


Added: branches/safari-608-branch/LayoutTests/http/tests/security/blob-null-url-location-origin.html (0 => 253712)

--- branches/safari-608-branch/LayoutTests/http/tests/security/blob-null-url-location-origin.html	(rev 0)
+++ branches/safari-608-branch/LayoutTests/http/tests/security/blob-null-url-location-origin.html	2019-12-18 21:43:50 UTC (rev 253712)
@@ -0,0 +1,36 @@
+
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+testRunner.setCanOpenWindows();
+}
+
+let count = 0;
+_onmessage_ = (event) => {
+++count;
+if (event.data !== "null") {
+document.body.innerHTML = "FAIL, got " + event.data + " with count " + count;
+if (window.testRunner)
+testRunner.notifyDone();
+window.clearTimeout(timer);
+count = 3;
+

[webkit-changes] [253711] trunk/Source/WebCore

[zalan]

Title: [253711] trunk/Source/WebCore








Revision 253711
Author za...@apple.com
Date 2019-12-18 13:28:55 -0800 (Wed, 18 Dec 2019)


Log Message
[LFC][IFC] LineLayoutContext::m_uncommittedList is not always a continuous list of runs
https://bugs.webkit.org/show_bug.cgi?id=205404


Reviewed by Antti Koivisto.

Since LineLayoutContext's m_uncommittedList is not necessarily continuous set of runs (continuous in the content of not having a soft wrap opportunity)
we can't use LineBreaker's Content struct anymore to store the uncommitted content.
Let's use a dedicated UncommittedContent struct instead. It also enables us to pass in a const RunList& to the ContinousContent. ContinousContent should never mutate this list.

* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::shouldKeepEndOfLineWhitespace):
(WebCore::Layout::LineBreaker::breakingContextForInlineContent):
(WebCore::Layout::LineBreaker::ContinousContent::ContinousContent):
(WebCore::Layout::LineBreaker::ContinousContent::hasTextContentOnly const):
(WebCore::Layout::LineBreaker::ContinousContent::isVisuallyEmptyWhitespaceContentOnly const):
(WebCore::Layout::LineBreaker::ContinousContent::firstTextRunIndex const):
(WebCore::Layout::LineBreaker::ContinousContent::hasNonContentRunsOnly const):
(WebCore::Layout::LineBreaker::ContinousContent::TrailingCollapsibleContent::reset):
(WebCore::Layout::LineBreaker::Content::append): Deleted.
(WebCore::Layout::LineBreaker::Content::reset): Deleted.
(WebCore::Layout::LineBreaker::Content::shrink): Deleted.
(WebCore::Layout::LineBreaker::Content::hasTextContentOnly const): Deleted.
(WebCore::Layout::LineBreaker::Content::isVisuallyEmptyWhitespaceContentOnly const): Deleted.
(WebCore::Layout::LineBreaker::Content::firstTextRunIndex const): Deleted.
(WebCore::Layout::LineBreaker::Content::hasNonContentRunsOnly const): Deleted.
(WebCore::Layout::LineBreaker::Content::TrailingCollapsibleContent::reset): Deleted.
* layout/inlineformatting/InlineLineBreaker.h:
(WebCore::Layout::LineBreaker::ContinousContent::runs const):
(WebCore::Layout::LineBreaker::ContinousContent::isEmpty const):
(WebCore::Layout::LineBreaker::ContinousContent::size const):
(WebCore::Layout::LineBreaker::Content::runs): Deleted.
(WebCore::Layout::LineBreaker::Content::runs const): Deleted.
(WebCore::Layout::LineBreaker::Content::isEmpty const): Deleted.
(WebCore::Layout::LineBreaker::Content::size const): Deleted.
(WebCore::Layout::LineBreaker::Content::width const): Deleted.
(WebCore::Layout::LineBreaker::Content::nonCollapsibleWidth const): Deleted.
(WebCore::Layout::LineBreaker::Content::hasTrailingCollapsibleContent const): Deleted.
(WebCore::Layout::LineBreaker::Content::isTrailingContentFullyCollapsible const): Deleted.
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineLayoutContext::processUncommittedContent):
(WebCore::Layout::LineLayoutContext::UncommittedContent::append):
(WebCore::Layout::LineLayoutContext::UncommittedContent::reset):
(WebCore::Layout::LineLayoutContext::UncommittedContent::shrink):
* layout/inlineformatting/LineLayoutContext.h:
(WebCore::Layout::LineLayoutContext::UncommittedContent::width const):
(WebCore::Layout::LineLayoutContext::UncommittedContent::size):
(WebCore::Layout::LineLayoutContext::UncommittedContent::isEmpty):
(WebCore::Layout::LineLayoutContext::UncommittedContent::runs const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.h
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (253710 => 253711)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 20:44:13 UTC (rev 253710)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 21:28:55 UTC (rev 253711)
@@ -1,3 +1,55 @@
+2019-12-18  Zalan Bujtas  
+
+[LFC][IFC] LineLayoutContext::m_uncommittedList is not always a continuous list of runs
+https://bugs.webkit.org/show_bug.cgi?id=205404
+
+
+Reviewed by Antti Koivisto.
+
+Since LineLayoutContext's m_uncommittedList is not necessarily continuous set of runs (continuous in the content of not having a soft wrap opportunity)
+we can't use LineBreaker's Content struct anymore to store the uncommitted content.
+Let's use a dedicated UncommittedContent struct instead. It also enables us to pass in a const RunList& to the ContinousContent. ContinousContent should never mutate this list.
+
+* layout/inlineformatting/InlineLineBreaker.cpp:
+(WebCore::Layout::shouldKeepEndOfLineWhitespace):
+(WebCore::Layout::LineBreaker::breakingContextForInlineContent):
+(WebCore::Layout::LineBreaker::ContinousContent::ContinousContent):
+(WebCore::Layout::LineBreaker::ContinousContent::hasTextContentOnly const):
+

[webkit-changes] [253710] trunk/Source/WebCore

[youenn]

Title: [253710] trunk/Source/WebCore








Revision 253710
Author you...@apple.com
Date 2019-12-18 12:44:13 -0800 (Wed, 18 Dec 2019)


Log Message
Protect ServiceWorker::postMessage from a null execState
https://bugs.webkit.org/show_bug.cgi?id=205394


Reviewed by Chris Dumez.

Crash logs indicate null pointer crashes.
We should return early in that case.

* workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::postMessage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorker.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253709 => 253710)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 20:32:55 UTC (rev 253709)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 20:44:13 UTC (rev 253710)
@@ -1,3 +1,17 @@
+2019-12-18  youenn fablet  
+
+Protect ServiceWorker::postMessage from a null execState
+https://bugs.webkit.org/show_bug.cgi?id=205394
+
+
+Reviewed by Chris Dumez.
+
+Crash logs indicate null pointer crashes.
+We should return early in that case.
+
+* workers/service/ServiceWorker.cpp:
+(WebCore::ServiceWorker::postMessage):
+
 2019-12-18  Zalan Bujtas  
 
 [LFC][IFC] LineBreaker::lastSoftWrapOpportunity should take a list of runs


Modified: trunk/Source/WebCore/workers/service/ServiceWorker.cpp (253709 => 253710)

--- trunk/Source/WebCore/workers/service/ServiceWorker.cpp	2019-12-18 20:32:55 UTC (rev 253709)
+++ trunk/Source/WebCore/workers/service/ServiceWorker.cpp	2019-12-18 20:44:13 UTC (rev 253710)
@@ -106,6 +106,8 @@
 
 auto* execState = context.execState();
 ASSERT(execState);
+if (!execState)
+return Exception { InvalidStateError };
 
 Vector> ports;
 auto messageData = SerializedScriptValue::create(*execState, messageValue, WTFMove(options.transfer), ports, SerializationContext::WorkerPostMessage);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253709] trunk/Tools

[jbedard]

Title: [253709] trunk/Tools








Revision 253709
Author jbed...@apple.com
Date 2019-12-18 12:32:55 -0800 (Wed, 18 Dec 2019)


Log Message
GPU-Process: Bring up automated tester
https://bugs.webkit.org/show_bug.cgi?id=205229

Reviewed by Stephanie Lewis.

* BuildSlaveSupport/build.webkit.org-config/config.json: Add GPU Process tester,
derived from debug testing queue.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (253708 => 253709)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2019-12-18 20:28:18 UTC (rev 253708)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2019-12-18 20:32:55 UTC (rev 253709)
@@ -15,6 +15,7 @@
 { "name": "bot248", "platform": "mac-catalina" },
 { "name": "bot121", "platform": "mac-catalina" },
 { "name": "bot659", "platform": "mac-catalina" },
+{ "name": "bot301", "platform": "mac-catalina" },
 
 { "name": "bot132", "platform": "mac-mojave" },
 { "name": "bot178", "platform": "mac-mojave" },
@@ -102,7 +103,7 @@
 "builders":   [ 
 { "name": "Apple-Catalina-Debug-Build", "type": "Build", "builddir": "catalina-debug",
   "platform": "mac-catalina", "configuration": "debug", "architectures": ["x86_64"],
-  "triggers": ["catalina-debug-tests-wk1", "catalina-debug-tests-wk2", "catalina-debug-tests-wk2-webgl"],
+  "triggers": ["catalina-debug-tests-wk1", "catalina-debug-tests-wk2", "catalina-debug-tests-wk2-webgl", "catalina-debug-tests-wk2-gpuprocess"],
   "slavenames": ["bot687", "bot688"]
 },
 { "name": "Apple-Catalina-Debug-WK1-Tests", "type": "TestWebKit1AllButJSC", "builddir": "catalina-debug-tests-wk1",
@@ -120,6 +121,11 @@
   "additionalArguments": ["--no-retry-failures", "--webgl-test-suite"],
   "slavenames": ["bot659"]
 },
+{ "name": "Apple-Catalina-Debug-WK2-GPUProcess-Tests", "type": "TestAllButJSC", "builddir": "catalina-debug-tests-wk2-gpuprocess",
+  "platform": "mac-catalina", "configuration": "debug", "architectures": ["x86_64"],
+  "additionalArguments": ["--no-retry-failures", "--use-gpu-process"],
+  "slavenames": ["bot301"]
+},
 { "name": "Apple-Catalina-Release-Build", "type": "Build", "builddir": "catalina-release",
   "platform": "mac-catalina", "configuration": "release", "architectures": ["x86_64"],
   "triggers": ["catalina-release-tests-wk1", "catalina-release-tests-wk2", "catalina-leaks"],
@@ -447,6 +453,9 @@
 { "type": "Triggerable", "name": "catalina-debug-tests-wk2-webgl",
   "builderNames": ["Apple-Catalina-Debug-WK2-WebGL-Tests"]
 },
+{ "type": "Triggerable", "name": "catalina-debug-tests-wk2-gpuprocess",
+  "builderNames": ["Apple-Catalina-Debug-WK2-GPUProcess-Tests"]
+},
 { "type": "Triggerable", "name": "catalina-leaks",
   "builderNames": ["Apple-Catalina-Leaks"]
 },


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py (253708 => 253709)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	2019-12-18 20:28:18 UTC (rev 253708)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py	2019-12-18 20:32:55 UTC (rev 253709)
@@ -531,6 +531,7 @@
 'Apple-Catalina-Debug-WK1-Tests': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'layout-test', 'run-api-tests', 'lldb-webkit-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand'],
 'Apple-Catalina-Debug-WK2-Tests': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 'layout-test', 'run-api-tests', 'lldb-webkit-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand'],
 'Apple-Catalina-Debug-WK2-WebGL-Tests': ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'download-built-product', 'extract-built-product', 

[webkit-changes] [253708] trunk/Source/WebCore

[zalan]

Title: [253708] trunk/Source/WebCore








Revision 253708
Author za...@apple.com
Date 2019-12-18 12:28:18 -0800 (Wed, 18 Dec 2019)


Log Message
[LFC][IFC] LineBreaker::lastSoftWrapOpportunity should take a list of runs
https://bugs.webkit.org/show_bug.cgi?id=205402


Reviewed by Antti Koivisto.

LineBreaker::Content is supposed to hold a continuous set of runs and the input to lastSoftWrapOpportunity is not
necessarily continuous (most of the time it is though).

* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::isContentSplitAllowed):
(WebCore::Layout::LineBreaker::wrapTextContent const):
(WebCore::Layout::LineBreaker::tryBreakingTextRun const):
(WebCore::Layout::LineBreaker::lastSoftWrapOpportunity):
(WebCore::Layout::LineBreaker::Content::lastSoftWrapOpportunity): Deleted.
* layout/inlineformatting/InlineLineBreaker.h:
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineLayoutContext::placeInlineItem):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.h
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253707 => 253708)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 20:17:03 UTC (rev 253707)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 20:28:18 UTC (rev 253708)
@@ -1,3 +1,24 @@
+2019-12-18  Zalan Bujtas  
+
+[LFC][IFC] LineBreaker::lastSoftWrapOpportunity should take a list of runs
+https://bugs.webkit.org/show_bug.cgi?id=205402
+
+
+Reviewed by Antti Koivisto.
+
+LineBreaker::Content is supposed to hold a continuous set of runs and the input to lastSoftWrapOpportunity is not
+necessarily continuous (most of the time it is though). 
+
+* layout/inlineformatting/InlineLineBreaker.cpp:
+(WebCore::Layout::isContentSplitAllowed):
+(WebCore::Layout::LineBreaker::wrapTextContent const):
+(WebCore::Layout::LineBreaker::tryBreakingTextRun const):
+(WebCore::Layout::LineBreaker::lastSoftWrapOpportunity):
+(WebCore::Layout::LineBreaker::Content::lastSoftWrapOpportunity): Deleted.
+* layout/inlineformatting/InlineLineBreaker.h:
+* layout/inlineformatting/LineLayoutContext.cpp:
+(WebCore::Layout::LineLayoutContext::placeInlineItem):
+
 2019-12-18  youenn fablet  
 
 AppCache should request certificate info when loading resources


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp (253707 => 253708)

--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp	2019-12-18 20:17:03 UTC (rev 253707)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp	2019-12-18 20:28:18 UTC (rev 253708)
@@ -43,7 +43,7 @@
 return style.whiteSpace() != WhiteSpace::Pre && style.whiteSpace() != WhiteSpace::NoWrap;
 }
 
-static inline bool isContentSplitAllowed(const LineBreaker::Content::Run& run)
+static inline bool isContentSplitAllowed(const LineBreaker::Run& run)
 {
 ASSERT(run.inlineItem.isText() || run.inlineItem.isContainerStart() || run.inlineItem.isContainerEnd());
 if (!run.inlineItem.isText()) {
@@ -124,7 +124,7 @@
 return !lineIsEmpty && floatLogicalWidth > availableWidth;
 }
 
-Optional LineBreaker::wrapTextContent(const Content::RunList& runs, const LineStatus& lineStatus) const
+Optional LineBreaker::wrapTextContent(const RunList& runs, const LineStatus& lineStatus) const
 {
 // Check where the overflow occurs and use the corresponding style to figure out the breaking behaviour.
 // firstsecondthird
@@ -196,7 +196,7 @@
 return WordBreakRule::NoBreak;
 }
 
-Optional LineBreaker::tryBreakingTextRun(const Content::Run& overflowRun, InlineLayoutUnit availableWidth, bool lineIsEmpty) const
+Optional LineBreaker::tryBreakingTextRun(const Run& overflowRun, InlineLayoutUnit availableWidth, bool lineIsEmpty) const
 {
 ASSERT(overflowRun.inlineItem.isText());
 auto& inlineTextItem = downcast(overflowRun.inlineItem);
@@ -280,7 +280,7 @@
 return !TextUtil::findNextBreakablePosition(lineBreakIterator, 0, nextInlineTextItem.style());
 }
 
-Optional LineBreaker::Content::lastSoftWrapOpportunity(const InlineItem& inlineItem, const Content& priorContent)
+Optional LineBreaker::lastSoftWrapOpportunity(const InlineItem& inlineItem, const RunList& priorContent)
 {
 // https://drafts.csswg.org/css-text-3/#line-break-details
 // Figure out if the new incoming content puts the uncommitted content on a soft wrap opportunity.
@@ -294,7 +294,7 @@
 }
 
 auto lastInlineItemWithContent = [&] () -> const InlineItem* {
-for (auto& previousRun : WTF::makeReversedRange(priorContent.runs())) {
+for (auto& previousRun : WTF::makeReversedRange(priorContent)) {
 auto& previousInlineItem = previousRun.inlineItem;
 if (previousInlineItem.isText() || 

[webkit-changes] [253707] trunk/Source/WebCore

[youenn]

Title: [253707] trunk/Source/WebCore








Revision 253707
Author you...@apple.com
Date 2019-12-18 12:17:03 -0800 (Wed, 18 Dec 2019)


Log Message
AppCache should request certificate info when loading resources
https://bugs.webkit.org/show_bug.cgi?id=205393

Reviewed by Anders Carlsson.

Covered by existing tests not crashing in Debug with newly added ASSERT.

* Modules/mediastream/UserMediaController.cpp:
(WebCore::isSecure):
ASSERT that certificate info is there.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
ASSERT that certificate info is there.
* loader/appcache/ApplicationCacheResourceLoader.cpp:
(WebCore::ApplicationCacheResourceLoader::create):
Request certificate info for all app cache resources.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/UserMediaController.cpp
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/appcache/ApplicationCacheResourceLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253706 => 253707)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 20:06:19 UTC (rev 253706)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 20:17:03 UTC (rev 253707)
@@ -1,5 +1,24 @@
 2019-12-18  youenn fablet  
 
+AppCache should request certificate info when loading resources
+https://bugs.webkit.org/show_bug.cgi?id=205393
+
+Reviewed by Anders Carlsson.
+
+Covered by existing tests not crashing in Debug with newly added ASSERT.
+
+* Modules/mediastream/UserMediaController.cpp:
+(WebCore::isSecure):
+ASSERT that certificate info is there.
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::responseReceived):
+ASSERT that certificate info is there.
+* loader/appcache/ApplicationCacheResourceLoader.cpp:
+(WebCore::ApplicationCacheResourceLoader::create):
+Request certificate info for all app cache resources.
+
+2019-12-18  youenn fablet  
+
 Add support for Audio Capture in GPUProcess
 https://bugs.webkit.org/show_bug.cgi?id=205056
 


Modified: trunk/Source/WebCore/Modules/mediastream/UserMediaController.cpp (253706 => 253707)

--- trunk/Source/WebCore/Modules/mediastream/UserMediaController.cpp	2019-12-18 20:06:19 UTC (rev 253706)
+++ trunk/Source/WebCore/Modules/mediastream/UserMediaController.cpp	2019-12-18 20:17:03 UTC (rev 253707)
@@ -64,6 +64,8 @@
 static inline bool isSecure(DocumentLoader& documentLoader)
 {
 auto& response = documentLoader.response();
+ASSERT(response.certificateInfo());
+
 if (SecurityOrigin::isLocalHostOrLoopbackIPAddress(documentLoader.response().url().host()))
 return true;
 return LegacySchemeRegistry::shouldTreatURLSchemeAsSecure(response.url().protocol().toStringWithoutCopying())


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (253706 => 253707)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2019-12-18 20:06:19 UTC (rev 253706)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2019-12-18 20:17:03 UTC (rev 253707)
@@ -760,6 +760,7 @@
 
 void DocumentLoader::responseReceived(const ResourceResponse& response, CompletionHandler&& completionHandler)
 {
+ASSERT(response.certificateInfo());
 CompletionHandlerCallingScope completionHandlerCaller(WTFMove(completionHandler));
 
 #if ENABLE(CONTENT_FILTERING)


Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheResourceLoader.cpp (253706 => 253707)

--- trunk/Source/WebCore/loader/appcache/ApplicationCacheResourceLoader.cpp	2019-12-18 20:06:19 UTC (rev 253706)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheResourceLoader.cpp	2019-12-18 20:17:03 UTC (rev 253707)
@@ -36,6 +36,7 @@
 options.storedCredentialsPolicy = StoredCredentialsPolicy::Use;
 options.credentials = FetchOptions::Credentials::Include;
 options.applicationCacheMode = ApplicationCacheMode::Bypass;
+options.certificateInfoPolicy = CertificateInfoPolicy::IncludeCertificateInfo;
 CachedResourceRequest cachedResourceRequest { WTFMove(request), options };
 auto resource = loader.requestRawResource(WTFMove(cachedResourceRequest));
 if (!resource.has_value()) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253706] trunk/Source/WebInspectorUI

[drousso]

Title: [253706] trunk/Source/WebInspectorUI








Revision 253706
Author drou...@apple.com
Date 2019-12-18 12:06:19 -0800 (Wed, 18 Dec 2019)


Log Message
Web Inspector: Elements: remove the "Show/Hide Shadow DOM" navigation item
https://bugs.webkit.org/show_bug.cgi?id=205199

Reviewed by Timothy Hatcher.

There's really no good reason to hide shadow DOM, especially for non-user-agent shadow trees.
The user has full control over whether to expand/collapse shadow trees (and their hosts), so
having a setting that entirely removes the shadow trees from view throughout Web Inspector
seems overkill.

* UserInterface/Base/Setting.js:

* UserInterface/Models/DOMNode.js:
(WI.DOMNode):
(WI.DOMNode.prototype.get nextSibling):
(WI.DOMNode.prototype.get previousSibling):
(WI.DOMNode.prototype.get children):
(WI.DOMNode.prototype.get childNodeCount):

* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView):
(WI.DOMTreeContentView.prototype.get navigationItems):
(WI.DOMTreeContentView.prototype.closed):
(WI.DOMTreeContentView.prototype._showShadowDOMSettingChanged): Deleted.
(WI.DOMTreeContentView.prototype._toggleShowsShadowDOMSetting): Deleted.

* UserInterface/Views/DOMTreeOutline.js:
(WI.DOMTreeOutline.prototype.close):
(WI.DOMTreeOutline.prototype._revealAndSelectNode):
(WI.DOMTreeOutline.prototype._showShadowDOMSettingChanged): Deleted.

* UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WI.LayerTreeDetailsSidebarPanel.prototype.initialLayout):
(WI.LayerTreeDetailsSidebarPanel.prototype._updateDisplayWithLayers):
(WI.LayerTreeDetailsSidebarPanel.prototype._showShadowDOMSettingChanged): Deleted.

* UserInterface/Images/ShadowDOM.svg: Removed.
* Localizations/en.lproj/localizedStrings.js:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js
trunk/Source/WebInspectorUI/UserInterface/Views/LayerTreeDetailsSidebarPanel.js


Removed Paths

trunk/Source/WebInspectorUI/UserInterface/Images/ShadowDOM.svg




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (253705 => 253706)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-12-18 19:40:07 UTC (rev 253705)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-12-18 20:06:19 UTC (rev 253706)
@@ -1,3 +1,44 @@
+2019-12-18  Devin Rousso  
+
+Web Inspector: Elements: remove the "Show/Hide Shadow DOM" navigation item
+https://bugs.webkit.org/show_bug.cgi?id=205199
+
+Reviewed by Timothy Hatcher.
+
+There's really no good reason to hide shadow DOM, especially for non-user-agent shadow trees.
+The user has full control over whether to expand/collapse shadow trees (and their hosts), so
+having a setting that entirely removes the shadow trees from view throughout Web Inspector
+seems overkill.
+
+* UserInterface/Base/Setting.js:
+
+* UserInterface/Models/DOMNode.js:
+(WI.DOMNode):
+(WI.DOMNode.prototype.get nextSibling):
+(WI.DOMNode.prototype.get previousSibling):
+(WI.DOMNode.prototype.get children):
+(WI.DOMNode.prototype.get childNodeCount):
+
+* UserInterface/Views/DOMTreeContentView.js:
+(WI.DOMTreeContentView):
+(WI.DOMTreeContentView.prototype.get navigationItems):
+(WI.DOMTreeContentView.prototype.closed):
+(WI.DOMTreeContentView.prototype._showShadowDOMSettingChanged): Deleted.
+(WI.DOMTreeContentView.prototype._toggleShowsShadowDOMSetting): Deleted.
+
+* UserInterface/Views/DOMTreeOutline.js:
+(WI.DOMTreeOutline.prototype.close):
+(WI.DOMTreeOutline.prototype._revealAndSelectNode):
+(WI.DOMTreeOutline.prototype._showShadowDOMSettingChanged): Deleted.
+
+* UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
+(WI.LayerTreeDetailsSidebarPanel.prototype.initialLayout):
+(WI.LayerTreeDetailsSidebarPanel.prototype._updateDisplayWithLayers):
+(WI.LayerTreeDetailsSidebarPanel.prototype._showShadowDOMSettingChanged): Deleted.
+
+* UserInterface/Images/ShadowDOM.svg: Removed.
+* Localizations/en.lproj/localizedStrings.js:
+
 2019-12-11  Brian Burg  
 
 Web Inspector: add TabNavigation diagnostic event and related hooks


Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (253705 => 253706)

--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2019-12-18 19:40:07 UTC (rev 253705)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js	2019-12-18 20:06:19 UTC (rev 253706)
@@ -608,7 +608,6 @@
 localizedStrings["Hide Path"] = "Hide Path";
 localizedStrings["Hide compositing borders"] = "Hide compositing borders";
 

[webkit-changes] [253705] trunk

[youenn]

Title: [253705] trunk








Revision 253705
Author you...@apple.com
Date 2019-12-18 11:40:07 -0800 (Wed, 18 Dec 2019)


Log Message
Add support for Audio Capture in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=205056

Reviewed by Eric Carlson.

Source/WebCore:

Export some WebCore headers.
Allow disabling the audio session debug assert in the GPU process.
No change of behavior.

* WebCore.xcodeproj/project.pbxproj:
* platform/mediastream/mac/BaseAudioSharedUnit.cpp:
(WebCore::BaseAudioSharedUnit::startUnit):
* platform/mediastream/mac/BaseAudioSharedUnit.h:
(WebCore::BaseAudioSharedUnit::setDisableAudioSessionCheck):
* platform/mediastream/mac/MockAudioSharedUnit.h:

Source/WebKit:

Make UserMediaCaptureManager and Proxy able to work with GPU process.
Add support for capturing audio in the GPU process, this is limited to mock audio sources for now
as we do not support AudioSession in the GPU process.
Covered by rebased test.

* GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::didReceiveMessage):
(WebKit::GPUConnectionToWebProcess::didReceiveSyncMessage):
* GPUProcess/GPUConnectionToWebProcess.h:
* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::setMockCaptureDevicesEnabled):
* GPUProcess/GPUProcess.h:
* GPUProcess/GPUProcess.messages.in:
* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::UserMediaCaptureManagerProxy):
(WebKit::UserMediaCaptureManagerProxy::~UserMediaCaptureManagerProxy):
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::applyConstraints):
(WebKit::UserMediaCaptureManagerProxy::clone):
* UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
(WebKit::UserMediaCaptureManagerProxy::didReceiveMessageFromGPUProcess):
(WebKit::UserMediaCaptureManagerProxy::didReceiveSyncMessageFromGPUProcess):
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
* WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::didReceiveMessage):
* WebProcess/GPU/GPUProcessConnection.h:
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::Source::setShouldCaptureInGPUProcess):
(WebKit::UserMediaCaptureManager::Source::shouldCaptureInGPUProcess const):
(WebKit::UserMediaCaptureManager::Source::requestToEnd):
(WebKit::UserMediaCaptureManager::createCaptureSource):
(WebKit::UserMediaCaptureManager::sourceStopped):
(WebKit::UserMediaCaptureManager::captureFailed):
(WebKit::UserMediaCaptureManager::Source::connection):
(WebKit::UserMediaCaptureManager::Source::startProducingData):
(WebKit::UserMediaCaptureManager::Source::stopProducingData):
(WebKit::UserMediaCaptureManager::Source::capabilities):
(WebKit::UserMediaCaptureManager::Source::applyConstraints):
(WebKit::UserMediaCaptureManager::sourceEnded):
(WebKit::UserMediaCaptureManager::Source::hasEnded):
(WebKit::UserMediaCaptureManager::Source::stopBeingObserved):
(WebKit::UserMediaCaptureManager::AudioFactory::createAudioCaptureSource):
* WebProcess/cocoa/UserMediaCaptureManager.h:
(WebKit::UserMediaCaptureManager::didReceiveMessageFromGPUProcess):

LayoutTests:

* fast/mediastream/captureAudioInGPUProcess-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/captureAudioInGPUProcess-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp
trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.h
trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.cpp
trunk/Source/WebKit/GPUProcess/GPUProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in
trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.h
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnection.h
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp
trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.h




Diff

Modified: trunk/LayoutTests/ChangeLog (253704 => 253705)

--- trunk/LayoutTests/ChangeLog	2019-12-18 19:39:09 UTC (rev 253704)
+++ trunk/LayoutTests/ChangeLog	2019-12-18 19:40:07 UTC (rev 253705)
@@ -1,3 +1,12 @@
+2019-12-18  youenn fablet  
+
+Add support for Audio Capture in GPUProcess
+https://bugs.webkit.org/show_bug.cgi?id=205056
+
+

[webkit-changes] [253704] trunk/LayoutTests

[cdumez]

Title: [253704] trunk/LayoutTests








Revision 253704
Author cdu...@apple.com
Date 2019-12-18 11:39:09 -0800 (Wed, 18 Dec 2019)


Log Message
Unreviewed, rebaseline all service workers tests and unskip 2 that no longer time out.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/client-navigate.https-expected.txt:
* web-platform-tests/service-workers/service-worker/clients-matchall-include-uncontrolled.https-expected.txt:
* web-platform-tests/service-workers/service-worker/dedicated-worker-service-worker-interception.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video-cache.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video.https-expected.txt:
* web-platform-tests/service-workers/service-worker/multipart-image.https-expected.txt:
* web-platform-tests/service-workers/service-worker/performance-timeline.https-expected.txt:
* web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https-expected.txt:
* web-platform-tests/service-workers/service-worker/skip-waiting-installed.https-expected.txt:
* web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:
* web-platform-tests/service-workers/service-worker/update-not-allowed.https-expected.txt:
* web-platform-tests/service-workers/service-worker/update.https-expected.txt:
* web-platform-tests/service-workers/service-worker/worker-client-id.https-expected.txt:
* web-platform-tests/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https-expected.txt:

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/client-navigate.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-include-uncontrolled.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/dedicated-worker-service-worker-interception.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video-cache.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/multipart-image.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/performance-timeline.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-installed.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/update-not-allowed.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/update.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-client-id.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (253703 => 253704)

--- trunk/LayoutTests/ChangeLog	2019-12-18 19:31:11 UTC (rev 253703)
+++ trunk/LayoutTests/ChangeLog	2019-12-18 19:39:09 UTC (rev 253704)
@@ -1,3 +1,9 @@
+2019-12-18  Chris Dumez  
+
+Unreviewed, rebaseline all service workers tests and unskip 2 that no longer time out.
+
+* TestExpectations:
+
 2019-12-18  Truitt Savell  
 
 REGRESSION: [ Mac ] accessibility/presentation-role-iframe.html is a flaky failure


Modified: trunk/LayoutTests/TestExpectations (253703 => 253704)

--- trunk/LayoutTests/TestExpectations	2019-12-18 19:31:11 UTC (rev 253703)
+++ trunk/LayoutTests/TestExpectations	2019-12-18 19:39:09 UTC (rev 253704)
@@ -223,7 +223,6 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/dedicated-worker-service-worker-interception.https.html [ Skip ]
 webkit.org/b/201665 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-video.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/multipart-image.https.html [ Skip ]
-imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html [ Skip ]
 

[webkit-changes] [253703] tags/Safari-609.1.12.2/Source/WebKit

[alancoon]

Title: [253703] tags/Safari-609.1.12.2/Source/WebKit








Revision 253703
Author alanc...@apple.com
Date 2019-12-18 11:31:11 -0800 (Wed, 18 Dec 2019)


Log Message
Cherry-pick r253696. rdar://problem/58046272

Add syscall to GPU Process sandbox
https://bugs.webkit.org/show_bug.cgi?id=205400


Reviewed by Simon Fraser.

This patch temporarily adds a syscall to the sandbox to work around a bug in the
system Sandbox framework. We will remove this in Bug 205400 once that issue is
resolved.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

tags/Safari-609.1.12.2/Source/WebKit/ChangeLog
tags/Safari-609.1.12.2/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: tags/Safari-609.1.12.2/Source/WebKit/ChangeLog (253702 => 253703)

--- tags/Safari-609.1.12.2/Source/WebKit/ChangeLog	2019-12-18 19:28:53 UTC (rev 253702)
+++ tags/Safari-609.1.12.2/Source/WebKit/ChangeLog	2019-12-18 19:31:11 UTC (rev 253703)
@@ -1,3 +1,35 @@
+2019-12-18  Dan Robson  
+
+Cherry-pick r253696. rdar://problem/58046272
+
+Add syscall to GPU Process sandbox
+https://bugs.webkit.org/show_bug.cgi?id=205400
+
+
+Reviewed by Simon Fraser.
+
+This patch temporarily adds a syscall to the sandbox to work around a bug in the
+system Sandbox framework. We will remove this in Bug 205400 once that issue is
+resolved.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-12-18  Brent Fulgham  
+
+Add syscall to GPU Process sandbox
+https://bugs.webkit.org/show_bug.cgi?id=205400
+
+
+Reviewed by Simon Fraser.
+
+This patch temporarily adds a syscall to the sandbox to work around a bug in the
+system Sandbox framework. We will remove this in Bug 205400 once that issue is
+resolved.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
 2019-12-07  David Quesada  
 
 REGRESSION(r253231): Debug assertion failures under ~WebDeviceOrientationUpdateProvider(Proxy)


Modified: tags/Safari-609.1.12.2/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (253702 => 253703)

--- tags/Safari-609.1.12.2/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2019-12-18 19:28:53 UTC (rev 253702)
+++ tags/Safari-609.1.12.2/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2019-12-18 19:31:11 UTC (rev 253703)
@@ -1140,5 +1140,6 @@
 (syscall-number SYS_kqueue_workloop_ctl) ;; 
 (syscall-number SYS_psynch_rw_rdlock) ;; 
 (syscall-number SYS_faccessat) ;; 
+(syscall-number SYS_chmod_extended) ;; 
 )
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253702] trunk/Source

[commit-queue]

Title: [253702] trunk/Source








Revision 253702
Author commit-qu...@webkit.org
Date 2019-12-18 11:28:53 -0800 (Wed, 18 Dec 2019)


Log Message
Add network loading signposts
https://bugs.webkit.org/show_bug.cgi?id=204822


Patch by Ben Nham  on 2019-12-18
Reviewed by Alex Christensen.

This adds os_signposts related to network loads to aid in debugging networking performance
issues. Since URLs are logged in the signposts, this capability is only enabled on Apple
internal builds when an environment variable is set.

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/PlatformMac.cmake:
* pal/spi/cocoa/OSVariantSPI.h: Added.

Source/WebKit:

* NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::signpostLogHandle):
(WebKit::signpostsEnabled):
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::didSendData):
(WebKit::NetworkDataTaskCocoa::didReceiveChallenge):
(WebKit::NetworkDataTaskCocoa::didCompleteWithError):
(WebKit::NetworkDataTaskCocoa::didReceiveData):
(WebKit::NetworkDataTaskCocoa::didReceiveResponse):
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):
(WebKit::NetworkDataTaskCocoa::cancel):
(WebKit::NetworkDataTaskCocoa::resume):

Source/WTF:

* wtf/Platform.h:
Add HAVE_OS_SIGNPOST.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
trunk/Source/WebCore/PAL/pal/PlatformMac.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm


Added Paths

trunk/Source/WebCore/PAL/pal/spi/cocoa/OSVariantSPI.h




Diff

Modified: trunk/Source/WTF/ChangeLog (253701 => 253702)

--- trunk/Source/WTF/ChangeLog	2019-12-18 19:27:52 UTC (rev 253701)
+++ trunk/Source/WTF/ChangeLog	2019-12-18 19:28:53 UTC (rev 253702)
@@ -1,3 +1,18 @@
+2019-12-18  Ben Nham  
+
+Add network loading signposts
+https://bugs.webkit.org/show_bug.cgi?id=204822
+
+
+Reviewed by Alex Christensen.
+
+This adds os_signposts related to network loads to aid in debugging networking performance
+issues. Since URLs are logged in the signposts, this capability is only enabled on Apple
+internal builds when an environment variable is set.
+
+* wtf/Platform.h:
+Add HAVE_OS_SIGNPOST.
+
 2019-12-17  Myles C. Maxfield  
 
 [iOS] Update to use CTFontCreateForCharactersWithLanguageAndOption()


Modified: trunk/Source/WTF/wtf/Platform.h (253701 => 253702)

--- trunk/Source/WTF/wtf/Platform.h	2019-12-18 19:27:52 UTC (rev 253701)
+++ trunk/Source/WTF/wtf/Platform.h	2019-12-18 19:28:53 UTC (rev 253702)
@@ -1666,3 +1666,7 @@
 #if PLATFORM(IOS_FAMILY) || (!(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && (OS(LINUX) && (PLATFORM(GTK) || PLATFORM(WPE
 #define USE_BMALLOC_MEMORY_FOOTPRINT_API 1
 #endif
+
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS_FAMILY)
+#define HAVE_OS_SIGNPOST 1
+#endif


Modified: trunk/Source/WebCore/PAL/ChangeLog (253701 => 253702)

--- trunk/Source/WebCore/PAL/ChangeLog	2019-12-18 19:27:52 UTC (rev 253701)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-12-18 19:28:53 UTC (rev 253702)
@@ -1,3 +1,19 @@
+2019-12-18  Ben Nham  
+
+Add network loading signposts
+https://bugs.webkit.org/show_bug.cgi?id=204822
+
+
+Reviewed by Alex Christensen.
+
+This adds os_signposts related to network loads to aid in debugging networking performance
+issues. Since URLs are logged in the signposts, this capability is only enabled on Apple
+internal builds when an environment variable is set.
+
+* PAL.xcodeproj/project.pbxproj:
+* pal/PlatformMac.cmake:
+* pal/spi/cocoa/OSVariantSPI.h: Added.
+
 2019-12-05  Chris Dumez  
 
 [IPC] Fail PAL::SessionID decoding if the decoded integer is not a valid session ID


Modified: trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj (253701 => 253702)

--- trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2019-12-18 19:27:52 UTC (rev 253701)
+++ trunk/Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj	2019-12-18 19:28:53 UTC (rev 253702)
@@ -168,6 +168,7 @@
 		CE5673872151A7B9002F92D7 /* IOKitSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = CE5673862151A7B9002F92D7 /* IOKitSPI.h */; };
 		E5D45D122106A07400D2B738 /* NSColorWellSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = E5D45D112106A07400D2B738 /* NSColorWellSPI.h */; };
 		E5D45D142106A18700D2B738 /* NSPopoverColorWellSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = E5D45D132106A18700D2B738 /* NSPopoverColorWellSPI.h */; };
+		EB707FA5239737F80059053A /* OSVariantSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = EB707FA4239737F80059053A /* OSVariantSPI.h */; };
 		F442915E1FA52473002CC93E /* NSFileSizeFormatterSPI.h in Headers 

[webkit-changes] [253701] tags/Safari-609.1.12.2/Source

[alancoon]

Title: [253701] tags/Safari-609.1.12.2/Source








Revision 253701
Author alanc...@apple.com
Date 2019-12-18 11:27:52 -0800 (Wed, 18 Dec 2019)


Log Message
Versioning.

Modified Paths

tags/Safari-609.1.12.2/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-609.1.12.2/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
tags/Safari-609.1.12.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-609.1.12.2/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-609.1.12.2/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-609.1.12.2/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-609.1.12.2/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-609.1.12.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-609.1.12.2/Source/_javascript_Core/Configurations/Version.xcconfig (253700 => 253701)

--- tags/Safari-609.1.12.2/Source/_javascript_Core/Configurations/Version.xcconfig	2019-12-18 19:25:16 UTC (rev 253700)
+++ tags/Safari-609.1.12.2/Source/_javascript_Core/Configurations/Version.xcconfig	2019-12-18 19:27:52 UTC (rev 253701)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.2/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (253700 => 253701)

--- tags/Safari-609.1.12.2/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2019-12-18 19:25:16 UTC (rev 253700)
+++ tags/Safari-609.1.12.2/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2019-12-18 19:27:52 UTC (rev 253701)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (253700 => 253701)

--- tags/Safari-609.1.12.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-12-18 19:25:16 UTC (rev 253700)
+++ tags/Safari-609.1.12.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-12-18 19:27:52 UTC (rev 253701)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.2/Source/WebCore/Configurations/Version.xcconfig (253700 => 253701)

--- tags/Safari-609.1.12.2/Source/WebCore/Configurations/Version.xcconfig	2019-12-18 19:25:16 UTC (rev 253700)
+++ tags/Safari-609.1.12.2/Source/WebCore/Configurations/Version.xcconfig	2019-12-18 19:27:52 UTC (rev 253701)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.2/Source/WebCore/PAL/Configurations/Version.xcconfig (253700 => 253701)

--- tags/Safari-609.1.12.2/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-12-18 19:25:16 UTC (rev 253700)
+++ tags/Safari-609.1.12.2/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-12-18 19:27:52 UTC (rev 253701)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.2/Source/WebInspectorUI/Configurations/Version.xcconfig (253700 => 253701)

--- tags/Safari-609.1.12.2/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-12-18 19:25:16 UTC (rev 253700)
+++ tags/Safari-609.1.12.2/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-12-18 19:27:52 UTC (rev 253701)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.2/Source/WebKit/Configurations/Version.xcconfig (253700 => 253701)

--- tags/Safari-609.1.12.2/Source/WebKit/Configurations/Version.xcconfig	2019-12-18 19:25:16 UTC (rev 253700)
+++ tags/Safari-609.1.12.2/Source/WebKit/Configurations/Version.xcconfig	2019-12-18 19:27:52 UTC (rev 253701)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 12;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-609.1.12.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (253700 => 253701)

--- tags/Safari-609.1.12.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-12-18 19:25:16 UTC (rev 

[webkit-changes] [253700] tags/Safari-609.1.12.2/

[alancoon]

Title: [253700] tags/Safari-609.1.12.2/








Revision 253700
Author alanc...@apple.com
Date 2019-12-18 11:25:16 -0800 (Wed, 18 Dec 2019)


Log Message
New tag.

Added Paths

tags/Safari-609.1.12.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253699] trunk/Source/WebKit

[youenn]

Title: [253699] trunk/Source/WebKit








Revision 253699
Author you...@apple.com
Date 2019-12-18 11:23:48 -0800 (Wed, 18 Dec 2019)


Log Message
Refine RTCMonitor logging
https://bugs.webkit.org/show_bug.cgi?id=205384

Reviewed by Eric Carlson.

Catch the case where the rtc thread is blocked in WebProcess and NetworkProcess.
Add logging of 'this' so as to disambiguate the case of several pages doing RTC in parallel.
No change of behavior.

* NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
(WebKit::NetworkRTCMonitor::startUpdatingIfNeeded):
(WebKit::NetworkRTCMonitor::stopUpdating):
(WebKit::NetworkRTCMonitor::onNetworksChanged):
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::NetworkRTCProvider):
(WebKit::NetworkRTCProvider::close):
(WebKit::NetworkRTCProvider::createSocket):
* NetworkProcess/webrtc/NetworkRTCProvider.h:
(WebKit::NetworkRTCProvider::canLog const):
* WebProcess/Network/webrtc/WebRTCMonitor.cpp:
(WebKit::WebRTCMonitor::StartUpdating):
(WebKit::WebRTCMonitor::StopUpdating):
(WebKit::WebRTCMonitor::networksChanged):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
trunk/Source/WebKit/WebProcess/Network/webrtc/WebRTCMonitor.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (253698 => 253699)

--- trunk/Source/WebKit/ChangeLog	2019-12-18 19:12:57 UTC (rev 253698)
+++ trunk/Source/WebKit/ChangeLog	2019-12-18 19:23:48 UTC (rev 253699)
@@ -1,3 +1,29 @@
+2019-12-18  youenn fablet  
+
+Refine RTCMonitor logging
+https://bugs.webkit.org/show_bug.cgi?id=205384
+
+Reviewed by Eric Carlson.
+
+Catch the case where the rtc thread is blocked in WebProcess and NetworkProcess.
+Add logging of 'this' so as to disambiguate the case of several pages doing RTC in parallel.
+No change of behavior.
+
+* NetworkProcess/webrtc/NetworkRTCMonitor.cpp:
+(WebKit::NetworkRTCMonitor::startUpdatingIfNeeded):
+(WebKit::NetworkRTCMonitor::stopUpdating):
+(WebKit::NetworkRTCMonitor::onNetworksChanged):
+* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
+(WebKit::NetworkRTCProvider::NetworkRTCProvider):
+(WebKit::NetworkRTCProvider::close):
+(WebKit::NetworkRTCProvider::createSocket):
+* NetworkProcess/webrtc/NetworkRTCProvider.h:
+(WebKit::NetworkRTCProvider::canLog const):
+* WebProcess/Network/webrtc/WebRTCMonitor.cpp:
+(WebKit::WebRTCMonitor::StartUpdating):
+(WebKit::WebRTCMonitor::StopUpdating):
+(WebKit::WebRTCMonitor::networksChanged):
+
 2019-12-18  Kate Cheney  
 
 Only report prevalent domains in the ResourceLoadStatistics data summary API


Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp (253698 => 253699)

--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp	2019-12-18 19:12:57 UTC (rev 253698)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp	2019-12-18 19:23:48 UTC (rev 253699)
@@ -36,6 +36,10 @@
 
 namespace WebKit {
 
+#undef RELEASE_LOG_IF_ALLOWED
+
+#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(m_rtcProvider.canLog(), Network, "%p - NetworkRTCMonitor::" fmt, this, ##__VA_ARGS__)
+
 NetworkRTCMonitor::~NetworkRTCMonitor()
 {
 ASSERT(!m_manager);
@@ -43,12 +47,14 @@
 
 void NetworkRTCMonitor::startUpdatingIfNeeded()
 {
-RELEASE_LOG(WebRTC, "NetworkRTCMonitor::startUpdatingIfNeeded %d", m_isStarted);
+RELEASE_LOG_IF_ALLOWED("startUpdatingIfNeeded %d", m_isStarted);
 if (m_isStarted)
 return;
 
 m_isStarted = true;
 m_rtcProvider.callOnRTCNetworkThread([this]() {
+RELEASE_LOG_IF_ALLOWED("startUpdating from network thread");
+
 m_manager = makeUniqueWithoutFastMallocCheck();
 m_manager->SignalNetworksChanged.connect(this, ::onNetworksChanged);
 m_manager->StartUpdating();
@@ -57,9 +63,11 @@
 
 void NetworkRTCMonitor::stopUpdating()
 {
-RELEASE_LOG(WebRTC, "NetworkRTCMonitor::stopUpdating");
+RELEASE_LOG_IF_ALLOWED("stopUpdating");
 m_isStarted = false;
 m_rtcProvider.callOnRTCNetworkThread([this]() {
+RELEASE_LOG_IF_ALLOWED("stopUpdating from network thread %p", m_manager.get());
+
 if (!m_manager)
 return;
 m_manager->StopUpdating();
@@ -69,6 +77,8 @@
 
 void NetworkRTCMonitor::onNetworksChanged()
 {
+RELEASE_LOG_IF_ALLOWED("onNetworksChanged");
+
 rtc::BasicNetworkManager::NetworkList networks;
 m_manager->GetNetworks();
 
@@ -84,8 +94,8 @@
 networkList.uncheckedAppend(RTCNetwork { *network });
 }
 
-m_rtcProvider.sendFromMainThread([networkList = WTFMove(networkList), ipv4 = WTFMove(ipv4), ipv6 = WTFMove(ipv6)](IPC::Connection& connection) {
-RELEASE_LOG(WebRTC, "NetworkRTCMonitor::onNetworksChanged");
+

[webkit-changes] [253698] trunk/LayoutTests

[tsavell]

Title: [253698] trunk/LayoutTests








Revision 253698
Author tsav...@apple.com
Date 2019-12-18 11:12:57 -0800 (Wed, 18 Dec 2019)


Log Message
REGRESSION: [ Mac ] accessibility/presentation-role-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205403

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (253697 => 253698)

--- trunk/LayoutTests/ChangeLog	2019-12-18 19:02:44 UTC (rev 253697)
+++ trunk/LayoutTests/ChangeLog	2019-12-18 19:12:57 UTC (rev 253698)
@@ -1,3 +1,12 @@
+2019-12-18  Truitt Savell  
+
+REGRESSION: [ Mac ] accessibility/presentation-role-iframe.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205403
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2019-12-18  Kate Cheney  
 
 Only report prevalent domains in the ResourceLoadStatistics data summary API


Modified: trunk/LayoutTests/platform/mac/TestExpectations (253697 => 253698)

--- trunk/LayoutTests/platform/mac/TestExpectations	2019-12-18 19:02:44 UTC (rev 253697)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2019-12-18 19:12:57 UTC (rev 253698)
@@ -1964,3 +1964,5 @@
 webkit.org/b/205361 [ Release ] crypto/workers/subtle/aes-indexeddb.html [ Pass Timeout ]
 
 webkit.org/b/205164 imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3.html [ Pass Failure ]
+
+webkit.org/b/205403 accessibility/presentation-role-iframe.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253697] trunk

[katherine_cheney]

Title: [253697] trunk








Revision 253697
Author katherine_che...@apple.com
Date 2019-12-18 11:02:44 -0800 (Wed, 18 Dec 2019)


Log Message
Only report prevalent domains in the ResourceLoadStatistics data summary API
https://bugs.webkit.org/show_bug.cgi?id=205281


Reviewed by Brent Fulgham.

Source/WebKit:

ResourceLoadStatisticsStore::aggregatedThirdPartyData() should only
return prevalent third party domains.

* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
* NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

Tools:

Update the GetResourceLoadStatisticsDataSummary to set third parties
as prevalent to maintain test functionality.

* TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(TEST):

LayoutTests:

The tests for the ITP data summary had to be updated to set their
third party domains to be prevalent to maintain test functionality.

All http/tests/resourceLoadStatistics/(dont-)count* tests should
no longer output the ITP data summary because the domains are not
set as prevalent.

* http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-database-expected.txt:
* http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-database.html:
* http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-expected.txt:
* http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access.html:
* http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-database-expected.txt:
* http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-expected.txt:
* http/tests/resourceLoadStatistics/count-third-party-script-loads-database-expected.txt:
* http/tests/resourceLoadStatistics/count-third-party-script-loads-expected.txt:
* http/tests/resourceLoadStatistics/dont-count-third-party-image-as-third-party-script-database-expected.txt:
* http/tests/resourceLoadStatistics/dont-count-third-party-image-as-third-party-script-expected.txt:
* http/tests/storageAccess/aggregate-sorted-data-with-storage-access-database-expected.txt:
* http/tests/storageAccess/aggregate-sorted-data-with-storage-access-database.html:
* http/tests/storageAccess/aggregate-sorted-data-with-storage-access-expected.txt:
* http/tests/storageAccess/aggregate-sorted-data-with-storage-access.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-database-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-database.html
trunk/LayoutTests/http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access.html
trunk/LayoutTests/http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-database-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/count-third-party-script-import-in-worker-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/count-third-party-script-loads-database-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/count-third-party-script-loads-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/dont-count-third-party-image-as-third-party-script-database-expected.txt
trunk/LayoutTests/http/tests/resourceLoadStatistics/dont-count-third-party-image-as-third-party-script-expected.txt
trunk/LayoutTests/http/tests/storageAccess/aggregate-sorted-data-with-storage-access-database-expected.txt
trunk/LayoutTests/http/tests/storageAccess/aggregate-sorted-data-with-storage-access-database.html
trunk/LayoutTests/http/tests/storageAccess/aggregate-sorted-data-with-storage-access-expected.txt
trunk/LayoutTests/http/tests/storageAccess/aggregate-sorted-data-with-storage-access.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (253696 => 253697)

--- trunk/LayoutTests/ChangeLog	2019-12-18 18:54:20 UTC (rev 253696)
+++ trunk/LayoutTests/ChangeLog	2019-12-18 19:02:44 UTC (rev 253697)
@@ -1,3 +1,33 @@
+2019-12-18  Kate Cheney  
+
+Only report prevalent domains in the ResourceLoadStatistics data summary API
+https://bugs.webkit.org/show_bug.cgi?id=205281
+
+
+Reviewed by Brent Fulgham.
+
+The tests for the ITP data summary had to be updated to set their
+third party domains to be prevalent to maintain test functionality.
+
+All http/tests/resourceLoadStatistics/(dont-)count* tests should
+no longer output the ITP data summary because the domains are not
+set as prevalent.
+
+* 

[webkit-changes] [253696] trunk/Source/WebKit

[bfulgham]

Title: [253696] trunk/Source/WebKit








Revision 253696
Author bfulg...@apple.com
Date 2019-12-18 10:54:20 -0800 (Wed, 18 Dec 2019)


Log Message
Add syscall to GPU Process sandbox
https://bugs.webkit.org/show_bug.cgi?id=205400


Reviewed by Simon Fraser.

This patch temporarily adds a syscall to the sandbox to work around a bug in the
system Sandbox framework. We will remove this in Bug 205400 once that issue is
resolved.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (253695 => 253696)

--- trunk/Source/WebKit/ChangeLog	2019-12-18 18:51:32 UTC (rev 253695)
+++ trunk/Source/WebKit/ChangeLog	2019-12-18 18:54:20 UTC (rev 253696)
@@ -1,3 +1,17 @@
+2019-12-18  Brent Fulgham  
+
+Add syscall to GPU Process sandbox
+https://bugs.webkit.org/show_bug.cgi?id=205400
+
+
+Reviewed by Simon Fraser.
+
+This patch temporarily adds a syscall to the sandbox to work around a bug in the
+system Sandbox framework. We will remove this in Bug 205400 once that issue is
+resolved.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
 2019-12-18  Eric Carlson  
 
 Enable generic cue API


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (253695 => 253696)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2019-12-18 18:51:32 UTC (rev 253695)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2019-12-18 18:54:20 UTC (rev 253696)
@@ -1140,5 +1140,6 @@
 (syscall-number SYS_kqueue_workloop_ctl) ;; 
 (syscall-number SYS_psynch_rw_rdlock) ;; 
 (syscall-number SYS_faccessat) ;; 
+(syscall-number SYS_chmod_extended) ;; 
 )
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253695] trunk/Source/WebKit

[eric . carlson]

Title: [253695] trunk/Source/WebKit








Revision 253695
Author eric.carl...@apple.com
Date 2019-12-18 10:51:32 -0800 (Wed, 18 Dec 2019)


Log Message
Enable generic cue API
https://bugs.webkit.org/show_bug.cgi?id=205398


Reviewed by Jon Lee.

No new tests, covered by existing tests.

* Shared/WebPreferences.yaml:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml




Diff

Modified: trunk/Source/WebKit/ChangeLog (253694 => 253695)

--- trunk/Source/WebKit/ChangeLog	2019-12-18 18:47:38 UTC (rev 253694)
+++ trunk/Source/WebKit/ChangeLog	2019-12-18 18:51:32 UTC (rev 253695)
@@ -1,5 +1,17 @@
 2019-12-18  Eric Carlson  
 
+Enable generic cue API
+https://bugs.webkit.org/show_bug.cgi?id=205398
+
+
+Reviewed by Jon Lee.
+
+No new tests, covered by existing tests.
+
+* Shared/WebPreferences.yaml:
+
+2019-12-18  Eric Carlson  
+
 Remove unused MediaPlayer methods
 https://bugs.webkit.org/show_bug.cgi?id=205341
 


Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (253694 => 253695)

--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-12-18 18:47:38 UTC (rev 253694)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-12-18 18:51:32 UTC (rev 253695)
@@ -1484,7 +1484,7 @@
 
 GenericCueAPIEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: true
   condition: ENABLE(VIDEO_TRACK)
   humanReadableName: "Generic Text Track Cue API"
   humanReadableDescription: "Enable Generic Text Track Cue API"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253694] branches/safari-609.1.13-branch/Source/JavaScriptCore

[alancoon]

Title: [253694] branches/safari-609.1.13-branch/Source/_javascript_Core








Revision 253694
Author alanc...@apple.com
Date 2019-12-18 10:47:38 -0800 (Wed, 18 Dec 2019)


Log Message
Cherry-pick r253608. rdar://problem/57978411

ASSERTION FAILED: length <= maximumLength in js-fixed-array-out-of-memory.js
https://bugs.webkit.org/show_bug.cgi?id=205259


Reviewed by Mark Lam.

JSImmutableButterfly has moderate size limit on its length, while JSFixedArray does not.
We should check this maximumLength when creating it in Spread. And if it exceeds, we should
throw OOM error.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSpread):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileSpread):
* runtime/ArrayConventions.h:
* runtime/IndexingHeader.h:
* runtime/JSImmutableButterfly.h:
(JSC::JSImmutableButterfly::tryCreate):
(JSC::JSImmutableButterfly::allocationSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.13-branch/Source/_javascript_Core/ChangeLog
branches/safari-609.1.13-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
branches/safari-609.1.13-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
branches/safari-609.1.13-branch/Source/_javascript_Core/runtime/ArrayConventions.h
branches/safari-609.1.13-branch/Source/_javascript_Core/runtime/IndexingHeader.h
branches/safari-609.1.13-branch/Source/_javascript_Core/runtime/JSImmutableButterfly.h




Diff

Modified: branches/safari-609.1.13-branch/Source/_javascript_Core/ChangeLog (253693 => 253694)

--- branches/safari-609.1.13-branch/Source/_javascript_Core/ChangeLog	2019-12-18 18:28:49 UTC (rev 253693)
+++ branches/safari-609.1.13-branch/Source/_javascript_Core/ChangeLog	2019-12-18 18:47:38 UTC (rev 253694)
@@ -1,3 +1,51 @@
+2019-12-18  Kocsen Chung  
+
+Cherry-pick r253608. rdar://problem/57978411
+
+ASSERTION FAILED: length <= maximumLength in js-fixed-array-out-of-memory.js
+https://bugs.webkit.org/show_bug.cgi?id=205259
+
+
+Reviewed by Mark Lam.
+
+JSImmutableButterfly has moderate size limit on its length, while JSFixedArray does not.
+We should check this maximumLength when creating it in Spread. And if it exceeds, we should
+throw OOM error.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileSpread):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileSpread):
+* runtime/ArrayConventions.h:
+* runtime/IndexingHeader.h:
+* runtime/JSImmutableButterfly.h:
+(JSC::JSImmutableButterfly::tryCreate):
+(JSC::JSImmutableButterfly::allocationSize):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-12-16  Yusuke Suzuki  
+
+ASSERTION FAILED: length <= maximumLength in js-fixed-array-out-of-memory.js
+https://bugs.webkit.org/show_bug.cgi?id=205259
+
+
+Reviewed by Mark Lam.
+
+JSImmutableButterfly has moderate size limit on its length, while JSFixedArray does not.
+We should check this maximumLength when creating it in Spread. And if it exceeds, we should
+throw OOM error.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileSpread):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileSpread):
+* runtime/ArrayConventions.h:
+* runtime/IndexingHeader.h:
+* runtime/JSImmutableButterfly.h:
+(JSC::JSImmutableButterfly::tryCreate):
+(JSC::JSImmutableButterfly::allocationSize):
+
 2019-12-13  Yusuke Suzuki  
 
 [JSC] Remove JSFixedArray, and use JSImmutableButterfly instead


Modified: branches/safari-609.1.13-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (253693 => 253694)

--- branches/safari-609.1.13-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2019-12-18 18:28:49 UTC (rev 253693)
+++ branches/safari-609.1.13-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2019-12-18 18:47:38 UTC (rev 253694)
@@ -7918,6 +7918,7 @@
 
 m_jit.loadPtr(MacroAssembler::Address(argument, JSObject::butterflyOffset()), lengthGPR);
 m_jit.load32(MacroAssembler::Address(lengthGPR, Butterfly::offsetOfPublicLength()), lengthGPR);
+slowPath.append(m_jit.branch32(MacroAssembler::Above, lengthGPR, TrustedImm32(MAX_STORAGE_VECTOR_LENGTH)));
 static_assert(sizeof(JSValue) == 8 && 1 << 3 == 8, "This is strongly assumed in the code below.");
 m_jit.move(lengthGPR, scratch1GPR);
 m_jit.lshift32(TrustedImm32(3), scratch1GPR);
@@ -7963,12 +7964,10 @@
 done.append(m_jit.jump());
 }
 
-m_jit.mutatorFence(vm());
+addSlowPathGenerator(slowPathCall(slowPath, this, 

[webkit-changes] [253693] trunk/Source

[eric . carlson]

Title: [253693] trunk/Source








Revision 253693
Author eric.carl...@apple.com
Date 2019-12-18 10:28:49 -0800 (Wed, 18 Dec 2019)


Log Message
Remove unused MediaPlayer methods
https://bugs.webkit.org/show_bug.cgi?id=205341


Reviewed by Jer Noble.

Source/WebCore:

No new tests, this just removes unused code.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaLoadingFailedFatally):
(WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerSetSize): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerIsPaused const): Deleted.
* html/HTMLMediaElement.h:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::setDisplayMode):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::MediaDocument):
(WebCore::MediaDocument::~MediaDocument):
(WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Deleted.
* html/MediaDocument.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::canLoadPoster const): Deleted.
(WebCore::MediaPlayer::setPoster): Deleted.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerContentsScale const):
(WebCore::MediaPlayerClient::mediaPlayerPlatformVolumeConfigurationRequired const):
(WebCore::MediaPlayerClient::mediaPlayerSawUnsupportedTracks): Deleted.
(WebCore::MediaPlayerClient::mediaPlayerSetSize): Deleted.
(WebCore::MediaPlayerClient::mediaPlayerIsPaused const): Deleted.
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setSize):
(WebCore::MediaPlayerPrivateInterface::canLoadPoster const): Deleted.
(WebCore::MediaPlayerPrivateInterface::setPoster): Deleted.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setSize): Deleted.
(WebCore::MediaPlayerPrivateAVFoundation::repaint): Deleted.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Deleted.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setSize): Deleted.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:

Source/WebKit:

* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSawUnsupportedTracks): Deleted.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRepaint): Deleted.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerAcceleratedCompositingEnabled): Deleted.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSetSize): Deleted.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerIsPaused const): Deleted.
(WebKit::RemoteMediaPlayerProxy::mediaPlayerIsLooping const): Deleted.
* GPUProcess/media/RemoteMediaPlayerProxy.h:
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::canLoadPoster const): Deleted.
(WebKit::MediaPlayerPrivateRemote::setPoster): Deleted.
* WebProcess/GPU/media/MediaPlayerPrivateRemote.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLVideoElement.cpp
trunk/Source/WebCore/html/MediaDocument.cpp
trunk/Source/WebCore/html/MediaDocument.h
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (253692 => 253693)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 17:58:40 UTC (rev 253692)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 18:28:49 UTC (rev 253693)
@@ -1,3 +1,52 @@
+2019-12-18  Eric Carlson  

[webkit-changes] [253692] trunk/Source/WebCore

[simon . fraser]

Title: [253692] trunk/Source/WebCore








Revision 253692
Author simon.fra...@apple.com
Date 2019-12-18 09:58:40 -0800 (Wed, 18 Dec 2019)


Log Message
Ensure transparency layers are properly ended when only painting root background
https://bugs.webkit.org/show_bug.cgi?id=205285

Patch by Doug Kelly  on 2019-12-18
Reviewed by Simon Fraser.

Ensure that if we are in a transparency layer and returning early from paintLayerContents() because of PaintLayerPaintingRootBackgroundOnly, we properly
reset the transparency state before returning.

* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContextStateStackChecker::~GraphicsContextStateStackChecker):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253691 => 253692)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 17:38:18 UTC (rev 253691)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 17:58:40 UTC (rev 253692)
@@ -1,3 +1,18 @@
+2019-12-18  Doug Kelly  
+
+Ensure transparency layers are properly ended when only painting root background
+https://bugs.webkit.org/show_bug.cgi?id=205285
+
+Reviewed by Simon Fraser.
+
+Ensure that if we are in a transparency layer and returning early from paintLayerContents() because of PaintLayerPaintingRootBackgroundOnly, we properly
+reset the transparency state before returning.
+
+* platform/graphics/GraphicsContext.h:
+(WebCore::GraphicsContextStateStackChecker::~GraphicsContextStateStackChecker):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::paintLayerContents):
+
 2019-12-18  ChangSeok Oh  
 
 [GTK] WebGL backed by ANGLE flickers when USE_OPENGL_ES is enabled.


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (253691 => 253692)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2019-12-18 17:38:18 UTC (rev 253691)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h	2019-12-18 17:58:40 UTC (rev 253692)
@@ -709,7 +709,7 @@
 ~GraphicsContextStateStackChecker()
 {
 if (m_context.stackSize() != m_stackSize)
-WTFLogAlways("GraphicsContext %p stack changed by %d", this, (int)m_context.stackSize() - (int)m_stackSize);
+WTFLogAlways("GraphicsContext %p stack changed by %d", _context, (int)m_context.stackSize() - (int)m_stackSize);
 }
 
 private:


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (253691 => 253692)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2019-12-18 17:38:18 UTC (rev 253691)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2019-12-18 17:58:40 UTC (rev 253692)
@@ -4532,8 +4532,16 @@
 || (!isPaintingScrollingContent && isPaintingCompositedForeground));
 bool shouldPaintContent = m_hasVisibleContent && isSelfPaintingLayer && !isPaintingOverlayScrollbars && !isCollectingEventRegion;
 
-if (localPaintFlags & PaintLayerPaintingRootBackgroundOnly && !renderer().isRenderView() && !renderer().isDocumentElementRenderer())
+if (localPaintFlags & PaintLayerPaintingRootBackgroundOnly && !renderer().isRenderView() && !renderer().isDocumentElementRenderer()) {
+// If beginTransparencyLayers was called prior to this, ensure the transparency state is cleaned up before returning.
+if (haveTransparency && m_usedTransparency && !m_paintingInsideReflection) {
+context.endTransparencyLayer();
+context.restore();
+m_usedTransparency = false;
+}
+
 return;
+}
 
 updateLayerListsIfNeeded();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253691] trunk/Source/WebCore

[changseok]

Title: [253691] trunk/Source/WebCore








Revision 253691
Author changs...@webkit.org
Date 2019-12-18 09:38:18 -0800 (Wed, 18 Dec 2019)


Log Message
[GTK] WebGL backed by ANGLE flickers when USE_OPENGL_ES is enabled.
https://bugs.webkit.org/show_bug.cgi?id=202508

Reviewed by Žan Doberšek.

The color format and internal one of BitmapTextureGL cannot be matched
where USE_ANGLE_WEBGL and USE_OPENGL_ES are enabled simultaneously.
This causes the flickering issue on WebGL scene since it prevents TextureMapper
from recycling available layer buffers due to mismatched color format.
When ANGLE_WEBGL is enabled, the internal color format is set GL_RGBA8.
However, that is not compatible to GLES textures. To address this,
We always make the color format of BitmapTextureGL GL_RGBA,
and only set its internal color format with a given value.

No new tests since no functionality changed.

* platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp:
(Nicosia::GC3DLayer::swapBuffersIfNeeded):
* platform/graphics/texmap/BitmapTextureGL.cpp:
(WebCore::BitmapTextureGL::BitmapTextureGL):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253690 => 253691)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 17:22:37 UTC (rev 253690)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 17:38:18 UTC (rev 253691)
@@ -1,3 +1,26 @@
+2019-12-18  ChangSeok Oh  
+
+[GTK] WebGL backed by ANGLE flickers when USE_OPENGL_ES is enabled.
+https://bugs.webkit.org/show_bug.cgi?id=202508
+
+Reviewed by Žan Doberšek.
+
+The color format and internal one of BitmapTextureGL cannot be matched
+where USE_ANGLE_WEBGL and USE_OPENGL_ES are enabled simultaneously.
+This causes the flickering issue on WebGL scene since it prevents TextureMapper
+from recycling available layer buffers due to mismatched color format.
+When ANGLE_WEBGL is enabled, the internal color format is set GL_RGBA8.
+However, that is not compatible to GLES textures. To address this,
+We always make the color format of BitmapTextureGL GL_RGBA,
+and only set its internal color format with a given value.
+
+No new tests since no functionality changed.
+
+* platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp:
+(Nicosia::GC3DLayer::swapBuffersIfNeeded):
+* platform/graphics/texmap/BitmapTextureGL.cpp:
+(WebCore::BitmapTextureGL::BitmapTextureGL):
+
 2019-12-18  Antti Koivisto  
 
 Style::Invalidator should be able to invalidate using multiple RuleSets in one pass


Modified: trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp (253690 => 253691)

--- trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp	2019-12-18 17:22:37 UTC (rev 253690)
+++ trunk/Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp	2019-12-18 17:38:18 UTC (rev 253691)
@@ -112,7 +112,7 @@
 std::unique_ptr layerBuffer;
 layerBuffer = proxy.getAvailableBuffer(textureSize, m_context.m_internalColorFormat);
 if (!layerBuffer) {
-auto texture = BitmapTextureGL::create(TextureMapperContextAttributes::get(), m_context.m_internalColorFormat);
+auto texture = BitmapTextureGL::create(TextureMapperContextAttributes::get(), flags, m_context.m_internalColorFormat);
 static_cast(texture.get()).setPendingContents(WTFMove(image));
 layerBuffer = makeUnique(WTFMove(texture), flags);
 } else


Modified: trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp (253690 => 253691)

--- trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp	2019-12-18 17:22:37 UTC (rev 253690)
+++ trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp	2019-12-18 17:38:18 UTC (rev 253691)
@@ -63,13 +63,14 @@
 
 BitmapTextureGL::BitmapTextureGL(const TextureMapperContextAttributes& contextAttributes, const Flags, GLint internalFormat)
 : m_contextAttributes(contextAttributes)
+, m_format(GL_RGBA)
 {
 if (internalFormat != GL_DONT_CARE) {
-m_internalFormat = m_format = internalFormat;
+m_internalFormat = internalFormat;
 return;
 }
 
-m_internalFormat = m_format = GL_RGBA;
+m_internalFormat = GL_RGBA;
 }
 
 void BitmapTextureGL::didReset()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253690] trunk/Source/WebCore

[antti]

Title: [253690] trunk/Source/WebCore








Revision 253690
Author an...@apple.com
Date 2019-12-18 09:22:37 -0800 (Wed, 18 Dec 2019)


Log Message
Style::Invalidator should be able to invalidate using multiple RuleSets in one pass
https://bugs.webkit.org/show_bug.cgi?id=205391

Reviewed by Zalan Bujtas.

It is inefficient to do multiple passes over DOM if there are multiple RuleSets to invalidate with.

* style/AttributeChangeInvalidation.cpp:
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):

Collect to a HashMap per MatchElement.

(WebCore::Style::AttributeChangeInvalidation::invalidateStyleWithRuleSets):

Call to common invalidation function in Style::Invalidator.

* style/AttributeChangeInvalidation.h:
* style/ClassChangeInvalidation.cpp:
(WebCore::Style::ClassChangeInvalidation::computeInvalidation):
(WebCore::Style::ClassChangeInvalidation::invalidateStyleWithRuleSets):

Same for classes.

* style/ClassChangeInvalidation.h:
* style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::Invalidator):

Take a Vector of RuleSets.

(WebCore::Style::Invalidator::invalidateIfNeeded):

Loop as needed.

(WebCore::Style::Invalidator::invalidateStyle):
(WebCore::Style::Invalidator::invalidateInShadowTreeIfNeeded):
(WebCore::Style::Invalidator::invalidateWithMatchElementRuleSets):

Factor the invalidation loop and HashMap to Invalidator.

* style/StyleInvalidator.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/AttributeChangeInvalidation.cpp
trunk/Source/WebCore/style/AttributeChangeInvalidation.h
trunk/Source/WebCore/style/ClassChangeInvalidation.cpp
trunk/Source/WebCore/style/ClassChangeInvalidation.h
trunk/Source/WebCore/style/StyleInvalidator.cpp
trunk/Source/WebCore/style/StyleInvalidator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (253689 => 253690)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 17:01:24 UTC (rev 253689)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 17:22:37 UTC (rev 253690)
@@ -1,3 +1,46 @@
+2019-12-18  Antti Koivisto  
+
+Style::Invalidator should be able to invalidate using multiple RuleSets in one pass
+https://bugs.webkit.org/show_bug.cgi?id=205391
+
+Reviewed by Zalan Bujtas.
+
+It is inefficient to do multiple passes over DOM if there are multiple RuleSets to invalidate with.
+
+* style/AttributeChangeInvalidation.cpp:
+(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):
+
+Collect to a HashMap per MatchElement.
+
+(WebCore::Style::AttributeChangeInvalidation::invalidateStyleWithRuleSets):
+
+Call to common invalidation function in Style::Invalidator.
+
+* style/AttributeChangeInvalidation.h:
+* style/ClassChangeInvalidation.cpp:
+(WebCore::Style::ClassChangeInvalidation::computeInvalidation):
+(WebCore::Style::ClassChangeInvalidation::invalidateStyleWithRuleSets):
+
+Same for classes.
+
+* style/ClassChangeInvalidation.h:
+* style/StyleInvalidator.cpp:
+(WebCore::Style::Invalidator::Invalidator):
+
+Take a Vector of RuleSets.
+
+(WebCore::Style::Invalidator::invalidateIfNeeded):
+
+Loop as needed.
+
+(WebCore::Style::Invalidator::invalidateStyle):
+(WebCore::Style::Invalidator::invalidateInShadowTreeIfNeeded):
+(WebCore::Style::Invalidator::invalidateWithMatchElementRuleSets):
+
+Factor the invalidation loop and HashMap to Invalidator.
+
+* style/StyleInvalidator.h:
+
 2019-12-18  Simon Fraser  
 
 Move m_exposedContentRect into the DelegatedScrollingGeometry optional


Modified: trunk/Source/WebCore/style/AttributeChangeInvalidation.cpp (253689 => 253690)

--- trunk/Source/WebCore/style/AttributeChangeInvalidation.cpp	2019-12-18 17:01:24 UTC (rev 253689)
+++ trunk/Source/WebCore/style/AttributeChangeInvalidation.cpp	2019-12-18 17:22:37 UTC (rev 253690)
@@ -28,8 +28,6 @@
 
 #include "ElementIterator.h"
 #include "StyleInvalidationFunctions.h"
-#include "StyleInvalidator.h"
-#include 
 
 namespace WebCore {
 namespace Style {
@@ -80,7 +78,7 @@
 bool oldMatches = !oldValue.isNull() && SelectorChecker::attributeSelectorMatches(m_element, attributeName, oldValue, *selector);
 bool newMatches = !newValue.isNull() && SelectorChecker::attributeSelectorMatches(m_element, attributeName, newValue, *selector);
 if (oldMatches != newMatches) {
-m_invalidationRuleSets.append();
+Invalidator::addToMatchElementRuleSets(m_matchElementRuleSets, invalidationRuleSet);
 break;
 }
 }
@@ -89,12 +87,7 @@
 
 void AttributeChangeInvalidation::invalidateStyleWithRuleSets()
 {
-SetForScope isInvalidating(m_element.styleResolver().ruleSets().isInvalidatingStyleWithRuleSets(), true);
-
-for (auto* invalidationRuleSet : m_invalidationRuleSets) {
-Invalidator invalidator(*invalidationRuleSet->ruleSet);
-

[webkit-changes] [253689] trunk/Source

[simon . fraser]

Title: [253689] trunk/Source








Revision 253689
Author simon.fra...@apple.com
Date 2019-12-18 09:01:24 -0800 (Wed, 18 Dec 2019)


Log Message
Move m_exposedContentRect into the DelegatedScrollingGeometry optional
https://bugs.webkit.org/show_bug.cgi?id=205377

Reviewed by Tim Horton.
Source/WebCore:

ScrollView's m_exposedContentRect is only set for delegated scrolling, so move it into
DelegatedScrollingGeometry and remove the iOS #ifdefs around it. Move the WAK/NSView-related
code into platformExposedContentRect() for iOS WK1. Stub out exposedContentRect() functions
on TiledCoreAnimationDrawingArea.

* platform/ScrollView.cpp:
(WebCore::ScrollView::exposedContentRect const):
(WebCore::ScrollView::setExposedContentRect):
(WebCore::ScrollView::platformExposedContentRect const):
* platform/ScrollView.h:
* platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::platformExposedContentRect const):
(WebCore::ScrollView::exposedContentRect const): Deleted.
(WebCore::ScrollView::setExposedContentRect): Deleted.

Source/WebKit:

ScrollView's m_exposedContentRect is only set for delegated scrolling, so move it into
DelegatedScrollingGeometry and remove the iOS #ifdefs around it. Move the WAK/NSView-related
code into platformExposedContentRect() for iOS WK1. Stub out exposedContentRect() functions
on TiledCoreAnimationDrawingArea.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setExposedContentRect):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::activityStateDidChange):
(WebKit::TiledCoreAnimationDrawingArea::setViewExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::exposedContentRect const):
(WebKit::TiledCoreAnimationDrawingArea::setExposedContentRect):
(WebKit::TiledCoreAnimationDrawingArea::adjustLayerFlushThrottling):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/platform/ios/ScrollViewIOS.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h
trunk/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (253688 => 253689)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 16:46:15 UTC (rev 253688)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 17:01:24 UTC (rev 253689)
@@ -1,3 +1,25 @@
+2019-12-18  Simon Fraser  
+
+Move m_exposedContentRect into the DelegatedScrollingGeometry optional
+https://bugs.webkit.org/show_bug.cgi?id=205377
+
+Reviewed by Tim Horton.
+
+ScrollView's m_exposedContentRect is only set for delegated scrolling, so move it into
+DelegatedScrollingGeometry and remove the iOS #ifdefs around it. Move the WAK/NSView-related
+code into platformExposedContentRect() for iOS WK1. Stub out exposedContentRect() functions
+on TiledCoreAnimationDrawingArea.
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::exposedContentRect const):
+(WebCore::ScrollView::setExposedContentRect):
+(WebCore::ScrollView::platformExposedContentRect const):
+* platform/ScrollView.h:
+* platform/ios/ScrollViewIOS.mm:
+(WebCore::ScrollView::platformExposedContentRect const):
+(WebCore::ScrollView::exposedContentRect const): Deleted.
+(WebCore::ScrollView::setExposedContentRect): Deleted.
+
 2019-12-18  Chris Dumez  
 
 REGRESSION: 32 Tests Crashing on Mac Debug wk2 with ASSERTION FAILED: m_pendingActivityForEventDispatch


Modified: trunk/Source/WebCore/platform/ScrollView.cpp (253688 => 253689)

--- trunk/Source/WebCore/platform/ScrollView.cpp	2019-12-18 16:46:15 UTC (rev 253688)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2019-12-18 17:01:24 UTC (rev 253689)
@@ -220,6 +220,33 @@
 setScrollPosition(position);
 }
 
+FloatRect ScrollView::exposedContentRect() const
+{
+#if PLATFORM(IOS_FAMILY)
+if (platformWidget())
+return platformExposedContentRect();
+#endif
+
+const ScrollView* parent = this->parent();
+if (!parent)
+return m_delegatedScrollingGeometry ? m_delegatedScrollingGeometry->exposedContentRect : FloatRect();
+
+IntRect parentViewExtentContentRect = enclosingIntRect(parent->exposedContentRect());
+IntRect selfExtentContentRect = rootViewToContents(parentViewExtentContentRect);
+selfExtentContentRect.intersect(boundsRect());
+return 

[webkit-changes] [253688] trunk/Source/WebCore

[cdumez]

Title: [253688] trunk/Source/WebCore








Revision 253688
Author cdu...@apple.com
Date 2019-12-18 08:46:15 -0800 (Wed, 18 Dec 2019)


Log Message
REGRESSION: 32 Tests Crashing on Mac Debug wk2 with ASSERTION FAILED: m_pendingActivityForEventDispatch
https://bugs.webkit.org/show_bug.cgi?id=205397


Unreviewed, fix debug assertion after r253667. The debug assertion is confused because we now use
the HTML5 event loop, which takes care of taking an ActiveDOMObject PendingActivity whenever we
queue an event.

* workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
(WebCore::ServiceWorkerRegistration::getNewestWorker const):
(WebCore::ServiceWorkerRegistration::updateStateFromServer):
(WebCore::ServiceWorkerRegistration::queueTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerRegistration::stop):
(WebCore::ServiceWorkerRegistration::hasPendingActivity const):
(WebCore::ServiceWorkerRegistration::getNewestWorker): Deleted.
(WebCore::ServiceWorkerRegistration::updatePendingActivityForEventDispatch): Deleted.
* workers/service/ServiceWorkerRegistration.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (253687 => 253688)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 16:40:26 UTC (rev 253687)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 16:46:15 UTC (rev 253688)
@@ -1,3 +1,24 @@
+2019-12-18  Chris Dumez  
+
+REGRESSION: 32 Tests Crashing on Mac Debug wk2 with ASSERTION FAILED: m_pendingActivityForEventDispatch
+https://bugs.webkit.org/show_bug.cgi?id=205397
+
+
+Unreviewed, fix debug assertion after r253667. The debug assertion is confused because we now use
+the HTML5 event loop, which takes care of taking an ActiveDOMObject PendingActivity whenever we
+queue an event.
+
+* workers/service/ServiceWorkerRegistration.cpp:
+(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
+(WebCore::ServiceWorkerRegistration::getNewestWorker const):
+(WebCore::ServiceWorkerRegistration::updateStateFromServer):
+(WebCore::ServiceWorkerRegistration::queueTaskToFireUpdateFoundEvent):
+(WebCore::ServiceWorkerRegistration::stop):
+(WebCore::ServiceWorkerRegistration::hasPendingActivity const):
+(WebCore::ServiceWorkerRegistration::getNewestWorker): Deleted.
+(WebCore::ServiceWorkerRegistration::updatePendingActivityForEventDispatch): Deleted.
+* workers/service/ServiceWorkerRegistration.h:
+
 2019-12-18  Diego Pino Garcia  
 
 [GTK][WPE] Renderization of Conic gradients


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp (253687 => 253688)

--- trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp	2019-12-18 16:40:26 UTC (rev 253687)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp	2019-12-18 16:46:15 UTC (rev 253688)
@@ -76,7 +76,6 @@
 m_container->addRegistration(*this);
 
 relaxAdoptionRequirement();
-updatePendingActivityForEventDispatch();
 }
 
 ServiceWorkerRegistration::~ServiceWorkerRegistration()
@@ -101,7 +100,7 @@
 return m_activeWorker.get();
 }
 
-ServiceWorker* ServiceWorkerRegistration::getNewestWorker()
+ServiceWorker* ServiceWorkerRegistration::getNewestWorker() const
 {
 if (m_installingWorker)
 return m_installingWorker.get();
@@ -179,7 +178,6 @@
 m_activeWorker = WTFMove(serviceWorker);
 break;
 }
-updatePendingActivityForEventDispatch();
 }
 
 void ServiceWorkerRegistration::queueTaskToFireUpdateFoundEvent()
@@ -189,7 +187,6 @@
 
 REGISTRATION_RELEASE_LOG_IF_ALLOWED("fireUpdateFoundEvent: Firing updatefound event for registration %llu", identifier().toUInt64());
 
-ASSERT(m_pendingActivityForEventDispatch);
 queueTaskToDispatchEvent(*this, TaskSource::DOMManipulation, Event::create(eventNames().updatefoundEvent, Event::CanBubble::No, Event::IsCancelable::No));
 }
 
@@ -212,19 +209,14 @@
 {
 m_isStopped = true;
 removeAllEventListeners();
-updatePendingActivityForEventDispatch();
 }
 
-void ServiceWorkerRegistration::updatePendingActivityForEventDispatch()
+bool ServiceWorkerRegistration::hasPendingActivity() const
 {
-// If a registration has no ServiceWorker, then it has been cleared on server-side.
-if (m_isStopped || !getNewestWorker()) {
-m_pendingActivityForEventDispatch = nullptr;
-return;
-}
-if (m_pendingActivityForEventDispatch)
-return;
-m_pendingActivityForEventDispatch = makePendingActivity(*this);
+if (!m_isStopped && getNewestWorker() && hasEventListeners())
+return true;
+
+return ActiveDOMObject::hasPendingActivity();
 }
 
 } // namespace WebCore


Modified: 

[webkit-changes] [253687] trunk/Source/WebKit

[wenson_hsieh]

Title: [253687] trunk/Source/WebKit








Revision 253687
Author wenson_hs...@apple.com
Date 2019-12-18 08:40:26 -0800 (Wed, 18 Dec 2019)


Log Message
Enable the async clipboard API by default on macOS and iOS
https://bugs.webkit.org/show_bug.cgi?id=205322


Reviewed by Tim Horton.

Enables the asynchronous clipboard API by default on Cocoa platforms.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (253686 => 253687)

--- trunk/Source/WebKit/ChangeLog	2019-12-18 16:23:49 UTC (rev 253686)
+++ trunk/Source/WebKit/ChangeLog	2019-12-18 16:40:26 UTC (rev 253687)
@@ -1,3 +1,16 @@
+2019-12-18  Wenson Hsieh  
+
+Enable the async clipboard API by default on macOS and iOS
+https://bugs.webkit.org/show_bug.cgi?id=205322
+
+
+Reviewed by Tim Horton.
+
+Enables the asynchronous clipboard API by default on Cocoa platforms.
+
+* Shared/WebPreferences.yaml:
+* Shared/WebPreferencesDefaultValues.h:
+
 2019-12-18  Philippe Normand  
 
 [GTK][WebInspector] Support for saving remote data


Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (253686 => 253687)

--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-12-18 16:23:49 UTC (rev 253686)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-12-18 16:40:26 UTC (rev 253687)
@@ -861,7 +861,7 @@
 
 AsyncClipboardAPIEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: DEFAULT_ASYNC_CLIPBOARD_API_ENABLED
   humanReadableName: "Async clipboard API"
   humanReadableDescription: "Enable the async clipboard API"
   category: experimental


Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (253686 => 253687)

--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2019-12-18 16:23:49 UTC (rev 253686)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2019-12-18 16:40:26 UTC (rev 253687)
@@ -248,8 +248,10 @@
 
 #if PLATFORM(COCOA)
 #define DEFAULT_CUSTOM_PASTEBOARD_DATA_ENABLED true
+#define DEFAULT_ASYNC_CLIPBOARD_API_ENABLED true
 #else
 #define DEFAULT_CUSTOM_PASTEBOARD_DATA_ENABLED false
+#define DEFAULT_ASYNC_CLIPBOARD_API_ENABLED false
 #endif
 
 #if PLATFORM(IOS) || PLATFORM(MAC)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253686] trunk/Source/ThirdParty/ANGLE

[dino]

Title: [253686] trunk/Source/ThirdParty/ANGLE








Revision 253686
Author d...@apple.com
Date 2019-12-18 08:23:49 -0800 (Wed, 18 Dec 2019)


Log Message
Reverting libANGLE.a -> libANGLE-shared.dylib.

Follow-up to remove the build phase that was trying
to fool Apple's build system.

* ANGLE.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
trunk/Source/ThirdParty/ANGLE/ChangeLog




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (253685 => 253686)

--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2019-12-18 16:23:47 UTC (rev 253685)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2019-12-18 16:23:49 UTC (rev 253686)
@@ -2974,7 +2974,6 @@
 312BDB0B15FECAB00097EBC7 /* CopyFiles */,
 312BDB0D15FECACE0097EBC7 /* CopyFiles */,
 6E28B8742294DD8000717E69 /* ShellScript */,
-313DE867239FFF91008FC47B /* Attempt to fool Apple Test Platform */,
 			);
 			buildRules = (
 53E934DB230609D800DE060C /* PBXBuildRule */,
@@ -3015,24 +3014,6 @@
 /* End PBXProject section */
 
 /* Begin PBXShellScriptBuildPhase section */
-		313DE867239FFF91008FC47B /* Attempt to fool Apple Test Platform */ = {
-			isa = PBXShellScriptBuildPhase;
-			buildActionMask = 2147483647;
-			files = (
-			);
-			inputFileListPaths = (
-			);
-			inputPaths = (
-			);
-			name = "Attempt to fool Apple Test Platform";
-			outputFileListPaths = (
-			);
-			outputPaths = (
-			);
-			runOnlyForDeploymentPostprocessing = 0;
-			shellPath = /bin/sh;
-			shellScript = "if [ \"$DEPLOYMENT_LOCATION\" == \"YES\" ] ; then\n# Apple-internal build.\noutput_dir=${DSTROOT}${WK_ALTERNATE_FRAMEWORKS_DIR}/usr/local/lib\nelse\n# External build.\noutput_dir=${BUILT_PRODUCTS_DIR}/usr/local/lib\nfi\n\nmkdir -p $output_dir\necho \"Fake file to fool Apple's test system\" > $output_dir/libANGLE.a\n";
-		};
 		6E28B8742294DD8000717E69 /* ShellScript */ = {
 			isa = PBXShellScriptBuildPhase;
 			buildActionMask = 2147483647;


Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (253685 => 253686)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2019-12-18 16:23:47 UTC (rev 253685)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2019-12-18 16:23:49 UTC (rev 253686)
@@ -2,6 +2,15 @@
 
 Reverting libANGLE.a -> libANGLE-shared.dylib.
 
+Follow-up to remove the build phase that was trying
+to fool Apple's build system.
+
+* ANGLE.xcodeproj/project.pbxproj:
+
+2019-12-18  Dean Jackson  
+
+Reverting libANGLE.a -> libANGLE-shared.dylib.
+
 The internal Apple build systems are still unhappy with
 this change, so I'm reverting it until I can be sure
 they'll accept it.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253684] trunk/LayoutTests

[youenn]

Title: [253684] trunk/LayoutTests








Revision 253684
Author you...@apple.com
Date 2019-12-18 08:08:27 -0800 (Wed, 18 Dec 2019)


Log Message
Layout Test imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=176929

Unreviewed.


* TestExpectations:
* platform/mac/TestExpectations:
Mark it as flaky in all platforms.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (253683 => 253684)

--- trunk/LayoutTests/ChangeLog	2019-12-18 15:48:59 UTC (rev 253683)
+++ trunk/LayoutTests/ChangeLog	2019-12-18 16:08:27 UTC (rev 253684)
@@ -1,3 +1,14 @@
+2019-12-18  youenn fablet  
+
+Layout Test imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=176929
+
+Unreviewed.
+
+* TestExpectations:
+* platform/mac/TestExpectations:
+Mark it as flaky in all platforms.
+
 2019-12-18  Chris Dumez  
 
 Re-sync web-platform-tests/common from upstream


Modified: trunk/LayoutTests/TestExpectations (253683 => 253684)

--- trunk/LayoutTests/TestExpectations	2019-12-18 15:48:59 UTC (rev 253683)
+++ trunk/LayoutTests/TestExpectations	2019-12-18 16:08:27 UTC (rev 253684)
@@ -258,6 +258,8 @@
 imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/tasks.window.html [ Skip ]
 imported/w3c/web-platform-tests/html/webappapis/scripting/event-loops/fully_active_document.window.html [ Skip ]
 
+webkit.org/b/176929 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html [ Pass Failure ]
+
 # Requires BroadcastChannel.
 imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-BarProp.window.html [ Skip ]
 imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-sizing.window.html [ Skip ]


Modified: trunk/LayoutTests/platform/mac/TestExpectations (253683 => 253684)

--- trunk/LayoutTests/platform/mac/TestExpectations	2019-12-18 15:48:59 UTC (rev 253683)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2019-12-18 16:08:27 UTC (rev 253684)
@@ -1730,8 +1730,6 @@
 webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer.html [ Slow ]
 [ HighSierra ] webgl/2.0.0/conformance2/textures/misc/copy-texture-image-luma-format.html [ Slow ]
 
-webkit.org/b/176929 [ Mojave+ ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html [ Pass Failure ]
-
 webkit.org/b/170877 [ Debug ] webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words.html [ Pass Timeout ]
 
 webkit.org/b/190883 legacy-animation-engine/animations/suspend-resume-animation.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253682] trunk/Source/WebCore

[zalan]

Title: [253682] trunk/Source/WebCore








Revision 253682
Author za...@apple.com
Date 2019-12-18 07:39:48 -0800 (Wed, 18 Dec 2019)


Log Message
[LFC][IFC] LineBreaker::isAtSoftWrapOpportunity should return the wrap position
https://bugs.webkit.org/show_bug.cgi?id=205371


Reviewed by Antti Koivisto.

Rename isAtSoftWrapOpportunity to lastSoftWrapOpportunity to reflect that it returns the last soft wrap
opportunity index.

* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::Content::lastSoftWrapOpportunity):
(WebCore::Layout::LineBreaker::Content::append):
(WebCore::Layout::LineBreaker::Content::isAtSoftWrapOpportunity): Deleted.
* layout/inlineformatting/InlineLineBreaker.h:
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineLayoutContext::placeInlineItem):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.h
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253681 => 253682)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 15:34:47 UTC (rev 253681)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 15:39:48 UTC (rev 253682)
@@ -1,5 +1,24 @@
 2019-12-18  Zalan Bujtas  
 
+[LFC][IFC] LineBreaker::isAtSoftWrapOpportunity should return the wrap position
+https://bugs.webkit.org/show_bug.cgi?id=205371
+
+
+Reviewed by Antti Koivisto.
+
+Rename isAtSoftWrapOpportunity to lastSoftWrapOpportunity to reflect that it returns the last soft wrap
+opportunity index.
+
+* layout/inlineformatting/InlineLineBreaker.cpp:
+(WebCore::Layout::LineBreaker::Content::lastSoftWrapOpportunity):
+(WebCore::Layout::LineBreaker::Content::append):
+(WebCore::Layout::LineBreaker::Content::isAtSoftWrapOpportunity): Deleted.
+* layout/inlineformatting/InlineLineBreaker.h:
+* layout/inlineformatting/LineLayoutContext.cpp:
+(WebCore::Layout::LineLayoutContext::placeInlineItem):
+
+2019-12-18  Zalan Bujtas  
+
 [LFC][IFC] Add lastInlineItemWithContent to LineBreaker::Content::isAtSoftWrapOpportunity
 https://bugs.webkit.org/show_bug.cgi?id=205362
 


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp (253681 => 253682)

--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp	2019-12-18 15:34:47 UTC (rev 253681)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp	2019-12-18 15:39:48 UTC (rev 253682)
@@ -280,7 +280,7 @@
 return !TextUtil::findNextBreakablePosition(lineBreakIterator, 0, nextInlineTextItem.style());
 }
 
-bool LineBreaker::Content::isAtSoftWrapOpportunity(const InlineItem& inlineItem, const Content& priorContent)
+Optional LineBreaker::Content::lastSoftWrapOpportunity(const InlineItem& inlineItem, const Content& priorContent)
 {
 // https://drafts.csswg.org/css-text-3/#line-break-details
 // Figure out if the new incoming content puts the uncommitted content on a soft wrap opportunity.
@@ -290,7 +290,7 @@
 ASSERT(!inlineItem.isFloat() && !inlineItem.isLineBreak());
 if (priorContent.isEmpty()) {
 // Can't decide it yet.
-return false;
+return { };
 }
 
 auto lastInlineItemWithContent = [&] () -> const InlineItem* {
@@ -308,7 +308,7 @@
 if (inlineItem.style().lineBreak() == LineBreak::Anywhere) {
 // There is a soft wrap opportunity around every typographic character unit, including around any punctuation character
 // or preserved white spaces, or in the middle of words.
-return true;
+return priorContent.size();
 }
 if (downcast(inlineItem).isWhitespace()) {
 // [prior content][ ] (some_content )
@@ -317,11 +317,11 @@
 // [ ][ ] : adjacent whitespace content has soft wrap opportunity.
 if (lastUncomittedContent->isText() && downcast(*lastUncomittedContent).isWhitespace())
 isAtSoftWrapOpportunityBeforeWhitespace = true;
-return isAtSoftWrapOpportunityBeforeWhitespace;
+return isAtSoftWrapOpportunityBeforeWhitespace ? makeOptional(priorContent.size()) : WTF::nullopt;
 }
 if (lastUncomittedContent->isContainerStart()) {
 // [container start][text] (text) : the [container start] and the [text] content form a continuous content.
-return false;
+return { };
 }
 if (lastUncomittedContent->isContainerEnd()) {
 // [container end][text] (text)
@@ -332,7 +332,7 @@
 lastUncomittedContent = lastInlineItemWithContent();
 if (!lastUncomittedContent) {
 // Did not find any content at all (e.g. [container start][container end][text] (text)).
-return false;
+return { };
  

[webkit-changes] [253681] trunk/Source/WebCore

[zalan]

Title: [253681] trunk/Source/WebCore








Revision 253681
Author za...@apple.com
Date 2019-12-18 07:34:47 -0800 (Wed, 18 Dec 2019)


Log Message
[LFC][IFC] Add lastInlineItemWithContent to LineBreaker::Content::isAtSoftWrapOpportunity
https://bugs.webkit.org/show_bug.cgi?id=205362


Reviewed by Antti Koivisto.

This is in preparation for being able to return a previous run index as the soft wrapping opportunity.

* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::endsWithSoftWrapOpportunity):
(WebCore::Layout::LineBreaker::Content::isAtSoftWrapOpportunity):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253680 => 253681)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 15:27:15 UTC (rev 253680)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 15:34:47 UTC (rev 253681)
@@ -1,3 +1,17 @@
+2019-12-18  Zalan Bujtas  
+
+[LFC][IFC] Add lastInlineItemWithContent to LineBreaker::Content::isAtSoftWrapOpportunity
+https://bugs.webkit.org/show_bug.cgi?id=205362
+
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for being able to return a previous run index as the soft wrapping opportunity.
+
+* layout/inlineformatting/InlineLineBreaker.cpp:
+(WebCore::Layout::endsWithSoftWrapOpportunity):
+(WebCore::Layout::LineBreaker::Content::isAtSoftWrapOpportunity):
+
 2019-12-18  Dean Jackson  
 
 Reverting libANGLE.a -> libANGLE-shared.dylib.


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp (253680 => 253681)

--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp	2019-12-18 15:27:15 UTC (rev 253680)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp	2019-12-18 15:34:47 UTC (rev 253681)
@@ -261,6 +261,9 @@
 // they are split at a soft breaking opportunity. See InlineTextItem::moveToNextBreakablePosition.
 if (() == ())
 return true;
+// We are at the position after a whitespace.
+if (previousTextItem.isWhitespace())
+return true;
 // Now we need to collect at least 3 adjacent characters to be able to make a descision whether the previous text item ends with breaking opportunity.
 // [ex-][ample] <- second to last[x] last[-] current[a]
 // We need at least 1 character in the current inline text item and 2 more from previous inline items.
@@ -289,6 +292,17 @@
 // Can't decide it yet.
 return false;
 }
+
+auto lastInlineItemWithContent = [&] () -> const InlineItem* {
+for (auto& previousRun : WTF::makeReversedRange(priorContent.runs())) {
+auto& previousInlineItem = previousRun.inlineItem;
+if (previousInlineItem.isText() || previousInlineItem.isBox())
+return 
+ASSERT(previousInlineItem.isContainerStart() || previousInlineItem.isContainerEnd());
+}
+return nullptr;
+};
+
 auto* lastUncomittedContent = ().last().inlineItem;
 if (inlineItem.isText()) {
 if (inlineItem.style().lineBreak() == LineBreak::Anywhere) {
@@ -315,31 +329,17 @@
 // e.g.
 // [text][container end][text] (texttext) : there's no soft wrap opportunity here.
 // [inline box][container end][text] (text) : after [container end] position is a soft wrap opportunity.
-auto& runs = priorContent.runs();
-auto didFindContent = false;
-for (auto i = priorContent.size(); i--;) {
-auto& previousInlineItem = runs[i].inlineItem;
-if (previousInlineItem.isContainerStart() || previousInlineItem.isContainerEnd())
-continue;
-if (previousInlineItem.isText() || previousInlineItem.isBox()) {
-lastUncomittedContent = 
-didFindContent = true;
-break;
-}
-ASSERT_NOT_REACHED();
+lastUncomittedContent = lastInlineItemWithContent();
+if (!lastUncomittedContent) {
+// Did not find any content at all (e.g. [container start][container end][text] (text)).
+return false;
 }
-// Did not find any content at all (e.g. [container start][container end][text] (text)).
-if (!didFindContent)
-return false;
 }
 if (lastUncomittedContent->isText()) {
 // [text][text] : is a continuous content.
 // [text-][text] : after [hyphen] position is a soft wrap opportunity.
 // [ ][text] : after [whitespace] position is a soft wrap opportunity.
-auto& lastInlineTextItem = downcast(*lastUncomittedContent);
-if (lastInlineTextItem.isWhitespace())
-return true;
-return endsWithSoftWrapOpportunity(lastInlineTextItem, downcast(inlineItem));
+

[webkit-changes] [253680] trunk/Source

[dino]

Title: [253680] trunk/Source








Revision 253680
Author d...@apple.com
Date 2019-12-18 07:27:15 -0800 (Wed, 18 Dec 2019)


Log Message
Reverting libANGLE.a -> libANGLE-shared.dylib.

The internal Apple build systems are still unhappy with
this change, so I'm reverting it until I can be sure
they'll accept it.

Source/ThirdParty/ANGLE:

* ANGLE.xcodeproj/project.pbxproj:
* Configurations/ANGLE.xcconfig:
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* include/CMakeLists.txt:
* include/GLSLANG/ShaderLang.h:
* include/GLSLANG/ShaderVars.h:
* src/libANGLE/renderer/gl/cgl/DisplayCGL.mm:
(rx::DisplayCGL::isValidNativeWindow const):
* src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm:
(rx::WindowSurfaceCGL::WindowSurfaceCGL):
(rx::WindowSurfaceCGL::~WindowSurfaceCGL):
* src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:
(rx::DisplayEAGL::terminate):
(rx::DisplayEAGL::isValidNativeWindow const):
(rx::WorkerContextEAGL::~WorkerContextEAGL):
* src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm:
(rx::WindowSurfaceEAGL::WindowSurfaceEAGL):
(rx::WindowSurfaceEAGL::~WindowSurfaceEAGL):

Source/WebCore:

* Configurations/WebCore.xcconfig:
* Configurations/WebCoreTestSupport.xcconfig:
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::cleanupCompilers):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
(WebCore::ANGLEWebKitBridge::angleAvailable): Deleted.
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/cocoa/GraphicsContext3DCocoa.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):

Modified Paths

trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig
trunk/Source/ThirdParty/ANGLE/include/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h
trunk/Source/ThirdParty/ANGLE/include/GLSLANG/ShaderVars.h
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/DisplayCGL.mm
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp
trunk/Source/WebCore/platform/graphics/ANGLEWebKitBridge.h
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (253679 => 253680)

--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2019-12-18 14:57:32 UTC (rev 253679)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2019-12-18 15:27:15 UTC (rev 253680)
@@ -455,6 +455,7 @@
 		5CB301461DE39F1A00D2C405 /* VertexArrayGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB301131DE39F1A00D2C405 /* VertexArrayGL.h */; };
 		5CB3014F1DE39F4700D2C405 /* DisplayCGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB301491DE39F4700D2C405 /* DisplayCGL.h */; };
 		5CB301511DE39F4700D2C405 /* PbufferSurfaceCGL.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB3014B1DE39F4700D2C405 /* PbufferSurfaceCGL.h */; };
+		5CB304921DE4156200D2C405 /* OpenGL.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048D1DE4144400D2C405 /* OpenGL.framework */; };
 		5CB304931DE4156B00D2C405 /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048F1DE4145500D2C405 /* QuartzCore.framework */; };
 		5CB304941DE4157200D2C405 /* CoreGraphics.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 5CB3048B1DE4143500D2C405 /* CoreGraphics.framework */; };
 		5CB304961DE4157B00D2C405 /* entry_points_egl_ext.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CB300BC1DE39E7500D2C405 /* entry_points_egl_ext.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -835,8 +836,6 @@
 		313BCE532361133900FC39E5 /* DisplayEAGL.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DisplayEAGL.mm; sourceTree = ""; };
 		3153ACFE239071D900D51DD8 /* WebKitTargetConditionals.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = WebKitTargetConditionals.xcconfig; sourceTree = ""; };
 		3153ACFF239071D900D51DD8 /* Version.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = Version.xcconfig; sourceTree = ""; };
-		3153AD002390C2EA00D51DD8 /* IOSurface.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = IOSurface.framework; path = System/Library/Frameworks/IOSurface.framework; sourceTree = SDKROOT; };
-		3153AD022390C32100D51DD8 

[webkit-changes] [253679] trunk/LayoutTests

[commit-queue]

Title: [253679] trunk/LayoutTests








Revision 253679
Author commit-qu...@webkit.org
Date 2019-12-18 06:57:32 -0800 (Wed, 18 Dec 2019)


Log Message
REGRESSION: animations/leak-document-with-css-animation.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=205299

While this test has proven to be solid running in isolation, it appears that the difference of live documents
before and after the iframe has been destroyed may be more than one. In fact, in reported failures, there always
seems to be 2 live documents fewer after than before, instead of the expected single document.

Since internals.numberOfLiveDocuments() returns the number of live documents throughout the life of the
Web process, we now force garbage collection every time we query internals.numberOfLiveDocuments(). This
should ensure that documents pending destruction due to garbage collection to be destroyed before we take
a snapshort of the number of live documents.

Patch by Antoine Quint  on 2019-12-18
Reviewed by Antti Koivisto.

* TestExpectations:
* animations/leak-document-with-css-animation.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/animations/leak-document-with-css-animation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (253678 => 253679)

--- trunk/LayoutTests/ChangeLog	2019-12-18 12:48:43 UTC (rev 253678)
+++ trunk/LayoutTests/ChangeLog	2019-12-18 14:57:32 UTC (rev 253679)
@@ -1,5 +1,24 @@
 2019-12-18  Antoine Quint  
 
+REGRESSION: animations/leak-document-with-css-animation.html is very flaky
+https://bugs.webkit.org/show_bug.cgi?id=205299
+
+While this test has proven to be solid running in isolation, it appears that the difference of live documents
+before and after the iframe has been destroyed may be more than one. In fact, in reported failures, there always
+seems to be 2 live documents fewer after than before, instead of the expected single document.
+
+Since internals.numberOfLiveDocuments() returns the number of live documents throughout the life of the
+Web process, we now force garbage collection every time we query internals.numberOfLiveDocuments(). This
+should ensure that documents pending destruction due to garbage collection to be destroyed before we take
+a snapshort of the number of live documents.
+
+Reviewed by Antti Koivisto.
+
+* TestExpectations:
+* animations/leak-document-with-css-animation.html:
+
+2019-12-18  Antoine Quint  
+
 [macOS/iOS Debug] Layout Test webanimations/animation-opacity-animation-crash.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=181612
 


Modified: trunk/LayoutTests/TestExpectations (253678 => 253679)

--- trunk/LayoutTests/TestExpectations	2019-12-18 12:48:43 UTC (rev 253678)
+++ trunk/LayoutTests/TestExpectations	2019-12-18 14:57:32 UTC (rev 253679)
@@ -3814,5 +3814,3 @@
 webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html [ Skip ]
 webgl/1.0.3/conformance/canvas/rapid-resizing.html [ Skip ]
 webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html [ Skip ]
-
-webkit.org/b/205299 animations/leak-document-with-css-animation.html [ Pass Failure ]


Modified: trunk/LayoutTests/animations/leak-document-with-css-animation.html (253678 => 253679)

--- trunk/LayoutTests/animations/leak-document-with-css-animation.html	2019-12-18 12:48:43 UTC (rev 253678)
+++ trunk/LayoutTests/animations/leak-document-with-css-animation.html	2019-12-18 14:57:32 UTC (rev 253679)
@@ -22,18 +22,21 @@
 if (frame.src ="" 'about:blank')
 return true;
 
-numberOfLiveDocumentsAfterIframeLoaded = internals.numberOfLiveDocuments();
-debug("The iframe has finished loading.");
+gc();
+setTimeout(function () {
+numberOfLiveDocumentsAfterIframeLoaded = internals.numberOfLiveDocuments();
+debug("The iframe has finished loading.");
 
-frame.remove();
-frame = null;
+frame.remove();
+frame = null;
 
-gc();
-setTimeout(function () {
-debug("The iframe has been destroyed.");
-shouldBe("internals.numberOfLiveDocuments()", "numberOfLiveDocumentsAfterIframeLoaded - 1");
-debug("");
-finishJSTest();
+gc();
+setTimeout(function () {
+debug("The iframe has been destroyed.");
+shouldBe("internals.numberOfLiveDocuments()", "numberOfLiveDocumentsAfterIframeLoaded - 1");
+debug("");
+finishJSTest();
+});
 });
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253678] trunk/Source/WebKit

[philn]

Title: [253678] trunk/Source/WebKit








Revision 253678
Author ph...@webkit.org
Date 2019-12-18 04:48:43 -0800 (Wed, 18 Dec 2019)


Log Message
[GTK][WebInspector] Support for saving remote data
https://bugs.webkit.org/show_bug.cgi?id=204618

Reviewed by Carlos Garcia Campos.

Similarly to what landed already in r251069, the Remote
WebInspector GTK client can now save data coming from the
inspector server.

* UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp:
(WebKit::RemoteWebInspectorProxy::platformSave):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp
trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (253677 => 253678)

--- trunk/Source/WebKit/ChangeLog	2019-12-18 12:07:00 UTC (rev 253677)
+++ trunk/Source/WebKit/ChangeLog	2019-12-18 12:48:43 UTC (rev 253678)
@@ -1,3 +1,17 @@
+2019-12-18  Philippe Normand  
+
+[GTK][WebInspector] Support for saving remote data
+https://bugs.webkit.org/show_bug.cgi?id=204618
+
+Reviewed by Carlos Garcia Campos.
+
+Similarly to what landed already in r251069, the Remote
+WebInspector GTK client can now save data coming from the
+inspector server.
+
+* UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp:
+(WebKit::RemoteWebInspectorProxy::platformSave):
+
 2019-12-17  Joonghun Park  
 
 Unreviewed. Remove the build warning below since r253452.


Modified: trunk/Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp (253677 => 253678)

--- trunk/Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp	2019-12-18 12:07:00 UTC (rev 253677)
+++ trunk/Source/WebKit/UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp	2019-12-18 12:48:43 UTC (rev 253678)
@@ -28,11 +28,13 @@
 
 #if ENABLE(REMOTE_INSPECTOR)
 
+#include "RemoteWebInspectorUIMessages.h"
 #include "WebInspectorProxy.h"
 #include "WebKitInspectorWindow.h"
 #include "WebKitWebViewBasePrivate.h"
 #include "WebPageGroup.h"
 #include 
+#include 
 
 namespace WebKit {
 using namespace WebCore;
@@ -99,10 +101,54 @@
 gtk_window_present(GTK_WINDOW(m_window));
 }
 
-void RemoteWebInspectorProxy::platformSave(const String&, const String&, bool, bool)
+static void remoteFileReplaceContentsCallback(GObject* sourceObject, GAsyncResult* result, gpointer userData)
 {
+GFile* file = G_FILE(sourceObject);
+if (!g_file_replace_contents_finish(file, result, nullptr, nullptr))
+return;
+
+auto* page = static_cast(userData);
+GUniquePtr path(g_file_get_path(file));
+page->process().send(Messages::RemoteWebInspectorUI::DidSave(path.get()), page->webPageID());
 }
 
+void RemoteWebInspectorProxy::platformSave(const String& suggestedURL, const String& content, bool base64Encoded, bool forceSaveDialog)
+{
+UNUSED_PARAM(forceSaveDialog);
+
+GRefPtr dialog = adoptGRef(gtk_file_chooser_native_new("Save File",
+GTK_WINDOW(m_window), GTK_FILE_CHOOSER_ACTION_SAVE, "Save", "Cancel"));
+
+GtkFileChooser* chooser = GTK_FILE_CHOOSER(dialog.get());
+gtk_file_chooser_set_do_overwrite_confirmation(chooser, TRUE);
+
+// Some inspector views (Audits for instance) use a custom URI scheme, such
+// as web-inspector. So we can't rely on the URL being a valid file:/// URL
+// unfortunately.
+URL url(URL(), suggestedURL);
+// Strip leading / character.
+gtk_file_chooser_set_current_name(chooser, url.path().substring(1).utf8().data());
+
+if (gtk_native_dialog_run(GTK_NATIVE_DIALOG(dialog.get())) != GTK_RESPONSE_ACCEPT)
+return;
+
+Vector dataVector;
+CString dataString;
+if (base64Encoded) {
+if (!base64Decode(content, dataVector, Base64ValidatePadding))
+return;
+dataVector.shrinkToFit();
+} else
+dataString = content.utf8();
+
+const char* data = "" ? dataString.data() : dataVector.data();
+size_t dataLength = !dataString.isNull() ? dataString.length() : dataVector.size();
+GRefPtr file = adoptGRef(gtk_file_chooser_get_file(chooser));
+GUniquePtr path(g_file_get_path(file.get()));
+g_file_replace_contents_async(file.get(), data, dataLength, nullptr, false,
+G_FILE_CREATE_REPLACE_DESTINATION, nullptr, remoteFileReplaceContentsCallback, m_inspectorPage);
+}
+
 void RemoteWebInspectorProxy::platformAppend(const String&, const String&)
 {
 }


Modified: trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp (253677 => 253678)

--- trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp	2019-12-18 12:07:00 UTC (rev 253677)
+++ trunk/Source/WebKit/UIProcess/gtk/WebInspectorProxyGtk.cpp	2019-12-18 12:48:43 UTC (rev 253678)
@@ -460,8 +460,19 @@
 notImplemented();
 }
 
-void WebInspectorProxy::platformSave(const String& filename, const String& content, bool base64Encoded, bool forceSaveDialog)
+static void fileReplaceContentsCallback(GObject* sourceObject, GAsyncResult* result, gpointer userData)
 {
+

[webkit-changes] [253677] trunk/Source/WebCore

[commit-queue]

Title: [253677] trunk/Source/WebCore








Revision 253677
Author commit-qu...@webkit.org
Date 2019-12-18 04:07:00 -0800 (Wed, 18 Dec 2019)


Log Message
Missing headers in worker files cause random build failures when adding new files
https://bugs.webkit.org/show_bug.cgi?id=205385

Patch by Chris Lord  on 2019-12-18
Reviewed by Youenn Fablet.

No new tests, no behavioral changes.

* workers/service/context/ServiceWorkerThreadProxy.cpp:
* workers/service/server/SWServerRegistration.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
trunk/Source/WebCore/workers/service/server/SWServerRegistration.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253676 => 253677)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 10:41:30 UTC (rev 253676)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 12:07:00 UTC (rev 253677)
@@ -1,5 +1,17 @@
 2019-12-18  Chris Lord  
 
+Missing headers in worker files cause random build failures when adding new files
+https://bugs.webkit.org/show_bug.cgi?id=205385
+
+Reviewed by Youenn Fablet.
+
+No new tests, no behavioral changes.
+
+* workers/service/context/ServiceWorkerThreadProxy.cpp:
+* workers/service/server/SWServerRegistration.cpp:
+
+2019-12-18  Chris Lord  
+
 [GTK][WPE] OffscreenCanvas worker tests that call drawImage crash in debug builds
 https://bugs.webkit.org/show_bug.cgi?id=205339
 


Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp (253676 => 253677)

--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp	2019-12-18 10:41:30 UTC (rev 253676)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp	2019-12-18 12:07:00 UTC (rev 253677)
@@ -29,6 +29,7 @@
 #if ENABLE(SERVICE_WORKER)
 
 #include "CacheStorageProvider.h"
+#include "EventLoop.h"
 #include "EventNames.h"
 #include "FetchLoader.h"
 #include "Frame.h"


Modified: trunk/Source/WebCore/workers/service/server/SWServerRegistration.cpp (253676 => 253677)

--- trunk/Source/WebCore/workers/service/server/SWServerRegistration.cpp	2019-12-18 10:41:30 UTC (rev 253676)
+++ trunk/Source/WebCore/workers/service/server/SWServerRegistration.cpp	2019-12-18 12:07:00 UTC (rev 253677)
@@ -28,6 +28,7 @@
 
 #if ENABLE(SERVICE_WORKER)
 
+#include "Logging.h"
 #include "SWServer.h"
 #include "SWServerToContextConnection.h"
 #include "SWServerWorker.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253676] trunk/LayoutTests

[commit-queue]

Title: [253676] trunk/LayoutTests








Revision 253676
Author commit-qu...@webkit.org
Date 2019-12-18 02:41:30 -0800 (Wed, 18 Dec 2019)


Log Message
[macOS/iOS Debug] Layout Test webanimations/animation-opacity-animation-crash.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=181612

This test is no longer flaky, removing any specific expectations.

Patch by Antoine Quint  on 2019-12-18
Reviewed by Dean Jackson.

* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (253675 => 253676)

--- trunk/LayoutTests/ChangeLog	2019-12-18 09:02:46 UTC (rev 253675)
+++ trunk/LayoutTests/ChangeLog	2019-12-18 10:41:30 UTC (rev 253676)
@@ -1,3 +1,15 @@
+2019-12-18  Antoine Quint  
+
+[macOS/iOS Debug] Layout Test webanimations/animation-opacity-animation-crash.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=181612
+
+This test is no longer flaky, removing any specific expectations.
+
+Reviewed by Dean Jackson.
+
+* platform/ios/TestExpectations:
+* platform/mac/TestExpectations:
+
 2019-12-17  Fujii Hironori  
 
 [iOS] Arabic text on Wikipedia is shown as boxes


Modified: trunk/LayoutTests/platform/ios/TestExpectations (253675 => 253676)

--- trunk/LayoutTests/platform/ios/TestExpectations	2019-12-18 09:02:46 UTC (rev 253675)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2019-12-18 10:41:30 UTC (rev 253676)
@@ -3050,8 +3050,6 @@
 
 webkit.org/b/182592 webgl/webgl-texture-image-buffer-reuse.html [ Skip ]
 
-webkit.org/b/181612 [ Debug ] webanimations/animation-opacity-animation-crash.html [ Pass Failure ]
-
 webkit.org/b/182850 editing/pasteboard/data-transfer-set-data-sanitizes-html-when-copying-in-null-origin.html [ Skip ]
 
 webkit.org/b/183219 editing/pasteboard/data-transfer-get-data-on-pasting-html-uses-blob-url.html [ Skip ]


Modified: trunk/LayoutTests/platform/mac/TestExpectations (253675 => 253676)

--- trunk/LayoutTests/platform/mac/TestExpectations	2019-12-18 09:02:46 UTC (rev 253675)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2019-12-18 10:41:30 UTC (rev 253676)
@@ -1601,8 +1601,6 @@
 
 webkit.org/b/181831 [ HighSierra+ ] fast/forms/searchfield-heights.html [ Pass Failure ]
 
-webkit.org/b/181612 [ Debug ] webanimations/animation-opacity-animation-crash.html [ Pass Failure ]
-
 webkit.org/b/173946 [ Debug ] media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Pass Failure ]
 
 webkit.org/b/183490 media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [253675] trunk/Source/WebCore

[commit-queue]

Title: [253675] trunk/Source/WebCore








Revision 253675
Author commit-qu...@webkit.org
Date 2019-12-18 01:02:46 -0800 (Wed, 18 Dec 2019)


Log Message
[GTK][WPE] OffscreenCanvas worker tests that call drawImage crash in debug builds
https://bugs.webkit.org/show_bug.cgi?id=205339

Patch by Chris Lord  on 2019-12-18
Reviewed by Carlos Garcia Campos.

Don't unnecessarily create an Image object in the Cairo graphics
backend when using drawImage/drawPattern. Doing so calls code that
isn't safe to use off-main-thread and causes OffscreenCanvas worker
tests to crash in debug builds.

No new tests, no behavioral changes.

* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::cairoSurfaceCopy):
(WebCore::cairoSurfaceCoerceToImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (253674 => 253675)

--- trunk/Source/WebCore/ChangeLog	2019-12-18 08:38:01 UTC (rev 253674)
+++ trunk/Source/WebCore/ChangeLog	2019-12-18 09:02:46 UTC (rev 253675)
@@ -1,3 +1,23 @@
+2019-12-18  Chris Lord  
+
+[GTK][WPE] OffscreenCanvas worker tests that call drawImage crash in debug builds
+https://bugs.webkit.org/show_bug.cgi?id=205339
+
+Reviewed by Carlos Garcia Campos.
+
+Don't unnecessarily create an Image object in the Cairo graphics
+backend when using drawImage/drawPattern. Doing so calls code that
+isn't safe to use off-main-thread and causes OffscreenCanvas worker
+tests to crash in debug builds.
+
+No new tests, no behavioral changes.
+
+* platform/graphics/cairo/ImageBufferCairo.cpp:
+(WebCore::cairoSurfaceCopy):
+(WebCore::cairoSurfaceCoerceToImage):
+(WebCore::ImageBuffer::draw):
+(WebCore::ImageBuffer::drawPattern):
+
 2019-12-17  Simon Fraser  
 
 Remove iOS #ifdefs around unobscuredContentSize


Modified: trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp (253674 => 253675)

--- trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp	2019-12-18 08:38:01 UTC (rev 253674)
+++ trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp	2019-12-18 09:02:46 UTC (rev 253675)
@@ -225,12 +225,8 @@
 #endif
 
 static RefPtr
-cairoSurfaceCoerceToImage(cairo_surface_t* surface)
+cairoSurfaceCopy(cairo_surface_t* surface)
 {
-if (cairo_surface_get_type(surface) == CAIRO_SURFACE_TYPE_IMAGE
-&& cairo_surface_get_content(surface) == CAIRO_CONTENT_COLOR_ALPHA)
-return surface;
-
 auto copy = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32,
 cairo_image_surface_get_width(surface),
 cairo_image_surface_get_height(surface)));
@@ -243,6 +239,16 @@
 return copy;
 }
 
+static RefPtr
+cairoSurfaceCoerceToImage(cairo_surface_t* surface)
+{
+if (cairo_surface_get_type(surface) == CAIRO_SURFACE_TYPE_IMAGE
+&& cairo_surface_get_content(surface) == CAIRO_CONTENT_COLOR_ALPHA)
+return surface;
+
+return cairoSurfaceCopy(surface);
+}
+
 Vector ImageBuffer::toBGRAData() const
 {
 auto surface = cairoSurfaceCoerceToImage(m_data.m_surface.get());
@@ -356,16 +362,27 @@
 
 void ImageBuffer::draw(GraphicsContext& destinationContext, const FloatRect& destRect, const FloatRect& srcRect,  const ImagePaintingOptions& options)
 {
-BackingStoreCopy copyMode =  == () ? CopyBackingStore : DontCopyBackingStore;
-RefPtr image = copyImage(copyMode);
-destinationContext.drawImage(*image, destRect, srcRect, options);
+if (destinationContext.paintingDisabled())
+return;
+
+if (auto surface = nativeImage()) {
+if ( == ())
+surface = cairoSurfaceCopy(surface.get());
+
+InterpolationQualityMaintainer interpolationQualityForThisScope(destinationContext, options.interpolationQuality());
+const auto& destinationContextState = destinationContext.state();
+drawNativeImage(*destinationContext.platformContext(), surface.get(), destRect, srcRect, { options, destinationContextState.imageInterpolationQuality }, destinationContextState.alpha, WebCore::Cairo::ShadowState(destinationContextState));
+}
 }
 
 void ImageBuffer::drawPattern(GraphicsContext& context, const FloatRect& destRect, const FloatRect& srcRect, const AffineTransform& patternTransform,
-const FloatPoint& phase, const FloatSize& spacing, const ImagePaintingOptions& options)
+const FloatPoint& phase, const FloatSize&, const ImagePaintingOptions& options)
 {
-if (RefPtr image = copyImage(DontCopyBackingStore))
-image->drawPattern(context, destRect, srcRect, patternTransform, phase, spacing, options);
+if (context.paintingDisabled())
+return;
+
+if (auto surface = nativeImage())
+Cairo::drawPattern(*context.platformContext(), surface.get(), m_size, destRect, srcRect, patternTransform, phase, 

[webkit-changes] [253674] trunk/Tools

[carlosgc]

Title: [253674] trunk/Tools








Revision 253674
Author carlo...@webkit.org
Date 2019-12-18 00:38:01 -0800 (Wed, 18 Dec 2019)


Log Message
Unreviewed GTK gardening. Update expectations of unit tests

Add two flaky failures and mark /jsc/vm as slow alos in release builds.

* TestWebKitAPI/glib/TestExpectations.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json




Diff

Modified: trunk/Tools/ChangeLog (253673 => 253674)

--- trunk/Tools/ChangeLog	2019-12-18 07:00:28 UTC (rev 253673)
+++ trunk/Tools/ChangeLog	2019-12-18 08:38:01 UTC (rev 253674)
@@ -1,3 +1,11 @@
+2019-12-18  Carlos Garcia Campos  
+
+Unreviewed GTK gardening. Update expectations of unit tests
+
+Add two flaky failures and mark /jsc/vm as slow alos in release builds.
+
+* TestWebKitAPI/glib/TestExpectations.json:
+
 2019-12-17  Jonathan Bedard  
 
 run-_javascript_core-tests: Fix upload details


Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (253673 => 253674)

--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2019-12-18 07:00:28 UTC (rev 253673)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json	2019-12-18 08:38:01 UTC (rev 253674)
@@ -46,6 +46,9 @@
 },
 "/webkit/WebKitWebExtension/form-submission-steps": {
 "expected": {"gtk": {"status": ["TIMEOUT"], "bug": "webkit.org/b/205333"}}
+},
+"/webkit/WebKitWebExtension/form-controls-associated-signal": {
+"expected": {"gtk": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/205380"}}
 }
 }
 },
@@ -83,6 +86,13 @@
 }
 }
 },
+"TestWebKitFaviconDatabase": {
+"subtests": {
+"/webkit/WebKitFaviconDatabase/get-favicon": {
+"expected": {"gtk": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/205381"}}
+}
+}
+},
 "TestWebKit": {
 "subtests": {
 "WebKit.MouseMoveAfterCrash": {
@@ -170,6 +180,9 @@
 "WTF_ParkingLot.UnparkAllHundredFast": {
 "expected": {"all": {"slow": true, "status": ["TIMEOUT", "PASS"]}}
 },
+"WTF_ParkingLot.UnparkAllOneFast": {
+"expected": {"all": {"slow": true, "status": ["TIMEOUT", "PASS"]}}
+},
 "WTF_ParkingLot.UnparkOneFiftyThenFiftyAllFast": {
 "expected": {"all": {"slow": true, "status": ["TIMEOUT", "PASS"]}}
 },
@@ -197,7 +210,7 @@
 "TestJSC": {
 "subtests": {
 "/jsc/vm": {
-"expected": {"all@Debug": {"slow": true}}
+"expected": {"all": {"slow": true}}
 }
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes