date:20200106

[webkit-changes] [254114] trunk

2020-01-06 Thread Hironori . Fujii

Title: [254114] trunk








Revision 254114
Author hironori.fu...@sony.com
Date 2020-01-06 23:49:12 -0800 (Mon, 06 Jan 2020)


Log Message
ComplexTextController::offsetForPosition returns a wrong offset for a glyph boundary in a RTL text
https://bugs.webkit.org/show_bug.cgi?id=205486

Reviewed by Ross Kirsling.

Source/WebCore:

ComplexTextController::offsetForPosition had the following code:

> unsigned hitIndex = hitGlyphStart + (hitGlyphEnd - hitGlyphStart) * (m_run.ltr() ? x / adjustedAdvance : 1 - x / adjustedAdvance);

If m_run.ltr() was false and x == 0, hitIndex would become hitGlyphEnd.
This is not expected. It expects hitIndex < hitGlyphEnd if hitGlyphStart ≠ hitGlyphEnd.
Let hitIndex be hitGlyphStart-1 in the such condition.

Above change makes fast/text/ellipsis-text-rtl.html starting to
fail because offsetForPosition returns the character offset of the
next glyph if the argument 'h' is in a glyph boundary. In RTL
text, offsetForPosition should return a character offset of the
previous glyph in case of a glyph boundary. Use '<=' instead of '<'
for RTL text in order to select previous glyphs for glyph
boundaries.

Test: fast/dom/Document/CaretRangeFromPoint/rtl.html

* platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::offsetForPosition): Compute correct hitGlyphEnd for RTL.

LayoutTests:

* fast/dom/Document/CaretRangeFromPoint/rtl-expected.txt: Added.
* fast/dom/Document/CaretRangeFromPoint/rtl.html: Added.
* platform/gtk/TestExpectations: Unmarked imported/blink/editing/selection/offset-from-point-complex-scripts.html.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ComplexTextController.cpp


Added Paths

trunk/LayoutTests/fast/dom/Document/CaretRangeFromPoint/rtl-expected.txt
trunk/LayoutTests/fast/dom/Document/CaretRangeFromPoint/rtl.html




Diff

Modified: trunk/LayoutTests/ChangeLog (254113 => 254114)

--- trunk/LayoutTests/ChangeLog	2020-01-07 05:48:41 UTC (rev 254113)
+++ trunk/LayoutTests/ChangeLog	2020-01-07 07:49:12 UTC (rev 254114)
@@ -1,3 +1,14 @@
+2020-01-06  Fujii Hironori  
+
+ComplexTextController::offsetForPosition returns a wrong offset for a glyph boundary in a RTL text
+https://bugs.webkit.org/show_bug.cgi?id=205486
+
+Reviewed by Ross Kirsling.
+
+* fast/dom/Document/CaretRangeFromPoint/rtl-expected.txt: Added.
+* fast/dom/Document/CaretRangeFromPoint/rtl.html: Added.
+* platform/gtk/TestExpectations: Unmarked imported/blink/editing/selection/offset-from-point-complex-scripts.html.
+
 2020-01-06  Yury Semikhatsky  
 
 REGRESSION: [ Mac wk2 ] http/tests/inspector/target/provisional-load-cancels-previous-load.html is a flaky failure


Added: trunk/LayoutTests/fast/dom/Document/CaretRangeFromPoint/rtl-expected.txt (0 => 254114)

--- trunk/LayoutTests/fast/dom/Document/CaretRangeFromPoint/rtl-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/Document/CaretRangeFromPoint/rtl-expected.txt	2020-01-07 07:49:12 UTC (rev 254114)
@@ -0,0 +1 @@
+6 5 4 3 2 1 0


Added: trunk/LayoutTests/fast/dom/Document/CaretRangeFromPoint/rtl.html (0 => 254114)

--- trunk/LayoutTests/fast/dom/Document/CaretRangeFromPoint/rtl.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/Document/CaretRangeFromPoint/rtl.html	2020-01-07 07:49:12 UTC (rev 254114)
@@ -0,0 +1,42 @@
+
+
+  
+  
+  p {
+  font-family: "Ahem";
+  direction: rtl;
+  unicode-bidi: bidi-override;
+  }
+  
+
+
+ABCDEF
+
+
+
+testOffsetFromPoint(container.firstElementChild);
+
+function testOffsetFromPoint(element) {
+var y = element.offsetTop + element.offsetHeight / 2;
+var xmin = element.offsetLeft;
+var xmax = xmin + element.offsetWidth;
+var lastCharacterOffset = null;
+var results = [];
+for (var x = xmin - 1; x <= xmax + 1; ++x) {
+var result = document.caretRangeFromPoint(x, y);
+var characterOffset = result ? result.startOffset : null;
+if (characterOffset === lastCharacterOffset)
+continue;
+results.push(characterOffset);
+lastCharacterOffset = characterOffset;
+}
+var div = document.createElement("div");
+div.innerText = results.join(" ");
+log.appendChild(div);
+}
+
+if (window.testRunner) {
+container.style.display = "none";
+testRunner.dumpAsText();
+}
+


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (254113 => 254114)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2020-01-07 05:48:41 UTC (rev 254113)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2020-01-07 07:49:12 UTC (rev 254114)
@@ -3403,7 +3403,6 @@
 webkit.org/b/177936 fast/text/all-small-caps-whitespace.html [ ImageOnlyFailure ]
 webkit.org/b/177936 fast/text/regional-indicator-symobls.html [ Failure ]
 webkit.org/b/177936

[webkit-changes] [254113] trunk/Source/WebCore

2020-01-06 Thread zalan

Title: [254113] trunk/Source/WebCore








Revision 254113
Author za...@apple.com
Date 2020-01-06 21:48:41 -0800 (Mon, 06 Jan 2020)


Log Message
[LFC] Start using the UsedHorizontalValues::Constraints values in ::layoutInFlowContent
https://bugs.webkit.org/show_bug.cgi?id=205831


Reviewed by Antti Koivisto.

Use the incoming horizontal constraint value instead of querying the root's geometry (which is technically outside of the current formatting context).

* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254112 => 254113)

--- trunk/Source/WebCore/ChangeLog	2020-01-07 04:51:46 UTC (rev 254112)
+++ trunk/Source/WebCore/ChangeLog	2020-01-07 05:48:41 UTC (rev 254113)
@@ -1,5 +1,20 @@
 2020-01-06  Zalan Bujtas  
 
+[LFC] Start using the UsedHorizontalValues::Constraints values in ::layoutInFlowContent
+https://bugs.webkit.org/show_bug.cgi?id=205831
+
+
+Reviewed by Antti Koivisto.
+
+Use the incoming horizontal constraint value instead of querying the root's geometry (which is technically outside of the current formatting context).
+
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
+
+2020-01-06  Zalan Bujtas  
+
 [LFC] computeBorderAndPadding/computeWidthAndMargin/computeStaticPosition functions should take UsedHorizontalValues::Constraints
 https://bugs.webkit.org/show_bug.cgi?id=205825
 


Modified: trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp (254112 => 254113)

--- trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp	2020-01-07 04:51:46 UTC (rev 254112)
+++ trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp	2020-01-07 05:48:41 UTC (rev 254113)
@@ -52,7 +52,7 @@
 }
 
 enum class LayoutDirection { Child, Sibling };
-void BlockFormattingContext::layoutInFlowContent(InvalidationState& invalidationState, const UsedHorizontalValues::Constraints&)
+void BlockFormattingContext::layoutInFlowContent(InvalidationState& invalidationState, const UsedHorizontalValues::Constraints& rootHorizontalConstraints)
 {
 // 9.4.1 Block formatting contexts
 // In a block formatting context, boxes are laid out one after the other, vertically, beginning at the top of a containing block.
@@ -89,6 +89,13 @@
 return false;
 };
 
+auto horizontalConstraintsForLayoutBox = [&] (const auto& layoutBox) {
+auto* containingBlock = layoutBox.containingBlock();
+ASSERT(containingBlock);
+if (containingBlock == )
+return rootHorizontalConstraints;
+return Geometry::inFlowHorizontalConstraints(geometryForBox(*containingBlock));
+};
 // This is a post-order tree traversal layout.
 // The root container layout is done in the formatting context it lives in, not that one it creates, so let's start with the first child.
 appendNextToLayoutQueue(formattingRoot, LayoutDirection::Child);
@@ -109,12 +116,13 @@
 break;
 continue;
 }
+{
+auto horizontalConstraints = horizontalConstraintsForLayoutBox(layoutBox);
+computeBorderAndPadding(layoutBox, horizontalConstraints);
+computeWidthAndMargin(layoutBox, horizontalConstraints);
+computeStaticPosition(floatingContext, layoutBox, horizontalConstraints);
+}
 
-auto horizontalConstraints = Geometry::inFlowHorizontalConstraints(geometryForBox(*layoutBox.containingBlock()));
-computeBorderAndPadding(layoutBox, horizontalConstraints);
-computeWidthAndMargin(layoutBox, horizontalConstraints);
-computeStaticPosition(floatingContext, layoutBox, horizontalConstraints);
-
 if (!appendNextToLayoutQueue(layoutBox, LayoutDirection::Child))
 break;
 }


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp (254112 => 254113)

--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp	2020-01-07 04:51:46 UTC (rev 254112)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp	2020-01-07 05:48:41 UTC (rev 254113)
@@ -64,7 +64,7 @@
 return nullptr;
 }
 
-void InlineFormattingContext::layoutInFlowContent(InvalidationState& invalidationState, const UsedHorizontalValues::Constraints&)

[webkit-changes] [254112] trunk/Source/WebCore

2020-01-06 Thread zalan

Title: [254112] trunk/Source/WebCore








Revision 254112
Author za...@apple.com
Date 2020-01-06 20:51:46 -0800 (Mon, 06 Jan 2020)


Log Message
[LFC] computeBorderAndPadding/computeWidthAndMargin/computeStaticPosition functions should take UsedHorizontalValues::Constraints
https://bugs.webkit.org/show_bug.cgi?id=205825


Reviewed by Antti Koivisto.

Let's pass in the horizontal constraints so that the compute* functions don't need to
access containing block's geometry.

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeBorderAndPadding):
(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
* layout/FormattingContext.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
* layout/blockformatting/BlockFormattingContext.h:
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin): Deleted.
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::InlineFormattingContext::computeHorizontalAndVerticalGeometry):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox):
* layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254111 => 254112)

--- trunk/Source/WebCore/ChangeLog	2020-01-07 04:42:34 UTC (rev 254111)
+++ trunk/Source/WebCore/ChangeLog	2020-01-07 04:51:46 UTC (rev 254112)
@@ -1,3 +1,35 @@
+2020-01-06  Zalan Bujtas  
+
+[LFC] computeBorderAndPadding/computeWidthAndMargin/computeStaticPosition functions should take UsedHorizontalValues::Constraints
+https://bugs.webkit.org/show_bug.cgi?id=205825
+
+
+Reviewed by Antti Koivisto.
+
+Let's pass in the horizontal constraints so that the compute* functions don't need to
+access containing block's geometry.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::computeBorderAndPadding):
+(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
+* layout/FormattingContext.h:
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
+(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
+(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
+(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
+(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
+* layout/blockformatting/BlockFormattingContext.h:
+(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin): Deleted.
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
+(WebCore::Layout::InlineFormattingContext::computeHorizontalAndVerticalGeometry):
+(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
+(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot):
+(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox):
+* layout/tableformatting/TableFormattingContext.cpp:
+(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
+
 2020-01-06  ChangSeok Oh  
 
 Unreviewed build fix since r254064.


Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (254111 => 254112)

--- trunk/Source/WebCore/layout/FormattingContext.cpp	2020-01-07 04:42:34 UTC (rev 254111)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp	2020-01-07 04:51:46 UTC (rev 254112)
@@ -131,13 +131,11 @@
 displayBox.setVerticalMargin({ nonCollapsedVerticalMargin, { } });
 }
 
-void FormattingContext::computeBorderAndPadding(const Box& layoutBox, Optional usedHorizontalValues)
+void FormattingContext::computeBorderAndPadding(const Box& layoutBox, const UsedHorizontalValues::Constraints& horizontalConstraint)
 {
-if

[webkit-changes] [254111] trunk

2020-01-06 Thread yurys

Title: [254111] trunk








Revision 254111
Author yu...@chromium.org
Date 2020-01-06 20:42:34 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION: [ Mac wk2 ] http/tests/inspector/target/provisional-load-cancels-previous-load.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205473


Source/WebInspectorUI:

The failure was due to attempts to add output to the test page which could be not fully
loaded after navigation. To make it deterministic it is now possible to keep provisional
navigation paused and to defer output until the test page is ready.

Reviewed by Brian Burg.

* UserInterface/Protocol/Target.js:
(WI.Target.prototype.initialize):
(WI.Target.prototype._resumeIfPaused): extracted resume logic in a method that
can be overridden in the tests.

* UserInterface/Test/FrontendTestHarness.js:
(FrontendTestHarness.prototype.deferOutputUntilTestPageIsReloaded): allow to pause
output when navigation is started via protocol commands rather than the test harness.

LayoutTests:

Reviewed by Brian Burg.

Keep provisional page paused until second navigation replaces it and also
defer output until test page is fully initialized after navigation.

* http/tests/inspector/target/provisional-load-cancels-previous-load.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Protocol/Target.js
trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js




Diff

Modified: trunk/LayoutTests/ChangeLog (254110 => 254111)

--- trunk/LayoutTests/ChangeLog	2020-01-07 04:40:20 UTC (rev 254110)
+++ trunk/LayoutTests/ChangeLog	2020-01-07 04:42:34 UTC (rev 254111)
@@ -1,3 +1,16 @@
+2020-01-06  Yury Semikhatsky  
+
+REGRESSION: [ Mac wk2 ] http/tests/inspector/target/provisional-load-cancels-previous-load.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205473
+
+
+Reviewed by Brian Burg.
+
+Keep provisional page paused until second navigation replaces it and also
+defer output until test page is fully initialized after navigation.
+
+* http/tests/inspector/target/provisional-load-cancels-previous-load.html:
+
 2020-01-06  Fujii Hironori  
 
 Unreviewed test gardening for WinCairo port after r253326 and r250849.


Modified: trunk/LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load.html (254110 => 254111)

--- trunk/LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load.html	2020-01-07 04:40:20 UTC (rev 254110)
+++ trunk/LayoutTests/http/tests/inspector/target/provisional-load-cancels-previous-load.html	2020-01-07 04:42:34 UTC (rev 254111)
@@ -18,6 +18,10 @@
 const url = ""
 let navigatedTwice = false;
 
+let originalResumeIfPaused = WI.Target.prototype._resumeIfPaused;
+// Keep first provisional navigation paused.
+WI.Target.prototype._resumeIfPaused = () => {};
+
 WI.targetManager.addEventListener(WI.TargetManager.Event.TargetAdded, (event) => {
 let target = event.data.target;
 let targetId = targetIdMap.get(target.identifier);
@@ -26,7 +30,10 @@
 InspectorTest.expectTrue(target.isPaused, `Target ${targetId} should be paused on start.`);
 if (!navigatedTwice) {
 navigatedTwice = true;
+WI.Target.prototype._resumeIfPaused = originalResumeIfPaused;
 
+InspectorTest.deferOutputUntilTestPageIsReloaded();
+
 // Send two consequtive navigation requests. The latter will cancel provisional
 // load of the former.
 WI.mainTarget.PageAgent.navigate(url);


Modified: trunk/Source/WebInspectorUI/ChangeLog (254110 => 254111)

--- trunk/Source/WebInspectorUI/ChangeLog	2020-01-07 04:40:20 UTC (rev 254110)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-01-07 04:42:34 UTC (rev 254111)
@@ -1,3 +1,24 @@
+2020-01-06  Yury Semikhatsky  
+
+REGRESSION: [ Mac wk2 ] http/tests/inspector/target/provisional-load-cancels-previous-load.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205473
+
+
+The failure was due to attempts to add output to the test page which could be not fully
+loaded after navigation. To make it deterministic it is now possible to keep provisional
+navigation paused and to defer output until the test page is ready.
+
+Reviewed by Brian Burg.
+
+* UserInterface/Protocol/Target.js:
+(WI.Target.prototype.initialize):
+(WI.Target.prototype._resumeIfPaused): extracted resume logic in a method that
+can be overridden in the tests.
+
+* UserInterface/Test/FrontendTestHarness.js:
+(FrontendTestHarness.prototype.deferOutputUntilTestPageIsReloaded): allow

[webkit-changes] [254110] trunk/Source/WebCore

2020-01-06 Thread changseok

Title: [254110] trunk/Source/WebCore








Revision 254110
Author changs...@webkit.org
Date 2020-01-06 20:40:20 -0800 (Mon, 06 Jan 2020)


Log Message
Unreviewed build fix since r254064.

* CMakeLists.txt: GraphicsContext3D was renamed GraphicsContextGLOpenGL, not GraphicsContextGLOpenGLBase.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (254109 => 254110)

--- trunk/Source/WebCore/CMakeLists.txt	2020-01-07 04:36:25 UTC (rev 254109)
+++ trunk/Source/WebCore/CMakeLists.txt	2020-01-07 04:40:20 UTC (rev 254110)
@@ -1492,7 +1492,7 @@
 list(APPEND WebCore_SOURCES
 platform/graphics/ANGLEWebKitBridge.cpp
 platform/graphics/FormatConverter.cpp
-platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp
+platform/graphics/opengl/GraphicsContextGLOpenGL.cpp
 )
 
 list(APPEND WebCore_LIBRARIES ANGLEFramework)


Modified: trunk/Source/WebCore/ChangeLog (254109 => 254110)

--- trunk/Source/WebCore/ChangeLog	2020-01-07 04:36:25 UTC (rev 254109)
+++ trunk/Source/WebCore/ChangeLog	2020-01-07 04:40:20 UTC (rev 254110)
@@ -1,3 +1,9 @@
+2020-01-06  ChangSeok Oh  
+
+Unreviewed build fix since r254064.
+
+* CMakeLists.txt: GraphicsContext3D was renamed GraphicsContextGLOpenGL, not GraphicsContextGLOpenGLBase.
+
 2020-01-06  Zalan Bujtas  
 
 [LFC] Remove redundant UsedVerticalValues::Constraints(Display::Box)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254109] trunk/LayoutTests

2020-01-06 Thread Hironori . Fujii

Title: [254109] trunk/LayoutTests








Revision 254109
Author hironori.fu...@sony.com
Date 2020-01-06 20:36:25 -0800 (Mon, 06 Jan 2020)


Log Message
Unreviewed test gardening for WinCairo port after r253326 and r250849.

* platform/wincairo/fast/css/invalidation-errors-2-expected.txt:
* platform/wincairo/fast/css/invalidation-errors-expected.txt:
* platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wincairo/fast/css/invalidation-errors-2-expected.txt
trunk/LayoutTests/platform/wincairo/fast/css/invalidation-errors-expected.txt
trunk/LayoutTests/platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (254108 => 254109)

--- trunk/LayoutTests/ChangeLog	2020-01-07 04:36:02 UTC (rev 254108)
+++ trunk/LayoutTests/ChangeLog	2020-01-07 04:36:25 UTC (rev 254109)
@@ -1,5 +1,13 @@
 2020-01-06  Fujii Hironori  
 
+Unreviewed test gardening for WinCairo port after r253326 and r250849.
+
+* platform/wincairo/fast/css/invalidation-errors-2-expected.txt:
+* platform/wincairo/fast/css/invalidation-errors-expected.txt:
+* platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt:
+
+2020-01-06  Fujii Hironori  
+
 Unreviewed test gardening for WinCairo port after r252598.
 
 * platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt:


Modified: trunk/LayoutTests/platform/wincairo/fast/css/invalidation-errors-2-expected.txt (254108 => 254109)

--- trunk/LayoutTests/platform/wincairo/fast/css/invalidation-errors-2-expected.txt	2020-01-07 04:36:02 UTC (rev 254108)
+++ trunk/LayoutTests/platform/wincairo/fast/css/invalidation-errors-2-expected.txt	2020-01-07 04:36:25 UTC (rev 254109)
@@ -13,9 +13,9 @@
 RenderInline {DIV} at (0,0) size 0x0
   RenderText {#text} at (0,0) size 0x0
 RenderText {#text} at (0,0) size 0x0
-layer at (8,44) size 200x200
+layer at (8,44) size 200x200 clip at (8,44) size 185x200
   RenderBlock (floating) {DIV} at (0,0) size 200x200 [color=#FF] [bgcolor=#006400]
-RenderText {#text} at (0,0) size 197x128
+RenderText {#text} at (0,0) size 183x128
   text run at (0,0) width 163: "this text should be left-"
   text run at (0,16) width 161: "aligned, all lower-case,"
   text run at (0,32) width 171: "normal font, white, 14px,"
@@ -22,6 +22,6 @@
   text run at (0,48) width 183: "bold, normally spaced and"
   text run at (0,64) width 171: "wrapped, in a darkgreen"
   text run at (0,80) width 103: "200x200px div "
-  text run at (103,80) width 94: "in the top left"
-  text run at (0,96) width 181: "corner with no borders or"
-  text run at (0,112) width 61: "outlines."
+  text run at (103,80) width 67: "in the top"
+  text run at (0,96) width 129: "left corner with no"
+  text run at (0,112) width 140: "borders or outlines."


Modified: trunk/LayoutTests/platform/wincairo/fast/css/invalidation-errors-expected.txt (254108 => 254109)

--- trunk/LayoutTests/platform/wincairo/fast/css/invalidation-errors-expected.txt	2020-01-07 04:36:02 UTC (rev 254108)
+++ trunk/LayoutTests/platform/wincairo/fast/css/invalidation-errors-expected.txt	2020-01-07 04:36:25 UTC (rev 254109)
@@ -13,9 +13,9 @@
 RenderInline {DIV} at (0,0) size 0x0
   RenderText {#text} at (0,0) size 0x0
 RenderText {#text} at (0,0) size 0x0
-layer at (8,44) size 200x200
+layer at (8,44) size 200x200 clip at (8,44) size 185x200
   RenderBlock (floating) {DIV} at (0,0) size 200x200 [color=#FF] [bgcolor=#006400]
-RenderText {#text} at (0,0) size 197x128
+RenderText {#text} at (0,0) size 183x128
   text run at (0,0) width 163: "this text should be left-"
   text run at (0,16) width 161: "aligned, all lower-case,"
   text run at (0,32) width 171: "normal font, white, 14px,"
@@ -22,6 +22,6 @@
   text run at (0,48) width 183: "bold, normally spaced and"
   text run at (0,64) width 171: "wrapped, in a darkgreen"
   text run at (0,80) width 103: "200x200px div "
-  text run at (103,80) width 94: "in the top left"
-  text run at (0,96) width 181: "corner with no borders or"
-  text run at (0,112) width 61: "outlines."
+  text run at (103,80) width 67: "in the top"
+  text run at (0,96) width 129: "left corner with no"
+  text run at (0,112) width 140: "borders or outlines."


Modified: trunk/LayoutTests/platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt (254108 => 254109)

--- trunk/LayoutTests/platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt	2020-01-07 04:36:02 UTC (rev 254108)
+++ trunk/LayoutTests/platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt	2020-01-07 04:36:25 UTC (rev 254109)
@@ -161,7 +161,7 @@

[webkit-changes] [254108] trunk

2020-01-06 Thread yoshiaki . jitsukawa

Title: [254108] trunk








Revision 254108
Author yoshiaki.jitsuk...@sony.com
Date 2020-01-06 20:36:02 -0800 (Mon, 06 Jan 2020)


Log Message
[PlayStation] Update port cmake
https://bugs.webkit.org/show_bug.cgi?id=205846

Reviewed by Don Olmstead.

.:

Define C/CXX macro BPLATFORM_PLAYSTATION.

Find HarfBuzz::ICU component to fix cmake errors.

Make the WebCore and WebKit builds optional.

* Source/cmake/OptionsPlayStation.cmake:

Source/_javascript_Core:

* PlatformPlayStation.cmake:
Workaround of compilation errors with VisualStudio generator, which gives -std=c++* options to C sources.

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/PlatformPlayStation.cmake
trunk/Source/cmake/OptionsPlayStation.cmake




Diff

Modified: trunk/ChangeLog (254107 => 254108)

--- trunk/ChangeLog	2020-01-07 04:18:39 UTC (rev 254107)
+++ trunk/ChangeLog	2020-01-07 04:36:02 UTC (rev 254108)
@@ -1,3 +1,18 @@
+2020-01-06  Yoshiaki Jitsukawa  
+
+[PlayStation] Update port cmake
+https://bugs.webkit.org/show_bug.cgi?id=205846
+
+Reviewed by Don Olmstead.
+
+Define C/CXX macro BPLATFORM_PLAYSTATION.
+
+Find HarfBuzz::ICU component to fix cmake errors.
+
+Make the WebCore and WebKit builds optional.
+
+* Source/cmake/OptionsPlayStation.cmake:
+
 2020-01-06  Don Olmstead  
 
 Rename GraphicsContext3D to GraphicsContextGL


Modified: trunk/Source/_javascript_Core/ChangeLog (254107 => 254108)

--- trunk/Source/_javascript_Core/ChangeLog	2020-01-07 04:18:39 UTC (rev 254107)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-07 04:36:02 UTC (rev 254108)
@@ -1,3 +1,13 @@
+2020-01-06  Yoshiaki Jitsukawa  
+
+[PlayStation] Update port cmake
+https://bugs.webkit.org/show_bug.cgi?id=205846
+
+Reviewed by Don Olmstead.
+
+* PlatformPlayStation.cmake:
+Workaround of compilation errors with VisualStudio generator, which gives -std=c++* options to C sources.
+
 2020-01-06  Alexey Shvayka  
 
 String.prototype.replace() incorrectly handles named references on RegExp w/o named groups


Modified: trunk/Source/_javascript_Core/PlatformPlayStation.cmake (254107 => 254108)

--- trunk/Source/_javascript_Core/PlatformPlayStation.cmake	2020-01-07 04:18:39 UTC (rev 254107)
+++ trunk/Source/_javascript_Core/PlatformPlayStation.cmake	2020-01-07 04:36:02 UTC (rev 254108)
@@ -34,6 +34,17 @@
 inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp
 )
 
+# With the VisualStudio generator, the compiler complains about -std=c++* for C sources.
+set_source_files_properties(
+disassembler/udis86/udis86.c
+disassembler/udis86/udis86_decode.c
+disassembler/udis86/udis86_itab_holder.c
+disassembler/udis86/udis86_syn-att.c
+disassembler/udis86/udis86_syn-intel.c
+disassembler/udis86/udis86_syn.c
+PROPERTIES LANGUAGE CXX
+)
+
 if (${WTF_LIBRARY_TYPE} STREQUAL "STATIC")
 add_definitions(-DSTATICALLY_LINKED_WITH_WTF)
 endif ()


Modified: trunk/Source/cmake/OptionsPlayStation.cmake (254107 => 254108)

--- trunk/Source/cmake/OptionsPlayStation.cmake	2020-01-07 04:18:39 UTC (rev 254107)
+++ trunk/Source/cmake/OptionsPlayStation.cmake	2020-01-07 04:36:02 UTC (rev 254108)
@@ -3,7 +3,23 @@
 include(Sign)
 
 add_definitions(-DWTF_PLATFORM_PLAYSTATION=1)
+add_definitions(-DBPLATFORM_PLAYSTATION=1)
 
+add_definitions(-DSCE_LIBC_DISABLE_CPP14_HEADER_WARNING= -DSCE_LIBC_DISABLE_CPP17_HEADER_WARNING=)
+
+set(ENABLE_API_TESTS ON CACHE BOOL "Build APITests")
+set(ENABLE_WEBCORE ON CACHE BOOL "Build WebCore")
+set(ENABLE_WEBKIT OFF CACHE BOOL "Build WebKit")
+set(ENABLE_WEBKIT_LEGACY OFF)
+
+if (NOT ENABLE_WEBCORE)
+set(ENABLE_WEBKIT OFF)
+endif ()
+
+if (NOT ENABLE_WEBKIT)
+set(ENABLE_API_TESTS OFF)
+endif ()
+
 WEBKIT_OPTION_BEGIN()
 
 # Turn off JIT
@@ -70,6 +86,8 @@
 
 list(APPEND CMAKE_PREFIX_PATH ${WEBKIT_LIBRARIES_DIR})
 
+set(HarfBuzz_ICU_NAMES harfbuzz)
+
 find_library(C_STD_LIBRARY c)
 find_library(KERNEL_LIBRARY kernel)
 
@@ -78,7 +96,7 @@
 find_package(EGL REQUIRED)
 find_package(Fontconfig REQUIRED)
 find_package(Freetype REQUIRED)
-find_package(HarfBuzz REQUIRED)
+find_package(HarfBuzz REQUIRED COMPONENTS ICU)
 find_package(ICU REQUIRED COMPONENTS data i18n uc)
 find_package(JPEG REQUIRED)
 find_package(LibPSL REQUIRED)
@@ -126,11 +144,6 @@
 set(_javascript_Core_LIBRARY_TYPE STATIC)
 set(WebCore_LIBRARY_TYPE STATIC)
 
-set(ENABLE_API_TESTS ON)
-set(ENABLE_WEBCORE ON)
-set(ENABLE_WEBKIT OFF)
-set(ENABLE_WEBKIT_LEGACY OFF)
-
 # Enable multi process builds for Visual Studio
 if (NOT ${CMAKE_GENERATOR} MATCHES "Ninja")
 add_definitions(/MP)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254107] trunk/Source/WebCore

2020-01-06 Thread zalan

Title: [254107] trunk/Source/WebCore








Revision 254107
Author za...@apple.com
Date 2020-01-06 20:18:39 -0800 (Mon, 06 Jan 2020)


Log Message
[LFC] Remove redundant UsedVerticalValues::Constraints(Display::Box)
https://bugs.webkit.org/show_bug.cgi?id=205813


Reviewed by Antti Koivisto.

Let's call the other c'tor instead.

* layout/LayoutUnits.cpp:
(WebCore::Layout::UsedVerticalValues::Constraints::Constraints): Deleted.
* layout/LayoutUnits.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/LayoutUnits.cpp
trunk/Source/WebCore/layout/LayoutUnits.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254106 => 254107)

--- trunk/Source/WebCore/ChangeLog	2020-01-07 03:58:15 UTC (rev 254106)
+++ trunk/Source/WebCore/ChangeLog	2020-01-07 04:18:39 UTC (rev 254107)
@@ -1,5 +1,24 @@
 2020-01-06  Zalan Bujtas  
 
+[LFC] Remove redundant UsedVerticalValues::Constraints(Display::Box)
+https://bugs.webkit.org/show_bug.cgi?id=205813
+
+
+Reviewed by Antti Koivisto.
+
+Let's call the other c'tor instead.
+
+* layout/LayoutUnits.cpp:
+(WebCore::Layout::UsedVerticalValues::Constraints::Constraints): Deleted.
+* layout/LayoutUnits.h:
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
+(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
+
+2020-01-06  Zalan Bujtas  
+
 [LFC] FormattingContext::layoutInFlowContent should take UsedHorizontalValues::Constraints
 https://bugs.webkit.org/show_bug.cgi?id=205809
 


Modified: trunk/Source/WebCore/layout/LayoutUnits.cpp (254106 => 254107)

--- trunk/Source/WebCore/layout/LayoutUnits.cpp	2020-01-07 03:58:15 UTC (rev 254106)
+++ trunk/Source/WebCore/layout/LayoutUnits.cpp	2020-01-07 04:18:39 UTC (rev 254107)
@@ -28,16 +28,9 @@
 
 #if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 
-#include "DisplayBox.h"
-
 namespace WebCore {
 namespace Layout {
 
-UsedVerticalValues::Constraints::Constraints(const Display::Box& containingBlockGeometry)
-: contentBoxTop(containingBlockGeometry.contentBoxTop())
-{
 }
-
 }
-}
 #endif


Modified: trunk/Source/WebCore/layout/LayoutUnits.h (254106 => 254107)

--- trunk/Source/WebCore/layout/LayoutUnits.h	2020-01-07 03:58:15 UTC (rev 254106)
+++ trunk/Source/WebCore/layout/LayoutUnits.h	2020-01-07 04:18:39 UTC (rev 254107)
@@ -48,10 +48,6 @@
 using InlineLayoutRect = LayoutRect;
 #endif
 
-namespace Display {
-class Box;
-}
-
 namespace Layout {
 
 struct Position {
@@ -186,7 +182,6 @@
 
 struct UsedVerticalValues {
 struct Constraints {
-explicit Constraints(const Display::Box& containingBlockGeometry);
 explicit Constraints(LayoutUnit contentBoxTop, Optional verticalConstraint = WTF::nullopt)
 : contentBoxTop(contentBoxTop)
 , height(verticalConstraint)


Modified: trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp (254106 => 254107)

--- trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp	2020-01-07 03:58:15 UTC (rev 254106)
+++ trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp	2020-01-07 04:18:39 UTC (rev 254107)
@@ -234,7 +234,7 @@
 
 void BlockFormattingContext::computeStaticVerticalPosition(const FloatingContext& floatingContext, const Box& layoutBox)
 {
-auto usedVerticalValues = UsedVerticalValues { UsedVerticalValues::Constraints { geometryForBox(*layoutBox.containingBlock()) } };
+auto usedVerticalValues = UsedVerticalValues { UsedVerticalValues::Constraints { geometryForBox(*layoutBox.containingBlock()).contentBoxTop() } };
 formattingState().displayBox(layoutBox).setTop(geometry().staticVerticalPosition(layoutBox, usedVerticalValues));
 if (layoutBox.hasFloatClear())
 computeEstimatedVerticalPositionForFloatClear(floatingContext, layoutBox);
@@ -428,7 +428,7 @@
 return { };
 };
 
-auto verticalConstraints = UsedVerticalValues::Constraints { containingBlockGeometry };
+auto verticalConstraints = UsedVerticalValues::Constraints { containingBlockGeometry.contentBoxTop() };
 auto contentHeightAndMargin = compute(UsedVerticalValues { verticalConstraints });
 if (auto maxHeight = geometry().computedMaxHeight(layoutBox)) {
 if (contentHeightAndMargin.contentHeight >

[webkit-changes] [254106] trunk/LayoutTests

2020-01-06 Thread Hironori . Fujii

Title: [254106] trunk/LayoutTests








Revision 254106
Author hironori.fu...@sony.com
Date 2020-01-06 19:58:15 -0800 (Mon, 06 Jan 2020)


Log Message
Unreviewed test gardening for WinCairo port after r252598.

* platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt:
* platform/wincairo/fast/css/hsl-color-expected.txt:
* platform/wincairo/fast/css/hsla-color-expected.txt:
* platform/wincairo/fast/css/percentage-non-integer-expected.txt:
* platform/wincairo/fast/css/shadow-multiple-expected.txt:
* platform/wincairo/fast/css/viewport-units-dynamic-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt
trunk/LayoutTests/platform/wincairo/fast/css/hsl-color-expected.txt
trunk/LayoutTests/platform/wincairo/fast/css/hsla-color-expected.txt
trunk/LayoutTests/platform/wincairo/fast/css/percentage-non-integer-expected.txt
trunk/LayoutTests/platform/wincairo/fast/css/shadow-multiple-expected.txt
trunk/LayoutTests/platform/wincairo/fast/css/viewport-units-dynamic-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (254105 => 254106)

--- trunk/LayoutTests/ChangeLog	2020-01-07 03:44:46 UTC (rev 254105)
+++ trunk/LayoutTests/ChangeLog	2020-01-07 03:58:15 UTC (rev 254106)
@@ -1,5 +1,16 @@
 2020-01-06  Fujii Hironori  
 
+Unreviewed test gardening for WinCairo port after r252598.
+
+* platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt:
+* platform/wincairo/fast/css/hsl-color-expected.txt:
+* platform/wincairo/fast/css/hsla-color-expected.txt:
+* platform/wincairo/fast/css/percentage-non-integer-expected.txt:
+* platform/wincairo/fast/css/shadow-multiple-expected.txt:
+* platform/wincairo/fast/css/viewport-units-dynamic-expected.txt:
+
+2020-01-06  Fujii Hironori  
+
 Unreviewed test gardening for WinCairo port after r254044.
 
 * platform/wincairo/css1/basic/containment-expected.txt:


Modified: trunk/LayoutTests/platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt (254105 => 254106)

--- trunk/LayoutTests/platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt	2020-01-07 03:44:46 UTC (rev 254105)
+++ trunk/LayoutTests/platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt	2020-01-07 03:58:15 UTC (rev 254106)
@@ -20,18 +20,18 @@
 RenderText {#text} at (0,0) size 0x0
   RenderText {#text} at (0,0) size 0x0
 layer at (12,12) size 280x280
-  RenderBlock (positioned) {DIV} at (12,12) size 280x280 [border: (10px solid #00FF000C)]
+  RenderBlock (positioned) {DIV} at (12,12) size 280x280 [border: (10px solid #00FF000D)]
 layer at (12,12) size 280x280
   RenderBlock (relative positioned) {DIV} at (0,0) size 280x280
 layer at (304,12) size 280x280
-  RenderBlock (positioned) {DIV} at (304,12) size 280x280 [border: (20px solid #00FF000C)]
+  RenderBlock (positioned) {DIV} at (304,12) size 280x280 [border: (20px solid #00FF000D)]
 layer at (304,12) size 280x280
   RenderBlock (relative positioned) {DIV} at (0,0) size 280x280
 layer at (12,301) size 280x280
-  RenderBlock (positioned) {DIV} at (12,301) size 280x280 [border: (50px solid #00FF000C)]
+  RenderBlock (positioned) {DIV} at (12,301) size 280x280 [border: (50px solid #00FF000D)]
 layer at (12,301) size 280x280
   RenderBlock (relative positioned) {DIV} at (0,0) size 280x280
 layer at (304,301) size 280x280
-  RenderBlock (positioned) {DIV} at (304,301) size 280x280 [border: (90px solid #00FF000C)]
+  RenderBlock (positioned) {DIV} at (304,301) size 280x280 [border: (90px solid #00FF000D)]
 layer at (304,301) size 280x280
   RenderBlock (relative positioned) {DIV} at (0,0) size 280x280


Modified: trunk/LayoutTests/platform/wincairo/fast/css/hsl-color-expected.txt (254105 => 254106)

--- trunk/LayoutTests/platform/wincairo/fast/css/hsl-color-expected.txt	2020-01-07 03:44:46 UTC (rev 254105)
+++ trunk/LayoutTests/platform/wincairo/fast/css/hsl-color-expected.txt	2020-01-07 03:58:15 UTC (rev 254106)
@@ -15,13 +15,13 @@
   RenderBlock {H1} at (0,175) size 769x38 [color=#FF]
 RenderText {#text} at (0,0) size 572x36
   text run at (0,0) width 572: "This should be blue: hsl(240, 100%, 50%)"
-  RenderBlock {H1} at (0,233) size 769x38 [color=#7FFF7F]
+  RenderBlock {H1} at (0,233) size 769x38 [color=#80FF80]
 RenderText {#text} at (0,0) size 660x36
   text run at (0,0) width 660: "This should be light green: hsl(120, 100%, 75%)"
-  RenderBlock {H1} at (0,292) size 769x38 [color=#007F00]
+  RenderBlock {H1} at (0,292) size 769x38 [color=#008000]
 RenderText {#text} at (0,0) size 662x36
   text run at (0,0) width 662: "This should be dark green: hsl(120, 100%, 25%)"
-  RenderBlock {H1} at (0,350) size 769x38 [color=#3FBF3F]
+  RenderBlock {H1} at (0,350) size 769x38 [color=#40BF40]
 RenderText {#text} at (0,0) size 661x36

[webkit-changes] [254104] trunk/Source/WebCore

2020-01-06 Thread zalan

Title: [254104] trunk/Source/WebCore








Revision 254104
Author za...@apple.com
Date 2020-01-06 19:15:36 -0800 (Mon, 06 Jan 2020)


Log Message
[LFC] FormattingContext::layoutInFlowContent should take UsedHorizontalValues::Constraints
https://bugs.webkit.org/show_bug.cgi?id=205809


Reviewed by Antti Koivisto.

This patch is in preparation for using the incoming horizontal constraint instead of
accessing the formatting context root's geometry.
(e.g. text content. The IFC should not need to query the div's display box
for the horizontal available space (100px))

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
* layout/FormattingContext.h:
* layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
* layout/blockformatting/BlockFormattingContext.h:
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
* layout/inlineformatting/InlineFormattingContext.h:
* layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
* layout/tableformatting/TableFormattingContext.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/LayoutContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.h
trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp
trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (254103 => 254104)

--- trunk/Source/WebCore/ChangeLog	2020-01-07 02:52:26 UTC (rev 254103)
+++ trunk/Source/WebCore/ChangeLog	2020-01-07 03:15:36 UTC (rev 254104)
@@ -1,3 +1,34 @@
+2020-01-06  Zalan Bujtas  
+
+[LFC] FormattingContext::layoutInFlowContent should take UsedHorizontalValues::Constraints
+https://bugs.webkit.org/show_bug.cgi?id=205809
+
+
+Reviewed by Antti Koivisto.
+
+This patch is in preparation for using the incoming horizontal constraint instead of
+accessing the formatting context root's geometry.
+(e.g. text content. The IFC should not need to query the div's display box
+for the horizontal available space (100px))
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):
+* layout/FormattingContext.h:
+* layout/LayoutContext.cpp:
+(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
+(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
+* layout/blockformatting/BlockFormattingContext.h:
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
+(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
+* layout/inlineformatting/InlineFormattingContext.h:
+* layout/tableformatting/TableFormattingContext.cpp:
+(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
+(WebCore::Layout::TableFormattingContext::layoutTableCellBox):
+* layout/tableformatting/TableFormattingContext.h:
+
 2020-01-06  Don Olmstead  
 
 Rename GraphicsContext3D to GraphicsContextGL


Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (254103 => 254104)

--- trunk/Source/WebCore/layout/FormattingContext.cpp	2020-01-07 02:52:26 UTC (rev 254103)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp	2020-01-07 03:15:36 UTC (rev 254104)
@@ -155,8 +155,9 @@
 computeOutOfFlowHorizontalGeometry(*outOfFlowBox);
 if (is(*outOfFlowBox)) {
 auto& outOfFlowRootContainer = downcast(*outOfFlowBox);
+auto& outOfFlowRootDisplayBox = geometryForBox(outOfFlowRootContainer);
 auto formattingContext = LayoutContext::createFormattingContext(outOfFlowRootContainer, layoutState());
-formattingContext->layoutInFlowContent(invalidationState);
+formattingContext->layoutInFlowContent(invalidationState, Geometry::inFlowHorizontalConstraints(outOfFlowRootDisplayBox));
 computeOutOfFlowVerticalGeometry(outOfFlowRootContainer);

[webkit-changes] [254102] trunk/Source/WebCore

2020-01-06 Thread zalan

Title: [254102] trunk/Source/WebCore








Revision 254102
Author za...@apple.com
Date 2020-01-06 17:10:29 -0800 (Mon, 06 Jan 2020)


Log Message
[LFC] UsedHorizontalValues::Constraints should not take Display::Box
https://bugs.webkit.org/show_bug.cgi?id=205811


Reviewed by Antti Koivisto.

Passing in only the actual rect values (content/padding box left/width) to UsedHorizontalValues::Constraints makes the
constraint logic look clear.

* layout/FormattingContext.cpp:
(WebCore::Layout::outOfFlowHorizontalConstraints):
(WebCore::Layout::FormattingContext::computeBorderAndPadding):
* layout/FormattingContextQuirks.cpp:
(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):
* layout/LayoutUnits.cpp:
(WebCore::Layout::UsedHorizontalValues::Constraints::Constraints):
* layout/LayoutUnits.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
* layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/FormattingContextGeometry.cpp
trunk/Source/WebCore/layout/FormattingContextQuirks.cpp
trunk/Source/WebCore/layout/LayoutUnits.cpp
trunk/Source/WebCore/layout/LayoutUnits.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextQuirks.cpp
trunk/Source/WebCore/layout/blockformatting/BlockMarginCollapse.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254101 => 254102)

--- trunk/Source/WebCore/ChangeLog	2020-01-07 01:06:34 UTC (rev 254101)
+++ trunk/Source/WebCore/ChangeLog	2020-01-07 01:10:29 UTC (rev 254102)
@@ -1,3 +1,34 @@
+2020-01-06  Zalan Bujtas  
+
+[LFC] UsedHorizontalValues::Constraints should not take Display::Box
+https://bugs.webkit.org/show_bug.cgi?id=205811
+
+
+Reviewed by Antti Koivisto.
+
+Passing in only the actual rect values (content/padding box left/width) to UsedHorizontalValues::Constraints makes the
+constraint logic look clear.
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::outOfFlowHorizontalConstraints):
+(WebCore::Layout::FormattingContext::computeBorderAndPadding):
+* layout/FormattingContextQuirks.cpp:
+(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):
+* layout/LayoutUnits.cpp:
+(WebCore::Layout::UsedHorizontalValues::Constraints::Constraints):
+* layout/LayoutUnits.h:
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
+(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
+(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
+(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
+* layout/blockformatting/BlockFormattingContextQuirks.cpp:
+(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
+* layout/blockformatting/BlockMarginCollapse.cpp:
+(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const):
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
+
 2020-01-06  Per Arne Vollan  
 
 [iOS] Only prewarm fonts with valid font names


Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (254101 => 254102)

--- trunk/Source/WebCore/layout/FormattingContext.cpp	2020-01-07 01:06:34 UTC (rev 254101)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp	2020-01-07 01:10:29 UTC (rev 254102)
@@ -45,16 +45,6 @@
 
 WTF_MAKE_ISO_ALLOCATED_IMPL(FormattingContext);
 
-static UsedHorizontalValues::Constraints outOfFlowHorizontalConstraints(const Display::Box& containingBlockGeometry)
-{
-return UsedHorizontalValues::Constraints { containingBlockGeometry.paddingBoxLeft(), containingBlockGeometry.paddingBoxWidth() };
-}
-
-static UsedVerticalValues::Constraints outOfFlowVerticalConstraints(const Display::Box& containingBlockGeometry)
-{
-return UsedVerticalValues::Constraints {

[webkit-changes] [254101] trunk/Source/WebKit

2020-01-06 Thread pvollan

Title: [254101] trunk/Source/WebKit








Revision 254101
Author pvol...@apple.com
Date 2020-01-06 17:06:34 -0800 (Mon, 06 Jan 2020)


Log Message
[iOS] Get display level in the UI process for all iOS platforms
https://bugs.webkit.org/show_bug.cgi?id=205835


Reviewed by Brent Fulgham.

This was previously only done for iOS, but should be done for all iOS platforms.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* UIProcess/WebProcessPool.h:
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/WebProcess.messages.in
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (254100 => 254101)

--- trunk/Source/WebKit/ChangeLog	2020-01-07 00:52:56 UTC (rev 254100)
+++ trunk/Source/WebKit/ChangeLog	2020-01-07 01:06:34 UTC (rev 254101)
@@ -1,3 +1,22 @@
+2020-01-06  Per Arne Vollan  
+
+[iOS] Get display level in the UI process for all iOS platforms
+https://bugs.webkit.org/show_bug.cgi?id=205835
+
+
+Reviewed by Brent Fulgham.
+
+This was previously only done for iOS, but should be done for all iOS platforms.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::registerNotificationObservers):
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::initializeNewWebProcess):
+* UIProcess/WebProcessPool.h:
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+* WebProcess/cocoa/WebProcessCocoa.mm:
+
 2020-01-06  Eric Carlson  
 
 Add some of the remote media player messages needed for video playback


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (254100 => 254101)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-01-07 00:52:56 UTC (rev 254100)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-01-07 01:06:34 UTC (rev 254101)
@@ -102,7 +102,7 @@
 static NSString * const WebKitLogCookieInformationDefaultsKey = @"WebKitLogCookieInformation";
 #endif
 
-#if PLATFORM(IOS)
+#if PLATFORM(IOS_FAMILY)
 SOFT_LINK_PRIVATE_FRAMEWORK(BackBoardServices)
 SOFT_LINK(BackBoardServices, BKSDisplayBrightnessGetCurrent, float, (), ());
 #endif
@@ -482,7 +482,7 @@
 return WTF::hasEntitlement(ensureNetworkProcess().connection()->xpcConnection(), entitlement.utf8().data());
 }
 
-#if PLATFORM(IOS)
+#if PLATFORM(IOS_FAMILY)
 float WebProcessPool::displayBrightness()
 {
 return BKSDisplayBrightnessGetCurrent();
@@ -541,12 +541,14 @@
 m_deactivationObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationDidResignActiveNotification object:NSApp queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *notification) {
 setApplicationIsActive(false);
 }];
-#elif PLATFORM(IOS)
+#else
 CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(), this, backlightLevelDidChangeCallback, static_cast(UIBacklightLevelChangedNotification), nullptr, CFNotificationSuspensionBehaviorCoalesce);
+#if PLATFORM(IOS)
 m_accessibilityEnabledObserver = [[NSNotificationCenter defaultCenter] addObserverForName:(__bridge id)kAXSApplicationAccessibilityEnabledNotification object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *) {
 for (size_t i = 0; i < m_processes.size(); ++i)
 m_processes[i]->unblockAccessibilityServerIfNeeded();
 }];
+#endif // PLATFORM(IOS)
 #endif // !PLATFORM(IOS_FAMILY)
 }
 


Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (254100 => 254101)

--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2020-01-07 00:52:56 UTC (rev 254100)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2020-01-07 01:06:34 UTC (rev 254101)
@@ -1062,7 +1062,7 @@
 process.send(Messages::WebProcess::PrewarmGlobally(), 0);
 }
 
-#if PLATFORM(IOS)
+#if PLATFORM(IOS_FAMILY)
 process.send(Messages::WebProcess::BacklightLevelDidChange(displayBrightness()), 0);
 #endif
 


Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.h (254100 => 254101)

--- trunk/Source/WebKit/UIProcess/WebProcessPool.h	2020-01-07 00:52:56 UTC (rev 254100)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.h	2020-01-07 01:06:34 UTC (rev 254101)
@@ -605,7 +605,7 @@
 
 void updateBackForwardCacheCapacity();
 
-#if PLATFORM(IOS)
+#if PLATFORM(IOS_FAMILY)
 static float displayBrightness();
 static void backlightLevelDidChangeCallback(CFNotificationCenterRef, void *observer, CFStringRef name, const void *, CFDictionaryRef

[webkit-changes] [254100] trunk/Tools

2020-01-06 Thread jbedard

Title: [254100] trunk/Tools








Revision 254100
Author jbed...@apple.com
Date 2020-01-06 16:52:56 -0800 (Mon, 06 Jan 2020)


Log Message
results.webkit.org: Tweak processing constants
https://bugs.webkit.org/show_bug.cgi?id=205828


Rubber-stamped by Aakash Jain.

* resultsdbpy/resultsdbpy/model/upload_context.py:
(UploadContext):
Increase process timeout to 1 week.
Allow 5 retries instead of 3.
Retry stuck tasks after 10 minutes instead of 5.
Include more tasks so that a scan is always greater than the number of workers.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/model/upload_context.py




Diff

Modified: trunk/Tools/ChangeLog (254099 => 254100)

--- trunk/Tools/ChangeLog	2020-01-07 00:49:32 UTC (rev 254099)
+++ trunk/Tools/ChangeLog	2020-01-07 00:52:56 UTC (rev 254100)
@@ -1,5 +1,20 @@
 2020-01-06  Jonathan Bedard  
 
+results.webkit.org: Tweak processing constants
+https://bugs.webkit.org/show_bug.cgi?id=205828
+
+
+Rubber-stamped by Aakash Jain.
+
+* resultsdbpy/resultsdbpy/model/upload_context.py:
+(UploadContext):
+Increase process timeout to 1 week.
+Allow 5 retries instead of 3.
+Retry stuck tasks after 10 minutes instead of 5.
+Include more tasks so that a scan is always greater than the number of workers.
+
+2020-01-06  Jonathan Bedard  
+
 test-lldb-webkit: Use logging module
 https://bugs.webkit.org/show_bug.cgi?id=205832
 


Modified: trunk/Tools/resultsdbpy/resultsdbpy/model/upload_context.py (254099 => 254100)

--- trunk/Tools/resultsdbpy/resultsdbpy/model/upload_context.py	2020-01-07 00:49:32 UTC (rev 254099)
+++ trunk/Tools/resultsdbpy/resultsdbpy/model/upload_context.py	2020-01-07 00:52:56 UTC (rev 254100)
@@ -37,10 +37,10 @@
 
 class UploadContext(object):
 QUEUE_NAME = 'upload_queue'
-PROCESS_TIMEOUT = 24 * 60 * 60
-MAX_ATTEMPTS = 3
-RETRY_TIME = 5 * 60  # After 5 minutes, re-try a task even if it's in-flight
-MAX_TASKS_IN_SCAN = 10
+PROCESS_TIMEOUT = 7 * 24 * 60 * 60
+MAX_ATTEMPTS = 5
+RETRY_TIME = 10 * 60  # After 10 minutes, re-try a task even if it's in-flight
+MAX_TASKS_IN_SCAN = 40
 
 class SuitesByConfiguration(ClusteredByConfiguration):
 __table_name__ = 'suites_by_configuration_and_branch'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254099] trunk/Source/WebCore

2020-01-06 Thread pvollan

Title: [254099] trunk/Source/WebCore








Revision 254099
Author pvol...@apple.com
Date 2020-01-06 16:49:32 -0800 (Mon, 06 Jan 2020)


Log Message
[iOS] Only prewarm fonts with valid font names
https://bugs.webkit.org/show_bug.cgi?id=205822

Reviewed by Brent Fulgham.

The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.

No new tests, no behavior change.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::prewarmGlobally):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254098 => 254099)

--- trunk/Source/WebCore/ChangeLog	2020-01-07 00:34:53 UTC (rev 254098)
+++ trunk/Source/WebCore/ChangeLog	2020-01-07 00:49:32 UTC (rev 254099)
@@ -1,3 +1,17 @@
+2020-01-06  Per Arne Vollan  
+
+[iOS] Only prewarm fonts with valid font names
+https://bugs.webkit.org/show_bug.cgi?id=205822
+
+Reviewed by Brent Fulgham.
+
+The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.
+
+No new tests, no behavior change.
+
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(WebCore::FontCache::prewarmGlobally):
+
 2020-01-06  Peng Liu  
 
 Build (unified) failure after adding source files to support media in GPU process


Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (254098 => 254099)

--- trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2020-01-07 00:34:53 UTC (rev 254098)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2020-01-07 00:49:32 UTC (rev 254099)
@@ -1694,8 +1694,10 @@
 return;
 
 Vector families = std::initializer_list {
+#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
 ".SF NS Text"_s,
 ".SF NS Display"_s,
+#endif
 "Arial"_s,
 "Helvetica"_s,
 "Helvetica Neue"_s,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254098] trunk/Source/WebKit

2020-01-06 Thread eric . carlson

Title: [254098] trunk/Source/WebKit








Revision 254098
Author eric.carl...@apple.com
Date 2020-01-06 16:34:53 -0800 (Mon, 06 Jan 2020)


Log Message
Add some of the remote media player messages needed for video playback
https://bugs.webkit.org/show_bug.cgi?id=205812


Reviewed by Jer Noble.

No new tests, it isn't possible to play video yet.

* GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::prepareForRendering):
(WebKit::RemoteMediaPlayerManagerProxy::setSize):
(WebKit::RemoteMediaPlayerManagerProxy::setVisible):
(WebKit::RemoteMediaPlayerManagerProxy::setShouldMaintainAspectRatio):
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenFrame):
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerManagerProxy::acceleratedRenderingStateChanged):
(WebKit::RemoteMediaPlayerManagerProxy::setShouldDisableSleep):
(WebKit::RemoteMediaPlayerManagerProxy::setRate):
* GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
* GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::getConfiguration):
(WebKit::RemoteMediaPlayerProxy::prepareForRendering):
(WebKit::RemoteMediaPlayerProxy::setSize):
(WebKit::RemoteMediaPlayerProxy::setVisible):
(WebKit::RemoteMediaPlayerProxy::setShouldMaintainAspectRatio):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenFrame):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerProxy::acceleratedRenderingStateChanged):
(WebKit::RemoteMediaPlayerProxy::setShouldDisableSleep):
(WebKit::RemoteMediaPlayerProxy::setRate):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerReadyStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingCanBeAccelerated):
* GPUProcess/media/RemoteMediaPlayerProxy.h:
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::sizeChanged):
(WebKit::MediaPlayerPrivateRemote::updateCachedState):
(WebKit::MediaPlayerPrivateRemote::shouldIgnoreIntrinsicSize):
(WebKit::MediaPlayerPrivateRemote::prepareForRendering):
(WebKit::MediaPlayerPrivateRemote::setSize):
(WebKit::MediaPlayerPrivateRemote::setVisible):
(WebKit::MediaPlayerPrivateRemote::setShouldMaintainAspectRatio):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenGravity):
(WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged):
(WebKit::MediaPlayerPrivateRemote::setShouldDisableSleep):
(WebKit::MediaPlayerPrivateRemote::naturalSize const):
* WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
* WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:
(WebKit::RemoteMediaPlayerConfiguration::encode const):
(WebKit::RemoteMediaPlayerConfiguration::decode):
* WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::sizeChanged):
* WebProcess/GPU/media/RemoteMediaPlayerManager.h:
* WebProcess/GPU/media/RemoteMediaPlayerManager.messages.in:
* WebProcess/GPU/media/RemoteMediaPlayerState.h:
(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.h
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h
trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.h
trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.messages.in
trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (254097 => 254098)

--- trunk/Source/WebKit/ChangeLog	2020-01-07 00:31:13 UTC (rev 254097)
+++ trunk/Source/WebKit/ChangeLog	2020-01-07 00:34:53 UTC (rev 254098)
@@ -1,3 +1,64 @@
+2020-01-06  Eric Carlson  
+
+Add some of the remote media player messages needed for video playback
+https://bugs.webkit.org/show_bug.cgi?id=205812
+
+
+Reviewed by Jer Noble.
+
+No new tests, it isn't possible to play video yet.
+
+* GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
+(WebKit::RemoteMediaPlayerManagerProxy::prepareForRendering):
+(WebKit::RemoteMediaPlayerManagerProxy::setSize):
+(WebKit::RemoteMediaPlayerManagerProxy::setVisible):
+(WebKit::RemoteMediaPlayerManagerProxy::setShouldMaintainAspectRatio):
+(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenFrame):
+

[webkit-changes] [254097] trunk/Source/WebKit

2020-01-06 Thread cdumez

Title: [254097] trunk/Source/WebKit








Revision 254097
Author cdu...@apple.com
Date 2020-01-06 16:31:13 -0800 (Mon, 06 Jan 2020)


Log Message
Improve logging for when a synchronous IPC times out
https://bugs.webkit.org/show_bug.cgi?id=205829

Reviewed by Tim Horton.

* Platform/IPC/Connection.cpp:
(IPC::Connection::sendSyncMessage):
(IPC::Connection::waitForSyncReply):
* Platform/IPC/Connection.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Connection.cpp
trunk/Source/WebKit/Platform/IPC/Connection.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (254096 => 254097)

--- trunk/Source/WebKit/ChangeLog	2020-01-07 00:15:31 UTC (rev 254096)
+++ trunk/Source/WebKit/ChangeLog	2020-01-07 00:31:13 UTC (rev 254097)
@@ -1,3 +1,15 @@
+2020-01-06  Chris Dumez  
+
+Improve logging for when a synchronous IPC times out
+https://bugs.webkit.org/show_bug.cgi?id=205829
+
+Reviewed by Tim Horton.
+
+* Platform/IPC/Connection.cpp:
+(IPC::Connection::sendSyncMessage):
+(IPC::Connection::waitForSyncReply):
+* Platform/IPC/Connection.h:
+
 2020-01-06  Peng Liu  
 
 Build (unified) failure after adding source files to support media in GPU process


Modified: trunk/Source/WebKit/Platform/IPC/Connection.cpp (254096 => 254097)

--- trunk/Source/WebKit/Platform/IPC/Connection.cpp	2020-01-07 00:15:31 UTC (rev 254096)
+++ trunk/Source/WebKit/Platform/IPC/Connection.cpp	2020-01-07 00:31:13 UTC (rev 254097)
@@ -600,12 +600,14 @@
 if (sendSyncOptions.contains(SendSyncOption::ForceDispatchWhenDestinationIsWaitingForUnboundedSyncReply))
 sendOptions = sendOptions | IPC::SendOption::DispatchMessageEvenWhenWaitingForUnboundedSyncReply;
 
+auto messageReceiverName = encoder->messageReceiverName();
+auto messageName = encoder->messageName();
 sendMessage(WTFMove(encoder), sendOptions);
 
 // Then wait for a reply. Waiting for a reply could involve dispatching incoming sync messages, so
 // keep an extra reference to the connection here in case it's invalidated.
 Ref protect(*this);
-std::unique_ptr reply = waitForSyncReply(syncRequestID, timeout, sendSyncOptions);
+std::unique_ptr reply = waitForSyncReply(syncRequestID, messageReceiverName, messageName, timeout, sendSyncOptions);
 
 --m_inSendSyncCount;
 
@@ -622,7 +624,7 @@
 return reply;
 }
 
-std::unique_ptr Connection::waitForSyncReply(uint64_t syncRequestID, Seconds timeout, OptionSet sendSyncOptions)
+std::unique_ptr Connection::waitForSyncReply(uint64_t syncRequestID, StringReference messageReceiverName, StringReference messageName, Seconds timeout, OptionSet sendSyncOptions)
 {
 timeout = timeoutRespectingIgnoreTimeoutsForTesting(timeout);
 MonotonicTime absoluteTime = MonotonicTime::now() + timeout;
@@ -666,7 +668,12 @@
 timedOut = !SyncMessageState::singleton().wait(absoluteTime);
 }
 
-RELEASE_LOG_ERROR(IPC, "Connection::waitForSyncReply: Timed-out while waiting for reply, id = %" PRIu64, syncRequestID);
+#if OS(DARWIN)
+RELEASE_LOG_ERROR(IPC, "Connection::waitForSyncReply: Timed-out while waiting for reply for %{public}s::%{public}s from process %d, id = %" PRIu64, messageReceiverName.toString().data(), messageName.toString().data(), remoteProcessID(), syncRequestID);
+#else
+RELEASE_LOG_ERROR(IPC, "Connection::waitForSyncReply: Timed-out while waiting for reply for %s::%s, id = %" PRIu64, messageReceiverName.toString().data(), messageName.toString().data(), syncRequestID);
+#endif
+
 didReceiveSyncReply(sendSyncOptions);
 
 return nullptr;


Modified: trunk/Source/WebKit/Platform/IPC/Connection.h (254096 => 254097)

--- trunk/Source/WebKit/Platform/IPC/Connection.h	2020-01-07 00:15:31 UTC (rev 254096)
+++ trunk/Source/WebKit/Platform/IPC/Connection.h	2020-01-07 00:31:13 UTC (rev 254097)
@@ -265,7 +265,7 @@
 
 std::unique_ptr waitForMessage(StringReference messageReceiverName, StringReference messageName, uint64_t destinationID, Seconds timeout, OptionSet);
 
-std::unique_ptr waitForSyncReply(uint64_t syncRequestID, Seconds timeout, OptionSet);
+std::unique_ptr waitForSyncReply(uint64_t syncRequestID, StringReference messageReceiverName, StringReference messageName, Seconds timeout, OptionSet);
 
 bool dispatchMessageToWorkQueueReceiver(std::unique_ptr&);
 bool dispatchMessageToThreadReceiver(std::unique_ptr&);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254096] branches/safari-608-branch/Source

2020-01-06 Thread alancoon

Title: [254096] branches/safari-608-branch/Source








Revision 254096
Author alanc...@apple.com
Date 2020-01-06 16:15:31 -0800 (Mon, 06 Jan 2020)


Log Message
Versioning.

Modified Paths

branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig (254095 => 254096)

--- branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-07 00:13:19 UTC (rev 254095)
+++ branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-07 00:15:31 UTC (rev 254096)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (254095 => 254096)

--- branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-07 00:13:19 UTC (rev 254095)
+++ branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-07 00:15:31 UTC (rev 254096)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig (254095 => 254096)

--- branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2020-01-07 00:13:19 UTC (rev 254095)
+++ branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2020-01-07 00:15:31 UTC (rev 254096)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (254095 => 254096)

--- branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-07 00:13:19 UTC (rev 254095)
+++ branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-07 00:15:31 UTC (rev 254096)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (254095 => 254096)

--- branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-01-07 00:13:19 UTC (rev 254095)
+++ branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-01-07 00:15:31 UTC (rev 254096)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig (254095 => 254096)

--- branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2020-01-07 00:13:19 UTC (rev 254095)
+++ branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2020-01-07 00:15:31 UTC (rev 254096)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (254095 => 254096)

--- branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2020-01-07 00:13:19 UTC (rev 254095)
+++ branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2020-01-07 00:15:31 UTC (rev 254096)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 7;
+TINY_VERSION = 8;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254095] trunk/Tools

2020-01-06 Thread jbedard

Title: [254095] trunk/Tools








Revision 254095
Author jbed...@apple.com
Date 2020-01-06 16:13:19 -0800 (Mon, 06 Jan 2020)


Log Message
test-lldb-webkit: Use logging module
https://bugs.webkit.org/show_bug.cgi?id=205832

Reviewed by Stephanie Lewis.

* Scripts/test-lldb-webkit:
(LldbTester.run): Configure logger.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/test-lldb-webkit




Diff

Modified: trunk/Tools/ChangeLog (254094 => 254095)

--- trunk/Tools/ChangeLog	2020-01-06 23:55:35 UTC (rev 254094)
+++ trunk/Tools/ChangeLog	2020-01-07 00:13:19 UTC (rev 254095)
@@ -1,3 +1,13 @@
+2020-01-06  Jonathan Bedard  
+
+test-lldb-webkit: Use logging module
+https://bugs.webkit.org/show_bug.cgi?id=205832
+
+Reviewed by Stephanie Lewis.
+
+* Scripts/test-lldb-webkit:
+(LldbTester.run): Configure logger.
+
 2020-01-06  Daniel Bates  
 
 Precision of getClientRects(), getBoundingClientRect() differs depending whether simple line layout or line box layout is used


Modified: trunk/Tools/Scripts/test-lldb-webkit (254094 => 254095)

--- trunk/Tools/Scripts/test-lldb-webkit	2020-01-06 23:55:35 UTC (rev 254094)
+++ trunk/Tools/Scripts/test-lldb-webkit	2020-01-07 00:13:19 UTC (rev 254095)
@@ -28,6 +28,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import argparse
+import logging
 import os
 import sys
 import time
@@ -34,9 +35,12 @@
 
 from webkitpy.common.host import Host
 from webkitpy.common.system.executive import ScriptError
+from webkitpy.common.system.logutils import configure_logging
 from webkitpy.port.config import Config
 from webkitpy.test.main import Tester
 
+_log = logging.getLogger(__name__)
+
 EXCEPTIONAL_EXIT_STATUS = -1
 
 
@@ -80,6 +84,7 @@
 return parser.parse_args()
 
 def run(self, host=None, webkit_root=None):
+configure_logging(logger=_log)
 host = host or Host()
 self._options = self.parse_args()
 self.printer.configure(self._options)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254094] trunk/Source/WebInspectorUI

2020-01-06 Thread nvasilyev

Title: [254094] trunk/Source/WebInspectorUI








Revision 254094
Author nvasil...@apple.com
Date 2020-01-06 15:55:35 -0800 (Mon, 06 Jan 2020)


Log Message
Web Inspector: Color picker: make it keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=205572


Reviewed by Brian Burg.

For the color square, make up, down, left, and right keys move the crosshair.

For the hue and opacity sliders:
- Pressing up and down keys should adjust the value by 1%.
- When holding Shift, up and down keys adjust the value by 10%.

* UserInterface/Views/ColorPicker.js:
(WI.ColorPicker.prototype.focus):
* UserInterface/Views/ColorSquare.css:
(.color-square):
Match the border of the hue and opacity sliders.

* UserInterface/Views/ColorSquare.js:
(WI.ColorSquare):
Make the color square focusable.

(WI.ColorSquare.prototype._handleMousedown):
(WI.ColorSquare.prototype._handleKeyDown):
* UserInterface/Views/InlineSwatch.js:
* UserInterface/Views/Slider.css:
(.slider:focus):
* UserInterface/Views/Slider.js:
(WI.Slider):
(WI.Slider.prototype._handleMousedown):
Drive-by: right clicking the slider shouldn't move the thumb.

(WI.Slider.prototype._handleKeyDown):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js
trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.css
trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.js
trunk/Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js
trunk/Source/WebInspectorUI/UserInterface/Views/Slider.css
trunk/Source/WebInspectorUI/UserInterface/Views/Slider.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (254093 => 254094)

--- trunk/Source/WebInspectorUI/ChangeLog	2020-01-06 23:49:21 UTC (rev 254093)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-01-06 23:55:35 UTC (rev 254094)
@@ -1,5 +1,41 @@
 2020-01-06  Nikita Vasilyev  
 
+Web Inspector: Color picker: make it keyboard accessible
+https://bugs.webkit.org/show_bug.cgi?id=205572
+
+
+Reviewed by Brian Burg.
+
+For the color square, make up, down, left, and right keys move the crosshair.
+
+For the hue and opacity sliders:
+- Pressing up and down keys should adjust the value by 1%.
+- When holding Shift, up and down keys adjust the value by 10%.
+
+* UserInterface/Views/ColorPicker.js:
+(WI.ColorPicker.prototype.focus):
+* UserInterface/Views/ColorSquare.css:
+(.color-square):
+Match the border of the hue and opacity sliders.
+
+* UserInterface/Views/ColorSquare.js:
+(WI.ColorSquare):
+Make the color square focusable.
+
+(WI.ColorSquare.prototype._handleMousedown):
+(WI.ColorSquare.prototype._handleKeyDown):
+* UserInterface/Views/InlineSwatch.js:
+* UserInterface/Views/Slider.css:
+(.slider:focus):
+* UserInterface/Views/Slider.js:
+(WI.Slider):
+(WI.Slider.prototype._handleMousedown):
+Drive-by: right clicking the slider shouldn't move the thumb.
+
+(WI.Slider.prototype._handleKeyDown):
+
+2020-01-06  Nikita Vasilyev  
+
 REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide color picker
 https://bugs.webkit.org/show_bug.cgi?id=205570
 


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js (254093 => 254094)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js	2020-01-06 23:49:21 UTC (rev 254093)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js	2020-01-06 23:55:35 UTC (rev 254094)
@@ -143,6 +143,11 @@
 this._showColorComponentInputs();
 }
 
+focus()
+{
+this._colorSquare.element.focus();
+}
+
 colorSquareColorDidChange(colorSquare)
 {
 this._updateColor();


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.css (254093 => 254094)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.css	2020-01-06 23:49:21 UTC (rev 254093)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.css	2020-01-06 23:55:35 UTC (rev 254094)
@@ -25,6 +25,7 @@
 
 .color-square {
 position: relative;
+outline: 0.5px solid hsl(0, 0%, 70%);
 
 --stroke-opacity: 0.8;
 }


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.js (254093 => 254094)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.js	2020-01-06 23:49:21 UTC (rev 254093)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ColorSquare.js	2020-01-06 23:55:35 UTC (rev 254094)
@@ -37,6 +37,7 @@
 
 this._element = document.createElement("div");
 this._element.className = "color-square";
+this._element.tabIndex = 0;
 
 let saturationGradientElement = this._element.appendChild(document.createElement("div"));
 saturationGradientElement.className = "saturation-gradient fill";
@@ -49,6 +50,7 @@
 this._polylineElement = null;

[webkit-changes] [254093] trunk/Source

2020-01-06 Thread commit-queue

Title: [254093] trunk/Source








Revision 254093
Author commit-qu...@webkit.org
Date 2020-01-06 15:49:21 -0800 (Mon, 06 Jan 2020)


Log Message
Build (unified) failure after adding source files to support media in GPU process
https://bugs.webkit.org/show_bug.cgi?id=205616

Patch by Peng Liu  on 2020-01-06
Reviewed by Darin Adler.

No new tests, no functional change.

Source/WebCore:

* Modules/mediastream/UserMediaClient.h:

Source/WebKit:

* Sources.txt:
* SourcesGTK.txt:
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/UserMediaClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/SourcesGTK.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (254092 => 254093)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 23:32:31 UTC (rev 254092)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 23:49:21 UTC (rev 254093)
@@ -1,3 +1,14 @@
+2020-01-06  Peng Liu  
+
+Build (unified) failure after adding source files to support media in GPU process
+https://bugs.webkit.org/show_bug.cgi?id=205616
+
+Reviewed by Darin Adler.
+
+No new tests, no functional change.
+
+* Modules/mediastream/UserMediaClient.h:
+
 2020-01-06  Daniel Bates  
 
 Precision of getClientRects(), getBoundingClientRect() differs depending whether simple line layout or line box layout is used


Modified: trunk/Source/WebCore/Modules/mediastream/UserMediaClient.h (254092 => 254093)

--- trunk/Source/WebCore/Modules/mediastream/UserMediaClient.h	2020-01-06 23:32:31 UTC (rev 254092)
+++ trunk/Source/WebCore/Modules/mediastream/UserMediaClient.h	2020-01-06 23:49:21 UTC (rev 254093)
@@ -39,6 +39,7 @@
 namespace WebCore {
 
 class CaptureDevice;
+class Document;
 class Page;
 class UserMediaRequest;
 


Modified: trunk/Source/WebKit/ChangeLog (254092 => 254093)

--- trunk/Source/WebKit/ChangeLog	2020-01-06 23:32:31 UTC (rev 254092)
+++ trunk/Source/WebKit/ChangeLog	2020-01-06 23:49:21 UTC (rev 254093)
@@ -1,3 +1,16 @@
+2020-01-06  Peng Liu  
+
+Build (unified) failure after adding source files to support media in GPU process
+https://bugs.webkit.org/show_bug.cgi?id=205616
+
+Reviewed by Darin Adler.
+
+No new tests, no functional change.
+
+* Sources.txt:
+* SourcesGTK.txt:
+* WebKit.xcodeproj/project.pbxproj:
+
 2020-01-06  Alex Christensen  
 
 NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions


Modified: trunk/Source/WebKit/Sources.txt (254092 => 254093)

--- trunk/Source/WebKit/Sources.txt	2020-01-06 23:32:31 UTC (rev 254092)
+++ trunk/Source/WebKit/Sources.txt	2020-01-06 23:49:21 UTC (rev 254093)
@@ -24,11 +24,11 @@
 GPUProcess/GPUProcess.cpp
 GPUProcess/GPUConnectionToWebProcess.cpp
 GPUProcess/GPUProcessCreationParameters.cpp
-//GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp
-//GPUProcess/media/RemoteMediaPlayerProxy.cpp
-//GPUProcess/media/RemoteMediaResource.cpp
-//GPUProcess/media/RemoteMediaResourceLoader.cpp
-//GPUProcess/media/RemoteMediaResourceManager.cpp
+GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp
+GPUProcess/media/RemoteMediaPlayerProxy.cpp
+GPUProcess/media/RemoteMediaResource.cpp
+GPUProcess/media/RemoteMediaResourceLoader.cpp
+GPUProcess/media/RemoteMediaResourceManager.cpp
 
 NetworkProcess/AdClickAttributionManager.cpp
 NetworkProcess/NetworkActivityTracker.cpp
@@ -508,10 +508,10 @@
 WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp
 
 WebProcess/GPU/GPUProcessConnection.cpp
-//WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
-//WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
-//WebProcess/GPU/media/RemoteMediaResourceProxy.cpp
+WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
+WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
 WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.cpp @no-unify
+WebProcess/GPU/media/RemoteMediaResourceProxy.cpp
 WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp
 
 WebProcess/Network/NetworkProcessConnection.cpp


Modified: trunk/Source/WebKit/SourcesGTK.txt (254092 => 254093)

--- trunk/Source/WebKit/SourcesGTK.txt	2020-01-06 23:32:31 UTC (rev 254092)
+++ trunk/Source/WebKit/SourcesGTK.txt	2020-01-06 23:49:21 UTC (rev 254093)
@@ -393,8 +393,8 @@
 
 WebProcess/MediaCache/WebMediaKeyStorageManager.cpp
 
-WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp
-WebProcess/Plugins/Netscape/unix/PluginProxyUnix.cpp
+WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp @no-unify
+WebProcess/Plugins/Netscape/unix/PluginProxyUnix.cpp @no-unify
 
 WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp @no-unify
 


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (254092 => 254093)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2020-01-06 23:32:31 UTC (rev 254092)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2020-01-06 23:49:21 UTC (rev

[webkit-changes] [254092] trunk/Source/WebKit

2020-01-06 Thread commit-queue

Title: [254092] trunk/Source/WebKit








Revision 254092
Author commit-qu...@webkit.org
Date 2020-01-06 15:32:31 -0800 (Mon, 06 Jan 2020)


Log Message
NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions
https://bugs.webkit.org/show_bug.cgi?id=205824


Patch by Alex Christensen  on 2020-01-06
Reviewed by Chris Dumez.

Classic iterator use after mutating iterated container was causing crashes by returning a null SessionWrapper&
This was introduced in r252185 or r248640.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::isolatedSession):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (254091 => 254092)

--- trunk/Source/WebKit/ChangeLog	2020-01-06 23:08:48 UTC (rev 254091)
+++ trunk/Source/WebKit/ChangeLog	2020-01-06 23:32:31 UTC (rev 254092)
@@ -1,3 +1,17 @@
+2020-01-06  Alex Christensen  
+
+NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions
+https://bugs.webkit.org/show_bug.cgi?id=205824
+
+
+Reviewed by Chris Dumez.
+
+Classic iterator use after mutating iterated container was causing crashes by returning a null SessionWrapper&
+This was introduced in r252185 or r248640.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::isolatedSession):
+
 2020-01-06  Mark Lam  
 
 Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (254091 => 254092)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2020-01-06 23:08:48 UTC (rev 254091)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2020-01-06 23:32:31 UTC (rev 254092)
@@ -1178,6 +1178,21 @@
 
 entry->lastUsed = WallTime::now();
 
+auto& sessionWrapper = [&] (auto storedCredentialsPolicy) -> SessionWrapper& {
+switch (storedCredentialsPolicy) {
+case WebCore::StoredCredentialsPolicy::Use:
+LOG(NetworkSession, "Using isolated NSURLSession with credential storage.");
+return entry->sessionWithCredentialStorage;
+case WebCore::StoredCredentialsPolicy::DoNotUse:
+LOG(NetworkSession, "Using isolated NSURLSession without credential storage.");
+return entry->sessionWithoutCredentialStorage;
+case WebCore::StoredCredentialsPolicy::EphemeralStateless:
+if (!m_ephemeralStatelessSession.session)
+initializeEphemeralStatelessSession();
+return m_ephemeralStatelessSession;
+}
+} (storedCredentialsPolicy);
+
 if (m_isolatedSessions.size() > maxNumberOfIsolatedSessions) {
 WebCore::RegistrableDomain keyToRemove;
 auto oldestTimestamp = WallTime::now();
@@ -1194,18 +1209,7 @@
 
 RELEASE_ASSERT(m_isolatedSessions.size() <= maxNumberOfIsolatedSessions);
 
-switch (storedCredentialsPolicy) {
-case WebCore::StoredCredentialsPolicy::Use:
-LOG(NetworkSession, "Using isolated NSURLSession with credential storage.");
-return entry->sessionWithCredentialStorage;
-case WebCore::StoredCredentialsPolicy::DoNotUse:
-LOG(NetworkSession, "Using isolated NSURLSession without credential storage.");
-return entry->sessionWithoutCredentialStorage;
-case WebCore::StoredCredentialsPolicy::EphemeralStateless:
-if (!m_ephemeralStatelessSession.session)
-initializeEphemeralStatelessSession();
-return m_ephemeralStatelessSession;
-}
+return sessionWrapper;
 }
 
 bool NetworkSessionCocoa::hasIsolatedSession(const WebCore::RegistrableDomain domain) const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254091] trunk

2020-01-06 Thread dbates

Title: [254091] trunk








Revision 254091
Author dba...@webkit.org
Date 2020-01-06 15:08:48 -0800 (Mon, 06 Jan 2020)


Log Message
Precision of getClientRects(), getBoundingClientRect() differs depending whether simple line layout or line box layout is used
https://bugs.webkit.org/show_bug.cgi?id=205563


Reviewed by Zalan Bujtas.

Source/WebCore:

Fix up simple line layout run rect to match the rect returned by the line layout code path.

* rendering/InlineTextBox.cpp:
(WebCore::snappedSelectionRect): Added; extracted from localSelectionRect().
(WebCore::InlineTextBox::localSelectionRect const): Moved some logic into snappedSelectionRect()
and modified code to use it.
* rendering/InlineTextBox.h:
* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::collectAbsoluteQuadsForRange): Fix up run rect.

Tools:

Update test results.

* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
(TEST):
* TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
(TEST):

LayoutTests:

Update expected result now that simple line layout computes a client rect that matches
the rect the line layout code computes.

* fast/dom/Range/getClientRects-expected.txt:
* fast/dom/Range/getClientRects.html:
* fast/dom/Range/mac/getClientRects-and-getBoundingClientRect-before-and-after-selection-expected.txt:
* fast/repaint/text-selection-overflow-hidden-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/Range/getClientRects-expected.txt
trunk/LayoutTests/fast/dom/Range/getClientRects.html
trunk/LayoutTests/fast/dom/Range/mac/getClientRects-and-getBoundingClientRect-before-and-after-selection-expected.txt
trunk/LayoutTests/fast/repaint/text-selection-overflow-hidden-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/rendering/InlineTextBox.h
trunk/Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm
trunk/Tools/TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm
trunk/Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (254090 => 254091)

--- trunk/LayoutTests/ChangeLog	2020-01-06 23:05:17 UTC (rev 254090)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 23:08:48 UTC (rev 254091)
@@ -1,3 +1,19 @@
+2020-01-06  Daniel Bates  
+
+Precision of getClientRects(), getBoundingClientRect() differs depending whether simple line layout or line box layout is used
+https://bugs.webkit.org/show_bug.cgi?id=205563
+
+
+Reviewed by Zalan Bujtas.
+
+Update expected result now that simple line layout computes a client rect that matches
+the rect the line layout code computes.
+
+* fast/dom/Range/getClientRects-expected.txt:
+* fast/dom/Range/getClientRects.html:
+* fast/dom/Range/mac/getClientRects-and-getBoundingClientRect-before-and-after-selection-expected.txt:
+* fast/repaint/text-selection-overflow-hidden-expected.txt:
+
 2020-01-06  Jack Lee  
 
 ASSERTION FAILED: hasLayer() in RenderLayer::enclosingOverflowClipLayer


Modified: trunk/LayoutTests/fast/dom/Range/getClientRects-expected.txt (254090 => 254091)

--- trunk/LayoutTests/fast/dom/Range/getClientRects-expected.txt	2020-01-06 23:05:17 UTC (rev 254090)
+++ trunk/LayoutTests/fast/dom/Range/getClientRects-expected.txt	2020-01-06 23:08:48 UTC (rev 254091)
@@ -40,9 +40,9 @@
 PASS rects[3].height.toFixed(2) is "18.00"
 Test 3
 PASS rects.length is 4
-PASS rects[0].left.toFixed(2) is "81.31"
+PASS rects[0].left.toFixed(2) is "81.00"
 PASS rects[0].top.toFixed(2) is "411.00"
-PASS rects[0].width.toFixed(2) is "313.27"
+PASS rects[0].width.toFixed(2) is "313.00"
 PASS rects[0].height.toFixed(2) is "18.00"
 PASS rects[1].left.toFixed(2) is "8.00"
 PASS rects[1].top.toFixed(2) is "451.00"
@@ -54,7 +54,7 @@
 PASS rects[2].height.toFixed(2) is "18.00"
 PASS rects[3].left.toFixed(2) is "8.00"
 PASS rects[3].top.toFixed(2) is "531.00"
-PASS rects[3].width.toFixed(2) is "146.66"
+PASS rects[3].width.toFixed(2) is "147.00"
 PASS rects[3].height.toFixed(2) is "18.00"
 Test 4
 PASS rects.length is 7
@@ -90,7 +90,7 @@
 PASS rects.length is 5
 PASS rects[0].left.toFixed(2) is "81.00"
 PASS rects[0].top.toFixed(2) is "921.00"
-PASS rects[0].width.toFixed(2) is "313.58"
+PASS rects[0].width.toFixed(2) is "313.00"
 PASS rects[0].height.toFixed(2) is "18.00"
 PASS rects[1].left.toFixed(2) is "8.00"
 PASS rects[1].top.toFixed(2) is "1039.00"


Modified: trunk/LayoutTests/fast/dom/Range/getClientRects.html (254090 => 254091)

--- trunk/LayoutTests/fast/dom/Range/getClientRects.html	2020-01-06 23:05:17 UTC (rev 254090)
+++ trunk/LayoutTests/fast/dom/Range/getClientRects.html	2020-01-06 23:08:48 UTC (rev 254091)
@@ -185,9 +185,9 @@
 show(range3);
 rects = range3.getClientRects();

[webkit-changes] [254090] tags/Safari-608.5.7/

2020-01-06 Thread alancoon

Title: [254090] tags/Safari-608.5.7/








Revision 254090
Author alanc...@apple.com
Date 2020-01-06 15:05:17 -0800 (Mon, 06 Jan 2020)


Log Message
Tag Safari-608.5.7.

Added Paths

tags/Safari-608.5.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254089] trunk

2020-01-06 Thread youenn

Title: [254089] trunk








Revision 254089
Author you...@apple.com
Date 2020-01-06 14:57:25 -0800 (Mon, 06 Jan 2020)


Log Message
XMLHTTPRequest POSTs blob data to a custom WKURLSchemeHandler protocol crash
https://bugs.webkit.org/show_bug.cgi?id=205685

Reviewed by Alex Christensen.

Source/WebCore:

There is no blob registry in the UIProcess.
This should not matter since we do not yet support blobs in custom scheme handlers.
But we are calling the blob registry when creating a request body, which does not work in UIProcess.
Instead, pass a lambda that will be called in case of blobs.
Covered by API test.

* platform/network/FormData.cpp:
(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::resolveBlobReferences):
* platform/network/FormData.h:
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::createHTTPBodyCFReadStream):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/FormData.cpp
trunk/Source/WebCore/platform/network/FormData.h
trunk/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (254088 => 254089)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 22:47:34 UTC (rev 254088)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 22:57:25 UTC (rev 254089)
@@ -1,3 +1,23 @@
+2020-01-06  youenn fablet  
+
+XMLHTTPRequest POSTs blob data to a custom WKURLSchemeHandler protocol crash
+https://bugs.webkit.org/show_bug.cgi?id=205685
+
+Reviewed by Alex Christensen.
+
+There is no blob registry in the UIProcess.
+This should not matter since we do not yet support blobs in custom scheme handlers.
+But we are calling the blob registry when creating a request body, which does not work in UIProcess.
+Instead, pass a lambda that will be called in case of blobs.
+Covered by API test.
+
+* platform/network/FormData.cpp:
+(WebCore::FormDataElement::lengthInBytes const):
+(WebCore::FormData::resolveBlobReferences):
+* platform/network/FormData.h:
+* platform/network/cf/FormDataStreamCFNet.cpp:
+(WebCore::createHTTPBodyCFReadStream):
+
 2020-01-06  Mark Lam  
 
 Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.


Modified: trunk/Source/WebCore/platform/network/FormData.cpp (254088 => 254089)

--- trunk/Source/WebCore/platform/network/FormData.cpp	2020-01-06 22:47:34 UTC (rev 254088)
+++ trunk/Source/WebCore/platform/network/FormData.cpp	2020-01-06 22:57:25 UTC (rev 254089)
@@ -123,9 +123,9 @@
 return formData;
 }
 
-static inline uint64_t computeLengthInBytes(const FormDataElement& element, const Function& blobSize)
+uint64_t FormDataElement::lengthInBytes(const Function& blobSize) const
 {
-return switchOn(element.data,
+return switchOn(data,
 [] (const Vector& bytes) {
 return static_cast(bytes.size());
 }, [] (const FormDataElement::EncodedFileData& fileData) {
@@ -141,16 +141,9 @@
 );
 }
 
-uint64_t FormDataElement::lengthInBytes(BlobRegistryImpl* blobRegistry) const
-{
-return computeLengthInBytes(*this, [&](auto& url) {
-return blobRegistry ? blobRegistry->blobSize(url) : 0;
-});
-}
-
 uint64_t FormDataElement::lengthInBytes() const
 {
-return computeLengthInBytes(*this, [](auto& url) {
+return lengthInBytes([](auto& url) {
 return blobRegistry().blobSize(url);
 });
 }
@@ -323,7 +316,7 @@
 }
 }
 
-Ref FormData::resolveBlobReferences(BlobRegistryImpl* blobRegistry)
+Ref FormData::resolveBlobReferences(BlobRegistryImpl* blobRegistryImpl)
 {
 // First check if any blobs needs to be resolved, or we can take the fast path.
 bool hasBlob = false;
@@ -349,7 +342,7 @@
 }, [&] (const FormDataElement::EncodedFileData& fileData) {
 newFormData->appendFileRange(fileData.filename, fileData.fileStart, fileData.fileLength, fileData.expectedFileModificationTime);
 }, [&] (const FormDataElement::EncodedBlobData& blobData) {
-appendBlobResolved(blobRegistry, newFormData.get(), blobData.url);
+appendBlobResolved(blobRegistryImpl ? blobRegistryImpl : blobRegistry().blobRegistryImpl(), newFormData.get(), blobData.url);
 }
 );
 }


Modified: trunk/Source/WebCore/platform/network/FormData.h (254088 => 254089)

--- trunk/Source/WebCore/platform/network/FormData.h	2020-01-06 22:47:34 UTC (rev 254088)
+++ trunk/Source/WebCore/platform/network/FormData.h	2020-01-06 22:57:25 UTC (rev 254089)
@@ -50,7 +50,7 @@
 explicit FormDataElement(const URL& blobURL)
 : data(EncodedBlobData { blobURL }) { }
 
-uint64_t lengthInBytes(BlobRegistryImpl*) const;
+uint64_t lengthInBytes(const Function&)

[webkit-changes] [254088] trunk

2020-01-06 Thread shvaikalesh

Title: [254088] trunk








Revision 254088
Author shvaikal...@gmail.com
Date 2020-01-06 14:47:34 -0800 (Mon, 06 Jan 2020)


Log Message
String.prototype.replace() incorrectly handles named references on RegExp w/o named groups
https://bugs.webkit.org/show_bug.cgi?id=205785

Reviewed by Ross Kirsling.

JSTests:

* test262/expectations.yaml: Mark 2 test cases as passing.

Source/_javascript_Core:

This patch fixes substitution of named references by ignoring "$<" sequences
for a RegExp without named capture groups, removing some index tweaking.
(step 11 of https://tc39.es/ecma262/#sec-getsubstitution)

Also this change removes 2 obsolete FIXMEs regarding possible spec changes.

* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp




Diff

Modified: trunk/JSTests/ChangeLog (254087 => 254088)

--- trunk/JSTests/ChangeLog	2020-01-06 22:24:50 UTC (rev 254087)
+++ trunk/JSTests/ChangeLog	2020-01-06 22:47:34 UTC (rev 254088)
@@ -1,5 +1,14 @@
 2020-01-06  Alexey Shvayka  
 
+String.prototype.replace() incorrectly handles named references on RegExp w/o named groups
+https://bugs.webkit.org/show_bug.cgi?id=205785
+
+Reviewed by Ross Kirsling.
+
+* test262/expectations.yaml: Mark 2 test cases as passing.
+
+2020-01-06  Alexey Shvayka  
+
 Proxy's [[OwnPropertyKeys]] is incorrect in DontEnumPropertiesMode::Exclude
 https://bugs.webkit.org/show_bug.cgi?id=203818
 


Modified: trunk/JSTests/test262/expectations.yaml (254087 => 254088)

--- trunk/JSTests/test262/expectations.yaml	2020-01-06 22:24:50 UTC (rev 254087)
+++ trunk/JSTests/test262/expectations.yaml	2020-01-06 22:47:34 UTC (rev 254088)
@@ -1270,9 +1270,6 @@
 test/built-ins/RegExp/named-groups/groups-object-subclass.js:
   default: 'Test262Error: Expected SameValue(«b», «$») to be true'
   strict mode: 'Test262Error: Expected SameValue(«b», «$») to be true'
-test/built-ins/RegExp/named-groups/string-replace-nocaptures.js:
-  default: 'Test262Error: Expected SameValue(«$$cd», «$<$cd») to be true'
-  strict mode: 'Test262Error: Expected SameValue(«$$cd», «$<$cd») to be true'
 test/built-ins/RegExp/named-groups/unicode-property-names.js:
   default: 'SyntaxError: Invalid regular _expression_: invalid group specifier name'
   strict mode: 'SyntaxError: Invalid regular _expression_: invalid group specifier name'


Modified: trunk/Source/_javascript_Core/ChangeLog (254087 => 254088)

--- trunk/Source/_javascript_Core/ChangeLog	2020-01-06 22:24:50 UTC (rev 254087)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-06 22:47:34 UTC (rev 254088)
@@ -1,3 +1,19 @@
+2020-01-06  Alexey Shvayka  
+
+String.prototype.replace() incorrectly handles named references on RegExp w/o named groups
+https://bugs.webkit.org/show_bug.cgi?id=205785
+
+Reviewed by Ross Kirsling.
+
+This patch fixes substitution of named references by ignoring "$<" sequences
+for a RegExp without named capture groups, removing some index tweaking.
+(step 11 of https://tc39.es/ecma262/#sec-getsubstitution)
+
+Also this change removes 2 obsolete FIXMEs regarding possible spec changes.
+
+* runtime/StringPrototype.cpp:
+(JSC::substituteBackreferencesSlow):
+
 2020-01-06  Mark Lam  
 
 Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.


Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (254087 => 254088)

--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2020-01-06 22:24:50 UTC (rev 254087)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2020-01-06 22:47:34 UTC (rev 254088)
@@ -220,31 +220,17 @@
 backrefLength = source.length() - backrefStart;
 } else if (reg && ref == '<') {
 // Named back reference
-if (!hasNamedCaptures) {
-result.append(replacement.substring(i, 2));
-offset = i + 2;
-advance = 1;
+if (!hasNamedCaptures)
 continue;
-}
 
 size_t closingBracket = replacement.find('>', i + 2);
-if (closingBracket == WTF::notFound) {
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=176434
-// Current proposed spec change throws a syntax error in this case.
-// We have made the case that it makes more sense to treat this a literal
-// If throwSyntaxError(globalObject, scope, "Missing closing '>' in replacement text");
+if (closingBracket == WTF::notFound)
 continue;
-}
 
 unsigned nameLength = closingBracket - i - 2;
 unsigned backrefIndex = reg->subpatternForName(replacement.substring(i + 2,

[webkit-changes] [254086] trunk

2020-01-06 Thread commit-queue

Title: [254086] trunk








Revision 254086
Author commit-qu...@webkit.org
Date 2020-01-06 14:20:43 -0800 (Mon, 06 Jan 2020)


Log Message
ASSERTION FAILED: hasLayer() in RenderLayer::enclosingOverflowClipLayer
https://bugs.webkit.org/show_bug.cgi?id=205474

Patch by Jack Lee  on 2020-01-06
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/sticky/sticky-tablecol-crash.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::enclosingClippingBoxForStickyPosition const):
(WebCore::RenderBoxModelObject::constrainingRectForStickyPosition const):
(WebCore::RenderBoxModelObject::stickyPositionOffset const):

LayoutTests:

* fast/css/sticky/sticky-tablecol-crash-expected.txt: Added.
* fast/css/sticky/sticky-tablecol-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp


Added Paths

trunk/LayoutTests/fast/css/sticky/sticky-tablecol-crash-expected.txt
trunk/LayoutTests/fast/css/sticky/sticky-tablecol-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (254085 => 254086)

--- trunk/LayoutTests/ChangeLog	2020-01-06 22:17:30 UTC (rev 254085)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 22:20:43 UTC (rev 254086)
@@ -1,3 +1,13 @@
+2020-01-06  Jack Lee  
+
+ASSERTION FAILED: hasLayer() in RenderLayer::enclosingOverflowClipLayer
+https://bugs.webkit.org/show_bug.cgi?id=205474
+
+Reviewed by Simon Fraser.
+
+* fast/css/sticky/sticky-tablecol-crash-expected.txt: Added.
+* fast/css/sticky/sticky-tablecol-crash.html: Added.
+
 2020-01-06  Antoine Quint  
 
 REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is failing


Added: trunk/LayoutTests/fast/css/sticky/sticky-tablecol-crash-expected.txt (0 => 254086)

--- trunk/LayoutTests/fast/css/sticky/sticky-tablecol-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/sticky/sticky-tablecol-crash-expected.txt	2020-01-06 22:20:43 UTC (rev 254086)
@@ -0,0 +1,5 @@
+Tests position:sticky on a table column.
+
+The test passes if WebKit doesn't crash or hit an assertion.
+
+


Added: trunk/LayoutTests/fast/css/sticky/sticky-tablecol-crash.html (0 => 254086)

--- trunk/LayoutTests/fast/css/sticky/sticky-tablecol-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/css/sticky/sticky-tablecol-crash.html	2020-01-06 22:20:43 UTC (rev 254086)
@@ -0,0 +1,22 @@
+
+body {
+height: 1000px;
+}
+col {
+position: sticky;
+}
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function runTest() {
+   tableCol.scrollIntoViewIfNeeded(true);
+}
+
+
+
+Tests position:sticky on a table column.
+The test passes if WebKit doesn't crash or hit an assertion.
+


Modified: trunk/Source/WebCore/ChangeLog (254085 => 254086)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 22:17:30 UTC (rev 254085)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 22:20:43 UTC (rev 254086)
@@ -1,3 +1,17 @@
+2020-01-06  Jack Lee  
+
+ASSERTION FAILED: hasLayer() in RenderLayer::enclosingOverflowClipLayer
+https://bugs.webkit.org/show_bug.cgi?id=205474
+
+Reviewed by Simon Fraser.
+
+Test: fast/css/sticky/sticky-tablecol-crash.html
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::enclosingClippingBoxForStickyPosition const):
+(WebCore::RenderBoxModelObject::constrainingRectForStickyPosition const):
+(WebCore::RenderBoxModelObject::stickyPositionOffset const):
+
 2020-01-06  Alex Christensen  
 
 Allow wildcard scheme in UserContentURLPattern


Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (254085 => 254086)

--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp	2020-01-06 22:17:30 UTC (rev 254085)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp	2020-01-06 22:20:43 UTC (rev 254086)
@@ -445,7 +445,8 @@
 {
 ASSERT(isStickilyPositioned());
 
-auto* clipLayer = layer()->enclosingOverflowClipLayer(ExcludeSelf);
+RenderLayer* clipLayer = hasLayer() ? layer()->enclosingOverflowClipLayer(ExcludeSelf) : nullptr;
+
 if (enclosingClippingLayer)
 *enclosingClippingLayer = clipLayer;
 
@@ -536,7 +537,8 @@
 
 FloatRect RenderBoxModelObject::constrainingRectForStickyPosition() const
 {
-RenderLayer* enclosingClippingLayer = layer()->enclosingOverflowClipLayer(ExcludeSelf);
+RenderLayer* enclosingClippingLayer = hasLayer() ? layer()->enclosingOverflowClipLayer(ExcludeSelf) : nullptr;
+
 if (enclosingClippingLayer) {
 RenderBox& enclosingClippingBox = downcast(enclosingClippingLayer->renderer());
 LayoutRect clipRect = enclosingClippingBox.overflowClipRect(LayoutPoint(), nullptr); // FIXME: make this work in regions.
@@ -560,8 +562,6 @@
 
 LayoutSize RenderBoxModelObject::stickyPositionOffset() const
 {
-ASSERT(hasLayer());
-
 FloatRect

[webkit-changes] [254085] trunk

2020-01-06 Thread commit-queue

Title: [254085] trunk








Revision 254085
Author commit-qu...@webkit.org
Date 2020-01-06 14:17:30 -0800 (Mon, 06 Jan 2020)


Log Message
Remove WebsiteDataStore::setServiceWorkerRegistrationDirectory
https://bugs.webkit.org/show_bug.cgi?id=205754

Patch by Alex Christensen  on 2020-01-06
Reviewed by Youenn Fablet.

Source/WebKit:

The directory is now only set in the configuration, which will prevent misuse of the misplaced SPI.
Updated API tests, which still work.

* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:
(WKWebsiteDataStoreConfigurationCopyServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreConfigurationSetServiceWorkerRegistrationDirectory):
* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:
* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreCopyServiceWorkerRegistrationDirectory): Deleted.
(WKWebsiteDataStoreSetServiceWorkerRegistrationDirectory): Deleted.
* UIProcess/API/C/WKWebsiteDataStoreRef.h:
* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _hasRegisteredServiceWorker]):
(-[WKWebsiteDataStore _serviceWorkerRegistrationDirectory]): Deleted.
(-[WKWebsiteDataStore _setServiceWorkerRegistrationDirectory:]): Deleted.
* UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::setCacheStorageDirectory):
(WebKit::WebsiteDataStore::serviceWorkerRegistrationDirectory const): Deleted.
(WebKit::WebsiteDataStore::setServiceWorkerRegistrationDirectory): Deleted.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::websiteDataStore):
(WTR::TestController::platformAdjustContext):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (254084 => 254085)

--- trunk/Source/WebKit/ChangeLog	2020-01-06 21:59:59 UTC (rev 254084)
+++ trunk/Source/WebKit/ChangeLog	2020-01-06 22:17:30 UTC (rev 254085)
@@ -1,5 +1,33 @@
 2020-01-06  Alex Christensen  
 
+Remove WebsiteDataStore::setServiceWorkerRegistrationDirectory
+https://bugs.webkit.org/show_bug.cgi?id=205754
+
+Reviewed by Youenn Fablet.
+
+The directory is now only set in the configuration, which will prevent misuse of the misplaced SPI.
+Updated API tests, which still work.
+
+* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:
+(WKWebsiteDataStoreConfigurationCopyServiceWorkerRegistrationDirectory):
+(WKWebsiteDataStoreConfigurationSetServiceWorkerRegistrationDirectory):
+* UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:
+* UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
+(WKWebsiteDataStoreCopyServiceWorkerRegistrationDirectory): Deleted.
+(WKWebsiteDataStoreSetServiceWorkerRegistrationDirectory): Deleted.
+* UIProcess/API/C/WKWebsiteDataStoreRef.h:
+* UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
+(-[WKWebsiteDataStore _hasRegisteredServiceWorker]):
+(-[WKWebsiteDataStore _serviceWorkerRegistrationDirectory]): Deleted.
+(-[WKWebsiteDataStore _setServiceWorkerRegistrationDirectory:]): Deleted.
+* UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
+* UIProcess/WebsiteData/WebsiteDataStore.h:
+(WebKit::WebsiteDataStore::setCacheStorageDirectory):
+(WebKit::WebsiteDataStore::serviceWorkerRegistrationDirectory const): Deleted.
+(WebKit::WebsiteDataStore::setServiceWorkerRegistrationDirectory): Deleted.
+
+2020-01-06  Alex Christensen  
+
 Remove _WKProcessPoolConfiguration.CTDataConnectionServiceType and suppressesConnectionTerminationOnSystemChange
 https://bugs.webkit.org/show_bug.cgi?id=205751
 


Modified: trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp (254084 => 254085)

--- trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp	2020-01-06 21:59:59 UTC (rev 254084)
+++ trunk/Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp	2020-01-06 22:17:30 UTC (rev 254085)
@@ -110,6 +110,16 @@
 WebKit::toImpl(configuration)->setResourceLoadStatisticsDirectory(WebKit::toImpl(directory)->string());
 }
 
+WKStringRef

[webkit-changes] [254084] trunk

2020-01-06 Thread commit-queue

Title: [254084] trunk








Revision 254084
Author commit-qu...@webkit.org
Date 2020-01-06 13:59:59 -0800 (Mon, 06 Jan 2020)


Log Message
Allow wildcard scheme in UserContentURLPattern
https://bugs.webkit.org/show_bug.cgi?id=205695

Patch by Alex Christensen  on 2020-01-06
Reviewed by Darin Adler.

Source/WebCore:

This is needed for  and covered by an API test.

* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::matches const):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/UserContentURLPattern.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (254083 => 254084)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 21:57:18 UTC (rev 254083)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 21:59:59 UTC (rev 254084)
@@ -1,3 +1,15 @@
+2020-01-06  Alex Christensen  
+
+Allow wildcard scheme in UserContentURLPattern
+https://bugs.webkit.org/show_bug.cgi?id=205695
+
+Reviewed by Darin Adler.
+
+This is needed for  and covered by an API test.
+
+* page/UserContentURLPattern.cpp:
+(WebCore::UserContentURLPattern::matches const):
+
 2020-01-06  Youenn Fablet  
 
 Fix non unified build in FIDO Pin.cpp


Modified: trunk/Source/WebCore/page/UserContentURLPattern.cpp (254083 => 254084)

--- trunk/Source/WebCore/page/UserContentURLPattern.cpp	2020-01-06 21:57:18 UTC (rev 254083)
+++ trunk/Source/WebCore/page/UserContentURLPattern.cpp	2020-01-06 21:59:59 UTC (rev 254084)
@@ -114,7 +114,7 @@
 if (m_invalid)
 return false;
 
-if (!equalIgnoringASCIICase(test.protocol(), m_scheme))
+if (m_scheme != "*" && !equalIgnoringASCIICase(test.protocol(), m_scheme))
 return false;
 
 if (!equalLettersIgnoringASCIICase(m_scheme, "file") && !matchesHost(test))


Modified: trunk/Tools/ChangeLog (254083 => 254084)

--- trunk/Tools/ChangeLog	2020-01-06 21:57:18 UTC (rev 254083)
+++ trunk/Tools/ChangeLog	2020-01-06 21:59:59 UTC (rev 254084)
@@ -1,3 +1,12 @@
+2020-01-06  Alex Christensen  
+
+Allow wildcard scheme in UserContentURLPattern
+https://bugs.webkit.org/show_bug.cgi?id=205695
+
+Reviewed by Darin Adler.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
+
 2020-01-06  Antoine Quint  
 
 REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is failing


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm (254083 => 254084)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm	2020-01-06 21:57:18 UTC (rev 254083)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm	2020-01-06 21:59:59 UTC (rev 254084)
@@ -850,7 +850,7 @@
 corsfailure = false;
 done = false;
 
-configuration._corsDisablingPatterns = @[@"http://*/*"];
+configuration._corsDisablingPatterns = @[@"*://*/*"];
 {
 auto webView = adoptNS([[WKWebView alloc] initWithFrame:CGRectMake(0, 0, 800, 600) configuration:configuration]);
 [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"cors://host1/main.html"]]];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254083] tags/Safari-609.1.13.3/

2020-01-06 Thread alancoon

Title: [254083] tags/Safari-609.1.13.3/








Revision 254083
Author alanc...@apple.com
Date 2020-01-06 13:57:18 -0800 (Mon, 06 Jan 2020)


Log Message
Tag Safari-609.1.13.3.

Added Paths

tags/Safari-609.1.13.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254082] trunk

2020-01-06 Thread commit-queue

Title: [254082] trunk








Revision 254082
Author commit-qu...@webkit.org
Date 2020-01-06 13:53:39 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205458


Patch by Antoine Quint  on 2020-01-06
Reviewed by Wenson Hsieh.

Tools:

The last sub-test in imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html checks on the
ability to activate various form controls after disabling and re-enabling them. Two of those form controls, 
and , would trigger animations of the web view's UIScrollView causing touches to be consumed by UIKit and
never seen by the WKContentView, and as such the expected "click" events would not be received. It would have been
possible to modify the test to wait on any potential page scroll to complete before dispatching taps, but since this
is a WPT test, we cannot modify it. Instead, we make a change to the function called by uiScriptController.singleTapAtPoint()
to interrupt any pending UIScrollView animation when a tap is being triggered on the web view. Credit to Wenson Hsieh
for suggesting this simple and effective approach.

* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):

LayoutTests:

Remove the platform-specific expectation since this test now passes reliably on iOS as well.

* platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm


Removed Paths

trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (254081 => 254082)

--- trunk/LayoutTests/ChangeLog	2020-01-06 21:23:19 UTC (rev 254081)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 21:53:39 UTC (rev 254082)
@@ -1,3 +1,15 @@
+2020-01-06  Antoine Quint  
+
+REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205458
+
+
+Reviewed by Wenson Hsieh.
+
+Remove the platform-specific expectation since this test now passes reliably on iOS as well.
+
+* platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt: Removed.
+
 2020-01-06  Chris Dumez  
 
 Regression r254029: imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html is failing


Deleted: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt (254081 => 254082)

--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt	2020-01-06 21:23:19 UTC (rev 254081)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt	2020-01-06 21:53:39 UTC (rev 254082)
@@ -1,12 +0,0 @@
- 
-
-PASS Can dispatch untrusted 'click' Events at disabled HTML elements. 
-PASS Can dispatch untrusted Events at disabled HTML elements. 
-PASS Can dispatch CustomEvents at disabled HTML elements. 
-PASS Calling click() on disabled elements must not dispatch events. 
-PASS CSS Transitions transitionrun, transitionstart, transitionend events fire on disabled form elements 
-PASS CSS Transitions transitioncancel event fires on disabled form elements 
-PASS CSS Animation animationstart, animationiteration, animationend fire on disabled form elements 
-PASS CSS Animation's animationcancel event fires on disabled form elements 
-FAIL Real clicks on disabled elements must not dispatch events. assert_true: HTMLSelectElement is enabled, so onclick must fire. expected true got false
-


Modified: trunk/Tools/ChangeLog (254081 => 254082)

--- trunk/Tools/ChangeLog	2020-01-06 21:23:19 UTC (rev 254081)
+++ trunk/Tools/ChangeLog	2020-01-06 21:53:39 UTC (rev 254082)
@@ -1,3 +1,23 @@
+2020-01-06  Antoine Quint  
+
+REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205458
+
+
+Reviewed by Wenson Hsieh.
+
+The last sub-test in imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html checks on the
+ability to activate various form controls after disabling and re-enabling them. Two of those form controls, 
+and , would trigger animations of the web view's UIScrollView causing touches to be consumed by UIKit and
+never seen by the WKContentView, and as such the expected "click" events would not be received. It would have been
+possible to modify the test to wait on any potential page

[webkit-changes] [254081] trunk/Source/WebKit

2020-01-06 Thread commit-queue

Title: [254081] trunk/Source/WebKit








Revision 254081
Author commit-qu...@webkit.org
Date 2020-01-06 13:23:19 -0800 (Mon, 06 Jan 2020)


Log Message
Remove _WKProcessPoolConfiguration.CTDataConnectionServiceType and suppressesConnectionTerminationOnSystemChange
https://bugs.webkit.org/show_bug.cgi?id=205751

Patch by Alex Christensen  on 2020-01-06
Reviewed by Darin Adler.

Their replacements on _WKWebViewConfiguration have been adopted.

* NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::suppressesConnectionTerminationOnSystemChange const): Deleted.
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::dataConnectionServiceType const):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::globalCTDataConnectionServiceType): Deleted.
(WebKit::NetworkSessionCocoa::setCTDataConnectionServiceType): Deleted.
* UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
* UIProcess/API/APIProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration suppressesConnectionTerminationOnSystemChange]): Deleted.
(-[_WKProcessPoolConfiguration setSuppressesConnectionTerminationOnSystemChange:]): Deleted.
(-[_WKProcessPoolConfiguration CTDataConnectionServiceType]): Deleted.
(-[_WKProcessPoolConfiguration setCTDataConnectionServiceType:]): Deleted.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::paymentCoordinatorCTDataConnectionServiceType):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (254080 => 254081)

--- trunk/Source/WebKit/ChangeLog	2020-01-06 20:58:44 UTC (rev 254080)
+++ trunk/Source/WebKit/ChangeLog	2020-01-06 21:23:19 UTC (rev 254081)
@@ -1,3 +1,40 @@
+2020-01-06  Alex Christensen  
+
+Remove _WKProcessPoolConfiguration.CTDataConnectionServiceType and suppressesConnectionTerminationOnSystemChange
+https://bugs.webkit.org/show_bug.cgi?id=205751
+
+Reviewed by Darin Adler.
+
+Their replacements on _WKWebViewConfiguration have been adopted.
+
+* NetworkProcess/NetworkProcess.h:
+(WebKit::NetworkProcess::suppressesConnectionTerminationOnSystemChange const): Deleted.
+* NetworkProcess/NetworkProcessCreationParameters.cpp:
+(WebKit::NetworkProcessCreationParameters::encode const):
+(WebKit::NetworkProcessCreationParameters::decode):
+* NetworkProcess/NetworkProcessCreationParameters.h:
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
+* NetworkProcess/cocoa/NetworkSessionCocoa.h:
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::dataConnectionServiceType const):
+(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+(WebKit::globalCTDataConnectionServiceType): Deleted.
+(WebKit::NetworkSessionCocoa::setCTDataConnectionServiceType): Deleted.
+* UIProcess/API/APIProcessPoolConfiguration.cpp:
+(API::ProcessPoolConfiguration::copy):
+* UIProcess/API/APIProcessPoolConfiguration.h:
+* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
+* UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
+(-[_WKProcessPoolConfiguration suppressesConnectionTerminationOnSystemChange]): Deleted.
+(-[_WKProcessPoolConfiguration setSuppressesConnectionTerminationOnSystemChange:]): Deleted.
+(-[_WKProcessPoolConfiguration CTDataConnectionServiceType]): Deleted.
+(-[_WKProcessPoolConfiguration setCTDataConnectionServiceType:]): Deleted.
+*

[webkit-changes] [254080] trunk/Tools

2020-01-06 Thread mark . lam

Title: [254080] trunk/Tools








Revision 254080
Author mark@apple.com
Date 2020-01-06 12:58:44 -0800 (Mon, 06 Jan 2020)


Log Message
Add --force-optimization-level option to Tools/Scripts/set-webkit-configuration.
https://bugs.webkit.org/show_bug.cgi?id=205787

Reviewed by Saam Barati.

Usage:
--force-optimization-level= Force optimization: O3, O2, O1, O0, Os, Ofast, Og, or none

This can be used to force debug builds to be built with a higher level optimization
so that tests can run to completion faster.

It can also be useful as a simple way to force release builds to be built with
different optimization levels for performance comparison.

Setting --force-optimization-level=none restores the default optimization levels.
Of course, the build targets need to be rebuilt for this to take effect.

* Scripts/set-webkit-configuration:
* Scripts/webkitdirs.pm:
(determineForceOptimizationLevel):
(forceOptimizationLevel):
(XcodeOptions):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/set-webkit-configuration
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (254079 => 254080)

--- trunk/Tools/ChangeLog	2020-01-06 20:56:41 UTC (rev 254079)
+++ trunk/Tools/ChangeLog	2020-01-06 20:58:44 UTC (rev 254080)
@@ -1,3 +1,28 @@
+2020-01-06  Mark Lam  
+
+Add --force-optimization-level option to Tools/Scripts/set-webkit-configuration.
+https://bugs.webkit.org/show_bug.cgi?id=205787
+
+Reviewed by Saam Barati.
+
+Usage:
+--force-optimization-level= Force optimization: O3, O2, O1, O0, Os, Ofast, Og, or none
+
+This can be used to force debug builds to be built with a higher level optimization
+so that tests can run to completion faster.
+
+It can also be useful as a simple way to force release builds to be built with
+different optimization levels for performance comparison.
+
+Setting --force-optimization-level=none restores the default optimization levels.
+Of course, the build targets need to be rebuilt for this to take effect.
+
+* Scripts/set-webkit-configuration:
+* Scripts/webkitdirs.pm:
+(determineForceOptimizationLevel):
+(forceOptimizationLevel):
+(XcodeOptions):
+
 2020-01-05  Dean Jackson  
 
 Rename GraphicsContext3D to GraphicsContextGL


Modified: trunk/Tools/Scripts/set-webkit-configuration (254079 => 254080)

--- trunk/Tools/Scripts/set-webkit-configuration	2020-01-06 20:56:41 UTC (rev 254079)
+++ trunk/Tools/Scripts/set-webkit-configuration	2020-01-06 20:58:44 UTC (rev 254080)
@@ -1,6 +1,6 @@
 #!/usr/bin/env perl
 
-# Copyright (C) 2005 Apple Inc.  All rights reserved.
+# Copyright (C) 2005-2019 Apple Inc.  All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -35,13 +35,14 @@
 my $programName = basename($0);
 my $usage = < Usage: $programName [options]
-  --32-bitSet the default architecture to 32-bit
-  --64-bitSet the default architecture to 64-bit
-  --[no-]asan Enable or disable clang address sanitizer
-  --lto-mode=   Set LTO mode: full, thin, or none
-  --debug Set the default configuration to debug
-  --release   Set the default configuration to release
-  --reset Reset configurations
+  --32-bit   Set the default architecture to 32-bit
+  --64-bit   Set the default architecture to 64-bit
+  --[no-]asanEnable or disable clang address sanitizer
+  --force-optimization-level= Optimization level: O3, O2, O1, O0, Os, Ofast, Og, or none
+  --lto-mode=  Set LTO mode: full, thin, or none
+  --debugSet the default configuration to debug
+  --release  Set the default configuration to release
+  --resetReset configurations
 EOF
 
 my $configuration = passedConfiguration();
@@ -52,6 +53,10 @@
 if (!checkForArgumentAndRemoveFromARGVGettingValue("--lto-mode", \$ltoMode)) {
 $ltoMode="";
 }
+my $forceOptimizationLevel;
+if (!checkForArgumentAndRemoveFromARGVGettingValue("--force-optimization-level", \$forceOptimizationLevel)) {
+$forceOptimizationLevel="";
+}
 
 if (!$architecture) {
 # Handle --64-bit explicitly here, as we don't want our other scripts to accept it
@@ -71,11 +76,12 @@
 unlink "$baseProductDir/Configuration";
 unlink "$baseProductDir/Architecture";
 unlink "$baseProductDir/ASan";
+unlink "$baseProductDir/ForceOptimizationLevel";
 unlink "$baseProductDir/LTO";
 exit 0;
 }
 
-if ((!$configuration && !$architecture && !$enableASAN && !$disableASAN && !$ltoMode) || ($enableASAN && $disableASAN)) {
+if ((!$configuration && !$architecture && !$enableASAN && !$disableASAN && !$ltoMode && !$forceOptimizationLevel) ||

[webkit-changes] [254079] trunk/Source/WebCore

2020-01-06 Thread youenn

Title: [254079] trunk/Source/WebCore








Revision 254079
Author you...@apple.com
Date 2020-01-06 12:56:41 -0800 (Mon, 06 Jan 2020)


Log Message
Fix non unified build in FIDO Pin.cpp
https://bugs.webkit.org/show_bug.cgi?id=205794

Reviewed by Jiewen Tan.

No change of behavior, this is a build fix.

* Modules/webauthn/fido/Pin.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp
trunk/Source/WebCore/Modules/webauthn/fido/FidoConstants.h
trunk/Source/WebCore/Modules/webauthn/fido/Pin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254078 => 254079)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 20:46:38 UTC (rev 254078)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 20:56:41 UTC (rev 254079)
@@ -1,3 +1,14 @@
+2020-01-06  Youenn Fablet  
+
+Fix non unified build in FIDO Pin.cpp
+https://bugs.webkit.org/show_bug.cgi?id=205794
+
+Reviewed by Jiewen Tan.
+
+No change of behavior, this is a build fix.
+
+* Modules/webauthn/fido/Pin.cpp:
+
 2020-01-06  Per Arne Vollan  
 
 REGRESSION(r247626): Introduced memory regression


Modified: trunk/Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp (254078 => 254079)

--- trunk/Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp	2020-01-06 20:46:38 UTC (rev 254078)
+++ trunk/Source/WebCore/Modules/webauthn/fido/DeviceResponseConverter.cpp	2020-01-06 20:56:41 UTC (rev 254079)
@@ -44,8 +44,6 @@
 using namespace WebCore;
 using CBOR = cbor::CBORValue;
 
-constexpr size_t kResponseCodeLength = 1;
-
 static ProtocolVersion convertStringToProtocolVersion(const String& version)
 {
 if (version == kCtap2Version)


Modified: trunk/Source/WebCore/Modules/webauthn/fido/FidoConstants.h (254078 => 254079)

--- trunk/Source/WebCore/Modules/webauthn/fido/FidoConstants.h	2020-01-06 20:46:38 UTC (rev 254078)
+++ trunk/Source/WebCore/Modules/webauthn/fido/FidoConstants.h	2020-01-06 20:56:41 UTC (rev 254079)
@@ -107,6 +107,8 @@
 
 bool isCtapDeviceResponseCode(CtapDeviceResponseCode);
 
+const size_t kResponseCodeLength = 1;
+
 // Commands supported by CTAPHID device as specified in
 // https://fidoalliance.org/specs/fido-v2.0-ps-20170927/fido-client-to-authenticator-protocol-v2.0-ps-20170927.html#ctaphid-commands
 enum class FidoHidDeviceCommand : uint8_t {


Modified: trunk/Source/WebCore/Modules/webauthn/fido/Pin.cpp (254078 => 254079)

--- trunk/Source/WebCore/Modules/webauthn/fido/Pin.cpp	2020-01-06 20:46:38 UTC (rev 254078)
+++ trunk/Source/WebCore/Modules/webauthn/fido/Pin.cpp	2020-01-06 20:56:41 UTC (rev 254079)
@@ -41,9 +41,14 @@
 #include "CryptoKeyAES.h"
 #include "CryptoKeyEC.h"
 #include "CryptoKeyHMAC.h"
+#include "DeviceResponseConverter.h"
+#include "WebAuthenticationConstants.h"
 #include 
 
 namespace fido {
+using namespace WebCore;
+using CBOR = cbor::CBORValue;
+
 namespace pin {
 using namespace cbor;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254078] trunk/Source/WebKit

2020-01-06 Thread krollin

Title: [254078] trunk/Source/WebKit








Revision 254078
Author krol...@apple.com
Date 2020-01-06 12:46:38 -0800 (Mon, 06 Jan 2020)


Log Message
Reformat WebPage logging
https://bugs.webkit.org/show_bug.cgi?id=205709


Reviewed by Brent Fulgham.

Update the format used by WebPage in its RELEASE_LOG logging. Use the
format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

 - [] ::: 

So, for example:

0x4a1df5000 - WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (frame=0x4a1db0220, priority=0, webPageID=15, frameID=3, resourceID=32)',

becomes:

0x4a1df5000 - [resourceLoader=0x1418b7200, frameLoader=0x1326d7340, frame=0x4a1db0220, webPageID=15, frameID=3, resourceID=32] WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (priority=2)

This new form is a lot more verbose, but it really helps in tracing
activity from the top of our page/frame/resource load stack to the
bottom.

No new tests - no added or changed functionality.

* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
* WebProcess/Network/WebLoaderStrategy.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (254077 => 254078)

--- trunk/Source/WebKit/ChangeLog	2020-01-06 20:42:31 UTC (rev 254077)
+++ trunk/Source/WebKit/ChangeLog	2020-01-06 20:46:38 UTC (rev 254078)
@@ -1,3 +1,39 @@
+2020-01-06  Keith Rollin  
+
+Reformat WebPage logging
+https://bugs.webkit.org/show_bug.cgi?id=205709
+
+
+Reviewed by Brent Fulgham.
+
+Update the format used by WebPage in its RELEASE_LOG logging. Use the
+format used by WebPageProxy and NetworkResourceLoader, which is
+generally of the form:
+
+ - [] ::: 
+
+So, for example:
+
+0x4a1df5000 - WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (frame=0x4a1db0220, priority=0, webPageID=15, frameID=3, resourceID=32)',
+
+becomes:
+
+0x4a1df5000 - [resourceLoader=0x1418b7200, frameLoader=0x1326d7340, frame=0x4a1db0220, webPageID=15, frameID=3, resourceID=32] WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (priority=2)
+
+This new form is a lot more verbose, but it really helps in tracing
+activity from the top of our page/frame/resource load stack to the
+bottom.
+
+No new tests - no added or changed functionality.
+
+* WebProcess/Network/WebLoaderStrategy.cpp:
+(WebKit::WebLoaderStrategy::scheduleLoad):
+(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
+(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
+(WebKit::WebLoaderStrategy::networkProcessCrashed):
+(WebKit::WebLoaderStrategy::loadResourceSynchronously):
+* WebProcess/Network/WebLoaderStrategy.h:
+
 2020-01-06  Luming Yin  
 
 Add WKWebView SPI to query _WKMediaMutedState


Modified: trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp (254077 => 254078)

--- trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2020-01-06 20:42:31 UTC (rev 254077)
+++ trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp	2020-01-06 20:46:38 UTC (rev 254078)
@@ -76,9 +76,22 @@
 #include 
 #endif
 
-#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(WebProcess::singleton().sessionID().isAlwaysOnLoggingAllowed(), Network, "%p - WebLoaderStrategy::" fmt, this, ##__VA_ARGS__)
-#define RELEASE_LOG_ERROR_IF_ALLOWED(fmt, ...) RELEASE_LOG_ERROR_IF(WebProcess::singleton().sessionID().isAlwaysOnLoggingAllowed(), Network, "%p - WebLoaderStrategy::" fmt, this, ##__VA_ARGS__)
 
+#define RELEASE_LOG_IS_ALLOWED (WebProcess::singleton().sessionID().isAlwaysOnLoggingAllowed())
+
+#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(RELEASE_LOG_IS_ALLOWED, Network, "%p - WebLoaderStrategy::" fmt, this, ##__VA_ARGS__)
+#define RELEASE_LOG_ERROR_IF_ALLOWED(fmt, ...) RELEASE_LOG_ERROR_IF(RELEASE_LOG_IS_ALLOWED, Network, "%p - WebLoaderStrategy::" fmt, this, ##__VA_ARGS__)
+
+#define WEBLOADERSTRATEGY_RELEASE_LOG_STANDARD_TEMPLATE "%p - [resourceLoader=%p, frameLoader=%p, frame=%p, webPageID=%" PRIu64 ", frameID=%" PRIu64 ", resourceID=%" PRIu64 "] WebLoaderStrategy::"
+#define WEBLOADERSTRATEGY_RELEASE_LOG_STANDARD_PARAMETERS this, , resourceLoader.frameLoader(), resourceLoader.frame(), trackingParameters.pageID.toUInt64(), trackingParameters.frameID.toUInt64(), trackingParameters.resourceID
+#define

[webkit-changes] [254077] trunk/LayoutTests

2020-01-06 Thread cdumez

Title: [254077] trunk/LayoutTests








Revision 254077
Author cdu...@apple.com
Date 2020-01-06 12:42:31 -0800 (Mon, 06 Jan 2020)


Log Message
Regression r254029: imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205819

Unreviewed, rebaseline test on iOS after r254029 now that one more check is passing.

* platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (254076 => 254077)

--- trunk/LayoutTests/ChangeLog	2020-01-06 20:38:44 UTC (rev 254076)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 20:42:31 UTC (rev 254077)
@@ -1,5 +1,14 @@
 2020-01-06  Chris Dumez  
 
+Regression r254029: imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205819
+
+Unreviewed, rebaseline test on iOS after r254029 now that one more check is passing.
+
+* platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
+
+2020-01-06  Chris Dumez  
+
 Regression r254029: imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=205817
 


Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt (254076 => 254077)

--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt	2020-01-06 20:38:44 UTC (rev 254076)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt	2020-01-06 20:42:31 UTC (rev 254077)
@@ -6,7 +6,7 @@
 PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (CustomEvent). 
 PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (DeviceMotionEvent). 
 PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (DeviceOrientationEvent). 
-FAIL If the event's initialized flag is not set, an InvalidStateError must be thrown (DragEvent). The operation is not supported.
+PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (DragEvent). 
 PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (Event). 
 PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (Events). 
 PASS If the event's initialized flag is not set, an InvalidStateError must be thrown (FocusEvent). 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254076] trunk/LayoutTests

2020-01-06 Thread cdumez

Title: [254076] trunk/LayoutTests








Revision 254076
Author cdu...@apple.com
Date 2020-01-06 12:38:44 -0800 (Mon, 06 Jan 2020)


Log Message
Regression r254029: imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205817

Unreviewed, rebaseline test on iOS after r254029 now that more checks are passing.

* platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (254075 => 254076)

--- trunk/LayoutTests/ChangeLog	2020-01-06 20:29:49 UTC (rev 254075)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 20:38:44 UTC (rev 254076)
@@ -1,3 +1,12 @@
+2020-01-06  Chris Dumez  
+
+Regression r254029: imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205817
+
+Unreviewed, rebaseline test on iOS after r254029 now that more checks are passing.
+
+* platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt:
+
 2020-01-06  Simon Fraser  
 
 REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1


Modified: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt (254075 => 254076)

--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt	2020-01-06 20:29:49 UTC (rev 254075)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt	2020-01-06 20:38:44 UTC (rev 254076)
@@ -34,12 +34,12 @@
 PASS DEVICEORIENTATIONEVENT should be an alias for DeviceOrientationEvent. 
 PASS createEvent('DEVICEORIENTATIONEVENT') should be initialized correctly. 
 PASS Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "DeviceOrientationEvents" 
-FAIL DragEvent should be an alias for DragEvent. The operation is not supported.
-FAIL createEvent('DragEvent') should be initialized correctly. undefined is not an object (evaluating 'ev.type')
-FAIL dragevent should be an alias for DragEvent. The operation is not supported.
-FAIL createEvent('dragevent') should be initialized correctly. undefined is not an object (evaluating 'ev.type')
-FAIL DRAGEVENT should be an alias for DragEvent. The operation is not supported.
-FAIL createEvent('DRAGEVENT') should be initialized correctly. undefined is not an object (evaluating 'ev.type')
+PASS DragEvent should be an alias for DragEvent. 
+PASS createEvent('DragEvent') should be initialized correctly. 
+PASS dragevent should be an alias for DragEvent. 
+PASS createEvent('dragevent') should be initialized correctly. 
+PASS DRAGEVENT should be an alias for DragEvent. 
+PASS createEvent('DRAGEVENT') should be initialized correctly. 
 PASS Should throw NOT_SUPPORTED_ERR for pluralized legacy event interface "DragEvents" 
 PASS Event should be an alias for Event. 
 PASS createEvent('Event') should be initialized correctly. 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254075] trunk/Source/WebKit

2020-01-06 Thread commit-queue

Title: [254075] trunk/Source/WebKit








Revision 254075
Author commit-qu...@webkit.org
Date 2020-01-06 12:29:49 -0800 (Mon, 06 Jan 2020)


Log Message
Add WKWebView SPI to query _WKMediaMutedState
https://bugs.webkit.org/show_bug.cgi?id=205789


Patch by Luming Yin  on 2020-01-06
Reviewed by Eric Carlson.

Add plumbing for clients to query the media muted state on WKWebView.

* SourcesCocoa.txt:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _mediaMutedState]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/Cocoa/MediaUtilities.h: Renamed from Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.h.
* UIProcess/Cocoa/MediaUtilities.mm: Renamed from Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.mm.
(WebKit::toWKMediaCaptureState):
(WebKit::toWKMediaMutedState):
* UIProcess/Cocoa/UIDelegate.mm:
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::mutedStateFlags const):
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/UIProcess/Cocoa/MediaUtilities.h
trunk/Source/WebKit/UIProcess/Cocoa/MediaUtilities.mm


Removed Paths

trunk/Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.h
trunk/Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (254074 => 254075)

--- trunk/Source/WebKit/ChangeLog	2020-01-06 20:11:20 UTC (rev 254074)
+++ trunk/Source/WebKit/ChangeLog	2020-01-06 20:29:49 UTC (rev 254075)
@@ -1,3 +1,26 @@
+2020-01-06  Luming Yin  
+
+Add WKWebView SPI to query _WKMediaMutedState
+https://bugs.webkit.org/show_bug.cgi?id=205789
+
+
+Reviewed by Eric Carlson.
+
+Add plumbing for clients to query the media muted state on WKWebView.
+
+* SourcesCocoa.txt:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _mediaMutedState]):
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+* UIProcess/Cocoa/MediaUtilities.h: Renamed from Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.h.
+* UIProcess/Cocoa/MediaUtilities.mm: Renamed from Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.mm.
+(WebKit::toWKMediaCaptureState):
+(WebKit::toWKMediaMutedState):
+* UIProcess/Cocoa/UIDelegate.mm:
+* UIProcess/WebPageProxy.h:
+(WebKit::WebPageProxy::mutedStateFlags const):
+* WebKit.xcodeproj/project.pbxproj:
+
 2020-01-05  Dean Jackson  
 
 Rename GraphicsContext3D to GraphicsContextGL


Modified: trunk/Source/WebKit/SourcesCocoa.txt (254074 => 254075)

--- trunk/Source/WebKit/SourcesCocoa.txt	2020-01-06 20:11:20 UTC (rev 254074)
+++ trunk/Source/WebKit/SourcesCocoa.txt	2020-01-06 20:29:49 UTC (rev 254075)
@@ -367,7 +367,7 @@
 UIProcess/Cocoa/GlobalFindInPageState.mm
 UIProcess/Cocoa/IconLoadingDelegate.mm
 UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm
-UIProcess/Cocoa/MediaCaptureUtilities.mm
+UIProcess/Cocoa/MediaUtilities.mm
 UIProcess/Cocoa/NavigationState.mm
 UIProcess/Cocoa/PageClientImplCocoa.mm
 UIProcess/Cocoa/PlaybackSessionManagerProxy.mm


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (254074 => 254075)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2020-01-06 20:11:20 UTC (rev 254074)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2020-01-06 20:29:49 UTC (rev 254075)
@@ -38,7 +38,7 @@
 #import "IconLoadingDelegate.h"
 #import "LegacySessionStateCoding.h"
 #import "Logging.h"
-#import "MediaCaptureUtilities.h"
+#import "MediaUtilities.h"
 #import "NavigationState.h"
 #import "ObjCObjectGraph.h"
 #import "PageClient.h"
@@ -1737,6 +1737,11 @@
 #endif
 }
 
+- (_WKMediaMutedState)_mediaMutedState
+{
+return WebKit::toWKMediaMutedState(_page->mutedStateFlags());
+}
+
 - (void)_closeAllMediaPresentations
 {
 #if ENABLE(FULLSCREEN_API)


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h (254074 => 254075)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h	2020-01-06 20:11:20 UTC (rev 254074)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h	2020-01-06 20:29:49 UTC (rev 254075)
@@ -296,6 +296,7 @@
 @property (nonatomic, readonly) BOOL _isInFullscreen WK_API_AVAILABLE(macos(10.12.3));
 
 @property (nonatomic, readonly) _WKMediaCaptureState _mediaCaptureState WK_API_AVAILABLE(macos(10.15), ios(13.0));
+@property (nonatomic, readonly) _WKMediaMutedState _mediaMutedState WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 - (void)_setPageMuted:(_WKMediaMutedState)mutedState WK_API_AVAILABLE(macos(10.13), ios(11.0));
 


Deleted: trunk/Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.h (254074 => 254075)

---

[webkit-changes] [254074] trunk/LayoutTests

2020-01-06 Thread simon . fraser

Title: [254074] trunk/LayoutTests








Revision 254074
Author simon.fra...@apple.com
Date 2020-01-06 12:11:20 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1
https://bugs.webkit.org/show_bug.cgi?id=205810

Unreviewed test gardening. Page Overlay test in WK1 now dump one or more repaint rects after r254042.


* platform/mac-wk1/pageoverlay/overlay-installation-expected.txt:
* platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt:
* platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt:
* platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt:
* platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-installation-expected.txt
trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt
trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt
trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt
trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (254073 => 254074)

--- trunk/LayoutTests/ChangeLog	2020-01-06 19:54:45 UTC (rev 254073)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 20:11:20 UTC (rev 254074)
@@ -1,3 +1,16 @@
+2020-01-06  Simon Fraser  
+
+REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1
+https://bugs.webkit.org/show_bug.cgi?id=205810
+
+Unreviewed test gardening. Page Overlay test in WK1 now dump one or more repaint rects after r254042.
+
+* platform/mac-wk1/pageoverlay/overlay-installation-expected.txt:
+* platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt:
+* platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt:
+* platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt:
+* platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt:
+
 2020-01-06  Truitt Savell  
 
 REGRESSION: [ Catalina wk1 ] editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html is failing


Modified: trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-installation-expected.txt (254073 => 254074)

--- trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-installation-expected.txt	2020-01-06 19:54:45 UTC (rev 254073)
+++ trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-installation-expected.txt	2020-01-06 20:11:20 UTC (rev 254074)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 0, 800, 600)
 View-relative:
 (GraphicsLayer
   (children 1


Modified: trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt (254073 => 254074)

--- trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt	2020-01-06 19:54:45 UTC (rev 254073)
+++ trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt	2020-01-06 20:11:20 UTC (rev 254074)
@@ -1,3 +1,7 @@
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (512, 512, 512, 512)
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 512, 512, 512)
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (512, 0, 512, 512)
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (0, 0, 512, 512)
 View-relative:
 (GraphicsLayer
   (children 1


Modified: trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt (254073 => 254074)

--- trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt	2020-01-06 19:54:45 UTC (rev 254073)
+++ trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt	2020-01-06 20:11:20 UTC (rev 254074)
@@ -1,3 +1,7 @@
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (4608, 4608, 400, 408)
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (4096, 4608, 512, 408)
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (4608, 4096, 400, 512)
+CONSOLE MESSAGE: MockPageOverlayClient::drawRect dirtyRect (4096, 4096, 512, 512)
 View-relative:
 (GraphicsLayer
   (children 1


Modified: trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt (254073 => 254074)

--- trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt	2020-01-06 19:54:45 UTC (rev 254073)
+++ trunk/LayoutTests/platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt	2020-01-06 20:11:20 UTC (rev 254074)
@@ -1,6 +1,7 @@
 CONSOLE MESSAGE: line 17: MockPageOverlayClient::mouseEvent location (105, 495)
 CONSOLE MESSAGE: line 18: MockPageOverlayClient::mouseEvent location (105, 495)
 CONSOLE MESSAGE: line 18: MockPageOverlayClient::mouseEvent location (105, 495)
+CONSOLE MESSAGE:

[webkit-changes] [254073] branches/safari-608-branch/Source/WebCore

2020-01-06 Thread alancoon

Title: [254073] branches/safari-608-branch/Source/WebCore








Revision 254073
Author alanc...@apple.com
Date 2020-01-06 11:54:45 -0800 (Mon, 06 Jan 2020)


Log Message
Protect ServiceWorker::postMessage from a null execState
https://bugs.webkit.org/show_bug.cgi?id=205394


Reviewed by Chris Dumez.

Crash logs indicate null pointer crashes.
We should return early in that case.

* workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::postMessage):

Modified Paths

branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/workers/service/ServiceWorker.cpp




Diff

Modified: branches/safari-608-branch/Source/WebCore/ChangeLog (254072 => 254073)

--- branches/safari-608-branch/Source/WebCore/ChangeLog	2020-01-06 19:47:47 UTC (rev 254072)
+++ branches/safari-608-branch/Source/WebCore/ChangeLog	2020-01-06 19:54:45 UTC (rev 254073)
@@ -1,3 +1,17 @@
+2019-12-18  youenn fablet  
+
+Protect ServiceWorker::postMessage from a null execState
+https://bugs.webkit.org/show_bug.cgi?id=205394
+
+
+Reviewed by Chris Dumez.
+
+Crash logs indicate null pointer crashes.
+We should return early in that case.
+
+* workers/service/ServiceWorker.cpp:
+(WebCore::ServiceWorker::postMessage):
+
 2019-12-18  Dan Robson  
 
 Cherry-pick r253654. rdar://problem/58049166


Modified: branches/safari-608-branch/Source/WebCore/workers/service/ServiceWorker.cpp (254072 => 254073)

--- branches/safari-608-branch/Source/WebCore/workers/service/ServiceWorker.cpp	2020-01-06 19:47:47 UTC (rev 254072)
+++ branches/safari-608-branch/Source/WebCore/workers/service/ServiceWorker.cpp	2020-01-06 19:54:45 UTC (rev 254073)
@@ -102,6 +102,8 @@
 
 auto* execState = context.execState();
 ASSERT(execState);
+if (!execState)
+return Exception { InvalidStateError };
 
 Vector> ports;
 auto messageData = SerializedScriptValue::create(*execState, messageValue, WTFMove(transfer), ports, SerializationContext::WorkerPostMessage);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254072] branches/safari-608-branch/Source

2020-01-06 Thread alancoon

Title: [254072] branches/safari-608-branch/Source








Revision 254072
Author alanc...@apple.com
Date 2020-01-06 11:47:47 -0800 (Mon, 06 Jan 2020)


Log Message
Versioning.

Modified Paths

branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig (254071 => 254072)

--- branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-06 19:32:44 UTC (rev 254071)
+++ branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-06 19:47:47 UTC (rev 254072)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (254071 => 254072)

--- branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-06 19:32:44 UTC (rev 254071)
+++ branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-06 19:47:47 UTC (rev 254072)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig (254071 => 254072)

--- branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2020-01-06 19:32:44 UTC (rev 254071)
+++ branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2020-01-06 19:47:47 UTC (rev 254072)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (254071 => 254072)

--- branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-06 19:32:44 UTC (rev 254071)
+++ branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-06 19:47:47 UTC (rev 254072)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (254071 => 254072)

--- branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-01-06 19:32:44 UTC (rev 254071)
+++ branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-01-06 19:47:47 UTC (rev 254072)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig (254071 => 254072)

--- branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2020-01-06 19:32:44 UTC (rev 254071)
+++ branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2020-01-06 19:47:47 UTC (rev 254072)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (254071 => 254072)

--- branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2020-01-06 19:32:44 UTC (rev 254071)
+++ branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2020-01-06 19:47:47 UTC (rev 254072)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 5;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254071] branches/safari-609.1.14-branch/

2020-01-06 Thread alancoon

Title: [254071] branches/safari-609.1.14-branch/








Revision 254071
Author alanc...@apple.com
Date 2020-01-06 11:32:44 -0800 (Mon, 06 Jan 2020)


Log Message
New branch.

Added Paths

branches/safari-609.1.14-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254070] trunk

2020-01-06 Thread shvaikalesh

Title: [254070] trunk








Revision 254070
Author shvaikal...@gmail.com
Date 2020-01-06 11:31:01 -0800 (Mon, 06 Jan 2020)


Log Message
Proxy's [[OwnPropertyKeys]] is incorrect in DontEnumPropertiesMode::Exclude
https://bugs.webkit.org/show_bug.cgi?id=203818

Reviewed by Keith Miller.

JSTests:

Stress test was failing because "ownKeys" trap didn't return non-configurable
"prototype" property of Proxy's target, violating an invariant.

* stress/proxy-get-own-property-names-should-not-clear-previous-results.js:
* test262/expectations.yaml: Mark 8 test cases as passing.

Source/_javascript_Core:

This change fixes two spec compatibility issues:

1. If Object.keys is called on Proxy w/o "ownKeys" trap, filtering non-enumerable
properties are not observed by "getOwnPropertyDescriptor" trap.
(step 4 of https://tc39.es/ecma262/#sec-enumerableownpropertynames)

2. If Object.keys is called on Proxy with "ownKeys" trap, non-enumerable
properties of Proxy's target are ignored during invariants validation.
(step 11 of https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys)

Instead of extracting DontEnum filtering to lambda function, a wrapper method for
ProxyObject::performGetOwnPropertyNames was introduced to avoid creating &
filling intermediate PropertyNameArray instance (in case of DontEnumPropertiesMode::Include)
and avoid having inner EnumerationMode in ProxyObject::performGetOwnPropertyNames.

* runtime/ProxyObject.cpp:
(JSC::ProxyObject::performGetOwnPropertyNames):
(JSC::ProxyObject::performGetOwnEnumerablePropertyNames):
(JSC::ProxyObject::getOwnPropertyNames):
* runtime/ProxyObject.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/proxy-get-own-property-names-should-not-clear-previous-results.js
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ProxyObject.cpp
trunk/Source/_javascript_Core/runtime/ProxyObject.h




Diff

Modified: trunk/JSTests/ChangeLog (254069 => 254070)

--- trunk/JSTests/ChangeLog	2020-01-06 19:27:21 UTC (rev 254069)
+++ trunk/JSTests/ChangeLog	2020-01-06 19:31:01 UTC (rev 254070)
@@ -1,3 +1,16 @@
+2020-01-06  Alexey Shvayka  
+
+Proxy's [[OwnPropertyKeys]] is incorrect in DontEnumPropertiesMode::Exclude
+https://bugs.webkit.org/show_bug.cgi?id=203818
+
+Reviewed by Keith Miller.
+
+Stress test was failing because "ownKeys" trap didn't return non-configurable
+"prototype" property of Proxy's target, violating an invariant.
+
+* stress/proxy-get-own-property-names-should-not-clear-previous-results.js:
+* test262/expectations.yaml: Mark 8 test cases as passing.
+
 2020-01-04  Alexey Shvayka  
 
 JSON.parse should initialize wrapper object with [[DefineOwnProperty]]


Modified: trunk/JSTests/stress/proxy-get-own-property-names-should-not-clear-previous-results.js (254069 => 254070)

--- trunk/JSTests/stress/proxy-get-own-property-names-should-not-clear-previous-results.js	2020-01-06 19:27:21 UTC (rev 254069)
+++ trunk/JSTests/stress/proxy-get-own-property-names-should-not-clear-previous-results.js	2020-01-06 19:31:01 UTC (rev 254070)
@@ -5,7 +5,7 @@
 
 a = {defineProperties:Object};
 function opt() {
-a.__proto__ = new Proxy(Object,{ownKeys:opt});
+a.__proto__ = new Proxy({}, {ownKeys:opt});
 return [];
 }
 for(var i=0;i<400;i=i+1) {


Modified: trunk/JSTests/test262/expectations.yaml (254069 => 254070)

--- trunk/JSTests/test262/expectations.yaml	2020-01-06 19:27:21 UTC (rev 254069)
+++ trunk/JSTests/test262/expectations.yaml	2020-01-06 19:31:01 UTC (rev 254070)
@@ -1183,18 +1183,6 @@
 test/built-ins/Object/internals/DefineOwnProperty/consistent-value-regexp-dollar1.js:
   default: 'Test262Error: Expected SameValue(«», «x») to be true'
   strict mode: 'Test262Error: Expected SameValue(«», «x») to be true'
-test/built-ins/Object/keys/property-traps-order-with-proxied-array.js:
-  default: 'Test262Error: Expected [ownKeys, getOwnPropertyDescriptor] and [ownKeys] to have the same contents. '
-  strict mode: 'Test262Error: Expected [ownKeys, getOwnPropertyDescriptor] and [ownKeys] to have the same contents. '
-test/built-ins/Object/keys/proxy-non-enumerable-prop-invariant-1.js:
-  default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
-  strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
-test/built-ins/Object/keys/proxy-non-enumerable-prop-invariant-2.js:
-  default: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
-  strict mode: 'Test262Error: Expected a TypeError to be thrown but no exception was thrown at all'
-test/built-ins/Object/keys/proxy-non-enumerable-prop-invariant-3.js:
-  default: "TypeError: Proxy handler's 'ownKeys' method returned a key that was not present in its non-extensible target"
-  strict mode: "TypeError: Proxy handler's 'ownKeys' method returned

[webkit-changes] [254069] branches/safari-609-branch/

2020-01-06 Thread alancoon

Title: [254069] branches/safari-609-branch/








Revision 254069
Author alanc...@apple.com
Date 2020-01-06 11:27:21 -0800 (Mon, 06 Jan 2020)


Log Message
New branch.

Added Paths

branches/safari-609-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254068] trunk/Source

2020-01-06 Thread alancoon

Title: [254068] trunk/Source








Revision 254068
Author alanc...@apple.com
Date 2020-01-06 11:18:04 -0800 (Mon, 06 Jan 2020)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (254067 => 254068)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-06 19:16:18 UTC (rev 254067)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-06 19:18:04 UTC (rev 254068)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 609;
+MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (254067 => 254068)

--- trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-01-06 19:16:18 UTC (rev 254067)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-01-06 19:18:04 UTC (rev 254068)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 609;
+MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (254067 => 254068)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-06 19:16:18 UTC (rev 254067)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-06 19:18:04 UTC (rev 254068)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 609;
+MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (254067 => 254068)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2020-01-06 19:16:18 UTC (rev 254067)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2020-01-06 19:18:04 UTC (rev 254068)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 609;
+MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (254067 => 254068)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-06 19:16:18 UTC (rev 254067)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-06 19:18:04 UTC (rev 254068)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 609;
+MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (254067 => 254068)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-01-06 19:16:18 UTC (rev 254067)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-01-06 19:18:04 UTC (rev 254068)
@@ -1,6 +1,6 @@
-MAJOR_VERSION = 609;
+MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 14;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (254067 => 254068)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2020-01-06 19:16:18 UTC (rev 254067)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2020-01-06 19:18:04 UTC (rev 254068)
@@ -21,9 +21,9 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
-MAJOR_VERSION = 609;

[webkit-changes] [254067] trunk/Source/WebCore

2020-01-06 Thread pvollan

Title: [254067] trunk/Source/WebCore








Revision 254067
Author pvol...@apple.com
Date 2020-01-06 11:16:18 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION(r247626): Introduced memory regression
https://bugs.webkit.org/show_bug.cgi?id=205815

Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::prewarmGlobally):
(WebCore::fontFamiliesForPrewarming): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254066 => 254067)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 19:00:42 UTC (rev 254066)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 19:16:18 UTC (rev 254067)
@@ -1,3 +1,14 @@
+2020-01-06  Per Arne Vollan  
+
+REGRESSION(r247626): Introduced memory regression
+https://bugs.webkit.org/show_bug.cgi?id=205815
+
+Unreviewed rollout of https://trac.webkit.org/changeset/247626/webkit.
+
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(WebCore::FontCache::prewarmGlobally):
+(WebCore::fontFamiliesForPrewarming): Deleted.
+
 2020-01-06  Yusuke Suzuki  
 
 [WebCore] Shrink sizeof(RuleFeature)


Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (254066 => 254067)

--- trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2020-01-06 19:00:42 UTC (rev 254066)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2020-01-06 19:16:18 UTC (rev 254067)
@@ -1688,9 +1688,12 @@
 });
 }
 
-static Vector& fontFamiliesForPrewarming()
+void FontCache::prewarmGlobally()
 {
-static NeverDestroyed> families = std::initializer_list {
+if (MemoryPressureHandler::singleton().isUnderMemoryPressure())
+return;
+
+Vector families = std::initializer_list {
 ".SF NS Text"_s,
 ".SF NS Display"_s,
 "Arial"_s,
@@ -1700,17 +1703,9 @@
 "Times"_s,
 "Times New Roman"_s,
 };
-return families;
-}
 
-void FontCache::prewarmGlobally()
-{
-if (MemoryPressureHandler::singleton().isUnderMemoryPressure())
-return;
-
 FontCache::PrewarmInformation prewarmInfo;
-prewarmInfo.seenFamilies = fontFamiliesForPrewarming();
-prewarmInfo.fontNamesRequiringSystemFallback = fontFamiliesForPrewarming();
+prewarmInfo.seenFamilies = WTFMove(families);
 FontCache::singleton().prewarm(prewarmInfo);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254066] trunk/LayoutTests

2020-01-06 Thread tsavell

Title: [254066] trunk/LayoutTests








Revision 254066
Author tsav...@apple.com
Date 2020-01-06 11:00:42 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION: [ Catalina wk1 ] editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205814

unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (254065 => 254066)

--- trunk/LayoutTests/ChangeLog	2020-01-06 18:59:35 UTC (rev 254065)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 19:00:42 UTC (rev 254066)
@@ -1,5 +1,14 @@
 2020-01-06  Truitt Savell  
 
+REGRESSION: [ Catalina wk1 ] editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205814
+
+unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
+2020-01-06  Truitt Savell  
+
 REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=205808
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (254065 => 254066)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-06 18:59:35 UTC (rev 254065)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-06 19:00:42 UTC (rev 254066)
@@ -842,3 +842,5 @@
 webkit.org/b/205412 [ Mojave Debug ] webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Timeout ]
 
 webkit.org/b/205410 [ Debug ] accessibility/mac/expanded-notification.html [ Failure ]
+
+webkit.org/b/205814 [ Catalina ] editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html  [ Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254065] trunk/Source/WebCore

2020-01-06 Thread ysuzuki

Title: [254065] trunk/Source/WebCore








Revision 254065
Author ysuz...@apple.com
Date 2020-01-06 10:59:35 -0800 (Mon, 06 Jan 2020)


Log Message
[WebCore] Shrink sizeof(RuleFeature)
https://bugs.webkit.org/show_bug.cgi?id=205774

Reviewed by Dean Jackson.

We noticed that Vector is frequently allocated and kept. While sizeof(RuleFeature) is 32,

1. RuleFeature::invalidationSelector is nullptr basically. It is used only for some specific cases.
2. RuleFeature::selectorIndex and RuleFeature::selectorListIndex is `unsigned`. But they never exceed `uint16_t` since
   both values are derived from RuleData::m_selectorIndex and RuleData::m_selectorListIndex and both are `uint16_t` size.
3. Optional takes 8 bytes since sizeof(MatchElement) is 4. But we can make it 1 byte.

Given the above observations, this patch introduced RuleFeatureWithInvalidationSelector, which is RuleFeature + invalidationSelector.
And keep using RuleFeature if invalidationSelector is unnecessary. By applying (2) and (3)'s optimizations, we can now make
sizeof(RuleFeature) 16, 50% reduction.

No behavior change.

* style/RuleData.h:
* style/RuleFeature.cpp:
(WebCore::Style::RuleFeature::RuleFeature):
(WebCore::Style::RuleFeatureSet::collectFeatures):
(WebCore::Style::RuleFeatureSet::add):
* style/RuleFeature.h:
(WebCore::Style::RuleFeatureWithInvalidationSelector::RuleFeatureWithInvalidationSelector):
* style/StyleScopeRuleSets.cpp:
(WebCore::Style::ensureInvalidationRuleSets):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/RuleData.h
trunk/Source/WebCore/style/RuleFeature.cpp
trunk/Source/WebCore/style/RuleFeature.h
trunk/Source/WebCore/style/StyleScopeRuleSets.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254064 => 254065)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 18:52:42 UTC (rev 254064)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 18:59:35 UTC (rev 254065)
@@ -1,3 +1,33 @@
+2020-01-06  Yusuke Suzuki  
+
+[WebCore] Shrink sizeof(RuleFeature)
+https://bugs.webkit.org/show_bug.cgi?id=205774
+
+Reviewed by Dean Jackson.
+
+We noticed that Vector is frequently allocated and kept. While sizeof(RuleFeature) is 32,
+
+1. RuleFeature::invalidationSelector is nullptr basically. It is used only for some specific cases.
+2. RuleFeature::selectorIndex and RuleFeature::selectorListIndex is `unsigned`. But they never exceed `uint16_t` since
+   both values are derived from RuleData::m_selectorIndex and RuleData::m_selectorListIndex and both are `uint16_t` size.
+3. Optional takes 8 bytes since sizeof(MatchElement) is 4. But we can make it 1 byte.
+
+Given the above observations, this patch introduced RuleFeatureWithInvalidationSelector, which is RuleFeature + invalidationSelector.
+And keep using RuleFeature if invalidationSelector is unnecessary. By applying (2) and (3)'s optimizations, we can now make
+sizeof(RuleFeature) 16, 50% reduction.
+
+No behavior change.
+
+* style/RuleData.h:
+* style/RuleFeature.cpp:
+(WebCore::Style::RuleFeature::RuleFeature):
+(WebCore::Style::RuleFeatureSet::collectFeatures):
+(WebCore::Style::RuleFeatureSet::add):
+* style/RuleFeature.h:
+(WebCore::Style::RuleFeatureWithInvalidationSelector::RuleFeatureWithInvalidationSelector):
+* style/StyleScopeRuleSets.cpp:
+(WebCore::Style::ensureInvalidationRuleSets):
+
 2020-01-05  Dean Jackson  
 
 Rename GraphicsContext3D to GraphicsContextGL


Modified: trunk/Source/WebCore/style/RuleData.h (254064 => 254065)

--- trunk/Source/WebCore/style/RuleData.h	2020-01-06 18:52:42 UTC (rev 254064)
+++ trunk/Source/WebCore/style/RuleData.h	2020-01-06 18:59:35 UTC (rev 254065)
@@ -75,6 +75,7 @@
 
 private:
 RefPtr m_styleRule;
+// Keep in sync with RuleFeature's selectorIndex and selectorListIndex size.
 unsigned m_selectorIndex : 16;
 unsigned m_selectorListIndex : 16;
 // This number was picked fairly arbitrarily. We can probably lower it if we need to.


Modified: trunk/Source/WebCore/style/RuleFeature.cpp (254064 => 254065)

--- trunk/Source/WebCore/style/RuleFeature.cpp	2020-01-06 18:52:42 UTC (rev 254064)
+++ trunk/Source/WebCore/style/RuleFeature.cpp	2020-01-06 18:59:35 UTC (rev 254065)
@@ -55,13 +55,14 @@
 return false;
 }
 
-RuleFeature::RuleFeature(const RuleData& ruleData, Optional matchElement, const CSSSelector* invalidationSelector)
+RuleFeature::RuleFeature(const RuleData& ruleData, Optional matchElement)
 : styleRule(())
 , selectorIndex(ruleData.selectorIndex())
 , selectorListIndex(ruleData.selectorListIndex())
 , matchElement(matchElement)
-, invalidationSelector(invalidationSelector)
 {
+ASSERT(selectorIndex == ruleData.selectorIndex());
+ASSERT(selectorListIndex == ruleData.selectorListIndex());
 }
 
 MatchElement RuleFeatureSet::computeNextMatchElement(MatchElement matchElement,

[webkit-changes] [254063] trunk/Source/WebKitLegacy/mac

2020-01-06 Thread commit-queue

Title: [254063] trunk/Source/WebKitLegacy/mac








Revision 254063
Author commit-qu...@webkit.org
Date 2020-01-06 10:39:58 -0800 (Mon, 06 Jan 2020)


Log Message
[Web Animations] Enable CSS Animations via Web Animations for WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=205791

Patch by Antoine Quint  on 2020-01-06
Reviewed by Dean Jackson.

It was an oversight that it had not been done along with the WebKit change.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (254062 => 254063)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2020-01-06 18:33:25 UTC (rev 254062)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2020-01-06 18:39:58 UTC (rev 254063)
@@ -1,3 +1,15 @@
+2020-01-06  Antoine Quint  
+
+[Web Animations] Enable CSS Animations via Web Animations for WebKitLegacy
+https://bugs.webkit.org/show_bug.cgi?id=205791
+
+Reviewed by Dean Jackson.
+
+It was an oversight that it had not been done along with the WebKit change.
+
+* WebView/WebPreferences.mm:
+(+[WebPreferences initialize]):
+
 2020-01-05  Simon Fraser  
 
 Fix a souce of WebKit1 test flakiness


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (254062 => 254063)

--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2020-01-06 18:33:25 UTC (rev 254062)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2020-01-06 18:39:58 UTC (rev 254063)
@@ -633,7 +633,7 @@
 @NO, WebKitDialogElementEnabledPreferenceKey,
 @NO, WebKitHighlightAPIEnabledPreferenceKey,
 @YES, WebKitModernMediaControlsEnabledPreferenceKey,
-@NO, WebKitWebAnimationsCSSIntegrationEnabledPreferenceKey,
+@YES, WebKitWebAnimationsCSSIntegrationEnabledPreferenceKey,
 
 #if ENABLE(WEBGL2)
 @NO, WebKitWebGL2EnabledPreferenceKey,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254062] trunk/Tools

2020-01-06 Thread commit-queue

Title: [254062] trunk/Tools








Revision 254062
Author commit-qu...@webkit.org
Date 2020-01-06 10:33:25 -0800 (Mon, 06 Jan 2020)


Log Message
Remove unused variable jsDriverArgs from script
https://bugs.webkit.org/show_bug.cgi?id=205797

Patch by Paulo Matos  on 2020-01-06
Reviewed by Žan Doberšek.

* Scripts/run-_javascript_core-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests




Diff

Modified: trunk/Tools/ChangeLog (254061 => 254062)

--- trunk/Tools/ChangeLog	2020-01-06 18:24:27 UTC (rev 254061)
+++ trunk/Tools/ChangeLog	2020-01-06 18:33:25 UTC (rev 254062)
@@ -1,5 +1,14 @@
 2020-01-06  Paulo Matos  
 
+Remove unused variable jsDriverArgs from script
+https://bugs.webkit.org/show_bug.cgi?id=205797
+
+Reviewed by Žan Doberšek.
+
+* Scripts/run-_javascript_core-tests:
+
+2020-01-06  Paulo Matos  
+
 Add support for passing test arguments in envvar TEST_JSC_ARGS
 https://bugs.webkit.org/show_bug.cgi?id=205800
 


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (254061 => 254062)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2020-01-06 18:24:27 UTC (rev 254061)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2020-01-06 18:33:25 UTC (rev 254062)
@@ -50,7 +50,6 @@
 my $root;
 my $showHelp;
 my @extraTests = ();
-my $jsDriverArgs;
 my $childProcesses;
 my $shellRunner;
 my $makeRunner;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254061] trunk/Source/WebInspectorUI

2020-01-06 Thread nvasilyev

Title: [254061] trunk/Source/WebInspectorUI








Revision 254061
Author nvasil...@apple.com
Date 2020-01-06 10:24:27 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide color picker
https://bugs.webkit.org/show_bug.cgi?id=205570


Reviewed by Brian Burg.

* UserInterface/Views/QuickConsole.js:
(WI.QuickConsole.prototype.set keyboardShortcutDisabled):
(WI.QuickConsole.prototype._toggleOrFocus):
Restore keyboardShortcutDisabled setter, which was removed in r218839 without any explanation.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (254060 => 254061)

--- trunk/Source/WebInspectorUI/ChangeLog	2020-01-06 18:08:17 UTC (rev 254060)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-01-06 18:24:27 UTC (rev 254061)
@@ -1,3 +1,16 @@
+2020-01-06  Nikita Vasilyev  
+
+REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide color picker
+https://bugs.webkit.org/show_bug.cgi?id=205570
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/QuickConsole.js:
+(WI.QuickConsole.prototype.set keyboardShortcutDisabled):
+(WI.QuickConsole.prototype._toggleOrFocus):
+Restore keyboardShortcutDisabled setter, which was removed in r218839 without any explanation.
+
 2020-01-06  Devin Rousso  
 
 Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js (254060 => 254061)

--- trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js	2020-01-06 18:08:17 UTC (rev 254060)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js	2020-01-06 18:24:27 UTC (rev 254061)
@@ -31,6 +31,7 @@
 
 this._toggleOrFocusKeyboardShortcut = new WI.KeyboardShortcut(null, WI.KeyboardShortcut.Key.Escape, this._toggleOrFocus.bind(this));
 this._toggleOrFocusKeyboardShortcut.implicitlyPreventsDefault = false;
+this._keyboardShortcutDisabled = false;
 
 this._automaticExecutionContextPathComponent = this._createExecutionContextPathComponent(null, WI.UIString("Auto"));
 this._updateAutomaticExecutionContextPathComponentTooltip();
@@ -101,6 +102,11 @@
 return this._navigationBar;
 }
 
+set keyboardShortcutDisabled(disabled)
+{
+this._keyboardShortcutDisabled = disabled;
+}
+
 closed()
 {
 WI.settings.consoleSavedResultAlias.removeEventListener(null, null, this);
@@ -446,6 +452,9 @@
 
 _toggleOrFocus(event)
 {
+if (this._keyboardShortcutDisabled)
+return;
+
 if (this.prompt.focused) {
 WI.toggleSplitConsole();
 event.preventDefault();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254060] trunk/LayoutTests

2020-01-06 Thread tsavell

Title: [254060] trunk/LayoutTests








Revision 254060
Author tsav...@apple.com
Date 2020-01-06 10:08:17 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205808

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (254059 => 254060)

--- trunk/LayoutTests/ChangeLog	2020-01-06 17:56:09 UTC (rev 254059)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 18:08:17 UTC (rev 254060)
@@ -1,5 +1,14 @@
 2020-01-06  Truitt Savell  
 
+REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205808
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2020-01-06  Truitt Savell  
+
 REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=205807
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (254059 => 254060)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-06 17:56:09 UTC (rev 254059)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-06 18:08:17 UTC (rev 254060)
@@ -927,3 +927,5 @@
 webkit.org/b/205301 [ Mojave+ ] inspector/canvas/requestShaderSource-webgpu.html [ Pass Failure ]
 
 webkit.org/b/171784 fast/shadow-dom/link-element-in-shadow-tree.html [ Pass Failure ]
+
+webkit.org/b/205808 fast/text/international/unicode-bidi-other-neutrals.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254059] trunk/LayoutTests

2020-01-06 Thread tsavell

Title: [254059] trunk/LayoutTests








Revision 254059
Author tsav...@apple.com
Date 2020-01-06 09:56:09 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205807

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (254058 => 254059)

--- trunk/LayoutTests/ChangeLog	2020-01-06 17:48:34 UTC (rev 254058)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 17:56:09 UTC (rev 254059)
@@ -1,3 +1,12 @@
+2020-01-06  Truitt Savell  
+
+REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205807
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2020-01-06  Zalan Bujtas  
 
 REGRESSION: [ Mojave ]  tables/mozilla_expected_failures/bugs/bug2479-5.html is failing


Modified: trunk/LayoutTests/platform/mac/TestExpectations (254058 => 254059)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-01-06 17:48:34 UTC (rev 254058)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-01-06 17:56:09 UTC (rev 254059)
@@ -1968,3 +1968,4 @@
 webkit.org/b/205757 webgl/1.0.3/conformance/textures/texture-upload-size.html [ Pass Timeout ]
 webkit.org/b/205756 webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader.html [ Pass Failure ]
 
+webkit.org/b/205807 [ Debug ] inspector/page/setBootstrapScript-main-frame.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254058] trunk/Source/WebInspectorUI

2020-01-06 Thread drousso

Title: [254058] trunk/Source/WebInspectorUI








Revision 254058
Author drou...@apple.com
Date 2020-01-06 09:48:34 -0800 (Mon, 06 Jan 2020)


Log Message
Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
https://bugs.webkit.org/show_bug.cgi?id=205659

Reviewed by Brian Burg.

Limit the height of the canvas and shader program tree a recording is selected.

* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
* UserInterface/Views/CanvasSidebarPanel.css:
(.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (254057 => 254058)

--- trunk/Source/WebInspectorUI/ChangeLog	2020-01-06 17:39:06 UTC (rev 254057)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-01-06 17:48:34 UTC (rev 254058)
@@ -1,3 +1,17 @@
+2020-01-06  Devin Rousso  
+
+Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
+https://bugs.webkit.org/show_bug.cgi?id=205659
+
+Reviewed by Brian Burg.
+
+Limit the height of the canvas and shader program tree a recording is selected.
+
+* UserInterface/Views/CanvasSidebarPanel.js:
+(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
+* UserInterface/Views/CanvasSidebarPanel.css:
+(.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.
+
 2019-12-21  Brian Burg  
 
 Web Inspector: add InspectedTargetTypes diagnostic event and related hooks


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css (254057 => 254058)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css	2020-01-06 17:39:06 UTC (rev 254057)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css	2020-01-06 17:48:34 UTC (rev 254058)
@@ -52,6 +52,13 @@
 overflow-y: scroll;
 }
 
+.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas {
+flex-shrink: 0;
+height: fit-content;
+max-height: 110px;
+overflow-y: auto;
+}
+
 .sidebar > .panel.navigation.canvas:not(.has-recordings) > .filter-bar,
 .sidebar > .panel.navigation.canvas:not(.has-recordings) > .content > :matches(.navigation-bar, .recording-content) {
 display: none;


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js (254057 => 254058)

--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js	2020-01-06 17:39:06 UTC (rev 254057)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js	2020-01-06 17:48:34 UTC (rev 254058)
@@ -498,6 +498,7 @@
 
 let hasRecordings = this._recording || (this._canvas && this._canvas.recordingCollection.size);
 this.element.classList.toggle("has-recordings", hasRecordings);
+this.element.classList.toggle("showing-recording", !!this._recording);
 if (!hasRecordings)
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254057] trunk/Tools

2020-01-06 Thread commit-queue

Title: [254057] trunk/Tools








Revision 254057
Author commit-qu...@webkit.org
Date 2020-01-06 09:39:06 -0800 (Mon, 06 Jan 2020)


Log Message
Add support for passing test arguments in envvar TEST_JSC_ARGS
https://bugs.webkit.org/show_bug.cgi?id=205800

Patch by Paulo Matos  on 2020-01-06
Reviewed by Žan Doberšek.

Similarly to what is done in build-jsc, we add support to pass
extra command line arguments in environment variable TEST_JSC_ARGS.

* Scripts/run-_javascript_core-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests




Diff

Modified: trunk/Tools/ChangeLog (254056 => 254057)

--- trunk/Tools/ChangeLog	2020-01-06 17:33:19 UTC (rev 254056)
+++ trunk/Tools/ChangeLog	2020-01-06 17:39:06 UTC (rev 254057)
@@ -1,3 +1,15 @@
+2020-01-06  Paulo Matos  
+
+Add support for passing test arguments in envvar TEST_JSC_ARGS
+https://bugs.webkit.org/show_bug.cgi?id=205800
+
+Reviewed by Žan Doberšek.
+
+Similarly to what is done in build-jsc, we add support to pass
+extra command line arguments in environment variable TEST_JSC_ARGS.
+
+* Scripts/run-_javascript_core-tests:
+
 2020-01-06  Per Arne Vollan  
 
 [iOS] Issue mach lookup extension to launch services daemon for Mail


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (254056 => 254057)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2020-01-06 17:33:19 UTC (rev 254056)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2020-01-06 17:39:06 UTC (rev 254057)
@@ -40,6 +40,7 @@
 use List::Util qw(min max);
 use POSIX;
 use webkitdirs;
+use Text::ParseWords;
 
 # determine configuration
 setConfiguration();
@@ -201,6 +202,9 @@
 }
 }
 
+# Additional environment parameters
+push @ARGV, parse_line('\s+', 0, $ENV{'TEST_JSC_ARGS'}) if ($ENV{'TEST_JSC_ARGS'});
+
 my $programName = basename($0);
 my $buildJSCDefault = $buildJSC ? "will check" : "will not check";
 my $testmasmDefault = defaultStringForTestState($runTestMasm);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254056] trunk/LayoutTests

2020-01-06 Thread zalan

Title: [254056] trunk/LayoutTests








Revision 254056
Author za...@apple.com
Date 2020-01-06 09:33:19 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION: [ Mojave ]  tables/mozilla_expected_failures/bugs/bug2479-5.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205805


Unreviewed.

Rebaseline after r254044.


* platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (254055 => 254056)

--- trunk/LayoutTests/ChangeLog	2020-01-06 17:09:02 UTC (rev 254055)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 17:33:19 UTC (rev 254056)
@@ -1,3 +1,15 @@
+2020-01-06  Zalan Bujtas  
+
+REGRESSION: [ Mojave ]  tables/mozilla_expected_failures/bugs/bug2479-5.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205805
+
+
+Unreviewed.
+
+Rebaseline after r254044.
+
+* platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
+
 2020-01-05  Simon Fraser  
 
 REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019'


Modified: trunk/LayoutTests/platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt (254055 => 254056)

--- trunk/LayoutTests/platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt	2020-01-06 17:09:02 UTC (rev 254055)
+++ trunk/LayoutTests/platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt	2020-01-06 17:33:19 UTC (rev 254056)
@@ -99,6 +99,7 @@
 RenderBlock {PRE} at (21,575) size 453x17 [border: (1px dotted #00)]
   RenderText {#text} at (1,1) size 40x15
 text run at (1,1) width 40: "  ..."
+text run at (40,1) width 1: " "
 RenderBlock {P} at (21,608) size 453x38 [border: (1px dotted #00)]
   RenderText {#text} at (1,1) size 419x36
 text run at (1,1) width 419: "The dotted borders and lines and the text in the left cell should be"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254055] trunk/Source/WebKit

2020-01-06 Thread commit-queue

Title: [254055] trunk/Source/WebKit








Revision 254055
Author commit-qu...@webkit.org
Date 2020-01-06 09:09:02 -0800 (Mon, 06 Jan 2020)


Log Message
Remove unused GlobalFrameID from NetworkCacheSpeculativeLoad
https://bugs.webkit.org/show_bug.cgi?id=205796

Patch by Rob Buis  on 2020-01-06
Reviewed by Chris Dumez.

Remove unused GlobalFrameID from NetworkCacheSpeculativeLoad
and NetworkCache::update.

No change in behavior.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::update):
* NetworkProcess/cache/NetworkCache.h:
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
(WebKit::NetworkCache::SpeculativeLoad::didReceiveResponse):
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp
trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (254054 => 254055)

--- trunk/Source/WebKit/ChangeLog	2020-01-06 16:44:32 UTC (rev 254054)
+++ trunk/Source/WebKit/ChangeLog	2020-01-06 17:09:02 UTC (rev 254055)
@@ -1,3 +1,25 @@
+2020-01-06  Rob Buis  
+
+Remove unused GlobalFrameID from NetworkCacheSpeculativeLoad
+https://bugs.webkit.org/show_bug.cgi?id=205796
+
+Reviewed by Chris Dumez.
+
+Remove unused GlobalFrameID from NetworkCacheSpeculativeLoad
+and NetworkCache::update.
+
+No change in behavior.
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::didReceiveResponse):
+* NetworkProcess/cache/NetworkCache.cpp:
+(WebKit::NetworkCache::Cache::update):
+* NetworkProcess/cache/NetworkCache.h:
+* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
+(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
+(WebKit::NetworkCache::SpeculativeLoad::didReceiveResponse):
+* NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
+
 2020-01-06  Per Arne Vollan  
 
 [iOS] Issue mach lookup extension to launch services daemon for Mail


Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (254054 => 254055)

--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp	2020-01-06 16:44:32 UTC (rev 254054)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp	2020-01-06 17:09:02 UTC (rev 254055)
@@ -496,7 +496,7 @@
 bool validationSucceeded = m_response.httpStatusCode() == 304; // 304 Not Modified
 RELEASE_LOG_IF_ALLOWED("didReceiveResponse: Received revalidation response (validationSucceeded=%d, wasOriginalRequestConditional=%d)", validationSucceeded, originalRequest().isConditional());
 if (validationSucceeded) {
-m_cacheEntryForValidation = m_cache->update(originalRequest(), globalFrameID(), *m_cacheEntryForValidation, m_response);
+m_cacheEntryForValidation = m_cache->update(originalRequest(), *m_cacheEntryForValidation, m_response);
 // If the request was conditional then this revalidation was not triggered by the network cache and we pass the 304 response to WebCore.
 if (originalRequest().isConditional())
 m_cacheEntryForValidation = nullptr;


Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp (254054 => 254055)

--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp	2020-01-06 16:44:32 UTC (rev 254054)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp	2020-01-06 17:09:02 UTC (rev 254055)
@@ -491,7 +491,7 @@
 return cacheEntry;
 }
 
-std::unique_ptr Cache::update(const WebCore::ResourceRequest& originalRequest, const GlobalFrameID& frameID, const Entry& existingEntry, const WebCore::ResourceResponse& validatingResponse)
+std::unique_ptr Cache::update(const WebCore::ResourceRequest& originalRequest, const Entry& existingEntry, const WebCore::ResourceResponse& validatingResponse)
 {
 LOG(NetworkCache, "(NetworkProcess) updating %s", originalRequest.url().string().latin1().data());
 


Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h (254054 => 254055)

--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h	2020-01-06 16:44:32 UTC (rev 254054)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h	2020-01-06 17:09:02 UTC (rev 254055)
@@ -143,7 +143,7 @@
 void retrieve(const WebCore::ResourceRequest&, const GlobalFrameID&, RetrieveCompletionHandler&&);
 std::unique_ptr store(const WebCore::ResourceRequest&, const WebCore::ResourceResponse&, RefPtr&&, Function&& = nullptr);
 std::unique_ptr storeRedirect(const WebCore::ResourceRequest&,

[webkit-changes] [254054] trunk

2020-01-06 Thread simon . fraser

Title: [254054] trunk








Revision 254054
Author simon.fra...@apple.com
Date 2020-01-06 08:44:32 -0800 (Mon, 06 Jan 2020)


Log Message
REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019'
https://bugs.webkit.org/show_bug.cgi?id=205694


Reviewed by Zalan Bujtas.

Source/WebCore:

After r252724, which separated 'used' from 'specified' z-index in style, we need to copy
the specified to the used z-index in animated styles, while preserving the existing 'forceStackingContext'
behavior which set the used z-index to 0.

Do so by creating Adjuster::adjustAnimatedStyle(), which is called from TreeResolver::createAnimatedElementUpdate()
if any animations could have affected the style. We need to pass back information about whether the animation should
force stacking context.

Test: animations/z-index-in-keyframe.html

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::apply):
* animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::triggersStackingContext const):
* dom/Element.cpp:
(WebCore::Element::applyKeyframeEffects):
* dom/Element.h:
* page/animation/CSSAnimationController.h:
(): Deleted.
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::animate):
* style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustAnimatedStyle):
* style/StyleAdjuster.h:
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

LayoutTests:

* animations/z-index-in-keyframe-expected.html: Added.
* animations/z-index-in-keyframe.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp
trunk/Source/WebCore/animation/KeyframeEffect.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/page/animation/AnimationBase.h
trunk/Source/WebCore/page/animation/CSSAnimationController.h
trunk/Source/WebCore/page/animation/CompositeAnimation.cpp
trunk/Source/WebCore/style/StyleAdjuster.cpp
trunk/Source/WebCore/style/StyleAdjuster.h
trunk/Source/WebCore/style/StyleTreeResolver.cpp


Added Paths

trunk/LayoutTests/animations/z-index-in-keyframe-expected.html
trunk/LayoutTests/animations/z-index-in-keyframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (254053 => 254054)

--- trunk/LayoutTests/ChangeLog	2020-01-06 16:36:56 UTC (rev 254053)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 16:44:32 UTC (rev 254054)
@@ -1,3 +1,14 @@
+2020-01-05  Simon Fraser  
+
+REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019'
+https://bugs.webkit.org/show_bug.cgi?id=205694
+
+
+Reviewed by Zalan Bujtas.
+
+* animations/z-index-in-keyframe-expected.html: Added.
+* animations/z-index-in-keyframe.html: Added.
+
 2020-01-06  Chris Dumez  
 
 Regression r254029: imported/w3c/web-platform-tests/html/dom/idlharness.https.html is failing


Added: trunk/LayoutTests/animations/z-index-in-keyframe-expected.html (0 => 254054)

--- trunk/LayoutTests/animations/z-index-in-keyframe-expected.html	(rev 0)
+++ trunk/LayoutTests/animations/z-index-in-keyframe-expected.html	2020-01-06 16:44:32 UTC (rev 254054)
@@ -0,0 +1,39 @@
+
+
+
+
+.container {
+position: absolute;
+width: 300px;
+height: 300px;
+border: 1px solid black;
+}
+
+.box {
+position: absolute;
+width: 200px;
+height: 200px;
+}
+
+.bottom {
+left: 0px;
+top: 0px;
+background-color: orange;
+}
+
+.top {
+left: 100px;
+top: 100px;
+background-color: green;
+z-index: -1;
+opacity: 0.8;
+}
+
+
+
+
+
+
+
+
+


Added: trunk/LayoutTests/animations/z-index-in-keyframe.html (0 => 254054)

--- trunk/LayoutTests/animations/z-index-in-keyframe.html	(rev 0)
+++ trunk/LayoutTests/animations/z-index-in-keyframe.html	2020-01-06 16:44:32 UTC (rev 254054)
@@ -0,0 +1,59 @@
+
+
+
+
+.container {
+position: absolute;
+width: 300px;
+height: 300px;
+border: 1px solid black;
+}
+
+.box {
+position: absolute;
+width: 200px;
+height: 200px;
+}
+
+.bottom {
+left: 0px;
+top: 0px;
+background-color: orange;
+}
+
+.top {
+left: 100px;
+top: 100px;
+background-color: green;
+animation: fade-out 30ms forwards;
+}
+
+@keyframes fade-out {
+0% {
+opacity: 1;
+}
+100% {
+z-index: -1;
+opacity: 0.8;
+}
+}
+
+

[webkit-changes] [254053] trunk/LayoutTests

2020-01-06 Thread cdumez

Title: [254053] trunk/LayoutTests








Revision 254053
Author cdu...@apple.com
Date 2020-01-06 08:36:56 -0800 (Mon, 06 Jan 2020)


Log Message
Regression r254029: imported/w3c/web-platform-tests/html/dom/idlharness.https.html is failing
https://bugs.webkit.org/show_bug.cgi?id=205803

Unreviewed, rebaseline WPT test on iOS after r254029, now that more checks are passing.

* platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (254052 => 254053)

--- trunk/LayoutTests/ChangeLog	2020-01-06 16:03:44 UTC (rev 254052)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 16:36:56 UTC (rev 254053)
@@ -1,3 +1,12 @@
+2020-01-06  Chris Dumez  
+
+Regression r254029: imported/w3c/web-platform-tests/html/dom/idlharness.https.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=205803
+
+Unreviewed, rebaseline WPT test on iOS after r254029, now that more checks are passing.
+
+* platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+
 2020-01-06  Per Arne Vollan  
 
 [iOS] Issue mach lookup extension to launch services daemon for Mail


Modified: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (254052 => 254053)

--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt	2020-01-06 16:03:44 UTC (rev 254052)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt	2020-01-06 16:36:56 UTC (rev 254053)
@@ -4261,13 +4261,13 @@
 PASS DataTransferItem interface: attribute type 
 PASS DataTransferItem interface: operation getAsString(FunctionStringCallback) 
 PASS DataTransferItem interface: operation getAsFile() 
-FAIL DragEvent interface: existence and properties of interface object assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
-FAIL DragEvent interface object length assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
-FAIL DragEvent interface object name assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
-FAIL DragEvent interface: existence and properties of interface prototype object assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
-FAIL DragEvent interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
-FAIL DragEvent interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
-FAIL DragEvent interface: attribute dataTransfer assert_own_property: self does not have own property "DragEvent" expected property "DragEvent" missing
+PASS DragEvent interface: existence and properties of interface object 
+PASS DragEvent interface object length 
+PASS DragEvent interface object name 
+PASS DragEvent interface: existence and properties of interface prototype object 
+PASS DragEvent interface: existence and properties of interface prototype object's "constructor" property 
+PASS DragEvent interface: existence and properties of interface prototype object's @@unscopables property 
+PASS DragEvent interface: attribute dataTransfer 
 PASS Window interface: existence and properties of interface object 
 PASS Window interface object length 
 PASS Window interface object name 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254052] trunk

2020-01-06 Thread pvollan

Title: [254052] trunk








Revision 254052
Author pvol...@apple.com
Date 2020-01-06 08:03:44 -0800 (Mon, 06 Jan 2020)


Log Message
[iOS] Issue mach lookup extension to launch services daemon for Mail
https://bugs.webkit.org/show_bug.cgi?id=205316

Reviewed by Brent Fulgham.

Source/WebCore:

Export function getting bundle identifier.

Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html

* platform/RuntimeApplicationChecks.h:

Source/WebKit:

Issue mach lookup extension to "com.apple.lsd.open" for Mail, since this service will be removed from the WebContent sandbox.

Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
* UIProcess/API/Cocoa/WKWebViewTesting.mm:
(+[WKWebView _setApplicationBundleIdentifier:]):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Add test option to set bundle identifier. Using this, WebKitTestRunner can pretend to be any client, e.g. Mail.

Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::setApplicationBundleIdentifier):

LayoutTests:

* fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt: Added.
* fast/sandbox/ios/sandbox-mach-lookup-mail.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/TestOptions.h
trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm


Added Paths

trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-mail.html




Diff

Modified: trunk/LayoutTests/ChangeLog (254051 => 254052)

--- trunk/LayoutTests/ChangeLog	2020-01-06 15:02:13 UTC (rev 254051)
+++ trunk/LayoutTests/ChangeLog	2020-01-06 16:03:44 UTC (rev 254052)
@@ -1,3 +1,13 @@
+2020-01-06  Per Arne Vollan  
+
+[iOS] Issue mach lookup extension to launch services daemon for Mail
+https://bugs.webkit.org/show_bug.cgi?id=205316
+
+Reviewed by Brent Fulgham.
+
+* fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt: Added.
+* fast/sandbox/ios/sandbox-mach-lookup-mail.html: Added.
+
 2020-01-05  Zalan Bujtas  
 
 [SLL] Generate runs for preserved new lines


Added: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt (0 => 254052)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt	2020-01-06 16:03:44 UTC (rev 254052)
@@ -0,0 +1,7 @@
+Regression tests for mach lookup sandbox changes for Mail on iOS
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.lsd.open") is true
+


Added: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-mail.html (0 => 254052)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-mail.html	(rev 0)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-mail.html	2020-01-06 16:03:44 UTC (rev 254052)
@@ -0,0 +1,14 @@
+
+
+
+
+description('Regression tests for mach lookup sandbox changes for Mail on iOS');
+
+if (window.internals) {
+shouldBeTrue("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.lsd.open\")");
+}
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (254051 => 254052)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 15:02:13 UTC (rev 254051)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 16:03:44 UTC (rev 254052)
@@ -1,3 +1,16 @@
+2020-01-06  Per

[webkit-changes] [254051] trunk/Source

2020-01-06 Thread youenn

Title: [254051] trunk/Source








Revision 254051
Author you...@apple.com
Date 2020-01-06 07:02:13 -0800 (Mon, 06 Jan 2020)


Log Message
RemoteVideoSample::create does not need to take a MediaSample r value
https://bugs.webkit.org/show_bug.cgi?id=205793

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

* platform/graphics/RemoteVideoSample.cpp:
(WebCore::RemoteVideoSample::create):
* platform/graphics/RemoteVideoSample.h:

Source/WebKit:

* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/RemoteVideoSample.cpp
trunk/Source/WebCore/platform/graphics/RemoteVideoSample.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (254050 => 254051)

--- trunk/Source/WebCore/ChangeLog	2020-01-06 09:47:37 UTC (rev 254050)
+++ trunk/Source/WebCore/ChangeLog	2020-01-06 15:02:13 UTC (rev 254051)
@@ -1,3 +1,16 @@
+2020-01-06  Youenn Fablet  
+
+RemoteVideoSample::create does not need to take a MediaSample r value
+https://bugs.webkit.org/show_bug.cgi?id=205793
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+
+* platform/graphics/RemoteVideoSample.cpp:
+(WebCore::RemoteVideoSample::create):
+* platform/graphics/RemoteVideoSample.h:
+
 2020-01-06  youenn fablet  
 
 Implement RTC VTB encoders in GPUProcess


Modified: trunk/Source/WebCore/platform/graphics/RemoteVideoSample.cpp (254050 => 254051)

--- trunk/Source/WebCore/platform/graphics/RemoteVideoSample.cpp	2020-01-06 09:47:37 UTC (rev 254050)
+++ trunk/Source/WebCore/platform/graphics/RemoteVideoSample.cpp	2020-01-06 15:02:13 UTC (rev 254051)
@@ -42,7 +42,7 @@
 using namespace PAL;
 
 #if HAVE(IOSURFACE)
-std::unique_ptr RemoteVideoSample::create(MediaSample&& sample)
+std::unique_ptr RemoteVideoSample::create(MediaSample& sample)
 {
 ASSERT(sample.platformSample().type == PlatformSample::CMSampleBufferType);
 


Modified: trunk/Source/WebCore/platform/graphics/RemoteVideoSample.h (254050 => 254051)

--- trunk/Source/WebCore/platform/graphics/RemoteVideoSample.h	2020-01-06 09:47:37 UTC (rev 254050)
+++ trunk/Source/WebCore/platform/graphics/RemoteVideoSample.h	2020-01-06 15:02:13 UTC (rev 254051)
@@ -48,7 +48,7 @@
 ~RemoteVideoSample() = default;
 
 #if HAVE(IOSURFACE)
-WEBCORE_EXPORT static std::unique_ptr create(MediaSample&&);
+WEBCORE_EXPORT static std::unique_ptr create(MediaSample&);
 WEBCORE_EXPORT static std::unique_ptr create(CVPixelBufferRef, MediaTime&& presentationTime, MediaSample::VideoRotation = MediaSample::VideoRotation::None);
 WEBCORE_EXPORT IOSurfaceRef surface();
 #endif


Modified: trunk/Source/WebKit/ChangeLog (254050 => 254051)

--- trunk/Source/WebKit/ChangeLog	2020-01-06 09:47:37 UTC (rev 254050)
+++ trunk/Source/WebKit/ChangeLog	2020-01-06 15:02:13 UTC (rev 254051)
@@ -1,3 +1,12 @@
+2020-01-06  Youenn Fablet  
+
+RemoteVideoSample::create does not need to take a MediaSample r value
+https://bugs.webkit.org/show_bug.cgi?id=205793
+
+Reviewed by Eric Carlson.
+
+* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
+
 2020-01-06  youenn fablet  
 
 Implement RTC VTB encoders in GPUProcess


Modified: trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp (254050 => 254051)

--- trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp	2020-01-06 09:47:37 UTC (rev 254050)
+++ trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp	2020-01-06 15:02:13 UTC (rev 254051)
@@ -125,7 +125,7 @@
 void videoSampleAvailable(MediaSample& sample) final
 {
 #if HAVE(IOSURFACE)
-auto remoteSample = RemoteVideoSample::create(WTFMove(sample));
+auto remoteSample = RemoteVideoSample::create(sample);
 if (remoteSample)
 m_connection->send(Messages::UserMediaCaptureManager::RemoteVideoSampleAvailable(m_id, WTFMove(*remoteSample)), 0);
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [254050] trunk/Source

2020-01-06 Thread youenn

Title: [254050] trunk/Source








Revision 254050
Author you...@apple.com
Date 2020-01-06 01:47:37 -0800 (Mon, 06 Jan 2020)


Log Message
Implement RTC VTB encoders in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=205713

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Add support for remote video encoders created and used through simple routines.
Add factory to create video encoders implemented elsewhere than in WebRTC backend.
This is used for H264 encoders.

* Configurations/libwebrtc.iOS.exp:
* Configurations/libwebrtc.iOSsim.exp:
* Configurations/libwebrtc.mac.exp:
* Source/webrtc/sdk/WebKit/WebKitEncoder.h: Added.
(webrtc::WebKitRTPFragmentationHeader::value):
(webrtc::WebKitEncodedFrameInfo::decode):
(webrtc::WebKitEncodedFrameInfo::encode const):
(webrtc::WebKitRTPFragmentationHeader::WebKitRTPFragmentationHeader):
(webrtc::WebKitRTPFragmentationHeader::encode const):
(webrtc::WebKitRTPFragmentationHeader::decode):
* Source/webrtc/sdk/WebKit/WebKitEncoder.mm: Added.
(webrtc::VideoEncoderFactoryWithSimulcast::CreateVideoEncoder):
(webrtc::videoEncoderCallbacks):
(webrtc::setVideoEncoderCallbacks):
(webrtc::RemoteVideoEncoder::RemoteVideoEncoder):
(webrtc::RemoteVideoEncoder::InitEncode):
(webrtc::RemoteVideoEncoder::Release):
(webrtc::RemoteVideoEncoder::Encode):
(webrtc::RemoteVideoEncoder::SetRates):
(webrtc::RemoteVideoEncoder::GetEncoderInfo const):
(webrtc::RemoteVideoEncoder::RegisterEncodeCompleteCallback):
(webrtc::RemoteVideoEncoder::encodeComplete):
(webrtc::createLocalEncoder):
(webrtc::releaseLocalEncoder):
(webrtc::initializeLocalEncoder):
(webrtc::encodeLocalEncoderFrame):
(webrtc::setLocalEncoderRates):
* Source/webrtc/sdk/WebKit/WebKitUtilities.h:
* Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
* libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:

Refactoring to expose a createPixelBuffer routine, to set/get RemoteVideoSample and to create a CVPixelBuffer from an IOSurfaceRef.

Covered by existing tests, in particular webrtc/video-gpuProcess.html.

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/RemoteVideoSample.cpp:
(WebCore::RemoteVideoSample::create):
* platform/graphics/RemoteVideoSample.h:
(WebCore::RemoteVideoSample::rotation const):
* platform/graphics/cv/ImageTransferSessionVT.h:
* platform/graphics/cv/ImageTransferSessionVT.mm:
(WebCore::ImageTransferSessionVT::createPixelBuffer):
* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferPool):
* platform/mediastream/mac/RealtimeVideoUtilities.h:
* platform/mediastream/mac/RealtimeVideoUtilities.mm: Added.
(WebCore::createPixelBufferPool):

Source/WebKit:

Add support for remote video encoders in GPUProcess based on libwebrtc exposed routines.
WebProcess sets callbacks in the webrtc backend to implement H264 encoding as a remote video encoder.
In addition to video frames, we also need to send rate setting orders.

* Configurations/WebKit.xcconfig:
* GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
* GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in:
* GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
(WebKit::LibWebRTCCodecsProxy::~LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::createEncoder):
(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
(WebKit::LibWebRTCCodecsProxy::initializeEncoder):
(WebKit::toWebRTCVideoRotation):
(WebKit::LibWebRTCCodecsProxy::encodeFrame):
(WebKit::LibWebRTCCodecsProxy::setEncodeRates):
* Scripts/webkit/messages.py:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:
(WebKit::createVideoEncoder):
(WebKit::releaseVideoEncoder):
(WebKit::initializeVideoEncoder):
(WebKit::toMediaSampleVideoRotation):
(WebKit::encodeVideoFrame):
(WebKit::registerEncodeCompleteCallback):
(WebKit::setEncodeRatesCallback):
(WebKit::LibWebRTCCodecs::setCallbacks):
(WebKit::LibWebRTCCodecs::createDecoder):
(WebKit::LibWebRTCCodecs::releaseDecoder):
(WebKit::LibWebRTCCodecs::failedDecoding):
(WebKit::LibWebRTCCodecs::completedDecoding):
(WebKit::LibWebRTCCodecs::createEncoder):
(WebKit::LibWebRTCCodecs::releaseEncoder):
(WebKit::LibWebRTCCodecs::initializeEncoder):
(WebKit::LibWebRTCCodecs::encodeFrame):
(WebKit::LibWebRTCCodecs::registerEncodeFrameCallback):
(WebKit::LibWebRTCCodecs::setEncodeRates):
(WebKit::LibWebRTCCodecs::completedEncoding):
(WebKit::LibWebRTCCodecs::pixelBufferPool):
* WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
* WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in:
* WebProcess/GPU/webrtc/RTCEncoderIdentifier.h: Added.
* WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::createDecoderFactory):

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h

[webkit-changes] [254049] trunk/Tools

2020-01-06 Thread philn

Title: [254049] trunk/Tools








Revision 254049
Author ph...@webkit.org
Date 2020-01-06 01:12:46 -0800 (Mon, 06 Jan 2020)


Log Message
[WPE][Qt] TestRunJavaScript failure
https://bugs.webkit.org/show_bug.cgi?id=205766

Reviewed by Carlos Garcia Campos.

* TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:
(TestRunJavaScript::main): Surround JS function with parentheses
to comply with the ECMAScript specification.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp




Diff

Modified: trunk/Tools/ChangeLog (254048 => 254049)

--- trunk/Tools/ChangeLog	2020-01-06 05:47:49 UTC (rev 254048)
+++ trunk/Tools/ChangeLog	2020-01-06 09:12:46 UTC (rev 254049)
@@ -1,3 +1,14 @@
+2020-01-06  Philippe Normand  
+
+[WPE][Qt] TestRunJavaScript failure
+https://bugs.webkit.org/show_bug.cgi?id=205766
+
+Reviewed by Carlos Garcia Campos.
+
+* TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:
+(TestRunJavaScript::main): Surround JS function with parentheses
+to comply with the ECMAScript specification.
+
 2020-01-05  Sam Weinig  
 
 Further simplify StringBuilder usage by standardizing hex formating to a single hex() function


Modified: trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp (254048 => 254049)

--- trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp	2020-01-06 05:47:49 UTC (rev 254048)
+++ trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp	2020-01-06 09:12:46 UTC (rev 254049)
@@ -37,7 +37,7 @@
 QVERIFY(!m_view->isLoading());
 QCOMPARE(m_view->title(), title);
 const QString tstProperty = QString(QLatin1String("Qt.tst_data"));
-QJSValue callback = m_engine.evaluate(QString("function(result) { %1 = result; }").arg(tstProperty));
+QJSValue callback = m_engine.evaluate(QString("(function(result) { %1 = result; })").arg(tstProperty));
 QVERIFY2(!callback.isError(), qPrintable(callback.toString()));
 QVERIFY(!callback.isUndefined());
 QVERIFY(callback.isCallable());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

62 matches

Mail list logo