[webkit-changes] [256912] trunk/Source/WebKit

[commit-queue]

Title: [256912] trunk/Source/WebKit








Revision 256912
Author commit-qu...@webkit.org
Date 2020-02-18 22:44:31 -0800 (Tue, 18 Feb 2020)


Log Message
Set User-Agent in preconnect requests
https://bugs.webkit.org/show_bug.cgi?id=20

Patch by Ben Nham  on 2020-02-18
Reviewed by Chris Dumez.

When using an HTTPS proxy, CFNetwork will not reuse a preconnected socket if the User-Agent
on the preconnect request doesn't match the User-Agent of the actual request
(). To work around this, this sets the User-Agent on preconnect
requests.

In addition, this patch moves the preconnect request from WebPage::loadRequest in the
WebProcess to WebPageProxy::loadRequest in the UIProcess. This is because there can be
long sync IPCs that last >100 ms that occur before WebProcess::loadRequest even starts,
e.g. https://bugs.webkit.org/show_bug.cgi?id=203165.

By making both changes, we see a ~2% improvement in PLT5 times.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::preconnectTo):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::preconnectTo):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::preconnectTo):
* UIProcess/WebPageProxy.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::preconnectTo):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadRequest):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (256911 => 256912)

--- trunk/Source/WebKit/ChangeLog	2020-02-19 05:42:37 UTC (rev 256911)
+++ trunk/Source/WebKit/ChangeLog	2020-02-19 06:44:31 UTC (rev 256912)
@@ -1,3 +1,38 @@
+2020-02-18  Ben Nham  
+
+Set User-Agent in preconnect requests
+https://bugs.webkit.org/show_bug.cgi?id=20
+
+Reviewed by Chris Dumez.
+
+When using an HTTPS proxy, CFNetwork will not reuse a preconnected socket if the User-Agent
+on the preconnect request doesn't match the User-Agent of the actual request
+(). To work around this, this sets the User-Agent on preconnect
+requests.
+
+In addition, this patch moves the preconnect request from WebPage::loadRequest in the
+WebProcess to WebPageProxy::loadRequest in the UIProcess. This is because there can be
+long sync IPCs that last >100 ms that occur before WebProcess::loadRequest even starts,
+e.g. https://bugs.webkit.org/show_bug.cgi?id=203165.
+
+By making both changes, we see a ~2% improvement in PLT5 times.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::NetworkProcess::preconnectTo):
+* NetworkProcess/NetworkProcess.h:
+* NetworkProcess/NetworkProcess.messages.in:
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::preconnectTo):
+* UIProcess/Network/NetworkProcessProxy.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::loadRequestWithNavigationShared):
+(WebKit::WebPageProxy::preconnectTo):
+* UIProcess/WebPageProxy.h:
+* WebProcess/Network/WebLoaderStrategy.cpp:
+(WebKit::WebLoaderStrategy::preconnectTo):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::loadRequest):
+
 2020-02-18  Lauro Moura  
 
 [WebKit] Avoid segfault if editor client is null


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (256911 => 256912)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2020-02-19 05:42:37 UTC (rev 256911)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2020-02-19 06:44:31 UTC (rev 256912)
@@ -79,6 +79,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1300,6 +1301,27 @@
 }
 #endif // ENABLE(RESOURCE_LOAD_STATISTICS)
 
+void NetworkProcess::preconnectTo(PAL::SessionID sessionID, const URL& url, const String& userAgent, WebCore::StoredCredentialsPolicy storedCredentialsPolicy)
+{
+#if ENABLE(SERVER_PRECONNECT)
+NetworkLoadParameters parameters;
+parameters.request = ResourceRequest { url };
+if (!userAgent.isEmpty()) {
+// FIXME: we add user-agent to the preconnect request because otherwise the preconnect
+// gets thrown away by CFNetwork when using an HTTPS proxy ().
+parameters.request.setHTTPUserAgent(userAgent);
+}
+

[webkit-changes] [256911] trunk/Source/WebCore

[zalan]

Title: [256911] trunk/Source/WebCore








Revision 256911
Author za...@apple.com
Date 2020-02-18 21:42:37 -0800 (Tue, 18 Feb 2020)


Log Message
Rename ScrollView::styleDidChange to styleAndRenderTreeDidChange
https://bugs.webkit.org/show_bug.cgi?id=207921

Reviewed by Simon Fraser.

When ScrollView::styleDidChange is called we actually finished updating the render tree as well.

* dom/Document.cpp:
(WebCore::Document::resolveStyle):
* page/FrameView.cpp:
(WebCore::FrameView::styleAndRenderTreeDidChange):
(WebCore::FrameView::styleDidChange): Deleted.
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::styleAndRenderTreeDidChange):
(WebCore::ScrollView::styleDidChange): Deleted.
* platform/ScrollView.h:
* rendering/RenderView.cpp: FrameView::styleDidChange gets called by the Document.
(WebCore::RenderView::styleDidChange): Deleted.
* rendering/RenderView.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollView.cpp
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256910 => 256911)

--- trunk/Source/WebCore/ChangeLog	2020-02-19 05:37:45 UTC (rev 256910)
+++ trunk/Source/WebCore/ChangeLog	2020-02-19 05:42:37 UTC (rev 256911)
@@ -1,3 +1,26 @@
+2020-02-18  Zalan Bujtas  
+
+Rename ScrollView::styleDidChange to styleAndRenderTreeDidChange
+https://bugs.webkit.org/show_bug.cgi?id=207921
+
+Reviewed by Simon Fraser.
+
+When ScrollView::styleDidChange is called we actually finished updating the render tree as well.
+
+* dom/Document.cpp:
+(WebCore::Document::resolveStyle):
+* page/FrameView.cpp:
+(WebCore::FrameView::styleAndRenderTreeDidChange):
+(WebCore::FrameView::styleDidChange): Deleted.
+* page/FrameView.h:
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::styleAndRenderTreeDidChange):
+(WebCore::ScrollView::styleDidChange): Deleted.
+* platform/ScrollView.h:
+* rendering/RenderView.cpp: FrameView::styleDidChange gets called by the Document.
+(WebCore::RenderView::styleDidChange): Deleted.
+* rendering/RenderView.h:
+
 2020-02-18  Jack Lee  
 
 ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects


Modified: trunk/Source/WebCore/dom/Document.cpp (256910 => 256911)

--- trunk/Source/WebCore/dom/Document.cpp	2020-02-19 05:37:45 UTC (rev 256910)
+++ trunk/Source/WebCore/dom/Document.cpp	2020-02-19 05:42:37 UTC (rev 256911)
@@ -1995,7 +1995,7 @@
 RenderTreeUpdater updater(*this);
 updater.commit(WTFMove(styleUpdate));
 
-frameView.styleDidChange();
+frameView.styleAndRenderTreeDidChange();
 }
 
 updatedCompositingLayers = frameView.updateCompositingLayersAfterStyleChange();


Modified: trunk/Source/WebCore/page/FrameView.cpp (256910 => 256911)

--- trunk/Source/WebCore/page/FrameView.cpp	2020-02-19 05:37:45 UTC (rev 256910)
+++ trunk/Source/WebCore/page/FrameView.cpp	2020-02-19 05:42:37 UTC (rev 256911)
@@ -799,14 +799,14 @@
 renderView->compositor().willRecalcStyle();
 }
 
-void FrameView::styleDidChange()
+void FrameView::styleAndRenderTreeDidChange()
 {
-ScrollView::styleDidChange();
-RenderView* renderView = this->renderView();
+ScrollView::styleAndRenderTreeDidChange();
+auto* renderView = this->renderView();
 if (!renderView)
 return;
 
-RenderLayer* layerTreeMutationRoot = renderView->takeStyleChangeLayerTreeMutationRoot();
+auto* layerTreeMutationRoot = renderView->takeStyleChangeLayerTreeMutationRoot();
 if (layerTreeMutationRoot && !needsLayout())
 layerTreeMutationRoot->updateLayerPositionsAfterStyleChange();
 }


Modified: trunk/Source/WebCore/page/FrameView.h (256910 => 256911)

--- trunk/Source/WebCore/page/FrameView.h	2020-02-19 05:37:45 UTC (rev 256910)
+++ trunk/Source/WebCore/page/FrameView.h	2020-02-19 05:42:37 UTC (rev 256911)
@@ -138,7 +138,7 @@
 #endif
 
 void willRecalcStyle();
-void styleDidChange() override;
+void styleAndRenderTreeDidChange() override;
 bool updateCompositingLayersAfterStyleChange();
 void updateCompositingLayersAfterLayout();
 


Modified: trunk/Source/WebCore/platform/ScrollView.cpp (256910 => 256911)

--- trunk/Source/WebCore/platform/ScrollView.cpp	2020-02-19 05:37:45 UTC (rev 256910)
+++ trunk/Source/WebCore/platform/ScrollView.cpp	2020-02-19 05:42:37 UTC (rev 256911)
@@ -1515,7 +1515,7 @@
 updateScrollbars(scrollPosition());
 }
 
-void ScrollView::styleDidChange()
+void ScrollView::styleAndRenderTreeDidChange()
 {
 if (m_horizontalScrollbar)
 m_horizontalScrollbar->styleChanged();


Modified: 

[webkit-changes] [256910] trunk/Source

[keith_miller]

Title: [256910] trunk/Source








Revision 256910
Author keith_mil...@apple.com
Date 2020-02-18 21:37:45 -0800 (Tue, 18 Feb 2020)


Log Message
Add an os_log PrintStream
https://bugs.webkit.org/show_bug.cgi?id=207898

Reviewed by Mark Lam.

Source/_javascript_Core:

Add jsc option to write dataLogs to os_log.

* runtime/Options.cpp:
(JSC::Options::initialize):
* runtime/OptionsList.h:

Source/WTF:

When debugging on iOS writing to a file can be hard (thanks
Sandboxing!)  so logging our dataLogs to os_log would make things
easier. This patch adds a new subclass of PrintStream,
OSLogPrintStream, that converts our file writes to
os_log. Unfortunately, os_log doesn't buffer writes so
OSLogPrintStream needs to do its own buffering. e.g. if you call
`dataLogLn("some text with a ", number, " and a ", string);`
os_log will log that as 5 separate logs.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/DataLog.cpp:
(WTF::setDataFile):
* wtf/DataLog.h:
* wtf/OSLogPrintStream.cpp: Added.
(WTF::OSLogPrintStream::OSLogPrintStream):
(WTF::OSLogPrintStream::~OSLogPrintStream):
(WTF::OSLogPrintStream::open):
(WTF::OSLogPrintStream::vprintf):
* wtf/OSLogPrintStream.h: Copied from Source/WTF/wtf/DataLog.h.
* wtf/PrintStream.cpp:
(WTF::printExpectedCStringHelper):
(WTF::printInternal):
* wtf/text/CString.cpp:
(WTF::CString::grow):
* wtf/text/CString.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.cpp
trunk/Source/_javascript_Core/runtime/OptionsList.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WTF/wtf/DataLog.cpp
trunk/Source/WTF/wtf/DataLog.h
trunk/Source/WTF/wtf/PrintStream.cpp
trunk/Source/WTF/wtf/text/CString.cpp
trunk/Source/WTF/wtf/text/CString.h


Added Paths

trunk/Source/WTF/wtf/OSLogPrintStream.cpp
trunk/Source/WTF/wtf/OSLogPrintStream.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (256909 => 256910)

--- trunk/Source/_javascript_Core/ChangeLog	2020-02-19 05:20:53 UTC (rev 256909)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-02-19 05:37:45 UTC (rev 256910)
@@ -1,3 +1,16 @@
+2020-02-18  Keith Miller  
+
+Add an os_log PrintStream
+https://bugs.webkit.org/show_bug.cgi?id=207898
+
+Reviewed by Mark Lam.
+
+Add jsc option to write dataLogs to os_log.
+
+* runtime/Options.cpp:
+(JSC::Options::initialize):
+* runtime/OptionsList.h:
+
 2020-02-18  Paulo Matos  
 
 Fix order (in MIPS) under which CS-registers are saved/restored


Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (256909 => 256910)

--- trunk/Source/_javascript_Core/runtime/Options.cpp	2020-02-19 05:20:53 UTC (rev 256909)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2020-02-19 05:37:45 UTC (rev 256910)
@@ -42,6 +42,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -613,6 +614,14 @@
 handleSignalsWithMach();
 #endif
 
+#if OS(DARWIN)
+if (Options::useOSLog()) {
+WTF::setDataFile(OSLogPrintStream::open("com.apple._javascript_Core", "DataLog", OS_LOG_TYPE_INFO));
+// Make sure no one jumped here for nefarious reasons...
+RELEASE_ASSERT(useOSLog());
+}
+#endif
+
 #if ASAN_ENABLED && OS(LINUX) && ENABLE(WEBASSEMBLY_FAST_MEMORY)
 if (Options::useWebAssemblyFastMemory()) {
 const char* asanOptions = getenv("ASAN_OPTIONS");


Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (256909 => 256910)

--- trunk/Source/_javascript_Core/runtime/OptionsList.h	2020-02-19 05:20:53 UTC (rev 256909)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h	2020-02-19 05:37:45 UTC (rev 256910)
@@ -119,6 +119,7 @@
 v(Unsigned, shadowChickenLogSize, 1000, Normal, nullptr) \
 v(Unsigned, shadowChickenMaxTailDeletedFramesSize, 128, Normal, nullptr) \
 \
+v(Bool, useOSLog, false, Normal, "Log dataLog()s to os_log instead of stderr") \
 /* dumpDisassembly implies dumpDFGDisassembly. */ \
 v(Bool, dumpDisassembly, false, Normal, "dumps disassembly of all JIT compiled code upon compilation") \
 v(Bool, asyncDisassembly, false, Normal, nullptr) \


Modified: trunk/Source/WTF/ChangeLog (256909 => 256910)

--- trunk/Source/WTF/ChangeLog	2020-02-19 05:20:53 UTC (rev 256909)
+++ trunk/Source/WTF/ChangeLog	2020-02-19 05:37:45 UTC (rev 256910)
@@ -1,3 +1,37 @@
+2020-02-18  Keith Miller  
+
+Add an os_log PrintStream
+https://bugs.webkit.org/show_bug.cgi?id=207898
+
+Reviewed by Mark Lam.
+
+When debugging on iOS writing to a file can be hard (thanks
+Sandboxing!)  so logging our dataLogs to os_log would make things
+easier. This patch adds a new subclass of PrintStream,
+OSLogPrintStream, that converts our file writes to
+os_log. Unfortunately, os_log doesn't buffer writes so
+

[webkit-changes] [256909] trunk/LayoutTests

[lmoura]

Title: [256909] trunk/LayoutTests








Revision 256909
Author lmo...@igalia.com
Date 2020-02-18 21:20:53 -0800 (Tue, 18 Feb 2020)


Log Message
[GTK] Gardening release build crashes
https://bugs.webkit.org/show_bug.cgi?id=207928

Unreviewed test gardening.


* platform/gtk-wayland/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk-wayland/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256908 => 256909)

--- trunk/LayoutTests/ChangeLog	2020-02-19 05:17:39 UTC (rev 256908)
+++ trunk/LayoutTests/ChangeLog	2020-02-19 05:20:53 UTC (rev 256909)
@@ -1,3 +1,13 @@
+2020-02-18  Lauro Moura  
+
+[GTK] Gardening release build crashes
+https://bugs.webkit.org/show_bug.cgi?id=207928
+
+Unreviewed test gardening.
+
+* platform/gtk-wayland/TestExpectations:
+* platform/gtk/TestExpectations:
+
 2020-02-18  Jack Lee  
 
 ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (256908 => 256909)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2020-02-19 05:17:39 UTC (rev 256908)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2020-02-19 05:20:53 UTC (rev 256909)
@@ -1259,7 +1259,7 @@
 
 webkit.org/b/206583 webrtc/video-gpuProcess.html [ Failure ]
 
-webkit.org/b/206584 media/video-set-presentation-mode-to-inline.html [ Failure ]
+webkit.org/b/206584 webkit.org/b/198830 [ Release ] media/video-set-presentation-mode-to-inline.html [ Failure Crash ]
 
 webkit.org/b/206585 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-lr.html [ Failure ]
 webkit.org/b/206585 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-position-vertical-rl.html [ Failure ]
@@ -1679,7 +1679,7 @@
 
 #Media controls
 webkit.org/b/132271 media/controls-styling-strict.html [ Failure Timeout Pass Crash ]
-webkit.org/b/132271 media/controls-strict.html [ ImageOnlyFailure Timeout Pass ]
+webkit.org/b/132271 webkit.org/b/198830 [ Release ] media/controls-strict.html [ ImageOnlyFailure Timeout Pass Crash ]
 webkit.org/b/132271 webkit.org/b/198830 media/media-controls-timeline-updates.html [ Timeout Pass Crash ]
 webkit.org/b/132271 media/media-controller-playbackrate.html [ Timeout Pass Crash ]
 webkit.org/b/132271 webkit.org/b/198830 media/media-controller-time-clamp.html [ Timeout Pass Crash ]
@@ -1803,7 +1803,7 @@
 webkit.org/b/144864 fast/events/clear-edit-drag-state.html [ Failure Pass ]
 webkit.org/b/144864 fast/events/clear-drag-state.html [ Failure Pass ]
 
-webkit.org/b/145051 media/video-rtl.html [ ImageOnlyFailure Pass ]
+webkit.org/b/145051 webkit.org/b/198830 [ Release ] media/video-rtl.html [ ImageOnlyFailure Pass Crash ]
 
 webkit.org/b/145167 transforms/2d/perspective-not-fixed-container.html [ ImageOnlyFailure Pass ]
 
@@ -1821,7 +1821,7 @@
 webkit.org/b/53959 fast/dom/Window/window-resize.html [ Failure Timeout Pass ]
 
 # This failures only seem to happen if the environment variable XVFB_SCREEN_DEPTH=8 is not set
-webkit.org/b/132126 media/track/track-cues-cuechange.html [ Timeout Pass ]
+webkit.org/b/132126 webkit.org/b/198830 [ Release ] media/track/track-cues-cuechange.html [ Timeout Pass Crash ]
 webkit.org/b/132126 media/track/track-cues-enter-exit.html [ Timeout Pass ]
 
 webkit.org/b/153771 animations/resume-after-page-cache.html [ Timeout Failure Pass ]
@@ -1841,7 +1841,7 @@
 
 webkit.org/b/157728 plugins/get-_javascript_-url.html [ Timeout Pass ]
 
-webkit.org/b/145639 media/volume-bar-empty-when-muted.html [ Failure Pass ]
+webkit.org/b/145639 webkit.org/b/198830 [ Release ] media/volume-bar-empty-when-muted.html [ Failure Pass Crash ]
 
 webkit.org/b/157729 fast/images/image-map-outline-with-paint-root-offset.html [ ImageOnlyFailure Pass ]
 
@@ -1894,7 +1894,7 @@
 
 webkit.org/b/168780 fast/forms/input-first-letter-edit.html [ ImageOnlyFailure Pass ]
 
-webkit.org/b/116277 media/video-buffered.html [ Pass Failure ]
+webkit.org/b/116277 webkit.org/b/198830 [ Release ] media/video-buffered.html [ Pass Failure Crash ]
 
 webkit.org/b/170337 fast/repaint/obscured-background-no-repaint.html [ Pass Failure ]
 
@@ -2398,6 +2398,60 @@
 webkit.org/b/198830 media/W3C/video/events/event_timeupdate.html [ Pass Crash ]
 webkit.org/b/198830 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html [ Pass Crash ]
 
+# From builds 12695-12698
+webkit.org/b/198830 [ Release ] fast/spatial-navigation/snav-media-elements.html [ Pass Crash ]
+webkit.org/b/198830 http/tests/appcache/video.html [ Pass Crash ]
+webkit.org/b/198830 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_canplaythrough_noautoplay.html [ Pass Crash ]
+webkit.org/b/198830 [ Release 

[webkit-changes] [256908] tags/Safari-610.1.3.3/

[kocsen_chung]

Title: [256908] tags/Safari-610.1.3.3/








Revision 256908
Author kocsen_ch...@apple.com
Date 2020-02-18 21:17:39 -0800 (Tue, 18 Feb 2020)


Log Message
Tag Safari-610.1.3.3.

Added Paths

tags/Safari-610.1.3.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256907] branches/safari-610.1.3-branch/Source

[kocsen_chung]

Title: [256907] branches/safari-610.1.3-branch/Source








Revision 256907
Author kocsen_ch...@apple.com
Date 2020-02-18 21:14:34 -0800 (Tue, 18 Feb 2020)


Log Message
Cherry-pick r256791. rdar://problem/59577979

getVTablePointer() should return a const void*.
https://bugs.webkit.org/show_bug.cgi?id=207871


Reviewed by Yusuke Suzuki.

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSInterfaceName.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSMapLike.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSReadOnlySetLike.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSSetLike.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestCEReactions.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestEnabledForContext.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestIterable.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestPluginInterface.cpp:

[webkit-changes] [256906] branches/safari-610.1.3-branch/Source

[kocsen_chung]

Title: [256906] branches/safari-610.1.3-branch/Source








Revision 256906
Author kocsen_ch...@apple.com
Date 2020-02-18 21:11:40 -0800 (Tue, 18 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-610.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256905 => 256906)

--- branches/safari-610.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-19 04:57:30 UTC (rev 256905)
+++ branches/safari-610.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-19 05:11:40 UTC (rev 256906)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256905 => 256906)

--- branches/safari-610.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-19 04:57:30 UTC (rev 256905)
+++ branches/safari-610.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-19 05:11:40 UTC (rev 256906)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256905 => 256906)

--- branches/safari-610.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-19 04:57:30 UTC (rev 256905)
+++ branches/safari-610.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-19 05:11:40 UTC (rev 256906)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/WebCore/Configurations/Version.xcconfig (256905 => 256906)

--- branches/safari-610.1.3-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-19 04:57:30 UTC (rev 256905)
+++ branches/safari-610.1.3-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-19 05:11:40 UTC (rev 256906)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256905 => 256906)

--- branches/safari-610.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-19 04:57:30 UTC (rev 256905)
+++ branches/safari-610.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-19 05:11:40 UTC (rev 256906)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (256905 => 256906)

--- branches/safari-610.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-19 04:57:30 UTC (rev 256905)
+++ branches/safari-610.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-19 05:11:40 UTC (rev 256906)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/WebKit/Configurations/Version.xcconfig (256905 => 256906)

--- branches/safari-610.1.3-branch/Source/WebKit/Configurations/Version.xcconfig	2020-02-19 04:57:30 UTC (rev 256905)
+++ branches/safari-610.1.3-branch/Source/WebKit/Configurations/Version.xcconfig	2020-02-19 05:11:40 UTC (rev 256906)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = 

[webkit-changes] [256905] trunk

[commit-queue]

Title: [256905] trunk








Revision 256905
Author commit-qu...@webkit.org
Date 2020-02-18 20:57:30 -0800 (Tue, 18 Feb 2020)


Log Message
ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects
https://bugs.webkit.org/show_bug.cgi?id=191532


Patch by Jack Lee  on 2020-02-18
Reviewed by Darin Adler.

Add reentrancy protection for FrameView::updateEmbeddedObjects().
Move the common code in renderWidgetLoadingPlugin() to inherited class, HTMLPlugInElement.

Source/WebCore:

Test: fast/text/textCombine-update-embeddedObj-assert.html

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::renderWidgetLoadingPlugin const):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin const):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetLoadingPlugin const): Deleted.
* html/HTMLObjectElement.h:
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::renderWidgetLoadingPlugin const):
* html/HTMLPlugInElement.h:
* page/FrameView.cpp:
(WebCore::FrameView::updateEmbeddedObjects):
* page/FrameView.h:

LayoutTests:

* fast/text/textCombine-update-embeddedObj-assert-expected.txt: Added.
* fast/text/textCombine-update-embeddedObj-assert.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAppletElement.cpp
trunk/Source/WebCore/html/HTMLEmbedElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.h
trunk/Source/WebCore/html/HTMLPlugInElement.cpp
trunk/Source/WebCore/html/HTMLPlugInElement.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h


Added Paths

trunk/LayoutTests/fast/text/textCombine-update-embeddedObj-assert-expected.txt
trunk/LayoutTests/fast/text/textCombine-update-embeddedObj-assert.html




Diff

Modified: trunk/LayoutTests/ChangeLog (256904 => 256905)

--- trunk/LayoutTests/ChangeLog	2020-02-19 04:50:31 UTC (rev 256904)
+++ trunk/LayoutTests/ChangeLog	2020-02-19 04:57:30 UTC (rev 256905)
@@ -1,3 +1,17 @@
+2020-02-18  Jack Lee  
+
+ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects
+https://bugs.webkit.org/show_bug.cgi?id=191532
+
+
+Reviewed by Darin Adler.
+
+Add reentrancy protection for FrameView::updateEmbeddedObjects().
+Move the common code in renderWidgetLoadingPlugin() to inherited class, HTMLPlugInElement.
+
+* fast/text/textCombine-update-embeddedObj-assert-expected.txt: Added.
+* fast/text/textCombine-update-embeddedObj-assert.html: Added.
+
 2020-02-18  Wenson Hsieh  
 
 REGRESSION (r256093): fast/events/touch/ios/block-without-overflow-scroll.html is failing


Added: trunk/LayoutTests/fast/text/textCombine-update-embeddedObj-assert-expected.txt (0 => 256905)

--- trunk/LayoutTests/fast/text/textCombine-update-embeddedObj-assert-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/text/textCombine-update-embeddedObj-assert-expected.txt	2020-02-19 04:57:30 UTC (rev 256905)
@@ -0,0 +1 @@
+Tests updating embedded objects in text-combine rendering. The test passes if WebKit doesn't crash or hit an assertion.


Added: trunk/LayoutTests/fast/text/textCombine-update-embeddedObj-assert.html (0 => 256905)

--- trunk/LayoutTests/fast/text/textCombine-update-embeddedObj-assert.html	(rev 0)
+++ trunk/LayoutTests/fast/text/textCombine-update-embeddedObj-assert.html	2020-02-19 04:57:30 UTC (rev 256905)
@@ -0,0 +1,18 @@
+
+body {
+-webkit-writing-mode: vertical-lr;
+-webkit-text-combine: horizontal;
+}
+::selection {
+color: red;
+}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+function eventhandler() {
+document.vlinkColor = "red";
+document.createElement("object").style.color = "red";
+}
+
+fooTests updating embedded objects in text-combine rendering. The test passes if WebKit doesn't crash or hit an assertion.


Modified: trunk/Source/WebCore/ChangeLog (256904 => 256905)

--- trunk/Source/WebCore/ChangeLog	2020-02-19 04:50:31 UTC (rev 256904)
+++ trunk/Source/WebCore/ChangeLog	2020-02-19 04:57:30 UTC (rev 256905)
@@ -1,3 +1,30 @@
+2020-02-18  Jack Lee  
+
+ASSERTION FAILED: !m_embeddedObjectsToUpdate->contains(nullptr) in WebCore::FrameView::updateEmbeddedObjects
+https://bugs.webkit.org/show_bug.cgi?id=191532
+
+
+Reviewed by Darin Adler.
+
+Add reentrancy protection for FrameView::updateEmbeddedObjects().
+Move the common code in renderWidgetLoadingPlugin() to inherited class, HTMLPlugInElement.
+
+Test: fast/text/textCombine-update-embeddedObj-assert.html
+
+* html/HTMLAppletElement.cpp:
+(WebCore::HTMLAppletElement::renderWidgetLoadingPlugin const):
+* html/HTMLEmbedElement.cpp:
+(WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin 

[webkit-changes] [256904] trunk/Source/WebCore

[youenn]

Title: [256904] trunk/Source/WebCore








Revision 256904
Author you...@apple.com
Date 2020-02-18 20:50:31 -0800 (Tue, 18 Feb 2020)


Log Message
Reduce use of PlatformMediaSessionManager::sharedManager()
https://bugs.webkit.org/show_bug.cgi?id=207924

Reviewed by Eric Carlson.

The plan is to be able to have PlatformMediaSession in GPU process which might have different managers,
typically a manager per connection to web process.
For that reason, reduce the use of the sharedManager to classes that can only live in WebProcess.
No change of behavior.

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::MediaElementSession):
(WebCore::MediaElementSession::clientDataBufferingTimerFired):
(WebCore::MediaElementSession::setHasPlaybackTargetAvailabilityListeners):
* platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::create):
(WebCore::PlatformMediaSession::PlatformMediaSession):
(WebCore::PlatformMediaSession::~PlatformMediaSession):
(WebCore::PlatformMediaSession::setState):
(WebCore::PlatformMediaSession::clientWillBeginPlayback):
(WebCore::PlatformMediaSession::processClientWillPausePlayback):
(WebCore::PlatformMediaSession::stopSession):
(WebCore::PlatformMediaSession::isPlayingToWirelessPlaybackTargetChanged):
(WebCore::PlatformMediaSession::canProduceAudioChanged):
(WebCore::PlatformMediaSession::clientCharacteristicsChanged):
(WebCore::PlatformMediaSession::manager):
* platform/audio/PlatformMediaSession.h:
* platform/audio/PlatformMediaSessionManager.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
trunk/Source/WebCore/html/MediaElementSession.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSession.h
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256903 => 256904)

--- trunk/Source/WebCore/ChangeLog	2020-02-19 04:15:11 UTC (rev 256903)
+++ trunk/Source/WebCore/ChangeLog	2020-02-19 04:50:31 UTC (rev 256904)
@@ -1,3 +1,38 @@
+2020-02-18  Youenn Fablet  
+
+Reduce use of PlatformMediaSessionManager::sharedManager()
+https://bugs.webkit.org/show_bug.cgi?id=207924
+
+Reviewed by Eric Carlson.
+
+The plan is to be able to have PlatformMediaSession in GPU process which might have different managers,
+typically a manager per connection to web process.
+For that reason, reduce the use of the sharedManager to classes that can only live in WebProcess.
+No change of behavior.
+
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::MediaStreamTrack):
+* Modules/webaudio/AudioContext.cpp:
+(WebCore::AudioContext::AudioContext):
+* html/MediaElementSession.cpp:
+(WebCore::MediaElementSession::MediaElementSession):
+(WebCore::MediaElementSession::clientDataBufferingTimerFired):
+(WebCore::MediaElementSession::setHasPlaybackTargetAvailabilityListeners):
+* platform/audio/PlatformMediaSession.cpp:
+(WebCore::PlatformMediaSession::create):
+(WebCore::PlatformMediaSession::PlatformMediaSession):
+(WebCore::PlatformMediaSession::~PlatformMediaSession):
+(WebCore::PlatformMediaSession::setState):
+(WebCore::PlatformMediaSession::clientWillBeginPlayback):
+(WebCore::PlatformMediaSession::processClientWillPausePlayback):
+(WebCore::PlatformMediaSession::stopSession):
+(WebCore::PlatformMediaSession::isPlayingToWirelessPlaybackTargetChanged):
+(WebCore::PlatformMediaSession::canProduceAudioChanged):
+(WebCore::PlatformMediaSession::clientCharacteristicsChanged):
+(WebCore::PlatformMediaSession::manager):
+* platform/audio/PlatformMediaSession.h:
+* platform/audio/PlatformMediaSessionManager.h:
+
 2020-02-18  Wenson Hsieh  
 
 REGRESSION (r256093): fast/events/touch/ios/block-without-overflow-scroll.html is failing


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (256903 => 256904)

--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp	2020-02-19 04:15:11 UTC (rev 256903)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp	2020-02-19 04:50:31 UTC (rev 256904)
@@ -45,6 +45,7 @@
 #include "NotImplemented.h"
 #include "OverconstrainedError.h"
 #include "Page.h"
+#include "PlatformMediaSessionManager.h"
 #include "RealtimeMediaSourceCenter.h"
 #include "ScriptExecutionContext.h"
 #include 
@@ -74,7 +75,7 @@
 : ActiveDOMObject()
 , m_private(WTFMove(privateTrack))
 , m_isCaptureTrack(m_private->isCaptureTrack())
-, 

[webkit-changes] [256903] trunk

[wenson_hsieh]

Title: [256903] trunk








Revision 256903
Author wenson_hs...@apple.com
Date 2020-02-18 20:15:11 -0800 (Tue, 18 Feb 2020)


Log Message
REGRESSION (r256093): fast/events/touch/ios/block-without-overflow-scroll.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207919


Reviewed by Tim Horton.

Source/WebCore:

Three iOS-specific layout tests began to fail after r256093, since they currently depend on a particular
ordering when iterating over elements in a hash map. Instead of just rebaselining these tests, we can make them
more robust against similar changes in the future by forcing a deterministic order when printing out synchronous
touch event regions for testing.

I arbitrarily chose to sort the keys (which are touch event type names) in alphabetical order.

* page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties const):

LayoutTests:

Rebaseline some layout tests after changing the order in which synchronous touch event regions are dumped when
calling internals.scrollingStateTreeAsText().

* fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt:
* fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt:
* fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt
trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt
trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (256902 => 256903)

--- trunk/LayoutTests/ChangeLog	2020-02-19 03:53:59 UTC (rev 256902)
+++ trunk/LayoutTests/ChangeLog	2020-02-19 04:15:11 UTC (rev 256903)
@@ -1,3 +1,18 @@
+2020-02-18  Wenson Hsieh  
+
+REGRESSION (r256093): fast/events/touch/ios/block-without-overflow-scroll.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=207919
+
+
+Reviewed by Tim Horton.
+
+Rebaseline some layout tests after changing the order in which synchronous touch event regions are dumped when
+calling internals.scrollingStateTreeAsText().
+
+* fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt:
+* fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt:
+* fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt:
+
 2020-02-18  Ryan Haddad  
 
 Changed results due to ANGLE use


Modified: trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt (256902 => 256903)

--- trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt	2020-02-19 03:53:59 UTC (rev 256902)
+++ trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt	2020-02-19 04:15:11 UTC (rev 256903)
@@ -15,12 +15,12 @@
   (max layout viewport origin (0,0))
   (synchronous event dispatch region for event touchend
 at (8,8) size 784x200)
-  (synchronous event dispatch region for event touchstart
-at (8,8) size 784x200)
   (synchronous event dispatch region for event touchforcechange
 at (8,8) size 784x200)
   (synchronous event dispatch region for event touchmove
 at (8,8) size 784x200)
+  (synchronous event dispatch region for event touchstart
+at (8,8) size 784x200)
   (behavior for fixed 0)
 )
 


Modified: trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt (256902 => 256903)

--- trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt	2020-02-19 03:53:59 UTC (rev 256902)
+++ trunk/LayoutTests/fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt	2020-02-19 04:15:11 UTC (rev 256903)
@@ -17,12 +17,12 @@
 at (0,0) size 800x600)
   (synchronous event dispatch region for event touchend
 at (8,8) size 784x200)
-  (synchronous event dispatch region for event touchstart
-at (8,8) size 784x200)
   (synchronous event dispatch region for event touchforcechange
 at (8,8) size 784x200)
   (synchronous event dispatch region for event touchmove
 at (8,8) size 784x200)
+  (synchronous event dispatch region for event touchstart
+at (8,8) size 784x200)
   (behavior for fixed 0)
 

[webkit-changes] [256901] trunk/Source/WebCore

[youenn]

Title: [256901] trunk/Source/WebCore








Revision 256901
Author you...@apple.com
Date 2020-02-18 19:38:47 -0800 (Tue, 18 Feb 2020)


Log Message
PlatformMediaSessionClient::processingUserGestureForMedia is not needed
https://bugs.webkit.org/show_bug.cgi?id=207922

Reviewed by Eric Carlson.

All code relies on the document and the virtual method is never used so remove it.
No change of behavior.

* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::processingUserGestureForMedia const): Deleted.
* Modules/mediastream/MediaStreamTrack.h:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::processingUserGestureForMedia const): Deleted.
* Modules/webaudio/AudioContext.h:
* html/HTMLMediaElement.h:
* platform/audio/PlatformMediaSession.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
trunk/Source/WebCore/Modules/webaudio/AudioContext.h
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/audio/PlatformMediaSession.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256900 => 256901)

--- trunk/Source/WebCore/ChangeLog	2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/ChangeLog	2020-02-19 03:38:47 UTC (rev 256901)
@@ -1,5 +1,24 @@
 2020-02-18  Youenn Fablet  
 
+PlatformMediaSessionClient::processingUserGestureForMedia is not needed
+https://bugs.webkit.org/show_bug.cgi?id=207922
+
+Reviewed by Eric Carlson.
+
+All code relies on the document and the virtual method is never used so remove it.
+No change of behavior.
+
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::processingUserGestureForMedia const): Deleted.
+* Modules/mediastream/MediaStreamTrack.h:
+* Modules/webaudio/AudioContext.cpp:
+(WebCore::AudioContext::processingUserGestureForMedia const): Deleted.
+* Modules/webaudio/AudioContext.h:
+* html/HTMLMediaElement.h:
+* platform/audio/PlatformMediaSession.h:
+
+2020-02-18  Youenn Fablet  
+
 SWServer::claim should check for the service worker to be active
 https://bugs.webkit.org/show_bug.cgi?id=207739
 


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp (256900 => 256901)

--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp	2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp	2020-02-19 03:38:47 UTC (rev 256901)
@@ -623,11 +623,6 @@
 return m_private->type() == RealtimeMediaSource::Type::Audio && !ended() && !muted();
 }
 
-bool MediaStreamTrack::processingUserGestureForMedia() const
-{
-return document() ? document()->processingUserGestureForMedia() : false;
-}
-
 DocumentIdentifier MediaStreamTrack::hostingDocumentIdentifier() const
 {
 auto* document = downcast(m_scriptExecutionContext);


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h (256900 => 256901)

--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h	2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h	2020-02-19 03:38:47 UTC (rev 256901)
@@ -203,7 +203,6 @@
 String sourceApplicationIdentifier() const final;
 bool canProduceAudio() const final;
 DocumentIdentifier hostingDocumentIdentifier() const final;
-bool processingUserGestureForMedia() const final;
 bool shouldOverridePauseDuringRouteChange() const final { return true; }
 
 #if !RELEASE_LOG_DISABLED


Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp (256900 => 256901)

--- trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp	2020-02-19 03:26:28 UTC (rev 256900)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp	2020-02-19 03:38:47 UTC (rev 256901)
@@ -382,11 +382,6 @@
 return emptyString();
 }
 
-bool AudioContext::processingUserGestureForMedia() const
-{
-return document() ? document()->processingUserGestureForMedia() : false;
-}
-
 bool AudioContext::isSuspended() const
 {
 return !document() || document()->activeDOMObjectsAreSuspended() || document()->activeDOMObjectsAreStopped();
@@ -1098,11 +1093,12 @@
 
 bool AudioContext::willBeginPlayback()
 {
-if (!document())
+auto* document = this->document();
+if (!document)
 return false;
 
 if (userGestureRequiredForAudioStart()) {
-if (!processingUserGestureForMedia() && !document()->isCapturing()) {
+if (!document->processingUserGestureForMedia() && !document->isCapturing()) {
 ALWAYS_LOG(LOGIDENTIFIER, "returning false, not processing user gesture or capturing");
 return false;
 }
@@ -1110,9 +1106,9 @@
 }
 
 if (pageConsentRequiredForAudioStart()) {
-Page* page = document()->page();
+auto* page = document->page();
   

[webkit-changes] [256900] trunk/Source

[youenn]

Title: [256900] trunk/Source








Revision 256900
Author you...@apple.com
Date 2020-02-18 19:26:28 -0800 (Tue, 18 Feb 2020)


Log Message
SWServer::claim should check for the service worker to be active
https://bugs.webkit.org/show_bug.cgi?id=207739


Reviewed by Alex Christensen.

Source/WebCore:

claim is only working for service workers that are active.
But there might be a time when a service worker is active in its web process but redundant in networking process.
Thus, we need to move the check from WebProcess to NetworkProcess.

* workers/service/ServiceWorkerClients.cpp:
(WebCore::ServiceWorkerClients::claim):
* workers/service/context/SWContextManager.h:
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::claim):
* workers/service/server/SWServer.h:
* workers/service/server/SWServerToContextConnection.cpp:
(WebCore::SWServerToContextConnection::claim):
* workers/service/server/SWServerToContextConnection.h:
* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::claim): Deleted.
* workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::isActive const):

Source/WebKit:

Use Async Reply to remove the need for a map and passing integers around.

* NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::claimCompleted): Deleted.
* NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
* NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::claim):
(WebKit::WebSWContextManagerConnection::claimCompleted): Deleted.
* WebProcess/Storage/WebSWContextManagerConnection.h:
* WebProcess/Storage/WebSWContextManagerConnection.messages.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerClients.cpp
trunk/Source/WebCore/workers/service/context/SWContextManager.h
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.cpp
trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h
trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp
trunk/Source/WebCore/workers/service/server/SWServerWorker.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (256899 => 256900)

--- trunk/Source/WebCore/ChangeLog	2020-02-19 02:38:19 UTC (rev 256899)
+++ trunk/Source/WebCore/ChangeLog	2020-02-19 03:26:28 UTC (rev 256900)
@@ -1,3 +1,29 @@
+2020-02-18  Youenn Fablet  
+
+SWServer::claim should check for the service worker to be active
+https://bugs.webkit.org/show_bug.cgi?id=207739
+
+
+Reviewed by Alex Christensen.
+
+claim is only working for service workers that are active.
+But there might be a time when a service worker is active in its web process but redundant in networking process.
+Thus, we need to move the check from WebProcess to NetworkProcess.
+
+* workers/service/ServiceWorkerClients.cpp:
+(WebCore::ServiceWorkerClients::claim):
+* workers/service/context/SWContextManager.h:
+* workers/service/server/SWServer.cpp:
+(WebCore::SWServer::claim):
+* workers/service/server/SWServer.h:
+* workers/service/server/SWServerToContextConnection.cpp:
+(WebCore::SWServerToContextConnection::claim):
+* workers/service/server/SWServerToContextConnection.h:
+* workers/service/server/SWServerWorker.cpp:
+(WebCore::SWServerWorker::claim): Deleted.
+* workers/service/server/SWServerWorker.h:
+(WebCore::SWServerWorker::isActive const):
+
 2020-02-18  Zalan Bujtas  
 
 [LFC][IFC] Replaced elements can also establish formatting contexts.


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerClients.cpp (256899 => 256900)

--- trunk/Source/WebCore/workers/service/ServiceWorkerClients.cpp	2020-02-19 02:38:19 UTC (rev 256899)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerClients.cpp	2020-02-19 03:26:28 UTC (rev 256900)
@@ -116,20 +116,17 @@
 
 auto serviceWorkerIdentifier = serviceWorkerGlobalScope.thread().identifier();
 
-if (!serviceWorkerGlobalScope.registration().active() || serviceWorkerGlobalScope.registration().active()->identifier() != serviceWorkerIdentifier) {
-promise->reject(Exception { InvalidStateError, "Service worker is not 

[webkit-changes] [256899] branches/safari-609-branch

[alancoon]

Title: [256899] branches/safari-609-branch








Revision 256899
Author alanc...@apple.com
Date 2020-02-18 18:38:19 -0800 (Tue, 18 Feb 2020)


Log Message
Apply patch. rdar://problem/59465474

Modified Paths

branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/TestExpectations
branches/safari-609-branch/LayoutTests/compositing/backing/animate-into-view.html
branches/safari-609-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-startTime.tentative-expected.txt
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/style-change-events-expected.txt
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-expected.txt
branches/safari-609-branch/LayoutTests/webanimations/css-transition-in-flight-reversal-accelerated.html
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/animation/CSSTransition.h
branches/safari-609-branch/Source/WebCore/animation/DeclarativeAnimation.cpp
branches/safari-609-branch/Source/WebCore/animation/DeclarativeAnimation.h
branches/safari-609-branch/Source/WebCore/animation/DocumentTimeline.cpp
branches/safari-609-branch/Source/WebCore/animation/DocumentTimeline.h
branches/safari-609-branch/Source/WebCore/animation/WebAnimation.cpp
branches/safari-609-branch/Source/WebCore/animation/WebAnimation.h




Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256898 => 256899)

--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-19 02:10:57 UTC (rev 256898)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-19 02:38:19 UTC (rev 256899)
@@ -1,5 +1,27 @@
 2020-02-18  Alan Coon  
 
+Apply patch. rdar://problem/59465474
+
+2020-02-18  Antoine Quint  
+
+[Web Animations] Ensure CSS Transition and CSS Animation events are queued, sorted and dispatched by their timeline
+https://bugs.webkit.org/show_bug.cgi?id=207364
+
+
+Reviewed by Simon Fraser.
+
+Fix a couple of tests that made some incorrect assumptions.
+
+* TestExpectations: imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html is no longer flaky.
+* compositing/backing/animate-into-view.html: Because the "animationstart" event is now dispatched during the "update animations and send events" procedure, which happens
+during page rendering _before_ rAF callbacks are serviced, we must remove the rAF callback used prior to adding the "animationstart" event listener or else we would never
+get it and the test would time out.
+* webanimations/css-transition-in-flight-reversal-accelerated.html: We must wait for the initial transition to start and then two frames before reversing the transition,
+to be certain that the animation did start. Indeed, the "transitionstart" event will be fired right before the next rAF callback is called, as the animation starts in that
+very same frame, and so progress will be 0 and the transition wouldn't be reversable until the next frame when the animation has progress > 0.
+
+2020-02-18  Alan Coon  
+
 Cherry-pick r256191. rdar://problem/59447003
 
 Disallow setting base URL to a data or _javascript_ URL


Modified: branches/safari-609-branch/LayoutTests/TestExpectations (256898 => 256899)

--- branches/safari-609-branch/LayoutTests/TestExpectations	2020-02-19 02:10:57 UTC (rev 256898)
+++ branches/safari-609-branch/LayoutTests/TestExpectations	2020-02-19 02:38:19 UTC (rev 256899)
@@ -2653,7 +2653,6 @@
 
 webkit.org/b/202107 imported/w3c/web-platform-tests/web-animations/interfaces/Animation/style-change-events.html [ Pass Failure ]
 webkit.org/b/202108 imported/w3c/web-platform-tests/web-animations/interfaces/DocumentTimeline/style-change-events.html [ Pass Failure ]
-webkit.org/b/202109 imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events.html [ Pass Failure ]
 
 webkit.org/b/157068 [ Debug ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Crash ]
 webkit.org/b/157068 [ Release ] imported/w3c/web-platform-tests/fetch/nosniff/importscripts.html [ Pass Failure ]


Modified: branches/safari-609-branch/LayoutTests/compositing/backing/animate-into-view.html (256898 => 256899)

--- branches/safari-609-branch/LayoutTests/compositing/backing/animate-into-view.html	2020-02-19 02:10:57 UTC (rev 256898)
+++ 

[webkit-changes] [256898] branches/safari-609-branch/Source/JavaScriptCore

[simon . fraser]

Title: [256898] branches/safari-609-branch/Source/_javascript_Core








Revision 256898
Author simon.fra...@apple.com
Date 2020-02-18 18:10:57 -0800 (Tue, 18 Feb 2020)


Log Message
Unreviewed build fix.

* jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):

Modified Paths

branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/jit/JITThunks.cpp




Diff

Modified: branches/safari-609-branch/Source/_javascript_Core/ChangeLog (256897 => 256898)

--- branches/safari-609-branch/Source/_javascript_Core/ChangeLog	2020-02-19 01:34:28 UTC (rev 256897)
+++ branches/safari-609-branch/Source/_javascript_Core/ChangeLog	2020-02-19 02:10:57 UTC (rev 256898)
@@ -1,3 +1,10 @@
+2020-02-18  Simon Fraser  
+
+Unreviewed build fix.
+
+* jit/JITThunks.cpp:
+(JSC::JITThunks::hostFunctionStub):
+
 2020-02-18  Alan Coon  
 
 Cherry-pick r256779. rdar://problem/59551695


Modified: branches/safari-609-branch/Source/_javascript_Core/jit/JITThunks.cpp (256897 => 256898)

--- branches/safari-609-branch/Source/_javascript_Core/jit/JITThunks.cpp	2020-02-19 01:34:28 UTC (rev 256897)
+++ branches/safari-609-branch/Source/_javascript_Core/jit/JITThunks.cpp	2020-02-19 02:10:57 UTC (rev 256898)
@@ -218,7 +218,7 @@
 ASSERT(!*addResult.iterator);
 *addResult.iterator = Weak(nativeExecutable, this);
 ASSERT(*addResult.iterator);
-#if ASSERT_ENABLED
+#if !ASSERT_DISABLED
 auto iterator = m_nativeExecutableSet.find(hostFunctionKey);
 ASSERT(iterator != m_nativeExecutableSet.end());
 ASSERT(iterator->get() == nativeExecutable);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256897] trunk/LayoutTests

[ryanhaddad]

Title: [256897] trunk/LayoutTests








Revision 256897
Author ryanhad...@apple.com
Date 2020-02-18 17:34:28 -0800 (Tue, 18 Feb 2020)


Log Message
Changed results due to ANGLE use
https://bugs.webkit.org/show_bug.cgi?id=207858

Unreviewed test gardening.

Remove conflict markers that were accidentally added as part of r256880,
remove duplicated expectation for a test, and move the expectations to the same
file as the rest of the ANGLE related failures.

* platform/ios-wk2/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256896 => 256897)

--- trunk/LayoutTests/ChangeLog	2020-02-19 01:29:57 UTC (rev 256896)
+++ trunk/LayoutTests/ChangeLog	2020-02-19 01:34:28 UTC (rev 256897)
@@ -1,3 +1,17 @@
+2020-02-18  Ryan Haddad  
+
+Changed results due to ANGLE use
+https://bugs.webkit.org/show_bug.cgi?id=207858
+
+Unreviewed test gardening.
+
+Remove conflict markers that were accidentally added as part of r256880,
+remove duplicated expectation for a test, and move the expectations to the same
+file as the rest of the ANGLE related failures.
+
+* platform/ios-wk2/TestExpectations:
+* platform/ios/TestExpectations:
+
 2020-02-18  Zalan Bujtas  
 
 [LFC][IFC] Replaced elements can also establish formatting contexts.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (256896 => 256897)

--- trunk/LayoutTests/platform/ios/TestExpectations	2020-02-19 01:29:57 UTC (rev 256896)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-02-19 01:34:28 UTC (rev 256897)
@@ -3513,6 +3513,8 @@
 webkit.org/b/207858 fast/canvas/webgl/webgl-depth-texture.html [ Pass Failure ]
 webkit.org/b/207858 fast/canvas/webgl/webgl-texture-binding-preserved.html [ Pass Failure ]
 webkit.org/b/207858 fast/canvas/webgl/oes-texture-float-linear.html [ Pass Failure ]
+webkit.org/b/207858 fast/canvas/webgl/oes-vertex-array-object.html [ Pass Failure ]
+webkit.org/b/207858 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html [ Pass Failure ]
 webkit.org/b/207858 webgl/1.0.3/conformance/canvas/texture-bindings-unaffected-on-resize.html [ Pass Failure ]
 webkit.org/b/207858 webgl/1.0.3/conformance/context/context-lost-restored.html [ Pass Failure ]
 webkit.org/b/207858 webgl/1.0.3/conformance/extensions/ext-sRGB.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256896 => 256897)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-19 01:29:57 UTC (rev 256896)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-19 01:34:28 UTC (rev 256897)
@@ -1416,14 +1416,4 @@
 webkit.org/b/207866 imported/w3c/IndexedDB-private-browsing [ Pass Timeout ]
 
 # skip LFC regression tests on iOS for now.
-<<< HEAD
 fast/layoutformattingcontext/ [ Skip ]
-
-webkit.org/b/207896 fast/canvas/webgl/oes-vertex-array-object.html [ Pass Failure ]
-===
-fast/layoutformattingcontext/block-only/ [ Skip ]
-
-webkit.org/b/207858 fast/canvas/webgl/oes-vertex-array-object.html [ Pass Failure ]
-
-webkit.org/b/207858 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html [ Pass Failure ]
->>> Changed results due to ANGLE use






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256895] trunk

[zalan]

Title: [256895] trunk








Revision 256895
Author za...@apple.com
Date 2020-02-18 17:23:50 -0800 (Tue, 18 Feb 2020)


Log Message
[LFC][IFC] Replaced elements can also establish formatting contexts.
https://bugs.webkit.org/show_bug.cgi?id=207923


Reviewed by Simon Fraser.

Source/WebCore:

While replaced boxes (leaf boxes) can also establish formatting contexts (e.g. style="inline-block"), we
only need to construct formatting context objects for the root's descendants (and not for the root itself).

Test: fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html

* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

LayoutTests:

* fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple-expected.html: Added.
* fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp


Added Paths

trunk/LayoutTests/fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple-expected.html
trunk/LayoutTests/fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html




Diff

Modified: trunk/LayoutTests/ChangeLog (256894 => 256895)

--- trunk/LayoutTests/ChangeLog	2020-02-19 01:16:08 UTC (rev 256894)
+++ trunk/LayoutTests/ChangeLog	2020-02-19 01:23:50 UTC (rev 256895)
@@ -1,3 +1,14 @@
+2020-02-18  Zalan Bujtas  
+
+[LFC][IFC] Replaced elements can also establish formatting contexts.
+https://bugs.webkit.org/show_bug.cgi?id=207923
+
+
+Reviewed by Simon Fraser.
+
+* fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple-expected.html: Added.
+* fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html: Added.
+
 2020-02-18  Jacob Uphoff  
 
 Changed results due to ANGLE use


Added: trunk/LayoutTests/fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple-expected.html (0 => 256895)

--- trunk/LayoutTests/fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple-expected.html	2020-02-19 01:23:50 UTC (rev 256895)
@@ -0,0 +1,9 @@
+
+
+div {
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+


Added: trunk/LayoutTests/fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html (0 => 256895)

--- trunk/LayoutTests/fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html	(rev 0)
+++ trunk/LayoutTests/fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html	2020-02-19 01:23:50 UTC (rev 256895)
@@ -0,0 +1,10 @@
+
+
+video {
+display: inline-block;
+width: 100px;
+height: 100px;
+background-color: green;
+}
+
+


Modified: trunk/Source/WebCore/ChangeLog (256894 => 256895)

--- trunk/Source/WebCore/ChangeLog	2020-02-19 01:16:08 UTC (rev 256894)
+++ trunk/Source/WebCore/ChangeLog	2020-02-19 01:23:50 UTC (rev 256895)
@@ -1,3 +1,19 @@
+2020-02-18  Zalan Bujtas  
+
+[LFC][IFC] Replaced elements can also establish formatting contexts.
+https://bugs.webkit.org/show_bug.cgi?id=207923
+
+
+Reviewed by Simon Fraser.
+
+While replaced boxes (leaf boxes) can also establish formatting contexts (e.g. style="inline-block"), we
+only need to construct formatting context objects for the root's descendants (and not for the root itself). 
+
+Test: fast/layoutformattingcontext/block-only/replaced-as-inline-block-simple.html
+
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
+
 2020-02-18  Said Abou-Hallawa  
 
 Allow different back-ends for ImageBuffer


Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp (256894 => 256895)

--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp	2020-02-19 01:16:08 UTC (rev 256894)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp	2020-02-19 01:23:50 UTC (rev 256895)
@@ -89,8 +89,7 @@
 
 if (layoutBox->isAtomicInlineLevelBox() || layoutBox->isFloatingPositioned()) {
 // Inline-blocks, inline-tables and replaced elements (img, video) can be sized but not yet positioned.
-if (layoutBox->establishesFormattingContext()) {
-ASSERT(is(*layoutBox));
+if (is(layoutBox) && layoutBox->establishesFormattingContext()) {
 ASSERT(layoutBox->isInlineBlockBox() || layoutBox->isInlineTableBox() || layoutBox->isFloatingPositioned());
 auto& containerBox = downcast(*layoutBox);
 computeBorderAndPadding(containerBox, 

[webkit-changes] [256894] trunk/Tools

[ryanhaddad]

Title: [256894] trunk/Tools








Revision 256894
Author ryanhad...@apple.com
Date 2020-02-18 17:16:08 -0800 (Tue, 18 Feb 2020)


Log Message
Unreviewed, rolling out r256851.

Broke internal bots

Reverted changeset:

"Stub repositories fail to upload some results due to missing
head svn revision"
https://bugs.webkit.org/show_bug.cgi?id=207684
https://trac.webkit.org/changeset/256851

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/port/base.py
trunk/Tools/Scripts/webkitpy/test/main.py




Diff

Modified: trunk/Tools/ChangeLog (256893 => 256894)

--- trunk/Tools/ChangeLog	2020-02-19 01:14:28 UTC (rev 256893)
+++ trunk/Tools/ChangeLog	2020-02-19 01:16:08 UTC (rev 256894)
@@ -1,3 +1,16 @@
+2020-02-18  Ryan Haddad  
+
+Unreviewed, rolling out r256851.
+
+Broke internal bots
+
+Reverted changeset:
+
+"Stub repositories fail to upload some results due to missing
+head svn revision"
+https://bugs.webkit.org/show_bug.cgi?id=207684
+https://trac.webkit.org/changeset/256851
+
 2020-02-18  Fujii Hironori  
 
 [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD


Modified: trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py (256893 => 256894)

--- trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py	2020-02-19 01:14:28 UTC (rev 256893)
+++ trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py	2020-02-19 01:16:08 UTC (rev 256894)
@@ -41,7 +41,6 @@
 def main(argv, stdout, stderr):
 options, args = parse_args(argv)
 host = Host()
-host.initialize_scm()
 
 try:
 options.webkit_test_runner = True


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (256893 => 256894)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2020-02-19 01:14:28 UTC (rev 256893)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2020-02-19 01:16:08 UTC (rev 256894)
@@ -359,7 +359,7 @@
 # FIXME: Do we really need to populate this both here and in the json_results_generator?
 if port_obj.get_option("builder_name"):
 port_obj.host.initialize_scm()
-results['revision'] = port_obj.commits_for_upload()[0]['id']
+results['revision'] = port_obj.host.scm().head_svn_revision()
 except Exception as e:
 _log.warn("Failed to determine svn revision for checkout (cwd: %s, webkit_base: %s), leaving 'revision' key blank in full_results.json.\n%s" % (port_obj._filesystem.getcwd(), port_obj.path_from_webkit_base(), e))
 # Handle cases where we're running outside of version control.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (256893 => 256894)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2020-02-19 01:14:28 UTC (rev 256893)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2020-02-19 01:16:08 UTC (rev 256894)
@@ -64,7 +64,6 @@
 host = MockHost()
 else:
 host = Host()
-host.initialize_scm()
 
 if options.lint_test_files:
 from webkitpy.layout_tests.lint_test_expectations import lint


Modified: trunk/Tools/Scripts/webkitpy/port/base.py (256893 => 256894)

--- trunk/Tools/Scripts/webkitpy/port/base.py	2020-02-19 01:14:28 UTC (rev 256893)
+++ trunk/Tools/Scripts/webkitpy/port/base.py	2020-02-19 01:16:08 UTC (rev 256894)
@@ -1601,12 +1601,16 @@
 repos = {}
 if port_config.apple_additions() and getattr(port_config.apple_additions(), 'repos', False):
 repos = port_config.apple_additions().repos()
-repos['webkit'] = self.host.scm().checkout_root
+
+up = os.path.dirname
+repos['webkit'] = up(up(up(up(up(os.path.abspath(__file__))
+
 commits = []
 for repo_id, path in repos.items():
+scm = SCMDetector(self._filesystem, self._executive).detect_scm_system(path)
 commits.append(Upload.create_commit(
 repository_id=repo_id,
-id=self.host.scm().native_revision(path),
-branch=self.host.scm().native_branch(path),
+id=scm.native_revision(path),
+branch=scm.native_branch(path),
 ))
 return commits


Modified: trunk/Tools/Scripts/webkitpy/test/main.py (256893 => 256894)

--- trunk/Tools/Scripts/webkitpy/test/main.py	2020-02-19 01:14:28 UTC (rev 256893)
+++ trunk/Tools/Scripts/webkitpy/test/main.py	2020-02-19 01:16:08 UTC (rev 256894)
@@ -50,7 +50,6 @@
 _log = logging.getLogger(__name__)
 
 _host = Host()
-_host.initialize_scm()
 _webkit_root = None
 
 
@@ -58,7 +57,8 @@
 global _webkit_root
 configure_logging(logger=_log)
 
-_webkit_root = 

[webkit-changes] [256893] tags/Safari-609.1.20.3.1/

[alancoon]

Title: [256893] tags/Safari-609.1.20.3.1/








Revision 256893
Author alanc...@apple.com
Date 2020-02-18 17:14:28 -0800 (Tue, 18 Feb 2020)


Log Message
Tag Safari-609.1.20.3.1.

Added Paths

tags/Safari-609.1.20.3.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256891] tags/Safari-609.1.20.2.1/

[alancoon]

Title: [256891] tags/Safari-609.1.20.2.1/








Revision 256891
Author alanc...@apple.com
Date 2020-02-18 17:12:20 -0800 (Tue, 18 Feb 2020)


Log Message
Tag Safari-609.1.20.2.1.

Added Paths

tags/Safari-609.1.20.2.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256890] trunk/Source/WebKit

[youenn]

Title: [256890] trunk/Source/WebKit








Revision 256890
Author you...@apple.com
Date 2020-02-18 17:06:26 -0800 (Tue, 18 Feb 2020)


Log Message
Add support for WebInspector WebSocket handshake in the new WebSocket code path
https://bugs.webkit.org/show_bug.cgi?id=207913

Reviewed by Alex Christensen.

Whenever creating the WebSocketTask, pass the request actually used for handshake to the WebProcess.
Whenever being connected, pass the request actually used for handshake to the WebProcess.
In case of failure before the web socket is connected, we send the response if we can get a non null from the task.

* NetworkProcess/NetworkSocketChannel.cpp:
(WebKit::NetworkSocketChannel::didSendHandshakeRequest):
(WebKit::NetworkSocketChannel::didReceiveHandshakeResponse):
* NetworkProcess/NetworkSocketChannel.h:
* NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
(WebKit::WebSocketTask::WebSocketTask):
(WebKit::WebSocketTask::didConnect):
* WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::connect):
(WebKit::WebSocketChannel::didConnect):
(WebKit::WebSocketChannel::didSendHandshakeRequest):
(WebKit::WebSocketChannel::didReceiveHandshakeResponse):
* WebProcess/Network/WebSocketChannel.h:
* WebProcess/Network/WebSocketChannel.messages.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.h
trunk/Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/WebSocketTaskCocoa.mm
trunk/Source/WebKit/WebProcess/Network/WebSocketChannel.cpp
trunk/Source/WebKit/WebProcess/Network/WebSocketChannel.h
trunk/Source/WebKit/WebProcess/Network/WebSocketChannel.messages.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (256889 => 256890)

--- trunk/Source/WebKit/ChangeLog	2020-02-19 00:49:13 UTC (rev 256889)
+++ trunk/Source/WebKit/ChangeLog	2020-02-19 01:06:26 UTC (rev 256890)
@@ -1,3 +1,29 @@
+2020-02-18  Youenn Fablet  
+
+Add support for WebInspector WebSocket handshake in the new WebSocket code path
+https://bugs.webkit.org/show_bug.cgi?id=207913
+
+Reviewed by Alex Christensen.
+
+Whenever creating the WebSocketTask, pass the request actually used for handshake to the WebProcess.
+Whenever being connected, pass the request actually used for handshake to the WebProcess.
+In case of failure before the web socket is connected, we send the response if we can get a non null from the task.
+
+* NetworkProcess/NetworkSocketChannel.cpp:
+(WebKit::NetworkSocketChannel::didSendHandshakeRequest):
+(WebKit::NetworkSocketChannel::didReceiveHandshakeResponse):
+* NetworkProcess/NetworkSocketChannel.h:
+* NetworkProcess/cocoa/WebSocketTaskCocoa.mm:
+(WebKit::WebSocketTask::WebSocketTask):
+(WebKit::WebSocketTask::didConnect):
+* WebProcess/Network/WebSocketChannel.cpp:
+(WebKit::WebSocketChannel::connect):
+(WebKit::WebSocketChannel::didConnect):
+(WebKit::WebSocketChannel::didSendHandshakeRequest):
+(WebKit::WebSocketChannel::didReceiveHandshakeResponse):
+* WebProcess/Network/WebSocketChannel.h:
+* WebProcess/Network/WebSocketChannel.messages.in:
+
 2020-02-18  Chris Dumez  
 
 Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called


Modified: trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp (256889 => 256890)

--- trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp	2020-02-19 00:49:13 UTC (rev 256889)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp	2020-02-19 01:06:26 UTC (rev 256890)
@@ -123,6 +123,17 @@
 send(Messages::WebSocketChannel::DidReceiveMessageError { errorMessage });
 }
 
+void NetworkSocketChannel::didSendHandshakeRequest(ResourceRequest&& request)
+{
+send(Messages::WebSocketChannel::DidSendHandshakeRequest { request });
+}
+
+void NetworkSocketChannel::didReceiveHandshakeResponse(ResourceResponse&& response)
+{
+response.sanitizeHTTPHeaderFields(ResourceResponse::SanitizationType::CrossOriginSafe);
+send(Messages::WebSocketChannel::DidReceiveHandshakeResponse { response });
+}
+
 IPC::Connection* NetworkSocketChannel::messageSenderConnection() const
 {
 return _connectionToWebProcess.connection();


Modified: trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.h (256889 => 256890)

--- trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.h	2020-02-19 00:49:13 UTC (rev 256889)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.h	2020-02-19 01:06:26 UTC (rev 256890)
@@ -67,6 +67,8 @@
 void didReceiveBinaryData(const uint8_t* data, size_t length);
 void didClose(unsigned short code, const String& reason);
 void didReceiveMessageError(const String&);
+void didSendHandshakeRequest(WebCore::ResourceRequest&&);
+void didReceiveHandshakeResponse(WebCore::ResourceResponse&&);
 
 

[webkit-changes] [256889] trunk/Tools

[Hironori . Fujii]

Title: [256889] trunk/Tools








Revision 256889
Author hironori.fu...@sony.com
Date 2020-02-18 16:49:13 -0800 (Tue, 18 Feb 2020)


Log Message
[Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
https://bugs.webkit.org/show_bug.cgi?id=207883

Reviewed by Ross Kirsling.

Unlike other mouse buttons, 4th and 5th mouse buttons are
processed differently. Clicking them dispatches WM_XBUTTONDOWN and
WM_XBUTTONUP events to the window under the mouse cursor.
Unhandled WM_XBUTTONUP events are automatically converted to
WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
parent window.


Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
handled.

* MiniBrowser/win/BrowserWindow.h:
* MiniBrowser/win/MainWindow.cpp:
(MainWindow::WndProc):
* MiniBrowser/win/WebKitBrowserWindow.cpp:
(WebKitBrowserWindow::navigateForwardOrBackward):
* MiniBrowser/win/WebKitBrowserWindow.h:
* MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
(WebKitLegacyBrowserWindow::navigateForwardOrBackward):
* MiniBrowser/win/WebKitLegacyBrowserWindow.h:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/win/BrowserWindow.h
trunk/Tools/MiniBrowser/win/MainWindow.cpp
trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.cpp
trunk/Tools/MiniBrowser/win/WebKitBrowserWindow.h
trunk/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp
trunk/Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.h




Diff

Modified: trunk/Tools/ChangeLog (256888 => 256889)

--- trunk/Tools/ChangeLog	2020-02-19 00:48:04 UTC (rev 256888)
+++ trunk/Tools/ChangeLog	2020-02-19 00:49:13 UTC (rev 256889)
@@ -1,3 +1,31 @@
+2020-02-18  Fujii Hironori  
+
+[Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
+https://bugs.webkit.org/show_bug.cgi?id=207883
+
+Reviewed by Ross Kirsling.
+
+Unlike other mouse buttons, 4th and 5th mouse buttons are
+processed differently. Clicking them dispatches WM_XBUTTONDOWN and
+WM_XBUTTONUP events to the window under the mouse cursor.
+Unhandled WM_XBUTTONUP events are automatically converted to
+WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
+parent window.
+
+
+Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
+handled.
+
+* MiniBrowser/win/BrowserWindow.h:
+* MiniBrowser/win/MainWindow.cpp:
+(MainWindow::WndProc):
+* MiniBrowser/win/WebKitBrowserWindow.cpp:
+(WebKitBrowserWindow::navigateForwardOrBackward):
+* MiniBrowser/win/WebKitBrowserWindow.h:
+* MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
+(WebKitLegacyBrowserWindow::navigateForwardOrBackward):
+* MiniBrowser/win/WebKitLegacyBrowserWindow.h:
+
 2020-02-18  Alex Christensen  
 
 Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types


Modified: trunk/Tools/MiniBrowser/win/BrowserWindow.h (256888 => 256889)

--- trunk/Tools/MiniBrowser/win/BrowserWindow.h	2020-02-19 00:48:04 UTC (rev 256888)
+++ trunk/Tools/MiniBrowser/win/BrowserWindow.h	2020-02-19 00:49:13 UTC (rev 256889)
@@ -44,7 +44,7 @@
 
 virtual HRESULT loadURL(const BSTR& passedURL) = 0;
 virtual void reload() = 0;
-virtual void navigateForwardOrBackward(UINT menuID) = 0;
+virtual void navigateForwardOrBackward(bool forward) = 0;
 virtual void navigateToHistory(UINT menuID) = 0;
 virtual void setPreference(UINT menuID, bool enable) = 0;
 virtual bool usesLayeredWebView() const { return false; }


Modified: trunk/Tools/MiniBrowser/win/MainWindow.cpp (256888 => 256889)

--- trunk/Tools/MiniBrowser/win/MainWindow.cpp	2020-02-19 00:48:04 UTC (rev 256888)
+++ trunk/Tools/MiniBrowser/win/MainWindow.cpp	2020-02-19 00:49:13 UTC (rev 256889)
@@ -253,6 +253,7 @@
 
 LRESULT CALLBACK MainWindow::WndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
 {
+LRESULT result = 0;
 RefPtr thisWindow = reinterpret_cast(GetWindowLongPtr(hWnd, GWLP_USERDATA));
 switch (message) {
 case WM_ACTIVATE:
@@ -265,6 +266,28 @@
 case WM_CREATE:
 SetWindowLongPtr(hWnd, GWLP_USERDATA, reinterpret_cast(reinterpret_cast(lParam)->lpCreateParams));
 break;
+case WM_APPCOMMAND: {
+auto cmd = GET_APPCOMMAND_LPARAM(lParam);
+switch (cmd) {
+case APPCOMMAND_BROWSER_BACKWARD:
+thisWindow->browserWindow()->navigateForwardOrBackward(false);
+result = 1;
+break;
+case APPCOMMAND_BROWSER_FORWARD:
+thisWindow->browserWindow()->navigateForwardOrBackward(true);
+result = 1;
+break;
+case APPCOMMAND_BROWSER_HOME:
+break;
+case APPCOMMAND_BROWSER_REFRESH:
+thisWindow->browserWindow()->reload();
+result = 1;
+break;
+case 

[webkit-changes] [256885] branches/safari-609-branch

[repstein]

Title: [256885] branches/safari-609-branch








Revision 256885
Author repst...@apple.com
Date 2020-02-18 16:47:55 -0800 (Tue, 18 Feb 2020)


Log Message
Cherry-pick r256665. rdar://problem/59551715

[WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention.
https://bugs.webkit.org/show_bug.cgi?id=207727

JSTests:

Reviewed by Mark Lam.

* wasm/regress/llint-callee-saves-with-fast-memory.js: Added.
* wasm/regress/llint-callee-saves-without-fast-memory.js: Added.

Source/_javascript_Core:

Reviewed by Mark Lam.

The Wasm JIT has unusual calling conventions, which were further complicated by the addition
of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly
saving and restoring the callee save registers used for the memory base and size). Here's a summary
of the calling convention:

- When entering Wasm from JS, the wrapper must:
- Preserve the base and size when entering LLInt regardless of the mode. (Prior to this
  patch we only preserved the base in Signaling mode)
- Preserve the memory base in either mode, and the size for BoundsChecking.
- Both tiers must preserve every *other* register they use. e.g. the LLInt must preserve PB
  and wasmInstance, but must *not* preserve memoryBase and memorySize.
- Changes to memoryBase and memorySize are visible to the caller. This means that:
- Intra-module calls can assume these registers are up-to-date even if the memory was
  resized. The only exception here is if the LLInt calls a signaling JIT, in which case
  the JIT will not update the size register, since it won't be using it.
- Inter-module and JS calls require the caller to reload these registers. These calls may
  result in memory changes (e.g. the callee may call memory.grow).
- A Signaling JIT caller must be aware that the LLInt may trash the size register, since
  it always bounds checks.

* llint/WebAssembly.asm:
* wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::addCall):
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addCall):
* wasm/WasmCallee.cpp:
(JSC::Wasm::LLIntCallee::calleeSaveRegisters):
* wasm/WasmCallingConvention.h:
* wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::didCompleteCompilation):
* wasm/WasmMemoryInformation.cpp:
(JSC::Wasm::PinnedRegisterInfo::get):
(JSC::Wasm::getPinnedRegisters): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/JSTests/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/llint/WebAssembly.asm
branches/safari-609-branch/Source/_javascript_Core/wasm/WasmAirIRGenerator.cpp
branches/safari-609-branch/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
branches/safari-609-branch/Source/_javascript_Core/wasm/WasmCallee.cpp
branches/safari-609-branch/Source/_javascript_Core/wasm/WasmCallingConvention.h
branches/safari-609-branch/Source/_javascript_Core/wasm/WasmLLIntPlan.cpp
branches/safari-609-branch/Source/_javascript_Core/wasm/WasmMemoryInformation.cpp


Added Paths

branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js
branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js




Diff

Modified: branches/safari-609-branch/JSTests/ChangeLog (256884 => 256885)

--- branches/safari-609-branch/JSTests/ChangeLog	2020-02-19 00:47:48 UTC (rev 256884)
+++ branches/safari-609-branch/JSTests/ChangeLog	2020-02-19 00:47:55 UTC (rev 256885)
@@ -1,3 +1,68 @@
+2020-02-18  Alan Coon  
+
+Cherry-pick r256665. rdar://problem/59551715
+
+[WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention.
+https://bugs.webkit.org/show_bug.cgi?id=207727
+
+JSTests:
+
+Reviewed by Mark Lam.
+
+* wasm/regress/llint-callee-saves-with-fast-memory.js: Added.
+* wasm/regress/llint-callee-saves-without-fast-memory.js: Added.
+
+Source/_javascript_Core:
+
+Reviewed by Mark Lam.
+
+The Wasm JIT has unusual calling conventions, which were further complicated by the addition
+of the interpreter, and the interpreter did not correctly follow these conventions (by incorrectly
+saving and restoring the callee save registers used for the memory base and size). Here's a summary
+of the calling convention:
+
+- When entering Wasm from JS, the wrapper must:
+- Preserve the base and size when entering LLInt regardless of the mode. (Prior to this
+  patch we only preserved the base in Signaling mode)
+- Preserve the memory base in either mode, and the size for BoundsChecking.
+- Both tiers must preserve every *other* register they use. e.g. the LLInt must 

[webkit-changes] [256887] branches/safari-609-branch

[repstein]

Title: [256887] branches/safari-609-branch








Revision 256887
Author repst...@apple.com
Date 2020-02-18 16:48:00 -0800 (Tue, 18 Feb 2020)


Log Message
Cherry-pick r256766. rdar://problem/59551706

[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
https://bugs.webkit.org/show_bug.cgi?id=207849

Reviewed by Mark Lam.

JSTests:

* wasm/regress/regress-256665.js: Added.
(f):

Source/_javascript_Core:

When generating the call IC, we should select the callee saves using BoundsChecking mode in order
to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
register when calling the Wasm LLInt through the call IC.

* wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::calleeSaves const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/JSTests/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/wasm/js/WebAssemblyFunction.cpp


Added Paths

branches/safari-609-branch/JSTests/wasm/regress/regress-256665.js




Diff

Modified: branches/safari-609-branch/JSTests/ChangeLog (256886 => 256887)

--- branches/safari-609-branch/JSTests/ChangeLog	2020-02-19 00:47:57 UTC (rev 256886)
+++ branches/safari-609-branch/JSTests/ChangeLog	2020-02-19 00:48:00 UTC (rev 256887)
@@ -1,5 +1,41 @@
 2020-02-18  Alan Coon  
 
+Cherry-pick r256766. rdar://problem/59551706
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
+Source/_javascript_Core:
+
+When generating the call IC, we should select the callee saves using BoundsChecking mode in order
+to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
+register when calling the Wasm LLInt through the call IC.
+
+* wasm/js/WebAssemblyFunction.cpp:
+(JSC::WebAssemblyFunction::calleeSaves const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-17  Tadeu Zagallo  
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
+2020-02-18  Alan Coon  
+
 Cherry-pick r256698. rdar://problem/59551715
 
 Unreviewed: fix broken tests added in r256665


Added: branches/safari-609-branch/JSTests/wasm/regress/regress-256665.js (0 => 256887)

--- branches/safari-609-branch/JSTests/wasm/regress/regress-256665.js	(rev 0)
+++ branches/safari-609-branch/JSTests/wasm/regress/regress-256665.js	2020-02-19 00:48:00 UTC (rev 256887)
@@ -0,0 +1,12 @@
+//@ requireOptions("--useConcurrentJIT=false", "--jitPolicyScale=0")
+
+function f() {
+var buffer = new Uint8Array([0, 97, 115, 109, 1, 0, 0, 0, 1, 6, 1, 96, 1, 127, 1, 127, 3, 2, 1, 0, 5, 3, 1, 0, 0, 7, 8, 1, 4, 108, 111, 97, 100, 0, 0, 10, 9, 1, 7, 0, 32, 0, 40, 0, 100, 11]);
+var module = new WebAssembly.Module(buffer);
+var instance = new WebAssembly.Instance(module);
+try { instance.exports.load(0x1 - 100 - 4); } catch (e) {}
+(555)[0];
+}
+
+f();
+f();


Modified: branches/safari-609-branch/Source/_javascript_Core/ChangeLog (256886 => 256887)

--- branches/safari-609-branch/Source/_javascript_Core/ChangeLog	2020-02-19 00:47:57 UTC (rev 256886)
+++ branches/safari-609-branch/Source/_javascript_Core/ChangeLog	2020-02-19 00:48:00 UTC (rev 256887)
@@ -1,5 +1,45 @@
 2020-02-18  Alan Coon  
 
+Cherry-pick r256766. rdar://problem/59551706
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed by Mark Lam.
+
+JSTests:
+
+* wasm/regress/regress-256665.js: Added.
+(f):
+
+Source/_javascript_Core:
+
+When generating the call IC, we should select the callee saves using BoundsChecking mode in order
+to obey to the calling conventions described in r256665. Currently, we won't restore the memory size
+register when calling the Wasm LLInt through the call IC.
+
+* wasm/js/WebAssemblyFunction.cpp:
+(JSC::WebAssemblyFunction::calleeSaves const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-17  Tadeu Zagallo  
+
+[Wasm] REGRESSION(r256665): Wasm->JS call IC needs to save memory size register
+https://bugs.webkit.org/show_bug.cgi?id=207849
+
+Reviewed 

[webkit-changes] [256884] branches/safari-609-branch/Source

[repstein]

Title: [256884] branches/safari-609-branch/Source








Revision 256884
Author repst...@apple.com
Date 2020-02-18 16:47:48 -0800 (Tue, 18 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256883 => 256884)

--- branches/safari-609-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-19 00:31:46 UTC (rev 256883)
+++ branches/safari-609-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-19 00:47:48 UTC (rev 256884)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 609;
-MINOR_VERSION = 1;
-TINY_VERSION = 20;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256883 => 256884)

--- branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-19 00:31:46 UTC (rev 256883)
+++ branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-19 00:47:48 UTC (rev 256884)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 609;
-MINOR_VERSION = 1;
-TINY_VERSION = 20;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256883 => 256884)

--- branches/safari-609-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-19 00:31:46 UTC (rev 256883)
+++ branches/safari-609-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-19 00:47:48 UTC (rev 256884)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 609;
-MINOR_VERSION = 1;
-TINY_VERSION = 20;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebCore/Configurations/Version.xcconfig (256883 => 256884)

--- branches/safari-609-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-19 00:31:46 UTC (rev 256883)
+++ branches/safari-609-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-19 00:47:48 UTC (rev 256884)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 609;
-MINOR_VERSION = 1;
-TINY_VERSION = 20;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256883 => 256884)

--- branches/safari-609-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-19 00:31:46 UTC (rev 256883)
+++ branches/safari-609-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-19 00:47:48 UTC (rev 256884)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 609;
-MINOR_VERSION = 1;
-TINY_VERSION = 20;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (256883 => 256884)

--- branches/safari-609-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-19 00:31:46 UTC (rev 256883)
+++ branches/safari-609-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-19 00:47:48 UTC (rev 256884)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 609;
-MINOR_VERSION = 1;
-TINY_VERSION = 20;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebKit/Configurations/Version.xcconfig (256883 => 256884)

--- branches/safari-609-branch/Source/WebKit/Configurations/Version.xcconfig	2020-02-19 00:31:46 UTC (rev 256883)
+++ 

[webkit-changes] [256886] branches/safari-609-branch/JSTests

[repstein]

Title: [256886] branches/safari-609-branch/JSTests








Revision 256886
Author repst...@apple.com
Date 2020-02-18 16:47:57 -0800 (Tue, 18 Feb 2020)


Log Message
Cherry-pick r256698. rdar://problem/59551715

Unreviewed: fix broken tests added in r256665
https://bugs.webkit.org/show_bug.cgi?id=207727

Our inline WAT doesn't seem to like named blocks/branch targets.

* wasm/regress/llint-callee-saves-with-fast-memory.js:
* wasm/regress/llint-callee-saves-without-fast-memory.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/JSTests/ChangeLog
branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js
branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js




Diff

Modified: branches/safari-609-branch/JSTests/ChangeLog (256885 => 256886)

--- branches/safari-609-branch/JSTests/ChangeLog	2020-02-19 00:47:55 UTC (rev 256885)
+++ branches/safari-609-branch/JSTests/ChangeLog	2020-02-19 00:47:57 UTC (rev 256886)
@@ -1,5 +1,29 @@
 2020-02-18  Alan Coon  
 
+Cherry-pick r256698. rdar://problem/59551715
+
+Unreviewed: fix broken tests added in r256665
+https://bugs.webkit.org/show_bug.cgi?id=207727
+
+Our inline WAT doesn't seem to like named blocks/branch targets.
+
+* wasm/regress/llint-callee-saves-with-fast-memory.js:
+* wasm/regress/llint-callee-saves-without-fast-memory.js:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-14  Tadeu Zagallo  
+
+Unreviewed: fix broken tests added in r256665
+https://bugs.webkit.org/show_bug.cgi?id=207727
+
+Our inline WAT doesn't seem to like named blocks/branch targets.
+
+* wasm/regress/llint-callee-saves-with-fast-memory.js:
+* wasm/regress/llint-callee-saves-without-fast-memory.js:
+
+2020-02-18  Alan Coon  
+
 Cherry-pick r256665. rdar://problem/59551715
 
 [WASM] Wasm interpreter's calling convention doesn't match Wasm JIT's convention.


Modified: branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js (256885 => 256886)

--- branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js	2020-02-19 00:47:55 UTC (rev 256885)
+++ branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-with-fast-memory.js	2020-02-19 00:47:57 UTC (rev 256886)
@@ -23,11 +23,11 @@
 (func (export "main")
 (local $i i32)
 (local.set $i (i32.const 10))
-(loop $warmup
+(loop
 (i32.sub (local.get $i) (i32.const 1))
 (local.tee $i)
 (call $f (i32.const 1))
-(br_if $warmup)
+(br_if 0)
 )
 (call $f (i32.const 0))
 )


Modified: branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js (256885 => 256886)

--- branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js	2020-02-19 00:47:55 UTC (rev 256885)
+++ branches/safari-609-branch/JSTests/wasm/regress/llint-callee-saves-without-fast-memory.js	2020-02-19 00:47:57 UTC (rev 256886)
@@ -21,11 +21,11 @@
 (func (export "main")
 (local $i i32)
 (local.set $i (i32.const 10))
-(loop $warmup
+(loop
 (i32.sub (local.get $i) (i32.const 1))
 (local.tee $i)
 (call $f (i32.const 1))
-(br_if $warmup)
+(br_if 0)
 )
 (call $f (i32.const 0))
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256888] branches/safari-609-branch

[repstein]

Title: [256888] branches/safari-609-branch








Revision 256888
Author repst...@apple.com
Date 2020-02-18 16:48:04 -0800 (Tue, 18 Feb 2020)


Log Message
Cherry-pick r256779. rdar://problem/59551695

[JSC] JITThunk should be HashSet> with appropriate GC weakness handling
https://bugs.webkit.org/show_bug.cgi?id=207715

Reviewed by Darin Adler.

JSTests:

* stress/stress-jitthunks.js: Added.
(let.set newGlobal):
(set catch):

Source/_javascript_Core:

This patch refines JITThunks GC-aware Weak hash map for NativeExecutable. Previously, we have
HashMap, Weak> table.
But this is not good because the first tuple's information is already in NativeExecutable.
But we were using this design since Weak can be nullified because of Weak<>. If this
happens, we could have invalid Entry in HashMap which does not have corresponding values. This will
cause crash when rehasing requires hash code for this entry.

But this HashMap is very bad in terms of memory usage. Each entry has 32 bytes, and this table gets enough
large. We identified that this table is consuming much memory in Membuster. So it is worth designing
carefully crafted data structure which only holds Weak by leveraging the deep interaction
with our GC implementation.

This patch implements new design of JITThunks, which uses HashSet> and carefully crafted
HashTraits / KeyTraits to handle Weak<> well.

1. Each Weak should have finalizer, and this finalizer should remove dead Weak from HashSet.

This is ensuring that all the keys in HashSet is, even if Weak<> is saying it is Dead, it still has an way
to access content of NativeExecutable if the content is not a JS objects. For example, we can get function
pointer from dead Weak if it is not yet finalized. Since we remove all finalized Weak<>
from the table, this finalizer mechanism allows us to access function pointers etc. from Weak
so long as it is held in this table.

2. Getting NativeExecutable* from JITThunks should have special protocol.

When getting NativeExecutable* from JITThunks, we do the following,

1. First, we check we have an Entry in JITThunks. If it does not exist, we should insert it anyway.
1.1. If it exists, we should check whether this Weak is dead or not. It is possible that
 dead one is still in the table because "dead" does not mean that it is "finalized". Until finalizing happens (and
 it can be delayed by incremental-sweeper), Weak can be dead but still accessible. So the table
 is still holding dead one. If we get dead one, we should insert a new one.
1.2. If it is not dead, we return it.
2. Second, we create a new NativeExecutable and insert it. In that case, it is possible that the table already has Weak,
   but it is dead. In that case, we need to explicitly replace it with newly created one since old one is holding old content. If we
   replaced, finalizer of Weak<> will not be invoked since it immediately deallocates Weak<>. So, it does not happen that this newly
   inserted NativeExecutable* is removed by the finalizer registered by the old Weak<>.

This change makes memory usage of JITThunks table 1/4.

* heap/Weak.cpp:
(JSC::weakClearSlowCase):
* heap/Weak.h:
(JSC::Weak::Weak):
(JSC::Weak::isHashTableEmptyValue const):
(JSC::Weak::unsafeImpl const):
(WTF::HashTraits>::isEmptyValue):
* heap/WeakInlines.h:
(JSC::Weak::Weak):
* jit/JITThunks.cpp:
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::WeakNativeExecutableHash::hash):
(JSC::JITThunks::WeakNativeExecutableHash::equal):
(JSC::JITThunks::HostKeySearcher::hash):
(JSC::JITThunks::HostKeySearcher::equal):
(JSC::JITThunks::NativeExecutableTranslator::hash):
(JSC::JITThunks::NativeExecutableTranslator::equal):
(JSC::JITThunks::NativeExecutableTranslator::translate):
(JSC::JITThunks::finalize):
(JSC::JITThunks::hostFunctionStub):
(JSC::JITThunks::clearHostFunctionStubs): Deleted.
* jit/JITThunks.h:
* runtime/NativeExecutable.h:
* tools/JSDollarVM.cpp:
(JSC::functionGCSweepAsynchronously):
(JSC::functionCreateEmptyFunctionWithName):
(JSC::JSDollarVM::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/JSTests/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/ChangeLog
branches/safari-609-branch/Source/_javascript_Core/heap/Weak.cpp
branches/safari-609-branch/Source/_javascript_Core/heap/Weak.h
branches/safari-609-branch/Source/_javascript_Core/heap/WeakInlines.h
branches/safari-609-branch/Source/_javascript_Core/jit/JITThunks.cpp
branches/safari-609-branch/Source/_javascript_Core/jit/JITThunks.h

[webkit-changes] [256883] trunk/Source/WebCore

[zalan]

Title: [256883] trunk/Source/WebCore








Revision 256883
Author za...@apple.com
Date 2020-02-18 16:31:46 -0800 (Tue, 18 Feb 2020)


Log Message
[First paint] Remove elementOverflowRectIsLargerThanThreshold check in qualifiesAsVisuallyNonEmpty
https://bugs.webkit.org/show_bug.cgi?id=207907


Reviewed by Geoffrey Garen.

This is in preparation for being able to qualify for visually non-empty content without looking at geometry.
This check was added long ago, initially with a 200px value which got reduced to 48px to reduce painting latency on google search result page.
At this point a 48px threshold does not make too much sense.

* page/FrameView.cpp:
(WebCore::FrameView::qualifiesAsSignificantRenderedText const):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::elementOverflowRectIsLargerThanThreshold): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (256882 => 256883)

--- trunk/Source/WebCore/ChangeLog	2020-02-19 00:21:49 UTC (rev 256882)
+++ trunk/Source/WebCore/ChangeLog	2020-02-19 00:31:46 UTC (rev 256883)
@@ -1,3 +1,20 @@
+2020-02-18  Zalan Bujtas  
+
+[First paint] Remove elementOverflowRectIsLargerThanThreshold check in qualifiesAsVisuallyNonEmpty
+https://bugs.webkit.org/show_bug.cgi?id=207907
+
+
+Reviewed by Geoffrey Garen.
+
+This is in preparation for being able to qualify for visually non-empty content without looking at geometry.
+This check was added long ago, initially with a 200px value which got reduced to 48px to reduce painting latency on google search result page.
+At this point a 48px threshold does not make too much sense.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::qualifiesAsSignificantRenderedText const):
+(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
+(WebCore::elementOverflowRectIsLargerThanThreshold): Deleted.
+
 2020-02-18  Daniel Bates  
 
 Ask the EditorClient whether to reveal the current selection after insertion


Modified: trunk/Source/WebCore/page/FrameView.cpp (256882 => 256883)

--- trunk/Source/WebCore/page/FrameView.cpp	2020-02-19 00:21:49 UTC (rev 256882)
+++ trunk/Source/WebCore/page/FrameView.cpp	2020-02-19 00:31:46 UTC (rev 256883)
@@ -4387,17 +4387,6 @@
 ++m_textRendererCountForVisuallyNonEmptyCharacters;
 }
 
-static bool elementOverflowRectIsLargerThanThreshold(const Element& element)
-{
-// Require the document to grow a bit.
-// Using a value of 48 allows the header on Google's search page to render immediately before search results populate later.
-static const int documentHeightThreshold = 48;
-if (auto* elementRenderBox = element.renderBox())
-return snappedIntRect(elementRenderBox->layoutOverflowRect()).height() >= documentHeightThreshold;
-
-return false;
-}
-
 void FrameView::updateHasReachedSignificantRenderedTextThreshold()
 {
 if (m_hasReachedSignificantRenderedTextThreshold)
@@ -4430,11 +4419,6 @@
 auto* document = frame().document();
 if (!document || document->styleScope().hasPendingSheetsBeforeBody())
 return false;
-
-auto* documentElement = document->documentElement();
-if (!documentElement || !elementOverflowRectIsLargerThanThreshold(*documentElement))
-return false;
-
 return m_hasReachedSignificantRenderedTextThreshold;
 }
 
@@ -4468,9 +4452,6 @@
 if (!isVisible(frame().document()->body()))
 return false;
 
-if (!elementOverflowRectIsLargerThanThreshold(*documentElement))
-return false;
-
 // The first few hundred characters rarely contain the interesting content of the page.
 if (m_visuallyNonEmptyCharacterCount > visualCharacterThreshold)
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256882] trunk/Source/WebKit

[cdumez]

Title: [256882] trunk/Source/WebKit








Revision 256882
Author cdu...@apple.com
Date 2020-02-18 16:21:49 -0800 (Tue, 18 Feb 2020)


Log Message
Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called
https://bugs.webkit.org/show_bug.cgi?id=207905

Reviewed by Alex Christensen.

Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called. It is bad for
performance as we cannot leverage the process cache if we don't know the domain of the site that
will be loaded.

Instead we now queue those injected bundle messages until we really need to launch the process.

No new tests, WebKitTestRunner extensively relies on this private API already, and was the
reason we did the eager process launch in the first place (https://trac.webkit.org/changeset/243156).

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcess):
* UIProcess/WebPageProxy.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (256881 => 256882)

--- trunk/Source/WebKit/ChangeLog	2020-02-19 00:13:59 UTC (rev 256881)
+++ trunk/Source/WebKit/ChangeLog	2020-02-19 00:21:49 UTC (rev 256882)
@@ -1,5 +1,25 @@
 2020-02-18  Chris Dumez  
 
+Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called
+https://bugs.webkit.org/show_bug.cgi?id=207905
+
+Reviewed by Alex Christensen.
+
+Do not eagerly launch WebProcess when WKPagePostMessageToInjectedBundle() is called. It is bad for
+performance as we cannot leverage the process cache if we don't know the domain of the site that
+will be loaded.
+
+Instead we now queue those injected bundle messages until we really need to launch the process.
+
+No new tests, WebKitTestRunner extensively relies on this private API already, and was the
+reason we did the eager process launch in the first place (https://trac.webkit.org/changeset/243156).
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::launchProcess):
+* UIProcess/WebPageProxy.h:
+
+2020-02-18  Chris Dumez  
+
 Drop getSandboxExtensionsForBlobFiles() as it is dead code
 https://bugs.webkit.org/show_bug.cgi?id=207909
 


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (256881 => 256882)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-19 00:13:59 UTC (rev 256881)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-19 00:21:49 UTC (rev 256882)
@@ -776,6 +776,10 @@
 m_process->addMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_webPageID, *this);
 
 finishAttachingToWebProcess(reason);
+
+auto pendingInjectedBundleMessage = WTFMove(m_pendingInjectedBundleMessages);
+for (auto& message : pendingInjectedBundleMessage)
+send(Messages::WebPage::PostInjectedBundleMessage(message.messageName, UserData(process().transformObjectsToHandles(message.messageBody.get()).get(;
 }
 
 bool WebPageProxy::suspendCurrentPageIfPossible(API::Navigation& navigation, Optional mainFrameID, ProcessSwapRequestedByClient processSwapRequestedByClient, ShouldDelayClosingUntilEnteringAcceleratedCompositingMode shouldDelayClosingUntilEnteringAcceleratedCompositingMode)
@@ -6282,8 +6286,10 @@
 
 void WebPageProxy::postMessageToInjectedBundle(const String& messageName, API::Object* messageBody)
 {
-// For backward-compatibility, make sure we launch the initial process if the client asks to post a message to its injected bundle before doing a load.
-launchInitialProcessIfNecessary();
+if (!hasRunningProcess()) {
+m_pendingInjectedBundleMessages.append(InjectedBundleMessage { messageName, messageBody });
+return;
+}
 
 send(Messages::WebPage::PostInjectedBundleMessage(messageName, UserData(process().transformObjectsToHandles(messageBody).get(;
 }
@@ -9601,7 +9607,8 @@
 return;
 }
 networkProcess->sendWithAsyncReply(Messages::NetworkProcess::ClearAdClickAttribution(m_websiteDataStore->sessionID()), WTFMove(completionHandler));
-}
+} else
+completionHandler();
 }
 
 void WebPageProxy::setAdClickAttributionOverrideTimerForTesting(bool value, CompletionHandler&& completionHandler)


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (256881 => 256882)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.h	2020-02-19 00:13:59 UTC (rev 256881)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h	2020-02-19 00:21:49 UTC (rev 256882)
@@ -2721,6 +2721,12 @@
 bool m_isLayerTreeFrozenDueToSwipeAnimation { false };
 
 String m_overriddenMediaType;
+
+struct InjectedBundleMessage {
+String messageName;
+RefPtr messageBody;
+};
+Vector m_pendingInjectedBundleMessages;
 
 #if PLATFORM(IOS_FAMILY) && ENABLE(DEVICE_ORIENTATION)
 std::unique_ptr 

[webkit-changes] [256881] trunk/Source/WebKit

[cdumez]

Title: [256881] trunk/Source/WebKit








Revision 256881
Author cdu...@apple.com
Date 2020-02-18 16:13:59 -0800 (Tue, 18 Feb 2020)


Log Message
Drop getSandboxExtensionsForBlobFiles() as it is dead code
https://bugs.webkit.org/show_bug.cgi?id=207909


Reviewed by Per Arne Vollan.

* NetworkProcess/NetworkProcess.cpp:
* NetworkProcess/NetworkProcess.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (256880 => 256881)

--- trunk/Source/WebKit/ChangeLog	2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/ChangeLog	2020-02-19 00:13:59 UTC (rev 256881)
@@ -1,3 +1,17 @@
+2020-02-18  Chris Dumez  
+
+Drop getSandboxExtensionsForBlobFiles() as it is dead code
+https://bugs.webkit.org/show_bug.cgi?id=207909
+
+
+Reviewed by Per Arne Vollan.
+
+* NetworkProcess/NetworkProcess.cpp:
+* NetworkProcess/NetworkProcess.h:
+* UIProcess/Network/NetworkProcessProxy.cpp:
+* UIProcess/Network/NetworkProcessProxy.h:
+* UIProcess/Network/NetworkProcessProxy.messages.in:
+
 2020-02-18  Alex Christensen  
 
 Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (256880 => 256881)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp	2020-02-19 00:13:59 UTC (rev 256881)
@@ -2377,13 +2377,6 @@
 completionHandler();
 }
 
-#if ENABLE(SANDBOX_EXTENSIONS)
-void NetworkProcess::getSandboxExtensionsForBlobFiles(const Vector& filenames, CompletionHandler&& completionHandler)
-{
-parentProcessConnection()->sendWithAsyncReply(Messages::NetworkProcessProxy::GetSandboxExtensionsForBlobFiles(filenames), WTFMove(completionHandler));
-}
-#endif // ENABLE(SANDBOX_EXTENSIONS)
-
 #if ENABLE(SERVICE_WORKER)
 void NetworkProcess::forEachSWServer(const Function& callback)
 {


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (256880 => 256881)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h	2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h	2020-02-19 00:13:59 UTC (rev 256881)
@@ -287,10 +287,6 @@
 
 void resetQuota(PAL::SessionID, CompletionHandler&&);
 
-#if ENABLE(SANDBOX_EXTENSIONS)
-void getSandboxExtensionsForBlobFiles(const Vector& filenames, CompletionHandler&&);
-#endif
-
 #if ENABLE(SERVICE_WORKER)
 WebCore::SWServer* swServerForSessionIfExists(PAL::SessionID sessionID) { return m_swServers.get(sessionID); }
 WebCore::SWServer& swServerForSession(PAL::SessionID);


Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (256880 => 256881)

--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp	2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp	2020-02-19 00:13:59 UTC (rev 256881)
@@ -1285,19 +1285,6 @@
 }
 #endif
 
-#if ENABLE(SANDBOX_EXTENSIONS)
-void NetworkProcessProxy::getSandboxExtensionsForBlobFiles(const Vector& paths, Messages::NetworkProcessProxy::GetSandboxExtensionsForBlobFiles::AsyncReply&& reply)
-{
-SandboxExtension::HandleArray extensions;
-extensions.allocate(paths.size());
-for (size_t i = 0; i < paths.size(); ++i) {
-// ReadWrite is required for creating hard links, which is something that might be done with these extensions.
-SandboxExtension::createHandle(paths[i], SandboxExtension::Type::ReadWrite, extensions[i]);
-}
-reply(WTFMove(extensions));
-}
-#endif
-
 #if ENABLE(SERVICE_WORKER)
 void NetworkProcessProxy::establishWorkerContextConnectionToNetworkProcess(RegistrableDomain&& registrableDomain, PAL::SessionID sessionID, CompletionHandler&& completionHandler)
 {


Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h (256880 => 256881)

--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h	2020-02-19 00:10:57 UTC (rev 256880)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h	2020-02-19 00:13:59 UTC (rev 256881)
@@ -259,10 +259,6 @@
 void contentExtensionRules(UserContentControllerIdentifier);
 #endif
 
-#if ENABLE(SANDBOX_EXTENSIONS)
-void getSandboxExtensionsForBlobFiles(const Vector& paths, Messages::NetworkProcessProxy::GetSandboxExtensionsForBlobFilesAsyncReply&&);
-#endif
-
 #if ENABLE(SERVICE_WORKER)
 void establishWorkerContextConnectionToNetworkProcess(WebCore::RegistrableDomain&&, PAL::SessionID, 

[webkit-changes] [256880] trunk/LayoutTests

[jacob_uphoff]

Title: [256880] trunk/LayoutTests








Revision 256880
Author jacob_uph...@apple.com
Date 2020-02-18 16:10:57 -0800 (Tue, 18 Feb 2020)


Log Message
Changed results due to ANGLE use
https://bugs.webkit.org/show_bug.cgi?id=207858

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:  updating expectations for 2 more tests that surfaced as failures.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256879 => 256880)

--- trunk/LayoutTests/ChangeLog	2020-02-19 00:01:42 UTC (rev 256879)
+++ trunk/LayoutTests/ChangeLog	2020-02-19 00:10:57 UTC (rev 256880)
@@ -1,3 +1,12 @@
+2020-02-18  Jacob Uphoff  
+
+Changed results due to ANGLE use
+https://bugs.webkit.org/show_bug.cgi?id=207858
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:  updating expectations for 2 more tests that surfaced as failures.
+
 2020-02-18  Wenson Hsieh  
 
 [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256879 => 256880)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-19 00:01:42 UTC (rev 256879)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-19 00:10:57 UTC (rev 256880)
@@ -1416,6 +1416,14 @@
 webkit.org/b/207866 imported/w3c/IndexedDB-private-browsing [ Pass Timeout ]
 
 # skip LFC regression tests on iOS for now.
+<<< HEAD
 fast/layoutformattingcontext/ [ Skip ]
 
-webkit.org/b/207896 fast/canvas/webgl/oes-vertex-array-object.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207896 fast/canvas/webgl/oes-vertex-array-object.html [ Pass Failure ]
+===
+fast/layoutformattingcontext/block-only/ [ Skip ]
+
+webkit.org/b/207858 fast/canvas/webgl/oes-vertex-array-object.html [ Pass Failure ]
+
+webkit.org/b/207858 fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html [ Pass Failure ]
+>>> Changed results due to ANGLE use






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256876] branches/safari-609.1.20.2-branch/Source

[alancoon]

Title: [256876] branches/safari-609.1.20.2-branch/Source








Revision 256876
Author alanc...@apple.com
Date 2020-02-18 16:01:27 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256692. rdar://problem/59478929

Modified Paths

branches/safari-609.1.20.2-branch/Source/_javascript_Core/ChangeLog
branches/safari-609.1.20.2-branch/Source/_javascript_Core/jit/JIT.cpp
branches/safari-609.1.20.2-branch/Source/_javascript_Core/jit/JITCodeMap.h
branches/safari-609.1.20.2-branch/Source/WTF/ChangeLog
branches/safari-609.1.20.2-branch/Source/WTF/wtf/MallocPtr.h




Diff

Modified: branches/safari-609.1.20.2-branch/Source/_javascript_Core/ChangeLog (256875 => 256876)

--- branches/safari-609.1.20.2-branch/Source/_javascript_Core/ChangeLog	2020-02-19 00:01:22 UTC (rev 256875)
+++ branches/safari-609.1.20.2-branch/Source/_javascript_Core/ChangeLog	2020-02-19 00:01:27 UTC (rev 256876)
@@ -1,73 +1,5 @@
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256498. rdar://problem/59478929
-
-[JSC] Compact JITCodeMap by storing BytecodeIndex and CodeLocation separately
-https://bugs.webkit.org/show_bug.cgi?id=207673
-
-Reviewed by Mark Lam.
-
-Source/_javascript_Core:
-
-While BytecodeIndex is 4 bytes, CodeLocation is 8 bytes. So the tuple of them "JITCodeMap::Entry"
-becomes 16 bytes because it adds 4 bytes padding. We should store BytecodeIndex and CodeLocation separately
-to avoid this padding.
-
-This patch introduces JITCodeMapBuilder. We use this to build JITCodeMap data structure as a immutable final result.
-
-* jit/JIT.cpp:
-(JSC::JIT::link):
-* jit/JITCodeMap.h:
-(JSC::JITCodeMap::JITCodeMap):
-(JSC::JITCodeMap::find const):
-(JSC::JITCodeMap::operator bool const):
-(JSC::JITCodeMap::codeLocations const):
-(JSC::JITCodeMap::indexes const):
-(JSC::JITCodeMapBuilder::append):
-(JSC::JITCodeMapBuilder::finalize):
-(JSC::JITCodeMap::Entry::Entry): Deleted.
-(JSC::JITCodeMap::Entry::bytecodeIndex const): Deleted.
-(JSC::JITCodeMap::Entry::codeLocation): Deleted.
-(JSC::JITCodeMap::append): Deleted.
-(JSC::JITCodeMap::finish): Deleted.
-
-Source/WTF:
-
-* wtf/MallocPtr.h:
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-12  Yusuke Suzuki  
-
-[JSC] Compact JITCodeMap by storing BytecodeIndex and CodeLocation separately
-https://bugs.webkit.org/show_bug.cgi?id=207673
-
-Reviewed by Mark Lam.
-
-While BytecodeIndex is 4 bytes, CodeLocation is 8 bytes. So the tuple of them "JITCodeMap::Entry"
-becomes 16 bytes because it adds 4 bytes padding. We should store BytecodeIndex and CodeLocation separately
-to avoid this padding.
-
-This patch introduces JITCodeMapBuilder. We use this to build JITCodeMap data structure as a immutable final result.
-
-* jit/JIT.cpp:
-(JSC::JIT::link):
-* jit/JITCodeMap.h:
-(JSC::JITCodeMap::JITCodeMap):
-(JSC::JITCodeMap::find const):
-(JSC::JITCodeMap::operator bool const):
-(JSC::JITCodeMap::codeLocations const):
-(JSC::JITCodeMap::indexes const):
-(JSC::JITCodeMapBuilder::append):
-(JSC::JITCodeMapBuilder::finalize):
-(JSC::JITCodeMap::Entry::Entry): Deleted.
-(JSC::JITCodeMap::Entry::bytecodeIndex const): Deleted.
-(JSC::JITCodeMap::Entry::codeLocation): Deleted.
-(JSC::JITCodeMap::append): Deleted.
-(JSC::JITCodeMap::finish): Deleted.
-
-2020-02-14  Russell Epstein  
-
 Cherry-pick r256467. rdar://problem/59478994
 
 [JSC] Make RegExpCache small


Modified: branches/safari-609.1.20.2-branch/Source/_javascript_Core/jit/JIT.cpp (256875 => 256876)

--- branches/safari-609.1.20.2-branch/Source/_javascript_Core/jit/JIT.cpp	2020-02-19 00:01:22 UTC (rev 256875)
+++ branches/safari-609.1.20.2-branch/Source/_javascript_Core/jit/JIT.cpp	2020-02-19 00:01:27 UTC (rev 256876)
@@ -894,14 +894,13 @@
 patchBuffer.locationOfNearCall(compilationInfo.hotPathOther));
 }
 
-{
-JITCodeMapBuilder jitCodeMapBuilder;
-for (unsigned bytecodeOffset = 0; bytecodeOffset < m_labels.size(); ++bytecodeOffset) {
-if (m_labels[bytecodeOffset].isSet())
-jitCodeMapBuilder.append(BytecodeIndex(bytecodeOffset), patchBuffer.locationOf(m_labels[bytecodeOffset]));
-}
-m_codeBlock->setJITCodeMap(jitCodeMapBuilder.finalize());
+JITCodeMap jitCodeMap;
+for (unsigned bytecodeOffset = 0; bytecodeOffset < m_labels.size(); ++bytecodeOffset) {
+if (m_labels[bytecodeOffset].isSet())
+jitCodeMap.append(BytecodeIndex(bytecodeOffset), patchBuffer.locationOf(m_labels[bytecodeOffset]));
 }
+jitCodeMap.finish();
+

[webkit-changes] [256878] branches/safari-609.1.20.2-branch/Source/JavaScriptCore

[alancoon]

Title: [256878] branches/safari-609.1.20.2-branch/Source/_javascript_Core








Revision 256878
Author alanc...@apple.com
Date 2020-02-18 16:01:38 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256690. rdar://problem/59478994

Modified Paths

branches/safari-609.1.20.2-branch/Source/_javascript_Core/ChangeLog
branches/safari-609.1.20.2-branch/Source/_javascript_Core/runtime/RegExpKey.h




Diff

Modified: branches/safari-609.1.20.2-branch/Source/_javascript_Core/ChangeLog (256877 => 256878)

--- branches/safari-609.1.20.2-branch/Source/_javascript_Core/ChangeLog	2020-02-19 00:01:34 UTC (rev 256877)
+++ branches/safari-609.1.20.2-branch/Source/_javascript_Core/ChangeLog	2020-02-19 00:01:38 UTC (rev 256878)
@@ -1,31 +1,5 @@
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256467. rdar://problem/59478994
-
-[JSC] Make RegExpCache small
-https://bugs.webkit.org/show_bug.cgi?id=207619
-
-Reviewed by Mark Lam.
-
-We can compact RegExpKey by using PackedRefPtr, so that we can shrink memory consumption of RegExpCache.
-
-* runtime/RegExpKey.h:
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-12  Yusuke Suzuki  
-
-[JSC] Make RegExpCache small
-https://bugs.webkit.org/show_bug.cgi?id=207619
-
-Reviewed by Mark Lam.
-
-We can compact RegExpKey by using PackedRefPtr, so that we can shrink memory consumption of RegExpCache.
-
-* runtime/RegExpKey.h:
-
-2020-02-14  Russell Epstein  
-
 Cherry-pick r254681. rdar://problem/59474790
 
 [Win] Fix AppleWin build


Modified: branches/safari-609.1.20.2-branch/Source/_javascript_Core/runtime/RegExpKey.h (256877 => 256878)

--- branches/safari-609.1.20.2-branch/Source/_javascript_Core/runtime/RegExpKey.h	2020-02-19 00:01:34 UTC (rev 256877)
+++ branches/safari-609.1.20.2-branch/Source/_javascript_Core/runtime/RegExpKey.h	2020-02-19 00:01:38 UTC (rev 256878)
@@ -36,7 +36,7 @@
 
 struct RegExpKey {
 OptionSet flagsValue;
-PackedRefPtr pattern;
+RefPtr pattern;
 
 RegExpKey()
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256875] branches/safari-609.1.20.2-branch/Source/WebCore

[alancoon]

Title: [256875] branches/safari-609.1.20.2-branch/Source/WebCore








Revision 256875
Author alanc...@apple.com
Date 2020-02-18 16:01:22 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256696. rdar://problem/59478734

Modified Paths

branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.2-branch/Source/WebCore/page/Frame.cpp




Diff

Modified: branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog (256874 => 256875)

--- branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog	2020-02-19 00:01:16 UTC (rev 256874)
+++ branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog	2020-02-19 00:01:22 UTC (rev 256875)
@@ -4,39 +4,6 @@
 
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256636. rdar://problem/59478734
-
-[Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
-https://bugs.webkit.org/show_bug.cgi?id=207784
-
-
-Patch by Antoine Quint  on 2020-02-14
-Reviewed by Dean Jackson.
-
-After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
-call should the Web Animations flag be on.
-
-* page/Frame.cpp:
-(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-14  Antoine Quint  
-
-[Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
-https://bugs.webkit.org/show_bug.cgi?id=207784
-
-
-Reviewed by Dean Jackson.
-
-After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
-call should the Web Animations flag be on.
-
-* page/Frame.cpp:
-(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
-
-2020-02-14  Russell Epstein  
-
 Cherry-pick r256623. rdar://problem/59478938
 
 Ensure animations that lose their effect don't schedule an animation update


Modified: branches/safari-609.1.20.2-branch/Source/WebCore/page/Frame.cpp (256874 => 256875)

--- branches/safari-609.1.20.2-branch/Source/WebCore/page/Frame.cpp	2020-02-19 00:01:16 UTC (rev 256874)
+++ branches/safari-609.1.20.2-branch/Source/WebCore/page/Frame.cpp	2020-02-19 00:01:22 UTC (rev 256875)
@@ -962,12 +962,7 @@
 m_doc->resumeScheduledTasks(ReasonForSuspension::PageWillBeSuspended);
 
 // Frame::clearTimers() suspended animations and pending relayouts.
-
-if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled()) {
-if (auto* timeline = m_doc->existingTimeline())
-timeline->resumeAnimations();
-} else
-animation().resumeAnimationsForDocument(m_doc.get());
+animation().resumeAnimationsForDocument(m_doc.get());
 if (m_view)
 m_view->layoutContext().scheduleLayout();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256877] branches/safari-609.1.20.2-branch/Source

[alancoon]

Title: [256877] branches/safari-609.1.20.2-branch/Source








Revision 256877
Author alanc...@apple.com
Date 2020-02-18 16:01:34 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256691. rdar://problem/59478881

Modified Paths

branches/safari-609.1.20.2-branch/Source/WTF/ChangeLog
branches/safari-609.1.20.2-branch/Source/WTF/wtf/Markable.h
branches/safari-609.1.20.2-branch/Source/WTF/wtf/ObjectIdentifier.h
branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.2-branch/Source/WebCore/loader/FetchOptions.h
branches/safari-609.1.20.2-branch/Source/WebCore/loader/ResourceLoaderOptions.h
branches/safari-609.1.20.2-branch/Source/WebCore/loader/cache/CachedImage.cpp
branches/safari-609.1.20.2-branch/Source/WebCore/loader/cache/CachedImage.h
branches/safari-609.1.20.2-branch/Source/WebCore/loader/cache/CachedResource.cpp
branches/safari-609.1.20.2-branch/Source/WebCore/loader/cache/CachedResource.h
branches/safari-609.1.20.2-branch/Source/WebCore/page/csp/ContentSecurityPolicyResponseHeaders.h
branches/safari-609.1.20.2-branch/Source/WebCore/platform/network/NetworkLoadMetrics.h
branches/safari-609.1.20.2-branch/Source/WebCore/platform/network/ResourceLoadPriority.h
branches/safari-609.1.20.2-branch/Source/WebCore/platform/network/ResourceRequestBase.h
branches/safari-609.1.20.2-branch/Source/WebCore/platform/network/ResourceResponseBase.h
branches/safari-609.1.20.2-branch/Source/WebCore/platform/network/StoredCredentialsPolicy.h




Diff

Modified: branches/safari-609.1.20.2-branch/Source/WTF/ChangeLog (256876 => 256877)

--- branches/safari-609.1.20.2-branch/Source/WTF/ChangeLog	2020-02-19 00:01:27 UTC (rev 256876)
+++ branches/safari-609.1.20.2-branch/Source/WTF/ChangeLog	2020-02-19 00:01:34 UTC (rev 256877)
@@ -34,80 +34,6 @@
 
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256482. rdar://problem/59478881
-
-Shrink CachedResource
-https://bugs.webkit.org/show_bug.cgi?id=207618
-
-Reviewed by Mark Lam.
-
-Source/WebCore:
-
-This patch shrinks sizeof(CachedResource) by 80 bytes by aggressively using bit-fields and Markable<>.
-For each enum class, we define `bitsOfXXX` value, which indicates # of bits to represent it. And using
-this value for bit-field's width.
-
-No behavior change.
-
-* loader/FetchOptions.h:
-(WebCore::FetchOptions::encode const):
-* loader/ResourceLoaderOptions.h:
-(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
-(WebCore::ResourceLoaderOptions::loadedFromOpaqueSource):
-* loader/cache/CachedImage.cpp:
-(WebCore::CachedImage::CachedImage):
-(WebCore::CachedImage::shouldDeferUpdateImageData const):
-(WebCore::CachedImage::didUpdateImageData):
-* loader/cache/CachedImage.h:
-* loader/cache/CachedResource.cpp:
-(WebCore::CachedResource::CachedResource):
-(WebCore::CachedResource::load):
-(WebCore::CachedResource::finish):
-* loader/cache/CachedResource.h:
-(WebCore::CachedResource::setStatus):
-* page/csp/ContentSecurityPolicyResponseHeaders.h:
-(WebCore::ContentSecurityPolicyResponseHeaders::MarkableTraits::isEmptyValue):
-(WebCore::ContentSecurityPolicyResponseHeaders::MarkableTraits::emptyValue):
-(WebCore::ContentSecurityPolicyResponseHeaders::ContentSecurityPolicyResponseHeaders):
-* platform/network/NetworkLoadMetrics.h:
-(WebCore::NetworkLoadMetrics::isolatedCopy const):
-(WebCore::NetworkLoadMetrics::clearNonTimingData):
-(WebCore::NetworkLoadMetrics::operator== const):
-(WebCore::NetworkLoadMetrics::encode const):
-(WebCore::NetworkLoadMetrics::decode):
-* platform/network/ResourceLoadPriority.h:
-* platform/network/ResourceRequestBase.h:
-(WebCore::ResourceRequestBase::ResourceRequestBase):
-* platform/network/ResourceResponseBase.h:
-* platform/network/StoredCredentialsPolicy.h:
-
-Source/WTF:
-
-* wtf/Markable.h:
-(WTF::Markable::asOptional const): Add helper method to get Optional easily from Markable.
-* wtf/ObjectIdentifier.h:
-(WTF::ObjectIdentifier::MarkableTraits::isEmptyValue):
-(WTF::ObjectIdentifier::MarkableTraits::emptyValue):
-(WTF::ObjectIdentifier::ObjectIdentifier): Add MarkableTraits for ObjectIdentifier.
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-12  Yusuke Suzuki  
-
-Shrink CachedResource
-https://bugs.webkit.org/show_bug.cgi?id=207618
-
-Reviewed by Mark Lam.
-
-* wtf/Markable.h:
-(WTF::Markable::asOptional const): Add helper method to get Optional easily from Markable.
-* wtf/ObjectIdentifier.h:
-(WTF::ObjectIdentifier::MarkableTraits::isEmptyValue):
-(WTF::ObjectIdentifier::MarkableTraits::emptyValue):
-(WTF::ObjectIdentifier::ObjectIdentifier): Add MarkableTraits for ObjectIdentifier.
-
-2020-02-14  Russell 

[webkit-changes] [256874] branches/safari-609.1.20.2-branch/Source/WebCore

[alancoon]

Title: [256874] branches/safari-609.1.20.2-branch/Source/WebCore








Revision 256874
Author alanc...@apple.com
Date 2020-02-18 16:01:16 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256746. rdar://problem/59478731

Modified Paths

branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.h




Diff

Modified: branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog (256873 => 256874)

--- branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog	2020-02-18 23:53:08 UTC (rev 256873)
+++ branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog	2020-02-19 00:01:16 UTC (rev 256874)
@@ -2,13 +2,6 @@
 
 Revert r256693. rdar://problem/59478981
 
-2020-02-17  Alex Christensen  
-
-Fix build after r256689
-
-* css/StyleProperties.h:
-Add missing include that wasn't on the branch.
-
 2020-02-14  Russell Epstein  
 
 Cherry-pick r256636. rdar://problem/59478734


Modified: branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.h (256873 => 256874)

--- branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.h	2020-02-18 23:53:08 UTC (rev 256873)
+++ branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.h	2020-02-19 00:01:16 UTC (rev 256874)
@@ -27,7 +27,6 @@
 #include "CSSValueKeywords.h"
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256879] branches/safari-609.1.20.2-branch/Source/WebCore

[alancoon]

Title: [256879] branches/safari-609.1.20.2-branch/Source/WebCore








Revision 256879
Author alanc...@apple.com
Date 2020-02-18 16:01:42 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256689. rdar://problem/59478731

Modified Paths

branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.cpp
branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.h




Diff

Modified: branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog (256878 => 256879)

--- branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog	2020-02-19 00:01:38 UTC (rev 256878)
+++ branches/safari-609.1.20.2-branch/Source/WebCore/ChangeLog	2020-02-19 00:01:42 UTC (rev 256879)
@@ -129,62 +129,6 @@
 
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256423. rdar://problem/59478731
-
-Compress ImmutableStyleProperties by using PackedPtr
-https://bugs.webkit.org/show_bug.cgi?id=207604
-
-Reviewed by Mark Lam.
-
-ImmutableStyleProperties is kept so long and consumes enough memory.
-We already attempted to compact it by storing CSSProperty's members separately.
-But we can compact further by using PackedPtr. This patch makes,
-
-1. Use PackedPtr for CSSValue* in ImmutableStyleProperties so that we can cut some bytes
-2. Reorder CSSValue* and StylePropertyMetadata arrays since StylePropertyMetadata requires alignment while PackedPtr is not.
-
-No behavior change.
-
-* css/StyleProperties.cpp:
-(WebCore::sizeForImmutableStylePropertiesWithPropertyCount):
-(WebCore::ImmutableStyleProperties::ImmutableStyleProperties):
-(WebCore::ImmutableStyleProperties::~ImmutableStyleProperties):
-(WebCore::ImmutableStyleProperties::findCustomPropertyIndex const):
-* css/StyleProperties.h:
-(WebCore::ImmutableStyleProperties::valueArray const):
-(WebCore::ImmutableStyleProperties::metadataArray const):
-(WebCore::ImmutableStyleProperties::propertyAt const):
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-11  Yusuke Suzuki  
-
-Compress ImmutableStyleProperties by using PackedPtr
-https://bugs.webkit.org/show_bug.cgi?id=207604
-
-Reviewed by Mark Lam.
-
-ImmutableStyleProperties is kept so long and consumes enough memory.
-We already attempted to compact it by storing CSSProperty's members separately.
-But we can compact further by using PackedPtr. This patch makes,
-
-1. Use PackedPtr for CSSValue* in ImmutableStyleProperties so that we can cut some bytes
-2. Reorder CSSValue* and StylePropertyMetadata arrays since StylePropertyMetadata requires alignment while PackedPtr is not.
-
-No behavior change.
-
-* css/StyleProperties.cpp:
-(WebCore::sizeForImmutableStylePropertiesWithPropertyCount):
-(WebCore::ImmutableStyleProperties::ImmutableStyleProperties):
-(WebCore::ImmutableStyleProperties::~ImmutableStyleProperties):
-(WebCore::ImmutableStyleProperties::findCustomPropertyIndex const):
-* css/StyleProperties.h:
-(WebCore::ImmutableStyleProperties::valueArray const):
-(WebCore::ImmutableStyleProperties::metadataArray const):
-(WebCore::ImmutableStyleProperties::propertyAt const):
-
-2020-02-14  Russell Epstein  
-
 Cherry-pick r254681. rdar://problem/59474790
 
 [Win] Fix AppleWin build


Modified: branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.cpp (256878 => 256879)

--- branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.cpp	2020-02-19 00:01:38 UTC (rev 256878)
+++ branches/safari-609.1.20.2-branch/Source/WebCore/css/StyleProperties.cpp	2020-02-19 00:01:42 UTC (rev 256879)
@@ -55,7 +55,7 @@
 
 static size_t sizeForImmutableStylePropertiesWithPropertyCount(unsigned count)
 {
-return sizeof(ImmutableStyleProperties) - sizeof(void*) + sizeof(StylePropertyMetadata) * count + sizeof(PackedPtr) * count;
+return sizeof(ImmutableStyleProperties) - sizeof(void*) + sizeof(CSSValue*) * count + sizeof(StylePropertyMetadata) * count;
 }
 
 static bool isInitialOrInherit(const String& value)
@@ -94,18 +94,17 @@
 : StyleProperties(cssParserMode, length)
 {
 StylePropertyMetadata* metadataArray = const_cast(this->metadataArray());
-PackedPtr* valueArray = bitwise_cast*>(this->valueArray());
+CSSValue** valueArray = const_cast(this->valueArray());
 for (unsigned i = 0; i < length; ++i) {
 metadataArray[i] = properties[i].metadata();
-auto* value = properties[i].value();
-valueArray[i] = value;
-value->ref();
+valueArray[i] = properties[i].value();
+valueArray[i]->ref();
 }
 }
 
 ImmutableStyleProperties::~ImmutableStyleProperties()
 {
-PackedPtr* valueArray 

[webkit-changes] [256873] branches/safari-609.1.20.3-branch/Source/WebCore

[alancoon]

Title: [256873] branches/safari-609.1.20.3-branch/Source/WebCore








Revision 256873
Author alanc...@apple.com
Date 2020-02-18 15:53:08 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256689. rdar://problem/59478731

Modified Paths

branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.cpp
branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.h




Diff

Modified: branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog (256872 => 256873)

--- branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog	2020-02-18 23:53:05 UTC (rev 256872)
+++ branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog	2020-02-18 23:53:08 UTC (rev 256873)
@@ -129,62 +129,6 @@
 
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256423. rdar://problem/59478731
-
-Compress ImmutableStyleProperties by using PackedPtr
-https://bugs.webkit.org/show_bug.cgi?id=207604
-
-Reviewed by Mark Lam.
-
-ImmutableStyleProperties is kept so long and consumes enough memory.
-We already attempted to compact it by storing CSSProperty's members separately.
-But we can compact further by using PackedPtr. This patch makes,
-
-1. Use PackedPtr for CSSValue* in ImmutableStyleProperties so that we can cut some bytes
-2. Reorder CSSValue* and StylePropertyMetadata arrays since StylePropertyMetadata requires alignment while PackedPtr is not.
-
-No behavior change.
-
-* css/StyleProperties.cpp:
-(WebCore::sizeForImmutableStylePropertiesWithPropertyCount):
-(WebCore::ImmutableStyleProperties::ImmutableStyleProperties):
-(WebCore::ImmutableStyleProperties::~ImmutableStyleProperties):
-(WebCore::ImmutableStyleProperties::findCustomPropertyIndex const):
-* css/StyleProperties.h:
-(WebCore::ImmutableStyleProperties::valueArray const):
-(WebCore::ImmutableStyleProperties::metadataArray const):
-(WebCore::ImmutableStyleProperties::propertyAt const):
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-11  Yusuke Suzuki  
-
-Compress ImmutableStyleProperties by using PackedPtr
-https://bugs.webkit.org/show_bug.cgi?id=207604
-
-Reviewed by Mark Lam.
-
-ImmutableStyleProperties is kept so long and consumes enough memory.
-We already attempted to compact it by storing CSSProperty's members separately.
-But we can compact further by using PackedPtr. This patch makes,
-
-1. Use PackedPtr for CSSValue* in ImmutableStyleProperties so that we can cut some bytes
-2. Reorder CSSValue* and StylePropertyMetadata arrays since StylePropertyMetadata requires alignment while PackedPtr is not.
-
-No behavior change.
-
-* css/StyleProperties.cpp:
-(WebCore::sizeForImmutableStylePropertiesWithPropertyCount):
-(WebCore::ImmutableStyleProperties::ImmutableStyleProperties):
-(WebCore::ImmutableStyleProperties::~ImmutableStyleProperties):
-(WebCore::ImmutableStyleProperties::findCustomPropertyIndex const):
-* css/StyleProperties.h:
-(WebCore::ImmutableStyleProperties::valueArray const):
-(WebCore::ImmutableStyleProperties::metadataArray const):
-(WebCore::ImmutableStyleProperties::propertyAt const):
-
-2020-02-14  Russell Epstein  
-
 Cherry-pick r254681. rdar://problem/59474790
 
 [Win] Fix AppleWin build


Modified: branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.cpp (256872 => 256873)

--- branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.cpp	2020-02-18 23:53:05 UTC (rev 256872)
+++ branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.cpp	2020-02-18 23:53:08 UTC (rev 256873)
@@ -55,7 +55,7 @@
 
 static size_t sizeForImmutableStylePropertiesWithPropertyCount(unsigned count)
 {
-return sizeof(ImmutableStyleProperties) - sizeof(void*) + sizeof(StylePropertyMetadata) * count + sizeof(PackedPtr) * count;
+return sizeof(ImmutableStyleProperties) - sizeof(void*) + sizeof(CSSValue*) * count + sizeof(StylePropertyMetadata) * count;
 }
 
 static bool isInitialOrInherit(const String& value)
@@ -94,18 +94,17 @@
 : StyleProperties(cssParserMode, length)
 {
 StylePropertyMetadata* metadataArray = const_cast(this->metadataArray());
-PackedPtr* valueArray = bitwise_cast*>(this->valueArray());
+CSSValue** valueArray = const_cast(this->valueArray());
 for (unsigned i = 0; i < length; ++i) {
 metadataArray[i] = properties[i].metadata();
-auto* value = properties[i].value();
-valueArray[i] = value;
-value->ref();
+valueArray[i] = properties[i].value();
+valueArray[i]->ref();
 }
 }
 
 ImmutableStyleProperties::~ImmutableStyleProperties()
 {
-PackedPtr* valueArray 

[webkit-changes] [256868] branches/safari-609.1.20.3-branch/Source/WebCore

[alancoon]

Title: [256868] branches/safari-609.1.20.3-branch/Source/WebCore








Revision 256868
Author alanc...@apple.com
Date 2020-02-18 15:52:52 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256746. rdar://problem/59478731

Modified Paths

branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.h




Diff

Modified: branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog (256867 => 256868)

--- branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog	2020-02-18 23:48:18 UTC (rev 256867)
+++ branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog	2020-02-18 23:52:52 UTC (rev 256868)
@@ -2,13 +2,6 @@
 
 Revert r256693. rdar://problem/59478981
 
-2020-02-17  Alex Christensen  
-
-Fix build after r256689
-
-* css/StyleProperties.h:
-Add missing include that wasn't on the branch.
-
 2020-02-14  Russell Epstein  
 
 Cherry-pick r256636. rdar://problem/59478734


Modified: branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.h (256867 => 256868)

--- branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.h	2020-02-18 23:48:18 UTC (rev 256867)
+++ branches/safari-609.1.20.3-branch/Source/WebCore/css/StyleProperties.h	2020-02-18 23:52:52 UTC (rev 256868)
@@ -27,7 +27,6 @@
 #include "CSSValueKeywords.h"
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256871] branches/safari-609.1.20.3-branch/Source

[alancoon]

Title: [256871] branches/safari-609.1.20.3-branch/Source








Revision 256871
Author alanc...@apple.com
Date 2020-02-18 15:53:03 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256691. rdar://problem/59478881

Modified Paths

branches/safari-609.1.20.3-branch/Source/WTF/ChangeLog
branches/safari-609.1.20.3-branch/Source/WTF/wtf/Markable.h
branches/safari-609.1.20.3-branch/Source/WTF/wtf/ObjectIdentifier.h
branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.3-branch/Source/WebCore/loader/FetchOptions.h
branches/safari-609.1.20.3-branch/Source/WebCore/loader/ResourceLoaderOptions.h
branches/safari-609.1.20.3-branch/Source/WebCore/loader/cache/CachedImage.cpp
branches/safari-609.1.20.3-branch/Source/WebCore/loader/cache/CachedImage.h
branches/safari-609.1.20.3-branch/Source/WebCore/loader/cache/CachedResource.cpp
branches/safari-609.1.20.3-branch/Source/WebCore/loader/cache/CachedResource.h
branches/safari-609.1.20.3-branch/Source/WebCore/page/csp/ContentSecurityPolicyResponseHeaders.h
branches/safari-609.1.20.3-branch/Source/WebCore/platform/network/NetworkLoadMetrics.h
branches/safari-609.1.20.3-branch/Source/WebCore/platform/network/ResourceLoadPriority.h
branches/safari-609.1.20.3-branch/Source/WebCore/platform/network/ResourceRequestBase.h
branches/safari-609.1.20.3-branch/Source/WebCore/platform/network/ResourceResponseBase.h
branches/safari-609.1.20.3-branch/Source/WebCore/platform/network/StoredCredentialsPolicy.h




Diff

Modified: branches/safari-609.1.20.3-branch/Source/WTF/ChangeLog (256870 => 256871)

--- branches/safari-609.1.20.3-branch/Source/WTF/ChangeLog	2020-02-18 23:52:59 UTC (rev 256870)
+++ branches/safari-609.1.20.3-branch/Source/WTF/ChangeLog	2020-02-18 23:53:03 UTC (rev 256871)
@@ -34,80 +34,6 @@
 
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256482. rdar://problem/59478881
-
-Shrink CachedResource
-https://bugs.webkit.org/show_bug.cgi?id=207618
-
-Reviewed by Mark Lam.
-
-Source/WebCore:
-
-This patch shrinks sizeof(CachedResource) by 80 bytes by aggressively using bit-fields and Markable<>.
-For each enum class, we define `bitsOfXXX` value, which indicates # of bits to represent it. And using
-this value for bit-field's width.
-
-No behavior change.
-
-* loader/FetchOptions.h:
-(WebCore::FetchOptions::encode const):
-* loader/ResourceLoaderOptions.h:
-(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
-(WebCore::ResourceLoaderOptions::loadedFromOpaqueSource):
-* loader/cache/CachedImage.cpp:
-(WebCore::CachedImage::CachedImage):
-(WebCore::CachedImage::shouldDeferUpdateImageData const):
-(WebCore::CachedImage::didUpdateImageData):
-* loader/cache/CachedImage.h:
-* loader/cache/CachedResource.cpp:
-(WebCore::CachedResource::CachedResource):
-(WebCore::CachedResource::load):
-(WebCore::CachedResource::finish):
-* loader/cache/CachedResource.h:
-(WebCore::CachedResource::setStatus):
-* page/csp/ContentSecurityPolicyResponseHeaders.h:
-(WebCore::ContentSecurityPolicyResponseHeaders::MarkableTraits::isEmptyValue):
-(WebCore::ContentSecurityPolicyResponseHeaders::MarkableTraits::emptyValue):
-(WebCore::ContentSecurityPolicyResponseHeaders::ContentSecurityPolicyResponseHeaders):
-* platform/network/NetworkLoadMetrics.h:
-(WebCore::NetworkLoadMetrics::isolatedCopy const):
-(WebCore::NetworkLoadMetrics::clearNonTimingData):
-(WebCore::NetworkLoadMetrics::operator== const):
-(WebCore::NetworkLoadMetrics::encode const):
-(WebCore::NetworkLoadMetrics::decode):
-* platform/network/ResourceLoadPriority.h:
-* platform/network/ResourceRequestBase.h:
-(WebCore::ResourceRequestBase::ResourceRequestBase):
-* platform/network/ResourceResponseBase.h:
-* platform/network/StoredCredentialsPolicy.h:
-
-Source/WTF:
-
-* wtf/Markable.h:
-(WTF::Markable::asOptional const): Add helper method to get Optional easily from Markable.
-* wtf/ObjectIdentifier.h:
-(WTF::ObjectIdentifier::MarkableTraits::isEmptyValue):
-(WTF::ObjectIdentifier::MarkableTraits::emptyValue):
-(WTF::ObjectIdentifier::ObjectIdentifier): Add MarkableTraits for ObjectIdentifier.
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-12  Yusuke Suzuki  
-
-Shrink CachedResource
-https://bugs.webkit.org/show_bug.cgi?id=207618
-
-Reviewed by Mark Lam.
-
-* wtf/Markable.h:
-(WTF::Markable::asOptional const): Add helper method to get Optional easily from Markable.
-* wtf/ObjectIdentifier.h:
-(WTF::ObjectIdentifier::MarkableTraits::isEmptyValue):
-(WTF::ObjectIdentifier::MarkableTraits::emptyValue):
-(WTF::ObjectIdentifier::ObjectIdentifier): Add MarkableTraits for ObjectIdentifier.
-
-2020-02-14  Russell 

[webkit-changes] [256869] branches/safari-609.1.20.3-branch/Source/WebCore

[alancoon]

Title: [256869] branches/safari-609.1.20.3-branch/Source/WebCore








Revision 256869
Author alanc...@apple.com
Date 2020-02-18 15:52:56 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256696. rdar://problem/59478734

Modified Paths

branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog
branches/safari-609.1.20.3-branch/Source/WebCore/page/Frame.cpp




Diff

Modified: branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog (256868 => 256869)

--- branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog	2020-02-18 23:52:52 UTC (rev 256868)
+++ branches/safari-609.1.20.3-branch/Source/WebCore/ChangeLog	2020-02-18 23:52:56 UTC (rev 256869)
@@ -4,39 +4,6 @@
 
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256636. rdar://problem/59478734
-
-[Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
-https://bugs.webkit.org/show_bug.cgi?id=207784
-
-
-Patch by Antoine Quint  on 2020-02-14
-Reviewed by Dean Jackson.
-
-After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
-call should the Web Animations flag be on.
-
-* page/Frame.cpp:
-(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-14  Antoine Quint  
-
-[Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
-https://bugs.webkit.org/show_bug.cgi?id=207784
-
-
-Reviewed by Dean Jackson.
-
-After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
-call should the Web Animations flag be on.
-
-* page/Frame.cpp:
-(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
-
-2020-02-14  Russell Epstein  
-
 Cherry-pick r256623. rdar://problem/59478938
 
 Ensure animations that lose their effect don't schedule an animation update


Modified: branches/safari-609.1.20.3-branch/Source/WebCore/page/Frame.cpp (256868 => 256869)

--- branches/safari-609.1.20.3-branch/Source/WebCore/page/Frame.cpp	2020-02-18 23:52:52 UTC (rev 256868)
+++ branches/safari-609.1.20.3-branch/Source/WebCore/page/Frame.cpp	2020-02-18 23:52:56 UTC (rev 256869)
@@ -962,12 +962,7 @@
 m_doc->resumeScheduledTasks(ReasonForSuspension::PageWillBeSuspended);
 
 // Frame::clearTimers() suspended animations and pending relayouts.
-
-if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled()) {
-if (auto* timeline = m_doc->existingTimeline())
-timeline->resumeAnimations();
-} else
-animation().resumeAnimationsForDocument(m_doc.get());
+animation().resumeAnimationsForDocument(m_doc.get());
 if (m_view)
 m_view->layoutContext().scheduleLayout();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256872] branches/safari-609.1.20.3-branch/Source/JavaScriptCore

[alancoon]

Title: [256872] branches/safari-609.1.20.3-branch/Source/_javascript_Core








Revision 256872
Author alanc...@apple.com
Date 2020-02-18 15:53:05 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256690. rdar://problem/59478994

Modified Paths

branches/safari-609.1.20.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-609.1.20.3-branch/Source/_javascript_Core/runtime/RegExpKey.h




Diff

Modified: branches/safari-609.1.20.3-branch/Source/_javascript_Core/ChangeLog (256871 => 256872)

--- branches/safari-609.1.20.3-branch/Source/_javascript_Core/ChangeLog	2020-02-18 23:53:03 UTC (rev 256871)
+++ branches/safari-609.1.20.3-branch/Source/_javascript_Core/ChangeLog	2020-02-18 23:53:05 UTC (rev 256872)
@@ -1,31 +1,5 @@
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256467. rdar://problem/59478994
-
-[JSC] Make RegExpCache small
-https://bugs.webkit.org/show_bug.cgi?id=207619
-
-Reviewed by Mark Lam.
-
-We can compact RegExpKey by using PackedRefPtr, so that we can shrink memory consumption of RegExpCache.
-
-* runtime/RegExpKey.h:
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-12  Yusuke Suzuki  
-
-[JSC] Make RegExpCache small
-https://bugs.webkit.org/show_bug.cgi?id=207619
-
-Reviewed by Mark Lam.
-
-We can compact RegExpKey by using PackedRefPtr, so that we can shrink memory consumption of RegExpCache.
-
-* runtime/RegExpKey.h:
-
-2020-02-14  Russell Epstein  
-
 Cherry-pick r254681. rdar://problem/59474790
 
 [Win] Fix AppleWin build


Modified: branches/safari-609.1.20.3-branch/Source/_javascript_Core/runtime/RegExpKey.h (256871 => 256872)

--- branches/safari-609.1.20.3-branch/Source/_javascript_Core/runtime/RegExpKey.h	2020-02-18 23:53:03 UTC (rev 256871)
+++ branches/safari-609.1.20.3-branch/Source/_javascript_Core/runtime/RegExpKey.h	2020-02-18 23:53:05 UTC (rev 256872)
@@ -36,7 +36,7 @@
 
 struct RegExpKey {
 OptionSet flagsValue;
-PackedRefPtr pattern;
+RefPtr pattern;
 
 RegExpKey()
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256870] branches/safari-609.1.20.3-branch/Source

[alancoon]

Title: [256870] branches/safari-609.1.20.3-branch/Source








Revision 256870
Author alanc...@apple.com
Date 2020-02-18 15:52:59 -0800 (Tue, 18 Feb 2020)


Log Message
Revert r256692. rdar://problem/59478929

Modified Paths

branches/safari-609.1.20.3-branch/Source/_javascript_Core/ChangeLog
branches/safari-609.1.20.3-branch/Source/_javascript_Core/jit/JIT.cpp
branches/safari-609.1.20.3-branch/Source/_javascript_Core/jit/JITCodeMap.h
branches/safari-609.1.20.3-branch/Source/WTF/ChangeLog
branches/safari-609.1.20.3-branch/Source/WTF/wtf/MallocPtr.h




Diff

Modified: branches/safari-609.1.20.3-branch/Source/_javascript_Core/ChangeLog (256869 => 256870)

--- branches/safari-609.1.20.3-branch/Source/_javascript_Core/ChangeLog	2020-02-18 23:52:56 UTC (rev 256869)
+++ branches/safari-609.1.20.3-branch/Source/_javascript_Core/ChangeLog	2020-02-18 23:52:59 UTC (rev 256870)
@@ -1,73 +1,5 @@
 2020-02-14  Russell Epstein  
 
-Cherry-pick r256498. rdar://problem/59478929
-
-[JSC] Compact JITCodeMap by storing BytecodeIndex and CodeLocation separately
-https://bugs.webkit.org/show_bug.cgi?id=207673
-
-Reviewed by Mark Lam.
-
-Source/_javascript_Core:
-
-While BytecodeIndex is 4 bytes, CodeLocation is 8 bytes. So the tuple of them "JITCodeMap::Entry"
-becomes 16 bytes because it adds 4 bytes padding. We should store BytecodeIndex and CodeLocation separately
-to avoid this padding.
-
-This patch introduces JITCodeMapBuilder. We use this to build JITCodeMap data structure as a immutable final result.
-
-* jit/JIT.cpp:
-(JSC::JIT::link):
-* jit/JITCodeMap.h:
-(JSC::JITCodeMap::JITCodeMap):
-(JSC::JITCodeMap::find const):
-(JSC::JITCodeMap::operator bool const):
-(JSC::JITCodeMap::codeLocations const):
-(JSC::JITCodeMap::indexes const):
-(JSC::JITCodeMapBuilder::append):
-(JSC::JITCodeMapBuilder::finalize):
-(JSC::JITCodeMap::Entry::Entry): Deleted.
-(JSC::JITCodeMap::Entry::bytecodeIndex const): Deleted.
-(JSC::JITCodeMap::Entry::codeLocation): Deleted.
-(JSC::JITCodeMap::append): Deleted.
-(JSC::JITCodeMap::finish): Deleted.
-
-Source/WTF:
-
-* wtf/MallocPtr.h:
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
-2020-02-12  Yusuke Suzuki  
-
-[JSC] Compact JITCodeMap by storing BytecodeIndex and CodeLocation separately
-https://bugs.webkit.org/show_bug.cgi?id=207673
-
-Reviewed by Mark Lam.
-
-While BytecodeIndex is 4 bytes, CodeLocation is 8 bytes. So the tuple of them "JITCodeMap::Entry"
-becomes 16 bytes because it adds 4 bytes padding. We should store BytecodeIndex and CodeLocation separately
-to avoid this padding.
-
-This patch introduces JITCodeMapBuilder. We use this to build JITCodeMap data structure as a immutable final result.
-
-* jit/JIT.cpp:
-(JSC::JIT::link):
-* jit/JITCodeMap.h:
-(JSC::JITCodeMap::JITCodeMap):
-(JSC::JITCodeMap::find const):
-(JSC::JITCodeMap::operator bool const):
-(JSC::JITCodeMap::codeLocations const):
-(JSC::JITCodeMap::indexes const):
-(JSC::JITCodeMapBuilder::append):
-(JSC::JITCodeMapBuilder::finalize):
-(JSC::JITCodeMap::Entry::Entry): Deleted.
-(JSC::JITCodeMap::Entry::bytecodeIndex const): Deleted.
-(JSC::JITCodeMap::Entry::codeLocation): Deleted.
-(JSC::JITCodeMap::append): Deleted.
-(JSC::JITCodeMap::finish): Deleted.
-
-2020-02-14  Russell Epstein  
-
 Cherry-pick r256467. rdar://problem/59478994
 
 [JSC] Make RegExpCache small


Modified: branches/safari-609.1.20.3-branch/Source/_javascript_Core/jit/JIT.cpp (256869 => 256870)

--- branches/safari-609.1.20.3-branch/Source/_javascript_Core/jit/JIT.cpp	2020-02-18 23:52:56 UTC (rev 256869)
+++ branches/safari-609.1.20.3-branch/Source/_javascript_Core/jit/JIT.cpp	2020-02-18 23:52:59 UTC (rev 256870)
@@ -894,14 +894,13 @@
 patchBuffer.locationOfNearCall(compilationInfo.hotPathOther));
 }
 
-{
-JITCodeMapBuilder jitCodeMapBuilder;
-for (unsigned bytecodeOffset = 0; bytecodeOffset < m_labels.size(); ++bytecodeOffset) {
-if (m_labels[bytecodeOffset].isSet())
-jitCodeMapBuilder.append(BytecodeIndex(bytecodeOffset), patchBuffer.locationOf(m_labels[bytecodeOffset]));
-}
-m_codeBlock->setJITCodeMap(jitCodeMapBuilder.finalize());
+JITCodeMap jitCodeMap;
+for (unsigned bytecodeOffset = 0; bytecodeOffset < m_labels.size(); ++bytecodeOffset) {
+if (m_labels[bytecodeOffset].isSet())
+jitCodeMap.append(BytecodeIndex(bytecodeOffset), patchBuffer.locationOf(m_labels[bytecodeOffset]));
 }
+jitCodeMap.finish();
+

[webkit-changes] [256867] trunk

[achristensen]

Title: [256867] trunk








Revision 256867
Author achristen...@apple.com
Date 2020-02-18 15:48:18 -0800 (Tue, 18 Feb 2020)


Log Message
Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
https://bugs.webkit.org/show_bug.cgi?id=207912


Reviewed by Brian Weinstein.

Source/WebKit:

This expands on r158806.  There's no reason not to support all NSNumber types, so I did.
Covered by API tests.

* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocationArguments):
(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):
(-[WKRemoteObjectDecoder decodeValueOfObjCType:at:]):
(decodeInvocationArguments):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
* TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
(TEST):
* TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
(-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256866 => 256867)

--- trunk/Source/WebKit/ChangeLog	2020-02-18 23:31:25 UTC (rev 256866)
+++ trunk/Source/WebKit/ChangeLog	2020-02-18 23:48:18 UTC (rev 256867)
@@ -1,3 +1,20 @@
+2020-02-18  Alex Christensen  
+
+Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
+https://bugs.webkit.org/show_bug.cgi?id=207912
+
+
+Reviewed by Brian Weinstein.
+
+This expands on r158806.  There's no reason not to support all NSNumber types, so I did.
+Covered by API tests.
+
+* Shared/API/Cocoa/WKRemoteObjectCoder.mm:
+(encodeInvocationArguments):
+(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):
+(-[WKRemoteObjectDecoder decodeValueOfObjCType:at:]):
+(decodeInvocationArguments):
+
 2020-02-18  Daniel Bates  
 
 Ask the EditorClient whether to reveal the current selection after insertion


Modified: trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm (256866 => 256867)

--- trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm	2020-02-18 23:31:25 UTC (rev 256866)
+++ trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm	2020-02-18 23:48:18 UTC (rev 256867)
@@ -140,6 +140,24 @@
 break;
 }
 
+// short
+case 's': {
+short value;
+[invocation getArgument: atIndex:i];
+
+encodeToObjectStream(encoder, @(value));
+break;
+}
+
+// unsigned short
+case 'S': {
+unsigned short value;
+[invocation getArgument: atIndex:i];
+
+encodeToObjectStream(encoder, @(value));
+break;
+}
+
 // int
 case 'i': {
 int value;
@@ -167,6 +185,15 @@
 break;
 }
 
+// unsigned char
+case 'C': {
+unsigned char value;
+[invocation getArgument: atIndex:i];
+
+encodeToObjectStream(encoder, @(value));
+break;
+}
+
 // bool
 case 'B': {
 BOOL value;
@@ -310,11 +337,71 @@
 - (void)encodeValueOfObjCType:(const char *)type at:(const void *)address
 {
 switch (*type) {
+// double
+case 'd':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// float
+case 'f':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// short
+case 's':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// unsigned short
+case 'S':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
 // int
 case 'i':
 encodeToObjectStream(self, @(*static_cast(address)));
 break;
 
+// unsigned
+case 'I':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// char
+case 'c':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// unsigned char
+case 'C':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// bool
+case 'B':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// long
+case 'l':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// unsigned long
+case 'L':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// long long
+case 'q':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
+// unsigned long long
+case 'Q':
+encodeToObjectStream(self, @(*static_cast(address)));
+break;
+
 // 

[webkit-changes] [256866] branches/safari-609.1.20.2-branch/Source

[alancoon]

Title: [256866] branches/safari-609.1.20.2-branch/Source








Revision 256866
Author alanc...@apple.com
Date 2020-02-18 15:31:25 -0800 (Tue, 18 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609.1.20.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609.1.20.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609.1.20.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609.1.20.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609.1.20.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609.1.20.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609.1.20.2-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609.1.20.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609.1.20.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256865 => 256866)

--- branches/safari-609.1.20.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
+++ branches/safari-609.1.20.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 23:31:25 UTC (rev 256866)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.20.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256865 => 256866)

--- branches/safari-609.1.20.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
+++ branches/safari-609.1.20.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 23:31:25 UTC (rev 256866)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.20.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256865 => 256866)

--- branches/safari-609.1.20.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
+++ branches/safari-609.1.20.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 23:31:25 UTC (rev 256866)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.20.2-branch/Source/WebCore/Configurations/Version.xcconfig (256865 => 256866)

--- branches/safari-609.1.20.2-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
+++ branches/safari-609.1.20.2-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 23:31:25 UTC (rev 256866)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.20.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256865 => 256866)

--- branches/safari-609.1.20.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
+++ branches/safari-609.1.20.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 23:31:25 UTC (rev 256866)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = 

[webkit-changes] [256865] branches/safari-609.1.20.3-branch/Source

[alancoon]

Title: [256865] branches/safari-609.1.20.3-branch/Source








Revision 256865
Author alanc...@apple.com
Date 2020-02-18 15:31:13 -0800 (Tue, 18 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609.1.20.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609.1.20.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609.1.20.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609.1.20.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609.1.20.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609.1.20.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609.1.20.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609.1.20.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609.1.20.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256864 => 256865)

--- branches/safari-609.1.20.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 23:27:22 UTC (rev 256864)
+++ branches/safari-609.1.20.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.20.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256864 => 256865)

--- branches/safari-609.1.20.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 23:27:22 UTC (rev 256864)
+++ branches/safari-609.1.20.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.20.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256864 => 256865)

--- branches/safari-609.1.20.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 23:27:22 UTC (rev 256864)
+++ branches/safari-609.1.20.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.20.3-branch/Source/WebCore/Configurations/Version.xcconfig (256864 => 256865)

--- branches/safari-609.1.20.3-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 23:27:22 UTC (rev 256864)
+++ branches/safari-609.1.20.3-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.20.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256864 => 256865)

--- branches/safari-609.1.20.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 23:27:22 UTC (rev 256864)
+++ branches/safari-609.1.20.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 23:31:13 UTC (rev 256865)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 20;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 3;
+NANO_VERSION = 1;
+FULL_VERSION = 

[webkit-changes] [256864] trunk/Source

[dbates]

Title: [256864] trunk/Source








Revision 256864
Author dba...@webkit.org
Date 2020-02-18 15:27:22 -0800 (Tue, 18 Feb 2020)


Log Message
Ask the EditorClient whether to reveal the current selection after insertion
https://bugs.webkit.org/show_bug.cgi?id=207866


Reviewed by Wenson Hsieh.

Source/WebCore:

Adds a new EditorClient function shouldRevealCurrentSelectionAfterInsertion() that returns whether
the client wants the engine to reveal the current selection after insertion. The default implementation
always returns true. On iOS it returns the result of WebPage::shouldRevealCurrentSelectionAfterInsertion().

* editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent): Call EditorClient::shouldRevealCurrentSelectionAfterInsertion().
If it returns false then skip the code to reveal the current selection: the UI process will call back
into WebPage::setShouldRevealCurrentSelectionAfterInsertion() when it is ready to reveal the current
selection. Otherwise, do what we do now.
* editing/Editor.h:
* page/EditorClient.h:
(WebCore::EditorClient::shouldRevealCurrentSelectionAfterInsertion const): Added.
* page/Page.cpp:
(WebCore::Page::revealCurrentSelection): Added.
* page/Page.h:

Source/WebKit:

On iOS, adds a new WebPage message SetShouldRevealCurrentSelectionAfterInsertion that the
UI process can send to toggle whether the current selection should be revealed after a
text insertion.

* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setWaitingForPostLayoutEditorStateUpdateAfterFocusingElement):
* UIProcess/ios/WKContentViewInteraction.h:
Add some declarations for some functions that I need to make the corresponding Apple Internal fix in .
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
If we are not going to zoom to reveal the focused element immediately then call WebPage::setWaitingForPostLayoutEditorStateUpdateAfterFocusingElement(true)
so that we schedule a -_didUpdateEditorState callback on the next editor state update so that we can call
-_zoomToRevealFocusedElement.
(-[WKContentView _elementDidBlur]): Call WebPage::setWaitingForPostLayoutEditorStateUpdateAfterFocusingElement(false)
to unschedule an existing -_didUpdateEditorState callback.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::elementDidFocus):
(WebKit::WebPageProxy::elementDidBlur):
Move the setting of m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement from here to
-_elementDidFocus and _elementDidBlur when an element is focused or blurred, respectively.

(WebKit::WebPageProxy::setShouldRevealCurrentSelectionAfterInsertion): Added.
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::shouldRevealCurrentSelectionAfterInsertion const): Added.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState const): Mark the editor state as ignoring selection changes if EditorClient::shouldRevealCurrentSelectionAfterInsertion()
returns false.
(WebKit::WebPage::didCommitLoad): Reset state.
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::shouldRevealCurrentSelectionAfterInsertion const):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateSelectionAppearance): Do not send an update if EditorClient::shouldRevealCurrentSelectionAfterInsertion()
returns false.
(WebKit::WebPage::setShouldRevealCurrentSelectionAfterInsertion): Added. Update state, if needed. If passed
false, then reveal the current selection just as we would have done after an insertion and schedule a full
editor state update (i.e. an update after layout is performed). The latter will trigger the UI process on iOS
to zoom to reveal the newly focused element.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/page/EditorClient.h
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h
trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (256863 => 256864)

--- trunk/Source/WebCore/ChangeLog	2020-02-18 23:18:23 UTC (rev 256863)
+++ trunk/Source/WebCore/ChangeLog	2020-02-18 23:27:22 UTC (rev 256864)
@@ -1,3 +1,27 @@
+2020-02-18  Daniel Bates  
+
+Ask the EditorClient whether to reveal 

[webkit-changes] [256862] branches/safari-609-branch

[repstein]

Title: [256862] branches/safari-609-branch








Revision 256862
Author repst...@apple.com
Date 2020-02-18 15:18:19 -0800 (Tue, 18 Feb 2020)


Log Message
Revert "Cherry-pick r256191. rdar://problem/59447003"

This reverts commit r256796.

Modified Paths

branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/fast/url/relative-expected.txt
branches/safari-609-branch/LayoutTests/fast/url/relative.html
branches/safari-609-branch/LayoutTests/fast/url/resources/utilities.js
branches/safari-609-branch/LayoutTests/fast/url/segments-from-data-url-expected.txt
branches/safari-609-branch/LayoutTests/fast/url/segments-from-data-url.html
branches/safari-609-branch/LayoutTests/fetch/fetch-url-serialization-expected.txt
branches/safari-609-branch/LayoutTests/http/tests/plugins/navigation-during-load-embed.html
branches/safari-609-branch/LayoutTests/http/tests/plugins/navigation-during-load.html
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt
branches/safari-609-branch/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
branches/safari-609-branch/Source/WTF/ChangeLog
branches/safari-609-branch/Source/WTF/wtf/spi/darwin/dyldSPI.h
branches/safari-609-branch/Source/WebCore/dom/Document.cpp
branches/safari-609-branch/Source/WebCore/html/parser/HTMLPreloadScanner.cpp
branches/safari-609-branch/Source/WebCore/html/parser/HTMLPreloadScanner.h
branches/safari-609-branch/Source/WebCore/page/SecurityPolicy.cpp
branches/safari-609-branch/Source/WebCore/page/SecurityPolicy.h
branches/safari-609-branch/Source/WebCore/page/Settings.yaml
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/Shared/WebPreferences.yaml
branches/safari-609-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-609-branch/Source/WebKit/UIProcess/Cocoa/VersionChecks.h
branches/safari-609-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-609-branch/Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h
branches/safari-609-branch/Source/WebKitLegacy/mac/WebView/WebView.mm


Removed Paths

branches/safari-609-branch/LayoutTests/fast/url/relative2-expected.txt
branches/safari-609-branch/LayoutTests/fast/url/relative2.html
branches/safari-609-branch/LayoutTests/fast/url/segments-from-data-url2-expected.txt
branches/safari-609-branch/LayoutTests/fast/url/segments-from-data-url2.html
branches/safari-609-branch/LayoutTests/http/tests/security/allowed-base-url-data-url-via-setting-expected.txt
branches/safari-609-branch/LayoutTests/http/tests/security/allowed-base-url-data-url-via-setting.html
branches/safari-609-branch/LayoutTests/http/tests/security/denied-base-url-data-url-expected.txt
branches/safari-609-branch/LayoutTests/http/tests/security/denied-base-url-data-url.html
branches/safari-609-branch/LayoutTests/http/tests/security/denied-base-url-_javascript_-url-expected.txt
branches/safari-609-branch/LayoutTests/http/tests/security/denied-base-url-_javascript_-url.html




Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256861 => 256862)

--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-18 23:16:16 UTC (rev 256861)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-18 23:18:19 UTC (rev 256862)
@@ -314,153 +314,6 @@
 
 * platform/mac-wk2/TestExpectations:
 
-2020-02-17  Alan Coon  
-
-Cherry-pick r256191. rdar://problem/59447003
-
-Disallow setting base URL to a data or _javascript_ URL
-https://bugs.webkit.org/show_bug.cgi?id=207136
-
-Source/WebCore:
-
-Reviewed by Brent Fulgham.
-
-Inspired by .
-
-Block setting the base URL to a data URL or _javascript_ URL as such usage is questionable.
-This makes WebKit match the behavior of Chrome and Firefox and is in the spirit of the
-discussion in .
-
-On Mac and iOS, this restriction is applied only to apps linked against a future SDK to
-avoid breaking shipped apps.
-
-For all other ports, this restriction is enabled by default.
-
-Tests: fast/url/relative2.html
-   fast/url/segments-from-data-url2.html
-   http/tests/security/allowed-base-url-data-url-via-setting.html
-   http/tests/security/denied-base-url-data-url.html
-   http/tests/security/denied-base-url-_javascript_-url.html
-
-* dom/Document.cpp:
-(WebCore::Document::processBaseElement): Condition updating the parsed
-base URL on whether is has an allowed scheme, if restrictions are enabled. Otherwise,
-do what we do now. If the scheme is disallowed then log a message to the console to
-explain this to web developers.
-* html/parser/HTMLPreloadScanner.cpp:
-

[webkit-changes] [256863] branches/safari-609-branch/Source/WebCore/platform/graphics/cg/ PDFDocumentImage.cpp

[repstein]

Title: [256863] branches/safari-609-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp








Revision 256863
Author repst...@apple.com
Date 2020-02-18 15:18:23 -0800 (Tue, 18 Feb 2020)


Log Message
Unreviewed build fix.

Modified Paths

branches/safari-609-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp




Diff

Modified: branches/safari-609-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp (256862 => 256863)

--- branches/safari-609-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp	2020-02-18 23:18:19 UTC (rev 256862)
+++ branches/safari-609-branch/Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp	2020-02-18 23:18:23 UTC (rev 256863)
@@ -42,6 +42,7 @@
 #include "SharedBuffer.h"
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256861] branches/safari-609.1.20.3-branch/

[alancoon]

Title: [256861] branches/safari-609.1.20.3-branch/








Revision 256861
Author alanc...@apple.com
Date 2020-02-18 15:16:16 -0800 (Tue, 18 Feb 2020)


Log Message
New branch.

Added Paths

branches/safari-609.1.20.3-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256860] branches/safari-609.1.20.2-branch/

[alancoon]

Title: [256860] branches/safari-609.1.20.2-branch/








Revision 256860
Author alanc...@apple.com
Date 2020-02-18 15:16:03 -0800 (Tue, 18 Feb 2020)


Log Message
New branch.

Added Paths

branches/safari-609.1.20.2-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256859] trunk

[wenson_hsieh]

Title: [256859] trunk








Revision 256859
Author wenson_hs...@apple.com
Date 2020-02-18 15:15:19 -0800 (Tue, 18 Feb 2020)


Log Message
[macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=207899


Reviewed by Tim Horton and Simon Fraser.

Source/WebCore:

Mitigates a null pointer crash in ServicesOverlayController::buildPotentialHighlightsIfNeeded(), wherein the
focused frame may not have a FrameView when the ServicesOverlayController's selection invalidation timer fires.
This is possible if, while being focused, the newly focused subframe is unparented and reparented, which causes
it to momentarily have a null view. During this time, if a selection change had occurred earlier in the runloop,
it will schedule the page overlay controller invalidation timer, which will fire and discover that the currently
focused frame no longer has a FrameView.

Test: editing/selection/selection-change-in-disconnected-frame-crash.html

* page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::buildSelectionHighlight):

Source/WebKit:

Add another missing null check on iOS, for the case where FrameView is null.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformEditorState const):

Tools:

Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.

* WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):

LayoutTests:

Add a new layout test to verify that we don't crash under this circumstance.

* editing/selection/selection-change-in-disconnected-frame-crash-expected.txt: Added.
* editing/selection/selection-change-in-disconnected-frame-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/mac/ServicesOverlayController.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestOptions.h
trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm


Added Paths

trunk/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash-expected.txt
trunk/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (256858 => 256859)

--- trunk/LayoutTests/ChangeLog	2020-02-18 23:11:58 UTC (rev 256858)
+++ trunk/LayoutTests/ChangeLog	2020-02-18 23:15:19 UTC (rev 256859)
@@ -1,3 +1,16 @@
+2020-02-18  Wenson Hsieh  
+
+[macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
+https://bugs.webkit.org/show_bug.cgi?id=207899
+
+
+Reviewed by Tim Horton and Simon Fraser.
+
+Add a new layout test to verify that we don't crash under this circumstance.
+
+* editing/selection/selection-change-in-disconnected-frame-crash-expected.txt: Added.
+* editing/selection/selection-change-in-disconnected-frame-crash.html: Added.
+
 2020-02-18  Chris Dumez  
 
 [WK1] Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html


Added: trunk/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash-expected.txt (0 => 256859)

--- trunk/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash-expected.txt	2020-02-18 23:15:19 UTC (rev 256859)
@@ -0,0 +1,3 @@
+This test passes if it does not crash.
+
+ 


Added: trunk/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash.html (0 => 256859)

--- trunk/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash.html	(rev 0)
+++ trunk/LayoutTests/editing/selection/selection-change-in-disconnected-frame-crash.html	2020-02-18 23:15:19 UTC (rev 256859)
@@ -0,0 +1,23 @@
+ 
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+addEventListener("load", () => {
+const frame = document.querySelector("iframe");
+const frameSet = document.createElement("frameset");
+const frameDocument = frame.contentDocument;
+
+frameDocument.getSelection().selectAllChildren(frameDocument.body);
+frameSet._onblur_ = () => document.body.appendChild(frame);
+frame.focus();
+});
+
+
+
+This test passes if it does not crash.
+
+
+
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (256858 => 256859)

--- trunk/Source/WebCore/ChangeLog	2020-02-18 23:11:58 UTC (rev 256858)
+++ trunk/Source/WebCore/ChangeLog	2020-02-18 23:15:19 UTC (rev 256859)
@@ -1,3 +1,23 @@

[webkit-changes] [256858] tags/Safari-609.1.20/

[alancoon]

Title: [256858] tags/Safari-609.1.20/








Revision 256858
Author alanc...@apple.com
Date 2020-02-18 15:11:58 -0800 (Tue, 18 Feb 2020)


Log Message
Tag Safari-609.1.20.

Added Paths

tags/Safari-609.1.20/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256857] trunk/Source/WebKit

[youenn]

Title: [256857] trunk/Source/WebKit








Revision 256857
Author you...@apple.com
Date 2020-02-18 15:09:01 -0800 (Tue, 18 Feb 2020)


Log Message
NetworkDataTask should not expect its session wrapper to be always live
https://bugs.webkit.org/show_bug.cgi?id=207903
rdar://problem/59291486

Reviewed by Alex Christensen.

NetworkDataTaskCocoa should take a weak pointer to its session wrapper.
If the session wrapper is still valid, then we can remove the task from the session wrapper map.
We cannot guarantee session wrapper is valid since NetworkDataTask is ref counted.

* NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256856 => 256857)

--- trunk/Source/WebKit/ChangeLog	2020-02-18 22:52:38 UTC (rev 256856)
+++ trunk/Source/WebKit/ChangeLog	2020-02-18 23:09:01 UTC (rev 256857)
@@ -1,3 +1,20 @@
+2020-02-18  Youenn Fablet  
+
+NetworkDataTask should not expect its session wrapper to be always live
+https://bugs.webkit.org/show_bug.cgi?id=207903
+rdar://problem/59291486
+
+Reviewed by Alex Christensen.
+
+NetworkDataTaskCocoa should take a weak pointer to its session wrapper.
+If the session wrapper is still valid, then we can remove the task from the session wrapper map.
+We cannot guarantee session wrapper is valid since NetworkDataTask is ref counted.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa):
+
 2020-02-18  Antti Koivisto  
 
 [macOS] Don't fire timers when there is a pending rendering update


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h (256856 => 256857)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h	2020-02-18 22:52:38 UTC (rev 256856)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h	2020-02-18 23:09:01 UTC (rev 256857)
@@ -90,7 +90,7 @@
 bool isThirdPartyRequest(const WebCore::ResourceRequest&) const;
 bool isAlwaysOnLoggingAllowed() const;
 
-SessionWrapper& m_sessionWrapper;
+WeakPtr m_sessionWrapper;
 RefPtr m_sandboxExtension;
 RetainPtr m_task;
 WebCore::NetworkLoadMetrics m_networkLoadMetrics;


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (256856 => 256857)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2020-02-18 22:52:38 UTC (rev 256856)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2020-02-18 23:09:01 UTC (rev 256857)
@@ -230,7 +230,7 @@
 
 NetworkDataTaskCocoa::NetworkDataTaskCocoa(NetworkSession& session, NetworkDataTaskClient& client, const WebCore::ResourceRequest& requestWithCredentials, WebCore::FrameIdentifier frameID, WebCore::PageIdentifier pageID, WebCore::StoredCredentialsPolicy storedCredentialsPolicy, WebCore::ContentSniffingPolicy shouldContentSniff, WebCore::ContentEncodingSniffingPolicy shouldContentEncodingSniff, bool shouldClearReferrerOnHTTPSToHTTPRedirect, PreconnectOnly shouldPreconnectOnly, bool dataTaskIsForMainFrameNavigation, bool dataTaskIsForMainResourceNavigationForAnyFrame, Optional networkActivityTracker)
 : NetworkDataTask(session, client, requestWithCredentials, storedCredentialsPolicy, shouldClearReferrerOnHTTPSToHTTPRedirect, dataTaskIsForMainFrameNavigation)
-, m_sessionWrapper(static_cast(session).sessionWrapperForTask(requestWithCredentials, storedCredentialsPolicy))
+, m_sessionWrapper(makeWeakPtr(static_cast(session).sessionWrapperForTask(requestWithCredentials, storedCredentialsPolicy)))
 , m_frameID(frameID)
 , m_pageID(pageID)
 , m_isForMainResourceNavigationForAnyFrame(dataTaskIsForMainResourceNavigationForAnyFrame)
@@ -277,12 +277,12 @@
 NSURLRequest *nsRequest = request.nsURLRequest(WebCore::HTTPBodyUpdatePolicy::UpdateHTTPBody);
 applySniffingPoliciesAndBindRequestToInferfaceIfNeeded(nsRequest, shouldContentSniff == WebCore::ContentSniffingPolicy::SniffContent && !url.isLocalFile(), shouldContentEncodingSniff == WebCore::ContentEncodingSniffingPolicy::Sniff);
 
-m_task = [m_sessionWrapper.session dataTaskWithRequest:nsRequest];
+m_task = [m_sessionWrapper->session dataTaskWithRequest:nsRequest];
 
 BEGIN_SIGNPOST(m_task, "%{public}s pri: %f preconnect: %d", url.string().ascii().data(), toNSURLSessionTaskPriority(request.priority()), shouldPreconnectOnly == PreconnectOnly::Yes);
 
-RELEASE_ASSERT(!m_sessionWrapper.dataTaskMap.contains([m_task taskIdentifier]));
-

[webkit-changes] [256856] trunk/Source/WebCore

[peng . liu6]

Title: [256856] trunk/Source/WebCore








Revision 256856
Author peng.l...@apple.com
Date 2020-02-18 14:52:38 -0800 (Tue, 18 Feb 2020)


Log Message
MediaSource.isTypeSupported() says "video/mp4;codecs=\"avc3.42C015\"" is not supported, but it is
https://bugs.webkit.org/show_bug.cgi?id=207622

Reviewed by Eric Carlson.

Revert the behavior change of MediaPlayerPrivateMediaSourceAVFObjC::supportsType() in r253952.

* platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
(WebCore::AVAssetMIMETypeCache::canDecodeExtendedType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (256855 => 256856)

--- trunk/Source/WebCore/ChangeLog	2020-02-18 22:41:15 UTC (rev 256855)
+++ trunk/Source/WebCore/ChangeLog	2020-02-18 22:52:38 UTC (rev 256856)
@@ -1,3 +1,15 @@
+2020-02-18  Peng Liu  
+
+MediaSource.isTypeSupported() says "video/mp4;codecs=\"avc3.42C015\"" is not supported, but it is
+https://bugs.webkit.org/show_bug.cgi?id=207622
+
+Reviewed by Eric Carlson.
+
+Revert the behavior change of MediaPlayerPrivateMediaSourceAVFObjC::supportsType() in r253952.
+
+* platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
+(WebCore::AVAssetMIMETypeCache::canDecodeExtendedType):
+
 2020-02-18  Antti Koivisto  
 
 [macOS] Don't fire timers when there is a pending rendering update


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm (256855 => 256856)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm	2020-02-18 22:41:15 UTC (rev 256855)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm	2020-02-18 22:52:38 UTC (rev 256856)
@@ -59,14 +59,8 @@
 #if ENABLE(VIDEO) && USE(AVFOUNDATION)
 ASSERT(isAvailable());
 
-String outputCodecs = type.parameter(ContentType::codecsParameter());
-ASSERT(!outputCodecs.isEmpty());
-if ([PAL::getAVStreamDataParserClass() respondsToSelector:@selector(outputMIMECodecParameterForInputMIMECodecParameter:)])
-outputCodecs = [PAL::getAVStreamDataParserClass() outputMIMECodecParameterForInputMIMECodecParameter:outputCodecs];
-
-String extendedType = makeString(type.containerType(), "; codecs=\"", outputCodecs, "\"");
 if ([PAL::getAVStreamDataParserClass() respondsToSelector:@selector(canParseExtendedMIMEType:)])
-return [PAL::getAVStreamDataParserClass() canParseExtendedMIMEType:extendedType];
+return [PAL::getAVStreamDataParserClass() canParseExtendedMIMEType:type.raw()];
 
 // FIXME(rdar://50502771) AVStreamDataParser does not have an -canParseExtendedMIMEType: method on this system,
 //  so just replace the container type with a valid one from AVAssetMIMETypeCache and ask that cache if it


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (256855 => 256856)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm	2020-02-18 22:41:15 UTC (rev 256855)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm	2020-02-18 22:52:38 UTC (rev 256856)
@@ -253,14 +253,21 @@
 if (!parameters.isMediaSource)
 return MediaPlayer::SupportsType::IsNotSupported;
 
+String extendedType = parameters.type.raw();
+String outputCodecs = parameters.type.parameter(ContentType::codecsParameter());
+if (!outputCodecs.isEmpty() && [PAL::getAVStreamDataParserClass() respondsToSelector:@selector(outputMIMECodecParameterForInputMIMECodecParameter:)]) {
+outputCodecs = [PAL::getAVStreamDataParserClass() outputMIMECodecParameterForInputMIMECodecParameter:outputCodecs];
+extendedType = makeString(parameters.type.containerType(), "; codecs=\"", outputCodecs, "\"");
+}
+
 auto supported = MediaPlayer::SupportsType::IsNotSupported;
 auto& streamDataParserCache = AVStreamDataParserMIMETypeCache::singleton();
 if (streamDataParserCache.isAvailable())
-supported = streamDataParserCache.canDecodeType(parameters.type.raw());
+supported = streamDataParserCache.canDecodeType(extendedType);
 else {
 auto& assetCache = AVAssetMIMETypeCache::singleton();
 if (assetCache.isAvailable())
-supported = assetCache.canDecodeType(parameters.type.raw());
+supported = assetCache.canDecodeType(extendedType);
 }
 
 if (supported != MediaPlayer::SupportsType::IsSupported)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256855] tags/Safari-610.1.3.2/

[alancoon]

Title: [256855] tags/Safari-610.1.3.2/








Revision 256855
Author alanc...@apple.com
Date 2020-02-18 14:41:15 -0800 (Tue, 18 Feb 2020)


Log Message
Tag Safari-610.1.3.2.

Added Paths

tags/Safari-610.1.3.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256854] branches/safari-610.1.3-branch/Source

[alancoon]

Title: [256854] branches/safari-610.1.3-branch/Source








Revision 256854
Author alanc...@apple.com
Date 2020-02-18 14:31:20 -0800 (Tue, 18 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-610.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.1.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256853 => 256854)

--- branches/safari-610.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 21:58:11 UTC (rev 256853)
+++ branches/safari-610.1.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 22:31:20 UTC (rev 256854)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256853 => 256854)

--- branches/safari-610.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 21:58:11 UTC (rev 256853)
+++ branches/safari-610.1.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 22:31:20 UTC (rev 256854)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256853 => 256854)

--- branches/safari-610.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 21:58:11 UTC (rev 256853)
+++ branches/safari-610.1.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 22:31:20 UTC (rev 256854)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/WebCore/Configurations/Version.xcconfig (256853 => 256854)

--- branches/safari-610.1.3-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 21:58:11 UTC (rev 256853)
+++ branches/safari-610.1.3-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 22:31:20 UTC (rev 256854)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256853 => 256854)

--- branches/safari-610.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 21:58:11 UTC (rev 256853)
+++ branches/safari-610.1.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 22:31:20 UTC (rev 256854)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (256853 => 256854)

--- branches/safari-610.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-18 21:58:11 UTC (rev 256853)
+++ branches/safari-610.1.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-18 22:31:20 UTC (rev 256854)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.3-branch/Source/WebKit/Configurations/Version.xcconfig (256853 => 256854)

--- branches/safari-610.1.3-branch/Source/WebKit/Configurations/Version.xcconfig	2020-02-18 21:58:11 UTC (rev 256853)
+++ branches/safari-610.1.3-branch/Source/WebKit/Configurations/Version.xcconfig	2020-02-18 22:31:20 UTC (rev 256854)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 3;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = 

[webkit-changes] [256853] trunk/Source

[antti]

Title: [256853] trunk/Source








Revision 256853
Author an...@apple.com
Date 2020-02-18 13:58:11 -0800 (Tue, 18 Feb 2020)


Log Message
[macOS] Don't fire timers when there is a pending rendering update
https://bugs.webkit.org/show_bug.cgi?id=207889

Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* dom/WindowEventLoop.cpp:
(WebCore::WindowEventLoop::breakToAllowRenderingUpdate):

Add the exported interface to WindowEventLoop as the future direction is to do everything via it.
For now it just calls into ThreadTimers rather than doing anything with the event loop itself.

* dom/WindowEventLoop.h:
* platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::sharedTimerFiredInternal):
(WebCore::ThreadTimers::breakFireLoopForRenderingUpdate):

If we are in a firing timer set a flag so that no more timers are fired during the current runloop cycle.

* platform/ThreadTimers.h:

Source/WebKit:

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scheduleRenderingUpdateRunLoopObserver):

Ensure the event loop cycles to reach the runloop observer as fast as possible.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/WindowEventLoop.cpp
trunk/Source/WebCore/dom/WindowEventLoop.h
trunk/Source/WebCore/platform/ThreadTimers.cpp
trunk/Source/WebCore/platform/ThreadTimers.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (256852 => 256853)

--- trunk/Source/WebCore/ChangeLog	2020-02-18 21:45:47 UTC (rev 256852)
+++ trunk/Source/WebCore/ChangeLog	2020-02-18 21:58:11 UTC (rev 256853)
@@ -1,3 +1,26 @@
+2020-02-18  Antti Koivisto  
+
+[macOS] Don't fire timers when there is a pending rendering update
+https://bugs.webkit.org/show_bug.cgi?id=207889
+
+Reviewed by Simon Fraser.
+
+* WebCore.xcodeproj/project.pbxproj:
+* dom/WindowEventLoop.cpp:
+(WebCore::WindowEventLoop::breakToAllowRenderingUpdate):
+
+Add the exported interface to WindowEventLoop as the future direction is to do everything via it.
+For now it just calls into ThreadTimers rather than doing anything with the event loop itself.
+
+* dom/WindowEventLoop.h:
+* platform/ThreadTimers.cpp:
+(WebCore::ThreadTimers::sharedTimerFiredInternal):
+(WebCore::ThreadTimers::breakFireLoopForRenderingUpdate):
+
+If we are in a firing timer set a flag so that no more timers are fired during the current runloop cycle.
+
+* platform/ThreadTimers.h:
+
 2020-02-18  Youenn Fablet  
 
 Remove PlatformMediaSessionClient dependency on Document


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (256852 => 256853)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2020-02-18 21:45:47 UTC (rev 256852)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2020-02-18 21:58:11 UTC (rev 256853)
@@ -2891,7 +2891,7 @@
 		9B02E0C8235EAD2A004044B2 /* TextManipulationController.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B02E0C3235E76AA004044B2 /* TextManipulationController.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		9B0ABCAE236BB43100B45085 /* TaskSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B0ABCAC236BB40A00B45085 /* TaskSource.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		9B24DE8E15194B9500C59C27 /* HTMLBDIElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B24DE8C15194B9500C59C27 /* HTMLBDIElement.h */; };
-		9B27FC60234D9ADB00394A46 /* WindowEventLoop.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B27FC5E234D9ADA00394A46 /* WindowEventLoop.h */; };
+		9B27FC60234D9ADB00394A46 /* WindowEventLoop.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B27FC5E234D9ADA00394A46 /* WindowEventLoop.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		9B2D8A7914997CCF00ECEF3E /* UndoStep.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B2D8A7814997CCF00ECEF3E /* UndoStep.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		9B32CDA913DF7FA900F34D13 /* RenderedPosition.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B32CDA713DF7FA900F34D13 /* RenderedPosition.h */; };
 		9B417064125662B3006B28FC /* ApplyBlockElementCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B417062125662B3006B28FC /* ApplyBlockElementCommand.h */; };
@@ -3408,7 +3408,6 @@
 		AA7FEEAD16A4E74B004C0C33 /* JSSpeechSynthesis.h in Headers */ = {isa = PBXBuildFile; fileRef = AA7FEEAC16A4E74B004C0C33 /* JSSpeechSynthesis.h */; };
 		AAA728F716D1D8BC00D3BBC6 /* WebAccessibilityObjectWrapperIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = AAA728F116D1D8BC00D3BBC6 /* WebAccessibilityObjectWrapperIOS.h */; };
 		AAC08CF315F941FD00F1E188 /* AccessibilitySVGRoot.h in Headers */ = {isa = PBXBuildFile; fileRef = AAC08CF115F941FC00F1E188 /* AccessibilitySVGRoot.h */; };
-		

[webkit-changes] [256852] trunk/Source

[alancoon]

Title: [256852] trunk/Source








Revision 256852
Author alanc...@apple.com
Date 2020-02-18 13:45:47 -0800 (Tue, 18 Feb 2020)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (256851 => 256852)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 20:17:36 UTC (rev 256851)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 21:45:47 UTC (rev 256852)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256851 => 256852)

--- trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 20:17:36 UTC (rev 256851)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 21:45:47 UTC (rev 256852)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256851 => 256852)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 20:17:36 UTC (rev 256851)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 21:45:47 UTC (rev 256852)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (256851 => 256852)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 20:17:36 UTC (rev 256851)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 21:45:47 UTC (rev 256852)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (256851 => 256852)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 20:17:36 UTC (rev 256851)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 21:45:47 UTC (rev 256852)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (256851 => 256852)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-18 20:17:36 UTC (rev 256851)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-18 21:45:47 UTC (rev 256852)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (256851 => 256852)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2020-02-18 20:17:36 UTC (rev 256851)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2020-02-18 21:45:47 UTC (rev 256852)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (256851 => 256852)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2020-02-18 20:17:36 UTC (rev 256851)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2020-02-18 21:45:47 UTC (rev 256852)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256851] trunk/Tools

[jlewis3]

Title: [256851] trunk/Tools








Revision 256851
Author jlew...@apple.com
Date 2020-02-18 12:17:36 -0800 (Tue, 18 Feb 2020)


Log Message
Stub repositories fail to upload some results due to missing head svn revision
https://bugs.webkit.org/show_bug.cgi?id=207684

Reviewed by Jonathan Bedard.

* Scripts/webkitpy/api_tests/run_api_tests.py:
(main): Added initializing the scm to the host object.
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
it in line with modern code.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main): Added inializing the scm to the host object.
* Scripts/webkitpy/port/base.py:
(Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
from using mock SCMs and more
* Scripts/webkitpy/test/main.py:
(main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
and converted the webkit_root variable to the SCM checkout root.
(Tester._run_tests):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/Scripts/webkitpy/port/base.py
trunk/Tools/Scripts/webkitpy/test/main.py




Diff

Modified: trunk/Tools/ChangeLog (256850 => 256851)

--- trunk/Tools/ChangeLog	2020-02-18 20:09:29 UTC (rev 256850)
+++ trunk/Tools/ChangeLog	2020-02-18 20:17:36 UTC (rev 256851)
@@ -1,3 +1,25 @@
+2020-02-18  Matt Lewis  
+
+Stub repositories fail to upload some results due to missing head svn revision
+https://bugs.webkit.org/show_bug.cgi?id=207684
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/webkitpy/api_tests/run_api_tests.py:
+(main): Added initializing the scm to the host object.
+* Scripts/webkitpy/layout_tests/models/test_run_results.py:
+(summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
+it in line with modern code.
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(main): Added inializing the scm to the host object.
+* Scripts/webkitpy/port/base.py:
+(Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
+from using mock SCMs and more
+* Scripts/webkitpy/test/main.py:
+(main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
+and converted the webkit_root variable to the SCM checkout root.
+(Tester._run_tests):
+
 2020-02-18  Per Arne Vollan  
 
 Move [UIDevice currentDevice] calls to UI process


Modified: trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py (256850 => 256851)

--- trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py	2020-02-18 20:09:29 UTC (rev 256850)
+++ trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py	2020-02-18 20:17:36 UTC (rev 256851)
@@ -41,6 +41,7 @@
 def main(argv, stdout, stderr):
 options, args = parse_args(argv)
 host = Host()
+host.initialize_scm()
 
 try:
 options.webkit_test_runner = True


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (256850 => 256851)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2020-02-18 20:09:29 UTC (rev 256850)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py	2020-02-18 20:17:36 UTC (rev 256851)
@@ -359,7 +359,7 @@
 # FIXME: Do we really need to populate this both here and in the json_results_generator?
 if port_obj.get_option("builder_name"):
 port_obj.host.initialize_scm()
-results['revision'] = port_obj.host.scm().head_svn_revision()
+results['revision'] = port_obj.commits_for_upload()[0]['id']
 except Exception as e:
 _log.warn("Failed to determine svn revision for checkout (cwd: %s, webkit_base: %s), leaving 'revision' key blank in full_results.json.\n%s" % (port_obj._filesystem.getcwd(), port_obj.path_from_webkit_base(), e))
 # Handle cases where we're running outside of version control.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (256850 => 256851)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2020-02-18 20:09:29 UTC (rev 256850)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2020-02-18 20:17:36 UTC (rev 256851)
@@ -64,6 +64,7 @@
 host = MockHost()
 else:
 host = Host()
+host.initialize_scm()
 
 if options.lint_test_files:
 from webkitpy.layout_tests.lint_test_expectations import lint


Modified: trunk/Tools/Scripts/webkitpy/port/base.py (256850 => 256851)

--- trunk/Tools/Scripts/webkitpy/port/base.py	2020-02-18 20:09:29 UTC (rev 256850)
+++ trunk/Tools/Scripts/webkitpy/port/base.py	2020-02-18 20:17:36 UTC (rev 

[webkit-changes] [256850] trunk/Source/JavaScriptCore

[commit-queue]

Title: [256850] trunk/Source/_javascript_Core








Revision 256850
Author commit-qu...@webkit.org
Date 2020-02-18 12:09:29 -0800 (Tue, 18 Feb 2020)


Log Message
Fix order (in MIPS) under which CS-registers are saved/restored
https://bugs.webkit.org/show_bug.cgi?id=207752

Patch by Paulo Matos  on 2020-02-18
Reviewed by Keith Miller.

This has been causing several segfaults on MIPS with JIT enabled
because during an OSR to baseline, the order in which LLInt was
saving the registers was not in sync with the way baseline was
restoring them.

* llint/LowLevelInterpreter.asm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (256849 => 256850)

--- trunk/Source/_javascript_Core/ChangeLog	2020-02-18 20:06:35 UTC (rev 256849)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-02-18 20:09:29 UTC (rev 256850)
@@ -1,3 +1,17 @@
+2020-02-18  Paulo Matos  
+
+Fix order (in MIPS) under which CS-registers are saved/restored
+https://bugs.webkit.org/show_bug.cgi?id=207752
+
+Reviewed by Keith Miller.
+
+This has been causing several segfaults on MIPS with JIT enabled
+because during an OSR to baseline, the order in which LLInt was
+saving the registers was not in sync with the way baseline was
+restoring them.
+
+* llint/LowLevelInterpreter.asm:
+
 2020-02-18  Ross Kirsling  
 
 [JSC] Computed function properties compute their keys twice


Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm (256849 => 256850)

--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2020-02-18 20:06:35 UTC (rev 256849)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2020-02-18 20:09:29 UTC (rev 256850)
@@ -791,9 +791,20 @@
 subp CalleeSaveSpaceStackAligned, sp
 if C_LOOP or C_LOOP_WIN
 storep metadataTable, -PtrSize[cfr]
-elsif ARMv7 or MIPS
+
+# Next ARMv7 and MIPS differ in how we store metadataTable and PB,
+# because this codes needs to be in sync with how registers are
+# restored in Baseline JIT (specifically in emitRestoreCalleeSavesFor).
+# emitRestoreCalleeSavesFor restores registers in order instead of by name.
+# However, ARMv7 and MIPS differ in the order in which registers are assigned
+# to metadataTable and PB, therefore they can also not have the same saving
+# order.
+elsif ARMv7
 storep metadataTable, -4[cfr]
 storep PB, -8[cfr]
+elsif MIPS
+storep PB, -4[cfr]
+storep metadataTable, -8[cfr]
 elsif ARM64 or ARM64E
 emit "stp x27, x28, [x29, #-16]"
 emit "stp x25, x26, [x29, #-32]"
@@ -815,9 +826,14 @@
 macro restoreCalleeSavesUsedByLLInt()
 if C_LOOP or C_LOOP_WIN
 loadp -PtrSize[cfr], metadataTable
-elsif ARMv7 or MIPS
+# To understand why ARMv7 and MIPS differ in restore order,
+# see comment in preserveCalleeSavesUsedByLLInt
+elsif ARMv7
 loadp -4[cfr], metadataTable
 loadp -8[cfr], PB
+elsif MIPS
+loadp -4[cfr], PB
+loadp -8[cfr], metadataTable
 elsif ARM64 or ARM64E
 emit "ldp x25, x26, [x29, #-32]"
 emit "ldp x27, x28, [x29, #-16]"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256848] branches/safari-610.1.4-branch/Source/WebKit

[alancoon]

Title: [256848] branches/safari-610.1.4-branch/Source/WebKit








Revision 256848
Author alanc...@apple.com
Date 2020-02-18 12:06:23 -0800 (Tue, 18 Feb 2020)


Log Message
Cherry-pick r256740. rdar://problem/59527003

[iOS] Add telemetry with backtrace for specific rules
https://bugs.webkit.org/show_bug.cgi?id=207494

Reviewed by Brent Fulgham.

For specific sandbox mach lookup rules in the WebContent process, add telemetry with backtrace.

No new tests, no behavior change.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.4-branch/Source/WebKit/ChangeLog
branches/safari-610.1.4-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: branches/safari-610.1.4-branch/Source/WebKit/ChangeLog (256847 => 256848)

--- branches/safari-610.1.4-branch/Source/WebKit/ChangeLog	2020-02-18 20:01:21 UTC (rev 256847)
+++ branches/safari-610.1.4-branch/Source/WebKit/ChangeLog	2020-02-18 20:06:23 UTC (rev 256848)
@@ -1,3 +1,35 @@
+2020-02-18  Alan Coon  
+
+Cherry-pick r256740. rdar://problem/59527003
+
+[iOS] Add telemetry with backtrace for specific rules
+https://bugs.webkit.org/show_bug.cgi?id=207494
+
+Reviewed by Brent Fulgham.
+
+For specific sandbox mach lookup rules in the WebContent process, add telemetry with backtrace.
+
+No new tests, no behavior change.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-17  Per Arne Vollan  
+
+[iOS] Add telemetry with backtrace for specific rules
+https://bugs.webkit.org/show_bug.cgi?id=207494
+
+Reviewed by Brent Fulgham.
+
+For specific sandbox mach lookup rules in the WebContent process, add telemetry with backtrace.
+
+No new tests, no behavior change.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-02-15  Pavel Feldman  
 
 [Geoclue] Avoid usage of provider in callbacks after it has been destroyed


Modified: branches/safari-610.1.4-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (256847 => 256848)

--- branches/safari-610.1.4-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-02-18 20:01:21 UTC (rev 256847)
+++ branches/safari-610.1.4-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-02-18 20:06:23 UTC (rev 256848)
@@ -115,7 +115,7 @@
 (allow file-read* asset-access-filter)
 (if (memq 'with-media-playback options)
 (play-media asset-access-filter))
-(allow mach-lookup (with report) (with telemetry)
+(allow mach-lookup (with telemetry-backtrace) (with telemetry)
(global-name "com.apple.mobileassetd" "com.apple.mobileassetd.v2"))
 (mobile-preferences-read "com.apple.MobileAsset")))
 
@@ -353,7 +353,7 @@
 "com.apple.mt"
 "com.apple.preferences.sounds")
 
-(allow mach-lookup (with report) (with telemetry)
+(allow mach-lookup (with telemetry-backtrace) (with telemetry)
 (global-name "com.apple.frontboard.systemappservices") ; -[UIViewServiceInterface _createProcessAssertion] -> SBSProcessIDForDisplayIdentifier()
 )
 
@@ -544,7 +544,7 @@
 (allow ipc-posix-shm-read*
(ipc-posix-name-prefix "apple.cfprefs."))
  
-(allow mach-lookup (with report) (with telemetry)
+(allow mach-lookup (with telemetry-backtrace) (with telemetry)
 (global-name "com.apple.lsd.open")
 (global-name "com.apple.lsd.mapdb"))
 
@@ -669,7 +669,7 @@
 ;;  LaunchServices app icons
 (allow file-read*
 (well-known-system-group-container-subpath "/systemgroup.com.apple.lsd.iconscache"))
-(allow mach-lookup (with report) (with telemetry)
+(allow mach-lookup (with telemetry-backtrace) (with telemetry)
 (xpc-service-name "com.apple.iconservices")
 (global-name "com.apple.iconservices"))
 
@@ -828,7 +828,7 @@
 (allow mach-lookup
(global-name "com.apple.webinspector"))
 
-(allow mach-lookup (with report) (with telemetry)
+(allow mach-lookup (with telemetry-backtrace) (with telemetry)
 (global-name "com.apple.PowerManagement.control"))
 
 (deny file-write-create (vnode-type SYMLINK))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256849] branches/safari-610.1.4-branch/Source

[alancoon]

Title: [256849] branches/safari-610.1.4-branch/Source








Revision 256849
Author alanc...@apple.com
Date 2020-02-18 12:06:35 -0800 (Tue, 18 Feb 2020)


Log Message
Cherry-pick r256791. rdar://problem/59554260

getVTablePointer() should return a const void*.
https://bugs.webkit.org/show_bug.cgi?id=207871


Reviewed by Yusuke Suzuki.

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSInterfaceName.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSMapLike.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSReadOnlySetLike.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSSetLike.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestCEReactions.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestEnabledForContext.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestIterable.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::toJSNewlyCreated):
* bindings/scripts/test/JS/JSTestPluginInterface.cpp:

[webkit-changes] [256846] trunk

[ross . kirsling]

Title: [256846] trunk








Revision 256846
Author ross.kirsl...@sony.com
Date 2020-02-18 12:01:20 -0800 (Tue, 18 Feb 2020)


Log Message
[JSC] Computed function properties compute their keys twice
https://bugs.webkit.org/show_bug.cgi?id=207297

Reviewed by Keith Miller.

JSTests:

* stress/computed-property-key-side-effects.js: Added.
* test262/expectations.yaml: Mark 6 test cases as passing.

Source/_javascript_Core:

If a pseudo-String is used as the key of a computed function property,
any side effects from resolving the string value occur in duplicate.

The cause has two parts:
  - We aren't ensuring that the string value is resolved before doing SetFunctionName and PutByVal.
  - Our implementation of SetFunctionName (https://tc39.es/ecma262/#sec-setfunctionname)
calls toString on a non-symbol argument, instead of assuming the type is a string.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::shouldSetFunctionName): Added.
(JSC::BytecodeGenerator::emitSetFunctionName): Added.
(JSC::BytecodeGenerator::emitSetFunctionNameIfNeededImpl): Deleted.
(JSC::BytecodeGenerator::emitSetFunctionNameIfNeeded): Deleted.
* bytecompiler/BytecodeGenerator.h:
Split the "if needed" logic out into its own function.

* bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
(JSC::PropertyListNode::emitPutConstantProperty):
(JSC::DefineFieldNode::emitBytecode):
Never emit OpSetFunctionName for a name of unknown type.
(But also, don't perform a needless ToPropertyKey for non-function computed property keys.)

* runtime/JSFunction.cpp:
(JSC::JSFunction::setFunctionName):
Don't call toString, assert isString.

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.cpp


Added Paths

trunk/JSTests/stress/computed-property-key-side-effects.js




Diff

Modified: trunk/JSTests/ChangeLog (256845 => 256846)

--- trunk/JSTests/ChangeLog	2020-02-18 19:55:39 UTC (rev 256845)
+++ trunk/JSTests/ChangeLog	2020-02-18 20:01:20 UTC (rev 256846)
@@ -1,3 +1,13 @@
+2020-02-18  Ross Kirsling  
+
+[JSC] Computed function properties compute their keys twice
+https://bugs.webkit.org/show_bug.cgi?id=207297
+
+Reviewed by Keith Miller.
+
+* stress/computed-property-key-side-effects.js: Added.
+* test262/expectations.yaml: Mark 6 test cases as passing.
+
 2020-02-17  Yusuke Suzuki  
 
 [JSC] JITThunk should be HashSet> with appropriate GC weakness handling


Added: trunk/JSTests/stress/computed-property-key-side-effects.js (0 => 256846)

--- trunk/JSTests/stress/computed-property-key-side-effects.js	(rev 0)
+++ trunk/JSTests/stress/computed-property-key-side-effects.js	2020-02-18 20:01:20 UTC (rev 256846)
@@ -0,0 +1,38 @@
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error(`expected ${expected} but got ${actual}`);
+}
+
+let count;
+const key1 = { toString() { count++; return 'foo'; } };
+const key2 = { toString: null, valueOf() { count++; return 'foo'; } };
+
+function test() {
+  count = 0;
+
+  ({ [key1]() { return 'bar'; } });
+  shouldBe(count, 1);
+  ({ [key1]: function () { return 'bar'; } });
+  shouldBe(count, 2);
+  ({ [key1]: () => 'bar' });
+  shouldBe(count, 3);
+  ({ get [key1]() { return 'bar'; } });
+  shouldBe(count, 4);
+  ({ set [key1](_) {} });
+  shouldBe(count, 5);
+
+  ({ [key2]() { return 'bar'; } });
+  shouldBe(count, 6);
+  ({ [key2]: function () { return 'bar'; } });
+  shouldBe(count, 7);
+  ({ [key2]: () => 'bar' });
+  shouldBe(count, 8);
+  ({ get [key2]() { return 'bar'; } });
+  shouldBe(count, 9);
+  ({ set [key2](_) {} });
+  shouldBe(count, 10);
+}
+noInline(test);
+
+for (let i = 0; i < 1e5; i++)
+  test();


Modified: trunk/JSTests/test262/expectations.yaml (256845 => 256846)

--- trunk/JSTests/test262/expectations.yaml	2020-02-18 19:55:39 UTC (rev 256845)
+++ trunk/JSTests/test262/expectations.yaml	2020-02-18 20:01:20 UTC (rev 256846)
@@ -2203,15 +2203,6 @@
   default: 'Test262: This statement should not be evaluated.'
 test/language/block-scope/syntax/redeclaration/var-redeclaration-attempt-after-generator.js:
   default: 'Test262: This statement should not be evaluated.'
-test/language/computed-property-names/to-name-side-effects/class.js:
-  default: 'Test262Error: Expected [0, 1] and [0] to have the same contents. order set for key1'
-  strict mode: 'Test262Error: Expected [0, 1] and [0] to have the same contents. order set for key1'
-test/language/computed-property-names/to-name-side-effects/numbers-class.js:
-  default: 'Test262Error: Expected [0, 1] and [0] to have the same contents. order set for key1'
-  strict mode: 'Test262Error: Expected [0, 1] and [0] to 

[webkit-changes] [256847] trunk/LayoutTests

[cdumez]

Title: [256847] trunk/LayoutTests








Revision 256847
Author cdu...@apple.com
Date 2020-02-18 12:01:21 -0800 (Tue, 18 Feb 2020)


Log Message
[WK1] Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html
https://bugs.webkit.org/show_bug.cgi?id=207895


Unreviewed, mark test as flaky on WK1 only as the WK2 bots appear to be fine.

* TestExpectations:
* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256846 => 256847)

--- trunk/LayoutTests/ChangeLog	2020-02-18 20:01:20 UTC (rev 256846)
+++ trunk/LayoutTests/ChangeLog	2020-02-18 20:01:21 UTC (rev 256847)
@@ -1,5 +1,16 @@
 2020-02-18  Chris Dumez  
 
+[WK1] Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html
+https://bugs.webkit.org/show_bug.cgi?id=207895
+
+
+Unreviewed, mark test as flaky on WK1 only as the WK2 bots appear to be fine.
+
+* TestExpectations:
+* platform/mac-wk1/TestExpectations:
+
+2020-02-18  Chris Dumez  
+
 Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html
 https://bugs.webkit.org/show_bug.cgi?id=207895
 


Modified: trunk/LayoutTests/TestExpectations (256846 => 256847)

--- trunk/LayoutTests/TestExpectations	2020-02-18 20:01:20 UTC (rev 256846)
+++ trunk/LayoutTests/TestExpectations	2020-02-18 20:01:21 UTC (rev 256847)
@@ -3344,9 +3344,6 @@
 
 webkit.org/b/206676 imported/w3c/web-platform-tests/requestidlecallback/callback-xhr-sync.html [ Pass Failure ]
 
-# This seems to be indicative of a CFNetwork bug.
-webkit.org/b/207895 http/tests/cookies/document-cookie-during-iframe-parsing.html [ Pass Failure ]
-
 # wpt css-backgrounds failures
 webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-attachment-local/attachment-local-clipping-color-4.html [ ImageOnlyFailure ]
 webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-attachment-local/attachment-local-clipping-color-6.html [ ImageOnlyFailure ]


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256846 => 256847)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-18 20:01:20 UTC (rev 256846)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-18 20:01:21 UTC (rev 256847)
@@ -925,6 +925,9 @@
 
 webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
 
+# This seems to be indicative of a CFNetwork bug.
+webkit.org/b/207895 http/tests/cookies/document-cookie-during-iframe-parsing.html [ Pass Failure ]
+
 webkit.org/b/207560 media/airplay-target-availability.html [ Pass Failure ]
 
 webkit.org/b/207153 [ Debug ] animations/animation-callback-timestamp.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256845] trunk/Source/WebKit

[achristensen]

Title: [256845] trunk/Source/WebKit








Revision 256845
Author achristen...@apple.com
Date 2020-02-18 11:55:39 -0800 (Tue, 18 Feb 2020)


Log Message
Unreviewed, rolling out r254873.
https://bugs.webkit.org/show_bug.cgi?id=205751

This is reverting r254081 which is effectively re-landing part of r254873 that was reverted
supposing that would be related to the fix for rdar://problem/59136037 but it was not.
Re-landing this is a step towards rdar://problem/56027111

Reverted changeset:

"Revert suppressesConnectionTerminationOnSystemChange part of
r254081"
https://bugs.webkit.org/show_bug.cgi?id=205751
https://trac.webkit.org/changeset/254873

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp
trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256844 => 256845)

--- trunk/Source/WebKit/ChangeLog	2020-02-18 19:42:31 UTC (rev 256844)
+++ trunk/Source/WebKit/ChangeLog	2020-02-18 19:55:39 UTC (rev 256845)
@@ -1,3 +1,19 @@
+2020-02-18  Alex Christensen  
+
+Unreviewed, rolling out r254873.
+https://bugs.webkit.org/show_bug.cgi?id=205751
+
+This is reverting r254081 which is effectively re-landing part of r254873 that was reverted
+supposing that would be related to the fix for rdar://problem/59136037 but it was not.
+Re-landing this is a step towards rdar://problem/56027111
+
+Reverted changeset:
+
+"Revert suppressesConnectionTerminationOnSystemChange part of
+r254081"
+https://bugs.webkit.org/show_bug.cgi?id=205751
+https://trac.webkit.org/changeset/254873
+
 2020-02-18  Per Arne Vollan  
 
 Move [UIDevice currentDevice] calls to UI process


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (256844 => 256845)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h	2020-02-18 19:42:31 UTC (rev 256844)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h	2020-02-18 19:55:39 UTC (rev 256845)
@@ -186,7 +186,6 @@
 void logDiagnosticMessageWithValue(WebPageProxyIdentifier, const String& message, const String& description, double value, unsigned significantFigures, WebCore::ShouldSample);
 
 #if PLATFORM(COCOA)
-bool suppressesConnectionTerminationOnSystemChange() const { return m_suppressesConnectionTerminationOnSystemChange; }
 RetainPtr sourceApplicationAuditData() const;
 #endif
 #if PLATFORM(COCOA) || USE(SOUP)
@@ -537,7 +536,6 @@
 // multiple requests to clear the cache can come in before previous requests complete, and we need to wait for all of them.
 // In the future using WorkQueue and a counting semaphore would work, as would WorkQueue supporting the libdispatch concept of "work groups".
 dispatch_group_t m_clearCacheDispatchGroup { nullptr };
-bool m_suppressesConnectionTerminationOnSystemChange { false };
 #endif
 
 #if ENABLE(CONTENT_EXTENSIONS)


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp (256844 => 256845)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp	2020-02-18 19:42:31 UTC (rev 256844)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp	2020-02-18 19:55:39 UTC (rev 256845)
@@ -55,7 +55,6 @@
 encoder << uiProcessSDKVersion;
 IPC::encode(encoder, networkATSContext.get());
 encoder << storageAccessAPIEnabled;
-encoder << suppressesConnectionTerminationOnSystemChange;
 #endif
 encoder << defaultDataStoreParameters;
 #if USE(SOUP)
@@ -120,8 +119,6 @@
 return false;
 if (!decoder.decode(result.storageAccessAPIEnabled))
 return false;
-if (!decoder.decode(result.suppressesConnectionTerminationOnSystemChange))
-return false;
 #endif
 
 Optional defaultDataStoreParameters;


Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h (256844 => 256845)

--- trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h	2020-02-18 19:42:31 UTC (rev 256844)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h	2020-02-18 19:55:39 UTC (rev 256845)
@@ -70,7 +70,6 @@
 uint32_t uiProcessSDKVersion { 0 };
 RetainPtr networkATSContext;
 bool storageAccessAPIEnabled;
-bool suppressesConnectionTerminationOnSystemChange;
 #endif
 
 WebsiteDataStoreParameters defaultDataStoreParameters;


Modified: 

[webkit-changes] [256844] trunk/Source/WebCore

[youenn]

Title: [256844] trunk/Source/WebCore








Revision 256844
Author you...@apple.com
Date 2020-02-18 11:42:31 -0800 (Tue, 18 Feb 2020)


Log Message
Remove PlatformMediaSessionClient dependency on Document
https://bugs.webkit.org/show_bug.cgi?id=207892

Reviewed by Eric Carlson.

Move DocumentIdentifier to Platform folder.
Use DocumentIdentifier instead of Document in PlatformMediaSession/Manager.
No change of behavior.

* Headers.cmake:
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::hostingDocumentIdentifier const):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::hostingDocumentIdentifier const):
(WebCore::AudioContext::hostingDocument const): Deleted.
* Modules/webaudio/AudioContext.h:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::stopAllMediaPlayback):
(WebCore::Document::suspendAllMediaPlayback):
(WebCore::Document::resumeAllMediaPlayback):
(WebCore::Document::suspendAllMediaBuffering):
(WebCore::Document::resumeAllMediaBuffering):
* html/HTMLMediaElement.h:
* platform/DocumentIdentifier.h: Renamed from Source/WebCore/dom/DocumentIdentifier.h.
* platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::PlatformMediaSession):
* platform/audio/PlatformMediaSession.h:
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::suspendAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaPlaybackForDocument):
(WebCore::PlatformMediaSessionManager::suspendAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::resumeAllMediaBufferingForDocument):
(WebCore::PlatformMediaSessionManager::sessionsMatching const):
(WebCore::PlatformMediaSessionManager::forEachDocumentSession):
* platform/audio/PlatformMediaSessionManager.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
trunk/Source/WebCore/Modules/webaudio/AudioContext.h
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSession.h
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h


Added Paths

trunk/Source/WebCore/platform/DocumentIdentifier.h


Removed Paths

trunk/Source/WebCore/dom/DocumentIdentifier.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256843 => 256844)

--- trunk/Source/WebCore/ChangeLog	2020-02-18 19:41:25 UTC (rev 256843)
+++ trunk/Source/WebCore/ChangeLog	2020-02-18 19:42:31 UTC (rev 256844)
@@ -1,3 +1,44 @@
+2020-02-18  Youenn Fablet  
+
+Remove PlatformMediaSessionClient dependency on Document
+https://bugs.webkit.org/show_bug.cgi?id=207892
+
+Reviewed by Eric Carlson.
+
+Move DocumentIdentifier to Platform folder.
+Use DocumentIdentifier instead of Document in PlatformMediaSession/Manager.
+No change of behavior.
+
+* Headers.cmake:
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::hostingDocumentIdentifier const):
+* Modules/mediastream/MediaStreamTrack.h:
+* Modules/webaudio/AudioContext.cpp:
+(WebCore::AudioContext::hostingDocumentIdentifier const):
+(WebCore::AudioContext::hostingDocument const): Deleted.
+* Modules/webaudio/AudioContext.h:
+* WebCore.xcodeproj/project.pbxproj:
+* dom/Document.cpp:
+(WebCore::Document::stopAllMediaPlayback):
+(WebCore::Document::suspendAllMediaPlayback):
+(WebCore::Document::resumeAllMediaPlayback):
+(WebCore::Document::suspendAllMediaBuffering):
+(WebCore::Document::resumeAllMediaBuffering):
+* html/HTMLMediaElement.h:
+* platform/DocumentIdentifier.h: Renamed from Source/WebCore/dom/DocumentIdentifier.h.
+* platform/audio/PlatformMediaSession.cpp:
+(WebCore::PlatformMediaSession::PlatformMediaSession):
+* platform/audio/PlatformMediaSession.h:
+* platform/audio/PlatformMediaSessionManager.cpp:
+(WebCore::PlatformMediaSessionManager::stopAllMediaPlaybackForDocument):
+(WebCore::PlatformMediaSessionManager::suspendAllMediaPlaybackForDocument):
+(WebCore::PlatformMediaSessionManager::resumeAllMediaPlaybackForDocument):
+(WebCore::PlatformMediaSessionManager::suspendAllMediaBufferingForDocument):
+(WebCore::PlatformMediaSessionManager::resumeAllMediaBufferingForDocument):
+(WebCore::PlatformMediaSessionManager::sessionsMatching const):
+

[webkit-changes] [256843] branches/safari-610.1.4-branch/Source

[alancoon]

Title: [256843] branches/safari-610.1.4-branch/Source








Revision 256843
Author alanc...@apple.com
Date 2020-02-18 11:41:25 -0800 (Tue, 18 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-610.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.1.4-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.1.4-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.1.4-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256842 => 256843)

--- branches/safari-610.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 19:24:43 UTC (rev 256842)
+++ branches/safari-610.1.4-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-18 19:41:25 UTC (rev 256843)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-610.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256842 => 256843)

--- branches/safari-610.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 19:24:43 UTC (rev 256842)
+++ branches/safari-610.1.4-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-18 19:41:25 UTC (rev 256843)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-610.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256842 => 256843)

--- branches/safari-610.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 19:24:43 UTC (rev 256842)
+++ branches/safari-610.1.4-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-18 19:41:25 UTC (rev 256843)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-610.1.4-branch/Source/WebCore/Configurations/Version.xcconfig (256842 => 256843)

--- branches/safari-610.1.4-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 19:24:43 UTC (rev 256842)
+++ branches/safari-610.1.4-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-18 19:41:25 UTC (rev 256843)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-610.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256842 => 256843)

--- branches/safari-610.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 19:24:43 UTC (rev 256842)
+++ branches/safari-610.1.4-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-18 19:41:25 UTC (rev 256843)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-610.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (256842 => 256843)

--- branches/safari-610.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-18 19:24:43 UTC (rev 256842)
+++ branches/safari-610.1.4-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-02-18 19:41:25 UTC (rev 256843)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-610.1.4-branch/Source/WebKit/Configurations/Version.xcconfig (256842 => 256843)

--- branches/safari-610.1.4-branch/Source/WebKit/Configurations/Version.xcconfig	2020-02-18 19:24:43 UTC (rev 256842)
+++ branches/safari-610.1.4-branch/Source/WebKit/Configurations/Version.xcconfig	2020-02-18 19:41:25 UTC (rev 256843)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-610.1.4-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (256842 => 256843)

--- 

[webkit-changes] [256842] trunk/LayoutTests

[cdumez]

Title: [256842] trunk/LayoutTests








Revision 256842
Author cdu...@apple.com
Date 2020-02-18 11:24:43 -0800 (Tue, 18 Feb 2020)


Log Message
Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html
https://bugs.webkit.org/show_bug.cgi?id=207895

Unreviewed, mark the test as flaky while I work with the CFNetwork team to resolve this.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256841 => 256842)

--- trunk/LayoutTests/ChangeLog	2020-02-18 18:58:04 UTC (rev 256841)
+++ trunk/LayoutTests/ChangeLog	2020-02-18 19:24:43 UTC (rev 256842)
@@ -1,3 +1,12 @@
+2020-02-18  Chris Dumez  
+
+Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html
+https://bugs.webkit.org/show_bug.cgi?id=207895
+
+Unreviewed, mark the test as flaky while I work with the CFNetwork team to resolve this.
+
+* TestExpectations:
+
 2020-02-18  Youenn Fablet  
 
 REGRESSION (256034): http/tests/media/media-stream/get-display-media-prompt.html is failing


Modified: trunk/LayoutTests/TestExpectations (256841 => 256842)

--- trunk/LayoutTests/TestExpectations	2020-02-18 18:58:04 UTC (rev 256841)
+++ trunk/LayoutTests/TestExpectations	2020-02-18 19:24:43 UTC (rev 256842)
@@ -3344,6 +3344,9 @@
 
 webkit.org/b/206676 imported/w3c/web-platform-tests/requestidlecallback/callback-xhr-sync.html [ Pass Failure ]
 
+# This seems to be indicative of a CFNetwork bug.
+webkit.org/b/207895 http/tests/cookies/document-cookie-during-iframe-parsing.html [ Pass Failure ]
+
 # wpt css-backgrounds failures
 webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-attachment-local/attachment-local-clipping-color-4.html [ ImageOnlyFailure ]
 webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-attachment-local/attachment-local-clipping-color-6.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256841] trunk/LayoutTests

[youenn]

Title: [256841] trunk/LayoutTests








Revision 256841
Author you...@apple.com
Date 2020-02-18 10:58:04 -0800 (Tue, 18 Feb 2020)


Log Message
REGRESSION (256034): http/tests/media/media-stream/get-display-media-prompt.html is failing
https://bugs.webkit.org/show_bug.cgi?id=207893


Reviewed by Eric Carlson.

After 256034, we are allowing { audio: true } for getDisplayMedia.
Update the test accordingly, and make it easier to debug by resetting the number of getDisplayMedia prompt for each test
so that they are more indepedent.

* http/tests/media/media-stream/get-display-media-prompt-expected.txt:
* http/tests/media/media-stream/get-display-media-prompt.html:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt-expected.txt
trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt.html
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256840 => 256841)

--- trunk/LayoutTests/ChangeLog	2020-02-18 18:39:55 UTC (rev 256840)
+++ trunk/LayoutTests/ChangeLog	2020-02-18 18:58:04 UTC (rev 256841)
@@ -1,3 +1,19 @@
+2020-02-18  Youenn Fablet  
+
+REGRESSION (256034): http/tests/media/media-stream/get-display-media-prompt.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=207893
+
+
+Reviewed by Eric Carlson.
+
+After 256034, we are allowing { audio: true } for getDisplayMedia.
+Update the test accordingly, and make it easier to debug by resetting the number of getDisplayMedia prompt for each test
+so that they are more indepedent.
+
+* http/tests/media/media-stream/get-display-media-prompt-expected.txt:
+* http/tests/media/media-stream/get-display-media-prompt.html:
+* platform/mac-wk2/TestExpectations:
+
 2020-02-18  Zalan Bujtas  
 
 [LFC][Quirk] Add additional escape reason to cover the case when body needs access to both the body and the ICB geometry


Modified: trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt-expected.txt (256840 => 256841)

--- trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt-expected.txt	2020-02-18 18:39:55 UTC (rev 256840)
+++ trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt-expected.txt	2020-02-18 18:58:04 UTC (rev 256841)
@@ -6,10 +6,9 @@
 PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 0
 
 ** Request an audio-only stream, the user should not be prompted **
-PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 0
-PASS stream is undefined.
-PASS err instanceof Error  is true
-PASS err.name is "TypeError"
+PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 1
+PASS stream.getAudioTracks().length is 0
+PASS stream.getVideoTracks().length is 1
 
 ** Request an video-only stream, the user should be prompted **
 PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 1
@@ -17,35 +16,35 @@
 PASS stream.getVideoTracks().length is 1
 
 ** Request a stream with audio and video, the user should be prompted but no audio track should be created **
-PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 2
+PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 1
 PASS stream.getAudioTracks().length is 0
 PASS stream.getVideoTracks().length is 1
 
 ** Request a stream with 'max' constraints, the user should not be prompted **
-PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 2
+PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 0
 PASS stream is undefined.
 PASS err instanceof Error  is true
 PASS err.name is "TypeError"
 
 ** Request a stream with 'min' constraints, the user should not be prompted **
-PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 2
+PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 0
 PASS stream is undefined.
 PASS err instanceof Error  is true
 PASS err.name is "TypeError"
 
 ** Request a stream with 'advanced' constraints, the user should not be prompted **
-PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 2
+PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 0
 PASS stream is undefined.
 PASS err instanceof Error  is true
 PASS err.name is "TypeError"
 
 ** Request a stream with valid constraints, the user should be prompted **
-PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 3
+PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 1
 PASS stream.getAudioTracks().length is 0
 PASS stream.getVideoTracks().length is 1
 
 ** Request a stream with an exact audio constraint, it should be ignored **
-PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 4
+PASS numberOfTimesGetUserMediaPromptHasBeenCalled() is 1
 PASS stream.getAudioTracks().length is 0
 PASS stream.getVideoTracks().length is 1
 


Modified: trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt.html (256840 => 256841)

--- trunk/LayoutTests/http/tests/media/media-stream/get-display-media-prompt.html	2020-02-18 

[webkit-changes] [256840] trunk

[zalan]

Title: [256840] trunk








Revision 256840
Author za...@apple.com
Date 2020-02-18 10:39:55 -0800 (Tue, 18 Feb 2020)


Log Message
[LFC][Quirk] Add additional escape reason to cover the case when body needs access to both the body and the ICB geometry
https://bugs.webkit.org/show_bug.cgi?id=207869


Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html

When the body is stretched all the way to the ICB, we have to read both the document box's and the ICB's geometry.
This patch also refactors Quirks::stretchedInFlowHeight a bit to decouple the document and the body cases.

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
* layout/FormattingContext.h:
* layout/blockformatting/BlockFormattingContext.h:
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
* layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::needsStretching const):
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):

LayoutTests:

* fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport-expected.txt: Added.
* fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html: Added.
* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextQuirks.cpp


Added Paths

trunk/LayoutTests/fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport-expected.txt
trunk/LayoutTests/fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html




Diff

Modified: trunk/LayoutTests/ChangeLog (256839 => 256840)

--- trunk/LayoutTests/ChangeLog	2020-02-18 18:27:01 UTC (rev 256839)
+++ trunk/LayoutTests/ChangeLog	2020-02-18 18:39:55 UTC (rev 256840)
@@ -1,3 +1,15 @@
+2020-02-18  Zalan Bujtas  
+
+[LFC][Quirk] Add additional escape reason to cover the case when body needs access to both the body and the ICB geometry
+https://bugs.webkit.org/show_bug.cgi?id=207869
+
+
+Reviewed by Antti Koivisto.
+
+* fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport-expected.txt: Added.
+* fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html: Added.
+* platform/ios-wk2/TestExpectations:
+
 2020-02-18  Kate Cheney  
 
 Web socket loads should be captured for logging per-page prevalent domains


Added: trunk/LayoutTests/fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport-expected.txt (0 => 256840)

--- trunk/LayoutTests/fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport-expected.txt	2020-02-18 18:39:55 UTC (rev 256840)
@@ -0,0 +1,5 @@
+layer at (0,0) size 785x601
+  RenderView at (0,0) size 785x600
+layer at (10,10) size 102x102
+  RenderBlock (positioned) {HTML} at (10,10) size 102x102 [border: (1px solid #008000)]
+RenderBody {BODY} at (9,9) size 84x582 [border: (1px solid #FF)]


Added: trunk/LayoutTests/fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html (0 => 256840)

--- trunk/LayoutTests/fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html	(rev 0)
+++ trunk/LayoutTests/fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html	2020-02-18 18:39:55 UTC (rev 256840)
@@ -0,0 +1,4 @@
+
+
+
+


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256839 => 256840)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-18 18:27:01 UTC (rev 256839)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-18 18:39:55 UTC (rev 256840)
@@ -1416,6 +1416,6 @@
 webkit.org/b/207866 imported/w3c/IndexedDB-private-browsing [ Pass Timeout ]
 
 # skip LFC regression tests on iOS for now.
-fast/layoutformattingcontext/block-only/ [ Skip ]
+fast/layoutformattingcontext/ [ Skip ]
 
 webkit.org/b/207896 fast/canvas/webgl/oes-vertex-array-object.html [ Pass Failure ]
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (256839 => 256840)

--- trunk/Source/WebCore/ChangeLog	2020-02-18 18:27:01 UTC (rev 256839)
+++ trunk/Source/WebCore/ChangeLog	2020-02-18 18:39:55 UTC (rev 256840)
@@ -1,3 +1,26 @@
+2020-02-18  Zalan Bujtas  
+
+[LFC][Quirk] Add additional 

[webkit-changes] [256839] trunk

[pvollan]

Title: [256839] trunk








Revision 256839
Author pvol...@apple.com
Date 2020-02-18 10:27:01 -0800 (Tue, 18 Feb 2020)


Log Message
Move [UIDevice currentDevice] calls to UI process
https://bugs.webkit.org/show_bug.cgi?id=204320

Reviewed by Darin Adler.

Source/WebCore:

Calling [UIDevice currentDevice] will cause the runningboard daemon to be accessed. Since this service will be removed from
the WebContent sandbox, these calls should be moved to the UI process. The function exernalDeviceDisplayNameForPlayer in
MediaPlayerPrivateAVFoundationObjC.mm is calling [[PAL::getUIDeviceClass() currentDevice] localizedModel], which should be
moved to the UI process.

API test: WebKit.LocalizedDeviceName

* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::exernalDeviceDisplayNameForPlayer):
* platform/ios/LocalizedDeviceModel.h: Added.
* platform/ios/LocalizedDeviceModel.mm: Added.
(WebCore::cachedLocalizedDeviceModel):
(WebCore::localizedDeviceModel):
(WebCore::setLocalizedDeviceModel):

Source/WebKit:

Get the localized device name in the UI process, and send it to the WebContent process as part of the
process creation parameters.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesCocoa.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/platform/ios/LocalizedDeviceModel.h
trunk/Source/WebCore/platform/ios/LocalizedDeviceModel.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (256838 => 256839)

--- trunk/Source/WebCore/ChangeLog	2020-02-18 18:19:13 UTC (rev 256838)
+++ trunk/Source/WebCore/ChangeLog	2020-02-18 18:27:01 UTC (rev 256839)
@@ -1,3 +1,27 @@
+2020-02-18  Per Arne Vollan  
+
+Move [UIDevice currentDevice] calls to UI process
+https://bugs.webkit.org/show_bug.cgi?id=204320
+
+Reviewed by Darin Adler.
+
+Calling [UIDevice currentDevice] will cause the runningboard daemon to be accessed. Since this service will be removed from
+the WebContent sandbox, these calls should be moved to the UI process. The function exernalDeviceDisplayNameForPlayer in
+MediaPlayerPrivateAVFoundationObjC.mm is calling [[PAL::getUIDeviceClass() currentDevice] localizedModel], which should be
+moved to the UI process.
+
+API test: WebKit.LocalizedDeviceName
+
+* SourcesCocoa.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::exernalDeviceDisplayNameForPlayer):
+* platform/ios/LocalizedDeviceModel.h: Added.
+* platform/ios/LocalizedDeviceModel.mm: Added.
+(WebCore::cachedLocalizedDeviceModel):
+(WebCore::localizedDeviceModel):
+(WebCore::setLocalizedDeviceModel):
+
 2020-02-18  Youenn Fablet  
 
 Use more ObjectIdentifier in WebRTC MDNS register


Modified: trunk/Source/WebCore/SourcesCocoa.txt (256838 => 256839)

--- trunk/Source/WebCore/SourcesCocoa.txt	2020-02-18 18:19:13 UTC (rev 256838)
+++ trunk/Source/WebCore/SourcesCocoa.txt	2020-02-18 18:27:01 UTC (rev 256839)
@@ -399,6 +399,7 @@
 platform/ios/LegacyTileLayer.mm
 platform/ios/LegacyTileLayerPool.mm
 platform/ios/LocalCurrentTraitCollection.mm
+platform/ios/LocalizedDeviceModel.mm
 platform/ios/LowPowerModeNotifierIOS.mm
 platform/ios/PasteboardIOS.mm
 platform/ios/PlatformEventFactoryIOS.mm @no-unify


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (256838 => 256839)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2020-02-18 18:19:13 UTC (rev 256838)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2020-02-18 18:27:01 UTC (rev 256839)
@@ -4796,6 +4796,7 @@
 		E323CFFA1E5AF6AF00F0B4A0 /* JSDOMConvertPromise.h in Headers */ = {isa = PBXBuildFile; fileRef = E323CFF91E5AF6A500F0B4A0 /* JSDOMConvertPromise.h */; settings = {ATTRIBUTES = (Private, ); }; 

[webkit-changes] [256838] trunk/Source

[youenn]

Title: [256838] trunk/Source








Revision 256838
Author you...@apple.com
Date 2020-02-18 10:19:13 -0800 (Tue, 18 Feb 2020)


Log Message
Use more ObjectIdentifier in WebRTC MDNS register
https://bugs.webkit.org/show_bug.cgi?id=207548

Reviewed by Eric Carlson.

Source/WebCore:

Pass document identifiers instead of uint64_t to mdns register.
No change of behavior.

* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::registerMDNSName):
* dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
(WebCore::Document::suspend):
* platform/mediastream/libwebrtc/LibWebRTCProvider.h:

Source/WebKit:

Use ObjectIdentifier for MDNSRegister for more type and IPC safety.
Update MDNSRegister to also use DocumentIdentifier where more appropriate.

* NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::PendingRegistrationRequest::PendingRegistrationRequest):
(WebKit::NetworkMDNSRegister::registerMDNSName):
(): Deleted.
* NetworkProcess/webrtc/NetworkMDNSRegister.h:
* NetworkProcess/webrtc/NetworkMDNSRegister.messages.in:
* Scripts/webkit/messages.py:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::unregisterMDNSNames):
(WebKit::LibWebRTCProvider::registerMDNSName):
* WebProcess/Network/webrtc/LibWebRTCProvider.h:
* WebProcess/Network/webrtc/WebMDNSRegister.cpp:
(WebKit::WebMDNSRegister::finishedRegisteringMDNSName):
(WebKit::WebMDNSRegister::unregisterMDNSNames):
(WebKit::WebMDNSRegister::registerMDNSName):
* WebProcess/Network/webrtc/WebMDNSRegister.h:
(): Deleted.
* WebProcess/Network/webrtc/WebMDNSRegister.messages.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.h
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.messages.in
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.cpp
trunk/Source/WebKit/WebProcess/Network/webrtc/LibWebRTCProvider.h
trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp
trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.h
trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.messages.in


Added Paths

trunk/Source/WebKit/WebProcess/Network/webrtc/MDNSRegisterIdentifier.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256837 => 256838)

--- trunk/Source/WebCore/ChangeLog	2020-02-18 18:09:13 UTC (rev 256837)
+++ trunk/Source/WebCore/ChangeLog	2020-02-18 18:19:13 UTC (rev 256838)
@@ -1,3 +1,20 @@
+2020-02-18  Youenn Fablet  
+
+Use more ObjectIdentifier in WebRTC MDNS register
+https://bugs.webkit.org/show_bug.cgi?id=207548
+
+Reviewed by Eric Carlson.
+
+Pass document identifiers instead of uint64_t to mdns register.
+No change of behavior.
+
+* Modules/mediastream/PeerConnectionBackend.cpp:
+(WebCore::PeerConnectionBackend::registerMDNSName):
+* dom/Document.cpp:
+(WebCore::Document::prepareForDestruction):
+(WebCore::Document::suspend):
+* platform/mediastream/libwebrtc/LibWebRTCProvider.h:
+
 2020-02-18  Kate Cheney  
 
 Web socket loads should be captured for logging per-page prevalent domains


Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp (256837 => 256838)

--- trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp	2020-02-18 18:09:13 UTC (rev 256837)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp	2020-02-18 18:19:13 UTC (rev 256838)
@@ -504,7 +504,7 @@
 ++m_waitingForMDNSRegistration;
 auto& document = downcast(*m_peerConnection.scriptExecutionContext());
 auto& provider = document.page()->libWebRTCProvider();
-provider.registerMDNSName(document.identifier().toUInt64(), ipAddress, [peerConnection = makeRef(m_peerConnection), this, ipAddress] (LibWebRTCProvider::MDNSNameOrError&& result) {
+provider.registerMDNSName(document.identifier(), ipAddress, [peerConnection = makeRef(m_peerConnection), this, ipAddress] (LibWebRTCProvider::MDNSNameOrError&& result) {
 if (peerConnection->isStopped())
 return;
 


Modified: trunk/Source/WebCore/dom/Document.cpp (256837 => 256838)

--- trunk/Source/WebCore/dom/Document.cpp	2020-02-18 18:09:13 UTC (rev 256837)
+++ trunk/Source/WebCore/dom/Document.cpp	2020-02-18 18:19:13 UTC (rev 256838)
@@ -2496,7 +2496,7 @@
 // FIXME: This should be moved to Modules/mediastream.
 if (LibWebRTCProvider::webRTCAvailable()) {
 if (auto* page = this->page())
-page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+

[webkit-changes] [256837] trunk

[katherine_cheney]

Title: [256837] trunk








Revision 256837
Author katherine_che...@apple.com
Date 2020-02-18 10:09:13 -0800 (Tue, 18 Feb 2020)


Log Message
Web socket loads should be captured for logging per-page prevalent domains
https://bugs.webkit.org/show_bug.cgi?id=207840


Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html

Captures a domain connection via WebSocket to check if it should be
logged as a prevalent resource.

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):

LayoutTests:

Resource load statistics is only supported on mac and iOS, we should
skip this on other platforms.

* http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt: Added.
* http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html: Added.
* platform/gtk/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WebSocket.cpp


Added Paths

trunk/LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt
trunk/LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html




Diff

Modified: trunk/LayoutTests/ChangeLog (256836 => 256837)

--- trunk/LayoutTests/ChangeLog	2020-02-18 17:46:05 UTC (rev 256836)
+++ trunk/LayoutTests/ChangeLog	2020-02-18 18:09:13 UTC (rev 256837)
@@ -1,3 +1,19 @@
+2020-02-18  Kate Cheney  
+
+Web socket loads should be captured for logging per-page prevalent domains
+https://bugs.webkit.org/show_bug.cgi?id=207840
+
+
+Reviewed by Chris Dumez.
+
+Resource load statistics is only supported on mac and iOS, we should
+skip this on other platforms.
+
+* http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt: Added.
+* http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html: Added.
+* platform/gtk/TestExpectations:
+* platform/win/TestExpectations:
+
 2020-02-17  Dean Jackson  
 
 [WebGL] Update WebGL2 results with ANGLE backend


Added: trunk/LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt (0 => 256837)

--- trunk/LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains-expected.txt	2020-02-18 18:09:13 UTC (rev 256837)
@@ -0,0 +1,10 @@
+Ensure web socket loads are captured by per-page prevalent domain logging.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Domain was successfully marked prevalent.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html (0 => 256837)

--- trunk/LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html	(rev 0)
+++ trunk/LayoutTests/http/tests/websocket/web-socket-loads-captured-in-per-page-domains.html	2020-02-18 18:09:13 UTC (rev 256837)
@@ -0,0 +1,39 @@
+
+
+
+
+