[webkit-changes] [259378] trunk/Source/WebCore
Title: [259378] trunk/Source/WebCore
Revision 259378
Author rn...@webkit.org
Date 2020-04-01 22:22:48 -0700 (Wed, 01 Apr 2020)
Log Message
Crash in WebCore::HTMLDocumentParser::insert
https://bugs.webkit.org/show_bug.cgi?id=209892
Reviewed by Darin Adler.
Speculative fix to check that the parser hasn't been detached before running preload scanner.
No new tests since there is no reproduction and I couldn't come up with one.
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259377 => 259378)
--- trunk/Source/WebCore/ChangeLog 2020-04-02 03:55:19 UTC (rev 259377)
+++ trunk/Source/WebCore/ChangeLog 2020-04-02 05:22:48 UTC (rev 259378)
@@ -1,3 +1,18 @@
+2020-04-01 Ryosuke Niwa
+
+Crash in WebCore::HTMLDocumentParser::insert
+https://bugs.webkit.org/show_bug.cgi?id=209892
+
+Reviewed by Darin Adler.
+
+Speculative fix to check that the parser hasn't been detached before running preload scanner.
+
+No new tests since there is no reproduction and I couldn't come up with one.
+
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::pumpTokenizer):
+(WebCore::HTMLDocumentParser::insert):
+
2020-04-01 Jack Lee
Remove the unnecessary null check for document
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (259377 => 259378)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2020-04-02 03:55:19 UTC (rev 259377)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2020-04-02 05:22:48 UTC (rev 259378)
@@ -333,7 +333,7 @@
if (shouldResume)
m_parserScheduler->scheduleForResume();
-if (isWaitingForScripts()) {
+if (isWaitingForScripts() && !isDetached()) {
ASSERT(m_tokenizer.isInDataState());
if (!m_preloadScanner) {
m_preloadScanner = makeUnique(m_options, document()->url(), document()->deviceScaleFactor());
@@ -391,7 +391,7 @@
m_input.insertAtCurrentInsertionPoint(WTFMove(source));
pumpTokenizerIfPossible(ForceSynchronous);
-if (isWaitingForScripts()) {
+if (isWaitingForScripts() && !isDetached()) {
// Check the document.write() output with a separate preload scanner as
// the main scanner can't deal with insertions.
if (!m_insertionPreloadScanner)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259377] trunk/LayoutTests
Title: [259377] trunk/LayoutTests Revision 259377 Author ryanhad...@apple.com Date 2020-04-01 20:55:19 -0700 (Wed, 01 Apr 2020) Log Message [iOS] svg/as-background-image/tiled-background-image.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=209885 Unreviewed test gardening. * platform/ios/TestExpectations: Mark test as flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259376 => 259377) --- trunk/LayoutTests/ChangeLog 2020-04-02 02:31:24 UTC (rev 259376) +++ trunk/LayoutTests/ChangeLog 2020-04-02 03:55:19 UTC (rev 259377) @@ -1,3 +1,12 @@ +2020-04-01 Ryan Haddad + +[iOS] svg/as-background-image/tiled-background-image.html is a flaky image failure +https://bugs.webkit.org/show_bug.cgi?id=209885 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: Mark test as flaky. + 2020-04-01 Ross Kirsling Intl.NumberFormat.prototype.format must preserve sign of -0 Modified: trunk/LayoutTests/platform/ios/TestExpectations (259376 => 259377) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-04-02 02:31:24 UTC (rev 259376) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-04-02 03:55:19 UTC (rev 259377) @@ -3517,6 +3517,8 @@ webkit.org/b/208592 svg/custom/object-sizing-explicit-height.xhtml [ Pass Failure ] +webkit.org/b/209885 svg/as-background-image/tiled-background-image.html [ Pass ImageOnlyFailure ] + # The line breaking rules changed in ICU 66. We've updated the tests to match, but old platforms won't get updated line breaking rules. webkit.org/b/209250 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-normal-015.xht [ ImageOnlyFailure ] webkit.org/b/209250 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-strict-015.xht [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259376] trunk/Source/WebCore
Title: [259376] trunk/Source/WebCore
Revision 259376
Author shihchieh_...@apple.com
Date 2020-04-01 19:31:24 -0700 (Wed, 01 Apr 2020)
Log Message
Remove the unnecessary null check for document
https://bugs.webkit.org/show_bug.cgi?id=209819
Reviewed by Ryosuke Niwa.
No new tests, covered by existing test.
* dom/Node.cpp:
(WebCore::Node::removedFromAncestor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259375 => 259376)
--- trunk/Source/WebCore/ChangeLog 2020-04-02 00:35:02 UTC (rev 259375)
+++ trunk/Source/WebCore/ChangeLog 2020-04-02 02:31:24 UTC (rev 259376)
@@ -1,3 +1,15 @@
+2020-04-01 Jack Lee
+
+Remove the unnecessary null check for document
+https://bugs.webkit.org/show_bug.cgi?id=209819
+
+Reviewed by Ryosuke Niwa.
+
+No new tests, covered by existing test.
+
+* dom/Node.cpp:
+(WebCore::Node::removedFromAncestor):
+
2020-04-01 Wenson Hsieh
Remove some PLATFORM(IOS_FAMILY) guards in TextFieldInputType
Modified: trunk/Source/WebCore/dom/Node.cpp (259375 => 259376)
--- trunk/Source/WebCore/dom/Node.cpp 2020-04-02 00:35:02 UTC (rev 259375)
+++ trunk/Source/WebCore/dom/Node.cpp 2020-04-02 02:31:24 UTC (rev 259376)
@@ -1304,10 +1304,8 @@
if (isInShadowTree() && !treeScope().rootNode().isShadowRoot())
clearFlag(IsInShadowTreeFlag);
if (removalType.disconnectedFromDocument) {
-if (auto* document = ().documentScope()) {
-if (auto* cache = document->existingAXObjectCache())
-cache->remove(*this);
-}
+if (auto* cache = oldParentOfRemovedTree.document().existingAXObjectCache())
+cache->remove(*this);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259375] trunk/Source/WebCore
Title: [259375] trunk/Source/WebCore
Revision 259375
Author wenson_hs...@apple.com
Date 2020-04-01 17:35:02 -0700 (Wed, 01 Apr 2020)
Log Message
Remove some PLATFORM(IOS_FAMILY) guards in TextFieldInputType
https://bugs.webkit.org/show_bug.cgi?id=209883
Reviewed by Darin Adler.
Refactor what is currently a compile-time IOS_FAMILY guard into a runtime check behind a private helper method
on TextFieldInputType. This makes the intention behind the iOS-specific logic more self-evident; no change in
behavior.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleFocusEvent):
(WebCore::TextFieldInputType::handleBlurEvent):
(WebCore::TextFieldInputType::createDataListDropdownIndicator):
(WebCore::TextFieldInputType::shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited const):
(WebCore::TextFieldInputType::didSetValueByUserEdit):
(WebCore::TextFieldInputType::listAttributeTargetChanged):
* html/TextFieldInputType.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/TextFieldInputType.cpp
trunk/Source/WebCore/html/TextFieldInputType.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259374 => 259375)
--- trunk/Source/WebCore/ChangeLog 2020-04-02 00:19:56 UTC (rev 259374)
+++ trunk/Source/WebCore/ChangeLog 2020-04-02 00:35:02 UTC (rev 259375)
@@ -1,3 +1,23 @@
+2020-04-01 Wenson Hsieh
+
+Remove some PLATFORM(IOS_FAMILY) guards in TextFieldInputType
+https://bugs.webkit.org/show_bug.cgi?id=209883
+
+Reviewed by Darin Adler.
+
+Refactor what is currently a compile-time IOS_FAMILY guard into a runtime check behind a private helper method
+on TextFieldInputType. This makes the intention behind the iOS-specific logic more self-evident; no change in
+behavior.
+
+* html/TextFieldInputType.cpp:
+(WebCore::TextFieldInputType::handleFocusEvent):
+(WebCore::TextFieldInputType::handleBlurEvent):
+(WebCore::TextFieldInputType::createDataListDropdownIndicator):
+(WebCore::TextFieldInputType::shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited const):
+(WebCore::TextFieldInputType::didSetValueByUserEdit):
+(WebCore::TextFieldInputType::listAttributeTargetChanged):
+* html/TextFieldInputType.h:
+
2020-04-01 Per Arne Vollan
[Cocoa] UTI from MIME type cache can be removed after r258915
Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (259374 => 259375)
--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2020-04-02 00:19:56 UTC (rev 259374)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2020-04-02 00:35:02 UTC (rev 259375)
@@ -268,8 +268,8 @@
ASSERT_UNUSED(oldFocusedNode, oldFocusedNode != element());
if (RefPtr frame = element()->document().frame()) {
frame->editor().textFieldDidBeginEditing(element());
-#if ENABLE(DATALIST_ELEMENT) && PLATFORM(IOS_FAMILY)
-if (element()->list() && m_dataListDropdownIndicator)
+#if ENABLE(DATALIST_ELEMENT)
+if (shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited() && element()->list() && m_dataListDropdownIndicator)
m_dataListDropdownIndicator->setInlineStyleProperty(CSSPropertyDisplay, suggestions().size() ? CSSValueBlock : CSSValueNone, true);
#endif
}
@@ -280,8 +280,8 @@
InputType::handleBlurEvent();
ASSERT(element());
element()->endEditing();
-#if ENABLE(DATALIST_ELEMENT) && PLATFORM(IOS_FAMILY)
-if (element()->list() && m_dataListDropdownIndicator)
+#if ENABLE(DATALIST_ELEMENT)
+if (shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited() && element()->list() && m_dataListDropdownIndicator)
m_dataListDropdownIndicator->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone, true);
#endif
}
@@ -448,6 +448,7 @@
}
#if ENABLE(DATALIST_ELEMENT)
+
void TextFieldInputType::createDataListDropdownIndicator()
{
ASSERT(!m_dataListDropdownIndicator);
@@ -459,10 +460,19 @@
m_container->appendChild(*m_dataListDropdownIndicator);
m_dataListDropdownIndicator->setPseudo(AtomString("-webkit-list-button", AtomString::ConstructFromLiteral));
m_dataListDropdownIndicator->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone, true);
+}
+bool TextFieldInputType::shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited()
+{
+#if PLATFORM(IOS_FAMILY)
+return true;
+#else
+return false;
+#endif
}
-#endif
+#endif // ENABLE(DATALIST_ELEMENT)
+
static String limitLength(const String& string, unsigned maxNumGraphemeClusters)
{
StringView stringView { string };
@@ -667,10 +677,9 @@
if (RefPtr frame = element()->document().frame())
frame->editor().textDidChangeInTextField(element());
#if ENABLE(DATALIST_ELEMENT)
-#if PLATFORM(IOS_FAMILY)
-if (element()->list() && m_dataListDropdownIndicator)
+if (shouldOnlyShowDataListDropdownButtonWhenFocusedOrEdited() && element()->list() && m_dataListDropdownIndicator)
[webkit-changes] [259374] trunk
Title: [259374] trunk
Revision 259374
Author pvol...@apple.com
Date 2020-04-01 17:19:56 -0700 (Wed, 01 Apr 2020)
Log Message
[Cocoa] UTI from MIME type cache can be removed after r258915
https://bugs.webkit.org/show_bug.cgi?id=209787
Unreviewed rollout of r257828.
Source/WebCore:
In r257828, a UTI from MIME type cache was added to avoid connecting to a launch services daemon in the
WebContent process, but after this cache is not strictly needed
anymore, since r258915 solves the problem of avoiding to connect to the daemon in a general way.
* platform/network/mac/UTIUtilities.h:
* platform/network/mac/UTIUtilities.mm:
(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::mapUTIFromMIMEType): Deleted.
(WebCore::additionalMIMETypes): Deleted.
(WebCore::createUTIFromMIMETypeMap): Deleted.
(WebCore::setUTIFromMIMETypeMap): Deleted.
* testing/Internals.cpp:
(WebCore::Internals::getUTIFromMIMEType): Deleted.
* testing/Internals.h:
* testing/Internals.idl:
* testing/Internals.mm:
(WebCore::Internals::getUTIFromMIMEType): Deleted.
Source/WebKit:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Removed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/UTIUtilities.h
trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebCore/testing/Internals.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Removed Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (259373 => 259374)
--- trunk/Source/WebCore/ChangeLog 2020-04-02 00:16:26 UTC (rev 259373)
+++ trunk/Source/WebCore/ChangeLog 2020-04-02 00:19:56 UTC (rev 259374)
@@ -1,3 +1,28 @@
+2020-04-01 Per Arne Vollan
+
+[Cocoa] UTI from MIME type cache can be removed after r258915
+https://bugs.webkit.org/show_bug.cgi?id=209787
+
+Unreviewed rollout of r257828.
+
+In r257828, a UTI from MIME type cache was added to avoid connecting to a launch services daemon in the
+WebContent process, but after this cache is not strictly needed
+anymore, since r258915 solves the problem of avoiding to connect to the daemon in a general way.
+
+* platform/network/mac/UTIUtilities.h:
+* platform/network/mac/UTIUtilities.mm:
+(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
+(WebCore::mapUTIFromMIMEType): Deleted.
+(WebCore::additionalMIMETypes): Deleted.
+(WebCore::createUTIFromMIMETypeMap): Deleted.
+(WebCore::setUTIFromMIMETypeMap): Deleted.
+* testing/Internals.cpp:
+(WebCore::Internals::getUTIFromMIMEType): Deleted.
+* testing/Internals.h:
+* testing/Internals.idl:
+* testing/Internals.mm:
+(WebCore::Internals::getUTIFromMIMEType): Deleted.
+
2020-04-01 Chris Dumez
http/tests/navigation/page-cache-fontfaceset.html is flaky crashing
Modified: trunk/Source/WebCore/platform/network/mac/UTIUtilities.h (259373 => 259374)
--- trunk/Source/WebCore/platform/network/mac/UTIUtilities.h 2020-04-02 00:16:26 UTC (rev 259373)
+++ trunk/Source/WebCore/platform/network/mac/UTIUtilities.h 2020-04-02 00:19:56 UTC (rev 259374)
@@ -25,7 +25,7 @@
#pragma once
-#include
+#import
namespace WebCore {
@@ -34,7 +34,4 @@
WEBCORE_EXPORT String UTIFromMIMEType(const String&);
bool isDeclaredUTI(const String&);
WEBCORE_EXPORT String UTIFromTag(const String& tagClass, const String& tag, const String& conformingToUTI);
-
-WEBCORE_EXPORT void setUTIFromMIMETypeMap(HashMap&&);
-WEBCORE_EXPORT const HashMap& createUTIFromMIMETypeMap();
}
Modified: trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm (259373 => 259374)
--- trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm 2020-04-02 00:16:26 UTC (rev 259373)
+++ trunk/Source/WebCore/platform/network/mac/UTIUtilities.mm 2020-04-02 00:19:56 UTC (rev 259374)
@@ -26,7 +26,6 @@
#import "config.h"
#import "UTIUtilities.h"
-#import "MIMETypeRegistry.h"
#import
#import
#import
@@ -42,8 +41,6 @@
#define ADDITIONAL_UTI_MAPPINGS
#endif
-#define
[webkit-changes] [259373] trunk/Source/WebCore/PAL
Title: [259373] trunk/Source/WebCore/PAL Revision 259373 Author timothy_hor...@apple.com Date 2020-04-01 17:16:26 -0700 (Wed, 01 Apr 2020) Log Message Fix the build. * pal/spi/ios/ManagedConfigurationSPI.h: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (259372 => 259373) --- trunk/Source/WebCore/PAL/ChangeLog 2020-04-02 00:13:11 UTC (rev 259372) +++ trunk/Source/WebCore/PAL/ChangeLog 2020-04-02 00:16:26 UTC (rev 259373) @@ -1,3 +1,9 @@ +2020-04-01 Timothy Horton + +Fix the build. + +* pal/spi/ios/ManagedConfigurationSPI.h: + 2020-04-01 Tim Horton Use ManagedConfiguration umbrella instead of including specific headers Modified: trunk/Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h (259372 => 259373) --- trunk/Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h 2020-04-02 00:13:11 UTC (rev 259372) +++ trunk/Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h 2020-04-02 00:16:26 UTC (rev 259373) @@ -31,7 +31,12 @@ // block to make them suitable for C++ use. WTF_EXTERN_C_BEGIN +#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 14 #import +#else +#import +#import +#endif WTF_EXTERN_C_END ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259372] trunk/Tools
Title: [259372] trunk/Tools
Revision 259372
Author jbed...@apple.com
Date 2020-04-01 17:13:11 -0700 (Wed, 01 Apr 2020)
Log Message
run-_javascript_core-tests: runJSCStressTests shouldn't exit the program
https://bugs.webkit.org/show_bug.cgi?id=209887
Reviewed by Darin Adler.
* Scripts/run-_javascript_core-tests:
(runJSCStressTests): Exit the function, not the program.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
Diff
Modified: trunk/Tools/ChangeLog (259371 => 259372)
--- trunk/Tools/ChangeLog 2020-04-01 23:47:37 UTC (rev 259371)
+++ trunk/Tools/ChangeLog 2020-04-02 00:13:11 UTC (rev 259372)
@@ -1,3 +1,13 @@
+2020-04-01 Jonathan Bedard
+
+run-_javascript_core-tests: runJSCStressTests shouldn't exit the program
+https://bugs.webkit.org/show_bug.cgi?id=209887
+
+Reviewed by Darin Adler.
+
+* Scripts/run-_javascript_core-tests:
+(runJSCStressTests): Exit the function, not the program.
+
2020-04-01 Chris Dumez
Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (259371 => 259372)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2020-04-01 23:47:37 UTC (rev 259371)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2020-04-02 00:13:11 UTC (rev 259372)
@@ -810,7 +810,7 @@
}
if (!$hasTestsToRun) {
-exit(0);
+return;
}
print "Running: " . join(" ", @jscStressDriverCmd) . "\n";
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259371] trunk/Websites/webkit.org
Title: [259371] trunk/Websites/webkit.org Revision 259371 Author j...@apple.com Date 2020-04-01 16:47:37 -0700 (Wed, 01 Apr 2020) Log Message Removed the update nag from the old WebKit Nightly start page https://bugs.webkit.org/show_bug.cgi?id=179214 Reviewed by Darin Adler. * wp-content/themes/webkit/nightly-start.php: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php Diff Modified: trunk/Websites/webkit.org/ChangeLog (259370 => 259371) --- trunk/Websites/webkit.org/ChangeLog 2020-04-01 23:15:16 UTC (rev 259370) +++ trunk/Websites/webkit.org/ChangeLog 2020-04-01 23:47:37 UTC (rev 259371) @@ -1,3 +1,12 @@ +2020-04-01 Jon Davis + +Removed the update nag from the old WebKit Nightly start page +https://bugs.webkit.org/show_bug.cgi?id=179214 + +Reviewed by Darin Adler. + +* wp-content/themes/webkit/nightly-start.php: + 2020-03-30 Simon Fraser http://webkit.org/css-status/ hangs Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php (259370 => 259371) --- trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php 2020-04-01 23:15:16 UTC (rev 259370) +++ trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php 2020-04-01 23:47:37 UTC (rev 259371) @@ -289,16 +289,6 @@ - - -"> - - ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259370] trunk
Title: [259370] trunk
Revision 259370
Author ross.kirsl...@sony.com
Date 2020-04-01 16:15:16 -0700 (Wed, 01 Apr 2020)
Log Message
Intl.NumberFormat.prototype.format must preserve sign of -0
https://bugs.webkit.org/show_bug.cgi?id=209880
Reviewed by Keith Miller.
JSTests:
* test262/config.yaml:
This test was skipped as ICU version-dependent, but it shouldn't be.
* test262/expectations.yaml:
Mark four test cases as passing.
Source/_javascript_Core:
The spec changed here two years ago:
https://github.com/tc39/ecma402/pull/232
* runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::formatNumber):
Do NOT throw away the sign of -0.
LayoutTests:
* js/intl-numberformat-expected.txt:
* js/script-tests/intl-numberformat.js:
Fix test accordingly.
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/test262/config.yaml
trunk/JSTests/test262/expectations.yaml
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/intl-numberformat-expected.txt
trunk/LayoutTests/js/script-tests/intl-numberformat.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp
Diff
Modified: trunk/JSTests/ChangeLog (259369 => 259370)
--- trunk/JSTests/ChangeLog 2020-04-01 23:03:30 UTC (rev 259369)
+++ trunk/JSTests/ChangeLog 2020-04-01 23:15:16 UTC (rev 259370)
@@ -1,3 +1,16 @@
+2020-04-01 Ross Kirsling
+
+Intl.NumberFormat.prototype.format must preserve sign of -0
+https://bugs.webkit.org/show_bug.cgi?id=209880
+
+Reviewed by Keith Miller.
+
+* test262/config.yaml:
+This test was skipped as ICU version-dependent, but it shouldn't be.
+
+* test262/expectations.yaml:
+Mark four test cases as passing.
+
2020-04-01 Justin Michaud
Delete IC incorrectly caches for proxies
Modified: trunk/JSTests/test262/config.yaml (259369 => 259370)
--- trunk/JSTests/test262/config.yaml 2020-04-01 23:03:30 UTC (rev 259369)
+++ trunk/JSTests/test262/config.yaml 2020-04-01 23:15:16 UTC (rev 259370)
@@ -115,8 +115,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=192920
- test/intl402/PluralRules/prototype/resolvedOptions/order.js
- test/intl402/PluralRules/prototype/resolvedOptions/pluralCategories.js
-- test/intl402/NumberFormat/prototype/format/format-fraction-digits.js
-- test/intl402/NumberFormat/prototype/format/format-significant-digits.js
# https://bugs.webkit.org/show_bug.cgi?id=190800
- test/built-ins/TypedArray/prototype/set/src-typedarray-big-throws.js
Modified: trunk/JSTests/test262/expectations.yaml (259369 => 259370)
--- trunk/JSTests/test262/expectations.yaml 2020-04-01 23:03:30 UTC (rev 259369)
+++ trunk/JSTests/test262/expectations.yaml 2020-04-01 23:15:16 UTC (rev 259370)
@@ -1998,9 +1998,6 @@
test/intl402/NumberFormat/proto-from-ctor-realm.js:
default: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object Object]», «[object Object]») to be true'
strict mode: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object Object]», «[object Object]») to be true'
-test/intl402/NumberFormat/prototype/format/format-negative-numbers.js:
- default: 'Test262Error: Intl.NumberFormat is formatting 0 and -0 the same way. Expected SameValue(«0», «0») to be false'
- strict mode: 'Test262Error: Intl.NumberFormat is formatting 0 and -0 the same way. Expected SameValue(«0», «0») to be false'
test/intl402/PluralRules/proto-from-ctor-realm.js:
default: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object Object]», «[object Object]») to be true'
strict mode: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object Object]», «[object Object]») to be true'
Modified: trunk/LayoutTests/ChangeLog (259369 => 259370)
--- trunk/LayoutTests/ChangeLog 2020-04-01 23:03:30 UTC (rev 259369)
+++ trunk/LayoutTests/ChangeLog 2020-04-01 23:15:16 UTC (rev 259370)
@@ -1,3 +1,14 @@
+2020-04-01 Ross Kirsling
+
+Intl.NumberFormat.prototype.format must preserve sign of -0
+https://bugs.webkit.org/show_bug.cgi?id=209880
+
+Reviewed by Keith Miller.
+
+* js/intl-numberformat-expected.txt:
+* js/script-tests/intl-numberformat.js:
+Fix test accordingly.
+
2020-04-01 Per Arne Vollan
[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
Modified: trunk/LayoutTests/js/intl-numberformat-expected.txt (259369 => 259370)
--- trunk/LayoutTests/js/intl-numberformat-expected.txt 2020-04-01 23:03:30 UTC (rev 259369)
+++ trunk/LayoutTests/js/intl-numberformat-expected.txt 2020-04-01 23:15:16 UTC (rev 259370)
@@ -201,7 +201,7 @@
PASS Intl.NumberFormat('en').format(Infinity) is '∞'
PASS Intl.NumberFormat('en').format(-Infinity) is '-∞'
PASS Intl.NumberFormat('en').format(0) is '0'
-PASS Intl.NumberFormat('en').format(-0) is '0'
+PASS Intl.NumberFormat('en').format(-0) is '-0'
PASS Intl.NumberFormat('en').format(Number.MIN_VALUE) is '0'
PASS
[webkit-changes] [259369] trunk/Source/WebCore/PAL
Title: [259369] trunk/Source/WebCore/PAL Revision 259369 Author timothy_hor...@apple.com Date 2020-04-01 16:03:30 -0700 (Wed, 01 Apr 2020) Log Message Use ManagedConfiguration umbrella instead of including specific headers https://bugs.webkit.org/show_bug.cgi?id=209884 Reviewed by Wenson Hsieh. * pal/spi/ios/ManagedConfigurationSPI.h: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (259368 => 259369) --- trunk/Source/WebCore/PAL/ChangeLog 2020-04-01 22:50:16 UTC (rev 259368) +++ trunk/Source/WebCore/PAL/ChangeLog 2020-04-01 23:03:30 UTC (rev 259369) @@ -1,3 +1,13 @@ +2020-04-01 Tim Horton + +Use ManagedConfiguration umbrella instead of including specific headers +https://bugs.webkit.org/show_bug.cgi?id=209884 + + +Reviewed by Wenson Hsieh. + +* pal/spi/ios/ManagedConfigurationSPI.h: + 2020-03-31 Eric Carlson [iPad] Use AVAudioSession to detect AirPlay route changes Modified: trunk/Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h (259368 => 259369) --- trunk/Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h 2020-04-01 22:50:16 UTC (rev 259368) +++ trunk/Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h 2020-04-01 23:03:30 UTC (rev 259369) @@ -31,8 +31,7 @@ // block to make them suitable for C++ use. WTF_EXTERN_C_BEGIN -#import -#import +#import WTF_EXTERN_C_END ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259368] trunk/Source/WebInspectorUI
Title: [259368] trunk/Source/WebInspectorUI
Revision 259368
Author nvasil...@apple.com
Date 2020-04-01 15:50:16 -0700 (Wed, 01 Apr 2020)
Log Message
Web Inspector: Use ECMAScript Numeric Separators for numbers with 5 or more digits
https://bugs.webkit.org/show_bug.cgi?id=209879
Reviewed by Joseph Pecoraro.
Instead of `100` write `1_000_000` so it's easier to read.
* UserInterface/Base/Utilities.js:
* UserInterface/Controllers/_javascript_LogViewController.js:
* UserInterface/Controllers/TimelineManager.js:
* UserInterface/Models/Gradient.js:
(WI.Gradient.prototype.stringFromStops):
* UserInterface/Models/HeapAllocationsInstrument.js:
(WI.HeapAllocationsInstrument.prototype.startInstrumentation):
* UserInterface/Protocol/Connection.js:
(InspectorBackend.Connection.prototype._dispatchResponse):
* UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView.prototype.initialLayout):
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._updateLoadTimeStatistic):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
trunk/Source/WebInspectorUI/UserInterface/Models/Gradient.js
trunk/Source/WebInspectorUI/UserInterface/Models/HeapAllocationsInstrument.js
trunk/Source/WebInspectorUI/UserInterface/Protocol/Connection.js
trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (259367 => 259368)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-04-01 22:32:39 UTC (rev 259367)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-04-01 22:50:16 UTC (rev 259368)
@@ -1,3 +1,26 @@
+2020-04-01 Nikita Vasilyev
+
+Web Inspector: Use ECMAScript Numeric Separators for numbers with 5 or more digits
+https://bugs.webkit.org/show_bug.cgi?id=209879
+
+Reviewed by Joseph Pecoraro.
+
+Instead of `100` write `1_000_000` so it's easier to read.
+
+* UserInterface/Base/Utilities.js:
+* UserInterface/Controllers/_javascript_LogViewController.js:
+* UserInterface/Controllers/TimelineManager.js:
+* UserInterface/Models/Gradient.js:
+(WI.Gradient.prototype.stringFromStops):
+* UserInterface/Models/HeapAllocationsInstrument.js:
+(WI.HeapAllocationsInstrument.prototype.startInstrumentation):
+* UserInterface/Protocol/Connection.js:
+(InspectorBackend.Connection.prototype._dispatchResponse):
+* UserInterface/Views/Layers3DContentView.js:
+(WI.Layers3DContentView.prototype.initialLayout):
+* UserInterface/Views/NetworkTableContentView.js:
+(WI.NetworkTableContentView.prototype._updateLoadTimeStatistic):
+
2020-03-31 Jon Davis
Added new WebSocket icon
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js (259367 => 259368)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2020-04-01 22:32:39 UTC (rev 259367)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Utilities.js 2020-04-01 22:50:16 UTC (rev 259368)
@@ -1348,13 +1348,13 @@
if (num < 1000)
return num.toLocaleString();
-if (num < 100)
+if (num < 1_000_000)
return WI.UIString("%.1fK").format(Math.round(num / 100) / 10);
-if (num < 10)
-return WI.UIString("%.1fM").format(Math.round(num / 10) / 10);
+if (num < 1_000_000_000)
+return WI.UIString("%.1fM").format(Math.round(num / 100_000) / 10);
-return WI.UIString("%.1fB").format(Math.round(num / 1) / 10);
+return WI.UIString("%.1fB").format(Math.round(num / 100_000_000) / 10);
}
});
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js (259367 => 259368)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js 2020-04-01 22:32:39 UTC (rev 259367)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/_javascript_LogViewController.js 2020-04-01 22:50:16 UTC (rev 259368)
@@ -362,5 +362,5 @@
}
};
-WI._javascript_LogViewController.CachedPropertiesDuration = 3;
+WI._javascript_LogViewController.CachedPropertiesDuration = 30_000;
WI._javascript_LogViewController.IgnoredRepeatCount = Symbol("ignored-repeat-count");
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (259367 => 259368)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2020-04-01 22:32:39 UTC (rev 259367)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2020-04-01 22:50:16 UTC (rev 259368)
@@ -1440,6 +1440,6 @@
RecordingImported:
[webkit-changes] [259367] trunk/Source/WebCore
Title: [259367] trunk/Source/WebCore
Revision 259367
Author cdu...@apple.com
Date 2020-04-01 15:32:39 -0700 (Wed, 01 Apr 2020)
Log Message
http/tests/navigation/page-cache-fontfaceset.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=209881
Reviewed by Darin Adler.
Make sure CSSFontSelector::m_beginLoadingTimer uses a SuspendableTimer instead of a regular
timer so that it cannot fire while in the back/forward cache and start a load.
No new tests, covered by existing test.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::clearDocument):
* css/CSSFontSelector.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontSelector.cpp
trunk/Source/WebCore/css/CSSFontSelector.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259366 => 259367)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 22:29:21 UTC (rev 259366)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 22:32:39 UTC (rev 259367)
@@ -1,5 +1,23 @@
2020-04-01 Chris Dumez
+http/tests/navigation/page-cache-fontfaceset.html is flaky crashing
+https://bugs.webkit.org/show_bug.cgi?id=209881
+
+
+Reviewed by Darin Adler.
+
+Make sure CSSFontSelector::m_beginLoadingTimer uses a SuspendableTimer instead of a regular
+timer so that it cannot fire while in the back/forward cache and start a load.
+
+No new tests, covered by existing test.
+
+* css/CSSFontSelector.cpp:
+(WebCore::CSSFontSelector::CSSFontSelector):
+(WebCore::CSSFontSelector::clearDocument):
+* css/CSSFontSelector.h:
+
+2020-04-01 Chris Dumez
+
ASSERTION FAILED: m_wrapper on webgl/max-active-contexts-webglcontextlost-prevent-default.html
https://bugs.webkit.org/show_bug.cgi?id=209863
Modified: trunk/Source/WebCore/css/CSSFontSelector.cpp (259366 => 259367)
--- trunk/Source/WebCore/css/CSSFontSelector.cpp 2020-04-01 22:29:21 UTC (rev 259366)
+++ trunk/Source/WebCore/css/CSSFontSelector.cpp 2020-04-01 22:32:39 UTC (rev 259367)
@@ -64,7 +64,7 @@
CSSFontSelector::CSSFontSelector(Document& document)
: m_document(makeWeakPtr(document))
, m_cssFontFaceSet(CSSFontFaceSet::create(this))
-, m_beginLoadingTimer(*this, ::beginLoadTimerFired)
+, m_beginLoadingTimer(, *this, ::beginLoadTimerFired)
, m_uniqueId(++fontSelectorId)
, m_version(0)
{
@@ -72,6 +72,8 @@
FontCache::singleton().addClient(*this);
m_cssFontFaceSet->addClient(*this);
LOG(Fonts, "CSSFontSelector %p ctor", this);
+
+m_beginLoadingTimer.suspendIfNeeded();
}
CSSFontSelector::~CSSFontSelector()
@@ -336,7 +338,7 @@
return;
}
-m_beginLoadingTimer.stop();
+m_beginLoadingTimer.cancel();
CachedResourceLoader& cachedResourceLoader = m_document->cachedResourceLoader();
for (auto& fontHandle : m_fontsToBeginLoading) {
Modified: trunk/Source/WebCore/css/CSSFontSelector.h (259366 => 259367)
--- trunk/Source/WebCore/css/CSSFontSelector.h 2020-04-01 22:29:21 UTC (rev 259366)
+++ trunk/Source/WebCore/css/CSSFontSelector.h 2020-04-01 22:32:39 UTC (rev 259367)
@@ -30,7 +30,7 @@
#include "CachedResourceHandle.h"
#include "Font.h"
#include "FontSelector.h"
-#include "Timer.h"
+#include "SuspendableTimer.h"
#include
#include
#include
@@ -112,7 +112,7 @@
Vector> m_fontsToBeginLoading;
HashSet> m_cssConnectionsPossiblyToRemove;
HashSet> m_cssConnectionsEncounteredDuringBuild;
-Timer m_beginLoadingTimer;
+SuspendableTimer m_beginLoadingTimer;
unsigned m_uniqueId;
unsigned m_version;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259366] trunk
Title: [259366] trunk
Revision 259366
Author pvol...@apple.com
Date 2020-04-01 15:29:21 -0700 (Wed, 01 Apr 2020)
Log Message
[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
https://bugs.webkit.org/show_bug.cgi?id=209814
Reviewed by Darin Adler.
Source/WebKit:
This was done for iOS in , and in order to be able to do this
on macOS, checking in with Launch Services and updating the process name needs to be done after the
Launch Services database mapping has been done in WebProcess::platformInitializeWebProcess. Also, the
previous call to RegisterApplication has been replaced with a call to launchServicesCheckIn, since
RegisterApplication is an AppKit function, and should be avoided since the WebContent process is not
a NSApplication anymore.
Test: fast/sandbox/mac/sandbox-mach-lookup.html
* Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::launchServicesCheckIn):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::updateProcessName):
(WebKit::WebProcess::platformInitializeProcess):
* WebProcess/com.apple.WebProcess.sb.in:
LayoutTests:
* fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
* fast/sandbox/mac/sandbox-mach-lookup.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt
trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
Diff
Modified: trunk/LayoutTests/ChangeLog (259365 => 259366)
--- trunk/LayoutTests/ChangeLog 2020-04-01 21:52:35 UTC (rev 259365)
+++ trunk/LayoutTests/ChangeLog 2020-04-01 22:29:21 UTC (rev 259366)
@@ -1,3 +1,13 @@
+2020-04-01 Per Arne Vollan
+
+[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
+https://bugs.webkit.org/show_bug.cgi?id=209814
+
+Reviewed by Darin Adler.
+
+* fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
+* fast/sandbox/mac/sandbox-mach-lookup.html:
+
2020-04-01 Jason Lawrence
[ Mac wk1 Debug ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is flaky timing out.
Modified: trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt (259365 => 259366)
--- trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt 2020-04-01 21:52:35 UTC (rev 259365)
+++ trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt 2020-04-01 22:29:21 UTC (rev 259366)
@@ -8,4 +8,5 @@
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager.content-filter") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.system.logger") is false
+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.lsd.mapdb") is false
Modified: trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html (259365 => 259366)
--- trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html 2020-04-01 21:52:35 UTC (rev 259365)
+++ trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html 2020-04-01 22:29:21 UTC (rev 259366)
@@ -11,6 +11,7 @@
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager.content-filter\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.system.logger\")");
+shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.lsd.mapdb\")");
}
Modified: trunk/Source/WebKit/ChangeLog (259365 => 259366)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 21:52:35 UTC (rev 259365)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 22:29:21 UTC (rev 259366)
@@ -1,3 +1,30 @@
+2020-04-01 Per Arne Vollan
+
+[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in sandbox
+https://bugs.webkit.org/show_bug.cgi?id=209814
+
+Reviewed by Darin Adler.
+
+This was done for iOS in , and in order to be able to do this
+on macOS, checking in with Launch Services and updating the process name needs to be done after the
+Launch Services database mapping has been done in WebProcess::platformInitializeWebProcess. Also, the
+previous call to RegisterApplication has
[webkit-changes] [259365] trunk/LayoutTests
Title: [259365] trunk/LayoutTests Revision 259365 Author lawrenc...@apple.com Date 2020-04-01 14:52:35 -0700 (Wed, 01 Apr 2020) Log Message [ Mac wk1 Debug ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is flaky timing out. https://bugs.webkit.org/show_bug.cgi?id=209882 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259364 => 259365) --- trunk/LayoutTests/ChangeLog 2020-04-01 21:51:18 UTC (rev 259364) +++ trunk/LayoutTests/ChangeLog 2020-04-01 21:52:35 UTC (rev 259365) @@ -1,5 +1,14 @@ 2020-04-01 Jason Lawrence +[ Mac wk1 Debug ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is flaky timing out. +https://bugs.webkit.org/show_bug.cgi?id=209882 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + +2020-04-01 Jason Lawrence + [ Mac wk2 Debug ] webrtc/datachannel/multiple-connections.html is flaky timing out. https://bugs.webkit.org/show_bug.cgi?id=209878 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259364 => 259365) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-04-01 21:51:18 UTC (rev 259364) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-04-01 21:52:35 UTC (rev 259365) @@ -947,4 +947,6 @@ webkit.org/b/209837 [ Mojave Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html [ Pass Timeout ] -webkit.org/b/209866 [ Mojave Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/209866 [ Mojave Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html [ Pass Failure ] + +webkit.org/b/209882 [ Debug ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Pass Timeout ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259364] trunk/Source/WebCore
Title: [259364] trunk/Source/WebCore
Revision 259364
Author cdu...@apple.com
Date 2020-04-01 14:51:18 -0700 (Wed, 01 Apr 2020)
Log Message
ASSERTION FAILED: m_wrapper on webgl/max-active-contexts-webglcontextlost-prevent-default.html
https://bugs.webkit.org/show_bug.cgi?id=209863
Reviewed by Darin Adler.
The HTMLCanvasElement JS wrapper needs to stay alive as long as JS events may need to be fired.
When the canvas has a WebGL context, the WebGL context may cause contextlost / contextrestored
/ contextchanged events at any point, unless the context is unrecoverably lost. To fix the
issue, we now override virtualHasPendingActivity() in HTMLCanvasElement and return true if
it has a WebGL context that is not unrecoverably lost and if relevant WebGL event listeners
are registed.
No new tests, covered by existing test.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
(WebCore::HTMLCanvasElement::virtualHasPendingActivity const):
(WebCore::HTMLCanvasElement::stop):
(WebCore::HTMLCanvasElement::eventListenersDidChange):
* html/HTMLCanvasElement.h:
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::isContextUnrecoverablyLost const):
* html/canvas/WebGLRenderingContextBase.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/html/HTMLCanvasElement.h
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259363 => 259364)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 21:15:18 UTC (rev 259363)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 21:51:18 UTC (rev 259364)
@@ -1,3 +1,30 @@
+2020-04-01 Chris Dumez
+
+ASSERTION FAILED: m_wrapper on webgl/max-active-contexts-webglcontextlost-prevent-default.html
+https://bugs.webkit.org/show_bug.cgi?id=209863
+
+
+Reviewed by Darin Adler.
+
+The HTMLCanvasElement JS wrapper needs to stay alive as long as JS events may need to be fired.
+When the canvas has a WebGL context, the WebGL context may cause contextlost / contextrestored
+/ contextchanged events at any point, unless the context is unrecoverably lost. To fix the
+issue, we now override virtualHasPendingActivity() in HTMLCanvasElement and return true if
+it has a WebGL context that is not unrecoverably lost and if relevant WebGL event listeners
+are registed.
+
+No new tests, covered by existing test.
+
+* html/HTMLCanvasElement.cpp:
+(WebCore::HTMLCanvasElement::~HTMLCanvasElement):
+(WebCore::HTMLCanvasElement::virtualHasPendingActivity const):
+(WebCore::HTMLCanvasElement::stop):
+(WebCore::HTMLCanvasElement::eventListenersDidChange):
+* html/HTMLCanvasElement.h:
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::isContextUnrecoverablyLost const):
+* html/canvas/WebGLRenderingContextBase.h:
+
2020-04-01 Jer Noble
CRASH in MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer(), uncaught ObjC exception
Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (259363 => 259364)
--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2020-04-01 21:15:18 UTC (rev 259363)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2020-04-01 21:51:18 UTC (rev 259364)
@@ -955,4 +955,28 @@
return "HTMLCanvasElement";
}
+bool HTMLCanvasElement::virtualHasPendingActivity() const
+{
+if (isContextStopped())
+return false;
+
+#if ENABLE(WEBGL)
+if (is(m_context.get())) {
+// WebGL rendering context may fire contextlost / contextchange / contextrestored events at any point.
+return m_hasRelevantWebGLEventListener && !downcast(*m_context).isContextUnrecoverablyLost();
+}
+#endif
+
+return false;
}
+
+void HTMLCanvasElement::eventListenersDidChange()
+{
+#if ENABLE(WEBGL)
+m_hasRelevantWebGLEventListener = hasEventListeners(eventNames().webglcontextchangedEvent)
+|| hasEventListeners(eventNames().webglcontextlostEvent)
+|| hasEventListeners(eventNames().webglcontextrestoredEvent);
+#endif
+}
+
+}
Modified: trunk/Source/WebCore/html/HTMLCanvasElement.h (259363 => 259364)
--- trunk/Source/WebCore/html/HTMLCanvasElement.h 2020-04-01 21:15:18 UTC (rev 259363)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.h 2020-04-01 21:51:18 UTC (rev 259364)
@@ -133,8 +133,14 @@
HTMLCanvasElement(const QualifiedName&, Document&);
bool isHTMLCanvasElement() const final { return true; }
+
+// ActiveDOMObject.
const char* activeDOMObjectName() const final;
+bool virtualHasPendingActivity() const final;
+// EventTarget.
+void eventListenersDidChange() final;
+
void parseAttribute(const QualifiedName&, const AtomString&) final;
RenderPtr createElementRenderer(RenderStyle&&, const
[webkit-changes] [259363] trunk/Source/WebCore
Title: [259363] trunk/Source/WebCore
Revision 259363
Author jer.no...@apple.com
Date 2020-04-01 14:15:18 -0700 (Wed, 01 Apr 2020)
Log Message
CRASH in MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer(), uncaught ObjC exception
https://bugs.webkit.org/show_bug.cgi?id=209827
Reviewed by Eric Carlson.
-[AVSampleBufferAudioRenderer init] can, in exceptional conditions, return nil. Passing a
nil object, or another object that AVSampleBufferRenderSynchronizer considers "invalid", into
-[AVSampleBufferRenderSynchronizer addRenderer:] will throw an exception. Protect against this
scenario in two ways:
- Check the return value of -[AVSampleBufferAudioRenderer init], and if nil, log an error,
log to console, and set the network state to "DecodeError".
- Wrap calls to -addRenderer: in @try/@catch blocks, which if caught, log an error, assert,
and set the network state to "DecodeError".
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::failedToCreateRenderer):
* Modules/mediasource/MediaSource.h:
* platform/graphics/MediaSourcePrivateClient.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::failedToCreateAudioRenderer):
(WebCore::MediaSourcePrivateAVFObjC::failedToCreateVideoRenderer):
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
trunk/Source/WebCore/Modules/mediasource/MediaSource.h
trunk/Source/WebCore/platform/graphics/MediaSourcePrivateClient.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (259362 => 259363)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 21:01:40 UTC (rev 259362)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 21:15:18 UTC (rev 259363)
@@ -1,3 +1,34 @@
+2020-04-01 Jer Noble
+
+CRASH in MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer(), uncaught ObjC exception
+https://bugs.webkit.org/show_bug.cgi?id=209827
+
+
+Reviewed by Eric Carlson.
+
+-[AVSampleBufferAudioRenderer init] can, in exceptional conditions, return nil. Passing a
+nil object, or another object that AVSampleBufferRenderSynchronizer considers "invalid", into
+-[AVSampleBufferRenderSynchronizer addRenderer:] will throw an exception. Protect against this
+scenario in two ways:
+
+- Check the return value of -[AVSampleBufferAudioRenderer init], and if nil, log an error,
+ log to console, and set the network state to "DecodeError".
+- Wrap calls to -addRenderer: in @try/@catch blocks, which if caught, log an error, assert,
+ and set the network state to "DecodeError".
+
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::failedToCreateRenderer):
+* Modules/mediasource/MediaSource.h:
+* platform/graphics/MediaSourcePrivateClient.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
+* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
+* platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
+(WebCore::MediaSourcePrivateAVFObjC::failedToCreateAudioRenderer):
+(WebCore::MediaSourcePrivateAVFObjC::failedToCreateVideoRenderer):
+* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
+
2020-04-01 Chris Dumez
ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (259362 => 259363)
--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2020-04-01 21:01:40 UTC (rev 259362)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp 2020-04-01 21:15:18 UTC (rev 259363)
@@ -1093,6 +1093,12 @@
}
#endif
+void MediaSource::failedToCreateRenderer(RendererType type)
+{
+if (auto context = scriptExecutionContext())
+context->addConsoleMessage(MessageSource::JS, MessageLevel::Error, makeString("MediaSource ", type == RendererType::Video ? "video" : "audio", " renderer creation failed."));
}
+}
+
#endif
Modified:
[webkit-changes] [259362] trunk
Title: [259362] trunk
Revision 259362
Author cdu...@apple.com
Date 2020-04-01 14:01:40 -0700 (Wed, 01 Apr 2020)
Log Message
Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation
https://bugs.webkit.org/show_bug.cgi?id=209873
Reviewed by Alex Christensen.
Source/WebKit:
ProvisionalPageProxy::cancel() was calling didFailProvisionalLoadForFrame() was not passing a valid
FrameInfoData struct as parameter. As a result, FrameInfoData::isMainFrame ended up being false
instead of true. This was an issue because NavigationState::NavigationClient::didFailProvisionalNavigationWithError()
was relying on this flag to decide whether to call webViewDidFailProvisionalNavigationWithError or
webViewNavigationDidFailProvisionalLoadInSubframeWithError, since r257963.
Change is covered by new API tests.
* UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::cancel):
Tools:
Add API test coverage.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (259361 => 259362)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 20:59:18 UTC (rev 259361)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 21:01:40 UTC (rev 259362)
@@ -1,3 +1,22 @@
+2020-04-01 Chris Dumez
+
+Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation
+https://bugs.webkit.org/show_bug.cgi?id=209873
+
+
+Reviewed by Alex Christensen.
+
+ProvisionalPageProxy::cancel() was calling didFailProvisionalLoadForFrame() was not passing a valid
+FrameInfoData struct as parameter. As a result, FrameInfoData::isMainFrame ended up being false
+instead of true. This was an issue because NavigationState::NavigationClient::didFailProvisionalNavigationWithError()
+was relying on this flag to decide whether to call webViewDidFailProvisionalNavigationWithError or
+webViewNavigationDidFailProvisionalLoadInSubframeWithError, since r257963.
+
+Change is covered by new API tests.
+
+* UIProcess/ProvisionalPageProxy.cpp:
+(WebKit::ProvisionalPageProxy::cancel):
+
2020-04-01 Don Olmstead
[GPUP][PlayStation] Enable GPU Process
Modified: trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp (259361 => 259362)
--- trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp 2020-04-01 20:59:18 UTC (rev 259361)
+++ trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp 2020-04-01 21:01:40 UTC (rev 259362)
@@ -133,7 +133,14 @@
ASSERT(m_mainFrame);
auto error = WebKit::cancelledError(m_request);
error.setType(WebCore::ResourceError::Type::Cancellation);
-didFailProvisionalLoadForFrame(m_mainFrame->frameID(), { }, { }, m_navigationID, m_provisionalLoadURL, error, WebCore::WillContinueLoading::No, UserData { }); // Will delete |this|.
+FrameInfoData frameInfo {
+true, // isMainFrame
+m_request,
+SecurityOriginData::fromURL(m_request.url()),
+m_mainFrame->frameID(),
+WTF::nullopt,
+};
+didFailProvisionalLoadForFrame(m_mainFrame->frameID(), WTFMove(frameInfo), ResourceRequest { m_request }, m_navigationID, m_provisionalLoadURL, error, WebCore::WillContinueLoading::No, UserData { }); // Will delete |this|.
}
void ProvisionalPageProxy::initializeWebPage(RefPtr&& websitePolicies)
Modified: trunk/Tools/ChangeLog (259361 => 259362)
--- trunk/Tools/ChangeLog 2020-04-01 20:59:18 UTC (rev 259361)
+++ trunk/Tools/ChangeLog 2020-04-01 21:01:40 UTC (rev 259362)
@@ -1,3 +1,15 @@
+2020-04-01 Chris Dumez
+
+Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation
+https://bugs.webkit.org/show_bug.cgi?id=209873
+
+
+Reviewed by Alex Christensen.
+
+Add API test coverage.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
2020-04-01 Don Olmstead
[PlayStation] Use OBJECT libraries for WebCore and PAL
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (259361 => 259362)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2020-04-01 20:59:18 UTC (rev 259361)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2020-04-01 21:01:40 UTC (rev 259362)
@@ -3124,7 +3124,51 @@
EXPECT_WK_STREQ(@"pson://www.apple.com/main.html", [[webView URL] absoluteString]);
}
+static void runCancelCrossSiteProvisionalLoadTest(ShouldEnablePSON shouldEnablePSON)
+{
+auto processPoolConfiguration = psonProcessPoolConfiguration();
+processPoolConfiguration.get().processSwapsOnNavigation =
[webkit-changes] [259361] trunk/LayoutTests
Title: [259361] trunk/LayoutTests Revision 259361 Author lawrenc...@apple.com Date 2020-04-01 13:59:18 -0700 (Wed, 01 Apr 2020) Log Message [ Mac wk2 Debug ] webrtc/datachannel/multiple-connections.html is flaky timing out. https://bugs.webkit.org/show_bug.cgi?id=209878 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259360 => 259361) --- trunk/LayoutTests/ChangeLog 2020-04-01 20:40:39 UTC (rev 259360) +++ trunk/LayoutTests/ChangeLog 2020-04-01 20:59:18 UTC (rev 259361) @@ -1,3 +1,13 @@ +2020-04-01 Jason Lawrence + +[ Mac wk2 Debug ] webrtc/datachannel/multiple-connections.html is flaky timing out. +https://bugs.webkit.org/show_bug.cgi?id=209878 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: +* platform/mac/TestExpectations: + 2020-04-01 Chris Dumez ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html Modified: trunk/LayoutTests/platform/mac/TestExpectations (259360 => 259361) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-04-01 20:40:39 UTC (rev 259360) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-04-01 20:59:18 UTC (rev 259361) @@ -1973,3 +1973,5 @@ webkit.org/b/208023 [ Catalina ] fast/text/international/system-language/declarative-language.html [ Failure ] webkit.org/b/209740 webgl/2.0.0/conformance2/rendering/framebuffer-completeness-unaffected.html [ Failure ] + +webkit.org/b/209878 [ Debug ] webrtc/datachannel/multiple-connections.html [ Slow ] \ No newline at end of file Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259360 => 259361) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-04-01 20:40:39 UTC (rev 259360) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-04-01 20:59:18 UTC (rev 259361) @@ -329,7 +329,6 @@ webrtc/datachannel [ Pass ] webrtc/datachannel/mdns-ice-candidates.html [ Skip ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ] -[ Debug ] webrtc/datachannel/multiple-connections.html [ Slow ] # These tests test the Shadow DOM based HTML form validation UI but Mac WK1 is using native dialogs instead. fast/forms/validation-message-on-listbox.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259360] trunk
Title: [259360] trunk Revision 259360 Author don.olmst...@sony.com Date 2020-04-01 13:40:39 -0700 (Wed, 01 Apr 2020) Log Message [GPUP][PlayStation] Enable GPU Process https://bugs.webkit.org/show_bug.cgi?id=209865 Reviewed by Eric Carlson. .: Enable GPU Process for development builds as an experimental feature. * Source/cmake/OptionsPlayStation.cmake: Source/WebKit: A generic LayerHostingContext is provided in this patch. It may make sense for this to be platform specific but it may also be possible to have some shared implementation with Cocoa ports. Once there are more implementations that can be decided. Add stubs for building out the GPU Process on the PlayStation port. No implementation is provided at this time but the GPU Process will compile and link with these changes. * GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp: Added. (WebKit::RemoteMediaPlayerProxy::prepareForPlayback): (WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable): (WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged): (WebKit::RemoteMediaPlayerProxy::enterFullscreen): (WebKit::RemoteMediaPlayerProxy::exitFullscreen): * GPUProcess/playstation/GPUProcessMainPlayStation.cpp: Added. (WebKit::initializeAuxiliaryProcess): (WebKit::GPUProcessMain): * GPUProcess/playstation/GPUProcessPlayStation.cpp: Added. (WebKit::GPUProcess::initializeProcess): (WebKit::GPUProcess::initializeProcessName): (WebKit::GPUProcess::initializeSandbox): * Platform/generic/LayerHostingContext.h: Added. * PlatformPlayStation.cmake: * WebProcess/GPU/media/playstation/VideoLayerRemotePlayStation.cpp: Added. (WebKit::createVideoLayerRemote): Modified Paths trunk/ChangeLog trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformPlayStation.cmake trunk/Source/cmake/OptionsPlayStation.cmake Added Paths trunk/Source/WebKit/GPUProcess/media/playstation/ trunk/Source/WebKit/GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp trunk/Source/WebKit/GPUProcess/playstation/ trunk/Source/WebKit/GPUProcess/playstation/GPUProcessMainPlayStation.cpp trunk/Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp trunk/Source/WebKit/Platform/generic/ trunk/Source/WebKit/Platform/generic/LayerHostingContext.h trunk/Source/WebKit/WebProcess/GPU/media/playstation/ trunk/Source/WebKit/WebProcess/GPU/media/playstation/VideoLayerRemotePlayStation.cpp Diff Modified: trunk/ChangeLog (259359 => 259360) --- trunk/ChangeLog 2020-04-01 19:30:13 UTC (rev 259359) +++ trunk/ChangeLog 2020-04-01 20:40:39 UTC (rev 259360) @@ -1,5 +1,16 @@ 2020-04-01 Don Olmstead +[GPUP][PlayStation] Enable GPU Process +https://bugs.webkit.org/show_bug.cgi?id=209865 + +Reviewed by Eric Carlson. + +Enable GPU Process for development builds as an experimental feature. + +* Source/cmake/OptionsPlayStation.cmake: + +2020-04-01 Don Olmstead + [PlayStation] Use OBJECT libraries for WebCore and PAL https://bugs.webkit.org/show_bug.cgi?id=209835 Modified: trunk/Source/WebKit/ChangeLog (259359 => 259360) --- trunk/Source/WebKit/ChangeLog 2020-04-01 19:30:13 UTC (rev 259359) +++ trunk/Source/WebKit/ChangeLog 2020-04-01 20:40:39 UTC (rev 259360) @@ -1,5 +1,39 @@ 2020-04-01 Don Olmstead +[GPUP][PlayStation] Enable GPU Process +https://bugs.webkit.org/show_bug.cgi?id=209865 + +Reviewed by Eric Carlson. + +A generic LayerHostingContext is provided in this patch. It may make sense for +this to be platform specific but it may also be possible to have some shared +implementation with Cocoa ports. Once there are more implementations that +can be decided. + +Add stubs for building out the GPU Process on the PlayStation port. No +implementation is provided at this time but the GPU Process will compile +and link with these changes. + +* GPUProcess/media/playstation/RemoteMediaPlayerProxyPlayStation.cpp: Added. +(WebKit::RemoteMediaPlayerProxy::prepareForPlayback): +(WebKit::RemoteMediaPlayerProxy::mediaPlayerFirstVideoFrameAvailable): +(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingModeChanged): +(WebKit::RemoteMediaPlayerProxy::enterFullscreen): +(WebKit::RemoteMediaPlayerProxy::exitFullscreen): +* GPUProcess/playstation/GPUProcessMainPlayStation.cpp: Added. +(WebKit::initializeAuxiliaryProcess): +(WebKit::GPUProcessMain): +* GPUProcess/playstation/GPUProcessPlayStation.cpp: Added. +(WebKit::GPUProcess::initializeProcess): +(WebKit::GPUProcess::initializeProcessName): +(WebKit::GPUProcess::initializeSandbox): +* Platform/generic/LayerHostingContext.h: Added. +* PlatformPlayStation.cmake: +* WebProcess/GPU/media/playstation/VideoLayerRemotePlayStation.cpp: Added. +(WebKit::createVideoLayerRemote): + +2020-04-01 Don Olmstead +
[webkit-changes] [259359] trunk
Title: [259359] trunk
Revision 259359
Author cdu...@apple.com
Date 2020-04-01 12:30:13 -0700 (Wed, 01 Apr 2020)
Log Message
ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
https://bugs.webkit.org/show_bug.cgi?id=209684
Reviewed by Darin Adler.
Source/WebCore:
Make sure the JS wrapper does not get collected while the HTMLMediaElement is in a state where
is may still fire events (and there are JS event listeners registered). In particular, it used
to be possible for the wrapper to get collected because media playback had started and we would
crash trying to fire the very early 'canplay' JS event.
No new tests, covered by existing test.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
LayoutTests:
Unmark the test as crashing.
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (259358 => 259359)
--- trunk/LayoutTests/ChangeLog 2020-04-01 19:15:17 UTC (rev 259358)
+++ trunk/LayoutTests/ChangeLog 2020-04-01 19:30:13 UTC (rev 259359)
@@ -1,3 +1,15 @@
+2020-04-01 Chris Dumez
+
+ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
+https://bugs.webkit.org/show_bug.cgi?id=209684
+
+
+Reviewed by Darin Adler.
+
+Unmark the test as crashing.
+
+* platform/mac/TestExpectations:
+
2020-04-01 Jason Lawrence
[ iOS wk2 ] crypto/subtle/rsa-indexeddb-non-exportable-private.html is flaky timing out.
Modified: trunk/LayoutTests/platform/mac/TestExpectations (259358 => 259359)
--- trunk/LayoutTests/platform/mac/TestExpectations 2020-04-01 19:15:17 UTC (rev 259358)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2020-04-01 19:30:13 UTC (rev 259359)
@@ -1652,7 +1652,7 @@
webkit.org/b/189680 platform/mac/media/audio-session-category-video-paused.html [ Pass Timeout ]
-webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html [ Pass Failure Crash ]
+webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html [ Pass Failure ]
webkit.org/b/195466 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/error-codes/error.html [ Pass Failure ]
webkit.org/b/193399 media/media-fullscreen-return-to-inline.html [ Pass Timeout Crash ]
Modified: trunk/Source/WebCore/ChangeLog (259358 => 259359)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 19:15:17 UTC (rev 259358)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 19:30:13 UTC (rev 259359)
@@ -1,3 +1,21 @@
+2020-04-01 Chris Dumez
+
+ASSERTION FAILED: m_wrapper on imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay.html
+https://bugs.webkit.org/show_bug.cgi?id=209684
+
+
+Reviewed by Darin Adler.
+
+Make sure the JS wrapper does not get collected while the HTMLMediaElement is in a state where
+is may still fire events (and there are JS event listeners registered). In particular, it used
+to be possible for the wrapper to get collected because media playback had started and we would
+crash trying to fire the very early 'canplay' JS event.
+
+No new tests, covered by existing test.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::virtualHasPendingActivity const):
+
2020-04-01 Don Olmstead
[PlayStation] Use OBJECT libraries for WebCore and PAL
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (259358 => 259359)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2020-04-01 19:15:17 UTC (rev 259358)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2020-04-01 19:30:13 UTC (rev 259359)
@@ -5761,7 +5761,10 @@
bool HTMLMediaElement::virtualHasPendingActivity() const
{
-return (hasAudio() && isPlaying()) || m_asyncEventQueue->hasPendingActivity() || m_playbackTargetIsWirelessQueue.hasPendingTasks() || m_creatingControls;
+return m_creatingControls
+|| (m_asyncEventQueue->hasPendingActivity() || m_playbackTargetIsWirelessQueue.hasPendingTasks())
+|| (hasAudio() && isPlaying())
+|| (m_player && (!ended() || seeking() || m_networkState >= NETWORK_IDLE) && hasEventListeners());
}
void HTMLMediaElement::mediaVolumeDidChange()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259358] trunk
Title: [259358] trunk
Revision 259358
Author don.olmst...@sony.com
Date 2020-04-01 12:15:17 -0700 (Wed, 01 Apr 2020)
Log Message
[PlayStation] Use OBJECT libraries for WebCore and PAL
https://bugs.webkit.org/show_bug.cgi?id=209835
Reviewed by Ross Kirsling.
.:
When compiling WebCore in debug mode ranlib was having issues with the size of
libWebCore.a. This is similar to what happened with Visual Studio and WinCairo.
Additionally hidden visibility defaults are added for the port.
* Source/cmake/OptionsPlayStation.cmake:
Source/WebCore:
After moving to object libraries MediaStrategy's constructor and destructor were
being reported as linker errors despite being set to default. Moving the definitions
to a source file stopped these issues.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/MediaStrategy.cpp: Copied from Source/WebCore/platform/MediaStrategy.h.
* platform/MediaStrategy.h:
Source/WebKit:
Use the object libraries when building WebKit.
* PlatformPlayStation.cmake:
Tools:
Use the object libraries when compiling TestWebCore.
* TestWebKitAPI/PlatformPlayStation.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/MediaStrategy.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformPlayStation.cmake
trunk/Source/cmake/OptionsPlayStation.cmake
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformPlayStation.cmake
Added Paths
trunk/Source/WebCore/platform/MediaStrategy.cpp
Diff
Modified: trunk/ChangeLog (259357 => 259358)
--- trunk/ChangeLog 2020-04-01 19:10:20 UTC (rev 259357)
+++ trunk/ChangeLog 2020-04-01 19:15:17 UTC (rev 259358)
@@ -1,3 +1,17 @@
+2020-04-01 Don Olmstead
+
+[PlayStation] Use OBJECT libraries for WebCore and PAL
+https://bugs.webkit.org/show_bug.cgi?id=209835
+
+Reviewed by Ross Kirsling.
+
+When compiling WebCore in debug mode ranlib was having issues with the size of
+libWebCore.a. This is similar to what happened with Visual Studio and WinCairo.
+
+Additionally hidden visibility defaults are added for the port.
+
+* Source/cmake/OptionsPlayStation.cmake:
+
2020-03-30 Zan Dobersek
[WPE] Can't create WebGL context after r259139
Modified: trunk/Source/WebCore/ChangeLog (259357 => 259358)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 19:10:20 UTC (rev 259357)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 19:15:17 UTC (rev 259358)
@@ -1,3 +1,19 @@
+2020-04-01 Don Olmstead
+
+[PlayStation] Use OBJECT libraries for WebCore and PAL
+https://bugs.webkit.org/show_bug.cgi?id=209835
+
+Reviewed by Ross Kirsling.
+
+After moving to object libraries MediaStrategy's constructor and destructor were
+being reported as linker errors despite being set to default. Moving the definitions
+to a source file stopped these issues.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/MediaStrategy.cpp: Copied from Source/WebCore/platform/MediaStrategy.h.
+* platform/MediaStrategy.h:
+
2020-04-01 Keith Miller
Bindings that override getOwnPropertySlotByIndex need to say they MayHaveIndexedAccessors
Modified: trunk/Source/WebCore/Sources.txt (259357 => 259358)
--- trunk/Source/WebCore/Sources.txt 2020-04-01 19:10:20 UTC (rev 259357)
+++ trunk/Source/WebCore/Sources.txt 2020-04-01 19:15:17 UTC (rev 259358)
@@ -1769,6 +1769,7 @@
platform/LowPowerModeNotifier.cpp
platform/MIMETypeRegistry.cpp
platform/MainThreadSharedTimer.cpp
+platform/MediaStrategy.cpp
platform/NotImplemented.cpp
platform/NowPlayingManager.cpp
platform/Pasteboard.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (259357 => 259358)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-04-01 19:10:20 UTC (rev 259357)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-04-01 19:15:17 UTC (rev 259358)
@@ -11684,6 +11684,7 @@
A1F78D0B1C25422C00245446 /* ResourceResponseCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ResourceResponseCocoa.mm; sourceTree = ""; };
A208E222A56A0C7575F2A72E /* RenderMathMLMenclose.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderMathMLMenclose.h; sourceTree = ""; };
A2B9217216C5CC420041DCD9 /* IntRectExtent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = IntRectExtent.h; sourceTree = ""; };
+ A31AC70A24340984007F00A2 /* MediaStrategy.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MediaStrategy.cpp; sourceTree = ""; };
A31C4E4C16E02AA6002F7957 /* OESTextureHalfFloat.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path =
[webkit-changes] [259357] trunk
Title: [259357] trunk
Revision 259357
Author commit-qu...@webkit.org
Date 2020-04-01 12:10:20 -0700 (Wed, 01 Apr 2020)
Log Message
Delete IC incorrectly caches for proxies
https://bugs.webkit.org/show_bug.cgi?id=209777
Patch by Justin Michaud on 2020-04-01
Reviewed by Mark Lam.
JSTests:
* stress/delete-property-ic-proxy.js: Added.
(obj1.this.foo1):
(foo1.foo2):
(foo1):
(foo2.foo3):
(foo2):
* stress/delete-property-inline-cache.js:
Source/_javascript_Core:
Proxy's do not change their structure ID when properties are added, so we cannot cache deletes
for them.
* jit/Repatch.cpp:
(JSC::tryCacheDeleteBy):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/delete-property-inline-cache.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/Repatch.cpp
Added Paths
trunk/JSTests/stress/delete-property-ic-proxy.js
Diff
Modified: trunk/JSTests/ChangeLog (259356 => 259357)
--- trunk/JSTests/ChangeLog 2020-04-01 18:47:51 UTC (rev 259356)
+++ trunk/JSTests/ChangeLog 2020-04-01 19:10:20 UTC (rev 259357)
@@ -1,3 +1,18 @@
+2020-04-01 Justin Michaud
+
+Delete IC incorrectly caches for proxies
+https://bugs.webkit.org/show_bug.cgi?id=209777
+
+Reviewed by Mark Lam.
+
+* stress/delete-property-ic-proxy.js: Added.
+(obj1.this.foo1):
+(foo1.foo2):
+(foo1):
+(foo2.foo3):
+(foo2):
+* stress/delete-property-inline-cache.js:
+
2020-04-01 Paulo Matos
[JSC] Reenable non-cloop LLint, JIT and DFG on 32-bit platforms
Added: trunk/JSTests/stress/delete-property-ic-proxy.js (0 => 259357)
--- trunk/JSTests/stress/delete-property-ic-proxy.js (rev 0)
+++ trunk/JSTests/stress/delete-property-ic-proxy.js 2020-04-01 19:10:20 UTC (rev 259357)
@@ -0,0 +1,40 @@
+//@ requireOptions("--jitPolicyScale=0", "--useDFGJIT=0")
+
+{
+var obj1 = this
+function foo1() {
+for (let i = 0; i < 5; ++i)
+delete obj1.x
+}
+noInline(foo1)
+
+foo1()
+Object.defineProperty(obj1, "x", {})
+foo1()
+}
+
+{
+var obj2 = new Proxy({}, {})
+function foo2() {
+for (let i = 0; i < 5; ++i)
+delete obj2.x
+}
+noInline(foo2)
+
+foo2()
+Object.defineProperty(obj2, "x", {})
+foo2()
+}
+
+{
+var obj3 = $vm.createProxy({})
+function foo3() {
+for (let i = 0; i < 5; ++i)
+delete obj3.x
+}
+noInline(foo3)
+
+foo3()
+Object.defineProperty(obj3, "x", {})
+foo3()
+}
\ No newline at end of file
Modified: trunk/JSTests/stress/delete-property-inline-cache.js (259356 => 259357)
--- trunk/JSTests/stress/delete-property-inline-cache.js 2020-04-01 18:47:51 UTC (rev 259356)
+++ trunk/JSTests/stress/delete-property-inline-cache.js 2020-04-01 19:10:20 UTC (rev 259357)
@@ -1,4 +1,4 @@
-//@ runDefault("--useBigInt=true")
+//@ requireOptions("--useBigInt=1")
function assert(condition) {
if (!condition)
Modified: trunk/Source/_javascript_Core/ChangeLog (259356 => 259357)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-01 18:47:51 UTC (rev 259356)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-01 19:10:20 UTC (rev 259357)
@@ -1,3 +1,16 @@
+2020-04-01 Justin Michaud
+
+Delete IC incorrectly caches for proxies
+https://bugs.webkit.org/show_bug.cgi?id=209777
+
+Reviewed by Mark Lam.
+
+Proxy's do not change their structure ID when properties are added, so we cannot cache deletes
+for them.
+
+* jit/Repatch.cpp:
+(JSC::tryCacheDeleteBy):
+
2020-04-01 Keith Miller
Bindings that override getOwnPropertySlotByIndex need to say they MayHaveIndexedAccessors
Modified: trunk/Source/_javascript_Core/jit/Repatch.cpp (259356 => 259357)
--- trunk/Source/_javascript_Core/jit/Repatch.cpp 2020-04-01 18:47:51 UTC (rev 259356)
+++ trunk/Source/_javascript_Core/jit/Repatch.cpp 2020-04-01 19:10:20 UTC (rev 259357)
@@ -750,7 +750,7 @@
return GiveUpOnCache;
ASSERT(oldStructure);
-if (!baseValue.isObject() || !oldStructure->propertyAccessesAreCacheable())
+if (!baseValue.isObject() || !oldStructure->propertyAccessesAreCacheable() || oldStructure->isProxy())
return GiveUpOnCache;
if (!slot.isCacheableDelete())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259356] trunk/LayoutTests
Title: [259356] trunk/LayoutTests Revision 259356 Author lawrenc...@apple.com Date 2020-04-01 11:47:51 -0700 (Wed, 01 Apr 2020) Log Message [ iOS wk2 ] crypto/subtle/rsa-indexeddb-non-exportable-private.html is flaky timing out. https://bugs.webkit.org/show_bug.cgi?id=209869 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259355 => 259356) --- trunk/LayoutTests/ChangeLog 2020-04-01 18:42:50 UTC (rev 259355) +++ trunk/LayoutTests/ChangeLog 2020-04-01 18:47:51 UTC (rev 259356) @@ -1,5 +1,14 @@ 2020-04-01 Jason Lawrence +[ iOS wk2 ] crypto/subtle/rsa-indexeddb-non-exportable-private.html is flaky timing out. +https://bugs.webkit.org/show_bug.cgi?id=209869 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2020-04-01 Jason Lawrence + [ Mojave wk1 Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=209866 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (259355 => 259356) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-04-01 18:42:50 UTC (rev 259355) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-04-01 18:47:51 UTC (rev 259356) @@ -1757,4 +1757,6 @@ webkit.org/b/209544 svg/custom/object-sizing-explicit-width.xhtml [ Pass Failure ] -webkit.org/b/209812 fast/forms/input-text-scroll-left-on-blur.html [ Pass Failure ] \ No newline at end of file +webkit.org/b/209812 fast/forms/input-text-scroll-left-on-blur.html [ Pass Failure ] + +webkit.org/b/209869 crypto/subtle/rsa-indexeddb-non-exportable-private.html [ Pass Timeout ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259355] trunk/Source
Title: [259355] trunk/Source Revision 259355 Author keith_mil...@apple.com Date 2020-04-01 11:42:50 -0700 (Wed, 01 Apr 2020) Log Message Bindings that override getOwnPropertySlotByIndex need to say they MayHaveIndexedAccessors https://bugs.webkit.org/show_bug.cgi?id=209762 Reviewed by Darin Adler. Source/_javascript_Core: Change indexingType to indexingModeIncludingHistory to more clearly indicate the expected range of possible valid values. * runtime/StructureInlines.h: (JSC::Structure::create): Source/WebCore: There may be places where we rely on this for semantic correctness. I couldn't find any right now but we might as well be conservative since this isn't a performance regression. * bindings/js/JSDOMWindowProperties.h: * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): * bindings/scripts/test/JS/JSInterfaceName.h: (WebCore::JSInterfaceName::createStructure): * bindings/scripts/test/JS/JSMapLike.h: (WebCore::JSMapLike::createStructure): * bindings/scripts/test/JS/JSReadOnlyMapLike.h: (WebCore::JSReadOnlyMapLike::createStructure): * bindings/scripts/test/JS/JSReadOnlySetLike.h: (WebCore::JSReadOnlySetLike::createStructure): * bindings/scripts/test/JS/JSSetLike.h: (WebCore::JSSetLike::createStructure): * bindings/scripts/test/JS/JSTestActiveDOMObject.h: (WebCore::JSTestActiveDOMObject::createStructure): * bindings/scripts/test/JS/JSTestCEReactions.h: (WebCore::JSTestCEReactions::createStructure): * bindings/scripts/test/JS/JSTestCEReactionsStringifier.h: (WebCore::JSTestCEReactionsStringifier::createStructure): * bindings/scripts/test/JS/JSTestCallTracer.h: (WebCore::JSTestCallTracer::createStructure): * bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h: (WebCore::JSTestClassWithJSBuiltinConstructor::createStructure): * bindings/scripts/test/JS/JSTestDOMJIT.h: (WebCore::JSTestDOMJIT::createStructure): * bindings/scripts/test/JS/JSTestEnabledBySetting.h: (WebCore::JSTestEnabledBySetting::createStructure): * bindings/scripts/test/JS/JSTestEnabledForContext.h: (WebCore::JSTestEnabledForContext::createStructure): * bindings/scripts/test/JS/JSTestEventConstructor.h: (WebCore::JSTestEventConstructor::createStructure): * bindings/scripts/test/JS/JSTestEventTarget.h: (WebCore::JSTestEventTarget::createStructure): * bindings/scripts/test/JS/JSTestException.h: (WebCore::JSTestException::createStructure): * bindings/scripts/test/JS/JSTestGenerateIsReachable.h: (WebCore::JSTestGenerateIsReachable::createStructure): * bindings/scripts/test/JS/JSTestGlobalObject.h: (WebCore::JSTestGlobalObject::createStructure): * bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h: (WebCore::JSTestIndexedSetterNoIdentifier::createStructure): * bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h: (WebCore::JSTestIndexedSetterThrowingException::createStructure): * bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h: (WebCore::JSTestIndexedSetterWithIdentifier::createStructure): * bindings/scripts/test/JS/JSTestInterface.h: * bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.h: (WebCore::JSTestInterfaceLeadingUnderscore::createStructure): * bindings/scripts/test/JS/JSTestIterable.h: (WebCore::JSTestIterable::createStructure): * bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h: (WebCore::JSTestJSBuiltinConstructor::createStructure): * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: (WebCore::JSTestMediaQueryListListener::createStructure): * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h: (WebCore::JSTestNamedAndIndexedSetterNoIdentifier::createStructure): * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h: (WebCore::JSTestNamedAndIndexedSetterThrowingException::createStructure): * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h: (WebCore::JSTestNamedAndIndexedSetterWithIdentifier::createStructure): * bindings/scripts/test/JS/JSTestNamedConstructor.h: (WebCore::JSTestNamedConstructor::createStructure): * bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h: (WebCore::JSTestNamedDeleterNoIdentifier::createStructure): * bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h: (WebCore::JSTestNamedDeleterThrowingException::createStructure): * bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h: (WebCore::JSTestNamedDeleterWithIdentifier::createStructure): * bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h: (WebCore::JSTestNamedDeleterWithIndexedGetter::createStructure): * bindings/scripts/test/JS/JSTestNamedGetterCallWith.h: (WebCore::JSTestNamedGetterCallWith::createStructure): * bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.h: (WebCore::JSTestNamedGetterNoIdentifier::createStructure): * bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.h: (WebCore::JSTestNamedGetterWithIdentifier::createStructure): * bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h: (WebCore::JSTestNamedSetterNoIdentifier::createStructure): *
[webkit-changes] [259354] trunk/LayoutTests
Title: [259354] trunk/LayoutTests Revision 259354 Author lawrenc...@apple.com Date 2020-04-01 11:22:36 -0700 (Wed, 01 Apr 2020) Log Message [ Mojave wk1 Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=209866 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259353 => 259354) --- trunk/LayoutTests/ChangeLog 2020-04-01 17:02:21 UTC (rev 259353) +++ trunk/LayoutTests/ChangeLog 2020-04-01 18:22:36 UTC (rev 259354) @@ -1,3 +1,12 @@ +2020-04-01 Jason Lawrence + +[ Mojave wk1 Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=209866 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2020-04-01 Commit Queue Unreviewed, reverting r259328. Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259353 => 259354) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-04-01 17:02:21 UTC (rev 259353) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-04-01 18:22:36 UTC (rev 259354) @@ -946,4 +946,6 @@ webkit.org/b/209621 fast/loader/child-frame-add-after-back-forward.html [ Pass Timeout ] -webkit.org/b/209837 [ Mojave Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html [ Pass Timeout ] \ No newline at end of file +webkit.org/b/209837 [ Mojave Release ] fast/canvas/webgl/texImage2D-mse-flipY-true.html [ Pass Timeout ] + +webkit.org/b/209866 [ Mojave Release ] platform/mac/media/media-source/videoplaybackquality-decompressionsession.html [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259353] trunk/Source/WebCore
Title: [259353] trunk/Source/WebCore
Revision 259353
Author jer.no...@apple.com
Date 2020-04-01 10:02:21 -0700 (Wed, 01 Apr 2020)
Log Message
Don't use raw pointers in ShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=209843
Reviewed by Brent Fulgham.
* dom/Element.cpp:
(WebCore::Element::addShadowRoot):
* dom/ShadowRoot.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/ShadowRoot.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259352 => 259353)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 16:48:51 UTC (rev 259352)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 17:02:21 UTC (rev 259353)
@@ -1,3 +1,15 @@
+2020-04-01 Jer Noble
+
+Don't use raw pointers in ShadowRoot.
+https://bugs.webkit.org/show_bug.cgi?id=209843
+
+
+Reviewed by Brent Fulgham.
+
+* dom/Element.cpp:
+(WebCore::Element::addShadowRoot):
+* dom/ShadowRoot.h:
+
2020-04-01 Jack Lee
Notify accessibility when a node is removed from its ancestor.
Modified: trunk/Source/WebCore/dom/Element.cpp (259352 => 259353)
--- trunk/Source/WebCore/dom/Element.cpp 2020-04-01 16:48:51 UTC (rev 259352)
+++ trunk/Source/WebCore/dom/Element.cpp 2020-04-01 17:02:21 UTC (rev 259353)
@@ -2291,7 +2291,7 @@
ensureElementRareData().setShadowRoot(WTFMove(newShadowRoot));
-shadowRoot.setHost(this);
+shadowRoot.setHost(makeWeakPtr(this));
shadowRoot.setParentTreeScope(treeScope());
#if ASSERT_ENABLED
Modified: trunk/Source/WebCore/dom/ShadowRoot.h (259352 => 259353)
--- trunk/Source/WebCore/dom/ShadowRoot.h 2020-04-01 16:48:51 UTC (rev 259352)
+++ trunk/Source/WebCore/dom/ShadowRoot.h 2020-04-01 17:02:21 UTC (rev 259353)
@@ -71,8 +71,8 @@
bool containsFocusedElement() const { return m_containsFocusedElement; }
void setContainsFocusedElement(bool flag) { m_containsFocusedElement = flag; }
-Element* host() const { return m_host; }
-void setHost(Element* host) { m_host = host; }
+Element* host() const { return m_host.get(); }
+void setHost(WeakPtr&& host) { m_host = WTFMove(host); }
String innerHTML() const;
ExceptionOr setInnerHTML(const String&);
@@ -130,7 +130,7 @@
bool m_containsFocusedElement { false };
ShadowRootMode m_type { ShadowRootMode::UserAgent };
-Element* m_host { nullptr };
+WeakPtr m_host;
RefPtr m_styleSheetList;
std::unique_ptr m_styleScope;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259352] trunk
Title: [259352] trunk
Revision 259352
Author commit-qu...@webkit.org
Date 2020-04-01 09:48:51 -0700 (Wed, 01 Apr 2020)
Log Message
Unreviewed, reverting r259328.
https://bugs.webkit.org/show_bug.cgi?id=209861
Introduced API test failures (Requested by perarne on
#webkit).
Reverted changeset:
"[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in
sandbox"
https://bugs.webkit.org/show_bug.cgi?id=209814
https://trac.webkit.org/changeset/259328
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt
trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
Diff
Modified: trunk/LayoutTests/ChangeLog (259351 => 259352)
--- trunk/LayoutTests/ChangeLog 2020-04-01 16:33:30 UTC (rev 259351)
+++ trunk/LayoutTests/ChangeLog 2020-04-01 16:48:51 UTC (rev 259352)
@@ -1,3 +1,18 @@
+2020-04-01 Commit Queue
+
+Unreviewed, reverting r259328.
+https://bugs.webkit.org/show_bug.cgi?id=209861
+
+Introduced API test failures (Requested by perarne on
+#webkit).
+
+Reverted changeset:
+
+"[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in
+sandbox"
+https://bugs.webkit.org/show_bug.cgi?id=209814
+https://trac.webkit.org/changeset/259328
+
2020-04-01 youenn fablet
Bump libwebrtc to M82
Modified: trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt (259351 => 259352)
--- trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt 2020-04-01 16:33:30 UTC (rev 259351)
+++ trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup-expected.txt 2020-04-01 16:48:51 UTC (rev 259352)
@@ -8,5 +8,4 @@
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nesessionmanager.content-filter") is false
PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.system.logger") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.lsd.mapdb") is false
Modified: trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html (259351 => 259352)
--- trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html 2020-04-01 16:33:30 UTC (rev 259351)
+++ trunk/LayoutTests/fast/sandbox/mac/sandbox-mach-lookup.html 2020-04-01 16:48:51 UTC (rev 259352)
@@ -11,7 +11,6 @@
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nesessionmanager.content-filter\")");
shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.system.logger\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.lsd.mapdb\")");
}
Modified: trunk/Source/WebKit/ChangeLog (259351 => 259352)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 16:33:30 UTC (rev 259351)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 16:48:51 UTC (rev 259352)
@@ -1,3 +1,18 @@
+2020-04-01 Commit Queue
+
+Unreviewed, reverting r259328.
+https://bugs.webkit.org/show_bug.cgi?id=209861
+
+Introduced API test failures (Requested by perarne on
+#webkit).
+
+Reverted changeset:
+
+"[macOS] Deny mach-lookup access to "com.apple.lsd.mapdb" in
+sandbox"
+https://bugs.webkit.org/show_bug.cgi?id=209814
+https://trac.webkit.org/changeset/259328
+
2020-04-01 Brent Fulgham
Convert app-bound domain categorization parameter to a method
Modified: trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm (259351 => 259352)
--- trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm 2020-04-01 16:33:30 UTC (rev 259351)
+++ trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm 2020-04-01 16:48:51 UTC (rev 259352)
@@ -75,9 +75,6 @@
typedef bool (^LSServerConnectionAllowedBlock) ( CFDictionaryRef optionsRef );
extern "C" void _LSSetApplicationLaunchServicesServerConnectionStatus(uint64_t flags, LSServerConnectionAllowedBlock block);
extern "C" CFDictionaryRef _LSApplicationCheckIn(LSSessionID sessionID, CFDictionaryRef applicationInfo);
-#if HAVE(CSCHECKFIXDISABLE)
-extern "C" void _CSCheckFixDisable();
-#endif
namespace WebKit {
using namespace WebCore;
@@ -154,11 +151,6 @@
void AuxiliaryProcess::launchServicesCheckIn()
{
-#if HAVE(CSCHECKFIXDISABLE)
-// _CSCheckFixDisable() needs to be called before checking in with
[webkit-changes] [259351] trunk/Source/WebKit
Title: [259351] trunk/Source/WebKit Revision 259351 Author bfulg...@apple.com Date 2020-04-01 09:33:30 -0700 (Wed, 01 Apr 2020) Log Message Convert app-bound domain categorization parameter to a method https://bugs.webkit.org/show_bug.cgi?id=209842 Reviewed by John Wilander. SSIA. Covered by existing TestWebKitAPI tests. * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h Diff Modified: trunk/Source/WebKit/ChangeLog (259350 => 259351) --- trunk/Source/WebKit/ChangeLog 2020-04-01 16:21:37 UTC (rev 259350) +++ trunk/Source/WebKit/ChangeLog 2020-04-01 16:33:30 UTC (rev 259351) @@ -1,3 +1,17 @@ +2020-04-01 Brent Fulgham + +Convert app-bound domain categorization parameter to a method +https://bugs.webkit.org/show_bug.cgi?id=209842 + + +Reviewed by John Wilander. + +SSIA. + +Covered by existing TestWebKitAPI tests. + +* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: + 2020-04-01 Alex Christensen Deprecate WKWebsiteDataStore._indexedDBDatabaseDirectory Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h (259350 => 259351) --- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h 2020-04-01 16:21:37 UTC (rev 259350) +++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h 2020-04-01 16:33:30 UTC (rev 259351) @@ -122,8 +122,10 @@ @property (nonatomic, setter=_setEditableImagesEnabled:) BOOL _editableImagesEnabled WK_API_AVAILABLE(macos(10.14.4), ios(12.2)); @property (nonatomic, setter=_setUndoManagerAPIEnabled:) BOOL _undoManagerAPIEnabled WK_API_AVAILABLE(macos(10.15), ios(13.0)); @property (nonatomic, setter=_setWebViewCategory:) _WKWebViewCategory _webViewCategory WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); -@property (nonatomic, setter=_setIgnoresAppBoundDomains:) BOOL _ignoresAppBoundDomains WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); +- (void)_setIgnoresAppBoundDomains:(BOOL)ignoresAppBoundDomains WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); +- (BOOL)_ignoresAppBoundDomains WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); + @property (nonatomic, setter=_setProcessDisplayName:) NSString *_processDisplayName WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); @end ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259350] trunk/Source/WebKit
Title: [259350] trunk/Source/WebKit
Revision 259350
Author commit-qu...@webkit.org
Date 2020-04-01 09:21:37 -0700 (Wed, 01 Apr 2020)
Log Message
Deprecate WKWebsiteDataStore._indexedDBDatabaseDirectory
https://bugs.webkit.org/show_bug.cgi?id=209243
Patch by Alex Christensen on 2020-04-01
Reviewed by David Kilzer.
Luckily it's read-only, but we have a way to get the configuration, so let's encourage that instead.
* UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (259349 => 259350)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 16:18:50 UTC (rev 259349)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 16:21:37 UTC (rev 259350)
@@ -1,3 +1,14 @@
+2020-04-01 Alex Christensen
+
+Deprecate WKWebsiteDataStore._indexedDBDatabaseDirectory
+https://bugs.webkit.org/show_bug.cgi?id=209243
+
+Reviewed by David Kilzer.
+
+Luckily it's read-only, but we have a way to get the configuration, so let's encourage that instead.
+
+* UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
+
2020-04-01 Wenson Hsieh
Make WebPasteboardProxy::didModifyContentsOfPasteboard robust when pasteboardName is null
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h (259349 => 259350)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h 2020-04-01 16:18:50 UTC (rev 259349)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h 2020-04-01 16:21:37 UTC (rev 259350)
@@ -56,8 +56,8 @@
@property (nonatomic, setter=_setAllowsCellularAccess:) BOOL _allowsCellularAccess WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration.allowsCellularAccess", macos(10.13.4, WK_MAC_TBA), ios(11.3, WK_IOS_TBA));
@property (nonatomic, setter=_setProxyConfiguration:) NSDictionary *_proxyConfiguration WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration.proxyConfiguration", macos(10.14, WK_MAC_TBA), ios(12.0, WK_IOS_TBA));
@property (nonatomic, setter=_setAllowsTLSFallback:) BOOL _allowsTLSFallback WK_API_AVAILABLE(macos(10.15), ios(13.0));
+@property (nonatomic, readonly) NSURL *_indexedDBDatabaseDirectory WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration._indexedDBDatabaseDirectory", macos(10.11, WK_MAC_TBA), ios(9.0, WK_IOS_TBA));
-@property (nonatomic, readonly) NSURL *_indexedDBDatabaseDirectory;
- (void)_setResourceLoadStatisticsTestingCallback:(nullable void (^)(WKWebsiteDataStore *, NSString *))callback WK_API_AVAILABLE(macos(10.13), ios(11.0));
- (void)_getAllStorageAccessEntriesFor:(WKWebView *)webView completionHandler:(void (^)(NSArray *domains))completionHandler WK_API_AVAILABLE(macos(10.14), ios(12.0));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259349] trunk/Tools
Title: [259349] trunk/Tools
Revision 259349
Author shihchieh_...@apple.com
Date 2020-04-01 09:18:50 -0700 (Wed, 01 Apr 2020)
Log Message
Unreviewed, add new committer to contributors.json
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (259348 => 259349)
--- trunk/Tools/ChangeLog 2020-04-01 16:13:01 UTC (rev 259348)
+++ trunk/Tools/ChangeLog 2020-04-01 16:18:50 UTC (rev 259349)
@@ -1,3 +1,9 @@
+2020-04-01 Jack Lee
+
+Unreviewed, add new committer to contributors.json
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2020-04-01 Philippe Normand
[Flatpak SDK] Migration to version 0.2
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (259348 => 259349)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2020-04-01 16:13:01 UTC (rev 259348)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2020-04-01 16:18:50 UTC (rev 259349)
@@ -2533,6 +2533,15 @@
],
"status" : "reviewer"
},
+ "Jack Lee" : {
+ "emails" : [
+ "shihchieh_...@apple.com"
+ ],
+ "nicks" : [
+ "jackl"
+ ],
+ "status" : "committer"
+ },
"Jacky Jiang" : {
"emails" : [
"jkji...@webkit.org",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259348] trunk/Source/WebCore
Title: [259348] trunk/Source/WebCore
Revision 259348
Author shihchieh_...@apple.com
Date 2020-04-01 09:13:01 -0700 (Wed, 01 Apr 2020)
Log Message
Notify accessibility when a node is removed from its ancestor.
https://bugs.webkit.org/show_bug.cgi?id=209819
Reviewed by Chris Fleizach.
Covered by existing tests in LayoutTests/accessibility.
* dom/Node.cpp:
(WebCore::Node::removedFromAncestor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259347 => 259348)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 16:04:07 UTC (rev 259347)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 16:13:01 UTC (rev 259348)
@@ -1,3 +1,15 @@
+2020-04-01 Jack Lee
+
+Notify accessibility when a node is removed from its ancestor.
+https://bugs.webkit.org/show_bug.cgi?id=209819
+
+Reviewed by Chris Fleizach.
+
+Covered by existing tests in LayoutTests/accessibility.
+
+* dom/Node.cpp:
+(WebCore::Node::removedFromAncestor):
+
2020-04-01 Commit Queue
Unreviewed, reverting r259282.
Modified: trunk/Source/WebCore/dom/Node.cpp (259347 => 259348)
--- trunk/Source/WebCore/dom/Node.cpp 2020-04-01 16:04:07 UTC (rev 259347)
+++ trunk/Source/WebCore/dom/Node.cpp 2020-04-01 16:13:01 UTC (rev 259348)
@@ -1297,12 +1297,18 @@
return InsertedIntoAncestorResult::Done;
}
-void Node::removedFromAncestor(RemovalType removalType, ContainerNode&)
+void Node::removedFromAncestor(RemovalType removalType, ContainerNode& oldParentOfRemovedTree)
{
if (removalType.disconnectedFromDocument)
clearFlag(IsConnectedFlag);
if (isInShadowTree() && !treeScope().rootNode().isShadowRoot())
clearFlag(IsInShadowTreeFlag);
+if (removalType.disconnectedFromDocument) {
+if (auto* document = ().documentScope()) {
+if (auto* cache = document->existingAXObjectCache())
+cache->remove(*this);
+}
+}
}
bool Node::isRootEditableElement() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259347] trunk/Source/WebCore
Title: [259347] trunk/Source/WebCore
Revision 259347
Author commit-qu...@webkit.org
Date 2020-04-01 09:04:07 -0700 (Wed, 01 Apr 2020)
Log Message
Unreviewed, reverting r259282.
https://bugs.webkit.org/show_bug.cgi?id=209860
Caused memory corruption (Requested by ap on #webkit).
Reverted changeset:
"Scroll latching state is not a stack"
https://bugs.webkit.org/show_bug.cgi?id=209790
https://trac.webkit.org/changeset/259282
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/page/mac/EventHandlerMac.mm
trunk/Source/WebCore/page/scrolling/ScrollLatchingState.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259346 => 259347)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 16:01:36 UTC (rev 259346)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 16:04:07 UTC (rev 259347)
@@ -1,3 +1,16 @@
+2020-04-01 Commit Queue
+
+Unreviewed, reverting r259282.
+https://bugs.webkit.org/show_bug.cgi?id=209860
+
+Caused memory corruption (Requested by ap on #webkit).
+
+Reverted changeset:
+
+"Scroll latching state is not a stack"
+https://bugs.webkit.org/show_bug.cgi?id=209790
+https://trac.webkit.org/changeset/259282
+
2020-04-01 youenn fablet
Bump libwebrtc to M82
Modified: trunk/Source/WebCore/page/Page.cpp (259346 => 259347)
--- trunk/Source/WebCore/page/Page.cpp 2020-04-01 16:01:36 UTC (rev 259346)
+++ trunk/Source/WebCore/page/Page.cpp 2020-04-01 16:04:07 UTC (rev 259347)
@@ -2943,26 +2943,41 @@
#if ENABLE(WHEEL_EVENT_LATCHING)
ScrollLatchingState* Page::latchingState()
{
-return m_latchingState.get();
+if (m_latchingState.isEmpty())
+return nullptr;
+
+return _latchingState.last();
}
-void Page::setLatchingState(std::unique_ptr&& state)
+void Page::pushNewLatchingState(ScrollLatchingState&& state)
{
-m_latchingState = WTFMove(state);
+m_latchingState.append(WTFMove(state));
}
void Page::resetLatchingState()
{
-m_latchingState = nullptr;
+m_latchingState.clear();
}
+void Page::popLatchingState()
+{
+m_latchingState.removeLast();
+LOG_WITH_STREAM(ScrollLatching, stream << "Page::popLatchingState() - new state " << m_latchingState);
+}
+
void Page::removeLatchingStateForTarget(Element& targetNode)
{
-if (!m_latchingState)
+if (m_latchingState.isEmpty())
return;
-if (m_latchingState->wheelEventElement() == )
-m_latchingState = nullptr;
+m_latchingState.removeAllMatching([] (ScrollLatchingState& state) {
+auto* wheelElement = state.wheelEventElement();
+if (!wheelElement)
+return false;
+
+return targetNode.isEqualNode(wheelElement);
+});
+LOG_WITH_STREAM(ScrollLatching, stream << "Page::removeLatchingStateForTarget() - new state " << m_latchingState);
}
#endif // ENABLE(WHEEL_EVENT_LATCHING)
Modified: trunk/Source/WebCore/page/Page.h (259346 => 259347)
--- trunk/Source/WebCore/page/Page.h 2020-04-01 16:01:36 UTC (rev 259346)
+++ trunk/Source/WebCore/page/Page.h 2020-04-01 16:04:07 UTC (rev 259347)
@@ -430,7 +430,9 @@
#if ENABLE(WHEEL_EVENT_LATCHING)
ScrollLatchingState* latchingState();
-void setLatchingState(std::unique_ptr&&);
+const Vector& latchingStateStack() const { return m_latchingState; }
+void pushNewLatchingState(ScrollLatchingState&&);
+void popLatchingState();
void resetLatchingState();
void removeLatchingStateForTarget(Element&);
#endif // ENABLE(WHEEL_EVENT_LATCHING)
@@ -978,7 +980,7 @@
std::unique_ptr m_performanceLogging;
#if ENABLE(WHEEL_EVENT_LATCHING)
-std::unique_ptr m_latchingState;
+Vector m_latchingState;
#endif
#if PLATFORM(MAC) && (ENABLE(SERVICE_CONTROLS) || ENABLE(TELEPHONE_NUMBER_DETECTION))
std::unique_ptr m_servicesOverlayController;
Modified: trunk/Source/WebCore/page/mac/EventHandlerMac.mm (259346 => 259347)
--- trunk/Source/WebCore/page/mac/EventHandlerMac.mm 2020-04-01 16:01:36 UTC (rev 259346)
+++ trunk/Source/WebCore/page/mac/EventHandlerMac.mm 2020-04-01 16:04:07 UTC (rev 259347)
@@ -983,23 +983,23 @@
if (scrollableContainer && scrollableArea) {
bool startingAtScrollLimit = scrolledToEdgeInDominantDirection(*scrollableContainer, *scrollableArea.get(), wheelEvent.deltaX(), wheelEvent.deltaY());
if (!startingAtScrollLimit) {
-auto latchingState = WTF::makeUnique();
-latchingState->setStartedGestureAtScrollLimit(false);
-latchingState->setWheelEventElement(wheelEventTarget.get());
-latchingState->setFrame(_frame);
-latchingState->setScrollableContainer(scrollableContainer.get());
-latchingState->setWidgetIsLatched(result.isOverWidget());
-page->setLatchingState(WTFMove(latchingState));
+ScrollLatchingState latchingState;
+
[webkit-changes] [259346] trunk/Source/WebKit
Title: [259346] trunk/Source/WebKit
Revision 259346
Author wenson_hs...@apple.com
Date 2020-04-01 09:01:36 -0700 (Wed, 01 Apr 2020)
Log Message
Make WebPasteboardProxy::didModifyContentsOfPasteboard robust when pasteboardName is null
https://bugs.webkit.org/show_bug.cgi?id=209848
Reviewed by Megan Gardner and David Kilzer.
Add more IPC message checks in WebPasteboardProxy; see below for more detail.
* UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
Rename what is currently MESSAGE_CHECK to MESSAGE_CHECK_COMPLETION, and introduce two more message check macros:
MESSAGE_CHECK_WITH_RETURN_VALUE, which supports a return value, and MESSAGE_CHECK, which returns with no value.
(WebKit::WebPasteboardProxy::canAccessPasteboardData const):
Replace the early returns when pasteboardName is empty or when the web process for the given connection is null
with `MESSAGE_CHECK`s. When the web content process is well-behaved, these early returns should never be hit.
(WebKit::WebPasteboardProxy::didModifyContentsOfPasteboard):
Similarly, replace this early return with a message check, and additionally `MESSAGE_CHECK` when the pasteboard
name is empty. This addresses the main issue caught by this radar.
(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (259345 => 259346)
--- trunk/Source/WebKit/ChangeLog 2020-04-01 15:31:36 UTC (rev 259345)
+++ trunk/Source/WebKit/ChangeLog 2020-04-01 16:01:36 UTC (rev 259346)
@@ -1,3 +1,30 @@
+2020-04-01 Wenson Hsieh
+
+Make WebPasteboardProxy::didModifyContentsOfPasteboard robust when pasteboardName is null
+https://bugs.webkit.org/show_bug.cgi?id=209848
+
+
+Reviewed by Megan Gardner and David Kilzer.
+
+Add more IPC message checks in WebPasteboardProxy; see below for more detail.
+
+* UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
+
+Rename what is currently MESSAGE_CHECK to MESSAGE_CHECK_COMPLETION, and introduce two more message check macros:
+MESSAGE_CHECK_WITH_RETURN_VALUE, which supports a return value, and MESSAGE_CHECK, which returns with no value.
+
+(WebKit::WebPasteboardProxy::canAccessPasteboardData const):
+
+Replace the early returns when pasteboardName is empty or when the web process for the given connection is null
+with `MESSAGE_CHECK`s. When the web content process is well-behaved, these early returns should never be hit.
+
+(WebKit::WebPasteboardProxy::didModifyContentsOfPasteboard):
+
+Similarly, replace this early return with a message check, and additionally `MESSAGE_CHECK` when the pasteboard
+name is empty. This addresses the main issue caught by this radar.
+
+(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
+
2020-04-01 Victor M. Jaquez
Bump libwebrtc to M82
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm (259345 => 259346)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm 2020-04-01 15:31:36 UTC (rev 259345)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm 2020-04-01 16:01:36 UTC (rev 259346)
@@ -38,7 +38,9 @@
#import
#import
-#define MESSAGE_CHECK(assertion, completion) MESSAGE_CHECK_COMPLETION_BASE(assertion, (), completion)
+#define MESSAGE_CHECK(assertion) MESSAGE_CHECK_BASE(assertion, ())
+#define MESSAGE_CHECK_WITH_RETURN_VALUE(assertion, returnValue) MESSAGE_CHECK_WITH_RETURN_VALUE_BASE(assertion, (), returnValue)
+#define MESSAGE_CHECK_COMPLETION(assertion, completion) MESSAGE_CHECK_COMPLETION_BASE(assertion, (), completion)
namespace WebKit {
using namespace WebCore;
@@ -73,14 +75,10 @@
bool WebPasteboardProxy::canAccessPasteboardData(IPC::Connection& connection, const String& pasteboardName) const
{
-if (pasteboardName.isEmpty()) {
-ASSERT_NOT_REACHED();
-return false;
-}
+MESSAGE_CHECK_WITH_RETURN_VALUE(!pasteboardName.isEmpty(), false);
auto* process = webProcessProxyForConnection(connection);
-if (!process)
-return false;
+MESSAGE_CHECK_WITH_RETURN_VALUE(process, false);
for (auto* page : process->pages()) {
auto& preferences = page->preferences();
@@ -106,9 +104,10 @@
void WebPasteboardProxy::didModifyContentsOfPasteboard(IPC::Connection& connection, const String& pasteboardName, int64_t previousChangeCount, int64_t newChangeCount)
{
+MESSAGE_CHECK(!pasteboardName.isEmpty());
+
auto* process = webProcessProxyForConnection(connection);
-if (!process)
-return;
+MESSAGE_CHECK(process);
auto changeCountAndProcesses = m_pasteboardNameToChangeCountAndProcessesMap.find(pasteboardName);
if (changeCountAndProcesses != m_pasteboardNameToChangeCountAndProcessesMap.end() && previousChangeCount == changeCountAndProcesses->value.first) {
@@ -300,7 +299,7 @@
[webkit-changes] [259344] trunk/Source/bmalloc
Title: [259344] trunk/Source/bmalloc Revision 259344 Author commit-qu...@webkit.org Date 2020-04-01 08:28:37 -0700 (Wed, 01 Apr 2020) Log Message Update check for aarch64 https://bugs.webkit.org/show_bug.cgi?id=209322 Patch by Michael Catanzaro on 2020-04-01 Reviewed by Mark Lam. Update BPlatform.h to follow the corresponding change in WTF's PlatformCPU.h. * bmalloc/BPlatform.h: Modified Paths trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/bmalloc/BPlatform.h Diff Modified: trunk/Source/bmalloc/ChangeLog (259343 => 259344) --- trunk/Source/bmalloc/ChangeLog 2020-04-01 14:44:31 UTC (rev 259343) +++ trunk/Source/bmalloc/ChangeLog 2020-04-01 15:28:37 UTC (rev 259344) @@ -1,3 +1,15 @@ +2020-04-01 Michael Catanzaro + +Update check for aarch64 +https://bugs.webkit.org/show_bug.cgi?id=209322 + + +Reviewed by Mark Lam. + +Update BPlatform.h to follow the corresponding change in WTF's PlatformCPU.h. + +* bmalloc/BPlatform.h: + 2020-03-15 Yusuke Suzuki Should not use variable-length-array (VLA) Modified: trunk/Source/bmalloc/bmalloc/BPlatform.h (259343 => 259344) --- trunk/Source/bmalloc/bmalloc/BPlatform.h 2020-04-01 14:44:31 UTC (rev 259343) +++ trunk/Source/bmalloc/bmalloc/BPlatform.h 2020-04-01 15:28:37 UTC (rev 259344) @@ -123,8 +123,8 @@ #define BCPU_X86_64 1 #endif -/* BCPU(ARM64) - Apple */ -#if (defined(__arm64__) && defined(__APPLE__)) || defined(__aarch64__) +/* BCPU(ARM64) */ +#if defined(__arm64__) || defined(__aarch64__) #define BCPU_ARM64 1 #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259343] trunk/LayoutTests
Title: [259343] trunk/LayoutTests Revision 259343 Author dp...@igalia.com Date 2020-04-01 07:44:31 -0700 (Wed, 01 Apr 2020) Log Message [GTK] Gardening, failures in EWS GTK-WK2 https://bugs.webkit.org/show_bug.cgi?id=209855 Unreviewed gardening. Garden failures happening in EWS GTK-WK2 but not in GTK test bot. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259342 => 259343) --- trunk/LayoutTests/ChangeLog 2020-04-01 13:31:07 UTC (rev 259342) +++ trunk/LayoutTests/ChangeLog 2020-04-01 14:44:31 UTC (rev 259343) @@ -1,3 +1,14 @@ +2020-04-01 Diego Pino Garcia + +[GTK] Gardening, failures in EWS GTK-WK2 +https://bugs.webkit.org/show_bug.cgi?id=209855 + +Unreviewed gardening. + +Garden failures happening in EWS GTK-WK2 but not in GTK test bot. + +* platform/gtk/TestExpectations: + 2020-04-01 Philippe Normand [Flatpak SDK] Migration to version 0.2 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (259342 => 259343) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-04-01 13:31:07 UTC (rev 259342) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-04-01 14:44:31 UTC (rev 259343) @@ -1371,6 +1371,29 @@ webkit.org/b/209801 imported/w3c/web-platform-tests/xhr/header-user-agent-sync.htm [ Failure ] +# Tests failing in EWS but not in test bot. +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-media.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-range.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-redirect.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-request-headers.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-request-max-stale.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-validation-attachment.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-validation-no-body.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-validation.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-vary-no-body.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-vary.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/redirect-chain-limits.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/resource-becomes-uncacheable.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cookies/same-site/popup-cross-site-post.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cookies/same-site/popup-cross-site.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cookies/same-site/popup-same-site-post.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cookies/same-site/popup-same-site-via-same-site-redirect.html [ Failure Pass ] +webkit.org/b/209533 http/tests/cookies/same-site/popup-same-site.html [ Failure Pass ] + # # End of Expected failures. # @@ -3189,6 +3212,14 @@ webkit.org/b/208000 [ Debug ] inspector/unit-tests/url-utilities.html [ Timeout ] # Tests timing out in EWS but not test-bot. +webkit.org/b/209533 accessibility/ARIA-reflection.html [ Timeout Pass ] +webkit.org/b/209533 accessibility/gtk/aria-activedescendant.html [ Timeout Pass ] +webkit.org/b/209533 animations/3d/change-transform-in-end-event.html [ Timeout Pass ] +webkit.org/b/209533 animations/CSSKeyframesRule-name-null.html [ Timeout Pass ] +webkit.org/b/209533 animations/font-variations/font-stretch.html [ Timeout Pass ] +webkit.org/b/209533 canvas/philip/tests/2d.canvas.readonly.html [ Timeout Pass ] +webkit.org/b/209533 compositing/absolute-inside-out-of-view-fixed.html [ Timeout Pass ] +webkit.org/b/209533 compositing/animation/animated-composited-inside-hidden.html [ Timeout Pass ] webkit.org/b/209533 fast/frames/exponential-frames.html [ Timeout Pass ] webkit.org/b/209533 http/tests/appcache/top-frame-2.html [ Timeout Pass ] webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-remove-several-pending-writes.html [ Timeout Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259342] trunk/JSTests
Title: [259342] trunk/JSTests Revision 259342 Author commit-qu...@webkit.org Date 2020-04-01 06:31:07 -0700 (Wed, 01 Apr 2020) Log Message [JSC] Reenable non-cloop LLint, JIT and DFG on 32-bit platforms https://bugs.webkit.org/show_bug.cgi?id=191163 Patch by Paulo Matos on 2020-04-01 Reviewed by Adrian Perez de Castro. Re-enable tests for 32bits. * stress/op_add.js: * stress/op_bitand.js: * stress/op_bitor.js: * stress/op_bitxor.js: * stress/op_lshift-ConstVar.js: * stress/op_lshift-VarConst.js: * stress/op_lshift-VarVar.js: * stress/op_mod-ConstVar.js: * stress/op_mod-VarConst.js: * stress/op_mod-VarVar.js: * stress/op_mul-ConstVar.js: * stress/op_mul-VarConst.js: * stress/op_mul-VarVar.js: * stress/op_rshift-ConstVar.js: * stress/op_rshift-VarConst.js: * stress/op_rshift-VarVar.js: * stress/op_sub-ConstVar.js: * stress/op_sub-VarConst.js: * stress/op_sub-VarVar.js: * stress/op_urshift-ConstVar.js: * stress/op_urshift-VarConst.js: * stress/op_urshift-VarVar.js: * stress/spread-forward-call-varargs-stack-overflow.js: * stress/value-to-boolean.js: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/stress/op_add.js trunk/JSTests/stress/op_bitand.js trunk/JSTests/stress/op_bitor.js trunk/JSTests/stress/op_bitxor.js trunk/JSTests/stress/op_lshift-ConstVar.js trunk/JSTests/stress/op_lshift-VarConst.js trunk/JSTests/stress/op_lshift-VarVar.js trunk/JSTests/stress/op_mod-ConstVar.js trunk/JSTests/stress/op_mod-VarConst.js trunk/JSTests/stress/op_mod-VarVar.js trunk/JSTests/stress/op_mul-ConstVar.js trunk/JSTests/stress/op_mul-VarConst.js trunk/JSTests/stress/op_mul-VarVar.js trunk/JSTests/stress/op_rshift-ConstVar.js trunk/JSTests/stress/op_rshift-VarConst.js trunk/JSTests/stress/op_rshift-VarVar.js trunk/JSTests/stress/op_sub-ConstVar.js trunk/JSTests/stress/op_sub-VarConst.js trunk/JSTests/stress/op_sub-VarVar.js trunk/JSTests/stress/op_urshift-ConstVar.js trunk/JSTests/stress/op_urshift-VarConst.js trunk/JSTests/stress/op_urshift-VarVar.js trunk/JSTests/stress/spread-forward-call-varargs-stack-overflow.js trunk/JSTests/stress/value-to-boolean.js Diff Modified: trunk/JSTests/ChangeLog (259341 => 259342) --- trunk/JSTests/ChangeLog 2020-04-01 13:27:39 UTC (rev 259341) +++ trunk/JSTests/ChangeLog 2020-04-01 13:31:07 UTC (rev 259342) @@ -1,3 +1,37 @@ +2020-04-01 Paulo Matos + +[JSC] Reenable non-cloop LLint, JIT and DFG on 32-bit platforms +https://bugs.webkit.org/show_bug.cgi?id=191163 + +Reviewed by Adrian Perez de Castro. + +Re-enable tests for 32bits. + +* stress/op_add.js: +* stress/op_bitand.js: +* stress/op_bitor.js: +* stress/op_bitxor.js: +* stress/op_lshift-ConstVar.js: +* stress/op_lshift-VarConst.js: +* stress/op_lshift-VarVar.js: +* stress/op_mod-ConstVar.js: +* stress/op_mod-VarConst.js: +* stress/op_mod-VarVar.js: +* stress/op_mul-ConstVar.js: +* stress/op_mul-VarConst.js: +* stress/op_mul-VarVar.js: +* stress/op_rshift-ConstVar.js: +* stress/op_rshift-VarConst.js: +* stress/op_rshift-VarVar.js: +* stress/op_sub-ConstVar.js: +* stress/op_sub-VarConst.js: +* stress/op_sub-VarVar.js: +* stress/op_urshift-ConstVar.js: +* stress/op_urshift-VarConst.js: +* stress/op_urshift-VarVar.js: +* stress/spread-forward-call-varargs-stack-overflow.js: +* stress/value-to-boolean.js: + 2020-03-30 Alexey Shvayka Add support in named capture group identifiers for direct surrogate pairs Modified: trunk/JSTests/stress/op_add.js (259341 => 259342) --- trunk/JSTests/stress/op_add.js 2020-04-01 13:27:39 UTC (rev 259341) +++ trunk/JSTests/stress/op_add.js 2020-04-01 13:31:07 UTC (rev 259342) @@ -1,6 +1,3 @@ -// FIXME: unskip when this is solved -// https://bugs.webkit.org/show_bug.cgi?id=191163 -//@ skip if ["arm", "mips", "x86"].include?($architecture) //@ runFTLNoCJIT // If all goes well, this test module will terminate silently. If not, it will print Modified: trunk/JSTests/stress/op_bitand.js (259341 => 259342) --- trunk/JSTests/stress/op_bitand.js 2020-04-01 13:27:39 UTC (rev 259341) +++ trunk/JSTests/stress/op_bitand.js 2020-04-01 13:31:07 UTC (rev 259342) @@ -1,6 +1,3 @@ -// FIXME: unskip when this is solved -// https://bugs.webkit.org/show_bug.cgi?id=191163 -//@ skip if ["arm", "mips", "x86"].include?($architecture) //@ runFTLNoCJIT // If all goes well, this test module will terminate silently. If not, it will print Modified: trunk/JSTests/stress/op_bitor.js (259341 => 259342) --- trunk/JSTests/stress/op_bitor.js 2020-04-01 13:27:39 UTC (rev 259341) +++ trunk/JSTests/stress/op_bitor.js 2020-04-01 13:31:07 UTC (rev 259342) @@ -1,6 +1,3 @@ -// FIXME: unskip when this is solved -// https://bugs.webkit.org/show_bug.cgi?id=191163 -//@ skip if ["arm", "mips", "x86"].include?($architecture) //@ runFTLNoCJIT // If all goes well, this test
[webkit-changes] [259340] trunk/LayoutTests
Title: [259340] trunk/LayoutTests
Revision 259340
Author dp...@igalia.com
Date 2020-04-01 06:16:56 -0700 (Wed, 01 Apr 2020)
Log Message
[GTK] Gardening, update baselines
https://bugs.webkit.org/show_bug.cgi?id=209852
Unreviewed gardening.
Update GTK baselines after r259296.
* platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt:
* platform/gtk/fast/forms/form-hides-table-expected.txt:
* platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/form-hides-table-expected.txt
trunk/LayoutTests/platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt
trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (259339 => 259340)
--- trunk/LayoutTests/ChangeLog 2020-04-01 12:15:40 UTC (rev 259339)
+++ trunk/LayoutTests/ChangeLog 2020-04-01 13:16:56 UTC (rev 259340)
@@ -1,3 +1,17 @@
+2020-04-01 Diego Pino Garcia
+
+[GTK] Gardening, update baselines
+https://bugs.webkit.org/show_bug.cgi?id=209852
+
+Unreviewed gardening.
+
+Update GTK baselines after r259296.
+
+* platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt:
+* platform/gtk/fast/forms/form-hides-table-expected.txt:
+* platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
+* platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
+
2020-03-31 Zalan Bujtas
[MultiColumn] Call RenderTreeBuilder::multiColumnDescendantInserted only when the enclosing fragmented flow has changed
Modified: trunk/LayoutTests/platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt (259339 => 259340)
--- trunk/LayoutTests/platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt 2020-04-01 12:15:40 UTC (rev 259339)
+++ trunk/LayoutTests/platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt 2020-04-01 13:16:56 UTC (rev 259340)
@@ -9,7 +9,8 @@
layer at (8,50) size 240x240
RenderBlock (positioned) {DIV} at (8,50) size 240x240 [border: (10px solid #FF)]
RenderTable {DIV} at (10,10) size 220x220
- RenderTableCol {DIV} at (0,0) size 0x0
+ RenderTableCol at (0,0) size 0x0
+RenderTableCol {DIV} at (0,0) size 0x0
RenderTableSection (anonymous) at (0,0) size 220x220
RenderTableRow {DIV} at (0,0) size 220x220
RenderTableCell {DIV} at (0,0) size 220x20 [border: (10px solid #FFA500)] [r=0 c=0 rs=1 cs=1]
Modified: trunk/LayoutTests/platform/gtk/fast/forms/form-hides-table-expected.txt (259339 => 259340)
--- trunk/LayoutTests/platform/gtk/fast/forms/form-hides-table-expected.txt 2020-04-01 12:15:40 UTC (rev 259339)
+++ trunk/LayoutTests/platform/gtk/fast/forms/form-hides-table-expected.txt 2020-04-01 13:16:56 UTC (rev 259340)
@@ -142,7 +142,8 @@
RenderTableCol {DIV} at (0,0) size 0x0
RenderBlock {DIV} at (0,526) size 769x0
RenderTable at (0,0) size 0x0
- RenderTableCol {DIV} at (0,0) size 0x0
+ RenderTableCol at (0,0) size 0x0
+RenderTableCol {DIV} at (0,0) size 0x0
RenderBlock {DIV} at (0,526) size 769x40
RenderTable at (0,0) size 116x40
RenderTableSection (anonymous) at (0,0) size 116x40
Modified: trunk/LayoutTests/platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt (259339 => 259340)
--- trunk/LayoutTests/platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt 2020-04-01 12:15:40 UTC (rev 259339)
+++ trunk/LayoutTests/platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt 2020-04-01 13:16:56 UTC (rev 259340)
@@ -7,7 +7,8 @@
RenderText {#text} at (0,0) size 410x17
text run at (0,0) width 410: "Test passes if there is a box with sharp or rounded corners below."
RenderTable {DIV} at (0,34) size 102x102 [border: (1px none #00)]
-RenderTableCol {DIV} at (0,0) size 0x0 [border: (3px solid #008000)]
+RenderTableCol at (0,0) size 0x0
+ RenderTableCol {DIV} at (0,0) size 0x0 [border: (3px solid #008000)]
RenderTableSection (anonymous) at (1,1) size 99x99
RenderTableRow {DIV} at (0,0) size 99x99
RenderTableCell {DIV} at (0,0) size 99x3 [border: (2px none #00)] [r=0 c=0 rs=1 cs=1]
Modified: trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.txt (259339 => 259340)
--- trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.txt 2020-04-01 12:15:40 UTC (rev 259339)
+++
[webkit-changes] [259339] trunk/Tools
Title: [259339] trunk/Tools
Revision 259339
Author carlo...@webkit.org
Date 2020-04-01 05:15:40 -0700 (Wed, 01 Apr 2020)
Log Message
[GTK] MiniBrowser: valgrind claims 'Invalid write of size 8' on close
https://bugs.webkit.org/show_bug.cgi?id=209471
Reviewed by Adrian Perez de Castro.
This is because we need to remove the weak pointer added in child windows to their parent.
* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowDispose): Remove the parentWindow weak ref.
(browser_window_class_init): Add dispose.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c
Diff
Modified: trunk/Tools/ChangeLog (259338 => 259339)
--- trunk/Tools/ChangeLog 2020-04-01 09:08:26 UTC (rev 259338)
+++ trunk/Tools/ChangeLog 2020-04-01 12:15:40 UTC (rev 259339)
@@ -1,3 +1,16 @@
+2020-04-01 Carlos Garcia Campos
+
+[GTK] MiniBrowser: valgrind claims 'Invalid write of size 8' on close
+https://bugs.webkit.org/show_bug.cgi?id=209471
+
+Reviewed by Adrian Perez de Castro.
+
+This is because we need to remove the weak pointer added in child windows to their parent.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(browserWindowDispose): Remove the parentWindow weak ref.
+(browser_window_class_init): Add dispose.
+
2020-03-31 Kate Cheney
Requests for messageHandlers() in the DOMWindow should be ignored for non-app-bound navigations
Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (259338 => 259339)
--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c 2020-04-01 09:08:26 UTC (rev 259338)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c 2020-04-01 12:15:40 UTC (rev 259339)
@@ -711,6 +711,18 @@
gtk_main_quit();
}
+static void browserWindowDispose(GObject *gObject)
+{
+BrowserWindow *window = BROWSER_WINDOW(gObject);
+
+if (window->parentWindow) {
+g_object_remove_weak_pointer(G_OBJECT(window->parentWindow), (gpointer *)>parentWindow);
+window->parentWindow = NULL;
+}
+
+G_OBJECT_CLASS(browser_window_parent_class)->dispose(gObject);
+}
+
static void browserWindowSetupEditorToolbar(BrowserWindow *window)
{
GtkWidget *toolbar = gtk_toolbar_new();
@@ -1126,6 +1138,7 @@
GObjectClass *gobjectClass = G_OBJECT_CLASS(klass);
gobjectClass->constructed = browserWindowConstructed;
+gobjectClass->dispose = browserWindowDispose;
gobjectClass->finalize = browserWindowFinalize;
GtkWidgetClass *widgetClass = GTK_WIDGET_CLASS(klass);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259338] trunk/Source
Title: [259338] trunk/Source
Revision 259338
Author you...@apple.com
Date 2020-04-01 02:08:26 -0700 (Wed, 01 Apr 2020)
Log Message
Support resolution of IPv6 STUN/TURN addresses
https://bugs.webkit.org/show_bug.cgi?id=209808
Reviewed by Eric Carlson.
Source/WebCore:
Add family access to IPAddress to support both IPv4 and IPv6.
Store IPAddress internal value as IPv6 and cast them to IPv4 on demand.
* platform/network/DNS.h:
* platform/network/soup/DNSResolveQueueSoup.cpp:
(WebCore::resolvedWithObserverCallback):
Source/WebKit:
Update code to support IPv6 addresses when doing DNS resolution of TURN/STUN servers.
Refactor code to share more code between Cocoa ports and non Cocoa ports.
Manually tested with external IPv6 TURN servers.
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createResolver):
* NetworkProcess/webrtc/NetworkRTCResolverCocoa.cpp:
(WebKit::resolvedName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/DNS.h
trunk/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolverCocoa.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259337 => 259338)
--- trunk/Source/WebCore/ChangeLog 2020-04-01 07:54:05 UTC (rev 259337)
+++ trunk/Source/WebCore/ChangeLog 2020-04-01 09:08:26 UTC (rev 259338)
@@ -1,3 +1,17 @@
+2020-04-01 youenn fablet
+
+Support resolution of IPv6 STUN/TURN addresses
+https://bugs.webkit.org/show_bug.cgi?id=209808
+
+Reviewed by Eric Carlson.
+
+Add family access to IPAddress to support both IPv4 and IPv6.
+Store IPAddress internal value as IPv6 and cast them to IPv4 on demand.
+
+* platform/network/DNS.h:
+* platform/network/soup/DNSResolveQueueSoup.cpp:
+(WebCore::resolvedWithObserverCallback):
+
2020-03-31 Simon Fraser
Make FrameView and Frame TextStream-loggable
Modified: trunk/Source/WebCore/platform/network/DNS.h (259337 => 259338)
--- trunk/Source/WebCore/platform/network/DNS.h 2020-04-01 07:54:05 UTC (rev 259337)
+++ trunk/Source/WebCore/platform/network/DNS.h 2020-04-01 09:08:26 UTC (rev 259338)
@@ -27,35 +27,56 @@
#if OS(WINDOWS)
#include
+#include
#else
#include
#endif
#include
+#include
+#include
namespace WebCore {
-class WEBCORE_EXPORT IPAddress {
+class IPAddress {
public:
-explicit IPAddress(const struct sockaddr_in& address)
+static Optional fromSockAddrIn6(const struct sockaddr_in6&);
+explicit IPAddress(const struct in_addr& address)
+: m_address(address)
{
-memset(_address, 0, sizeof(struct sockaddr_in));
-m_address = address;
}
-const struct in_addr& getSinAddr() { return m_address.sin_addr; };
+explicit IPAddress(const struct in6_addr& address)
+: m_address(address)
+{
+}
+bool isIPv4() const { return WTF::holds_alternative(m_address); }
+bool isIPv6() const { return WTF::holds_alternative(m_address); }
+
+const struct in_addr& ipv4Address() const { return WTF::get(m_address); }
+const struct in6_addr& ipv6Address() const { return WTF::get(m_address); }
+
private:
-struct sockaddr_in m_address;
+Variant m_address;
};
enum class DNSError { Unknown, CannotResolve, Cancelled };
-using DNSAddressesOrError = Expected, DNSError>;
-using DNSCompletionHandler = WTF::CompletionHandler;
+using DNSAddressesOrError = Expected, DNSError>;
+using DNSCompletionHandler = CompletionHandler;
WEBCORE_EXPORT void prefetchDNS(const String& hostname);
WEBCORE_EXPORT void resolveDNS(const String& hostname, uint64_t identifier, DNSCompletionHandler&&);
WEBCORE_EXPORT void stopResolveDNS(uint64_t identifier);
+inline Optional IPAddress::fromSockAddrIn6(const struct sockaddr_in6& address)
+{
+if (address.sin6_family == AF_INET6)
+return IPAddress { address.sin6_addr };
+if (address.sin6_family == AF_INET)
+return IPAddress {reinterpret_cast(address).sin_addr };
+return { };
}
+
+}
Modified: trunk/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp (259337 => 259338)
--- trunk/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp 2020-04-01 07:54:05 UTC (rev 259337)
+++ trunk/Source/WebCore/platform/network/soup/DNSResolveQueueSoup.cpp 2020-04-01 09:08:26 UTC (rev 259338)
@@ -143,9 +143,16 @@
Vector addresses;
addresses.reserveInitialCapacity(1);
int len;
-auto* ipAddress = reinterpret_cast(soup_address_get_sockaddr(address, ));
-for (unsigned i = 0; i < sizeof(*ipAddress) / len; i++)
-addresses.uncheckedAppend(WebCore::IPAddress(ipAddress[i]));
+// FIXME: Support multiple addresses, IPv6 and IPv4.
+auto* ipAddress = soup_address_get_sockaddr(address, );
+if (ipAddress) {
+if (auto address =
[webkit-changes] [259337] trunk/Source/ThirdParty/libwebrtc
Title: [259337] trunk/Source/ThirdParty/libwebrtc
Revision 259337
Author you...@apple.com
Date 2020-04-01 00:54:05 -0700 (Wed, 01 Apr 2020)
Log Message
Use kVTVideoEncoderSpecification_RequiredLowLatency instead of kVTVideoEncoderList_EncoderID
https://bugs.webkit.org/show_bug.cgi?id=209800
Reviewed by Eric Carlson.
For recent OS versions, disable use of VCP.
Instead, use VTB compression session with kVTVideoEncoderSpecification_RequiredLowLatency set to true.
We keep MacOS code path checking frame size for public builds running on devices without hardware encoders.
* Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
(isStandardFrameSize): Deleted.
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (259336 => 259337)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-04-01 03:19:45 UTC (rev 259336)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-04-01 07:54:05 UTC (rev 259337)
@@ -1,3 +1,20 @@
+2020-04-01 Youenn Fablet
+
+Use kVTVideoEncoderSpecification_RequiredLowLatency instead of kVTVideoEncoderList_EncoderID
+https://bugs.webkit.org/show_bug.cgi?id=209800
+
+Reviewed by Eric Carlson.
+
+For recent OS versions, disable use of VCP.
+Instead, use VTB compression session with kVTVideoEncoderSpecification_RequiredLowLatency set to true.
+We keep MacOS code path checking frame size for public builds running on devices without hardware encoders.
+
+* Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
+* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+(-[RTCVideoEncoderH264 encode:codecSpecificInfo:frameTypes:]):
+(-[RTCVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
+(isStandardFrameSize): Deleted.
+
2020-03-27 youenn fablet
Bump boringssl version to M82
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h (259336 => 259337)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h 2020-04-01 03:19:45 UTC (rev 259336)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h 2020-04-01 07:54:05 UTC (rev 259337)
@@ -37,11 +37,13 @@
#define ENABLE_VCP_ENCODER 0
#define ENABLE_VCP_VTB_ENCODER 0
#elif (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
-#define ENABLE_VCP_ENCODER 1
-#define ENABLE_VCP_VTB_ENCODER __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+#define ENABLE_VCP_ENCODER __IPHONE_OS_VERSION_MIN_REQUIRED < 14
+#define ENABLE_VCP_VTB_ENCODER __IPHONE_OS_VERSION_MIN_REQUIRED >= 13 && __IPHONE_OS_VERSION_MIN_REQUIRED < 14
+#define HAVE_VTB_REQUIREDLOWLATENCY __IPHONE_OS_VERSION_MIN_REQUIRED >= 14
#elif (defined(TARGET_OS_MAC) && TARGET_OS_MAC)
-#define ENABLE_VCP_ENCODER 1
-#define ENABLE_VCP_VTB_ENCODER __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500
+#define ENABLE_VCP_ENCODER __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
+#define ENABLE_VCP_VTB_ENCODER __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500 && __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
+#define HAVE_VTB_REQUIREDLOWLATENCY __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
#endif
#endif
@@ -52,6 +54,9 @@
#if !defined(ENABLE_VCP_VTB_ENCODER)
#define ENABLE_VCP_VTB_ENCODER 0
#endif
+#if !defined(HAVE_VTB_REQUIREDLOWLATENCY)
+#define HAVE_VTB_REQUIREDLOWLATENCY 0
+#endif
#if !defined(ALWAYS_INLINE)
#define ALWAYS_INLINE inline
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (259336 => 259337)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm 2020-04-01 03:19:45 UTC (rev 259336)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm 2020-04-01 07:54:05 UTC (rev 259337)
@@ -48,7 +48,7 @@
VT_EXPORT const CFStringRef kVTVideoEncoderSpecification_Usage;
VT_EXPORT const CFStringRef kVTCompressionPropertyKey_Usage;
-#if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS) && !ENABLE_VCP_ENCODER
+#if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS) && !HAVE_VTB_REQUIREDLOWLATENCY
static inline bool isStandardFrameSize(int32_t width, int32_t height)
{
// FIXME: Envision relaxing this rule, something like width and height dividable by 4 or 8 should be good enough.
@@ -561,7 +561,7 @@
nullptr);
} else {
#if ENABLE_VCP_ENCODER
- status = webrtc::VCPCompressionSessionEncodeFrame(_vcpCompressionSession,
+
