[webkit-changes] [264747] trunk/Source
Title: [264747] trunk/Source
Revision 264747
Author jer.no...@apple.com
Date 2020-07-22 21:52:32 -0700 (Wed, 22 Jul 2020)
Log Message
[Cocoa] Add feature flag for WebM & VP9
https://bugs.webkit.org/show_bug.cgi?id=214672
Reviewed by Beth Dakin.
Source/WebKit:
* FeatureFlags/WebKit.plist:
* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultVP9DecoderEnabled):
(WebKit::defaultWebMParserEnabled):
* Shared/WebPreferencesDefaultValues.h:
Source/WTF:
* wtf/PlatformEnableCocoa.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformEnableCocoa.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/FeatureFlags/WebKit.plist
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
Diff
Modified: trunk/Source/WTF/ChangeLog (264746 => 264747)
--- trunk/Source/WTF/ChangeLog 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WTF/ChangeLog 2020-07-23 04:52:32 UTC (rev 264747)
@@ -1,3 +1,13 @@
+2020-07-22 Jer Noble
+
+[Cocoa] Add feature flag for WebM & VP9
+https://bugs.webkit.org/show_bug.cgi?id=214672
+
+
+Reviewed by Beth Dakin.
+
+* wtf/PlatformEnableCocoa.h:
+
2020-07-22 Conrad Shultz
Update macOS Version macros
Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (264746 => 264747)
--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-07-23 04:52:32 UTC (rev 264747)
@@ -530,6 +530,10 @@
#define ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN 1
#endif
+#if !defined(ENABLE_VP9) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
+#define ENABLE_VP9 1
+#endif
+
#if !defined(ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS)
#define ENABLE_WEBDRIVER_KEYBOARD_INTERACTIONS 1
#endif
Modified: trunk/Source/WebKit/ChangeLog (264746 => 264747)
--- trunk/Source/WebKit/ChangeLog 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/ChangeLog 2020-07-23 04:52:32 UTC (rev 264747)
@@ -1,3 +1,18 @@
+2020-07-22 Jer Noble
+
+[Cocoa] Add feature flag for WebM & VP9
+https://bugs.webkit.org/show_bug.cgi?id=214672
+
+
+Reviewed by Beth Dakin.
+
+* FeatureFlags/WebKit.plist:
+* Shared/WebPreferences.yaml:
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultVP9DecoderEnabled):
+(WebKit::defaultWebMParserEnabled):
+* Shared/WebPreferencesDefaultValues.h:
+
2020-07-22 Conrad Shultz
Update macOS Version macros
Modified: trunk/Source/WebKit/FeatureFlags/WebKit.plist (264746 => 264747)
--- trunk/Source/WebKit/FeatureFlags/WebKit.plist 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/FeatureFlags/WebKit.plist 2020-07-23 04:52:32 UTC (rev 264747)
@@ -47,5 +47,15 @@
Enabled
+vp9_decoder
+
+Enabled
+
+
+webm_parser
+
+Enabled
+
+
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (264746 => 264747)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-07-23 04:52:32 UTC (rev 264747)
@@ -662,20 +662,21 @@
VP9DecoderEnabled:
type: bool
- defaultValue: false
+ defaultValue: defaultVP9DecoderEnabled()
webcoreBinding: none
humanReadableName: "VP9 decoder"
humanReadableDescription: "Enable VP9 decoder"
category: experimental
+ condition: ENABLE(VP9)
WebMParserEnabled:
type: bool
- defaultValue: false
+ defaultValue: defaultWebMParserEnabled()
webcoreBinding: RuntimeEnabledFeatures
humanReadableName: "WebM MSE parser"
humanReadableDescription: "Enable WebM MSE parser"
category: experimental
- condition: ENABLE(MEDIA_SOURCE)
+ condition: ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
UseLegacyTextAlignPositionedElementBehavior:
type: bool
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (264746 => 264747)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-07-23 04:49:02 UTC (rev 264746)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-07-23 04:52:32 UTC (rev 264747)
@@ -243,4 +243,26 @@
#endif // ENABLE(WEBXR)
+#if ENABLE(VP9)
+bool defaultVP9DecoderEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+return isFeatureFlagEnabled("vp9_decoder");
+#endif
+
+return true;
+}
+#endif
+
+#if ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
+bool defaultWebMParserEnabled()
+{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
+return isFeatureFlagEnabled("webm_parser");
+#endif
+
+return true;
+}
+#endif
+
} // namespace WebKit
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (264746 => 264747)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2020-07-23 04:49:02 UTC (rev 264746)
+++
[webkit-changes] [264746] trunk
Title: [264746] trunk Revision 264746 Author conrad_shu...@apple.com Date 2020-07-22 21:49:02 -0700 (Wed, 22 Jul 2020) Log Message Update macOS Version macros https://bugs.webkit.org/show_bug.cgi?id=214653 Reviewed by Tim Horton. PerformanceTests: * MediaTime/Configurations/Base.xcconfig: * MediaTime/Configurations/DebugRelease.xcconfig: Source/bmalloc: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: Source/_javascript_Core: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Source/ThirdParty: * gtest/xcode/Config/DebugProject.xcconfig: * gtest/xcode/Config/ReleaseProject.xcconfig: Source/ThirdParty/ANGLE: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Source/ThirdParty/libwebrtc: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Source/WebCore: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Source/WebCore/PAL: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Source/WebInspectorUI: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Source/WebKit: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Source/WebKitLegacy/mac: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * Configurations/Version.xcconfig: * Configurations/WebKitTargetConditionals.xcconfig: Source/WTF: * Configurations/Base.xcconfig: * Configurations/DebugRelease.xcconfig: * wtf/PlatformHave.h: Tools: * ContentExtensionTester/Configurations/Base.xcconfig: * ContentExtensionTester/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/Configurations/Base.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * ImageDiff/cg/Configurations/Base.xcconfig: * ImageDiff/cg/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/Base.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/Base.xcconfig: * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig: * WebEditingTester/Configurations/Base.xcconfig: * WebEditingTester/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/Base.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * lldb/lldbWebKitTester/Configurations/Base.xcconfig: * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/MediaTime/Configurations/Base.xcconfig trunk/PerformanceTests/MediaTime/Configurations/DebugRelease.xcconfig trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/Base.xcconfig trunk/Source/_javascript_Core/Configurations/DebugRelease.xcconfig trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/_javascript_Core/Configurations/WebKitTargetConditionals.xcconfig trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig trunk/Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig trunk/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig trunk/Source/ThirdParty/ANGLE/Configurations/WebKitTargetConditionals.xcconfig trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig trunk/Source/ThirdParty/gtest/xcode/Config/ReleaseProject.xcconfig trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/DebugRelease.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/WebKitTargetConditionals.xcconfig trunk/Source/WTF/ChangeLog trunk/Source/WTF/Configurations/Base.xcconfig trunk/Source/WTF/Configurations/DebugRelease.xcconfig trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/Base.xcconfig trunk/Source/WebCore/Configurations/DebugRelease.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/WebKitTargetConditionals.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/Base.xcconfig trunk/Source/WebCore/PAL/Configurations/DebugRelease.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
[webkit-changes] [264745] trunk
Title: [264745] trunk Revision 264745 Author keith_mil...@apple.com Date 2020-07-22 21:20:47 -0700 (Wed, 22 Jul 2020) Log Message iOS simulator does not support WebAssembly https://bugs.webkit.org/show_bug.cgi?id=191064 Reviewed by Yusuke Suzuki. Now that it seems we can JIT in the Simulator we should enable WebAssembly there. This just means enabling FTL/B3 so WASM gets enabled. * wtf/PlatformEnable.h: * wtf/PlatformEnableCocoa.h: Modified Paths trunk/LayoutTests/platform/ios-simulator/TestExpectations trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformEnable.h trunk/Source/WTF/wtf/PlatformEnableCocoa.h Diff Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (264744 => 264745) --- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2020-07-23 04:15:24 UTC (rev 264744) +++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2020-07-23 04:20:47 UTC (rev 264745) @@ -41,27 +41,6 @@ # we explicitly disallow this because this font is too slow. fast/text/initial-advance-in-intermediate-run-complex.html [ ImageOnlyFailure ] -# Simulator doesn't support WebAssembly. -http/tests/security/contentSecurityPolicy/WebAssembly-allowed.html [ Failure ] -http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-about-blank-iframe.html [ Failure ] -http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-external-script.html [ Failure ] -http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-subframe.html [ Failure ] -http/tests/security/contentSecurityPolicy/WebAssembly-blocked.html [ Failure ] -imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.html [ Failure ] -imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-failure.https.any.serviceworker.html [ Failure ] -imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/requires-success.any.worker.html [ Failure ] -wasm/iframe-postmessage.html [ Skip ] -wasm/iframe-parent-postmessage.html [ Skip ] -wasm/window-postmessage.html [ Skip ] -imported/w3c/web-platform-tests/encoding/encodeInto.any.html [ Skip ] -imported/w3c/web-platform-tests/encoding/encodeInto.any.worker.html [ Skip ] -imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.html [ Skip ] -imported/w3c/web-platform-tests/encoding/streams/decode-utf8.any.worker.html [ Skip ] -imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.html [ Skip ] -imported/w3c/web-platform-tests/encoding/textdecoder-copy.any.worker.html [ Skip ] -imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.html [ Skip ] -imported/w3c/web-platform-tests/encoding/textdecoder-streaming.any.worker.html [ Skip ] - # These tests seem to fail due pixel rounding errors in the absolute positioned elements used as reference. webkit.org/b/170176 fast/inline-block/baseline-vertical-01.html [ ImageOnlyFailure ] webkit.org/b/170176 fast/inline-block/baseline-vertical-02.html [ ImageOnlyFailure ] Modified: trunk/Source/WTF/ChangeLog (264744 => 264745) --- trunk/Source/WTF/ChangeLog 2020-07-23 04:15:24 UTC (rev 264744) +++ trunk/Source/WTF/ChangeLog 2020-07-23 04:20:47 UTC (rev 264745) @@ -1,3 +1,17 @@ +2020-07-22 Keith Miller + +iOS simulator does not support WebAssembly +https://bugs.webkit.org/show_bug.cgi?id=191064 + +Reviewed by Yusuke Suzuki. + +Now that it seems we can JIT in the Simulator we should enable +WebAssembly there. This just means enabling FTL/B3 so WASM gets +enabled. + +* wtf/PlatformEnable.h: +* wtf/PlatformEnableCocoa.h: + 2020-07-22 Geoffrey Garen WTF::Function adoption should be explicit instead of implicit Modified: trunk/Source/WTF/wtf/PlatformEnable.h (264744 => 264745) --- trunk/Source/WTF/wtf/PlatformEnable.h 2020-07-23 04:15:24 UTC (rev 264744) +++ trunk/Source/WTF/wtf/PlatformEnable.h 2020-07-23 04:20:47 UTC (rev 264745) @@ -610,13 +610,6 @@ #define ENABLE_FTL_JIT 0 #endif -/* FIXME: This should be turned into an #error invariant */ -/* The FTL is disabled on the iOS simulator, mostly for simplicity. */ -#if PLATFORM(IOS_FAMILY_SIMULATOR) -#undef ENABLE_FTL_JIT -#define ENABLE_FTL_JIT 0 -#endif - /* If possible, try to enable a disassembler. This is optional. We proceed in two steps: first we try to find some disassembler that we can use, and then we decide if the high-level disassembler API can be enabled. */ Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (264744 => 264745) --- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-07-23 04:15:24 UTC (rev 264744) +++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2020-07-23 04:20:47 UTC (rev 264745) @@ -204,7 +204,7 @@ #define ENABLE_FILTERS_LEVEL_2 1 #endif -#if !defined(ENABLE_FTL_JIT) &&
[webkit-changes] [264744] trunk/LayoutTests
Title: [264744] trunk/LayoutTests Revision 264744 Author ryanhad...@apple.com Date 2020-07-22 21:15:24 -0700 (Wed, 22 Jul 2020) Log Message [Win10] js/weakref-finalizationregistry.html is frequently timing out https://bugs.webkit.org/show_bug.cgi?id=214673 Unreviewed test gardening. * platform/win/TestExpectations: Mark test as flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (264743 => 264744) --- trunk/LayoutTests/ChangeLog 2020-07-23 03:33:25 UTC (rev 264743) +++ trunk/LayoutTests/ChangeLog 2020-07-23 04:15:24 UTC (rev 264744) @@ -1,5 +1,14 @@ 2020-07-22 Ryan Haddad +[Win10] js/weakref-finalizationregistry.html is frequently timing out +https://bugs.webkit.org/show_bug.cgi?id=214673 + +Unreviewed test gardening. + +* platform/win/TestExpectations: Mark test as flaky. + +2020-07-22 Ryan Haddad + Unreviewed test gardening, remove old test expectation directories for iOS 12 since they are unused. * platform/ios-12/TestExpectations: Removed. Modified: trunk/LayoutTests/platform/win/TestExpectations (264743 => 264744) --- trunk/LayoutTests/platform/win/TestExpectations 2020-07-23 03:33:25 UTC (rev 264743) +++ trunk/LayoutTests/platform/win/TestExpectations 2020-07-23 04:15:24 UTC (rev 264744) @@ -4525,3 +4525,6 @@ webkit.org/b/214428 imported/mozilla/svg/blend-saturation.svg [ Failure ] storage/indexeddb/structured-clone.html [ Skip ] + +webkit.org/b/214673 js/weakref-finalizationregistry.html [ Pass Timeout ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264743] trunk/Source
Title: [264743] trunk/Source
Revision 264743
Author gga...@apple.com
Date 2020-07-22 20:33:25 -0700 (Wed, 22 Jul 2020)
Log Message
WTF::Function adoption should be explicit instead of implicit
https://bugs.webkit.org/show_bug.cgi?id=214654
Reviewed by Darin Adler.
Source/_javascript_Core:
* heap/Heap.cpp:
(JSC::Heap::LambdaFinalizerOwner::finalize): Use new adopt function.
Source/WTF:
* wtf/Function.h:
(WTF::Function
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Function.h
trunk/Source/WTF/wtf/cf/RunLoopCF.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (264742 => 264743)
--- trunk/Source/_javascript_Core/ChangeLog 2020-07-23 03:01:25 UTC (rev 264742)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-07-23 03:33:25 UTC (rev 264743)
@@ -1,3 +1,13 @@
+2020-07-22 Geoffrey Garen
+
+WTF::Function adoption should be explicit instead of implicit
+https://bugs.webkit.org/show_bug.cgi?id=214654
+
+Reviewed by Darin Adler.
+
+* heap/Heap.cpp:
+(JSC::Heap::LambdaFinalizerOwner::finalize): Use new adopt function.
+
2020-07-22 Mark Lam
Disallow VM entry when doing a VMInquiry.
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (264742 => 264743)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2020-07-23 03:01:25 UTC (rev 264742)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2020-07-23 03:33:25 UTC (rev 264743)
@@ -2428,7 +2428,7 @@
void Heap::addFinalizer(JSCell* cell, LambdaFinalizer function)
{
-WeakSet::allocate(cell, _lambdaFinalizerOwner, function.leakImpl()); // Balanced by LambdaFinalizerOwner::finalize().
+WeakSet::allocate(cell, _lambdaFinalizerOwner, function.leak()); // Balanced by LambdaFinalizerOwner::finalize().
}
void Heap::CFinalizerOwner::finalize(Handle handle, void* context)
@@ -2441,8 +2441,7 @@
void Heap::LambdaFinalizerOwner::finalize(Handle handle, void* context)
{
-LambdaFinalizer::Impl* impl = bitwise_cast(context);
-LambdaFinalizer finalizer(impl);
+auto finalizer = WTF::adopt(static_cast(context));
HandleSlot slot = handle.slot();
finalizer(slot->asCell());
WeakSet::deallocate(WeakImpl::asWeakImpl(slot));
Modified: trunk/Source/WTF/ChangeLog (264742 => 264743)
--- trunk/Source/WTF/ChangeLog 2020-07-23 03:01:25 UTC (rev 264742)
+++ trunk/Source/WTF/ChangeLog 2020-07-23 03:33:25 UTC (rev 264743)
@@ -1,3 +1,18 @@
+2020-07-22 Geoffrey Garen
+
+WTF::Function adoption should be explicit instead of implicit
+https://bugs.webkit.org/show_bug.cgi?id=214654
+
+Reviewed by Darin Adler.
+
+* wtf/Function.h:
+(WTF::Function 2020-07-22 Jer Noble
Unreviewed build fix after r264710; add a HAVE_AVPLAYER_VIDEORANGEOVERRIDE guard.
Modified: trunk/Source/WTF/wtf/Function.h (264742 => 264743)
--- trunk/Source/WTF/wtf/Function.h 2020-07-23 03:01:25 UTC (rev 264742)
+++ trunk/Source/WTF/wtf/Function.h 2020-07-23 03:33:25 UTC (rev 264743)
@@ -58,6 +58,8 @@
template class Function;
+template Function adopt(Detail::CallableWrapperBase*);
+
template
class Function {
WTF_MAKE_FAST_ALLOCATED;
@@ -66,9 +68,6 @@
Function() = default;
Function(std::nullptr_t) { }
-Function(Impl* impl)
-: m_callableWrapper(impl)
-{ }
template::value && std::is_function::type>::value) && std::is_rvalue_reference::value>::type>
Function(CallableType&& callable)
@@ -106,15 +105,28 @@
return *this;
}
-Impl* leakImpl()
+Impl* leak()
{
return m_callableWrapper.release();
}
private:
+enum AdoptTag { Adopt };
+Function(Impl* impl, AdoptTag)
+: m_callableWrapper(impl)
+{
+}
+
+friend Function adopt(Impl*);
+
std::unique_ptr m_callableWrapper;
};
+template Function adopt(Detail::CallableWrapperBase* impl)
+{
+return Function(impl, Function::Adopt);
+}
+
} // namespace WTF
using WTF::Function;
Modified: trunk/Source/WTF/wtf/cf/RunLoopCF.cpp (264742 => 264743)
--- trunk/Source/WTF/wtf/cf/RunLoopCF.cpp 2020-07-23 03:01:25 UTC (rev 264742)
+++ trunk/Source/WTF/wtf/cf/RunLoopCF.cpp 2020-07-23 03:33:25 UTC (rev 264743)
@@ -91,9 +91,9 @@
CFRunLoopTimerInvalidate(timer);
-Function function(static_cast::Impl*>(context));
+auto function = adopt(static_cast::Impl*>(context));
function();
-}, function.leakImpl());
+}, function.leak());
for (auto& schedulePair : schedulePairs)
CFRunLoopAddTimer(schedulePair->runLoop(), timer.get(), schedulePair->mode());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264742] trunk/Source/WebCore
Title: [264742] trunk/Source/WebCore
Revision 264742
Author jer.no...@apple.com
Date 2020-07-22 20:01:25 -0700 (Wed, 22 Jul 2020)
Log Message
[Cocoa|WebM] Decode error when seeking
https://bugs.webkit.org/show_bug.cgi?id=214666
Reviewed by Eric Carlson.
A decoder error is hit when seeking because we think all samples coming out of the SourceBufferParserWebM are sync-samples.
This is because the attachment added with CMSetAttachment() is ignored; the correct way to set sample attachments is by
getting the sample attachments array with CMSampleBufferGetSampleAttachmentsArray(), and then iterating over the attachments
and adding keys to the underlying mutable CFDictionary.
* platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::OnFrame):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (264741 => 264742)
--- trunk/Source/WebCore/ChangeLog 2020-07-23 01:49:25 UTC (rev 264741)
+++ trunk/Source/WebCore/ChangeLog 2020-07-23 03:01:25 UTC (rev 264742)
@@ -1,3 +1,18 @@
+2020-07-22 Jer Noble
+
+[Cocoa|WebM] Decode error when seeking
+https://bugs.webkit.org/show_bug.cgi?id=214666
+
+Reviewed by Eric Carlson.
+
+A decoder error is hit when seeking because we think all samples coming out of the SourceBufferParserWebM are sync-samples.
+This is because the attachment added with CMSetAttachment() is ignored; the correct way to set sample attachments is by
+getting the sample attachments array with CMSampleBufferGetSampleAttachmentsArray(), and then iterating over the attachments
+and adding keys to the underlying mutable CFDictionary.
+
+* platform/graphics/cocoa/SourceBufferParserWebM.cpp:
+(WebCore::SourceBufferParserWebM::OnFrame):
+
2020-07-22 Fujii Hironori
[WinCairo][32bit] JPEG2000ImageDecoder.cpp: error C2664: 'std::unique_ptr<...>::unique_ptr(...)': cannot convert argument 2 from 'void (__stdcall *)(opj_codec_t *)' to 'const _Dx &'
Modified: trunk/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp (264741 => 264742)
--- trunk/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp 2020-07-23 01:49:25 UTC (rev 264741)
+++ trunk/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp 2020-07-23 03:01:25 UTC (rev 264742)
@@ -42,6 +42,7 @@
#include
#include
#include
+#include
#include
WTF_WEAK_LINK_FORCE_IMPORT(webm::swap);
@@ -793,8 +794,16 @@
trackData->currentBlockBuffer = nullptr;
trackData->currentBlockBufferPosition = 0;
-if (!isSync)
-CMSetAttachment(sampleBuffer.get(), kCMSampleAttachmentKey_NotSync, kCFBooleanTrue, kCMAttachmentMode_ShouldPropagate);
+if (!isSync) {
+auto attachmentsArray = CMSampleBufferGetSampleAttachmentsArray(sampleBuffer.get(), true);
+ASSERT(attachmentsArray);
+if (!attachmentsArray)
+return Skip(reader, bytesRemaining);
+for (CFIndex i = 0, count = CFArrayGetCount(attachmentsArray); i < count; ++i) {
+CFMutableDictionaryRef attachments = checked_cf_cast(CFArrayGetValueAtIndex(attachmentsArray, i));
+CFDictionarySetValue(attachments, kCMSampleAttachmentKey_NotSync, kCFBooleanTrue);
+}
+}
auto trackID = track.track_uid.value();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264741] trunk/Source/WebCore
Title: [264741] trunk/Source/WebCore
Revision 264741
Author hironori.fu...@sony.com
Date 2020-07-22 18:49:25 -0700 (Wed, 22 Jul 2020)
Log Message
[WinCairo][32bit] JPEG2000ImageDecoder.cpp: error C2664: 'std::unique_ptr<...>::unique_ptr(...)': cannot convert argument 2 from 'void (__stdcall *)(opj_codec_t *)' to 'const _Dx &'
https://bugs.webkit.org/show_bug.cgi?id=214657
Reviewed by Darin Adler.
__cdecl and __stdcall calling conventions don't match.
* platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp:
(WebCore::JPEG2000ImageDecoder::decode): Use decltype for the second template argument of unique_ptr.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (264740 => 264741)
--- trunk/Source/WebCore/ChangeLog 2020-07-23 01:44:59 UTC (rev 264740)
+++ trunk/Source/WebCore/ChangeLog 2020-07-23 01:49:25 UTC (rev 264741)
@@ -1,3 +1,16 @@
+2020-07-22 Fujii Hironori
+
+[WinCairo][32bit] JPEG2000ImageDecoder.cpp: error C2664: 'std::unique_ptr<...>::unique_ptr(...)': cannot convert argument 2 from 'void (__stdcall *)(opj_codec_t *)' to 'const _Dx &'
+https://bugs.webkit.org/show_bug.cgi?id=214657
+
+Reviewed by Darin Adler.
+
+__cdecl and __stdcall calling conventions don't match.
+
+
+* platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp:
+(WebCore::JPEG2000ImageDecoder::decode): Use decltype for the second template argument of unique_ptr.
+
2020-07-22 Jon Davis
Add feature status for CSS Containment Module Level 1
Modified: trunk/Source/WebCore/platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp (264740 => 264741)
--- trunk/Source/WebCore/platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp 2020-07-23 01:44:59 UTC (rev 264740)
+++ trunk/Source/WebCore/platform/image-decoders/jpeg2000/JPEG2000ImageDecoder.cpp 2020-07-23 01:49:25 UTC (rev 264741)
@@ -360,7 +360,7 @@
if (failed())
return;
-std::unique_ptr decoder(opj_create_decompress(m_format == Format::JP2 ? OPJ_CODEC_JP2 : OPJ_CODEC_J2K), opj_destroy_codec);
+std::unique_ptr decoder(opj_create_decompress(m_format == Format::JP2 ? OPJ_CODEC_JP2 : OPJ_CODEC_J2K), opj_destroy_codec);
if (!decoder) {
setFailed();
return;
@@ -373,7 +373,7 @@
return;
}
-std::unique_ptr stream(opj_stream_default_create(OPJ_TRUE), opj_stream_destroy);
+std::unique_ptr stream(opj_stream_default_create(OPJ_TRUE), opj_stream_destroy);
if (!stream) {
setFailed();
return;
@@ -424,7 +424,7 @@
return;
}
-std::unique_ptr image(imagePtr, opj_image_destroy);
+std::unique_ptr image(imagePtr, opj_image_destroy);
setSize({ static_cast(image->x1 - image->x0), static_cast(image->y1 - image->y0) });
if (onlySize)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264740] trunk/Source/WebKit
Title: [264740] trunk/Source/WebKit
Revision 264740
Author hironori.fu...@sony.com
Date 2020-07-22 18:44:59 -0700 (Wed, 22 Jul 2020)
Log Message
[WinCairo][32bit] ConnectionWin.cpp(327): error C2664: 'BOOL RegisterWaitForSingleObject(...)': cannot convert argument 3 from 'void (__cdecl *)(...)' to 'WAITORTIMERCALLBACK'
https://bugs.webkit.org/show_bug.cgi?id=214658
Reviewed by Darin Adler.
__cdecl and __stdcall calling conventions don't match.
* Platform/IPC/Connection.h: Added WINAPI to Connection::EventListener::callback method.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Connection.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (264739 => 264740)
--- trunk/Source/WebKit/ChangeLog 2020-07-23 01:41:16 UTC (rev 264739)
+++ trunk/Source/WebKit/ChangeLog 2020-07-23 01:44:59 UTC (rev 264740)
@@ -1,3 +1,15 @@
+2020-07-22 Fujii Hironori
+
+[WinCairo][32bit] ConnectionWin.cpp(327): error C2664: 'BOOL RegisterWaitForSingleObject(...)': cannot convert argument 3 from 'void (__cdecl *)(...)' to 'WAITORTIMERCALLBACK'
+https://bugs.webkit.org/show_bug.cgi?id=214658
+
+Reviewed by Darin Adler.
+
+__cdecl and __stdcall calling conventions don't match.
+
+
+* Platform/IPC/Connection.h: Added WINAPI to Connection::EventListener::callback method.
+
2020-07-22 David Kilzer
Follow-up: [IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type
Modified: trunk/Source/WebKit/Platform/IPC/Connection.h (264739 => 264740)
--- trunk/Source/WebKit/Platform/IPC/Connection.h 2020-07-23 01:41:16 UTC (rev 264739)
+++ trunk/Source/WebKit/Platform/IPC/Connection.h 2020-07-23 01:44:59 UTC (rev 264740)
@@ -448,7 +448,7 @@
OVERLAPPED& state() { return m_state; }
private:
-static void callback(void*, BOOLEAN);
+static void WINAPI callback(void*, BOOLEAN);
OVERLAPPED m_state;
HANDLE m_waitHandle { INVALID_HANDLE_VALUE };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264739] trunk/Source/WebCore
Title: [264739] trunk/Source/WebCore
Revision 264739
Author j...@apple.com
Date 2020-07-22 18:41:16 -0700 (Wed, 22 Jul 2020)
Log Message
Add feature status for CSS Containment Module Level 1
https://bugs.webkit.org/show_bug.cgi?id=214663
Reviewed by Darin Adler.
* features.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (264738 => 264739)
--- trunk/Source/WebCore/ChangeLog 2020-07-23 01:37:19 UTC (rev 264738)
+++ trunk/Source/WebCore/ChangeLog 2020-07-23 01:41:16 UTC (rev 264739)
@@ -1,5 +1,14 @@
2020-07-22 Jon Davis
+Add feature status for CSS Containment Module Level 1
+https://bugs.webkit.org/show_bug.cgi?id=214663
+
+Reviewed by Darin Adler.
+
+* features.json:
+
+2020-07-22 Jon Davis
+
Add feature status for the focus-visible pseudo-selector
https://bugs.webkit.org/show_bug.cgi?id=214662
Modified: trunk/Source/WebCore/features.json (264738 => 264739)
--- trunk/Source/WebCore/features.json 2020-07-23 01:37:19 UTC (rev 264738)
+++ trunk/Source/WebCore/features.json 2020-07-23 01:41:16 UTC (rev 264739)
@@ -73,6 +73,17 @@
"description": "Allows content to specify colors outside of the sRGB Color Space."
},
{
+"name": "CSS Containment Level 1",
+"status": {
+"status": "Under Consideration",
+"enabled-by-default": false
+},
+"url": "https://www.w3.org/TR/css-contain-1/",
+"keywords": ["css containment", "contain", "content", "layout", "size", "paint"],
+"category": "css",
+"description": "Allows content to specify that an element’s subtree is independent of the rest of the page to allow for optimizations by the browser."
+},
+{
"name": "CSS Font Display",
"status": {
"status": "Supported",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264738] trunk/Source/WebCore
Title: [264738] trunk/Source/WebCore
Revision 264738
Author j...@apple.com
Date 2020-07-22 18:37:19 -0700 (Wed, 22 Jul 2020)
Log Message
Add feature status for the focus-visible pseudo-selector
https://bugs.webkit.org/show_bug.cgi?id=214662
Reviewed by Darin Adler.
* features.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (264737 => 264738)
--- trunk/Source/WebCore/ChangeLog 2020-07-23 00:21:14 UTC (rev 264737)
+++ trunk/Source/WebCore/ChangeLog 2020-07-23 01:37:19 UTC (rev 264738)
@@ -1,3 +1,12 @@
+2020-07-22 Jon Davis
+
+Add feature status for the focus-visible pseudo-selector
+https://bugs.webkit.org/show_bug.cgi?id=214662
+
+Reviewed by Darin Adler.
+
+* features.json:
+
2020-07-22 Wenson Hsieh
Unreviewed, update feature status for async clipboard API
Modified: trunk/Source/WebCore/features.json (264737 => 264738)
--- trunk/Source/WebCore/features.json 2020-07-23 00:21:14 UTC (rev 264737)
+++ trunk/Source/WebCore/features.json 2020-07-23 01:37:19 UTC (rev 264738)
@@ -798,6 +798,21 @@
}
},
{
+"name": "CSS Selector :focus-visible",
+"status": {
+"status": "Under Consideration",
+"enabled-by-default": false
+},
+"url": "https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo",
+"specification": "CSS Selectors Level 4",
+"description": "The selector :focus-visible matches an element that has received focus and the user-agent has determined that the focus should be made visible on the element.",
+"contact": {
+"name": "Jonathan Davis",
+"twitter": "@jonathandavis",
+"email": "web-evangel...@apple.com"
+}
+},
+{
"name": "CSS Selector :focus-within",
"status": {
"status": "Supported",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264737] trunk/Source/WebCore
Title: [264737] trunk/Source/WebCore
Revision 264737
Author wenson_hs...@apple.com
Date 2020-07-22 17:21:14 -0700 (Wed, 22 Jul 2020)
Log Message
Unreviewed, update feature status for async clipboard API
* features.json: Move from "In Development" to "Supported".
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (264736 => 264737)
--- trunk/Source/WebCore/ChangeLog 2020-07-23 00:08:50 UTC (rev 264736)
+++ trunk/Source/WebCore/ChangeLog 2020-07-23 00:21:14 UTC (rev 264737)
@@ -1,3 +1,9 @@
+2020-07-22 Wenson Hsieh
+
+Unreviewed, update feature status for async clipboard API
+
+* features.json: Move from "In Development" to "Supported".
+
2020-07-21 Mark Lam
Disallow VM entry when doing a VMInquiry.
Modified: trunk/Source/WebCore/features.json (264736 => 264737)
--- trunk/Source/WebCore/features.json 2020-07-23 00:08:50 UTC (rev 264736)
+++ trunk/Source/WebCore/features.json 2020-07-23 00:21:14 UTC (rev 264737)
@@ -14,7 +14,7 @@
{
"name": "Async Clipboard API",
"status": {
-"status": "In Development"
+"status": "Supported"
},
"url": "https://www.w3.org/TR/clipboard-apis/#async-clipboard-api",
"category": "webapps",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264736] trunk/Source
Title: [264736] trunk/Source Revision 264736 Author mark@apple.com Date 2020-07-22 17:08:50 -0700 (Wed, 22 Jul 2020) Log Message Disallow VM entry when doing a VMInquiry. https://bugs.webkit.org/show_bug.cgi?id=214624 Reviewed by Saam Barati. Source/_javascript_Core: 1. In PropertySlot's constructor, automatically install a DisallowVMEntry scope if the passed in internal method type is VMInquiry. This ensures that we won't be able to enter the VM to call JS code while doing the inquiry. As a result, the PropertySlot constructor will now take an optional VM pointer, which is must be passed in in when the internal method type is VMInquiry. Note that the handling of attempts to enter the VM depends on Options::crashOnDisallowedVMEntry(). On Debug build (due to ASSERT_ENABLED), Options::crashOnDisallowedVMEntry() defaults to true and the VM will crash on disallowed entry. On Release build, Options::crashOnDisallowedVMEntry() defaults to false and disallow entry attempts into the VM will be treated like calling an empty function that returns undefined. This is not new behavior in this patch, but I just want to have a reminder here of how DisallowVMEntry will be enforcing no entry into the VM while doing a VMInquiry. 2. After VMInquiry gets, sometimes the client code wants to do other work that do entails entering the VM. In such cases, we need to reset the PropertySlot's disallowVMEntry scope. Fixed up a few places in client code to do this reset. 3. Make the DisableVMEntry scope copyable. At least one place wants to copy PropertySlot, and as a result, will need to copy its embedded DisableVMEntry scope as well if installed. For DisableVMEntry, we'll handle copying semantics as follows: copying a DisableVMEntry will ref the VM::disallowVMEntryCount. The count will be decremented when both instances are destructed. As a result, VM entry will be disallowed as long as one of the copies are still alive. 4. For the setObjectToStringValue() method of Structure and StructureRareData, we were previously passing a PropertySlot by copy. We don't really need to do this. Ultimately, only StructureRareData::setObjectToStringValue() needs to access a few of the PropertySlot query methods. So, we changed these methods to pass a `const PropertySlot&` instead to void the needless copying. * API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::put): (JSC::JSCallbackObject::staticFunctionGetter): * heap/HeapSnapshotBuilder.cpp: (JSC::HeapSnapshotBuilder::json): * inspector/JSInjectedScriptHost.cpp: (Inspector::JSInjectedScriptHost::queryInstances): * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): * jit/JITOperations.cpp: * llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): * runtime/DisallowVMEntry.h: (JSC::DisallowVMEntryImpl::DisallowVMEntryImpl): * runtime/ErrorInstance.cpp: (JSC::ErrorInstance::sanitizedToString): * runtime/JSFunction.cpp: (JSC::JSFunction::getOwnNonIndexPropertyNames): (JSC::JSFunction::put): (JSC::JSFunction::defineOwnProperty): * runtime/JSGenericTypedArrayViewConstructorInlines.h: (JSC::constructGenericTypedArrayViewWithArguments): * runtime/JSGlobalObject.cpp: (JSC::getGetterById): (JSC::JSGlobalObject::defineOwnProperty): (JSC::JSGlobalObject::tryInstallArraySpeciesWatchpoint): * runtime/JSObject.cpp: (JSC::JSObject::calculatedClassName): * runtime/JSObjectInlines.h: (JSC::JSObject::getPrivateFieldSlot): * runtime/JSScope.cpp: (JSC::abstractAccess): * runtime/PropertySlot.h: (JSC::PropertySlot::PropertySlot): * runtime/SamplingProfiler.cpp: (JSC::SamplingProfiler::StackFrame::nameFromCallee): * runtime/Structure.h: * runtime/StructureInlines.h: (JSC::Structure::setObjectToStringValue): * runtime/StructureRareData.cpp: (JSC::StructureRareData::setObjectToStringValue): * runtime/StructureRareData.h: * tools/JSDollarVM.cpp: (JSC::functionGetGetterSetter): Source/WebCore: 1. Change binding to reset the DisallowVMEntry scope in PropertySlot after doing a VMInquiry. 2. Rebase bindings test results to match. * bindings/js/JSDOMAbstractOperations.h: (WebCore::isVisibleNamedProperty): (WebCore::accessVisibleNamedProperty): * bindings/scripts/CodeGeneratorJS.pm: (GeneratePut): (GeneratePutByIndex): (GenerateDefineOwnProperty): * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp: (WebCore::JSTestNamedAndIndexedSetterNoIdentifier::put): (WebCore::JSTestNamedAndIndexedSetterNoIdentifier::putByIndex): (WebCore::JSTestNamedAndIndexedSetterNoIdentifier::defineOwnProperty): * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp: (WebCore::JSTestNamedAndIndexedSetterThrowingException::put): (WebCore::JSTestNamedAndIndexedSetterThrowingException::putByIndex): (WebCore::JSTestNamedAndIndexedSetterThrowingException::defineOwnProperty): * bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
[webkit-changes] [264735] trunk/LayoutTests
Title: [264735] trunk/LayoutTests Revision 264735 Author ryanhad...@apple.com Date 2020-07-22 16:57:55 -0700 (Wed, 22 Jul 2020) Log Message Unreviewed test gardening, remove old test expectation directories for iOS 12 since they are unused. * platform/ios-12/TestExpectations: Removed. * platform/ios-12/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed. * platform/ios-12/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed. * platform/ios-12/css2.1/t1202-counter-09-b-expected.txt: Removed. * platform/ios-12/css2.1/t1202-counters-09-b-expected.txt: Removed. * platform/ios-12/editing/deleting/delete-emoji-1-expected.txt: Removed. * platform/ios-12/editing/deleting/delete-emoji-9-expected.txt: Removed. * platform/ios-12/editing/deleting/delete-emoji-expected.txt: Removed. * platform/ios-12/fast/css-generated-content/014-expected.txt: Removed. * platform/ios-12/fast/css/apple-system-colors-expected.txt: Removed. * platform/ios-12/fast/css/beforeSelectorOnCodeElement-expected.txt: Removed. * platform/ios-12/fast/css/line-height-font-order-expected.txt: Removed. * platform/ios-12/fast/events/touch/ios/pointer-events-with-modifiers-expected.txt: Removed. * platform/ios-12/fast/events/updateLayoutForHitTest-expected.txt: Removed. * platform/ios-12/fast/overflow/007-expected.txt: Removed. * platform/ios-12/fast/table/col-and-colgroup-offsets-expected.txt: Removed. * platform/ios-12/fast/text/hyphenate-avoid-orphaned-word-expected.txt: Removed. * platform/ios-12/fast/text/hyphenate-character-expected.txt: Removed. * platform/ios-12/fast/text/hyphens-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/cors/access-control-expose-headers-parsing.window-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/fetch/content-type/script.window-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt: Removed. * platform/ios-12/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: Removed. * platform/ios-12/platform/ios/ios/fast/text/opticalFont-expected.txt: Removed. * platform/ios-12/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt: Removed. * platform/ios-12/platform/ios/ios/fast/text/opticalFontWithWeight-expected.txt: Removed. * platform/ios-12/quicklook/excel-expected.txt: Removed. * platform/ios-12/quicklook/excel-legacy-expected.txt: Removed. * platform/ios-12/quicklook/excel-macro-enabled-expected.txt: Removed. * platform/ios-12/quicklook/keynote-09-expected.txt: Removed. * platform/ios-12/quicklook/numbers-09-expected.txt: Removed. * platform/ios-12/quicklook/pages-09-expected.txt: Removed. * platform/ios-12/quicklook/powerpoint-expected.txt: Removed. * platform/ios-12/quicklook/powerpoint-legacy-expected.txt: Removed. * platform/ios-12/svg/custom/object-sizing-expected.txt: Removed. * platform/ios-12/tables/mozilla/bugs/bug10269-2-expected.txt: Removed. * platform/ios-12/tables/mozilla/bugs/bug10296-1-expected.txt: Removed. * platform/ios-12/tables/mozilla/bugs/bug139524-2-expected.txt: Removed. * platform/ios-12/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed. * platform/ipad-12/TestExpectations: Removed. * platform/ipad-12/fast/scrolling/ios/overflow-scroll-inherited-expected.txt: Removed. * platform/ipad-12/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt: Removed. * platform/ipad-12/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt: Removed. * platform/ipad-12/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt: Removed. * platform/ipad-12/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Removed. * platform/ipad-12/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt: Removed. * platform/ipad-12/scrollingcoordinator/ios/ui-scrolling-tree-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/ios-12/ trunk/LayoutTests/platform/ipad-12/ Diff Modified: trunk/LayoutTests/ChangeLog (264734 => 264735) --- trunk/LayoutTests/ChangeLog 2020-07-22 23:52:48 UTC (rev 264734) +++ trunk/LayoutTests/ChangeLog 2020-07-22 23:57:55 UTC (rev 264735) @@ -1,3 +1,61 @@ +2020-07-22 Ryan Haddad + +Unreviewed test
[webkit-changes] [264734] trunk
Title: [264734] trunk
Revision 264734
Author eric.carl...@apple.com
Date 2020-07-22 16:52:48 -0700 (Wed, 22 Jul 2020)
Log Message
[Cocoa] canPlayType with 'codecs' parameter should never return "maybe"
https://bugs.webkit.org/show_bug.cgi?id=214621
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated existing tests and results.
* platform/graphics/MIMETypeCache.cpp:
(WebCore::MIMETypeCache::canDecodeType):
LayoutTests:
* media/media-can-play-av1-expected.txt:
* media/media-can-play-av1.html:
* media/vp9.html:
* platform/ios/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Added.
* platform/ios/media/media-can-play-av1-expected.txt: Removed.
* platform/ios/media/media-can-play-wav-audio-expected.txt: Copied from LayoutTests/platform/mac/media/media-can-play-wav-audio-expected.txt.
* platform/mac/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Added.
* platform/mac/media/media-can-play-av1-expected.txt: Removed.
* platform/mac/media/media-can-play-wav-audio-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-can-play-av1-expected.txt
trunk/LayoutTests/media/media-can-play-av1.html
trunk/LayoutTests/media/vp9.html
trunk/LayoutTests/platform/mac/media/media-can-play-wav-audio-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/MIMETypeCache.cpp
Added Paths
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt
trunk/LayoutTests/platform/ios/media/media-can-play-wav-audio-expected.txt
trunk/LayoutTests/platform/ios/media/video-source-type-params-expected.txt
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/
trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt
Removed Paths
trunk/LayoutTests/platform/ios/media/media-can-play-av1-expected.txt
trunk/LayoutTests/platform/mac/media/media-can-play-av1-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (264733 => 264734)
--- trunk/LayoutTests/ChangeLog 2020-07-22 23:38:57 UTC (rev 264733)
+++ trunk/LayoutTests/ChangeLog 2020-07-22 23:52:48 UTC (rev 264734)
@@ -1,3 +1,21 @@
+2020-07-22 Eric Carlson
+
+[Cocoa] canPlayType with 'codecs' parameter should never return "maybe"
+https://bugs.webkit.org/show_bug.cgi?id=214621
+
+
+Reviewed by Jer Noble.
+
+* media/media-can-play-av1-expected.txt:
+* media/media-can-play-av1.html:
+* media/vp9.html:
+* platform/ios/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Added.
+* platform/ios/media/media-can-play-av1-expected.txt: Removed.
+* platform/ios/media/media-can-play-wav-audio-expected.txt: Copied from LayoutTests/platform/mac/media/media-can-play-wav-audio-expected.txt.
+* platform/mac/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Added.
+* platform/mac/media/media-can-play-av1-expected.txt: Removed.
+* platform/mac/media/media-can-play-wav-audio-expected.txt:
+
2020-07-22 Kenneth Russell
[WebGL2] Implement multiple render target entry points
Modified: trunk/LayoutTests/media/media-can-play-av1-expected.txt (264733 => 264734)
--- trunk/LayoutTests/media/media-can-play-av1-expected.txt 2020-07-22 23:38:57 UTC (rev 264733)
+++ trunk/LayoutTests/media/media-can-play-av1-expected.txt 2020-07-22 23:52:48 UTC (rev 264734)
@@ -5,7 +5,7 @@
EXPECTED (video.canPlayType('video/mp4; codecs=av1') == '') OK
EXPECTED (video.canPlayType('video/webm; codecs=av1') == '') OK
-EXPECTED (video.canPlayType('video/mp4; codecs=av01.0.04M.08') == 'probably') OK
-EXPECTED (video.canPlayType('video/webm; codecs=av01.0.04M.08') == 'probably') OK
+EXPECTED (video.canPlayType('video/mp4; codecs=av01.0.04M.08') == '') OK
+EXPECTED (video.canPlayType('video/webm; codecs=av01.0.04M.08') == '') OK
END OF TEST
Modified: trunk/LayoutTests/media/media-can-play-av1.html (264733 => 264734)
--- trunk/LayoutTests/media/media-can-play-av1.html 2020-07-22 23:38:57 UTC (rev 264733)
+++ trunk/LayoutTests/media/media-can-play-av1.html 2020-07-22 23:52:48 UTC (rev 264734)
@@ -9,8 +9,8 @@
testExpected("video.canPlayType('video/mp4; codecs=av1')", "");
[webkit-changes] [264733] trunk
Title: [264733] trunk Revision 264733 Author commit-qu...@webkit.org Date 2020-07-22 16:38:57 -0700 (Wed, 22 Jul 2020) Log Message [WebGL2] Implement multiple render target entry points https://bugs.webkit.org/show_bug.cgi?id=211156 Patch by Kenneth Russell on 2020-07-22 Reviewed by Dean Jackson. Source/WebCore: Implement the drawBuffers and clearBuffer entry points. Integrate the clearBuffer APIs with preserveDrawingBuffer:false's auto-clearing. Move some auto-clearing state from WebGLRenderingContextBase to GraphicsContextGL and GraphicsContextGLOpenGL. Rename setPreserveDrawingBuffer to enablePreserveDrawingBuffer to make it clear that arbitrary changes of preserveDrawingBuffer are not supported. setPreserveDrawingBuffer was previously added for capture of preserveDrawingBuffer:false WebGL canvases. Covered by existing WebGL conformance tests and canvas capture layout tests. * Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp: (WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged): * html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::drawBuffers): (WebCore::WebGL2RenderingContext::clearBufferiv): (WebCore::WebGL2RenderingContext::clearBufferuiv): (WebCore::WebGL2RenderingContext::clearBufferfv): (WebCore::WebGL2RenderingContext::clearBufferfi): (WebCore::WebGL2RenderingContext::validateClearBuffer): (WebCore::WebGL2RenderingContext::updateBuffersToAutoClear): * html/canvas/WebGL2RenderingContext.h: * html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::drawBuffersIfNecessary): * html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::clearIfComposited): (WebCore::WebGLRenderingContextBase::enablePreserveDrawingBuffer): * html/canvas/WebGLRenderingContextBase.h: (WebCore::WebGLRenderingContextBase::setPreserveDrawingBuffer): Deleted. * platform/graphics/GraphicsContextGL.cpp: (WebCore::GraphicsContextGL::enablePreserveDrawingBuffer): * platform/graphics/GraphicsContextGL.h: * platform/graphics/angle/GraphicsContextGLANGLE.cpp: (WebCore::GraphicsContextGLOpenGL::markLayerComposited): (WebCore::GraphicsContextGLOpenGL::drawBuffers): (WebCore::GraphicsContextGLOpenGL::clearBufferiv): (WebCore::GraphicsContextGLOpenGL::clearBufferuiv): (WebCore::GraphicsContextGLOpenGL::clearBufferfv): (WebCore::GraphicsContextGLOpenGL::clearBufferfi): * platform/graphics/opengl/GraphicsContextGLOpenGL.cpp: (WebCore::GraphicsContextGLOpenGL::resetBuffersToAutoClear): (WebCore::GraphicsContextGLOpenGL::setBuffersToAutoClear): (WebCore::GraphicsContextGLOpenGL::getBuffersToAutoClear const): (WebCore::GraphicsContextGLOpenGL::enablePreserveDrawingBuffer): * platform/graphics/opengl/GraphicsContextGLOpenGL.h: * platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp: (WebCore::GraphicsContextGLOpenGL::markLayerComposited): (WebCore::GraphicsContextGLOpenGL::drawBuffers): LayoutTests: Rebaseline one layout test which is now fully passing, and another which now properly detects errors. * fast/canvas/webgl/webgl2/sequences-expected.txt: * webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt trunk/LayoutTests/webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h trunk/Source/WebCore/html/canvas/WebGLFramebuffer.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h trunk/Source/WebCore/platform/graphics/GraphicsContextGL.cpp trunk/Source/WebCore/platform/graphics/GraphicsContextGL.h trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp Diff Modified: trunk/LayoutTests/ChangeLog (264732 => 264733) --- trunk/LayoutTests/ChangeLog 2020-07-22 23:36:22 UTC (rev 264732) +++ trunk/LayoutTests/ChangeLog 2020-07-22 23:38:57 UTC (rev 264733) @@ -1,3 +1,16 @@ +2020-07-22 Kenneth Russell + +[WebGL2] Implement multiple render target entry points +https://bugs.webkit.org/show_bug.cgi?id=211156 + +Reviewed by Dean Jackson. + +Rebaseline one layout test which is now fully passing, and another +which now properly detects errors. + +* fast/canvas/webgl/webgl2/sequences-expected.txt: +* webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt: + 2020-07-22 Karl Rackler [ macOS debug wk2 ] Set expectation for imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events.html is a flaky
[webkit-changes] [264732] trunk/Source/WebKit
Title: [264732] trunk/Source/WebKit
Revision 264732
Author ddkil...@apple.com
Date 2020-07-22 16:36:22 -0700 (Wed, 22 Jul 2020)
Log Message
Follow-up: [IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type
Unreviewed fix to get rid of extra namespace blocks.
* Shared/mac/ObjCObjectGraph.mm:
(enum class WebKit::ObjCType):
- Move enum class definition back to its original location.
(WTF::EnumTraits):
- Move to the end of the file. Noticed this worked in
ColorSpaceData.mm.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (264731 => 264732)
--- trunk/Source/WebKit/ChangeLog 2020-07-22 22:31:05 UTC (rev 264731)
+++ trunk/Source/WebKit/ChangeLog 2020-07-22 23:36:22 UTC (rev 264732)
@@ -1,5 +1,20 @@
2020-07-22 David Kilzer
+Follow-up: [IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type
+
+
+
+Unreviewed fix to get rid of extra namespace blocks.
+
+* Shared/mac/ObjCObjectGraph.mm:
+(enum class WebKit::ObjCType):
+- Move enum class definition back to its original location.
+(WTF::EnumTraits):
+- Move to the end of the file. Noticed this worked in
+ ColorSpaceData.mm.
+
+2020-07-22 David Kilzer
+
[IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type
Modified: trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm (264731 => 264732)
--- trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm 2020-07-22 22:31:05 UTC (rev 264731)
+++ trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm 2020-07-22 23:36:22 UTC (rev 264732)
@@ -38,43 +38,6 @@
namespace WebKit {
-enum class ObjCType : uint8_t {
-Null,
-
-NSArray,
-NSData,
-NSDate,
-NSDictionary,
-NSNumber,
-NSString,
-
-WKBrowsingContextHandle,
-WKTypeRefWrapper,
-};
-
-} // namespace WebKit
-
-namespace WTF {
-
-template<> struct EnumTraits {
-using values = EnumValues<
-WebKit::ObjCType,
-WebKit::ObjCType::Null,
-WebKit::ObjCType::NSArray,
-WebKit::ObjCType::NSData,
-WebKit::ObjCType::NSDate,
-WebKit::ObjCType::NSDictionary,
-WebKit::ObjCType::NSNumber,
-WebKit::ObjCType::NSString,
-WebKit::ObjCType::WKBrowsingContextHandle,
-WebKit::ObjCType::WKTypeRefWrapper
->;
-};
-
-} // namespace WTF
-
-namespace WebKit {
-
static bool shouldTransformGraph(id object, const ObjCObjectGraph::Transformer& transformer)
{
if (NSArray *array = dynamic_objc_cast(object)) {
@@ -132,6 +95,20 @@
return transformGraph(object, transformer);
}
+enum class ObjCType : uint8_t {
+Null,
+
+NSArray,
+NSData,
+NSDate,
+NSDictionary,
+NSNumber,
+NSString,
+
+WKBrowsingContextHandle,
+WKTypeRefWrapper,
+};
+
static Optional typeFromObject(id object)
{
ASSERT(object);
@@ -370,3 +347,22 @@
}
} // namespace WebKit
+
+namespace WTF {
+
+template<> struct EnumTraits {
+using values = EnumValues<
+WebKit::ObjCType,
+WebKit::ObjCType::Null,
+WebKit::ObjCType::NSArray,
+WebKit::ObjCType::NSData,
+WebKit::ObjCType::NSDate,
+WebKit::ObjCType::NSDictionary,
+WebKit::ObjCType::NSNumber,
+WebKit::ObjCType::NSString,
+WebKit::ObjCType::WKBrowsingContextHandle,
+WebKit::ObjCType::WKTypeRefWrapper
+>;
+};
+
+} // namespace WTF
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264731] trunk/LayoutTests/ChangeLog
Title: [264731] trunk/LayoutTests/ChangeLog Revision 264731 Author rack...@apple.com Date 2020-07-22 15:31:05 -0700 (Wed, 22 Jul 2020) Log Message [ macOS debug wk2 ] Set expectation for imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events.html is a flaky crash. https://bugs.webkit.org/show_bug.cgi?id=214661 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (264730 => 264731) --- trunk/LayoutTests/ChangeLog 2020-07-22 22:22:49 UTC (rev 264730) +++ trunk/LayoutTests/ChangeLog 2020-07-22 22:31:05 UTC (rev 264731) @@ -1,7 +1,7 @@ 2020-07-22 Karl Rackler [ macOS debug wk2 ] Set expectation for imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events.html is a flaky crash. -webkit.org/b/214661 +https://bugs.webkit.org/show_bug.cgi?id=214661 Unreviewed test gardening. @@ -23,7 +23,7 @@ 2020-07-22 Karl Rackler [ macOS debug wk2 ] Set test expectation for tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html as it is flaky crash -webkkit.org/b/214651 +https://bugs.webkit.org/show_bug.cgi?id=214651 Unreviewed test gardening. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264730] trunk/LayoutTests
Title: [264730] trunk/LayoutTests Revision 264730 Author rack...@apple.com Date 2020-07-22 15:22:49 -0700 (Wed, 22 Jul 2020) Log Message [ macOS debug wk2 ] Set expectation for imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events.html is a flaky crash. webkit.org/b/214661 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (264729 => 264730) --- trunk/LayoutTests/ChangeLog 2020-07-22 22:10:20 UTC (rev 264729) +++ trunk/LayoutTests/ChangeLog 2020-07-22 22:22:49 UTC (rev 264730) @@ -1,3 +1,12 @@ +2020-07-22 Karl Rackler + +[ macOS debug wk2 ] Set expectation for imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events.html is a flaky crash. +webkit.org/b/214661 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-07-22 Fujii Hironori [Win][Uniscribe] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart @@ -13,8 +22,8 @@ 2020-07-22 Karl Rackler -Set test expectation for tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html as it is flaky crash -https://bugs.webkit.org/show_bug.cgi?id=214651 +[ macOS debug wk2 ] Set test expectation for tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html as it is flaky crash +webkkit.org/b/214651 Unreviewed test gardening. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (264729 => 264730) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-07-22 22:10:20 UTC (rev 264729) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-07-22 22:22:49 UTC (rev 264730) @@ -1080,3 +1080,5 @@ webkit.org/b/214579 [ Release ] svg/animations/smil-leak-element-instances.svg [ Pass Failure ] webkkit.org/b/214651 [ Debug ] tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html [ Pass Crash ] + +webkit.org/b/214661 [ Debug ] imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264729] trunk
Title: [264729] trunk
Revision 264729
Author wenson_hs...@apple.com
Date 2020-07-22 15:10:20 -0700 (Wed, 22 Jul 2020)
Log Message
Article headlines are split across multiple lines after translating tagesschau.de
https://bugs.webkit.org/show_bug.cgi?id=214652
Reviewed by Tim Horton.
Source/WebCore:
Treat block-level heading elements (`h1` through `h6`) as item boundaries. On this website, we currently vend
the main heading and sub-heading as separate tokens in the same item, which sometimes causes the machine
translation framework to try and rearrange and split tokens, since it treats the combination of the main heading
and sub-heading text as a single sentence to be translated.
Test: TextManipulation.StartTextManipulationExtractsHeadingElementsAsSeparateItems
* editing/TextManipulationController.cpp:
(WebCore::isEnclosingItemBoundaryElement):
Tools:
Adds a new API test (a reduced version of article headlines from the front page of tagesschau.de).
* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextManipulationController.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (264728 => 264729)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 21:55:03 UTC (rev 264728)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 22:10:20 UTC (rev 264729)
@@ -1,3 +1,21 @@
+2020-07-22 Wenson Hsieh
+
+Article headlines are split across multiple lines after translating tagesschau.de
+https://bugs.webkit.org/show_bug.cgi?id=214652
+
+
+Reviewed by Tim Horton.
+
+Treat block-level heading elements (`h1` through `h6`) as item boundaries. On this website, we currently vend
+the main heading and sub-heading as separate tokens in the same item, which sometimes causes the machine
+translation framework to try and rearrange and split tokens, since it treats the combination of the main heading
+and sub-heading text as a single sentence to be translated.
+
+Test: TextManipulation.StartTextManipulationExtractsHeadingElementsAsSeparateItems
+
+* editing/TextManipulationController.cpp:
+(WebCore::isEnclosingItemBoundaryElement):
+
2020-07-22 Alex Christensen
Safari does not present CertificateInfo for service-worker served documents
Modified: trunk/Source/WebCore/editing/TextManipulationController.cpp (264728 => 264729)
--- trunk/Source/WebCore/editing/TextManipulationController.cpp 2020-07-22 21:55:03 UTC (rev 264728)
+++ trunk/Source/WebCore/editing/TextManipulationController.cpp 2020-07-22 22:10:20 UTC (rev 264729)
@@ -316,6 +316,10 @@
if (element.hasTagName(HTMLNames::spanTag) && displayType == DisplayType::InlineBlock)
return true;
+if (displayType == DisplayType::Block && (element.hasTagName(HTMLNames::h1Tag) || element.hasTagName(HTMLNames::h2Tag) || element.hasTagName(HTMLNames::h3Tag)
+|| element.hasTagName(HTMLNames::h4Tag) || element.hasTagName(HTMLNames::h5Tag) || element.hasTagName(HTMLNames::h6Tag)))
+return true;
+
return false;
}
Modified: trunk/Tools/ChangeLog (264728 => 264729)
--- trunk/Tools/ChangeLog 2020-07-22 21:55:03 UTC (rev 264728)
+++ trunk/Tools/ChangeLog 2020-07-22 22:10:20 UTC (rev 264729)
@@ -1,3 +1,15 @@
+2020-07-22 Wenson Hsieh
+
+Article headlines are split across multiple lines after translating tagesschau.de
+https://bugs.webkit.org/show_bug.cgi?id=214652
+
+
+Reviewed by Tim Horton.
+
+Adds a new API test (a reduced version of article headlines from the front page of tagesschau.de).
+
+* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
+
2020-07-22 Alex Christensen
Safari does not present CertificateInfo for service-worker served documents
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm (264728 => 264729)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm 2020-07-22 21:55:03 UTC (rev 264728)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm 2020-07-22 22:10:20 UTC (rev 264729)
@@ -1092,6 +1092,35 @@
TestWebKitAPI::Util::run();
}
+TEST(TextManipulation, StartTextManipulationExtractsHeadingElementsAsSeparateItems)
+{
+auto delegate = adoptNS([[TextManipulationDelegate alloc] init]);
+auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 400, 400)]);
+[webView _setTextManipulationDelegate:delegate.get()];
+
+[webView synchronouslyLoadHTMLString:@""
+""
+" "
+""
+"Hello world"
+"This is a heading"
+" "
+""];
+
+done = false;
+[webView _startTextManipulationsWithConfiguration:nil completion:^{
+done = true;
+}];
+TestWebKitAPI::Util::run();
+
+auto items = [delegate items];
+
[webkit-changes] [264728] tags/Safari-610.1.23/
Title: [264728] tags/Safari-610.1.23/ Revision 264728 Author alanc...@apple.com Date 2020-07-22 14:55:03 -0700 (Wed, 22 Jul 2020) Log Message Tag Safari-610.1.23. Added Paths tags/Safari-610.1.23/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264727] trunk/Source/WebCore/PAL
Title: [264727] trunk/Source/WebCore/PAL Revision 264727 Author cdu...@apple.com Date 2020-07-22 14:28:12 -0700 (Wed, 22 Jul 2020) Log Message Unreviewed attempt to fix internal build with very recent SDKs. * pal/spi/cocoa/LaunchServicesSPI.h: Modified Paths trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h Diff Modified: trunk/Source/WebCore/PAL/ChangeLog (264726 => 264727) --- trunk/Source/WebCore/PAL/ChangeLog 2020-07-22 21:15:34 UTC (rev 264726) +++ trunk/Source/WebCore/PAL/ChangeLog 2020-07-22 21:28:12 UTC (rev 264727) @@ -1,3 +1,9 @@ +2020-07-22 Chris Dumez + +Unreviewed attempt to fix internal build with very recent SDKs. + +* pal/spi/cocoa/LaunchServicesSPI.h: + 2020-07-22 Jer Noble Unreviewed build fix after r264710; add a HAVE_AVPLAYER_VIDEORANGEOVERRIDE guard. Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h (264726 => 264727) --- trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h 2020-07-22 21:15:34 UTC (rev 264726) +++ trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h 2020-07-22 21:28:12 UTC (rev 264727) @@ -88,7 +88,7 @@ #if HAVE(LSDATABASECONTEXT) #if __has_include() #import -#else +#elif !USE(APPLE_INTERNAL_SDK) @interface LSDatabaseContext (WebKitChangeTracking) - (id )addDatabaseChangeObserver4WebKit:(void (^)(xpc_object_t change))observer; - (void)removeDatabaseChangeObserver4WebKit:(id )token; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264726] branches/safari-610.1.22.0-branch/Source
Title: [264726] branches/safari-610.1.22.0-branch/Source Revision 264726 Author alanc...@apple.com Date 2020-07-22 14:15:34 -0700 (Wed, 22 Jul 2020) Log Message Versioning. WebKit-610.1.22.0.2 Modified Paths branches/safari-610.1.22.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-610.1.22.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-610.1.22.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-610.1.22.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-610.1.22.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-610.1.22.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-610.1.22.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-610.1.22.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-610.1.22.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (264725 => 264726) --- branches/safari-610.1.22.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-07-22 21:01:41 UTC (rev 264725) +++ branches/safari-610.1.22.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-07-22 21:15:34 UTC (rev 264726) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 22; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.22.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (264725 => 264726) --- branches/safari-610.1.22.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-07-22 21:01:41 UTC (rev 264725) +++ branches/safari-610.1.22.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-07-22 21:15:34 UTC (rev 264726) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 22; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.22.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (264725 => 264726) --- branches/safari-610.1.22.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-07-22 21:01:41 UTC (rev 264725) +++ branches/safari-610.1.22.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-07-22 21:15:34 UTC (rev 264726) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 22; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.22.0-branch/Source/WebCore/Configurations/Version.xcconfig (264725 => 264726) --- branches/safari-610.1.22.0-branch/Source/WebCore/Configurations/Version.xcconfig 2020-07-22 21:01:41 UTC (rev 264725) +++ branches/safari-610.1.22.0-branch/Source/WebCore/Configurations/Version.xcconfig 2020-07-22 21:15:34 UTC (rev 264726) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 22; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.22.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (264725 => 264726) --- branches/safari-610.1.22.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-07-22 21:01:41 UTC (rev 264725) +++ branches/safari-610.1.22.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-07-22 21:15:34 UTC (rev 264726) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 22; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.1.22.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (264725 => 264726) --- branches/safari-610.1.22.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-07-22 21:01:41 UTC (rev 264725) +++ branches/safari-610.1.22.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-07-22 21:15:34 UTC (rev 264726) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 22; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION =
[webkit-changes] [264725] trunk/LayoutTests
Title: [264725] trunk/LayoutTests Revision 264725 Author rack...@apple.com Date 2020-07-22 14:01:41 -0700 (Wed, 22 Jul 2020) Log Message Set test expectation for tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html as it is flaky crash https://bugs.webkit.org/show_bug.cgi?id=214651 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (264724 => 264725) --- trunk/LayoutTests/ChangeLog 2020-07-22 20:17:52 UTC (rev 264724) +++ trunk/LayoutTests/ChangeLog 2020-07-22 21:01:41 UTC (rev 264725) @@ -11,6 +11,15 @@ containing only 0-9, underscore, 'a' and U+E000 glyphs. U+E000 has a ligature string "0_a". +2020-07-22 Karl Rackler + +Set test expectation for tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html as it is flaky crash +https://bugs.webkit.org/show_bug.cgi?id=214651 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-07-22 Simon Fraser compositing/repaint/iframes/compositing-iframe-scroll-repaint.html fails on Mojave Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (264724 => 264725) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-07-22 20:17:52 UTC (rev 264724) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-07-22 21:01:41 UTC (rev 264725) @@ -1078,3 +1078,5 @@ webkit.org/b/214574 [ Release ] svg/animations/smil-leak-list-property-instances.svg [ Pass Failure ] webkit.org/b/214579 [ Release ] svg/animations/smil-leak-element-instances.svg [ Pass Failure ] + +webkkit.org/b/214651 [ Debug ] tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264724] trunk
Title: [264724] trunk Revision 264724 Author achristen...@apple.com Date 2020-07-22 13:17:52 -0700 (Wed, 22 Jul 2020) Log Message Safari does not present CertificateInfo for service-worker served documents https://bugs.webkit.org/show_bug.cgi?id=206403 Reviewed by Darin Adler and Youenn Fablet. Source/WebCore: When loading a service worker _javascript_ resource, we need to tell the network process to include certificate info with the response. We then pass that response to the ServiceWorkerContextData for storage. When the service worker generates responses to fetches, use that certificate chain for WKWebView.serverTrust when the page is committed. Covered by updating a test I wrote in r264687. * platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::setCertificateInfo): * platform/network/cf/CertificateInfo.h: * platform/network/cf/CertificateInfoCFNet.cpp: (WebCore::CertificateInfo::isolatedCopy const): * platform/network/soup/CertificateInfo.h: (WebCore::CertificateInfo::isolatedCopy const): * workers/Worker.cpp: (WebCore::Worker::create): * workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::didReceiveResponse): * workers/WorkerScriptLoader.h: (WebCore::WorkerScriptLoader::certificateInfo const): * workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::jobFinishedLoadingScript): * workers/service/ServiceWorkerContainer.h: * workers/service/ServiceWorkerContextData.cpp: (WebCore::ServiceWorkerContextData::isolatedCopy const): * workers/service/ServiceWorkerContextData.h: (WebCore::ServiceWorkerContextData::encode const): (WebCore::ServiceWorkerContextData::decode): * workers/service/ServiceWorkerFetchResult.h: (WebCore::ServiceWorkerFetchResult::isolatedCopy const): (WebCore::serviceWorkerFetchError): (WebCore::ServiceWorkerFetchResult::encode const): (WebCore::ServiceWorkerFetchResult::decode): * workers/service/ServiceWorkerGlobalScope.h: * workers/service/ServiceWorkerJob.cpp: (WebCore::ServiceWorkerJob::fetchScriptWithContext): (WebCore::ServiceWorkerJob::notifyFinished): * workers/service/ServiceWorkerJobClient.h: * workers/service/context/ServiceWorkerFetch.cpp: (WebCore::ServiceWorkerFetch::processResponse): (WebCore::ServiceWorkerFetch::dispatchFetchEvent): * workers/service/server/RegistrationDatabase.cpp: (WebCore::RegistrationDatabase::importRecords): * workers/service/server/SWServer.cpp: (WebCore::SWServer::addRegistrationFromStore): Also fix a possible use-after-move bug, depending on parameter evaluation order which is undefined behavior. (WebCore::SWServer::updateWorker): (WebCore::SWServer::installContextData): * workers/service/server/SWServer.h: * workers/service/server/SWServerJobQueue.cpp: (WebCore::SWServerJobQueue::scriptFetchFinished): * workers/service/server/SWServerWorker.cpp: (WebCore::SWServerWorker::SWServerWorker): (WebCore::SWServerWorker::contextData const): * workers/service/server/SWServerWorker.h: Tools: * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/ResourceResponseBase.h trunk/Source/WebCore/platform/network/cf/CertificateInfo.h trunk/Source/WebCore/platform/network/soup/CertificateInfo.h trunk/Source/WebCore/workers/WorkerScriptLoader.cpp trunk/Source/WebCore/workers/WorkerScriptLoader.h trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h trunk/Source/WebCore/workers/service/ServiceWorkerContextData.cpp trunk/Source/WebCore/workers/service/ServiceWorkerContextData.h trunk/Source/WebCore/workers/service/ServiceWorkerFetchResult.h trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp trunk/Source/WebCore/workers/service/ServiceWorkerJobClient.h trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp trunk/Source/WebCore/workers/service/server/RegistrationDatabase.cpp trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebCore/workers/service/server/SWServer.h trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp trunk/Source/WebCore/workers/service/server/SWServerWorker.h trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3 trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm Diff Modified: trunk/Source/WebCore/ChangeLog (264723 => 264724) --- trunk/Source/WebCore/ChangeLog 2020-07-22 20:16:00 UTC (rev 264723) +++ trunk/Source/WebCore/ChangeLog 2020-07-22 20:17:52 UTC (rev 264724) @@ -1,3 +1,67 @@
[webkit-changes] [264723] trunk/Source/WebCore
Title: [264723] trunk/Source/WebCore
Revision 264723
Author ddkil...@apple.com
Date 2020-07-22 13:16:00 -0700 (Wed, 22 Jul 2020)
Log Message
Unreviewed build fix after r264710, r264719, r264721: use more HAVE_AVPLAYER_VIDEORANGEOVERRIDE.
* platform/PlatformScreen.h:
* platform/mac/PlatformScreenMac.mm:
(WebCore::collectScreenProperties):
- Guard more code with HAVE(AVPLAYER_VIDEORANGEOVERRIDE).
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformScreen.h
trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (264722 => 264723)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 20:04:21 UTC (rev 264722)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 20:16:00 UTC (rev 264723)
@@ -1,3 +1,12 @@
+2020-07-22 David Kilzer
+
+Unreviewed build fix after r264710, r264719, r264721: use more HAVE_AVPLAYER_VIDEORANGEOVERRIDE.
+
+* platform/PlatformScreen.h:
+* platform/mac/PlatformScreenMac.mm:
+(WebCore::collectScreenProperties):
+- Guard more code with HAVE(AVPLAYER_VIDEORANGEOVERRIDE).
+
2020-07-22 Fujii Hironori
[Win][Uniscribe] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart
Modified: trunk/Source/WebCore/platform/PlatformScreen.h (264722 => 264723)
--- trunk/Source/WebCore/platform/PlatformScreen.h 2020-07-22 20:04:21 UTC (rev 264722)
+++ trunk/Source/WebCore/platform/PlatformScreen.h 2020-07-22 20:16:00 UTC (rev 264723)
@@ -88,7 +88,7 @@
HDR10,
DolbyVisionPQ,
};
-#if PLATFORM(MAC)
+#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE)
WEBCORE_EXPORT DynamicRangeMode preferredDynamicRangeMode(Widget* = nullptr);
#else
constexpr DynamicRangeMode preferredDynamicRangeMode(Widget* = nullptr) { return DynamicRangeMode::Standard; }
Modified: trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm (264722 => 264723)
--- trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm 2020-07-22 20:04:21 UTC (rev 264722)
+++ trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm 2020-07-22 20:16:00 UTC (rev 264723)
@@ -98,6 +98,7 @@
return screen(displayID(widget));
}
+#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE)
static DynamicRangeMode convertAVVideoRangeToEnum(NSString* range)
{
if (!range)
@@ -114,6 +115,7 @@
ASSERT_NOT_REACHED();
return DynamicRangeMode::None;
}
+#endif
ScreenProperties collectScreenProperties()
{
@@ -140,12 +142,17 @@
float scaleFactor = screen.backingScaleFactor;
DynamicRangeMode dynamicRangeMode = DynamicRangeMode::None;
+#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE)
if (PAL::isAVFoundationFrameworkAvailable() && [PAL::getAVPlayerClass() respondsToSelector:@selector(preferredVideoRangeForDisplays:)]) {
dynamicRangeMode = convertAVVideoRangeToEnum([PAL::getAVPlayerClass() preferredVideoRangeForDisplays:@[ @(displayID) ]]);
screenSupportsHighDynamicRange = dynamicRangeMode > DynamicRangeMode::Standard;
}
+#endif
+#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE) && USE(MEDIATOOLBOX)
+else
+#endif
#if USE(MEDIATOOLBOX)
-else if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
+if (PAL::isMediaToolboxFrameworkAvailable() && PAL::canLoad_MediaToolbox_MTShouldPlayHDRVideo())
screenSupportsHighDynamicRange = PAL::softLink_MediaToolbox_MTShouldPlayHDRVideo((__bridge CFArrayRef)@[ @(displayID) ]);
#endif
@@ -368,6 +375,7 @@
return false;
}
+#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE)
DynamicRangeMode preferredDynamicRangeMode(Widget* widget)
{
if (auto data = ""
@@ -381,6 +389,7 @@
return DynamicRangeMode::Standard;
}
+#endif
FloatRect toUserSpace(const NSRect& rect, NSWindow *destination)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264722] trunk
Title: [264722] trunk
Revision 264722
Author hironori.fu...@sony.com
Date 2020-07-22 13:04:21 -0700 (Wed, 22 Jul 2020)
Log Message
[Win][Uniscribe] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart
https://bugs.webkit.org/show_bug.cgi?id=201214
Reviewed by Don Olmstead.
Source/WebCore:
ScriptItemize split "3d_rotation" into "3", "d", "_" and
"rotation". It has a option fMergeNeutralItems to control it.
Test: fonts/ligature.html
* platform/graphics/win/ComplexTextControllerUniscribe.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
Set fMergeNeutralItems of SCRIPT_CONTROL true.
LayoutTests:
* fonts/ligature-expected.html: Added.
* fonts/ligature.html: Added.
* fonts/ligature.woff: Added. Created a font for testing ligature
containing only 0-9, underscore, 'a' and U+E000 glyphs. U+E000 has
a ligature string "0_a".
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp
Added Paths
trunk/LayoutTests/fonts/ligature-expected.html
trunk/LayoutTests/fonts/ligature.html
trunk/LayoutTests/fonts/ligature.woff
Diff
Modified: trunk/LayoutTests/ChangeLog (264721 => 264722)
--- trunk/LayoutTests/ChangeLog 2020-07-22 19:58:53 UTC (rev 264721)
+++ trunk/LayoutTests/ChangeLog 2020-07-22 20:04:21 UTC (rev 264722)
@@ -1,3 +1,16 @@
+2020-07-22 Fujii Hironori
+
+[Win][Uniscribe] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart
+https://bugs.webkit.org/show_bug.cgi?id=201214
+
+Reviewed by Don Olmstead.
+
+* fonts/ligature-expected.html: Added.
+* fonts/ligature.html: Added.
+* fonts/ligature.woff: Added. Created a font for testing ligature
+containing only 0-9, underscore, 'a' and U+E000 glyphs. U+E000 has
+a ligature string "0_a".
+
2020-07-22 Simon Fraser
compositing/repaint/iframes/compositing-iframe-scroll-repaint.html fails on Mojave
Added: trunk/LayoutTests/fonts/ligature-expected.html (0 => 264722)
--- trunk/LayoutTests/fonts/ligature-expected.html (rev 0)
+++ trunk/LayoutTests/fonts/ligature-expected.html 2020-07-22 20:04:21 UTC (rev 264722)
@@ -0,0 +1,19 @@
+
+
+
+@font-face {
+font-family: TestFont;
+src: url("ligature.woff");
+}
+span {
+border: blue solid;
+font-family: TestFont;
+text-rendering: optimizeLegibility;
+font-size: 100px;
+color: green;
+}
+
+
+The blue box should contain ▲■■▲.
+0a
+
Property changes on: trunk/LayoutTests/fonts/ligature-expected.html
___
Added: svn:executable
+*
\ No newline at end of property
Added: trunk/LayoutTests/fonts/ligature.html (0 => 264722)
--- trunk/LayoutTests/fonts/ligature.html (rev 0)
+++ trunk/LayoutTests/fonts/ligature.html 2020-07-22 20:04:21 UTC (rev 264722)
@@ -0,0 +1,19 @@
+
+
+
+@font-face {
+font-family: TestFont;
+src: url("ligature.woff");
+}
+span {
+border: blue solid;
+font-family: TestFont;
+text-rendering: optimizeLegibility;
+font-size: 100px;
+color: green;
+}
+
+
+The blue box should contain ▲■■▲.
+00_a0_aa
+
Property changes on: trunk/LayoutTests/fonts/ligature.html
___
Added: svn:executable
+*
\ No newline at end of property
Added: trunk/LayoutTests/fonts/ligature.woff
(Binary files differ)
Index: trunk/LayoutTests/fonts/ligature.woff
===
--- trunk/LayoutTests/fonts/ligature.woff 2020-07-22 19:58:53 UTC (rev 264721)
+++ trunk/LayoutTests/fonts/ligature.woff 2020-07-22 20:04:21 UTC (rev 264722)
Property changes on: trunk/LayoutTests/fonts/ligature.woff
___
Added: svn:executable
+*
\ No newline at end of property
Added: svn:mime-type
+application/octet-stream
\ No newline at end of property
Modified: trunk/Source/WebCore/ChangeLog (264721 => 264722)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 19:58:53 UTC (rev 264721)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 20:04:21 UTC (rev 264722)
@@ -1,3 +1,19 @@
+2020-07-22 Fujii Hironori
+
+[Win][Uniscribe] Material icons containing underscore or numbers aren't shown because ScriptItemize splits them apart
+https://bugs.webkit.org/show_bug.cgi?id=201214
+
+Reviewed by Don Olmstead.
+
+ScriptItemize split "3d_rotation" into "3", "d", "_" and
+"rotation". It has a option fMergeNeutralItems to control it.
+
+Test: fonts/ligature.html
+
+* platform/graphics/win/ComplexTextControllerUniscribe.cpp:
+
[webkit-changes] [264721] trunk/Source/WebCore
Title: [264721] trunk/Source/WebCore
Revision 264721
Author jer.no...@apple.com
Date 2020-07-22 12:58:53 -0700 (Wed, 22 Jul 2020)
Log Message
Further unreviewed build fix after r264710; need more HAVE_AVPLAYER_VIDEORANGEOVERRIDE guards.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (264720 => 264721)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 19:33:10 UTC (rev 264720)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 19:58:53 UTC (rev 264721)
@@ -1,5 +1,11 @@
2020-07-22 Jer Noble
+Further unreviewed build fix after r264710; need more HAVE_AVPLAYER_VIDEORANGEOVERRIDE guards.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+
+2020-07-22 Jer Noble
+
Unreviewed build fix after r264710; add a HAVE_AVPLAYER_VIDEORANGEOVERRIDE guard.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (264720 => 264721)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2020-07-22 19:33:10 UTC (rev 264720)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2020-07-22 19:58:53 UTC (rev 264721)
@@ -877,6 +877,7 @@
});
}
+#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE)
static NSString* convertDynamicRangeModeEnumToAVVideoRange(DynamicRangeMode mode)
{
switch (mode) {
@@ -895,6 +896,7 @@
ASSERT_NOT_REACHED();
return nil;
}
+#endif
void MediaPlayerPrivateAVFoundationObjC::createAVPlayer()
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264720] trunk/Source/WebKit
Title: [264720] trunk/Source/WebKit
Revision 264720
Author ddkil...@apple.com
Date 2020-07-22 12:33:10 -0700 (Wed, 22 Jul 2020)
Log Message
[IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type
Unreviewed fix to include the better header.
* Shared/mac/ObjCObjectGraph.mm:
- Switch #include from OptionSet.h to EnumTraits.h.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (264719 => 264720)
--- trunk/Source/WebKit/ChangeLog 2020-07-22 19:27:05 UTC (rev 264719)
+++ trunk/Source/WebKit/ChangeLog 2020-07-22 19:33:10 UTC (rev 264720)
@@ -1,3 +1,14 @@
+2020-07-22 David Kilzer
+
+[IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type
+
+
+
+Unreviewed fix to include the better header.
+
+* Shared/mac/ObjCObjectGraph.mm:
+- Switch #include from OptionSet.h to EnumTraits.h.
+
2020-07-22 Jer Noble
Unreviewed build fix after r264710; add a HAVE_AVPLAYER_VIDEORANGEOVERRIDE guard.
Modified: trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm (264719 => 264720)
--- trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm 2020-07-22 19:27:05 UTC (rev 264719)
+++ trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm 2020-07-22 19:33:10 UTC (rev 264720)
@@ -33,7 +33,7 @@
#import "WKAPICast.h"
#import "WKBrowsingContextHandleInternal.h"
#import "WKTypeRefWrapper.h"
-#import
+#import
#import
namespace WebKit {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264719] trunk/Source
Title: [264719] trunk/Source Revision 264719 Author jer.no...@apple.com Date 2020-07-22 12:27:05 -0700 (Wed, 22 Jul 2020) Log Message Unreviewed build fix after r264710; add a HAVE_AVPLAYER_VIDEORANGEOVERRIDE guard. Source/WebCore: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::setPreferredDynamicRangeMode): Source/WebCore/PAL: * pal/spi/cocoa/AVFoundationSPI.h: Source/WebKit: * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updatePageScreenProperties): Source/WTF: * wtf/PlatformHave.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Diff Modified: trunk/Source/WTF/ChangeLog (264718 => 264719) --- trunk/Source/WTF/ChangeLog 2020-07-22 19:00:40 UTC (rev 264718) +++ trunk/Source/WTF/ChangeLog 2020-07-22 19:27:05 UTC (rev 264719) @@ -1,3 +1,9 @@ +2020-07-22 Jer Noble + +Unreviewed build fix after r264710; add a HAVE_AVPLAYER_VIDEORANGEOVERRIDE guard. + +* wtf/PlatformHave.h: + 2020-07-22 Geoffrey Garen JSRunLoopTimer should use WTF::RunLoop rather than custom CF code Modified: trunk/Source/WTF/wtf/PlatformHave.h (264718 => 264719) --- trunk/Source/WTF/wtf/PlatformHave.h 2020-07-22 19:00:40 UTC (rev 264718) +++ trunk/Source/WTF/wtf/PlatformHave.h 2020-07-22 19:27:05 UTC (rev 264719) @@ -550,6 +550,10 @@ #define HAVE_AVASSETWRITERDELEGATE 1 #endif +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600 +#define HAVE_AVPLAYER_VIDEORANGEOVERRIDE 1 +#endif + #if PLATFORM(COCOA) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) #define HAVE_CG_PATH_UNEVEN_CORNERS_ROUNDEDRECT 1 #endif Modified: trunk/Source/WebCore/ChangeLog (264718 => 264719) --- trunk/Source/WebCore/ChangeLog 2020-07-22 19:00:40 UTC (rev 264718) +++ trunk/Source/WebCore/ChangeLog 2020-07-22 19:27:05 UTC (rev 264719) @@ -1,3 +1,11 @@ +2020-07-22 Jer Noble + +Unreviewed build fix after r264710; add a HAVE_AVPLAYER_VIDEORANGEOVERRIDE guard. + +* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: +(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): +(WebCore::MediaPlayerPrivateAVFoundationObjC::setPreferredDynamicRangeMode): + 2020-07-22 Myles C. Maxfield REGRESSION(r205826): narrowNoBreakSpace (U+202F) has zero width, regardless of font Modified: trunk/Source/WebCore/PAL/ChangeLog (264718 => 264719) --- trunk/Source/WebCore/PAL/ChangeLog 2020-07-22 19:00:40 UTC (rev 264718) +++ trunk/Source/WebCore/PAL/ChangeLog 2020-07-22 19:27:05 UTC (rev 264719) @@ -1,5 +1,11 @@ 2020-07-22 Jer Noble +Unreviewed build fix after r264710; add a HAVE_AVPLAYER_VIDEORANGEOVERRIDE guard. + +* pal/spi/cocoa/AVFoundationSPI.h: + +2020-07-22 Jer Noble + [macOS] Adopt AVPlayer.videoRangeOverride https://bugs.webkit.org/show_bug.cgi?id=213902 Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h (264718 => 264719) --- trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h 2020-07-22 19:00:40 UTC (rev 264718) +++ trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h 2020-07-22 19:27:05 UTC (rev 264719) @@ -64,11 +64,13 @@ @end NS_ASSUME_NONNULL_END +#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE) typedef NSString * AVVideoRange NS_TYPED_ENUM; @interface AVPlayer (AVPlayerVideoRangeOverride) @property (nonatomic, copy, nullable) AVVideoRange videoRangeOverride; + (nullable AVVideoRange)preferredVideoRangeForDisplays:(nonnull NSArray *)displays; @end +#endif #if ENABLE(WIRELESS_PLAYBACK_TARGET) || PLATFORM(IOS_FAMILY) Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (264718 => 264719) --- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2020-07-22 19:00:40 UTC (rev 264718) +++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2020-07-22 19:27:05 UTC (rev 264719) @@ -912,8 +912,10 @@ setShouldObserveTimeControlStatus(true); m_avPlayer.get().appliesMediaSelectionCriteriaAutomatically = NO; +#if HAVE(AVPLAYER_VIDEORANGEOVERRIDE) if ([m_avPlayer respondsToSelector:@selector(setVideoRangeOverride:)]) m_avPlayer.get().videoRangeOverride = convertDynamicRangeModeEnumToAVVideoRange(player()->preferredDynamicRangeMode()); +#endif #if ENABLE(WIRELESS_PLAYBACK_TARGET) updateDisableExternalPlayback(); @@ -3271,8 +3273,12 @@ void
[webkit-changes] [264718] trunk/Tools
Title: [264718] trunk/Tools
Revision 264718
Author ysuz...@apple.com
Date 2020-07-22 12:00:40 -0700 (Wed, 22 Jul 2020)
Log Message
TestWTF.WTF_Packed.PackedAlignedPtr should be adjusted because ARM macOS is using 48 bits for effective address width
https://bugs.webkit.org/show_bug.cgi?id=214633
Reviewed by Mark Lam.
While PlatformOS.h's condition is updated, the test is not changed. This patch just aligns the condition used in this test
to the one in PlatformOS.h.
* TestWebKitAPI/Tests/WTF/Packed.cpp:
(TestWebKitAPI::TEST):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/Packed.cpp
Diff
Modified: trunk/Tools/ChangeLog (264717 => 264718)
--- trunk/Tools/ChangeLog 2020-07-22 18:59:45 UTC (rev 264717)
+++ trunk/Tools/ChangeLog 2020-07-22 19:00:40 UTC (rev 264718)
@@ -1,3 +1,16 @@
+2020-07-22 Yusuke Suzuki
+
+TestWTF.WTF_Packed.PackedAlignedPtr should be adjusted because ARM macOS is using 48 bits for effective address width
+https://bugs.webkit.org/show_bug.cgi?id=214633
+
+Reviewed by Mark Lam.
+
+While PlatformOS.h's condition is updated, the test is not changed. This patch just aligns the condition used in this test
+to the one in PlatformOS.h.
+
+* TestWebKitAPI/Tests/WTF/Packed.cpp:
+(TestWebKitAPI::TEST):
+
2020-07-22 Jonathan Bedard
[webkitcorepy] Add string_utils (Part 1)
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/Packed.cpp (264717 => 264718)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/Packed.cpp 2020-07-22 18:59:45 UTC (rev 264717)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/Packed.cpp 2020-07-22 19:00:40 UTC (rev 264718)
@@ -91,7 +91,7 @@
}
{
PackedAlignedPtr key { nullptr };
-#if OS(DARWIN) && CPU(ARM64)
+#if (OS(IOS) || OS(TVOS) || OS(WATCHOS)) && CPU(ARM64)
EXPECT_EQ(sizeof(key), 4U);
#else
EXPECT_LE(sizeof(key), 6U);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264717] trunk/Source/WebInspectorUI
Title: [264717] trunk/Source/WebInspectorUI
Revision 264717
Author bb...@apple.com
Date 2020-07-22 11:59:45 -0700 (Wed, 22 Jul 2020)
Log Message
Web Inspector: Sources tab empty, sidebar nonfunctional
https://bugs.webkit.org/show_bug.cgi?id=214611
Reviewed by Devin Rousso.
This is caused when a subresource fails its initial load. This generates a
networking IssueMessage without a source code location, which is not adequately handled.
* UserInterface/Views/IssueTreeElement.js:
(WI.IssueTreeElement.prototype._updateTitles):
(WI.IssueTreeElement):
If there is no sourceCodeLocation for the issue, then don't try to compute line numbers.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (264716 => 264717)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-07-22 18:47:32 UTC (rev 264716)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-07-22 18:59:45 UTC (rev 264717)
@@ -1,3 +1,19 @@
+2020-07-22 Brian Burg
+
+Web Inspector: Sources tab empty, sidebar nonfunctional
+https://bugs.webkit.org/show_bug.cgi?id=214611
+
+
+Reviewed by Devin Rousso.
+
+This is caused when a subresource fails its initial load. This generates a
+networking IssueMessage without a source code location, which is not adequately handled.
+
+* UserInterface/Views/IssueTreeElement.js:
+(WI.IssueTreeElement.prototype._updateTitles):
+(WI.IssueTreeElement):
+If there is no sourceCodeLocation for the issue, then don't try to compute line numbers.
+
2020-07-21 Devin Rousso
Web Inspector: unable to save files that are base64 encoded
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js (264716 => 264717)
--- trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js 2020-07-22 18:47:32 UTC (rev 264716)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IssueTreeElement.js 2020-07-22 18:59:45 UTC (rev 264717)
@@ -58,15 +58,18 @@
_updateTitles()
{
-var displayLineNumber = this._issueMessage.sourceCodeLocation.displayLineNumber;
-var displayColumnNumber = this._issueMessage.sourceCodeLocation.displayColumnNumber;
-var title;
-if (displayColumnNumber > 0)
-title = WI.UIString("Line %d:%d").format(displayLineNumber + 1, displayColumnNumber + 1); // The user visible line and column numbers are 1-based.
-else
-title = WI.UIString("Line %d").format(displayLineNumber + 1); // The user visible line number is 1-based.
+if (this._issueMessage.sourceCodeLocation) {
+let displayLineNumber = this._issueMessage.sourceCodeLocation.displayLineNumber;
+let displayColumnNumber = this._issueMessage.sourceCodeLocation.displayColumnNumber;
+var lineNumberLabel;
+if (displayColumnNumber > 0)
+lineNumberLabel = WI.UIString("Line %d:%d").format(displayLineNumber + 1, displayColumnNumber + 1); // The user visible line and column numbers are 1-based.
+else
+lineNumberLabel = WI.UIString("Line %d").format(displayLineNumber + 1); // The user visible line number is 1-based.
-this.mainTitle = title + " " + this._issueMessage.text;
+this.mainTitle = `${lineNumberLabel} ${this._issueMessage.text}`;
+} else
+this.mainTitle = this._issueMessage.text;
}
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264716] trunk/LayoutTests
Title: [264716] trunk/LayoutTests Revision 264716 Author simon.fra...@apple.com Date 2020-07-22 11:47:32 -0700 (Wed, 22 Jul 2020) Log Message compositing/repaint/iframes/compositing-iframe-scroll-repaint.html fails on Mojave https://bugs.webkit.org/show_bug.cgi?id=214647 Unreviewed test gardening. This test fails on Mojave. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (264715 => 264716) --- trunk/LayoutTests/ChangeLog 2020-07-22 18:35:42 UTC (rev 264715) +++ trunk/LayoutTests/ChangeLog 2020-07-22 18:47:32 UTC (rev 264716) @@ -1,3 +1,12 @@ +2020-07-22 Simon Fraser + +compositing/repaint/iframes/compositing-iframe-scroll-repaint.html fails on Mojave +https://bugs.webkit.org/show_bug.cgi?id=214647 + +Unreviewed test gardening. This test fails on Mojave. + +* platform/mac-wk1/TestExpectations: + 2020-07-22 Myles C. Maxfield REGRESSION(r205826): narrowNoBreakSpace (U+202F) has zero width, regardless of font Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (264715 => 264716) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-07-22 18:35:42 UTC (rev 264715) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-07-22 18:47:32 UTC (rev 264716) @@ -817,6 +817,9 @@ webkit.org/b/198459 [ Debug ] inspector/canvas/recording-webgl-full.html [ Slow ] webkit.org/b/196508 compositing/repaint/scroller-with-foreground-layer-repaints.html [ Pass Failure ] +webkit.org/b/206945 [ Catalina ] compositing/repaint/become-overlay-composited-layer.html [ Pass Failure ] +webkit.org/b/214647 [ Mojave ] compositing/repaint/iframes/compositing-iframe-scroll-repaint.html [ Failure ] +webkit.org/b/214388 [ Mojave ] compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html [ Pass Failure ] webkit.org/b/198676 imported/w3c/web-platform-tests/content-security-policy/reporting/report-only-in-meta.sub.html [ Pass Failure ] @@ -874,8 +877,6 @@ webkit.org/b/190830 [ Debug ] media/track/video-track-addition-and-frame-removal.html [ Pass Crash ] -webkit.org/b/206945 [ Catalina ] compositing/repaint/become-overlay-composited-layer.html [ Pass Failure ] - webkit.org/b/206974 http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-xslt-document-in-iframe-with-inherited-policy.html [ Pass Failure ] webkit.org/b/207059 imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-small.html [ Pass Failure ] @@ -982,8 +983,6 @@ webkit.org/b/214308 http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html [ Pass Failure ] -webkit.org/b/214388 [ Mojave ] compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html [ Pass Failure ] - webkit.org/b/214469 imported/w3c/web-platform-tests/css/css-animations/animation-opacity-pause-and-set-time.html [ ImageOnlyFailure ] webkit.org/b/214469 imported/w3c/web-platform-tests/css/css-animations/animation-transform-pause-and-set-time.html [ ImageOnlyFailure ] webkit.org/b/214469 imported/w3c/web-platform-tests/css/css-overflow/overflow-ellipsis-dynamic-001.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264715] trunk/Tools
Title: [264715] trunk/Tools Revision 264715 Author jbed...@apple.com Date 2020-07-22 11:35:42 -0700 (Wed, 22 Jul 2020) Log Message [webkitcorepy] Add string_utils (Part 1) https://bugs.webkit.org/show_bug.cgi?id=214405 Reviewed by Dewei Zhu. Centralize handling of unicode encoding/decoding along with various tools for printing strings. * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: * Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py: Added. (encode): Encode a string as bytes. (decode): Decode a bytes as a string. (ordinal): Convert a number to 1st, 2nd, 3rd, 4th, ect. (pluralize): Convert a string to it's plurlarized version, if provided number indicates it should be. (join): Join a list of elements in a human-readable form. (out_of): Create a fraction which takes up a constant amount of characters. (elapsed): Describe the amount of time elapsed as a human-readable string. * Scripts/libraries/webkitcorepy/webkitcorepy/tests/string_utils_unittest.py: Added. (StringUtils): Test string_utils. * Scripts/webkitpy/common/unicode_compatibility.py: Replaced with webkitcorepy.string_utils. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitcorepy/README.md trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/version.py trunk/Tools/Scripts/webkitpy/common/unicode_compatibility.py Added Paths trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/string_utils_unittest.py Diff Modified: trunk/Tools/ChangeLog (264714 => 264715) --- trunk/Tools/ChangeLog 2020-07-22 18:28:32 UTC (rev 264714) +++ trunk/Tools/ChangeLog 2020-07-22 18:35:42 UTC (rev 264715) @@ -1,3 +1,27 @@ +2020-07-22 Jonathan Bedard + +[webkitcorepy] Add string_utils (Part 1) +https://bugs.webkit.org/show_bug.cgi?id=214405 + +Reviewed by Dewei Zhu. + +Centralize handling of unicode encoding/decoding along with various tools +for printing strings. + +* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: +* Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py: Added. +(encode): Encode a string as bytes. +(decode): Decode a bytes as a string. +(ordinal): Convert a number to 1st, 2nd, 3rd, 4th, ect. +(pluralize): Convert a string to it's plurlarized version, if provided number indicates +it should be. +(join): Join a list of elements in a human-readable form. +(out_of): Create a fraction which takes up a constant amount of characters. +(elapsed): Describe the amount of time elapsed as a human-readable string. +* Scripts/libraries/webkitcorepy/webkitcorepy/tests/string_utils_unittest.py: Added. +(StringUtils): Test string_utils. +* Scripts/webkitpy/common/unicode_compatibility.py: Replaced with webkitcorepy.string_utils. + 2020-07-22 Aakash Jain [ews-app] Pass api key in more secure manner Modified: trunk/Tools/Scripts/libraries/webkitcorepy/README.md (264714 => 264715) --- trunk/Tools/Scripts/libraries/webkitcorepy/README.md 2020-07-22 18:28:32 UTC (rev 264714) +++ trunk/Tools/Scripts/libraries/webkitcorepy/README.md 2020-07-22 18:35:42 UTC (rev 264715) @@ -10,3 +10,16 @@ from webkitcorepy import Version version = Version(1, 2, 3) ``` + +Unicode stream management across Python 2 and 3 +``` +from webkitcorepy import BytesIO, StringIO, UnicodeIO, unicode +``` + +Encoding and decoding byte strings and unicode strings +``` +from webkitcorepy import string_utils + +string_utils.encode(...) +string_utils.decode(...) +``` Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py (264714 => 264715) --- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py 2020-07-22 18:28:32 UTC (rev 264714) +++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py 2020-07-22 18:35:42 UTC (rev 264715) @@ -21,4 +21,6 @@ # SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. from webkitcorepy.version import Version -version = Version(0, 0, 1) +from webkitcorepy.string_utils import BytesIO, StringIO, UnicodeIO, unicode + +version = Version(0, 0, 2) Added: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py (0 => 264715) --- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py (rev 0) +++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/string_utils.py 2020-07-22 18:35:42 UTC (rev 264715) @@ -0,0 +1,102 @@ +# Copyright (C) 2020 Apple Inc. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# 1. Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# 2.
[webkit-changes] [264714] trunk
Title: [264714] trunk Revision 264714 Author mmaxfi...@apple.com Date 2020-07-22 11:28:32 -0700 (Wed, 22 Jul 2020) Log Message REGRESSION(r205826): narrowNoBreakSpace (U+202F) has zero width, regardless of font https://bugs.webkit.org/show_bug.cgi?id=214626 Reviewed by Timothy Hatcher. Source/WebCore: There's no reason to overwrite narrowNoBreakSpace with zeroWidthSpace. This is becoming much more prominent now because a lot of the French unit formatting data in CLDR - and hence in e.g. NSMeasurementFormatter - uses 202F between numeric value and unit, e.g. "37 km" It works in native content on macOS, and in all other browsers on macOS, but not in WebKit. Test: fast/text/narrowNoBreakSpace.html * platform/graphics/Font.cpp: (WebCore::overrideControlCharacters): LayoutTests: * fast/text/narrowNoBreakSpace-expected-mismatch.html: Added. * fast/text/narrowNoBreakSpace.html: Added. * fast/text/narrow-non-breaking-space-expected-mismatch.html: Renamed from fast/text/narrow-non-breaking-space-expected.html. * fast/text/narrow-non-breaking-space.html: Made the test more robust. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/text/narrow-non-breaking-space.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/Font.cpp Added Paths trunk/LayoutTests/fast/text/narrow-non-breaking-space-expected-mismatch.html trunk/LayoutTests/fast/text/narrowNoBreakSpace-expected-mismatch.html trunk/LayoutTests/fast/text/narrowNoBreakSpace.html Removed Paths trunk/LayoutTests/fast/text/narrow-non-breaking-space-expected.html Diff Modified: trunk/LayoutTests/ChangeLog (264713 => 264714) --- trunk/LayoutTests/ChangeLog 2020-07-22 18:25:43 UTC (rev 264713) +++ trunk/LayoutTests/ChangeLog 2020-07-22 18:28:32 UTC (rev 264714) @@ -1,3 +1,16 @@ +2020-07-22 Myles C. Maxfield + +REGRESSION(r205826): narrowNoBreakSpace (U+202F) has zero width, regardless of font +https://bugs.webkit.org/show_bug.cgi?id=214626 + + +Reviewed by Timothy Hatcher. + +* fast/text/narrowNoBreakSpace-expected-mismatch.html: Added. +* fast/text/narrowNoBreakSpace.html: Added. +* fast/text/narrow-non-breaking-space-expected-mismatch.html: Renamed from fast/text/narrow-non-breaking-space-expected.html. +* fast/text/narrow-non-breaking-space.html: Made the test more robust. + 2020-07-21 Simon Fraser Scrolling tesla.com on iPad is not smooth Added: trunk/LayoutTests/fast/text/narrow-non-breaking-space-expected-mismatch.html (0 => 264714) --- trunk/LayoutTests/fast/text/narrow-non-breaking-space-expected-mismatch.html (rev 0) +++ trunk/LayoutTests/fast/text/narrow-non-breaking-space-expected-mismatch.html 2020-07-22 18:28:32 UTC (rev 264714) @@ -0,0 +1,7 @@ + + + +"" + + + Deleted: trunk/LayoutTests/fast/text/narrow-non-breaking-space-expected.html (264713 => 264714) --- trunk/LayoutTests/fast/text/narrow-non-breaking-space-expected.html 2020-07-22 18:25:43 UTC (rev 264713) +++ trunk/LayoutTests/fast/text/narrow-non-breaking-space-expected.html 2020-07-22 18:28:32 UTC (rev 264714) @@ -1,8 +0,0 @@ - - - -This test makes sure that a narrow non-breaking space does not draw as a .notdef character. -This character is a U+202f narrow non-breaking space: "" - - - Modified: trunk/LayoutTests/fast/text/narrow-non-breaking-space.html (264713 => 264714) --- trunk/LayoutTests/fast/text/narrow-non-breaking-space.html 2020-07-22 18:25:43 UTC (rev 264713) +++ trunk/LayoutTests/fast/text/narrow-non-breaking-space.html 2020-07-22 18:28:32 UTC (rev 264714) @@ -1,8 +1,7 @@ - + -This test makes sure that a narrow non-breaking space does not draw as a .notdef character. -This character is a U+202f narrow non-breaking space: "" +"" Added: trunk/LayoutTests/fast/text/narrowNoBreakSpace-expected-mismatch.html (0 => 264714) --- trunk/LayoutTests/fast/text/narrowNoBreakSpace-expected-mismatch.html (rev 0) +++ trunk/LayoutTests/fast/text/narrowNoBreakSpace-expected-mismatch.html 2020-07-22 18:28:32 UTC (rev 264714) @@ -0,0 +1,9 @@ + + + + + + +1000 + + Added: trunk/LayoutTests/fast/text/narrowNoBreakSpace.html (0 => 264714) --- trunk/LayoutTests/fast/text/narrowNoBreakSpace.html (rev 0) +++ trunk/LayoutTests/fast/text/narrowNoBreakSpace.html 2020-07-22 18:28:32 UTC (rev 264714) @@ -0,0 +1,9 @@ + + + + + + +1000 + + Modified: trunk/Source/WebCore/ChangeLog (264713 => 264714) --- trunk/Source/WebCore/ChangeLog 2020-07-22 18:25:43 UTC (rev 264713) +++ trunk/Source/WebCore/ChangeLog 2020-07-22 18:28:32 UTC (rev 264714) @@ -1,3 +1,22 @@ +2020-07-22 Myles C. Maxfield + +REGRESSION(r205826): narrowNoBreakSpace (U+202F) has zero width, regardless of font +https://bugs.webkit.org/show_bug.cgi?id=214626 + + +Reviewed by Timothy Hatcher. + +There's no reason to overwrite narrowNoBreakSpace with zeroWidthSpace. + +
[webkit-changes] [264713] trunk/Source/WebCore
Title: [264713] trunk/Source/WebCore Revision 264713 Author commit-qu...@webkit.org Date 2020-07-22 11:25:43 -0700 (Wed, 22 Jul 2020) Log Message Fix validation of deleted WebGL objects https://bugs.webkit.org/show_bug.cgi?id=214622 Patch by James Darpinian on 2020-07-22 Reviewed by Dean Jackson. Programs and shaders need to be validated differently than other WebGL objects. Using a deleted WebGL object should cause an INVALID_OPERATION error, except for programs and shaders which should be INVALID_VALUE. * html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::getFragDataLocation): (WebCore::WebGL2RenderingContext::transformFeedbackVaryings): (WebCore::WebGL2RenderingContext::getTransformFeedbackVarying): (WebCore::WebGL2RenderingContext::getUniformIndices): (WebCore::WebGL2RenderingContext::getActiveUniforms): (WebCore::WebGL2RenderingContext::getUniformBlockIndex): (WebCore::WebGL2RenderingContext::getActiveUniformBlockParameter): (WebCore::WebGL2RenderingContext::getActiveUniformBlockName): (WebCore::WebGL2RenderingContext::uniformBlockBinding): * html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::attachShader): (WebCore::WebGLRenderingContextBase::bindAttribLocation): (WebCore::WebGLRenderingContextBase::compileShader): (WebCore::WebGLRenderingContextBase::detachShader): (WebCore::WebGLRenderingContextBase::validateWebGLObject): (WebCore::WebGLRenderingContextBase::validateWebGLProgramOrShader): (WebCore::WebGLRenderingContextBase::getActiveAttrib): (WebCore::WebGLRenderingContextBase::getActiveUniform): (WebCore::WebGLRenderingContextBase::getAttachedShaders): (WebCore::WebGLRenderingContextBase::getAttribLocation): (WebCore::WebGLRenderingContextBase::getProgramParameter): (WebCore::WebGLRenderingContextBase::getProgramInfoLog): (WebCore::WebGLRenderingContextBase::getShaderParameter): (WebCore::WebGLRenderingContextBase::getShaderInfoLog): (WebCore::WebGLRenderingContextBase::getShaderSource): (WebCore::WebGLRenderingContextBase::getUniform): (WebCore::WebGLRenderingContextBase::getUniformLocation): (WebCore::WebGLRenderingContextBase::linkProgramWithoutInvalidatingAttribLocations): (WebCore::WebGLRenderingContextBase::shaderSource): (WebCore::WebGLRenderingContextBase::validateProgram): * html/canvas/WebGLRenderingContextBase.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.h Diff Modified: trunk/Source/WebCore/ChangeLog (264712 => 264713) --- trunk/Source/WebCore/ChangeLog 2020-07-22 18:23:46 UTC (rev 264712) +++ trunk/Source/WebCore/ChangeLog 2020-07-22 18:25:43 UTC (rev 264713) @@ -1,3 +1,47 @@ +2020-07-22 James Darpinian + +Fix validation of deleted WebGL objects +https://bugs.webkit.org/show_bug.cgi?id=214622 + +Reviewed by Dean Jackson. + +Programs and shaders need to be validated differently than other WebGL objects. +Using a deleted WebGL object should cause an INVALID_OPERATION error, except +for programs and shaders which should be INVALID_VALUE. + +* html/canvas/WebGL2RenderingContext.cpp: +(WebCore::WebGL2RenderingContext::getFragDataLocation): +(WebCore::WebGL2RenderingContext::transformFeedbackVaryings): +(WebCore::WebGL2RenderingContext::getTransformFeedbackVarying): +(WebCore::WebGL2RenderingContext::getUniformIndices): +(WebCore::WebGL2RenderingContext::getActiveUniforms): +(WebCore::WebGL2RenderingContext::getUniformBlockIndex): +(WebCore::WebGL2RenderingContext::getActiveUniformBlockParameter): +(WebCore::WebGL2RenderingContext::getActiveUniformBlockName): +(WebCore::WebGL2RenderingContext::uniformBlockBinding): +* html/canvas/WebGLRenderingContextBase.cpp: +(WebCore::WebGLRenderingContextBase::attachShader): +(WebCore::WebGLRenderingContextBase::bindAttribLocation): +(WebCore::WebGLRenderingContextBase::compileShader): +(WebCore::WebGLRenderingContextBase::detachShader): +(WebCore::WebGLRenderingContextBase::validateWebGLObject): +(WebCore::WebGLRenderingContextBase::validateWebGLProgramOrShader): +(WebCore::WebGLRenderingContextBase::getActiveAttrib): +(WebCore::WebGLRenderingContextBase::getActiveUniform): +(WebCore::WebGLRenderingContextBase::getAttachedShaders): +(WebCore::WebGLRenderingContextBase::getAttribLocation): +(WebCore::WebGLRenderingContextBase::getProgramParameter): +(WebCore::WebGLRenderingContextBase::getProgramInfoLog): +(WebCore::WebGLRenderingContextBase::getShaderParameter): +(WebCore::WebGLRenderingContextBase::getShaderInfoLog): +(WebCore::WebGLRenderingContextBase::getShaderSource): +(WebCore::WebGLRenderingContextBase::getUniform): +
[webkit-changes] [264712] trunk/Source/WebCore
Title: [264712] trunk/Source/WebCore
Revision 264712
Author j...@apple.com
Date 2020-07-22 11:23:46 -0700 (Wed, 22 Jul 2020)
Log Message
Update feature status to include the inert attribute
https://bugs.webkit.org/show_bug.cgi?id=214644
Reviewed by Darin Adler.
* features.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (264711 => 264712)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 18:16:40 UTC (rev 264711)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 18:23:46 UTC (rev 264712)
@@ -1,3 +1,12 @@
+2020-07-22 Jon Davis
+
+Update feature status to include the inert attribute
+https://bugs.webkit.org/show_bug.cgi?id=214644
+
+Reviewed by Darin Adler.
+
+* features.json:
+
2020-07-22 Jer Noble
[macOS] Adopt AVPlayer.videoRangeOverride
Modified: trunk/Source/WebCore/features.json (264711 => 264712)
--- trunk/Source/WebCore/features.json 2020-07-22 18:16:40 UTC (rev 264711)
+++ trunk/Source/WebCore/features.json 2020-07-22 18:23:46 UTC (rev 264712)
@@ -1454,6 +1454,23 @@
"description": "An an API for securely providing access to Universal Serial Bus devices from web pages."
},
{
+"name": "inert attribute",
+"status": {
+"status": "Under Consideration",
+"enabled-by-default": false
+},
+"url": "https://whatpr.org/html/4288/interaction.html#the-inert-attribute",
+"documentation-url": "https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/inert",
+"webkit-url": "https://bugs.webkit.org/show_bug.cgi?id=165279",
+"specification": "DOM",
+"description": "An attribute that flags a node as inert to tell the user-agent to ignore the node for targeting user interaction events such as selecting text in the node, or find-in-page text search.",
+"contact": {
+"name": "Jonathan Davis",
+"twitter": "@jonathandavis",
+"email": "web-evangel...@apple.com"
+}
+},
+{
"name": "requestIdleCallback",
"status": {
"status": "Under Consideration"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264711] trunk/Tools
Title: [264711] trunk/Tools
Revision 264711
Author aakash_j...@apple.com
Date 2020-07-22 11:16:40 -0700 (Wed, 22 Jul 2020)
Log Message
[ews-app] Pass api key in more secure manner
https://bugs.webkit.org/show_bug.cgi?id=214639
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
(Bugzilla.get_bugzilla_api_key): Method to read api key from file instead of environment variable.
(Bugzilla.fetch_data_from_bugzilla_with_authentication): Method to fetch data from bugzilla using api key.
(Bugzilla._fetch_attachment_json): Do not append api key in the url, use new method instead.
(Bugzilla._get_bug_json): Ditto.
(Bugzilla._get_commit_queue_patches_from_bug): Ditto.
* BuildSlaveSupport/ews-app/ews/common/util.py:
(fetch_data_from_url): Log the url to help in debugging any possible issues.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py
trunk/Tools/BuildSlaveSupport/ews-app/ews/common/util.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py (264710 => 264711)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py 2020-07-22 18:12:11 UTC (rev 264710)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/bugzilla.py 2020-07-22 18:16:40 UTC (rev 264711)
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 Apple Inc. All rights reserved.
+# Copyright (C) 2018-2020 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -21,9 +21,11 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
import base64
+import json
import logging
import os
import re
+import requests
import socket
import time
@@ -75,6 +77,30 @@
attachment_file.write(attachment_data)
@classmethod
+def get_bugzilla_api_key(cls):
+try:
+passwords = json.load(open('passwords.json'))
+return passwords.get('BUGZILLA_API_KEY', '')
+except Exception as e:
+_log.error('Error in reading Bugzilla api key')
+return ''
+
+@classmethod
+def fetch_data_from_bugzilla_with_authentication(cls, url):
+_log.info('Fetching from bugzilla: {}'.format(url))
+response = None
+try:
+response = requests.get(url, timeout=10, params={'Bugzilla_api_key': cls.get_bugzilla_api_key()})
+if response.status_code != 200:
+_log.error('Accessed {url} with unexpected status code {status_code}.'.format(url="" status_code=response.status_code))
+return None
+except Exception as e:
+# Catching all exceptions here to safeguard api key.
+_log.error('Failed to access {}'.format(url))
+return None
+return response
+
+@classmethod
def _fetch_attachment_json(cls, attachment_id):
if not Patch.is_valid_patch_id(attachment_id):
_log.warn('Invalid attachment id: "{}", skipping download.'.format(attachment_id))
@@ -81,10 +107,7 @@
return None
attachment_url = '{}rest/bug/attachment/{}'.format(config.BUG_SERVER_URL, attachment_id)
-api_key = os.getenv('BUGZILLA_API_KEY', None)
-if api_key:
-attachment_url += '?api_key={}'.format(api_key)
-attachment = util.fetch_data_from_url(attachment_url)
+attachment = cls.fetch_data_from_bugzilla_with_authentication(attachment_url)
if not attachment:
return None
attachment_json = attachment.json().get('attachments')
@@ -99,10 +122,7 @@
return []
bug_url = '{}rest/bug/{}'.format(config.BUG_SERVER_URL, bug_id)
-api_key = os.getenv('BUGZILLA_API_KEY', None)
-if api_key:
-bug_url += '?api_key={}'.format(api_key)
-bug = util.fetch_data_from_url(bug_url)
+bug = cls.fetch_data_from_bugzilla_with_authentication(bug_url)
if not bug:
return None
bugs_json = bug.json().get('bugs')
@@ -117,10 +137,7 @@
return []
bug_url = '{}rest/bug/{}/attachment'.format(config.BUG_SERVER_URL, bug_id)
-api_key = os.getenv('BUGZILLA_API_KEY', None)
-if api_key:
-bug_url += '?api_key={}'.format(api_key)
-bug = util.fetch_data_from_url(bug_url)
+bug = cls.fetch_data_from_bugzilla_with_authentication(bug_url)
if not bug:
return []
bug_json = bug.json().get('bugs')
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/util.py (264710 => 264711)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/util.py 2020-07-22 18:12:11 UTC (rev 264710)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/util.py 2020-07-22 18:16:40 UTC (rev 264711)
@@ -27,7 +27,7 @@
def fetch_data_from_url(url):
-_log.debug('Fetching: {}'.format(url))
+_log.info('Fetching: {}'.format(url))
[webkit-changes] [264710] trunk
Title: [264710] trunk Revision 264710 Author jer.no...@apple.com Date 2020-07-22 11:12:11 -0700 (Wed, 22 Jul 2020) Log Message [macOS] Adopt AVPlayer.videoRangeOverride https://bugs.webkit.org/show_bug.cgi?id=213902 Reviewed by Youenn Fablet. Source/WebCore: AVPlayer.videoRangeOverride and also +[AVPlayer preferredVideoRangeForDisplays:] are replacements for the process-global MTShouldPlayHDR() and MTOverrideShouldPlayHDRVideo() and should be used preferentially if present. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::createMediaPlayer): (WebCore::HTMLMediaElement::setPreferredDynamicRangeMode): * html/HTMLMediaElement.h: * page/Page.cpp: (WebCore::Page::screenPropertiesDidChange): (WebCore::Page::windowScreenDidChange): * page/Page.h: * platform/PlatformScreen.h: (WebCore::preferredDynamicRangeMode): * platform/ScreenProperties.h: (WebCore::ScreenData::encode const): (WebCore::ScreenData::decode): * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPreferredDynamicRangeMode): * platform/graphics/MediaPlayer.h: * platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreferredDynamicRangeMode): * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm: (WebCore::CDMSessionAVStreamSession::update): * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::convertDynamicRangeModeEnumToAVVideoRange): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::setPreferredDynamicRangeMode): * platform/mac/PlatformScreenMac.mm: (WebCore::convertAVVideoRangeToEnum): (WebCore::collectScreenProperties): (WebCore::preferredDynamicRangeMode): Source/WebCore/PAL: * pal/cocoa/AVFoundationSoftLink.h: * pal/cocoa/AVFoundationSoftLink.mm: * pal/spi/cocoa/AVFoundationSPI.h: Source/WebKit: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::screenPropertiesDidChange): * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::updatePageScreenProperties): Tools: * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: (TestWebKitAPI::TEST): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebCore/platform/PlatformScreen.h trunk/Source/WebCore/platform/ScreenProperties.h trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp trunk/Source/WebCore/platform/graphics/MediaPlayer.h trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm Diff Modified: trunk/Source/WebCore/ChangeLog (264709 => 264710) --- trunk/Source/WebCore/ChangeLog 2020-07-22 18:00:35 UTC (rev 264709) +++ trunk/Source/WebCore/ChangeLog 2020-07-22 18:12:11 UTC (rev 264710) @@ -1,3 +1,45 @@ +2020-07-22 Jer Noble + +[macOS] Adopt AVPlayer.videoRangeOverride +https://bugs.webkit.org/show_bug.cgi?id=213902 + + +Reviewed by Youenn Fablet. + +AVPlayer.videoRangeOverride and also +[AVPlayer preferredVideoRangeForDisplays:] are replacements for the +process-global MTShouldPlayHDR() and MTOverrideShouldPlayHDRVideo() and should be used preferentially if +present. + +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::createMediaPlayer): +(WebCore::HTMLMediaElement::setPreferredDynamicRangeMode): +* html/HTMLMediaElement.h: +* page/Page.cpp: +(WebCore::Page::screenPropertiesDidChange): +(WebCore::Page::windowScreenDidChange): +* page/Page.h: +* platform/PlatformScreen.h: +(WebCore::preferredDynamicRangeMode): +* platform/ScreenProperties.h: +(WebCore::ScreenData::encode const): +(WebCore::ScreenData::decode): +* platform/graphics/MediaPlayer.cpp: +(WebCore::MediaPlayer::setPreferredDynamicRangeMode): +* platform/graphics/MediaPlayer.h: +* platform/graphics/MediaPlayerPrivate.h: +(WebCore::MediaPlayerPrivateInterface::setPreferredDynamicRangeMode): +*
[webkit-changes] [264707] branches/safari-610.1.23-branch/Source/WebKit
Title: [264707] branches/safari-610.1.23-branch/Source/WebKit Revision 264707 Author alanc...@apple.com Date 2020-07-22 11:00:21 -0700 (Wed, 22 Jul 2020) Log Message Cherry-pick r264678. rdar://problem/65944685 [macOS] Layout tests exiting early with crashes https://bugs.webkit.org/show_bug.cgi?id=214612 Reviewed by Brent Fulgham. This is caused by the WebContent process making a syscall not allowed by the sandbox. * WebProcess/com.apple.WebProcess.sb.in: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264678 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610.1.23-branch/Source/WebKit/ChangeLog branches/safari-610.1.23-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: branches/safari-610.1.23-branch/Source/WebKit/ChangeLog (264706 => 264707) --- branches/safari-610.1.23-branch/Source/WebKit/ChangeLog 2020-07-22 18:00:18 UTC (rev 264706) +++ branches/safari-610.1.23-branch/Source/WebKit/ChangeLog 2020-07-22 18:00:21 UTC (rev 264707) @@ -1,5 +1,34 @@ 2020-07-22 Alan Coon +Cherry-pick r264678. rdar://problem/65944685 + +[macOS] Layout tests exiting early with crashes +https://bugs.webkit.org/show_bug.cgi?id=214612 + + +Reviewed by Brent Fulgham. + +This is caused by the WebContent process making a syscall not allowed by the sandbox. + +* WebProcess/com.apple.WebProcess.sb.in: + + +git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264678 268f45cc-cd09-0410-ab3c-d52691b4dbfc + +2020-07-21 Per Arne Vollan + +[macOS] Layout tests exiting early with crashes +https://bugs.webkit.org/show_bug.cgi?id=214612 + + +Reviewed by Brent Fulgham. + +This is caused by the WebContent process making a syscall not allowed by the sandbox. + +* WebProcess/com.apple.WebProcess.sb.in: + +2020-07-22 Alan Coon + Cherry-pick r264659. rdar://problem/65944694 [Cocoa] Adopt VTRegisterSupplementalVideoDecoderIfAvailable Modified: branches/safari-610.1.23-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (264706 => 264707) --- branches/safari-610.1.23-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-07-22 18:00:18 UTC (rev 264706) +++ branches/safari-610.1.23-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-07-22 18:00:21 UTC (rev 264707) @@ -1159,8 +1159,9 @@ (if (equal? (param "CPU") "arm64") (allow syscall-unix +(syscall-number SYS_fileport_makefd) +(syscall-number SYS_guarded_open_dprotected_np) ;; (syscall-number SYS_mremap_encrypted) -(syscall-number SYS_fileport_makefd) ) ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264709] branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc
Title: [264709] branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc
Revision 264709
Author alanc...@apple.com
Date 2020-07-22 11:00:35 -0700 (Wed, 22 Jul 2020)
Log Message
Cherry-pick r264693. rdar://problem/65944676
Unreviewed build fix after r264685; copy headers to the correct path during a DEPLOYMENT_LOCATION build.
* Configurations/libwebm.xcconfig:
* libwebrtc.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/ChangeLog
branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig
branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
Diff
Modified: branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/ChangeLog (264708 => 264709)
--- branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/ChangeLog 2020-07-22 18:00:32 UTC (rev 264708)
+++ branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/ChangeLog 2020-07-22 18:00:35 UTC (rev 264709)
@@ -1,5 +1,23 @@
2020-07-22 Alan Coon
+Cherry-pick r264693. rdar://problem/65944676
+
+Unreviewed build fix after r264685; copy headers to the correct path during a DEPLOYMENT_LOCATION build.
+
+* Configurations/libwebm.xcconfig:
+* libwebrtc.xcodeproj/project.pbxproj:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-07-21 Jer Noble
+
+Unreviewed build fix after r264685; copy headers to the correct path during a DEPLOYMENT_LOCATION build.
+
+* Configurations/libwebm.xcconfig:
+* libwebrtc.xcodeproj/project.pbxproj:
+
+2020-07-22 Alan Coon
+
Cherry-pick r264685. rdar://problem/65944676
[Cocoa] Add experimental MSE WebM parser
Modified: branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig (264708 => 264709)
--- branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig 2020-07-22 18:00:32 UTC (rev 264708)
+++ branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig 2020-07-22 18:00:35 UTC (rev 264709)
@@ -8,6 +8,9 @@
HEADER_SEARCH_PATHS = Source/third_party/libwebm Source/third_party/libwebm/webm_parser Source/third_party/libwebm/webm_parser/include;
INSTALL_PATH = /usr/local/lib;
-PRIVATE_HEADERS_FOLDER_PATH = /usr/local/include;
USE_HEADERMAP = NO;
+INSTALL_HEADERS_PATH = /usr/local/include;
+LIBWEBM_HEADERS_FOLDER_PATH = $(LIBWEBM_HEADERS_FOLDER_PATH_$(DEPLOYMENT_LOCATION));
+LIBWEBM_HEADERS_FOLDER_PATH_NO = $(BUILT_PRODUCTS_DIR)/$(INSTALL_HEADERS_PATH);
+LIBWEBM_HEADERS_FOLDER_PATH_YES = $(INSTALL_HEADERS_PATH);
Modified: branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (264708 => 264709)
--- branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2020-07-22 18:00:32 UTC (rev 264708)
+++ branches/safari-610.1.23-branch/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2020-07-22 18:00:35 UTC (rev 264709)
@@ -4185,8 +4185,8 @@
CDFD2FC424C4D9D10048DAC3 /* Copy webm headers */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
- dstPath = usr/local/include/webm;
- dstSubfolderSpec = 16;
+ dstPath = "$(LIBWEBM_HEADERS_FOLDER_PATH)/webm";
+ dstSubfolderSpec = 0;
files = (
CDFD2FC524C4DAF70048DAC3 /* buffer_reader.h in Copy webm headers */,
CDFD2FC624C4DAF70048DAC3 /* callback.h in Copy webm headers */,
@@ -4205,8 +4205,8 @@
CDFD2FCF24C4DB0C0048DAC3 /* Copy common headers */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
- dstPath = usr/local/include/common;
- dstSubfolderSpec = 16;
+ dstPath = "$(LIBWEBM_HEADERS_FOLDER_PATH)/common";
+ dstSubfolderSpec = 0;
files = (
CDFD2FD024C4DB2F0048DAC3 /* vp9_header_parser.h in Copy common headers */,
);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264706] branches/safari-610.1.23-branch/Source
Title: [264706] branches/safari-610.1.23-branch/Source
Revision 264706
Author alanc...@apple.com
Date 2020-07-22 11:00:18 -0700 (Wed, 22 Jul 2020)
Log Message
Cherry-pick r264659. rdar://problem/65944694
[Cocoa] Adopt VTRegisterSupplementalVideoDecoderIfAvailable
https://bugs.webkit.org/show_bug.cgi?id=214585
Reviewed by Youenn Fablet.
Source/WebCore:
* WebCore.xcodeproj/project.pbxproj:
* platform/cocoa/VideoToolboxSoftLink.cpp:
* platform/cocoa/VideoToolboxSoftLink.h:
* platform/graphics/cocoa/VP9UtilitiesCocoa.h:
* platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
(WebCore::registerSupplementalVP9Decoder):
Source/WebKit:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::enableVP9Decoder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-610.1.23-branch/Source/WebCore/ChangeLog
branches/safari-610.1.23-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-610.1.23-branch/Source/WebCore/platform/cocoa/VideoToolboxSoftLink.cpp
branches/safari-610.1.23-branch/Source/WebCore/platform/cocoa/VideoToolboxSoftLink.h
branches/safari-610.1.23-branch/Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.h
branches/safari-610.1.23-branch/Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm
branches/safari-610.1.23-branch/Source/WebKit/ChangeLog
branches/safari-610.1.23-branch/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: branches/safari-610.1.23-branch/Source/WebCore/ChangeLog (264705 => 264706)
--- branches/safari-610.1.23-branch/Source/WebCore/ChangeLog 2020-07-22 17:51:40 UTC (rev 264705)
+++ branches/safari-610.1.23-branch/Source/WebCore/ChangeLog 2020-07-22 18:00:18 UTC (rev 264706)
@@ -1,3 +1,45 @@
+2020-07-22 Alan Coon
+
+Cherry-pick r264659. rdar://problem/65944694
+
+[Cocoa] Adopt VTRegisterSupplementalVideoDecoderIfAvailable
+https://bugs.webkit.org/show_bug.cgi?id=214585
+
+
+Reviewed by Youenn Fablet.
+
+Source/WebCore:
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/cocoa/VideoToolboxSoftLink.cpp:
+* platform/cocoa/VideoToolboxSoftLink.h:
+* platform/graphics/cocoa/VP9UtilitiesCocoa.h:
+* platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
+(WebCore::registerSupplementalVP9Decoder):
+
+Source/WebKit:
+
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::enableVP9Decoder):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@264659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-07-21 Jer Noble
+
+[Cocoa] Adopt VTRegisterSupplementalVideoDecoderIfAvailable
+https://bugs.webkit.org/show_bug.cgi?id=214585
+
+
+Reviewed by Youenn Fablet.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/cocoa/VideoToolboxSoftLink.cpp:
+* platform/cocoa/VideoToolboxSoftLink.h:
+* platform/graphics/cocoa/VP9UtilitiesCocoa.h:
+* platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
+(WebCore::registerSupplementalVP9Decoder):
+
2020-07-20 Commit Queue
Unreviewed, reverting r264596.
Modified: branches/safari-610.1.23-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj (264705 => 264706)
--- branches/safari-610.1.23-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-07-22 17:51:40 UTC (rev 264705)
+++ branches/safari-610.1.23-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-07-22 18:00:18 UTC (rev 264706)
@@ -4160,6 +4160,7 @@
CD92F5182261038200F87BB3 /* FullscreenManager.h in Headers */ = {isa = PBXBuildFile; fileRef = CD92F5162261038200F87BB3 /* FullscreenManager.h */; settings = {ATTRIBUTES = (Private, ); }; };
CD94A5DD1F71D5D800F525C5 /* CDMClearKey.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CD94A5DB1F71CBB000F525C5 /* CDMClearKey.cpp */; };
CD94A5DE1F72F57B00F525C5 /* CDMClient.h in Headers */ = {isa = PBXBuildFile; fileRef = CD94A5C91F71CA9D00F525C5 /* CDMClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ CD9CC58524C6BBEB00CD3C64 /* VP9Utilities.h in Headers */ = {isa = PBXBuildFile; fileRef = CD6FE5BA24BCE7B6009FCDA4 /* VP9Utilities.h */; settings = {ATTRIBUTES = (Private, ); }; };
CD9D82761C7AE535006FF066 /* TextureCacheCV.h in Headers */ = {isa = PBXBuildFile; fileRef = CD9D82741C7AE535006FF066 /* TextureCacheCV.h */; };
CD9D827A1C7B8EE1006FF066 /* VideoTextureCopierCV.h in Headers */ = {isa = PBXBuildFile; fileRef = CD9D82781C7B8EE1006FF066 /* VideoTextureCopierCV.h */; };
CD9DE17517AAC74C00EA386D /* JSMediaSource.h in Headers */ = {isa = PBXBuildFile; fileRef = CD9DE17317AAC74C00EA386D /* JSMediaSource.h */; };
@@ -4182,6 +4183,7 @@
CDAB6D2917C7DE6C00C60B34 /* MediaControlsHost.h in Headers */ = {isa = PBXBuildFile; fileRef = CDAB6D2717C7DE6C00C60B34 /* MediaControlsHost.h */; };
CDAB6D2E17C814EE00C60B34 /*
[webkit-changes] [264705] trunk/Source/WebCore
Title: [264705] trunk/Source/WebCore
Revision 264705
Author j...@apple.com
Date 2020-07-22 10:51:40 -0700 (Wed, 22 Jul 2020)
Log Message
Update status for Web App Manifest
https://bugs.webkit.org/show_bug.cgi?id=204863
Reviewed by Dean Jackson.
* features.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (264704 => 264705)
--- trunk/Source/WebCore/ChangeLog 2020-07-22 17:48:26 UTC (rev 264704)
+++ trunk/Source/WebCore/ChangeLog 2020-07-22 17:51:40 UTC (rev 264705)
@@ -1,3 +1,12 @@
+2020-07-22 Jon Davis
+
+Update status for Web App Manifest
+https://bugs.webkit.org/show_bug.cgi?id=204863
+
+Reviewed by Dean Jackson.
+
+* features.json:
+
2020-07-21 Simon Fraser
Scrolling tesla.com on iPad is not smooth
Modified: trunk/Source/WebCore/features.json (264704 => 264705)
--- trunk/Source/WebCore/features.json 2020-07-22 17:48:26 UTC (rev 264704)
+++ trunk/Source/WebCore/features.json 2020-07-22 17:51:40 UTC (rev 264705)
@@ -677,7 +677,7 @@
{
"name": "Web App Manifest",
"status": {
-"status": "In Development",
+"status": "Partially Supported",
"enabled-by-default": false
},
"url": "https://www.w3.org/TR/appmanifest/",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264704] trunk
Title: [264704] trunk Revision 264704 Author simon.fra...@apple.com Date 2020-07-22 10:48:26 -0700 (Wed, 22 Jul 2020) Log Message Scrolling tesla.com on iPad is not smooth https://bugs.webkit.org/show_bug.cgi?id=214627 Source/WebCore: Reviewed by Tim Horton. This is the iOS equivalent of the fix in r264203; if the user is scrolling (or we're animating for scroll snap), layout should not trigger scroll position changes via computation of the current snap location. To fix this, we need to send data from the UI process to the web process about which scrolling tree nodes the user is scrolling. That's done via RemoteScrollingUIState, which will, in the long term, become a more general UI -> WebProcess scrolling state updating mechanism. For now, it just keeps track of nodes undergoing scroll snap and user scrolls (only the latter is hooked up for now). Test: fast/scrolling/ios/adjust-scroll-snap-during-gesture.html * page/scrolling/AsyncScrollingCoordinator.h: * page/scrolling/ScrollingTree.h: (WebCore::ScrollingTree::scrollingTreeNodeWillStartPanGesture): (WebCore::ScrollingTree::scrollingTreeNodeWillStartScroll): (WebCore::ScrollingTree::scrollingTreeNodeDidEndScroll): Source/WebKit: Reviewed by Tim Horton. This is the iOS equivalent of the fix in r264203; if the user is scrolling (or we're animating for scroll snap), layout should not trigger scroll position changes via computation of the current snap location. To fix this, we need to send data from the UI process to the web process about which scrolling tree nodes the user is scrolling. That's done via RemoteScrollingUIState, which will, in the long term, become a more general UI -> WebProcess scrolling state updating mechanism. For now, it just keeps track of nodes undergoing scroll snap and user scrolls (only the latter is hooked up for now). * Shared/RemoteLayerTree/RemoteScrollingUIState.cpp: Added. (WebKit::RemoteScrollingUIState::encode const): (WebKit::RemoteScrollingUIState::decode): (WebKit::RemoteScrollingUIState::addNodeWithActiveScrollSnap): (WebKit::RemoteScrollingUIState::removeNodeWithActiveScrollSnap): (WebKit::RemoteScrollingUIState::addNodeWithActiveUserScroll): (WebKit::RemoteScrollingUIState::removeNodeWithActiveUserScroll): * Shared/RemoteLayerTree/RemoteScrollingUIState.h: Added. (WebKit::RemoteScrollingUIState::changes const): (WebKit::RemoteScrollingUIState::clearChanges): (WebKit::RemoteScrollingUIState::nodesWithActiveScrollSnap const): (WebKit::RemoteScrollingUIState::nodesWithActiveUserScrolls const): * SourcesCocoa.txt: * UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp: (WebKit::RemoteScrollingCoordinatorProxy::RemoteScrollingCoordinatorProxy): (WebKit::RemoteScrollingCoordinatorProxy::sendUIStateChangedIfNecessary): * UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h: * UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp: (WebKit::RemoteScrollingTree::scrollingTreeNodeWillStartPanGesture): (WebKit::RemoteScrollingTree::scrollingTreeNodeWillStartScroll): (WebKit::RemoteScrollingTree::scrollingTreeNodeDidEndScroll): * UIProcess/RemoteLayerTree/RemoteScrollingTree.h: * UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm: (WebKit::RemoteScrollingCoordinatorProxy::scrollViewForScrollingNodeID const): (WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeWillStartPanGesture): (WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeWillStartScroll): (WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidEndScroll): * UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollWillStart const): (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollDidEnd const): (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewWillStartPanGesture const): * WebKit.xcodeproj/project.pbxproj: * WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.h: * WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.messages.in: * WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm: (WebKit::RemoteScrollingCoordinator::isUserScrollInProgress const): (WebKit::RemoteScrollingCoordinator::isScrollSnapInProgress const): (WebKit::RemoteScrollingCoordinator::scrollingStateInUIProcessChanged): LayoutTests: Reviewed by Tim Horton. * fast/scrolling/ios/adjust-scroll-snap-during-gesture-expected.txt: Added. * fast/scrolling/ios/adjust-scroll-snap-during-gesture.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h trunk/Source/WebCore/page/scrolling/ScrollingTree.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/SourcesCocoa.txt trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp
[webkit-changes] [264703] trunk/JSTests
Title: [264703] trunk/JSTests
Revision 264703
Author commit-qu...@webkit.org
Date 2020-07-22 10:17:00 -0700 (Wed, 22 Jul 2020)
Log Message
Skip failing intl tests on ARM
https://bugs.webkit.org/show_bug.cgi?id=214638
Unreviewed Gardening.
Patch by Angelos Oikonomopoulos on 2020-07-22
* stress/intl-displaynames.js:
* stress/intl-parse-unicode-subtags.js:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/intl-displaynames.js
trunk/JSTests/stress/intl-parse-unicode-subtags.js
Diff
Modified: trunk/JSTests/ChangeLog (264702 => 264703)
--- trunk/JSTests/ChangeLog 2020-07-22 16:51:00 UTC (rev 264702)
+++ trunk/JSTests/ChangeLog 2020-07-22 17:17:00 UTC (rev 264703)
@@ -1,3 +1,13 @@
+2020-07-22 Angelos Oikonomopoulos
+
+Skip failing intl tests on ARM
+https://bugs.webkit.org/show_bug.cgi?id=214638
+
+Unreviewed Gardening.
+
+* stress/intl-displaynames.js:
+* stress/intl-parse-unicode-subtags.js:
+
2020-07-21 Michael Catanzaro
REGRESSION(r264330): infinite loop in JSC stress tests using cloop
Modified: trunk/JSTests/stress/intl-displaynames.js (264702 => 264703)
--- trunk/JSTests/stress/intl-displaynames.js 2020-07-22 16:51:00 UTC (rev 264702)
+++ trunk/JSTests/stress/intl-displaynames.js 2020-07-22 17:17:00 UTC (rev 264703)
@@ -1,4 +1,5 @@
//@ runDefault("--useIntlDisplayNames=1")
+//@ skip if $architecture == "arm"
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error('bad value: ' + actual);
Modified: trunk/JSTests/stress/intl-parse-unicode-subtags.js (264702 => 264703)
--- trunk/JSTests/stress/intl-parse-unicode-subtags.js 2020-07-22 16:51:00 UTC (rev 264702)
+++ trunk/JSTests/stress/intl-parse-unicode-subtags.js 2020-07-22 17:17:00 UTC (rev 264703)
@@ -1,4 +1,5 @@
//@ runDefault("--useIntlDisplayNames=1")
+//@ skip if $architecture == "arm"
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error('bad value: ' + actual);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264702] trunk/LayoutTests
Title: [264702] trunk/LayoutTests Revision 264702 Author tsav...@apple.com Date 2020-07-22 09:51:00 -0700 (Wed, 22 Jul 2020) Log Message [ macOS ] imported/w3c/web-platform-tests/css/css-pseudo/marker-hit-testing.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=214643 Unreviewed test gardening. Patch by Hector Lopez on 2020-07-22 * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (264701 => 264702) --- trunk/LayoutTests/ChangeLog 2020-07-22 16:28:17 UTC (rev 264701) +++ trunk/LayoutTests/ChangeLog 2020-07-22 16:51:00 UTC (rev 264702) @@ -1,3 +1,12 @@ +2020-07-22 Hector Lopez + +[ macOS ] imported/w3c/web-platform-tests/css/css-pseudo/marker-hit-testing.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=214643 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2020-07-22 Commit Queue Unreviewed, reverting r264691. Modified: trunk/LayoutTests/platform/mac/TestExpectations (264701 => 264702) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-07-22 16:28:17 UTC (rev 264701) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-07-22 16:51:00 UTC (rev 264702) @@ -1931,3 +1931,5 @@ webkit.org/b/214512 imported/w3c/web-platform-tests/css/geometry/DOMMatrix2DInit-validate-fixup.html [ Failure ] +webkit.org/b/214643 imported/w3c/web-platform-tests/css/css-pseudo/marker-hit-testing.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264701] trunk/Source/WebKit
Title: [264701] trunk/Source/WebKit
Revision 264701
Author ddkil...@apple.com
Date 2020-07-22 09:28:17 -0700 (Wed, 22 Jul 2020)
Log Message
[IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type
Reviewed by Youenn Fablet.
* Shared/mac/ObjCObjectGraph.h:
- Drive-by fix to use #pragma once. This is included in some
plain C++ source files.
* Shared/mac/ObjCObjectGraph.mm:
(WebKit::ObjCType):
- Move enum definition to the top of the file so that the
EnumTraits<> can be defined after it, but before it's used.
(WTF::EnumTraits): Add.
- Define so that IPC::Decoder and IPC::Encoder can validate enum
values.
(WebKit::ObjCObjectGraph::encode):
- Encode using WebKit::ObjCType value.
- Add ObjCType::Null label so that default: label can be
removed. Change break statements to early return statements.
- Move ASSERT_NOT_REACHED() to the end of the method.
(WebKit::ObjCObjectGraph::decode):
- Decode using WebKit::ObjCType value.
- Change break statements to early return statements.
- Remove default: label, and move `return false` to the end of
the method. Add ASSERT_NOT_REACHED().
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.h
trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (264700 => 264701)
--- trunk/Source/WebKit/ChangeLog 2020-07-22 16:21:15 UTC (rev 264700)
+++ trunk/Source/WebKit/ChangeLog 2020-07-22 16:28:17 UTC (rev 264701)
@@ -1,3 +1,33 @@
+2020-07-22 David Kilzer
+
+[IPC hardening] WebKit::ObjCObjectGraph::decode() and encode() should use enum ObjCType type
+
+
+
+Reviewed by Youenn Fablet.
+
+* Shared/mac/ObjCObjectGraph.h:
+- Drive-by fix to use #pragma once. This is included in some
+ plain C++ source files.
+
+* Shared/mac/ObjCObjectGraph.mm:
+(WebKit::ObjCType):
+- Move enum definition to the top of the file so that the
+ EnumTraits<> can be defined after it, but before it's used.
+(WTF::EnumTraits): Add.
+- Define so that IPC::Decoder and IPC::Encoder can validate enum
+ values.
+(WebKit::ObjCObjectGraph::encode):
+- Encode using WebKit::ObjCType value.
+- Add ObjCType::Null label so that default: label can be
+ removed. Change break statements to early return statements.
+- Move ASSERT_NOT_REACHED() to the end of the method.
+(WebKit::ObjCObjectGraph::decode):
+- Decode using WebKit::ObjCType value.
+- Change break statements to early return statements.
+- Remove default: label, and move `return false` to the end of
+ the method. Add ASSERT_NOT_REACHED().
+
2020-07-22 Megan Gardner
Tapped DataDetected links present sub-menus from the wrong location.
Modified: trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.h (264700 => 264701)
--- trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.h 2020-07-22 16:21:15 UTC (rev 264700)
+++ trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.h 2020-07-22 16:28:17 UTC (rev 264701)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2020 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -23,8 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef ObjCObjectGraph_h
-#define ObjCObjectGraph_h
+#pragma once
#include "APIObject.h"
#include
@@ -70,5 +69,3 @@
};
} // namespace WebKit
-
-#endif // ObjCObjectGraph_h
Modified: trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm (264700 => 264701)
--- trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm 2020-07-22 16:21:15 UTC (rev 264700)
+++ trunk/Source/WebKit/Shared/mac/ObjCObjectGraph.mm 2020-07-22 16:28:17 UTC (rev 264701)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2020 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -33,10 +33,48 @@
#import "WKAPICast.h"
#import "WKBrowsingContextHandleInternal.h"
#import "WKTypeRefWrapper.h"
+#import
#import
namespace WebKit {
+enum class ObjCType : uint8_t {
+Null,
+
+NSArray,
+NSData,
+NSDate,
+NSDictionary,
+NSNumber,
+NSString,
+
+WKBrowsingContextHandle,
+WKTypeRefWrapper,
+};
+
+} // namespace WebKit
+
+namespace WTF {
+
+template<> struct EnumTraits {
+using values = EnumValues<
+WebKit::ObjCType,
+WebKit::ObjCType::Null,
+WebKit::ObjCType::NSArray,
+WebKit::ObjCType::NSData,
+WebKit::ObjCType::NSDate,
+WebKit::ObjCType::NSDictionary,
+WebKit::ObjCType::NSNumber,
+WebKit::ObjCType::NSString,
+
[webkit-changes] [264700] trunk
Title: [264700] trunk Revision 264700 Author commit-qu...@webkit.org Date 2020-07-22 09:21:15 -0700 (Wed, 22 Jul 2020) Log Message Unreviewed, reverting r264691. https://bugs.webkit.org/show_bug.cgi?id=214642 Regressed fast/mediastream/captureStream/canvas3d.html Reverted changeset: "[WebGL2] Implement multiple render target entry points" https://bugs.webkit.org/show_bug.cgi?id=211156 https://trac.webkit.org/changeset/264691 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt trunk/LayoutTests/webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.h trunk/Source/WebCore/html/canvas/WebGLFramebuffer.cpp trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp trunk/Source/WebCore/platform/graphics/GraphicsContextGL.h trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp Diff Modified: trunk/LayoutTests/ChangeLog (264699 => 264700) --- trunk/LayoutTests/ChangeLog 2020-07-22 16:09:52 UTC (rev 264699) +++ trunk/LayoutTests/ChangeLog 2020-07-22 16:21:15 UTC (rev 264700) @@ -1,3 +1,16 @@ +2020-07-22 Commit Queue + +Unreviewed, reverting r264691. +https://bugs.webkit.org/show_bug.cgi?id=214642 + +Regressed fast/mediastream/captureStream/canvas3d.html + +Reverted changeset: + +"[WebGL2] Implement multiple render target entry points" +https://bugs.webkit.org/show_bug.cgi?id=211156 +https://trac.webkit.org/changeset/264691 + 2020-07-22 Youenn Fablet KeepAlive fetch should not be blocked in pagehide event handlers Modified: trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt (264699 => 264700) --- trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt 2020-07-22 16:09:52 UTC (rev 264699) +++ trunk/LayoutTests/fast/canvas/webgl/webgl2/sequences-expected.txt 2020-07-22 16:21:15 UTC (rev 264700) @@ -2,12 +2,6 @@ CONSOLE MESSAGE: WebGL: INVALID_VALUE: vertexAttribI4iv: array too small CONSOLE MESSAGE: WebGL: INVALID_VALUE: vertexAttribI4uiv: array too small CONSOLE MESSAGE: WebGL: INVALID_VALUE: vertexAttribI4uiv: array too small -CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferiv: invalid array size / srcOffset -CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferiv: invalid array size / srcOffset -CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferuiv: invalid array size / srcOffset -CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferuiv: invalid array size / srcOffset -CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferfv: invalid array size / srcOffset -CONSOLE MESSAGE: WebGL: INVALID_VALUE: clearBufferfv: invalid array size / srcOffset PASS uniform1uiv data with typed array of type ui PASS uniform1uiv data with sequence of type ui Modified: trunk/LayoutTests/webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt (264699 => 264700) --- trunk/LayoutTests/webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt 2020-07-22 16:09:52 UTC (rev 264699) +++ trunk/LayoutTests/webgl/2.0.0/conformance2/reading/read-pixels-from-fbo-test-expected.txt 2020-07-22 16:21:15 UTC (rev 264700) @@ -1,5 +1,200 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance2/reading/read-pixels-from-fbo-test.html -[ PASS ] All tests passed +[ 1: PASS ] getError was expected value: NO_ERROR : Setting up fbo should generate no error +[ 2: PASS ] getError was expected value: NO_ERROR : Clear color should generate no error +[ 3: PASS ] getError was expected value: NO_ERROR : readPixels should generate no error +[ 4: PASS ] Color read back as expected +[ 5: PASS ] getError was expected value: NO_ERROR : readPixels should generate no error +[ 6: PASS ] Color read back as expected +[ 7: PASS ] getError was expected value: NO_ERROR : Setting up fbo should generate no error +[ 8: PASS ] getError was expected value: NO_ERROR : Clear color should generate no error +[ 9: PASS ] getError was expected value: NO_ERROR : readPixels should generate no error +[ 10: FAIL ] Expected color = 250,0,0,0, was = 0,0,0,1 +[ 11: PASS ] getError was expected value: NO_ERROR : readPixels should generate no error +[ 12: FAIL ] Expected color = 250,0,0,0, was = 0 +[ 13: PASS ] getError was expected value: NO_ERROR : Setting up fbo should generate no error +[ 14: PASS ] getError was expected value: NO_ERROR : Clear color should generate no error +[ 15: PASS ] getError was expected value: NO_ERROR : readPixels should generate no error +[ 16: FAIL ] Expected color =
[webkit-changes] [264699] trunk/Source/WebKit
Title: [264699] trunk/Source/WebKit
Revision 264699
Author megan_gard...@apple.com
Date 2020-07-22 09:09:52 -0700 (Wed, 22 Jul 2020)
Log Message
Tapped DataDetected links present sub-menus from the wrong location.
https://bugs.webkit.org/show_bug.cgi?id=214628
When getting the positionInformation associated with presenting DataDetectors UI
we were not indicating that we need the linkIndicator data. This caused the
resulting CGRect to not be filled out, and we were returning a zeroed out CGRect
to the DataDetectors framework for the location that it should present the subMenu from.
Setting this bit ensures that all the necessary data is calculated and returned
when a DataDetector link is tapped.
Reviewed by Wenson Hsieh.
* WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::showDataDetectorsUIForElement):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (264698 => 264699)
--- trunk/Source/WebKit/ChangeLog 2020-07-22 15:59:56 UTC (rev 264698)
+++ trunk/Source/WebKit/ChangeLog 2020-07-22 16:09:52 UTC (rev 264699)
@@ -1,3 +1,21 @@
+2020-07-22 Megan Gardner
+
+Tapped DataDetected links present sub-menus from the wrong location.
+https://bugs.webkit.org/show_bug.cgi?id=214628
+
+
+When getting the positionInformation associated with presenting DataDetectors UI
+we were not indicating that we need the linkIndicator data. This caused the
+resulting CGRect to not be filled out, and we were returning a zeroed out CGRect
+to the DataDetectors framework for the location that it should present the subMenu from.
+Setting this bit ensures that all the necessary data is calculated and returned
+when a DataDetector link is tapped.
+
+Reviewed by Wenson Hsieh.
+
+* WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
+(WebKit::WebChromeClient::showDataDetectorsUIForElement):
+
2020-07-22 Carlos Garcia Campos
[GTK][WPE] ITP: use the database store unconditionally
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm (264698 => 264699)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm 2020-07-22 15:59:56 UTC (rev 264698)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm 2020-07-22 16:09:52 UTC (rev 264699)
@@ -203,7 +203,9 @@
// FIXME: Ideally, we would be able to generate InteractionInformationAtPosition without re-hit-testing the element.
auto& mouseEvent = downcast(event);
-auto positionInformation = m_page.positionInformation(InteractionInformationRequest { roundedIntPoint(mouseEvent.locationInRootViewCoordinates()) });
+auto request = InteractionInformationRequest { roundedIntPoint(mouseEvent.locationInRootViewCoordinates()) };
+request.includeLinkIndicator = true;
+auto positionInformation = m_page.positionInformation(request);
m_page.send(Messages::WebPageProxy::ShowDataDetectorsUIForPositionInformation(positionInformation));
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264698] trunk
Title: [264698] trunk Revision 264698 Author you...@apple.com Date 2020-07-22 08:59:56 -0700 (Wed, 22 Jul 2020) Log Message KeepAlive fetch should not be blocked in pagehide event handlers https://bugs.webkit.org/show_bug.cgi?id=214630 Reviewed by Chris Dumez. Source/WebCore: Test: http/wpt/fetch/fetch-in-pagehide.html * loader/cache/CachedResource.cpp: (WebCore::CachedResource::load): Allow keep alive fetches to proceed similarly to ping loads. LayoutTests: * http/wpt/fetch/fetch-in-pagehide-expected.txt: Added. * http/wpt/fetch/fetch-in-pagehide.html: Added. * http/wpt/fetch/resources/fetch-in-pagehide-window.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/cache/CachedResource.cpp Added Paths trunk/LayoutTests/http/wpt/fetch/fetch-in-pagehide-expected.txt trunk/LayoutTests/http/wpt/fetch/fetch-in-pagehide.html trunk/LayoutTests/http/wpt/fetch/resources/fetch-in-pagehide-window.html Diff Modified: trunk/LayoutTests/ChangeLog (264697 => 264698) --- trunk/LayoutTests/ChangeLog 2020-07-22 15:23:00 UTC (rev 264697) +++ trunk/LayoutTests/ChangeLog 2020-07-22 15:59:56 UTC (rev 264698) @@ -1,3 +1,15 @@ +2020-07-22 Youenn Fablet + +KeepAlive fetch should not be blocked in pagehide event handlers +https://bugs.webkit.org/show_bug.cgi?id=214630 + + +Reviewed by Chris Dumez. + +* http/wpt/fetch/fetch-in-pagehide-expected.txt: Added. +* http/wpt/fetch/fetch-in-pagehide.html: Added. +* http/wpt/fetch/resources/fetch-in-pagehide-window.html: Added. + 2020-07-22 Diego Pino Garcia [GTK] Unreviewed test gardening. Update test expectations after r264694. Added: trunk/LayoutTests/http/wpt/fetch/fetch-in-pagehide-expected.txt (0 => 264698) --- trunk/LayoutTests/http/wpt/fetch/fetch-in-pagehide-expected.txt (rev 0) +++ trunk/LayoutTests/http/wpt/fetch/fetch-in-pagehide-expected.txt 2020-07-22 15:59:56 UTC (rev 264698) @@ -0,0 +1,4 @@ + +PASS Test that fetch sent from pagehide event handler is properly received with keepalive +PASS Test that fetch sent from pagehide event handler is not received with no keepalive + Added: trunk/LayoutTests/http/wpt/fetch/fetch-in-pagehide.html (0 => 264698) --- trunk/LayoutTests/http/wpt/fetch/fetch-in-pagehide.html (rev 0) +++ trunk/LayoutTests/http/wpt/fetch/fetch-in-pagehide.html 2020-07-22 15:59:56 UTC (rev 264698) @@ -0,0 +1,53 @@ + + + + +Fetch in pagehide + + +