[webkit-changes] [270470] trunk/Source/WebKit
Title: [270470] trunk/Source/WebKit
Revision 270470
Author s...@apple.com
Date 2020-12-04 21:59:55 -0800 (Fri, 04 Dec 2020)
Log Message
[GPU Process] Remove ConcreteShareableImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=219563
Reviewed by Simon Fraser.
Delete this class since the only function it implements:
'createImageBufferBackendHandle()' is not used.
* Shared/ConcreteShareableImageBuffer.h: Removed.
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
Removed Paths
trunk/Source/WebKit/Shared/ConcreteShareableImageBuffer.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (270469 => 270470)
--- trunk/Source/WebKit/ChangeLog 2020-12-05 05:49:30 UTC (rev 270469)
+++ trunk/Source/WebKit/ChangeLog 2020-12-05 05:59:55 UTC (rev 270470)
@@ -1,3 +1,17 @@
+2020-12-04 Said Abou-Hallawa
+
+[GPU Process] Remove ConcreteShareableImageBuffer
+https://bugs.webkit.org/show_bug.cgi?id=219563
+
+Reviewed by Simon Fraser.
+
+Delete this class since the only function it implements:
+'createImageBufferBackendHandle()' is not used.
+
+* Shared/ConcreteShareableImageBuffer.h: Removed.
+* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
+
2020-12-04 Wenson Hsieh
[iOS] Cancel image extraction when navigating
Deleted: trunk/Source/WebKit/Shared/ConcreteShareableImageBuffer.h (270469 => 270470)
--- trunk/Source/WebKit/Shared/ConcreteShareableImageBuffer.h 2020-12-05 05:49:30 UTC (rev 270469)
+++ trunk/Source/WebKit/Shared/ConcreteShareableImageBuffer.h 2020-12-05 05:59:55 UTC (rev 270470)
@@ -1,52 +0,0 @@
-/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#pragma once
-
-#include "ImageBufferBackendHandle.h"
-#include
-
-namespace WebKit {
-
-template
-class ConcreteShareableImageBuffer : public WebCore::ConcreteImageBuffer {
-using BaseConcreteImageBuffer = WebCore::ConcreteImageBuffer;
-using BaseConcreteImageBuffer::m_backend;
-
-public:
-static auto create(const WebCore::FloatSize& size, float resolutionScale, WebCore::ColorSpace colorSpace, WebCore::PixelFormat pixelFormat)
-{
-return BaseConcreteImageBuffer::template create(size, resolutionScale, colorSpace, pixelFormat, nullptr);
-}
-
-using BaseConcreteImageBuffer::BaseConcreteImageBuffer;
-
-ImageBufferBackendHandle createImageBufferBackendHandle()
-{
-return m_backend->createImageBufferBackendHandle();
-}
-};
-
-} // namespace WebKit
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (270469 => 270470)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2020-12-05 05:49:30 UTC (rev 270469)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2020-12-05 05:59:55 UTC (rev 270470)
@@ -27,7 +27,6 @@
#import "RemoteLayerBackingStore.h"
#import "ArgumentCoders.h"
-#import "ConcreteShareableImageBuffer.h"
#import "MachPort.h"
#import "PlatformCALayerRemote.h"
#import "PlatformRemoteImageBufferProxy.h"
@@ -181,15 +180,14 @@
if (m_frontBuffer.imageBuffer)
return;
-if (WebProcess::singleton().shouldUseRemoteRenderingFor(WebCore::RenderingPurpose::DOM)) {
-m_frontBuffer.imageBuffer = m_layer->context()->ensureRemoteRenderingBackendProxy().createImageBuffer(backingStoreSize(), m_acceleratesDrawing ? WebCore::RenderingMode::Accelerated : WebCore::RenderingMode::Unaccelerated, 1,
[webkit-changes] [270469] trunk/LayoutTests
Title: [270469] trunk/LayoutTests Revision 270469 Author lmo...@igalia.com Date 2020-12-04 21:49:30 -0800 (Fri, 04 Dec 2020) Log Message [GLIB] Gardening media-source timeouts Unreviewed test gardening. * platform/glib/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (270468 => 270469) --- trunk/LayoutTests/ChangeLog 2020-12-05 01:26:45 UTC (rev 270468) +++ trunk/LayoutTests/ChangeLog 2020-12-05 05:49:30 UTC (rev 270469) @@ -1,3 +1,11 @@ +2020-12-04 Lauro Moura + +[GLIB] Gardening media-source timeouts + +Unreviewed test gardening. + +* platform/glib/TestExpectations: + 2020-12-04 Zalan Bujtas [LFC][IFC] Add support for intrusive floats when line gets stretched vertically Modified: trunk/LayoutTests/platform/glib/TestExpectations (270468 => 270469) --- trunk/LayoutTests/platform/glib/TestExpectations 2020-12-05 01:26:45 UTC (rev 270468) +++ trunk/LayoutTests/platform/glib/TestExpectations 2020-12-05 05:49:30 UTC (rev 270469) @@ -426,7 +426,7 @@ webkit.org/b/203078 media/media-source/media-source-remove-unload-crash.html [ Crash Timeout Pass ] webkit.org/b/210528 media/media-source/media-source-seek-back.html [ Crash Pass ] webkit.org/b/214636 media/media-source/media-source-webm.html [ Timeout Crash ] -webkit.org/b/218317 media/media-source/media-source-trackid-change.html [ Failure ] +webkit.org/b/218317 webkit.org/b/219565 media/media-source/media-source-trackid-change.html [ Failure Timeout ] webkit.org/b/210528 media/video-src-blob-replay.html [ Crash Pass ] @@ -451,6 +451,40 @@ webkit.org/b/219245 webrtc/peer-connection-remote-audio-mute.html [ Crash ] webkit.org/b/219245 webrtc/peer-connection-remote-audio-mute2.html [ Crash ] +webkit.org/b/219565 media/media-source/media-source-abort-resets-parser.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-canplaythrough-event.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-error-crash.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-paint-to-canvas.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-remove-crash.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-resize.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-samples-resolution-change.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-seek-detach-crash.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-seek-redundant-append.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-seek-twice.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-unnecessary-seek-seeked.html [ Timeout ] +webkit.org/b/219565 media/media-source/media-source-webm-init-inside-segment.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.https.html [ Timeout ] +webkit.org/b/219565 imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.https.html [ Timeout ] +webkit.org/b/219565
[webkit-changes] [270468] trunk/Source/WebCore
Title: [270468] trunk/Source/WebCore Revision 270468 Author cdu...@apple.com Date 2020-12-04 17:26:45 -0800 (Fri, 04 Dec 2020) Log Message Simplify audio resampling code https://bugs.webkit.org/show_bug.cgi?id=219560 Reviewed by Darin Adler. Made the following changes to simplify / improve the resampling code: - MultiChannelResampler & SincResampler now take a lambda upon construction to fetch input data, instead of taking a AudioSourceProvider pointer whenever process() is called. - We can now get rid of the whole MultiChannelResampler::ChannelProvider class and have the lambda call MultiChannelResampler::provideInputForChannel() instead. Similarly, we can also get rid of SincResampler's BufferSourceProvider. - As an optimization, MultiChannelResampler::process() now has a fast path when the AudioBus only has a single channel, to avoid the processing-in-chunks logic. The chunking logic is only needed when there are multiple channels, to make sure that provideInputForChannel() only gets called once per channel, to avoid confusing its logic. This is similar to what Chromium does. * Modules/webaudio/MediaElementAudioSourceNode.cpp: (WebCore::MediaElementAudioSourceNode::setFormat): (WebCore::MediaElementAudioSourceNode::provideInput): (WebCore::MediaElementAudioSourceNode::process): * Modules/webaudio/MediaElementAudioSourceNode.h: * Modules/webaudio/MediaStreamAudioSourceNode.cpp: (WebCore::MediaStreamAudioSourceNode::setFormat): (WebCore::MediaStreamAudioSourceNode::provideInput): (WebCore::MediaStreamAudioSourceNode::process): * Modules/webaudio/MediaStreamAudioSourceNode.h: * platform/audio/AudioBus.cpp: (WebCore::AudioBus::createBySampleRateConverting): * platform/audio/MultiChannelResampler.cpp: (WebCore::MultiChannelResampler::MultiChannelResampler): (WebCore::MultiChannelResampler::process): (WebCore::MultiChannelResampler::provideInputForChannel): * platform/audio/MultiChannelResampler.h: * platform/audio/SincResampler.cpp: (WebCore::SincResampler::SincResampler): (WebCore::SincResampler::processBuffer): (WebCore::SincResampler::process): * platform/audio/SincResampler.h: * platform/audio/cocoa/AudioDestinationCocoa.cpp: (WebCore::AudioDestinationCocoa::AudioDestinationCocoa): (WebCore::AudioDestinationCocoa::renderOnRenderingThead): * platform/audio/cocoa/AudioDestinationCocoa.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h trunk/Source/WebCore/platform/audio/AudioBus.cpp trunk/Source/WebCore/platform/audio/MultiChannelResampler.cpp trunk/Source/WebCore/platform/audio/MultiChannelResampler.h trunk/Source/WebCore/platform/audio/SincResampler.cpp trunk/Source/WebCore/platform/audio/SincResampler.h trunk/Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp trunk/Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.h Diff Modified: trunk/Source/WebCore/ChangeLog (270467 => 270468) --- trunk/Source/WebCore/ChangeLog 2020-12-05 00:55:25 UTC (rev 270467) +++ trunk/Source/WebCore/ChangeLog 2020-12-05 01:26:45 UTC (rev 270468) @@ -1,3 +1,51 @@ +2020-12-04 Chris Dumez + +Simplify audio resampling code +https://bugs.webkit.org/show_bug.cgi?id=219560 + +Reviewed by Darin Adler. + +Made the following changes to simplify / improve the resampling code: +- MultiChannelResampler & SincResampler now take a lambda upon construction + to fetch input data, instead of taking a AudioSourceProvider pointer + whenever process() is called. +- We can now get rid of the whole MultiChannelResampler::ChannelProvider + class and have the lambda call MultiChannelResampler::provideInputForChannel() + instead. Similarly, we can also get rid of SincResampler's BufferSourceProvider. +- As an optimization, MultiChannelResampler::process() now has a fast path + when the AudioBus only has a single channel, to avoid the + processing-in-chunks logic. The chunking logic is only needed when there + are multiple channels, to make sure that provideInputForChannel() only gets + called once per channel, to avoid confusing its logic. This is similar to + what Chromium does. + +* Modules/webaudio/MediaElementAudioSourceNode.cpp: +(WebCore::MediaElementAudioSourceNode::setFormat): +(WebCore::MediaElementAudioSourceNode::provideInput): +(WebCore::MediaElementAudioSourceNode::process): +* Modules/webaudio/MediaElementAudioSourceNode.h: +* Modules/webaudio/MediaStreamAudioSourceNode.cpp: +(WebCore::MediaStreamAudioSourceNode::setFormat): +(WebCore::MediaStreamAudioSourceNode::provideInput): +
[webkit-changes] [270467] trunk/Source/WebKit
Title: [270467] trunk/Source/WebKit Revision 270467 Author wenson_hs...@apple.com Date 2020-12-04 16:55:25 -0800 (Fri, 04 Dec 2020) Log Message [iOS] Cancel image extraction when navigating https://bugs.webkit.org/show_bug.cgi?id=219559 Reviewed by Tim Horton. Call `-_cancelImageExtraction` during mainframe navigation. See WebKitAdditions change for more information. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _webTouchEventsRecognized:]): (-[WKContentView _didStartProvisionalLoadForMainFrame]): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: trunk/Source/WebKit/ChangeLog (270466 => 270467) --- trunk/Source/WebKit/ChangeLog 2020-12-05 00:28:31 UTC (rev 270466) +++ trunk/Source/WebKit/ChangeLog 2020-12-05 00:55:25 UTC (rev 270467) @@ -1,3 +1,17 @@ +2020-12-04 Wenson Hsieh + +[iOS] Cancel image extraction when navigating +https://bugs.webkit.org/show_bug.cgi?id=219559 + + +Reviewed by Tim Horton. + +Call `-_cancelImageExtraction` during mainframe navigation. See WebKitAdditions change for more information. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView _webTouchEventsRecognized:]): +(-[WKContentView _didStartProvisionalLoadForMainFrame]): + 2020-12-04 Jer Noble [Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (270466 => 270467) --- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-12-05 00:28:31 UTC (rev 270466) +++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2020-12-05 00:55:25 UTC (rev 270467) @@ -1523,7 +1523,7 @@ } forRequest:positionInformationRequest]; #if ENABLE(IMAGE_EXTRACTION) -[self _cancelImageExtractionIfNeeded:_lastInteractionLocation]; +[self _cancelImageExtractionIfNeededAfterTouchAt:_lastInteractionLocation]; #endif } @@ -4376,6 +4376,9 @@ // in the same location to trigger double-tap recognition. [self _setDoubleTapGesturesEnabled:NO]; [_twoFingerDoubleTapGestureRecognizer _wk_cancel]; +#if ENABLE(IMAGE_EXTRACTION) +[self _cancelImageExtraction]; +#endif } - (void)_didCommitLoadForMainFrame ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270466] trunk/Tools
Title: [270466] trunk/Tools
Revision 270466
Author jbed...@apple.com
Date 2020-12-04 16:28:31 -0800 (Fri, 04 Dec 2020)
Log Message
[webkitscmpy] local.Svn reports incorrect timestamps
https://bugs.webkit.org/show_bug.cgi?id=219549
Rubber-stamped by Aakash Jain.
* Scripts/libraries/webkitscmpy/setup.py: Remote dateutil dependency. Add svn remote dependencies.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version, move dateutil library hook.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
(Svn.commit): Increment parsed time by UTC delta instead of configuring timezone.
* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:
(Svn): Allow caller to specify UTC offset, treat all times as UTC to avoid issues with the
local timezone.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
* Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
(TestLocalSvn.test_info):
* Scripts/webkitpy/__init__.py: Move dateutil library hook.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py
trunk/Tools/Scripts/webkitpy/__init__.py
Diff
Modified: trunk/Tools/ChangeLog (270465 => 270466)
--- trunk/Tools/ChangeLog 2020-12-04 23:39:14 UTC (rev 270465)
+++ trunk/Tools/ChangeLog 2020-12-05 00:28:31 UTC (rev 270466)
@@ -1,3 +1,23 @@
+2020-12-04 Jonathan Bedard
+
+[webkitscmpy] local.Svn reports incorrect timestamps
+https://bugs.webkit.org/show_bug.cgi?id=219549
+
+
+Rubber-stamped by Aakash Jain.
+
+* Scripts/libraries/webkitscmpy/setup.py: Remote dateutil dependency. Add svn remote dependencies.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version, move dateutil library hook.
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
+(Svn.commit): Increment parsed time by UTC delta instead of configuring timezone.
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py:
+(Svn): Allow caller to specify UTC offset, treat all times as UTC to avoid issues with the
+local timezone.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/find_unittest.py:
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
+(TestLocalSvn.test_info):
+* Scripts/webkitpy/__init__.py: Move dateutil library hook.
+
2020-12-04 John Wilander
PCM: Switch to 8+4 bits for source IDs and trigger values respectively
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (270465 => 270466)
--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2020-12-04 23:39:14 UTC (rev 270465)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py 2020-12-05 00:28:31 UTC (rev 270466)
@@ -56,7 +56,7 @@
'webkitscmpy.test',
],
scripts=['git-webkit'],
-install_requires=['python-dateutil', 'webkitcorepy'],
+install_requires=['fasteners', 'monotonic', 'webkitcorepy', 'xmltodict'],
include_package_data=True,
zip_safe=False,
)
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (270465 => 270466)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2020-12-04 23:39:14 UTC (rev 270465)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py 2020-12-05 00:28:31 UTC (rev 270466)
@@ -46,9 +46,8 @@
"Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
)
-version = Version(0, 5, 0)
+version = Version(0, 5, 1)
-AutoInstall.register(Package('dateutil', Version(2, 8, 1), pypi_name='python-dateutil'))
AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
AutoInstall.register(Package('monotonic', Version(1, 5)))
AutoInstall.register(Package('xmltodict', Version(0, 12, 0)))
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py (270465 => 270466)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py 2020-12-04 23:39:14 UTC (rev 270465)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py 2020-12-05 00:28:31 UTC (rev 270466)
@@ -30,7 +30,6 @@
import sys
from datetime import datetime, timedelta
-from dateutil import tz
from webkitcorepy import log, run, decorators
from webkitscmpy.local.scm import Scm
@@ -331,16 +330,10 @@
date = info['Last Changed Date'].split(' (')[0]
tz_diff = date.split(' ')[-1]
date = datetime.strptime(date[:-len(tz_diff)], '%Y-%m-%d %H:%M:%S ')
-delta = timedelta(
+date += timedelta(
hours=int(tz_diff[1:3]),
minutes=int(tz_diff[3:5]),
-)
-
[webkit-changes] [270465] tags/Safari-610.3.7.1.9/
Title: [270465] tags/Safari-610.3.7.1.9/ Revision 270465 Author repst...@apple.com Date 2020-12-04 15:39:14 -0800 (Fri, 04 Dec 2020) Log Message Tag Safari-610.3.7.1.9. Added Paths tags/Safari-610.3.7.1.9/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270464] trunk
Title: [270464] trunk
Revision 270464
Author za...@apple.com
Date 2020-12-04 15:37:36 -0800 (Fri, 04 Dec 2020)
Log Message
[LFC][IFC] Add support for intrusive floats when line gets stretched vertically
https://bugs.webkit.org/show_bug.cgi?id=219528
Reviewed by Antti Koivisto.
Source/WebCore:
This patch adds supports for cases when the the candidate content stretches the line vertically
and we need to check if additional floats are getting in the way and adjust the available horizontal width accordingly.
Test: fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::hasInlineLevelBox const):
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
(WebCore::Layout::LineCandidate::InlineContent::reset):
(WebCore::Layout::LineBuilder::handleInlineContent):
LayoutTests:
* fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple-expected.html: Added.
* fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
Added Paths
trunk/LayoutTests/fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple-expected.html
trunk/LayoutTests/fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html
Diff
Modified: trunk/LayoutTests/ChangeLog (270463 => 270464)
--- trunk/LayoutTests/ChangeLog 2020-12-04 22:58:36 UTC (rev 270463)
+++ trunk/LayoutTests/ChangeLog 2020-12-04 23:37:36 UTC (rev 270464)
@@ -1,3 +1,13 @@
+2020-12-04 Zalan Bujtas
+
+[LFC][IFC] Add support for intrusive floats when line gets stretched vertically
+https://bugs.webkit.org/show_bug.cgi?id=219528
+
+Reviewed by Antti Koivisto.
+
+* fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple-expected.html: Added.
+* fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html: Added.
+
2020-12-04 Truitt Savell
[ Mac ] inspector/animation/effectChanged.html is a flaky timeout
Added: trunk/LayoutTests/fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple-expected.html (0 => 270464)
--- trunk/LayoutTests/fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple-expected.html (rev 0)
+++ trunk/LayoutTests/fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple-expected.html 2020-12-04 23:37:36 UTC (rev 270464)
@@ -0,0 +1,20 @@
+
+
+div {
+ background-color: green;
+ height: 50px;
+}
+.inline_content {
+ font-size: 20px;
+ font-family: ahem;
+ background-color: white;
+ position: relative;
+ left: 100px;
+ top: -100px;
+}
+
+
+
+
+text
+
\ No newline at end of file
Added: trunk/LayoutTests/fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html (0 => 270464)
--- trunk/LayoutTests/fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html (rev 0)
+++ trunk/LayoutTests/fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html 2020-12-04 23:37:36 UTC (rev 270464)
@@ -0,0 +1,17 @@
+
+
+.floaty {
+ float: left;
+ background-color: green;
+ height: 50px;
+}
+.inline_content {
+ font-size: 20px;
+ font-family: ahem;
+}
+
+
+
+
+text
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (270463 => 270464)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 22:58:36 UTC (rev 270463)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 23:37:36 UTC (rev 270464)
@@ -1,3 +1,21 @@
+2020-12-04 Zalan Bujtas
+
+[LFC][IFC] Add support for intrusive floats when line gets stretched vertically
+https://bugs.webkit.org/show_bug.cgi?id=219528
+
+Reviewed by Antti Koivisto.
+
+This patch adds supports for cases when the the candidate content stretches the line vertically
+and we need to check if additional floats are getting in the way and adjust the available horizontal width accordingly.
+
+Test: fast/layoutformattingcontext/intrusive-floats-and-stretchy-lines-simple.html
+
+* layout/inlineformatting/InlineLineBuilder.cpp:
+(WebCore::Layout::LineCandidate::InlineContent::hasInlineLevelBox const):
+(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
+(WebCore::Layout::LineCandidate::InlineContent::reset):
+(WebCore::Layout::LineBuilder::handleInlineContent):
+
2020-12-04 Jer Noble
[Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp (270463 => 270464)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp 2020-12-04 22:58:36 UTC (rev 270463)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp 2020-12-04 23:37:36 UTC (rev
[webkit-changes] [270463] trunk/Source
Title: [270463] trunk/Source Revision 270463 Author jer.no...@apple.com Date 2020-12-04 14:58:36 -0800 (Fri, 04 Dec 2020) Log Message [Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio https://bugs.webkit.org/show_bug.cgi?id=219503 Reviewed by Eric Carlson. Source/WebCore: AudioConfiguration.spatialRendering is an Optional, so it both needs to be null-checked and also value checked. Additionally, WTF::allOf() will return true if the passed in container is empty, so empty-check that container in addition to checking its contents. * platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp: (WebCore::createMediaPlayerDecodingConfigurationCocoa): Source/WebCore/PAL: On macOS, clients who wish to query head tracking AVOutputDevice capabilities must use the sharedSystemAudioContext--not the sharedAudioPresentationOutputContext--to do so. This context requires a specific entitlement to use. In addition to querying -supportsHeadTrackedSpatialAudio, also query -allowsHeadTrackedSpatialAudio, if present, to determine whether the current route supports spatialization. * pal/avfoundation/OutputContext.mm: (PAL::OutputContext::sharedAudioPresentationOutputContext): * pal/avfoundation/OutputDevice.mm: (PAL::OutputDevice::supportsSpatialAudio const): * pal/spi/cocoa/AVFoundationSPI.h: Source/WebKit: Adopt the "com.apple.avfoundation.allow-system-wide-context" entitlement on macOS for both the WebContent and GPU processes. * Scripts/process-entitlements.sh: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/avfoundation/OutputContext.mm trunk/Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h trunk/Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Scripts/process-entitlements.sh Diff Modified: trunk/Source/WebCore/ChangeLog (270462 => 270463) --- trunk/Source/WebCore/ChangeLog 2020-12-04 22:57:47 UTC (rev 270462) +++ trunk/Source/WebCore/ChangeLog 2020-12-04 22:58:36 UTC (rev 270463) @@ -1,5 +1,20 @@ 2020-12-04 Jer Noble +[Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio +https://bugs.webkit.org/show_bug.cgi?id=219503 + +Reviewed by Eric Carlson. + +AudioConfiguration.spatialRendering is an Optional, so it both needs to be +null-checked and also value checked. Additionally, WTF::allOf() will return true if the +passed in container is empty, so empty-check that container in addition to checking its +contents. + +* platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp: +(WebCore::createMediaPlayerDecodingConfigurationCocoa): + +2020-12-04 Jer Noble + [GPUP] Move MediaCapabilities into the GPU process https://bugs.webkit.org/show_bug.cgi?id=219521 Modified: trunk/Source/WebCore/PAL/ChangeLog (270462 => 270463) --- trunk/Source/WebCore/PAL/ChangeLog 2020-12-04 22:57:47 UTC (rev 270462) +++ trunk/Source/WebCore/PAL/ChangeLog 2020-12-04 22:58:36 UTC (rev 270463) @@ -1,3 +1,24 @@ +2020-12-04 Jer Noble + +[Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio +https://bugs.webkit.org/show_bug.cgi?id=219503 + +Reviewed by Eric Carlson. + +On macOS, clients who wish to query head tracking AVOutputDevice capabilities must use the +sharedSystemAudioContext--not the sharedAudioPresentationOutputContext--to do so. This context +requires a specific entitlement to use. + +In addition to querying -supportsHeadTrackedSpatialAudio, also query +-allowsHeadTrackedSpatialAudio, if present, to determine whether the current route supports +spatialization. + +* pal/avfoundation/OutputContext.mm: +(PAL::OutputContext::sharedAudioPresentationOutputContext): +* pal/avfoundation/OutputDevice.mm: +(PAL::OutputDevice::supportsSpatialAudio const): +* pal/spi/cocoa/AVFoundationSPI.h: + 2020-12-04 Adam Roben More FALLBACK_PLATFORM adoption Modified: trunk/Source/WebCore/PAL/pal/avfoundation/OutputContext.mm (270462 => 270463) --- trunk/Source/WebCore/PAL/pal/avfoundation/OutputContext.mm 2020-12-04 22:57:47 UTC (rev 270462) +++ trunk/Source/WebCore/PAL/pal/avfoundation/OutputContext.mm 2020-12-04 22:58:36 UTC (rev 270463) @@ -49,7 +49,11 @@ if (![PAL::getAVOutputContextClass() respondsToSelector:@selector(sharedAudioPresentationOutputContext)]) return WTF::nullopt; +#if PLATFORM(MAC) || PLATFORM(MACCATALYST) +AVOutputContext* context = [getAVOutputContextClass() sharedSystemAudioContext]; +#else auto context = [getAVOutputContextClass() sharedAudioPresentationOutputContext]; +#endif if (!context) return WTF::nullopt; Modified: trunk/Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm (270462
[webkit-changes] [270462] trunk/Source
Title: [270462] trunk/Source Revision 270462 Author jer.no...@apple.com Date 2020-12-04 14:57:47 -0800 (Fri, 04 Dec 2020) Log Message [GPUP] Move MediaCapabilities into the GPU process https://bugs.webkit.org/show_bug.cgi?id=219521 Reviewed by Eric Carlson. Source/WebCore: Add encode() and decode() operations to all structs used inside MediaEngineConfigurationFactory. Add the ability for clients to provide their own factories for use in MediaEngineConfigurationFactory. * Headers.cmake: * WebCore.xcodeproj/project.pbxproj: * platform/MediaCapabilitiesDecodingInfo.h: (WebCore::MediaCapabilitiesDecodingInfo::encode const): (WebCore::MediaCapabilitiesDecodingInfo::decode): * platform/MediaCapabilitiesEncodingInfo.h: (WebCore::MediaCapabilitiesEncodingInfo::encode const): (WebCore::MediaCapabilitiesEncodingInfo::decode): * platform/MediaCapabilitiesInfo.h: (WebCore::MediaCapabilitiesInfo::encode const): (WebCore::MediaCapabilitiesInfo::decode): * platform/mediacapabilities/AudioConfiguration.h: (WebCore::AudioConfiguration::encode const): (WebCore::AudioConfiguration::decode): * platform/mediacapabilities/ColorGamut.h: * platform/mediacapabilities/HdrMetadataType.h: * platform/mediacapabilities/MediaCapabilitiesLogging.h: * platform/mediacapabilities/MediaConfiguration.h: (WebCore::MediaConfiguration::encode const): (WebCore::MediaConfiguration::decode): * platform/mediacapabilities/MediaDecodingConfiguration.h: (WebCore::MediaDecodingConfiguration::encode const): (WebCore::MediaDecodingConfiguration::decode): * platform/mediacapabilities/MediaDecodingType.h: * platform/mediacapabilities/MediaEncodingConfiguration.h: (WebCore::MediaEncodingConfiguration::encode const): (WebCore::MediaEncodingConfiguration::decode): * platform/mediacapabilities/MediaEncodingType.h: * platform/mediacapabilities/MediaEngineConfigurationFactory.cpp: (WebCore::defaultFactories): (WebCore::factories): (WebCore::MediaEngineConfigurationFactory::clearFactories): (WebCore::MediaEngineConfigurationFactory::resetFactories): (WebCore::MediaEngineConfigurationFactory::installFactory): (WebCore::MediaEngineConfigurationFactory::hasDecodingConfigurationFactory): (WebCore::MediaEngineConfigurationFactory::hasEncodingConfigurationFactory): * platform/mediacapabilities/MediaEngineConfigurationFactory.h: * platform/mediacapabilities/TransferFunction.h: * platform/mediacapabilities/VideoConfiguration.h: (WebCore::VideoConfiguration::encode const): (WebCore::VideoConfiguration::decode): Source/WebKit: Add a new pair of process supplements, RemoteMediaEngineConfigurationFactory and ..Proxy. * DerivedSources-input.xcfilelist: * DerivedSources-output.xcfilelist: * DerivedSources.make: * GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::mediaEngineConfigurationFactoryProxy): (WebKit::GPUConnectionToWebProcess::dispatchMessage): * GPUProcess/GPUConnectionToWebProcess.h: * GPUProcess/media/RemoteMediaEngineConfigurationFactoryProxy.cpp: Added. (WebKit::RemoteMediaEngineConfigurationFactoryProxy::RemoteMediaEngineConfigurationFactoryProxy): (WebKit::createDecodingConfiguration): (WebKit::RemoteMediaEngineConfigurationFactoryProxy::createEncodingConfiguration): * GPUProcess/media/RemoteMediaEngineConfigurationFactoryProxy.h: Added. * GPUProcess/media/RemoteMediaEngineConfigurationFactoryProxy.messages.in: Added. * Sources.txt: * WebKit.xcodeproj/project.pbxproj: * WebProcess/GPU/GPUProcessConnection.cpp: (WebKit::GPUProcessConnection::mediaEngineConfigurationFactory): * WebProcess/GPU/GPUProcessConnection.h: * WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp: * WebProcess/GPU/media/RemoteAudioSourceProviderManager.h: * WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.cpp: Added. (WebKit::RemoteMediaEngineConfigurationFactory::RemoteMediaEngineConfigurationFactory): (WebKit::RemoteMediaEngineConfigurationFactory::registerFactory): (WebKit::RemoteMediaEngineConfigurationFactory::supplementName): (WebKit::RemoteMediaEngineConfigurationFactory::gpuProcessConnection): (WebKit::RemoteMediaEngineConfigurationFactory::createDecodingConfiguration): (WebKit::RemoteMediaEngineConfigurationFactory::createEncodingConfiguration): * WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.h: Copied from Source/WTF/wtf/Algorithms.h. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::setUseGPUProcessForMedia): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Headers.cmake trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/MediaCapabilitiesDecodingInfo.h trunk/Source/WebCore/platform/MediaCapabilitiesEncodingInfo.h trunk/Source/WebCore/platform/MediaCapabilitiesInfo.h trunk/Source/WebCore/platform/mediacapabilities/AudioConfiguration.h trunk/Source/WebCore/platform/mediacapabilities/ColorGamut.h trunk/Source/WebCore/platform/mediacapabilities/HdrMetadataType.h trunk/Source/WebCore/platform/mediacapabilities/MediaCapabilitiesLogging.h
[webkit-changes] [270461] trunk/LayoutTests
Title: [270461] trunk/LayoutTests Revision 270461 Author tsav...@apple.com Date 2020-12-04 14:46:40 -0800 (Fri, 04 Dec 2020) Log Message [ Mac ] inspector/animation/effectChanged.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=219555 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (270460 => 270461) --- trunk/LayoutTests/ChangeLog 2020-12-04 22:39:13 UTC (rev 270460) +++ trunk/LayoutTests/ChangeLog 2020-12-04 22:46:40 UTC (rev 270461) @@ -1,3 +1,12 @@ +2020-12-04 Truitt Savell + +[ Mac ] inspector/animation/effectChanged.html is a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=219555 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2020-12-04 Chris Dumez [macOS] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html is a flaky failure Modified: trunk/LayoutTests/platform/mac/TestExpectations (270460 => 270461) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-12-04 22:39:13 UTC (rev 270460) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-12-04 22:46:40 UTC (rev 270461) @@ -2263,3 +2263,4 @@ webkit.org/b/219464 [ Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-success-inline-classic.html [ Pass Failure ] webkit.org/b/219464 [ Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-success-inline-module.html [ Pass Failure ] +webkit.org/b/219555 inspector/animation/effectChanged.html [ Pass Timeout ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270460] trunk/Source/WebCore
Title: [270460] trunk/Source/WebCore
Revision 270460
Author cdu...@apple.com
Date 2020-12-04 14:39:13 -0800 (Fri, 04 Dec 2020)
Log Message
Stop constructing unnecessary AudioBus in SincResampler
https://bugs.webkit.org/show_bug.cgi?id=219553
Reviewed by Darin Adler.
Stop constructing unnecessary AudioBus in SincResampler. Instead, pass the float* buffer
to the lambda directly.
* platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::ChannelProvider::provideInputForChannel):
(WebCore::MultiChannelResampler::process):
* platform/audio/SincResampler.cpp:
(WebCore::SincResampler::consumeSource):
(WebCore::SincResampler::process):
* platform/audio/SincResampler.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/MultiChannelResampler.cpp
trunk/Source/WebCore/platform/audio/SincResampler.cpp
trunk/Source/WebCore/platform/audio/SincResampler.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (270459 => 270460)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 22:37:27 UTC (rev 270459)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 22:39:13 UTC (rev 270460)
@@ -1,3 +1,21 @@
+2020-12-04 Chris Dumez
+
+Stop constructing unnecessary AudioBus in SincResampler
+https://bugs.webkit.org/show_bug.cgi?id=219553
+
+Reviewed by Darin Adler.
+
+Stop constructing unnecessary AudioBus in SincResampler. Instead, pass the float* buffer
+to the lambda directly.
+
+* platform/audio/MultiChannelResampler.cpp:
+(WebCore::MultiChannelResampler::ChannelProvider::provideInputForChannel):
+(WebCore::MultiChannelResampler::process):
+* platform/audio/SincResampler.cpp:
+(WebCore::SincResampler::consumeSource):
+(WebCore::SincResampler::process):
+* platform/audio/SincResampler.h:
+
2020-12-04 Said Abou-Hallawa
[GPU Process] Clean up recreating the ImageBufferBackend because of GPU crashing
Modified: trunk/Source/WebCore/platform/audio/MultiChannelResampler.cpp (270459 => 270460)
--- trunk/Source/WebCore/platform/audio/MultiChannelResampler.cpp 2020-12-04 22:37:27 UTC (rev 270459)
+++ trunk/Source/WebCore/platform/audio/MultiChannelResampler.cpp 2020-12-04 22:39:13 UTC (rev 270460)
@@ -53,7 +53,7 @@
// provideInput() will be called once for each channel, starting with the first channel.
// Each time it's called, it will provide the next channel of data.
-void provideInputForChannel(AudioBus* bus, size_t framesToProcess, unsigned channelIndex)
+void provideInputForChannel(float* buffer, size_t framesToProcess, unsigned channelIndex)
{
ASSERT(channelIndex < m_multiChannelBus->numberOfChannels());
ASSERT(framesToProcess <= m_multiChannelBus->length());
@@ -60,11 +60,6 @@
if (framesToProcess > m_multiChannelBus->length())
return;
-bool isBusGood = bus && bus->numberOfChannels() == 1;
-ASSERT(isBusGood);
-if (!isBusGood)
-return;
-
// Get the data from the multi-channel provider when the first channel asks for it.
// For subsequent channels, we can just dish out the channel data from that (stored in m_multiChannelBus).
if (!channelIndex) {
@@ -79,7 +74,7 @@
return;
// Copy the channel data from what we received from m_multiChannelProvider.
-memcpy(bus->channel(0)->mutableData(), m_multiChannelBus->channel(channelIndex)->data(), sizeof(float) * framesToProcess);
+memcpy(buffer, m_multiChannelBus->channel(channelIndex)->data(), sizeof(float) * framesToProcess);
}
private:
@@ -119,10 +114,10 @@
for (unsigned channelIndex = 0; channelIndex < m_numberOfChannels; ++channelIndex) {
ASSERT(chunkSize == m_kernels[channelIndex]->chunkSize());
bool wasProvideInputCalled = false;
-m_kernels[channelIndex]->process(destination->channel(channelIndex)->mutableData() + m_outputFramesReady, framesThisTime, [this, channelIndex, ](AudioBus* bus, size_t framesToProcess) {
+m_kernels[channelIndex]->process(destination->channel(channelIndex)->mutableData() + m_outputFramesReady, framesThisTime, [this, channelIndex, ](float* buffer, size_t framesToProcess) {
ASSERT_WITH_MESSAGE(!wasProvideInputCalled, "provideInputForChannel should only be called once");
wasProvideInputCalled = true;
-m_channelProvider->provideInputForChannel(bus, framesToProcess, channelIndex);
+m_channelProvider->provideInputForChannel(buffer, framesToProcess, channelIndex);
});
}
Modified: trunk/Source/WebCore/platform/audio/SincResampler.cpp (270459 => 270460)
--- trunk/Source/WebCore/platform/audio/SincResampler.cpp 2020-12-04 22:37:27 UTC (rev 270459)
+++ trunk/Source/WebCore/platform/audio/SincResampler.cpp 2020-12-04 22:39:13 UTC (rev 270460)
@@ -197,22 +197,6 @@
}
}
-void
[webkit-changes] [270459] trunk/LayoutTests
Title: [270459] trunk/LayoutTests
Revision 270459
Author cdu...@apple.com
Date 2020-12-04 14:37:27 -0800 (Fri, 04 Dec 2020)
Log Message
[macOS] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=219455
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Import flakiness fix I landed upstream:
- https://github.com/web-platform-tests/wpt/commit/2ab8d794f0c48068703f4d9769bf693ac5b52a3f
* web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html:
LayoutTests:
Unskip test that should no longer be flaky.
* platform/glib/TestExpectations:
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html
trunk/LayoutTests/platform/glib/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
Diff
Modified: trunk/LayoutTests/ChangeLog (270458 => 270459)
--- trunk/LayoutTests/ChangeLog 2020-12-04 22:30:23 UTC (rev 270458)
+++ trunk/LayoutTests/ChangeLog 2020-12-04 22:37:27 UTC (rev 270459)
@@ -1,3 +1,16 @@
+2020-12-04 Chris Dumez
+
+[macOS] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=219455
+
+
+Reviewed by Darin Adler.
+
+Unskip test that should no longer be flaky.
+
+* platform/glib/TestExpectations:
+* platform/mac/TestExpectations:
+
2020-12-04 John Wilander
PCM: Switch to 8+4 bits for source IDs and trigger values respectively
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (270458 => 270459)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-12-04 22:30:23 UTC (rev 270458)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-12-04 22:37:27 UTC (rev 270459)
@@ -1,3 +1,16 @@
+2020-12-04 Chris Dumez
+
+[macOS] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=219455
+
+
+Reviewed by Darin Adler.
+
+Import flakiness fix I landed upstream:
+- https://github.com/web-platform-tests/wpt/commit/2ab8d794f0c48068703f4d9769bf693ac5b52a3f
+
+* web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html:
+
2020-12-03 Alicia Boya García
[GStreamer] Fix video losing size at the end of the stream
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html (270458 => 270459)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html 2020-12-04 22:30:23 UTC (rev 270458)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html 2020-12-04 22:37:27 UTC (rev 270459)
@@ -211,17 +211,19 @@
Promise
.all([
c1.startRendering().then(function(resultBuffer) {
-return should(resultBuffer.getChannelData(0), 'c1 result')
-.beEqualToArray(data);
+return resultBuffer;
}),
c2.startRendering().then(function(resultBuffer) {
-return should(resultBuffer.getChannelData(0), 'c2 result')
-.beEqualToArray(data);
+return resultBuffer;
}),
])
-.then(returnValues => {
+.then(resultBuffers => {
+ let c1ResultValue = should(resultBuffers[0].getChannelData(0), 'c1 result')
+ .beEqualToArray(data);
+ let c2ResultValue = should(resultBuffers[1].getChannelData(0), 'c2 result')
+ .beEqualToArray(data);
should(
- returnValues[0] && returnValues[1],
+ c1ResultValue && c2ResultValue,
'AudioBuffer shared between two different contexts')
.message('correctly', 'incorrectly');
task.done();
Modified: trunk/LayoutTests/platform/glib/TestExpectations (270458 => 270459)
--- trunk/LayoutTests/platform/glib/TestExpectations 2020-12-04 22:30:23 UTC (rev 270458)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2020-12-04 22:37:27 UTC (rev 270459)
@@ -814,9 +814,6 @@
webkit.org/b/214422 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct.html [ Failure Pass ]
webkit.org/b/217542 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/processing-after-resume.https.html [ Failure Pass ]
-# AudioBuffer.
-webkit.org/b/215281
[webkit-changes] [270457] trunk/Source/WebCore
Title: [270457] trunk/Source/WebCore
Revision 270457
Author cdu...@apple.com
Date 2020-12-04 14:21:19 -0800 (Fri, 04 Dec 2020)
Log Message
Improve vectorization in SincResampler
https://bugs.webkit.org/show_bug.cgi?id=219546
Reviewed by Darin Adler.
Add USE(ACCELERATE) vectorization logic to SincResampler for Cocoa ports.
Also import HAVE(ARM_NEON_INTRINSICS) vectorization from Blink:
- https://github.com/chromium/chromium/blob/master/media/base/sinc_resampler.cc
Move convolution implements from process() to a separate convolve() function
for clarity.
* platform/audio/SincResampler.cpp:
(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::process):
(WebCore::SincResampler::convolve):
* platform/audio/SincResampler.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/SincResampler.cpp
trunk/Source/WebCore/platform/audio/SincResampler.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (270456 => 270457)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 22:18:51 UTC (rev 270456)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 22:21:19 UTC (rev 270457)
@@ -1,3 +1,24 @@
+2020-12-04 Chris Dumez
+
+Improve vectorization in SincResampler
+https://bugs.webkit.org/show_bug.cgi?id=219546
+
+Reviewed by Darin Adler.
+
+Add USE(ACCELERATE) vectorization logic to SincResampler for Cocoa ports.
+
+Also import HAVE(ARM_NEON_INTRINSICS) vectorization from Blink:
+- https://github.com/chromium/chromium/blob/master/media/base/sinc_resampler.cc
+
+Move convolution implements from process() to a separate convolve() function
+for clarity.
+
+* platform/audio/SincResampler.cpp:
+(WebCore::SincResampler::SincResampler):
+(WebCore::SincResampler::process):
+(WebCore::SincResampler::convolve):
+* platform/audio/SincResampler.h:
+
2020-12-04 John Wilander
PCM: Switch to 8+4 bits for source IDs and trigger values respectively
Modified: trunk/Source/WebCore/platform/audio/SincResampler.cpp (270456 => 270457)
--- trunk/Source/WebCore/platform/audio/SincResampler.cpp 2020-12-04 22:18:51 UTC (rev 270456)
+++ trunk/Source/WebCore/platform/audio/SincResampler.cpp 2020-12-04 22:21:19 UTC (rev 270457)
@@ -35,8 +35,12 @@
#include "AudioBus.h"
#include
-#if CPU(X86_SSE2)
-#include
+#if USE(ACCELERATE)
+#include
+#elif CPU(X86_SSE2)
+#include
+#elif HAVE(ARM_NEON_INTRINSICS)
+#include
#endif
// Initial input buffer layout, dividing into regions r0 to r4 (note: r0, r3
@@ -113,6 +117,7 @@
constexpr unsigned kernelSize { 32 };
constexpr unsigned numberOfKernelOffsets { 32 };
+constexpr unsigned kernelStorageSize { kernelSize * (numberOfKernelOffsets + 1) };
static size_t calculateChunkSize(unsigned blockSize, double scaleFactor)
{
@@ -121,7 +126,7 @@
SincResampler::SincResampler(double scaleFactor, unsigned requestFrames)
: m_scaleFactor(scaleFactor)
-, m_kernelStorage(kernelSize * (numberOfKernelOffsets + 1))
+, m_kernelStorage(kernelStorageSize)
, m_requestFrames(requestFrames)
, m_inputBuffer(m_requestFrames + kernelSize) // See input buffer layout above.
, m_r1(m_inputBuffer.data())
@@ -296,214 +301,18 @@
float* k1 = m_kernelStorage.data() + offsetIndex * kernelSize;
float* k2 = k1 + kernelSize;
+// Ensure |k1|, |k2| are 16-byte aligned for SIMD usage. Should always be true so long as kernelSize is a multiple of 16.
+ASSERT(!(reinterpret_cast(k1) & 0x0F));
+ASSERT(!(reinterpret_cast(k2) & 0x0F));
+
// Initialize input pointer based on quantized m_virtualSourceIndex.
float* inputP = m_r1 + sourceIndexI;
-// We'll compute "convolutions" for the two kernels which straddle m_virtualSourceIndex
-float sum1 = 0;
-float sum2 = 0;
-
// Figure out how much to weight each kernel's "convolution".
double kernelInterpolationFactor = virtualOffsetIndex - offsetIndex;
-// Generate a single output sample.
-int n = kernelSize;
+*destination++ = convolve(inputP, k1, k2, kernelInterpolationFactor);
-#define CONVOLVE_ONE_SAMPLE \
-input = *inputP++; \
-sum1 += input * *k1; \
-sum2 += input * *k2; \
-++k1;\
-++k2;
-
-{
-float input;
-
-#if CPU(X86_SSE2)
-// If the sourceP address is not 16-byte aligned, the first several frames (at most three) should be processed seperately.
-while ((reinterpret_cast(inputP) & 0x0F) && n) {
-CONVOLVE_ONE_SAMPLE
-n--;
-}
-
-// Now the inputP is aligned and start to apply SSE.
-float* endP = inputP + n - n % 4;
-__m128 mInput;
-__m128 mK1;
-
[webkit-changes] [270456] trunk
Title: [270456] trunk Revision 270456 Author wilan...@apple.com Date 2020-12-04 14:18:51 -0800 (Fri, 04 Dec 2020) Log Message PCM: Switch to 8+4 bits for source IDs and trigger values respectively https://bugs.webkit.org/show_bug.cgi?id=219519 Reviewed by Brent Fulgham. We've received a lot of feedback saying increased entropy on the click side is more important than the current 6 bits on the conversion side. Some of that conversation is captured in https://github.com/privacycg/private-click-measurement/issues/28. Source/WebCore: This patch switches from 6+6 bits to 8+4 bits. It also fixes some minor logging issues. Existing layout tests and API tests were updated. * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parsePrivateClickMeasurement const): * loader/PrivateClickMeasurement.cpp: (WebCore::PrivateClickMeasurement::parseAttributionRequest): Removed the check that would log "Conversion was not accepted because the URL path did not start with ..." on every redirect in PCM Debug Mode. It was wrong and annoying. (WebCore::PrivateClickMeasurement::json const): Added a call to isValid(). Other checks made sure this wasn't an issue but I'd rather have it in this public function too. * loader/PrivateClickMeasurement.h: (WebCore::PrivateClickMeasurement::AttributionTriggerData::isValid const): Source/WebKit: This patch switches from 6+6 bits to 8+4 bits. It also makes sure PCM Debug Mode consistently logs on the LOG level except for real errors. Existing layout tests and API tests were updated. * NetworkProcess/PrivateClickMeasurementManager.cpp: (WebKit::PrivateClickMeasurementManager::storeUnattributed): (WebKit::PrivateClickMeasurementManager::attribute): (WebKit::PrivateClickMeasurementManager::fireConversionRequest): Tools: This patch switches from 6+6 bits to 8+4 bits. * TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp: (TestWebKitAPI::TEST): LayoutTests: This patch switches from 6+6 bits to 8+4 bits. * http/tests/privateClickMeasurement/anchor-tag-attributes-validation-expected.txt: * http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation-expected.txt trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLAnchorElement.cpp trunk/Source/WebCore/loader/PrivateClickMeasurement.cpp trunk/Source/WebCore/loader/PrivateClickMeasurement.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp Diff Modified: trunk/LayoutTests/ChangeLog (270455 => 270456) --- trunk/LayoutTests/ChangeLog 2020-12-04 22:14:21 UTC (rev 270455) +++ trunk/LayoutTests/ChangeLog 2020-12-04 22:18:51 UTC (rev 270456) @@ -1,3 +1,20 @@ +2020-12-04 John Wilander + +PCM: Switch to 8+4 bits for source IDs and trigger values respectively +https://bugs.webkit.org/show_bug.cgi?id=219519 + + +Reviewed by Brent Fulgham. + +We've received a lot of feedback saying increased entropy on the click side is more +important than the current 6 bits on the conversion side. Some of that conversation +is captured in https://github.com/privacycg/private-click-measurement/issues/28. + +This patch switches from 6+6 bits to 8+4 bits. + +* http/tests/privateClickMeasurement/anchor-tag-attributes-validation-expected.txt: +* http/tests/privateClickMeasurement/anchor-tag-attributes-validation.html: + 2020-12-04 Commit Queue Unreviewed, reverting r270422. Modified: trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation-expected.txt (270455 => 270456) --- trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation-expected.txt 2020-12-04 22:14:21 UTC (rev 270455) +++ trunk/LayoutTests/http/tests/privateClickMeasurement/anchor-tag-attributes-validation-expected.txt 2020-12-04 22:18:51 UTC (rev 270456) @@ -1,5 +1,5 @@ -CONSOLE MESSAGE: attributionsourceid must have a non-negative value less than or equal to 63 for Private Click Measurement. -CONSOLE MESSAGE: attributionsourceid must have a non-negative value less than or equal to 63 for Private Click Measurement. +CONSOLE MESSAGE: attributionsourceid must have a non-negative value less than or equal to 255 for Private Click Measurement. +CONSOLE MESSAGE: attributionsourceid must have a non-negative value less than or equal to 255 for Private Click Measurement. CONSOLE MESSAGE: attributionsourceid can not be converted to a non-negative integer which is required for Private Click Measurement. CONSOLE MESSAGE: attributionsourceid can not be converted to a non-negative integer which is required for Private Click
[webkit-changes] [270455] trunk/Source/WebCore
Title: [270455] trunk/Source/WebCore
Revision 270455
Author cdu...@apple.com
Date 2020-12-04 14:14:21 -0800 (Fri, 04 Dec 2020)
Log Message
Drop unused data members from SincResampler
https://bugs.webkit.org/show_bug.cgi?id=219548
Reviewed by Darin Adler.
* platform/audio/SincResampler.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/SincResampler.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (270454 => 270455)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 21:59:36 UTC (rev 270454)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 22:14:21 UTC (rev 270455)
@@ -1,3 +1,12 @@
+2020-12-04 Chris Dumez
+
+Drop unused data members from SincResampler
+https://bugs.webkit.org/show_bug.cgi?id=219548
+
+Reviewed by Darin Adler.
+
+* platform/audio/SincResampler.h:
+
2020-12-04 Brian Burg
Web Inspector: InspectorFrontendAPIDispatcher should not ignore all exceptions
Modified: trunk/Source/WebCore/platform/audio/SincResampler.h (270454 => 270455)
--- trunk/Source/WebCore/platform/audio/SincResampler.h 2020-12-04 21:59:36 UTC (rev 270454)
+++ trunk/Source/WebCore/platform/audio/SincResampler.h 2020-12-04 22:14:21 UTC (rev 270455)
@@ -89,9 +89,6 @@
float* m_r3 { nullptr };
float* m_r4 { nullptr };
-const float* m_source { nullptr };
-unsigned m_sourceFramesAvailable { 0 };
-
// The buffer is primed once at the very beginning of processing.
bool m_isBufferPrimed { false };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270453] trunk/Source
Title: [270453] trunk/Source Revision 270453 Author bb...@apple.com Date 2020-12-04 13:06:17 -0800 (Fri, 04 Dec 2020) Log Message Web Inspector: InspectorFrontendAPIDispatcher should not ignore all exceptions https://bugs.webkit.org/show_bug.cgi?id=219378 Reviewed by Devin Rousso. Source/WebCore: Covered by existing Web Inspector layout tests. * bindings/js/ScriptController.h: Make evaluateInWorld public and exported. * inspector/InspectorFrontendAPIDispatcher.h: * inspector/InspectorFrontendAPIDispatcher.cpp: (WebCore::InspectorFrontendAPIDispatcher::evaluateOrQueueExpression): (WebCore::InspectorFrontendAPIDispatcher::evaluateExpression): Evaluate and pass along the result whether it's a value or exception. * inspector/InspectorFrontendClientLocal.h: * inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::evaluationResultToBoolean): (WebCore::InspectorFrontendClientLocal::isDebuggingEnabled): (WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled): (WebCore::InspectorFrontendClientLocal::isProfilingJavaScript): Refactor the common code to take an EvaluationResult and figure out if the value is true or falsy. * platform/Logging.h: Add an Inspector logging channel, for logging errors. Source/WebKit: The underlying method used for frontend _expression_ evaluations is ScriptController::evaluateIgnoringExceptions. This method calls evaluateInWorld and returns nullopt if an exception happens. Switch to using evaluateInWorld directly and using the existing ValueOrException type from in WebCore. Change our EvaluationResult type to use ValueOrException in place of JSC::JSValue. ValueOrException is Expected so this is exposing more error information in addition to the JSC::JSValue. * Platform/Logging.h: Add 'Inspector' log channel for WebKit.framework. * WebProcess/Inspector/WebInspectorUIExtensionController.cpp: (WebKit::WebInspectorUIExtensionController::WebInspectorUIExtensionController): (WebKit::WebInspectorUIExtensionController::~WebInspectorUIExtensionController): Remove unnecessary debugging code that was accidentally left in/commented out. * WebProcess/Inspector/WebInspectorUIExtensionController.h: (WebKit::WebInspectorUIExtensionController::parseInspectorExtensionErrorFromResult): Deleted. (WebKit::WebInspectorUIExtensionController::parseInspectorExtensionErrorFromEvaluationResult): Added. (WebKit::WebInspectorUIExtensionController::registerExtension): (WebKit::WebInspectorUIExtensionController::unregisterExtension): Adapt to using the new result type. Use the InspectorExtensionID type where possible. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/ScriptController.h trunk/Source/WebCore/inspector/InspectorFrontendAPIDispatcher.cpp trunk/Source/WebCore/inspector/InspectorFrontendAPIDispatcher.h trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h trunk/Source/WebCore/platform/Logging.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/Logging.h trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.h Diff Modified: trunk/Source/WebCore/ChangeLog (270452 => 270453) --- trunk/Source/WebCore/ChangeLog 2020-12-04 20:53:59 UTC (rev 270452) +++ trunk/Source/WebCore/ChangeLog 2020-12-04 21:06:17 UTC (rev 270453) @@ -1,3 +1,30 @@ +2020-12-04 Brian Burg + +Web Inspector: InspectorFrontendAPIDispatcher should not ignore all exceptions +https://bugs.webkit.org/show_bug.cgi?id=219378 + +Reviewed by Devin Rousso. + +Covered by existing Web Inspector layout tests. + +* bindings/js/ScriptController.h: Make evaluateInWorld public and exported. + +* inspector/InspectorFrontendAPIDispatcher.h: +* inspector/InspectorFrontendAPIDispatcher.cpp: +(WebCore::InspectorFrontendAPIDispatcher::evaluateOrQueueExpression): +(WebCore::InspectorFrontendAPIDispatcher::evaluateExpression): +Evaluate and pass along the result whether it's a value or exception. + +* inspector/InspectorFrontendClientLocal.h: +* inspector/InspectorFrontendClientLocal.cpp: +(WebCore::InspectorFrontendClientLocal::evaluationResultToBoolean): +(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled): +(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled): +(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript): +Refactor the common code to take an EvaluationResult and figure out if the value is true or falsy. + +* platform/Logging.h: Add an Inspector logging channel, for logging errors. + 2020-12-04 Zalan Bujtas [LFC][Floats] FloatAvoider does not need to keep a pointer to Layout::Box around. Modified: trunk/Source/WebCore/bindings/js/ScriptController.h (270452 => 270453) ---
[webkit-changes] [270452] trunk/Source/WebCore
Title: [270452] trunk/Source/WebCore
Revision 270452
Author za...@apple.com
Date 2020-12-04 12:53:59 -0800 (Fri, 04 Dec 2020)
Log Message
[LFC][Floats] FloatAvoider does not need to keep a pointer to Layout::Box around.
https://bugs.webkit.org/show_bug.cgi?id=219529
Reviewed by Antti Koivisto.
* layout/floats/FloatAvoider.cpp:
(WebCore::Layout::FloatAvoider::FloatAvoider):
* layout/floats/FloatAvoider.h:
(WebCore::Layout::FloatAvoider::isLeftAligned const):
(WebCore::Layout::FloatAvoider::isFloatingBox const):
(WebCore::Layout::FloatAvoider::layoutBox const): Deleted.
* layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/floats/FloatAvoider.cpp
trunk/Source/WebCore/layout/floats/FloatAvoider.h
trunk/Source/WebCore/layout/floats/FloatingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (270451 => 270452)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 20:38:37 UTC (rev 270451)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 20:53:59 UTC (rev 270452)
@@ -1,3 +1,20 @@
+2020-12-04 Zalan Bujtas
+
+[LFC][Floats] FloatAvoider does not need to keep a pointer to Layout::Box around.
+https://bugs.webkit.org/show_bug.cgi?id=219529
+
+Reviewed by Antti Koivisto.
+
+* layout/floats/FloatAvoider.cpp:
+(WebCore::Layout::FloatAvoider::FloatAvoider):
+* layout/floats/FloatAvoider.h:
+(WebCore::Layout::FloatAvoider::isLeftAligned const):
+(WebCore::Layout::FloatAvoider::isFloatingBox const):
+(WebCore::Layout::FloatAvoider::layoutBox const): Deleted.
+* layout/floats/FloatingContext.cpp:
+(WebCore::Layout::FloatingContext::positionForFloat const):
+(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
+
2020-12-04 Fujii Hironori
GraphicsContextGLOpenGL: m_depthBuffer and m_stencilBuffer are used only if USE(OPENGL_ES)
Modified: trunk/Source/WebCore/layout/floats/FloatAvoider.cpp (270451 => 270452)
--- trunk/Source/WebCore/layout/floats/FloatAvoider.cpp 2020-12-04 20:38:37 UTC (rev 270451)
+++ trunk/Source/WebCore/layout/floats/FloatAvoider.cpp 2020-12-04 20:53:59 UTC (rev 270452)
@@ -39,14 +39,14 @@
// Floating boxes intersect their margin box with the other floats in the context,
// while other float avoiders (e.g. non-floating formatting context roots) intersect their border box.
-FloatAvoider::FloatAvoider(const Box& layoutBox, LayoutPoint absoluteTopLeft, LayoutUnit borderBoxWidth, const Edges& margin, HorizontalEdges containingBlockAbsoluteContentBox)
-: m_layoutBox(makeWeakPtr(layoutBox))
-, m_absoluteTopLeft(absoluteTopLeft)
+FloatAvoider::FloatAvoider(LayoutPoint absoluteTopLeft, LayoutUnit borderBoxWidth, const Edges& margin, HorizontalEdges containingBlockAbsoluteContentBox, bool isFloatingPositioned, bool isLeftAligned)
+: m_absoluteTopLeft(absoluteTopLeft)
, m_borderBoxWidth(borderBoxWidth)
, m_margin(margin)
, m_containingBlockAbsoluteContentBox(containingBlockAbsoluteContentBox)
+, m_isFloatingPositioned(isFloatingPositioned)
+, m_isLeftAligned(isLeftAligned)
{
-ASSERT(m_layoutBox->establishesBlockFormattingContext());
m_absoluteTopLeft.setX(initialHorizontalPosition());
}
Modified: trunk/Source/WebCore/layout/floats/FloatAvoider.h (270451 => 270452)
--- trunk/Source/WebCore/layout/floats/FloatAvoider.h 2020-12-04 20:38:37 UTC (rev 270451)
+++ trunk/Source/WebCore/layout/floats/FloatAvoider.h 2020-12-04 20:53:59 UTC (rev 270452)
@@ -41,7 +41,7 @@
class FloatAvoider {
WTF_MAKE_ISO_ALLOCATED(FloatAvoider);
public:
-FloatAvoider(const Box&, LayoutPoint absoluteTopLeft, LayoutUnit borderBoxWidth, const Edges& margin, HorizontalEdges containingBlockAbsoluteContentBox);
+FloatAvoider(LayoutPoint absoluteTopLeft, LayoutUnit borderBoxWidth, const Edges& margin, HorizontalEdges containingBlockAbsoluteContentBox, bool isFloatingPositioned, bool isLeftAligned);
virtual ~FloatAvoider() = default;
void setHorizontalPosition(LayoutUnit);
@@ -54,7 +54,7 @@
LayoutUnit left() const;
LayoutUnit right() const;
-bool isLeftAligned() const { return isFloatingBox() ? layoutBox().isLeftFloatingPositioned() : layoutBox().style().isLeftToRightDirection(); }
+bool isLeftAligned() const { return m_isLeftAligned; }
private:
LayoutUnit borderBoxWidth() const { return m_borderBoxWidth; }
@@ -66,11 +66,9 @@
LayoutUnit marginEnd() const { return m_margin.horizontal.right; }
LayoutUnit marginBoxWidth() const { return marginStart() + borderBoxWidth() + marginEnd(); }
-bool isFloatingBox() const { return layoutBox().isFloatingPositioned(); }
-const Box& layoutBox() const { return *m_layoutBox; }
+bool isFloatingBox() const { return m_isFloatingPositioned; }
[webkit-changes] [270451] trunk/Source/WebCore
Title: [270451] trunk/Source/WebCore
Revision 270451
Author hironori.fu...@sony.com
Date 2020-12-04 12:38:37 -0800 (Fri, 04 Dec 2020)
Log Message
GraphicsContextGLOpenGL: m_depthBuffer and m_stencilBuffer are used only if USE(OPENGL_ES)
https://bugs.webkit.org/show_bug.cgi?id=219422
Reviewed by Don Olmstead.
* platform/graphics/opengl/GraphicsContextGLOpenGL.h:
Conditioned out m_depthBuffer and m_stencilBuffer with #if !USE(ANGLE) && USE(OPENGL_ES).
* platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
Removed code to generate m_depthBuffer and m_stencilBuffer because
this code is only for USE(ANGLE).
(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h
trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (270450 => 270451)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 20:15:22 UTC (rev 270450)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 20:38:37 UTC (rev 270451)
@@ -1,3 +1,18 @@
+2020-12-04 Fujii Hironori
+
+GraphicsContextGLOpenGL: m_depthBuffer and m_stencilBuffer are used only if USE(OPENGL_ES)
+https://bugs.webkit.org/show_bug.cgi?id=219422
+
+Reviewed by Don Olmstead.
+
+* platform/graphics/opengl/GraphicsContextGLOpenGL.h:
+Conditioned out m_depthBuffer and m_stencilBuffer with #if !USE(ANGLE) && USE(OPENGL_ES).
+* platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:
+(WebCore::GraphicsContextGLOpenGL::GraphicsContextGLOpenGL):
+Removed code to generate m_depthBuffer and m_stencilBuffer because
+this code is only for USE(ANGLE).
+(WebCore::GraphicsContextGLOpenGL::~GraphicsContextGLOpenGL):
+
2020-12-04 David Kilzer
Add safety checks to xsltParamArrayFromParameterMap()
Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h (270450 => 270451)
--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h 2020-12-04 20:15:22 UTC (rev 270450)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h 2020-12-04 20:38:37 UTC (rev 270451)
@@ -644,8 +644,10 @@
GCGLuint m_intermediateTexture { 0 };
#endif
+#if !USE(ANGLE) && USE(OPENGL_ES)
GCGLuint m_depthBuffer { 0 };
GCGLuint m_stencilBuffer { 0 };
+#endif
GCGLuint m_depthStencilBuffer { 0 };
bool m_layerComposited { false };
Modified: trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp (270450 => 270451)
--- trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp 2020-12-04 20:15:22 UTC (rev 270450)
+++ trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp 2020-12-04 20:38:37 UTC (rev 270451)
@@ -190,12 +190,6 @@
// Bind canvas FBO.
gl::BindFramebuffer(GL_FRAMEBUFFER, m_fbo);
m_state.boundDrawFBO = m_state.boundReadFBO = m_fbo;
-#if USE(OPENGL_ES)
-if (attributes.depth)
-gl::GenRenderbuffers(1, _depthBuffer);
-if (attributes.stencil)
-gl::GenRenderbuffers(1, _stencilBuffer);
-#endif
if (attributes.stencil || attributes.depth)
gl::GenRenderbuffers(1, _depthStencilBuffer);
}
@@ -352,7 +346,7 @@
gl::DeleteRenderbuffers(1, _multisampleDepthStencilBuffer);
gl::DeleteFramebuffers(1, _multisampleFBO);
} else if (attributes.stencil || attributes.depth) {
-#if USE(OPENGL_ES)
+#if !USE(ANGLE) && USE(OPENGL_ES)
if (m_depthBuffer)
glDeleteRenderbuffers(1, _depthBuffer);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270450] branches/safari-610.3.7.1-branch/Source
Title: [270450] branches/safari-610.3.7.1-branch/Source Revision 270450 Author repst...@apple.com Date 2020-12-04 12:15:22 -0800 (Fri, 04 Dec 2020) Log Message Versioning. WebKit-7610.3.7.1.9 Modified Paths branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (270449 => 270450) --- branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-12-04 20:10:22 UTC (rev 270449) +++ branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-12-04 20:15:22 UTC (rev 270450) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (270449 => 270450) --- branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-12-04 20:10:22 UTC (rev 270449) +++ branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-12-04 20:15:22 UTC (rev 270450) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (270449 => 270450) --- branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-12-04 20:10:22 UTC (rev 270449) +++ branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-12-04 20:15:22 UTC (rev 270450) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig (270449 => 270450) --- branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2020-12-04 20:10:22 UTC (rev 270449) +++ branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2020-12-04 20:15:22 UTC (rev 270450) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (270449 => 270450) --- branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-12-04 20:10:22 UTC (rev 270449) +++ branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-12-04 20:15:22 UTC (rev 270450) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (270449 => 270450) --- branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-12-04 20:10:22 UTC (rev 270449) +++ branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-12-04 20:15:22 UTC (rev 270450) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 8; +NANO_VERSION = 9; FULL_VERSION =
[webkit-changes] [270449] trunk/Source
Title: [270449] trunk/Source
Revision 270449
Author ddkil...@apple.com
Date 2020-12-04 12:10:22 -0800 (Fri, 04 Dec 2020)
Log Message
Add safety checks to xsltParamArrayFromParameterMap()
Reviewed by Darin Adler.
Source/WebCore:
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::xsltParamArrayFromParameterMap):
Source/WTF:
* wtf/PlatformHave.h:
(HAVE_LIBXSLT_FIX_FOR_RADAR_71864140): Add.
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (270448 => 270449)
--- trunk/Source/WTF/ChangeLog 2020-12-04 20:05:59 UTC (rev 270448)
+++ trunk/Source/WTF/ChangeLog 2020-12-04 20:10:22 UTC (rev 270449)
@@ -1,3 +1,14 @@
+2020-12-04 David Kilzer
+
+Add safety checks to xsltParamArrayFromParameterMap()
+
+
+
+Reviewed by Darin Adler.
+
+* wtf/PlatformHave.h:
+(HAVE_LIBXSLT_FIX_FOR_RADAR_71864140): Add.
+
2020-12-04 Kate Cheney
Create API to enable/disable text interaction gestures in WKWebView
Modified: trunk/Source/WTF/wtf/PlatformHave.h (270448 => 270449)
--- trunk/Source/WTF/wtf/PlatformHave.h 2020-12-04 20:05:59 UTC (rev 270448)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2020-12-04 20:10:22 UTC (rev 270449)
@@ -781,3 +781,10 @@
#if PLATFORM(IOS_FAMILY)
#define HAVE_APPLE_LOW_POWER_MODE_SUPPORT 1
#endif
+
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED >= 110200) \
+|| (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 140400) \
+|| (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED >= 70300) \
+|| (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED >= 140400)
+#define HAVE_LIBXSLT_FIX_FOR_RADAR_71864140 1
+#endif
Modified: trunk/Source/WebCore/ChangeLog (270448 => 270449)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 20:05:59 UTC (rev 270448)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 20:10:22 UTC (rev 270449)
@@ -1,3 +1,14 @@
+2020-12-04 David Kilzer
+
+Add safety checks to xsltParamArrayFromParameterMap()
+
+
+
+Reviewed by Darin Adler.
+
+* xml/XSLTProcessorLibxslt.cpp:
+(WebCore::xsltParamArrayFromParameterMap):
+
2020-12-04 Zalan Bujtas
[LFC][IFC] Move float constraint logic from initialConstraintsForLine to a dedicated function
Modified: trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp (270448 => 270449)
--- trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp 2020-12-04 20:05:59 UTC (rev 270448)
+++ trunk/Source/WebCore/xml/XSLTProcessorLibxslt.cpp 2020-12-04 20:10:22 UTC (rev 270449)
@@ -1,7 +1,7 @@
/*
* This file is part of the XSL implementation.
*
- * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple, Inc. All rights reserved.
+ * Copyright (C) 2004-2020 Apple, Inc. All rights reserved.
* Copyright (C) 2005, 2006 Alexey Proskuryakov
*
* This library is free software; you can redistribute it and/or
@@ -48,6 +48,7 @@
#include
#include
#include
+#include
#if OS(DARWIN) && !PLATFORM(GTK)
#include "SoftLinkLibxslt.h"
@@ -223,9 +224,10 @@
if (parameters.isEmpty())
return 0;
-const char** parameterArray = (const char**)fastMalloc(((parameters.size() * 2) + 1) * sizeof(char*));
+auto size = (((Checked(parameters.size()) * 2U) + 1U) * sizeof(char*)).unsafeGet();
+auto** parameterArray = static_cast(fastMalloc(size));
-unsigned index = 0;
+size_t index = 0;
for (auto& parameter : parameters) {
parameterArray[index++] = fastStrDup(parameter.key.utf8().data());
parameterArray[index++] = fastStrDup(parameter.value.utf8().data());
@@ -232,6 +234,10 @@
}
parameterArray[index] = nullptr;
+#if !PLATFORM(WIN) && !HAVE(LIBXSLT_FIX_FOR_RADAR_71864140)
+RELEASE_ASSERT(index <= std::numeric_limits::max());
+#endif
+
return parameterArray;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270448] trunk/Source/WebCore
Title: [270448] trunk/Source/WebCore
Revision 270448
Author za...@apple.com
Date 2020-12-04 12:05:59 -0800 (Fri, 04 Dec 2020)
Log Message
[LFC][IFC] Move float constraint logic from initialConstraintsForLine to a dedicated function
https://bugs.webkit.org/show_bug.cgi?id=219526
Reviewed by Antti Koivisto.
We are going to call this new function whenever the line stretches vertically and not just once at the very beginning.
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::floatConstraints const):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):
(WebCore::Layout::LineBuilder::initialConstraintsForLine): Deleted.
* layout/inlineformatting/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::floatingState const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (270447 => 270448)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 20:03:53 UTC (rev 270447)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 20:05:59 UTC (rev 270448)
@@ -1,3 +1,19 @@
+2020-12-04 Zalan Bujtas
+
+[LFC][IFC] Move float constraint logic from initialConstraintsForLine to a dedicated function
+https://bugs.webkit.org/show_bug.cgi?id=219526
+
+Reviewed by Antti Koivisto.
+
+We are going to call this new function whenever the line stretches vertically and not just once at the very beginning.
+
+* layout/inlineformatting/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::floatConstraints const):
+(WebCore::Layout::LineBuilder::initialConstraintsForLine const):
+(WebCore::Layout::LineBuilder::initialConstraintsForLine): Deleted.
+* layout/inlineformatting/InlineLineBuilder.h:
+(WebCore::Layout::LineBuilder::floatingState const):
+
2020-12-04 Kate Cheney
Create API to enable/disable text interaction gestures in WKWebView
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp (270447 => 270448)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp 2020-12-04 20:03:53 UTC (rev 270447)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp 2020-12-04 20:05:59 UTC (rev 270448)
@@ -360,42 +360,53 @@
return lineRange;
}
-LineBuilder::UsedConstraints LineBuilder::initialConstraintsForLine(const InlineRect& lineLogicalConstraints, bool isFirstLine)
+Optional LineBuilder::floatConstraints(const InlineRect& lineLogicalRect) const
{
-auto lineLogicalLeft = lineLogicalConstraints.left();
-auto lineLogicalTop = lineLogicalConstraints.top();
-auto lineLogicalRight = lineLogicalLeft + lineLogicalConstraints.width();
-auto lineIsConstrainedByFloat = false;
+auto* floatingState = this->floatingState();
+if (!floatingState || floatingState->floats().isEmpty())
+return { };
// Check for intruding floats and adjust logical left/available width for this line accordingly.
-if (auto* floatingState = this->floatingState()) {
-auto floatingContext = FloatingContext { formattingContext(), *floatingState };
-if (!floatingContext.isEmpty()) {
-// FIXME: Add support for variable line height, where the floats should be probed as the line height grows.
-auto floatConstraints = floatingContext.constraints(toLayoutUnit(lineLogicalTop), toLayoutUnit(lineLogicalTop + lineLogicalConstraints.height()));
-// Check if these values actually constrain the line.
-if (floatConstraints.left && floatConstraints.left->x <= lineLogicalLeft)
-floatConstraints.left = { };
+auto floatingContext = FloatingContext { formattingContext(), *floatingState };
+auto constraints = floatingContext.constraints(toLayoutUnit(lineLogicalRect.top()), toLayoutUnit(lineLogicalRect.bottom()));
+// Check if these values actually constrain the line.
+if (constraints.left && constraints.left->x <= lineLogicalRect.left())
+constraints.left = { };
-if (floatConstraints.right && floatConstraints.right->x >= lineLogicalRight)
-floatConstraints.right = { };
+if (constraints.right && constraints.right->x >= lineLogicalRect.right())
+constraints.right = { };
-lineIsConstrainedByFloat = floatConstraints.left || floatConstraints.right;
+if (!constraints.left && !constraints.right)
+return { };
-if (floatConstraints.left && floatConstraints.right) {
-ASSERT(floatConstraints.left->x <= floatConstraints.right->x);
-lineLogicalRight = floatConstraints.right->x;
-lineLogicalLeft = floatConstraints.left->x;
-} else if (floatConstraints.left) {
-ASSERT(floatConstraints.left->x >= lineLogicalLeft);
-lineLogicalLeft =
[webkit-changes] [270447] trunk/Tools
Title: [270447] trunk/Tools Revision 270447 Author jbed...@apple.com Date 2020-12-04 12:03:53 -0800 (Fri, 04 Dec 2020) Log Message [git-webkit] Use contributors.json https://bugs.webkit.org/show_bug.cgi?id=217732 Reviewed by Dewei Zhu. The interaction between Git, Svn and old commits means that our canonical record of commit authors is somewhat incomplete. contributors.json has most of the information we are missing, we should rely on it to map non-standard author names to their canonical names and email addresses. Additionally, making the record of Contributors owned by the repository instead of being global to the entire process. * Scripts/git-webkit: Parse contributors.json and add it to a Contributor.Mapping. * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Bump version. * Scripts/libraries/webkitscmpy/webkitscmpy/commit.py: (Commit): Contributor class object no longer owns record of contributors. * Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py: (Contributor): (Contributor.Mapping): Dictionary mapping Contributors and their potential aliases. (Contributor.Mapping.__init__): (Contributor.Mapping.add): Add Contributor to mapping. (Contributor.Mapping.create): Find or create a contributor with the specified name and email addresses and bind it to the record of contributors. (Contributor.from_scm_log): Leverage Contributor.Mapping provided by caller. (Contributor.clear): Deleted. * Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py: (Git.__init__): Instantiate repository with existing Contributor.Mapping. (Git.commit): Repository now owns the record of contributors. * Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py: (Scm.from_path): Instantiate repository with existing Contributor.Mapping. (Scm.__init__): Ditto. * Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py: (Svn.__init__): Instantiate repository with existing Contributor.Mapping. (Svn.commit): Repository now owns the record of contributors. * Scripts/libraries/webkitscmpy/webkitscmpy/program.py: (main): Allow caller to pass an existing record of contributors. * Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py: (Scm.from_url): Instantiate repository with existing Contributor.Mapping. (Scm.__init__): Ditto. * Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py: (Svn.__init__): Instantiate repository with existing Contributor.Mapping. (Svn.commit): Repository now owns the record of contributors. * Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py: (ScmBase.__init__): Instantiate repository with existing Contributor.Mapping. * Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py: * Scripts/libraries/webkitscmpy/webkitscmpy/test/contributor_unittest.py: (TestContributor.test_git_log): No more global contributor record. (TestContributor.test_git_svn_log): Ditto. (TestContributor.test_git_no_author): Ditto. (TestContributor.test_git_svn_no_author): Ditto. (TestContributor.test_svn_log): Ditto. (TestContributor.test_short_svn_log): Ditto. (TestContributor.test_svn_patch_by_log): Ditto. (TestContributor.test_author_mapping): Contributor record is owned by the caller of the caller of Contributor management. (TestContributor.test_email_mapping): Ditto. (TestContributor.test_invalid_log): No more global contributor record. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/git-webkit trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/contributor_unittest.py Diff Modified: trunk/Tools/ChangeLog (270446 => 270447) --- trunk/Tools/ChangeLog 2020-12-04 19:53:50 UTC (rev 270446) +++ trunk/Tools/ChangeLog 2020-12-04 20:03:53 UTC (rev 270447) @@ -1,3 +1,65 @@ +2020-12-04 Jonathan Bedard + +[git-webkit] Use contributors.json +https://bugs.webkit.org/show_bug.cgi?id=217732 + + +Reviewed by Dewei Zhu. + +The interaction between Git, Svn and old commits means that our canonical record of +commit authors is somewhat incomplete. contributors.json has most of the information +we are missing, we should rely on it to map non-standard author names to their canonical +names and email addresses. + +Additionally, making the record of Contributors owned by the repository instead
[webkit-changes] [270446] trunk
Title: [270446] trunk Revision 270446 Author katherine_che...@apple.com Date 2020-12-04 11:53:50 -0800 (Fri, 04 Dec 2020) Log Message Create API to enable/disable text interaction gestures in WKWebView https://bugs.webkit.org/show_bug.cgi?id=217784 Reviewed by Wenson Hsieh. Source/WebCore: Add API to disable text selection for macOS. * page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestContextualWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::mouseDownMayStartSelect): Create a new function to return whether a click results in a selection. It will always return false if text interaction is disabled. (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::selectCursor): * page/EventHandler.h: * page/Page.cpp: (WebCore::m_textInteractionEnabled): (WebCore::m_shouldRelaxThirdPartyCookieBlocking): Deleted. * page/Page.h: Store the textInteractionEnabled value in the Page so it is accessible from the EventHandler. (WebCore::Page::textInteractionEnabled): (WebCore::Page::setTextInteractionEnabled): * page/PageConfiguration.h: Source/WebKit: Create a new API to disable text interaction gestures in a WKWebView. We have SPI for this for iOS, but it could be useful to other WebKit clients and on macOS. Add the API to WKPreferences, instead of WKWebViewConfiguration, so it can be changed on the fly. Deprecate the SPI. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode): * Shared/WebPageCreationParameters.h: * UIProcess/API/Cocoa/WKPreferences.h: * UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences encodeWithCoder:]): (-[WKPreferences initWithCoder:]): (-[WKPreferences textInteractionEnabled]): (-[WKPreferences setTextInteractionEnabled:]): * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration init]): (-[WKWebViewConfiguration encodeWithCoder:]): (-[WKWebViewConfiguration initWithCoder:]): (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _textInteractionEnabled]): (-[WKWebViewConfiguration _setTextInteractionEnabled:]): * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView hasSelectablePositionAtPoint:]): (-[WKContentView pointIsNearMarkedText:]): (-[WKContentView textInteractionGesture:shouldBeginAtPoint:]): (-[WKContentView _cascadeInteractionTintColor]): (-[WKContentView selectForWebView:]): (-[WKContentView selectAllForWebView:]): Add check for textInteractionEnabled in these select* functions because disabling text interaction should disable selection in WKWebView. * WebProcess/WebPage/WebPage.cpp: Update the textInteractionEnabled value in the page when preferences are updated. (WebKit::WebPage::updatePreferences): Source/WTF: Create new WKPreference. See WebKit Changelog for details. * Scripts/Preferences/WebPreferences.yaml: Tools: Add API test coverage for macOS and support for layout tests for iOS. API tests do not support user gestures which is why iOS tests must use WebKitTestRunner. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDisableSelection.mm: Added. (TEST): (clickAndDragToSelectText): * TestWebKitAPI/Tests/WebKitCocoa/try-text-select-with-disabled-text-interaction.html: Added. * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::cocoaResetStateToConsistentValues): * WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): (WTR::TestOptions::keyTypeMapping): * WebKitTestRunner/TestOptions.h: (WTR::TestOptions::textInteractionEnabled const): LayoutTests: Layout test coverage for iOS. * LayoutTests/editing/selection/ios/cannot-select-after-disabling-text-interaction-expected.txt: Added. * LayoutTests/editing/selection/ios/cannot-select-after-disabling-text-interaction.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebCore/page/PageConfiguration.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp trunk/Source/WebKit/Shared/WebPageCreationParameters.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
[webkit-changes] [270445] trunk
Title: [270445] trunk Revision 270445 Author commit-qu...@webkit.org Date 2020-12-04 11:51:39 -0800 (Fri, 04 Dec 2020) Log Message More FALLBACK_PLATFORM adoption https://bugs.webkit.org/show_bug.cgi?id=219545 Patch by Adam Roben on 2020-12-04 Reviewed by Tim Horton. PerformanceTests: * MediaTime/Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/bmalloc: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/_javascript_Core: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/ThirdParty: * gtest/xcode/Config/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/ThirdParty/ANGLE: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/ThirdParty/libwebrtc: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/WebCore: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/WebCore/PAL: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/WebInspectorUI: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/WebKit: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/WebKitLegacy/mac: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Source/WTF: * Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Tools: * DumpRenderTree/Scripts/check-xcfilelists.sh: * TestWebKitAPI/Scripts/check-xcfilelists.sh: * WebKitTestRunner/Scripts/check-xcfilelists.sh: Use FALLBACK_PLATFORM if it's defined. * ContentExtensionTester/Configurations/SDKVariant.xcconfig: * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: * ImageDiff/cg/Configurations/SDKVariant.xcconfig: * MiniBrowser/Configurations/SDKVariant.xcconfig: * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: * TestWebKitAPI/Configurations/SDKVariant.xcconfig: * WebEditingTester/Configurations/SDKVariant.xcconfig: * WebKitTestRunner/Configurations/SDKVariant.xcconfig: * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: WK_EMPTY_$(THIS_IS_NOT_EMPTY) evaluates to the empty string, not to NO. Modified Paths trunk/PerformanceTests/ChangeLog trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/SDKVariant.xcconfig trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig trunk/Source/WTF/ChangeLog trunk/Source/WTF/Configurations/SDKVariant.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/SDKVariant.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/SDKVariant.xcconfig trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Configurations/SDKVariant.xcconfig trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/SDKVariant.xcconfig trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/Configurations/SDKVariant.xcconfig trunk/Tools/ChangeLog trunk/Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh trunk/Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig trunk/Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig trunk/Tools/MiniBrowser/Configurations/SDKVariant.xcconfig trunk/Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig trunk/Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig trunk/Tools/TestWebKitAPI/Scripts/check-xcfilelists.sh trunk/Tools/WebEditingTester/Configurations/SDKVariant.xcconfig trunk/Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh trunk/Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig Diff Modified: trunk/PerformanceTests/ChangeLog (270444 => 270445) --- trunk/PerformanceTests/ChangeLog 2020-12-04 19:47:56 UTC (rev 270444) +++ trunk/PerformanceTests/ChangeLog 2020-12-04 19:51:39 UTC (rev 270445) @@ -1,3 +1,14 @@ +2020-12-04 Adam Roben + +More FALLBACK_PLATFORM adoption +https://bugs.webkit.org/show_bug.cgi?id=219545 + +Reviewed by Tim Horton. + +*
[webkit-changes] [270444] trunk/Source
Title: [270444] trunk/Source
Revision 270444
Author s...@apple.com
Date 2020-12-04 11:47:56 -0800 (Fri, 04 Dec 2020)
Log Message
[GPU Process] Share the NativeImage with GPU Process through a ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=218934
Reviewed by Tim Horton.
Source/WebCore:
Delete a NativeImage constructor and a create method which were used by
the deleted IPC coders of the NativeImage.
* Headers.cmake:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/NativeImage.cpp:
(WebCore::NativeImage::create):
(WebCore::NativeImage::NativeImage):
* platform/graphics/NativeImage.h:
* platform/graphics/NativeImageReference.h: Removed.
Source/WebKit:
Instead of relying on the IPC coders to transfer the NativeImage to the
GPUP, we are going to move this logic to RemoteResourceCacheProxy and
RemoteRenderingBackend. The NativeImage will be transfered as a handle of
ShareableBitamp and a renderingResourceIdentifier.
* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::cacheNativeImage):
* GPUProcess/graphics/RemoteRenderingBackend.h:
* GPUProcess/graphics/RemoteRenderingBackend.messages.in:
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::createPlatformImage):
Add this helper function and avoid adding directive code in many places.
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder>::encode): Deleted.
(IPC::ArgumentCoder>::decode): Deleted.
* Shared/WebCoreArgumentCoders.h:
* WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
(WebKit::ImageBufferShareableBitmapBackend::copyNativeImage const):
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::cacheNativeImage):
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
* WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::createShareableBitmapFromNativeImage):
(WebKit::RemoteResourceCacheProxy::cacheNativeImage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/NativeImage.cpp
trunk/Source/WebCore/platform/graphics/NativeImage.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in
trunk/Source/WebKit/Shared/ShareableBitmap.h
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h
trunk/Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp
Removed Paths
trunk/Source/WebCore/platform/graphics/NativeImageReference.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (270443 => 270444)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 19:44:52 UTC (rev 270443)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 19:47:56 UTC (rev 270444)
@@ -1,3 +1,21 @@
+2020-12-04 Said Abou-Hallawa
+
+[GPU Process] Share the NativeImage with GPU Process through a ShareableBitmap
+https://bugs.webkit.org/show_bug.cgi?id=218934
+
+Reviewed by Tim Horton.
+
+Delete a NativeImage constructor and a create method which were used by
+the deleted IPC coders of the NativeImage.
+
+* Headers.cmake:
+* WebCore.xcodeproj/project.pbxproj:
+* platform/graphics/NativeImage.cpp:
+(WebCore::NativeImage::create):
+(WebCore::NativeImage::NativeImage):
+* platform/graphics/NativeImage.h:
+* platform/graphics/NativeImageReference.h: Removed.
+
2020-12-04 Peng Liu
[MSE] Move track buffer management from SourceBuffer to SourceBufferPrivate
Modified: trunk/Source/WebCore/Headers.cmake (270443 => 270444)
--- trunk/Source/WebCore/Headers.cmake 2020-12-04 19:44:52 UTC (rev 270443)
+++ trunk/Source/WebCore/Headers.cmake 2020-12-04 19:47:56 UTC (rev 270444)
@@ -1236,7 +1236,6 @@
platform/graphics/MediaSourcePrivateClient.h
platform/graphics/MediaUsageInfo.h
platform/graphics/NativeImage.h
-platform/graphics/NativeImageReference.h
platform/graphics/OpenGLESShims.h
platform/graphics/OpenGLShims.h
platform/graphics/Path.h
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (270443 => 270444)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-12-04 19:44:52 UTC (rev 270443)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2020-12-04 19:47:56 UTC (rev 270444)
@@ -2192,7 +2192,6 @@
7299BC6823D6A53E00CC6883 /* RenderingMode.h in Headers */ = {isa = PBXBuildFile; fileRef = 7299BC6623D686C600CC6883 /* RenderingMode.h */; settings = {ATTRIBUTES = (Private, ); }; };
729D05302531424300422098 /*
[webkit-changes] [270443] trunk/LayoutTests
Title: [270443] trunk/LayoutTests Revision 270443 Author lmo...@igalia.com Date 2020-12-04 11:44:52 -0800 (Fri, 04 Dec 2020) Log Message [GTK] Gardening wheel failures and timeouts Unreviewed test gardening. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (270442 => 270443) --- trunk/LayoutTests/ChangeLog 2020-12-04 19:43:08 UTC (rev 270442) +++ trunk/LayoutTests/ChangeLog 2020-12-04 19:44:52 UTC (rev 270443) @@ -1,3 +1,11 @@ +2020-12-04 Lauro Moura + +[GTK] Gardening wheel failures and timeouts + +Unreviewed test gardening. + +* platform/gtk/TestExpectations: + 2020-12-02 Darin Adler Make dump-as-markup.js dump newlines within text as "\n" Modified: trunk/LayoutTests/platform/gtk/TestExpectations (270442 => 270443) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-12-04 19:43:08 UTC (rev 270442) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-12-04 19:44:52 UTC (rev 270443) @@ -118,8 +118,6 @@ # Passing since r260062. imported/w3c/web-platform-tests/css/css-shapes/spec-examples/shape-outside-018.html [ Pass ] -fast/scrolling/rtl-scrollbars-listbox-scroll.html [ Pass ] - imported/w3c/web-platform-tests/service-workers/service-worker/fetch-audio-tainting.https.html [ Pass ] webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/baseline-with-orthogonal-flow-001.html [ Pass ] @@ -227,6 +225,24 @@ webkit.org/b/201270 [ Release ] http/tests/security/showModalDialog-sync-cross-origin-page-load2.html [ Timeout ] webkit.org/b/201270 [ Debug ] http/tests/security/showModalDialog-sync-cross-origin-page-load2.html [ Crash ] +# Wheel events and scrolling +webkit.org/b/219547 fast/events/remove-child-onscroll.html [ Timeout ] +webkit.org/b/219547 fast/events/wheel/wheel-event-destroys-frame.html [ Timeout ] +webkit.org/b/219547 fast/events/wheel/wheel-event-destroys-overflow.html [ Timeout ] +webkit.org/b/219547 fast/events/wheel/wheel-event-outside-body.html [ Timeout ] +webkit.org/b/219547 fast/events/wheel/wheelevent-basic.html [ Timeout ] +webkit.org/b/219547 fast/events/wheel/wheelevent-in-text-node.html [ Timeout ] +webkit.org/b/219547 fast/events/wheel/wheelevent-mousewheel-interaction.html [ Timeout ] +webkit.org/b/186670 webkit.org/b/219547 fast/scrolling/iframe-scrollable-after-back.html [ Timeout Pass Failure ] +webkit.org/b/219547 fast/scrolling/overflow-scrollable-after-back.html [ Timeout ] +webkit.org/b/219547 pointer-lock/mouse-event-delivery.html [ Timeout ] +webkit.org/b/219547 scrollbars/scroll-rtl-or-bt-layer.html [ Timeout ] +webkit.org/b/219547 fast/events/wheel/continuous-platform-wheelevent-in-scrolling-div.html [ ImageOnlyFailure ] +webkit.org/b/219547 fast/frames/flattening/scrolling-in-object.html [ ImageOnlyFailure ] +# This one below should be moved back to PASS when fixed to override the root expectation of ImageOnlyFailure +webkit.org/b/219547 fast/scrolling/rtl-scrollbars-listbox-scroll.html [ ImageOnlyFailure ] + + # Workers ## Also timeouts sometimes in Wayland webkit.org/b/177940 workers/wasm-hashset-many-2.html [ Crash Slow ] @@ -1360,8 +1376,6 @@ webkit.org/b/186667 compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html [ Failure Pass ] -webkit.org/b/186670 fast/scrolling/iframe-scrollable-after-back.html [ Failure Pass ] - webkit.org/b/186673 editing/spelling/spellcheck-async-mutation.html [ Failure Pass ] webkit.org/b/186679 media/video-currentTime-delay.html [ Crash Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270441] tags/Safari-610.3.7.1.8/
Title: [270441] tags/Safari-610.3.7.1.8/ Revision 270441 Author alanc...@apple.com Date 2020-12-04 11:31:04 -0800 (Fri, 04 Dec 2020) Log Message Tag Safari-610.3.7.1.8. Added Paths tags/Safari-610.3.7.1.8/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270440] branches/safari-610.3.7.1-branch/Source
Title: [270440] branches/safari-610.3.7.1-branch/Source Revision 270440 Author alanc...@apple.com Date 2020-12-04 11:30:20 -0800 (Fri, 04 Dec 2020) Log Message Versioning. WebKit-7610.3.7.1.8 Modified Paths branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (270439 => 270440) --- branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-12-04 19:21:39 UTC (rev 270439) +++ branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-12-04 19:30:20 UTC (rev 270440) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (270439 => 270440) --- branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-12-04 19:21:39 UTC (rev 270439) +++ branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-12-04 19:30:20 UTC (rev 270440) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (270439 => 270440) --- branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-12-04 19:21:39 UTC (rev 270439) +++ branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-12-04 19:30:20 UTC (rev 270440) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig (270439 => 270440) --- branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2020-12-04 19:21:39 UTC (rev 270439) +++ branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2020-12-04 19:30:20 UTC (rev 270440) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (270439 => 270440) --- branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-12-04 19:21:39 UTC (rev 270439) +++ branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-12-04 19:30:20 UTC (rev 270440) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (270439 => 270440) --- branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-12-04 19:21:39 UTC (rev 270439) +++ branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-12-04 19:30:20 UTC (rev 270440) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION =
[webkit-changes] [270439] trunk/Source/WebKit
Title: [270439] trunk/Source/WebKit Revision 270439 Author pvol...@apple.com Date 2020-12-04 11:21:39 -0800 (Fri, 04 Dec 2020) Log Message [macOS] Deny mach-lookup to the service 'com.apple.print.normalizerd' in the WebContent process https://bugs.webkit.org/show_bug.cgi?id=219541 Reviewed by Darin Adler. On macOS, deny mach-lookup to the service 'com.apple.print.normalizerd' in the WebContent process, since there are no reports of this being used. No new tests, since the result will depend on the macOS version. * WebProcess/com.apple.WebProcess.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (270438 => 270439) --- trunk/Source/WebKit/ChangeLog 2020-12-04 19:04:43 UTC (rev 270438) +++ trunk/Source/WebKit/ChangeLog 2020-12-04 19:21:39 UTC (rev 270439) @@ -1,3 +1,18 @@ +2020-12-04 Per Arne Vollan + +[macOS] Deny mach-lookup to the service 'com.apple.print.normalizerd' in the WebContent process +https://bugs.webkit.org/show_bug.cgi?id=219541 + + +Reviewed by Darin Adler. + +On macOS, deny mach-lookup to the service 'com.apple.print.normalizerd' in the WebContent process, since there are no +reports of this being used. + +No new tests, since the result will depend on the macOS version. + +* WebProcess/com.apple.WebProcess.sb.in: + 2020-12-04 Devin Rousso [iOS] Provide a context menu action to perform accessibility image extraction Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (270438 => 270439) --- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-12-04 19:04:43 UTC (rev 270438) +++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2020-12-04 19:21:39 UTC (rev 270439) @@ -623,7 +623,9 @@ #endif (xpc-service-name "com.apple.audio.SandboxHelper") (xpc-service-name "com.apple.hiservices-xpcservice") +#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 11 (xpc-service-name "com.apple.print.normalizerd") +#endif ) #if __MAC_OS_X_VERSION_MIN_REQUIRED < 11 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270438] tags/Safari-610.3.7.1.7/
Title: [270438] tags/Safari-610.3.7.1.7/ Revision 270438 Author alanc...@apple.com Date 2020-12-04 11:04:43 -0800 (Fri, 04 Dec 2020) Log Message Tag Safari-610.3.7.1.7. Added Paths tags/Safari-610.3.7.1.7/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270437] branches/safari-610.3.7.1-branch/Source
Title: [270437] branches/safari-610.3.7.1-branch/Source Revision 270437 Author alanc...@apple.com Date 2020-12-04 11:01:57 -0800 (Fri, 04 Dec 2020) Log Message Versioning. WebKit-7610.3.7.1.7 Modified Paths branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-610.3.7.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (270436 => 270437) --- branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-12-04 18:56:48 UTC (rev 270436) +++ branches/safari-610.3.7.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2020-12-04 19:01:57 UTC (rev 270437) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (270436 => 270437) --- branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-12-04 18:56:48 UTC (rev 270436) +++ branches/safari-610.3.7.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2020-12-04 19:01:57 UTC (rev 270437) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (270436 => 270437) --- branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-12-04 18:56:48 UTC (rev 270436) +++ branches/safari-610.3.7.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2020-12-04 19:01:57 UTC (rev 270437) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig (270436 => 270437) --- branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2020-12-04 18:56:48 UTC (rev 270436) +++ branches/safari-610.3.7.1-branch/Source/WebCore/Configurations/Version.xcconfig 2020-12-04 19:01:57 UTC (rev 270437) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (270436 => 270437) --- branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-12-04 18:56:48 UTC (rev 270436) +++ branches/safari-610.3.7.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2020-12-04 19:01:57 UTC (rev 270437) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (270436 => 270437) --- branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-12-04 18:56:48 UTC (rev 270436) +++ branches/safari-610.3.7.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2020-12-04 19:01:57 UTC (rev 270437) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 7; MICRO_VERSION = 1; -NANO_VERSION = 6; +NANO_VERSION = 7; FULL_VERSION =
[webkit-changes] [270436] trunk/Source/WebKit
Title: [270436] trunk/Source/WebKit Revision 270436 Author drou...@apple.com Date 2020-12-04 10:56:48 -0800 (Fri, 04 Dec 2020) Log Message [iOS] Provide a context menu action to perform accessibility image extraction https://bugs.webkit.org/show_bug.cgi?id=219524 Reviewed by Wenson Hsieh. * UIProcess/API/Cocoa/_WKElementAction.h: * UIProcess/API/Cocoa/_WKElementAction.mm: (+[_WKElementAction _elementActionWithType:customTitle:assistant:]): (+[_WKElementAction imageForElementActionType:]): (elementActionTypeToUIActionIdentifier): (uiActionIdentifierToElementActionType): Add a new `_WKElementActionTypeImageExtraction` enum type with a default icon and title. * UIProcess/ios/WKActionSheetAssistant.h: * UIProcess/ios/WKActionSheetAssistant.mm: (-[WKActionSheetAssistant defaultActionsForLinkSheet:]): (-[WKActionSheetAssistant defaultActionsForImageSheet:]): (-[WKActionSheetAssistant handleElementActionWithType:element:needsInteraction:]): If the `WKActionSheetAssistantDelegate` allows it, add a `_WKElementActionTypeImageExtraction` action for images (including those inside links). Call out to the `WKActionSheetAssistantDelegate` when handling the action. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm trunk/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h trunk/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm Diff Modified: trunk/Source/WebKit/ChangeLog (270435 => 270436) --- trunk/Source/WebKit/ChangeLog 2020-12-04 18:12:18 UTC (rev 270435) +++ trunk/Source/WebKit/ChangeLog 2020-12-04 18:56:48 UTC (rev 270436) @@ -1,3 +1,28 @@ +2020-12-04 Devin Rousso + +[iOS] Provide a context menu action to perform accessibility image extraction +https://bugs.webkit.org/show_bug.cgi?id=219524 + + +Reviewed by Wenson Hsieh. + +* UIProcess/API/Cocoa/_WKElementAction.h: +* UIProcess/API/Cocoa/_WKElementAction.mm: +(+[_WKElementAction _elementActionWithType:customTitle:assistant:]): +(+[_WKElementAction imageForElementActionType:]): +(elementActionTypeToUIActionIdentifier): +(uiActionIdentifierToElementActionType): +Add a new `_WKElementActionTypeImageExtraction` enum type with a default icon and title. + +* UIProcess/ios/WKActionSheetAssistant.h: +* UIProcess/ios/WKActionSheetAssistant.mm: +(-[WKActionSheetAssistant defaultActionsForLinkSheet:]): +(-[WKActionSheetAssistant defaultActionsForImageSheet:]): +(-[WKActionSheetAssistant handleElementActionWithType:element:needsInteraction:]): +If the `WKActionSheetAssistantDelegate` allows it, add a `_WKElementActionTypeImageExtraction` +action for images (including those inside links). Call out to the `WKActionSheetAssistantDelegate` +when handling the action. + 2020-12-04 Peng Liu [MSE] Move track buffer management from SourceBuffer to SourceBufferPrivate Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h (270435 => 270436) --- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h 2020-12-04 18:12:18 UTC (rev 270435) +++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h 2020-12-04 18:56:48 UTC (rev 270436) @@ -54,6 +54,7 @@ _WKElementActionTypeOpenInNewWindow WK_API_AVAILABLE(macos(10.15), ios(13.0)), _WKElementActionTypeDownload WK_API_AVAILABLE(macos(10.15), ios(13.0)), _WKElementActionToggleShowLinkPreviews WK_API_AVAILABLE(macos(10.15), ios(13.0)), +_WKElementActionTypeImageExtraction WK_API_AVAILABLE(ios(WK_IOS_TBA)), } WK_API_AVAILABLE(macos(10.10), ios(8.0)); WK_CLASS_AVAILABLE(macos(10.10), ios(8.0)) Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm (270435 => 270436) --- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm 2020-12-04 18:12:18 UTC (rev 270435) +++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm 2020-12-04 18:56:48 UTC (rev 270436) @@ -61,6 +61,7 @@ static UIActionIdentifier const WKElementActionTypeOpenInNewWindowIdentifier = @"WKElementActionTypeOpenInNewWindow"; static UIActionIdentifier const WKElementActionTypeDownloadIdentifier = @"WKElementActionTypeDownload"; UIActionIdentifier const WKElementActionTypeToggleShowLinkPreviewsIdentifier = @"WKElementActionTypeToggleShowLinkPreviews"; +static UIActionIdentifier const WKElementActionTypeImageExtractionIdentifier = @"WKElementActionTypeImageExtraction"; static NSString * const webkitShowLinkPreviewsPreferenceKey = @"WebKitShowLinkPreviews"; static NSString * const webkitShowLinkPreviewsPreferenceChangedNotification = @"WebKitShowLinkPreviewsPreferenceChanged"; @@ -159,6 +160,14 @@ case _WKElementActionToggleShowLinkPreviews: // This action must still exist for compatibility, but doesn't do anything. break; +case _WKElementActionTypeImageExtraction: +#if
[webkit-changes] [270434] trunk
Title: [270434] trunk
Revision 270434
Author za...@apple.com
Date 2020-12-04 09:57:24 -0800 (Fri, 04 Dec 2020)
Log Message
[LFC][IFC] Only shrink the line with the float when it is intrusive
https://bugs.webkit.org/show_bug.cgi?id=219525
Reviewed by Antti Koivisto.
Source/WebCore:
In this patch we check if the positioned float box actually intersects the line and shrink the available width accordingly.
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::placeInlineContent):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::initialConstraintsForLine):
(WebCore::Layout::LineBuilder::handleFloatContent):
(WebCore::Layout::LineBuilder::handleInlineContent):
(WebCore::Layout::LineBuilder::rebuildLineForTrailingSoftHyphen):
(WebCore::Layout::LineBuilder::constraintsForLine): Deleted.
* layout/inlineformatting/InlineLineBuilder.h:
LayoutTests:
* platform/mac-wk2/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.h
Diff
Modified: trunk/LayoutTests/ChangeLog (270433 => 270434)
--- trunk/LayoutTests/ChangeLog 2020-12-04 16:50:34 UTC (rev 270433)
+++ trunk/LayoutTests/ChangeLog 2020-12-04 17:57:24 UTC (rev 270434)
@@ -1,3 +1,12 @@
+2020-12-04 Zalan Bujtas
+
+[LFC][IFC] Only shrink the line with the float when it is intrusive
+https://bugs.webkit.org/show_bug.cgi?id=219525
+
+Reviewed by Antti Koivisto.
+
+* platform/mac-wk2/TestExpectations:
+
2020-12-04 Truitt Savell
Followup rebase for fast/forms/listbox-width-change.html and fast/forms/search/search-size-with-decorations.html
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (270433 => 270434)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-12-04 16:50:34 UTC (rev 270433)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-12-04 17:57:24 UTC (rev 270434)
@@ -1279,7 +1279,6 @@
fast/layoutformattingcontext/br-and-wbr-simple.html [ ImageOnlyFailure ]
fast/layoutformattingcontext/empty-table-with-specified-height-quirk-simple.html [ ImageOnlyFailure ]
fast/layoutformattingcontext/empty-table-with-specified-height-standards-simple.html [ ImageOnlyFailure ]
-fast/layoutformattingcontext/float-in-inline-context-simple.html [ ImageOnlyFailure ]
fast/layoutformattingcontext/flow-integration-basic.html [ ImageOnlyFailure ]
fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not.html [ ImageOnlyFailure ]
fast/layoutformattingcontext/inline-box-overlaps-multiple-lines.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (270433 => 270434)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 16:50:34 UTC (rev 270433)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 17:57:24 UTC (rev 270434)
@@ -1,5 +1,27 @@
2020-12-04 Zalan Bujtas
+[LFC][IFC] Only shrink the line with the float when it is intrusive
+https://bugs.webkit.org/show_bug.cgi?id=219525
+
+Reviewed by Antti Koivisto.
+
+In this patch we check if the positioned float box actually intersects the line and shrink the available width accordingly.
+
+* layout/inlineformatting/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::layoutInlineContent):
+(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
+(WebCore::Layout::LineBuilder::initialize):
+(WebCore::Layout::LineBuilder::placeInlineContent):
+(WebCore::Layout::LineBuilder::close):
+(WebCore::Layout::LineBuilder::initialConstraintsForLine):
+(WebCore::Layout::LineBuilder::handleFloatContent):
+(WebCore::Layout::LineBuilder::handleInlineContent):
+(WebCore::Layout::LineBuilder::rebuildLineForTrailingSoftHyphen):
+(WebCore::Layout::LineBuilder::constraintsForLine): Deleted.
+* layout/inlineformatting/InlineLineBuilder.h:
+
+2020-12-04 Zalan Bujtas
+
[LFC][IFC] Float positioning needs to happen while building the line
https://bugs.webkit.org/show_bug.cgi?id=219523
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp (270433 => 270434)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp 2020-12-04 16:50:34 UTC (rev 270433)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp 2020-12-04 17:57:24 UTC (rev 270434)
@@ -247,19 +247,17 @@
{
}
-LineBuilder::LineContent LineBuilder::layoutInlineContent(const InlineItemRange& needsLayoutRange, size_t partialLeadingContentLength, const InlineRect& initialConstraintsForLine, bool isFirstLine)
+LineBuilder::LineContent
[webkit-changes] [270433] trunk/LayoutTests
Title: [270433] trunk/LayoutTests
Revision 270433
Author tsav...@apple.com
Date 2020-12-04 08:50:34 -0800 (Fri, 04 Dec 2020)
Log Message
Followup rebase for fast/forms/listbox-width-change.html and fast/forms/search/search-size-with-decorations.html
https://bugs.webkit.org/show_bug.cgi?id=218359
Unreviewed test gardening.
* platform/mac-catalina/fast/forms/listbox-width-change-expected.txt:
* platform/mac-catalina/fast/forms/search/search-size-with-decorations-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-catalina/fast/forms/listbox-width-change-expected.txt
trunk/LayoutTests/platform/mac-catalina/fast/forms/search/search-size-with-decorations-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (270432 => 270433)
--- trunk/LayoutTests/ChangeLog 2020-12-04 16:45:00 UTC (rev 270432)
+++ trunk/LayoutTests/ChangeLog 2020-12-04 16:50:34 UTC (rev 270433)
@@ -1,3 +1,13 @@
+2020-12-04 Truitt Savell
+
+Followup rebase for fast/forms/listbox-width-change.html and fast/forms/search/search-size-with-decorations.html
+https://bugs.webkit.org/show_bug.cgi?id=218359
+
+Unreviewed test gardening.
+
+* platform/mac-catalina/fast/forms/listbox-width-change-expected.txt:
+* platform/mac-catalina/fast/forms/search/search-size-with-decorations-expected.txt:
+
2020-12-04 Alicia Boya García
[GStreamer] Unreviewed micro gardening
Modified: trunk/LayoutTests/platform/mac-catalina/fast/forms/listbox-width-change-expected.txt (270432 => 270433)
--- trunk/LayoutTests/platform/mac-catalina/fast/forms/listbox-width-change-expected.txt 2020-12-04 16:45:00 UTC (rev 270432)
+++ trunk/LayoutTests/platform/mac-catalina/fast/forms/listbox-width-change-expected.txt 2020-12-04 16:50:34 UTC (rev 270433)
@@ -6,5 +6,5 @@
RenderText {#text} at (0,0) size 661x18
text run at (0,0) width 661: "This tests that when a list box's options get updated, the list box will recalculate its width, and relayout."
RenderBR {BR} at (660,0) size 1x18
- RenderListBox {SELECT} at (2,20) size 188x57 [bgcolor=#FF] [border: (1px inset #808080)]
+ RenderListBox {SELECT} at (2,20) size 189x57 [bgcolor=#FF] [border: (1px inset #808080)]
RenderText {#text} at (0,0) size 0x0
Modified: trunk/LayoutTests/platform/mac-catalina/fast/forms/search/search-size-with-decorations-expected.txt (270432 => 270433)
--- trunk/LayoutTests/platform/mac-catalina/fast/forms/search/search-size-with-decorations-expected.txt 2020-12-04 16:45:00 UTC (rev 270432)
+++ trunk/LayoutTests/platform/mac-catalina/fast/forms/search/search-size-with-decorations-expected.txt 2020-12-04 16:50:34 UTC (rev 270433)
@@ -65,5 +65,5 @@
text run at (0,0) width 135: "12345678901234567890"
layer at (35,151) size 281x13
RenderBlock {DIV} at (0,0) size 281x13
-RenderText {#text} at (0,0) size 269x13
- text run at (0,0) width 269: "1234567890123456789012345678901234567890"
+RenderText {#text} at (0,0) size 270x13
+ text run at (0,0) width 270: "1234567890123456789012345678901234567890"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270432] trunk/LayoutTests
Title: [270432] trunk/LayoutTests Revision 270432 Author ab...@igalia.com Date 2020-12-04 08:45:00 -0800 (Fri, 04 Dec 2020) Log Message [GStreamer] Unreviewed micro gardening https://bugs.webkit.org/show_bug.cgi?id=214031 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video-poster-shown-preload-auto.html is now passing, likely due to r269407. * platform/glib/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (270431 => 270432) --- trunk/LayoutTests/ChangeLog 2020-12-04 15:54:44 UTC (rev 270431) +++ trunk/LayoutTests/ChangeLog 2020-12-04 16:45:00 UTC (rev 270432) @@ -1,3 +1,13 @@ +2020-12-04 Alicia Boya García + +[GStreamer] Unreviewed micro gardening +https://bugs.webkit.org/show_bug.cgi?id=214031 + +imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video-poster-shown-preload-auto.html +is now passing, likely due to r269407. + +* platform/glib/TestExpectations: + 2020-12-04 Zalan Bujtas Web process assert when loading slack Modified: trunk/LayoutTests/platform/glib/TestExpectations (270431 => 270432) --- trunk/LayoutTests/platform/glib/TestExpectations 2020-12-04 15:54:44 UTC (rev 270431) +++ trunk/LayoutTests/platform/glib/TestExpectations 2020-12-04 16:45:00 UTC (rev 270432) @@ -434,8 +434,6 @@ webkit.org/b/214038 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-cuechange.html [ Missing Failure ] -webkit.org/b/214031 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video-poster-shown-preload-auto.html [ ImageOnlyFailure ] - webkit.org/b/217829 media/video-orientation-canvas.html [ Failure ] webkit.org/b/217845 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-stereopanner-interface/no-dezippering.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270431] trunk/Source/JavaScriptCore
Title: [270431] trunk/Source/_javascript_Core
Revision 270431
Author ticaiol...@gmail.com
Date 2020-12-04 07:54:44 -0800 (Fri, 04 Dec 2020)
Log Message
[JIT] Value profile stores wrong value in BaselineJIT for some operations
https://bugs.webkit.org/show_bug.cgi?id=219535
Reviewed by Mark Lam.
This patch is a follow up from r270423 to fix 32-bits baseline JIT
code from `op_iterator_next`. It's also fixing wrong profile value for
`op_get_prototype_of`.
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_iterator_next):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_prototype_of):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITCall32_64.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (270430 => 270431)
--- trunk/Source/_javascript_Core/ChangeLog 2020-12-04 15:43:41 UTC (rev 270430)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-12-04 15:54:44 UTC (rev 270431)
@@ -1,3 +1,19 @@
+2020-12-04 Caio Lima
+
+[JIT] Value profile stores wrong value in BaselineJIT for some operations
+https://bugs.webkit.org/show_bug.cgi?id=219535
+
+Reviewed by Mark Lam.
+
+This patch is a follow up from r270423 to fix 32-bits baseline JIT
+code from `op_iterator_next`. It's also fixing wrong profile value for
+`op_get_prototype_of`.
+
+* jit/JITCall32_64.cpp:
+(JSC::JIT::emit_op_iterator_next):
+* jit/JITOpcodes.cpp:
+(JSC::JIT::emit_op_get_prototype_of):
+
2020-12-03 Saam Barati
"done" checkpoint of iterator_next stores the wrong register in the value profile in baseline JIT
Modified: trunk/Source/_javascript_Core/jit/JITCall32_64.cpp (270430 => 270431)
--- trunk/Source/_javascript_Core/jit/JITCall32_64.cpp 2020-12-04 15:43:41 UTC (rev 270430)
+++ trunk/Source/_javascript_Core/jit/JITCall32_64.cpp 2020-12-04 15:54:44 UTC (rev 270431)
@@ -497,6 +497,8 @@
GPRReg payloadDoneGPR = regT4;
{
+JSValueRegs doneRegs = JSValueRegs(tagDoneGPR, payloadDoneGPR);
+
GPRReg tagIterResultGPR = regT3;
GPRReg payloadIterResultGPR = regT2;
@@ -516,18 +518,19 @@
preservedRegs,
CacheableIdentifier::createFromImmortalIdentifier(vm().propertyNames->done.impl()),
JSValueRegs(tagIterResultGPR, payloadIterResultGPR),
-JSValueRegs(tagDoneGPR, payloadDoneGPR),
+doneRegs,
AccessType::GetById);
gen.generateFastPath(*this);
addSlowCase(gen.slowPathJump());
m_getByIds.append(gen);
-emitValueProfilingSite(metadata);
-emitPutVirtualRegister(bytecode.m_done, JSValueRegs(tagDoneGPR, payloadDoneGPR));
+emitValueProfilingSite(metadata, doneRegs);
+emitPutVirtualRegister(bytecode.m_done, doneRegs);
advanceToNextCheckpoint();
}
{
+JSValueRegs resultRegs = JSValueRegs(tagValueGPR, payloadValueGPR);
GPRReg tagIterResultGPR = regT1;
GPRReg payloadIterResultGPR = regT0;
@@ -543,14 +546,14 @@
RegisterSet::stubUnavailableRegisters(),
CacheableIdentifier::createFromImmortalIdentifier(vm().propertyNames->value.impl()),
JSValueRegs(tagIterResultGPR, payloadIterResultGPR),
-JSValueRegs(tagValueGPR, payloadValueGPR),
+resultRegs,
AccessType::GetById);
gen.generateFastPath(*this);
addSlowCase(gen.slowPathJump());
m_getByIds.append(gen);
-emitValueProfilingSite(metadata);
-emitPutVirtualRegister(bytecode.m_value, JSValueRegs(tagValueGPR, payloadValueGPR));
+emitValueProfilingSite(metadata, resultRegs);
+emitPutVirtualRegister(bytecode.m_value, resultRegs);
iterationDone.link(this);
}
Modified: trunk/Source/_javascript_Core/jit/JITOpcodes.cpp (270430 => 270431)
--- trunk/Source/_javascript_Core/jit/JITOpcodes.cpp 2020-12-04 15:43:41 UTC (rev 270430)
+++ trunk/Source/_javascript_Core/jit/JITOpcodes.cpp 2020-12-04 15:54:44 UTC (rev 270431)
@@ -1785,7 +1785,7 @@
emitLoadPrototype(vm(), valueRegs.payloadGPR(), resultRegs, scratchGPR, slowCases);
addSlowCase(slowCases);
-emitValueProfilingSite(bytecode.metadata(m_codeBlock));
+emitValueProfilingSite(bytecode.metadata(m_codeBlock), resultRegs);
emitPutVirtualRegister(bytecode.m_dst, resultRegs);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270430] trunk/Source/WebKit
Title: [270430] trunk/Source/WebKit Revision 270430 Author commit-qu...@webkit.org Date 2020-12-04 07:43:41 -0800 (Fri, 04 Dec 2020) Log Message GPU Process WindowServer blocking prevents CGL https://bugs.webkit.org/show_bug.cgi?id=219431 Patch by Kimmo Kinnunen on 2020-12-04 Reviewed by Per Arne Vollan. Mark the GPU process as NSSupportsAutomaticGraphicsSwitching. This allows CGL to work in cases when WindowServer connection is blocked. No new tests, makes the future WebGL in GPU process work. * GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist Diff Modified: trunk/Source/WebKit/ChangeLog (270429 => 270430) --- trunk/Source/WebKit/ChangeLog 2020-12-04 13:48:09 UTC (rev 270429) +++ trunk/Source/WebKit/ChangeLog 2020-12-04 15:43:41 UTC (rev 270430) @@ -1,3 +1,19 @@ +2020-12-04 Kimmo Kinnunen + +GPU Process WindowServer blocking prevents CGL +https://bugs.webkit.org/show_bug.cgi?id=219431 + + +Reviewed by Per Arne Vollan. + +Mark the GPU process as NSSupportsAutomaticGraphicsSwitching. +This allows CGL to work in cases when WindowServer connection +is blocked. + +No new tests, makes the future WebGL in GPU process work. + +* GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist: + 2020-12-03 Simon Fraser Only the first wheel event in a gesture should be cancelable Modified: trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist (270429 => 270430) --- trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist 2020-12-04 13:48:09 UTC (rev 270429) +++ trunk/Source/WebKit/GPUProcess/EntryPoint/Cocoa/XPCService/GPUService/Info-OSX.plist 2020-12-04 15:43:41 UTC (rev 270430) @@ -41,5 +41,7 @@ _MultipleInstances +NSSupportsAutomaticGraphicsSwitching + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270429] trunk/Source/WebCore
Title: [270429] trunk/Source/WebCore
Revision 270429
Author za...@apple.com
Date 2020-12-04 05:48:09 -0800 (Fri, 04 Dec 2020)
Log Message
[LFC][IFC] Float positioning needs to happen while building the line
https://bugs.webkit.org/show_bug.cgi?id=219523
Reviewed by Antti Koivisto.
This patch is in preparation for cases when the float may fit the line and we assume it's intrusive but due to e.g. "clear"
it is not intersecting the line at all.
In order to figure out whether the float boxes intersect the current line, we need to compute their position as we find them.
In this patch the float positioning logic is moved over to LineBuilder (from the line post-processing) and floats are added
to the FloatingState as we encounter them while building the line.
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
* layout/inlineformatting/InlineFormattingContext.h:
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::LineBuilder):
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialize):
(WebCore::Layout::LineBuilder::constraintsForLine):
(WebCore::Layout::LineBuilder::handleFloatContent):
* layout/inlineformatting/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::formattingState):
(WebCore::Layout::LineBuilder::floatingState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.h
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (270428 => 270429)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 13:35:23 UTC (rev 270428)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 13:48:09 UTC (rev 270429)
@@ -1,5 +1,34 @@
2020-12-04 Zalan Bujtas
+[LFC][IFC] Float positioning needs to happen while building the line
+https://bugs.webkit.org/show_bug.cgi?id=219523
+
+Reviewed by Antti Koivisto.
+
+This patch is in preparation for cases when the float may fit the line and we assume it's intrusive but due to e.g. "clear"
+it is not intersecting the line at all.
+In order to figure out whether the float boxes intersect the current line, we need to compute their position as we find them.
+In this patch the float positioning logic is moved over to LineBuilder (from the line post-processing) and floats are added
+to the FloatingState as we encounter them while building the line.
+
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::lineLayout):
+(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
+(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
+* layout/inlineformatting/InlineFormattingContext.h:
+* layout/inlineformatting/InlineLineBuilder.cpp:
+(WebCore::Layout::LineBuilder::LineBuilder):
+(WebCore::Layout::LineBuilder::layoutInlineContent):
+(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
+(WebCore::Layout::LineBuilder::initialize):
+(WebCore::Layout::LineBuilder::constraintsForLine):
+(WebCore::Layout::LineBuilder::handleFloatContent):
+* layout/inlineformatting/InlineLineBuilder.h:
+(WebCore::Layout::LineBuilder::formattingState):
+(WebCore::Layout::LineBuilder::floatingState):
+
+2020-12-04 Zalan Bujtas
+
Web process assert when loading slack
https://bugs.webkit.org/show_bug.cgi?id=219079
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp (270428 => 270429)
--- trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp 2020-12-04 13:35:23 UTC (rev 270428)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp 2020-12-04 13:48:09 UTC (rev 270429)
@@ -149,10 +149,11 @@
size_t overflowContentLength { 0 };
};
Optional previousLine;
-auto floatingContext = FloatingContext { *this, formattingState().floatingState() };
+auto& floatingState = formattingState().floatingState();
+auto floatingContext = FloatingContext { *this, floatingState };
auto isFirstLine = formattingState().lines().isEmpty();
-auto lineBuilder = LineBuilder { *this, floatingContext, inlineItems };
+auto lineBuilder = LineBuilder { *this, floatingState, constraints.horizontal, inlineItems };
while (!needsLayoutRange.isEmpty()) {
// Turn previous line's overflow content length into the next
[webkit-changes] [270428] trunk
Title: [270428] trunk
Revision 270428
Author za...@apple.com
Date 2020-12-04 05:35:23 -0800 (Fri, 04 Dec 2020)
Log Message
Web process assert when loading slack
https://bugs.webkit.org/show_bug.cgi?id=219079
Reviewed by Antti Koivisto.
Source/WebCore:
While some display types do not make too much sense on replaced elements, Box::isInlineLevelBox should
return true for all of them.
Test: fast/inline/inline-flex-on-replaced-crash.html
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isInlineLevelBox const):
LayoutTests:
* fast/inline/inline-flex-on-replaced-crash-expected.txt: Added.
* fast/inline/inline-flex-on-replaced-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp
Added Paths
trunk/LayoutTests/fast/inline/inline-flex-on-replaced-crash-expected.txt
trunk/LayoutTests/fast/inline/inline-flex-on-replaced-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (270427 => 270428)
--- trunk/LayoutTests/ChangeLog 2020-12-04 12:26:38 UTC (rev 270427)
+++ trunk/LayoutTests/ChangeLog 2020-12-04 13:35:23 UTC (rev 270428)
@@ -1,3 +1,14 @@
+2020-12-04 Zalan Bujtas
+
+Web process assert when loading slack
+https://bugs.webkit.org/show_bug.cgi?id=219079
+
+
+Reviewed by Antti Koivisto.
+
+* fast/inline/inline-flex-on-replaced-crash-expected.txt: Added.
+* fast/inline/inline-flex-on-replaced-crash.html: Added.
+
2020-12-04 Rob Buis
WebGL2: Null pointer dereference in std::string implementation in gl::Shader::getTransformFeedbackVaryingMappedName
Added: trunk/LayoutTests/fast/inline/inline-flex-on-replaced-crash-expected.txt (0 => 270428)
--- trunk/LayoutTests/fast/inline/inline-flex-on-replaced-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/inline/inline-flex-on-replaced-crash-expected.txt 2020-12-04 13:35:23 UTC (rev 270428)
@@ -0,0 +1,2 @@
+PASS if no crash or ASSERT
+
Added: trunk/LayoutTests/fast/inline/inline-flex-on-replaced-crash.html (0 => 270428)
--- trunk/LayoutTests/fast/inline/inline-flex-on-replaced-crash.html (rev 0)
+++ trunk/LayoutTests/fast/inline/inline-flex-on-replaced-crash.html 2020-12-04 13:35:23 UTC (rev 270428)
@@ -0,0 +1,6 @@
+PASS if no crash or ASSERT
+
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (270427 => 270428)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 12:26:38 UTC (rev 270427)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 13:35:23 UTC (rev 270428)
@@ -1,5 +1,21 @@
2020-12-04 Zalan Bujtas
+Web process assert when loading slack
+https://bugs.webkit.org/show_bug.cgi?id=219079
+
+
+Reviewed by Antti Koivisto.
+
+While some display types do not make too much sense on replaced elements, Box::isInlineLevelBox should
+return true for all of them.
+
+Test: fast/inline/inline-flex-on-replaced-crash.html
+
+* layout/layouttree/LayoutBox.cpp:
+(WebCore::Layout::Box::isInlineLevelBox const):
+
+2020-12-04 Zalan Bujtas
+
[LFC][IFC] Decouple inline content and float handling in LineBuilder
https://bugs.webkit.org/show_bug.cgi?id=219522
Modified: trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp (270427 => 270428)
--- trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp 2020-12-04 12:26:38 UTC (rev 270427)
+++ trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp 2020-12-04 13:35:23 UTC (rev 270428)
@@ -308,7 +308,12 @@
{
// Inline level elements generate inline level boxes.
auto display = m_style.display();
-return display == DisplayType::Inline || isInlineBlockBox() || isInlineTableBox();
+return display == DisplayType::Inline
+|| display == DisplayType::InlineFlex
+|| display == DisplayType::WebKitInlineFlex
+|| display == DisplayType::InlineGrid
+|| isInlineBlockBox()
+|| isInlineTableBox();
}
bool Box::isInlineBox() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270427] trunk/Source/WebCore
Title: [270427] trunk/Source/WebCore
Revision 270427
Author za...@apple.com
Date 2020-12-04 04:26:38 -0800 (Fri, 04 Dec 2020)
Log Message
[LFC][IFC] Decouple inline content and float handling in LineBuilder
https://bugs.webkit.org/show_bug.cgi?id=219522
Reviewed by Antti Koivisto.
The line candidate content is either a list of inline runs or an individual float box. Let's process them separately.
This is in preparation for adding support for "vertically stretchy" lines vs. intrusive floats where the line height
may change as we add new inline level boxes and we need to probe against existing floats.
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::continuousContent const):
(WebCore::Layout::LineCandidate::InlineContent::isEmpty const):
(WebCore::Layout::LineBuilder::placeInlineContent):
(WebCore::Layout::LineBuilder::handleFloatContent):
(WebCore::Layout::LineBuilder::handleInlineContent):
(WebCore::Layout::LineCandidate::InlineContent::operator() const): Deleted.
(WebCore::Layout::LineBuilder::handleFloatOrInlineContent): Deleted.
* layout/inlineformatting/InlineLineBuilder.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (270426 => 270427)
--- trunk/Source/WebCore/ChangeLog 2020-12-04 09:41:08 UTC (rev 270426)
+++ trunk/Source/WebCore/ChangeLog 2020-12-04 12:26:38 UTC (rev 270427)
@@ -1,3 +1,25 @@
+2020-12-04 Zalan Bujtas
+
+[LFC][IFC] Decouple inline content and float handling in LineBuilder
+https://bugs.webkit.org/show_bug.cgi?id=219522
+
+Reviewed by Antti Koivisto.
+
+The line candidate content is either a list of inline runs or an individual float box. Let's process them separately.
+
+This is in preparation for adding support for "vertically stretchy" lines vs. intrusive floats where the line height
+may change as we add new inline level boxes and we need to probe against existing floats.
+
+* layout/inlineformatting/InlineLineBuilder.cpp:
+(WebCore::Layout::LineCandidate::InlineContent::continuousContent const):
+(WebCore::Layout::LineCandidate::InlineContent::isEmpty const):
+(WebCore::Layout::LineBuilder::placeInlineContent):
+(WebCore::Layout::LineBuilder::handleFloatContent):
+(WebCore::Layout::LineBuilder::handleInlineContent):
+(WebCore::Layout::LineCandidate::InlineContent::operator() const): Deleted.
+(WebCore::Layout::LineBuilder::handleFloatOrInlineContent): Deleted.
+* layout/inlineformatting/InlineLineBuilder.h:
+
2020-12-03 Simon Fraser
Only the first wheel event in a gesture should be cancelable
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp (270426 => 270427)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp 2020-12-04 09:41:08 UTC (rev 270426)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp 2020-12-04 12:26:38 UTC (rev 270427)
@@ -129,7 +129,7 @@
struct InlineContent {
InlineContent(bool ignoreTrailingLetterSpacing);
-const InlineContentBreaker::ContinuousContent& operator()() const { return m_continuousContent; }
+const InlineContentBreaker::ContinuousContent& continuousContent() const { return m_continuousContent; }
const InlineItem* trailingLineBreak() const { return m_trailingLineBreak; }
const InlineItem* trailingWordBreakOpportunity() const { return m_trailingWordBreakOpportunity; }
@@ -137,6 +137,7 @@
void appendTrailingLineBreak(const InlineItem& lineBreakItem) { m_trailingLineBreak = }
void appendtrailingWordBreakOpportunity(const InlineItem& wordBreakItem) { m_trailingWordBreakOpportunity = }
void reset();
+bool isEmpty() const { return m_continuousContent.runs().isEmpty() && !trailingWordBreakOpportunity() && !trailingLineBreak(); }
private:
bool m_ignoreTrailingLetterSpacing { false };
@@ -289,10 +290,15 @@
// 4. Return if we are at the end of the line either by not being able to fit more content or because of an explicit line break.
candidateContentForLine(lineCandidate, currentItemIndex, needsLayoutRange, partialLeadingContentLength, m_line.contentLogicalWidth());
// Now check if we can put this content on the current line.
-auto result = handleFloatOrInlineContent(inlineContentBreaker, needsLayoutRange, lineCandidate);
+auto result = Result { };
+if (lineCandidate.floatItem) {
+ASSERT(lineCandidate.inlineContent.isEmpty());
+result = handleFloatContent(*lineCandidate.floatItem);
+} else
+result = handleInlineContent(inlineContentBreaker, needsLayoutRange, lineCandidate);
committedInlineItemCount =
[webkit-changes] [270426] trunk
Title: [270426] trunk
Revision 270426
Author commit-qu...@webkit.org
Date 2020-12-04 01:41:08 -0800 (Fri, 04 Dec 2020)
Log Message
WebGL2: Null pointer dereference in std::string implementation in gl::Shader::getTransformFeedbackVaryingMappedName
https://bugs.webkit.org/show_bug.cgi?id=218602
Patch by Rob Buis on 2020-12-04
Reviewed by Dean Jackson.
Source/ThirdParty/ANGLE:
Skip varying if field is not found since in this
case we have no match for the varying parameter name.
* src/libANGLE/Shader.cpp:
(gl::Shader::getTransformFeedbackVaryingMappedName):
LayoutTests:
Add test that triggers the Shader::getTransformFeedbackVaryingMappedName
field code.
* fast/canvas/webgl/webgl-transformed-varying-name-crash-expected.txt: Added.
* fast/canvas/webgl/webgl-transformed-varying-name-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/libANGLE/Shader.cpp
Added Paths
trunk/LayoutTests/fast/canvas/webgl/webgl-transformed-varying-name-crash-expected.txt
trunk/LayoutTests/fast/canvas/webgl/webgl-transformed-varying-name-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (270425 => 270426)
--- trunk/LayoutTests/ChangeLog 2020-12-04 07:10:03 UTC (rev 270425)
+++ trunk/LayoutTests/ChangeLog 2020-12-04 09:41:08 UTC (rev 270426)
@@ -1,3 +1,16 @@
+2020-12-04 Rob Buis
+
+WebGL2: Null pointer dereference in std::string implementation in gl::Shader::getTransformFeedbackVaryingMappedName
+https://bugs.webkit.org/show_bug.cgi?id=218602
+
+Reviewed by Dean Jackson.
+
+Add test that triggers the Shader::getTransformFeedbackVaryingMappedName
+field code.
+
+* fast/canvas/webgl/webgl-transformed-varying-name-crash-expected.txt: Added.
+* fast/canvas/webgl/webgl-transformed-varying-name-crash.html: Added.
+
2020-12-03 Simon Fraser
Only the first wheel event in a gesture should be cancelable
Added: trunk/LayoutTests/fast/canvas/webgl/webgl-transformed-varying-name-crash-expected.txt (0 => 270426)
--- trunk/LayoutTests/fast/canvas/webgl/webgl-transformed-varying-name-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/webgl-transformed-varying-name-crash-expected.txt 2020-12-04 09:41:08 UTC (rev 270426)
@@ -0,0 +1,2 @@
+PASS. You didn't crash.
+
Added: trunk/LayoutTests/fast/canvas/webgl/webgl-transformed-varying-name-crash.html (0 => 270426)
--- trunk/LayoutTests/fast/canvas/webgl/webgl-transformed-varying-name-crash.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/webgl-transformed-varying-name-crash.html 2020-12-04 09:41:08 UTC (rev 270426)
@@ -0,0 +1,92 @@
+
+
+
+#version 300 es
+precision mediump float;
+in vec4 a_position;
+struct S
+{
+mat3x4 m;
+};
+out S matrix;
+out vec3 vector;
+
+void main()
+{
+matrix.m = mat3x4(1.0);
+vector = vec3(1.0);
+gl_Position = a_position;
+}
+
+#version 300 es
+precision mediump float;
+uniform vec3 uCol;
+out vec4 col;
+void main(){
+col = vec4(uCol,1.);
+}
+
+
+function createShader(gl, sourceCode, type, type_str) {
+var shader = gl.createShader(type);
+gl.shaderSource(shader, sourceCode);
+gl.compileShader(shader);
+
+if (!gl.getShaderParameter(shader, gl.COMPILE_STATUS)) {
+var info = gl.getShaderInfoLog(shader);
+console.log(info);
+}
+
+return shader;
+}
+
+function createProgram(gl, vertexShader, fragmentShader) {
+var program = gl.createProgram();
+gl.attachShader(program, vertexShader);
+gl.attachShader(program, fragmentShader);
+transform_outs = ["vector"];
+transform_feed = gl.createTransformFeedback();
+gl.bindTransformFeedback(gl.TRANSFORM_FEEDBACK,transform_feed);
+gl.transformFeedbackVaryings(program,transform_outs,gl.INTERLEAVED_ATTRIBS);
+gl.linkProgram(program);
+active_info = gl.getTransformFeedbackVarying(program,0);
+gl.useProgram(program);
+
+if (!gl.getProgramParameter(program, gl.LINK_STATUS)) {
+var info = gl.getProgramInfoLog(program);
+console.log(info);
+}
+return program
+}
+
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+
+function runTest() {
+var canvas = document.createElement("canvas");
+canvas.width = "640";
+canvas.height = "480"
+canvas.style.border = "thick solid #00";
+var webgl_1 = canvas.getContext("webgl2");
+document.body.append(canvas)
+
+var schader_script_3 = document.getElementById('2d-vertex-shader');
+var shader_source_3 = schader_script_3.text;
+var schader_script_4 = document.getElementById('2d-fragment-shader');
+var shader_source_4
