[webkit-changes] [279536] branches/safari-612.1.22.11-branch/
Title: [279536] branches/safari-612.1.22.11-branch/ Revision 279536 Author rubent...@apple.com Date 2021-07-02 21:42:01 -0700 (Fri, 02 Jul 2021) Log Message New branch. Added Paths branches/safari-612.1.22.11-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279535] branches/safari-612.1.22.3-branch/
Title: [279535] branches/safari-612.1.22.3-branch/ Revision 279535 Author rubent...@apple.com Date 2021-07-02 21:41:50 -0700 (Fri, 02 Jul 2021) Log Message New branch. Added Paths branches/safari-612.1.22.3-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279534] branches/safari-612.1.22.2-branch/
Title: [279534] branches/safari-612.1.22.2-branch/ Revision 279534 Author rubent...@apple.com Date 2021-07-02 21:41:34 -0700 (Fri, 02 Jul 2021) Log Message New branch. Added Paths branches/safari-612.1.22.2-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279533] branches/safari-612.1.22.1-branch/
Title: [279533] branches/safari-612.1.22.1-branch/ Revision 279533 Author rubent...@apple.com Date 2021-07-02 21:40:42 -0700 (Fri, 02 Jul 2021) Log Message New branch. Added Paths branches/safari-612.1.22.1-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279532] branches/safari-612.1.22.0-branch/
Title: [279532] branches/safari-612.1.22.0-branch/ Revision 279532 Author rubent...@apple.com Date 2021-07-02 21:40:24 -0700 (Fri, 02 Jul 2021) Log Message New branch. Added Paths branches/safari-612.1.22.0-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279531] tags/Safari-612.1.22/
Title: [279531] tags/Safari-612.1.22/ Revision 279531 Author rubent...@apple.com Date 2021-07-02 21:34:47 -0700 (Fri, 02 Jul 2021) Log Message Tag Safari-612.1.22. Added Paths tags/Safari-612.1.22/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279530] trunk/Source/WebCore
Title: [279530] trunk/Source/WebCore Revision 279530 Author jh718.p...@samsung.com Date 2021-07-02 19:50:52 -0700 (Fri, 02 Jul 2021) Log Message Unreviewed. Remove the build warning below since r279498. warning: redundant move in return statement [-Wredundant-move] No new tests, no new behavioral changes. * css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceUnicodeRange): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (279529 => 279530) --- trunk/Source/WebCore/ChangeLog 2021-07-03 01:24:12 UTC (rev 279529) +++ trunk/Source/WebCore/ChangeLog 2021-07-03 02:50:52 UTC (rev 279530) @@ -1,3 +1,13 @@ +2021-07-02 Joonghun Park + +Unreviewed. Remove the build warning below since r279498. +warning: redundant move in return statement [-Wredundant-move] + +No new tests, no new behavioral changes. + +* css/parser/CSSPropertyParserWorkerSafe.cpp: +(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceUnicodeRange): + 2021-07-02 Chris Dumez [MacOS wk1] crypto/workers/subtle/hrsa-postMessage-worker.html is a flaky failure Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp (279529 => 279530) --- trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp 2021-07-03 01:24:12 UTC (rev 279529) +++ trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp 2021-07-03 02:50:52 UTC (rev 279530) @@ -512,7 +512,7 @@ return nullptr; values->append(CSSUnicodeRangeValue::create(unicodeRange->start, unicodeRange->end)); } while (CSSPropertyParserHelpers::consumeCommaIncludingWhitespace(range)); -return WTFMove(values); +return values; } static RefPtr consumeFontFeatureTag(CSSParserTokenRange& range) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279529] branches/safari-611.3.10.1-branch/Source/WebCore
Title: [279529] branches/safari-611.3.10.1-branch/Source/WebCore
Revision 279529
Author kocsen_ch...@apple.com
Date 2021-07-02 18:24:12 -0700 (Fri, 02 Jul 2021)
Log Message
Cherry-pick r278964. rdar://problem/79474157
Protect Element before calling dispatchMouseEvent() on it
https://bugs.webkit.org/show_bug.cgi?id=226767
Reviewed by Ryosuke Niwa.
* page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::dispatchMouseEvent):
* page/PointerLockController.cpp:
(WebCore::PointerLockController::dispatchLockedMouseEvent):
* page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-611.3.10.1-branch/Source/WebCore/ChangeLog
branches/safari-611.3.10.1-branch/Source/WebCore/dom/Element.cpp
branches/safari-611.3.10.1-branch/Source/WebCore/page/EventHandler.cpp
branches/safari-611.3.10.1-branch/Source/WebCore/page/PointerLockController.cpp
branches/safari-611.3.10.1-branch/Source/WebCore/page/Quirks.cpp
Diff
Modified: branches/safari-611.3.10.1-branch/Source/WebCore/ChangeLog (279528 => 279529)
--- branches/safari-611.3.10.1-branch/Source/WebCore/ChangeLog 2021-07-03 01:19:51 UTC (rev 279528)
+++ branches/safari-611.3.10.1-branch/Source/WebCore/ChangeLog 2021-07-03 01:24:12 UTC (rev 279529)
@@ -1,3 +1,40 @@
+2021-07-02 Ruben Turcios
+
+Cherry-pick r278964. rdar://problem/79474157
+
+Protect Element before calling dispatchMouseEvent() on it
+https://bugs.webkit.org/show_bug.cgi?id=226767
+
+
+Reviewed by Ryosuke Niwa.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::updateMouseEventTargetNode):
+(WebCore::EventHandler::dispatchMouseEvent):
+* page/PointerLockController.cpp:
+(WebCore::PointerLockController::dispatchLockedMouseEvent):
+* page/Quirks.cpp:
+(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-16 Chris Dumez
+
+Protect Element before calling dispatchMouseEvent() on it
+https://bugs.webkit.org/show_bug.cgi?id=226767
+
+
+Reviewed by Ryosuke Niwa.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::updateMouseEventTargetNode):
+(WebCore::EventHandler::dispatchMouseEvent):
+* page/PointerLockController.cpp:
+(WebCore::PointerLockController::dispatchLockedMouseEvent):
+* page/Quirks.cpp:
+(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
+
2021-06-21 Alan Coon
Cherry-pick r279010. rdar://problem/79574790
Modified: branches/safari-611.3.10.1-branch/Source/WebCore/dom/Element.cpp (279528 => 279529)
--- branches/safari-611.3.10.1-branch/Source/WebCore/dom/Element.cpp 2021-07-03 01:19:51 UTC (rev 279528)
+++ branches/safari-611.3.10.1-branch/Source/WebCore/dom/Element.cpp 2021-07-03 01:24:12 UTC (rev 279529)
@@ -385,6 +385,7 @@
if (mouseEvent->type().isEmpty())
return true; // Shouldn't happen.
+Ref protectedThis { *this };
bool didNotSwallowEvent = true;
if (dispatchPointerEventIfNeeded(*this, mouseEvent.get(), platformEvent, didNotSwallowEvent) == ShouldIgnoreMouseEvent::Yes)
Modified: branches/safari-611.3.10.1-branch/Source/WebCore/page/EventHandler.cpp (279528 => 279529)
--- branches/safari-611.3.10.1-branch/Source/WebCore/page/EventHandler.cpp 2021-07-03 01:19:51 UTC (rev 279528)
+++ branches/safari-611.3.10.1-branch/Source/WebCore/page/EventHandler.cpp 2021-07-03 01:24:12 UTC (rev 279529)
@@ -2547,8 +2547,8 @@
enteredElementsChain.shrink(enteredElementsChain.size() - i);
}
-if (m_lastElementUnderMouse)
-m_lastElementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventNames().mouseoutEvent, 0, m_elementUnderMouse.get());
+if (auto lastElementUnderMouse = m_lastElementUnderMouse)
+lastElementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventNames().mouseoutEvent, 0, m_elementUnderMouse.get());
for (auto& chain : leftElementsChain) {
if (hasCapturingMouseLeaveListener || chain->hasEventListeners(eventNames().pointerleaveEvent) || chain->hasEventListeners(eventNames().mouseleaveEvent))
@@ -2555,8 +2555,8 @@
chain->dispatchMouseEvent(platformMouseEvent, eventNames().mouseleaveEvent, 0, m_elementUnderMouse.get());
}
-if (m_elementUnderMouse)
-m_elementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventNames().mouseoverEvent, 0, m_lastElementUnderMouse.get());
+if (auto elementUnderMouse = m_elementUnderMouse)
+
[webkit-changes] [279528] branches/safari-611.3.10.1-branch/Source
Title: [279528] branches/safari-611.3.10.1-branch/Source Revision 279528 Author kocsen_ch...@apple.com Date 2021-07-02 18:19:51 -0700 (Fri, 02 Jul 2021) Log Message Versioning. WebKit-7611.3.10.1.3 Modified Paths branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-611.3.10.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-611.3.10.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279527 => 279528) --- branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-07-03 01:11:12 UTC (rev 279527) +++ branches/safari-611.3.10.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-07-03 01:19:51 UTC (rev 279528) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 10; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279527 => 279528) --- branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-07-03 01:11:12 UTC (rev 279527) +++ branches/safari-611.3.10.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-07-03 01:19:51 UTC (rev 279528) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 10; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279527 => 279528) --- branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-07-03 01:11:12 UTC (rev 279527) +++ branches/safari-611.3.10.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-07-03 01:19:51 UTC (rev 279528) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 10; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig (279527 => 279528) --- branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-07-03 01:11:12 UTC (rev 279527) +++ branches/safari-611.3.10.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-07-03 01:19:51 UTC (rev 279528) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 10; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279527 => 279528) --- branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-07-03 01:11:12 UTC (rev 279527) +++ branches/safari-611.3.10.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-07-03 01:19:51 UTC (rev 279528) @@ -25,7 +25,7 @@ MINOR_VERSION = 3; TINY_VERSION = 10; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (279527 => 279528) --- branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-07-03 01:11:12 UTC (rev 279527) +++ branches/safari-611.3.10.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-07-03 01:19:51 UTC (rev 279528) @@ -2,7 +2,7 @@ MINOR_VERSION = 3; TINY_VERSION = 10; MICRO_VERSION = 1; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION =
[webkit-changes] [279527] branches/safari-611.3.10.0-branch/Source/WebCore
Title: [279527] branches/safari-611.3.10.0-branch/Source/WebCore
Revision 279527
Author kocsen_ch...@apple.com
Date 2021-07-02 18:11:12 -0700 (Fri, 02 Jul 2021)
Log Message
Cherry-pick r278964. rdar://problem/79474157
Protect Element before calling dispatchMouseEvent() on it
https://bugs.webkit.org/show_bug.cgi?id=226767
Reviewed by Ryosuke Niwa.
* page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::dispatchMouseEvent):
* page/PointerLockController.cpp:
(WebCore::PointerLockController::dispatchLockedMouseEvent):
* page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-611.3.10.0-branch/Source/WebCore/ChangeLog
branches/safari-611.3.10.0-branch/Source/WebCore/dom/Element.cpp
branches/safari-611.3.10.0-branch/Source/WebCore/page/EventHandler.cpp
branches/safari-611.3.10.0-branch/Source/WebCore/page/PointerLockController.cpp
branches/safari-611.3.10.0-branch/Source/WebCore/page/Quirks.cpp
Diff
Modified: branches/safari-611.3.10.0-branch/Source/WebCore/ChangeLog (279526 => 279527)
--- branches/safari-611.3.10.0-branch/Source/WebCore/ChangeLog 2021-07-03 00:33:25 UTC (rev 279526)
+++ branches/safari-611.3.10.0-branch/Source/WebCore/ChangeLog 2021-07-03 01:11:12 UTC (rev 279527)
@@ -1,3 +1,40 @@
+2021-07-02 Ruben Turcios
+
+Cherry-pick r278964. rdar://problem/79474157
+
+Protect Element before calling dispatchMouseEvent() on it
+https://bugs.webkit.org/show_bug.cgi?id=226767
+
+
+Reviewed by Ryosuke Niwa.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::updateMouseEventTargetNode):
+(WebCore::EventHandler::dispatchMouseEvent):
+* page/PointerLockController.cpp:
+(WebCore::PointerLockController::dispatchLockedMouseEvent):
+* page/Quirks.cpp:
+(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-06-16 Chris Dumez
+
+Protect Element before calling dispatchMouseEvent() on it
+https://bugs.webkit.org/show_bug.cgi?id=226767
+
+
+Reviewed by Ryosuke Niwa.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::updateMouseEventTargetNode):
+(WebCore::EventHandler::dispatchMouseEvent):
+* page/PointerLockController.cpp:
+(WebCore::PointerLockController::dispatchLockedMouseEvent):
+* page/Quirks.cpp:
+(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
+
2021-06-21 Alan Coon
Cherry-pick r279010. rdar://problem/79574790
Modified: branches/safari-611.3.10.0-branch/Source/WebCore/dom/Element.cpp (279526 => 279527)
--- branches/safari-611.3.10.0-branch/Source/WebCore/dom/Element.cpp 2021-07-03 00:33:25 UTC (rev 279526)
+++ branches/safari-611.3.10.0-branch/Source/WebCore/dom/Element.cpp 2021-07-03 01:11:12 UTC (rev 279527)
@@ -385,6 +385,7 @@
if (mouseEvent->type().isEmpty())
return true; // Shouldn't happen.
+Ref protectedThis { *this };
bool didNotSwallowEvent = true;
if (dispatchPointerEventIfNeeded(*this, mouseEvent.get(), platformEvent, didNotSwallowEvent) == ShouldIgnoreMouseEvent::Yes)
Modified: branches/safari-611.3.10.0-branch/Source/WebCore/page/EventHandler.cpp (279526 => 279527)
--- branches/safari-611.3.10.0-branch/Source/WebCore/page/EventHandler.cpp 2021-07-03 00:33:25 UTC (rev 279526)
+++ branches/safari-611.3.10.0-branch/Source/WebCore/page/EventHandler.cpp 2021-07-03 01:11:12 UTC (rev 279527)
@@ -2547,8 +2547,8 @@
enteredElementsChain.shrink(enteredElementsChain.size() - i);
}
-if (m_lastElementUnderMouse)
-m_lastElementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventNames().mouseoutEvent, 0, m_elementUnderMouse.get());
+if (auto lastElementUnderMouse = m_lastElementUnderMouse)
+lastElementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventNames().mouseoutEvent, 0, m_elementUnderMouse.get());
for (auto& chain : leftElementsChain) {
if (hasCapturingMouseLeaveListener || chain->hasEventListeners(eventNames().pointerleaveEvent) || chain->hasEventListeners(eventNames().mouseleaveEvent))
@@ -2555,8 +2555,8 @@
chain->dispatchMouseEvent(platformMouseEvent, eventNames().mouseleaveEvent, 0, m_elementUnderMouse.get());
}
-if (m_elementUnderMouse)
-m_elementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventNames().mouseoverEvent, 0, m_lastElementUnderMouse.get());
+if (auto elementUnderMouse = m_elementUnderMouse)
+
[webkit-changes] [279526] trunk/Source/WebKit
Title: [279526] trunk/Source/WebKit
Revision 279526
Author cdu...@apple.com
Date 2021-07-02 17:33:25 -0700 (Fri, 02 Jul 2021)
Log Message
Unreviewed attempt to fix Mac Catalyst build.
* NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
* NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm
trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (279525 => 279526)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 23:40:06 UTC (rev 279525)
+++ trunk/Source/WebKit/ChangeLog 2021-07-03 00:33:25 UTC (rev 279526)
@@ -1,5 +1,14 @@
2021-07-02 Chris Dumez
+Unreviewed attempt to fix Mac Catalyst build.
+
+* NetworkProcess/ios/NetworkProcessIOS.mm:
+(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
+* NetworkProcess/mac/NetworkProcessMac.mm:
+(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
+
+2021-07-02 Chris Dumez
+
Unreviewed Mac Catalyst build fix after r279514.
* NetworkProcess/ios/NetworkProcessIOS.mm:
Modified: trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm (279525 => 279526)
--- trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm 2021-07-02 23:40:06 UTC (rev 279525)
+++ trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm 2021-07-03 00:33:25 UTC (rev 279526)
@@ -40,7 +40,6 @@
#import
namespace WebKit {
-using namespace WebCore;
#if !PLATFORM(MACCATALYST)
@@ -58,7 +57,7 @@
{
}
-void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host)
+void NetworkProcess::allowSpecificHTTPSCertificateForHost(const WebCore::CertificateInfo& certificateInfo, const String& host)
{
[NSURLRequest setAllowsSpecificHTTPSCertificate:(NSArray *)certificateInfo.certificateChain() forHost:host];
}
Modified: trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm (279525 => 279526)
--- trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm 2021-07-02 23:40:06 UTC (rev 279525)
+++ trunk/Source/WebKit/NetworkProcess/mac/NetworkProcessMac.mm 2021-07-03 00:33:25 UTC (rev 279526)
@@ -48,7 +48,6 @@
#import
namespace WebKit {
-using namespace WebCore;
void NetworkProcess::initializeProcess(const AuxiliaryProcessInitializationParameters&)
{
@@ -79,7 +78,7 @@
#endif
}
-void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host)
+void NetworkProcess::allowSpecificHTTPSCertificateForHost(const WebCore::CertificateInfo& certificateInfo, const String& host)
{
[NSURLRequest setAllowsSpecificHTTPSCertificate:(__bridge NSArray *)certificateInfo.certificateChain() forHost:(NSString *)host];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279525] trunk/Tools
Title: [279525] trunk/Tools Revision 279525 Author aakash_j...@apple.com Date 2021-07-02 16:40:06 -0700 (Fri, 02 Jul 2021) Log Message Delete unused BuildSlaveSupport symlink https://bugs.webkit.org/show_bug.cgi?id=227644 Reviewed by Dewei Zhu. * BuildSlaveSupport: Symlink removed. Modified Paths trunk/Tools/ChangeLog Removed Paths trunk/Tools/BuildSlaveSupport Diff Deleted: trunk/Tools/BuildSlaveSupport (279524 => 279525) --- trunk/Tools/BuildSlaveSupport 2021-07-02 23:21:00 UTC (rev 279524) +++ trunk/Tools/BuildSlaveSupport 2021-07-02 23:40:06 UTC (rev 279525) @@ -1 +0,0 @@ -link CISupport \ No newline at end of file Modified: trunk/Tools/ChangeLog (279524 => 279525) --- trunk/Tools/ChangeLog 2021-07-02 23:21:00 UTC (rev 279524) +++ trunk/Tools/ChangeLog 2021-07-02 23:40:06 UTC (rev 279525) @@ -1,3 +1,12 @@ +2021-07-02 Aakash Jain + +Delete unused BuildSlaveSupport symlink +https://bugs.webkit.org/show_bug.cgi?id=227644 + +Reviewed by Dewei Zhu. + +* BuildSlaveSupport: Symlink removed. + 2021-07-02 Commit Queue Unreviewed, reverting r279494. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279524] trunk/Source/WTF
Title: [279524] trunk/Source/WTF Revision 279524 Author bfulg...@apple.com Date 2021-07-02 16:21:00 -0700 (Fri, 02 Jul 2021) Log Message [macOS] Only use WebGL on Metal by default on safe versions of macOS https://bugs.webkit.org/show_bug.cgi?id=227633 Reviewed by Dean Jackson. Tested by WebGL test suite. * Scripts/Preferences/WebPreferencesExperimental.yaml: * wtf/PlatformHave.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml trunk/Source/WTF/wtf/PlatformHave.h Diff Modified: trunk/Source/WTF/ChangeLog (279523 => 279524) --- trunk/Source/WTF/ChangeLog 2021-07-02 23:05:49 UTC (rev 279523) +++ trunk/Source/WTF/ChangeLog 2021-07-02 23:21:00 UTC (rev 279524) @@ -1,3 +1,16 @@ +2021-07-02 Brent Fulgham + +[macOS] Only use WebGL on Metal by default on safe versions of macOS +https://bugs.webkit.org/show_bug.cgi?id=227633 + + +Reviewed by Dean Jackson. + +Tested by WebGL test suite. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: +* wtf/PlatformHave.h: + 2021-07-01 Youenn Fablet Disable relay for UDP sockets when not needed Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (279523 => 279524) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-07-02 23:05:49 UTC (rev 279523) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-07-02 23:21:00 UTC (rev 279524) @@ -1202,11 +1202,14 @@ condition: ENABLE(WEBGL) && PLATFORM(COCOA) defaultValue: WebKitLegacy: - default: true + "HAVE(WEBGL_COMPATIBLE_METAL)": true + default: false WebKit: - default: true + "HAVE(WEBGL_COMPATIBLE_METAL)": true + default: false WebCore: - default: true + "HAVE(WEBGL_COMPATIBLE_METAL)": true + default: false WebGPUEnabled: type: bool Modified: trunk/Source/WTF/wtf/PlatformHave.h (279523 => 279524) --- trunk/Source/WTF/wtf/PlatformHave.h 2021-07-02 23:05:49 UTC (rev 279523) +++ trunk/Source/WTF/wtf/PlatformHave.h 2021-07-02 23:21:00 UTC (rev 279524) @@ -1093,3 +1093,7 @@ #if !defined(HAVE_GROUP_ACTIVITIES) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 12 #define HAVE_GROUP_ACTIVITIES 1 #endif + +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 12) +#define HAVE_WEBGL_COMPATIBLE_METAL 1 +#endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279523] trunk/Source/WebKit
Title: [279523] trunk/Source/WebKit
Revision 279523
Author cdu...@apple.com
Date 2021-07-02 16:05:49 -0700 (Fri, 02 Jul 2021)
Log Message
Unreviewed Mac Catalyst build fix after r279514.
* NetworkProcess/ios/NetworkProcessIOS.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (279522 => 279523)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 22:52:10 UTC (rev 279522)
+++ trunk/Source/WebKit/ChangeLog 2021-07-02 23:05:49 UTC (rev 279523)
@@ -1,5 +1,11 @@
2021-07-02 Chris Dumez
+Unreviewed Mac Catalyst build fix after r279514.
+
+* NetworkProcess/ios/NetworkProcessIOS.mm:
+
+2021-07-02 Chris Dumez
+
Take a process assertion in the network process when holding locked files
https://bugs.webkit.org/show_bug.cgi?id=227552
Modified: trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm (279522 => 279523)
--- trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm 2021-07-02 22:52:10 UTC (rev 279522)
+++ trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm 2021-07-02 23:05:49 UTC (rev 279523)
@@ -26,7 +26,7 @@
#import "config.h"
#import "NetworkProcess.h"
-#if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST)
+#if PLATFORM(IOS_FAMILY)
#import "NetworkCache.h"
#import "NetworkProcessCreationParameters.h"
@@ -42,6 +42,8 @@
namespace WebKit {
using namespace WebCore;
+#if !PLATFORM(MACCATALYST)
+
void NetworkProcess::initializeProcess(const AuxiliaryProcessInitializationParameters&)
{
InitWebCoreThreadSystemInterface();
@@ -97,6 +99,8 @@
completionHandler();
}
+#endif // !PLATFORM(MACCATALYST)
+
void NetworkProcess::setIsHoldingLockedFiles(bool isHoldingLockedFiles)
{
if (!isHoldingLockedFiles) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279522] trunk/LayoutTests
Title: [279522] trunk/LayoutTests Revision 279522 Author tsav...@apple.com Date 2021-07-02 15:52:10 -0700 (Fri, 02 Jul 2021) Log Message [BigSur Release wk2] fast/history/visited-href-mutation.html is a flaky image failure https://bugs.webkit.org/show_bug.cgi?id=227639 Unreviewed test gardening. Patch by Eric Hutchison on 2021-07-02 * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (279521 => 279522) --- trunk/LayoutTests/ChangeLog 2021-07-02 22:43:32 UTC (rev 279521) +++ trunk/LayoutTests/ChangeLog 2021-07-02 22:52:10 UTC (rev 279522) @@ -1,3 +1,12 @@ +2021-07-02 Eric Hutchison + +[BigSur Release wk2] fast/history/visited-href-mutation.html is a flaky image failure +https://bugs.webkit.org/show_bug.cgi?id=227639 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2021-07-02 Chris Dumez Unreviewed, mark imported/w3c/web-platform-tests/beacon/beacon-basic.https.window.html as flaky Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (279521 => 279522) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-07-02 22:43:32 UTC (rev 279521) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-07-02 22:52:10 UTC (rev 279522) @@ -1377,3 +1377,5 @@ webkit.org/b/227504 [ BigSur Debug ] accessibility/table-title.html [ Pass Timeout ] webkit.org/b/227536 [ BigSur ] imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html [ Pass Failure ] + +webkit.org/b/227639 [ BigSur Release ] fast/history/visited-href-mutation.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279521] trunk/LayoutTests
Title: [279521] trunk/LayoutTests Revision 279521 Author cdu...@apple.com Date 2021-07-02 15:43:32 -0700 (Fri, 02 Jul 2021) Log Message Unreviewed, mark imported/w3c/web-platform-tests/beacon/beacon-basic.https.window.html as flaky It has been flaky since its import in r279225. * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (279520 => 279521) --- trunk/LayoutTests/ChangeLog 2021-07-02 22:40:19 UTC (rev 279520) +++ trunk/LayoutTests/ChangeLog 2021-07-02 22:43:32 UTC (rev 279521) @@ -1,5 +1,13 @@ 2021-07-02 Chris Dumez +Unreviewed, mark imported/w3c/web-platform-tests/beacon/beacon-basic.https.window.html as flaky + +It has been flaky since its import in r279225. + +* TestExpectations: + +2021-07-02 Chris Dumez + [MacOS wk1] crypto/workers/subtle/hrsa-postMessage-worker.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=227540 Modified: trunk/LayoutTests/TestExpectations (279520 => 279521) --- trunk/LayoutTests/TestExpectations 2021-07-02 22:40:19 UTC (rev 279520) +++ trunk/LayoutTests/TestExpectations 2021-07-02 22:43:32 UTC (rev 279521) @@ -644,6 +644,7 @@ imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-represent-nothing-04.html [ ImageOnlyFailure Crash ] # Newly imported WPT tests that are flaky. +webkit.org/b/227649 imported/w3c/web-platform-tests/beacon/beacon-basic.https.window.html [ Failure Pass ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-window-onerror-module.html [ Failure Pass ] imported/w3c/web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.html [ Failure Pass ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-credentialless.tentative.https.html [ Failure Pass ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279520] trunk/Source/JavaScriptCore
Title: [279520] trunk/Source/_javascript_Core
Revision 279520
Author keith_mil...@apple.com
Date 2021-07-02 15:40:19 -0700 (Fri, 02 Jul 2021)
Log Message
Add 10 more unified source cpp files for JSC
https://bugs.webkit.org/show_bug.cgi?id=227643
Reviewed by Alex Christensen.
* _javascript_Core.xcodeproj/project.pbxproj:
* Scripts/generate-unified-sources.sh:
* UnifiedSources-output.xcfilelist:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/Scripts/generate-unified-sources.sh
trunk/Source/_javascript_Core/UnifiedSources-output.xcfilelist
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (279519 => 279520)
--- trunk/Source/_javascript_Core/ChangeLog 2021-07-02 22:33:24 UTC (rev 279519)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-07-02 22:40:19 UTC (rev 279520)
@@ -1,3 +1,14 @@
+2021-07-02 Keith Miller
+
+Add 10 more unified source cpp files for JSC
+https://bugs.webkit.org/show_bug.cgi?id=227643
+
+Reviewed by Alex Christensen.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* Scripts/generate-unified-sources.sh:
+* UnifiedSources-output.xcfilelist:
+
2021-07-02 Philippe Normand
[GTK] Add new revision variable in pkgconfig file
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (279519 => 279520)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2021-07-02 22:33:24 UTC (rev 279519)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2021-07-02 22:40:19 UTC (rev 279520)
@@ -1084,6 +1084,16 @@
5370806B1FE232DF00299E44 /* JSArrayBufferView.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F2B66BB17B6B5AB00A7AE3F /* JSArrayBufferView.h */; };
5370B4F61BF26205005C40FC /* AdaptiveInferredPropertyValueWatchpointBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 5370B4F41BF25EA2005C40FC /* AdaptiveInferredPropertyValueWatchpointBase.h */; };
5381B9391E60E97D0090F794 /* WasmFaultSignalHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 5381B9381E60E97D0090F794 /* WasmFaultSignalHandler.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 538F15E7268FBBB600D601C4 /* UnifiedSource148.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15DD268FBBB300D601C4 /* UnifiedSource148.cpp */; };
+ 538F15E8268FBBB600D601C4 /* UnifiedSource151.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15DE268FBBB300D601C4 /* UnifiedSource151.cpp */; };
+ 538F15E9268FBBB600D601C4 /* UnifiedSource152.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15DF268FBBB300D601C4 /* UnifiedSource152.cpp */; };
+ 538F15EA268FBBB600D601C4 /* UnifiedSource154.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15E0268FBBB400D601C4 /* UnifiedSource154.cpp */; };
+ 538F15EB268FBBB600D601C4 /* UnifiedSource150.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15E1268FBBB400D601C4 /* UnifiedSource150.cpp */; };
+ 538F15ED268FBBB600D601C4 /* UnifiedSource153.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15E3268FBBB500D601C4 /* UnifiedSource153.cpp */; };
+ 538F15EE268FBBB600D601C4 /* UnifiedSource147.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15E4268FBBB500D601C4 /* UnifiedSource147.cpp */; };
+ 538F15EF268FBBB600D601C4 /* UnifiedSource155.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15E5268FBBB500D601C4 /* UnifiedSource155.cpp */; };
+ 538F15F0268FBBB600D601C4 /* UnifiedSource149.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15E6268FBBB600D601C4 /* UnifiedSource149.cpp */; };
+ 538F15F2268FBC7B00D601C4 /* UnifiedSource146.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538F15F1268FBC7B00D601C4 /* UnifiedSource146.cpp */; };
53917E7B1B7906FA000EBD33 /* JSGenericTypedArrayViewPrototypeFunctions.h in Headers */ = {isa = PBXBuildFile; fileRef = 53917E7A1B7906E4000EBD33 /* JSGenericTypedArrayViewPrototypeFunctions.h */; };
539930C822AD3B9A0051CDE2 /* WeakObjectRefConstructor.h in Headers */ = {isa = PBXBuildFile; fileRef = 539930C722AD3B9A0051CDE2 /* WeakObjectRefConstructor.h */; };
539BFBAE22AD3C3A0023F4C0 /* WeakObjectRefPrototype.h in Headers */ = {isa = PBXBuildFile; fileRef = 539BFBAD22AD3C3A0023F4C0 /* WeakObjectRefPrototype.h */; };
@@ -3859,6 +3869,16 @@
5381B9361E60E9660090F794 /* WasmFaultSignalHandler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WasmFaultSignalHandler.cpp; sourceTree = ""; };
5381B9381E60E97D0090F794 /* WasmFaultSignalHandler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WasmFaultSignalHandler.h; sourceTree = ""; };
5383AA2F1E65E8A100A532FC /* JSWebAssemblyCodeBlock.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSWebAssemblyCodeBlock.cpp; path = js/JSWebAssemblyCodeBlock.cpp; sourceTree
[webkit-changes] [279519] branches/safari-612.1.21-branch/Source
Title: [279519] branches/safari-612.1.21-branch/Source Revision 279519 Author rubent...@apple.com Date 2021-07-02 15:33:24 -0700 (Fri, 02 Jul 2021) Log Message Versioning. WebKit-7612.1.22 Modified Paths branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.21-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig (279518 => 279519) --- branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-07-02 22:26:31 UTC (rev 279518) +++ branches/safari-612.1.21-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-07-02 22:33:24 UTC (rev 279519) @@ -23,10 +23,10 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; -TINY_VERSION = 21; -MICRO_VERSION = 2; +TINY_VERSION = 22; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (279518 => 279519) --- branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-07-02 22:26:31 UTC (rev 279518) +++ branches/safari-612.1.21-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-07-02 22:33:24 UTC (rev 279519) @@ -23,10 +23,10 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; -TINY_VERSION = 21; -MICRO_VERSION = 2; +TINY_VERSION = 22; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (279518 => 279519) --- branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-07-02 22:26:31 UTC (rev 279518) +++ branches/safari-612.1.21-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-07-02 22:33:24 UTC (rev 279519) @@ -23,10 +23,10 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; -TINY_VERSION = 21; -MICRO_VERSION = 2; +TINY_VERSION = 22; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig (279518 => 279519) --- branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2021-07-02 22:26:31 UTC (rev 279518) +++ branches/safari-612.1.21-branch/Source/WebCore/Configurations/Version.xcconfig 2021-07-02 22:33:24 UTC (rev 279519) @@ -23,10 +23,10 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; -TINY_VERSION = 21; -MICRO_VERSION = 2; +TINY_VERSION = 22; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (279518 => 279519) --- branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-07-02 22:26:31 UTC (rev 279518) +++ branches/safari-612.1.21-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-07-02 22:33:24 UTC (rev 279519) @@ -23,10 +23,10 @@ MAJOR_VERSION = 612; MINOR_VERSION = 1; -TINY_VERSION = 21; -MICRO_VERSION = 2; +TINY_VERSION = 22; +MICRO_VERSION = 0; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
[webkit-changes] [279518] trunk
Title: [279518] trunk Revision 279518 Author cdu...@apple.com Date 2021-07-02 15:26:31 -0700 (Fri, 02 Jul 2021) Log Message [MacOS wk1] crypto/workers/subtle/hrsa-postMessage-worker.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=227540 Reviewed by Geoffrey Garen. Source/WebCore: The test was sending 2 messages to the worker, the first one with the public key and the second one for the private key. As the worker would receive those messages, it would do some checks synchronously and post a message back to the main thread script with the result. As we could see from the test's expected results, the main thread script would usually (although flakily) receive the result for the private key *before* the result for the public key, which was wrong. The reason for this was that serializing / deserializing the crypto key would spin the worker's run loop and the worker would thus process incoming messages while serializing / deserializing a crypto key from a previous message. To address the issue, we now use a BinarySemaphore to wait for the main thread to finish the wrapping / unwrapping, instead of spinning the run loop. No new tests, unskipped existing test. * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::wrapCryptoKey): (WebCore::WorkerGlobalScope::unwrapCryptoKey): LayoutTests: Rebaseline test now that the output is correct (and non-flaky). Also unmark the test as flaky. * crypto/workers/subtle/ec-postMessage-worker-expected.txt: * crypto/workers/subtle/hrsa-postMessage-worker-expected.txt: * crypto/workers/subtle/hrsa-postMessage-worker.html: * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/crypto/workers/subtle/ec-postMessage-worker-expected.txt trunk/LayoutTests/crypto/workers/subtle/hrsa-postMessage-worker-expected.txt trunk/LayoutTests/crypto/workers/subtle/hrsa-postMessage-worker.html trunk/LayoutTests/crypto/workers/subtle/rsa-postMessage-worker-expected.txt trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/WorkerGlobalScope.cpp Diff Modified: trunk/LayoutTests/ChangeLog (279517 => 279518) --- trunk/LayoutTests/ChangeLog 2021-07-02 21:19:29 UTC (rev 279517) +++ trunk/LayoutTests/ChangeLog 2021-07-02 22:26:31 UTC (rev 279518) @@ -1,5 +1,20 @@ 2021-07-02 Chris Dumez +[MacOS wk1] crypto/workers/subtle/hrsa-postMessage-worker.html is a flaky failure +https://bugs.webkit.org/show_bug.cgi?id=227540 + + +Reviewed by Geoffrey Garen. + +Rebaseline test now that the output is correct (and non-flaky). Also unmark the test as flaky. + +* crypto/workers/subtle/ec-postMessage-worker-expected.txt: +* crypto/workers/subtle/hrsa-postMessage-worker-expected.txt: +* crypto/workers/subtle/hrsa-postMessage-worker.html: +* platform/mac-wk1/TestExpectations: + +2021-07-02 Chris Dumez + REGRESSION (r279427): [ Mac wk1 ] imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/tall-cross-domain-iframe-in-scrolled.sub.html is timing out https://bugs.webkit.org/show_bug.cgi?id=227637 Modified: trunk/LayoutTests/crypto/workers/subtle/ec-postMessage-worker-expected.txt (279517 => 279518) --- trunk/LayoutTests/crypto/workers/subtle/ec-postMessage-worker-expected.txt 2021-07-02 21:19:29 UTC (rev 279517) +++ trunk/LayoutTests/crypto/workers/subtle/ec-postMessage-worker-expected.txt 2021-07-02 22:26:31 UTC (rev 279518) @@ -3,6 +3,14 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". +PASS All checks passed in worker for public key +PASS publicKey.type is 'public' +PASS publicKey.extractable is true +PASS publicKey.algorithm.name is 'ECDH' +PASS publicKey.algorithm.namedCurve is 'P-256' +PASS publicKey.usages is [ ] +PASS exportedKey.x is publicKeyJSON.x +PASS exportedKey.y is publicKeyJSON.y PASS All checks passed in worker for private key PASS privateKey.type is 'private' PASS privateKey.extractable is true @@ -12,14 +20,6 @@ PASS exportedKey.x is privateKeyJSON.x PASS exportedKey.y is privateKeyJSON.y PASS exportedKey.d is privateKeyJSON.d -PASS All checks passed in worker for public key -PASS publicKey.type is 'public' -PASS publicKey.extractable is true -PASS publicKey.algorithm.name is 'ECDH' -PASS publicKey.algorithm.namedCurve is 'P-256' -PASS publicKey.usages is [ ] -PASS exportedKey.x is publicKeyJSON.x -PASS exportedKey.y is publicKeyJSON.y PASS successfullyParsed is true TEST COMPLETE Modified: trunk/LayoutTests/crypto/workers/subtle/hrsa-postMessage-worker-expected.txt (279517 => 279518) --- trunk/LayoutTests/crypto/workers/subtle/hrsa-postMessage-worker-expected.txt 2021-07-02 21:19:29 UTC (rev 279517) +++ trunk/LayoutTests/crypto/workers/subtle/hrsa-postMessage-worker-expected.txt 2021-07-02 22:26:31 UTC (rev 279518) @@ -3,6 +3,14 @@ On success, you will see a
[webkit-changes] [279517] trunk/LayoutTests
Title: [279517] trunk/LayoutTests Revision 279517 Author cdu...@apple.com Date 2021-07-02 14:19:29 -0700 (Fri, 02 Jul 2021) Log Message REGRESSION (r279427): [ Mac wk1 ] imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/tall-cross-domain-iframe-in-scrolled.sub.html is timing out https://bugs.webkit.org/show_bug.cgi?id=227637 Unreviewed, Skip this newly imported WPT test on mac wk1 as it is timing out on this platform. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (279516 => 279517) --- trunk/LayoutTests/ChangeLog 2021-07-02 21:09:02 UTC (rev 279516) +++ trunk/LayoutTests/ChangeLog 2021-07-02 21:19:29 UTC (rev 279517) @@ -1,5 +1,16 @@ 2021-07-02 Chris Dumez +REGRESSION (r279427): [ Mac wk1 ] imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/tall-cross-domain-iframe-in-scrolled.sub.html is timing out +https://bugs.webkit.org/show_bug.cgi?id=227637 + + +Unreviewed, Skip this newly imported WPT test on mac wk1 as it is timing out on this +platform. + +* platform/mac-wk1/TestExpectations: + +2021-07-02 Chris Dumez + Resync WebCryptoAPI web-platform-tests from upstream https://bugs.webkit.org/show_bug.cgi?id=227601 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (279516 => 279517) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-07-02 21:09:02 UTC (rev 279516) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-07-02 21:19:29 UTC (rev 279517) @@ -869,6 +869,7 @@ imported/w3c/web-platform-tests/css/css-display/display-none-inline-img.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-compositing-change.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html [ ImageOnlyFailure ] +imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/tall-cross-domain-iframe-in-scrolled.sub.html [ Skip ] # REGRESSION (Mojave): 12 fast/images tests timing out on WK1 fast/images/animated-heics-draw.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279515] tags/Safari-612.1.21.2/
Title: [279515] tags/Safari-612.1.21.2/ Revision 279515 Author rubent...@apple.com Date 2021-07-02 13:42:37 -0700 (Fri, 02 Jul 2021) Log Message Tag Safari-612.1.21.2. Added Paths tags/Safari-612.1.21.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279514] trunk/Source/WebKit
Title: [279514] trunk/Source/WebKit Revision 279514 Author cdu...@apple.com Date 2021-07-02 13:35:05 -0700 (Fri, 02 Jul 2021) Log Message Take a process assertion in the network process when holding locked files https://bugs.webkit.org/show_bug.cgi?id=227552 Reviewed by Sihui Liu. Take a process assertion in the network process when holding locked files. Previously, we'd send an IPC to the UIProcess and the UIProcess would take the assertion on behalf of the network process. However, our previous approach was racy and could cause the network process to still get suspended while still holding locked files (which would get it killed). We have evidence that the network process is getting killed a lot for this reason (rdar://79787123). * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::NetworkProcess): Call setIsHoldingLockedFiles() when the "isHoldingLockedFiles" state changes instead of sending an IPC to the UIProcess. setIsHoldingLockedFiles() takes care of taking or releasing a RunningBoard assertion. (WebKit::NetworkProcess::prepareToSuspend): (WebKit::NetworkProcess::resume): Stop calling setSuspended() on the WebSQLiteDatabaseTracker. The purpose was to avoid sending the SetIsHoldingLockedFiles IPC to the UIProcess after receiving the PrepareToSuspend IPC. However, it is now acceptable to take a process assertion after PrepareToSuspend IPC has been received. * NetworkProcess/NetworkProcess.h: * NetworkProcess/ios/NetworkProcessIOS.mm: (WebKit::NetworkProcess::setIsHoldingLockedFiles): When setIsHoldingLockedFiles(true) gets called, we take a runningboard assertion to prevent suspension. Note that setIsHoldingLockedFiles(true) gets on the storage thread (which started the SQLite transaction) so we take the assertion synchronously to make sure we cannot get suspended during a SQLite transaction. When setIsHoldingLockedFiles(false) gets called, we release the runningboard assertion. * Shared/WebSQLiteDatabaseTracker.cpp: (WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker): (WebKit::WebSQLiteDatabaseTracker::~WebSQLiteDatabaseTracker): (WebKit::WebSQLiteDatabaseTracker::setIsSuspended): (WebKit::WebSQLiteDatabaseTracker::willBeginFirstTransaction): (WebKit::WebSQLiteDatabaseTracker::didFinishLastTransaction): (WebKit::WebSQLiteDatabaseTracker::setIsHoldingLockedFiles): * Shared/WebSQLiteDatabaseTracker.h: Update WebSQLiteDatabaseTracker so that it called its isHoldingLockedFilesHandler lambda directly on the storage thread when the first transaction starts, instead of dispatching to the main thread. Dispatching to the main thread would be racy as it would mean taking the process assertion asynchronously (on the main thread), after the SQLite transaction has begun on the storage thread. As a result, of this change, I am not using the HysterisActivity class anymore and using my own thread-safe hysteresis activity using RunLoop::dispatchAfter() with an integer and a lock. * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::networkProcessDidTerminate): (WebKit::NetworkProcessProxy::sendProcessDidResume): * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: Drop the SetIsHoldingLockedFiles IPC and its handling on UIProcess side since the network process now takes the assertion by itself. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkProcess.h trunk/Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm trunk/Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp trunk/Source/WebKit/Shared/WebSQLiteDatabaseTracker.h trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in trunk/Source/WebKit/UIProcess/ProcessAssertion.cpp trunk/Source/WebKit/UIProcess/ProcessAssertion.h trunk/Source/WebKit/UIProcess/ProcessThrottler.cpp trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm Diff Modified: trunk/Source/WebKit/ChangeLog (279513 => 279514) --- trunk/Source/WebKit/ChangeLog 2021-07-02 20:33:30 UTC (rev 279513) +++ trunk/Source/WebKit/ChangeLog 2021-07-02 20:35:05 UTC (rev 279514) @@ -1,5 +1,68 @@ 2021-07-02 Chris Dumez +Take a process assertion in the network process when holding locked files +https://bugs.webkit.org/show_bug.cgi?id=227552 + +Reviewed by Sihui Liu. + +Take a process assertion in the network process when holding locked files. Previously, we'd +send an IPC to the UIProcess and the UIProcess would take the assertion on behalf of the +network process. However, our previous approach was racy and could cause the network process +to still get suspended while still holding locked files (which would get it killed). + +We have evidence that the network
[webkit-changes] [279512] trunk/Source/WebKit
Title: [279512] trunk/Source/WebKit
Revision 279512
Author cdu...@apple.com
Date 2021-07-02 13:22:56 -0700 (Fri, 02 Jul 2021)
Log Message
Regression(r278786) LocalStorageDatabase's transaction may be remain active when process gets suspended
https://bugs.webkit.org/show_bug.cgi?id=227632
Reviewed by Geoffrey Garen.
After r278786, LocalStorageDatabase has a SQL transaction that gets committed with a 500ms delay on the
storage thread. When the network process would receive the PrepareToSuspend IPC, it would suspend / hang
the storage thread, which would prevent the SQL transaction from getting committed and we would suspend
with a locked file and get killed. We now make sure to flush local storage to disk (i.e. commit that
transaction) before we suspend / hang the storage thread.
* NetworkProcess/WebStorage/StorageManagerSet.cpp:
(WebKit::StorageManagerSet::waitUntilSyncingLocalStorageFinished):
(WebKit::StorageManagerSet::flushLocalStorage):
(WebKit::StorageManagerSet::suspend):
* NetworkProcess/WebStorage/StorageManagerSet.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp
trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (279511 => 279512)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 20:22:50 UTC (rev 279511)
+++ trunk/Source/WebKit/ChangeLog 2021-07-02 20:22:56 UTC (rev 279512)
@@ -1,3 +1,22 @@
+2021-07-02 Chris Dumez
+
+Regression(r278786) LocalStorageDatabase's transaction may be remain active when process gets suspended
+https://bugs.webkit.org/show_bug.cgi?id=227632
+
+Reviewed by Geoffrey Garen.
+
+After r278786, LocalStorageDatabase has a SQL transaction that gets committed with a 500ms delay on the
+storage thread. When the network process would receive the PrepareToSuspend IPC, it would suspend / hang
+the storage thread, which would prevent the SQL transaction from getting committed and we would suspend
+with a locked file and get killed. We now make sure to flush local storage to disk (i.e. commit that
+transaction) before we suspend / hang the storage thread.
+
+* NetworkProcess/WebStorage/StorageManagerSet.cpp:
+(WebKit::StorageManagerSet::waitUntilSyncingLocalStorageFinished):
+(WebKit::StorageManagerSet::flushLocalStorage):
+(WebKit::StorageManagerSet::suspend):
+* NetworkProcess/WebStorage/StorageManagerSet.h:
+
2021-07-02 Brady Eidson
WebPageProxy::setAppHighlightsVisibility might send message from a background thread, ASSERTing
Modified: trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp (279511 => 279512)
--- trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp 2021-07-02 20:22:50 UTC (rev 279511)
+++ trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp 2021-07-02 20:22:56 UTC (rev 279512)
@@ -157,16 +157,22 @@
BinarySemaphore semaphore;
m_queue->dispatch([this, ] {
-for (const auto& storageArea : m_storageAreas.values()) {
-ASSERT(storageArea);
-if (storageArea)
-storageArea->syncToDatabase();
-}
+flushLocalStorage();
semaphore.signal();
});
semaphore.wait();
}
+void StorageManagerSet::flushLocalStorage()
+{
+ASSERT(!RunLoop::isMain());
+for (const auto& storageArea : m_storageAreas.values()) {
+ASSERT(storageArea);
+if (storageArea)
+storageArea->syncToDatabase();
+}
+}
+
void StorageManagerSet::suspend(CompletionHandler&& completionHandler)
{
ASSERT(RunLoop::isMain());
@@ -186,6 +192,10 @@
return;
}
+// Make sure we flush local storage to disk before we suspend the thread as we want to make sure any pending
+// SQL transaction has been committed.
+flushLocalStorage();
+
m_state = State::Suspended;
RunLoop::main().dispatch(WTFMove(completionHandler));
Modified: trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.h (279511 => 279512)
--- trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.h 2021-07-02 20:22:50 UTC (rev 279511)
+++ trunk/Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.h 2021-07-02 20:22:56 UTC (rev 279512)
@@ -80,6 +80,8 @@
private:
StorageManagerSet();
+void flushLocalStorage();
+
// Message Handlers
void connectToLocalStorageArea(IPC::Connection&, PAL::SessionID , StorageNamespaceIdentifier, SecurityOriginData&&, ConnectToStorageAreaCallback&&);
void connectToTransientLocalStorageArea(IPC::Connection&, PAL::SessionID , StorageNamespaceIdentifier, SecurityOriginData&&, SecurityOriginData&&, ConnectToStorageAreaCallback&&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [279511] trunk/LayoutTests
Title: [279511] trunk/LayoutTests Revision 279511 Author tsav...@apple.com Date 2021-07-02 13:22:50 -0700 (Fri, 02 Jul 2021) Log Message Unreviewed, reverting r279485. Broke expectations for 7 mathML test on Big Sur wk1 Reverted changeset: "Move some Mac MathML test expectation files around" https://bugs.webkit.org/show_bug.cgi?id=227520 https://commits.webkit.org/r279485 Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt Added Paths trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/relations/ trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/ trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/ trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt Removed Paths trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/presentation-markup/ trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/ Diff Modified: trunk/LayoutTests/ChangeLog (279510 => 279511) --- trunk/LayoutTests/ChangeLog 2021-07-02 19:19:47 UTC (rev 279510) +++ trunk/LayoutTests/ChangeLog 2021-07-02 20:22:50 UTC (rev 279511) @@ -1,3 +1,15 @@ +2021-07-02 Truitt Savell + +Unreviewed, reverting r279485. + +Broke expectations for 7 mathML test on Big Sur wk1 + +Reverted changeset: + +"Move some Mac MathML test expectation files around" +https://bugs.webkit.org/show_bug.cgi?id=227520 +https://commits.webkit.org/r279485 + 2021-07-02 Eric Hutchison [ BigSur Release Arm64 ] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html is a flakey text failure Modified: trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt (279510 => 279511) --- trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt 2021-07-02 19:19:47 UTC (rev 279510) +++ trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt 2021-07-02 20:22:50 UTC (rev 279511) @@ -3,8 +3,8 @@ PASS Border properties on maction (rtl) FAIL Border properties on menclose assert_approx_equals: bottom border expected 60 +/- 1 but got -4.171875 FAIL Border properties on menclose (rtl) assert_approx_equals: bottom border expected 60 +/- 1 but got -4.171875 -FAIL Border properties on merror assert_approx_equals: element width expected 70 +/- 1 but got 72 -FAIL Border properties on merror (rtl) assert_approx_equals: element width expected 70 +/- 1 but got 72 +PASS Border properties on merror +PASS Border properties on merror (rtl) FAIL Border properties on mfrac assert_approx_equals: left border expected 30 +/- 1 but got 0 FAIL Border properties on mfrac (rtl) assert_approx_equals: left border expected 30 +/- 1 but got 0 PASS Border properties on mi Copied: trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt (from rev 279510, trunk/LayoutTests/platform/mac-mojave-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt) (0 => 279511) --- trunk/LayoutTests/platform/mac-bigsur-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt (rev 0) +++
[webkit-changes] [279509] trunk/Source/WebKit
Title: [279509] trunk/Source/WebKit
Revision 279509
Author beid...@apple.com
Date 2021-07-02 10:57:12 -0700 (Fri, 02 Jul 2021)
Log Message
WebPageProxy::setAppHighlightsVisibility might send message from a background thread, ASSERTing
and https://bugs.webkit.org/show_bug.cgi?id=227607
Reviewed by Chris Dumez.
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::setAppHighlightsVisibility):
(WebKit::WebPageProxy::setUpHighlightsObserver): The callback we get here is often on a background thread.
So bounce it to main.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (279508 => 279509)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 17:55:45 UTC (rev 279508)
+++ trunk/Source/WebKit/ChangeLog 2021-07-02 17:57:12 UTC (rev 279509)
@@ -1,3 +1,15 @@
+2021-07-02 Brady Eidson
+
+WebPageProxy::setAppHighlightsVisibility might send message from a background thread, ASSERTing
+ and https://bugs.webkit.org/show_bug.cgi?id=227607
+
+Reviewed by Chris Dumez.
+
+* UIProcess/Cocoa/WebPageProxyCocoa.mm:
+(WebKit::WebPageProxy::setAppHighlightsVisibility):
+(WebKit::WebPageProxy::setUpHighlightsObserver): The callback we get here is often on a background thread.
+ So bounce it to main.
+
2021-07-02 Philippe Normand
[GTK] Add new revision variable in pkgconfig file
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm (279508 => 279509)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm 2021-07-02 17:55:45 UTC (rev 279508)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm 2021-07-02 17:57:12 UTC (rev 279509)
@@ -587,6 +587,8 @@
void WebPageProxy::setAppHighlightsVisibility(WebCore::HighlightVisibility appHighlightsVisibility)
{
+RELEASE_ASSERT(isMainRunLoop());
+
if (!hasRunningProcess())
return;
@@ -604,9 +606,16 @@
{
if (m_appHighlightsObserver)
return;
+
+auto weakThis = makeWeakPtr(*this);
auto updateAppHighlightsVisibility = ^(BOOL isVisible) {
-setAppHighlightsVisibility(isVisible ? WebCore::HighlightVisibility::Visible : WebCore::HighlightVisibility::Hidden);
+ensureOnMainRunLoop([weakThis, isVisible] {
+if (!weakThis)
+return;
+weakThis->setAppHighlightsVisibility(isVisible ? WebCore::HighlightVisibility::Visible : WebCore::HighlightVisibility::Hidden);
+});
};
+
m_appHighlightsObserver = adoptNS([allocSYNotesActivationObserverInstance() initWithHandler:updateAppHighlightsVisibility]);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279508] trunk/Source/WebCore
Title: [279508] trunk/Source/WebCore
Revision 279508
Author za...@apple.com
Date 2021-07-02 10:55:45 -0700 (Fri, 02 Jul 2021)
Log Message
[LFC][TFC] Keep track of both the fixed and percent maximum values for each column
https://bugs.webkit.org/show_bug.cgi?id=227491
Reviewed by Antti Koivisto.
This patch is in preparation for supporting mixed column width types when each row
has diffrent type of widths (e.g )
* layout/formattingContexts/table/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::computedPreferredWidthForColumns):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (279507 => 279508)
--- trunk/Source/WebCore/ChangeLog 2021-07-02 17:41:29 UTC (rev 279507)
+++ trunk/Source/WebCore/ChangeLog 2021-07-02 17:55:45 UTC (rev 279508)
@@ -1,5 +1,18 @@
2021-07-02 Alan Bujtas
+[LFC][TFC] Keep track of both the fixed and percent maximum values for each column
+https://bugs.webkit.org/show_bug.cgi?id=227491
+
+Reviewed by Antti Koivisto.
+
+This patch is in preparation for supporting mixed column width types when each row
+has diffrent type of widths (e.g )
+
+* layout/formattingContexts/table/TableFormattingContext.cpp:
+(WebCore::Layout::TableFormattingContext::computedPreferredWidthForColumns):
+
+2021-07-02 Alan Bujtas
+
[LFC][TFC] TableGrid::Column holds both the computed and the used width values
https://bugs.webkit.org/show_bug.cgi?id=227488
Modified: trunk/Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp (279507 => 279508)
--- trunk/Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp 2021-07-02 17:41:29 UTC (rev 279507)
+++ trunk/Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp 2021-07-02 17:55:45 UTC (rev 279508)
@@ -339,8 +339,10 @@
column.setComputedLogicalWidth({ *fixedWidth, LengthType::Fixed });
}
-Vector> columnPercentList(columnList.size());
auto hasColumnWithPercentWidth = false;
+auto hasColumnWithFixedWidth = false;
+Vector> maximumFixedColumnWidths(columnList.size());
+Vector> maximumPercentColumnWidths(columnList.size());
for (auto& cell : grid.cells()) {
auto& cellBox = cell->box();
ASSERT(cellBox.establishesBlockFormattingContext());
@@ -351,26 +353,35 @@
formattingState.setIntrinsicWidthConstraintsForBox(cellBox, *intrinsicWidth);
}
auto cellPosition = cell->position();
+auto& cellStyle = cellBox.style();
// Expand it with border and padding.
auto horizontalBorderAndPaddingWidth = formattingGeometry.computedCellBorder(*cell).width()
-+ formattingGeometry.fixedValue(cellBox.style().paddingLeft()).value_or(0)
-+ formattingGeometry.fixedValue(cellBox.style().paddingRight()).value_or(0);
++ formattingGeometry.fixedValue(cellStyle.paddingLeft()).value_or(0)
++ formattingGeometry.fixedValue(cellStyle.paddingRight()).value_or(0);
intrinsicWidth->expand(horizontalBorderAndPaddingWidth);
// Spanner cells put their intrinsic widths on the initial slots.
grid.slot(cellPosition)->setWidthConstraints(*intrinsicWidth);
-if (auto fixedWidth = formattingGeometry.fixedValue(cellBox.style().logicalWidth())) {
-*fixedWidth += horizontalBorderAndPaddingWidth;
-auto& column = columnList[cellPosition.column];
-if (*fixedWidth > column.computedLogicalWidth().value())
-column.setComputedLogicalWidth({ *fixedWidth, LengthType::Fixed });
+
+auto cellLogicalWidth = cellStyle.logicalWidth();
+auto columnIndex = cellPosition.column;
+switch (cellLogicalWidth.type()) {
+case LengthType::Fixed: {
+auto fixedWidth = LayoutUnit { cellLogicalWidth.value() } + horizontalBorderAndPaddingWidth;
+maximumFixedColumnWidths[columnIndex] = std::max(maximumFixedColumnWidths[columnIndex].value_or(0_lu), fixedWidth);
+hasColumnWithFixedWidth = true;
+break;
}
-// Collect the percent values so that we can compute the maximum values per column.
-auto& cellLogicalWidth = cellBox.style().logicalWidth();
-if (cellLogicalWidth.isPercent()) {
-// FIXME: Add support for column spanning distribution.
-columnPercentList[cellPosition.column] = std::max(cellLogicalWidth.percent(), columnPercentList[cellPosition.column].value_or(0.0f));
+case LengthType::Percent: {
+maximumPercentColumnWidths[columnIndex] = std::max(maximumPercentColumnWidths[columnIndex].value_or(0.f), cellLogicalWidth.percent());
hasColumnWithPercentWidth = true;
+break;
}
+case LengthType::Relative:
+
[webkit-changes] [279507] trunk/LayoutTests
Title: [279507] trunk/LayoutTests Revision 279507 Author ryanhad...@apple.com Date 2021-07-02 10:41:29 -0700 (Fri, 02 Jul 2021) Log Message [ BigSur Release Arm64 ] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html is a flakey text failure https://bugs.webkit.org/show_bug.cgi?id=223472 Unreviewed test gardening. Patch by Eric Hutchison on 2021-07-02 * platform/mac-wk1/TestExpectations: Removing obsolete failure expectation. * platform/mac/TestExpectations: Mark test as flaky. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (279506 => 279507) --- trunk/LayoutTests/ChangeLog 2021-07-02 16:05:57 UTC (rev 279506) +++ trunk/LayoutTests/ChangeLog 2021-07-02 17:41:29 UTC (rev 279507) @@ -1,3 +1,13 @@ +2021-07-02 Eric Hutchison + +[ BigSur Release Arm64 ] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html is a flakey text failure +https://bugs.webkit.org/show_bug.cgi?id=223472 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: Removing obsolete failure expectation. +* platform/mac/TestExpectations: Mark test as flaky. + 2021-07-02 Commit Queue Unreviewed, reverting r279487. Modified: trunk/LayoutTests/platform/mac/TestExpectations (279506 => 279507) --- trunk/LayoutTests/platform/mac/TestExpectations 2021-07-02 16:05:57 UTC (rev 279506) +++ trunk/LayoutTests/platform/mac/TestExpectations 2021-07-02 17:41:29 UTC (rev 279507) @@ -2306,3 +2306,5 @@ webkit.org/b/226598 animations/leak-document-with-css-animation.html [ Pass Failure ] webkit.org/b/215335 [ BigSur Release ] webanimations/css-transition-retargeting-during-ready-promise.html [ Pass Failure ] + +webkit.org/b/223472 [ BigSur Release arm64 ] imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html [ Pass Failure ] Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (279506 => 279507) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-07-02 16:05:57 UTC (rev 279506) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-07-02 17:41:29 UTC (rev 279507) @@ -815,8 +815,6 @@ webkit.org/b/191357 imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-subframe-root.html [ Skip ] webkit.org/b/191357 imported/w3c/web-platform-tests/css/cssom-view/scroll-behavior-subframe-window.html [ Skip ] -webkit.org/b/189908 imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html [ Failure ] - webkit.org/b/189756 compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html [ Pass ImageOnlyFailure ] webkit.org/b/189723 http/tests/security/cross-origin-xsl-redirect-BLOCKED.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279506] trunk/Source
Title: [279506] trunk/Source
Revision 279506
Author commit-qu...@webkit.org
Date 2021-07-02 09:05:57 -0700 (Fri, 02 Jul 2021)
Log Message
[GTK] Add new revision variable in pkgconfig file
https://bugs.webkit.org/show_bug.cgi?id=227629
Patch by Philippe Normand on 2021-07-02
Reviewed by Michael Catanzaro.
Source/_javascript_Core:
* _javascript_coregtk.pc.in: Include SVN_REVISION as revision variable, useful for apps to
know on which upstream SVN revision their WebKitGTK-based app is built on.
Source/WebKit:
Include SVN_REVISION as revision variable, useful for apps to know on which upstream SVN
revision their WebKitGTK-based app is built on.
* gtk/webkit2gtk-web-extension.pc.in:
* gtk/webkit2gtk.pc.in:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_coregtk.pc.in
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/gtk/webkit2gtk-web-extension.pc.in
trunk/Source/WebKit/gtk/webkit2gtk.pc.in
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (279505 => 279506)
--- trunk/Source/_javascript_Core/ChangeLog 2021-07-02 15:38:36 UTC (rev 279505)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-07-02 16:05:57 UTC (rev 279506)
@@ -1,3 +1,13 @@
+2021-07-02 Philippe Normand
+
+[GTK] Add new revision variable in pkgconfig file
+https://bugs.webkit.org/show_bug.cgi?id=227629
+
+Reviewed by Michael Catanzaro.
+
+* _javascript_coregtk.pc.in: Include SVN_REVISION as revision variable, useful for apps to
+know on which upstream SVN revision their WebKitGTK-based app is built on.
+
2021-07-01 Yijia Huang
Remove unnecessary canBeInternal invocations to mitigate the cost of potential unmatched patterns in B3LowerToAir
Modified: trunk/Source/_javascript_Core/_javascript_coregtk.pc.in (279505 => 279506)
--- trunk/Source/_javascript_Core/_javascript_coregtk.pc.in 2021-07-02 15:38:36 UTC (rev 279505)
+++ trunk/Source/_javascript_Core/_javascript_coregtk.pc.in 2021-07-02 16:05:57 UTC (rev 279506)
@@ -2,6 +2,7 @@
exec_prefix=${prefix}
libdir=@LIB_INSTALL_DIR@
includedir=${prefix}/include
+revision=@SVN_REVISION@
Name: _javascript_CoreGTK+
Description: GTK+ version of the _javascript_Core engine
Modified: trunk/Source/WebKit/ChangeLog (279505 => 279506)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 15:38:36 UTC (rev 279505)
+++ trunk/Source/WebKit/ChangeLog 2021-07-02 16:05:57 UTC (rev 279506)
@@ -1,3 +1,16 @@
+2021-07-02 Philippe Normand
+
+[GTK] Add new revision variable in pkgconfig file
+https://bugs.webkit.org/show_bug.cgi?id=227629
+
+Reviewed by Michael Catanzaro.
+
+Include SVN_REVISION as revision variable, useful for apps to know on which upstream SVN
+revision their WebKitGTK-based app is built on.
+
+* gtk/webkit2gtk-web-extension.pc.in:
+* gtk/webkit2gtk.pc.in:
+
2021-07-02 Commit Queue
Unreviewed, reverting r279494.
Modified: trunk/Source/WebKit/gtk/webkit2gtk-web-extension.pc.in (279505 => 279506)
--- trunk/Source/WebKit/gtk/webkit2gtk-web-extension.pc.in 2021-07-02 15:38:36 UTC (rev 279505)
+++ trunk/Source/WebKit/gtk/webkit2gtk-web-extension.pc.in 2021-07-02 16:05:57 UTC (rev 279506)
@@ -2,6 +2,7 @@
exec_prefix=${prefix}
libdir=@LIB_INSTALL_DIR@
includedir=${prefix}/include
+revision=@SVN_REVISION@
Name: WebKitGTK web process extensions
Description: Web content engine for GTK - web process extensions
Modified: trunk/Source/WebKit/gtk/webkit2gtk.pc.in (279505 => 279506)
--- trunk/Source/WebKit/gtk/webkit2gtk.pc.in 2021-07-02 15:38:36 UTC (rev 279505)
+++ trunk/Source/WebKit/gtk/webkit2gtk.pc.in 2021-07-02 16:05:57 UTC (rev 279506)
@@ -2,6 +2,7 @@
exec_prefix=${prefix}
libdir=@LIB_INSTALL_DIR@
includedir=${prefix}/include
+revision=@SVN_REVISION@
Name: WebKitGTK
Description: Web content engine for GTK
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279505] trunk
Title: [279505] trunk
Revision 279505
Author commit-qu...@webkit.org
Date 2021-07-02 08:38:36 -0700 (Fri, 02 Jul 2021)
Log Message
Unreviewed, reverting r279494.
https://bugs.webkit.org/show_bug.cgi?id=227628
Broke api test
TestWebKitAPI.WKWebView.LoadSimulatedRequestUpdatesBackForwardList
Reverted changeset:
"loadSimulatedRequest: should do same delegate callbacks as
loadHTMLString and loadData"
https://bugs.webkit.org/show_bug.cgi?id=227599
https://commits.webkit.org/r279494
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (279504 => 279505)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 15:28:05 UTC (rev 279504)
+++ trunk/Source/WebKit/ChangeLog 2021-07-02 15:38:36 UTC (rev 279505)
@@ -1,3 +1,18 @@
+2021-07-02 Commit Queue
+
+Unreviewed, reverting r279494.
+https://bugs.webkit.org/show_bug.cgi?id=227628
+
+Broke api test
+TestWebKitAPI.WKWebView.LoadSimulatedRequestUpdatesBackForwardList
+
+Reverted changeset:
+
+"loadSimulatedRequest: should do same delegate callbacks as
+loadHTMLString and loadData"
+https://bugs.webkit.org/show_bug.cgi?id=227599
+https://commits.webkit.org/r279494
+
2021-07-02 Antoine Quint
REGRESSION (r279477): WebKit_iosmac failed to build in : ModelElementControllerCocoa.mm:58:24: member reference type 'WebKit::WebPageProxy' is not a pointer; did you mean to use '.'?
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (279504 => 279505)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-07-02 15:28:05 UTC (rev 279504)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-07-02 15:38:36 UTC (rev 279505)
@@ -1793,8 +1793,7 @@
m_pendingNavigationID = loadParameters.navigationID;
m_pendingWebsitePolicies = WTFMove(loadParameters.websitePolicies);
-auto unreachableURL = loadParameters.unreachableURLString.isEmpty() ? URL() : URL(URL(), loadParameters.unreachableURLString);
-SubstituteData substituteData(WTFMove(sharedBuffer), unreachableURL, simulatedResponse, SubstituteData::SessionHistoryVisibility::Visible);
+SubstituteData substituteData(WTFMove(sharedBuffer), loadParameters.request.url(), simulatedResponse, SubstituteData::SessionHistoryVisibility::Visible);
// Let the InjectedBundle know we are about to start the load, passing the user data from the UIProcess
// to all the client to set up any needed state.
Modified: trunk/Tools/ChangeLog (279504 => 279505)
--- trunk/Tools/ChangeLog 2021-07-02 15:28:05 UTC (rev 279504)
+++ trunk/Tools/ChangeLog 2021-07-02 15:38:36 UTC (rev 279505)
@@ -1,3 +1,18 @@
+2021-07-02 Commit Queue
+
+Unreviewed, reverting r279494.
+https://bugs.webkit.org/show_bug.cgi?id=227628
+
+Broke api test
+TestWebKitAPI.WKWebView.LoadSimulatedRequestUpdatesBackForwardList
+
+Reverted changeset:
+
+"loadSimulatedRequest: should do same delegate callbacks as
+loadHTMLString and loadData"
+https://bugs.webkit.org/show_bug.cgi?id=227599
+https://commits.webkit.org/r279494
+
2021-07-02 Xabier Rodriguez Calvar
[GTK] media/event-attributes.html fails if mixer is not at 100%
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm (279504 => 279505)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm 2021-07-02 15:28:05 UTC (rev 279504)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm 2021-07-02 15:38:36 UTC (rev 279505)
@@ -32,7 +32,6 @@
#import
#import
#import
-#import
#import
static NSString *exampleURLString = @"https://example.com/";
@@ -83,61 +82,6 @@
[delegate waitForDidFinishNavigation];
}
-TEST(WKWebView, LoadSimulatedRequestDelegateCallbacks)
-{
-enum class Callback : uint8_t {
-NavigationAction,
-NavigationResponse,
-StartProvisional,
-Commit,
-Finish
-};
-
-auto checkCallbacks = [] (const Vector vector) {
-ASSERT_EQ(vector.size(), 4u);
-EXPECT_EQ(vector[0], Callback::NavigationAction);
-EXPECT_EQ(vector[1], Callback::StartProvisional);
-EXPECT_EQ(vector[2], Callback::Commit);
-EXPECT_EQ(vector[3], Callback::Finish);
-};
-
-__block Vector callbacks;
-__block bool finished = false;
-auto delegate = adoptNS([TestNavigationDelegate new]);
-delegate.get().decidePolicyForNavigationAction = ^(WKNavigationAction *, void (^completionHandler)(WKNavigationActionPolicy)) {
-callbacks.append(Callback::NavigationAction);
-completionHandler(WKNavigationActionPolicyAllow);
-};
-delegate.get().decidePolicyForNavigationResponse = ^(WKNavigationResponse *, void (^completionHandler)(WKNavigationResponsePolicy)) {
-
[webkit-changes] [279504] trunk/Source/WebCore
Title: [279504] trunk/Source/WebCore Revision 279504 Author za...@apple.com Date 2021-07-02 08:28:05 -0700 (Fri, 02 Jul 2021) Log Message [LFC][TFC] TableGrid::Column holds both the computed and the used width values https://bugs.webkit.org/show_bug.cgi?id=227488 Reviewed by Antti Koivisto. This patch cleans up TableGrid::Column interface to ensure we don't confused the computed and the used widths for columns. This is also in prepartion for adding mixed width type support. * layout/formattingContexts/table/TableFormattingContext.cpp: (WebCore::Layout::TableFormattingContext::setUsedGeometryForCells): (WebCore::Layout::TableFormattingContext::computedPreferredWidthForColumns): (WebCore::Layout::TableFormattingContext::computeAndDistributeExtraSpace): * layout/formattingContexts/table/TableFormattingGeometry.cpp: (WebCore::Layout::TableFormattingGeometry::horizontalSpaceForCellContent const): * layout/formattingContexts/table/TableGrid.cpp: (WebCore::Layout::TableGrid::Column::setLogicalWidth): Deleted. (WebCore::Layout::TableGrid::Column::logicalWidth const): Deleted. (WebCore::Layout::TableGrid::Column::setLogicalLeft): Deleted. (WebCore::Layout::TableGrid::Column::logicalLeft const): Deleted. * layout/formattingContexts/table/TableGrid.h: (WebCore::Layout::TableGrid::Column::usedLogicalRight const): (WebCore::Layout::TableGrid::Column::computedLogicalWidth const): (WebCore::Layout::TableGrid::Columns::logicalWidth const): (WebCore::Layout::TableGrid::Column::setComputedLogicalWidth): (WebCore::Layout::TableGrid::Column::setUsedLogicalWidth): (WebCore::Layout::TableGrid::Column::usedLogicalWidth const): (WebCore::Layout::TableGrid::Column::setUsedLogicalLeft): (WebCore::Layout::TableGrid::Column::usedLogicalLeft const): (WebCore::Layout::TableGrid::Column::logicalRight const): Deleted. (WebCore::Layout::TableGrid::Column::fixedWidth const): Deleted. (WebCore::Layout::TableGrid::Column::percent const): Deleted. (WebCore::Layout::TableGrid::Column::setFixedWidth): Deleted. (WebCore::Layout::TableGrid::Column::setPercent): Deleted. * layout/formattingContexts/table/TableLayout.cpp: (WebCore::Layout::TableFormattingContext::TableLayout::distributedHorizontalSpace): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp trunk/Source/WebCore/layout/formattingContexts/table/TableFormattingGeometry.cpp trunk/Source/WebCore/layout/formattingContexts/table/TableGrid.cpp trunk/Source/WebCore/layout/formattingContexts/table/TableGrid.h trunk/Source/WebCore/layout/formattingContexts/table/TableLayout.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (279503 => 279504) --- trunk/Source/WebCore/ChangeLog 2021-07-02 14:45:56 UTC (rev 279503) +++ trunk/Source/WebCore/ChangeLog 2021-07-02 15:28:05 UTC (rev 279504) @@ -1,3 +1,42 @@ +2021-07-02 Alan Bujtas + +[LFC][TFC] TableGrid::Column holds both the computed and the used width values +https://bugs.webkit.org/show_bug.cgi?id=227488 + +Reviewed by Antti Koivisto. + +This patch cleans up TableGrid::Column interface to ensure we don't confused +the computed and the used widths for columns. +This is also in prepartion for adding mixed width type support. + +* layout/formattingContexts/table/TableFormattingContext.cpp: +(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells): +(WebCore::Layout::TableFormattingContext::computedPreferredWidthForColumns): +(WebCore::Layout::TableFormattingContext::computeAndDistributeExtraSpace): +* layout/formattingContexts/table/TableFormattingGeometry.cpp: +(WebCore::Layout::TableFormattingGeometry::horizontalSpaceForCellContent const): +* layout/formattingContexts/table/TableGrid.cpp: +(WebCore::Layout::TableGrid::Column::setLogicalWidth): Deleted. +(WebCore::Layout::TableGrid::Column::logicalWidth const): Deleted. +(WebCore::Layout::TableGrid::Column::setLogicalLeft): Deleted. +(WebCore::Layout::TableGrid::Column::logicalLeft const): Deleted. +* layout/formattingContexts/table/TableGrid.h: +(WebCore::Layout::TableGrid::Column::usedLogicalRight const): +(WebCore::Layout::TableGrid::Column::computedLogicalWidth const): +(WebCore::Layout::TableGrid::Columns::logicalWidth const): +(WebCore::Layout::TableGrid::Column::setComputedLogicalWidth): +(WebCore::Layout::TableGrid::Column::setUsedLogicalWidth): +(WebCore::Layout::TableGrid::Column::usedLogicalWidth const): +(WebCore::Layout::TableGrid::Column::setUsedLogicalLeft): +(WebCore::Layout::TableGrid::Column::usedLogicalLeft const): +(WebCore::Layout::TableGrid::Column::logicalRight const): Deleted. +(WebCore::Layout::TableGrid::Column::fixedWidth const): Deleted. +(WebCore::Layout::TableGrid::Column::percent const): Deleted. +
[webkit-changes] [279503] trunk
Title: [279503] trunk
Revision 279503
Author commit-qu...@webkit.org
Date 2021-07-02 07:45:56 -0700 (Fri, 02 Jul 2021)
Log Message
Unreviewed, reverting r279487.
https://bugs.webkit.org/show_bug.cgi?id=227626
Added broken ios-wk2 test
Reverted changeset:
"WebAudio auto-play policy should come from top document"
https://bugs.webkit.org/show_bug.cgi?id=227593
https://commits.webkit.org/r279487
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Removed Paths
trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe-expected.txt
trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe.html
trunk/LayoutTests/media/auto-play-web-audio-in-about-blank-iframe-expected.txt
trunk/LayoutTests/media/auto-play-web-audio-in-about-blank-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (279502 => 279503)
--- trunk/LayoutTests/ChangeLog 2021-07-02 14:13:18 UTC (rev 279502)
+++ trunk/LayoutTests/ChangeLog 2021-07-02 14:45:56 UTC (rev 279503)
@@ -1,3 +1,16 @@
+2021-07-02 Commit Queue
+
+Unreviewed, reverting r279487.
+https://bugs.webkit.org/show_bug.cgi?id=227626
+
+Added broken ios-wk2 test
+
+Reverted changeset:
+
+"WebAudio auto-play policy should come from top document"
+https://bugs.webkit.org/show_bug.cgi?id=227593
+https://commits.webkit.org/r279487
+
2021-07-02 Razvan Caliman
Web Inspector: Styles: should autocomplete `var()` and `attr()` values
Deleted: trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe-expected.txt (279502 => 279503)
--- trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe-expected.txt 2021-07-02 14:13:18 UTC (rev 279502)
+++ trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe-expected.txt 2021-07-02 14:45:56 UTC (rev 279503)
@@ -1,19 +0,0 @@
-
-
-*** Test with auto-play policy set to 'Allow'
-EVENT(load)
-EVENT(message)
-PASS: Video auto-played
-
-*** Test with auto-play policy set to 'AllowWithoutSound'
-EVENT(load)
-EVENT(message)
-PASS: Video did not auto-play
-
-*** Test with auto-play policy set to 'Deny'
-EVENT(load)
-EVENT(message)
-PASS: Video did not auto-play
-
-END OF TEST
-
Deleted: trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe.html (279502 => 279503)
--- trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe.html 2021-07-02 14:13:18 UTC (rev 279502)
+++ trunk/LayoutTests/media/auto-play-video-in-about-blank-iframe.html 2021-07-02 14:45:56 UTC (rev 279503)
@@ -1,80 +0,0 @@
-
-
-iframe {
-width: 320px;
-height: 240px;
-}
-
-
-if (window.testRunner) {
-testRunner.waitUntilDone();
-testRunner.dumpAsText();
-}
-
-async function checkAutoPlay(allowed)
-{
-let message = allowed ? "Video auto-played" : "Video did not auto-play";
-let video = iframe.contentDocument.querySelector("video");
-
-let played;
-let counter = 0;
-while (++counter < 20) {
-played = video.ended || video.currentTime != 0;
-if (allowed === played)
-break;
-await new Promise(resolve => setTimeout(resolve, 50));
-}
-
-if (allowed == played)
-consoleWrite(`PASS: ${allowed ? "Video auto-played" : "Video did not auto-play"}`);
-else
-consoleWrite(`FAIL: ${allowed ? "Video did not auto-play" : "Video auto-played"}`);
-}
-
-async function loadVideo(policy, allow)
-{
-consoleWrite(`
*** Test with auto-play policy set to '${policy}'`);
-
-if (window.internals)
-internals.setDocumentAutoplayPolicy(document, policy)
-
-iframe.src = '';
-await waitForEventWithTimeout(iframe, 'load', 4000, '"about:blank" iframe failed to load!');
-
-let script = iframe.contentDocument.head.appendChild(iframe.contentDocument.createElement('script'));
-let code = `
-let video=document.createElement('video');
-document.body.appendChild(video);
-video.controls = 1;
-video.autoplay = 1;
-video.src = '';
-video._oncanplaythrough_ = () => {
-window.parent.postMessage('loaded', '*')
-}`;
-script.appendChild(iframe.contentDocument.createTextNode(code));
-
-await waitForEventWithTimeout(window, 'message', 4000, 'iframe failed to send message!');
-await new Promise(resolve => setTimeout(resolve, 250));
-await checkAutoPlay(allow);
-}
-
-window.addEventListener('load', async () => {
-iframe = document.querySelector('iframe');
-
-await loadVideo('Allow', true);
-
-await
[webkit-changes] [279502] trunk
Title: [279502] trunk
Revision 279502
Author rcali...@apple.com
Date 2021-07-02 07:13:18 -0700 (Fri, 02 Jul 2021)
Log Message
Web Inspector: Styles: should autocomplete `var()` and `attr()` values
https://bugs.webkit.org/show_bug.cgi?id=227098
Reviewed by Devin Rousso.
Source/WebInspectorUI:
Add support for completion suggestions in the Styles details sidebar panel
for CSS Variables for use with var() and DOM node attributes for use with attr().
* UserInterface/Models/CSSCompletions.js:
(WI.CSSCompletions.prototype.addValues):
* UserInterface/Models/CSSKeywordCompletions.js:
* UserInterface/Models/DOMNodeStyles.js:
(WI.DOMNodeStyles):
(WI.DOMNodeStyles.prototype.get allCSSVariables):
(WI.DOMNodeStyles.prototype._updateStyleCascade):
(WI.DOMNodeStyles.prototype._collectCSSVariables):
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.getFunctionValueCompletions):
(WI.SpreadsheetStyleProperty.prototype._valueCompletionDataProvider):
LayoutTests:
Add test cases for contextual CSS function value completion.
* inspector/unit-tests/css-keyword-completions-expected.txt:
* inspector/unit-tests/css-keyword-completions.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/unit-tests/css-keyword-completions-expected.txt
trunk/LayoutTests/inspector/unit-tests/css-keyword-completions.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js
trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js
trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
Diff
Modified: trunk/LayoutTests/ChangeLog (279501 => 279502)
--- trunk/LayoutTests/ChangeLog 2021-07-02 08:13:46 UTC (rev 279501)
+++ trunk/LayoutTests/ChangeLog 2021-07-02 14:13:18 UTC (rev 279502)
@@ -1,3 +1,16 @@
+2021-07-02 Razvan Caliman
+
+Web Inspector: Styles: should autocomplete `var()` and `attr()` values
+https://bugs.webkit.org/show_bug.cgi?id=227098
+
+
+Reviewed by Devin Rousso.
+
+Add test cases for contextual CSS function value completion.
+
+* inspector/unit-tests/css-keyword-completions-expected.txt:
+* inspector/unit-tests/css-keyword-completions.html:
+
2021-07-02 Xabier Rodriguez Calvar
[GTK] media/event-attributes.html fails if mixer is not at 100%
Modified: trunk/LayoutTests/inspector/unit-tests/css-keyword-completions-expected.txt (279501 => 279502)
--- trunk/LayoutTests/inspector/unit-tests/css-keyword-completions-expected.txt 2021-07-02 08:13:46 UTC (rev 279501)
+++ trunk/LayoutTests/inspector/unit-tests/css-keyword-completions-expected.txt 2021-07-02 14:13:18 UTC (rev 279502)
@@ -51,3 +51,23 @@
PASS: Expected result prefix to be ""
PASS: All expected completions were present.
+-- Running test case: WI.CSSKeywordCompletions.forPartialPropertyValue.AttributeFunction
+PASS: Expected result prefix to be ""
+PASS: All expected completions were present.
+
+-- Running test case: WI.CSSKeywordCompletions.forPartialPropertyValue.MidLineAttributeFunction
+PASS: Expected result prefix to be "c"
+PASS: All expected completions were present.
+
+-- Running test case: WI.CSSKeywordCompletions.forPartialPropertyValue.VariableFunction
+PASS: Expected result prefix to be ""
+PASS: All expected completions were present.
+
+-- Running test case: WI.CSSKeywordCompletions.forPartialPropertyValue.VariableFunctionFiltered
+PASS: Expected result prefix to be "--o"
+PASS: All expected completions were present.
+
+-- Running test case: WI.CSSKeywordCompletions.forPartialPropertyValue.VariableFunctionInCalc
+PASS: Expected result prefix to be ""
+PASS: All expected completions were present.
+
Modified: trunk/LayoutTests/inspector/unit-tests/css-keyword-completions.html (279501 => 279502)
--- trunk/LayoutTests/inspector/unit-tests/css-keyword-completions.html 2021-07-02 08:13:46 UTC (rev 279501)
+++ trunk/LayoutTests/inspector/unit-tests/css-keyword-completions.html 2021-07-02 14:13:18 UTC (rev 279502)
@@ -66,7 +66,7 @@
expectedCompletions: ["range"],
});
-function addTestForPartialPropertyValue({name, description, propertyName, text, caretPosition, expectedPrefix, expectedCompletions}) {
+function addTestForPartialPropertyValue({name, description, propertyName, text, caretPosition, expectedPrefix, expectedCompletions, additionalFunctionValueCompletionsProvider}) {
suite.addTestCase({
name,
description,
@@ -74,8 +74,9 @@
caretPosition ??= text.length;
expectedPrefix ??= text;
expectedCompletions ??= [];
+additionalFunctionValueCompletionsProvider ??= () => {};
-let completionResults = WI.CSSKeywordCompletions.forPartialPropertyValue(text, propertyName, {caretPosition});
+let completionResults =
[webkit-changes] [279501] trunk/Source/WebKit
Title: [279501] trunk/Source/WebKit
Revision 279501
Author grao...@webkit.org
Date 2021-07-02 01:13:46 -0700 (Fri, 02 Jul 2021)
Log Message
REGRESSION (r279477): WebKit_iosmac failed to build in : ModelElementControllerCocoa.mm:58:24: member reference type 'WebKit::WebPageProxy' is not a pointer; did you mean to use '.'?
https://bugs.webkit.org/show_bug.cgi?id=227612
Reviewed by Alan Bujtas.
* UIProcess/Cocoa/ModelElementControllerCocoa.mm:
(WebKit::ModelElementController::takeModelElementFullscreen):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (279500 => 279501)
--- trunk/Source/WebKit/ChangeLog 2021-07-02 07:09:52 UTC (rev 279500)
+++ trunk/Source/WebKit/ChangeLog 2021-07-02 08:13:46 UTC (rev 279501)
@@ -1,3 +1,14 @@
+2021-07-02 Antoine Quint
+
+REGRESSION (r279477): WebKit_iosmac failed to build in : ModelElementControllerCocoa.mm:58:24: member reference type 'WebKit::WebPageProxy' is not a pointer; did you mean to use '.'?
+https://bugs.webkit.org/show_bug.cgi?id=227612
+
+
+Reviewed by Alan Bujtas.
+
+* UIProcess/Cocoa/ModelElementControllerCocoa.mm:
+(WebKit::ModelElementController::takeModelElementFullscreen):
+
2021-07-01 Chris Dumez
[macOS] Suspend WebProcesses that are in the process cache
Modified: trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm (279500 => 279501)
--- trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-07-02 07:09:52 UTC (rev 279500)
+++ trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm 2021-07-02 08:13:46 UTC (rev 279501)
@@ -55,7 +55,7 @@
void ModelElementController::takeModelElementFullscreen(WebCore::GraphicsLayer::PlatformLayerID contentLayerId)
{
-if (!m_webPageProxy->preferences().modelElementEnabled())
+if (!m_webPageProxy.preferences().modelElementEnabled())
return;
if (!is(m_webPageProxy.drawingArea()))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279500] trunk/Source/WebCore
Title: [279500] trunk/Source/WebCore
Revision 279500
Author you...@apple.com
Date 2021-07-02 00:09:52 -0700 (Fri, 02 Jul 2021)
Log Message
Make LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData hop to main thread before hopping to processing thread
https://bugs.webkit.org/show_bug.cgi?id=227444
Reviewed by Chris Dumez.
It is safer to hop to main thread in requestNotificationWhenReadyForVideoData callback so that we can check weakThis safely.
When in main thread, hop to processing thread if LocalSampleBufferDisplayLayer is alive.
* platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::~LocalSampleBufferDisplayLayer):
(WebCore::LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (279499 => 279500)
--- trunk/Source/WebCore/ChangeLog 2021-07-02 07:01:19 UTC (rev 279499)
+++ trunk/Source/WebCore/ChangeLog 2021-07-02 07:09:52 UTC (rev 279500)
@@ -1,3 +1,18 @@
+2021-07-02 Youenn Fablet
+
+Make LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData hop to main thread before hopping to processing thread
+https://bugs.webkit.org/show_bug.cgi?id=227444
+
+
+Reviewed by Chris Dumez.
+
+It is safer to hop to main thread in requestNotificationWhenReadyForVideoData callback so that we can check weakThis safely.
+When in main thread, hop to processing thread if LocalSampleBufferDisplayLayer is alive.
+
+* platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
+(WebCore::LocalSampleBufferDisplayLayer::~LocalSampleBufferDisplayLayer):
+(WebCore::LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData):
+
2021-06-30 Darin Adler
CSS parser using a token for Unicode ranges, but recent CSS specification says it should not
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm (279499 => 279500)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm 2021-07-02 07:01:19 UTC (rev 279499)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm 2021-07-02 07:09:52 UTC (rev 279500)
@@ -156,6 +156,7 @@
, m_frameRateMonitor([this](auto info) { onIrregularFrameRateNotification(info.frameTime, info.lastFrameTime); })
#endif
{
+ASSERT(isMainThread());
}
void LocalSampleBufferDisplayLayer::initialize(bool hideRootLayer, IntSize size, CompletionHandler&& callback)
@@ -186,6 +187,8 @@
LocalSampleBufferDisplayLayer::~LocalSampleBufferDisplayLayer()
{
+ASSERT(isMainThread());
+
m_processingQueue->dispatchSync([] { });
m_processingQueue = nullptr;
@@ -391,20 +394,22 @@
void LocalSampleBufferDisplayLayer::requestNotificationWhenReadyForVideoData()
{
auto weakThis = makeWeakPtr(*this);
-[m_sampleBufferDisplayLayer requestMediaDataWhenReadyOnQueue:m_processingQueue->dispatchQueue() usingBlock:^{
+[m_sampleBufferDisplayLayer requestMediaDataWhenReadyOnQueue:dispatch_get_main_queue() usingBlock:^{
if (!weakThis)
return;
-[m_sampleBufferDisplayLayer stopRequestingMediaData];
+m_processingQueue->dispatch([this] {
+[m_sampleBufferDisplayLayer stopRequestingMediaData];
-while (!m_pendingVideoSampleQueue.isEmpty()) {
-if (![m_sampleBufferDisplayLayer isReadyForMoreMediaData]) {
-requestNotificationWhenReadyForVideoData();
-return;
+while (!m_pendingVideoSampleQueue.isEmpty()) {
+if (![m_sampleBufferDisplayLayer isReadyForMoreMediaData]) {
+requestNotificationWhenReadyForVideoData();
+return;
+}
+auto sample = m_pendingVideoSampleQueue.takeFirst();
+enqueueSampleBuffer(sample);
}
-auto sample = m_pendingVideoSampleQueue.takeFirst();
-enqueueSampleBuffer(sample);
-}
+});
}];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279499] trunk
Title: [279499] trunk Revision 279499 Author calva...@igalia.com Date 2021-07-02 00:01:19 -0700 (Fri, 02 Jul 2021) Log Message [GTK] media/event-attributes.html fails if mixer is not at 100% https://bugs.webkit.org/show_bug.cgi?id=83704 Reviewed by Philippe Normand. Tools: * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): GStreamer ports use fakesink to avoid sound output and setting the page volume to 0 creates trouble with volume events. Let's avoid it in GStreamer ports. LayoutTests: * platform/glib/TestExpectations: Unflagged that test and other that get fixed with this patch. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/TestController.cpp Diff Modified: trunk/LayoutTests/ChangeLog (279498 => 279499) --- trunk/LayoutTests/ChangeLog 2021-07-02 06:37:39 UTC (rev 279498) +++ trunk/LayoutTests/ChangeLog 2021-07-02 07:01:19 UTC (rev 279499) @@ -1,3 +1,13 @@ +2021-07-02 Xabier Rodriguez Calvar + +[GTK] media/event-attributes.html fails if mixer is not at 100% +https://bugs.webkit.org/show_bug.cgi?id=83704 + +Reviewed by Philippe Normand. + +* platform/glib/TestExpectations: Unflagged that test and other +that get fixed with this patch. + 2021-07-01 Jean-Yves Avenard [Cocoa] Last few seconds of 'audio/webm; codecs=vorbis' appended to a SampleBuffer are not played Modified: trunk/LayoutTests/platform/glib/TestExpectations (279498 => 279499) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-07-02 06:37:39 UTC (rev 279498) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-07-02 07:01:19 UTC (rev 279499) @@ -2182,7 +2182,6 @@ webkit.org/b/143702 media/progress-events-generated-correctly.html [ Failure ] webkit.org/b/198830 media/context-menu-actions.html [ Pass Crash Failure ] webkit.org/b/193638 media/video-webkit-playsinline.html [ Failure ] -webkit.org/b/201266 media/audio-playback-restriction-play-muted.html [ Failure ] webkit.org/b/224067 media/media-source/media-source-timestampoffset-trim.html [ Failure ] webkit.org/b/160119 media/video-object-fit-change.html [ Pass Crash ImageOnlyFailure ] @@ -2208,7 +2207,6 @@ webkit.org/b/145051 webkit.org/b/198830 [ Release ] media/video-rtl.html [ ImageOnlyFailure Pass Crash ] webkit.org/b/145258 media/video-controller-child-rate.html [ Failure Pass ] -webkit.org/b/158914 webkit.org/b/198830 media/restore-from-page-cache.html [ Failure ] webkit.org/b/116277 media/video-buffered.html [ Pass Failure ] webkit.org/b/186638 media/video-remote-control-playpause.html [ Failure Timeout Pass ] @@ -2216,7 +2214,6 @@ webkit.org/b/198827 media/media-fullscreen-return-to-inline.html [ Timeout ] -webkit.org/b/198830 media/event-attributes.html [ Crash Failure ] webkit.org/b/198830 media/track/track-cue-css.html [ ImageOnlyFailure Failure Pass ] webkit.org/b/198830 media/video-size-intrinsic-scale.html [ Failure ] webkit.org/b/198830 http/tests/media/autoplay-if-audio-is-playing.html [ Pass Timeout ] @@ -2231,16 +2228,10 @@ # GLX error in gst_gl_context_glx_create_context webkit.org/b/210374 http/tests/media/user-gesture-preserved-across-xmlhttprequest.html [ Failure Pass Timeout ] -webkit.org/b/208293 media/video-restricted-invisible-autoplay-allowed-if-audible.html [ Failure ] - http/tests/media/video-preload.html [ Pass Slow ] webkit.org/b/108925 http/tests/media/video-play-stall.html [ Failure Timeout ] -webkit.org/b/131545 media/media-event-listeners.html [ Timeout ] -webkit.org/b/131545 media/video-volume.html [ Failure ] -webkit.org/b/131545 media/audio-playback-volume-changes-with-restrictions.html [ Failure ] - webkit.org/b/135086 media/video-seek-with-negative-playback.html [ Timeout Pass ] webkit.org/b/137698 media/video-controls-drag.html [ Timeout ] webkit.org/b/141959 http/tests/media/clearkey/clear-key-hls-aes128.html [ Crash Timeout ] Modified: trunk/Tools/ChangeLog (279498 => 279499) --- trunk/Tools/ChangeLog 2021-07-02 06:37:39 UTC (rev 279498) +++ trunk/Tools/ChangeLog 2021-07-02 07:01:19 UTC (rev 279499) @@ -1,3 +1,16 @@ +2021-07-02 Xabier Rodriguez Calvar + +[GTK] media/event-attributes.html fails if mixer is not at 100% +https://bugs.webkit.org/show_bug.cgi?id=83704 + +Reviewed by Philippe Normand. + +* WebKitTestRunner/TestController.cpp: +(WTR::TestController::resetStateToConsistentValues): GStreamer +ports use fakesink to avoid sound output and setting the page +volume to 0 creates trouble with volume events. Let's avoid it in +GStreamer ports. + 2021-07-01 Jonathan Bedard [run-webkit-tests] Set software_variant from runtime Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (279498 => 279499) --- trunk/Tools/WebKitTestRunner/TestController.cpp 2021-07-02 06:37:39 UTC (rev 279498) +++
[webkit-changes] [279498] trunk
Title: [279498] trunk Revision 279498 Author da...@apple.com Date 2021-07-01 23:37:39 -0700 (Thu, 01 Jul 2021) Log Message CSS parser using a token for Unicode ranges, but recent CSS specification says it should not https://bugs.webkit.org/show_bug.cgi?id=227569 Reviewed by Sam Weinig. LayoutTests/imported/w3c: * web-platform-tests/css/css-syntax/unicode-range-selector-expected.txt: * web-platform-tests/css/css-syntax/urange-parsing-expected.txt: Expect passes instead of fails. Source/WebCore: Tests: imported/w3c/web-platform-tests/css/css-syntax/unicode-range-selector.html imported/w3c/web-platform-tests/css/css-syntax/urange-parsing.html * css/parser/CSSParserToken.cpp: (WebCore::CSSParserToken::CSSParserToken): Change the NumberToken constructor to take a StringView so we can recover the original text if we need to parse it as part of a Unicode range. (WebCore::mergeIfAdjacent): Added. Helper used by convertToDimensionWithUnit. (WebCore::CSSParserToken::convertToDimensionWithUnit): If the number token string is adjacent to the dimension, then store the string containing both, so it can be used if we need to parse it as part of a Unicode range. If the string is long, then don't bother because a long string can't be part of such a range anyway. We use 4 bits for the length, so can handle lengths in the range [1,15]. (WebCore::CSSParserToken::originalText const): Added. Used to recover the original text for Unicode range parsing. (WebCore::CSSParserToken::unitString const): Added. Used to get just the unit part of the string for DimensionToken, since the full string now can include the number as well in some cases (see above). (WebCore::CSSParserToken::copyWithUpdatedString const): Changed the argument type to StringView instead of using const& and added an assertion since this is only safe if we are moving the backing characters, not changing the string contents. (WebCore::CSSParserToken::valueDataCharRawEqual const): Deleted. (WebCore::CSSParserToken::operator== const): Use StringView == operator instead of our own valueDataCharRawEqual function. Also use unitString for DimensionToken. (WebCore::CSSParserToken::serialize const): Use unitString for DimensionToken. * css/parser/CSSParserToken.h: Updated for the above. Also deleted UnicodeRangeToken, unicodeRangeStart, unicodeRangeEnd, and m_unicodeRange. * css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeResolutionCSSPrimitiveValueWithKnownTokenTypeDimension): Use unitString for DimensionToken. (WebCore::CSSPropertyParserHelpers::parseHexColor): Ditto. * css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeOptionalDelimiter): Added. (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeIdentifier): Added. (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeAndAppendOptionalNumber): Added. (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeAndAppendOptionalDelimiter): Added. (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeAndAppendOptionalQuestionMarks): Added. (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeUnicodeRangeString): Added. (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeUnicodeRange): Added. Along with the functions above, this implements the CSS specification's algorithm for consuming a Unicode range, based on existing tokens without requiring a token. (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceUnicodeRange): Call the new consumeUnicodeRange function from this file instead of the old one that depended on a token. Also refactored to use auto and to do the validity check for the range as specified. * css/parser/CSSSelectorParser.cpp: (WebCore::consumeANPlusB): Use unitString for DimensionToken. * css/parser/CSSTokenizer.cpp: (WebCore::CSSTokenizer::letterU): Deleted. (WebCore::CSSTokenizer::consumeNumber): Added code to pass in the original text when constructing a NumberToken. (WebCore::CSSTokenizer::consumeUnicodeRange): Deleted. * css/parser/CSSTokenizer.h: Deleted consumeUnicodeRange. * css/parser/SizesCalcParser.cpp: (WebCore::SizesCalcParser::calcToReversePolishNotation): Removed case for UnicodeRangeToken. * dom/ConstantPropertyMap.cpp: (WebCore::variableDataForPositivePixelLength): Pass a null StringView for the original text when constructing a NumberToken. This is OK for now since this token won't ever be parsed as part of a Unicode range, and we can change it if we ever need to support originalText for any other cases. (WebCore::variableDataForPositiveDuration): Ditto. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-syntax/unicode-range-selector-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-syntax/urange-parsing-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSParserToken.cpp trunk/Source/WebCore/css/parser/CSSParserToken.h
[webkit-changes] [279497] trunk/Source
Title: [279497] trunk/Source
Revision 279497
Author n...@apple.com
Date 2021-07-01 23:01:51 -0700 (Thu, 01 Jul 2021)
Log Message
Unreviewed, reverting r279172.
Broke WebGL context construction on some devices.
Reverted changeset:
"rAF driven WebGL submits excessive amount of GPU work when frames are slow"
https://bugs.webkit.org/show_bug.cgi?id=227059
https://commits.webkit.org/r279172
Modified Paths
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLEUtilities.h
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (279496 => 279497)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-07-02 04:05:41 UTC (rev 279496)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-07-02 06:01:51 UTC (rev 279497)
@@ -1,3 +1,15 @@
+2021-07-01 Ben Nham
+
+Unreviewed, reverting r279172.
+
+Broke WebGL context construction on some devices.
+
+Reverted changeset:
+
+"rAF driven WebGL submits excessive amount of GPU work when frames are slow"
+https://bugs.webkit.org/show_bug.cgi?id=227059
+https://commits.webkit.org/r279172
+
2021-07-01 Kyle Piddington
BabylonJS Under water demo is slower than it should be on Intel
Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm (279496 => 279497)
--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm 2021-07-02 04:05:41 UTC (rev 279496)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm 2021-07-02 06:01:51 UTC (rev 279497)
@@ -884,9 +884,6 @@
// GL_OES_EGL_sync
mNativeExtensions.eglSyncOES = true;
-
-// GL_ARB_sync
-mNativeExtensions.glSyncARB = true;
}
}
Modified: trunk/Source/WebCore/ChangeLog (279496 => 279497)
--- trunk/Source/WebCore/ChangeLog 2021-07-02 04:05:41 UTC (rev 279496)
+++ trunk/Source/WebCore/ChangeLog 2021-07-02 06:01:51 UTC (rev 279497)
@@ -1,3 +1,15 @@
+2021-07-01 Ben Nham
+
+Unreviewed, reverting r279172.
+
+Broke WebGL context construction on some devices.
+
+Reverted changeset:
+
+"rAF driven WebGL submits excessive amount of GPU work when frames are slow"
+https://bugs.webkit.org/show_bug.cgi?id=227059
+https://commits.webkit.org/r279172
+
2021-07-01 Jean-Yves Avenard
[Cocoa] Last few seconds of 'audio/webm; codecs=vorbis' appended to a SampleBuffer are not played
Modified: trunk/Source/WebCore/Headers.cmake (279496 => 279497)
--- trunk/Source/WebCore/Headers.cmake 2021-07-02 04:05:41 UTC (rev 279496)
+++ trunk/Source/WebCore/Headers.cmake 2021-07-02 06:01:51 UTC (rev 279497)
@@ -1330,7 +1330,6 @@
platform/graphics/angle/ANGLEHeaders.h
platform/graphics/angle/ExtensionsGLANGLE.h
-platform/graphics/angle/GraphicsContextGLANGLEUtilities.h
platform/graphics/displaylists/DisplayList.h
platform/graphics/displaylists/DisplayListDrawGlyphsRecorder.h
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (279496 => 279497)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-07-02 04:05:41 UTC (rev 279496)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2021-07-02 06:01:51 UTC (rev 279497)
@@ -715,7 +715,7 @@
26F756B51B3B68F20005DD79 /* ImmutableNFANodeBuilder.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F756B41B3B68F20005DD79 /* ImmutableNFANodeBuilder.h */; settings = {ATTRIBUTES = (Private, ); }; };
26F9A83818A046AC00AEB88A /* ViewportConfiguration.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26F9A83618A046AC00AEB88A /* ViewportConfiguration.cpp */; };
26F9A83918A046AC00AEB88A /* ViewportConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F9A83718A046AC00AEB88A /* ViewportConfiguration.h */; settings = {ATTRIBUTES = (Private, ); }; };
- 27E3C808257F5E6E00C986AB /* ANGLEHeaders.h in Headers */ = {isa = PBXBuildFile; fileRef = 27E3C806257F5E6E00C986AB /* ANGLEHeaders.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 27E3C808257F5E6E00C986AB /* ANGLEHeaders.h in Headers */ = {isa = PBXBuildFile; fileRef = 27E3C806257F5E6E00C986AB /* ANGLEHeaders.h */; };
2914E3081CAB5A440049966F /* AccessibilityAttachment.h in Headers */ = {isa = PBXBuildFile; fileRef = 2914E3061CAB5A440049966F /* AccessibilityAttachment.h */; };
2936BF5C21D69E4B004A8FC9 /* AccessibilityObjectInterface.h in Headers */ = {isa = PBXBuildFile; fileRef = 2936BF5A21D6999E004A8FC9 /* AccessibilityObjectInterface.h */; settings = {ATTRIBUTES = (Private, ); }; };
