date:20210906

[webkit-changes] [282072] trunk/Source/WebCore

2021-09-06 Thread zalan

Title: [282072] trunk/Source/WebCore








Revision 282072
Author za...@apple.com
Date 2021-09-06 20:26:03 -0700 (Mon, 06 Sep 2021)


Log Message
[LFC][Integration] Remove redundant NonRootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=229967

Reviewed by Antti Koivisto.

Now that all the inline boxes generate runs, and we use those runs to do painint/hittest, this
helper structure is not needed anymore.

* layout/integration/LayoutIntegrationInlineContent.h:
* layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayRuns const): Deleted.
* layout/integration/LayoutIntegrationInlineContentBuilder.h:
* layout/integration/LayoutIntegrationLine.h:
(WebCore::LayoutIntegration::NonRootInlineBox::NonRootInlineBox): Deleted.
(WebCore::LayoutIntegration::NonRootInlineBox::layoutBox const): Deleted.
(WebCore::LayoutIntegration::NonRootInlineBox::style const): Deleted.
(WebCore::LayoutIntegration::NonRootInlineBox::lineIndex const): Deleted.
(WebCore::LayoutIntegration::NonRootInlineBox::rect const): Deleted.
(WebCore::LayoutIntegration::NonRootInlineBox::setVerticalPositionIntegral): Deleted.
(WebCore::LayoutIntegration::NonRootInlineBox::hasScrollableContent const): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationLine.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (282071 => 282072)

--- trunk/Source/WebCore/ChangeLog	2021-09-07 01:54:49 UTC (rev 282071)
+++ trunk/Source/WebCore/ChangeLog	2021-09-07 03:26:03 UTC (rev 282072)
@@ -1,3 +1,28 @@
+2021-09-06  Alan Bujtas  
+
+[LFC][Integration] Remove redundant NonRootInlineBox
+https://bugs.webkit.org/show_bug.cgi?id=229967
+
+Reviewed by Antti Koivisto.
+
+Now that all the inline boxes generate runs, and we use those runs to do painint/hittest, this
+helper structure is not needed anymore.
+
+* layout/integration/LayoutIntegrationInlineContent.h:
+* layout/integration/LayoutIntegrationInlineContentBuilder.cpp:
+(WebCore::LayoutIntegration::InlineContentBuilder::build const):
+(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const):
+(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayRuns const): Deleted.
+* layout/integration/LayoutIntegrationInlineContentBuilder.h:
+* layout/integration/LayoutIntegrationLine.h:
+(WebCore::LayoutIntegration::NonRootInlineBox::NonRootInlineBox): Deleted.
+(WebCore::LayoutIntegration::NonRootInlineBox::layoutBox const): Deleted.
+(WebCore::LayoutIntegration::NonRootInlineBox::style const): Deleted.
+(WebCore::LayoutIntegration::NonRootInlineBox::lineIndex const): Deleted.
+(WebCore::LayoutIntegration::NonRootInlineBox::rect const): Deleted.
+(WebCore::LayoutIntegration::NonRootInlineBox::setVerticalPositionIntegral): Deleted.
+(WebCore::LayoutIntegration::NonRootInlineBox::hasScrollableContent const): Deleted.
+
 2021-09-06  Commit Queue  
 
 Unreviewed, reverting r282058.


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h (282071 => 282072)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h	2021-09-07 01:54:49 UTC (rev 282071)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContent.h	2021-09-07 03:26:03 UTC (rev 282072)
@@ -59,7 +59,6 @@
 
 Runs runs;
 Lines lines;
-Vector nonRootInlineBoxes;
 
 float clearGapAfterLastLine { 0 };
 


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp (282071 => 282072)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp	2021-09-07 01:54:49 UTC (rev 282071)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp	2021-09-07 03:26:03 UTC (rev 282072)
@@ -67,42 +67,16 @@
 
 void InlineContentBuilder::build(Layout::InlineFormattingState& inlineFormattingState, InlineContent& inlineContent) const
 {
-createDisplayRuns(inlineFormattingState, inlineContent);
-createDisplayLines(inlineFormattingState.lines(), inlineContent);
-}
-
-void InlineContentBuilder::createDisplayRuns(Layout::InlineFormattingState& inlineFormattingState, InlineContent& inlineContent) const
-{
-// FIXME: Remove this loop when we transitioned to the "run only" setup (i.e. each inline box is represented as a run as well)
-auto& lineBoxes = const_cast(inlineFormattingState).lineBoxes();
-for (size_t lineIndex = 0;

[webkit-changes] [282071] trunk/LayoutTests

2021-09-06 Thread clopez

Title: [282071] trunk/LayoutTests








Revision 282071
Author clo...@igalia.com
Date 2021-09-06 18:54:49 -0700 (Mon, 06 Sep 2021)


Log Message
[GTK][WPE] Gardening of two flaky tests and timeout.

Unreviewed test gardening.

* TestExpectations:
* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (282070 => 282071)

--- trunk/LayoutTests/ChangeLog	2021-09-07 01:14:51 UTC (rev 282070)
+++ trunk/LayoutTests/ChangeLog	2021-09-07 01:54:49 UTC (rev 282071)
@@ -1,3 +1,12 @@
+2021-09-06  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] Gardening of two flaky tests and timeout.
+
+Unreviewed test gardening.
+
+* TestExpectations:
+* platform/glib/TestExpectations:
+
 2021-09-06  Arcady Goldmints-Orlov  
 
 [Gstreamer] Mark tests media/track/in-band/track-in-band-*-added-once.html as flaky


Modified: trunk/LayoutTests/TestExpectations (282070 => 282071)

--- trunk/LayoutTests/TestExpectations	2021-09-07 01:14:51 UTC (rev 282070)
+++ trunk/LayoutTests/TestExpectations	2021-09-07 01:54:49 UTC (rev 282071)
@@ -5084,3 +5084,5 @@
 webkit.org/b/229726 imported/w3c/web-platform-tests/css/css-font-loading/fontface-override-descriptors.html [ ImageOnlyFailure ]
 webkit.org/b/229726 imported/w3c/web-platform-tests/css/css-font-loading/fontface-size-adjust-descriptor.html [ ImageOnlyFailure ]
 webkit.org/b/229727 imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-load-var.html [ Skip ]
+
+webkit.org/b/229975 fast/text/FontFaceSet-status-after-style-update.html [ Failure Pass ]


Modified: trunk/LayoutTests/platform/glib/TestExpectations (282070 => 282071)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-09-07 01:14:51 UTC (rev 282070)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-09-07 01:54:49 UTC (rev 282071)
@@ -2439,6 +2439,10 @@
 
 webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-clip-content-box-002.html [ ImageOnlyFailure ]
 
+webkit.org/b/229764 animations/background-position.html [ ImageOnlyFailure Pass ]
+
+webkit.org/b/229979 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
+
 # End: Common failures between GTK and WPE.
 
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282070] trunk/LayoutTests

2021-09-06 Thread commit-queue

Title: [282070] trunk/LayoutTests








Revision 282070
Author commit-qu...@webkit.org
Date 2021-09-06 18:14:51 -0700 (Mon, 06 Sep 2021)


Log Message
[Gstreamer] Mark tests media/track/in-band/track-in-band-*-added-once.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=229973

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov  on 2021-09-06

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (282069 => 282070)

--- trunk/LayoutTests/ChangeLog	2021-09-07 00:48:35 UTC (rev 282069)
+++ trunk/LayoutTests/ChangeLog	2021-09-07 01:14:51 UTC (rev 282070)
@@ -1,3 +1,12 @@
+2021-09-06  Arcady Goldmints-Orlov  
+
+[Gstreamer] Mark tests media/track/in-band/track-in-band-*-added-once.html as flaky
+https://bugs.webkit.org/show_bug.cgi?id=229973
+
+Unreviewed test gardening.
+
+* platform/glib/TestExpectations:
+
 2021-09-06  Commit Queue  
 
 Unreviewed, reverting r282058.


Modified: trunk/LayoutTests/platform/glib/TestExpectations (282069 => 282070)

--- trunk/LayoutTests/platform/glib/TestExpectations	2021-09-07 00:48:35 UTC (rev 282069)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2021-09-07 01:14:51 UTC (rev 282070)
@@ -687,6 +687,9 @@
 
 webkit.org/b/229761 http/tests/media/media-stream/audio-capture-and-category.https.html [ Failure ]
 
+webkit.org/b/229973 media/track/in-band/track-in-band-kate-ogg-cues-added-once.html [ Failure Pass ]
+webkit.org/b/229973 media/track/in-band/track-in-band-srt-mkv-cues-added-once.html [ Failure Pass ]
+
 #
 # End of GStreamer-related bugs
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282069] trunk

2021-09-06 Thread commit-queue

Title: [282069] trunk








Revision 282069
Author commit-qu...@webkit.org
Date 2021-09-06 17:48:35 -0700 (Mon, 06 Sep 2021)


Log Message
Unreviewed, reverting r282058.
https://bugs.webkit.org/show_bug.cgi?id=229978

broken two css layout tests on iOS

Reverted changeset:

"Add a temporarily prefixed property for mask-mode, aliased to
-webkit-mask-source-type"
https://bugs.webkit.org/show_bug.cgi?id=229915
https://commits.webkit.org/r282058

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/CSSToStyleMap.cpp
trunk/Source/WebCore/css/CSSToStyleMap.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/style/FillLayer.cpp
trunk/Source/WebCore/rendering/style/FillLayer.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.cpp
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py




Diff

Modified: trunk/LayoutTests/ChangeLog (282068 => 282069)

--- trunk/LayoutTests/ChangeLog	2021-09-07 00:41:11 UTC (rev 282068)
+++ trunk/LayoutTests/ChangeLog	2021-09-07 00:48:35 UTC (rev 282069)
@@ -1,5 +1,19 @@
 2021-09-06  Commit Queue  
 
+Unreviewed, reverting r282058.
+https://bugs.webkit.org/show_bug.cgi?id=229978
+
+broken two css layout tests on iOS
+
+Reverted changeset:
+
+"Add a temporarily prefixed property for mask-mode, aliased to
+-webkit-mask-source-type"
+https://bugs.webkit.org/show_bug.cgi?id=229915
+https://commits.webkit.org/r282058
+
+2021-09-06  Commit Queue  
+
 Unreviewed, reverting r282057.
 https://bugs.webkit.org/show_bug.cgi?id=229977
 


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282068 => 282069)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-09-07 00:41:11 UTC (rev 282068)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-09-07 00:48:35 UTC (rev 282069)
@@ -1,5 +1,19 @@
 2021-09-06  Commit Queue  
 
+Unreviewed, reverting r282058.
+https://bugs.webkit.org/show_bug.cgi?id=229978
+
+broken two css layout tests on iOS
+
+Reverted changeset:
+
+"Add a temporarily prefixed property for mask-mode, aliased to
+-webkit-mask-source-type"
+https://bugs.webkit.org/show_bug.cgi?id=229915
+https://commits.webkit.org/r282058
+
+2021-09-06  Commit Queue  
+
 Unreviewed, reverting r282057.
 https://bugs.webkit.org/show_bug.cgi?id=229977
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (282068 => 282069)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2021-09-07 00:41:11 UTC (rev 282068)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2021-09-07 00:48:35 UTC (rev 282069)
@@ -367,7 +367,6 @@
 PASS -webkit-mask-clip
 PASS -webkit-mask-composite
 PASS -webkit-mask-image
-PASS -webkit-mask-mode
 PASS -webkit-mask-origin
 PASS -webkit-mask-position-x
 PASS -webkit-mask-position-y


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt (282068 => 282069)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt	2021-09-07 00:41:11 UTC (rev 282068)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt	2021-09-07 00:48:35 UTC (rev 282069)
@@ -9,5 +9,5 @@
 PASS invalid property does not appear
 FAIL Shorthands aren't serialized if there are other properties with different logical groups in between assert_equals: expected "margin-top: 10px; margin-right: 10px; margin-left: 10px; margin-inline-start: 10px; margin-block: 10px; margin-inline-end: 10px; margin-bottom: 10px;" but got "margin: 10px; margin-inline: 10px; margin-block: 10px;"
 PASS Shorthands _are_ serialized if there are no other properties with different logical groups in between
-FAIL cssText on computed style declaration returns the empty string assert_equals: cssText

[webkit-changes] [282068] trunk/Tools

2021-09-06 Thread aakash_jain

Title: [282068] trunk/Tools








Revision 282068
Author aakash_j...@apple.com
Date 2021-09-06 17:41:11 -0700 (Mon, 06 Sep 2021)


Log Message
[ews] Invoke transfer-archive-to-s3 with Python 3
https://bugs.webkit.org/show_bug.cgi?id=229972

Reviewed by Alexey Proskuryakov.

* CISupport/ews-build/steps.py:
(TransferToS3): Invoke with python 3.
* CISupport/ews-build/steps_unittest.py: Updated unit-tests.
* CISupport/Shared/transfer-archive-to-s3: Changed shebang to python 3.

Modified Paths

trunk/Tools/CISupport/Shared/transfer-archive-to-s3
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/Shared/transfer-archive-to-s3 (282067 => 282068)

--- trunk/Tools/CISupport/Shared/transfer-archive-to-s3	2021-09-07 00:16:52 UTC (rev 282067)
+++ trunk/Tools/CISupport/Shared/transfer-archive-to-s3	2021-09-07 00:41:11 UTC (rev 282068)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 import argparse
 import boto3
 import os


Modified: trunk/Tools/CISupport/ews-build/steps.py (282067 => 282068)

--- trunk/Tools/CISupport/ews-build/steps.py	2021-09-07 00:16:52 UTC (rev 282067)
+++ trunk/Tools/CISupport/ews-build/steps.py	2021-09-07 00:41:11 UTC (rev 282068)
@@ -2748,7 +2748,7 @@
 archive = WithProperties('public_html/archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(patch_id)s.zip')
 identifier = WithProperties('%(fullPlatform)s-%(architecture)s-%(configuration)s')
 patch_id = WithProperties('%(patch_id)s')
-command = ['python', '../Shared/transfer-archive-to-s3', '--patch_id', patch_id, '--identifier', identifier, '--archive', archive]
+command = ['python3', '../Shared/transfer-archive-to-s3', '--patch_id', patch_id, '--identifier', identifier, '--archive', archive]
 haltOnFailure = False
 flunkOnFailure = False
 


Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (282067 => 282068)

--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2021-09-07 00:16:52 UTC (rev 282067)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2021-09-07 00:41:11 UTC (rev 282068)
@@ -3196,7 +3196,7 @@
 self.setProperty('architecture', 'x86_64')
 self.setProperty('patch_id', '1234')
 self.expectLocalCommands(
-ExpectMasterShellCommand(command=['python',
+ExpectMasterShellCommand(command=['python3',
   '../Shared/transfer-archive-to-s3',
   '--patch_id', '1234',
   '--identifier', 'mac-highsierra-x86_64-release',
@@ -3215,7 +3215,7 @@
 self.setProperty('architecture', 'x86_64')
 self.setProperty('patch_id', '1234')
 self.expectLocalCommands(
-ExpectMasterShellCommand(command=['python',
+ExpectMasterShellCommand(command=['python3',
   '../Shared/transfer-archive-to-s3',
   '--patch_id', '1234',
   '--identifier', 'ios-simulator-12-x86_64-debug',


Modified: trunk/Tools/ChangeLog (282067 => 282068)

--- trunk/Tools/ChangeLog	2021-09-07 00:16:52 UTC (rev 282067)
+++ trunk/Tools/ChangeLog	2021-09-07 00:41:11 UTC (rev 282068)
@@ -1,3 +1,15 @@
+2021-09-06  Aakash Jain  
+
+[ews] Invoke transfer-archive-to-s3 with Python 3
+https://bugs.webkit.org/show_bug.cgi?id=229972
+
+Reviewed by Alexey Proskuryakov.
+
+* CISupport/ews-build/steps.py:
+(TransferToS3): Invoke with python 3.
+* CISupport/ews-build/steps_unittest.py: Updated unit-tests.
+* CISupport/Shared/transfer-archive-to-s3: Changed shebang to python 3.
+
 2021-09-06  Commit Queue  
 
 Unreviewed, reverting r282025.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282067] trunk

2021-09-06 Thread commit-queue

Title: [282067] trunk








Revision 282067
Author commit-qu...@webkit.org
Date 2021-09-06 17:16:52 -0700 (Mon, 06 Sep 2021)


Log Message
Unreviewed, reverting r282057.
https://bugs.webkit.org/show_bug.cgi?id=229977

made a layout test extremely flaky

Reverted changeset:

"Add support for RTCSctpTransport"
https://bugs.webkit.org/show_bug.cgi?id=229292
https://commits.webkit.org/r282057

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCIceTransport-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-connectionState.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-constructor-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxChannels-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt
trunk/LayoutTests/webrtc/datachannel/dtls10.html
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources-input.xcfilelist
trunk/Source/WebCore/DerivedSources-output.xcfilelist
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/dom/EventTargetFactory.in


Removed Paths

trunk/Source/WebCore/Modules/mediastream/RTCSctpTransport.cpp
trunk/Source/WebCore/Modules/mediastream/RTCSctpTransport.h
trunk/Source/WebCore/Modules/mediastream/RTCSctpTransport.idl
trunk/Source/WebCore/Modules/mediastream/RTCSctpTransportBackend.h
trunk/Source/WebCore/Modules/mediastream/RTCSctpTransportState.h
trunk/Source/WebCore/Modules/mediastream/RTCSctpTransportState.idl
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.cpp
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.h




Diff

Modified: trunk/LayoutTests/ChangeLog (282066 => 282067)

--- trunk/LayoutTests/ChangeLog	2021-09-06 22:44:24 UTC (rev 282066)
+++ trunk/LayoutTests/ChangeLog	2021-09-07 00:16:52 UTC (rev 282067)
@@ -1,5 +1,18 @@
 2021-09-06  Commit Queue  
 
+Unreviewed, reverting r282057.
+https://bugs.webkit.org/show_bug.cgi?id=229977
+
+made a layout test extremely flaky
+
+Reverted changeset:
+
+"Add support for RTCSctpTransport"
+https://bugs.webkit.org/show_bug.cgi?id=229292
+https://commits.webkit.org/r282057
+
+2021-09-06  Commit Queue  
+
 Unreviewed, reverting r282025.
 https://bugs.webkit.org/show_bug.cgi?id=229970
 


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282066 => 282067)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-09-06 22:44:24 UTC (rev 282066)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-09-07 00:16:52 UTC (rev 282067)
@@ -1,3 +1,16 @@
+2021-09-06  Commit Queue  
+
+Unreviewed, reverting r282057.
+https://bugs.webkit.org/show_bug.cgi?id=229977
+
+made a layout test extremely flaky
+
+Reverted changeset:
+
+"Add support for RTCSctpTransport"
+https://bugs.webkit.org/show_bug.cgi?id=229292
+https://commits.webkit.org/r282057
+
 2021-09-06  Youenn Fablet  
 
 Add support for RTCSctpTransport


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-expected.txt (282066 => 282067)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-expected.txt	2021-09-06 22:44:24 UTC (rev 282066)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-expected.txt	2021-09-07 00:16:52 UTC (rev 282067)
@@ -9,7 +9,7 @@
 PASS Datachannel should be able to send ArrayBuffer message and receive as Blob
 FAIL Datachannel binaryType

[webkit-changes] [282065] trunk

2021-09-06 Thread clopez

Title: [282065] trunk








Revision 282065
Author clo...@igalia.com
Date 2021-09-06 15:03:44 -0700 (Mon, 06 Sep 2021)


Log Message
[CMake] Prefer python3 over python2
https://bugs.webkit.org/show_bug.cgi?id=229969

Reviewed by Michael Catanzaro.

Use the CMake module FindPython instead of FindPythonInterp.
FindPython looks preferably for version 3 of Python. If not found, then it looks for version 2.

* Source/cmake/WebKitCommon.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/WebKitCommon.cmake




Diff

Modified: trunk/ChangeLog (282064 => 282065)

--- trunk/ChangeLog	2021-09-06 19:48:30 UTC (rev 282064)
+++ trunk/ChangeLog	2021-09-06 22:03:44 UTC (rev 282065)
@@ -1,3 +1,15 @@
+2021-09-06  Carlos Alberto Lopez Perez  
+
+[CMake] Prefer python3 over python2
+https://bugs.webkit.org/show_bug.cgi?id=229969
+
+Reviewed by Michael Catanzaro.
+
+Use the CMake module FindPython instead of FindPythonInterp.
+FindPython looks preferably for version 3 of Python. If not found, then it looks for version 2.
+
+* Source/cmake/WebKitCommon.cmake:
+
 2021-09-03  Michael Catanzaro  
 
 Disable GCC_OFFLINEASM_SOURCE_MAP


Modified: trunk/Source/cmake/WebKitCommon.cmake (282064 => 282065)

--- trunk/Source/cmake/WebKitCommon.cmake	2021-09-06 19:48:30 UTC (rev 282064)
+++ trunk/Source/cmake/WebKitCommon.cmake	2021-09-06 22:03:44 UTC (rev 282065)
@@ -177,8 +177,10 @@
 find_package(Perl 5.10.0 REQUIRED)
 find_package(PerlModules COMPONENTS JSON::PP REQUIRED)
 
-set(Python_ADDITIONAL_VERSIONS 3)
-find_package(PythonInterp 2.7.0 REQUIRED)
+# This module looks preferably for version 3 of Python. If not found, version 2 is searched.
+find_package(Python COMPONENTS Interpreter REQUIRED)
+# Set the variable with uppercase name to keep compatibility with code and users expecting it.
+set(PYTHON_EXECUTABLE ${Python_EXECUTABLE} CACHE FILEPATH "Path to the Python interpreter")
 
 # We cannot check for RUBY_FOUND because it is set only when the full package is installed and
 # the only thing we need is the interpreter. Unlike Python, cmake does not provide a macro






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282064] trunk/Tools

2021-09-06 Thread clopez

Title: [282064] trunk/Tools








Revision 282064
Author clo...@igalia.com
Date 2021-09-06 12:48:30 -0700 (Mon, 06 Sep 2021)


Log Message
[GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash
https://bugs.webkit.org/show_bug.cgi?id=229758

Reviewed by Philippe Normand.

Add a new function in XvfbDriver() to ensure that the display server
at a given display_id is replying as expected. Ask it for the screen
size at monitor 0 and compare the result with the one we expect to
have inside Xvfb. For doing this check a external python program is
called which does the query using GTK. Using a external program is
more robust against possible failures calling into GTK and also will
allow re-using this program also to check that the weston server is
also replying as expected for the weston driver (on a future patch).

If the Xvfb driver is not replying as expected then restart it and
try again, up to 3 retries.

Use this also on the weston driver to check that the Xvfb driver is
ready.

The code is both compatible with python2 and python3, when running on
python2 it will try first to use subprocess32 if available, otherwise
will use standard python2 subprocess without using the timeout feature.

* Scripts/webkitpy/common/system/executive_mock.py:
(MockProcess.__init__):
(MockProcess.communicate):
* Scripts/webkitpy/port/westondriver.py:
(WestonDriver._setup_environ_for_test):
* Scripts/webkitpy/port/westondriver_unittest.py:
(WestonXvfbDriverDisplayTest._xvfb_check_if_ready):
* Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver):
(XvfbDriver.__init__):
(XvfbDriver.check_driver):
(XvfbDriver._xvfb_run):
(XvfbDriver._xvfb_screen_size):
(XvfbDriver._xvfb_stop):
(XvfbDriver._xvfb_check_if_ready):
(XvfbDriver._setup_environ_for_test):
(XvfbDriver.has_crashed):
(XvfbDriver.stop):
* Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.assertDriverStartSuccessful):
(XvfbDriverTest.test_xvfb_start_and_ready):
(XvfbDriverTest.test_xvfb_start_arbitrary_worker_number):
(XvfbDriverTest.test_xvfb_not_replying):
* gtk/print-screen-size: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py
trunk/Tools/Scripts/webkitpy/port/westondriver.py
trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py
trunk/Tools/Scripts/webkitpy/port/xvfbdriver.py
trunk/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py


Added Paths

trunk/Tools/gtk/print-screen-size




Diff

Modified: trunk/Tools/ChangeLog (282063 => 282064)

--- trunk/Tools/ChangeLog	2021-09-06 19:30:19 UTC (rev 282063)
+++ trunk/Tools/ChangeLog	2021-09-06 19:48:30 UTC (rev 282064)
@@ -1,3 +1,55 @@
+2021-09-06  Carlos Alberto Lopez Perez  
+
+[GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash
+https://bugs.webkit.org/show_bug.cgi?id=229758
+
+Reviewed by Philippe Normand.
+
+Add a new function in XvfbDriver() to ensure that the display server
+at a given display_id is replying as expected. Ask it for the screen
+size at monitor 0 and compare the result with the one we expect to
+have inside Xvfb. For doing this check a external python program is
+called which does the query using GTK. Using a external program is
+more robust against possible failures calling into GTK and also will
+allow re-using this program also to check that the weston server is
+also replying as expected for the weston driver (on a future patch).
+
+If the Xvfb driver is not replying as expected then restart it and
+try again, up to 3 retries.
+
+Use this also on the weston driver to check that the Xvfb driver is
+ready.
+
+The code is both compatible with python2 and python3, when running on
+python2 it will try first to use subprocess32 if available, otherwise
+will use standard python2 subprocess without using the timeout feature.
+
+* Scripts/webkitpy/common/system/executive_mock.py:
+(MockProcess.__init__):
+(MockProcess.communicate):
+* Scripts/webkitpy/port/westondriver.py:
+(WestonDriver._setup_environ_for_test):
+* Scripts/webkitpy/port/westondriver_unittest.py:
+(WestonXvfbDriverDisplayTest._xvfb_check_if_ready):
+* Scripts/webkitpy/port/xvfbdriver.py:
+(XvfbDriver):
+(XvfbDriver.__init__):
+(XvfbDriver.check_driver):
+(XvfbDriver._xvfb_run):
+(XvfbDriver._xvfb_screen_size):
+(XvfbDriver._xvfb_stop):
+(XvfbDriver._xvfb_check_if_ready):
+(XvfbDriver._setup_environ_for_test):
+(XvfbDriver.has_crashed):
+(XvfbDriver.stop):
+* Scripts/webkitpy/port/xvfbdriver_unittest.py:
+(XvfbDriverTest.make_driver):
+(XvfbDriverTest.assertDriverStartSuccessful):
+(XvfbDriverTest.test_xvfb_start_and_ready):
+

[webkit-changes] [282063] trunk

2021-09-06 Thread simon . fraser

Title: [282063] trunk








Revision 282063
Author simon.fra...@apple.com
Date 2021-09-06 12:30:19 -0700 (Mon, 06 Sep 2021)


Log Message
REGRESSION (r280017): Calling getBoundingClientRect() on an empty element with "break-before: column" in columns returns a rect with all zeros
https://bugs.webkit.org/show_bug.cgi?id=229747

Reviewed by Alan Bujtas.
Source/WebCore:

A zero-height element with `break-before: column` ends up with an offset which is exactly
equal to the column height, and therefore logically can be positioned at the bottom of one
column, or the top of the next. For elements with non-zero height, we have logic to avoid
putting the bottom of the box into the next column. Fix this logic for zero-height elements
to avoid the end column being less than the start column. This avoids an early return in
RenderMultiColumnSet::fragmentRectsForFlowContentRect() which resulted in a zero client rect.

Test: fast/multicol/newmulticol/client-rects-column-breakers.html

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::firstAndLastColumnsFromOffsets const):

LayoutTests:

* fast/multicol/newmulticol/client-rects-column-breakers-expected.txt: Added.
* fast/multicol/newmulticol/client-rects-column-breakers.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp


Added Paths

trunk/LayoutTests/fast/multicol/newmulticol/client-rects-column-breakers-expected.txt
trunk/LayoutTests/fast/multicol/newmulticol/client-rects-column-breakers.html




Diff

Modified: trunk/LayoutTests/ChangeLog (282062 => 282063)

--- trunk/LayoutTests/ChangeLog	2021-09-06 19:04:04 UTC (rev 282062)
+++ trunk/LayoutTests/ChangeLog	2021-09-06 19:30:19 UTC (rev 282063)
@@ -1,3 +1,13 @@
+2021-09-06  Simon Fraser  
+
+REGRESSION (r280017): Calling getBoundingClientRect() on an empty element with "break-before: column" in columns returns a rect with all zeros
+https://bugs.webkit.org/show_bug.cgi?id=229747
+
+Reviewed by Alan Bujtas.
+
+* fast/multicol/newmulticol/client-rects-column-breakers-expected.txt: Added.
+* fast/multicol/newmulticol/client-rects-column-breakers.html: Added.
+
 2021-09-06  Arcady Goldmints-Orlov  
 
 [GLIB] Garden tests related to the experimetal  element


Added: trunk/LayoutTests/fast/multicol/newmulticol/client-rects-column-breakers-expected.txt (0 => 282063)

--- trunk/LayoutTests/fast/multicol/newmulticol/client-rects-column-breakers-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/client-rects-column-breakers-expected.txt	2021-09-06 19:30:19 UTC (rev 282063)
@@ -0,0 +1,6 @@
+bounding client rect x:288 y:11 width: 229 height:0
+bounding client rect x:19 y:651 width: 229 height:0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/multicol/newmulticol/client-rects-column-breakers.html (0 => 282063)

--- trunk/LayoutTests/fast/multicol/newmulticol/client-rects-column-breakers.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/newmulticol/client-rects-column-breakers.html	2021-09-06 19:30:19 UTC (rev 282063)
@@ -0,0 +1,66 @@
+
+
+
+
+.columns {
+margin: 10px;
+width: 500px;
+height: 400px;
+column-count: 2;
+column-gap: 40px;
+column-fill: auto;
+border: 1px solid gray;
+box-sizing:border-box;
+}
+
+.box {
+margin: 10px;
+width: 100px;
+height: 100px;
+background-color: silver;
+}
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function logClientRect(elementId)
+{
+let target = document.getElementById(elementId);
+var bounds = target.getBoundingClientRect();
+debug('bounding client rect x:' + bounds.x + ' y:' + bounds.y + ' width: ' + bounds.width + ' height:'+ bounds.height);
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+logClientRect('target-before');
+logClientRect('target-after');
+
+

[webkit-changes] [282062] trunk/LayoutTests

2021-09-06 Thread commit-queue

Title: [282062] trunk/LayoutTests








Revision 282062
Author commit-qu...@webkit.org
Date 2021-09-06 12:04:04 -0700 (Mon, 06 Sep 2021)


Log Message
[GLIB] Garden tests related to the experimetal  element
https://bugs.webkit.org/show_bug.cgi?id=229966

All the tests fail for the same basic reason: this element is not
enabled on GLIB platforms, so all these failures should be tracked
under one bug.

Unreviewed test gardening.

Patch by Arcady Goldmints-Orlov  on 2021-09-06

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (282061 => 282062)

--- trunk/LayoutTests/ChangeLog	2021-09-06 18:42:42 UTC (rev 282061)
+++ trunk/LayoutTests/ChangeLog	2021-09-06 19:04:04 UTC (rev 282062)
@@ -1,3 +1,17 @@
+2021-09-06  Arcady Goldmints-Orlov  
+
+[GLIB] Garden tests related to the experimetal  element
+https://bugs.webkit.org/show_bug.cgi?id=229966
+
+All the tests fail for the same basic reason: this element is not
+enabled on GLIB platforms, so all these failures should be tracked
+under one bug.
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2021-09-06  Enrique Ocaña González  
 
 [MSE] Prevent false-positive "stalled" event iff MSE used


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (282061 => 282062)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2021-09-06 18:42:42 UTC (rev 282061)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2021-09-06 19:04:04 UTC (rev 282062)
@@ -604,6 +604,11 @@
 
 webkit.org/b/141699 fast/attachment/attachment-disabled-rendering.html [ Failure ]
 webkit.org/b/141699 fast/attachment/attachment-rendering.html [ Failure ]
+webkit.org/b/141699 editing/pasteboard/copy-paste-attachment.html [ Failure ]
+webkit.org/b/141699 fast/attachment/attachment-dom.html [ Failure ]
+webkit.org/b/141699 fast/attachment/attachment-respects-css-size.html [ ImageOnlyFailure ]
+webkit.org/b/141699 fast/css/has-attachment.html [ Failure ]
+webkit.org/b/141699 editing/text-iterator/backwards-text-iterator-attachment.html [ Failure ]
 
 webkit.org/b/141458 imported/mozilla/svg/blend-overlay.svg [ ImageOnlyFailure Pass ]
 webkit.org/b/141458 imported/mozilla/svg/pattern-scale-01a.svg [ ImageOnlyFailure Pass ]
@@ -615,8 +620,6 @@
 
 webkit.org/b/118126 css3/flexbox/image-percent-max-height.html [ ImageOnlyFailure ]
 
-webkit.org/b/142268 editing/pasteboard/copy-paste-attachment.html [ Failure ]
-webkit.org/b/142269 fast/attachment/attachment-dom.html [ Failure ]
 webkit.org/b/142270 fast/canvas/canvas-ellipse-zero-lineto.html [ Failure ]
 
 # This feature is only enabled on Mac and iOS right now
@@ -968,9 +971,6 @@
 
 webkit.org/b/152642 http/tests/misc/detached-frame-console.html [ Failure ]
 
-# See also webkit.org/b/141699
-webkit.org/b/177534 fast/attachment/attachment-respects-css-size.html [ Crash ImageOnlyFailure ]
-
 # Crashes only when GNOME icon theme is not installed
 webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ]
 
@@ -1853,8 +1853,6 @@
 webkit.org/b/191400 fast/block/basic/inline-content-with-floating-images2.html [ Failure ]
 webkit.org/b/191400 fast/block/basic/quirk-mode-percent-height.html [ Failure ]
 
-webkit.org/b/191402 fast/css/has-attachment.html [ Failure ]
-
 webkit.org/b/191688 compositing/backing/no-backing-for-clip-overlap.html [ Failure ]
 webkit.org/b/191688 compositing/backing/no-backing-for-clip.html [ Failure ]
 webkit.org/b/191688 compositing/backing/no-backing-for-perspective.html [ Failure ]


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (282061 => 282062)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2021-09-06 18:42:42 UTC (rev 282061)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2021-09-06 19:04:04 UTC (rev 282062)
@@ -1317,7 +1317,7 @@
 
 webkit.org/b/192891 fast/writing-mode/vertical-align-table-baseline.html [ Failure ]
 
-webkit.org/b/194009 fast/css/has-attachment.html [ Failure ]
+webkit.org/b/141699 fast/css/has-attachment.html [ Failure ]
 
 webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-force-end-001.xht [ ImageOnlyFailure ]
 webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-first-001.xht [ Timeout ImageOnlyFailure ]
@@ -1387,7 +1387,7 @@
 
 webkit.org/b/212157 imported/blink/editing/execCommand/4128080-2.html [ Failure ]
 
-webkit.org/b/212199 fast/attachment/attachment-respects-css-size.html [ ImageOnlyFailure ]
+webkit.org/b/141699 fast/attachment/attachment-respects-css-size.html [ ImageOnlyFailure ]
 
 webkit.org/b/212200 fast/spatial-navigation/snav-input.html [ Failure ]
 webkit.org/b/212200 fast/spatial-navigation/snav-textarea.html [

[webkit-changes] [282061] trunk/Source

2021-09-06 Thread commit-queue

Title: [282061] trunk/Source








Revision 282061
Author commit-qu...@webkit.org
Date 2021-09-06 11:42:42 -0700 (Mon, 06 Sep 2021)


Log Message
Fix WebKitGTK build on MacOS
https://bugs.webkit.org/show_bug.cgi?id=225850

Patch by Dmitry Kalinkin  on 2021-09-06
Reviewed by Michael Catanzaro.

Define HAVE_AUDIT_TOKEN only for Cocoa backend.
Source/WebKit:

Streamline other conditionals for consistency between headers and implementations.

* NetworkProcess/ServiceWorker/WebSWOriginStore.cpp:
(WebKit::WebSWOriginStore::sendStoreHandle):
* Platform/IPC/unix/ConnectionUnix.cpp:
* Platform/IPC/IPCSemaphore.h:
* Platform/SharedMemory.h:
* UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::sendStoreHandleToProcess):

Source/WTF:

* wtf/PlatformHave.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWOriginStore.cpp
trunk/Source/WebKit/Platform/IPC/IPCSemaphore.h
trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
trunk/Source/WebKit/Platform/SharedMemory.h
trunk/Source/WebKit/UIProcess/VisitedLinkStore.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (282060 => 282061)

--- trunk/Source/WTF/ChangeLog	2021-09-06 17:49:10 UTC (rev 282060)
+++ trunk/Source/WTF/ChangeLog	2021-09-06 18:42:42 UTC (rev 282061)
@@ -1,3 +1,14 @@
+2021-09-06  Dmitry Kalinkin  
+
+Fix WebKitGTK build on MacOS
+https://bugs.webkit.org/show_bug.cgi?id=225850
+
+Reviewed by Michael Catanzaro.
+
+Define HAVE_AUDIT_TOKEN only for Cocoa backend.
+
+* wtf/PlatformHave.h:
+
 2021-09-03  Basuke Suzuki  
 
 Use USE(SYSTEM_MALLOC) macro in all cases


Modified: trunk/Source/WTF/wtf/PlatformHave.h (282060 => 282061)

--- trunk/Source/WTF/wtf/PlatformHave.h	2021-09-06 17:49:10 UTC (rev 282060)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2021-09-06 18:42:42 UTC (rev 282061)
@@ -53,6 +53,10 @@
 #endif
 
 #if PLATFORM(COCOA)
+#define HAVE_AUDIT_TOKEN 1
+#endif
+
+#if PLATFORM(COCOA)
 #define HAVE_OUT_OF_PROCESS_LAYER_HOSTING 1
 #endif
 
@@ -206,10 +210,6 @@
 #define HAVE_SYS_TIMEB_H 1
 #endif
 
-#if OS(DARWIN)
-#define HAVE_AUDIT_TOKEN 1
-#endif
-
 #if OS(DARWIN) && __has_include() && !PLATFORM(GTK)
 #define HAVE_MACH_EXCEPTIONS 1
 #endif


Modified: trunk/Source/WebKit/ChangeLog (282060 => 282061)

--- trunk/Source/WebKit/ChangeLog	2021-09-06 17:49:10 UTC (rev 282060)
+++ trunk/Source/WebKit/ChangeLog	2021-09-06 18:42:42 UTC (rev 282061)
@@ -1,3 +1,21 @@
+2021-09-06  Dmitry Kalinkin  
+
+Fix WebKitGTK build on MacOS
+https://bugs.webkit.org/show_bug.cgi?id=225850
+
+Reviewed by Michael Catanzaro.
+
+Define HAVE_AUDIT_TOKEN only for Cocoa backend.
+Streamline other conditionals for consistency between headers and implementations.
+
+* NetworkProcess/ServiceWorker/WebSWOriginStore.cpp:
+(WebKit::WebSWOriginStore::sendStoreHandle):
+* Platform/IPC/unix/ConnectionUnix.cpp:
+* Platform/IPC/IPCSemaphore.h:
+* Platform/SharedMemory.h:
+* UIProcess/VisitedLinkStore.cpp:
+(WebKit::VisitedLinkStore::sendStoreHandleToProcess):
+
 2021-09-06  Youenn Fablet  
 
 Implement libwebrtc network manager GetMdnsResponder


Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWOriginStore.cpp (282060 => 282061)

--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWOriginStore.cpp	2021-09-06 17:49:10 UTC (rev 282060)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWOriginStore.cpp	2021-09-06 18:42:42 UTC (rev 282061)
@@ -87,7 +87,7 @@
 if (!m_store.createSharedMemoryHandle(handle))
 return;
 
-#if OS(DARWIN) || OS(WINDOWS)
+#if (OS(DARWIN) || OS(WINDOWS)) && !USE(UNIX_DOMAIN_SOCKETS)
 uint64_t dataSize = handle.size();
 #else
 uint64_t dataSize = 0;


Modified: trunk/Source/WebKit/Platform/IPC/IPCSemaphore.h (282060 => 282061)

--- trunk/Source/WebKit/Platform/IPC/IPCSemaphore.h	2021-09-06 17:49:10 UTC (rev 282060)
+++ trunk/Source/WebKit/Platform/IPC/IPCSemaphore.h	2021-09-06 18:42:42 UTC (rev 282061)
@@ -29,7 +29,7 @@
 #include 
 #include 
 
-#if OS(DARWIN)
+#if PLATFORM(COCOA)
 #include 
 #include 
 #elif OS(WINDOWS)
@@ -57,7 +57,7 @@
 bool wait();
 bool waitFor(Timeout);
 
-#if OS(DARWIN)
+#if PLATFORM(COCOA)
 explicit Semaphore(MachSendRight&&);
 
 MachSendRight createSendRight() const;
@@ -70,7 +70,7 @@
 
 private:
 void destroy();
-#if OS(DARWIN)
+#if PLATFORM(COCOA)
 MachSendRight m_sendRight;
 semaphore_t m_semaphore { SEMAPHORE_NULL };
 #elif OS(WINDOWS)


Modified: trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp (282060 => 282061)

--- trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp	2021-09-06 17:49:10 UTC (rev 282060)
+++ trunk/Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp	2021-09-06 18:42:42 UTC (rev 282061)
@@ -44,6 +44,10 @@
 #include 
 #endif
 
+#if OS(DARWIN)
+#define MSG_NOSIGNAL 0
+#endif

[webkit-changes] [282060] trunk/Source/WebCore

2021-09-06 Thread antti

Title: [282060] trunk/Source/WebCore








Revision 282060
Author an...@apple.com
Date 2021-09-06 10:49:10 -0700 (Mon, 06 Sep 2021)


Log Message
[LFC][Integration] Use inline boxes in run vector for hit testing
https://bugs.webkit.org/show_bug.cgi?id=229933

Reviewed by Alan Bujtas.

Stop using nonRootInlineBoxes.

* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::hitTest):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (282059 => 282060)

--- trunk/Source/WebCore/ChangeLog	2021-09-06 16:38:28 UTC (rev 282059)
+++ trunk/Source/WebCore/ChangeLog	2021-09-06 17:49:10 UTC (rev 282060)
@@ -1,3 +1,15 @@
+2021-09-06  Antti Koivisto  
+
+[LFC][Integration] Use inline boxes in run vector for hit testing
+https://bugs.webkit.org/show_bug.cgi?id=229933
+
+Reviewed by Alan Bujtas.
+
+Stop using nonRootInlineBoxes.
+
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::hitTest):
+
 2021-09-06  Enrique Ocaña González  
 
 [MSE] Prevent false-positive "stalled" event iff MSE used


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (282059 => 282060)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2021-09-06 16:38:28 UTC (rev 282059)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2021-09-06 17:49:10 UTC (rev 282060)
@@ -480,56 +480,29 @@
 
 // FIXME: This should do something efficient to find the run range.
 for (auto& run : WTF::makeReversedRange(inlineContent.runs)) {
-// FIXME: Use for hit testing instead of nonRootInlineBoxes.
-if (run.isInlineBox())
-continue;
-
 auto& renderer = m_boxTree.rendererForLayoutBox(run.layoutBox());
 
-if (is(renderer)) {
-auto runRect = Layout::toLayoutRect(run.logicalRect());
-runRect.moveBy(accumulatedOffset);
+if (!run.isRootInlineBox() && is(renderer) && downcast(renderer).hasSelfPaintingLayer())
+continue;
 
-if (!locationInContainer.intersects(runRect))
-continue;
-
-auto& style = run.style();
-if (style.visibility() != Visibility::Visible || style.pointerEvents() == PointerEvents::None)
-continue;
-
-renderer.updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset));
-if (result.addNodeToListBasedTestResult(renderer.nodeForHitTest(), request, locationInContainer, runRect) == HitTestProgress::Stop)
+if (run.isAtomicInlineLevelBox()) {
+if (renderer.hitTest(request, result, locationInContainer, accumulatedOffset))
 return true;
 continue;
 }
 
-if (is(renderer)) {
-auto& renderBox = downcast(renderer);
-if (renderBox.hasSelfPaintingLayer())
-continue;
-
-if (renderBox.hitTest(request, result, locationInContainer, accumulatedOffset)) {
-renderBox.updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset));
-return true;
-}
-}
-}
+auto runRect = Layout::toLayoutRect(run.logicalRect());
+runRect.moveBy(accumulatedOffset);
 
-for (auto& inlineBox : WTF::makeReversedRange(inlineContent.nonRootInlineBoxes)) {
-auto inlineBoxRect = Layout::toLayoutRect(inlineBox.rect());
-inlineBoxRect.moveBy(accumulatedOffset);
-
-if (!locationInContainer.intersects(inlineBoxRect))
+if (!locationInContainer.intersects(runRect))
 continue;
 
-auto& style = inlineBox.style();
+auto& style = run.style();
 if (style.visibility() != Visibility::Visible || style.pointerEvents() == PointerEvents::None)
 continue;
-
-auto& renderer = m_boxTree.rendererForLayoutBox(inlineBox.layoutBox());
-
+
 renderer.updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset));
-if (result.addNodeToListBasedTestResult(renderer.nodeForHitTest(), request, locationInContainer, inlineBoxRect) == HitTestProgress::Stop)
+if (result.addNodeToListBasedTestResult(renderer.nodeForHitTest(), request, locationInContainer, runRect) == HitTestProgress::Stop)
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282059] trunk

2021-09-06 Thread eocanha

Title: [282059] trunk








Revision 282059
Author eoca...@igalia.com
Date 2021-09-06 09:38:28 -0700 (Mon, 06 Sep 2021)


Log Message
[MSE] Prevent false-positive "stalled" event iff MSE used
https://bugs.webkit.org/show_bug.cgi?id=226882


Reviewed by Alicia Boya Garcia.

Source/WebCore:

"progress" and "stalled" events make no sense in context of MSE:
https://github.com/w3c/media-source/issues/88
and hence they will likely be removed soon:
https://w3c.github.io/media-source/#h-note-19

This patch is authored by Pawel Lampe .
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/711

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::progressEventTimerFired): Only fire the progess event if the player supports progress monitoring.
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsProgressMonitoring const): Forward call to the player private.
* platform/graphics/MediaPlayer.h: Added new supportsProgressMonitoring() method.
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::supportsProgressMonitoring const): Added method, defaulting to true to trigger the old behaviour.
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h: Return false on new supportsProgressMonitoring() method to prevent progress event triggering.

LayoutTests:

* platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.txt: Updated expectations.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h




Diff

Modified: trunk/LayoutTests/ChangeLog (282058 => 282059)

--- trunk/LayoutTests/ChangeLog	2021-09-06 16:33:24 UTC (rev 282058)
+++ trunk/LayoutTests/ChangeLog	2021-09-06 16:38:28 UTC (rev 282059)
@@ -1,3 +1,13 @@
+2021-09-06  Enrique Ocaña González  
+
+[MSE] Prevent false-positive "stalled" event iff MSE used
+https://bugs.webkit.org/show_bug.cgi?id=226882
+
+
+Reviewed by Alicia Boya Garcia.
+
+* platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.txt: Updated expectations.
+
 2021-09-06  Simon Fraser  
 
 Add a temporarily prefixed property for mask-mode, aliased to -webkit-mask-source-type


Modified: trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.txt (282058 => 282059)

--- trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.txt	2021-09-06 16:33:24 UTC (rev 282058)
+++ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-append-buffer-expected.txt	2021-09-06 16:38:28 UTC (rev 282059)
@@ -21,5 +21,5 @@
 PASS Test abort after appendBuffer update ends.
 PASS Test appending null.
 PASS Test appending after removeSourceBuffer().
-FAIL Test slow appending does not trigger stalled events. assert_unreached: Unexpected 'stalled' event. Reached unreachable code
+PASS Test slow appending does not trigger stalled events.
 


Modified: trunk/Source/WebCore/ChangeLog (282058 => 282059)

--- trunk/Source/WebCore/ChangeLog	2021-09-06 16:33:24 UTC (rev 282058)
+++ trunk/Source/WebCore/ChangeLog	2021-09-06 16:38:28 UTC (rev 282059)
@@ -1,3 +1,28 @@
+2021-09-06  Enrique Ocaña González  
+
+[MSE] Prevent false-positive "stalled" event iff MSE used
+https://bugs.webkit.org/show_bug.cgi?id=226882
+
+
+Reviewed by Alicia Boya Garcia.
+
+"progress" and "stalled" events make no sense in context of MSE:
+https://github.com/w3c/media-source/issues/88
+and hence they will likely be removed soon:
+https://w3c.github.io/media-source/#h-note-19
+
+This patch is authored by Pawel Lampe .
+See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/711
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::progressEventTimerFired): Only fire the progess event if the player supports progress monitoring.
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::supportsProgressMonitoring const): Forward call to the player private.
+* platform/graphics/MediaPlayer.h: Added new supportsProgressMonitoring() method.
+* platform/graphics/MediaPlayerPrivate.h:
+(WebCore::MediaPlayerPrivateInterface::supportsProgressMonitoring const): Added method, defaulting to true to trigger the old behaviour.
+* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h: Return false on new supportsProgressMonitoring() method to

[webkit-changes] [282058] trunk

2021-09-06 Thread simon . fraser

Title: [282058] trunk








Revision 282058
Author simon.fra...@apple.com
Date 2021-09-06 09:33:24 -0700 (Mon, 06 Sep 2021)


Log Message
Add a temporarily prefixed property for mask-mode, aliased to -webkit-mask-source-type
https://bugs.webkit.org/show_bug.cgi?id=229915

Reviewed by Antti Koivisto.
Source/WebCore:

In preparation for unprefixing the "mask" property, add -webkit-mask-mode. This is
almost an alias to the existing -webkit-mask-source-type, but takes a "match-source"
value rather than "auto".

To make it easier to have aliases with different parsing requirements, add support
in CSSProperties.json for "synonyms"; these are like aliases but they get their
own CSSPropertyID to allow for customized parsing. They share style builder code
with the related property.

FillLayer now uses MaskMode rather than MaskSourceType.

Test: fast/masking/parsing-mask-mode.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::maskSourceTypeToCSSValue):
(WebCore::maskModeToCSSValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
(WebCore::fillSourceTypeToCSSValue): Deleted.
* css/CSSProperties.json:
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillMaskMode):
(WebCore::CSSToStyleMap::mapFillMaskSourceType): Deleted.
* css/CSSToStyleMap.h:
* css/CSSValueKeywords.in:
* css/makeprop.pl:
(addProperty):
(generateFillLayerPropertyValueSetter):
(generateValueSetter):
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeWebkitMaskMode):
(WebCore::consumeBackgroundComponent):
(WebCore::CSSPropertyParser::parseSingleValue):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator== const):
(WebCore::operator<<):
* rendering/style/FillLayer.h:
(WebCore::FillLayer::maskMode const):
(WebCore::FillLayer::isMaskModeSet const):
(WebCore::FillLayer::setMaskMode):
(WebCore::FillLayer::clearMaskMode):
(WebCore::FillLayer::initialFillMaskMode):
(WebCore::FillLayer::maskSourceType const): Deleted.
(WebCore::FillLayer::isMaskSourceTypeSet const): Deleted.
(WebCore::FillLayer::setMaskSourceType): Deleted.
(WebCore::FillLayer::clearMaskSourceType): Deleted.
(WebCore::FillLayer::initialFillMaskSourceType): Deleted.
* rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* rendering/style/RenderStyleConstants.h:

Tools:

Allow the "synonym" key in CSSProperties.json.

* Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONCSSPropertiesChecker.check_codegen_properties):

LayoutTests:

* fast/masking/parsing-mask-mode-expected.txt: Added.
* fast/masking/parsing-mask-mode.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/CSSToStyleMap.cpp
trunk/Source/WebCore/css/CSSToStyleMap.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/style/FillLayer.cpp
trunk/Source/WebCore/rendering/style/FillLayer.h
trunk/Source/WebCore/rendering/style/RenderStyleConstants.cpp
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py




Diff

Modified: trunk/LayoutTests/ChangeLog (282057 => 282058)

--- trunk/LayoutTests/ChangeLog	2021-09-06 16:14:32 UTC (rev 282057)
+++ trunk/LayoutTests/ChangeLog	2021-09-06 16:33:24 UTC (rev 282058)
@@ -1,3 +1,13 @@
+2021-09-06  Simon Fraser  
+
+Add a temporarily prefixed property for mask-mode, aliased to -webkit-mask-source-type
+https://bugs.webkit.org/show_bug.cgi?id=229915
+
+Reviewed by Antti Koivisto.
+
+* fast/masking/parsing-mask-mode-expected.txt: Added.
+* fast/masking/parsing-mask-mode.html: Added.
+
 2021-09-06  Youenn Fablet  
 
 Add support for RTCSctpTransport


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (282057 => 282058)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt	2021-09-06 16:14:32 UTC (rev 282057)
+++

[webkit-changes] [282057] trunk

2021-09-06 Thread youenn

Title: [282057] trunk








Revision 282057
Author you...@apple.com
Date 2021-09-06 09:14:32 -0700 (Mon, 06 Sep 2021)


Log Message
Add support for RTCSctpTransport
https://bugs.webkit.org/show_bug.cgi?id=229292


Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* web-platform-tests/webrtc/RTCDataChannel-send-expected.txt:
* web-platform-tests/webrtc/RTCIceTransport-expected.txt:
* web-platform-tests/webrtc/RTCPeerConnection-connectionState.https-expected.txt:
* web-platform-tests/webrtc/RTCRtpSender-transport.https-expected.txt:
* web-platform-tests/webrtc/RTCSctpTransport-constructor-expected.txt:
* web-platform-tests/webrtc/RTCSctpTransport-events-expected.txt:
* web-platform-tests/webrtc/RTCSctpTransport-maxChannels-expected.txt:
* web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt:
* web-platform-tests/webrtc/idlharness.https.window-expected.txt:

Source/ThirdParty/libwebrtc:

* Configurations/libwebrtc.iOS.exp:
* Configurations/libwebrtc.iOSsim.exp:
* Configurations/libwebrtc.mac.exp:

Source/WebCore:

Expose RTSctpTransport API and getter from the peer connection.
Implement event mechanism and getters.
Additional work will be needed to make ice transport objects consistent between SCTP and senders/receivers.
Covered by rebased tests.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::setLocalDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):
* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::updateSctpBackend):
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSctpTransport.cpp: Added.
(WebCore::RTCSctpTransport::RTCSctpTransport):
(WebCore::RTCSctpTransport::~RTCSctpTransport):
(WebCore::RTCSctpTransport::stop):
(WebCore::RTCSctpTransport::virtualHasPendingActivity const):
(WebCore::RTCSctpTransport::onStateChanged):
* Modules/mediastream/RTCSctpTransport.h: Added.
* Modules/mediastream/RTCSctpTransport.idl: Added.
* Modules/mediastream/RTCSctpTransportBackend.h: Added.
(WebCore::operator==):
* Modules/mediastream/RTCSctpTransportState.h: Added.
* Modules/mediastream/RTCSctpTransportState.idl: Added.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::SctpTransportState::SctpTransportState):
(WebCore::SctpTransportState::createBackend):
(WebCore::LibWebRTCMediaEndpoint::setLocalSessionDescriptionSucceeded):
(WebCore::LibWebRTCMediaEndpoint::setLocalSessionDescriptionFailed):
(WebCore::LibWebRTCMediaEndpoint::setRemoteSessionDescriptionSucceeded):
* Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.cpp: Added.
(WebCore::toRTCSctpTransportState):
(WebCore::LibWebRTCSctpTransportBackendObserver::LibWebRTCSctpTransportBackendObserver):
(WebCore::LibWebRTCSctpTransportBackendObserver::updateState):
(WebCore::LibWebRTCSctpTransportBackendObserver::start):
(WebCore::LibWebRTCSctpTransportBackendObserver::stop):
(WebCore::LibWebRTCSctpTransportBackendObserver::OnStateChange):
(WebCore::LibWebRTCSctpTransportBackend::LibWebRTCSctpTransportBackend):
(WebCore::LibWebRTCSctpTransportBackend::~LibWebRTCSctpTransportBackend):
(WebCore::LibWebRTCSctpTransportBackend::dtlsTransportBackend):
(WebCore::LibWebRTCSctpTransportBackend::registerClient):
(WebCore::LibWebRTCSctpTransportBackend::unregisterClient):
* Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.h: Added.
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* dom/EventTargetFactory.in:

LayoutTests:

* webrtc/datachannel/dtls10.html:
We should now check for the RTCSctpTransport's RTCDtlsTransport state
to identify whether connection is successful or not.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-send-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCIceTransport-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-connectionState.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpSender-transport.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-constructor-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-events-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxChannels-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCSctpTransport-maxMessageSize-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/idlharness.https.window-expected.txt
trunk/LayoutTests/webrtc/datachannel/dtls10.html
trunk/Source/ThirdParty/libwebrtc/ChangeLog

[webkit-changes] [282056] trunk/LayoutTests

2021-09-06 Thread eocanha

Title: [282056] trunk/LayoutTests








Revision 282056
Author eoca...@igalia.com
Date 2021-09-06 08:57:45 -0700 (Mon, 06 Sep 2021)


Log Message
[GTK] webaudio/silent-audio-interrupted-in-background.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=229964

Unreviewed test gardening.

Flagged flaky timeout for webaudio/silent-audio-interrupted-in-background.html.


* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (282055 => 282056)

--- trunk/LayoutTests/ChangeLog	2021-09-06 11:47:32 UTC (rev 282055)
+++ trunk/LayoutTests/ChangeLog	2021-09-06 15:57:45 UTC (rev 282056)
@@ -1,3 +1,14 @@
+2021-09-06  Enrique Ocaña González  
+
+[GTK] webaudio/silent-audio-interrupted-in-background.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=229964
+
+Unreviewed test gardening.
+
+Flagged flaky timeout for webaudio/silent-audio-interrupted-in-background.html.
+
+* platform/gtk/TestExpectations:
+
 2021-09-06  Youenn Fablet  
 
 Implement libwebrtc network manager GetMdnsResponder


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (282055 => 282056)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2021-09-06 11:47:32 UTC (rev 282055)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2021-09-06 15:57:45 UTC (rev 282056)
@@ -1229,6 +1229,8 @@
 webkit.org/b/229268 media/media-fragments/TC0009.html [ Failure Pass ]
 webkit.org/b/229268 media/media-fragments/TC0014.html [ Failure Pass ]
 
+webkit.org/b/229964 webaudio/silent-audio-interrupted-in-background.html [ Pass Timeout ]
+
 # Flaky on skip-failing-test bot (EWS)
 webkit.org/b/229270 fast/events/monotonic-event-time.html [ Failure Pass ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282055] trunk/Source/WebCore

2021-09-06 Thread eocanha

Title: [282055] trunk/Source/WebCore








Revision 282055
Author eoca...@igalia.com
Date 2021-09-06 04:47:32 -0700 (Mon, 06 Sep 2021)


Log Message
[GStreamer][MSE] Check ContentType parameters when checking supported types
https://bugs.webkit.org/show_bug.cgi?id=229859

Reviewed by Xabier Rodriguez-Calvar.

Some services like YouTube TV or Apple TV use ContentType parameters (channels, features, width, height,
framerate) to check for extra features or device maximum capabilities and just don't work if they're not
honored.

This patch checks that those parameters don't go over reasonable limits and reject support for the type
if they do.

This patch is an adaptation of the following downstream patches:

- https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/12c726290ac3395a0b7dd09861355e97be42e434 (authored by me)
- https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/b33dfe9fea5f991cf98884ef3bb3e3d9c660bc6b (authored by Pawel Lampe)

* platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::supportsFeatures const): Check the features parameter. Factored out as a method with the idea to add more checks it in the future.
(WebCore::GStreamerRegistryScanner::isContentTypeSupported const): Check the channels, features, width, height and framerate parameters against sane maximum values.
* platform/graphics/gstreamer/GStreamerRegistryScanner.h: Added supportsFeatures() method.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (282054 => 282055)

--- trunk/Source/WebCore/ChangeLog	2021-09-06 08:49:02 UTC (rev 282054)
+++ trunk/Source/WebCore/ChangeLog	2021-09-06 11:47:32 UTC (rev 282055)
@@ -1,3 +1,27 @@
+2021-09-06  Enrique Ocaña González  
+
+[GStreamer][MSE] Check ContentType parameters when checking supported types
+https://bugs.webkit.org/show_bug.cgi?id=229859
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Some services like YouTube TV or Apple TV use ContentType parameters (channels, features, width, height,
+framerate) to check for extra features or device maximum capabilities and just don't work if they're not
+honored.
+
+This patch checks that those parameters don't go over reasonable limits and reject support for the type
+if they do.
+
+This patch is an adaptation of the following downstream patches:
+
+- https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/12c726290ac3395a0b7dd09861355e97be42e434 (authored by me)
+- https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/b33dfe9fea5f991cf98884ef3bb3e3d9c660bc6b (authored by Pawel Lampe)
+
+* platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
+(WebCore::GStreamerRegistryScanner::supportsFeatures const): Check the features parameter. Factored out as a method with the idea to add more checks it in the future.
+(WebCore::GStreamerRegistryScanner::isContentTypeSupported const): Check the channels, features, width, height and framerate parameters against sane maximum values.
+* platform/graphics/gstreamer/GStreamerRegistryScanner.h: Added supportsFeatures() method.
+
 2021-09-06  Youenn Fablet  
 
 Implement libwebrtc network manager GetMdnsResponder


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp (282054 => 282055)

--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp	2021-09-06 08:49:02 UTC (rev 282054)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp	2021-09-06 11:47:32 UTC (rev 282055)
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 
 namespace WebCore {
 
@@ -34,6 +35,15 @@
 GST_DEBUG_CATEGORY_STATIC(webkit_media_gst_registry_scanner_debug);
 #define GST_CAT_DEFAULT webkit_media_gst_registry_scanner_debug
 
+// We shouldn't accept media that the player can't actually play.
+// AAC supports up to 96 channels.
+#define MEDIA_MAX_AAC_CHANNELS 96
+
+// Assume hardware video decoding acceleration up to 8K@60fps for the generic case. Some embedded platforms might want to tune this.
+#define MEDIA_MAX_WIDTH 7680.0f
+#define MEDIA_MAX_HEIGHT 4320.0f
+#define MEDIA_MAX_FRAMERATE 60.0f
+
 GStreamerRegistryScanner& GStreamerRegistryScanner::singleton()
 {
 static NeverDestroyed sharedInstance;
@@ -501,6 +511,16 @@
 return supported;
 }
 
+bool GStreamerRegistryScanner::supportsFeatures(const String& features) const
+{
+// Apple TV requires this one for DD+.
+constexpr auto dolbyDigitalPlusJOC = "joc";
+if (features == dolbyDigitalPlusJOC)
+return true;
+
+return false;
+}
+
 MediaPlayerEnums::SupportsType GStreamerRegistryScanner::isContentTypeSupported(Configuration configuration, const ContentType& contentType, const

[webkit-changes] [282054] trunk

2021-09-06 Thread youenn

Title: [282054] trunk








Revision 282054
Author you...@apple.com
Date 2021-09-06 01:49:02 -0700 (Mon, 06 Sep 2021)


Log Message
Implement libwebrtc network manager GetMdnsResponder
https://bugs.webkit.org/show_bug.cgi?id=229757

Reviewed by Eric Carlson.

Source/WebCore:

Use libwebrtc mDNS support instead of applying it within PeerConnectionBackend.
This allows a better integration and is more consistent with the API and other browsers.
For instance mDNS candidates now show up in local descriptions.
We introduce RTCNetworkManager which is responsible for WebRTC network.
RTCNetworkManager is responsible of all peer connections of a document. It can thus reuse mDNS names from one connection to another.
When document goes away, RTCNetworkManager needs to unregister all mDNS names.
Update existing SDP and ICE candidate filtering code by only keeping debug assert that we do not leak private IP addresses in case ICE filtering is on.
WK1 does not support mDNS candidates. In that case, we expose private IP addresses.

Covered by updated and existing tests.

* Headers.cmake:
* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::enableICECandidateFiltering):
(WebCore::PeerConnectionBackend::disableICECandidateFiltering):
(WebCore::PeerConnectionBackend::validateSDP const):
(WebCore::PeerConnectionBackend::newICECandidate):
(WebCore::PeerConnectionBackend::doneGatheringCandidates):
* Modules/mediastream/PeerConnectionBackend.h:
* Modules/mediastream/RTCController.cpp:
(WebCore::RTCController::add):
(WebCore::RTCController::disableICECandidateFilteringForAllOrigins):
(WebCore::RTCController::disableICECandidateFilteringForDocument):
(WebCore::RTCController::enableICECandidateFiltering):
* Modules/mediastream/RTCNetworkManager.h: Added.
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::setConfiguration):
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::currentLocalDescription const):
(WebCore::LibWebRTCPeerConnectionBackend::pendingLocalDescription const):
(WebCore::LibWebRTCPeerConnectionBackend::localDescription const):
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::willBeRemovedFromFrame):
(WebCore::Document::suspend):
* dom/Document.h:
(WebCore::Document::rtcNetworkManager):
(WebCore::Document::setRTCNetworkManager):
* platform/mediastream/MDNSRegisterError.h: Added.
* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::createPeerConnection):
* platform/mediastream/libwebrtc/LibWebRTCProvider.h:

Source/WebKit:

Implement RTCNetworkManager API in LibWebRTCNetworkManager to handle per-document mDNS registrations.
Move part of WebRTCMonitor to LibWebRTCNetworkManager.
LibWebRTCNetworkManager is a WebRTCMonitor observer to get the list of networks.
Since libwebrtc is now doing the mDNS registration, we need to return a mDNS name even if registration failed.
We update WebMDNSRegister and NetworkMDNSRegister accordingly.

* NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::registerMDNSNameCallback):
(WebKit::NetworkMDNSRegister::registerMDNSName):
* Sources.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Network/webrtc/LibWebRTCNetworkManager.cpp: Added.
(WebKit::LibWebRTCNetworkManager::getOrCreate):
(WebKit::LibWebRTCNetworkManager::LibWebRTCNetworkManager):
(WebKit::LibWebRTCNetworkManager::~LibWebRTCNetworkManager):
(WebKit::LibWebRTCNetworkManager::unregisterMDNSNames):
(WebKit::LibWebRTCNetworkManager::StartUpdating):
(WebKit::LibWebRTCNetworkManager::StopUpdating):
(WebKit::LibWebRTCNetworkManager::GetMdnsResponder const):
(WebKit::LibWebRTCNetworkManager::networksChanged):
(WebKit::LibWebRTCNetworkManager::networkProcessCrashed):
(WebKit::LibWebRTCNetworkManager::CreateNameForAddress):
(WebKit::LibWebRTCNetworkManager::RemoveNameForAddress):
* WebProcess/Network/webrtc/LibWebRTCNetworkManager.h: Added.
* WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::createPeerConnection):
(WebKit::LibWebRTCProvider::disableNonLocalhostConnections):
* WebProcess/Network/webrtc/LibWebRTCProvider.h:
* WebProcess/Network/webrtc/WebMDNSRegister.cpp:
(WebKit::WebMDNSRegister::finishedRegisteringMDNSName):
(WebKit::WebMDNSRegister::registerMDNSName):
* WebProcess/Network/webrtc/WebMDNSRegister.h:
* WebProcess/Network/webrtc/WebMDNSRegister.messages.in:
* WebProcess/Network/webrtc/WebRTCMonitor.cpp:
(WebKit::WebRTCMonitor::startUpdating):
(WebKit::WebRTCMonitor::stopUpdating):
(WebKit::WebRTCMonitor::networksChanged):
(WebKit::WebRTCMonitor::networkProcessCrashed):
* WebProcess/Network/webrtc/WebRTCMonitor.h:
(WebKit::WebRTCMonitor::addObserver):
(WebKit::WebRTCMonitor::removeObserver):
(WebKit::WebRTCMonitor::didReceiveNetworkList const):
(WebKit::WebRTCMonitor::networkList const):
(WebKit::WebRTCMonitor::ipv4 const):

[webkit-changes] [282053] trunk

2021-09-06 Thread commit-queue

Title: [282053] trunk








Revision 282053
Author commit-qu...@webkit.org
Date 2021-09-06 00:54:25 -0700 (Mon, 06 Sep 2021)


Log Message
webgl/1.0.x/conformance/context/constants-and-properties.html fails
https://bugs.webkit.org/show_bug.cgi?id=223311


Patch by Kimmo Kinnunen  on 2021-09-06
Reviewed by Antti Koivisto.

Source/WebCore:

Remove STENCIL_INDEX, it was removed from the spec 2017.

Fixes tests:
webgl/1.0.x/conformance/context/constants-and-properties.html
webgl/2.0.y/conformance2/context/constants-and-properties-2.html

* html/canvas/WebGLRenderingContextBase.idl:
* platform/graphics/GraphicsContextGL.h:

LayoutTests:

* TestExpectations:
Mark the skipped tests as Pass until all 1.0.x/2.0.y tests
are unskipped.
Skip the 2.0.0/1.0.3 test that is invalid now.
* fast/canvas/webgl/constants-on-interface.html: Removed.
* fast/canvas/webgl/constants.html: Removed.
Remove failing tests that serve the same purpose.
They seem to, according to best effort inspection, test
the same properties.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl
trunk/Source/WebCore/platform/graphics/GraphicsContextGL.h


Removed Paths

trunk/LayoutTests/fast/canvas/webgl/constants-on-interface.html
trunk/LayoutTests/fast/canvas/webgl/constants.html




Diff

Modified: trunk/LayoutTests/ChangeLog (282052 => 282053)

--- trunk/LayoutTests/ChangeLog	2021-09-06 02:48:59 UTC (rev 282052)
+++ trunk/LayoutTests/ChangeLog	2021-09-06 07:54:25 UTC (rev 282053)
@@ -1,3 +1,22 @@
+2021-09-06  Kimmo Kinnunen  
+
+webgl/1.0.x/conformance/context/constants-and-properties.html fails
+https://bugs.webkit.org/show_bug.cgi?id=223311
+
+
+Reviewed by Antti Koivisto.
+
+* TestExpectations:
+Mark the skipped tests as Pass until all 1.0.x/2.0.y tests
+are unskipped.
+Skip the 2.0.0/1.0.3 test that is invalid now.
+* fast/canvas/webgl/constants-on-interface.html: Removed.
+* fast/canvas/webgl/constants.html: Removed.
+Remove failing tests that serve the same purpose.
+They seem to, according to best effort inspection, test 
+the same properties.
+
+
 2021-09-05  Alan Bujtas  
 
 In-page search results overlay broken if the result spans more than two elements


Modified: trunk/LayoutTests/TestExpectations (282052 => 282053)

--- trunk/LayoutTests/TestExpectations	2021-09-06 02:48:59 UTC (rev 282052)
+++ trunk/LayoutTests/TestExpectations	2021-09-06 07:54:25 UTC (rev 282053)
@@ -3678,6 +3678,7 @@
 webgl/1.0.x/conformance/glsl/bugs/character-set.html [ Pass ]
 webgl/1.0.x/conformance/textures/misc/texture-corner-case-videos.html [ Pass ]
 webgl/1.0.x/conformance/glsl/misc/fragcolor-fragdata-invariant.html [ Pass ]
+webgl/1.0.x/conformance/context/constants-and-properties.html [ Pass ]
 
 
 # WebGL conformance test suite 2.0.1 is skipped until 2.0.0 is retired.
@@ -3689,14 +3690,17 @@
 webgl/2.0.y/conformance/glsl/bugs/character-set.html [ Pass ]
 webgl/2.0.y/conformance/textures/misc/texture-corner-case-videos.html [ Pass ]
 webgl/2.0.y/conformance/glsl/misc/fragcolor-fragdata-invariant.html [ Pass ]
+webgl/2.0.y/conformance2/context/constants-and-properties-2.html [ Pass ]
 
 # WebGL 1.0.3 and 2.0.0 tests where behavior is obsolete and WebKit contains implementation
 # and tests for the new behavior. Should be removed once 1.0.3 and 2.0.0 are retired.
+fast/canvas/webgl/invalid-passed-params.html [ Skip ]
+webgl/1.0.3/conformance/context/constants-and-properties.html  [ Skip ]
 webgl/1.0.3/conformance/glsl/misc/shader-with-define-line-continuation.frag.html [ Skip ]
 webgl/1.0.3/conformance/misc/invalid-passed-params.html [ Skip ]
+webgl/2.0.0/conformance/context/constants-and-properties.html  [ Skip ]
 webgl/2.0.0/conformance/glsl/misc/shader-with-define-line-continuation.frag.html [ Skip ]
 webgl/2.0.0/conformance/misc/invalid-passed-params.html [ Skip ]
-fast/canvas/webgl/invalid-passed-params.html [ Skip ]
 
 # pre-wrap progression. Other rendering engines agree with the result.
 webkit.org/b/206168 [ Debug ] fast/dom/insert-span-into-long-text-bug-28245.html [ Skip ]


Deleted: trunk/LayoutTests/fast/canvas/webgl/constants-on-interface.html (282052 => 282053)

--- trunk/LayoutTests/fast/canvas/webgl/constants-on-interface.html	2021-09-06 02:48:59 UTC (rev 282052)
+++ trunk/LayoutTests/fast/canvas/webgl/constants-on-interface.html	2021-09-06 07:54:25 UTC (rev 282053)
@@ -1,323 +0,0 @@
-
-if (window.testRunner)
-window.testRunner.dumpAsText();
-
-const WebGLEnums = new Map([
-["ACTIVE_ATTRIBUTES", 0x8B89],
-["ACTIVE_TEXTURE", 0x84E0],
-["ACTIVE_UNIFORMS", 0x8B86],
-["ALIASED_LINE_WIDTH_RANGE", 0x846E],
-["ALIASED_POINT_SIZE_RANGE", 0x846D],
-["ALPHA", 0x1906],
-["ALPHA_BITS", 0x0D55],
-["ALWAYS", 0x0207],
-["ARRAY_BUFFER", 0x8892],
-["ARRAY_BUFFER_BINDING", 0x8894],
-

[webkit-changes] [282072] trunk/Source/WebCore

[webkit-changes] [282071] trunk/LayoutTests

[webkit-changes] [282070] trunk/LayoutTests

[webkit-changes] [282069] trunk

[webkit-changes] [282068] trunk/Tools

[webkit-changes] [282067] trunk

[webkit-changes] [282065] trunk

[webkit-changes] [282064] trunk/Tools

[webkit-changes] [282063] trunk

[webkit-changes] [282062] trunk/LayoutTests

[webkit-changes] [282061] trunk/Source

[webkit-changes] [282060] trunk/Source/WebCore

[webkit-changes] [282059] trunk

[webkit-changes] [282058] trunk

[webkit-changes] [282057] trunk

[webkit-changes] [282056] trunk/LayoutTests

[webkit-changes] [282055] trunk/Source/WebCore

[webkit-changes] [282054] trunk

[webkit-changes] [282053] trunk

19 matches

Site Navigation

Mail list logo

Footer information