[webkit-changes] [285772] trunk/Tools

[jbedard]

Title: [285772] trunk/Tools








Revision 285772
Author jbed...@apple.com
Date 2021-11-12 20:45:28 -0800 (Fri, 12 Nov 2021)


Log Message
[webkitpy] Symlink daemons into simulator runtime root
https://bugs.webkit.org/show_bug.cgi?id=233080


Reviewed by Brady Eidson.

* Scripts/webkitpy/api_tests/manager.py:
(Manager._initialize_devices): Symlink daemons in the WebKit.framework into
simulator runtime root.
* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.symlink):
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.symlink):
* Scripts/webkitpy/port/darwin.py:
(DarwinPort.path_to_daemons):
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.Runtime.__init__): Add root.
(SimulatedDeviceManager._create_device_with_runtime): Pass runtime.
(SimulatedDevice.__init__): Link to runtime.
* Scripts/webkitpy/xcode/simulated_device_unittest.py:

Canonical link: https://commits.webkit.org/244216@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/api_tests/manager.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem.py
trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py
trunk/Tools/Scripts/webkitpy/port/darwin.py
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py
trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (285771 => 285772)

--- trunk/Tools/ChangeLog	2021-11-13 03:22:14 UTC (rev 285771)
+++ trunk/Tools/ChangeLog	2021-11-13 04:45:28 UTC (rev 285772)
@@ -1,3 +1,26 @@
+2021-11-12  Jonathan Bedard  
+
+[webkitpy] Symlink daemons into simulator runtime root
+https://bugs.webkit.org/show_bug.cgi?id=233080
+
+
+Reviewed by Brady Eidson.
+
+* Scripts/webkitpy/api_tests/manager.py:
+(Manager._initialize_devices): Symlink daemons in the WebKit.framework into
+simulator runtime root.
+* Scripts/webkitpy/common/system/filesystem.py:
+(FileSystem.symlink):
+* Scripts/webkitpy/common/system/filesystem_mock.py:
+(MockFileSystem.symlink):
+* Scripts/webkitpy/port/darwin.py:
+(DarwinPort.path_to_daemons):
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager.Runtime.__init__): Add root.
+(SimulatedDeviceManager._create_device_with_runtime): Pass runtime.
+(SimulatedDevice.__init__): Link to runtime.
+* Scripts/webkitpy/xcode/simulated_device_unittest.py:
+
 2021-11-12  Darin Adler  
 
 Make sort-Xcode-project-file idempotent


Modified: trunk/Tools/Scripts/webkitpy/api_tests/manager.py (285771 => 285772)

--- trunk/Tools/Scripts/webkitpy/api_tests/manager.py	2021-11-13 03:22:14 UTC (rev 285771)
+++ trunk/Tools/Scripts/webkitpy/api_tests/manager.py	2021-11-13 04:45:28 UTC (rev 285772)
@@ -152,6 +152,22 @@
 def _initialize_devices(self):
 if 'simulator' in self._port.port_name:
 SimulatedDeviceManager.initialize_devices(DeviceRequest(self._port.DEVICE_TYPE, allow_incomplete_match=True), self.host, simulator_ui=False)
+
+# A Daemons executable path must be located within the runtime root.
+roots = {
+device.platform_device.runtime.root for device in SimulatedDeviceManager.INITIALIZED_DEVICES
+if device.platform_device.runtime and device.platform_device.runtime.root
+}
+fs = self._port.host.filesystem
+for root in roots:
+_log.debug("Linking Daemons into runtime root '{}'".format(root))
+for file in fs.files_under(self._port.path_to_daemons()):
+target = fs.join(root, 'usr', 'local', 'bin', 'webkit-testing', fs.basename(file))
+fs.maybe_make_directory(fs.dirname(target))
+if fs.isfile(target):
+fs.remove(target)
+fs.symlink(file, target)
+
 elif 'device' in self._port.port_name:
 raise RuntimeError('Running api tests on {} is not supported'.format(self._port.port_name))
 


Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem.py (285771 => 285772)

--- trunk/Tools/Scripts/webkitpy/common/system/filesystem.py	2021-11-13 03:22:14 UTC (rev 285771)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem.py	2021-11-13 04:45:28 UTC (rev 285772)
@@ -339,3 +339,6 @@
 self.copytree(source, destination)
 else:
 self.copyfile(source, destination)
+
+def symlink(self, *args, **kwargs):
+os.symlink(*args, **kwargs)


Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py (285771 => 285772)

--- trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py	2021-11-13 03:22:14 UTC (rev 285771)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py	2021-11-13 04:45:28 UTC (rev 285772)
@@ -436,7 +436,10 @@
 def copy_from_base_host(self, source, destination):
 self.move(source, 

[webkit-changes] [285771] trunk/Source/WebCore

[timothy]

Title: [285771] trunk/Source/WebCore








Revision 285771
Author timo...@apple.com
Date 2021-11-12 19:22:14 -0800 (Fri, 12 Nov 2021)


Log Message
webView._isBeingInspected does not work with Service Worker pages
https://bugs.webkit.org/show_bug.cgi?id=233062
rdar://problem/85354982

Reviewed by Devin Rousso.

* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend): Call updateServiceWorkerPageFrontendCount().
(WebCore::WorkerInspectorController::disconnectFrontend): Ditto.
(WebCore::WorkerInspectorController::updateServiceWorkerPageFrontendCount): Added.
* inspector/WorkerInspectorController.h: Added updateServiceWorkerPageFrontendCount().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/WorkerInspectorController.cpp
trunk/Source/WebCore/inspector/WorkerInspectorController.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285770 => 285771)

--- trunk/Source/WebCore/ChangeLog	2021-11-13 02:26:18 UTC (rev 285770)
+++ trunk/Source/WebCore/ChangeLog	2021-11-13 03:22:14 UTC (rev 285771)
@@ -1,3 +1,17 @@
+2021-11-12  Timothy Hatcher  
+
+webView._isBeingInspected does not work with Service Worker pages
+https://bugs.webkit.org/show_bug.cgi?id=233062
+rdar://problem/85354982
+
+Reviewed by Devin Rousso.
+
+* inspector/WorkerInspectorController.cpp:
+(WebCore::WorkerInspectorController::connectFrontend): Call updateServiceWorkerPageFrontendCount().
+(WebCore::WorkerInspectorController::disconnectFrontend): Ditto.
+(WebCore::WorkerInspectorController::updateServiceWorkerPageFrontendCount): Added.
+* inspector/WorkerInspectorController.h: Added updateServiceWorkerPageFrontendCount().
+
 2021-11-12  Darin Adler  
 
 Make sort-Xcode-project-file idempotent


Modified: trunk/Source/WebCore/inspector/WorkerInspectorController.cpp (285770 => 285771)

--- trunk/Source/WebCore/inspector/WorkerInspectorController.cpp	2021-11-13 02:26:18 UTC (rev 285770)
+++ trunk/Source/WebCore/inspector/WorkerInspectorController.cpp	2021-11-13 03:22:14 UTC (rev 285771)
@@ -48,6 +48,8 @@
 #include <_javascript_Core/InspectorFrontendRouter.h>
 
 #if ENABLE(SERVICE_WORKER)
+#include "InspectorClient.h"
+#include "Page.h"
 #include "ServiceWorkerAgent.h"
 #include "ServiceWorkerGlobalScope.h"
 #endif
@@ -109,6 +111,10 @@
 m_forwardingChannel = makeUnique(m_globalScope);
 m_frontendRouter->connectFrontend(*m_forwardingChannel.get());
 m_agents.didCreateFrontendAndBackend(_frontendRouter.get(), _backendDispatcher.get());
+
+#if ENABLE(SERVICE_WORKER)
+updateServiceWorkerPageFrontendCount();
+#endif
 }
 
 void WorkerInspectorController::disconnectFrontend(Inspector::DisconnectReason reason)
@@ -125,8 +131,34 @@
 m_agents.willDestroyFrontendAndBackend(reason);
 m_frontendRouter->disconnectFrontend(*m_forwardingChannel.get());
 m_forwardingChannel = nullptr;
+
+#if ENABLE(SERVICE_WORKER)
+updateServiceWorkerPageFrontendCount();
+#endif
 }
 
+#if ENABLE(SERVICE_WORKER)
+void WorkerInspectorController::updateServiceWorkerPageFrontendCount()
+{
+if (!is(m_globalScope))
+return;
+
+auto serviceWorkerPage = downcast(m_globalScope).serviceWorkerPage();
+if (!serviceWorkerPage)
+return;
+
+ASSERT(isMainThread());
+
+// When a service worker is loaded in a Page, we need to report its inspector frontend count
+// up to the page's inspectorController so the client knows about it.
+auto inspectorClient = serviceWorkerPage->inspectorController().inspectorClient();
+if (!inspectorClient)
+return;
+
+inspectorClient->frontendCountChanged(m_frontendRouter->frontendCount());
+}
+#endif
+
 void WorkerInspectorController::dispatchMessageFromFrontend(const String& message)
 {
 m_backendDispatcher->dispatch(message);


Modified: trunk/Source/WebCore/inspector/WorkerInspectorController.h (285770 => 285771)

--- trunk/Source/WebCore/inspector/WorkerInspectorController.h	2021-11-13 02:26:18 UTC (rev 285770)
+++ trunk/Source/WebCore/inspector/WorkerInspectorController.h	2021-11-13 03:22:14 UTC (rev 285771)
@@ -74,6 +74,10 @@
 WorkerAgentContext workerAgentContext();
 void createLazyAgents();
 
+#if ENABLE(SERVICE_WORKER)
+void updateServiceWorkerPageFrontendCount();
+#endif
+
 Ref m_instrumentingAgents;
 std::unique_ptr m_injectedScriptManager;
 Ref m_frontendRouter;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285769] trunk

[said]

Title: [285769] trunk








Revision 285769
Author s...@apple.com
Date 2021-11-12 18:12:05 -0800 (Fri, 12 Nov 2021)


Log Message
REGRESSION(r285481): Infinite recursion with cyclic filter reference
https://bugs.webkit.org/show_bug.cgi?id=232972
rdar://85264240

Reviewed by Wenson Hsieh.

Source/WebCore:

Before r285481, we were creating the ImageBuffer of the referenced SVGElement
for the FEImage through RenderSVGResourceFilter::postApplyResource(). Now
we create this ImageBuffer through RenderSVGResourceFilter::applyResource().
The difference is at the end of RenderSVGResourceFilter::applyResource()
we add an entry to m_rendererFilterDataMap. This entry was preventing
trying to rebuild the SVGFilter for the same renderer if there is a
cyclic reference.

The fix is to add the entry in m_rendererFilterDataMap before creating the
SVGFilter. If an error happens, this entry will be removed before returning.

Test: svg/filters/feImage-cyclic-reference.svg

* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

* svg/filters/feImage-cyclic-reference-expected.txt: Added.
* svg/filters/feImage-cyclic-reference.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp


Added Paths

trunk/LayoutTests/svg/filters/feImage-cyclic-reference-expected.txt
trunk/LayoutTests/svg/filters/feImage-cyclic-reference.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (285768 => 285769)

--- trunk/LayoutTests/ChangeLog	2021-11-13 01:23:27 UTC (rev 285768)
+++ trunk/LayoutTests/ChangeLog	2021-11-13 02:12:05 UTC (rev 285769)
@@ -1,3 +1,14 @@
+2021-11-12  Said Abou-Hallawa  
+
+REGRESSION(r285481): Infinite recursion with cyclic filter reference
+https://bugs.webkit.org/show_bug.cgi?id=232972
+rdar://85264240
+
+Reviewed by Wenson Hsieh.
+
+* svg/filters/feImage-cyclic-reference-expected.txt: Added.
+* svg/filters/feImage-cyclic-reference.svg: Added.
+
 2021-11-12  Rob Buis  
 
 Null check m_spanElement


Added: trunk/LayoutTests/svg/filters/feImage-cyclic-reference-expected.txt (0 => 285769)

--- trunk/LayoutTests/svg/filters/feImage-cyclic-reference-expected.txt	(rev 0)
+++ trunk/LayoutTests/svg/filters/feImage-cyclic-reference-expected.txt	2021-11-13 02:12:05 UTC (rev 285769)
@@ -0,0 +1 @@
+This test passes if it does not crash.


Added: trunk/LayoutTests/svg/filters/feImage-cyclic-reference.svg (0 => 285769)

--- trunk/LayoutTests/svg/filters/feImage-cyclic-reference.svg	(rev 0)
+++ trunk/LayoutTests/svg/filters/feImage-cyclic-reference.svg	2021-11-13 02:12:05 UTC (rev 285769)
@@ -0,0 +1,11 @@
+
+
+
+
+This test passes if it does not crash.
+
+if (window.testRunner)
+testRunner.dumpAsText(true);
+
+


Modified: trunk/Source/WebCore/ChangeLog (285768 => 285769)

--- trunk/Source/WebCore/ChangeLog	2021-11-13 01:23:27 UTC (rev 285768)
+++ trunk/Source/WebCore/ChangeLog	2021-11-13 02:12:05 UTC (rev 285769)
@@ -1,3 +1,27 @@
+2021-11-12  Said Abou-Hallawa  
+
+REGRESSION(r285481): Infinite recursion with cyclic filter reference
+https://bugs.webkit.org/show_bug.cgi?id=232972
+rdar://85264240
+
+Reviewed by Wenson Hsieh.
+
+Before r285481, we were creating the ImageBuffer of the referenced SVGElement
+for the FEImage through RenderSVGResourceFilter::postApplyResource(). Now
+we create this ImageBuffer through RenderSVGResourceFilter::applyResource(). 
+The difference is at the end of RenderSVGResourceFilter::applyResource()
+we add an entry to m_rendererFilterDataMap. This entry was preventing 
+trying to rebuild the SVGFilter for the same renderer if there is a
+cyclic reference.
+
+The fix is to add the entry in m_rendererFilterDataMap before creating the
+SVGFilter. If an error happens, this entry will be removed before returning.
+
+Test: svg/filters/feImage-cyclic-reference.svg
+
+* rendering/svg/RenderSVGResourceFilter.cpp:
+(WebCore::RenderSVGResourceFilter::applyResource):
+
 2021-11-12  Rob Buis  
 
 Null check m_spanElement


Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp (285768 => 285769)

--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp	2021-11-13 01:23:27 UTC (rev 285768)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp	2021-11-13 02:12:05 UTC (rev 285769)
@@ -96,17 +96,23 @@
 return false; // Already built, or we're in a cycle, or we're marked for removal. Regardless, just do nothing more now.
 }
 
-auto filterData = makeUnique();
+auto addResult = m_rendererFilterDataMap.set(, makeUnique());
+auto filterData = addResult.iterator->value.get();
+
 FloatRect targetBoundingBox = 

[webkit-changes] [285768] tags/Safari-612.3.6.1.1/

[repstein]

Title: [285768] tags/Safari-612.3.6.1.1/








Revision 285768
Author repst...@apple.com
Date 2021-11-12 17:23:27 -0800 (Fri, 12 Nov 2021)


Log Message
Tag Safari-612.3.6.1.1.

Added Paths

tags/Safari-612.3.6.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285767] tags/Safari-612.3.6.1.1/

[repstein]

Title: [285767] tags/Safari-612.3.6.1.1/








Revision 285767
Author repst...@apple.com
Date 2021-11-12 17:22:34 -0800 (Fri, 12 Nov 2021)


Log Message
Delete tag.

Removed Paths

tags/Safari-612.3.6.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285766] branches/safari-612.3.6.1-branch/Source/WebKit/NetworkProcess/ cocoa/NetworkSessionCocoa.h

[repstein]

Title: [285766] branches/safari-612.3.6.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h








Revision 285766
Author repst...@apple.com
Date 2021-11-12 17:18:54 -0800 (Fri, 12 Nov 2021)


Log Message
Unreviewed build fix. rdar://problem/83159358

error: out-of-line definition of 'isolatedSession' does not match any declaration in 'WebKit::SessionSet'

Modified Paths

branches/safari-612.3.6.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h




Diff

Modified: branches/safari-612.3.6.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h (285765 => 285766)

--- branches/safari-612.3.6.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h	2021-11-13 01:16:24 UTC (rev 285765)
+++ branches/safari-612.3.6.1-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h	2021-11-13 01:18:54 UTC (rev 285766)
@@ -82,7 +82,7 @@
 SessionWrapper& initializeEphemeralStatelessSessionIfNeeded(NavigatingToAppBoundDomain, NetworkSessionCocoa&);
 
 #if !HAVE(CFNETWORK_SESSION_PARTITIONING_BASED_ON_FIRST_PARTY_DOMAIN)
-SessionWrapper& isolatedSession(WebCore::StoredCredentialsPolicy, const WebCore::RegistrableDomain&, NavigatingToAppBoundDomain, NetworkSessionCocoa&);
+SessionWrapper& isolatedSession(WebCore::StoredCredentialsPolicy, const WebCore::RegistrableDomain, NavigatingToAppBoundDomain, NetworkSessionCocoa&); 
 HashMap> isolatedSessions;
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285765] trunk/Tools

[jbedard]

Title: [285765] trunk/Tools








Revision 285765
Author jbed...@apple.com
Date 2021-11-12 17:16:24 -0800 (Fri, 12 Nov 2021)


Log Message
[git-webkit] Checkout pull-requests
https://bugs.webkit.org/show_bug.cgi?id=233042


Reviewed by Dewei Zhu.

In GitHub, pull-requests are somewhat difficult to checkout because they're
attached to a specific user's mirror of WebKit. Automate this process.

* Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Scripts/libraries/webkitscmpy/webkitscmpy/__init.py__: Ditto.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git): Add username:branch regex.
(Git.checkout): Allow checking out of branches by username:branch.
* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
(Git.__init__): Add `git checkout -B`.
(Git.checkout): `-B` will force checkout a branch, even if one already exists.
* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
(GitHub): Embed error message in 404 response.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py:
(Checkout.main): Allow direct checkout of pull-request instead of relying
exclusively on branches.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py:
(Clean.main): Add newline.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:
(TestCheckout.test_no_pr_github):
(TestCheckout.test_no_pr_bitbucket):
(TestCheckout.test_pr_github):
(TestCheckout.test_pr_bitbucket):

Canonical link: https://commits.webkit.org/244211@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (285764 => 285765)

--- trunk/Tools/ChangeLog	2021-11-13 01:16:04 UTC (rev 285764)
+++ trunk/Tools/ChangeLog	2021-11-13 01:16:24 UTC (rev 285765)
@@ -1,3 +1,35 @@
+2021-11-12  Jonathan Bedard  
+
+[git-webkit] Checkout pull-requests
+https://bugs.webkit.org/show_bug.cgi?id=233042
+
+
+Reviewed by Dewei Zhu.
+
+In GitHub, pull-requests are somewhat difficult to checkout because they're
+attached to a specific user's mirror of WebKit. Automate this process.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init.py__: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
+(Git): Add username:branch regex.
+(Git.checkout): Allow checking out of branches by username:branch.
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
+(Git.__init__): Add `git checkout -B`.
+(Git.checkout): `-B` will force checkout a branch, even if one already exists.
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
+(GitHub): Embed error message in 404 response.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py:
+(Checkout.main): Allow direct checkout of pull-request instead of relying
+exclusively on branches.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py:
+(Clean.main): Add newline.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:
+(TestCheckout.test_no_pr_github):
+(TestCheckout.test_no_pr_bitbucket):
+(TestCheckout.test_pr_github):
+(TestCheckout.test_pr_bitbucket):
+
 2021-11-12  Sihui Liu  
 
 Set default general storage directory to websiteDataDirectory


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (285764 => 285765)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-11-13 01:16:04 UTC (rev 285764)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2021-11-13 01:16:24 UTC (rev 285765)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='3.0.0',
+version='3.0.1',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (285764 => 285765)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-11-13 01:16:04 UTC (rev 285764)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2021-11-13 01:16:24 UTC (rev 285765)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(3, 0, 0)
+version = Version(3, 0, 1)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 

[webkit-changes] [285764] trunk

[commit-queue]

Title: [285764] trunk








Revision 285764
Author commit-qu...@webkit.org
Date 2021-11-12 17:16:04 -0800 (Fri, 12 Nov 2021)


Log Message
Null check m_spanElement
https://bugs.webkit.org/show_bug.cgi?id=230894

Patch by Rob Buis  on 2021-11-12
Reviewed by Wenson Hsieh.

Source/WebCore:

Null check m_spanElement in ReplaceNodeWithSpanCommand::doUnapply, since
it may not be created by ReplaceNodeWithSpanCommand::doApply.

Test: editing/execCommand/default-paragraph-separator-crash.html

* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::ReplaceNodeWithSpanCommand::doUnapply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):

LayoutTests:

* editing/execCommand/default-paragraph-separator-crash-expected.txt: Added.
* editing/execCommand/default-paragraph-separator-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp


Added Paths

trunk/LayoutTests/editing/execCommand/default-paragraph-separator-crash-expected.txt
trunk/LayoutTests/editing/execCommand/default-paragraph-separator-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285763 => 285764)

--- trunk/LayoutTests/ChangeLog	2021-11-13 00:55:20 UTC (rev 285763)
+++ trunk/LayoutTests/ChangeLog	2021-11-13 01:16:04 UTC (rev 285764)
@@ -1,3 +1,13 @@
+2021-11-12  Rob Buis  
+
+Null check m_spanElement
+https://bugs.webkit.org/show_bug.cgi?id=230894
+
+Reviewed by Wenson Hsieh.
+
+* editing/execCommand/default-paragraph-separator-crash-expected.txt: Added.
+* editing/execCommand/default-paragraph-separator-crash.html: Added.
+
 2021-11-12  Chris Dumez  
 
 Crash when accessing reason property of a newly created AbortSignal


Added: trunk/LayoutTests/editing/execCommand/default-paragraph-separator-crash-expected.txt (0 => 285764)

--- trunk/LayoutTests/editing/execCommand/default-paragraph-separator-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/execCommand/default-paragraph-separator-crash-expected.txt	2021-11-13 01:16:04 UTC (rev 285764)
@@ -0,0 +1 @@
+Test passes if it does not crash.


Added: trunk/LayoutTests/editing/execCommand/default-paragraph-separator-crash.html (0 => 285764)

--- trunk/LayoutTests/editing/execCommand/default-paragraph-separator-crash.html	(rev 0)
+++ trunk/LayoutTests/editing/execCommand/default-paragraph-separator-crash.html	2021-11-13 01:16:04 UTC (rev 285764)
@@ -0,0 +1,20 @@
+
+if (window.testRunner)
+   window.testRunner.dumpAsText();
+_onload_ = () => {
+let output0 = document.createElement('output');
+document.body.appendChild(output0);
+let h1 = document.createElement('h1');
+output0.appendChild(h1);
+let table0 = document.createElement('table');
+h1.appendChild(table0);
+table0.appendChild(document.createElement('h1'));
+output0.appendChild(document.createElement('div'));
+document.designMode = 'on';
+document.execCommand('SelectAll');
+document.execCommand('DefaultParagraphSeparator', false, 'p');
+document.execCommand('JustifyRight');
+document.execCommand('Undo');
+document.write("Test passes if it does not crash.");
+};
+


Modified: trunk/Source/WebCore/ChangeLog (285763 => 285764)

--- trunk/Source/WebCore/ChangeLog	2021-11-13 00:55:20 UTC (rev 285763)
+++ trunk/Source/WebCore/ChangeLog	2021-11-13 01:16:04 UTC (rev 285764)
@@ -1,3 +1,20 @@
+2021-11-12  Rob Buis  
+
+Null check m_spanElement
+https://bugs.webkit.org/show_bug.cgi?id=230894
+
+Reviewed by Wenson Hsieh.
+
+Null check m_spanElement in ReplaceNodeWithSpanCommand::doUnapply, since
+it may not be created by ReplaceNodeWithSpanCommand::doApply.
+
+Test: editing/execCommand/default-paragraph-separator-crash.html
+
+* editing/ReplaceNodeWithSpanCommand.cpp:
+(WebCore::ReplaceNodeWithSpanCommand::doUnapply):
+* editing/ReplaceSelectionCommand.cpp:
+(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
+
 2021-11-12  Chris Dumez  
 
 Crash when accessing reason property of a newly created AbortSignal


Modified: trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (285763 => 285764)

--- trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp	2021-11-13 00:55:20 UTC (rev 285763)
+++ trunk/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp	2021-11-13 01:16:04 UTC (rev 285764)
@@ -68,7 +68,7 @@
 
 void ReplaceNodeWithSpanCommand::doUnapply()
 {
-if (!m_spanElement->isConnected())
+if (!m_spanElement || !m_spanElement->isConnected())
 return;
 swapInNodePreservingAttributesAndChildren(m_elementToReplace, *m_spanElement);
 }


Modified: 

[webkit-changes] [285763] trunk/Source/WebKit

[commit-queue]

Title: [285763] trunk/Source/WebKit








Revision 285763
Author commit-qu...@webkit.org
Date 2021-11-12 16:55:20 -0800 (Fri, 12 Nov 2021)


Log Message
_WKWebAuthenticationPanel should expose a way to encode CTAP commands
https://bugs.webkit.org/show_bug.cgi?id=232977


Patch by Garrett Davidson  on 2021-11-12
Reviewed by David Kilzer.

Expose the existing CTAP command encoding through _WKWebAuthenticationPanel.

Covered by existing tests.

* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(coreUserVerificationAvailability):
(+[_WKWebAuthenticationPanel getClientDataJSONForAuthenticationType:challenge:origin:])
(+[_WKWebAuthenticationPanel encodeMakeCredentialCommandWithClientDataJSON:options:userVerificationAvailability:]):
(+[_WKWebAuthenticationPanel encodeGetAssertionCommandWithClientDataJSON:options:userVerificationAvailability:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (285762 => 285763)

--- trunk/Source/WebKit/ChangeLog	2021-11-13 00:11:43 UTC (rev 285762)
+++ trunk/Source/WebKit/ChangeLog	2021-11-13 00:55:20 UTC (rev 285763)
@@ -1,3 +1,22 @@
+2021-11-12  Garrett Davidson  
+
+_WKWebAuthenticationPanel should expose a way to encode CTAP commands
+https://bugs.webkit.org/show_bug.cgi?id=232977
+
+
+Reviewed by David Kilzer.
+
+Expose the existing CTAP command encoding through _WKWebAuthenticationPanel.
+
+Covered by existing tests.
+
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
+(coreUserVerificationAvailability):
+(+[_WKWebAuthenticationPanel getClientDataJSONForAuthenticationType:challenge:origin:])
+(+[_WKWebAuthenticationPanel encodeMakeCredentialCommandWithClientDataJSON:options:userVerificationAvailability:]):
+(+[_WKWebAuthenticationPanel encodeGetAssertionCommandWithClientDataJSON:options:userVerificationAvailability:]):
+
 2021-11-12  Per Arne Vollan 
 
 [iOS][GPUP] Allow access to syscalls


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h (285762 => 285763)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h	2021-11-13 00:11:43 UTC (rev 285762)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h	2021-11-13 00:55:20 UTC (rev 285763)
@@ -80,6 +80,12 @@
 _WKWebAuthenticationSourceExternal,
 } WK_API_AVAILABLE(macos(11.0), ios(14.0));
 
+typedef NS_ENUM(NSInteger, _WKWebAuthenticationUserVerificationAvailability) {
+_WKWebAuthenticationUserVerificationAvailabilitySupportedAndConfigured,
+_WKWebAuthenticationUserVerificationAvailabilitySupportedButNotConfigured,
+_WKWebAuthenticationUserVerificationAvailabilityNotSupported,
+} WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+
 WK_EXPORT extern NSString * const _WKLocalAuthenticatorCredentialNameKey;
 WK_EXPORT extern NSString * const _WKLocalAuthenticatorCredentialIDKey;
 WK_EXPORT extern NSString * const _WKLocalAuthenticatorCredentialRelyingPartyIDKey;
@@ -112,6 +118,10 @@
 
 + (BOOL)isUserVerifyingPlatformAuthenticatorAvailable WK_API_AVAILABLE(macos(12.0), ios(15.0));
 
++ (NSData *)getClientDataJSONForAuthenticationType:(_WKWebAuthenticationType)type challenge:(NSData *)challenge origin:(NSString *)origin WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
++ (NSData *)encodeMakeCredentialCommandWithClientDataJSON:(NSData *)clientDataJSON options:(_WKPublicKeyCredentialCreationOptions *)options userVerificationAvailability:(_WKWebAuthenticationUserVerificationAvailability)userVerificationAvailability WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
++ (NSData *)encodeGetAssertionCommandWithClientDataJSON:(NSData *)clientDataJSON options:(_WKPublicKeyCredentialRequestOptions *)options userVerificationAvailability:(_WKWebAuthenticationUserVerificationAvailability)userVerificationAvailability WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+
 - (instancetype)init;
 
 // FIXME:  Adds detailed NSError.


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm (285762 => 285763)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm	2021-11-13 00:11:43 UTC (rev 285762)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm	2021-11-13 00:55:20 UTC (rev 285763)
@@ -48,6 +48,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -194,6 +195,21 @@
 }
 }
 
+static fido::AuthenticatorSupportedOptions::UserVerificationAvailability coreUserVerificationAvailability(_WKWebAuthenticationUserVerificationAvailability wkAvailability)
+{
+switch (wkAvailability) {
+case _WKWebAuthenticationUserVerificationAvailabilitySupportedAndConfigured:
+

[webkit-changes] [285762] tags/Safari-612.3.6.2.1/

[repstein]

Title: [285762] tags/Safari-612.3.6.2.1/








Revision 285762
Author repst...@apple.com
Date 2021-11-12 16:11:43 -0800 (Fri, 12 Nov 2021)


Log Message
Tag Safari-612.3.6.2.1.

Added Paths

tags/Safari-612.3.6.2.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285761] tags/Safari-612.3.6.0.1/

[repstein]

Title: [285761] tags/Safari-612.3.6.0.1/








Revision 285761
Author repst...@apple.com
Date 2021-11-12 16:08:49 -0800 (Fri, 12 Nov 2021)


Log Message
Tag Safari-612.3.6.0.1.

Added Paths

tags/Safari-612.3.6.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285759] tags/Safari-612.3.6.1.1/

[repstein]

Title: [285759] tags/Safari-612.3.6.1.1/








Revision 285759
Author repst...@apple.com
Date 2021-11-12 16:07:32 -0800 (Fri, 12 Nov 2021)


Log Message
Tag Safari-612.3.6.1.1.

Added Paths

tags/Safari-612.3.6.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285758] trunk/JSTests

[guijemont]

Title: [285758] trunk/JSTests








Revision 285758
Author guijem...@igalia.com
Date 2021-11-12 16:01:00 -0800 (Fri, 12 Nov 2021)


Log Message
Unskip typeProfiler/getter-richards.js on armv7
https://bugs.webkit.org/show_bug.cgi?id=233050

Unreviewed gardening.

Our arm bots are now fast enough to run this, it does still timeout on
some of our test mips devices though.


* typeProfiler/getter-richards.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/typeProfiler/getter-richards.js




Diff

Modified: trunk/JSTests/ChangeLog (285757 => 285758)

--- trunk/JSTests/ChangeLog	2021-11-12 23:56:07 UTC (rev 285757)
+++ trunk/JSTests/ChangeLog	2021-11-13 00:01:00 UTC (rev 285758)
@@ -1,3 +1,15 @@
+2021-11-12  Guillaume Emont  
+
+Unskip typeProfiler/getter-richards.js on armv7
+https://bugs.webkit.org/show_bug.cgi?id=233050
+
+Unreviewed gardening.
+
+Our arm bots are now fast enough to run this, it does still timeout on
+some of our test mips devices though.
+
+* typeProfiler/getter-richards.js:
+
 2021-11-12  Xan Lopez  
 
 [JSC][32bit] Unskip JSTests/microbenchmarks/redefine-property-accessor-dictionary.js


Modified: trunk/JSTests/typeProfiler/getter-richards.js (285757 => 285758)

--- trunk/JSTests/typeProfiler/getter-richards.js	2021-11-12 23:56:07 UTC (rev 285757)
+++ trunk/JSTests/typeProfiler/getter-richards.js	2021-11-13 00:01:00 UTC (rev 285758)
@@ -1,4 +1,4 @@
-//@ if $buildType == "debug" or not $jitTests or $architecture =~ /(^arm$)|mips/ then skip else runTypeProfiler end
+//@ if $buildType == "debug" or not $jitTests or $architecture == "mips" then skip else runTypeProfiler end
 
 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Copyright 2014 Apple Inc.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285757] tags/Safari-613.1.7.4/

[bshafiei]

Title: [285757] tags/Safari-613.1.7.4/








Revision 285757
Author bshaf...@apple.com
Date 2021-11-12 15:56:07 -0800 (Fri, 12 Nov 2021)


Log Message
Tag Safari-613.1.7.4.

Added Paths

tags/Safari-613.1.7.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285754] branches/safari-612.3.6.1-branch/Source/WebCore

[repstein]

Title: [285754] branches/safari-612.3.6.1-branch/Source/WebCore








Revision 285754
Author repst...@apple.com
Date 2021-11-12 15:54:32 -0800 (Fri, 12 Nov 2021)


Log Message
Revert r285680. rdar://problem/85004449

Modified Paths

branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog
branches/safari-612.3.6.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
branches/safari-612.3.6.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog (285753 => 285754)

--- branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog	2021-11-12 23:54:15 UTC (rev 285753)
+++ branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog	2021-11-12 23:54:32 UTC (rev 285754)
@@ -1,3 +1,7 @@
+2021-11-12  Russell Epstein  
+
+Revert r285680. rdar://problem/85004449
+
 2021-11-11  Alan Coon  
 
 Cherry-pick r285531. rdar://problem/83381842


Modified: branches/safari-612.3.6.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h (285753 => 285754)

--- branches/safari-612.3.6.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h	2021-11-12 23:54:15 UTC (rev 285753)
+++ branches/safari-612.3.6.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h	2021-11-12 23:54:32 UTC (rev 285754)
@@ -419,7 +419,6 @@
 mutable long long m_cachedTotalBytes { 0 };
 unsigned m_pendingStatusChanges { 0 };
 int m_cachedItemStatus;
-int m_runLoopNestingLevel { 0 };
 MediaPlayer::BufferingPolicy m_bufferingPolicy { MediaPlayer::BufferingPolicy::Default };
 bool m_cachedLikelyToKeepUp { false };
 bool m_cachedBufferEmpty { false };
@@ -439,6 +438,7 @@
 mutable bool m_allowsWirelessVideoPlayback { true };
 bool m_shouldPlayToPlaybackTarget { false };
 #endif
+bool m_runningModalPaint { false };
 bool m_waitForVideoOutputMediaDataWillChangeTimedOut { false };
 bool m_haveBeenAskedToPaint { false };
 };


Modified: branches/safari-612.3.6.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (285753 => 285754)

--- branches/safari-612.3.6.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2021-11-12 23:54:15 UTC (rev 285753)
+++ branches/safari-612.3.6.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2021-11-12 23:54:32 UTC (rev 285754)
@@ -2563,31 +2563,21 @@
 {
 if (m_waitForVideoOutputMediaDataWillChangeTimedOut)
 return;
+[m_videoOutput requestNotificationOfMediaDataChangeWithAdvanceInterval:0];
 
 // Wait for 1 second.
 MonotonicTime start = MonotonicTime::now();
 
-std::optional> timeoutTimer;
+RunLoop::Timer timeoutTimer { RunLoop::main(), [] {
+RunLoop::main().stop();
+} };
+timeoutTimer.startOneShot(1_s);
 
-if (!m_runLoopNestingLevel) {
-[m_videoOutput requestNotificationOfMediaDataChangeWithAdvanceInterval:0];
-
-timeoutTimer.emplace(RunLoop::main(), [&] {
-RunLoop::main().stop();
-});
-timeoutTimer->startOneShot(1_s);
-}
-
-++m_runLoopNestingLevel;
+m_runningModalPaint = true;
 RunLoop::run();
---m_runLoopNestingLevel;
+m_runningModalPaint = false;
 
-if (m_runLoopNestingLevel) {
-RunLoop::main().stop();
-return;
-}
-
-bool satisfied = timeoutTimer->isActive();
+bool satisfied = timeoutTimer.isActive();
 if (!satisfied) {
 ERROR_LOG(LOGIDENTIFIER, "timed out");
 m_waitForVideoOutputMediaDataWillChangeTimedOut = true;
@@ -2597,7 +2587,7 @@
 
 void MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange()
 {
-if (m_runLoopNestingLevel)
+if (m_runningModalPaint)
 RunLoop::main().stop();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285755] branches/safari-612.3.6.1-branch/Source/WebCore

[repstein]

Title: [285755] branches/safari-612.3.6.1-branch/Source/WebCore








Revision 285755
Author repst...@apple.com
Date 2021-11-12 15:54:35 -0800 (Fri, 12 Nov 2021)


Log Message
Revert r285691. rdar://problem/83381842

Modified Paths

branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog
branches/safari-612.3.6.1-branch/Source/WebCore/Modules/speech/cocoa/SpeechRecognizerCocoa.mm




Diff

Modified: branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog (285754 => 285755)

--- branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog	2021-11-12 23:54:32 UTC (rev 285754)
+++ branches/safari-612.3.6.1-branch/Source/WebCore/ChangeLog	2021-11-12 23:54:35 UTC (rev 285755)
@@ -1,5 +1,9 @@
 2021-11-12  Russell Epstein  
 
+Revert r285691. rdar://problem/83381842
+
+2021-11-12  Russell Epstein  
+
 Revert r285680. rdar://problem/85004449
 
 2021-11-11  Alan Coon  


Modified: branches/safari-612.3.6.1-branch/Source/WebCore/Modules/speech/cocoa/SpeechRecognizerCocoa.mm (285754 => 285755)

--- branches/safari-612.3.6.1-branch/Source/WebCore/Modules/speech/cocoa/SpeechRecognizerCocoa.mm	2021-11-12 23:54:32 UTC (rev 285754)
+++ branches/safari-612.3.6.1-branch/Source/WebCore/Modules/speech/cocoa/SpeechRecognizerCocoa.mm	2021-11-12 23:54:35 UTC (rev 285755)
@@ -28,7 +28,6 @@
 
 #if HAVE(SPEECHRECOGNIZER)
 
-#import "AudioStreamDescription.h"
 #import "MediaUtilities.h"
 #import "SpeechRecognitionUpdate.h"
 #import "WebSpeechRecognizerTaskMock.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285756] branches/safari-612.3.6.1-branch/Source/WebKit

[repstein]

Title: [285756] branches/safari-612.3.6.1-branch/Source/WebKit








Revision 285756
Author repst...@apple.com
Date 2021-11-12 15:54:38 -0800 (Fri, 12 Nov 2021)


Log Message
Revert r285690. rdar://problem/83381842

Modified Paths

branches/safari-612.3.6.1-branch/Source/WebKit/ChangeLog
branches/safari-612.3.6.1-branch/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp
branches/safari-612.3.6.1-branch/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp




Diff

Modified: branches/safari-612.3.6.1-branch/Source/WebKit/ChangeLog (285755 => 285756)

--- branches/safari-612.3.6.1-branch/Source/WebKit/ChangeLog	2021-11-12 23:54:35 UTC (rev 285755)
+++ branches/safari-612.3.6.1-branch/Source/WebKit/ChangeLog	2021-11-12 23:54:38 UTC (rev 285756)
@@ -1,3 +1,7 @@
+2021-11-12  Russell Epstein  
+
+Revert r285690. rdar://problem/83381842
+
 2021-11-11  Alan Coon  
 
 Cherry-pick r285565. rdar://problem/83159358


Modified: branches/safari-612.3.6.1-branch/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp (285755 => 285756)

--- branches/safari-612.3.6.1-branch/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp	2021-11-12 23:54:35 UTC (rev 285755)
+++ branches/safari-612.3.6.1-branch/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp	2021-11-12 23:54:38 UTC (rev 285756)
@@ -77,13 +77,8 @@
 
 void SpeechRecognitionRemoteRealtimeMediaSource::setStorage(const SharedMemory::Handle& handle, const WebCore::CAAudioStreamDescription& description, uint64_t numberOfFrames)
 {
-if (!numberOfFrames) {
-m_ringBuffer = nullptr;
-m_buffer = nullptr;
-return;
-}
+m_description = description;
 
-m_description = description;
 m_ringBuffer = WebCore::CARingBuffer::adoptStorage(makeUniqueRef(handle), description, numberOfFrames).moveToUniquePtr();
 m_buffer = makeUnique(description);
 }


Modified: branches/safari-612.3.6.1-branch/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp (285755 => 285756)

--- branches/safari-612.3.6.1-branch/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp	2021-11-12 23:54:35 UTC (rev 285755)
+++ branches/safari-612.3.6.1-branch/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp	2021-11-12 23:54:38 UTC (rev 285756)
@@ -63,7 +63,7 @@
 , m_source(WTFMove(source))
 , m_connection(WTFMove(connection))
 #if PLATFORM(COCOA)
-, m_ringBuffer(makeUniqueRef(std::bind(::storageChanged, this, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3)))
+, m_ringBuffer(makeUniqueRef(std::bind(::storageChanged, this, std::placeholders::_1)))
 #endif
 {
 m_source->addObserver(*this);
@@ -113,7 +113,9 @@
 if (m_description != description) {
 ASSERT(description.platformDescription().type == PlatformDescription::CAAudioStreamBasicType);
 m_description = *WTF::get(description.platformDescription().description);
-m_ringBuffer.allocate(m_description.streamDescription(), m_description.sampleRate() * 2);
+
+m_numberOfFrames = m_description.sampleRate() * 2;
+m_ringBuffer.allocate(m_description.streamDescription(), m_numberOfFrames);
 }
 
 ASSERT(is(audioData));
@@ -129,7 +131,7 @@
 
 #if PLATFORM(COCOA)
 
-void storageChanged(SharedMemory* storage, const WebCore::CAAudioStreamDescription& description, size_t numberOfFrames)
+void storageChanged(SharedMemory* storage)
 {
 DisableMallocRestrictionsForCurrentThreadScope scope;
 SharedMemory::Handle handle;
@@ -140,7 +142,7 @@
 #else
 uint64_t dataSize = 0;
 #endif
-m_connection->send(Messages::SpeechRecognitionRemoteRealtimeMediaSourceManager::SetStorage(m_identifier, SharedMemory::IPCHandle { WTFMove(handle),  dataSize }, description, numberOfFrames), 0);
+m_connection->send(Messages::SpeechRecognitionRemoteRealtimeMediaSourceManager::SetStorage(m_identifier, SharedMemory::IPCHandle { WTFMove(handle),  dataSize }, m_description, m_numberOfFrames), 0);
 }
 
 #endif
@@ -160,6 +162,7 @@
 Ref m_connection;
 
 #if PLATFORM(COCOA)
+uint64_t m_numberOfFrames { 0 };
 CARingBuffer m_ringBuffer;
 CAAudioStreamDescription m_description { };
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285753] branches/safari-612.3.6.0-branch/Source/WebKit

[repstein]

Title: [285753] branches/safari-612.3.6.0-branch/Source/WebKit








Revision 285753
Author repst...@apple.com
Date 2021-11-12 15:54:15 -0800 (Fri, 12 Nov 2021)


Log Message
Revert r285683. rdar://problem/83381842

Modified Paths

branches/safari-612.3.6.0-branch/Source/WebKit/ChangeLog
branches/safari-612.3.6.0-branch/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp
branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp




Diff

Modified: branches/safari-612.3.6.0-branch/Source/WebKit/ChangeLog (285752 => 285753)

--- branches/safari-612.3.6.0-branch/Source/WebKit/ChangeLog	2021-11-12 23:54:12 UTC (rev 285752)
+++ branches/safari-612.3.6.0-branch/Source/WebKit/ChangeLog	2021-11-12 23:54:15 UTC (rev 285753)
@@ -1,3 +1,7 @@
+2021-11-12  Babak Shafiei  
+
+Revert r285683. rdar://problem/83381842
+
 2021-11-11  Alan Coon  
 
 Apply patch. rdar://problem/83673859


Modified: branches/safari-612.3.6.0-branch/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp (285752 => 285753)

--- branches/safari-612.3.6.0-branch/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp	2021-11-12 23:54:12 UTC (rev 285752)
+++ branches/safari-612.3.6.0-branch/Source/WebKit/UIProcess/SpeechRecognitionRemoteRealtimeMediaSource.cpp	2021-11-12 23:54:15 UTC (rev 285753)
@@ -77,13 +77,8 @@
 
 void SpeechRecognitionRemoteRealtimeMediaSource::setStorage(const SharedMemory::Handle& handle, const WebCore::CAAudioStreamDescription& description, uint64_t numberOfFrames)
 {
-if (!numberOfFrames) {
-m_ringBuffer = nullptr;
-m_buffer = nullptr;
-return;
-}
+m_description = description;
 
-m_description = description;
 m_ringBuffer = WebCore::CARingBuffer::adoptStorage(makeUniqueRef(handle), description, numberOfFrames).moveToUniquePtr();
 m_buffer = makeUnique(description);
 }


Modified: branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp (285752 => 285753)

--- branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp	2021-11-12 23:54:12 UTC (rev 285752)
+++ branches/safari-612.3.6.0-branch/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp	2021-11-12 23:54:15 UTC (rev 285753)
@@ -63,7 +63,7 @@
 , m_source(WTFMove(source))
 , m_connection(WTFMove(connection))
 #if PLATFORM(COCOA)
-, m_ringBuffer(makeUniqueRef(std::bind(::storageChanged, this, std::placeholders::_1, std::placeholders::_2, std::placeholders::_3)))
+, m_ringBuffer(makeUniqueRef(std::bind(::storageChanged, this, std::placeholders::_1)))
 #endif
 {
 m_source->addObserver(*this);
@@ -113,7 +113,9 @@
 if (m_description != description) {
 ASSERT(description.platformDescription().type == PlatformDescription::CAAudioStreamBasicType);
 m_description = *WTF::get(description.platformDescription().description);
-m_ringBuffer.allocate(m_description.streamDescription(), m_description.sampleRate() * 2);
+
+m_numberOfFrames = m_description.sampleRate() * 2;
+m_ringBuffer.allocate(m_description.streamDescription(), m_numberOfFrames);
 }
 
 ASSERT(is(audioData));
@@ -129,7 +131,7 @@
 
 #if PLATFORM(COCOA)
 
-void storageChanged(SharedMemory* storage, const WebCore::CAAudioStreamDescription& description, size_t numberOfFrames)
+void storageChanged(SharedMemory* storage)
 {
 DisableMallocRestrictionsForCurrentThreadScope scope;
 SharedMemory::Handle handle;
@@ -140,7 +142,7 @@
 #else
 uint64_t dataSize = 0;
 #endif
-m_connection->send(Messages::SpeechRecognitionRemoteRealtimeMediaSourceManager::SetStorage(m_identifier, SharedMemory::IPCHandle { WTFMove(handle),  dataSize }, description, numberOfFrames), 0);
+m_connection->send(Messages::SpeechRecognitionRemoteRealtimeMediaSourceManager::SetStorage(m_identifier, SharedMemory::IPCHandle { WTFMove(handle),  dataSize }, m_description, m_numberOfFrames), 0);
 }
 
 #endif
@@ -160,6 +162,7 @@
 Ref m_connection;
 
 #if PLATFORM(COCOA)
+uint64_t m_numberOfFrames { 0 };
 CARingBuffer m_ringBuffer;
 CAAudioStreamDescription m_description { };
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285752] branches/safari-612.3.6.0-branch/Source/WebCore

[repstein]

Title: [285752] branches/safari-612.3.6.0-branch/Source/WebCore








Revision 285752
Author repst...@apple.com
Date 2021-11-12 15:54:12 -0800 (Fri, 12 Nov 2021)


Log Message
Revert r285684. rdar://problem/83381842

Modified Paths

branches/safari-612.3.6.0-branch/Source/WebCore/ChangeLog
branches/safari-612.3.6.0-branch/Source/WebCore/Modules/speech/cocoa/SpeechRecognizerCocoa.mm




Diff

Modified: branches/safari-612.3.6.0-branch/Source/WebCore/ChangeLog (285751 => 285752)

--- branches/safari-612.3.6.0-branch/Source/WebCore/ChangeLog	2021-11-12 23:54:09 UTC (rev 285751)
+++ branches/safari-612.3.6.0-branch/Source/WebCore/ChangeLog	2021-11-12 23:54:12 UTC (rev 285752)
@@ -1,5 +1,9 @@
 2021-11-12  Babak Shafiei  
 
+Revert r285684. rdar://problem/83381842
+
+2021-11-12  Babak Shafiei  
+
 Revert r285682. rdar://problem/85004449
 
 2021-11-11  Alan Coon  


Modified: branches/safari-612.3.6.0-branch/Source/WebCore/Modules/speech/cocoa/SpeechRecognizerCocoa.mm (285751 => 285752)

--- branches/safari-612.3.6.0-branch/Source/WebCore/Modules/speech/cocoa/SpeechRecognizerCocoa.mm	2021-11-12 23:54:09 UTC (rev 285751)
+++ branches/safari-612.3.6.0-branch/Source/WebCore/Modules/speech/cocoa/SpeechRecognizerCocoa.mm	2021-11-12 23:54:12 UTC (rev 285752)
@@ -28,7 +28,6 @@
 
 #if HAVE(SPEECHRECOGNIZER)
 
-#import "AudioStreamDescription.h"
 #import "MediaUtilities.h"
 #import "SpeechRecognitionUpdate.h"
 #import "WebSpeechRecognizerTaskMock.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285751] branches/safari-612.3.6.0-branch/Source/WebCore

[repstein]

Title: [285751] branches/safari-612.3.6.0-branch/Source/WebCore








Revision 285751
Author repst...@apple.com
Date 2021-11-12 15:54:09 -0800 (Fri, 12 Nov 2021)


Log Message
Revert r285682. rdar://problem/85004449

Modified Paths

branches/safari-612.3.6.0-branch/Source/WebCore/ChangeLog
branches/safari-612.3.6.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
branches/safari-612.3.6.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: branches/safari-612.3.6.0-branch/Source/WebCore/ChangeLog (285750 => 285751)

--- branches/safari-612.3.6.0-branch/Source/WebCore/ChangeLog	2021-11-12 23:48:51 UTC (rev 285750)
+++ branches/safari-612.3.6.0-branch/Source/WebCore/ChangeLog	2021-11-12 23:54:09 UTC (rev 285751)
@@ -1,3 +1,7 @@
+2021-11-12  Babak Shafiei  
+
+Revert r285682. rdar://problem/85004449
+
 2021-11-11  Alan Coon  
 
 Apply patch. rdar://problem/83673859


Modified: branches/safari-612.3.6.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h (285750 => 285751)

--- branches/safari-612.3.6.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h	2021-11-12 23:48:51 UTC (rev 285750)
+++ branches/safari-612.3.6.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h	2021-11-12 23:54:09 UTC (rev 285751)
@@ -419,7 +419,6 @@
 mutable long long m_cachedTotalBytes { 0 };
 unsigned m_pendingStatusChanges { 0 };
 int m_cachedItemStatus;
-int m_runLoopNestingLevel { 0 };
 MediaPlayer::BufferingPolicy m_bufferingPolicy { MediaPlayer::BufferingPolicy::Default };
 bool m_cachedLikelyToKeepUp { false };
 bool m_cachedBufferEmpty { false };
@@ -439,6 +438,7 @@
 mutable bool m_allowsWirelessVideoPlayback { true };
 bool m_shouldPlayToPlaybackTarget { false };
 #endif
+bool m_runningModalPaint { false };
 bool m_waitForVideoOutputMediaDataWillChangeTimedOut { false };
 bool m_haveBeenAskedToPaint { false };
 };


Modified: branches/safari-612.3.6.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (285750 => 285751)

--- branches/safari-612.3.6.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2021-11-12 23:48:51 UTC (rev 285750)
+++ branches/safari-612.3.6.0-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2021-11-12 23:54:09 UTC (rev 285751)
@@ -2563,31 +2563,21 @@
 {
 if (m_waitForVideoOutputMediaDataWillChangeTimedOut)
 return;
+[m_videoOutput requestNotificationOfMediaDataChangeWithAdvanceInterval:0];
 
 // Wait for 1 second.
 MonotonicTime start = MonotonicTime::now();
 
-std::optional> timeoutTimer;
+RunLoop::Timer timeoutTimer { RunLoop::main(), [] {
+RunLoop::main().stop();
+} };
+timeoutTimer.startOneShot(1_s);
 
-if (!m_runLoopNestingLevel) {
-[m_videoOutput requestNotificationOfMediaDataChangeWithAdvanceInterval:0];
-
-timeoutTimer.emplace(RunLoop::main(), [&] {
-RunLoop::main().stop();
-});
-timeoutTimer->startOneShot(1_s);
-}
-
-++m_runLoopNestingLevel;
+m_runningModalPaint = true;
 RunLoop::run();
---m_runLoopNestingLevel;
+m_runningModalPaint = false;
 
-if (m_runLoopNestingLevel) {
-RunLoop::main().stop();
-return;
-}
-
-bool satisfied = timeoutTimer->isActive();
+bool satisfied = timeoutTimer.isActive();
 if (!satisfied) {
 ERROR_LOG(LOGIDENTIFIER, "timed out");
 m_waitForVideoOutputMediaDataWillChangeTimedOut = true;
@@ -2597,7 +2587,7 @@
 
 void MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange()
 {
-if (m_runLoopNestingLevel)
+if (m_runningModalPaint)
 RunLoop::main().stop();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285750] branches/safari-613.1.7-branch/Source/WebCore/PAL

[bshafiei]

Title: [285750] branches/safari-613.1.7-branch/Source/WebCore/PAL








Revision 285750
Author bshaf...@apple.com
Date 2021-11-12 15:48:51 -0800 (Fri, 12 Nov 2021)


Log Message
Cherry-pick r285744. rdar://problem/85341122

Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Replace these static NSString definitions with soft-linked constants instead.

* pal/spi/cocoa/NSAttributedStringSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613.1.7-branch/Source/WebCore/PAL/ChangeLog
branches/safari-613.1.7-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h




Diff

Modified: branches/safari-613.1.7-branch/Source/WebCore/PAL/ChangeLog (285749 => 285750)

--- branches/safari-613.1.7-branch/Source/WebCore/PAL/ChangeLog	2021-11-12 23:47:33 UTC (rev 285749)
+++ branches/safari-613.1.7-branch/Source/WebCore/PAL/ChangeLog	2021-11-12 23:48:51 UTC (rev 285750)
@@ -1,3 +1,32 @@
+2021-11-12  Babak Shafiei  
+
+Cherry-pick r285744. rdar://problem/85341122
+
+Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
+https://bugs.webkit.org/show_bug.cgi?id=233064
+rdar://85341122
+
+Reviewed by Tim Horton.
+
+Replace these static NSString definitions with soft-linked constants instead.
+
+* pal/spi/cocoa/NSAttributedStringSPI.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-11-12  Wenson Hsieh  
+
+Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
+https://bugs.webkit.org/show_bug.cgi?id=233064
+rdar://85341122
+
+Reviewed by Tim Horton.
+
+Replace these static NSString definitions with soft-linked constants instead.
+
+* pal/spi/cocoa/NSAttributedStringSPI.h:
+
 2021-10-29  Alex Christensen  
 
 Unreviewed, reverting r284917.


Modified: branches/safari-613.1.7-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h (285749 => 285750)

--- branches/safari-613.1.7-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h	2021-11-12 23:47:33 UTC (rev 285749)
+++ branches/safari-613.1.7-branch/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h	2021-11-12 23:48:51 UTC (rev 285750)
@@ -95,6 +95,32 @@
 #define NSMarkedClauseSegmentAttributeName getNSMarkedClauseSegmentAttributeName()
 SOFT_LINK_CONSTANT(UIFoundation, NSTextAlternativesAttributeName, NSString *)
 #define NSTextAlternativesAttributeName getNSTextAlternativesAttributeName()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerCircle, NSString *)
+#define NSTextListMarkerCircle getNSTextListMarkerCircle()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerDisc, NSString *)
+#define NSTextListMarkerDisc getNSTextListMarkerDisc()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerSquare, NSString *)
+#define NSTextListMarkerSquare getNSTextListMarkerSquare()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseHexadecimal, NSString *)
+#define NSTextListMarkerLowercaseHexadecimal getNSTextListMarkerLowercaseHexadecimal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseHexadecimal, NSString *)
+#define NSTextListMarkerUppercaseHexadecimal getNSTextListMarkerUppercaseHexadecimal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerOctal, NSString *)
+#define NSTextListMarkerOctal getNSTextListMarkerOctal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseAlpha, NSString *)
+#define NSTextListMarkerLowercaseAlpha getNSTextListMarkerLowercaseAlpha()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseAlpha, NSString *)
+#define NSTextListMarkerUppercaseAlpha getNSTextListMarkerUppercaseAlpha()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseLatin, NSString *)
+#define NSTextListMarkerLowercaseLatin getNSTextListMarkerLowercaseLatin()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseLatin, NSString *)
+#define NSTextListMarkerUppercaseLatin getNSTextListMarkerUppercaseLatin()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseRoman, NSString *)
+#define NSTextListMarkerLowercaseRoman getNSTextListMarkerLowercaseRoman()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseRoman, NSString *)
+#define NSTextListMarkerUppercaseRoman getNSTextListMarkerUppercaseRoman()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerDecimal, NSString *)
+#define NSTextListMarkerDecimal getNSTextListMarkerDecimal()
 
 // We don't softlink NSSuperscriptAttributeName because UIFoundation stopped exporting it.
 // This attribute is being deprecated at the API level, but internally UIFoundation
@@ -111,18 +137,4 @@
 - (BOOL)containsAttachments;
 @end
 
-static NSString *const 

[webkit-changes] [285749] branches/safari-613.1.7-branch/Source

[bshafiei]

Title: [285749] branches/safari-613.1.7-branch/Source








Revision 285749
Author bshaf...@apple.com
Date 2021-11-12 15:47:33 -0800 (Fri, 12 Nov 2021)


Log Message
Versioning.

WebKit-7613.1.7.4

Modified Paths

branches/safari-613.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.7-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/WebCore/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/WebCore/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-613.1.7-branch/Source/WebKit/Configurations/Version.xcconfig (285748 => 285749)

--- branches/safari-613.1.7-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-12 23:45:58 UTC (rev 285748)
+++ branches/safari-613.1.7-branch/Source/WebKit/Configurations/Version.xcconfig	2021-11-12 23:47:33 UTC (rev 285749)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 7;
-MICRO_VERSION = 3;
+MICRO_VERSION = 4;
 NANO_VERSION = 0;
 FULL_VERSION = 

[webkit-changes] [285748] trunk/Source/WebKit

[pvollan]

Title: [285748] trunk/Source/WebKit








Revision 285748
Author pvol...@apple.com
Date 2021-11-12 15:45:58 -0800 (Fri, 12 Nov 2021)


Log Message
[iOS][GPUP] Allow access to syscalls
https://bugs.webkit.org/show_bug.cgi?id=232825


Reviewed by Brent Fulgham.

Based on telemetry, add access to unix syscalls in the GPU process on iOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (285747 => 285748)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 23:17:17 UTC (rev 285747)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 23:45:58 UTC (rev 285748)
@@ -1,3 +1,15 @@
+2021-11-12  Per Arne Vollan 
+
+[iOS][GPUP] Allow access to syscalls
+https://bugs.webkit.org/show_bug.cgi?id=232825
+
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, add access to unix syscalls in the GPU process on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
 2021-11-12  Sihui Liu  
 
 Set default general storage directory to websiteDataDirectory


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (285747 => 285748)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-12 23:17:17 UTC (rev 285747)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-12 23:45:58 UTC (rev 285748)
@@ -729,6 +729,7 @@
 SYS_getgid
 SYS_getpid
 SYS_getrlimit
+SYS_getrusage
 SYS_gettid
 SYS_gettimeofday
 SYS_getuid
@@ -779,6 +780,7 @@
 SYS_sigaction
 SYS_socket
 SYS_stat64
+SYS_statfs64
 SYS_sysctl
 SYS_sysctlbyname
 SYS_thread_selfid






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285747] trunk

[cdumez]

Title: [285747] trunk








Revision 285747
Author cdu...@apple.com
Date 2021-11-12 15:17:17 -0800 (Fri, 12 Nov 2021)


Log Message
Crash when accessing reason property of a newly created AbortSignal
https://bugs.webkit.org/show_bug.cgi?id=233066


Reviewed by Geoffrey Garen.

Source/WebCore:

Make sure AbortSignal.reason get initialized to jsUndefined() by default
and not a default-constructed JSValue.

Test: fast/dom/AbortSignal-reason-crash.html

* dom/AbortSignal.cpp:
(WebCore::AbortSignal::AbortSignal):
* dom/AbortSignal.h:

LayoutTests:

Add layout test coverage.

* fast/dom/AbortSignal-reason-crash-expected.txt: Added.
* fast/dom/AbortSignal-reason-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/AbortSignal.cpp
trunk/Source/WebCore/dom/AbortSignal.h


Added Paths

trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-expected.txt
trunk/LayoutTests/fast/dom/AbortSignal-reason-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285746 => 285747)

--- trunk/LayoutTests/ChangeLog	2021-11-12 23:11:42 UTC (rev 285746)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 23:17:17 UTC (rev 285747)
@@ -1,3 +1,16 @@
+2021-11-12  Chris Dumez  
+
+Crash when accessing reason property of a newly created AbortSignal
+https://bugs.webkit.org/show_bug.cgi?id=233066
+
+
+Reviewed by Geoffrey Garen.
+
+Add layout test coverage.
+
+* fast/dom/AbortSignal-reason-crash-expected.txt: Added.
+* fast/dom/AbortSignal-reason-crash.html: Added.
+
 2021-11-12  Ryan Haddad  
 
 Unreviewed, reverting r285583.


Added: trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-expected.txt (0 => 285747)

--- trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-expected.txt	2021-11-12 23:17:17 UTC (rev 285747)
@@ -0,0 +1,10 @@
+Tests accessing the reason of a newly created AbortSignal.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS new AbortController().signal.reason is undefined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/AbortSignal-reason-crash.html (0 => 285747)

--- trunk/LayoutTests/fast/dom/AbortSignal-reason-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/AbortSignal-reason-crash.html	2021-11-12 23:17:17 UTC (rev 285747)
@@ -0,0 +1,11 @@
+
+
+
+
+description("Tests accessing the reason of a newly created AbortSignal.");
+
+shouldBeUndefined("new AbortController().signal.reason");
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (285746 => 285747)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 23:11:42 UTC (rev 285746)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 23:17:17 UTC (rev 285747)
@@ -1,3 +1,20 @@
+2021-11-12  Chris Dumez  
+
+Crash when accessing reason property of a newly created AbortSignal
+https://bugs.webkit.org/show_bug.cgi?id=233066
+
+
+Reviewed by Geoffrey Garen.
+
+Make sure AbortSignal.reason get initialized to jsUndefined() by default
+and not a default-constructed JSValue.
+
+Test: fast/dom/AbortSignal-reason-crash.html
+
+* dom/AbortSignal.cpp:
+(WebCore::AbortSignal::AbortSignal):
+* dom/AbortSignal.h:
+
 2021-11-12  Ryan Haddad  
 
 Unreviewed, reverting r285583.


Modified: trunk/Source/WebCore/dom/AbortSignal.cpp (285746 => 285747)

--- trunk/Source/WebCore/dom/AbortSignal.cpp	2021-11-12 23:11:42 UTC (rev 285746)
+++ trunk/Source/WebCore/dom/AbortSignal.cpp	2021-11-12 23:17:17 UTC (rev 285747)
@@ -57,6 +57,7 @@
 , m_aborted(aborted == Aborted::Yes)
 , m_reason(reason)
 {
+ASSERT(reason);
 }
 
 // https://dom.spec.whatwg.org/#abortsignal-signal-abort


Modified: trunk/Source/WebCore/dom/AbortSignal.h (285746 => 285747)

--- trunk/Source/WebCore/dom/AbortSignal.h	2021-11-12 23:11:42 UTC (rev 285746)
+++ trunk/Source/WebCore/dom/AbortSignal.h	2021-11-12 23:17:17 UTC (rev 285747)
@@ -64,7 +64,7 @@
 
 private:
 enum class Aborted : bool { No, Yes };
-explicit AbortSignal(ScriptExecutionContext&, Aborted = Aborted::No, JSC::JSValue reason = { });
+explicit AbortSignal(ScriptExecutionContext&, Aborted = Aborted::No, JSC::JSValue reason = JSC::jsUndefined());
 
 // EventTarget.
 EventTargetInterface eventTargetInterface() const final { return AbortSignalEventTargetInterfaceType; }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285746] trunk

[sihui_liu]

Title: [285746] trunk








Revision 285746
Author sihui_...@apple.com
Date 2021-11-12 15:11:42 -0800 (Fri, 12 Nov 2021)


Log Message
Set default general storage directory to websiteDataDirectory
https://bugs.webkit.org/show_bug.cgi?id=232985

Reviewed by Geoffrey Garen.

Source/WebKit:

New API test: FileSystemAccess.MigrateToNewStorageDirectory

* UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::defaultGeneralStorageDirectory):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm:
* TestWebKitAPI/Tests/WebKitCocoa/file-system-access.salt: Added.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h
trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/FileSystemAccess.mm


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/file-system-access.salt




Diff

Modified: trunk/Source/WebKit/ChangeLog (285745 => 285746)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 23:00:38 UTC (rev 285745)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 23:11:42 UTC (rev 285746)
@@ -1,3 +1,16 @@
+2021-11-12  Sihui Liu  
+
+Set default general storage directory to websiteDataDirectory
+https://bugs.webkit.org/show_bug.cgi?id=232985
+
+Reviewed by Geoffrey Garen.
+
+New API test: FileSystemAccess.MigrateToNewStorageDirectory
+
+* UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
+* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
+(WebKit::WebsiteDataStore::defaultGeneralStorageDirectory):
+
 2021-11-12  Timothy Hatcher  
 
 Remove non-completionHandler version of -[WKWebView _loadServiceWorker:]


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h (285745 => 285746)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h	2021-11-12 23:00:38 UTC (rev 285745)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h	2021-11-12 23:11:42 UTC (rev 285746)
@@ -82,7 +82,7 @@
 
 @property (nonatomic, nullable, copy) NSURL *alternativeServicesStorageDirectory WK_API_AVAILABLE(macos(11.0), ios(14.0));
 @property (nonatomic, nullable, copy) NSURL *standaloneApplicationURL WK_API_AVAILABLE(macos(11.0), ios(14.0));
-@property (nonatomic, nullable, copy) NSURL *storageDirectory WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+@property (nonatomic, nullable, copy) NSURL *generalStorageDirectory WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 // Testing only.
 @property (nonatomic) BOOL allLoadsBlockedByDeviceManagementRestrictionsForTesting WK_API_AVAILABLE(macos(10.15), ios(13.0));


Modified: trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm (285745 => 285746)

--- trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm	2021-11-12 23:00:38 UTC (rev 285745)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm	2021-11-12 23:11:42 UTC (rev 285746)
@@ -278,7 +278,28 @@
 
 String WebsiteDataStore::defaultGeneralStorageDirectory()
 {
-return cacheDirectoryFileSystemRepresentation("Storage");
+auto directory = websiteDataDirectoryFileSystemRepresentation("Default");
+
+static dispatch_once_t onceToken;
+dispatch_once(, ^{
+// This is the old storage directory, and there might be files left here.
+auto oldDirectory = cacheDirectoryFileSystemRepresentation("Storage", ShouldCreateDirectory::No);
+NSFileManager *fileManager = [NSFileManager defaultManager];
+NSArray *files = [fileManager contentsOfDirectoryAtPath:oldDirectory error:0];
+if (files) {
+for (NSString *fileName in files) {
+if (![fileName length])
+continue;
+
+NSString *path = [directory stringByAppendingPathComponent:fileName];
+NSString *oldPath = [oldDirectory stringByAppendingPathComponent:fileName];
+[fileManager moveItemAtPath:oldPath toPath:path error:nil];
+}
+}
+[fileManager removeItemAtPath:oldDirectory error:nil];
+});
+
+return directory;
 }
 
 String WebsiteDataStore::defaultNetworkCacheDirectory()


Modified: trunk/Tools/ChangeLog (285745 => 285746)

--- trunk/Tools/ChangeLog	2021-11-12 23:00:38 UTC (rev 285745)
+++ trunk/Tools/ChangeLog	2021-11-12 23:11:42 UTC (rev 285746)
@@ -1,3 +1,14 @@
+2021-11-12  Sihui Liu  
+
+Set default general storage directory to websiteDataDirectory
+https://bugs.webkit.org/show_bug.cgi?id=232985
+
+Reviewed by Geoffrey Garen.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* 

[webkit-changes] [285745] trunk

[ryanhaddad]

Title: [285745] trunk








Revision 285745
Author ryanhad...@apple.com
Date 2021-11-12 15:00:38 -0800 (Fri, 12 Nov 2021)


Log Message
Unreviewed, reverting r285583.

Seems to have caused many layout tests to become flaky
failures

Reverted changeset:

"[css-contain] Support contain:paint"
https://bugs.webkit.org/show_bug.cgi?id=224742
https://commits.webkit.org/r285583

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-item-contains-strict-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFragmentContainer.cpp
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (285744 => 285745)

--- trunk/LayoutTests/ChangeLog	2021-11-12 22:47:21 UTC (rev 285744)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 23:00:38 UTC (rev 285745)
@@ -1,3 +1,16 @@
+2021-11-12  Ryan Haddad  
+
+Unreviewed, reverting r285583.
+
+Seems to have caused many layout tests to become flaky
+failures
+
+Reverted changeset:
+
+"[css-contain] Support contain:paint"
+https://bugs.webkit.org/show_bug.cgi?id=224742
+https://commits.webkit.org/r285583
+
 2021-11-12  Chris Dumez  
 
 Regression(r285639) fast/dom/Geolocation/cached-position-iframe.html is frequently crashing on Mac-wk1


Modified: trunk/LayoutTests/TestExpectations (285744 => 285745)

--- trunk/LayoutTests/TestExpectations	2021-11-12 22:47:21 UTC (rev 285744)
+++ trunk/LayoutTests/TestExpectations	2021-11-12 23:00:38 UTC (rev 285745)
@@ -4721,10 +4721,6 @@
 # CSS containment tests that fail
 # webkit-ruby-text
 imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/css/css-contain/contain-paint-005.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/css/css-contain/contain-paint-006.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/css/css-contain/contain-paint-008.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/css/css-contain/contain-paint-021.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-001.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-003.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-004.html [ ImageOnlyFailure ]
@@ -4739,8 +4735,49 @@
 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-020.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-021.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-022.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-001.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-004.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-005.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-006.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-008.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-009.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-010.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-014.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-019.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-020.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-022.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-023.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-047.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-048.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-cell-001.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-contain/contain-paint-cell-002.html [ 

[webkit-changes] [285744] trunk/Source/WebCore/PAL

[wenson_hsieh]

Title: [285744] trunk/Source/WebCore/PAL








Revision 285744
Author wenson_hs...@apple.com
Date 2021-11-12 14:47:21 -0800 (Fri, 12 Nov 2021)


Log Message
Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
https://bugs.webkit.org/show_bug.cgi?id=233064
rdar://85341122

Reviewed by Tim Horton.

Replace these static NSString definitions with soft-linked constants instead.

* pal/spi/cocoa/NSAttributedStringSPI.h:

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (285743 => 285744)

--- trunk/Source/WebCore/PAL/ChangeLog	2021-11-12 22:32:18 UTC (rev 285743)
+++ trunk/Source/WebCore/PAL/ChangeLog	2021-11-12 22:47:21 UTC (rev 285744)
@@ -1,3 +1,15 @@
+2021-11-12  Wenson Hsieh  
+
+Stop statically declaring various UIFoundation constants in NSAttributedStringSPI.h
+https://bugs.webkit.org/show_bug.cgi?id=233064
+rdar://85341122
+
+Reviewed by Tim Horton.
+
+Replace these static NSString definitions with soft-linked constants instead.
+
+* pal/spi/cocoa/NSAttributedStringSPI.h:
+
 2021-11-11  Adrian Perez de Castro  
 
 Non-unified build fixes, early November 2021 edition, bis


Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h (285743 => 285744)

--- trunk/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h	2021-11-12 22:32:18 UTC (rev 285743)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h	2021-11-12 22:47:21 UTC (rev 285744)
@@ -95,6 +95,32 @@
 #define NSMarkedClauseSegmentAttributeName getNSMarkedClauseSegmentAttributeName()
 SOFT_LINK_CONSTANT(UIFoundation, NSTextAlternativesAttributeName, NSString *)
 #define NSTextAlternativesAttributeName getNSTextAlternativesAttributeName()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerCircle, NSString *)
+#define NSTextListMarkerCircle getNSTextListMarkerCircle()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerDisc, NSString *)
+#define NSTextListMarkerDisc getNSTextListMarkerDisc()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerSquare, NSString *)
+#define NSTextListMarkerSquare getNSTextListMarkerSquare()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseHexadecimal, NSString *)
+#define NSTextListMarkerLowercaseHexadecimal getNSTextListMarkerLowercaseHexadecimal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseHexadecimal, NSString *)
+#define NSTextListMarkerUppercaseHexadecimal getNSTextListMarkerUppercaseHexadecimal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerOctal, NSString *)
+#define NSTextListMarkerOctal getNSTextListMarkerOctal()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseAlpha, NSString *)
+#define NSTextListMarkerLowercaseAlpha getNSTextListMarkerLowercaseAlpha()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseAlpha, NSString *)
+#define NSTextListMarkerUppercaseAlpha getNSTextListMarkerUppercaseAlpha()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseLatin, NSString *)
+#define NSTextListMarkerLowercaseLatin getNSTextListMarkerLowercaseLatin()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseLatin, NSString *)
+#define NSTextListMarkerUppercaseLatin getNSTextListMarkerUppercaseLatin()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerLowercaseRoman, NSString *)
+#define NSTextListMarkerLowercaseRoman getNSTextListMarkerLowercaseRoman()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerUppercaseRoman, NSString *)
+#define NSTextListMarkerUppercaseRoman getNSTextListMarkerUppercaseRoman()
+SOFT_LINK_CONSTANT(UIFoundation, NSTextListMarkerDecimal, NSString *)
+#define NSTextListMarkerDecimal getNSTextListMarkerDecimal()
 
 // We don't softlink NSSuperscriptAttributeName because UIFoundation stopped exporting it.
 // This attribute is being deprecated at the API level, but internally UIFoundation
@@ -111,18 +137,4 @@
 - (BOOL)containsAttachments;
 @end
 
-static NSString *const NSTextListMarkerCircle = @"{circle}";
-static NSString *const NSTextListMarkerDisc = @"{disc}";
-static NSString *const NSTextListMarkerSquare = @"{square}";
-static NSString *const NSTextListMarkerLowercaseHexadecimal = @"{lower-hexadecimal}";
-static NSString *const NSTextListMarkerUppercaseHexadecimal = @"{upper-hexadecimal}";
-static NSString *const NSTextListMarkerOctal = @"{octal}";
-static NSString *const NSTextListMarkerLowercaseAlpha = @"{lower-alpha}";
-static NSString *const NSTextListMarkerUppercaseAlpha = @"{upper-alpha}";
-static NSString *const NSTextListMarkerLowercaseLatin = @"{lower-latin}";
-static NSString *const NSTextListMarkerUppercaseLatin = @"{upper-latin}";
-static NSString *const NSTextListMarkerLowercaseRoman = @"{lower-roman}";
-static NSString *const NSTextListMarkerUppercaseRoman = @"{upper-roman}";
-static NSString *const NSTextListMarkerDecimal = @"{decimal}";
-
 #endif // PLATFORM(IOS_FAMILY)

[webkit-changes] [285743] trunk/LayoutTests

[cdumez]

Title: [285743] trunk/LayoutTests








Revision 285743
Author cdu...@apple.com
Date 2021-11-12 14:32:18 -0800 (Fri, 12 Nov 2021)


Log Message
Regression(r285639) fast/dom/Geolocation/cached-position-iframe.html is frequently crashing on Mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=233043


Unreviewed, unskip the test now that Alexey reverted r285639.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285742 => 285743)

--- trunk/LayoutTests/ChangeLog	2021-11-12 22:20:11 UTC (rev 285742)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 22:32:18 UTC (rev 285743)
@@ -1,3 +1,13 @@
+2021-11-12  Chris Dumez  
+
+Regression(r285639) fast/dom/Geolocation/cached-position-iframe.html is frequently crashing on Mac-wk1
+https://bugs.webkit.org/show_bug.cgi?id=233043
+
+
+Unreviewed, unskip the test now that Alexey reverted r285639.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-11-12  Commit Queue  
 
 Unreviewed, reverting r285639.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (285742 => 285743)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-11-12 22:20:11 UTC (rev 285742)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-11-12 22:32:18 UTC (rev 285743)
@@ -1518,7 +1518,5 @@
 
 webkit.org/b/233008 [ Debug ] http/tests/css/filters-on-iframes-transform.html [ Skip ]
 
-webkit.org/b/233043 fast/dom/Geolocation/cached-position-iframe.html [ Skip ]
-
 # DumpRenderTree doesn't invoke inspector instrumentation when repainting.
 webkit.org/b/232852 inspector/page/setShowPaintRects.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285742] trunk/Source/WebKit

[timothy]

Title: [285742] trunk/Source/WebKit








Revision 285742
Author timo...@apple.com
Date 2021-11-12 14:20:11 -0800 (Fri, 12 Nov 2021)


Log Message
Remove non-completionHandler version of -[WKWebView _loadServiceWorker:]
https://bugs.webkit.org/show_bug.cgi?id=233069
rdar://problem/85355540

Reviewed by Chris Dumez.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _loadServiceWorker:]): Deleted.
* UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed _loadServiceWorker:.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (285741 => 285742)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 22:14:26 UTC (rev 285741)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 22:20:11 UTC (rev 285742)
@@ -1,3 +1,15 @@
+2021-11-12  Timothy Hatcher  
+
+Remove non-completionHandler version of -[WKWebView _loadServiceWorker:]
+https://bugs.webkit.org/show_bug.cgi?id=233069
+rdar://problem/85355540
+
+Reviewed by Chris Dumez.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _loadServiceWorker:]): Deleted.
+* UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed _loadServiceWorker:.
+
 2021-11-12  Peng Liu  
 
 Promote WKPreferences._fullScreenEnabled to API


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (285741 => 285742)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2021-11-12 22:14:26 UTC (rev 285741)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm	2021-11-12 22:20:11 UTC (rev 285742)
@@ -2442,11 +2442,6 @@
 });
 }
 
-- (void)_loadServiceWorker:(NSURL *)url
-{
-[self _loadServiceWorker:url completionHandler:^(BOOL) { }];
-}
-
 - (void)_grantAccessToAssetServices
 {
 THROW_IF_SUSPENDED;


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h (285741 => 285742)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h	2021-11-12 22:14:26 UTC (rev 285741)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h	2021-11-12 22:20:11 UTC (rev 285742)
@@ -409,7 +409,6 @@
 - (void)_didLoadAppInitiatedRequest:(void (^)(BOOL result))completionHandler;
 - (void)_didLoadNonAppInitiatedRequest:(void (^)(BOOL result))completionHandler;
 
-- (void)_loadServiceWorker:(NSURL *)url WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); // FIXME: Remove this once clients have adopted the version with a completion handler.
 - (void)_loadServiceWorker:(NSURL *)url completionHandler:(void (^)(BOOL success))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 - (void)_suspendPage:(void (^)(BOOL))completionHandler WK_API_AVAILABLE(macos(12.0), ios(15.0));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285741] trunk

[peng . liu6]

Title: [285741] trunk








Revision 285741
Author peng.l...@apple.com
Date 2021-11-12 14:14:26 -0800 (Fri, 12 Nov 2021)


Log Message
Promote WKPreferences._fullScreenEnabled to API
https://bugs.webkit.org/show_bug.cgi?id=230784


Reviewed by Jer Noble.

Source/WebKit:

* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences isElementFullscreenEnabled]):
(-[WKPreferences setElementFullscreenEnabled:]):
* UIProcess/API/Cocoa/WKWebView.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView fullscreenState]):
* UIProcess/Cocoa/FullscreenClient.h:
* UIProcess/Cocoa/FullscreenClient.mm:
(WebKit::FullscreenClient::willEnterFullscreen):
(WebKit::FullscreenClient::didEnterFullscreen):
(WebKit::FullscreenClient::willExitFullscreen):
(WebKit::FullscreenClient::didExitFullscreen):
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::WebViewImpl):
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::willEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::didEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::willExitFullScreen):
(WebKit::WebFullScreenManagerProxy::didExitFullScreen):
* UIProcess/WebFullScreenManagerProxy.h:
(WebKit::WebFullScreenManagerProxy::fullscreenState const):

Tools:

* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate defaultConfiguration]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/Cocoa/FullscreenClient.h
trunk/Source/WebKit/UIProcess/Cocoa/FullscreenClient.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
trunk/Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/AppDelegate.m




Diff

Modified: trunk/Source/WebKit/ChangeLog (285740 => 285741)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 22:11:13 UTC (rev 285740)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 22:14:26 UTC (rev 285741)
@@ -1,3 +1,34 @@
+2021-11-12  Peng Liu  
+
+Promote WKPreferences._fullScreenEnabled to API
+https://bugs.webkit.org/show_bug.cgi?id=230784
+
+
+Reviewed by Jer Noble.
+
+* UIProcess/API/Cocoa/WKPreferences.h:
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences isElementFullscreenEnabled]):
+(-[WKPreferences setElementFullscreenEnabled:]):
+* UIProcess/API/Cocoa/WKWebView.h:
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView fullscreenState]):
+* UIProcess/Cocoa/FullscreenClient.h:
+* UIProcess/Cocoa/FullscreenClient.mm:
+(WebKit::FullscreenClient::willEnterFullscreen):
+(WebKit::FullscreenClient::didEnterFullscreen):
+(WebKit::FullscreenClient::willExitFullscreen):
+(WebKit::FullscreenClient::didExitFullscreen):
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::WebViewImpl):
+* UIProcess/WebFullScreenManagerProxy.cpp:
+(WebKit::WebFullScreenManagerProxy::willEnterFullScreen):
+(WebKit::WebFullScreenManagerProxy::didEnterFullScreen):
+(WebKit::WebFullScreenManagerProxy::willExitFullScreen):
+(WebKit::WebFullScreenManagerProxy::didExitFullScreen):
+* UIProcess/WebFullScreenManagerProxy.h:
+(WebKit::WebFullScreenManagerProxy::fullscreenState const):
+
 2021-11-12  Chris Dumez  
 
 Demote WKWebpagePreferences.captivePortalModeEnabled API to SPI


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h (285740 => 285741)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h	2021-11-12 22:11:13 UTC (rev 285740)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h	2021-11-12 22:14:26 UTC (rev 285741)
@@ -70,6 +70,11 @@
  */
 @property (nonatomic, getter=isSiteSpecificQuirksModeEnabled) BOOL siteSpecificQuirksModeEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
+/*! @abstract A Boolean value indicating whether Fullscreen API is enabled.
+ @discussion The default value is NO. We can set it to YES to enable support for the fullscreen API.
+ */
+@property (nonatomic, getter=isElementFullscreenEnabled) BOOL elementFullscreenEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+
 @end
 
 @interface WKPreferences (WKDeprecated)


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (285740 => 285741)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm	2021-11-12 22:11:13 UTC (rev 285740)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm	2021-11-12 22:14:26 UTC (rev 285741)
@@ -163,6 +163,16 @@
 _preferences->setNeedsSiteSpecificQuirks(enabled);
 }
 
+- (BOOL)isElementFullscreenEnabled
+{
+return _preferences->fullScreenEnabled();
+}
+
+- 

[webkit-changes] [285740] trunk

[commit-queue]

Title: [285740] trunk








Revision 285740
Author commit-qu...@webkit.org
Date 2021-11-12 14:11:13 -0800 (Fri, 12 Nov 2021)


Log Message
Implement custom element definition's *disable shadow* flag
https://bugs.webkit.org/show_bug.cgi?id=233023

Patch by Alexey Shvayka  on 2021-11-12
Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing or failing later on.

* web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
* web-platform-tests/custom-elements/upgrading-expected.txt:
* web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:

Source/WebCore:

This change implements *disable shadow* flag that precludes attachShadow() [1]
as well as upgrading an element with already attached shadow root [2].

Aligns WebKit with Blink and Gecko.
Preserves the fast path for non-custom elements.

[1] https://dom.spec.whatwg.org/#ref-for-concept-custom-element-definition-disable-shadow
[2] https://html.spec.whatwg.org/multipage/custom-elements.html#upgrades:concept-custom-element-definition-disable-shadow

Tests: imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html
   imported/w3c/web-platform-tests/custom-elements/upgrading.html
   imported/w3c/web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element.html

* bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::JSCustomElementInterface):
(WebCore::JSCustomElementInterface::upgradeElement):
* bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::disableShadow):
(WebCore::JSCustomElementInterface::isShadowDisabled const):
* bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::JSCustomElementRegistry::define):
* dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::addElementDefinition):
* dom/CustomElementRegistry.h:
(WebCore::CustomElementRegistry::isShadowDisabled const):
* dom/Element.cpp:
(WebCore::canAttachAuthorShadowRoot):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/upgrading-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCustomElementInterface.cpp
trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h
trunk/Source/WebCore/bindings/js/JSCustomElementRegistryCustom.cpp
trunk/Source/WebCore/dom/CustomElementRegistry.cpp
trunk/Source/WebCore/dom/CustomElementRegistry.h
trunk/Source/WebCore/dom/Element.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285739 => 285740)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-12 21:23:59 UTC (rev 285739)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-11-12 22:11:13 UTC (rev 285740)
@@ -1,3 +1,16 @@
+2021-11-12  Alexey Shvayka  
+
+Implement custom element definition's *disable shadow* flag
+https://bugs.webkit.org/show_bug.cgi?id=233023
+
+Reviewed by Geoffrey Garen.
+
+Rebaseline WPT tests now that more checks are passing or failing later on.
+
+* web-platform-tests/custom-elements/CustomElementRegistry-expected.txt:
+* web-platform-tests/custom-elements/upgrading-expected.txt:
+* web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:
+
 2021-11-12  Commit Queue  
 
 Unreviewed, reverting r285639.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt (285739 => 285740)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt	2021-11-12 21:23:59 UTC (rev 285739)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry-expected.txt	2021-11-12 22:11:13 UTC (rev 285740)
@@ -9,26 +9,26 @@
 PASS customElements.define must check IsConstructor on the constructor before checking the element definition is running flag
 PASS customElements.define must validate the custom element name before checking the element definition is running flag
 PASS customElements.define unset the element definition is running flag before upgrading custom elements
-FAIL customElements.define must not throw when defining another custom element in a different global object during Get(constructor, "prototype") assert_array_equals: customElements.define must get "prototype", "disabledFeatures", and "formAssociated" on the constructor lengths differ, expected array ["prototype", "disabledFeatures", "formAssociated"] length 3, got ["prototype"] length 1
+FAIL customElements.define must not throw when defining another custom element in a different global object during Get(constructor, "prototype") assert_array_equals: customElements.define must get "prototype", 

[webkit-changes] [285739] trunk

[cdumez]

Title: [285739] trunk








Revision 285739
Author cdu...@apple.com
Date 2021-11-12 13:23:59 -0800 (Fri, 12 Nov 2021)


Log Message
Demote WKWebpagePreferences.captivePortalModeEnabled API to SPI
https://bugs.webkit.org/show_bug.cgi?id=233059

Reviewed by Geoffrey Garen.

Source/WebKit:

Demote WKWebpagePreferences.captivePortalModeEnabled API to SPI until we reach
agreement on a suitable API name.

* UIProcess/API/Cocoa/WKWebpagePreferences.h:
* UIProcess/API/Cocoa/WKWebpagePreferences.mm:
(-[WKWebpagePreferences _setCaptivePortalModeEnabled:]):
(-[WKWebpagePreferences _captivePortalModeEnabled]):
(-[WKWebpagePreferences setCaptivePortalModeEnabled:]): Deleted.
(-[WKWebpagePreferences captivePortalModeEnabled]): Deleted.
* UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:

Tools:

Update API test accordingly.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (285738 => 285739)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 21:22:47 UTC (rev 285738)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 21:23:59 UTC (rev 285739)
@@ -1,5 +1,23 @@
 2021-11-12  Chris Dumez  
 
+Demote WKWebpagePreferences.captivePortalModeEnabled API to SPI
+https://bugs.webkit.org/show_bug.cgi?id=233059
+
+Reviewed by Geoffrey Garen.
+
+Demote WKWebpagePreferences.captivePortalModeEnabled API to SPI until we reach
+agreement on a suitable API name.
+
+* UIProcess/API/Cocoa/WKWebpagePreferences.h:
+* UIProcess/API/Cocoa/WKWebpagePreferences.mm:
+(-[WKWebpagePreferences _setCaptivePortalModeEnabled:]):
+(-[WKWebpagePreferences _captivePortalModeEnabled]):
+(-[WKWebpagePreferences setCaptivePortalModeEnabled:]): Deleted.
+(-[WKWebpagePreferences captivePortalModeEnabled]): Deleted.
+* UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
+
+2021-11-12  Chris Dumez  
+
 Rename ProcessLauncherMac.mm to ProcessLauncherCocoa.mm
 https://bugs.webkit.org/show_bug.cgi?id=233045
 


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h (285738 => 285739)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h	2021-11-12 21:22:47 UTC (rev 285738)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h	2021-11-12 21:23:59 UTC (rev 285739)
@@ -71,9 +71,4 @@
 */
 @property (nonatomic) BOOL allowsContentJavaScript WK_API_AVAILABLE(macos(11.0), ios(14.0));
 
-/*! @abstract A boolean indicating whether Captive Portal mode is enabled.
- @discussion The default value is NO on macOS. On iOS, the default value depends on the system setting.
- */
-@property (nonatomic) BOOL captivePortalModeEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
-
 @end


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm (285738 => 285739)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm	2021-11-12 21:22:47 UTC (rev 285738)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm	2021-11-12 21:23:59 UTC (rev 285739)
@@ -391,7 +391,7 @@
 }
 }
 
-- (void)setCaptivePortalModeEnabled:(BOOL)captivePortalModeEnabled
+- (void)_setCaptivePortalModeEnabled:(BOOL)captivePortalModeEnabled
 {
 #if PLATFORM(IOS_FAMILY)
 if (!WTF::processHasEntitlement("com.apple.developer.web-browser"))
@@ -400,7 +400,7 @@
 _websitePolicies->setCaptivePortalModeEnabled(!!captivePortalModeEnabled);
 }
 
-- (BOOL)captivePortalModeEnabled
+- (BOOL)_captivePortalModeEnabled
 {
 return _websitePolicies->captivePortalModeEnabled();
 }


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h (285738 => 285739)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h	2021-11-12 21:22:47 UTC (rev 285738)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h	2021-11-12 21:23:59 UTC (rev 285739)
@@ -85,4 +85,6 @@
 
 @property (nonatomic, setter=_setMouseEventPolicy:) _WKWebsiteMouseEventPolicy _mouseEventPolicy WK_API_AVAILABLE(macos(11.0), ios(14.0));
 
+@property (nonatomic, setter=_setCaptivePortalModeEnabled:) BOOL _captivePortalModeEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+
 @end


Modified: trunk/Tools/ChangeLog (285738 => 285739)

--- trunk/Tools/ChangeLog	2021-11-12 21:22:47 UTC (rev 285738)
+++ trunk/Tools/ChangeLog	2021-11-12 21:23:59 UTC (rev 285739)
@@ -1,3 +1,14 @@
+2021-11-12  Chris Dumez  
+
+Demote WKWebpagePreferences.captivePortalModeEnabled API to SPI
+https://bugs.webkit.org/show_bug.cgi?id=233059
+
+Reviewed by Geoffrey Garen.
+
+Update API test 

[webkit-changes] [285737] trunk/Source/WebKit

[cdumez]

Title: [285737] trunk/Source/WebKit








Revision 285737
Author cdu...@apple.com
Date 2021-11-12 12:38:12 -0800 (Fri, 12 Nov 2021)


Log Message
Rename ProcessLauncherMac.mm to ProcessLauncherCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=233045


Reviewed by Brent Fulgham.

Follow-up to r285729 to rename to ProcessLauncherCocoa.mm instead of ProcessLauncherDarwin.mm
given that the implementation is using NSBundle.

* SourcesCocoa.txt:
* UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: Renamed from Source/WebKit/UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm.
(WebKit::serviceName):
(WebKit::shouldLeakBoost):
(WebKit::systemDirectoryPath):
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):
(WebKit::ProcessLauncher::terminateXPCConnection):
(WebKit::terminateWithReason):
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/UIProcess/Launcher/cocoa/
trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm


Removed Paths

trunk/Source/WebKit/UIProcess/Launcher/darwin/




Diff

Modified: trunk/Source/WebKit/ChangeLog (285736 => 285737)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 20:15:39 UTC (rev 285736)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 20:38:12 UTC (rev 285737)
@@ -1,3 +1,26 @@
+2021-11-12  Chris Dumez  
+
+Rename ProcessLauncherMac.mm to ProcessLauncherCocoa.mm
+https://bugs.webkit.org/show_bug.cgi?id=233045
+
+
+Reviewed by Brent Fulgham.
+
+Follow-up to r285729 to rename to ProcessLauncherCocoa.mm instead of ProcessLauncherDarwin.mm
+given that the implementation is using NSBundle.
+
+* SourcesCocoa.txt:
+* UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: Renamed from Source/WebKit/UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm.
+(WebKit::serviceName):
+(WebKit::shouldLeakBoost):
+(WebKit::systemDirectoryPath):
+(WebKit::ProcessLauncher::launchProcess):
+(WebKit::ProcessLauncher::terminateProcess):
+(WebKit::ProcessLauncher::platformInvalidate):
+(WebKit::ProcessLauncher::terminateXPCConnection):
+(WebKit::terminateWithReason):
+* WebKit.xcodeproj/project.pbxproj:
+
 2021-11-12  Brent Fulgham  
 
 REGRESSION (r285698): Build correction after refactoring id handling


Modified: trunk/Source/WebKit/SourcesCocoa.txt (285736 => 285737)

--- trunk/Source/WebKit/SourcesCocoa.txt	2021-11-12 20:15:39 UTC (rev 285736)
+++ trunk/Source/WebKit/SourcesCocoa.txt	2021-11-12 20:38:12 UTC (rev 285737)
@@ -511,7 +511,7 @@
 UIProcess/ios/WKUSDPreviewView.mm
 UIProcess/ios/WKWebEvent.mm
 
-UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm
+UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm
 
 UIProcess/mac/CorrectionPanel.mm
 UIProcess/mac/DisplayLink.cpp


Copied: trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm (from rev 285736, trunk/Source/WebKit/UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm) (0 => 285737)

--- trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm	(rev 0)
+++ trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm	2021-11-12 20:38:12 UTC (rev 285737)
@@ -0,0 +1,358 @@
+/*
+ * Copyright (C) 2010-2021 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import "config.h"
+#import "ProcessLauncher.h"
+
+#import "Logging.h"
+#import "ReasonSPI.h"
+#import "WebPreferencesDefaultValues.h"
+#import 
+#import 
+#import 
+#import 
+#import 

[webkit-changes] [285736] trunk/Source/WebKit

[bfulgham]

Title: [285736] trunk/Source/WebKit








Revision 285736
Author bfulg...@apple.com
Date 2021-11-12 12:15:39 -0800 (Fri, 12 Nov 2021)


Log Message
REGRESSION (r285698): Build correction after refactoring id handling
https://bugs.webkit.org/show_bug.cgi?id=233052


Reviewed by Chris Dumez.

Build fix after r285698. The new 'toNSData' method needs its namespace included.

* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::toASCDescriptor):
(WebKit::configureRegistrationRequestContext):
(WebKit::configurationAssertionRequestContext):
(WebKit::toNSData): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (285735 => 285736)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 20:09:11 UTC (rev 285735)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 20:15:39 UTC (rev 285736)
@@ -1,3 +1,19 @@
+2021-11-12  Brent Fulgham  
+
+REGRESSION (r285698): Build correction after refactoring id handling
+https://bugs.webkit.org/show_bug.cgi?id=233052
+
+
+Reviewed by Chris Dumez.
+
+Build fix after r285698. The new 'toNSData' method needs its namespace included.
+
+* UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
+(WebKit::toASCDescriptor):
+(WebKit::configureRegistrationRequestContext):
+(WebKit::configurationAssertionRequestContext):
+(WebKit::toNSData): Deleted.
+
 2021-11-12  Per Arne  
 
 [macOS][GPUP] Block access to mach register


Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm (285735 => 285736)

--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm	2021-11-12 20:09:11 UTC (rev 285735)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm	2021-11-12 20:15:39 UTC (rev 285736)
@@ -35,6 +35,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -49,11 +50,6 @@
 return ArrayBuffer::create(reinterpret_cast(data.bytes), data.length);
 }
 
-static inline RetainPtr toNSData(const Vector vector)
-{
-return adoptNS([[NSData alloc] initWithBytes:vector.data() length:vector.size()]);
-}
-
 static inline RetainPtr toNSString(UserVerificationRequirement userVerificationRequirement)
 {
 switch (userVerificationRequirement) {
@@ -146,7 +142,7 @@
 }
 }
 
-return adoptNS([allocASCPublicKeyCredentialDescriptorInstance() initWithCredentialID:toNSData(descriptor.id).get() transports:transports.get()]);
+return adoptNS([allocASCPublicKeyCredentialDescriptorInstance() initWithCredentialID:WebCore::toNSData(descriptor.id).get() transports:transports.get()]);
 }
 
 static RetainPtr configureRegistrationRequestContext(const PublicKeyCredentialCreationOptions& options)
@@ -173,10 +169,10 @@
 
 auto credentialCreationOptions = adoptNS([allocASCPublicKeyCredentialCreationOptionsInstance() init]);
 
-[credentialCreationOptions setChallenge:toNSData(options.challenge).get()];
+[credentialCreationOptions setChallenge:WebCore::toNSData(options.challenge).get()];
 [credentialCreationOptions setRelyingPartyIdentifier:options.rp.id];
 [credentialCreationOptions setUserName:options.user.name];
-[credentialCreationOptions setUserIdentifier:toNSData(options.user.id.data()).get()];
+[credentialCreationOptions setUserIdentifier:WebCore::toNSData(options.user.id).get()];
 [credentialCreationOptions setUserDisplayName:options.user.displayName];
 [credentialCreationOptions setUserVerificationPreference:userVerification.get()];
 [credentialCreationOptions setShouldRequireResidentKey:shouldRequireResidentKey];
@@ -231,7 +227,7 @@
 auto requestContext = adoptNS([allocASCCredentialRequestContextInstance() initWithRequestTypes:requestTypes]);
 [requestContext setRelyingPartyIdentifier:options.rpId];
 
-auto challenge = toNSData(options.challenge);
+auto challenge = WebCore::toNSData(options.challenge);
 
 if (requestTypes & ASCCredentialRequestTypePlatformPublicKeyAssertion)
 [requestContext setPlatformKeyCredentialAssertionOptions:[allocASCPublicKeyCredentialAssertionOptionsInstance() initWithKind:ASCPublicKeyCredentialKindPlatform relyingPartyIdentifier:options.rpId challenge:challenge.get() userVerificationPreference:userVerification.get() allowedCredentials:allowedCredentials.get()]];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285735] trunk/Source/WebKit

[pvollan]

Title: [285735] trunk/Source/WebKit








Revision 285735
Author pvol...@apple.com
Date 2021-11-12 12:09:11 -0800 (Fri, 12 Nov 2021)


Log Message
[macOS][GPUP] Block access to mach register
https://bugs.webkit.org/show_bug.cgi?id=232259


Reviewed by Brent Fulgham.

Based on telemetry, block access to mach register in the GPU process on macOS.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (285734 => 285735)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 19:50:24 UTC (rev 285734)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 20:09:11 UTC (rev 285735)
@@ -1,3 +1,15 @@
+2021-11-12  Per Arne  
+
+[macOS][GPUP] Block access to mach register
+https://bugs.webkit.org/show_bug.cgi?id=232259
+
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, block access to mach register in the GPU process on macOS.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+
 2021-11-12  Chris Dumez  
 
 Disable MathML when in Captive Portal Mode


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (285734 => 285735)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-12 19:50:24 UTC (rev 285734)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-12 20:09:11 UTC (rev 285735)
@@ -37,9 +37,6 @@
 ;;; remove unneeded sandbox extensions.
 ;;;
 
-;;; Allow registration of per-pid services.
-(allow mach-register (with telemetry) (local-name-prefix ""))
-
 ;;; Allow read access to standard system paths.
 (allow file-read*
 (require-all
@@ -602,7 +599,8 @@
 (read-write-and-issue-extensions (extension "com.apple.app-sandbox.read-write"))
 
 ;; Allow the OpenGL Profiler to attach.
-(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$"))
+(with-filter (system-attribute apple-internal)
+(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$")))
 
 (if (positive? (string-length (param "DARWIN_USER_CACHE_DIR")))
 (allow-read-write-directory-and-issue-read-write-extensions (param "DARWIN_USER_CACHE_DIR")))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285734] trunk

[don . olmstead]

Title: [285734] trunk








Revision 285734
Author don.olmst...@sony.com
Date 2021-11-12 11:50:24 -0800 (Fri, 12 Nov 2021)


Log Message
[WinCairo] Add Little-CMS support
https://bugs.webkit.org/show_bug.cgi?id=233024

Reviewed by Michael Catanzaro.

.:

Search for LCMS2 and if its present turn it on for WinCairo.

* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

Centralize addition of LCMS2::LCMS2 to the root CMakeLists in WebCore.

* CMakeLists.txt:
* PlatformGTK.cmake:
* PlatformWPE.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/PlatformWPE.cmake
trunk/Source/cmake/OptionsWinCairo.cmake




Diff

Modified: trunk/ChangeLog (285733 => 285734)

--- trunk/ChangeLog	2021-11-12 19:13:03 UTC (rev 285733)
+++ trunk/ChangeLog	2021-11-12 19:50:24 UTC (rev 285734)
@@ -1,3 +1,14 @@
+2021-11-12  Don Olmstead  
+
+[WinCairo] Add Little-CMS support
+https://bugs.webkit.org/show_bug.cgi?id=233024
+
+Reviewed by Michael Catanzaro.
+
+Search for LCMS2 and if its present turn it on for WinCairo.
+
+* Source/cmake/OptionsWinCairo.cmake:
+
 2021-11-11  Michael Catanzaro  
 
 -Warray-bounds, -Wstringop-truncation, -Wstringop-overread warnings in Packed.h


Modified: trunk/Source/WebCore/CMakeLists.txt (285733 => 285734)

--- trunk/Source/WebCore/CMakeLists.txt	2021-11-12 19:13:03 UTC (rev 285733)
+++ trunk/Source/WebCore/CMakeLists.txt	2021-11-12 19:50:24 UTC (rev 285734)
@@ -1936,6 +1936,10 @@
 )
 endif ()
 
+if (USE_LCMS)
+list(APPEND WebCore_LIBRARIES LCMS2::LCMS2)
+endif ()
+
 if (USE_WOFF2)
   list(APPEND WebCore_LIBRARIES WOFF2::dec)
 endif ()


Modified: trunk/Source/WebCore/ChangeLog (285733 => 285734)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 19:13:03 UTC (rev 285733)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 19:50:24 UTC (rev 285734)
@@ -1,3 +1,16 @@
+2021-11-12  Don Olmstead  
+
+[WinCairo] Add Little-CMS support
+https://bugs.webkit.org/show_bug.cgi?id=233024
+
+Reviewed by Michael Catanzaro.
+
+Centralize addition of LCMS2::LCMS2 to the root CMakeLists in WebCore.
+
+* CMakeLists.txt:
+* PlatformGTK.cmake:
+* PlatformWPE.cmake:
+
 2021-11-12  Rob Buis  
 
 Null check host in SlotAssignment::assignSlots


Modified: trunk/Source/WebCore/PlatformGTK.cmake (285733 => 285734)

--- trunk/Source/WebCore/PlatformGTK.cmake	2021-11-12 19:13:03 UTC (rev 285733)
+++ trunk/Source/WebCore/PlatformGTK.cmake	2021-11-12 19:50:24 UTC (rev 285734)
@@ -103,12 +103,6 @@
 GTK::GTK
 )
 
-if (USE_LCMS)
-list(APPEND WebCore_LIBRARIES
-LCMS2::LCMS2
-)
-endif ()
-
 if (USE_WPE_RENDERER)
 list(APPEND WebCore_LIBRARIES
 WPE::libwpe


Modified: trunk/Source/WebCore/PlatformWPE.cmake (285733 => 285734)

--- trunk/Source/WebCore/PlatformWPE.cmake	2021-11-12 19:13:03 UTC (rev 285733)
+++ trunk/Source/WebCore/PlatformWPE.cmake	2021-11-12 19:50:24 UTC (rev 285734)
@@ -76,12 +76,6 @@
 ${UPOWERGLIB_INCLUDE_DIRS}
 )
 
-if (USE_LCMS)
-list(APPEND WebCore_LIBRARIES
-LCMS2::LCMS2
-)
-endif ()
-
 if (USE_WPE_VIDEO_PLANE_DISPLAY_DMABUF OR USE_WPEBACKEND_FDO_AUDIO_EXTENSION)
 list(APPEND WebCore_LIBRARIES ${WPEBACKEND_FDO_LIBRARIES})
 list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES ${WPE_INCLUDE_DIRS})


Modified: trunk/Source/cmake/OptionsWinCairo.cmake (285733 => 285734)

--- trunk/Source/cmake/OptionsWinCairo.cmake	2021-11-12 19:13:03 UTC (rev 285733)
+++ trunk/Source/cmake/OptionsWinCairo.cmake	2021-11-12 19:50:24 UTC (rev 285734)
@@ -21,6 +21,11 @@
 endif ()
 
 # Optional packages
+find_package(LCMS2)
+if (LCMS2_FOUND)
+SET_AND_EXPOSE_TO_BUILD(USE_LCMS ON)
+endif ()
+
 find_package(OpenJPEG 2.3.1)
 if (OpenJPEG_FOUND)
 SET_AND_EXPOSE_TO_BUILD(USE_OPENJPEG ON)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285733] trunk/Tools

[jbedard]

Title: [285733] trunk/Tools








Revision 285733
Author jbed...@apple.com
Date 2021-11-12 11:13:03 -0800 (Fri, 12 Nov 2021)


Log Message
[git-webkit] Open closed pull-request when running pr
https://bugs.webkit.org/show_bug.cgi?id=232765


Reviewed by Dewei Zhu.

* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket.request): Ensure displayId is set when updating PR.
* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
(GitHub.request): Make sure that new pull-requests are open.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.main): Open closed pull-requests.
* Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.PRGenerator.update): Only set head if user specifies head.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:

Canonical link: https://commits.webkit.org/244192@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/setup.py
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (285732 => 285733)

--- trunk/Tools/ChangeLog	2021-11-12 19:02:40 UTC (rev 285732)
+++ trunk/Tools/ChangeLog	2021-11-12 19:13:03 UTC (rev 285733)
@@ -1,3 +1,23 @@
+2021-11-05  Jonathan Bedard  
+
+[git-webkit] Open closed pull-request when running pr
+https://bugs.webkit.org/show_bug.cgi?id=232765
+
+
+Reviewed by Dewei Zhu.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
+(BitBucket.request): Ensure displayId is set when updating PR.
+* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
+(GitHub.request): Make sure that new pull-requests are open.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
+(PullRequest.main): Open closed pull-requests.
+* Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
+(GitHub.PRGenerator.update): Only set head if user specifies head.
+* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
+
 2021-11-12  Chris Dumez  
 
 Disable MathML when in Captive Portal Mode


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/setup.py (285732 => 285733)

--- trunk/Tools/Scripts/libraries/webkitcorepy/setup.py	2021-11-12 19:02:40 UTC (rev 285732)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/setup.py	2021-11-12 19:13:03 UTC (rev 285733)
@@ -30,7 +30,7 @@
 
 setup(
 name='webkitcorepy',
-version='0.11.3',
+version='0.11.4',
 description='Library containing various Python support classes and functions.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py (285732 => 285733)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py	2021-11-12 19:02:40 UTC (rev 285732)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py	2021-11-12 19:13:03 UTC (rev 285733)
@@ -43,7 +43,7 @@
 from webkitcorepy.editor import Editor
 from webkitcorepy.file_lock import FileLock
 
-version = Version(0, 11, 3)
+version = Version(0, 11, 4)
 
 from webkitcorepy.autoinstall import Package, AutoInstall
 if sys.version_info > (3, 0):


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py (285732 => 285733)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py	2021-11-12 19:02:40 UTC (rev 285732)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py	2021-11-12 19:13:03 UTC (rev 285733)
@@ -221,8 +221,8 @@
 json['author'] = dict(user=dict(displayName='Tim Committer', emailAddress='commit...@webkit.org'))
 json['participants'] = [json['author']]
 json['id'] = 1 + max([0] + [pr.get('id', 0) for pr in self.pull_requests])
-json['fromRef']['displayId'] = json['fromRef']['id'].split('/')[-2:]
-json['toRef']['displayId'] = json['toRef']['id'].split('/')[-2:]
+json['fromRef']['displayId'] = '/'.join(json['fromRef']['id'].split('/')[-2:])
+json['toRef']['displayId'] = '/'.join(json['toRef']['id'].split('/')[-2:])
 json['state'] = 'OPEN'
 json['activities'] = []
 self.pull_requests.append(json)
@@ -240,6 +240,8 @@
 return mocks.Response.create404(url)
   

[webkit-changes] [285732] trunk

[commit-queue]

Title: [285732] trunk








Revision 285732
Author commit-qu...@webkit.org
Date 2021-11-12 11:02:40 -0800 (Fri, 12 Nov 2021)


Log Message
Null check host in SlotAssignment::assignSlots
https://bugs.webkit.org/show_bug.cgi?id=230899

Patch by Rob Buis  on 2021-11-12
Reviewed by Darin Adler.

Source/WebCore:

Null check host in SlotAssignment::assignSlots.

Tests: fast/shadow-dom/shadow-root-gc-crash.html

* dom/SlotAssignment.cpp:
(WebCore::SlotAssignment::assignSlots):

LayoutTests:

* fast/shadow-dom/shadow-root-gc-crash-expected.txt: Added.
* fast/shadow-dom/shadow-root-gc-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/SlotAssignment.cpp


Added Paths

trunk/LayoutTests/fast/shadow-dom/shadow-root-gc-crash-expected.txt
trunk/LayoutTests/fast/shadow-dom/shadow-root-gc-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285731 => 285732)

--- trunk/LayoutTests/ChangeLog	2021-11-12 18:29:14 UTC (rev 285731)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 19:02:40 UTC (rev 285732)
@@ -1,3 +1,13 @@
+2021-11-12  Rob Buis  
+
+Null check host in SlotAssignment::assignSlots
+https://bugs.webkit.org/show_bug.cgi?id=230899
+
+Reviewed by Darin Adler.
+
+* fast/shadow-dom/shadow-root-gc-crash-expected.txt: Added.
+* fast/shadow-dom/shadow-root-gc-crash.html: Added.
+
 2021-11-12  Antoine Quint  
 
 [Web Animations] Accelerated animations with a single keyframe don't account for prior forward-filling animations


Added: trunk/LayoutTests/fast/shadow-dom/shadow-root-gc-crash-expected.txt (0 => 285732)

--- trunk/LayoutTests/fast/shadow-dom/shadow-root-gc-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/shadow-root-gc-crash-expected.txt	2021-11-12 19:02:40 UTC (rev 285732)
@@ -0,0 +1 @@
+PASS


Added: trunk/LayoutTests/fast/shadow-dom/shadow-root-gc-crash.html (0 => 285732)

--- trunk/LayoutTests/fast/shadow-dom/shadow-root-gc-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/shadow-dom/shadow-root-gc-crash.html	2021-11-12 19:02:40 UTC (rev 285732)
@@ -0,0 +1,15 @@
+
+  _onload_ = () => {
+if (window.testRunner)
+  testRunner.dumpAsText();
+let div0 = document.createElement('div');
+div0.appendChild(document.createElement('slot'));
+div0.appendChild(document.createElement('slot'));
+let div1 = document.createElement('div');
+div1.attachShadow({mode: 'open'}).appendChild(div0);
+div1.appendChild(document.createElement('div'));
+div0.appendChild(document.createElement('div'));
+window.GCController?.collect();
+document.write("PASS");
+  };
+


Modified: trunk/Source/WebCore/ChangeLog (285731 => 285732)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 18:29:14 UTC (rev 285731)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 19:02:40 UTC (rev 285732)
@@ -1,3 +1,17 @@
+2021-11-12  Rob Buis  
+
+Null check host in SlotAssignment::assignSlots
+https://bugs.webkit.org/show_bug.cgi?id=230899
+
+Reviewed by Darin Adler.
+
+Null check host in SlotAssignment::assignSlots.
+
+Tests: fast/shadow-dom/shadow-root-gc-crash.html
+
+* dom/SlotAssignment.cpp:
+(WebCore::SlotAssignment::assignSlots):
+
 2021-11-12  Chris Dumez  
 
 Disable MathML when in Captive Portal Mode


Modified: trunk/Source/WebCore/dom/SlotAssignment.cpp (285731 => 285732)

--- trunk/Source/WebCore/dom/SlotAssignment.cpp	2021-11-12 18:29:14 UTC (rev 285731)
+++ trunk/Source/WebCore/dom/SlotAssignment.cpp	2021-11-12 19:02:40 UTC (rev 285732)
@@ -356,12 +356,13 @@
 for (auto& entry : m_slots)
 entry.value->assignedNodes.shrink(0);
 
-auto& host = *shadowRoot.host();
-for (auto* child = host.firstChild(); child; child = child->nextSibling()) {
-if (!is(*child) && !is(*child))
-continue;
-auto slotName = slotNameForHostChild(*child);
-assignToSlot(*child, slotName);
+if (auto* host = shadowRoot.host()) {
+for (auto* child = host->firstChild(); child; child = child->nextSibling()) {
+if (!is(*child) && !is(*child))
+continue;
+auto slotName = slotNameForHostChild(*child);
+assignToSlot(*child, slotName);
+}
 }
 
 for (auto& entry : m_slots)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285731] trunk

[cdumez]

Title: [285731] trunk








Revision 285731
Author cdu...@apple.com
Date 2021-11-12 10:29:14 -0800 (Fri, 12 Nov 2021)


Log Message
Disable MathML when in Captive Portal Mode
https://bugs.webkit.org/show_bug.cgi?id=233013


Reviewed by Brent Fulgham.

Source/WebCore:

Add runtime feature flag for MathML and update implementation in WebCore to only support
MathML when the flag is on.

* bindings/js/WebCoreBuiltinNames.h:
* dom/Document.cpp:
(WebCore::Document::createElement):
* mathml/MathMLElement.idl:
* mathml/MathMLMathElement.idl:

Source/WebKit:

Turn off MathML support when in Captive Portal Mode.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Source/WTF:

Add runtime feature flag for MathML.

* Scripts/Preferences/WebPreferences.yaml:

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/mathml/MathMLElement.idl
trunk/Source/WebCore/mathml/MathMLMathElement.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (285730 => 285731)

--- trunk/Source/WTF/ChangeLog	2021-11-12 18:15:56 UTC (rev 285730)
+++ trunk/Source/WTF/ChangeLog	2021-11-12 18:29:14 UTC (rev 285731)
@@ -1,5 +1,17 @@
 2021-11-12  Chris Dumez  
 
+Disable MathML when in Captive Portal Mode
+https://bugs.webkit.org/show_bug.cgi?id=233013
+
+
+Reviewed by Brent Fulgham.
+
+Add runtime feature flag for MathML.
+
+* Scripts/Preferences/WebPreferences.yaml:
+
+2021-11-12  Chris Dumez  
+
 Unreviewed, partial revert of r285565 to resolve a PLT5 regression.
 
 


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (285730 => 285731)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml	2021-11-12 18:15:56 UTC (rev 285730)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml	2021-11-12 18:29:14 UTC (rev 285731)
@@ -1340,6 +1340,17 @@
 WebCore:
   default: false
 
+MathMLEnabled:
+  type: bool
+  condition: ENABLE(MATHML)
+  defaultValue:
+WebKitLegacy:
+  default: true
+WebKit:
+  default: true
+WebCore:
+  default: true
+
 MaxParseDuration:
   type: double
   webKitLegacyPreferenceKey: WebKitMaxParseDurationPreferenceKey


Modified: trunk/Source/WebCore/ChangeLog (285730 => 285731)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 18:15:56 UTC (rev 285730)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 18:29:14 UTC (rev 285731)
@@ -1,3 +1,20 @@
+2021-11-12  Chris Dumez  
+
+Disable MathML when in Captive Portal Mode
+https://bugs.webkit.org/show_bug.cgi?id=233013
+
+
+Reviewed by Brent Fulgham.
+
+Add runtime feature flag for MathML and update implementation in WebCore to only support
+MathML when the flag is on.
+
+* bindings/js/WebCoreBuiltinNames.h:
+* dom/Document.cpp:
+(WebCore::Document::createElement):
+* mathml/MathMLElement.idl:
+* mathml/MathMLMathElement.idl:
+
 2021-11-11  Mark Lam  
 
 Refactor allocateCell() and tryAllocateCell() to take VM& instead of Heap&.


Modified: trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h (285730 => 285731)

--- trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h	2021-11-12 18:15:56 UTC (rev 285730)
+++ trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h	2021-11-12 18:29:14 UTC (rev 285731)
@@ -197,6 +197,8 @@
 macro(KeyframeEffect) \
 macro(Lock) \
 macro(LockManager) \
+macro(MathMLElement) \
+macro(MathMLMathElement) \
 macro(MediaCapabilities) \
 macro(MediaCapabilitiesInfo) \
 macro(MediaDevices) \


Modified: trunk/Source/WebCore/dom/Document.cpp (285730 => 285731)

--- trunk/Source/WebCore/dom/Document.cpp	2021-11-12 18:15:56 UTC (rev 285730)
+++ trunk/Source/WebCore/dom/Document.cpp	2021-11-12 18:29:14 UTC (rev 285731)
@@ -1256,7 +1256,7 @@
 } else if (name.namespaceURI() == SVGNames::svgNamespaceURI)
 element = SVGElementFactory::createElement(name, *this, createdByParser);
 #if ENABLE(MATHML)
-else if (name.namespaceURI() == MathMLNames::mathmlNamespaceURI)
+else if (settings().mathMLEnabled() && name.namespaceURI() == MathMLNames::mathmlNamespaceURI)
 element = MathMLElementFactory::createElement(name, *this, createdByParser);
 #endif
 


Modified: trunk/Source/WebCore/mathml/MathMLElement.idl (285730 => 285731)

--- trunk/Source/WebCore/mathml/MathMLElement.idl	2021-11-12 18:15:56 UTC (rev 285730)
+++ trunk/Source/WebCore/mathml/MathMLElement.idl	2021-11-12 18:29:14 UTC (rev 285731)
@@ -25,6 +25,7 @@
 
 [
 

[webkit-changes] [285729] trunk/Source/WebKit

[cdumez]

Title: [285729] trunk/Source/WebKit








Revision 285729
Author cdu...@apple.com
Date 2021-11-12 09:52:26 -0800 (Fri, 12 Nov 2021)


Log Message
Rename ProcessLauncherMac.mm to ProcessLauncherDarwin.mm
https://bugs.webkit.org/show_bug.cgi?id=233045

Reviewed by Brent Fulgham.

Rename ProcessLauncherMac.mm to ProcessLauncherDarwin.mm since this implementation is used by both macOS and iOS.
I chose the Darwin naming (as opposed to the Cocoa one) because the implementation only relies on libXPC and mach.

* SourcesCocoa.txt:
* UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm: Renamed from Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm.
(WebKit::serviceName):
(WebKit::shouldLeakBoost):
(WebKit::systemDirectoryPath):
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):
(WebKit::ProcessLauncher::terminateXPCConnection):
(WebKit::terminateWithReason):
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/UIProcess/Launcher/darwin/
trunk/Source/WebKit/UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm


Removed Paths

trunk/Source/WebKit/UIProcess/Launcher/mac/




Diff

Modified: trunk/Source/WebKit/ChangeLog (285728 => 285729)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 17:40:47 UTC (rev 285728)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 17:52:26 UTC (rev 285729)
@@ -1,5 +1,27 @@
 2021-11-12  Chris Dumez  
 
+Rename ProcessLauncherMac.mm to ProcessLauncherDarwin.mm
+https://bugs.webkit.org/show_bug.cgi?id=233045
+
+Reviewed by Brent Fulgham.
+
+Rename ProcessLauncherMac.mm to ProcessLauncherDarwin.mm since this implementation is used by both macOS and iOS.
+I chose the Darwin naming (as opposed to the Cocoa one) because the implementation only relies on libXPC and mach.
+
+* SourcesCocoa.txt:
+* UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm: Renamed from Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm.
+(WebKit::serviceName):
+(WebKit::shouldLeakBoost):
+(WebKit::systemDirectoryPath):
+(WebKit::ProcessLauncher::launchProcess):
+(WebKit::ProcessLauncher::terminateProcess):
+(WebKit::ProcessLauncher::platformInvalidate):
+(WebKit::ProcessLauncher::terminateXPCConnection):
+(WebKit::terminateWithReason):
+* WebKit.xcodeproj/project.pbxproj:
+
+2021-11-12  Chris Dumez  
+
 Unreviewed, partial revert of r285565 to resolve a PLT5 regression.
 
 


Modified: trunk/Source/WebKit/SourcesCocoa.txt (285728 => 285729)

--- trunk/Source/WebKit/SourcesCocoa.txt	2021-11-12 17:40:47 UTC (rev 285728)
+++ trunk/Source/WebKit/SourcesCocoa.txt	2021-11-12 17:52:26 UTC (rev 285729)
@@ -511,7 +511,7 @@
 UIProcess/ios/WKUSDPreviewView.mm
 UIProcess/ios/WKWebEvent.mm
 
-UIProcess/Launcher/mac/ProcessLauncherMac.mm
+UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm
 
 UIProcess/mac/CorrectionPanel.mm
 UIProcess/mac/DisplayLink.cpp


Copied: trunk/Source/WebKit/UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm (from rev 285728, trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm) (0 => 285729)

--- trunk/Source/WebKit/UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm	(rev 0)
+++ trunk/Source/WebKit/UIProcess/Launcher/darwin/ProcessLauncherDarwin.mm	2021-11-12 17:52:26 UTC (rev 285729)
@@ -0,0 +1,358 @@
+/*
+ * Copyright (C) 2010-2021 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#import "config.h"
+#import 

[webkit-changes] [285728] trunk

[graouts]

Title: [285728] trunk








Revision 285728
Author grao...@webkit.org
Date 2021-11-12 09:40:47 -0800 (Fri, 12 Nov 2021)


Log Message
[Web Animations] Accelerated animations with a single keyframe don't account for prior forward-filling animations
https://bugs.webkit.org/show_bug.cgi?id=233041


Reviewed by Dean Jackson.

Source/WebCore:

Test: webanimations/accelerated-animation-after-forward-filling-animation.html

When starting an accelerated animation, we would fill any implicit keyframes based on the unanimated style.
We now also apply all animations below this animation in the target's effect stack such that a previous
forward-filling animation is accounted for.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):

LayoutTests:

Add a new test that runs a forward-filling animation for `transform`, waits for its completion,
then runs another `transform` animation with an implicit initial keyframe, ensuring that the
result of the first forward-filling animation is accounted for when computing the initial
keyframe.

This test would fail prior to this patch.

* webanimations/accelerated-animation-after-forward-filling-animation-expected.html: Added.
* webanimations/accelerated-animation-after-forward-filling-animation.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/KeyframeEffect.cpp


Added Paths

trunk/LayoutTests/webanimations/accelerated-animation-after-forward-filling-animation-expected.html
trunk/LayoutTests/webanimations/accelerated-animation-after-forward-filling-animation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285727 => 285728)

--- trunk/LayoutTests/ChangeLog	2021-11-12 17:37:01 UTC (rev 285727)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 17:40:47 UTC (rev 285728)
@@ -1,3 +1,21 @@
+2021-11-12  Antoine Quint  
+
+[Web Animations] Accelerated animations with a single keyframe don't account for prior forward-filling animations
+https://bugs.webkit.org/show_bug.cgi?id=233041
+
+
+Reviewed by Dean Jackson.
+
+Add a new test that runs a forward-filling animation for `transform`, waits for its completion,
+then runs another `transform` animation with an implicit initial keyframe, ensuring that the
+result of the first forward-filling animation is accounted for when computing the initial
+keyframe.
+
+This test would fail prior to this patch.
+
+* webanimations/accelerated-animation-after-forward-filling-animation-expected.html: Added.
+* webanimations/accelerated-animation-after-forward-filling-animation.html: Added.
+
 2021-11-12  Patrick Angle  
 
 Web Inspector: Mark inspector/page/setShowPaintRects.html as flakey in test expectations for Mac


Added: trunk/LayoutTests/webanimations/accelerated-animation-after-forward-filling-animation-expected.html (0 => 285728)

--- trunk/LayoutTests/webanimations/accelerated-animation-after-forward-filling-animation-expected.html	(rev 0)
+++ trunk/LayoutTests/webanimations/accelerated-animation-after-forward-filling-animation-expected.html	2021-11-12 17:40:47 UTC (rev 285728)
@@ -0,0 +1,17 @@
+
+
+
+
+#target {
+position: absolute;
+left: 0;
+top: 0;
+width: 100px;
+height: 100px;
+background-color: black;
+transform: translateX(100px);
+}
+
+
+
+


Added: trunk/LayoutTests/webanimations/accelerated-animation-after-forward-filling-animation.html (0 => 285728)

--- trunk/LayoutTests/webanimations/accelerated-animation-after-forward-filling-animation.html	(rev 0)
+++ trunk/LayoutTests/webanimations/accelerated-animation-after-forward-filling-animation.html	2021-11-12 17:40:47 UTC (rev 285728)
@@ -0,0 +1,41 @@
+
+
+
+
+#target {
+position: absolute;
+left: 0;
+top: 0;
+width: 100px;
+height: 100px;
+background-color: black;
+}
+
+
+
+
+
+(async () => {
+if (window.testRunner)
+window.testRunner.waitUntilDone();
+
+const target = document.getElementById("target");
+
+// Start a forward-filling accelerated animation.
+const fillingAnimation = target.animate({ transform: "translateX(100px)" }, { duration: 1, fill: "forwards" });
+await fillingAnimation.finished;
+
+// Start another animation with an implicit from keyframe.
+const animation = target.animate({ transform: "translateY(1px)" }, { duration: 1000 * 1000 });
+
+// Wait two frames for the accelerated animation to be committed.
+await animation.ready;
+await new Promise(requestAnimationFrame);
+await new Promise(requestAnimationFrame);
+
+if (window.testRunner)
+window.testRunner.notifyDone();
+})();
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (285727 => 285728)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 17:37:01 UTC (rev 285727)
+++ 

[webkit-changes] [285727] trunk/LayoutTests

[pangle]

Title: [285727] trunk/LayoutTests








Revision 285727
Author pan...@apple.com
Date 2021-11-12 09:37:01 -0800 (Fri, 12 Nov 2021)


Log Message
Web Inspector: Mark inspector/page/setShowPaintRects.html as flakey in test expectations for Mac
https://bugs.webkit.org/show_bug.cgi?id=233048

Unreviewed test gardening.


* platform/mac/TestExpectations: Add expectation for inspector/page/setShowPaintRects.html while the flakey
failure is investigated.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285726 => 285727)

--- trunk/LayoutTests/ChangeLog	2021-11-12 16:53:57 UTC (rev 285726)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 17:37:01 UTC (rev 285727)
@@ -1,3 +1,13 @@
+2021-11-12  Patrick Angle  
+
+Web Inspector: Mark inspector/page/setShowPaintRects.html as flakey in test expectations for Mac
+https://bugs.webkit.org/show_bug.cgi?id=233048
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations: Add expectation for inspector/page/setShowPaintRects.html while the flakey
+failure is investigated. 
+
 2021-11-12  Chris Dumez  
 
 fast/dom/Geolocation/cached-position-iframe.html is frequently crashing on Mac-wk1


Modified: trunk/LayoutTests/platform/mac/TestExpectations (285726 => 285727)

--- trunk/LayoutTests/platform/mac/TestExpectations	2021-11-12 16:53:57 UTC (rev 285726)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2021-11-12 17:37:01 UTC (rev 285727)
@@ -2424,6 +2424,8 @@
 
 webkit.org/b/231924 inspector/css/modify-css-property.html [ Pass Failure ]
 
+webkit.org/b/233047 inspector/page/setShowPaintRects.html [ Pass Failure ]
+
 # Plugins
 # FIXME: Remove these tests.
 platform/mac/plugins/testplugin-onnew-onpaint.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285726] trunk/Source

[cdumez]

Title: [285726] trunk/Source








Revision 285726
Author cdu...@apple.com
Date 2021-11-12 08:53:57 -0800 (Fri, 12 Nov 2021)


Log Message
Unreviewed, partial revert of r285565 to resolve a PLT5 regression.


Source/WebKit:

* NetworkProcess/cocoa/NetworkSessionCocoa.h:
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::NetworkSessionCocoa::isolatedSession):
(WebKit::SessionSet::isolatedSession):
(WebKit::NetworkSessionCocoa::hasIsolatedSession const):
(WebKit::NetworkSessionCocoa::clearIsolatedSessions):
(WebKit::NetworkSessionCocoa::invalidateAndCancelSessionSet):

Source/WTF:

* wtf/PlatformHave.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (285725 => 285726)

--- trunk/Source/WTF/ChangeLog	2021-11-12 16:52:20 UTC (rev 285725)
+++ trunk/Source/WTF/ChangeLog	2021-11-12 16:53:57 UTC (rev 285726)
@@ -1,3 +1,10 @@
+2021-11-12  Chris Dumez  
+
+Unreviewed, partial revert of r285565 to resolve a PLT5 regression.
+
+
+* wtf/PlatformHave.h:
+
 2021-11-11  Michael Saboff  
 
 Inline RegExp.test JIT code in DFG and FTL


Modified: trunk/Source/WTF/wtf/PlatformHave.h (285725 => 285726)

--- trunk/Source/WTF/wtf/PlatformHave.h	2021-11-12 16:52:20 UTC (rev 285725)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2021-11-12 16:53:57 UTC (rev 285726)
@@ -958,7 +958,6 @@
 || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 15)
 #define HAVE_CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER 1
 #define HAVE_CFNETWORK_NSURLSESSION_HSTS_WITH_UNTRUSTED_ROOT 1
-#define HAVE_CFNETWORK_SESSION_PARTITIONING_BASED_ON_FIRST_PARTY_DOMAIN 1
 #define HAVE_AUDIO_OBJECT_PROPERTY_ELEMENT_MAIN 1
 #define HAVE_IMAGE_RESTRICTED_DECODING 1
 #define HAVE_XPC_CONNECTION_COPY_INVALIDATION_REASON 1


Modified: trunk/Source/WebKit/ChangeLog (285725 => 285726)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 16:52:20 UTC (rev 285725)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 16:53:57 UTC (rev 285726)
@@ -1,3 +1,17 @@
+2021-11-12  Chris Dumez  
+
+Unreviewed, partial revert of r285565 to resolve a PLT5 regression.
+
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.h:
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
+(WebKit::NetworkSessionCocoa::isolatedSession):
+(WebKit::SessionSet::isolatedSession):
+(WebKit::NetworkSessionCocoa::hasIsolatedSession const):
+(WebKit::NetworkSessionCocoa::clearIsolatedSessions):
+(WebKit::NetworkSessionCocoa::invalidateAndCancelSessionSet):
+
 2021-11-12  Adrian Perez de Castro  
 
 Some C++ source files use #pragma once


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h (285725 => 285726)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h	2021-11-12 16:52:20 UTC (rev 285725)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h	2021-11-12 16:53:57 UTC (rev 285726)
@@ -81,10 +81,8 @@
 
 SessionWrapper& initializeEphemeralStatelessSessionIfNeeded(NavigatingToAppBoundDomain, NetworkSessionCocoa&);
 
-#if !HAVE(CFNETWORK_SESSION_PARTITIONING_BASED_ON_FIRST_PARTY_DOMAIN)
 SessionWrapper& isolatedSession(WebCore::StoredCredentialsPolicy, const WebCore::RegistrableDomain&, NavigatingToAppBoundDomain, NetworkSessionCocoa&);
 HashMap> isolatedSessions;
-#endif
 
 std::unique_ptr appBoundSession;
 


Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (285725 => 285726)

--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2021-11-12 16:52:20 UTC (rev 285725)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2021-11-12 16:53:57 UTC (rev 285726)
@@ -1419,8 +1419,8 @@
 auto shouldBeConsideredAppBound = isNavigatingToAppBoundDomain ? *isNavigatingToAppBoundDomain : NavigatingToAppBoundDomain::Yes;
 if (isParentProcessAFullWebBrowser(networkProcess()))
 shouldBeConsideredAppBound = NavigatingToAppBoundDomain::No;
-// This ITP partitioning is unnecessary on newer platforms since CFNetwork already has full partioning based on first-party domains.
-#if ENABLE(INTELLIGENT_TRACKING_PREVENTION) && !HAVE(CFNETWORK_SESSION_PARTITIONING_BASED_ON_FIRST_PARTY_DOMAIN)
+
+#if ENABLE(INTELLIGENT_TRACKING_PREVENTION)
 if (auto* storageSession = networkStorageSession()) {
 auto firstParty = WebCore::RegistrableDomain(request.firstPartyForCookies());
 if (storageSession->shouldBlockThirdPartyCookiesButKeepFirstPartyCookiesFor(firstParty))
@@ -1493,14 +1493,11 @@
 }
 #endif
 
-#if !HAVE(CFNETWORK_SESSION_PARTITIONING_BASED_ON_FIRST_PARTY_DOMAIN)
 SessionWrapper& 

[webkit-changes] [285725] trunk/Source/WebCore

[wenson_hsieh]

Title: [285725] trunk/Source/WebCore








Revision 285725
Author wenson_hs...@apple.com
Date 2021-11-12 08:52:20 -0800 (Fri, 12 Nov 2021)


Log Message
Move subtree update logic in ImageOverlay::updateWithTextRecognitionResult() into a separate helper
https://bugs.webkit.org/show_bug.cgi?id=233010

Reviewed by Aditya Keerthi.

Split `updateWithTextRecognitionResult()` into two phases: the first of which updates the UA shadow DOM to
reflect the given text recognition results, and a second phase that updates inline styles for each of the image
overlay elements by mapping normalized OCR quads onto rotated bounding rects in client coordinates. This will
make it easier to add support for representing `TextRecognitionBlockData` as image overlay content in the next
patch.

* dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::imageOverlayLineClass):
(WebCore::ImageOverlay::imageOverlayTextClass):
(WebCore::ImageOverlay::updateSubtree):

Now that this is all namespaced inside `ImageOverlay`, we can also simplify some of these names. Instead of
TextRecognitionLineElements and TextRecognitionElements, we can just call them LineElements and Elements.

(WebCore::ImageOverlay::updateWithTextRecognitionResult):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ImageOverlay.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285724 => 285725)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 16:39:49 UTC (rev 285724)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 16:52:20 UTC (rev 285725)
@@ -1,3 +1,26 @@
+2021-11-12  Wenson Hsieh  
+
+Move subtree update logic in ImageOverlay::updateWithTextRecognitionResult() into a separate helper
+https://bugs.webkit.org/show_bug.cgi?id=233010
+
+Reviewed by Aditya Keerthi.
+
+Split `updateWithTextRecognitionResult()` into two phases: the first of which updates the UA shadow DOM to
+reflect the given text recognition results, and a second phase that updates inline styles for each of the image
+overlay elements by mapping normalized OCR quads onto rotated bounding rects in client coordinates. This will
+make it easier to add support for representing `TextRecognitionBlockData` as image overlay content in the next
+patch.
+
+* dom/ImageOverlay.cpp:
+(WebCore::ImageOverlay::imageOverlayLineClass):
+(WebCore::ImageOverlay::imageOverlayTextClass):
+(WebCore::ImageOverlay::updateSubtree):
+
+Now that this is all namespaced inside `ImageOverlay`, we can also simplify some of these names. Instead of
+TextRecognitionLineElements and TextRecognitionElements, we can just call them LineElements and Elements.
+
+(WebCore::ImageOverlay::updateWithTextRecognitionResult):
+
 2021-11-12  Adrian Perez de Castro  
 
 Some C++ source files use #pragma once


Modified: trunk/Source/WebCore/dom/ImageOverlay.cpp (285724 => 285725)

--- trunk/Source/WebCore/dom/ImageOverlay.cpp	2021-11-12 16:39:49 UTC (rev 285724)
+++ trunk/Source/WebCore/dom/ImageOverlay.cpp	2021-11-12 16:52:20 UTC (rev 285725)
@@ -69,6 +69,22 @@
 return className;
 }
 
+#if ENABLE(IMAGE_ANALYSIS)
+
+static const AtomString& imageOverlayLineClass()
+{
+static MainThreadNeverDestroyed className("image-overlay-line", AtomString::ConstructFromLiteral);
+return className;
+}
+
+static const AtomString& imageOverlayTextClass()
+{
+static MainThreadNeverDestroyed className("image-overlay-text", AtomString::ConstructFromLiteral);
+return className;
+}
+
+#endif // ENABLE(IMAGE_ANALYSIS)
+
 bool hasOverlay(const HTMLElement& element)
 {
 auto shadowRoot = element.shadowRoot();
@@ -166,24 +182,21 @@
 return enclosingIntRect(downcast(*renderer).replacedContentRect());
 }
 
-void updateWithTextRecognitionResult(HTMLElement& element, const TextRecognitionResult& result, CacheTextRecognitionResults cacheTextRecognitionResults)
-{
-static MainThreadNeverDestroyed imageOverlayLineClass("image-overlay-line", AtomString::ConstructFromLiteral);
-static MainThreadNeverDestroyed imageOverlayTextClass("image-overlay-text", AtomString::ConstructFromLiteral);
+struct LineElements {
+Ref line;
+Vector> children;
+};
 
-struct TextRecognitionLineElements {
-Ref line;
-Vector> children;
-};
+struct Elements {
+RefPtr root;
+Vector lines;
+Vector> dataDetectors;
+};
 
-struct TextRecognitionElements {
-RefPtr root;
-Vector lines;
-Vector> dataDetectors;
-};
-
-bool hadExistingTextRecognitionElements = false;
-TextRecognitionElements textRecognitionElements;
+static Elements updateSubtree(HTMLElement& element, const TextRecognitionResult& result)
+{
+bool hadExistingElements = false;
+Elements elements;
 RefPtr mediaControlsContainer;
 if (RefPtr shadowRoot = element.shadowRoot()) {
 #if ENABLE(MODERN_MEDIA_CONTROLS)
@@ -207,8 +220,8 @@
 containerForImageOverlay = 

[webkit-changes] [285724] trunk/Source

[aperez]

Title: [285724] trunk/Source








Revision 285724
Author ape...@igalia.com
Date 2021-11-12 08:39:49 -0800 (Fri, 12 Nov 2021)


Log Message
Some C++ source files use #pragma once
https://bugs.webkit.org/show_bug.cgi?id=233040

Source/WebCore:

Reviewed by Chris Dumez.

Remove spurious usage of "#pragma once" in implementation files.

No new tests needed.

* Modules/WebGPU/GPUBuffer.cpp:
* Modules/WebGPU/GPUCommandEncoder.cpp:
* Modules/WebGPU/GPUComputePassEncoder.cpp:
* Modules/WebGPU/GPUQuerySet.cpp:
* Modules/WebGPU/GPUQueue.cpp:
* Modules/WebGPU/GPURenderBundleEncoder.cpp:
* Modules/WebGPU/GPURenderPassEncoder.cpp:
* page/PerformanceNavigationTiming.cpp:

Source/WebKit:

Remove spurious usage of "#pragma once" in implementation files.

Reviewed by Chris Dumez.

* WebProcess/WebCoreSupport/WebCaptionPreferencesDelegate.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
trunk/Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp
trunk/Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp
trunk/Source/WebCore/Modules/WebGPU/GPUQuerySet.cpp
trunk/Source/WebCore/Modules/WebGPU/GPUQueue.cpp
trunk/Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp
trunk/Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp
trunk/Source/WebCore/page/PerformanceNavigationTiming.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebCaptionPreferencesDelegate.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285723 => 285724)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 16:38:59 UTC (rev 285723)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 16:39:49 UTC (rev 285724)
@@ -1,3 +1,23 @@
+2021-11-12  Adrian Perez de Castro  
+
+Some C++ source files use #pragma once
+https://bugs.webkit.org/show_bug.cgi?id=233040
+
+Reviewed by Chris Dumez.
+
+Remove spurious usage of "#pragma once" in implementation files.
+
+No new tests needed.
+
+* Modules/WebGPU/GPUBuffer.cpp:
+* Modules/WebGPU/GPUCommandEncoder.cpp:
+* Modules/WebGPU/GPUComputePassEncoder.cpp:
+* Modules/WebGPU/GPUQuerySet.cpp:
+* Modules/WebGPU/GPUQueue.cpp:
+* Modules/WebGPU/GPURenderBundleEncoder.cpp:
+* Modules/WebGPU/GPURenderPassEncoder.cpp:
+* page/PerformanceNavigationTiming.cpp:
+
 2021-11-12  Philippe Normand  
 
 [GLib] Developer build with release logs disabled fails


Modified: trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.cpp (285723 => 285724)

--- trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.cpp	2021-11-12 16:38:59 UTC (rev 285723)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUBuffer.cpp	2021-11-12 16:39:49 UTC (rev 285724)
@@ -23,8 +23,6 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#pragma once
-
 #include "config.h"
 #include "GPUBuffer.h"
 


Modified: trunk/Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp (285723 => 285724)

--- trunk/Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp	2021-11-12 16:38:59 UTC (rev 285723)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUCommandEncoder.cpp	2021-11-12 16:39:49 UTC (rev 285724)
@@ -23,8 +23,6 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#pragma once
-
 #include "config.h"
 #include "GPUCommandEncoder.h"
 


Modified: trunk/Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp (285723 => 285724)

--- trunk/Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp	2021-11-12 16:38:59 UTC (rev 285723)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUComputePassEncoder.cpp	2021-11-12 16:39:49 UTC (rev 285724)
@@ -23,8 +23,6 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#pragma once
-
 #include "config.h"
 #include "GPUComputePassEncoder.h"
 


Modified: trunk/Source/WebCore/Modules/WebGPU/GPUQuerySet.cpp (285723 => 285724)

--- trunk/Source/WebCore/Modules/WebGPU/GPUQuerySet.cpp	2021-11-12 16:38:59 UTC (rev 285723)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUQuerySet.cpp	2021-11-12 16:39:49 UTC (rev 285724)
@@ -23,8 +23,6 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#pragma once
-
 #include "config.h"
 #include "GPUQuerySet.h"
 


Modified: trunk/Source/WebCore/Modules/WebGPU/GPUQueue.cpp (285723 => 285724)

--- trunk/Source/WebCore/Modules/WebGPU/GPUQueue.cpp	2021-11-12 16:38:59 UTC (rev 285723)
+++ trunk/Source/WebCore/Modules/WebGPU/GPUQueue.cpp	2021-11-12 16:39:49 UTC (rev 285724)
@@ -23,8 +23,6 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#pragma once
-
 #include "config.h"
 #include "GPUQueue.h"
 


Modified: trunk/Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp (285723 => 285724)

--- trunk/Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp	2021-11-12 16:38:59 UTC (rev 285723)
+++ trunk/Source/WebCore/Modules/WebGPU/GPURenderBundleEncoder.cpp	2021-11-12 16:39:49 UTC (rev 285724)
@@ -23,8 +23,6 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#pragma once
-
 #include "config.h"
 #include "GPURenderBundleEncoder.h"
 


Modified: trunk/Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.cpp 

[webkit-changes] [285723] trunk/Source/WebKit

[pvollan]

Title: [285723] trunk/Source/WebKit








Revision 285723
Author pvol...@apple.com
Date 2021-11-12 08:38:59 -0800 (Fri, 12 Nov 2021)


Log Message
[macOS][GPUP] Remove sandbox write access to files
https://bugs.webkit.org/show_bug.cgi?id=232247


Reviewed by Brent Fulgham.

Based on telemetry, remove sandbox write access to files in the GPU process on macOS.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (285722 => 285723)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 16:32:32 UTC (rev 285722)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 16:38:59 UTC (rev 285723)
@@ -1,5 +1,17 @@
 2021-11-12  Per Arne Vollan 
 
+[macOS][GPUP] Remove sandbox write access to files
+https://bugs.webkit.org/show_bug.cgi?id=232247
+
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, remove sandbox write access to files in the GPU process on macOS.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+
+2021-11-12  Per Arne Vollan 
+
 [iOS][GPU] Remove access to IOKit classes
 https://bugs.webkit.org/show_bug.cgi?id=232344
 


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (285722 => 285723)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-12 16:32:32 UTC (rev 285722)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-12 16:38:59 UTC (rev 285723)
@@ -74,21 +74,9 @@
 (literal "/dev/random")
 (literal "/private/etc/passwd"))
 
-(allow file-write-data (with telemetry)
-(literal "/dev/null")
-(literal "/dev/zero"))
-
-(allow file-read*
+(allow file-read* file-write-data file-ioctl
 (literal "/dev/dtracehelper"))
-(allow file-write-data
-   file-ioctl (with telemetry)
-(literal "/dev/dtracehelper"))
 
-;;; Allow creation of core dumps.
-(allow file-write-create (with telemetry)
-(require-all (prefix "/cores/")
-(vnode-type REGULAR-FILE)))
-
 ;;; Allow IPC to standard system agents.
 (allow ipc-posix-shm-read* (with telemetry)
 #if !ENABLE(CFPREFS_DIRECT_MODE)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285722] trunk/Source/WebKit

[pvollan]

Title: [285722] trunk/Source/WebKit








Revision 285722
Author pvol...@apple.com
Date 2021-11-12 08:32:32 -0800 (Fri, 12 Nov 2021)


Log Message
[iOS][GPU] Remove access to IOKit classes
https://bugs.webkit.org/show_bug.cgi?id=232344


Reviewed by Darin Adler.

Based on telemetry, remove access to unused IOKit classes in the GPU process' sandbox on iOS.

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb




Diff

Modified: trunk/Source/WebKit/ChangeLog (285721 => 285722)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 16:31:07 UTC (rev 285721)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 16:32:32 UTC (rev 285722)
@@ -1,3 +1,15 @@
+2021-11-12  Per Arne Vollan 
+
+[iOS][GPU] Remove access to IOKit classes
+https://bugs.webkit.org/show_bug.cgi?id=232344
+
+
+Reviewed by Darin Adler.
+
+Based on telemetry, remove access to unused IOKit classes in the GPU process' sandbox on iOS.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+
 2021-11-12  Per Arne  
 
 [macOS][GPUP] Add syscalls to sandbox


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (285721 => 285722)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-12 16:31:07 UTC (rev 285721)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2021-11-12 16:32:32 UTC (rev 285722)
@@ -65,21 +65,6 @@
 (home-literal (string-append "/Library/Preferences/" domain ".plist")
 domains))
 
-(define-once (framebuffer-access)
-(allow iokit-open (with telemetry)
-   (iokit-user-client-class "IOMobileFramebufferUserClient")
-   (when (defined? 'iokit-external-method)
-   (apply-message-filter
-   (deny (with telemetry)
-   iokit-async-external-method
-   iokit-external-trap)
-   (allow
-   iokit-external-method)
-   )
-   )
-)
-(mobile-preferences-read "com.apple.iokit.IOMobileGraphicsFamily"))
-
 (define-once (asset-access . options)
 (let ((asset-access-filter
 (require-all
@@ -207,21 +192,6 @@
 ;;; Declare that the application uses the OpenGL, Metal, and CoreML hardware & frameworks.
 ;;;
 (define-once (opengl)
-;; Items not seen in testing
-(deny iokit-open (with telemetry)
-   (iokit-connection "IOGPU")
-   (iokit-user-client-class
-"AGXCommandQueue"
-"AGXDevice"
-"AGXSharedUserClient"
-"IOAccelContext"
-"IOAccelDevice"
-"IOAccelSharedUserClient"
-"IOAccelSubmitter2"
-"IOAccelContext2"
-"IOAccelDevice2"
-"IOAccelSharedUserClient2"))
-
 (allow iokit-open (with telemetry)
(iokit-connection "IOGPU")
(iokit-user-client-class
@@ -305,7 +275,6 @@
 ; UIKit-required IOKit nodes.
 (allow iokit-open (with telemetry)
 (iokit-user-client-class "IOSurfaceAcceleratorClient")
-(iokit-user-client-class "IOSurfaceSendRight")
 ;; Requires by UIView -> UITextMagnifierRenderer -> UIWindow
 (iokit-user-client-class "IOSurfaceRootUserClient"))
 
@@ -535,8 +504,6 @@
 (home-literal "/Library/Caches/DateFormats.plist")
 (with no-log))
 
-(framebuffer-access)
-
 ;  , 
 (opengl)
 
@@ -689,24 +656,6 @@
 (deny file-write-create (vnode-type SYMLINK))
 (deny file-read-xattr file-write-xattr (xattr-prefix "com.apple.security.private."))
 
-(allow iokit-open (with telemetry)
-(require-all
-(extension "com.apple.webkit.extension.iokit")
-(iokit-user-client-class
-"AGXCommandQueue"
-"AGXDevice"
-"AGXSharedUserClient"
-"IOAccelContext"
-"IOAccelDevice"
-"IOAccelSharedUserClient"
-"IOAccelSubmitter2"
-"IOAccelContext2"
-"IOAccelDevice2"
-"IOAccelSharedUserClient2"
-)
-)
-)
-
 (deny mach-lookup (with no-log)
 (xpc-service-name "com.apple.audio.toolbox.reporting.service")
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285721] trunk/Source/WebKit

[pvollan]

Title: [285721] trunk/Source/WebKit








Revision 285721
Author pvol...@apple.com
Date 2021-11-12 08:31:07 -0800 (Fri, 12 Nov 2021)


Log Message
[macOS][GPUP] Add syscalls to sandbox
https://bugs.webkit.org/show_bug.cgi?id=232210


Reviewed by Brent Fulgham.

Based on telemetry, add syscalls to the GPU process' sandbox on macOS.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (285720 => 285721)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 16:18:51 UTC (rev 285720)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 16:31:07 UTC (rev 285721)
@@ -1,3 +1,15 @@
+2021-11-12  Per Arne  
+
+[macOS][GPUP] Add syscalls to sandbox
+https://bugs.webkit.org/show_bug.cgi?id=232210
+
+
+Reviewed by Brent Fulgham.
+
+Based on telemetry, add syscalls to the GPU process' sandbox on macOS.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+
 2021-11-12  Chris Dumez  
 
 WebKit is unable to recover if a WebProcess gets terminated while it is launching


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (285720 => 285721)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-12 16:18:51 UTC (rev 285720)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2021-11-12 16:31:07 UTC (rev 285721)
@@ -873,53 +873,97 @@
 (when (defined? 'syscall-unix)
 (allow syscall-unix (with telemetry))
 (allow syscall-unix (syscall-number
+SYS___channel_open
 SYS___disable_threadsignal
 SYS___mac_syscall
+SYS___pthread_kill
+SYS___pthread_sigmask
+SYS___semwait_signal
 SYS_access
 SYS_bsdthread_create
 SYS_bsdthread_ctl
 SYS_bsdthread_terminate
+SYS_change_fdguard_np
 SYS_csrctl
+SYS_dup
+SYS_exit
+SYS_faccessat
 SYS_fcntl
+SYS_fcntl_nocancel
+SYS_fgetxattr
 SYS_flock
 SYS_fsgetpath
 SYS_fstat
+SYS_fstat64
+SYS_fstatat64
 SYS_fstatfs
+SYS_fstatfs64
 SYS_ftruncate
 SYS_getattrlist
+SYS_getattrlistbulk
 SYS_getaudit_addr
 SYS_getdirentries
+SYS_getdirentries64
 SYS_getentropy
 SYS_geteuid
 SYS_getfsstat
+SYS_getfsstat64
 SYS_getgid
+SYS_getpriority
+SYS_getrlimit
+SYS_getrusage
 SYS_gettimeofday
 SYS_getuid
+SYS_getxattr
+SYS_issetugid
+SYS_kdebug_trace
+SYS_kdebug_trace64
+SYS_kdebug_trace_string
+SYS_kdebug_typefilter
 SYS_kevent_id
 SYS_kevent_qos
 SYS_kqueue_workloop_ctl
 SYS_lseek
 SYS_lstat
+SYS_lstat64
 SYS_madvise
+SYS_memorystatus_control
+SYS_mincore
 SYS_mkdir
+SYS_mlock
 SYS_mmap
 SYS_mprotect
+SYS_msync
+SYS_munlock
 SYS_munmap
+SYS_necp_client_action
+SYS_necp_open
 SYS_pathconf
+SYS_pread
+SYS_proc_rlimit_control
 SYS_psynch_cvbroad
+SYS_psynch_cvclrprepost
+SYS_psynch_cvsignal
 SYS_psynch_cvwait
 SYS_psynch_mutexdrop
 SYS_psynch_mutexwait
+SYS_psynch_rw_rdlock
 SYS_psynch_rw_unlock
 SYS_psynch_rw_wrlock
 SYS_read
 SYS_read_nocancel
+SYS_readlink
 SYS_rename
+SYS_sendto
+SYS_sigaltstack
+SYS_sigprocmask
+SYS_socket
 SYS_stat
+SYS_stat64
 SYS_statfs
+SYS_statfs64
 SYS_thread_selfid
 SYS_ulock_wait
 SYS_ulock_wake
 SYS_work_interval_ctl
-SYS_workq_kernreturn
 SYS_workq_kernreturn)))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285720] trunk

[cdumez]

Title: [285720] trunk








Revision 285720
Author cdu...@apple.com
Date 2021-11-12 08:18:51 -0800 (Fri, 12 Nov 2021)


Log Message
WebKit is unable to recover if a WebProcess gets terminated while it is launching
https://bugs.webkit.org/show_bug.cgi?id=233001


Reviewed by Brent Fulgham.

Source/WebKit:

While investigating , I found that the WebAuthn Process would get
jetsammed, which would cause us to call WebProcessPool::terminateAllWebContentProcesses().
I also noticed that if one of these WebProcesses was still launching at the time
of the termination, then the WebProcessProxy / WebPageProxy would keep thinking the
WebProcess is still launching and would never attempt to relaunch it. This would result
in a blank and unresponsive WKWebView which wouldn't be able to do any loads.

The issue was due to ProcessLauncher::terminateProcess() calling invalidate(), which
it would not only terminate the XPC connection, it would also null out m_client. As a
result, we wouldn't notify the client that the process failed to launch. To address
the issue, I move the XPC connection termination logic out of invalidate() and into
its own terminateXPCConnection() function. I then called terminateXPCConnection()
instead of invalidate() inside ProcessLauncher::terminateProcess().

* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _terminateAllWebContentProcesses]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::invalidate):
* UIProcess/Launcher/ProcessLauncher.h:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::terminateProcess):
(WebKit::ProcessLauncher::platformInvalidate):
(WebKit::ProcessLauncher::terminateXPCConnection):

Tools:

Add API test coverage, this test was timing out before the fix.

* TestWebKitAPI/Tests/WebKitCocoa/WebProcessTerminate.mm:
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
trunk/Source/WebKit/UIProcess/Launcher/ProcessLauncher.cpp
trunk/Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessTerminate.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (285719 => 285720)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 15:59:24 UTC (rev 285719)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 16:18:51 UTC (rev 285720)
@@ -1,5 +1,38 @@
 2021-11-12  Chris Dumez  
 
+WebKit is unable to recover if a WebProcess gets terminated while it is launching
+https://bugs.webkit.org/show_bug.cgi?id=233001
+
+
+Reviewed by Brent Fulgham.
+
+While investigating , I found that the WebAuthn Process would get
+jetsammed, which would cause us to call WebProcessPool::terminateAllWebContentProcesses().
+I also noticed that if one of these WebProcesses was still launching at the time
+of the termination, then the WebProcessProxy / WebPageProxy would keep thinking the
+WebProcess is still launching and would never attempt to relaunch it. This would result
+in a blank and unresponsive WKWebView which wouldn't be able to do any loads.
+
+The issue was due to ProcessLauncher::terminateProcess() calling invalidate(), which
+it would not only terminate the XPC connection, it would also null out m_client. As a
+result, we wouldn't notify the client that the process failed to launch. To address
+the issue, I move the XPC connection termination logic out of invalidate() and into
+its own terminateXPCConnection() function. I then called terminateXPCConnection()
+instead of invalidate() inside ProcessLauncher::terminateProcess().
+
+* UIProcess/API/Cocoa/WKProcessPool.mm:
+(-[WKProcessPool _terminateAllWebContentProcesses]):
+* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
+* UIProcess/Launcher/ProcessLauncher.cpp:
+(WebKit::ProcessLauncher::invalidate):
+* UIProcess/Launcher/ProcessLauncher.h:
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::ProcessLauncher::terminateProcess):
+(WebKit::ProcessLauncher::platformInvalidate):
+(WebKit::ProcessLauncher::terminateXPCConnection):
+
+2021-11-12  Chris Dumez  
+
 Disable getUserMedia() when in Captive Portal Mode
 https://bugs.webkit.org/show_bug.cgi?id=233021
 


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm (285719 => 285720)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm	2021-11-12 15:59:24 UTC (rev 285719)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm	2021-11-12 16:18:51 UTC (rev 285720)
@@ -590,4 +590,9 @@
 _processPool->setUsesOnlyHIDGamepadProviderForTesting(usesHIDProvider);
 }
 
+- (void)_terminateAllWebContentProcesses
+{
+

[webkit-changes] [285719] trunk/LayoutTests

[cdumez]

Title: [285719] trunk/LayoutTests








Revision 285719
Author cdu...@apple.com
Date 2021-11-12 07:59:24 -0800 (Fri, 12 Nov 2021)


Log Message
fast/dom/Geolocation/cached-position-iframe.html is frequently crashing on Mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=233043

Unreviewed, skip test to make EWS happy while the issue is being investigated.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (285718 => 285719)

--- trunk/LayoutTests/ChangeLog	2021-11-12 15:44:28 UTC (rev 285718)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 15:59:24 UTC (rev 285719)
@@ -1,3 +1,12 @@
+2021-11-12  Chris Dumez  
+
+fast/dom/Geolocation/cached-position-iframe.html is frequently crashing on Mac-wk1
+https://bugs.webkit.org/show_bug.cgi?id=233043
+
+Unreviewed, skip test to make EWS happy while the issue is being investigated.
+
+* platform/mac-wk1/TestExpectations:
+
 2021-11-12  Antti Koivisto  
 
 Stack overflow with revert and revert-layer


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (285718 => 285719)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-11-12 15:44:28 UTC (rev 285718)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2021-11-12 15:59:24 UTC (rev 285719)
@@ -1518,5 +1518,7 @@
 
 webkit.org/b/233008 [ Debug ] http/tests/css/filters-on-iframes-transform.html [ Skip ]
 
+webkit.org/b/233043 fast/dom/Geolocation/cached-position-iframe.html [ Skip ]
+
 # DumpRenderTree doesn't invoke inspector instrumentation when repainting.
 webkit.org/b/232852 inspector/page/setShowPaintRects.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285718] trunk/Source/WebCore

[commit-queue]

Title: [285718] trunk/Source/WebCore








Revision 285718
Author commit-qu...@webkit.org
Date 2021-11-12 07:44:28 -0800 (Fri, 12 Nov 2021)


Log Message
[GLib] Developer build with release logs disabled fails
https://bugs.webkit.org/show_bug.cgi?id=232931

Patch by Philippe Normand  on 2021-11-12
Reviewed by Adrian Perez de Castro.

* platform/audio/PlatformMediaSession.cpp: Remove ifdef around convertEnumerationToString
functions, required by Internals.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285717 => 285718)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 14:57:30 UTC (rev 285717)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 15:44:28 UTC (rev 285718)
@@ -1,3 +1,13 @@
+2021-11-12  Philippe Normand  
+
+[GLib] Developer build with release logs disabled fails
+https://bugs.webkit.org/show_bug.cgi?id=232931
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/audio/PlatformMediaSession.cpp: Remove ifdef around convertEnumerationToString
+functions, required by Internals.
+
 2021-11-12  Alan Bujtas  
 
 [LFC][IFC] Add inline box margin-start support for visual ordering (bidi)


Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp (285717 => 285718)

--- trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp	2021-11-12 14:57:30 UTC (rev 285717)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp	2021-11-12 15:44:28 UTC (rev 285718)
@@ -37,7 +37,6 @@
 
 static constexpr Seconds clientDataBufferingTimerThrottleDelay { 100_ms };
 
-#if !RELEASE_LOG_DISABLED
 String convertEnumerationToString(PlatformMediaSession::State state)
 {
 static const NeverDestroyed values[] = {
@@ -121,8 +120,6 @@
 return values[static_cast(command)];
 }
 
-#endif
-
 std::unique_ptr PlatformMediaSession::create(PlatformMediaSessionManager& manager, PlatformMediaSessionClient& client)
 {
 return std::unique_ptr(new PlatformMediaSession(manager, client));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285717] trunk

[cdumez]

Title: [285717] trunk








Revision 285717
Author cdu...@apple.com
Date 2021-11-12 06:57:30 -0800 (Fri, 12 Nov 2021)


Log Message
Disable getUserMedia() when in Captive Portal Mode
https://bugs.webkit.org/show_bug.cgi?id=233021

Reviewed by Brent Fulgham.

Source/WebKit:

Disable getUserMedia() when in Captive Portal Mode.

No new tests, covered by updated API test.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (285716 => 285717)

--- trunk/Source/WebKit/ChangeLog	2021-11-12 14:40:42 UTC (rev 285716)
+++ trunk/Source/WebKit/ChangeLog	2021-11-12 14:57:30 UTC (rev 285717)
@@ -1,3 +1,17 @@
+2021-11-12  Chris Dumez  
+
+Disable getUserMedia() when in Captive Portal Mode
+https://bugs.webkit.org/show_bug.cgi?id=233021
+
+Reviewed by Brent Fulgham.
+
+Disable getUserMedia() when in Captive Portal Mode.
+
+No new tests, covered by updated API test.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::updatePreferences):
+
 2021-11-11  Sergio Villar Senin  
 
 [css-flexbox] Add flex-basis: content support


Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (285716 => 285717)

--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2021-11-12 14:40:42 UTC (rev 285716)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2021-11-12 14:57:30 UTC (rev 285717)
@@ -4064,6 +4064,9 @@
 settings.setWebXREnabled(false);
 settings.setWebXRAugmentedRealityModuleEnabled(false);
 #endif
+#if ENABLE(MEDIA_STREAM)
+settings.setMediaDevicesEnabled(false);
+#endif
 #if ENABLE(WEB_AUDIO)
 settings.setWebAudioEnabled(false);
 #endif


Modified: trunk/Tools/ChangeLog (285716 => 285717)

--- trunk/Tools/ChangeLog	2021-11-12 14:40:42 UTC (rev 285716)
+++ trunk/Tools/ChangeLog	2021-11-12 14:57:30 UTC (rev 285717)
@@ -1,3 +1,14 @@
+2021-11-12  Chris Dumez  
+
+Disable getUserMedia() when in Captive Portal Mode
+https://bugs.webkit.org/show_bug.cgi?id=233021
+
+Reviewed by Brent Fulgham.
+
+Add API test coverage.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
 2021-11-11  Brent Fulgham  
 
 [WebAuthn] Stop serializing BufferSource and Vector duplicates of identifiers


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (285716 => 285717)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm	2021-11-12 14:40:42 UTC (rev 285716)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm	2021-11-12 14:57:30 UTC (rev 285717)
@@ -7646,33 +7646,40 @@
 enum class IsShowingInitialEmptyDocument : bool { No, Yes };
 static void checkSettingsControlledByCaptivePortalMode(WKWebView *webView, ShouldBeEnabled shouldBeEnabled, IsShowingInitialEmptyDocument isShowingInitialEmptyDocument = IsShowingInitialEmptyDocument::No)
 {
-auto checkWindowPropertyExists = [&](ASCIILiteral property) -> bool {
+auto runJSCheck = [&](const String& js) -> bool {
 bool finishedRunningScript = false;
-bool propertyExists = false;
-[webView evaluateJavaScript:makeString("!!window.", property) completionHandler:[&] (id result, NSError *error) {
+bool checkResult = false;
+[webView evaluateJavaScript:js completionHandler:[&] (id result, NSError *error) {
 EXPECT_NULL(error);
-propertyExists = [result boolValue];
+checkResult = [result boolValue];
 finishedRunningScript = true;
 }];
 TestWebKitAPI::Util::run();
-return propertyExists;
+return checkResult;
 };
 
-EXPECT_EQ(checkWindowPropertyExists("WebGL2RenderingContext"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // WebGL2.
-EXPECT_EQ(checkWindowPropertyExists("Gamepad"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Gamepad API.
-EXPECT_EQ(checkWindowPropertyExists("RemotePlayback"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Remote Playback.
-EXPECT_EQ(checkWindowPropertyExists("FileSystemHandle"_s), isShowingInitialEmptyDocument != IsShowingInitialEmptyDocument::Yes && shouldBeEnabled == ShouldBeEnabled::Yes); // File System Access.
-EXPECT_EQ(checkWindowPropertyExists("EnterPictureInPictureEvent"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Picture in Picture API.
-EXPECT_EQ(checkWindowPropertyExists("SpeechRecognitionEvent"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Speech recognition.
-EXPECT_EQ(checkWindowPropertyExists("Notification"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Notification API.
-

[webkit-changes] [285716] trunk/Source/WebCore

[zalan]

Title: [285716] trunk/Source/WebCore








Revision 285716
Author za...@apple.com
Date 2021-11-12 06:40:42 -0800 (Fri, 12 Nov 2021)


Log Message
[LFC][IFC] Add inline box margin-start support for visual ordering (bidi)
https://bugs.webkit.org/show_bug.cgi?id=233022

Reviewed by Antti Koivisto.

Line run geometry is margin box based (only applicable for inline level boxes), while
the displayRect() returns border box based geometry (again, only relevant for inline level boxes).
When computing the border box based left position using the distanceFromLogicalPreviousRun (line run based)
we have to offset it with the margin value.

* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (285715 => 285716)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 14:25:04 UTC (rev 285715)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 14:40:42 UTC (rev 285716)
@@ -1,3 +1,18 @@
+2021-11-12  Alan Bujtas  
+
+[LFC][IFC] Add inline box margin-start support for visual ordering (bidi)
+https://bugs.webkit.org/show_bug.cgi?id=233022
+
+Reviewed by Antti Koivisto.
+
+Line run geometry is margin box based (only applicable for inline level boxes), while
+the displayRect() returns border box based geometry (again, only relevant for inline level boxes).
+When computing the border box based left position using the distanceFromLogicalPreviousRun (line run based)
+we have to offset it with the margin value.
+
+* layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:
+(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent):
+
 2021-11-12  Adrian Perez de Castro  
 
 Non-unified build fixes, early November 2021 edition, bis x2


Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp (285715 => 285716)

--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp	2021-11-12 14:25:04 UTC (rev 285715)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp	2021-11-12 14:40:42 UTC (rev 285716)
@@ -95,6 +95,7 @@
 
 auto displayBoxRect = [&] {
 auto logicalRect = InlineRect { };
+auto marginStart = std::optional { };
 
 if (lineRun.isText() || lineRun.isSoftLineBreak())
 logicalRect = lineBox.logicalRectForTextRun(lineRun);
@@ -102,6 +103,7 @@
 logicalRect = lineBox.logicalRectForLineBreakBox(layoutBox);
 else {
 auto& boxGeometry = formattingState.boxGeometry(layoutBox);
+marginStart = boxGeometry.marginStart();
 if (lineRun.isBox())
 logicalRect = lineBox.logicalBorderBoxForAtomicInlineLevelBox(layoutBox, boxGeometry);
 else if (lineRun.isInlineBoxStart() || lineRun.isLineSpanningInlineBoxStart())
@@ -119,13 +121,13 @@
 // Certain css properties (e.g. word-spacing) may introduce a gap between runs.
 auto distanceFromLogicalPreviousRun = logicalPreviousRun ? lineRun.logicalLeft() - logicalPreviousRun->logicalRight() : lineRun.logicalLeft();
 auto visualOrderRect = logicalRect;
-auto contentLeft = contentRightInVisualOrder + distanceFromLogicalPreviousRun;
+auto contentLeft = contentRightInVisualOrder + distanceFromLogicalPreviousRun + marginStart.value_or(0);
 visualOrderRect.setLeft(contentLeft);
 // The inline box right edge includes its content as well as the inline box end (padding-right etc).
 // What we need here is the inline box start run's width.
-contentRightInVisualOrder = lineRun.isInlineBoxStart() || lineRun.isLineSpanningInlineBoxStart()
-? visualOrderRect.left() + lineRun.logicalWidth()
-: visualOrderRect.right();
+// Note that content width does not refer to content _box_ here (it does include padding and border for inline level boxes).
+auto contentWidth = lineRun.isInlineBoxStart() || lineRun.isLineSpanningInlineBoxStart() ? lineRun.logicalWidth() - *marginStart : logicalRect.width();
+contentRightInVisualOrder = visualOrderRect.left() + contentWidth;
 return visualOrderRect;
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285715] trunk/Source

[aperez]

Title: [285715] trunk/Source








Revision 285715
Author ape...@igalia.com
Date 2021-11-12 06:25:04 -0800 (Fri, 12 Nov 2021)


Log Message
Non-unified build fixes, early November 2021 edition, bis x2

Unreviewed non-unified build fixes.

Source/_javascript_Core:

* jit/JITWorklist.cpp: Add missing DeferGCInlines.h header.

Source/WebCore:

* platform/gamepad/GamepadConstants.h: Use wtf/Forward.h instead of manually
forward-declaring the WTF::String type in the file.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITWorklist.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gamepad/GamepadConstants.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (285714 => 285715)

--- trunk/Source/_javascript_Core/ChangeLog	2021-11-12 12:48:43 UTC (rev 285714)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-11-12 14:25:04 UTC (rev 285715)
@@ -1,3 +1,11 @@
+2021-11-12  Adrian Perez de Castro  
+
+Non-unified build fixes, early November 2021 edition, bis x2
+
+Unreviewed non-unified build fixes.
+
+* jit/JITWorklist.cpp: Add missing DeferGCInlines.h header.
+
 2021-11-11  Mark Lam  
 
 Add VM::writeBarrier() and VM::mutatorFence().


Modified: trunk/Source/_javascript_Core/jit/JITWorklist.cpp (285714 => 285715)

--- trunk/Source/_javascript_Core/jit/JITWorklist.cpp	2021-11-12 12:48:43 UTC (rev 285714)
+++ trunk/Source/_javascript_Core/jit/JITWorklist.cpp	2021-11-12 14:25:04 UTC (rev 285715)
@@ -28,6 +28,7 @@
 
 #if ENABLE(JIT)
 
+#include "DeferGCInlines.h"
 #include "HeapInlines.h"
 #include "JITSafepoint.h"
 #include "JITWorklistThread.h"


Modified: trunk/Source/WebCore/ChangeLog (285714 => 285715)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 12:48:43 UTC (rev 285714)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 14:25:04 UTC (rev 285715)
@@ -1,3 +1,12 @@
+2021-11-12  Adrian Perez de Castro  
+
+Non-unified build fixes, early November 2021 edition, bis x2
+
+Unreviewed non-unified build fixes.
+
+* platform/gamepad/GamepadConstants.h: Use wtf/Forward.h instead of manually
+forward-declaring the WTF::String type in the file.
+
 2021-11-12  Tim Nguyen  
 
 Re-use isCSSWideKeyword in CSSCustomPropertyValue::createWithID


Modified: trunk/Source/WebCore/platform/gamepad/GamepadConstants.h (285714 => 285715)

--- trunk/Source/WebCore/platform/gamepad/GamepadConstants.h	2021-11-12 12:48:43 UTC (rev 285714)
+++ trunk/Source/WebCore/platform/gamepad/GamepadConstants.h	2021-11-12 14:25:04 UTC (rev 285715)
@@ -27,9 +27,7 @@
 
 #if ENABLE(GAMEPAD)
 
-namespace WTF {
-class String;
-};
+#include 
 
 namespace WebCore {
 
@@ -61,9 +59,9 @@
 extern const size_t numberOfStandardGamepadButtonsWithHomeButton;
 extern const GamepadButtonRole maximumGamepadButton;
 
-const WTF::String& standardGamepadMappingString();
+const String& standardGamepadMappingString();
 #if ENABLE(WEBXR)
-const WTF::String& xrStandardGamepadMappingString();
+const String& xrStandardGamepadMappingString();
 #endif
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285714] trunk/Source/WebCore

[ntim]

Title: [285714] trunk/Source/WebCore








Revision 285714
Author n...@apple.com
Date 2021-11-12 04:48:43 -0800 (Fri, 12 Nov 2021)


Log Message
Re-use isCSSWideKeyword in CSSCustomPropertyValue::createWithID
https://bugs.webkit.org/show_bug.cgi?id=233035

Reviewed by Antti Koivisto.

* css/CSSCustomPropertyValue.cpp:
(WebCore::CSSCustomPropertyValue::createWithID):
* css/CSSCustomPropertyValue.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCustomPropertyValue.cpp
trunk/Source/WebCore/css/CSSCustomPropertyValue.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (285713 => 285714)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 12:28:01 UTC (rev 285713)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 12:48:43 UTC (rev 285714)
@@ -1,3 +1,14 @@
+2021-11-12  Tim Nguyen  
+
+Re-use isCSSWideKeyword in CSSCustomPropertyValue::createWithID
+https://bugs.webkit.org/show_bug.cgi?id=233035
+
+Reviewed by Antti Koivisto.
+
+* css/CSSCustomPropertyValue.cpp:
+(WebCore::CSSCustomPropertyValue::createWithID):
+* css/CSSCustomPropertyValue.h:
+
 2021-11-12  Antti Koivisto  
 
 Stack overflow with revert and revert-layer


Modified: trunk/Source/WebCore/css/CSSCustomPropertyValue.cpp (285713 => 285714)

--- trunk/Source/WebCore/css/CSSCustomPropertyValue.cpp	2021-11-12 12:28:01 UTC (rev 285713)
+++ trunk/Source/WebCore/css/CSSCustomPropertyValue.cpp	2021-11-12 12:48:43 UTC (rev 285714)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "CSSCustomPropertyValue.h"
 
+#include "CSSParserIdioms.h"
 #include "CSSTokenizer.h"
 
 namespace WebCore {
@@ -35,6 +36,12 @@
 return adoptRef(*new CSSCustomPropertyValue(name, std::monostate { }));
 }
 
+Ref CSSCustomPropertyValue::createWithID(const AtomString& name, CSSValueID id)
+{
+ASSERT(WebCore::isCSSWideKeyword(id) || id == CSSValueInvalid);
+return adoptRef(*new CSSCustomPropertyValue(name, { id }));
+}
+
 bool CSSCustomPropertyValue::equals(const CSSCustomPropertyValue& other) const
 {
 if (m_name != other.m_name || m_value.index() != other.m_value.index())


Modified: trunk/Source/WebCore/css/CSSCustomPropertyValue.h (285713 => 285714)

--- trunk/Source/WebCore/css/CSSCustomPropertyValue.h	2021-11-12 12:28:01 UTC (rev 285713)
+++ trunk/Source/WebCore/css/CSSCustomPropertyValue.h	2021-11-12 12:48:43 UTC (rev 285714)
@@ -52,17 +52,13 @@
 return adoptRef(*new CSSCustomPropertyValue(name, { value }));
 }
 
-static Ref createWithID(const AtomString& name, CSSValueID id)
-{
-ASSERT(id == CSSValueInherit || id == CSSValueInitial || id == CSSValueUnset || id == CSSValueRevert || id == CSSValueInvalid);
-return adoptRef(*new CSSCustomPropertyValue(name, { id }));
-}
+static Ref createWithID(const AtomString& name, CSSValueID);
 
 static Ref createSyntaxAll(const AtomString& name, Ref&& value)
 {
 return adoptRef(*new CSSCustomPropertyValue(name, { WTFMove(value) }));
 }
-
+
 static Ref createSyntaxLength(const AtomString& name, Length value)
 {
 ASSERT(!value.isUndefined());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285713] trunk

[antti]

Title: [285713] trunk








Revision 285713
Author an...@apple.com
Date 2021-11-12 04:28:01 -0800 (Fri, 12 Nov 2021)


Log Message
Stack overflow with revert and revert-layer
https://bugs.webkit.org/show_bug.cgi?id=233033
rdar://85336439

Reviewed by Antoine Quint.

Source/WebCore:

Test: fast/css/revert-layer-stack-overflow.html

We end up using a rollback cascade made for revert-layer to do revert and that leads to eternal recursion.

* style/StyleBuilder.cpp:
(WebCore::Style::Builder::ensureRollbackCascadeForRevert):
(WebCore::Style::Builder::ensureRollbackCascadeForRevertLayer):

Key the rollback cascade map with the reverted values instead of the original ones since the same
original keys produce different rollbacks depending on whether it is made for revert or revert-layer.

LayoutTests:

* fast/css/revert-layer-stack-overflow-expected.txt: Added.
* fast/css/revert-layer-stack-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleBuilder.cpp


Added Paths

trunk/LayoutTests/fast/css/revert-layer-stack-overflow-expected.txt
trunk/LayoutTests/fast/css/revert-layer-stack-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285712 => 285713)

--- trunk/LayoutTests/ChangeLog	2021-11-12 11:43:26 UTC (rev 285712)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 12:28:01 UTC (rev 285713)
@@ -1,5 +1,16 @@
 2021-11-12  Antti Koivisto  
 
+Stack overflow with revert and revert-layer
+https://bugs.webkit.org/show_bug.cgi?id=233033
+rdar://85336439
+
+Reviewed by Antoine Quint.
+
+* fast/css/revert-layer-stack-overflow-expected.txt: Added.
+* fast/css/revert-layer-stack-overflow.html: Added.
+
+2021-11-12  Antti Koivisto  
+
 REGRESSION(r285624) Using revert keyword with a css variable hits assert
 https://bugs.webkit.org/show_bug.cgi?id=233031
 rdar://85332271


Added: trunk/LayoutTests/fast/css/revert-layer-stack-overflow-expected.txt (0 => 285713)

--- trunk/LayoutTests/fast/css/revert-layer-stack-overflow-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/revert-layer-stack-overflow-expected.txt	2021-11-12 12:28:01 UTC (rev 285713)
@@ -0,0 +1 @@
+This test passes if it doesn't crash.


Added: trunk/LayoutTests/fast/css/revert-layer-stack-overflow.html (0 => 285713)

--- trunk/LayoutTests/fast/css/revert-layer-stack-overflow.html	(rev 0)
+++ trunk/LayoutTests/fast/css/revert-layer-stack-overflow.html	2021-11-12 12:28:01 UTC (rev 285713)
@@ -0,0 +1,15 @@
+
+  @layer l0 {
+html {
+  width: revert;
+}
+  }
+  html {
+height: revert-layer;
+  }
+
+This test passes if it doesn't crash.
+
+if (window.testRunner)
+testRunner.dumpAsText();
+


Modified: trunk/Source/WebCore/ChangeLog (285712 => 285713)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 11:43:26 UTC (rev 285712)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 12:28:01 UTC (rev 285713)
@@ -1,5 +1,24 @@
 2021-11-12  Antti Koivisto  
 
+Stack overflow with revert and revert-layer
+https://bugs.webkit.org/show_bug.cgi?id=233033
+rdar://85336439
+
+Reviewed by Antoine Quint.
+
+Test: fast/css/revert-layer-stack-overflow.html
+
+We end up using a rollback cascade made for revert-layer to do revert and that leads to eternal recursion.
+
+* style/StyleBuilder.cpp:
+(WebCore::Style::Builder::ensureRollbackCascadeForRevert):
+(WebCore::Style::Builder::ensureRollbackCascadeForRevertLayer):
+
+Key the rollback cascade map with the reverted values instead of the original ones since the same
+original keys produce different rollbacks depending on whether it is made for revert or revert-layer.
+
+2021-11-12  Antti Koivisto  
+
 REGRESSION(r285624) Using revert keyword with a css variable hits assert
 https://bugs.webkit.org/show_bug.cgi?id=233031
 rdar://85332271


Modified: trunk/Source/WebCore/style/StyleBuilder.cpp (285712 => 285713)

--- trunk/Source/WebCore/style/StyleBuilder.cpp	2021-11-12 11:43:26 UTC (rev 285712)
+++ trunk/Source/WebCore/style/StyleBuilder.cpp	2021-11-12 12:28:01 UTC (rev 285713)
@@ -375,9 +375,11 @@
 if (rollbackCascadeLevel == CascadeLevel::UserAgent)
 return nullptr;
 
+--rollbackCascadeLevel;
+
 auto key = makeRollbackCascadeKey(rollbackCascadeLevel, RuleSet::cascadeLayerPriorityForUnlayered);
 return m_rollbackCascades.ensure(key, [&] {
-return makeUnique(m_cascade, --rollbackCascadeLevel, RuleSet::cascadeLayerPriorityForUnlayered);
+return makeUnique(m_cascade, rollbackCascadeLevel, RuleSet::cascadeLayerPriorityForUnlayered);
 }).iterator->value.get();
 }
 
@@ -386,9 +388,11 @@
 if (!rollbackLayerPriority)
 return nullptr;
 
+--rollbackLayerPriority;
+
 auto key = makeRollbackCascadeKey(cascadeLevel, rollbackLayerPriority);
 return 

[webkit-changes] [285712] trunk/JSTests

[commit-queue]

Title: [285712] trunk/JSTests








Revision 285712
Author commit-qu...@webkit.org
Date 2021-11-12 03:43:26 -0800 (Fri, 12 Nov 2021)


Log Message
[JSC][32bit] Unskip JSTests/microbenchmarks/redefine-property-accessor-dictionary.js
https://bugs.webkit.org/show_bug.cgi?id=233034

Unreviewed gardening.

This is skipped for memoryLimited *and* mips|arm systems, but a)
seems to run fine on both setups and b) is almost identical to the
other tests/benchmarks that landed in the same patch, that do not
have that limitation. Optimistically remove the skip and let's see
if it sticks.

Patch by Xan Lopez  on 2021-11-12

* microbenchmarks/redefine-property-accessor-dictionary.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/microbenchmarks/redefine-property-accessor-dictionary.js




Diff

Modified: trunk/JSTests/ChangeLog (285711 => 285712)

--- trunk/JSTests/ChangeLog	2021-11-12 10:54:05 UTC (rev 285711)
+++ trunk/JSTests/ChangeLog	2021-11-12 11:43:26 UTC (rev 285712)
@@ -1,3 +1,18 @@
+2021-11-12  Xan Lopez  
+
+[JSC][32bit] Unskip JSTests/microbenchmarks/redefine-property-accessor-dictionary.js
+https://bugs.webkit.org/show_bug.cgi?id=233034
+
+Unreviewed gardening.
+
+This is skipped for memoryLimited *and* mips|arm systems, but a)
+seems to run fine on both setups and b) is almost identical to the
+other tests/benchmarks that landed in the same patch, that do not
+have that limitation. Optimistically remove the skip and let's see
+if it sticks.
+
+* microbenchmarks/redefine-property-accessor-dictionary.js:
+
 2021-11-11  Michael Saboff  
 
 Inline RegExp.test JIT code in DFG and FTL


Modified: trunk/JSTests/microbenchmarks/redefine-property-accessor-dictionary.js (285711 => 285712)

--- trunk/JSTests/microbenchmarks/redefine-property-accessor-dictionary.js	2021-11-12 10:54:05 UTC (rev 285711)
+++ trunk/JSTests/microbenchmarks/redefine-property-accessor-dictionary.js	2021-11-12 11:43:26 UTC (rev 285712)
@@ -1,4 +1,3 @@
-//@ skip if $memoryLimited and ["arm", "mips"].include?($architecture)
 const obj = {};
 for (let i = 0; i < 100; ++i)
 obj["k" + i] = i;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285711] trunk/Source/WebInspectorUI

[rcaliman]

Title: [285711] trunk/Source/WebInspectorUI








Revision 285711
Author rcali...@apple.com
Date 2021-11-12 02:54:05 -0800 (Fri, 12 Nov 2021)


Log Message
Web Inspector: Extract reusable logic from ResourceQueryController, ResourceQueryResult and ResourceQueryMatch
https://bugs.webkit.org/show_bug.cgi?id=231604


Reviewed by Devin Rousso.

Extract reusable logic from `ResourceQueryController` into a generic `QueryController`
to enable subclassing for other specialized use cases.

* UserInterface/Controllers/QueryController.js: Added.
(WI.QueryController.prototype.executeQuery):
(WI.QueryController.prototype.findQueryMatches.pushMatch):
(WI.QueryController.prototype.findQueryMatches.matchNextSpecialCharacter):
(WI.QueryController.prototype.findQueryMatches.backtrack):
(WI.QueryController.prototype.findQueryMatches):
(WI.QueryController):

Keep only the reusable matching logic in `QueryController`.
Subclasses like `ResourceQueryController` are responsible for agregating
the data to be queried, customization for special characters and sorting results.

* UserInterface/Controllers/ResourceQueryController.js:
(WI.ResourceQueryController.prototype.executeQuery):
(WI.ResourceQueryController.prototype._findQueryMatches.pushMatch): Deleted.
(WI.ResourceQueryController.prototype._findQueryMatches.matchNextSpecialCharacter): Deleted.
(WI.ResourceQueryController.prototype._findQueryMatches.backtrack): Deleted.
(WI.ResourceQueryController.prototype._findQueryMatches): Deleted.

* UserInterface/Main.html:

* UserInterface/Models/QueryMatch.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceQueryMatch.js.

`ResourceQueryMatch` doesn't contain any resource-specific logic. It can be generalized to `QueryMatch`.

* UserInterface/Models/QueryResult.js: Copied from Source/WebInspectorUI/UserInterface/Models/ResourceQueryResult.js.
(WI.QueryResult):
(WI.QueryResult.prototype.get value):
(WI.QueryResult.prototype.get rank):
(WI.QueryResult.prototype.get matchingTextRanges):
(WI.QueryResult.prototype._calculateRank.getMultiplier):
(WI.QueryResult.prototype._calculateRank):
(WI.QueryResult.prototype._createMatchingTextRanges):

A generic `QueryResult` can be extracted from `ResourceQueryResult` containing
the reusable logic for ranking results and identifing matching text ranges.

* UserInterface/Models/ResourceQueryResult.js:
(WI.ResourceQueryResult):
(WI.ResourceQueryResult.prototype.get resource):
(WI.ResourceQueryResult.prototype.__test_createMatchesMask):
(WI.ResourceQueryResult.prototype.get rank): Deleted.
(WI.ResourceQueryResult.prototype.get matchingTextRanges): Deleted.
(WI.ResourceQueryResult.prototype._calculateRank.getMultiplier): Deleted.
(WI.ResourceQueryResult.prototype._calculateRank): Deleted.
(WI.ResourceQueryResult.prototype._createMatchingTextRanges): Deleted.

`ResourceQueryResult` extends `QueryResult` with resource-specifc members:
- the `cookie` property which holds the optional line and column info used when jumping to matched files
- the `resource` property which maps to the generic `QueryResult.value`; this is used in tests and when sorting in `ResourceQueryController`

* UserInterface/Test.html:

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Controllers/ResourceQueryController.js
trunk/Source/WebInspectorUI/UserInterface/Main.html
trunk/Source/WebInspectorUI/UserInterface/Models/ResourceQueryResult.js
trunk/Source/WebInspectorUI/UserInterface/Test.html


Added Paths

trunk/Source/WebInspectorUI/UserInterface/Controllers/QueryController.js
trunk/Source/WebInspectorUI/UserInterface/Models/QueryMatch.js
trunk/Source/WebInspectorUI/UserInterface/Models/QueryResult.js


Removed Paths

trunk/Source/WebInspectorUI/UserInterface/Models/ResourceQueryMatch.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (285710 => 285711)

--- trunk/Source/WebInspectorUI/ChangeLog	2021-11-12 10:50:47 UTC (rev 285710)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-11-12 10:54:05 UTC (rev 285711)
@@ -1,3 +1,67 @@
+2021-11-12  Razvan Caliman  
+
+Web Inspector: Extract reusable logic from ResourceQueryController, ResourceQueryResult and ResourceQueryMatch
+https://bugs.webkit.org/show_bug.cgi?id=231604
+
+
+Reviewed by Devin Rousso.
+
+Extract reusable logic from `ResourceQueryController` into a generic `QueryController`
+to enable subclassing for other specialized use cases.
+
+* UserInterface/Controllers/QueryController.js: Added.
+(WI.QueryController.prototype.executeQuery):
+(WI.QueryController.prototype.findQueryMatches.pushMatch):
+(WI.QueryController.prototype.findQueryMatches.matchNextSpecialCharacter):
+(WI.QueryController.prototype.findQueryMatches.backtrack):
+(WI.QueryController.prototype.findQueryMatches):
+(WI.QueryController):
+
+Keep only the reusable matching logic in `QueryController`.
+Subclasses like 

[webkit-changes] [285710] trunk

[antti]

Title: [285710] trunk








Revision 285710
Author an...@apple.com
Date 2021-11-12 02:50:47 -0800 (Fri, 12 Nov 2021)


Log Message
REGRESSION(r285624) Using revert keyword with a css variable hits assert
https://bugs.webkit.org/show_bug.cgi?id=233031
rdar://85332271

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/selectors/variable-revert-crash.html

* style/StyleBuilderState.h:

Default initialization set the variable to a value that is not in the enumeration.

LayoutTests:

* fast/selectors/variable-revert-crash-expected.txt: Added.
* fast/selectors/variable-revert-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleBuilderState.h


Added Paths

trunk/LayoutTests/fast/selectors/variable-revert-crash-expected.txt
trunk/LayoutTests/fast/selectors/variable-revert-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (285709 => 285710)

--- trunk/LayoutTests/ChangeLog	2021-11-12 10:17:21 UTC (rev 285709)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 10:50:47 UTC (rev 285710)
@@ -1,3 +1,14 @@
+2021-11-12  Antti Koivisto  
+
+REGRESSION(r285624) Using revert keyword with a css variable hits assert
+https://bugs.webkit.org/show_bug.cgi?id=233031
+rdar://85332271
+
+Reviewed by Tim Horton.
+
+* fast/selectors/variable-revert-crash-expected.txt: Added.
+* fast/selectors/variable-revert-crash.html: Added.
+
 2021-11-11  Sergio Villar Senin  
 
 [css-flexbox] Add flex-basis: content support


Added: trunk/LayoutTests/fast/selectors/variable-revert-crash-expected.txt (0 => 285710)

--- trunk/LayoutTests/fast/selectors/variable-revert-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/selectors/variable-revert-crash-expected.txt	2021-11-12 10:50:47 UTC (rev 285710)
@@ -0,0 +1 @@
+This test passes if it doesn't crash.


Added: trunk/LayoutTests/fast/selectors/variable-revert-crash.html (0 => 285710)

--- trunk/LayoutTests/fast/selectors/variable-revert-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/selectors/variable-revert-crash.html	2021-11-12 10:50:47 UTC (rev 285710)
@@ -0,0 +1,6 @@
+
+This test passes if it doesn't crash.
+
+if (window.testRunner)
+testRunner.dumpAsText();
+


Modified: trunk/Source/WebCore/ChangeLog (285709 => 285710)

--- trunk/Source/WebCore/ChangeLog	2021-11-12 10:17:21 UTC (rev 285709)
+++ trunk/Source/WebCore/ChangeLog	2021-11-12 10:50:47 UTC (rev 285710)
@@ -1,3 +1,17 @@
+2021-11-12  Antti Koivisto  
+
+REGRESSION(r285624) Using revert keyword with a css variable hits assert
+https://bugs.webkit.org/show_bug.cgi?id=233031
+rdar://85332271
+
+Reviewed by Tim Horton.
+
+Test: fast/selectors/variable-revert-crash.html
+
+* style/StyleBuilderState.h:
+
+Default initialization set the variable to a value that is not in the enumeration.
+
 2021-11-11  Sergio Villar Senin  
 
 [css-flexbox] Add flex-basis: content support


Modified: trunk/Source/WebCore/style/StyleBuilderState.h (285709 => 285710)

--- trunk/Source/WebCore/style/StyleBuilderState.h	2021-11-12 10:17:21 UTC (rev 285709)
+++ trunk/Source/WebCore/style/StyleBuilderState.h	2021-11-12 10:50:47 UTC (rev 285710)
@@ -135,7 +135,7 @@
 Bitmap m_inProgressProperties;
 HashSet m_inProgressPropertiesCustom;
 
-CascadeLevel m_cascadeLevel { };
+CascadeLevel m_cascadeLevel { CascadeLevel::Author };
 ScopeOrdinal m_styleScopeOrdinal { };
 CascadeLayerPriority m_cascadeLayerPriority { };
 SelectorChecker::LinkMatchMask m_linkMatch { };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [285709] trunk

[svillar]

Title: [285709] trunk








Revision 285709
Author svil...@igalia.com
Date 2021-11-12 02:17:21 -0800 (Fri, 12 Nov 2021)


Log Message
[css-flexbox] Add flex-basis: content support
https://bugs.webkit.org/show_bug.cgi?id=221479

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-flexbox/parsing/flex-basis-computed-expected.txt: Replaced FAIL
by PASS expectations.
* web-platform-tests/css/css-flexbox/parsing/flex-basis-valid-expected.txt: Ditto.
* web-platform-tests/css/css-flexbox/parsing/flex-shorthand-expected.txt: Ditto.

Source/WebCore:

Add support for the content keyword as a valid value for the flex-basis property.
It indicates an automated size based on the contents of the flex item. It's typically
equivalent to the max-content size but it has some adjustments for aspect ratios,
orthogonal flows and intrinsic sizing constraints.

Apart from adding the parsing support, it required very little adjustments in the
flexbox code after the refactoring in r284359.

This makes WebKit pass all of the flex-basis:content tests in WPT. We're talking
about 6 tests testing the feature and 6 subtests related to parsing.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Handle Content in switch.
(WebCore::CSSPrimitiveValue::init): Initialization for content CSS value.
* css/CSSProperties.json:
* css/LengthFunctions.cpp: Replaced LengthOrAuto by LengthSizing.
(WebCore::valueForLength): Handle Content in switch.
(WebCore::floatValueForLength): Ditto.
* css/LengthFunctions.h:
(WebCore::minimumValueForLength): Ditto.
* css/calc/CSSCalcValue.cpp:
(WebCore::createCSS): Ditto.
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeFlexBasis): Consume CSSValueContent.
(WebCore::CSSPropertyParser::consumeFlex): Ditto.
* platform/Length.cpp:
(WebCore::operator<<): Added printing support for content.
* platform/Length.h:
(WebCore::Length::initialize): Added enum for content.
(WebCore::Length::isContent const): New method.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing const): Handle content in switch.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::childMainSizeIsDefinite): Treat content as indefinite lenght.
(WebCore::RenderFlexibleBox::computeFlexBaseSizeForChild): Compute flex-basis using max-content
if flex-basis:content is specified.
* style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertLengthSizing): Handle content in switch.

Source/WebKit:

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode): Handle content in switch.
(IPC::ArgumentCoder::decode): Ditto.

LayoutTests:

* TestExpectations: Unskipped all the flexbox-flex-basis-content tests that work fine now.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-basis-computed-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-basis-valid-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-shorthand-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
trunk/Source/WebCore/css/CSSProperties.json
trunk/Source/WebCore/css/LengthFunctions.cpp
trunk/Source/WebCore/css/LengthFunctions.h
trunk/Source/WebCore/css/calc/CSSCalcValue.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp
trunk/Source/WebCore/platform/Length.cpp
trunk/Source/WebCore/platform/Length.h
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/style/StyleBuilderConverter.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (285708 => 285709)

--- trunk/LayoutTests/ChangeLog	2021-11-12 08:59:44 UTC (rev 285708)
+++ trunk/LayoutTests/ChangeLog	2021-11-12 10:17:21 UTC (rev 285709)
@@ -1,3 +1,12 @@
+2021-11-11  Sergio Villar Senin  
+
+[css-flexbox] Add flex-basis: content support
+https://bugs.webkit.org/show_bug.cgi?id=221479
+
+Reviewed by Javier Fernandez.
+
+* TestExpectations: Unskipped all the flexbox-flex-basis-content tests that work fine now.
+
 2021-11-12  Arcady Goldmints-Orlov  
 
 [GLIB] Update test expectations and baselines. Unreviewed test gardening.


Modified: trunk/LayoutTests/TestExpectations (285708 => 285709)

--- trunk/LayoutTests/TestExpectations	2021-11-12 08:59:44 UTC (rev 285708)
+++ trunk/LayoutTests/TestExpectations	2021-11-12 10:17:21 UTC (rev 285709)
@@ -4261,14 +4261,6 @@
 webkit.org/b/221478 imported/w3c/web-platform-tests/css/css-flexbox/dynamic-baseline-change.html [ ImageOnlyFailure ]
 webkit.org/b/221478 imported/w3c/web-platform-tests/css/css-flexbox/synthesize-vrl-baseline.html [ ImageOnlyFailure ]
 
-# flex-basis:content.
-webkit.org/b/221479