[webkit-changes] [287674] trunk

2022-01-05 Thread zalan
Title: [287674] trunk








Revision 287674
Author za...@apple.com
Date 2022-01-05 21:51:41 -0800 (Wed, 05 Jan 2022)


Log Message
Text-decoration color not changing back after input blur with outline removed
https://bugs.webkit.org/show_bug.cgi?id=234800


Reviewed by Antti Koivisto.

Source/WebCore:

This patch fixes the case when a decoration type of style value changes on the input
element (e.g. text-decoration-color) and the inner renderer does not get notified through the usual styleDidChange
flow because the property is non-inherited.

Test: fast/forms/dynamic-text-decoration-change.html

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):

LayoutTests:

* fast/forms/dynamic-text-decoration-change-expected.html: Added.
* fast/forms/dynamic-text-decoration-change.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTextControl.cpp


Added Paths

trunk/LayoutTests/fast/forms/dynamic-text-decoration-change-expected.txt
trunk/LayoutTests/fast/forms/dynamic-text-decoration-change.html




Diff

Modified: trunk/LayoutTests/ChangeLog (287673 => 287674)

--- trunk/LayoutTests/ChangeLog	2022-01-06 04:40:39 UTC (rev 287673)
+++ trunk/LayoutTests/ChangeLog	2022-01-06 05:51:41 UTC (rev 287674)
@@ -1,3 +1,14 @@
+2022-01-05  Alan Bujtas  
+
+Text-decoration color not changing back after input blur with outline removed
+https://bugs.webkit.org/show_bug.cgi?id=234800
+
+
+Reviewed by Antti Koivisto.
+
+* fast/forms/dynamic-text-decoration-change-expected.html: Added.
+* fast/forms/dynamic-text-decoration-change.html: Added.
+
 2021-10-30  Myles C. Maxfield  
 
 [GPU Process] Small ImageBuffers cause the web process to crash


Added: trunk/LayoutTests/fast/forms/dynamic-text-decoration-change-expected.txt (0 => 287674)

--- trunk/LayoutTests/fast/forms/dynamic-text-decoration-change-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/dynamic-text-decoration-change-expected.txt	2022-01-06 05:51:41 UTC (rev 287674)
@@ -0,0 +1,2 @@
+
+PASS


Added: trunk/LayoutTests/fast/forms/dynamic-text-decoration-change.html (0 => 287674)

--- trunk/LayoutTests/fast/forms/dynamic-text-decoration-change.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/dynamic-text-decoration-change.html	2022-01-06 05:51:41 UTC (rev 287674)
@@ -0,0 +1,32 @@
+
+
+input {
+  width: 500px;
+  font-size: 18px;
+  text-decoration-line: underline;
+  text-decoration-color: red;
+  outline: none;
+}
+
+
+

+