[webkit-changes] [WebKit/WebKit] 24afea: Add FIXME in `CSS*` IDL files and comments
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24afea6105eb95fb3cf0acb2509cc7eec1242157 https://github.com/WebKit/WebKit/commit/24afea6105eb95fb3cf0acb2509cc7eec1242157 Author: Ahmad Saleem Date: 2024-04-15 (Mon, 15 Apr 2024) Changed paths: M Source/WebCore/css/CSSConditionRule.idl M Source/WebCore/css/CSSContainerRule.idl M Source/WebCore/css/CSSFontFaceRule.idl M Source/WebCore/css/CSSFontFeatureValuesRule.idl M Source/WebCore/css/CSSFontPaletteValuesRule.idl M Source/WebCore/css/CSSGroupingRule.idl M Source/WebCore/css/CSSImportRule.idl M Source/WebCore/css/CSSKeyframeRule.idl M Source/WebCore/css/CSSKeyframesRule.idl M Source/WebCore/css/CSSLayerBlockRule.idl M Source/WebCore/css/CSSLayerStatementRule.idl M Source/WebCore/css/CSSMediaRule.idl M Source/WebCore/css/CSSPageRule.idl M Source/WebCore/css/CSSPropertyRule.idl M Source/WebCore/css/CSSRule.idl M Source/WebCore/css/CSSRuleList.idl M Source/WebCore/css/CSSScopeRule.idl M Source/WebCore/css/CSSStyleDeclaration.idl M Source/WebCore/css/CSSStyleSheet.idl M Source/WebCore/css/CSSSupportsRule.idl M Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl M Source/WebCore/css/DOMMatrix.idl M Source/WebCore/css/DOMMatrix2DInit.idl M Source/WebCore/css/DOMMatrixInit.idl M Source/WebCore/css/FontFace.idl M Source/WebCore/css/FontFaceSet.idl M Source/WebCore/css/LinkStyle.idl M Source/WebCore/css/MediaList.idl M Source/WebCore/css/MediaQueryList.idl M Source/WebCore/css/MediaQueryListEvent.idl M Source/WebCore/css/StyleSheet.idl M Source/WebCore/css/StyleSheetList.idl Log Message: --- Add FIXME in `CSS*` IDL files and comments https://bugs.webkit.org/show_bug.cgi?id=265327 Reviewed by Anne van Kesteren. This patch is to add FIXME links and web specification URLs for quick reference. * Source/WebCore/css/CSSConditionRule.idl: * Source/WebCore/css/CSSContainerRule.idl: * Source/WebCore/css/CSSFontFaceRule.idl: * Source/WebCore/css/CSSFontFeatureValuesRule.idl: * Source/WebCore/css/CSSFontPaletteValuesRule.idl: * Source/WebCore/css/CSSGroupingRule.idl: * Source/WebCore/css/CSSImportRule.idl: * Source/WebCore/css/CSSKeyframeRule.idl: * Source/WebCore/css/CSSKeyframeRule.idl: * Source/WebCore/css/CSSLayerBlockRule.idl: * Source/WebCore/css/CSSLayerStatementRule.idl: * Source/WebCore/css/CSSMediaRule.idl: * Source/WebCore/css/CSSPageRule.idl: * Source/WebCore/css/CSSPropertyRule.idl: * Source/WebCore/css/CSSRule.idl: * Source/WebCore/css/CSSRuleList.idl: * Source/WebCore/css/CSSScopeRule.idl: * Source/WebCore/css/CSSStyleDeclaration.idl: * Source/WebCore/css/CSSStyleSheet.idl: * Source/WebCore/css/CSSSupportsRule.idl: * Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl: * Source/WebCore/css/DOMMatrix.idl: * Source/WebCore/css/DOMMatrix2DInit.idl: * Source/WebCore/css/DOMMatrixInit.idl: * Source/WebCore/css/FontFace.idl: * Source/WebCore/css/FontFaceSet.idl: * Source/WebCore/css/LinkStyle.idl: * Source/WebCore/css/MediaList.idl: * Source/WebCore/css/MediaQueryList.idl: * Source/WebCore/css/MediaQueryListEvent.idl: * Source/WebCore/css/StyleSheet.idl: * Source/WebCore/css/StyleSheetList.idl: Canonical link: https://commits.webkit.org/277518@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6231f: `BackgroundPainter::paintFillLayers` should check ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6231f750f4e26e71cdf3c0f1d2fbb81879c665b https://github.com/WebKit/WebKit/commit/b6231f750f4e26e71cdf3c0f1d2fbb81879c665b Author: Ahmad Saleem Date: 2024-03-06 (Wed, 06 Mar 2024) Changed paths: A LayoutTests/fast/box-shadow/normal-box-shadow-with-background-image-expected-mismatch.html A LayoutTests/fast/box-shadow/normal-box-shadow-with-background-image.html M Source/WebCore/rendering/BackgroundPainter.cpp Log Message: --- `BackgroundPainter::paintFillLayers` should check box-shadow when finding an opaque layer https://bugs.webkit.org/show_bug.cgi?id=250882 rdar://problem/104722307 Reviewed by Antti Koivisto. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. Merge: https://chromium.googlesource.com/chromium/blink/+/a48f4540763c24adff42b9b77d719597f51482f6 BackgroundPainter::paintFillLayers has a fast path when a layer has an opaque background image. If a layer has an opaque background image, basically the layer's background layers will be hidden by the background image. So we can skip rendering the background layers. However, if box-shadow is also specified, the box-shadow will be rendered in a skipped background layer. This causes "box-shadow disappears". We cannot use the fast path if box-shadow is specified. * Source/WebCore/rendering/BackgroundPainter.cpp: (BackgroundPainter::paintFillLayers): * LayoutTests/fast/box-shadow/normal-box-shadow-with-background-image.html: Add Test Case * LayoutTests/fast/box-shadow/normal-box-shadow-with-background-image-expected-mismatch.html: Add Test Case Expectation Mismatch Canonical link: https://commits.webkit.org/275735@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e65124: Sync `media-element-enqueue-event-crash.html` from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e651241992db825459849c26dbd8d85a7e1c6988 https://github.com/WebKit/WebKit/commit/e651241992db825459849c26dbd8d85a7e1c6988 Author: Ahmad Saleem Date: 2024-03-04 (Mon, 04 Mar 2024) Changed paths: M LayoutTests/media/track/media-element-enqueue-event-crash-expected.txt M LayoutTests/media/track/media-element-enqueue-event-crash.html Log Message: --- Sync `media-element-enqueue-event-crash.html` from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=270410 Reviewed by Jean-Yves Avenard. This patch is to sync `media-element-enqueue-event-crash.html` from Blink / Chromium upstream as per below latest commit: Only change is to use `mp4` rather than `ogv`. Partial Merge: https://source.chromium.org/chromium/chromium/src/+/2e0d99c0e86f5dc6624817f27ba76884f5cbbf83 * LayoutTests/media/track/media-element-enqueue-event-crash.html: Updated * LayoutTests/media/track/media-element-enqueue-event-crash-expected.txt: Ditto Canonical link: https://commits.webkit.org/275654@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8cc453: Use `unsigned` instead of `unsigned int` in `Edito...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cc45329975e949cef09753ac8db62c78ba9ad2b https://github.com/WebKit/WebKit/commit/8cc45329975e949cef09753ac8db62c78ba9ad2b Author: Ahmad Saleem Date: 2024-03-03 (Sun, 03 Mar 2024) Changed paths: M Source/WebCore/editing/Editor.cpp Log Message: --- Use `unsigned` instead of `unsigned int` in `Editor::selectionStartHasMarkerFor` aligning with WebKit Code Style https://bugs.webkit.org/show_bug.cgi?id=270424 Reviewed by Fujii Hironori. This patch is to use `unsigned` instead of `unsigned int` as per WebKit's Code Style Guidelines [1]: [1] https://webkit.org/code-style-guidelines/#types-unsigned * Source/WebCore/editing/Editor.cpp: (Editor::selectionStartHasMarkerFor): Canonical link: https://commits.webkit.org/275612@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9a69a5: Minor refactoring to avoid redundant functions cal...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9a69a5010e0f688e8f0f5aa47a389060b2cbdc2e https://github.com/WebKit/WebKit/commit/9a69a5010e0f688e8f0f5aa47a389060b2cbdc2e Author: Ahmad Saleem Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/editing/ApplyBlockElementCommand.cpp M Source/WebCore/editing/IndentOutdentCommand.cpp Log Message: --- Minor refactoring to avoid redundant functions calls in Editing code https://bugs.webkit.org/show_bug.cgi?id=270202 Reviewed by Ryosuke Niwa. Merge: https://chromium.googlesource.com/chromium/blink/+/27d47607bcb998d4ca3d4e0452341bde77c74f98 This patch do minor refactoring to avoid redundant function calls. Also, it also remove unused `nodeAfterStart` variable. * Source/WebCore/editing/ApplyBlockElementCommand.cpp: (ApplyBlockElementCommand::formatSelection): * Source/WebCore/editing/IndentOutdentCommand.cpp: (IndentOutdentCommand::indentIntoBlockquote): (IndentOutdentCommand::outdentRegion): Canonical link: https://commits.webkit.org/275422@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cbcae5: Remove unused `type` function from `BarProp.cpp|h`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cbcae553570809f2c48cbe4faab29e9a80ff8ba3 https://github.com/WebKit/WebKit/commit/cbcae553570809f2c48cbe4faab29e9a80ff8ba3 Author: Ahmad Saleem Date: 2024-02-27 (Tue, 27 Feb 2024) Changed paths: M Source/WebCore/page/BarProp.cpp M Source/WebCore/page/BarProp.h Log Message: --- Remove unused `type` function from `BarProp.cpp|h` https://bugs.webkit.org/show_bug.cgi?id=270157 Reviewed by Charlie Wolfe. This patch removes unused function 'type' from `BarProp.cpp|h`. * Source/WebCore/page/BarProp.cpp: (BarProp::type): Deleted * Source/WebCore/page/BarProp.h: Canonical link: https://commits.webkit.org/275393@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f2d99: [Part 2] Remove local track tests in favor of WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f2d99d8d5683aa6c67bba585448331755dd9a68 https://github.com/WebKit/WebKit/commit/0f2d99d8d5683aa6c67bba585448331755dd9a68 Author: Ahmad Saleem Date: 2024-02-26 (Mon, 26 Feb 2024) Changed paths: M LayoutTests/TestExpectations R LayoutTests/media/track/captions-webvtt/cues-overlapping.vtt R LayoutTests/media/track/captions-webvtt/large-timestamp.vtt R LayoutTests/media/track/captions-webvtt/missed-cues.vtt R LayoutTests/media/track/track-add-remove-cue-expected.txt R LayoutTests/media/track/track-add-remove-cue.html R LayoutTests/media/track/track-add-track-expected.txt R LayoutTests/media/track/track-add-track.html R LayoutTests/media/track/track-addtrack-kind-expected.txt R LayoutTests/media/track/track-addtrack-kind.html R LayoutTests/media/track/track-cue-inline-assertion-crash-expected.txt R LayoutTests/media/track/track-cue-inline-assertion-crash.html R LayoutTests/media/track/track-cue-mutable-expected.txt R LayoutTests/media/track/track-cue-mutable-fragment-expected.txt R LayoutTests/media/track/track-cue-mutable-fragment.html R LayoutTests/media/track/track-cue-mutable.html R LayoutTests/media/track/track-cues-missed-expected.txt R LayoutTests/media/track/track-cues-missed.html R LayoutTests/media/track/track-cues-pause-on-exit-expected.txt R LayoutTests/media/track/track-cues-pause-on-exit.html R LayoutTests/media/track/track-cues-seeking-expected.txt R LayoutTests/media/track/track-cues-seeking.html R LayoutTests/media/track/track-cues-sorted-before-dispatch-expected.txt R LayoutTests/media/track/track-cues-sorted-before-dispatch.html R LayoutTests/media/track/track-disabled-addcue-expected.txt R LayoutTests/media/track/track-disabled-addcue.html R LayoutTests/media/track/track-disabled-expected.txt R LayoutTests/media/track/track-disabled.html R LayoutTests/media/track/track-element-dom-change-crash-expected.txt R LayoutTests/media/track/track-element-dom-change-crash.html R LayoutTests/media/track/track-large-timestamp-expected.txt R LayoutTests/media/track/track-large-timestamp.html R LayoutTests/media/track/track-load-error-readyState-expected.txt R LayoutTests/media/track/track-load-error-readyState.html R LayoutTests/media/track/track-load-from-element-readyState-expected.txt R LayoutTests/media/track/track-load-from-element-readyState.html R LayoutTests/media/track/track-load-from-src-readyState-expected.txt R LayoutTests/media/track/track-load-from-src-readyState.html R LayoutTests/media/track/track-mode-disabled-crash-expected.txt R LayoutTests/media/track/track-mode-disabled-crash.html R LayoutTests/media/track/track-mode-expected.txt R LayoutTests/media/track/track-mode-not-changed-by-new-track-expected.txt R LayoutTests/media/track/track-mode-not-changed-by-new-track.html R LayoutTests/media/track/track-mode-triggers-loading-expected.txt R LayoutTests/media/track/track-mode-triggers-loading.html R LayoutTests/media/track/track-mode.html R LayoutTests/media/track/track-remove-quickly-expected.txt R LayoutTests/media/track/track-remove-quickly.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M LayoutTests/platform/wk2/TestExpectations Log Message: --- [Part 2] Remove local track tests in favor of WPT https://bugs.webkit.org/show_bug.cgi?id=269671 Reviewed by Eric Carlson. This is part 2 of on-going effort to de-duplicate bunch of local tests in `media` specifically `track` in favor of WPT tests: > Remove local tests in favor of WPT: * LayoutTests/media/track/track-remove-quickly.html: Same name on WPT * LayoutTests/media/track/track-remove-quickly-expected.txt: * LayoutTests/media/track/track-cue-mutable.html: Same name on WPT * LayoutTests/media/track/track-cue-mutable-expected.txt: * LayoutTests/media/track/track-cue-mutable-fragment.html: Same name on WPT * LayoutTests/media/track/track-cue-mutable-fragment-expected.txt: * LayoutTests/media/track/track-cue-inline-assertion-crash.html: Renamed 'track-cue-inline.html' * LayoutTests/media/track/track-cue-inline-assertion-crash-expected.txt: * LayoutTests/media/track/track-addtrack-kind.html: Same name on WPT * LayoutTests/media/track/track-addtrack-kind-expected.txt: * LayoutTests/media/track/track-add-track.html: Same name on WPT * LayoutTests/media/track/track-add-track-expected.txt: * LayoutTests/media/track/track-add-remove-cue.html: Same name on WPT * LayoutTests/media/track/track-add-remove-cue-expected.txt: * LayoutTests/media/track/track-cues-sorted-before-dispatch.html: Same name on WPT * LayoutTests/media/track/track-cues-sorted-before-dispatch-expected.txt: * LayoutTests/media/track/track-cues-seeking.html: S
[webkit-changes] [WebKit/WebKit] 74a570: [Part 3] Un-skip more passing 'track' WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 74a570d11375304d6dd2fe7e2e2696e5f93bcff2 https://github.com/WebKit/WebKit/commit/74a570d11375304d6dd2fe7e2e2696e5f93bcff2 Author: Ahmad Saleem Date: 2024-02-25 (Sun, 25 Feb 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/src-empty-string-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/src-empty-string.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-add-remove-cue-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-add-remove-cue.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-mutable-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-mutable-fragment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-mutable-fragment.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-mutable.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-negative-timestamp-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-negative-timestamp.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-sorted-before-dispatch-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-sorted-before-dispatch.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-default-attribute-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-default-attribute.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-load-error-readyState-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-load-error-readyState.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-load-from-element-readyState-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-load-from-element-readyState.html M LayoutTests/platform/glib/TestExpectations Log Message: --- [Part 3] Un-skip more passing 'track' WPT tests https://bugs.webkit.org/show_bug.cgi?id=270051 Reviewed by Eric Carlson. This PR is to start enabling `track` tests selectively and modify them as needed, where specific flag is needed for `vtt` related tests: > Test Expectation Update: * LayoutTests/TestExpectations: > Test & Test Expectation Changes: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-load-from-element-readyState.html:; * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-load-from-element-readyState-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-load-error-readyState.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-load-error-readyState-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-default-attribute.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-default-attribute-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-sorted-before-dispatch.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-sorted-before-dispatch-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-negative-timestamp.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/medi
[webkit-changes] [WebKit/WebKit] 36e27e: Eliminate some unneeded header inclusions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 36e27eaf8bd45b13ef0a99d9be290866485afbe8 https://github.com/WebKit/WebKit/commit/36e27eaf8bd45b13ef0a99d9be290866485afbe8 Author: Ahmad Saleem Date: 2024-02-25 (Sun, 25 Feb 2024) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapper.h M Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp M Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h Log Message: --- Eliminate some unneeded header inclusions https://bugs.webkit.org/show_bug.cgi?id=149343 Reviewed by Tim Nguyen. Credits: Emanuele Aina This patch removes unneeded headers from two files and redundant class from another. * Source/WebCore/platform/graphics/texmap/TextureMapper.h: Remove `GraphicsLayer` class * Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: * Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h: Canonical link: https://commits.webkit.org/275294@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eade05: Remove unused `pageLocation` function from `MouseR...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eade0529b1d751328f3d0e6861b35c2370824caa https://github.com/WebKit/WebKit/commit/eade0529b1d751328f3d0e6861b35c2370824caa Author: Ahmad Saleem Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WebCore/dom/MouseRelatedEvent.cpp M Source/WebCore/dom/MouseRelatedEvent.h Log Message: --- Remove unused `pageLocation` function from `MouseRelatedEvent.cpp|h` https://bugs.webkit.org/show_bug.cgi?id=269963 Reviewed by Ryosuke Niwa. This patch removes unused function 'pageLocation' from `MouseRelatedEvent.cpp|h`. * Source/WebCore/dom/MouseRelatedEvent.cpp: (MouseRelatedEvent::pageLocation): * Source/WebCore/dom/MouseRelatedEvent.h: Canonical link: https://commits.webkit.org/275232@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d477c7: Web Inspector: Add '*-conic-gradient' for autocomp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d477c762a9ecbbc8dedf3ca7a6a2a079577bf60c https://github.com/WebKit/WebKit/commit/d477c762a9ecbbc8dedf3ca7a6a2a079577bf60c Author: Ahmad Saleem Date: 2024-02-22 (Thu, 22 Feb 2024) Changed paths: M Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js Log Message: --- Web Inspector: Add '*-conic-gradient' for autocompletion suggestion in 'background' https://bugs.webkit.org/show_bug.cgi?id=269889 Reviewed by Timothy Hatcher. This patch adds missing 'conic-gradient' and 'repeating-conic-gradient' support in autocompletion for background since these properties are supported as far back as 2018 with 204375@main. * Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js: (background): Add 'conic-gradient()' and 'repeating-conic-gradient()' Canonical link: https://commits.webkit.org/275160@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a18f3e: Import `progress-events-generated-correctly.html` ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a18f3e115c5277f715d33631a60462e361bd2dc4 https://github.com/WebKit/WebKit/commit/a18f3e115c5277f715d33631a60462e361bd2dc4 Author: Ahmad Saleem Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: A LayoutTests/http/tests/media/progress-events-generated-correctly-expected.txt A LayoutTests/http/tests/media/progress-events-generated-correctly.html R LayoutTests/media/progress-events-generated-correctly-expected.txt R LayoutTests/media/progress-events-generated-correctly.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- Import `progress-events-generated-correctly.html` from Blink / Chromium https://bugs.webkit.org/show_bug.cgi?id=269644 Reviewed by Eric Carlson. This patch is to import test from Blink, which was updated to use `testharness`. Partial Merge: https://source.chromium.org/chromium/chromium/src/+/25f67c81bfa8c6b1ce5a4c061ca5bd76eae32fff * LayoutTests/media/progress-events-generated-correctly.html: Remove old copy * LayoutTests/media/progress-events-generated-correctly-expected.txt: Ditto * LayoutTests/http/tests/media/progress-events-generated-correctly.html: Updated Test Case in `http` directory * LayoutTests/http/tests/media/progress-events-generated-correctly-expected.txt: Add Test Case Expectation > Remove / Update old Test Expectations: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/275082@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eae264: Sync few more `media` tests from Blink / Chromium
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eae264a888e1aa5237e85d73debc6b9f5f459ab6 https://github.com/WebKit/WebKit/commit/eae264a888e1aa5237e85d73debc6b9f5f459ab6 Author: Ahmad Saleem Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M LayoutTests/media/audio-data-url-expected.txt M LayoutTests/media/audio-data-url.html M LayoutTests/media/controls-css-overload-expected.txt M LayoutTests/media/controls-css-overload.html M LayoutTests/media/event-attributes-expected.txt M LayoutTests/media/event-attributes.html M LayoutTests/media/invalid-media-url-crash-expected.txt M LayoutTests/media/invalid-media-url-crash.html M LayoutTests/media/unsupported-rtsp-expected.txt M LayoutTests/media/unsupported-rtsp.html M LayoutTests/media/unsupported-tracks-expected.txt M LayoutTests/media/unsupported-tracks.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/ios-device/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- Sync few more `media` tests from Blink / Chromium https://bugs.webkit.org/show_bug.cgi?id=269768 Reviewed by Eric Carlson. This patch is to sync few `media` tests from Blink / Chromium, leveraging `testharness` and also potentially de-flake. Partial Merge: https://source.chromium.org/chromium/chromium/src/+/f0b4140302ed4571ec1c063fcb0a87b7cca67514 , https://source.chromium.org/chromium/chromium/src/+/b7181764cf5da42aa606b814291c9a465567461b , https://source.chromium.org/chromium/chromium/src/+/2403d8e3ac2673941329a1942091409e4b21bb64 , https://source.chromium.org/chromium/chromium/src/+/f2dfca4180ffdf50c2c9d926d8113d61d5886efc > Test & Test Expectations Update: * LayoutTests/media/unsupported-tracks.html: * LayoutTests/media/unsupported-tracks-expected.txt: * LayoutTests/media/unsupported-rtsp.html: * LayoutTests/media/unsupported-rtsp-expected.txt: * LayoutTests/media/invalid-media-url-crash.html: * LayoutTests/media/invalid-media-url-crash-expected.txt: * LayoutTests/media/event-attributes.html: * LayoutTests/media/event-attributes-expected.txt: * LayoutTests/media/controls-css-overload.html: * LayoutTests/media/controls-css-overload-expected.txt: * LayoutTests/media/audio-data-url.html: * LayoutTests/media/audio-data-url-expected.txt: > Platform Test Expectations: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/ios-device/TestExpectations: * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/275069@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2644f4: Sync `video-append-source.html` from Blink / Chrom...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2644f4c513410c8699b617df4a854984a44e6ab9 https://github.com/WebKit/WebKit/commit/2644f4c513410c8699b617df4a854984a44e6ab9 Author: Ahmad Saleem Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M LayoutTests/media/video-append-source-expected.txt M LayoutTests/media/video-append-source.html Log Message: --- Sync `video-append-source.html` from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=116263 Reviewed by Eric Carlson. This patch is to sync `video-append-source.html` from Blink / Chromium upstream as per below latest commit: Only change is to use `mp4` rather than `ogv`. Partial Merge: https://source.chromium.org/chromium/chromium/src/+/f0b4140302ed4571ec1c063fcb0a87b7cca67514 * LayoutTests/media/video-append-source.html: Updated * LayoutTests/media/video-append-source-expected.txt: Ditto Canonical link: https://commits.webkit.org/275041@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 281bb8: Sync `auto-play-in-sandbox-with-allow-scripts.html...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 281bb85fd5a55bf1d0245993a879bde442d9f6d9 https://github.com/WebKit/WebKit/commit/281bb85fd5a55bf1d0245993a879bde442d9f6d9 Author: Ahmad Saleem Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M LayoutTests/media/auto-play-in-sandbox-with-allow-scripts-expected.txt M LayoutTests/media/auto-play-in-sandbox-with-allow-scripts.html M LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- Sync `auto-play-in-sandbox-with-allow-scripts.html` from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=112533 Reviewed by Eric Carlson. This patch is to sync `auto-play-in-sandbox-with-allow-scripts.html` from Blink / Chromium upstream as per below commit: Merge: https://source.chromium.org/chromium/chromium/src/+/66f2fa7fc9c02fe7929245a915433602c956a959 > Test & Test Expectations Updated: * LayoutTests/media/auto-play-in-sandbox-with-allow-scripts.html: * LayoutTests/media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: * LayoutTests/media/auto-play-in-sandbox-with-allow-scripts-expected.txt: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/275009@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dcd60b: Return initial value for `stop-color` instead of `...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dcd60b82e8d89608e2cb5072c7e3f3ee040102c8 https://github.com/WebKit/WebKit/commit/dcd60b82e8d89608e2cb5072c7e3f3ee040102c8 Author: Ahmad Saleem Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebCore/svg/SVGStopElement.cpp Log Message: --- Return initial value for `stop-color` instead of `transparentBlack` https://bugs.webkit.org/show_bug.cgi?id=269545 Reviewed by Nikolas Zimmermann. This patch is to better align with expectations and web-specification by returning initial value (black) rather than 'transparentBlack' for `stop-color` in absence of 'renderer'. Web-Spec: https://svgwg.org/svg2-draft/pservers.html#StopColorProperties * Source/WebCore/svg/SVGStopElement.cpp: (SVGStopElement::stopColorIncludingOpacity): Canonical link: https://commits.webkit.org/274997@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b24a21: Web Inspector: Autocomplete for text-indent proper...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b24a216b175d9bcf1e318e013acfe1e2c357b498 https://github.com/WebKit/WebKit/commit/b24a216b175d9bcf1e318e013acfe1e2c357b498 Author: Ahmad Saleem Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: M Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js Log Message: --- Web Inspector: Autocomplete for text-indent property suggests -webkit-each-line and -webkit-hanging incorrectly https://bugs.webkit.org/show_bug.cgi?id=269307 Reviewed by Timothy Hatcher. This PR is to update `autocompletion` list to not suggest prefixed properties of `hanging` and `each-line` for `text-ident`. Both of these properties are enabled since 235896@main. * Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js: (text-ident): Canonical link: https://commits.webkit.org/274979@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 393573: HTMLPreloadScanner should only use valid `base` urls
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 393573035d7ef055e27d29da79d2f8ce5833f783 https://github.com/WebKit/WebKit/commit/393573035d7ef055e27d29da79d2f8ce5833f783 Author: Ahmad Saleem Date: 2024-02-19 (Mon, 19 Feb 2024) Changed paths: A LayoutTests/fast/parser/badurl-base-preloader-crash-expected.txt A LayoutTests/fast/parser/badurl-base-preloader-crash.html A LayoutTests/http/tests/loading/preload-ignore-invalid-base-expected.txt A LayoutTests/http/tests/loading/preload-ignore-invalid-base.html A LayoutTests/http/tests/loading/resources/fail.js M Source/WebCore/html/parser/HTMLPreloadScanner.cpp Log Message: --- HTMLPreloadScanner should only use valid `base` urls https://bugs.webkit.org/show_bug.cgi?id=269643 Reviewed by Ryosuke Niwa. Partial Merge: https://chromium.googlesource.com/chromium/blink/+/754b22f62f6fa5f0b938a90c0e92502eb7f5a7c3 Before this patch, HTMLPreloadScanner accepted invalid `base` urls and used it to resolve urls encountered later in the scan. This patch ensures that only valid urls specified in `base href` are actually used as base urls. * Source/WebCore/html/parser/HTMLPreloadScanner.cpp: (TokenPreloadScanner::updatePredictedBaseURL): * LayoutTests/fast/parser/badurl-base-preloader-crash.html: Add Test Case * LayoutTests/fast/parser/badurl-base-preloader-crash-expected.txt: Add Test Case Expectation * LayoutTests/http/tests/loading/preload-ignore-invalid-base.html: Add Test Case * LayoutTests/http/tests/loading/resources/fail.js: Add Test Case Helper Script * LayoutTests/http/tests/loading/preload-ignore-invalid-base-expected.txt: Add Test Expectation Canonical link: https://commits.webkit.org/274963@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 92e050: Un-skip Passing 'track' WPT tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 92e050e938089e40b97e9cf7800ec8c3f94249b4 https://github.com/WebKit/WebKit/commit/92e050e938089e40b97e9cf7800ec8c3f94249b4 Author: Ahmad Saleem Date: 2024-02-18 (Sun, 18 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-disabled-addcue-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-disabled-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-insert-after-load-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-large-timestamp-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-large-timestamp.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-mode-disabled-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-mode-triggers-loading-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-remove-active-cue-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-alignment-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-alignment.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-blank-lines-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-blank-lines.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-bom-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-bom.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-class-markup-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-class-markup.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-identifiers-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-identifiers.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-no-id-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-no-id.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-recovery-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-recovery.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-size-align-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-size-align.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-size-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-cue-size.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-degenerate-cues-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-degenerate-cues.html A LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-empty-cue-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track
[webkit-changes] [WebKit/WebKit] 1fcbc1: Remove local `track` tests in favor of WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fcbc136b4143a32dca6429fa0679c24cd41e763 https://github.com/WebKit/WebKit/commit/1fcbc136b4143a32dca6429fa0679c24cd41e763 Author: Ahmad Saleem Date: 2024-02-18 (Sun, 18 Feb 2024) Changed paths: R LayoutTests/media/track/captions-webvtt/cues-chrono-order.vtt R LayoutTests/media/track/captions-webvtt/tc001-iso2022jp3.vtt R LayoutTests/media/track/captions-webvtt/tc001-utf8.vtt R LayoutTests/media/track/captions-webvtt/tc002-bom.vtt R LayoutTests/media/track/captions-webvtt/tc003-newlines.vtt R LayoutTests/media/track/captions-webvtt/tc003-no-newline-at-eof.vtt R LayoutTests/media/track/captions-webvtt/tc004-webvtt-rubbish.vtt R LayoutTests/media/track/captions-webvtt/tc005-metadata-area.vtt R LayoutTests/media/track/captions-webvtt/tc006-cue-id-error.vtt R LayoutTests/media/track/captions-webvtt/tc006-cue-id.vtt R LayoutTests/media/track/captions-webvtt/tc007-cue-no-id-error.vtt R LayoutTests/media/track/captions-webvtt/tc007-cue-no-id.vtt R LayoutTests/media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt R LayoutTests/media/track/captions-webvtt/tc008-timings-no-hour.vtt R LayoutTests/media/track/captions-webvtt/tc009-timings-hour-error.vtt R LayoutTests/media/track/captions-webvtt/tc009-timings-hour.vtt R LayoutTests/media/track/captions-webvtt/tc010-no-timings.vtt R LayoutTests/media/track/captions-webvtt/tc011-cues-no-separation.vtt R LayoutTests/media/track/captions-webvtt/tc011-cues.vtt R LayoutTests/media/track/captions-webvtt/tc012-out-of-order.vtt R LayoutTests/media/track/captions-webvtt/tc013-settings-bad-separation.vtt R LayoutTests/media/track/captions-webvtt/tc014-alignment-bad.vtt R LayoutTests/media/track/captions-webvtt/tc014-alignment-ltr.vtt R LayoutTests/media/track/captions-webvtt/tc014-alignment.vtt R LayoutTests/media/track/captions-webvtt/tc015-positioning-bad.vtt R LayoutTests/media/track/captions-webvtt/tc015-positioning-ltr.vtt R LayoutTests/media/track/captions-webvtt/tc015-positioning.vtt R LayoutTests/media/track/captions-webvtt/tc016-align-positioning-bad.vtt R LayoutTests/media/track/captions-webvtt/tc016-align-positioning.vtt R LayoutTests/media/track/captions-webvtt/tc017-line-position-bad.vtt R LayoutTests/media/track/captions-webvtt/tc017-line-position.vtt R LayoutTests/media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt R LayoutTests/media/track/captions-webvtt/tc018-align-text-line-position.vtt R LayoutTests/media/track/captions-webvtt/tc020-cue-size-align-bad.vtt R LayoutTests/media/track/captions-webvtt/tc020-cue-size-align.vtt R LayoutTests/media/track/captions-webvtt/tc021-valign-bad.vtt R LayoutTests/media/track/captions-webvtt/tc021-valign-ltr.vtt R LayoutTests/media/track/captions-webvtt/tc021-valign.vtt R LayoutTests/media/track/captions-webvtt/tc022-entities-wrong.vtt R LayoutTests/media/track/captions-webvtt/tc022-entities.vtt R LayoutTests/media/track/captions-webvtt/tc023-markup-bad.vtt R LayoutTests/media/track/captions-webvtt/tc023-markup.vtt R LayoutTests/media/track/captions-webvtt/tc024-timestamp-bad.vtt R LayoutTests/media/track/captions-webvtt/tc024-timestamp.vtt R LayoutTests/media/track/captions-webvtt/tc025-class-bad.vtt R LayoutTests/media/track/captions-webvtt/tc025-class.vtt R LayoutTests/media/track/captions-webvtt/tc026-voice-bad.vtt R LayoutTests/media/track/captions-webvtt/tc026-voice.vtt R LayoutTests/media/track/captions-webvtt/tc027-empty-cue.vtt R LayoutTests/media/track/captions-webvtt/tc028-unsupported-markup.vtt R LayoutTests/media/track/captions-webvtt/tc029-timings-whitespace.vtt R LayoutTests/media/track/captions-webvtt/tc030-interspersed-non-cue.vtt R LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-cuetext.vtt R LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-header.vtt R LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-note.vtt R LayoutTests/media/track/captions-webvtt/tc032-degenerate-cues.vtt R LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/crossOrigin.html R LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/kind.html R LayoutTests/media/track/regions-webvtt/vtt-region-parser-expected.txt R LayoutTests/media/track/regions-webvtt/vtt-region-parser.html R LayoutTests/media/track/track-active-cues-expected.txt R LayoutTests/media/track/track-active-cues.html R LayoutTests/media/track/track-constants-expected.txt R LayoutTests/media/track/track-constants.html R LayoutTests/media/track/track-cues-cuechange-expected.txt R LayoutTests/media/track/track-cues-cuechange.html R LayoutTests/media/track/track-cues-enter-exit-expected.txt R LayoutTests/media/track/track-cues-enter
[webkit-changes] [WebKit/WebKit] 85c396: Sync `video-display-aspect-ratio.html` test from B...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85c396bcfe9d798ee3cb60acbd0f62b04a1ef393 https://github.com/WebKit/WebKit/commit/85c396bcfe9d798ee3cb60acbd0f62b04a1ef393 Author: Ahmad Saleem Date: 2024-02-18 (Sun, 18 Feb 2024) Changed paths: M LayoutTests/media/video-display-aspect-ratio-expected.txt M LayoutTests/media/video-display-aspect-ratio.html M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- Sync `video-display-aspect-ratio.html` test from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=35297 Reviewed by Eric Carlson. This patch is to sync `video-display-aspect-ratio.html` from Blink / Chromium upstream as per below commit: Partial Merge: https://source.chromium.org/chromium/chromium/src/+/fb4997976e1c1db6712d1a1b8be871f041eeaf4e * LayoutTests/media/video-display-aspect-ratio.html: Updated * LayoutTests/media/video-display-aspect-ratio-expected.txt: Rebaselined * LayoutTests/platform/ios/TestExpectations: Remove 'fail' expectation * LayoutTests/platform/mac/TestExpectations: Ditto Canonical link: https://commits.webkit.org/274947@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 345a31: Remove non-standard `VTTRegion.track`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 345a3158dfec00a635894d05ee186d24c16ec777 https://github.com/WebKit/WebKit/commit/345a3158dfec00a635894d05ee186d24c16ec777 Author: Ahmad Saleem Date: 2024-02-17 (Sat, 17 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/historical-expected.txt R LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt R LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html M Source/WebCore/html/track/InbandGenericTextTrack.cpp M Source/WebCore/html/track/InbandWebVTTTextTrack.cpp M Source/WebCore/html/track/LoadableTextTrack.cpp M Source/WebCore/html/track/TextTrack.cpp M Source/WebCore/html/track/VTTRegion.cpp M Source/WebCore/html/track/VTTRegion.h M Source/WebCore/html/track/VTTRegion.idl Log Message: --- Remove non-standard `VTTRegion.track` https://bugs.webkit.org/show_bug.cgi?id=269649 Reviewed by Eric Carlson. This patch is to align WebKit with Blink / Chromium, Gecko / Firefox and Web Specification [1]: [1] https://w3c.github.io/webvtt/#the-vttregion-interface It was removed from the web-spec in following: W3C Bug - https://www.w3.org/Bugs/Public/show_bug.cgi?id=24380 WebVTT GitHub Commit - https://github.com/w3c/webvtt/pull/31 * Source/WebCore/html/track/VTTRegion.cpp: (VTTRegion::setTrack): * Source/WebCore/html/track/VTTRegion.h: * Source/WebCore/html/track/VTTRegion.idl: * Source/WebCore/html/track/InbandGenericTextTrack.cpp: (InbandGenericTextTrack::newRegionsParsed): * Source/WebCore/html/track/InbandWebVTTTextTrack.cpp: (InbandWebVTTTextTrack::newRegionsParsed): * Source/WebCore/html/track/LoadableTextTrack.cpp: (LoadableTextTrack::newRegionsAvailable): * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/historical-expected.txt: Rebaselined * LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html: Removed in favor of WPT Test: `webvtt/api/VTTRegion/constructor.html` * LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt: Deleted Test Expectations Canonical link: https://commits.webkit.org/274936@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5b92ef: Revert 274308@main - Broke discord.com login button
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5b92efd47caab72297ba516a095b517d629bb56b https://github.com/WebKit/WebKit/commit/5b92efd47caab72297ba516a095b517d629bb56b Author: Ahmad Saleem Date: 2024-02-17 (Sat, 17 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03-expected.txt M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04-expected.txt M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05-expected.txt M LayoutTests/svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html M LayoutTests/svg/dom/path-pointAtLength-expected.txt M LayoutTests/svg/dom/path-pointAtLength.html M Source/WebCore/svg/SVGGeometryElement.cpp M Source/WebCore/svg/SVGPathElement.cpp Log Message: --- Revert 274308@main - Broke discord.com login button https://bugs.webkit.org/show_bug.cgi?id=269647 Reviewed by Simon Fraser. This patch reverts 274308@main as title states manually. > Reverted Changes: * LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05-expected.txt: * LayoutTests/svg/dom/path-pointAtLength-expected.txt: * LayoutTests/svg/dom/path-pointAtLength.html: * LayoutTests/svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html: * Source/WebCore/svg/SVGGeometryElement.cpp: (SVGGeometryElement::getPointAtLength): * Source/WebCore/svg/SVGPathElement.cpp: (SVGPathElement::getPointAtLength): Canonical link: https://commits.webkit.org/274929@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 909976: Import `video-cancel-load.html` from Blink / Chromium
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9099761a9066727cd84b6a7ec1f0986b5ae93fb2 https://github.com/WebKit/WebKit/commit/9099761a9066727cd84b6a7ec1f0986b5ae93fb2 Author: Ahmad Saleem Date: 2024-02-17 (Sat, 17 Feb 2024) Changed paths: M LayoutTests/http/tests/media/video-cancel-load-expected.txt M LayoutTests/http/tests/media/video-cancel-load.html A LayoutTests/platform/glib/http/tests/media/video-cancel-load-expected.txt Log Message: --- Import `video-cancel-load.html` from Blink / Chromium https://bugs.webkit.org/show_bug.cgi?id=269171 Reviewed by Eric Carlson. This patch is to import test from Blink, which was updated: Partial Merge: https://source.chromium.org/chromium/chromium/src/+/25f67c81bfa8c6b1ce5a4c061ca5bd76eae32fff * LayoutTests/http/tests/media/video-cancel-load.html: Update Test Case * LayoutTests/http/tests/media/video-cancel-load-expected.txt: Add Test Case Expectation > It requires Back/Forward Test Runner flag and it seems to not work on WPE & GTK platform and previously it had `empty` line as expectation as well. So it keeps similar for GTK & WPE. * LayoutTests/platform/glib/http/tests/media/video-cancel-load-expected.txt: Add Platform Specific Test Expectation Canonical link: https://commits.webkit.org/274925@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f07572: Sync `no-clipping-overflow-hidden-added-after-tran...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f07572f71508530dbd75f5c1178b8fad02e0bf83 https://github.com/WebKit/WebKit/commit/f07572f71508530dbd75f5c1178b8fad02e0bf83 Author: Ahmad Saleem Date: 2024-02-17 (Sat, 17 Feb 2024) Changed paths: M LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html M LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform.html M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- Sync `no-clipping-overflow-hidden-added-after-transform.html` test from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=157007 Reviewed by Antoine Quint. This patch is to sync `no-clipping-overflow-hidden-added-after-transform.html` from Blink / Chromium upstream as per below commit: Merge: https://source.chromium.org/chromium/chromium/src/+/7dcf0801857f3fc64f066c5c20738a54889ae835 * LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform.html: Updated Test Case * LayoutTests/fast/layers/no-clipping-overflow-hidden-added-after-transform-expected.html: Updated Test Case Expectation * LayoutTests/platform/mac-wk1/TestExpectations: Remove [ Pass ImageOnlyFailure ] Expectation Canonical link: https://commits.webkit.org/274922@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c57e3: Sync `transition-end-event-nested.html` test from ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c57e3d7752e11a23e1ec87a9bfb523c65da4228 https://github.com/WebKit/WebKit/commit/7c57e3d7752e11a23e1ec87a9bfb523c65da4228 Author: Ahmad Saleem Date: 2024-02-17 (Sat, 17 Feb 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations M LayoutTests/transitions/transition-end-event-helpers.js M LayoutTests/transitions/transition-end-event-nested-expected.txt M LayoutTests/transitions/transition-end-event-nested.html Log Message: --- Sync `transition-end-event-nested.html` test from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=228002 rdar://problem/80647736 Reviewed by Antoine Quint. This patch is to sync `transition-end-event-nested.html` from Blink / Chromium upstream as per below commit: Merge: https://source.chromium.org/chromium/chromium/src/+/854380e3ef0dc2d5cfdc171bb7b49ef7d46fe725 * LayoutTests/transitions/transition-end-event-nested.html: Update Test Case * LayoutTests/transitions/transition-end-event-nested-expected.txt: Update Test Case Expectation * LayoutTests/transitions/transition-end-event-helpers.js: Update Helper Script * LayoutTests/platform/mac/TestExpectations: Remove [ Pass Failure ] Expectation Canonical link: https://commits.webkit.org/274921@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d015cf: Sync `start-transform-transition.html` test from B...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d015cf1551cc58dcf879b91775bf3a12c732b4ac https://github.com/WebKit/WebKit/commit/d015cf1551cc58dcf879b91775bf3a12c732b4ac Author: Ahmad Saleem Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations M LayoutTests/transitions/start-transform-transition-expected.txt M LayoutTests/transitions/start-transform-transition.html Log Message: --- Sync `start-transform-transition.html` test from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=207125 rdar://problem/59112567 Reviewed by Antoine Quint. This patch is to sync `start-transform-transition.html` from Blink / Chromium upstream as per below commit: Merge: https://source.chromium.org/chromium/chromium/src/+/246d89262dc44712d67ebdcf1be88b4e29a643a4 * LayoutTests/transitions/start-transform-transition.html: Updated Test Case * LayoutTests/transitions/start-transform-transition-expected.txt: Updated Test Case Expectation * LayoutTests/platform/mac/TestExpectations: Remove [ Pass Failure ] Expectation Canonical link: https://commits.webkit.org/274884@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 912ab0: Sync `play-state.html` test from Blink / Chromium ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 912ab0557e23a343f349f1e0b4034108065811c3 https://github.com/WebKit/WebKit/commit/912ab0557e23a343f349f1e0b4034108065811c3 Author: Ahmad Saleem Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/animations/play-state-expected.txt M LayoutTests/animations/play-state.html Log Message: --- Sync `play-state.html` test from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=42821 Reviewed by Antoine Quint. This patch is to sync `play-state.html` from Blink / Chromium upstream as per below commit: Merge: https://source.chromium.org/chromium/chromium/src/+/d8ae480412425c4b3f8ecccb81bb5b0c8b4b3fc1 * LayoutTests/animations/play-state.html: Updated * LayoutTests/animations/play-state-expected.txt: Updated Test Expectations * LayoutTests/TestExpectations: Remove [ Pass Failure ] Expectation Canonical link: https://commits.webkit.org/274880@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aaf812: Sync `extra-transition.html` test from Blink / Chr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aaf812a078ddab5fcde6fa01c24ac3575752cd2a https://github.com/WebKit/WebKit/commit/aaf812a078ddab5fcde6fa01c24ac3575752cd2a Author: Ahmad Saleem Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/transitions/extra-transition-expected.txt M LayoutTests/transitions/extra-transition.html Log Message: --- Sync `extra-transition.html` test from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=171947 Reviewed by Antoine Quint. This patch is to sync `extra-transition.html` from Blink / Chromium upstream as per below commit: Merge: https://source.chromium.org/chromium/chromium/src/+/9fd376e988691e1b08a9a0302237d22ef7098809 * LayoutTests/transitions/extra-transition.html: Updated Test * LayoutTests/transitions/extra-transition-expected.txt: Updated Test Expectation * LayoutTests/platform/mac-wk1/TestExpectations: Removed Expectation * LayoutTests/platform/ios-wk2/TestExpectations: Ditto Canonical link: https://commits.webkit.org/274860@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 689641: Sync `transform-origin-vs-functions.html` test fro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68964191fb4958a59e43cb98c3b1cb9c0b1ee118 https://github.com/WebKit/WebKit/commit/68964191fb4958a59e43cb98c3b1cb9c0b1ee118 Author: Ahmad Saleem Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/animations/3d/transform-origin-vs-functions-expected.txt M LayoutTests/animations/3d/transform-origin-vs-functions.html A LayoutTests/animations/resources/helpers.js Log Message: --- Sync `transform-origin-vs-functions.html` test from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=155501 Reviewed by Antoine Quint. This patch is to sync `ransform-origin-vs-functions.html` from Blink / Chromium upstream as per below commit: Merge: https://source.chromium.org/chromium/chromium/src/+/53db6d2749de2904b040c2d86936c9a4d1e7dde3 The updated test uses `testharness` and does not have setTimeout and don't rely on callback timing leading to less flakiness. * LayoutTests/animations/3d/transform-origin-vs-functions.html: Updated Test * LayoutTests/animations/3d/transform-origin-vs-functions-expected.txt: Updated Test Expectation * LayoutTests/animations/resources/helpers.js: Helper Script * LayoutTests/TestExpectations: Remove Expectation Canonical link: https://commits.webkit.org/274835@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d1274a: Sync `animation-events-prefixed-*` tests from Blin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1274a1f94713f089625a31039e2c6d712845aec https://github.com/WebKit/WebKit/commit/d1274a1f94713f089625a31039e2c6d712845aec Author: Ahmad Saleem Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M LayoutTests/imported/blink/animations/animation-events-prefixed-01-expected.txt M LayoutTests/imported/blink/animations/animation-events-prefixed-01.html M LayoutTests/imported/blink/animations/animation-events-prefixed-02-expected.txt M LayoutTests/imported/blink/animations/animation-events-prefixed-02.html M LayoutTests/imported/blink/animations/animation-events-prefixed-03-expected.txt M LayoutTests/imported/blink/animations/animation-events-prefixed-03.html M LayoutTests/imported/blink/virtual/stable/animations-unprefixed/animation-events-prefixed-04-expected.txt M LayoutTests/imported/blink/virtual/stable/animations-unprefixed/animation-events-prefixed-04.html Log Message: --- Sync `animation-events-prefixed-*` tests from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=161208 Reviewed by Antoine Quint. This patch is to sync all `animation-events-prefixed-*` tests from Blink / Chromium upstream, which were modified in below commit: Partial Merge (Prefixed): https://source.chromium.org/chromium/chromium/src/+/a8ddfde5071f182c11adcbe1060a93b3332c92e7 > Updated (use `testharness`): * LayoutTests/imported/blink/animations/animation-events-prefixed-01.html: * LayoutTests/imported/blink/animations/animation-events-prefixed-01-expected.txt: * LayoutTests/imported/blink/animations/animation-events-prefixed-02.html: * LayoutTests/imported/blink/animations/animation-events-prefixed-02-expected.txt: * LayoutTests/imported/blink/animations/animation-events-prefixed-03.html: * LayoutTests/imported/blink/animations/animation-events-prefixed-03-expected.txt: * LayoutTests/imported/blink/virtual/stable/animations-unprefixed/animation-events-prefixed-04.html: * LayoutTests/imported/blink/virtual/stable/animations-unprefixed/animation-events-prefixed-04-expected.txt: Canonical link: https://commits.webkit.org/274831@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ce832: Apply SVG paint-order to text-decorations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ce832dcb0d37a68a7980d4a4251f92195e864f6 https://github.com/WebKit/WebKit/commit/9ce832dcb0d37a68a7980d4a4251f92195e864f6 Author: Ahmad Saleem Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp Log Message: --- Apply SVG paint-order to text-decorations https://bugs.webkit.org/show_bug.cgi?id=268825 Reviewed by Tim Nguyen. This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web-Specification [1] & [2]: [1] https://svgwg.org/svg2-draft/painting.html#PaintOrder [2] https://svgwg.org/svg2-draft/text.html#TextDecorationProperties "The paint order of the text decoration itself (fill/stroke) is determined by the value of the paint-order property at the point where the text decoration is declared." Merge: https://chromium.googlesource.com/chromium/blink/+/72eecba077f756ef4ed254541ff37dcb9baec05a * Source/WebCore/rendering/svg/SVGInlineTextBox.cpp: (SVGInlineTextBox::paintDecoration): 'for' loop similar to `paint()` function * LayoutTests/TestExpectations: Remove passing test Canonical link: https://commits.webkit.org/274814@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e432d4: Sync `svg/painting/reftests` from WPT upstream
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e432d4044e6e1c73d09d2ca39b965c8dbdb2dba0 https://github.com/WebKit/WebKit/commit/e432d4044e6e1c73d09d2ca39b965c8dbdb2dba0 Author: Ahmad Saleem Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/display-none-mask-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/display-none-mask-ref.html M LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/display-none-mask.html A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/fallback-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/fallback-001.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/fallback-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/fallback-002.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-implicit-subpaths-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-implicit-subpaths.html A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.svg R LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-001.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.svg R LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-003-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.svg R LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-011-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.svg R LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-012-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.svg R LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-013-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-021-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-022-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-path-023-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.svg R LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-strokewidth-non-scaling-stroke-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.svg R LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/marker-units-userspaceonuse-non-scaling-stroke-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/markers-orient-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/markers-orient-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/markers-orient-002.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/mask-percentage-expected.html A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/mask-percentage-ref.html A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/mask-percentage.html A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/mask-print-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/paint-context-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/paint-context-002-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/paint-order-001-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/paintorder-text-decorations-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/paintorder-text-decorations-ref.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/paintorder-text-decorations.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/percentage-attribute-expected.svg A LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/percentage-expected.svg M LayoutTests/imported/w3c/web-platform-tests/svg/painting/reftests/w3c-import.log M LayoutTests/platform/ios
[webkit-changes] [WebKit/WebKit] b85b96: Remove unused expectations of SVGCursorElement-svg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b85b96c50d057a446880f433c5fe9404e7152094 https://github.com/WebKit/WebKit/commit/b85b96c50d057a446880f433c5fe9404e7152094 Author: Ahmad Saleem Date: 2024-02-14 (Wed, 14 Feb 2024) Changed paths: R LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png R LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png R LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png R LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png Log Message: --- Remove unused expectations of SVGCursorElement-svgdom-* tests https://bugs.webkit.org/show_bug.cgi?id=269339 Reviewed by Nikolas Zimmermann. This patch removes unused file expectations for following tests (which don't exist anymore): > svg/dynamic-updates/SVGCursorElement-svgdom-x-prop.html: > svg/dynamic-updates/SVGCursorElement-svgdom-y-prop.html: * LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Deleted * LayoutTests/platform/gtk/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Ditto * LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Ditto * LayoutTests/platform/mac/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Ditto Canonical link: https://commits.webkit.org/274622@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4ed491: Remove prefixed `HTMLMediaElement.webkitPreservesP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ed49192487b2b842b62b35aabde3c9a039b7ed4 https://github.com/WebKit/WebKit/commit/4ed49192487b2b842b62b35aabde3c9a039b7ed4 Author: Ahmad Saleem Date: 2024-02-13 (Tue, 13 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt M Source/WebCore/html/HTMLMediaElement.idl Log Message: --- Remove prefixed `HTMLMediaElement.webkitPreservesPitch` https://bugs.webkit.org/show_bug.cgi?id=250871 rdar://problem/104451631 Reviewed by Eric Carlson. In 267341@main, WebKit exposed `preservesPitch` while retaining prefixed `webkitPreservesPitch` for web compatibility, since then Safari had two major releases (17.3 and 17.4 as beta). So this patch is to remove prefixed `webkitPreservesPitch` and align completely with other web browsers. * Source/WebCore/html/HTMLMediaElement.idl: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/274551@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2582df: Import `video-error-abort.html` from Blink using `...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2582df18b6d41723de507d03879ab2428f9284e4 https://github.com/WebKit/WebKit/commit/2582df18b6d41723de507d03879ab2428f9284e4 Author: Ahmad Saleem Date: 2024-02-13 (Tue, 13 Feb 2024) Changed paths: M LayoutTests/http/tests/media/video-error-abort-expected.txt M LayoutTests/http/tests/media/video-error-abort.html Log Message: --- Import `video-error-abort.html` from Blink using `testharness` https://bugs.webkit.org/show_bug.cgi?id=269142 Reviewed by Eric Carlson. This patch is to import test from Blink, which was updated to use `testharness`. Partial Merge: https://source.chromium.org/chromium/chromium/src/+/5fbfa5d22ad8d973ecbd66c416ff3182eee623a4 * LayoutTests/http/tests/media/video-error-abort.html: Updated Test Case * LayoutTests/http/tests/media/video-error-abort-expected.txt: Updated Test Case Expectation Canonical link: https://commits.webkit.org/274550@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 83099a: Remove redundant 'stroke' setup in RenderDetailsMa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 83099abfe4609b9c8ca5bc5ab3592ae8e9c99f59 https://github.com/WebKit/WebKit/commit/83099abfe4609b9c8ca5bc5ab3592ae8e9c99f59 Author: Ahmad Saleem Date: 2024-02-13 (Tue, 13 Feb 2024) Changed paths: M Source/WebCore/rendering/RenderDetailsMarker.cpp Log Message: --- Remove redundant 'stroke' setup in RenderDetailsMarker::paint https://bugs.webkit.org/show_bug.cgi?id=269265 Reviewed by Simon Fraser. Merge: https://chromium.googlesource.com/chromium/src.git/+/3cc1fc709c9d6a56027368c26b8719d3e8eb5fc2 This patch removes stroke parameters setup during `paint` but they are unused in `fillPath` used later in function. * Source/WebCore/rendering/RenderDetailsMarker.cpp: (RenderDetailsMarker::paint): Canonical link: https://commits.webkit.org/274548@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2fcf9: Import `video-cookie.html` from Blink
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2fcf98ab3ae6ce8936e952c96769bef6db6642b https://github.com/WebKit/WebKit/commit/c2fcf98ab3ae6ce8936e952c96769bef6db6642b Author: Ahmad Saleem Date: 2024-02-11 (Sun, 11 Feb 2024) Changed paths: M LayoutTests/http/tests/media/video-cookie-expected.txt M LayoutTests/http/tests/media/video-cookie.html M LayoutTests/platform/mac/TestExpectations Log Message: --- Import `video-cookie.html` from Blink https://bugs.webkit.org/show_bug.cgi?id=34287 Reviewed by Jean-Yves Avenard. This patch is to import test from Blink with two changes: 1) Use `python` script for setting up server 2) Use `mp4` test file Partial Merge: https://source.chromium.org/chromium/chromium/src/+/5fbfa5d22ad8d973ecbd66c416ff3182eee623a4 * LayoutTests/platform/mac/TestExpectations: Remove Test Expectation * LayoutTests/http/tests/media/video-cookie.html: Updated Test Case * LayoutTests/http/tests/media/video-cookie-expected.txt: Updated Test Case Expectation Canonical link: https://commits.webkit.org/274451@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8469bb: Remove `applet` specific UA Style Rules from `html...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8469bb227f90e41898da991b8e2fe039626640ec https://github.com/WebKit/WebKit/commit/8469bb227f90e41898da991b8e2fe039626640ec Author: Ahmad Saleem Date: 2024-02-10 (Sat, 10 Feb 2024) Changed paths: M Source/WebCore/css/html.css Log Message: --- Remove `applet` specific UA Style Rules from `html.css` https://bugs.webkit.org/show_bug.cgi?id=269137 Reviewed by Anne van Kesteren. This patch is to remove deprecated `applet` tag user agent stylesheet rules. * Source/WebCore/css/html.css: Remove UA rules for outline and tap highlight Canonical link: https://commits.webkit.org/274427@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 042030: Sync `link` specific UA stylesheet rule as per SVG...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 042030db2bb825fe23c6d49310fa6e37e82243f8 https://github.com/WebKit/WebKit/commit/042030db2bb825fe23c6d49310fa6e37e82243f8 Author: Ahmad Saleem Date: 2024-02-10 (Sat, 10 Feb 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/no-help-cursor-on-links-wrapped-in-svg.historical-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/no-help-cursor-on-links-wrapped-in-svg.historical.html M LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/w3c-import.log M Source/WebCore/css/svg.css Log Message: --- Sync `link` specific UA stylesheet rule as per SVG2 Web Specification https://bugs.webkit.org/show_bug.cgi?id=269076 Reviewed by Anne van Kesteren. This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web Specification: [1] https://svgwg.org/svg2-draft/styling.html#UAStyleSheet As per SVG2 specification, this PR adds UA rules for links wrapped in SVG element to have cursor as `pointer`. Additionally, this PR also sync test to test above behavior from WPT: Upstream commit: https://github.com/web-platform-tests/wpt/commit/43a23d0263d9d8a3c0fad2c28d8ff608f4343bb9 * Source/WebCore/css/svg.css: (a:any-link): * LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/no-help-cursor-on-links-wrapped-in-svg.historical.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/the-css-user-agent-style-sheet-and-presentational-hints/no-help-cursor-on-links-wrapped-in-svg.historical-expected.txt: Canonical link: https://commits.webkit.org/274422@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 904a6d: Sync `html/rendering/bidi-rendering` WPT from upst...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 904a6d2eea778953b84217c8c5576b1b8f6fce4f https://github.com/WebKit/WebKit/commit/904a6d2eea778953b84217c8c5576b1b8f6fce4f Author: Ahmad Saleem Date: 2024-02-09 (Fri, 09 Feb 2024) Changed paths: M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-direction.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-direction.window.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-direction.window.js A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-no-isolate-001-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-no-isolate-001-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-no-isolate-001.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules.html A LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/w3c-import.log Log Message: --- Sync `html/rendering/bidi-rendering` WPT from upstream https://bugs.webkit.org/show_bug.cgi?id=269038 Reviewed by Tim Nguyen. This PR is to import `bidi-rendering` test cases from WPT upstream: Upstream Commit Hash: https://github.com/web-platform-tests/wpt/commit/da25e93244e17fa16f245a955af8e0638230acab * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/w3c-import.log: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-direction.window.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-direction.window.js: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-no-isolate-001.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-no-isolate-001-ref.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/slot-no-isolate-001-expected.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules.html: * LayoutTests/imported/w3c/web-platform-tests/html/rendering/bidi-rendering/unicode-bidi-ua-rules-expected.txt: Canonical link: https://commits.webkit.org/274368@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9f2fac: [SVG2] getPointAtLength should throw exception whe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9f2facf9ef6db9cf652f3e8729ce4e5cc3b90e26 https://github.com/WebKit/WebKit/commit/9f2facf9ef6db9cf652f3e8729ce4e5cc3b90e26 Author: Ahmad Saleem Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03-expected.txt M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04-expected.txt M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05-expected.txt M LayoutTests/svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html M LayoutTests/svg/dom/path-pointAtLength-expected.txt M LayoutTests/svg/dom/path-pointAtLength.html M Source/WebCore/svg/SVGGeometryElement.cpp M Source/WebCore/svg/SVGPathElement.cpp Log Message: --- [SVG2] getPointAtLength should throw exception when in non-rendered document for SVGPathElement https://bugs.webkit.org/show_bug.cgi?id=264876 rdar://problem/118720630 Reviewed by Said Abou-Hallawa. This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web-Specification [1]: [1] https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement NOTE: SVGPathElement interface with SVGGeometryElement. This patch aligns WebKit to throw exception in case of document being non-rendered element. "If current element is a non-rendered element, and the UA is not able to compute the total length of the path, then throw an InvalidStateError." I took the opportunity to add meaningful error to `SVGGeometryElement` as well and add check for content-visibility to SVGPathElement. * Source/WebCore/svg/SVGGeometryElement.cpp: (SVGGeometryElement::getPointAtLength): Added meaningful message * Source/WebCore/svg/SVGPathElement.cpp: (SVGPathElement::getPointAtLength): Aligned with 'SVGGeometryElement' * LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03-expected.txt: Rebaselined * LayoutTests/svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html: Rebaselined * LayoutTests/svg/dom/path-pointAtLength.html: Ditto * LayoutTests/svg/dom/path-pointAtLength-expected.txt: Ditto * LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04-expected.txt: Rebaselined * LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/274308@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 619a40: Build fix - add missing `ScriptExecutionContext` h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 619a40a6876850213c4907704f0dfa0a5db17b69 https://github.com/WebKit/WebKit/commit/619a40a6876850213c4907704f0dfa0a5db17b69 Author: Ahmad Saleem Date: 2024-02-08 (Thu, 08 Feb 2024) Changed paths: M Source/WebCore/dom/TrustedTypePolicyFactory.cpp Log Message: --- Build fix - add missing `ScriptExecutionContext` header https://bugs.webkit.org/show_bug.cgi?id=268985 Reviewed by Chris Dumez and Anne van Kesteren. This PR adds missing header in `TrustedTypePolicyFactory.cpp` post 274263@main. * Source/WebCore/dom/TrustedTypePolicyFactory.cpp: Canonical link: https://commits.webkit.org/274289@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 775f16: Sync `munder` & `mover` (font-size: inherit) UA st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 775f16a37adca5f1c20f3739fd39e8086bc3341d https://github.com/WebKit/WebKit/commit/775f16a37adca5f1c20f3739fd39e8086bc3341d Author: Ahmad Saleem Date: 2024-02-07 (Wed, 07 Feb 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt M LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt M Source/WebCore/css/mathml.css Log Message: --- Sync `munder` & `mover` (font-size: inherit) UA stylesheet rule as per MathML Spec https://bugs.webkit.org/show_bug.cgi?id=268853 Reviewed by Frédéric Wang. This patch is to align WebKit with Web-Specification [1]: [1] https://w3c.github.io/mathml-core/#user-agent-stylesheet This patch is to sync UA rule of `font-size` as 'inherit' for `munder` and `mover` with accent as `true` with nth-child of certain depth. * Source/WebCore/css/mathml.css: * LayoutTests/TestExpectations: Remove now passing test * LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Rebaselined * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Rebaselined * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Rebaselined * LayoutTests/platform/glib/imported/w3c/web-platform-tests/mathml/relations/css-styling/scriptlevel-001-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/274212@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 11a520: Remove local copies of `SVGTextElement-*dom-length...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 11a520625f34c48dae8320b5e5192328a07e6886 https://github.com/WebKit/WebKit/commit/11a520625f34c48dae8320b5e5192328a07e6886 Author: Ahmad Saleem Date: 2024-02-05 (Mon, 05 Feb 2024) Changed paths: R LayoutTests/platform/gtk/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png R LayoutTests/platform/gtk/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png R LayoutTests/platform/mac-sonoma-wk2-pixel/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png R LayoutTests/platform/mac-sonoma-wk2-pixel/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png R LayoutTests/platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png R LayoutTests/platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png R LayoutTests/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.txt R LayoutTests/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html R LayoutTests/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt R LayoutTests/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html Log Message: --- Remove local copies of `SVGTextElement-*dom-lengthAdjust-*.html` copies in favor of WPT Tests https://bugs.webkit.org/show_bug.cgi?id=268677 Reviewed by Rob Buis. This patch is to remove local copies of tests, which were uploaded to WPT by Blink commit below: Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/3385118 For reference, these tests were replaced by following WPT Test (as a single test): -> svg/text/scripted/lengthadjust.html > Deleted test & test expecations: * LayoutTests/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html: * LayoutTests/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.txt: * LayoutTests/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html: * LayoutTests/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.txt: * LayoutTests/platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: * LayoutTests/platform/mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: * LayoutTests/platform/mac-sonoma-wk2-pixel/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: * LayoutTests/platform/mac-sonoma-wk2-pixel/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png: * LayoutTests/platform/gtk/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png: * LayoutTests/platform/gtk/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png: Canonical link: https://commits.webkit.org/274101@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c00a65: Remove unused `percentLoaded` function from HTMLMe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c00a65b0b3bba16f1b07e0f55cd6b65729ab86b7 https://github.com/WebKit/WebKit/commit/c00a65b0b3bba16f1b07e0f55cd6b65729ab86b7 Author: Ahmad Saleem Date: 2024-02-05 (Mon, 05 Feb 2024) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h Log Message: --- Remove unused `percentLoaded` function from HTMLMediaElement https://bugs.webkit.org/show_bug.cgi?id=268715 Reviewed by Eric Carlson. This patch removes unused function 'percentLoaded' from `HTMLMediaElement.cpp|h`. * Source/WebCore/html/HTMLMediaElement.cpp: (HTMLMediaElement::percentLoaded): Deleted * Source/WebCore/html/HTMLMediaElement.h: Canonical link: https://commits.webkit.org/274088@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f50de8: Remove non-standard `WheelEvent.initWebKitWheelEve...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f50de885e127381197e0bab6e3a0f598161b2758 https://github.com/WebKit/WebKit/commit/f50de885e127381197e0bab6e3a0f598161b2758 Author: Ahmad Saleem Date: 2024-02-04 (Sun, 04 Feb 2024) Changed paths: M LayoutTests/fast/events/wheelevent-delta-overflow-expected.txt M LayoutTests/fast/events/wheelevent-delta-overflow.html M LayoutTests/fast/events/wheelevent-in-scrolling-div-expected.txt M LayoutTests/fast/events/wheelevent-in-scrolling-div.html M LayoutTests/fast/forms/resources/common-wheel-event.js M Source/WebCore/dom/WheelEvent.cpp M Source/WebCore/dom/WheelEvent.h M Source/WebCore/dom/WheelEvent.idl M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMWheelEvent.cpp M Source/WebKitLegacy/mac/DOM/DOMWheelEvent.mm Log Message: --- Remove non-standard `WheelEvent.initWebKitWheelEvent()` https://bugs.webkit.org/show_bug.cgi?id=267813 rdar://problem/121733957 Reviewed by Ryosuke Niwa. This patch is to align WebKit with Gecko / Firefox, Blink / Chromium and Web Specification [1]: [1] https://w3c.github.io/uievents/#interface-wheelevent This patch remoes prefixed non-standard API `initWebKitWheelEvent` from WheelEvent, it was never supported by Gecko and removed by Blink in 2014. All test changes are merged from below Blink commit: Merge: https://src.chromium.org/viewvc/blink?view=revision=179230 * Source/WebCore/dom/WheelEvent.cpp: (WheelEvent::initWebKitWheelEvent): Deleted * Source/WebCore/dom/WheelEvent.h: * Source/WebCore/dom/WheelEvent.idl: * Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMWheelEvent.cpp: (webkit_dom_wheel_event_init_wheel_event): * Source/WebKitLegacy/mac/DOM/DOMWheelEvent.mm: (initWheelEvent): * LayoutTests/fast/events/wheelevent-in-scrolling-div.html: Rebaselined * LayoutTests/fast/events/wheelevent-in-scrolling-div-expected.txt: Ditto * LayoutTests/fast/events/wheelevent-delta-overflow.html: Ditto * LayoutTests/fast/events/wheelevent-delta-overflow-expected.txt: Ditto * LayoutTests/fast/forms/resources/common-wheel-event.js: Update Test Script Canonical link: https://commits.webkit.org/274069@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d6d260: Sync `InputEvent` and `CompositionEvent` with WebI...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d6d2602cfff3fe9880f243845a21f868166cef0b https://github.com/WebKit/WebKit/commit/d6d2602cfff3fe9880f243845a21f868166cef0b Author: Ahmad Saleem Date: 2024-02-04 (Sun, 04 Feb 2024) Changed paths: M Source/WebCore/dom/CompositionEvent.idl M Source/WebCore/dom/InputEvent.idl Log Message: --- Sync `InputEvent` and `CompositionEvent` with WebIDL Specification https://bugs.webkit.org/show_bug.cgi?id=268707 Reviewed by Ryosuke Niwa. This patch is to align WebKit with Web-Specification: [1] https://w3c.github.io/uievents/#idl-inputevent [2] https://w3c.github.io/uievents/#idl-compositionevent Only change is to modify `data` in both interfaces to `USVString` as per below: Web-Spec Issue: https://github.com/w3c/uievents/issues/352 * Source/WebCore/dom/InputEvent.idl: * Source/WebCore/dom/CompositionEvent.idl: Canonical link: https://commits.webkit.org/274067@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55c8a5: Rename `Cloneable` to `Clonable` to align with Web...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55c8a567ee56cf6f488c2a1d6a7675088204bea7 https://github.com/WebKit/WebKit/commit/55c8a567ee56cf6f488c2a1d6a7675088204bea7 Author: Ahmad Saleem Date: 2024-02-03 (Sat, 03 Feb 2024) Changed paths: A LayoutTests/fast/shadow-dom/clonable-shadow-root-expected.txt A LayoutTests/fast/shadow-dom/clonable-shadow-root.html R LayoutTests/fast/shadow-dom/cloneable-shadow-root-expected.txt R LayoutTests/fast/shadow-dom/cloneable-shadow-root.html M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Range.cpp M Source/WebCore/dom/ShadowRoot.cpp M Source/WebCore/dom/ShadowRoot.h M Source/WebCore/dom/ShadowRoot.idl M Source/WebCore/dom/ShadowRootInit.h M Source/WebCore/dom/ShadowRootInit.idl Log Message: --- Rename `Cloneable` to `Clonable` to align with Web Specification wording https://bugs.webkit.org/show_bug.cgi?id=267634 rdar://problem/121516711 Reviewed by Ryosuke Niwa. This patch is just rename of `cloneable` to `clonable` as per web-specification [1]: [1] https://dom.spec.whatwg.org/#shadowroot-clonable * Source/WebCore/dom/ShadowRoot.cpp: (ShadowRoot::ShadowRoot): (ShadowRoot::cloneNodeInternal): * Source/WebCore/dom/ShadowRoot.h: * Source/WebCore/dom/ShadowRoot.idl: * Source/WebCore/dom/ShadowRootInit.h: * LayoutTests/fast/shadow-dom/clonable-shadow-root.html: Renamed from LayoutTests/fast/shadow-dom/cloneable-shadow-root.html and rebaselined * LayoutTests/fast/shadow-dom/clonable-shadow-root-expected.txt: Renamed from LayoutTests/fast/shadow-dom/cloneable-shadow-root-expected.txt and rebaselined Canonical link: https://commits.webkit.org/274063@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 289dfe: Remove unused `ColumnInfo.h`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 289dfe401a1291b1f664366fdbb571ead33c37f7 https://github.com/WebKit/WebKit/commit/289dfe401a1291b1f664366fdbb571ead33c37f7 Author: Ahmad Saleem Date: 2024-02-01 (Thu, 01 Feb 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj R Source/WebCore/rendering/ColumnInfo.h Log Message: --- Remove unused `ColumnInfo.h` https://bugs.webkit.org/show_bug.cgi?id=268545 Reviewed by Tim Nguyen. This patch is to remove `ColumnInfo.h` since it is unused. * Source/WebCore/rendering/ColumnInfo.h: Deleted (desiredColumnWidth): Remove both 'unsigned' and 'LayoutUnit' (setDesiredColumnWidth): Ditto (columnCount): Removed (columnHeight): Ditto (setColumnCountAndHeight): Ditto (setColumnHeight): Ditto (updateMinimumColumnHeight): Remove both 'unsigned' and 'LayoutUnit' (forcedBreaks): Removed (forcedBreakOffset): Ditto (clearForcedBreaks): Ditto (addForcedBreak): Ditto (paginationUnit): Ditto (setPaginationUnit): Ditto (progressionIsInline): Ditto (setProgressionIsInline): Ditto (progressionIsReversed): Ditto (setProgressionIsReversed): Ditto * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Update Canonical link: https://commits.webkit.org/273925@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fba982: Sync `WheelEvent` interface (deltaX, deltaY and de...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fba982021841293d38a888bc7efd7800a070dd5c https://github.com/WebKit/WebKit/commit/fba982021841293d38a888bc7efd7800a070dd5c Author: Ahmad Saleem Date: 2024-02-01 (Thu, 01 Feb 2024) Changed paths: M Source/WebCore/dom/WheelEvent.idl Log Message: --- Sync `WheelEvent` interface (deltaX, deltaY and deltaZ) with Web-Specification https://bugs.webkit.org/show_bug.cgi?id=268514 Reviewed by Ryosuke Niwa. This patch aligns WebKit with Web-Specification [1]: [1] https://w3c.github.io/uievents/#interface-wheelevent As per web-specification, all delta values should be just 'double', so this remove 'unrestricted'. * Source/WebCore/dom/WheelEvent.idl: Canonical link: https://commits.webkit.org/273891@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a245d3: Remove local test copies `svg/dom` in favor of WPT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a245d3c9c9b415a71a95fa1248bbf7586b51b6fb https://github.com/WebKit/WebKit/commit/a245d3c9c9b415a71a95fa1248bbf7586b51b6fb Author: Ahmad Saleem Date: 2024-01-31 (Wed, 31 Jan 2024) Changed paths: R LayoutTests/svg/dom/SVGAnimatedBoolean-expected.txt R LayoutTests/svg/dom/SVGAnimatedBoolean.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFilterElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGGradientElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMarkerElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGMaskElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGPatternElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGTextContentElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGTextPathElement.html R LayoutTests/svg/dom/SVGAnimatedEnumeration-expected.txt R LayoutTests/svg/dom/SVGAnimatedEnumeration.html R LayoutTests/svg/dom/SVGAnimatedInteger-expected.txt R LayoutTests/svg/dom/SVGAnimatedInteger.html R LayoutTests/svg/dom/SVGAnimatedLength-expected.txt R LayoutTests/svg/dom/SVGAnimatedLength.html R LayoutTests/svg/dom/SVGAnimatedLengthList-expected.txt R LayoutTests/svg/dom/SVGAnimatedLengthList.html R LayoutTests/svg/dom/SVGAnimatedNumber-expected.txt R LayoutTests/svg/dom/SVGAnimatedNumber.html R LayoutTests/svg/dom/SVGAnimatedNumberList-expected.txt R LayoutTests/svg/dom/SVGAnimatedNumberList.html R LayoutTests/svg/dom/SVGAnimatedPreserveAspectRatio-expected.txt R LayoutTests/svg/dom/SVGAnimatedPreserveAspectRatio.html R LayoutTests/svg/dom/SVGAnimatedRect-expected.txt R LayoutTests/svg/dom/SVGAnimatedRect.html R LayoutTests/svg/dom/SVGLengthList-appendItem-expected.txt R LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml R LayoutTests/svg/dom/SVGLengthList-basics-expected.txt R LayoutTests/svg/dom/SVGLengthList-basics.xhtml R LayoutTests/svg/dom/SVGLengthList-getItem-expected.txt R LayoutTests/svg/dom/SVGLengthList-getItem.xhtml R LayoutTests/svg/dom/SVGPoint-expected.txt R LayoutTests/svg/dom/SVGPoint.html Log Message: --- Remove local test copies `svg/dom` in favor of WPT Tests https://bugs.webkit.org/show_bug.cgi?id=268432 Reviewed by Simon Fraser. This patch is to remove local copies of tests in 'svg/dom/*' since they are same of WPT Tests in following directory: WPT Directory: svg/types/scripted/* > Deleted Tests & Test Expectations: * LayoutTests/svg/dom/SVGAnimatedBoolean.html: * LayoutTests/svg/dom/SVGAnimatedBoolean-expected.txt: * LayoutTests/svg/dom/SVGPoint.html: * LayoutTests/svg/dom/SVGPoint-expected.txt: * LayoutTests/svg/dom/SVGLengthList-getItem.xhtml: * LayoutTests/svg/dom/SVGLengthList-getItem-expected.txt: * LayoutTests/svg/dom/SVGLengthList-basics.xhtml: * LayoutTests/svg/dom/SVGLengthList-basics-expected.txt: * LayoutTests/svg/dom/SVGLengthList-appendItem.xhtml: * LayoutTests/svg/dom/SVGLengthList-app
[webkit-changes] [WebKit/WebKit] c7afd1: Remove `includePartialGlyphs` argument from `offse...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7afd1bc35e2d071f74e61e392d22cac36246b60 https://github.com/WebKit/WebKit/commit/c7afd1bc35e2d071f74e61e392d22cac36246b60 Author: Ahmad Saleem Date: 2024-01-31 (Wed, 31 Jan 2024) Changed paths: M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp M Source/WebCore/rendering/svg/SVGInlineTextBox.h Log Message: --- Remove `includePartialGlyphs` argument from `offsetForPositionInFragment` since it is always true https://bugs.webkit.org/show_bug.cgi?id=268438 Reviewed by Simon Fraser. This patch removes 'includePartialGlyphs' as argument from function and just add directly since it is always true. Accordingly, also update relevant call-site in 'positionForPoint'. * Source/WebCore/rendering/svg/SVGInlineTextBox.cpp: (SVGInlineTextBox::offsetForPositionInFragment): * Source/WebCore/rendering/svg/SVGInlineTextBox.h: * Source/WebCore/rendering/svg/RenderSVGInlineText.cpp: (RenderSVGInlineText::positionForPoint): Canonical link: https://commits.webkit.org/273833@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2b0818: Remove accidentally added `captions.css` by 247182...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2b0818bd25407e30b5d42d1d93e8885752325b4b https://github.com/WebKit/WebKit/commit/2b0818bd25407e30b5d42d1d93e8885752325b4b Author: Ahmad Saleem Date: 2024-01-30 (Tue, 30 Jan 2024) Changed paths: R Source/WebCore/css/captions.css Log Message: --- Remove accidentally added `captions.css` by 247182@main https://bugs.webkit.org/show_bug.cgi?id=268296 Reviewed by Anne van Kesteren. This patch is to remove `captions.css`, which seems accidentally added in 247182@main and it was not referenced in the change-log of commit and seems to be unused. * Source/WebCore/css/captions.css: Deleted Canonical link: https://commits.webkit.org/273775@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df7782: Sync and update 'which' across KeyboardEvent, Mous...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df7782c2b48baf7b7f2c5c23912ea4754232fc11 https://github.com/WebKit/WebKit/commit/df7782c2b48baf7b7f2c5c23912ea4754232fc11 Author: Ahmad Saleem Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M Source/WebCore/dom/KeyboardEvent.cpp M Source/WebCore/dom/KeyboardEvent.h M Source/WebCore/dom/KeyboardEvent.idl M Source/WebCore/dom/MouseEvent.cpp M Source/WebCore/dom/MouseEvent.h M Source/WebCore/dom/UIEvent.cpp M Source/WebCore/dom/UIEvent.h M Source/WebCore/dom/UIEvent.idl Log Message: --- Sync and update 'which' across KeyboardEvent, MouseEvent and UIEvent interfaces as per web specification https://bugs.webkit.org/show_bug.cgi?id=253366 rdar://problem/106580687 Reviewed by Ryosuke Niwa. This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web Specifications [1], [2] and [3]. [1] https://w3c.github.io/uievents/#idl-uievent [2] https://w3c.github.io/uievents/#idl-keyboardevent [3] https://w3c.github.io/uievents/#idl-mouseevent This patch modifies 'which' to be 'unsigned' as per web-specification and also remove it from 'KeyboardEvent'. Merge: https://chromium.googlesource.com/chromium/src.git/+/cf13270c47f29b21ce7a8c937f598989cd66c840 * Source/WebCore/dom/KeyboardEvent.cpp: (KeyboardEvent::which): * Source/WebCore/dom/KeyboardEvent.h: * Source/WebCore/dom/KeyboardEvent.idl: * Source/WebCore/dom/MouseEvent.cpp: (MouseEvent::which): * Source/WebCore/dom/MouseEvent.h: * Source/WebCore/dom/UIEvent.cpp: (UIEvent::which): * Source/WebCore/dom/UIEvent.h: * Source/WebCore/dom/UIEvent.idl: Remove FIXME and align with web-spec Canonical link: https://commits.webkit.org/273701@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba575d: XMLTreeViewer::transformDocumentToTreeView should ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba575dadde29513f46fdb6fb181030d1e5fadaf7 https://github.com/WebKit/WebKit/commit/ba575dadde29513f46fdb6fb181030d1e5fadaf7 Author: Ahmad Saleem Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M Source/WebCore/xml/XMLTreeViewer.cpp Log Message: --- XMLTreeViewer::transformDocumentToTreeView should not call didChangeActiveStyleSheetCandidates https://bugs.webkit.org/show_bug.cgi?id=250976 rdar://problem/104797532 Reviewed by Ryosuke Niwa. Merge: https://chromium.googlesource.com/chromium/blink/+/7654964eebca76141b8c44ef2f369d547963f577 transformDocumentToTreeView was calling didChangeActiveStyleSheetCandidates after updating the text inside a `style` element. This isn't necessary since we already updated the stylesheets. * Source/WebCore/xml/XMLTreeViewer.cpp: (XMLTreeViewer::transformDocumentToTreeView): Canonical link: https://commits.webkit.org/273689@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d7621e: Rename argument 'xValue' for `setY` in SVGRect.h t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d7621ef52d44fd96e9bfb1d98d14f76260a5fe64 https://github.com/WebKit/WebKit/commit/d7621ef52d44fd96e9bfb1d98d14f76260a5fe64 Author: Ahmad Saleem Date: 2024-01-28 (Sun, 28 Jan 2024) Changed paths: M Source/WebCore/svg/SVGRect.h Log Message: --- Rename argument 'xValue' for `setY` in SVGRect.h to be more consistent https://bugs.webkit.org/show_bug.cgi?id=268267 Reviewed by Charlie Wolfe. This PR is just rename of argument to be more consistent with function name. i.e., `setX = xValue` and `setY = yValue` * Source/WebCore/svg/SVGRect.h: (setY): Canonical link: https://commits.webkit.org/273636@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2c8860: MerchantValidationEvent's validationURL should use...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2c886037b3061f1b3dbe86fd959608645af9b132 https://github.com/WebKit/WebKit/commit/2c886037b3061f1b3dbe86fd959608645af9b132 Author: Ahmad Saleem Date: 2024-01-28 (Sun, 28 Jan 2024) Changed paths: M LayoutTests/imported/w3c/resources/import-expectations.json A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/META.yml A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/complete-method.tentative.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/complete-method.tentative.https.html A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/constructor.tentative.http-expected.txt A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/constructor.tentative.http.html A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/constructor.tentative.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/constructor.tentative.https.html A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/onmerchantvalidation-attribute.https-expected.txt A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/onmerchantvalidation-attribute.https.html A LayoutTests/imported/w3c/web-platform-tests/merchant-validation/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/complete-method.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/complete-method.https.html R LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/constructor.http-expected.txt R LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/constructor.http.html R LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/constructor.https-expected.txt R LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/constructor.https.html R LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/w3c-import.log M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp Log Message: --- MerchantValidationEvent's validationURL should use 'completeURL' to resolve document baseURL https://bugs.webkit.org/show_bug.cgi?id=216530 rdar://problem/69023893 Reviewed by Anne van Kesteren. This patch is to use completeURL() from Document in MerchantValidationEvent's validationURL, so it can be resolved against document baseURL [1]. By leveraging completeURL(), we achieve this and also align with CSS and HTML URL Parsing standards (i.e. forcing UTF8) and make this future proof. [1] https://w3c.github.io/merchant-validation/#merchantvalidationevent-constructor "Let validationURL be the result of URL parsing eventInitDict.validationURL and base." Additionally, we didn't had the WPT test cases imported, so this PR import them from upstream. Upstream Hash: https://github.com/web-platform-tests/wpt/commit/adc1ac02e6d8e080508325ab4525bab8d09177a6 > Change: * Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp: (MerchantValidationEvent::create): > WPT Test Cases & Test Expectations: * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/META.yml: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/complete-method.tentative.https.html: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/complete-method.tentative.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/constructor.tentative.http.html: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/constructor.tentative.http-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/constructor.tentative.https.html: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/constructor.tentative.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/onmerchantvalidation-attribute.https.html: * LayoutTests/imported/w3c/web-platform-tests/merchant-validation/onmerchantvalidation-attribute.https-expected.txt: * LayoutTests/platform/glib/TestExpectations: Add Platform Specific Expectations * LayoutTests/platform/mac-wk1/TestExpectations: Ditto > Remove old imported WPT tests: * LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/complete-method.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/payment-request/MerchantValidationEvent/complete-method.https.html: * LayoutTests/im
[webkit-changes] [WebKit/WebKit] 4daa78: Remove local test copies (svg-in-object-*) in favo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4daa780ad8d6eacc14bde29a227788cf91ed6a29 https://github.com/WebKit/WebKit/commit/4daa780ad8d6eacc14bde29a227788cf91ed6a29 Author: Ahmad Saleem Date: 2024-01-27 (Sat, 27 Jan 2024) Changed paths: M LayoutTests/TestExpectations R LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-auto-expected.txt R LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-auto.html R LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-fixed-expected.txt R LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-fixed.html R LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-percentage-expected.txt R LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-percentage.html R LayoutTests/svg/as-object/sizing/svg-in-object.js Log Message: --- Remove local test copies (svg-in-object-*) in favor of WPT Tests case of 'svg-embedded-sizing' https://bugs.webkit.org/show_bug.cgi?id=132791 Reviewed by Simon Fraser. This patch is to remove local copies of tests in 'svg/as-object/svg-in-object-*' since they are same of WPT Tests in following directory and the WPT tests are not skipped as well. WPT Directory: html/rendering/replaced-elements/svg-embedded-sizing/ Test Names: svg-in-object-auto.html , svg-in-object-fixed.html , svg-in-object-percentage.html > Deleted Tests, Test Expectations and resource script: * LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-auto-expected.txt: * LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-auto.html: * LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-fixed-expected.txt: * LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-fixed.html: * LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-percentage-expected.txt: * LayoutTests/svg/as-object/sizing/svg-in-object-placeholder-height-percentage.html: * LayoutTests/svg/as-object/sizing/svg-in-object.js: > Update Test Expectation: * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/273616@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 268bc3: Sync 'html/dom/elements/global-attributes' from WP...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 268bc370a22870886301f87d4121d9d6e1d36708 https://github.com/WebKit/WebKit/commit/268bc370a22870886301f87d4121d9d6e1d36708 Author: Ahmad Saleem Date: 2024-01-25 (Thu, 25 Jan 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-assorted.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-assorted.window.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-assorted.window.js A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-div-append-child-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-div-append-child.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-dynamic-changes.window-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-dynamic-changes.window.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-dynamic-changes.window.js M LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-auto-form-associated.window.js A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-01-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-01-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-01.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-02-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-02-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-02.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-03-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-03-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-03.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-04-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-04-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-04.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-05-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-05-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-05.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-06-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-06-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-06.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-07-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-07-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-07.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-08-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-08-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-08.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-09-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-09-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-09.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-10-expected.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-10-ref.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir-shadow-10.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global
[webkit-changes] [WebKit/WebKit] bba680: Remove non-standard `KeyboardEvent.keyLocation`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bba680e17fee76325be7facc38899eda3f43d419 https://github.com/WebKit/WebKit/commit/bba680e17fee76325be7facc38899eda3f43d419 Author: Ahmad Saleem Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt M LayoutTests/fast/events/constructors/keyboard-event-constructor.html M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-option-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-shift-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-control-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-option-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-shift-expected.txt M LayoutTests/fast/events/ios/key-events-comprehensive/key-events-shift-expected.txt M Source/WebCore/dom/KeyboardEvent.cpp M Source/WebCore/dom/KeyboardEvent.h M Source/WebCore/dom/KeyboardEvent.idl Log Message: --- Remove non-standard `KeyboardEvent.keyLocation` https://bugs.webkit.org/show_bug.cgi?id=267819 Reviewed by Ryosuke Niwa. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium by removing non-standard KeyboardEvent.keyLocation (alias of 'location'). It is not in web-specification [1]. [1] https://w3c.github.io/uievents/#events-keyboardevents It was never shipped in Gecko / Firefox while removed in Blink in 2016 and with commit [2]: [2] https://chromium.googlesource.com/chromium/src.git/+/263d94f9b2dc4a0a3cf5b3124c1cc8d2163a4410 * Source/WebCore/dom/KeyboardEvent.cpp: (KeyboardEvent::KeyboardEvent): * Source/WebCore/dom/KeyboardEvent.h: * Source/WebCore/dom/KeyboardEvent.idl: * LayoutTests/fast/events/constructors/keyboard-event-constructor.html: Rebaselined * LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt: Rebaselined * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-expected.txt: Rebaselined * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-option-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-control-shift-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-control-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-option-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-meta-shift-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-option-shift-expected.txt: Ditto * LayoutTests/fast/events/ios/key-events-comprehensive/key-events-shift-expected.txt: Ditto Canonical link: https://commits.webkit.org/273457@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ae38a: [Gardening] `CSSStyleSheet-constructable-concat.ht...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ae38a7f4c08fa8fbc9041e8cb52e5693eda0b1c https://github.com/WebKit/WebKit/commit/0ae38a7f4c08fa8fbc9041e8cb52e5693eda0b1c Author: Ahmad Saleem Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: R LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-concat-expected.txt Log Message: --- [Gardening] `CSSStyleSheet-constructable-concat.html` is reftest and should not have '-expected.txt' file https://bugs.webkit.org/show_bug.cgi?id=267997 Reviewed by Anne van Kesteren. The test is 'reftest' and should not have `-expected.txt` file, this PR removes it. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSSStyleSheet-constructable-concat-expected.txt: Deleted Canonical link: https://commits.webkit.org/273418@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f1f9f0: Remove non-standard `KeyboardEvent.altGraphKey`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f1f9f0045afe3ae23d359d72658b600e4a623ac5 https://github.com/WebKit/WebKit/commit/f1f9f0045afe3ae23d359d72658b600e4a623ac5 Author: Ahmad Saleem Date: 2024-01-23 (Tue, 23 Jan 2024) Changed paths: M LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt M LayoutTests/fast/events/constructors/keyboard-event-constructor.html M LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt M LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html M LayoutTests/fast/events/constructors/mouse-event-getModifierState-expected.txt M LayoutTests/fast/events/constructors/mouse-event-getModifierState.html M LayoutTests/fast/events/init-event-clears-capslock-expected.txt M LayoutTests/fast/events/init-event-clears-capslock.html M LayoutTests/fast/events/init-events-expected.txt M LayoutTests/fast/events/init-events.html M LayoutTests/fast/forms/tabs-with-modifiers-expected.txt M LayoutTests/fast/forms/tabs-with-modifiers.html M Source/WebCore/dom/KeyboardEvent.cpp M Source/WebCore/dom/KeyboardEvent.h M Source/WebCore/dom/KeyboardEvent.idl M Source/WebCore/dom/UIEventWithKeyState.cpp M Source/WebCore/dom/UIEventWithKeyState.h M Source/WebCore/html/HTMLSelectElementWin.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMKeyboardEvent.cpp M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKitLegacy/mac/DOM/DOMKeyboardEvent.mm Log Message: --- Remove non-standard `KeyboardEvent.altGraphKey` https://bugs.webkit.org/show_bug.cgi?id=248394 Reviewed by Chris Dumez. This pach aligns WebKit with Gecko / Firefox and Blink / Chromium by removing non-standard KeyboardEvent.altGraphKey. It is not in web-specification [1]. [1] https://www.w3.org/TR/uievents/ It was never shipped in Gecko / Firefox while removed in Blink in 2014 and with commit [2]: [2] https://src.chromium.org/viewvc/blink?view=revision=179545 > Files modified: * Source/WebCore/dom/KeyboardEvent.cpp: (KeyboardEvent::initKeyboardEvent): * Source/WebCore/dom/KeyboardEvent.h: * Source/WebCore/dom/KeyboardEvent.idl: * Source/WebCore/dom/UIEventWithKeyState.cpp: (UIEventWithKeyState::getModifierState): (UIEventWithKeyState::setModifierKeys): * Source/WebCore/dom/UIEventWithKeyState.h: * Source/WebCore/html/HTMLSelectElementWin.cpp: (HTMLSelectElement::platformHandleKeydownEvent): * Source/WebCore/page/EventHandler.cpp: (EventHandler::defaultPageUpDownEventHandler): (EventHandler::defaultHomeEndEventHandler): (EventHandler::defaultArrowEventHandler(): (EventHandler::defaultTabEventHandler): * Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMKeyboardEvent.cpp: (webkit_dom_keyboard_event_init_keyboard_event): (webkit_dom_keyboard_event_get_alt_graph_key): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm: (PDFPluginTextAnnotation::value): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebPage::handleKeyEventByRelinquishingFocusToChrome): * Source/WebKitLegacy/mac/DOM/DOMKeyboardEvent.mm: ((BOOL)altGraphKey): ((void)initKeyboardEvent): > Tests Rebaselined / Updated: * LayoutTests/fast/forms/tabs-with-modifiers.html: * LayoutTests/fast/forms/tabs-with-modifiers-expected.txt: * LayoutTests/fast/events/init-events.html: * LayoutTests/fast/events/init-events-expected.txt: * LayoutTests/fast/events/init-event-clears-capslock.html: * LayoutTests/fast/events/init-event-clears-capslock-expected.txt: * LayoutTests/fast/events/constructors/mouse-event-getModifierState.html: * LayoutTests/fast/events/constructors/mouse-event-getModifierState-expected.txt: * LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html: * LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt: * LayoutTests/fast/events/constructors/keyboard-event-constructor.html: * LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt: Canonical link: https://commits.webkit.org/273379@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15c6ce: Make the SVG parser interpret `form feed` as white...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15c6cea827c0761eb8c1b8638fc12568bf4170b3 https://github.com/WebKit/WebKit/commit/15c6cea827c0761eb8c1b8638fc12568bf4170b3 Author: Ahmad Saleem Date: 2024-01-23 (Tue, 23 Jan 2024) Changed paths: A LayoutTests/svg/transforms/svg-formFeed-as-whitespace-expected.html A LayoutTests/svg/transforms/svg-formFeed-as-whitespace.html A LayoutTests/svg/transforms/svg-line-tabulation-as-not-whitespace-expected.html A LayoutTests/svg/transforms/svg-line-tabulation-as-not-whitespace.html M Source/WebCore/svg/SVGParserUtilities.cpp M Source/WebCore/svg/SVGParserUtilities.h M Source/WebCore/svg/SVGStringList.cpp Log Message: --- Make the SVG parser interpret `form feed` as whitespace https://bugs.webkit.org/show_bug.cgi?id=77755 rdar://problem/95488677 Reviewed by Anne van Kesteren. This patch is to align WebKit with Chromium / Blink, Gecko / Firefox and Web Specification [1]: [1] https://lists.w3.org/Archives/Public/public-svg-wg/2014AprJun/0068.html This patch uses 'isASCIIWhite' across SVG Parser and code base to enable it to handle 'form feed'. It is inspired by following change in Blink, which enables 'leading' and 'trailing' whitespace in SVG Attributes [2]: [2] https://src.chromium.org/viewvc/blink?view=revision=175785 Credits to Jacob Goldstein for 'test case'. * Source/WebCore/svg/SVGParserUtilities.cpp: (parseGlyphName): * Source/WebCore/svg/SVGParserUtilities.h: (isSVGSpace): Deleted (isSVGSpaceOrComma): Updated (skipOptionalSVGSpaces): (skipOptionalSVGSpacesOrDelimiter): Both templates * Source/WebCore/svg/SVGStringList.cpp: (SVGStringList::parse): * LayoutTests/svg/transforms/svg-formFeed-as-whitespace.html: Add Test Case * LayoutTests/svg/transforms/svg-formFeed-as-whitespace-expected.html: Add Test Case Expectation * LayoutTests/svg/transforms/svg-line-tabulation-as-not-whitespace.html: Add Test Case * LayoutTests/svg/transforms/svg-line-tabulation-as-not-whitespace-expected.html: Add Test Case Expectation Canonical link: https://commits.webkit.org/273353@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f95c85: RenderListBox::size() should be 'unsigned' instead...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f95c858b517e265064bba68c07f970beaf38394f https://github.com/WebKit/WebKit/commit/f95c858b517e265064bba68c07f970beaf38394f Author: Ahmad Saleem Date: 2024-01-22 (Mon, 22 Jan 2024) Changed paths: M Source/WebCore/rendering/RenderListBox.cpp M Source/WebCore/rendering/RenderListBox.h Log Message: --- RenderListBox::size() should be 'unsigned' instead of 'int' https://bugs.webkit.org/show_bug.cgi?id=267854 Reviewed by Simon Fraser. This patch is to align size() function with HTMLSelectElement `size`, which is 'unsigned long' so 'int' should be aligned to have 'unsigned' as well in rendering code. * Source/WebCore/rendering/RenderListBox.cpp: (RenderListBox::size): * Source/WebCore/rendering/RenderListBox.h: Canonical link: https://commits.webkit.org/273312@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 744d12: Fix LayoutTest transitions/flex-transitions.html b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 744d1201a37974e2c5235684ddf3a83659dbe6ae https://github.com/WebKit/WebKit/commit/744d1201a37974e2c5235684ddf3a83659dbe6ae Author: Ahmad Saleem Date: 2024-01-20 (Sat, 20 Jan 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/transitions/flex-transitions-expected.txt M LayoutTests/transitions/flex-transitions.html Log Message: --- Fix LayoutTest transitions/flex-transitions.html by syncing from Blink / Chromium upstream https://bugs.webkit.org/show_bug.cgi?id=125894 Reviewed by Antoine Quint. Merge: https://chromium.googlesource.com/chromium/blink/+/40cc24abe770f2fd20d9a09c60cf87502c28063a & https://source.chromium.org/chromium/chromium/src/+/cb4809f7770d86811559c3f39ed0cbc308a73887 Update the expected results to account for the fact that flex-grow and flex-shrink don't interpolate smoothly to or from zero. Also update the test to use values of similar magnitudes for each part of the property shorthand, to allow the tolerance to be applied meaningfully. * LayoutTests/transitions/flex-transitions.html: Updated * LayoutTests/transitions/flex-transitions-expected.txt: Ditto * LayoutTests/TestExpectations: Remove the test expectation Canonical link: https://commits.webkit.org/273266@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5c3202: [Part 2] Update/Remove tests relying on 'getProper...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5c32022a6685577c3d1621fcbf1ca827ec50e509 https://github.com/WebKit/WebKit/commit/5c32022a6685577c3d1621fcbf1ca827ec50e509 Author: Ahmad Saleem Date: 2024-01-20 (Sat, 20 Jan 2024) Changed paths: M LayoutTests/fast/css/border-width-large-expected.txt M LayoutTests/fast/css/border-width-large.html M LayoutTests/fast/css/getComputedStyle/computed-style-page-break-inside-expected.txt M LayoutTests/fast/css/getComputedStyle/computed-style-page-break-inside.html M LayoutTests/fast/css/inherited-properties-explicit-expected.txt M LayoutTests/fast/css/inherited-properties-explicit.html M LayoutTests/fast/css/inherited-properties-rare-text.html M LayoutTests/fast/css/large-value-csstext.html M LayoutTests/transitions/multiple-text-shadow-transition.html Log Message: --- [Part 2] Update/Remove tests relying on 'getPropertyCSSValue' https://bugs.webkit.org/show_bug.cgi?id=266052 rdar://problem/119700175 Reviewed by Tim Nguyen. This PR is to update tests relying on historical 'CSS' properties and make it easier to remove them in future. Partial Merge: https://src.chromium.org/viewvc/blink?view=revision=184925 , https://src.chromium.org/viewvc/blink?view=revision=184988 and https://src.chromium.org/viewvc/blink?view=revision=185165 > Rebaselined Tests & Expectations: * LayoutTests/fast/css/border-width-large.html: * LayoutTests/fast/css/border-width-large-expected.txt: * LayoutTests/fast/css/getComputedStyle/computed-style-font.html: * LayoutTests/fast/css/getComputedStyle/computed-style-font-expected.txt: * LayoutTests/fast/css/inherited-properties-explicit.html: * LayoutTests/fast/css/inherited-properties-explicit-expected.txt: * LayoutTests/fast/css/inherited-properties-rare-text.html: * LayoutTests/transitions/multiple-text-shadow-transition.html: * LayoutTests/fast/css/large-value-csstext.html: Canonical link: https://commits.webkit.org/273265@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 54ef5b: Fix typo 'traget' in SVGTextLayoutEngine::beginTex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 54ef5b20caa43058def253267469fb0475b31c9f https://github.com/WebKit/WebKit/commit/54ef5b20caa43058def253267469fb0475b31c9f Author: Ahmad Saleem Date: 2024-01-19 (Fri, 19 Jan 2024) Changed paths: M Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp Log Message: --- Fix typo 'traget' in SVGTextLayoutEngine::beginTextPathLayout https://bugs.webkit.org/show_bug.cgi?id=267797 Reviewed by Simon Fraser. This patch is to just fix typo error of 'traget' instead of 'target' in SVGTextLayoutEngine::beginTextPathLayout. * Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp: (SVGTextLayoutEngine::beginTextPathLayout): Canonical link: https://commits.webkit.org/273250@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15904f: Fix 'failing' test expectation of 'input-date-vali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15904f94fa7a97638ec60c4785345864fd288d1c https://github.com/WebKit/WebKit/commit/15904f94fa7a97638ec60c4785345864fd288d1c Author: Ahmad Saleem Date: 2024-01-19 (Fri, 19 Jan 2024) Changed paths: M LayoutTests/fast/forms/date/input-date-validation-message-expected.txt M LayoutTests/fast/forms/date/input-date-validation-message.html Log Message: --- Fix 'failing' test expectation of 'input-date-validation-message.html' https://bugs.webkit.org/show_bug.cgi?id=267761 Reviewed by Aditya Keerthi. This patch is to update test to use 'js-test.js' and also fix 'invalidation message' being incorrect in test from the expectation leading to test failures. * LayoutTests/fast/forms/date/input-date-validation-message.html: Updated * LayoutTests/fast/forms/date/input-date-validation-message-expected.txt: Ditto Canonical link: https://commits.webkit.org/273237@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 80993f: Avoid traversing the FrameTree up in FrameTree::top()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80993fda030b571a3937b08f8809b50d72b61855 https://github.com/WebKit/WebKit/commit/80993fda030b571a3937b08f8809b50d72b61855 Author: Ahmad Saleem Date: 2024-01-19 (Fri, 19 Jan 2024) Changed paths: M Source/WebCore/page/FrameTree.cpp Log Message: --- Avoid traversing the FrameTree up in FrameTree::top() https://bugs.webkit.org/show_bug.cgi?id=185394 Reviewed by Chris Dumez. Credits & Patch Authored by Chris Dumez. Avoid traversing the FrameTree up in FrameTree::top() and rely on Frame::mainFrame() instead to get the answer right away. There is a potential behavior change if calling FrameTree::top() on a detached frame (it will keep return the main frame now instead of returning the frame itself). However, it should not matter in practice as we should not be dealing with the FrameTree of a detached frame. * Source/WebCore/page/FrameTree.cpp: (FrameTree::top): Canonical link: https://commits.webkit.org/273230@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ba9ec2: Sync 'svg-root-lengths.html' from Blink / Chromium...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ba9ec2f8082f6c3842b3ad15b16062d033d525ee https://github.com/WebKit/WebKit/commit/ba9ec2f8082f6c3842b3ad15b16062d033d525ee Author: Ahmad Saleem Date: 2024-01-17 (Wed, 17 Jan 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/svg/dom/svg-root-lengths-expected.txt M LayoutTests/svg/dom/svg-root-lengths.html Log Message: --- Sync 'svg-root-lengths.html' from Blink / Chromium to fix flakiness https://bugs.webkit.org/show_bug.cgi?id=148925 Reviewed by Tim Nguyen. This patch is to sync 'svg-root-lengths.html' from Blink / Chromium to fix flakiness since the upstream uses 'js-test.js' and don't have 'setTimeout' especially latter to remove flakiness. In order to confirm this does not lead to flakiness, I ran following as mentioned in bug: run-webkit-tests svg/dom/svg-root-lengths.html --repeat 1000 --no-build --no-retry --force -f and above does not lead to any flakiness or failures. Blink Source (Merge): https://source.chromium.org/chromium/chromium/src/+/c639b683032f5f16b6b11c16021bdca69bc7cd6b * LayoutTests/TestExpectations: Remove flakiness expectation * LayoutTests/svg/dom/svg-root-lengths.html: Updated from Blink Source * LayoutTests/svg/dom/svg-root-lengths-expected.txt: Updated Expectation Canonical link: https://commits.webkit.org/273156@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a40fb1: Remove 'SVGAnimatedAngle.html' local test copy in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a40fb1bfc84684d27b79eb4d1b7dd55d63427d22 https://github.com/WebKit/WebKit/commit/a40fb1bfc84684d27b79eb4d1b7dd55d63427d22 Author: Ahmad Saleem Date: 2024-01-17 (Wed, 17 Jan 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations R LayoutTests/svg/dom/SVGAnimatedAngle-expected.txt R LayoutTests/svg/dom/SVGAnimatedAngle.html Log Message: --- Remove 'SVGAnimatedAngle.html' local test copy in favor of WPT Test https://bugs.webkit.org/show_bug.cgi?id=267642 Reviewed by Rob Buis. This patch is to remove local copy of test in favor of WPT test copy below: > imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedAngle.html * LayoutTests/svg/dom/SVGAnimatedAngle.html: Removed * LayoutTests/svg/dom/SVGAnimatedAngle-expected.txt: Removed * LayoutTests/platform/ios/TestExpectations: Removed 'deleted' test expectation Canonical link: https://commits.webkit.org/273139@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2379c: Remove additional UA stylesheet rule for `audio` e...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2379cbda4fa28879673e949ae84b5c4a6095fc3 https://github.com/WebKit/WebKit/commit/f2379cbda4fa28879673e949ae84b5c4a6095fc3 Author: Ahmad Saleem Date: 2024-01-16 (Tue, 16 Jan 2024) Changed paths: M Source/WebCore/css/mediaControls.css Log Message: --- Remove additional UA stylesheet rule for `audio` element from mediaControls.css https://bugs.webkit.org/show_bug.cgi?id=267615 Reviewed by Eric Carlson. We have an additional UA stylesheet rule for `audio` element in 'html.css' added by 223534@main, when modern media controls were enabled. The commit tried to consolidate and remove `audio` element UA rules from other files (i.e., mediaControlsApple.css) but forgot to remove this one. This patch is to remove it as well and rely on 'html.css' as single source of truth. * Source/WebCore/css/mediaControls.css: (audio): Removed Canonical link: https://commits.webkit.org/273114@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0100fa: Remove unneeded flow thread awareness from accumul...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0100fa2b12eeea5c040c6054a13ca737ca323719 https://github.com/WebKit/WebKit/commit/0100fa2b12eeea5c040c6054a13ca737ca323719 Author: Ahmad Saleem Date: 2024-01-16 (Tue, 16 Jan 2024) Changed paths: M Source/WebCore/rendering/RenderLayer.cpp Log Message: --- Remove unneeded flow thread awareness from accumulateOffsetTowardsAncestor() https://bugs.webkit.org/show_bug.cgi?id=257937 rdar://problem/110946829 Reviewed by Simon Fraser. Merge: https://src.chromium.org/viewvc/blink?view=revision=183313 This code was used for old CSS Regions Multicolumn implementation, so this is clean-up patch. * Source/WebCore/rendering/RenderLayer.cpp: (accumulateOffsetTowardsAncestor): Canonical link: https://commits.webkit.org/273085@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 31a93a: Remove unused inline function `checkForRepaint` fr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 31a93adb3d725161ede333a80f3a6410200fd14f https://github.com/WebKit/WebKit/commit/31a93adb3d725161ede333a80f3a6410200fd14f Author: Ahmad Saleem Date: 2024-01-15 (Mon, 15 Jan 2024) Changed paths: M Source/WebCore/rendering/LayoutRepainter.h Log Message: --- Remove unused inline function `checkForRepaint` from `LayoutRepainter.h` https://bugs.webkit.org/show_bug.cgi?id=267556 Reviewed by Alan Baradlay. This patch is to remove unused inline function `checkForRepaint` from `LayoutRepainter.h`. * Source/WebCore/rendering/LayoutRepainter.h: Canonical link: https://commits.webkit.org/273051@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7adc3d: Replaced elements avoid floats, including check bo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7adc3dd2a2260a3dd133dbc2245a9be5b8b78772 https://github.com/WebKit/WebKit/commit/7adc3dd2a2260a3dd133dbc2245a9be5b8b78772 Author: Ahmad Saleem Date: 2024-01-15 (Mon, 15 Jan 2024) Changed paths: A LayoutTests/fast/block/float/checkbox-and-radio-avoid-floats-expected.txt A LayoutTests/fast/block/float/checkbox-and-radio-avoid-floats.html M Source/WebCore/rendering/RenderBox.cpp Log Message: --- Replaced elements avoid floats, including check boxes and radio boxes when turned into block box https://bugs.webkit.org/show_bug.cgi?id=264770 rdar://problem/118660695 Reviewed by Alan Baradlay. This patch aligns WebKit with Blink / Chromium and Gecko / Firefox. Merge: https://chromium.googlesource.com/chromium/blink/+/141235180acceb7bbdd50a315c31171dfcf55a07 This bug is reproducible when the input box is turned into a block box (by default their display type value is inline-block and inline layout handles such cases just fine i.e. they do avoid floats). Check boxes and radio boxes are the odd man out among form control elements: they neither have their own renderer class with which to override avoidFloats nor are they isReplaced(). If the case for making form control elements isReplaced() builds further than it may be worth looking at including them in that effort but for now just replaced the isReplaced() check in avoidsFloats() with a more inclusive alternative. * Source/WebCore/rendering/RenderBox.cpp: (RenderBox::avoidsFloats): * LayoutTests/fast/block/float/checkbox-and-radio-avoid-floats.html: Add Test Case * LayoutTests/fast/block/float/checkbox-and-radio-avoid-floats-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/273047@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a1e03: Remove two unused functions from `Editor.cpp|h`
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a1e03344a23ee581bec8e302365a9b54f8cd2cc https://github.com/WebKit/WebKit/commit/2a1e03344a23ee581bec8e302365a9b54f8cd2cc Author: Ahmad Saleem Date: 2024-01-12 (Fri, 12 Jan 2024) Changed paths: M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/Editor.h Log Message: --- Remove two unused functions from `Editor.cpp|h` https://bugs.webkit.org/show_bug.cgi?id=267474 Reviewed by Ryosuke Niwa. This patch is to remove two unused functions (indent & outdent) in Editor.cpp|h. * Source/WebCore/editing/Editor.cpp: (Editor::indent): Removed (Editor::outdent): Removed * Source/WebCore/editing/Editor.h: Remove above deleted functions definition Canonical link: https://commits.webkit.org/273005@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6d4c6: Update 'bogus-dropEffect-effectAllowed' to account...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6d4c6154380b7278662043aed49944d933b30ef https://github.com/WebKit/WebKit/commit/f6d4c6154380b7278662043aed49944d933b30ef Author: Ahmad Saleem Date: 2024-01-10 (Wed, 10 Jan 2024) Changed paths: M LayoutTests/fast/events/bogus-dropEffect-effectAllowed-expected.txt M LayoutTests/fast/events/bogus-dropEffect-effectAllowed.html Log Message: --- Update 'bogus-dropEffect-effectAllowed' to account for 'empty String', 'null' and 'undefined' https://bugs.webkit.org/show_bug.cgi?id=267233 Reviewed by Wenson Hsieh. Merge: https://src.chromium.org/viewvc/blink?view=revision=197013 This test is to update 'bogus-dropEffect-effectAllowed' test to account for 'empty String', 'null' and 'undefined' results for m_dropEffect as none and m_effectAllowed as uninitialized. * LayoutTests/fast/events/bogus-dropEffect-effectAllowed.html: Updated * LayoutTests/fast/events/bogus-dropEffect-effectAllowed-expected.txt: Updated Test Case Expectation Canonical link: https://commits.webkit.org/272888@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2efdea: Negative SVGTransform scale values should be corre...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2efdea0ba354c2758bfa2a8c6a262e411fc6c4f8
https://github.com/WebKit/WebKit/commit/2efdea0ba354c2758bfa2a8c6a262e411fc6c4f8
Author: Ahmad Saleem
Date: 2024-01-10 (Wed, 10 Jan 2024)
Changed paths:
A LayoutTests/svg/transforms/negative-scale-value-expected.txt
A LayoutTests/svg/transforms/negative-scale-value.html
M Source/WebCore/svg/SVGTransformValue.h
Log Message:
---
Negative SVGTransform scale values should be correctly stringified
https://bugs.webkit.org/show_bug.cgi?id=264752
rdar://problem/118656892
Reviewed by Said Abou-Hallawa.
This patch is to align WebKit with Blink / Chromium and partially with Gecko /
Firefox.
Merge:
https://chromium.googlesource.com/chromium/blink/+/8a7252a2602bd8067c83d48c8fd525ef322708c2
Before this patch, SVGTransformValue::appendScale used
AffineTransform::{x,y}Scale},
which computed transform scale values by computing norm of projected unit
vectors.
However, that would always return positive values, even if negative scale
values were specified.
This patch changes the implementation to use `a` and `d` values instead. This
is valid,
as the scale matrix is guaranteed to be in the below simple form when the
transform has
type `SVG_TRANSFORM_SCALE`.
|xscale0 0|
| 0 yscale 0|
* Source/WebCore/svg/SVGTransformValue.h:
(appendScale):
* LayoutTests/svg/transforms/negative-scale-value.html: Add Test Case
* LayoutTests/svg/transforms/negative-scale-value-expected.txt: Add Test Case
Expectation
Canonical link: https://commits.webkit.org/272885@main
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e73b80: Add more integer overflow tests for `enclosingIntR...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e73b8072d7b44b4246dd5a7dfdbad3de3b085d38 https://github.com/WebKit/WebKit/commit/e73b8072d7b44b4246dd5a7dfdbad3de3b085d38 Author: Ahmad Saleem Date: 2024-01-08 (Mon, 08 Jan 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp Log Message: --- Add more integer overflow tests for `enclosingIntRect` in FloatRectTests.cpp https://bugs.webkit.org/show_bug.cgi?id=267162 Reviewed by Antti Koivisto. Partial Merge: https://chromium.googlesource.com/chromium/src.git/+/663b023cf7022eca119acc1b8b3a610cd8993da3 This PR adds additional test from Blink commit and the underlying bug was already fixed in 189573@main. * Tools/TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp: (EnclosingIntRect): Canonical link: https://commits.webkit.org/272779@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e3966: Update/Remove tests relying on 'getPropertyCSSValue'
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e3966d2e89c2d1356ee89cd1de68c2daa150f63 https://github.com/WebKit/WebKit/commit/1e3966d2e89c2d1356ee89cd1de68c2daa150f63 Author: Ahmad Saleem Date: 2024-01-08 (Mon, 08 Jan 2024) Changed paths: M LayoutTests/animations/fill-mode-iteration-count-non-integer.html M LayoutTests/animations/fill-mode-missing-from-to-keyframes.html M LayoutTests/animations/fill-mode-multiple-keyframes.html M LayoutTests/animations/fill-mode-removed.html M LayoutTests/animations/fill-mode.html M LayoutTests/css3/blending/background-blend-mode-property-parsing-expected.txt M LayoutTests/css3/blending/background-blend-mode-property-parsing.html M LayoutTests/css3/blending/blend-mode-property-parsing-expected.txt M LayoutTests/css3/blending/blend-mode-property-parsing.html M LayoutTests/css3/calc/reflection-computed-style-expected.txt M LayoutTests/css3/calc/reflection-computed-style.html M LayoutTests/css3/filters/filter-property-computed-style-expected.txt M LayoutTests/css3/filters/filter-property-computed-style.html M LayoutTests/css3/filters/filter-property-parsing-expected.txt M LayoutTests/css3/filters/filter-property-parsing.html M LayoutTests/fast/css/custom-font-xheight.html M LayoutTests/fast/css/sheet-collection-link.html M LayoutTests/fast/css/style-enumerate-properties-expected.txt M LayoutTests/fast/css/style-enumerate-properties.html M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style.html M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt M LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position.html M LayoutTests/fast/dom/css-element-attribute-js-null-expected.txt M LayoutTests/fast/dom/css-element-attribute-js-null.html M LayoutTests/fast/dom/dom-constructors-expected.txt M LayoutTests/fast/dom/dom-constructors.html M LayoutTests/fast/dom/domListEnumeration-expected.txt M LayoutTests/fast/dom/domListEnumeration.html M LayoutTests/fast/dom/gc-9-expected.txt M LayoutTests/fast/dom/gc-9.html M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt M LayoutTests/fast/dom/non-numeric-values-numeric-parameters.html M LayoutTests/fast/dom/prototypes-expected.txt M LayoutTests/fast/dom/prototypes.html M LayoutTests/fast/dom/wrapper-classes-expected.txt M LayoutTests/fast/dom/wrapper-classes.html M LayoutTests/fast/history/visited-generated-content-test.html M LayoutTests/fast/media/mq-js-update-media.html M LayoutTests/fast/reflections/reflection-computed-style-expected.txt M LayoutTests/fast/reflections/reflection-computed-style.html R LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt R LayoutTests/http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html M LayoutTests/platform/mac/fast/dom/objc-wrapper-identity-expected.txt M LayoutTests/platform/mac/fast/dom/objc-wrapper-identity.html M LayoutTests/svg/animations/animate-color-rgba-calcMode-discrete-expected.txt M LayoutTests/svg/animations/animate-color-rgba-calcMode-discrete.html M LayoutTests/svg/animations/change-css-property-while-animating-fill-freeze-expected.txt M LayoutTests/svg/animations/change-css-property-while-animating-fill-freeze.html M LayoutTests/svg/animations/change-css-property-while-animating-fill-remove-expected.txt M LayoutTests/svg/animations/change-css-property-while-animating-fill-remove.html M LayoutTests/svg/css/getComputedStyle-basic-expected.txt M LayoutTests/svg/css/getComputedStyle-basic.xhtml M LayoutTests/svg/css/glyph-orientation-rounding-test-expected.txt M LayoutTests/svg/css/glyph-orientation-rounding-test.xhtml M LayoutTests/svg/css/rect-system-color.xhtml M LayoutTests/svg/transforms/transform-origin-presentation-attribute.xhtml Log Message: --- Update/Remove tests relying on 'getPropertyCSSValue' https://bugs.webkit.org/show_bug.cgi?id=229912 Reviewed by Tim Nguyen. This PR is to update tests relying on historical
[webkit-changes] [WebKit/WebKit] 3db3a7: Remove unused `CStringTranslator` structure from `...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3db3a794a844d2c7e4cda8fc6a7588f8e62ee85a https://github.com/WebKit/WebKit/commit/3db3a794a844d2c7e4cda8fc6a7588f8e62ee85a Author: Ahmad Saleem Date: 2024-01-08 (Mon, 08 Jan 2024) Changed paths: M Source/WTF/wtf/text/StringImpl.h Log Message: --- Remove unused `CStringTranslator` structure from `StringImpl.h` https://bugs.webkit.org/show_bug.cgi?id=267210 Reviewed by Tim Nguyen. This PR is to remove unused structure `CStringTranslator`. * Source/WTF/wtf/text/StringImpl.h: Canonical link: https://commits.webkit.org/272755@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] be98f6: Sync 'SVGTransform.idl' with WebIDL Specification
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: be98f63ecae4c7e34c8293c6dc4f7c893d7e171e https://github.com/WebKit/WebKit/commit/be98f63ecae4c7e34c8293c6dc4f7c893d7e171e Author: Ahmad Saleem Date: 2024-01-07 (Sun, 07 Jan 2024) Changed paths: M LayoutTests/svg/dom/SVGTransform-expected.txt M LayoutTests/svg/dom/SVGTransform.html M Source/WebCore/svg/SVGTransform.idl Log Message: --- Sync 'SVGTransform.idl' with WebIDL Specification https://bugs.webkit.org/show_bug.cgi?id=267190 Reviewed by Simon Fraser. This patch is to align WebKit with Web-Specification [1]: [1] https://svgwg.org/svg2-draft/coords.html#InterfaceSVGTransform It removes 'unrestricted' from multiple values and add [SameObject] as needed. Additionally, the test is synced from below Blink commit (SVGTransform.js): Commit: https://src.chromium.org/viewvc/blink?view=revision=190303 * Source/WebCore/svg/SVGTransform.idl: * LayoutTests/svg/dom/SVGTransform.html: Updated from Blink / Chromium source * LayoutTests/svg/dom/SVGTransform-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/272751@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 25c142: Sync 'SVGNumber.idl' with WebIDL Specification
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 25c142f653a1234a8c98ce488c590dc2a17a0758 https://github.com/WebKit/WebKit/commit/25c142f653a1234a8c98ce488c590dc2a17a0758 Author: Ahmad Saleem Date: 2024-01-06 (Sat, 06 Jan 2024) Changed paths: M LayoutTests/svg/dom/SVGNumber-expected.txt M LayoutTests/svg/dom/SVGNumber.html M Source/WebCore/svg/SVGNumber.idl Log Message: --- Sync 'SVGNumber.idl' with WebIDL Specification https://bugs.webkit.org/show_bug.cgi?id=267186 Reviewed by Tim Nguyen. This patch is to align WebKit with Web-Specification [1]: [1] https://svgwg.org/svg2-draft/types.html#InterfaceSVGNumber It removes 'unrestricted' from `value`. Additionally, the test is synced from below Blink upstream (main), which uses 'testharness'. * Source/WebCore/svg/SVGNumber.idl: * LayoutTests/svg/dom/SVGNumber.html: Updated from Blink / Chromium source * LayoutTests/svg/dom/SVGNumber-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/272741@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 105fea: Sync 'SVGAngle.idl' with WebIDL Specification
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 105fea294b3d6d23cd87708a567c2089230d678a https://github.com/WebKit/WebKit/commit/105fea294b3d6d23cd87708a567c2089230d678a Author: Ahmad Saleem Date: 2024-01-06 (Sat, 06 Jan 2024) Changed paths: M LayoutTests/svg/dom/SVGAngle-expected.txt M LayoutTests/svg/dom/SVGAngle.html M Source/WebCore/svg/SVGAngle.idl Log Message: --- Sync 'SVGAngle.idl' with WebIDL Specification https://bugs.webkit.org/show_bug.cgi?id=267182 Reviewed by Tim Nguyen. This patch is to align WebKit with Web-Specification [1]: [1] https://svgwg.org/svg2-draft/types.html#InterfaceSVGAngle It removes 'unrestricted' from `value` and `valueInSpecifiedUnits` and uses. Additionally, the test is synced from below Blink commit (SVGAngle.js): Commit: https://src.chromium.org/viewvc/blink?view=revision=190303 * Source/WebCore/svg/SVGAngle.idl: * LayoutTests/svg/dom/SVGAngle.html: Rebaselined * LayoutTests/svg/dom/SVGAngle-expected.txt: Rebaselined Canonical link: https://commits.webkit.org/272739@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0058f6: Add more LayoutUnit API tests for LayoutUnit::from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0058f6b04bfbf152643d9cd7548dd10c197a176a https://github.com/WebKit/WebKit/commit/0058f6b04bfbf152643d9cd7548dd10c197a176a Author: Ahmad Saleem Date: 2024-01-05 (Fri, 05 Jan 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebCore/LayoutUnitTests.cpp Log Message: --- Add more LayoutUnit API tests for LayoutUnit::fromFloat*() behavior https://bugs.webkit.org/show_bug.cgi?id=266950 Reviewed by Alan Baradlay. Partial Merge: https://chromium-review.googlesource.com/c/chromium/src/+/4652129 This PR imports additional API tests around LayoutUnit::fromFloat*() from Blink / Chromium. NOTE: This PR does not add `quiet_NaN()` tests. * Tools/TestWebKitAPI/Tests/WebCore/LayoutUnitTests.cpp: (LayoutUnitFloat): (FromFloatCeil): (FromFloatFloor): (FromFloatRound): Canonical link: https://commits.webkit.org/272707@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e7d1f5: Handle empty title attribute tooltips
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7d1f5b567cb04f64825384d926dd722450663df https://github.com/WebKit/WebKit/commit/e7d1f5b567cb04f64825384d926dd722450663df Author: Ahmad Saleem Date: 2024-01-04 (Thu, 04 Jan 2024) Changed paths: A LayoutTests/fast/html/a-tooltip-null-expected.txt A LayoutTests/fast/html/a-tooltip-null.html M Source/WebCore/rendering/HitTestResult.cpp Log Message: --- Handle empty title attribute tooltips https://bugs.webkit.org/show_bug.cgi?id=264702 rdar://problem/118619793 Reviewed by Ryosuke Niwa and Aditya Keerthi. This patch aligns WebKit with Gecko / Firefox and Blink / Chromium. Merge: https://chromium.googlesource.com/chromium/blink/+/a57f7f4625cd5d699a41154c67436ae423f7a5e1 The spec [1] tells us that if an element has a title attribute, its value should be returned as its tooltip/advisory information: [1] https://html.spec.whatwg.org/#the-title-attribute Align with how other browsers behave for `` and return the empty string rather than consult the parent element. NOTE - the tests are modified to work with WebKit Test Infrastructure. * Source/WebCore/rendering/HitTestResult.cpp: (HitTestResult::title): * LayoutTests/fast/html/a-tooltip-null.html: Add Test Case * LayoutTests/fast/html/a-tooltip-null-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/272667@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] eed535: Avoid duplicate null check in ReplaceSelectionComm...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eed5354f0af639be61de79c2c1f00a8a1af496b1 https://github.com/WebKit/WebKit/commit/eed5354f0af639be61de79c2c1f00a8a1af496b1 Author: Ahmad Saleem Date: 2024-01-04 (Thu, 04 Jan 2024) Changed paths: M Source/WebCore/editing/ReplaceSelectionCommand.h Log Message: --- Avoid duplicate null check in ReplaceSelectionCommand::pastLastLeaf() https://bugs.webkit.org/show_bug.cgi?id=267067 Reviewed by Ryosuke Niwa. Merge: https://chromium.googlesource.com/chromium/blink/+/4c63691bebc58be7ff827759a489286b71e6d314 Avoid duplicate null check in ReplaceSelectionCommand::pastLastLeaf() by calling m_lastNodeInserted->lastDescendant() directly instead of lastLeafInserted(). This also makes it clearer by we are checking that m_lastNodeInserted is not null as it is now explicitly use right after. This avoid avoids dereferencing a pointer as we now get a reference directly. * Source/WebCore/editing/ReplaceSelectionCommand.h: (pastLastLeaf): Canonical link: https://commits.webkit.org/272659@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e98b9d: Remove unused function `userPreferredLanguagesOver...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e98b9d978ece88c0f5932d8fd69ed60882a9aed7 https://github.com/WebKit/WebKit/commit/e98b9d978ece88c0f5932d8fd69ed60882a9aed7 Author: Ahmad Saleem Date: 2024-01-04 (Thu, 04 Jan 2024) Changed paths: M Source/WTF/wtf/Language.cpp M Source/WTF/wtf/Language.h Log Message: --- Remove unused function `userPreferredLanguagesOverride` from Language.cpp|h https://bugs.webkit.org/show_bug.cgi?id=267086 Reviewed by Sihui Liu. This PR is to remove unused function `userPreferredLanguagesOverride` from Language.cpp|h. * Source/WTF/wtf/Language.cpp: (userPreferredLanguagesOverride): Removed * Source/WTF/wtf/Language.h: Above function definition removed Canonical link: https://commits.webkit.org/272658@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 10bf0c: Remove setAncestorChainHasVisibleDescendant()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 10bf0ccfca7cb06d260316bc0c98c671a9eedda7 https://github.com/WebKit/WebKit/commit/10bf0ccfca7cb06d260316bc0c98c671a9eedda7 Author: Ahmad Saleem Date: 2024-01-04 (Thu, 04 Jan 2024) Changed paths: M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h Log Message: --- Remove setAncestorChainHasVisibleDescendant() https://bugs.webkit.org/show_bug.cgi?id=266915 Reviewed by Simon Fraser. Merge: https://chromium.googlesource.com/chromium/blink/+/8d5551bd2723ecd23332255a6ded2814e5d97148 We shouldn't clear dirty bits by walking up the tree. Instead, we should mark dirty bits up the tree and clean the dirty bits by walking down the tree. * Source/WebCore/rendering/RenderLayer.cpp: (RenderLayer::addChild): (RenderLayer::setHasVisibleContent): (RenderLayer::setAncestorChainHasVisibleDescendant): Deleted * Source/WebCore/rendering/RenderLayer.h: Clean-up deleted function definition Canonical link: https://commits.webkit.org/272652@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 20c4db: Remove two unused functions definition in `DeleteS...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20c4db257206aec9b393695a0f34f9369a31bd3b https://github.com/WebKit/WebKit/commit/20c4db257206aec9b393695a0f34f9369a31bd3b Author: Ahmad Saleem Date: 2024-01-03 (Wed, 03 Jan 2024) Changed paths: M Source/WebCore/editing/DeleteSelectionCommand.h Log Message: --- Remove two unused functions definition in `DeleteSelectionCommand.h` https://bugs.webkit.org/show_bug.cgi?id=267045 Reviewed by Ryosuke Niwa and Tim Nguyen. This PR is to delete unused functions 'insertPlaceholderForAncestorBlockContent' and 'calculateEndingPosition' definition in DeleteSelectionCommand.h. * Source/WebCore/editing/DeleteSelectionCommand.h: Canonical link: https://commits.webkit.org/272626@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7cb416: Remove unused inline function `smartDelete` in Typ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7cb416462b7d97af2c4e2267302b6a35904d2db1 https://github.com/WebKit/WebKit/commit/7cb416462b7d97af2c4e2267302b6a35904d2db1 Author: Ahmad Saleem Date: 2024-01-03 (Wed, 03 Jan 2024) Changed paths: M Source/WebCore/editing/TypingCommand.h Log Message: --- Remove unused inline function `smartDelete` in TypingCommand.h https://bugs.webkit.org/show_bug.cgi?id=267048 Reviewed by Ryosuke Niwa. This PR is to delete unused inline function `smartDelete` from TypingCommand.h. * Source/WebCore/editing/TypingCommand.h: Canonical link: https://commits.webkit.org/272625@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a392df: Remove unused function `nodeFullyUnselected` from ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a392df464f656eac01fab91cf5bb2e28f4efa810 https://github.com/WebKit/WebKit/commit/a392df464f656eac01fab91cf5bb2e28f4efa810 Author: Ahmad Saleem Date: 2024-01-03 (Wed, 03 Jan 2024) Changed paths: M Source/WebCore/editing/ApplyStyleCommand.cpp M Source/WebCore/editing/ApplyStyleCommand.h Log Message: --- Remove unused function `nodeFullyUnselected` from `ApplyStyleCommand.cpp|h` https://bugs.webkit.org/show_bug.cgi?id=267047 Reviewed by Ryosuke Niwa. This PR is to delete unused function `nodeFullyUnselected` from ApplyStyleCommand.cpp|h. * Source/WebCore/editing/ApplyStyleCommand.cpp: (ApplyStyleCommand::nodeFullyUnselected): Deleted * Source/WebCore/editing/ApplyStyleCommand.h: Delete function definition Canonical link: https://commits.webkit.org/272623@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 77a2ca: Add early return in 'prepareWhitespaceAtPositionFo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 77a2ca7c64f95562693a8be9854b1d1b8f60fe2f https://github.com/WebKit/WebKit/commit/77a2ca7c64f95562693a8be9854b1d1b8f60fe2f Author: Ahmad Saleem Date: 2024-01-02 (Tue, 02 Jan 2024) Changed paths: M Source/WebCore/editing/CompositeEditCommand.cpp Log Message: --- Add early return in 'prepareWhitespaceAtPositionForSplit' if there is no richly editable position https://bugs.webkit.org/show_bug.cgi?id=266919 Reviewed by Ryosuke Niwa. This patch is to add early return inspired by Blink / Chromium to early return, if there is no richly editable position to potentially improve performance. * Source/WebCore/editing/CompositeEditCommand.cpp: (CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Canonical link: https://commits.webkit.org/272570@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d13d14: Simplify RenderLayer::setParent
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d13d1454f6a706fff1abee99a816dc4af627bc5d https://github.com/WebKit/WebKit/commit/d13d1454f6a706fff1abee99a816dc4af627bc5d Author: Ahmad Saleem Date: 2024-01-02 (Tue, 02 Jan 2024) Changed paths: M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayer.h Log Message: --- Simplify RenderLayer::setParent https://bugs.webkit.org/show_bug.cgi?id=266851 Reviewed by Antti Koivisto. Merge: https://chromium.googlesource.com/chromium/blink/+/34436ac331a767eded6b60bc2b68cbcc5d8cb163 There's no need call these functions on RenderLayerCompositor. RenderLayer::addChild and RenderLayer::removeChild already call them. * Source/WebCore/rendering/RenderLayer.cpp: (RenderLayer::addChild): (RenderLayer::removeChild): (RenderLayer::setParent): Deleted (RenderLayer::createReflection): (RenderLayer::removeReflection): * Source/WebCore/rendering/RenderLayer.h: Canonical link: https://commits.webkit.org/272566@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a9263: Remove duplicate 'svg/animations' tests in favor o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a92632912838a769ab5ec563052e34438298c03 https://github.com/WebKit/WebKit/commit/2a92632912838a769ab5ec563052e34438298c03 Author: Ahmad Saleem Date: 2024-01-01 (Mon, 01 Jan 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M LayoutTests/platform/mac/TestExpectations M LayoutTests/platform/wpe/TestExpectations R LayoutTests/svg/animations/accumulate-values-width-animation-expected.txt R LayoutTests/svg/animations/accumulate-values-width-animation.html R LayoutTests/svg/animations/additive-from-to-width-animation-expected.txt R LayoutTests/svg/animations/additive-from-to-width-animation.html R LayoutTests/svg/animations/additive-type-by-animation-expected.txt R LayoutTests/svg/animations/additive-type-by-animation.html R LayoutTests/svg/animations/additive-values-width-animation-expected.txt R LayoutTests/svg/animations/additive-values-width-animation.html R LayoutTests/svg/animations/animVal-basics-expected.txt R LayoutTests/svg/animations/animVal-basics.html R LayoutTests/svg/animations/animate-calcMode-spline-by-expected.txt R LayoutTests/svg/animations/animate-calcMode-spline-by.html R LayoutTests/svg/animations/animate-calcMode-spline-from-by-expected.txt R LayoutTests/svg/animations/animate-calcMode-spline-from-by.html R LayoutTests/svg/animations/animate-calcMode-spline-from-to-expected.txt R LayoutTests/svg/animations/animate-calcMode-spline-from-to.html R LayoutTests/svg/animations/animate-calcMode-spline-to-expected.txt R LayoutTests/svg/animations/animate-calcMode-spline-to.html R LayoutTests/svg/animations/animate-calcMode-spline-values-expected.txt R LayoutTests/svg/animations/animate-calcMode-spline-values.html R LayoutTests/svg/animations/animate-color-calcMode-discrete-expected.txt R LayoutTests/svg/animations/animate-color-calcMode-discrete.html R LayoutTests/svg/animations/animate-color-fill-currentColor-expected.txt R LayoutTests/svg/animations/animate-color-fill-currentColor.html R LayoutTests/svg/animations/animate-color-fill-from-by-expected.txt R LayoutTests/svg/animations/animate-color-fill-from-by.html R LayoutTests/svg/animations/animate-color-transparent-expected.txt R LayoutTests/svg/animations/animate-color-transparent.html R LayoutTests/svg/animations/animate-css-xml-attributeType-expected.txt R LayoutTests/svg/animations/animate-css-xml-attributeType.html R LayoutTests/svg/animations/animate-currentColor-expected.txt R LayoutTests/svg/animations/animate-currentColor.html R LayoutTests/svg/animations/animate-dynamic-update-attributeName-expected.txt R LayoutTests/svg/animations/animate-dynamic-update-attributeName.html R LayoutTests/svg/animations/animate-elem-02-t-drt-expected.txt R LayoutTests/svg/animations/animate-elem-02-t-drt.html R LayoutTests/svg/animations/animate-elem-14-t-drt-expected.txt R LayoutTests/svg/animations/animate-elem-14-t-drt.html R LayoutTests/svg/animations/animate-elem-15-t-drt-expected.txt R LayoutTests/svg/animations/animate-elem-15-t-drt.html R LayoutTests/svg/animations/animate-elem-16-t-drt-expected.txt R LayoutTests/svg/animations/animate-elem-16-t-drt.html R LayoutTests/svg/animations/animate-elem-17-t-drt-expected.txt R LayoutTests/svg/animations/animate-elem-17-t-drt.html R LayoutTests/svg/animations/animate-elem-18-t-drt-expected.txt R LayoutTests/svg/animations/animate-elem-18-t-drt.html R LayoutTests/svg/animations/animate-elem-19-t-drt-expected.txt R LayoutTests/svg/animations/animate-elem-19-t-drt.html R LayoutTests/svg/animations/animate-end-attribute-numeric-precision-expected.txt R LayoutTests/svg/animations/animate-end-attribute-numeric-precision.html R LayoutTests/svg/animations/animate-from-to-keyTimes-expected.txt R LayoutTests/svg/animations/animate-from-to-keyTimes.html R LayoutTests/svg/animations/animate-gradient-transform-expected.txt R LayoutTests/svg/animations/animate-gradient-transform.html R LayoutTests/svg/animations/animate-inherit-css-property-expected.txt R LayoutTests/svg/animations/animate-inherit-css-property.html R LayoutTests/svg/animations/animate-insert-begin-expected.txt R LayoutTests/svg/animations/animate-insert-begin.html R LayoutTests/svg/animations/animate-insert-no-begin-expected.txt R LayoutTests/svg/animations/animate-insert-no-begin.html R LayoutTests/svg/animations/animate-keySplines-expected.txt R LayoutTests/svg/animations/animate-keySplines.html
[webkit-changes] [WebKit/WebKit] 6fdbc4: Sync 'svg/animations' from WPT upstream
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6fdbc429226f79f3ac914301dcf2ea02f6975c04 https://github.com/WebKit/WebKit/commit/6fdbc429226f79f3ac914301dcf2ea02f6975c04 Author: Ahmad Saleem Date: 2023-12-31 (Sun, 31 Dec 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-marker-orient-from-auto-to-auto-start-reverse-expected.txt M LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-marker-orient-from-auto-to-auto-start-reverse.html R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-Cc-Ss-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-Mm-Aa-Z-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-Qq-Tt-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-cC-sS-inverse-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-mM-aA-Z-inverse-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt R LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-path-to-animation-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-reset-freeze-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animate-reset-freeze.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-base-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-base.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-circle-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-circle.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-display-none-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-display-none.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-ellipse-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-ellipse.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-from-to-rotate-auto-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-from-to-rotate-auto.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-keyPoints-001-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-keyPoints-001.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-line-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-line.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-mpath-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-mpath.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-rect-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animateMotion-rect.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/animated-classname-crash.svg A LayoutTests/imported/w3c/web-platform-tests/svg/animations/custom-events-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/custom-events.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/end-of-time-001-crash.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/end-of-time-002-crash.html R LayoutTests/imported/w3c/web-platform-tests/svg/animations/end-of-time-crash.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/event-listeners-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/event-listeners.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/eventbase-non-svg-element-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/eventbase-non-svg-element.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/first-interval-in-the-past-contribute-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/first-interval-in-the-past-contribute.html A LayoutTests/imported/w3c/web-platform-tests/svg/animations/first-interval-in-the-past-dont-contribute-expected.txt A LayoutTests/imported/w3c/web-platform-tests/svg/animations/first-interval-in-the-past-dont-contribute.html M LayoutTests/imported/w3c/web-platform-tests/svg/animations/keysplines-x
[webkit-changes] [WebKit/WebKit] 2afefe: Fix rounding of very large and very small LayoutUnits
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2afefe7449cd82d4b70c9ed85add5827f44e7278 https://github.com/WebKit/WebKit/commit/2afefe7449cd82d4b70c9ed85add5827f44e7278 Author: Ahmad Saleem Date: 2023-12-29 (Fri, 29 Dec 2023) Changed paths: M LayoutTests/platform/ios/fast/block/float/overhanging-tall-block-expected.txt M LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt M LayoutTests/platform/wpe/fast/block/float/overhanging-tall-block-expected.txt M Source/WebCore/platform/LayoutUnit.h M Tools/TestWebKitAPI/Tests/WebCore/LayoutUnitTests.cpp Log Message: --- Fix rounding of very large and very small LayoutUnits https://bugs.webkit.org/show_bug.cgi?id=266869 Reviewed by Alan Baradlay. Merge: https://source.chromium.org/chromium/chromium/src/+/a7b04f8fe15406cbf98995da00fc63f73e9fff61 Previously, LayoutUnit's between nearlyMax() and max() would round down, even though their fractional parts are > 0.5. Similarly, LayoutUnit's between min() and nearlyMin() would round up (toward zero), even though their fractional parts are < -0.5. * Source/WebCore/platform/LayoutUnit.h: (round): * Tools/TestWebKitAPI/Tests/WebCore/LayoutUnitTests.cpp: (LayoutUnitRounding): Added new test case * LayoutTests/platform/ios/fast/block/float/overhanging-tall-block-expected.txt: Rebaselined * LayoutTests/platform/wpe/fast/block/float/overhanging-tall-block-expected.txt: Ditto * LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt: Ditto Canonical link: https://commits.webkit.org/272534@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57f898: Make FloatQuad::boundingBox manage large finite va...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 57f898204047c2950cdb7cbe02436a5faf1ba104 https://github.com/WebKit/WebKit/commit/57f898204047c2950cdb7cbe02436a5faf1ba104 Author: Ahmad Saleem Date: 2023-12-29 (Fri, 29 Dec 2023) Changed paths: A LayoutTests/fast/css/transform-infinity-expected.txt A LayoutTests/fast/css/transform-infinity.html M Source/WebCore/platform/graphics/FloatQuad.cpp M Tools/TestWebKitAPI/Tests/WebCore/FloatQuadTests.cpp Log Message: --- Make FloatQuad::boundingBox manage large finite values and infinite ones https://bugs.webkit.org/show_bug.cgi?id=266855 Reviewed by Alan Baradlay. Merge: https://chromium.googlesource.com/chromium/src.git/+/6f25d3a7fca5d1a30eb5f05c4057ee33aa7eb702 , https://chromium.googlesource.com/chromium/src/+/76905b16d9f5ba9533a7e8d41724fcd383fa4d37 and https://chromium.googlesource.com/chromium/src/+/fdda021cbb442c16633595fa580614b6039132e3 This PR is to change FloatQuad::boundingBox() to check for -Infinity and Infinity when converting to a FloatRect, thereby allowing the returned rect to be used and snapped without hitting the isNaN() check when clamping to saturate. Further, this is to extend FloatQuad::boundingBox to treat large finite values the same way it treats infinite values, by clamping them to the range of int. * Source/WebCore/platform/graphics/FloatQuad.cpp: (clampToIntRange): For clamping new function (FloatQuad::boundingBox): Use above new function * Tools/TestWebKitAPI/Tests/WebCore/FloatQuadTests.cpp: New API tests * LayoutTests/fast/css/transform-infinity.html: Add Test Case * LayoutTests/fast/css/transform-infinity-expected.txt: Add Test Case Expectation Canonical link: https://commits.webkit.org/272533@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7ee701: Remove unused `valueShouldChangeOnHotTrack` function
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7ee701c3a6f7df1063168dc03ec130f6f7c5cac1 https://github.com/WebKit/WebKit/commit/7ee701c3a6f7df1063168dc03ec130f6f7c5cac1 Author: Ahmad Saleem Date: 2023-12-26 (Tue, 26 Dec 2023) Changed paths: M Source/WebCore/platform/PopupMenuClient.h M Source/WebCore/rendering/RenderMenuList.h M Source/WebCore/rendering/RenderSearchField.h Log Message: --- Remove unused `valueShouldChangeOnHotTrack` function https://bugs.webkit.org/show_bug.cgi?id=266908 Reviewed by Tim Nguyen. This patch is to remove 'valueShouldChangeOnHotTrack', which does not have any call sites and just return 'true' or 'false' without any usage. * Source/WebCore/platform/PopupMenuClient.h: * Source/WebCore/rendering/RenderMenuList.h: * Source/WebCore/rendering/RenderSearchField.h: Canonical link: https://commits.webkit.org/272507@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
