[webkit-changes] [WebKit/WebKit] 325129: Reverting 269064@main + 269052@main + 269049@main ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 325129c9392cd113e4ad3ba170f9fed980c5c629 https://github.com/WebKit/WebKit/commit/325129c9392cd113e4ad3ba170f9fed980c5c629 Author: Dean Jackson Date: 2023-10-09 (Mon, 09 Oct 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WebCore/Modules/webxr/WebXRSession.cpp M Source/WebCore/Modules/webxr/WebXRSystem.cpp M Source/WebCore/platform/xr/PlatformXR.h M Source/WebCore/platform/xr/cocoa/PlatformXRCocoa.mm M Source/WebKit/Configurations/WebKit.xcconfig M Source/WebKit/Shared/XR/XRDeviceInfo.h M Source/WebKit/Shared/XR/XRDeviceProxy.cpp M Source/WebKit/Shared/XR/XRSystem.serialization.in M Source/WebKit/SourcesCocoa.txt R Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.h R Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm R Source/WebKit/UIProcess/XR/ios/PlatformXRSystemIOS.mm R Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.h R Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.mm M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h M Source/WebKit/UIProcess/ios/WKModelView.h M Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.mm M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Reverting 269064@main + 269052@main + 269049@main due to a linking dependency https://bugs.webkit.org/show_bug.cgi?id=262773 rdar://116502294 https://bugs.webkit.org/show_bug.cgi?id=262760 rdar://116502232 https://bugs.webkit.org/show_bug.cgi?id=262679 rdar://116502210 Unreviewed build fix. We need to soft-link ARKit.framework. * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.h: * Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm: (WebKit::ARKitCoordinator::startSession): (WebKit::ARKitCoordinator::endSessionIfExists): (WebKit::ARKitCoordinator::scheduleAnimationFrame): (WebKit::ARKitCoordinator::createSessionIfNeeded): Deleted. (WebKit::ARKitCoordinator::renderLoop): Deleted. * Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.h: Removed. * Source/WebKit/UIProcess/XR/ios/WKARPresentationSession.mm: Removed. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.h: * Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm: (WebKit::ARKitCoordinator::getPrimaryDeviceInfo): (WebKit::ARKitCoordinator::startSession): (WebKit::ARKitCoordinator::endSessionIfExists): (WebKit::ARKitCoordinator::scheduleAnimationFrame): (WebKit::ARKitCoordinator::submitFrame): (WebKit::ARKitCoordinator::currentSessionHasEnded): Deleted. * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/Modules/webxr/WebXRSession.cpp: (WebCore::isImmersive): (WebCore::WebXRSession::supportsViewportScaling const): (WebCore::WebXRSession::onFrame): * Source/WebCore/Modules/webxr/WebXRSystem.cpp: (WebCore::WebXRSystem::obtainCurrentDevice): (WebCore::WebXRSystem::resolveRequestedFeatures const): (WebCore::WebXRSystem::requestSession): * Source/WebCore/platform/xr/PlatformXR.h: (PlatformXR::isImmersive): Deleted. * Source/WebCore/platform/xr/cocoa/PlatformXRCocoa.mm: * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/Shared/XR/XRDeviceInfo.h: * Source/WebKit/Shared/XR/XRDeviceProxy.cpp: (WebKit::XRDeviceProxy::XRDeviceProxy): (WebKit::XRDeviceProxy::initializeTrackingAndRendering): * Source/WebKit/Shared/XR/XRSystem.serialization.in: * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.h: Removed. * Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm: Removed. * Source/WebKit/UIProcess/XR/ios/PlatformXRSystemIOS.mm: Removed. * Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h: * Source/WebKit/UIProcess/ios/WKModelView.h: * Source/WebKit/UIProcess/ios/WKSyntheticTapGestureRecognizer.mm: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/269116@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f98b4: [visionOS] Media: fullscreen player controls are n...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f98b4e907f520ed1dc15c8915e6697a6ee89c6d https://github.com/WebKit/WebKit/commit/3f98b4e907f520ed1dc15c8915e6697a6ee89c6d Author: Dean Jackson Date: 2023-10-06 (Fri, 06 Oct 2023) Changed paths: M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm Log Message: --- [visionOS] Media: fullscreen player controls are not up to spec https://bugs.webkit.org/show_bug.cgi?id=262801 rdar://116372898 Reviewed by Tim Horton. When visionOS changed its pixels-per-meter value, we forgot to update the sizes and positions of the fullscreen exit and related buttons. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController loadView]): Adjust some constants. Canonical link: https://commits.webkit.org/269013@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c3dd6: Seeing 5 windows opened, even though only tapped o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c3dd61568c98905d1eb9bdeb901fbe099e6b5c4 https://github.com/WebKit/WebKit/commit/8c3dd61568c98905d1eb9bdeb901fbe099e6b5c4 Author: Dean Jackson Date: 2023-09-06 (Wed, 06 Sep 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: --- Seeing 5 windows opened, even though only tapped on 3 model links from Safari https://bugs.webkit.org/show_bug.cgi?id=261232 rdar://114172309 Reviewed by Mike Wyrzykowski. On iOS the AR Quick Look feature is modal, which means only one preview is open at a time. On visionOS the preview opens in a separate app, allowing for the case where the user can tap many times and multiple windows open. Furthermore, the communication with the system is a bit limited, which can create a situation where more windows open than the user requested. Limit this so that only one Quick Look can be downloading at a time. This will still allow the user to open multiple models, but not get into this confusing situation. It isn't a great fix. A future change would be to keep a list of active previews, with an upper limit, so that the user isn't blocked from opening another file while a large file is being downloaded. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: Canonical link: https://commits.webkit.org/267708@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6082b4: Interaction: When using media controls in full scr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6082b4aaed9f7255e573d0fdb7d73c2463047624 https://github.com/WebKit/WebKit/commit/6082b4aaed9f7255e573d0fdb7d73c2463047624 Author: Dean Jackson Date: 2023-08-26 (Sat, 26 Aug 2023) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- Interaction: When using media controls in full screen, Safari thinks we're trying to type. https://bugs.webkit.org/show_bug.cgi?id=260754 rdar://114412655 Reviewed by Richard Robinson. visionOS is popping up the potential phishing alert when you tap around in the fullscreen media controls. This platform has a virtual keyboard, but it is always in a separate window, so we don't need the phishing protection. Turn it off for visionOS. I left a FIXME saying it would be better to have this feature controlled globally with a USE or HAVE. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _shouldAvoidSecurityHeuristicScoreUpdates]): Canonical link: https://commits.webkit.org/267329@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6baa27: Fix visionOS build - didRefreshDisplay is private
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6baa2797064869db90839ccac0088104b13a9611 https://github.com/WebKit/WebKit/commit/6baa2797064869db90839ccac0088104b13a9611 Author: Dean Jackson Date: 2023-08-25 (Fri, 25 Aug 2023) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm Log Message: --- Fix visionOS build - didRefreshDisplay is private https://bugs.webkit.org/show_bug.cgi?id=260752 rdar://114478408 Unreviewed build fix. Was caused by f754a3da5. * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeDrawingAreaProxyIOS.mm: (-[WKDisplayLinkHandler timerFired]): Canonical link: https://commits.webkit.org/267307@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f6e9a7: ANGLE - error: implicit capture of 'this' with a c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f6e9a70fa4e34e717c5960b38beda3bc0db6b5b5 https://github.com/WebKit/WebKit/commit/f6e9a70fa4e34e717c5960b38beda3bc0db6b5b5 Author: Dean Jackson Date: 2023-08-08 (Tue, 08 Aug 2023) Changed paths: M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp Log Message: --- ANGLE - error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture] https://bugs.webkit.org/show_bug.cgi?id=259941 rdar://111828854 Reviewed by David Kilzer. Newer versions of clang detect the now-deprecated implicit capture of 'this' in lambdas. Replace that capture with explicit forms. * Source/ThirdParty/ANGLE/changes.diff: * Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp: (sh::TCompiler::resizeClipAndCullDistanceBuiltins): Canonical link: https://commits.webkit.org/266712@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 17723a: Media: Update fullscreen controls for 1360 PPM
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 17723aacd5f56e3299fbe876bed81b7c2bac02b2 https://github.com/WebKit/WebKit/commit/17723aacd5f56e3299fbe876bed81b7c2bac02b2 Author: Dean Jackson Date: 2023-08-04 (Fri, 04 Aug 2023) Changed paths: M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- Media: Update fullscreen controls for 1360 PPM https://bugs.webkit.org/show_bug.cgi?id=259845 rdar://112866983 Reviewed by Eric Carlson. The visionOS media controls are too small when in fullscreen. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen:]): Canonical link: https://commits.webkit.org/266607@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab6f03: REGRESSION (265825@main): Safari CPU usage in Surf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab6f0338a00f9fa6773cd5f574b90b91f9f5b99f https://github.com/WebKit/WebKit/commit/ab6f0338a00f9fa6773cd5f574b90b91f9f5b99f Author: Dean Jackson Date: 2023-08-03 (Thu, 03 Aug 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm Log Message: --- REGRESSION (265825@main): Safari CPU usage in SurferJoannaProxy increased by 5.8% https://bugs.webkit.org/show_bug.cgi?id=259805 rdar://111986083 Reviewed by Matt Woodrow. The fix in 265825@main caused a slight performance regression. We can now back out most of it, thanks to a change in CoreAnimation. The thing we don't restore is the CATransaction. * Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm: (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree): Canonical link: https://commits.webkit.org/266557@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ac4233: visionOS build broken after 266533@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ac423361b4bbf1cad591675161c6d5f2cb4f7185 https://github.com/WebKit/WebKit/commit/ac423361b4bbf1cad591675161c6d5f2cb4f7185 Author: Dean Jackson Date: 2023-08-03 (Thu, 03 Aug 2023) Changed paths: M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp M Source/WebKit/Shared/RemoteLayerTree/LayerProperties.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm Log Message: --- visionOS build broken after 266533@main https://bugs.webkit.org/show_bug.cgi?id=259788 rdar://113346360 Reviewed by Alex Christensen. Rearrange some members. Make sure the values don't clash. Adjust the BitsInIncreasingOrder to test relational size rather than exact values. * Source/WebKit/Scripts/generate-serializers.py: (generate_impl): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp: * Source/WebKit/Shared/RemoteLayerTree/LayerProperties.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyProperties): Canonical link: https://commits.webkit.org/266549@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 416f23: AR issues. Right after opening the USDZ and GLB fi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 416f2342d7bf83b5381e371315b4292fc6a75a56 https://github.com/WebKit/WebKit/commit/416f2342d7bf83b5381e371315b4292fc6a75a56 Author: Dean Jackson Date: 2023-07-31 (Mon, 31 Jul 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm Log Message: --- AR issues. Right after opening the USDZ and GLB file in the browser, it closes itself https://bugs.webkit.org/show_bug.cgi?id=259670 rdar://110978209 Reviewed by Tim Horton. We tightened the list of MIME types we accepted in ARQL during the past year. Unfortunately still many servers are not configured to send USD with the correct type, so we need to relax the list a bit. For now, we'll add "application/octet-stream". Added a new API test for this case. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/266462@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fdd0bc: Canvas does not show results of CanvasRenderingCon...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdd0bc163f50cc35458a06481a7cc3df056c16a5 https://github.com/WebKit/WebKit/commit/fdd0bc163f50cc35458a06481a7cc3df056c16a5 Author: Dean Jackson Date: 2023-07-28 (Fri, 28 Jul 2023) Changed paths: M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp Log Message: --- Canvas does not show results of CanvasRenderingContext2D.putImageData until forced re-render. https://bugs.webkit.org/show_bug.cgi?id=259584 rdar://112901862 Reviewed by Tim Nguyen. The commit in 263694@main caused a regression when calculating the dirty region of a putImageDataUpdate. It accidentally removed a reference marker on a parameter. * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::computeImageDataRect): Make sure the destRect parameter is a reference because it is updated. (WebCore::CanvasRenderingContext2DBase::putImageData): Leave a fixme! Canonical link: https://commits.webkit.org/266397@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6ab20: WebXR: Content is not loading in Private Browsing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6ab20ed7b64f6163f87f90d10397ef5bd6c553a https://github.com/WebKit/WebKit/commit/a6ab20ed7b64f6163f87f90d10397ef5bd6c553a Author: Dean Jackson Date: 2023-07-26 (Wed, 26 Jul 2023) Changed paths: M Source/WebKit/Shared/WebProcessCreationParameters.h M Source/WebKit/Shared/WebProcessCreationParameters.serialization.in M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- WebXR: Content is not loading in Private Browsing https://bugs.webkit.org/show_bug.cgi?id=259462 rdar://108818635 Reviewed by Tim Horton and Mike Wyrzykowski. The sandbox on iOS Private Browsing blocks WebXR from accessing its cache directory on visionOS. Specifically add those directories to the sandbox extension. * Source/WebKit/Shared/WebProcessCreationParameters.h: * Source/WebKit/Shared/WebProcessCreationParameters.serialization.in: * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: Canonical link: https://commits.webkit.org/266346@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0359f: Translator: Limit variable sizes vs uint overflow
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0359fbb43df03a64de57551c11c4d3f17bd8f5b https://github.com/WebKit/WebKit/commit/f0359fbb43df03a64de57551c11c4d3f17bd8f5b Author: Dean Jackson Date: 2023-07-18 (Tue, 18 Jul 2023) Changed paths: M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/src/compiler/translator/ValidateTypeSizeLimitations.cpp M Source/ThirdParty/ANGLE/src/tests/gl_tests/WebGLCompatibilityTest.cpp Log Message: --- Translator: Limit variable sizes vs uint overflow https://bugs.webkit.org/show_bug.cgi?id=259322 rdar://112414766 Reviewed by Alan Baradlay. Take change bebb83d from the main ANGLE repository. * Source/ThirdParty/ANGLE/changes.diff: * Source/ThirdParty/ANGLE/src/compiler/translator/ValidateTypeSizeLimitations.cpp: * Source/ThirdParty/ANGLE/src/tests/gl_tests/WebGLCompatibilityTest.cpp: Canonical link: https://commits.webkit.org/266146@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a5aad7: CrashTracer: com.apple.WebKit.WebContent at CoreGr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a5aad74576d8c44d3fff0d5b50bbffc485e6ac62 https://github.com/WebKit/WebKit/commit/a5aad74576d8c44d3fff0d5b50bbffc485e6ac62 Author: Dean Jackson Date: 2023-07-17 (Mon, 17 Jul 2023) Changed paths: R Source/WebKit/Shared/cg/ShareableBitmapCG.cpp A Source/WebKit/Shared/cg/ShareableBitmapCG.mm M Source/WebKit/SourcesCocoa.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- CrashTracer: com.apple.WebKit.WebContent at CoreGraphics: CGDataProviderCopyData https://bugs.webkit.org/show_bug.cgi?id=259296 rdar://29394886 Reviewed by Simon Fraser. The change in https://commits.webkit.org/262607@main has caused an occasional out of memory exception to be thrown in CGDataProviderCopyData. Catch and ignore this exception, while bailing out of the method. I've added some logging to give more information if we see it again. This involved changing a .cpp file to .mm. * Source/WebKit/Shared/cg/ShareableBitmapCG.mm: Renamed from Source/WebKit/Shared/cg/ShareableBitmapCG.cpp. (WebKit::ShareableBitmapConfiguration::ShareableBitmapConfiguration): (WebKit::ShareableBitmapConfiguration::validateColorSpace): (WebKit::wantsExtendedRange): (WebKit::ShareableBitmapConfiguration::calculateBytesPerPixel): (WebKit::ShareableBitmapConfiguration::calculateBytesPerRow): (WebKit::ShareableBitmapConfiguration::calculateBitmapInfo): (WebKit::ShareableBitmap::createFromImagePixels): (WebKit::ShareableBitmap::createGraphicsContext): (WebKit::ShareableBitmap::paint): (WebKit::ShareableBitmap::makeCGImageCopy): (WebKit::ShareableBitmap::makeCGImage): (WebKit::ShareableBitmap::createPlatformImage): (WebKit::ShareableBitmap::createCGImage const): (WebKit::ShareableBitmap::releaseBitmapContextData): (WebKit::ShareableBitmap::createImage): * Source/WebKit/SourcesCocoa.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/266119@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c7ca29: AR View closes instead of showing 3D asset - Mobil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c7ca29832dcbf36dc2c8ee92f42b7c3aae2abf9e https://github.com/WebKit/WebKit/commit/c7ca29832dcbf36dc2c8ee92f42b7c3aae2abf9e Author: Dean Jackson Date: 2023-07-13 (Thu, 13 Jul 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview.html Log Message: --- AR View closes instead of showing 3D asset - MobileSafari Crashing at -[_WKSystemPreviewDataTaskDelegate dataTask:didCompleteWithError:] + 32 https://bugs.webkit.org/show_bug.cgi?id=258957 rdar://110671973 Reviewed by Tim Horton. When we try to load a `blob:` URL, the WKDataTask instantly fails. This causes us to try to close a file handle that hasn't been initialised. Add a check to make sure that doesn't happen. There is still the bigger bug of needing to actually load blob URLs. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview.html: Canonical link: https://commits.webkit.org/266048@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6bd11f: Canvas context allocation fails because "Total can...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6bd11f3792f05b4e58e5647bf173212879fa62cc https://github.com/WebKit/WebKit/commit/6bd11f3792f05b4e58e5647bf173212879fa62cc Author: Dean Jackson Date: 2023-06-29 (Thu, 29 Jun 2023) Changed paths: M LayoutTests/fast/canvas/canvas-crash.html M LayoutTests/fast/canvas/canvas-skia-excessive-size.html R LayoutTests/fast/canvas/canvas-too-large-to-draw-expected.txt R LayoutTests/fast/canvas/canvas-too-large-to-draw.html M LayoutTests/fast/canvas/large-getImageData.html M LayoutTests/platform/wincairo/TestExpectations R LayoutTests/webgl/webgl-oom-paint-document-no-crash-expected.html R LayoutTests/webgl/webgl-oom-paint-document-no-crash.html M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/html/CanvasBase.h M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.idl M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp Log Message: --- Canvas context allocation fails because "Total canvas memory use exceeds the maximum limit" https://bugs.webkit.org/show_bug.cgi?id=195325 rdar://48609162 Reviewed by Geoff Garen. Some pages that use a lot of transient canvas memory can hit our artificial limits even when they are no longer referencing canvases. This happens because we don't instantly reclaim memory when we drop the reference, and instead have to wait for garbage collection. This problem can also continue between page refreshes. The limit was introduced many many releases ago when devices had less memory, and it was more common to accidentally jetsam a page if you used too much canvas memory. After some internal and external discussion we've decided to remove the canvas limit and just let the page follow the same memory restrictions as all other Web features. This might mean more pages crash (jetsam) than break. * LayoutTests/fast/canvas/canvas-too-large-to-draw-expected.txt: Removed. * LayoutTests/fast/canvas/canvas-too-large-to-draw.html: Removed. * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::allocateImageBuffer const): (WebCore::CanvasBase::maxActivePixelMemory): Deleted. (WebCore::CanvasBase::setMaxPixelMemoryForTesting): Deleted. * Source/WebCore/html/CanvasBase.h: * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createContext2d): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::resetToConsistentState): (WebCore::Internals::avoidIOSurfaceSizeCheckInWebProcess): (WebCore::Internals::setMaxCanvasPixelMemory): Deleted. * Source/WebCore/testing/Internals.idl: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::getPixelBufferForImageBufferWithNewMemory): Canonical link: https://commits.webkit.org/265628@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40b644: Safari video playback and Youtube app playback usi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40b644b3f1961d26cf352fabbba261a3f5181419 https://github.com/WebKit/WebKit/commit/40b644b3f1961d26cf352fabbba261a3f5181419 Author: Dean Jackson Date: 2023-06-28 (Wed, 28 Jun 2023) Changed paths: M LayoutTests/media/audio-session-category-at-most-recent-playback-expected.txt M LayoutTests/media/audio-session-category-at-most-recent-playback.html M LayoutTests/media/video-audio-session-mode-expected.txt M LayoutTests/media/video-audio-session-mode.html M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm Log Message: --- Safari video playback and Youtube app playback using Movie tuning route when it should be using General tuning route https://bugs.webkit.org/show_bug.cgi?id=258629 rdar://110648685 Reviewed by Jer Noble. We unilaterally changed the AudioSession Category for playback in a previous commit. It turns out this should only be for visionOS, which has an experience that is more like wearing headphones. Use the default category for iOS, and only the MoviePlayback category for visionOS. * LayoutTests/media/audio-session-category-at-most-recent-playback-expected.txt: * LayoutTests/media/audio-session-category-at-most-recent-playback.html: * LayoutTests/media/video-audio-session-mode-expected.txt: * LayoutTests/media/video-audio-session-mode.html: * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::updateSessionState): Canonical link: https://commits.webkit.org/265592@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 058ae5: WebGL in the GPUP should be enabled for watchOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 058ae53cb190adaa2d5d51fa7f39cdc366b45a27 https://github.com/WebKit/WebKit/commit/058ae53cb190adaa2d5d51fa7f39cdc366b45a27 Author: Dean Jackson Date: 2023-06-02 (Fri, 02 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformEnable.h Log Message: --- WebGL in the GPUP should be enabled for watchOS https://bugs.webkit.org/show_bug.cgi?id=257669 rdar://110191155 Reviewed by Per Arne Vollan and Mike Wyrzykowski. WebGL in the GPUP should be enabled for watchOS. * Source/WTF/wtf/PlatformEnable.h: Canonical link: https://commits.webkit.org/264845@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d6ae25: WebXR: Severe aliasing in WebXR experiences (with ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d6ae2528a9f3819005e08f9d5091ceff8b880fa8 https://github.com/WebKit/WebKit/commit/d6ae2528a9f3819005e08f9d5091ceff8b880fa8 Author: Dean Jackson Date: 2023-06-02 (Fri, 02 Jun 2023) Changed paths: M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/platform/graphics/GraphicsContextGL.h M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp Log Message: --- WebXR: Severe aliasing in WebXR experiences (with WebGL1 contexts) https://bugs.webkit.org/show_bug.cgi?id=256861 rdar://109424254 Reviewed by Dan Glastonbury. WebXR sessions using WebGL1 contexts are unable to turn on multisampling. I'm pretty sure this was my fault, but I can't remember if it was intentional or a mistake. Either way it is a bug. Fix this by implementing the multisample renderbuffer creation and resolution steps. Since we're doing this on a WebGL1 context, the normal API will be invalid (it requires GLES3), so call the extension API instead. This means we need to expose some extra methods on GraphicsContextGL. Lastly, the framebuffer textures we get are SRGB8_ALPHA8 which requires an extension to be enabled with a WebGL1 context when we're talking to an XR-compatible context. Similarly, we enable the extension to allow multisampled framebuffers. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::endFrame): call blitFramebufferANGLE. (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): Implement logic for WebGL 1. * Source/WebCore/platform/graphics/GraphicsContextGL.h: * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp: Implement the extension API/ (WebCore::GraphicsContextGLANGLE::renderbufferStorageMultisampleANGLE): (WebCore::GraphicsContextGLANGLE::blitFramebufferANGLE): * Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::platformInitialize): Turn on the sRGB extension. * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h: (renderbufferStorageMultisampleANGLE): (blitFramebufferANGLE): * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp: (WebKit::RemoteGraphicsContextGLProxy::renderbufferStorageMultisampleANGLE): (WebKit::RemoteGraphicsContextGLProxy::blitFramebufferANGLE): Canonical link: https://commits.webkit.org/264838@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ea1c0: MTLSharedEvent is returned as a RetainPtr
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ea1c0f48a09bcccb86edfbf78072d441f2c6f57 https://github.com/WebKit/WebKit/commit/5ea1c0f48a09bcccb86edfbf78072d441f2c6f57 Author: Dean Jackson Date: 2023-05-19 (Fri, 19 May 2023) Changed paths: M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp Log Message: --- MTLSharedEvent is returned as a RetainPtr https://bugs.webkit.org/show_bug.cgi?id=257072 rdar://109590090 Unreviewed. Build fix in WebXROpaqueFramebuffer. m_completionEvent is a RetainPtr. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::endFrame): Canonical link: https://commits.webkit.org/264282@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 79dcef: Tests crashing at com.apple.AssetViewer: __64-[ASV...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 79dceff293fcb856e9fc198fc8c7472bccc0563b https://github.com/WebKit/WebKit/commit/79dceff293fcb856e9fc198fc8c7472bccc0563b Author: Dean Jackson Date: 2023-05-08 (Mon, 08 May 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/ios-simulator/TestExpectations M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations M LayoutTests/platform/mac/TestExpectations M LayoutTests/platform/wpe/TestExpectations Log Message: --- Tests crashing at com.apple.AssetViewer: __64-[ASVInlinePreview preparePreviewOfFileAtURL:completionHandler:]_block_invoke_2 https://bugs.webkit.org/show_bug.cgi?id=256485 rdar://103419649 Unreviewed. The model element tests are crashing in various ways, causing other tests to appear to fail. Disable them all. * LayoutTests/TestExpectations: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/ios-simulator/TestExpectations: * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/263828@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f91c37: Tests crashing at com.apple.AssetViewer: __64-[ASV...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f91c377541e98376060b37ae823636d7dfff1d75 https://github.com/WebKit/WebKit/commit/f91c377541e98376060b37ae823636d7dfff1d75 Author: Dean Jackson Date: 2023-05-08 (Mon, 08 May 2023) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- Tests crashing at com.apple.AssetViewer: __64-[ASVInlinePreview preparePreviewOfFileAtURL:completionHandler:]_block_invoke_2 https://bugs.webkit.org/show_bug.cgi?id=256485 rdar://103419649 Unreviewed. The model element tests are crashing in various ways, causing other tests to appear to fail. Disable them temporarily. * LayoutTests/platform/mac/TestExpectations: Skip model-element. Canonical link: https://commits.webkit.org/263821@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 345d5c: Signal ARQL when a download fails
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 345d5c9e9dae6bcdf0a7cb4d9ddc34d5e921e348 https://github.com/WebKit/WebKit/commit/345d5c9e9dae6bcdf0a7cb4d9ddc34d5e921e348 Author: Dean Jackson Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: --- Signal ARQL when a download fails https://bugs.webkit.org/show_bug.cgi?id=254451 rdar://104039022 Reviewed by Tim Horton. ARQL doesn't get told when a download fails. Add this using their new SPI. * Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h: Add the new SPI. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: - Open the file handle as soon as we start downloading, so that we can make a URL. - ARQL fails if you give it a .reality file that doesn't have the right file extension, so add that if necessary. - Close the file handle if we fail the download. Also, tell ARQL that the load failed. - Lastly, make sure we always attach the fragment identifier, so ARQL knows that the cancel is related to a previous launch call. * Source/WebKit/UIProcess/SystemPreviewController.h: Canonical link: https://commits.webkit.org/263479@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 353f4a: Remove unused SystemPreview code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 353f4a5321755a37ef1ee6d0796ebdc4178187d1 https://github.com/WebKit/WebKit/commit/353f4a5321755a37ef1ee6d0796ebdc4178187d1 Author: Dean Jackson Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: --- Remove unused SystemPreview code https://bugs.webkit.org/show_bug.cgi?id=255963 rdar://108532798 Reviewed by Tim Horton. Previous patches moved SystemPreview to use a WKDataTask. Remove the old code that was called from the LegacyDownloadClient. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: Canonical link: https://commits.webkit.org/263476@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d55e3c: Use WKDataTask for SystemPreview downloads
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d55e3cae6649895b6d2aeb7235ba879bdb403868 https://github.com/WebKit/WebKit/commit/d55e3cae6649895b6d2aeb7235ba879bdb403868 Author: Dean Jackson Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/FoundationSPI.h M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebCore/page/ChromeClient.h M Source/WebCore/page/Page.cpp M Source/WebCore/page/Page.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h M Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj M Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm A Tools/TestWebKitAPI/Tests/WebKitCocoa/UnitBox.usdz M Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html A Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview.html Log Message: --- Use WKDataTask for SystemPreview downloads https://bugs.webkit.org/show_bug.cgi?id=255954 rdar://108524222 Reviewed by Tim Horton. Migrate away from LegacyDownloadClient and instead handle System Previews directly. This will allow us to remove the horrible code in the download client, as well eventually allow 3rd-party engines to use ARQL. The fix is to intercept the HTMLAnchorElement click for a system preview, and send that directly to the SystemPreviewController in the UI Process. That object then creates a WKDataTask for the download and presents ARQL as normal. A followup patch will remove the old code. * Source/WebCore/html/HTMLAnchorElement.cpp: * Source/WebCore/page/ChromeClient.h: * Source/WebCore/page/Page.cpp: * Source/WebCore/page/Page.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h: * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp: * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm: (-[TestSystemPreviewUIDelegate _presentingViewControllerForWebView:]): (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/UnitBox.usdz: Added. * Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: * Tools/TestWebKitAPI/Tests/WebKitCocoa/system-preview.html: Added. Canonical link: https://commits.webkit.org/263393@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 05aaf4: Remove LegacyDownloadClient code for SystemPreview
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 05aaf4a5692421321939630ecd0612308082ed21 https://github.com/WebKit/WebKit/commit/05aaf4a5692421321939630ecd0612308082ed21 Author: Dean Jackson Date: 2023-04-25 (Tue, 25 Apr 2023) Changed paths: M Source/WebCore/html/HTMLAnchorElement.cpp M Source/WebCore/loader/FrameLoadRequest.cpp M Source/WebCore/loader/FrameLoadRequest.h M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/FrameLoaderTypes.h M Source/WebCore/platform/network/ResourceRequestBase.cpp M Source/WebCore/platform/network/ResourceRequestBase.h M Source/WebCore/platform/network/cf/ResourceRequest.h M Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/API/APINavigation.h M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.h M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm M Source/WebKit/UIProcess/Downloads/DownloadProxy.h M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Remove LegacyDownloadClient code for SystemPreview https://bugs.webkit.org/show_bug.cgi?id=255957 rdar://108526852 Reviewed by Tim Horton. https://bugs.webkit.org/show_bug.cgi?id=255954 implements a new way to trigger this code, so the old way can be deleted. This will make Alex happy. * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): * Source/WebCore/loader/FrameLoadRequest.cpp: (WebCore::FrameLoadRequest::FrameLoadRequest): * Source/WebCore/loader/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::isSystemPreview const): Deleted. (WebCore::FrameLoadRequest::systemPreviewInfo const): Deleted. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::loadURL): * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/FrameLoaderTypes.h: * Source/WebCore/platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::isSystemPreview const): Deleted. (WebCore::ResourceRequestBase::systemPreviewInfo const): Deleted. (WebCore::ResourceRequestBase::setSystemPreviewInfo): Deleted. * Source/WebCore/platform/network/ResourceRequestBase.h: * Source/WebCore/platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): * Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::fromResourceRequestData): * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/API/APINavigation.h: (API::Navigation::isSystemPreview const): Deleted. * Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.h: * Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm: (WebKit::LegacyDownloadClient::legacyDidStart): (WebKit::LegacyDownloadClient::didReceiveResponse): (WebKit::LegacyDownloadClient::didReceiveData): (WebKit::LegacyDownloadClient::didCreateDestination): (WebKit::LegacyDownloadClient::processDidCrash): (WebKit::LegacyDownloadClient::decideDestinationWithSuggestedFilename): (WebKit::LegacyDownloadClient::didFinish): (WebKit::LegacyDownloadClient::didFail): (WebKit::LegacyDownloadClient::legacyDidCancel): (WebKit::systemPreviewController): Deleted. (WebKit::LegacyDownloadClient::takeActivityToken): Deleted. (WebKit::LegacyDownloadClient::releaseActivityTokenIfNecessary): Deleted. * Source/WebKit/UIProcess/Downloads/DownloadProxy.h: (WebKit::DownloadProxy::isSystemPreviewDownload const): Deleted. (WebKit::DownloadProxy::systemPreviewDownloadInfo const): Deleted. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::receivedNavigationPolicyDecision): Canonical link: https://commits.webkit.org/263392@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e0ce48: Safari is not using the intended AudioSession
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e0ce48fe5c2e1b20a22f817e081face321c7c541 https://github.com/WebKit/WebKit/commit/e0ce48fe5c2e1b20a22f817e081face321c7c541 Author: Dean Jackson Date: 2023-04-20 (Thu, 20 Apr 2023) Changed paths: M LayoutTests/media/audio-session-category-at-most-recent-playback-expected.txt M LayoutTests/media/audio-session-category-at-most-recent-playback.html M LayoutTests/media/audio-session-category-expected.txt M LayoutTests/media/audio-session-category.html A LayoutTests/media/video-audio-session-mode-expected.txt A LayoutTests/media/video-audio-session-mode.html M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/platform/audio/AudioSession.cpp M Source/WebCore/platform/audio/AudioSession.h M Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm M Source/WebCore/platform/audio/ios/AudioSessionIOS.h M Source/WebCore/platform/audio/ios/AudioSessionIOS.mm M Source/WebCore/platform/audio/mac/AudioSessionMac.h M Source/WebCore/platform/audio/mac/AudioSessionMac.mm M Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp M Source/WebCore/testing/Internals.cpp M Source/WebCore/testing/Internals.h M Source/WebCore/testing/Internals.idl M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.messages.in M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp M Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp M Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h M Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp Log Message: --- Safari is not using the intended AudioSession https://bugs.webkit.org/show_bug.cgi?id=255681 rdar://107095456 Reviewed by Jer Noble. WebKit never sets the AudioSession mode to anything other than "default", which is not appropriate for video playback, especially in a spatial audio environment. Fix this by exposing a way for the Media system to select an AudioSession mode, and set it to MoviePlayback when needed. * LayoutTests/media/audio-session-category-at-most-recent-playback-expected.txt: * LayoutTests/media/audio-session-category-at-most-recent-playback.html: * LayoutTests/media/audio-session-category-expected.txt: * LayoutTests/media/audio-session-category.html: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h: Expose the new mode constant. * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm: * Source/WebCore/html/HTMLMediaElement.cpp: Save the mode so that tests can query it. (WebCore::HTMLMediaElement::playPlayer): * Source/WebCore/html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::modeAtMostRecentPlayback const): * Source/WebCore/platform/audio/AudioSession.h: Add a new type AudioSession::Mode that can be set alongside the Category value. (WTF::LogArgument::toString): * Source/WebCore/platform/audio/AudioSession.cpp: (WebCore::AudioSession::setCategory): (WebCore::AudioSession::setCategoryOverride): (WebCore::AudioSession::mode const): (WebCore::convertEnumerationToString): * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::updateSessionState): Set the mode to VideoPlayback here if `hasAudibleAudioOrVideoMediaType` is true. * Source/WebCore/platform/audio/ios/AudioSessionIOS.h: * Source/WebCore/platform/audio/ios/AudioSessionIOS.mm: (WebCore::AudioSessionIOS::setCategory): Actually send the mode down to the AVAudioSession. (WebCore::AudioSessionIOS::mode const): * Source/WebCore/platform/audio/mac/AudioSessionMac.h: * Source/WebCore/platform/audio/mac/AudioSessionMac.mm: (WebCore::AudioSessionMac::setCategory): Accept the parameter, but we don't set anything on Mac. * Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp: (WebCore::MockRealtimeAudioSource::startProducingData): Update call to setCategory. * Source/WebCore/testing/Internals.cpp: Expose a way to test the mode. (WebCore::Internals::audioSessionMode const): (WebCore::Internals::modeAtMostRecentPlayback const): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: * Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp: (WebKit::RemoteAudioSessionProxy::setCategory): * Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h: (WebKit::RemoteAudioSessionProxy::mode const): * Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.messages.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit
[webkit-changes] [WebKit/WebKit] 8f3ab1: element counter-scaling causes overlapping...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8f3ab17c3a9d4ebeea314cb06ff6d8f073ef https://github.com/WebKit/WebKit/commit/8f3ab17c3a9d4ebeea314cb06ff6d8f073ef Author: Dean Jackson Date: 2023-04-14 (Fri, 14 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/html/HTMLMediaElement.cpp Log Message: --- element counter-scaling causes overlapping media elements when page scale is < 1 https://bugs.webkit.org/show_bug.cgi?id=255428 rdar://105846526 Reviewed by Tim Horton. We counter scale controls on iOS, which causes them to escape their element bounds if the user zooms out. Add a setting to disable this behaviour. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Add a new setting AudioControlsScaleWithPageZoom to mirror the generic Media setting. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Add a test that escapes before setting the value. Canonical link: https://commits.webkit.org/262952@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4b5b02: More build fixes for ANGLE on embedded platforms
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4b5b02b509683ac9d75644be5a3909ee20a670e4 https://github.com/WebKit/WebKit/commit/4b5b02b509683ac9d75644be5a3909ee20a670e4 Author: Dean Jackson Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/ThirdParty/ANGLE/src/common/apple/apple_platform.h M Source/ThirdParty/ANGLE/src/common/apple_platform_utils.mm M Source/ThirdParty/ANGLE/src/common/platform.h M Source/ThirdParty/ANGLE/src/common/system_utils.cpp M Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp M Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_internal.h M Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_ios.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Caps.cpp M Source/ThirdParty/ANGLE/src/libANGLE/Display.cpp M Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/apple/DisplayApple_api.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm Log Message: --- More build fixes for ANGLE on embedded platforms https://bugs.webkit.org/show_bug.cgi?id=254933 rdar://107570491 Reviewed by Ken Russell. The change https://commits.webkit.org/262190@main fixed one build issue on watchOS, but uncovered more on other Apple embedded platforms. Sometimes there were branches of code not being compiled on anything but iOS and macOS. A lot of this comes from the slighting confusing way Apple defines targets in TargetConditionals.h. This patch is an attempt to make better sense of it, and apply it to ANGLE. The idea is that this will land first in WebKit, and if it doesn't break anything it will be posted to upstream ANGLE. Note that macOS Catalyst builds might require a followup. * Source/ThirdParty/ANGLE/src/common/apple/apple_platform.h: The meat of the patch is here. Add a new APPLE_EMBEDDED definition for iOS/watchOS/tvOS. Split the simulator out into its own definition. Everything below this is moving things to use the embedded path where needed. * Source/ThirdParty/ANGLE/src/common/apple_platform_utils.mm: (angle::IsMetalRendererAvailable): * Source/ThirdParty/ANGLE/src/common/platform.h: * Source/ThirdParty/ANGLE/src/common/system_utils.cpp: (angle::OpenSystemLibraryAndGetError): * Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp: (angle::OpenSystemLibraryWithExtensionAndGetError): * Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_internal.h: * Source/ThirdParty/ANGLE/src/gpu_info_util/SystemInfo_ios.cpp: * Source/ThirdParty/ANGLE/src/libANGLE/Caps.cpp: (gl::DetermineDepthTextureANGLESupport): (gl::DetermineDepthTextureOESSupport): * Source/ThirdParty/ANGLE/src/libANGLE/Display.cpp: (egl::GenerateClientExtensions): * Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp: (gl::BuildInternalFormatInfoMap): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp: * Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h: (rx::IsAppleEmbedded): (rx::IsIOS): Deleted. * Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/apple/DisplayApple_api.cpp: (rx::CreateDisplayCGLOrEAGL): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp: (rx::nativegl_gl::InitializeFeatures): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm: (rx::DisplayMtl::initializeExtensions const): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm: (rx::ShaderMtl::compile): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm: (rx::mtl::GetSamplerAddressMode): Canonical link: https://commits.webkit.org/262636@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 65b2e0: Media: Videos opening fullscreen via JS API have d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 65b2e06df85324883b2f5b62e035a4f474db3fa6 https://github.com/WebKit/WebKit/commit/65b2e06df85324883b2f5b62e035a4f474db3fa6 Author: Dean Jackson Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h M Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp M Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h Log Message: --- Media: Videos opening fullscreen via JS API have duplicated fullscreen controls https://bugs.webkit.org/show_bug.cgi?id=255012 rdar://103032343 Reviewed by Aditya Keerthi. We overlay native "exit fullscreen" and "PiP" buttons when we think they are necessary. However, our detection of necessity was slightly incorrect. When a element goes fullscreen, we always inject our default controls. They provide their own "exit fullscreen" button, so the native one is not necessary. We were assuming you needed to have the `controls` attribute on the video. While here, rename the member variable to be more clear that we're hiding two particular buttons, not the media controls as a whole. * Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::isVideoElement const): (WebKit::WebFullScreenManagerProxy::enterFullScreen): (WebKit::WebFullScreenManagerProxy::isVideoElementWithControls const): Deleted. * Source/WebKit/UIProcess/WebFullScreenManagerProxy.h: * Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController initWithWebView:]): (-[WKFullScreenViewController videoControlsManagerDidChange]): (-[WKFullScreenViewController hideCancelAndPIPButtons:]): (-[WKFullScreenViewController hideMediaControls:]): Deleted. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen:]): * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement): * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: (WebKit::InjectedBundlePageFullScreenClient::enterFullScreenForElement): * Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h: Canonical link: https://commits.webkit.org/262632@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4103d2: Default build configuration for WebKit should be D...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4103d2cbf3e5e317a6a9ccf695637d27cedf65e2 https://github.com/WebKit/WebKit/commit/4103d2cbf3e5e317a6a9ccf695637d27cedf65e2 Author: Dean Jackson Date: 2023-03-30 (Thu, 30 Mar 2023) Changed paths: M Source/WebKit/WebKit.xcodeproj/xcshareddata/xcschemes/WebKit.xcscheme Log Message: --- Default build configuration for WebKit should be Debug https://bugs.webkit.org/show_bug.cgi?id=254712 rdar://107394752 Reviewed by Antoine Quint. Make Debug builds the default for the WebKit scheme. * Source/WebKit/WebKit.xcodeproj/xcshareddata/xcschemes/WebKit.xcscheme: Canonical link: https://commits.webkit.org/262329@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 69a415: TextureMirrorClampToEdgeEXT is not available on wa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 69a4159e08ae77ab28177ed872a21decec5c641e https://github.com/WebKit/WebKit/commit/69a4159e08ae77ab28177ed872a21decec5c641e Author: Dean Jackson Date: 2023-03-27 (Mon, 27 Mar 2023) Changed paths: M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm Log Message: --- TextureMirrorClampToEdgeEXT is not available on watchOS https://bugs.webkit.org/show_bug.cgi?id=254557 rdar://107290832 Reviewed by Elliot Williams and Tim Horton. This extension is not supported on watchOS. We need to guard against the enum values. * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm: (rx::DisplayMtl::initializeExtensions const): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm: (rx::mtl::GetSamplerAddressMode): Canonical link: https://commits.webkit.org/262190@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e78009: ARQL: Launch Preview needs to be passed along the ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7800968d1c8f502c22250854397d16fd0679cde https://github.com/WebKit/WebKit/commit/e7800968d1c8f502c22250854397d16fd0679cde Author: Dean Jackson Date: 2023-03-24 (Fri, 24 Mar 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm Log Message: --- ARQL: Launch Preview needs to be passed along the appropriate disableScaling and customSharing fragment identifiers https://bugs.webkit.org/show_bug.cgi?id=254371 rdar://106193234 Reviewed by Antoine Quint. ARQL needs to see the fragment identifier on the link in order to do things like disable scaling. * Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm: (WebKit::LegacyDownloadClient::didCreateDestination): Pass along the fragment identifier. (WebKit::LegacyDownloadClient::didFinish): Copy the code from above. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Don't explicitly remove the fragment identifier. Canonical link: https://commits.webkit.org/262080@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b9ab83: WebXR needs to not crash on macOS with GPU Process...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b9ab83d9212044c2635894eb20cce29758303cb2 https://github.com/WebKit/WebKit/commit/b9ab83d9212044c2635894eb20cce29758303cb2 Author: Dean Jackson Date: 2023-03-17 (Fri, 17 Mar 2023) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac/TestExpectations M LayoutTests/platform/mac/fast/dom/navigator-detached-no-crash-expected.txt M Source/WTF/wtf/PlatformEnableCocoa.h Log Message: --- WebXR needs to not crash on macOS with GPU Process enabled https://bugs.webkit.org/show_bug.cgi?id=254043 rdar://102067140 Reviewed by Tim Horton. Temporarily disable WebXR on macOS while we implement the GPUP support for it. Reenablement is tracked in https://bugs.webkit.org/show_bug.cgi?id=254044 * Source/WTF/wtf/PlatformEnableCocoa.h: Canonical link: https://commits.webkit.org/261811@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fb73c: Cherry-pick 41855a914387. rdar://problem/103458234
Branch: refs/heads/safari-7616.1.5-branch Home: https://github.com/WebKit/WebKit Commit: 3fb73c04b21e4a3768df1616f42a720c59f8a6ef https://github.com/WebKit/WebKit/commit/3fb73c04b21e4a3768df1616f42a720c59f8a6ef Author: Dean Jackson Date: 2023-03-03 (Fri, 03 Mar 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm Log Message: --- Cherry-pick 41855a914387. rdar://problem/103458234 Opt out of playback preventing app backgrounding for silent videos https://bugs.webkit.org/show_bug.cgi?id=253163 rdar://103458234 Reviewed by Jer Noble and Eric Carlson. AVFoundation has exposed new API on AVPlayer and AVSampleBufferDisplayLayer to avoid silent media playback from keeping the app moving to the background. Test for the property, then set it to NO. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer): * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: (WebCore::MediaPlayerPrivateWebM::ensureLayer): Canonical link: https://commits.webkit.org/261128@main Canonical link: https://commits.webkit.org/261058.4@safari-7616.1.5-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 70e57c: Cherry-pick 41855a914387. rdar://problem/103458234
Branch: refs/heads/safari-7616.1.4-branch Home: https://github.com/WebKit/WebKit Commit: 70e57c28227fb6852e23f860c6d6df72a485c952 https://github.com/WebKit/WebKit/commit/70e57c28227fb6852e23f860c6d6df72a485c952 Author: Dean Jackson Date: 2023-03-03 (Fri, 03 Mar 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm Log Message: --- Cherry-pick 41855a914387. rdar://problem/103458234 Opt out of playback preventing app backgrounding for silent videos https://bugs.webkit.org/show_bug.cgi?id=253163 rdar://103458234 Reviewed by Jer Noble and Eric Carlson. AVFoundation has exposed new API on AVPlayer and AVSampleBufferDisplayLayer to avoid silent media playback from keeping the app moving to the background. Test for the property, then set it to NO. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer): * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: (WebCore::MediaPlayerPrivateWebM::ensureLayer): Canonical link: https://commits.webkit.org/261128@main Canonical link: https://commits.webkit.org/260848.7@safari-7616.1.4-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 41855a: Opt out of playback preventing app backgrounding f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 41855a9143871d0ff15e9880b841fd51a11164e6 https://github.com/WebKit/WebKit/commit/41855a9143871d0ff15e9880b841fd51a11164e6 Author: Dean Jackson Date: 2023-03-03 (Fri, 03 Mar 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm Log Message: --- Opt out of playback preventing app backgrounding for silent videos https://bugs.webkit.org/show_bug.cgi?id=253163 rdar://103458234 Reviewed by Jer Noble and Eric Carlson. AVFoundation has exposed new API on AVPlayer and AVSampleBufferDisplayLayer to avoid silent media playback from keeping the app moving to the background. Test for the property, then set it to NO. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer): * Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm: (WebCore::MediaPlayerPrivateWebM::ensureLayer): Canonical link: https://commits.webkit.org/261128@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 17ea45: Some SystemPreview actions are not being detected
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 17ea4508cabe787a84cfca694baec246a43e6393 https://github.com/WebKit/WebKit/commit/17ea4508cabe787a84cfca694baec246a43e6393 Author: Dean Jackson Date: 2023-02-22 (Wed, 22 Feb 2023) Changed paths: M Source/WebKit/Platform/Logging.h M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm Log Message: --- Some SystemPreview actions are not being detected https://bugs.webkit.org/show_bug.cgi?id=252780 rdar://105800886 Reviewed by Darin Adler. We're getting reports of some SystemPreviews not detecting the user action. We've been unable to reproduce, so this is adding some release logging to help us narrow down the problem. * Source/WebKit/Platform/Logging.h: * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Add logging when a user taps on a link, it finishes loading, the user clicks, and the preview ends. Canonical link: https://commits.webkit.org/260727@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb4854: Allow iPad UserAgent header to be static
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb48549c51eda1cc99d256d1cfbce7576883b9f5 https://github.com/WebKit/WebKit/commit/fb48549c51eda1cc99d256d1cfbce7576883b9f5 Author: Dean Jackson Date: 2023-02-17 (Fri, 17 Feb 2023) Changed paths: M Source/WebCore/platform/ios/UserAgentIOS.mm Log Message: --- Allow iPad UserAgent header to be static https://bugs.webkit.org/show_bug.cgi?id=252421 rdar://105504510 Reviewed by Tim Horton. There are cases where we want to provide a static UserAgent header, similar to what we do for desktop-class browsing. But unlike that, we still want to identify as a mobile browser, so we need the "iPad" component. This would be better exposed as a Setting, but this method is called from WebKit without a Document, so it is a compile- time guard for now. * Source/WebCore/platform/ios/UserAgentIOS.mm: (WebCore::standardUserAgentWithApplicationName): Canonical link: https://commits.webkit.org/260450@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b251c: Revert 8c5dd8c31d25. rdar://problem/103764832
Branch: refs/heads/safari-7615.1.16.1-branch Home: https://github.com/WebKit/WebKit Commit: 9b251c40b7d74bc5dd1fa0d8067edeaea41f0237 https://github.com/WebKit/WebKit/commit/9b251c40b7d74bc5dd1fa0d8067edeaea41f0237 Author: Alan Coon Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M Source/WebKit/Shared/Sandbox/common.sb Log Message: --- Revert 8c5dd8c31d25. rdar://problem/103764832 This reverts commit 4aead986769f72773686c872d5a78c04375f889b. Canonical link: https://commits.webkit.org/257979.12@safari-7615.1.16.1-branch Commit: dbaab09195d39e10ac2ab47f81bb2b58bd2e61b4 https://github.com/WebKit/WebKit/commit/dbaab09195d39e10ac2ab47f81bb2b58bd2e61b4 Author: Tim Horton Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M Source/WebCore/page/InteractionRegion.cpp Log Message: --- Cherry-pick 2e2c969c2b73. rdar://problem/103465057 WebKit crash-looping under WebCore::interactionRegionForRenderedRegion after 256432@main https://bugs.webkit.org/show_bug.cgi?id=249744 rdar://103465057 Reviewed by Wenson Hsieh. * Source/WebCore/page/InteractionRegion.cpp: (WebCore::interactionRegionForRenderedRegion): Avoid dereferencing `element` if it is null. Both of these assignments change `element` but only if they find nonnull parents to ascend to, so we don't need to duplicate the check, we can just move it upwards. Canonical link: https://commits.webkit.org/258220@main Canonical link: https://commits.webkit.org/257979.13@safari-7615.1.16.1-branch Commit: 7fa55dd58256b342bb5da5737bf07db8e6db74bf https://github.com/WebKit/WebKit/commit/7fa55dd58256b342bb5da5737bf07db8e6db74bf Author: Dean Jackson Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: --- Cherry-pick 60f0cac6d918. rdar://problem/103499310 Safari should pass current URL to ARQL when using ASVLaunchPreview https://bugs.webkit.org/show_bug.cgi?id=250056 rdar://103499310 Reviewed by Tim Horton. ARQL have updated the ASVLaunchPreview API to allow an originating URL. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: Canonical link: https://commits.webkit.org/258439@main Canonical link: https://commits.webkit.org/257979.14@safari-7615.1.16.1-branch Compare: https://github.com/WebKit/WebKit/compare/4aead986769f...7fa55dd58256 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60f0ca: Safari should pass current URL to ARQL when using ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60f0cac6d918171da9beae365f712a3ac1166bd1 https://github.com/WebKit/WebKit/commit/60f0cac6d918171da9beae365f712a3ac1166bd1 Author: Dean Jackson Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: --- Safari should pass current URL to ARQL when using ASVLaunchPreview https://bugs.webkit.org/show_bug.cgi?id=250056 rdar://103499310 Reviewed by Tim Horton. ARQL have updated the ASVLaunchPreview API to allow an originating URL. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: Canonical link: https://commits.webkit.org/258439@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ba9be: Catalyst build is broken
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ba9bec9bc99aed57025dcc971f6a226215293d6 https://github.com/WebKit/WebKit/commit/5ba9bec9bc99aed57025dcc971f6a226215293d6 Author: Dean Jackson Date: 2022-12-15 (Thu, 15 Dec 2022) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Tools/DumpRenderTree/mac/UIDelegate.mm Log Message: --- Catalyst build is broken https://bugs.webkit.org/show_bug.cgi?id=249441 rdar://103424117 Reviewed by Tim Horton. Some small tweaks to get local Catalyst builds working. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]): * Tools/DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webViewClose:]): Canonical link: https://commits.webkit.org/257963@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7b47f8: [iOS EWS] TestWebKitAPI.ProcessSwap.CrossOriginSys...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b47f891dd8ef065e9ac7656f30975acca997ef9 https://github.com/WebKit/WebKit/commit/7b47f891dd8ef065e9ac7656f30975acca997ef9 Author: Dean Jackson Date: 2022-12-13 (Tue, 13 Dec 2022) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [iOS EWS] TestWebKitAPI.ProcessSwap.CrossOriginSystemPreview and TestWebKitAPI.ProcessSwap.SameOriginSystemPreview consistently timing out https://bugs.webkit.org/show_bug.cgi?id=249277 rdar://103318890 Reviewed by Chris Dumez. Traces suggest this is stalling trying to load something over the network and, indeed, the test content references a real URL inside the `img` element. Change this to point to a `pson` scheme and intercept the load to provide fake data. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/257825@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82b61e: P3 colorspace support for WebGL canvas on iOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82b61e28388d39958b3747cd2c88781c07b82489 https://github.com/WebKit/WebKit/commit/82b61e28388d39958b3747cd2c88781c07b82489 Author: Dean Jackson Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M Source/WebCore/html/canvas/WebGLRenderingContextBase.idl Log Message: --- P3 colorspace support for WebGL canvas on iOS https://bugs.webkit.org/show_bug.cgi?id=249180 rdar://101663634 Reviewed by Simon Fraser. Remove the flag restricting this to macOS. * Source/WebCore/html/canvas/WebGLRenderingContextBase.idl: Canonical link: https://commits.webkit.org/257776@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 407bf5: Add more deprecation guards for AVFoundation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 407bf5b3e4df1c25be1ac59021623d370e2f435c https://github.com/WebKit/WebKit/commit/407bf5b3e4df1c25be1ac59021623d370e2f435c Author: Dean Jackson Date: 2022-12-07 (Wed, 07 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm M Source/WebKit/Shared/Cocoa/WebIconUtilities.mm Log Message: --- Add more deprecation guards for AVFoundation https://bugs.webkit.org/show_bug.cgi?id=248891 Reviewed by Tim Horton. * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect): (WebCore::MediaPlayerPrivateAVFoundationObjC::processChapterTracks): (WebCore::MediaPlayerPrivateAVFoundationObjC::firstEnabledTrack const): (WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia): (WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForAudibleMedia): (WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForVisualMedia): (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack const): * Source/WebKit/Shared/Cocoa/WebIconUtilities.mm: (WebKit::iconForVideoFile): Canonical link: https://commits.webkit.org/257495@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ce361a: Add deprecation guards for various AVFoundation calls
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ce361abc6ad80a0353e8af5115af58af333c1dd4 https://github.com/WebKit/WebKit/commit/ce361abc6ad80a0353e8af5115af58af333c1dd4 Author: Dean Jackson Date: 2022-12-05 (Mon, 05 Dec 2022) Changed paths: M Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm M Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm M Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm Log Message: --- Add deprecation guards for various AVFoundation calls https://bugs.webkit.org/show_bug.cgi?id=248794 Reviewed by Antoine Quint. * Source/WebCore/PAL/pal/avfoundation/OutputDevice.mm: (PAL::OutputDevice::name const): * Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm: (WebCore::CDMSessionAVFoundationObjC::generateKeyRequest): * Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm: (WebCore::ImageDecoderAVFObjC::firstEnabledTrack): Canonical link: https://commits.webkit.org/257395@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ef3a06: Show thumbnail when navigating to a USDZ file
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ef3a06e1f3c35d4776583f03ec9688f6e9f9152c https://github.com/WebKit/WebKit/commit/ef3a06e1f3c35d4776583f03ec9688f6e9f9152c Author: Dean Jackson Date: 2022-11-30 (Wed, 30 Nov 2022) Changed paths: M Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm M Source/WebKit/UIProcess/ios/WKUSDPreviewView.h M Source/WebKit/UIProcess/ios/WKUSDPreviewView.mm Log Message: --- Show thumbnail when navigating to a USDZ file https://bugs.webkit.org/show_bug.cgi?id=248574 rdar://102780167 Reviewed by Tim Horton. ASVThumbnailView is available again, so use it. * Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: (-[WKWebViewContentProviderRegistry initWithConfiguration:]): * Source/WebKit/UIProcess/ios/WKUSDPreviewView.h: * Source/WebKit/UIProcess/ios/WKUSDPreviewView.mm: Canonical link: https://commits.webkit.org/257206@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ca0682: Closing ARQL results in an empty view with a spinner
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca068233ac864da83dc48c89a51cc9d7f4ee05e8 https://github.com/WebKit/WebKit/commit/ca068233ac864da83dc48c89a51cc9d7f4ee05e8 Author: Dean Jackson Date: 2022-11-30 (Wed, 30 Nov 2022) Changed paths: M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm Log Message: --- Closing ARQL results in an empty view with a spinner https://bugs.webkit.org/show_bug.cgi?id=248538 rdar://102379447 Reviewed by Antoine Quint. ARQL compares the URL we give it at the start of a download to the one we give it at the end. The latter one has the fragment identifier appended, and unfortunately ARQL does a string comparison. This causes it to think it is opening two different files, resulting in a spinner spinning forever. * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: Remove the fragment identifier before sending it to ARQL. Canonical link: https://commits.webkit.org/257188@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8537f7: Media fullscreen banner showing when gesture is di...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8537f74a00cdbcc63ca53257f9924200e8214319 https://github.com/WebKit/WebKit/commit/8537f74a00cdbcc63ca53257f9924200e8214319 Author: Dean Jackson Date: 2022-11-28 (Mon, 28 Nov 2022) Changed paths: M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm Log Message: --- Media fullscreen banner showing when gesture is disabled https://bugs.webkit.org/show_bug.cgi?id=248441 rdar://101917160 Reviewed by Eric Carlson. We currently show a banner explaining the gesture to get out of fullscreen on iOS. However, certain build configurations do not support that gesture, so make the banner conditional on that compile flag. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController invalidate]): (-[WKFullScreenViewController showBanner]): (-[WKFullScreenViewController hideBanner]): (-[WKFullScreenViewController setLocation:]): (-[WKFullScreenViewController loadView]): Canonical link: https://commits.webkit.org/257101@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 703520: Zillow.com: Scrolling or pinching the map causes p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 70352065621e3f98e7e61e75ecb52943d16037ed https://github.com/WebKit/WebKit/commit/70352065621e3f98e7e61e75ecb52943d16037ed Author: Dean Jackson Date: 2022-11-18 (Fri, 18 Nov 2022) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp M Source/WebCore/html/canvas/WebGL2RenderingContext.h M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.h M Source/WebCore/html/canvas/WebGLRenderingContextBase.idl Log Message: --- Zillow.com: Scrolling or pinching the map causes page to freeze https://bugs.webkit.org/show_bug.cgi?id=248099 rdar://102120764 Unreviewed. Reverting 255256@main. * LayoutTests/TestExpectations: * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: (WebCore::WebGL2RenderingContext::readPixels): * Source/WebCore/html/canvas/WebGL2RenderingContext.h: * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::readPixels): * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/html/canvas/WebGLRenderingContextBase.idl: Canonical link: https://commits.webkit.org/256851@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e37fe: Cherry-pick 9626f28c4f96. rdar://problem/101981518
Branch: refs/heads/safari-7615.1.12-branch Home: https://github.com/WebKit/WebKit Commit: 1e37fe2685935d248f524e69429eb1b748a2bbf3 https://github.com/WebKit/WebKit/commit/1e37fe2685935d248f524e69429eb1b748a2bbf3 Author: Dean Jackson Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: --- Cherry-pick 9626f28c4f96. rdar://problem/101981518 Adopt new ARQL scene API when possible https://bugs.webkit.org/show_bug.cgi?id=247511 rdar://101981518 Reviewed by Sam Weinig. AR Quick Look are exposing a new API to launch scenes. Add support for it when the right compile-time flags are set. * Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h: * Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm: (WebKit::LegacyDownloadClient::didCreateDestination): * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: Canonical link: https://commits.webkit.org/256671@main Canonical link: https://commits.webkit.org/256138.29@safari-7615.1.12-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9626f2: Adopt new ARQL scene API when possible
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9626f28c4f960793e9efcd05937293dd62cb930b https://github.com/WebKit/WebKit/commit/9626f28c4f960793e9efcd05937293dd62cb930b Author: Dean Jackson Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h M Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm M Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm M Source/WebKit/UIProcess/SystemPreviewController.h Log Message: --- Adopt new ARQL scene API when possible https://bugs.webkit.org/show_bug.cgi?id=247511 rdar://101981518 Reviewed by Sam Weinig. AR Quick Look are exposing a new API to launch scenes. Add support for it when the right compile-time flags are set. * Source/WebCore/PAL/pal/spi/ios/SystemPreviewSPI.h: * Source/WebKit/UIProcess/Cocoa/LegacyDownloadClient.mm: (WebKit::LegacyDownloadClient::didCreateDestination): * Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm: * Source/WebKit/UIProcess/SystemPreviewController.h: Canonical link: https://commits.webkit.org/256671@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 615b2c: Hide more standard library exports
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 615b2c8069cdda2b86c6c82e6433a8138a53f218 https://github.com/WebKit/WebKit/commit/615b2c8069cdda2b86c6c82e6433a8138a53f218 Author: Dean Jackson Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig Log Message: --- Hide more standard library exports https://bugs.webkit.org/show_bug.cgi?id=247388 rdar://101884652 Reviewed by Sihui Liu. New toolchains have new C++ standard library symbols that need to be hidden. * Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig: Add more symbols to OTHER_LDFLAGS_HIDE_SYMBOLS. Canonical link: https://commits.webkit.org/256259@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 232d6c: Guard against ARKitSoftLink on macOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 232d6ce7870643e3c6d5a1698714503200d3190b https://github.com/WebKit/WebKit/commit/232d6ce7870643e3c6d5a1698714503200d3190b Author: Dean Jackson Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M Source/WebKit/Shared/Cocoa/ARKitSoftLink.mm Log Message: --- Guard against ARKitSoftLink on macOS https://bugs.webkit.org/show_bug.cgi?id=247082 rdar://101447167 Reviewed by Tim Horton. ARKit isn't available on macOS. Our softlinking code is guarded by PLATFORM(COCOA), which is a bit misleading. It doesn't cause problems because a later condition restricts it to PLATFORM(IOS), but we should be more clear. * Source/WebKit/Shared/Cocoa/ARKitSoftLink.mm: Tweak the #if. Canonical link: https://commits.webkit.org/256163@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82d2d6: Remove WebGLLoadPolicy code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82d2d64c2ad7dcc2163f7ca040b73f587bd1b833 https://github.com/WebKit/WebKit/commit/82d2d64c2ad7dcc2163f7ca040b73f587bd1b833 Author: Dean Jackson Date: 2022-10-28 (Fri, 28 Oct 2022) Changed paths: R LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt R LayoutTests/fast/canvas/webgl/useWhilePending.html M LayoutTests/platform/mac-wk1/TestExpectations M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp M Source/WebCore/html/canvas/WebGLRenderingContext.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp M Source/WebCore/html/canvas/WebGLRenderingContextBase.h M Source/WebCore/loader/FrameLoaderClient.h M Source/WebCore/loader/FrameLoaderTypes.h M Source/WebCore/page/Settings.yaml M Source/WebKit/Scripts/webkit/messages.py M Source/WebKit/UIProcess/API/APINavigationClient.h M Source/WebKit/UIProcess/API/C/WKAPICast.h M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/C/WKPageLoaderClient.h M Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h M Source/WebKit/UIProcess/Cocoa/NavigationState.h M Source/WebKit/UIProcess/Cocoa/NavigationState.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm M Tools/TestWebKitAPI/SourcesCocoa.txt R Tools/TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm Log Message: --- Remove WebGLLoadPolicy code https://bugs.webkit.org/show_bug.cgi?id=247039 rdar://101569935 Reviewed by Kimmo Kinnunen. We don't use the WebGLLoadPolicy mechanism any more. Remove all the code. * LayoutTests/fast/canvas/webgl/useWhilePending-expected.txt: Removed. * LayoutTests/fast/canvas/webgl/useWhilePending.html: Removed. * Source/WebCore/html/canvas/WebGL2RenderingContext.cpp: Lots of removal for isContextLostOrPending(). * Source/WebCore/html/canvas/WebGLRenderingContext.cpp: * Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::isContextLostOrPending): Deleted. * Source/WebCore/html/canvas/WebGLRenderingContextBase.h: * Source/WebCore/loader/FrameLoaderClient.h: * Source/WebCore/loader/FrameLoaderTypes.h: * Source/WebCore/page/Settings.yaml: * Source/WebKit/Scripts/webkit/messages.py: (headers_for_type): * Source/WebKit/UIProcess/API/APINavigationClient.h: (API::NavigationClient::webGLLoadPolicy const): Deleted. (API::NavigationClient::resolveWebGLLoadPolicy const): Deleted. * Source/WebKit/UIProcess/API/C/WKAPICast.h: (WebKit::toWebGLLoadPolicy): Deleted. * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageSetPageLoaderClient): * Source/WebKit/UIProcess/API/C/WKPageLoaderClient.h: * Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: * Source/WebKit/UIProcess/Cocoa/NavigationState.h: * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::setNavigationDelegate): (WebKit::toWebCoreWebGLLoadPolicy): Deleted. (WebKit::NavigationState::NavigationClient::webGLLoadPolicy const): Deleted. (WebKit::NavigationState::NavigationClient::resolveWebGLLoadPolicy const): Deleted. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::webGLPolicyForURL): Deleted. (WebKit::WebPageProxy::resolveWebGLPolicyForURL): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::webGLPolicyForURL const): Deleted. (WebKit::WebFrameLoaderClient::resolveWebGLPolicyForURL const): Deleted. * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::webGLPolicyForURL): Deleted. (WebKit::WebPage::resolveWebGLPolicyForURL): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::webGLPolicyForURL): Deleted. (WebKit::WebPage::resolveWebGLPolicyForURL): Deleted. * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h: * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm: (shouldBlockWebGL): Deleted. (WebFrameLoaderClient::webGLPolicyForURL const): Deleted. (WebFrameLoaderClient::resolveWebGLPolicyForURL const): Deleted. * Tools/TestWebKitAPI/SourcesCocoa.txt: * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm: Removed. Canonical link: https://commits.webkit.org/256114@main
[webkit-changes] [WebKit/WebKit] ae1e3e: Remove ImageBitmapEnabled from DeprecatedGlobalSet...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae1e3ede5a3eb89670e005bc83aec401b8e19d6f https://github.com/WebKit/WebKit/commit/ae1e3ede5a3eb89670e005bc83aec401b8e19d6f Author: Dean Jackson Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml M Source/WebCore/html/ImageBitmap.idl M Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl M Source/WebCore/page/DeprecatedGlobalSettings.h M Source/WebCore/page/WindowOrWorkerGlobalScope.idl M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp Log Message: --- Remove ImageBitmapEnabled from DeprecatedGlobalSettings https://bugs.webkit.org/show_bug.cgi?id=247099 rdar://101610138 Reviewed by Sam Weinig. Remove ImageBitmapEnabled from DeprecatedGlobalSettings and WebPreferences. We enable this by default everywhere and don't have any need to disable it. Another gift for Sam Weinig. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebCore/html/ImageBitmap.idl: * Source/WebCore/html/canvas/ImageBitmapRenderingContext.idl: * Source/WebCore/page/DeprecatedGlobalSettings.h: (WebCore::DeprecatedGlobalSettings::setImageBitmapEnabled): Deleted. (WebCore::DeprecatedGlobalSettings::imageBitmapEnabled): Deleted. * Source/WebCore/page/WindowOrWorkerGlobalScope.idl: * Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp: (WebKit::WebInspectorUI::enableFrontendFeatures): Canonical link: https://commits.webkit.org/256077@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 779033: Remove unused webXREnabled deprecated global setting
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7790337646a26c99563ded137dc373a2ce0931a3 https://github.com/WebKit/WebKit/commit/7790337646a26c99563ded137dc373a2ce0931a3 Author: Dean Jackson Date: 2022-10-26 (Wed, 26 Oct 2022) Changed paths: M Source/WebCore/page/DeprecatedGlobalSettings.h Log Message: --- Remove unused webXREnabled deprecated global setting https://bugs.webkit.org/show_bug.cgi?id=247075 rdar://101595916 Reviewed by Tim Horton. Make Sam Weinig slightly happier by removing a DeprecatedGlobalSetting that wasn't even being used. All the code looks for the existing preference. * Source/WebCore/page/DeprecatedGlobalSettings.h: (WebCore::DeprecatedGlobalSettings::setWebXREnabled): Deleted. (WebCore::DeprecatedGlobalSettings::webXREnabled): Deleted. Canonical link: https://commits.webkit.org/256034@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5307a8: Add Kyle's github username
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5307a823f8464dfda43a9f0d810cef2b1eb0587c https://github.com/WebKit/WebKit/commit/5307a823f8464dfda43a9f0d810cef2b1eb0587c Author: Dean Jackson Date: 2022-10-24 (Mon, 24 Oct 2022) Changed paths: M metadata/contributors.json Log Message: --- Add Kyle's github username https://bugs.webkit.org/show_bug.cgi?id=246985 rdar://101526825 Unreviewed. * metadata/contributors.json: Canonical link: https://commits.webkit.org/255939@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1626a4: Clamp fullscreen window size based on video dimens...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1626a43b85c9e19cb35cab1d7f752749a31fd55f https://github.com/WebKit/WebKit/commit/1626a43b85c9e19cb35cab1d7f752749a31fd55f Author: Dean Jackson Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- Clamp fullscreen window size based on video dimensions https://bugs.webkit.org/show_bug.cgi?id=246883 Reviewed by Aditya Keerthi. We have a preferred size for fullscreen windows, and then we try to fit video into that size. But if the video is an unusual aspect ratio, we can accidentally create windows that escape the bounds. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen:]): Clamp the window size to the preferred dimensions. Canonical link: https://commits.webkit.org/255857@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f7d70a: Safari crashes upon clicking the object in AR Quic...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f7d70aae1103dc7eb282342089cf56cd2c8a9447 https://github.com/WebKit/WebKit/commit/f7d70aae1103dc7eb282342089cf56cd2c8a9447 Author: Dean Jackson Date: 2022-10-20 (Thu, 20 Oct 2022) Changed paths: M Source/WebKit/Shared/Cocoa/ARKitSoftLink.mm Log Message: --- Safari crashes upon clicking the object in AR Quicklook https://bugs.webkit.org/show_bug.cgi?id=246821 rdar://100022666 Reviewed by Antoine Quint. ARKit is in /System/Library/Frameworks, not PrivateFrameworks. * Source/WebKit/Shared/Cocoa/ARKitSoftLink.mm: Canonical link: https://commits.webkit.org/255799@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e01a91: Add preference for size of fullscreen window
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e01a9102cf543994daa725d2f0d54c35a9b50eab https://github.com/WebKit/WebKit/commit/e01a9102cf543994daa725d2f0d54c35a9b50eab Author: Dean Jackson Date: 2022-10-18 (Tue, 18 Oct 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferences.yaml M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm Log Message: --- Add preference for size of fullscreen window https://bugs.webkit.org/show_bug.cgi?id=246728 rdar://101319114 Reviewed by Tim Horton. Expose a preference that suggests a width for the fullscreen window, and then use that value when creating the UIWindow. * Source/WTF/Scripts/Preferences/WebPreferences.yaml: Add MediaPreferredFullscreenWidth. * Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _setMediaPreferredFullscreenWidth:]): (-[WKPreferences _mediaPreferredFullscreenWidth]): * Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h: * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen:]): Use the preference value. Canonical link: https://commits.webkit.org/255712@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d71fb1: CSS Keyframes names can't be CSS wide keywords
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d71fb1b829e793d50dc0d909865611cdb22e5589 https://github.com/WebKit/WebKit/commit/d71fb1b829e793d50dc0d909865611cdb22e5589 Author: Dean Jackson Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-invalid-expected.txt M Source/WebCore/css/parser/CSSParserImpl.cpp Log Message: --- CSS Keyframes names can't be CSS wide keywords https://bugs.webkit.org/show_bug.cgi?id=246596 rdar://101226253 Reviewed by Tim Nguyen. The CSS Animations and CSS Values specifications require identifier-based keyframes names to not be CSS wide keywords, nor "default", nor "none". * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-invalid-expected.txt: * Source/WebCore/css/parser/CSSParserImpl.cpp: (WebCore::CSSParserImpl::consumeKeyframesRule): Forbid the invalid names. Canonical link: https://commits.webkit.org/255640@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82a8c1: Use MTLSharedTexture for bounds calculation in WebXR
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82a8c10638a4093d33186e7da6d1c63f781f46f9 https://github.com/WebKit/WebKit/commit/82a8c10638a4093d33186e7da6d1c63f781f46f9 Author: Dean Jackson Date: 2022-10-15 (Sat, 15 Oct 2022) Changed paths: M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm Log Message: --- Use MTLSharedTexture for bounds calculation in WebXR https://bugs.webkit.org/show_bug.cgi?id=246555 rdar://101195746 Reviewed by Antoine Quint. The incoming IOSurface can't reliably be used for bounds calculation. It first has to be turned back into a MTLTexture. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::startFrame): Move the logic to test for the size of the incoming texture until after we've associated the IOSurface with a MTLTexture. (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.h: * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::attachIOSurfaceToSharedTexture): Return the width and height of the texture along with the EGL image handle. Canonical link: https://commits.webkit.org/255595@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f796e: Update import of WPT css-animations parsing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f796e716d8851cd4b39ecb7196d0358c16b6e2a https://github.com/WebKit/WebKit/commit/2f796e716d8851cd4b39ecb7196d0358c16b6e2a Author: Dean Jackson Date: 2022-10-15 (Sat, 15 Oct 2022) Changed paths: M LayoutTests/imported/w3c/resources/import-expectations.json M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-computed-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-computed.html M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-invalid-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-invalid.html M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-valid.html R LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html R LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-invalid-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-invalid.html R LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt R LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-invalid-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-invalid.html A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-valid-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-valid.html M LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/css/support/parsing-testcommon.js Log Message: --- Update import of WPT css-animations parsing https://bugs.webkit.org/show_bug.cgi?id=246582 rdar://101210467 Reviewed by Antoine Quint. Reimport css/css-animations/parsing. * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-computed.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-invalid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-name-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-computed-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-computed.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-invalid-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-invalid.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-valid-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-timing-function-valid.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-invalid-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-invalid.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-valid-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/keyframes-name-valid.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/support/parsing-testcommon.js: (test_keyframes_name_valid): Canonical link: https://commits.webkit.org/255593@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2da880: WebXR should respond to changes in frame size
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2da8807b15a6fe8b49b1b83484daa350c532001e https://github.com/WebKit/WebKit/commit/2da8807b15a6fe8b49b1b83484daa350c532001e Author: Dean Jackson Date: 2022-10-14 (Fri, 14 Oct 2022) Changed paths: M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp Log Message: --- WebXR should respond to changes in frame size https://bugs.webkit.org/show_bug.cgi?id=246496 Reviewed by Antoine Quint. The size of the framebuffer provided by the compositor may change during the life of a session. Detect this and respond to it. * Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp: (WebCore::WebXROpaqueFramebuffer::startFrame): Look at the size of the incoming frame. If it has changed, re-run the setupFramebuffer logic. (WebCore::WebXROpaqueFramebuffer::setupFramebuffer): Make sure we delete existing WebGL objects if we create new ones. Canonical link: https://commits.webkit.org/255543@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 76aa13: Implement CSSTransformValue.toMatrix
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 76aa139eb22f8a04743020ab3a5f66ca1045b30a https://github.com/WebKit/WebKit/commit/76aa139eb22f8a04743020ab3a5f66ca1045b30a Author: Dean Jackson Date: 2022-10-07 (Fri, 07 Oct 2022) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformValue-toMatrix-expected.txt M Source/WebCore/css/typedom/transform/CSSTransformValue.cpp Log Message: --- Implement CSSTransformValue.toMatrix https://bugs.webkit.org/show_bug.cgi?id=246173 rdar://100868409 Reviewed by Antoine Quint. Implement the toMatrix method of CSSTransformValue. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformValue-toMatrix-expected.txt: * Source/WebCore/css/typedom/transform/CSSTransformValue.cpp: (WebCore::CSSTransformValue::toMatrix): Canonical link: https://commits.webkit.org/255299@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b85011: CSSTransformComponent.toMatrix should flatten to 2...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b85011927483d8cab677b6312f4889ebb7ed0f2f https://github.com/WebKit/WebKit/commit/b85011927483d8cab677b6312f4889ebb7ed0f2f Author: Dean Jackson Date: 2022-10-07 (Fri, 07 Oct 2022) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-2d-flattening-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-2d-flattening.html M Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp M Source/WebCore/css/typedom/transform/CSSRotate.cpp M Source/WebCore/css/typedom/transform/CSSScale.cpp M Source/WebCore/css/typedom/transform/CSSTranslate.cpp Log Message: --- CSSTransformComponent.toMatrix should flatten to 2d if necessary https://bugs.webkit.org/show_bug.cgi?id=246172 rdar://100868158 Reviewed by Antoine Quint. CSSTransformComponent classes should provide a 2d matrix in toMatrix() if their is2d value is true, regardless of what actual value they have. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-2d-flattening-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssTransformComponent-2d-flattening.html: Added. * Source/WebCore/css/typedom/transform/CSSMatrixComponent.cpp: Return a 2d variant of the 3d transform. (WebCore::CSSMatrixComponent::toMatrix): * Source/WebCore/css/typedom/transform/CSSRotate.cpp: Ditto. (WebCore::CSSRotate::toMatrix): * Source/WebCore/css/typedom/transform/CSSScale.cpp: Ditto. (WebCore::CSSScale::toMatrix): * Source/WebCore/css/typedom/transform/CSSTranslate.cpp: Ditto. (WebCore::CSSTranslate::toMatrix): Canonical link: https://commits.webkit.org/255290@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d3be2f: Disable ModelDocument everywhere
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3be2f06a2a29748a4dd3021e92834753ae94f7b https://github.com/WebKit/WebKit/commit/d3be2f06a2a29748a4dd3021e92834753ae94f7b Author: Dean Jackson Date: 2022-10-06 (Thu, 06 Oct 2022) Changed paths: M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Log Message: --- Disable ModelDocument everywhere https://bugs.webkit.org/show_bug.cgi?id=246130 Reviewed by Tim Horton. ModelDocument should not be enabled anywhere. It's currently gated on ENABLE(SEPARATED_MODEL) but that's wrong. * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: Canonical link: https://commits.webkit.org/255235@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
