[webkit-changes] [WebKit/WebKit] 00d8e8: Remove dispatch_async now that APS is working
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 00d8e875174dae409eb44ff6046eade899789649 https://github.com/WebKit/WebKit/commit/00d8e875174dae409eb44ff6046eade899789649 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-06-15 (Thu, 15 Jun 2023) Changed paths: M Source/WebKit/webpushd/ApplePushServiceConnection.mm Log Message: --- Remove dispatch_async now that APS is working https://bugs.webkit.org/show_bug.cgi?id=251806 Reviewed by Ben Nham. Now that APS is working again, the dispatch_async can be removed. * Source/WebKit/webpushd/ApplePushServiceConnection.mm: (didReceiveIncomingMessage): Remove dispatch_async now that APS is working as of macOS Ventura. Canonical link: https://commits.webkit.org/265201@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 461e6c: [WebCore]:Assign the scalar by default to avoid po...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 461e6c05f16d62178184cb0fd4070aa5148c6465 https://github.com/WebKit/WebKit/commit/461e6c05f16d62178184cb0fd4070aa5148c6465 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-05-28 (Sun, 28 May 2023) Changed paths: M Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp Log Message: --- [WebCore]:Assign the scalar by default to avoid potential function calls https://bugs.webkit.org/show_bug.cgi?id=257421 Reviewed by Tim Nguyen. We can avoid calls to functions like targetX and targetY if we assign the scalar first and then do checking of attributes. * Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::attributeChanged): Fixed space typo. (WebCore::SVGFEConvolveMatrixElement::createFilterEffect const): Refactored. Canonical link: https://commits.webkit.org/264641@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 81d93d: Set numBoundArgs after setting boundArgs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81d93da03d83c8e0e7d641030972ee2cf7c3c798 https://github.com/WebKit/WebKit/commit/81d93da03d83c8e0e7d641030972ee2cf7c3c798 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-05-16 (Tue, 16 May 2023) Changed paths: M Source/JavaScriptCore/runtime/FunctionPrototype.cpp Log Message: --- Set numBoundArgs after setting boundArgs https://bugs.webkit.org/show_bug.cgi?id=255540 Reviewed by Yusuke Suzuki. numBoundArgs is always zero because it is never changed after being set to zero. It is clear from the code itself that the number of arguments is meant to be set, but whoever programmed this part forgot to do so. * Source/JavaScriptCore/runtime/FunctionPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Assign numBoundArgs to the size of the boundArgs array. Canonical link: https://commits.webkit.org/264109@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a83ee5: WTF: Fix unsigned overflows/underflows in string c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a83ee572364b9ae35c05e5eb6a36d502515d5c22 https://github.com/WebKit/WebKit/commit/a83ee572364b9ae35c05e5eb6a36d502515d5c22 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-05-09 (Tue, 09 May 2023) Changed paths: M Source/WTF/wtf/text/IntegerToStringConversion.h Log Message: --- WTF: Fix unsigned overflows/underflows in string conversion https://bugs.webkit.org/show_bug.cgi?id=256164 Reviewed by David Kilzer. Although we check that integer is less than 0 before negating it, the UBSanitizer keeps tripping up at this section. The proper fix would be to use std::make_unsigned_t here, to convert the variable to its unsigned equivalent. * Source/WTF/wtf/text/IntegerToStringConversion.h: (writeIntegerToBuffer): Cast to unsigned. Canonical link: https://commits.webkit.org/263866@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1fb674: RemoteInspectorMessageParser: Checking if vector i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fb67415dc152397ed426ecc1acc5c7e6fcb663e https://github.com/WebKit/WebKit/commit/1fb67415dc152397ed426ecc1acc5c7e6fcb663e Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-04-19 (Wed, 19 Apr 2023) Changed paths: M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorMessageParser.cpp Log Message: --- RemoteInspectorMessageParser: Checking if vector is empty is redundant https://bugs.webkit.org/show_bug.cgi?id=255532 Reviewed by Fujii Hironori. Because we only operate on it if the size of the array is more than a uint32_t, checking if it is empty is redundant. * Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorMessageParser.cpp: (Inspector::MessageParser::parse): Canonical link: https://commits.webkit.org/263141@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c8ed9: Assign to self before returning in init methods
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c8ed9ea14550faa4067caf7e5985a71ee569760 https://github.com/WebKit/WebKit/commit/4c8ed9ea14550faa4067caf7e5985a71ee569760 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-04-14 (Fri, 14 Apr 2023) Changed paths: M Source/WebCore/PAL/pal/system/mac/WebPanel.mm M Source/WebKit/Shared/Cocoa/WKNSDictionary.mm M Source/WebKit/UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm M Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm M Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm M Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm M Source/WebKit/UIProcess/ios/forms/WKFormSelectControl.mm M Source/WebKit/UIProcess/ios/forms/WKSelectMenuListViewController.mm M Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm M Source/WebKitLegacy/mac/Misc/WebDownload.mm M Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm M Source/WebKitLegacy/mac/WebView/WebResource.mm M Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm M Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm M Tools/WebKitTestRunner/mac/WebKitTestRunnerWindow.mm Log Message: --- Assign to self before returning in init methods https://bugs.webkit.org/show_bug.cgi?id=255341 Reviewed by Alexey Proskuryakov. ARC requires this and this is good practice anyway, even if these files are not being compiled with ARC. Yes, there were some exceptions simply because reordering statements in legacy code is too risky/not worth the effort. * Source/WebCore/PAL/pal/system/mac/WebPanel.mm: (-[WebPanel init]): * Source/WebKit/Shared/Cocoa/WKNSDictionary.mm: (-[WKNSDictionary initWithObjects:forKeys:count:]): * Source/WebKit/UIProcess/Cocoa/WKReloadFrameErrorRecoveryAttempter.mm: (-[WKReloadFrameErrorRecoveryAttempter initWithCoder:]): * Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm: (-[WKDatePickerViewController initWithDelegate:]): * Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm: (-[WKDateTimeInputControl initWithView:]): * Source/WebKit/UIProcess/ios/forms/WKFormColorControl.mm: (-[WKFormColorControl initWithView:]): * Source/WebKit/UIProcess/ios/forms/WKFormSelectControl.mm: (-[WKFormSelectControl initWithView:]): * Source/WebKit/UIProcess/ios/forms/WKSelectMenuListViewController.mm: (-[WKSelectMenuListViewController initWithDelegate:]): * Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm: (-[WKTimePickerViewController initWithDelegate:]): * Source/WebKitLegacy/mac/Misc/WebDownload.mm: (-[WebDownload init:]): * Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): * Source/WebKitLegacy/mac/WebView/WebResource.mm: (-[WebResourcePrivate init]): * Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: (-[DumpRenderTreeDraggingInfo initWithImage:offset:pasteboard:source:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm: (-[MockContentFilterEnabler initWithCoder:]): * Tools/TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: (-[MockDropSession initWithProviders:location:window:allowMove:]): (-[MockDragSession initWithWindow:allowMove:]): * Tools/WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]): Canonical link: https://commits.webkit.org/262971@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d1b097: WebCore: Replace stringWithFormat call with literals
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1b09796df9e520b27a8f2016df9f132ee23b614 https://github.com/WebKit/WebKit/commit/d1b09796df9e520b27a8f2016df9f132ee23b614 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-04-13 (Thu, 13 Apr 2023) Changed paths: M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm Log Message: --- WebCore: Replace stringWithFormat call with literals https://bugs.webkit.org/show_bug.cgi?id=255153 Reviewed by Alexey Proskuryakov. There is no reason to have a stringWithFormat call when the the supplied number is a literal. * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (appendStringToResult): Prefer literals over NSStringWithFormat. Canonical link: https://commits.webkit.org/262937@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e43254: Remove Legacy Dashboard Support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4325475d7d8b7fb7180384c6c288bfaac432b42 https://github.com/WebKit/WebKit/commit/e4325475d7d8b7fb7180384c6c288bfaac432b42 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-04-10 (Mon, 10 Apr 2023) Changed paths: M Source/WebCore/platform/mac/PasteboardMac.mm M Source/WebKit/Configurations/WebKit.xcconfig M Source/WebKit/MigratedHeaders-input.xcfilelist M Source/WebKit/MigratedHeaders-output.xcfilelist M Source/WebKit/Modules/OSX_Private.modulemap M Source/WebKitLegacy/PlatformMac.cmake M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig M Source/WebKitLegacy/mac/WebKit.order R Source/WebKitLegacy/mac/WebView/WebDashboardRegion.h R Source/WebKitLegacy/mac/WebView/WebDashboardRegion.mm M Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h M Source/WebKitLegacy/mac/WebView/WebView.mm M Source/WebKitLegacy/mac/WebView/WebViewData.h M Source/WebKitLegacy/mac/WebView/WebViewPrivate.h Log Message: --- Remove Legacy Dashboard Support https://bugs.webkit.org/show_bug.cgi?id=255204 Reviewed by Alexey Proskuryakov. The Legacy Dashboard itself has not been used for many years. We can remove it without issue now, especially since nothing is dependent on the files themselves anymore. * Source/WebCore/platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::setDragImage): * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/MigratedHeaders-input.xcfilelist: * Source/WebKit/MigratedHeaders-output.xcfilelist: * Source/WebKit/Modules/OSX_Private.modulemap: * Source/WebKitLegacy/PlatformMac.cmake: * Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj: * Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig: * Source/WebKitLegacy/mac/WebKit.order: * Source/WebKitLegacy/mac/WebView/WebDashboardRegion.h: Removed. * Source/WebKitLegacy/mac/WebView/WebDashboardRegion.mm: Removed. * Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h: * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView _addScrollerDashboardRegions:]): Deleted. (-[WebView _dashboardRegions]): Deleted. (-[WebView _setDashboardBehavior:to:]): Deleted. (-[WebView _dashboardBehavior:]): Deleted. * Source/WebKitLegacy/mac/WebView/WebViewData.h: * Source/WebKitLegacy/mac/WebView/WebViewPrivate.h: Canonical link: https://commits.webkit.org/262798@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7780fe: Prefer std::copy_n over std::copy
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7780feb6148591a05d6f4164ec6763dc545b279b https://github.com/WebKit/WebKit/commit/7780feb6148591a05d6f4164ec6763dc545b279b Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-04-01 (Sat, 01 Apr 2023) Changed paths: M Source/JavaScriptCore/jsc.cpp M Source/JavaScriptCore/runtime/JSBigInt.cpp M Source/JavaScriptCore/wasm/WasmParser.h M Source/WTF/wtf/Vector.h M Source/WebCore/platform/KeyedCoding.h Log Message: --- Prefer std::copy_n over std::copy https://bugs.webkit.org/show_bug.cgi?id=254029 Reviewed by Geoffrey Garen. We do not have to do the manual addition this way. * Source/JavaScriptCore/jsc.cpp:(runWithOptions): Prefer std::copy_n over std::copy. * Source/JavaScriptCore/runtime/JSBigInt.cpp:(JSBigInt::rightTrim): Ditto. * Source/JavaScriptCore/wasm/WasmParser.h:(parseImmByteArray16): Ditto. * Source/WTF/wtf/Vector.h: Ditto. * Source/WebCore/platform/KeyedCoding.h:(decodeBytes): Ditto. Canonical link: https://commits.webkit.org/262478@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27185f: Remove _webkit_fixedCarbonPOSIXPath
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27185f9bee793bfd09452c651b83385d488c3dea https://github.com/WebKit/WebKit/commit/27185f9bee793bfd09452c651b83385d488c3dea Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm M Source/WebKitLegacy/mac/WebKit.order Log Message: --- Remove _webkit_fixedCarbonPOSIXPath https://bugs.webkit.org/show_bug.cgi?id=252818 Reviewed by Alexey Proskuryakov. Safari 8 is long gone and no longer supported. We can remove this function/method. Canonical link: https://commits.webkit.org/262457@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e5c038: Remove workarounds for Microsoft My Day, Messenger...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e5c038660e27bd020baf52f74a31b91dc467af5b https://github.com/WebKit/WebKit/commit/e5c038660e27bd020baf52f74a31b91dc467af5b Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-31 (Fri, 31 Mar 2023) Changed paths: M Source/WebCore/WebCore.order M Source/WebCore/platform/RuntimeApplicationChecks.h M Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj M Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig R Source/WebKitLegacy/mac/Misc/OutlookQuirksUserScript.js M Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Remove workarounds for Microsoft My Day, Messenger, and Outlook https://bugs.webkit.org/show_bug.cgi?id=252816 Reviewed by Brent Fulgham. Microsoft My Day no longer exists as of 2008, so we can remove the workarounds made for it. Same for Microsoft Messenger and Microsoft Outlook as of 2010. * Source/WebCore/WebCore.order: Removed mangled names of removed workarounds. * Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm: (isMicrosoftMessenger): Removed. (isMicrosoftMyDay): Removed. * Source/WebCore/platform/RuntimeApplicationChecks.h: (isMicrosoftMessenger): Removed. (isMicrosoftMyDay): Removed. * Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj: Remove references to OutlookQuirksUserScript.js. * Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig: Ditto. * Source/WebKitLegacy/mac/Misc/OutlookQuirksUserScript.js: Deleted. * Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_HTML5_PARSER. * Source/WebKitLegacy/mac/WebView/WebFrame.mm: (needsMicrosoftMessengerDOMDocumentWorkaround): Removed. * Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm: (defaultUsePreHTML5ParserQuirks): Remove calls to isMicrosoftMyDay. * Source/WebKitLegacy/mac/WebView/WebView.mm:(needsOutlookQuirksScript): Removed. (_commonInitializationWithFrameName): Removed call to needsOutlookQuirksScript. (createOutlookQuirksUserScriptContents): Removed (_injectOutlookQuirksScript): Removed. Canonical link: https://commits.webkit.org/262393@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9e90ce: Rewrite FIXME to note that only tvOS and watchOS f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e90ceb499eb09b79c6525161cfc1901b6390212 https://github.com/WebKit/WebKit/commit/9e90ceb499eb09b79c6525161cfc1901b6390212 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-30 (Thu, 30 Mar 2023) Changed paths: M Source/JavaScriptCore/API/tests/testapi.mm Log Message: --- Rewrite FIXME to note that only tvOS and watchOS fails to compile some API tests https://bugs.webkit.org/show_bug.cgi?id=251928 Reviewed by Jonathan Bedard. We no longer compile for iOS 12 or macOS 10.14, but this ifdef also meant that tvOS and watchOS did not have to run these tests, so I reworded the FIXME to make that more clear. *Source/JavaScriptCore/API/tests/testapi.mm:(testObjectiveCAPIMain): Change FIXME and preprocessor directive Canonical link: https://commits.webkit.org/262365@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e5fe6: [NFC] WebCore: Fix typos regarding "WebCore"
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e5fe65ea18a449ab703a10b16c55a635aabe36a https://github.com/WebKit/WebKit/commit/1e5fe65ea18a449ab703a10b16c55a635aabe36a Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-30 (Thu, 30 Mar 2023) Changed paths: M Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm M Source/WebCore/html/FormListedElement.cpp M Source/WebCore/html/HTMLFormControlElement.cpp M Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp M Source/WebCore/html/HTMLTextFormControlElement.cpp M Source/WebCore/html/ValidatedFormListedElement.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.h Log Message: --- [NFC] WebCore: Fix typos regarding "WebCore" https://bugs.webkit.org/show_bug.cgi?id=254764 Reviewed by Ryosuke Niwa. No behavioral changes, but fixing typos regarding "WebCore" * Source/WebCore/html/FormListedElement.cpp: * Source/WebCore/html/HTMLFormControlElement.cpp: * Source/WebCore/html/HTMLMaybeFormAssociatedCustomElement.cpp: * Source/WebCore/html/HTMLTextFormControlElement.cpp: * Source/WebCore/html/ValidatedFormListedElement.cpp: * Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm: * Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.h: Canonical link: https://commits.webkit.org/262364@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e399b: WKWebAuthenticationPanel: attributesArrayRef is no...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e399bd0c6f4aaf24907cf10a9067e0b7ea6c8fd https://github.com/WebKit/WebKit/commit/2e399bd0c6f4aaf24907cf10a9067e0b7ea6c8fd Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-29 (Wed, 29 Mar 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm Log Message: --- WKWebAuthenticationPanel: attributesArrayRef is not released https://bugs.webkit.org/show_bug.cgi?id=254667 Reviewed by Chris Dumez. Normally, the result of SecItemCopyMatching is assigned to a smart pointer, and/or released later in the code. However, there is one instance where that does not happen, and the value is simply bridged to an NSDictionary without any change in ownership. This results in said result being leaked in memory. * Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm: (exportLocalAuthenticatorCredentialWithGroupAndID): Assign attributesArrayRef to a smart pointer. Canonical link: https://commits.webkit.org/262299@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a6823: Have functions that only require VMs take a VM ref...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a682381645f03d8fc7f2fa58c134d45b5b59c2d https://github.com/WebKit/WebKit/commit/7a682381645f03d8fc7f2fa58c134d45b5b59c2d Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-27 (Mon, 27 Mar 2023) Changed paths: M Source/JavaScriptCore/runtime/JSONObject.cpp M Source/WebCore/Modules/encryptedmedia/MediaKeyStatusMap.cpp M Source/WebCore/bindings/js/JSDOMConvertEnumeration.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.h M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.h M Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestObj.h M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.h Log Message: --- Have functions that only require VMs take a VM reference https://bugs.webkit.org/show_bug.cgi?id=202392 Reviewed by Darin Adler. We can have the .vm() method be called before these functions, and pass the result VM reference instead of passing the pointer to the JSGlobalObject, potentially calling the .vm() methods redundantly in each method to which said JSGlobalObject pointer is passed, and dereferencing the pointers to the VM. * Source/JavaScriptCore/runtime/JSONObject.cpp:(value): Change argument type from JSGlobalObject* to VM&. * Source/WebCore/Modules/encryptedmedia/MediaKeyStatusMap.cpp: (get): Pass the VM of the state object to convertEnumerationToJS rather than the whole object. * Source/WebCore/bindings/js/JSDOMConvertEnumeration.h: (convertEnumerationToJS): Change argument type from JSGlobalObject to VM. (convert): Pass the VM of lexicalGlobalObject instead of the entire global object. * Source/WebCore/bindings/scripts/CodeGeneratorJS.pm: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.h: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.cpp: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONEnum.h: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestObj.h: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp: Ditto. * Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneEnumeration.h: Ditto. Canonical link: https://commits.webkit.org/262166@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f953a3: JavaScriptCore: m_linkBuffer should be initialized...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f953a3491357343e2784b672e31b779d15ca3be8 https://github.com/WebKit/WebKit/commit/f953a3491357343e2784b672e31b779d15ca3be8 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-24 (Fri, 24 Mar 2023) Changed paths: M Source/JavaScriptCore/jit/JIT.cpp Log Message: --- JavaScriptCore: m_linkBuffer should be initialized via WTF::makeUnique https://bugs.webkit.org/show_bug.cgi?id=253156 Reviewed by Chris Dumez. m_linkBuffer can be fast-allocated, so let's do this via WTF::makeUnique. * Source/JavaScriptCore/jit/JIT.cpp:(JIT::compileAndLinkWithoutFinalizing): Use WTF::MakeUnique to initialize m_linkBuffer. Canonical link: https://commits.webkit.org/262084@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0b222: WebCore: Prefer mutableCopy over mutableCopyWithZone
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0b2221b92ed2006b6216173610b438198f5a620 https://github.com/WebKit/WebKit/commit/c0b2221b92ed2006b6216173610b438198f5a620 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-24 (Fri, 24 Mar 2023) Changed paths: M Source/WebCore/platform/mac/WebNSAttributedStringExtras.mm M Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm Log Message: --- WebCore: Prefer mutableCopy over mutableCopyWithZone https://bugs.webkit.org/show_bug.cgi?id=253825 Reviewed by Chris Dumez. The mutableCopyWithZone method is not overridden, nor is the zone parameter even acknowledged anymore by the Objective-C runtime. We should replace calls to mutableCopyWithZone with calls to mutableCopy. * Source/WebCore/platform/mac/WebNSAttributedStringExtras.mm: (attributedStringByStrippingAttachmentCharacters): Replace mutableCopyWithZone with mutableCopy. * Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm: (initWithSession): Ditto. Canonical link: https://commits.webkit.org/262083@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b6a50d: WTF: Use __bridge_retained to help the compiler ke...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6a50d258a8e656e38e2d0b92b8cfa96eb3bc692 https://github.com/WebKit/WebKit/commit/b6a50d258a8e656e38e2d0b92b8cfa96eb3bc692 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-20 (Mon, 20 Mar 2023) Changed paths: M Source/WTF/wtf/RetainPtr.h M Source/WTF/wtf/cocoa/TypeCastsCocoa.h Log Message: --- WTF: Use __bridge_retained to help the compiler keep track of CF objects https://bugs.webkit.org/show_bug.cgi?id=253820 Reviewed by Darin Adler. As we use __bridged_release when converting to NS Objects, it makes sense to do the inverse when converting to CF Objects. * Source/WTF/wtf/RetainPtr.h: Statically assert that adoptNS is only used for NS objects. * Source/WTF/wtf/cocoa/TypeCastsCocoa.h: Use __bridge_retained to convert NS objects to CF objects. Canonical link: https://commits.webkit.org/261860@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 82bd76: Scripts: Use webbrowser package in Python to open ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 82bd766bd89d5a7865183ae72be484db7e27126f https://github.com/WebKit/WebKit/commit/82bd766bd89d5a7865183ae72be484db7e27126f Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-15 (Wed, 15 Mar 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py M Tools/Scripts/webkitpy/common/system/user.py Log Message: --- Scripts: Use webbrowser package in Python to open a URL in a web browser https://bugs.webkit.org/show_bug.cgi?id=253515 Reviewed by Jonathan Bedard. I made a mistake. Because "start" worked on the command line, I assumed that it would work under the Terminal.run() command. Now I realize this is not what actually happens. Instead of reverting that commit, commit https://commits.webkit.org/261332@main, I am instead introducing a proper fix, which is using the URL and opening it in a browser via the webbrowser package. * Tools\Scripts\libraries\webkitcorepy\webkitcorepy\terminal.py: Change 'start' back to 'explorer.' Teach open_url to call the webbrowser url method to open webpages if the scheme is http or https. * Tools\Scripts\webkitpy\common\system\user.py: Inline redundant method. Canonical link: https://commits.webkit.org/261687@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5b1535: WebScriptObject: Refactor getListFromNSArray to us...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5b1535c14751afb8aa1f3f9401639c407e1585ce https://github.com/WebKit/WebKit/commit/5b1535c14751afb8aa1f3f9401639c407e1585ce Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-13 (Mon, 13 Mar 2023) Changed paths: M Source/WebCore/bridge/objc/WebScriptObject.mm Log Message: --- WebScriptObject: Refactor getListFromNSArray to use a for-in loop https://bugs.webkit.org/show_bug.cgi?id=253823 Reviewed by Alexey Proskuryakov. This makes the code cleaner and more terse. * Source\WebCore\bridge\objc\WebScriptObject.mm:(getListFromNSArray): Prefer for-in loop over regular for loop for iteration of an NSArray. Canonical link: https://commits.webkit.org/261607@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18dbbe: Hooks: Fix typo in pre-push script
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18dbbee3f2c795f53639d1d776916df0f4c91430 https://github.com/WebKit/WebKit/commit/18dbbee3f2c795f53639d1d776916df0f4c91430 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-13 (Mon, 13 Mar 2023) Changed paths: M Tools/Scripts/hooks/pre-push Log Message: --- Hooks: Fix typo in pre-push script https://bugs.webkit.org/show_bug.cgi?id=253822 Reviewed by Alexey Proskuryakov. The correct phrasing is "no classification," not "not classification." * Tools\Scripts\hooks\pre-push:(main): Fix "not" typo. Canonical link: https://commits.webkit.org/261606@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da9344: Prefer std::abs over fabs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da934454c84ac2dcbf9fca9e5f4ac2644ef25d72 https://github.com/WebKit/WebKit/commit/da934454c84ac2dcbf9fca9e5f4ac2644ef25d72 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-13 (Mon, 13 Mar 2023) Changed paths: M Source/JavaScriptCore/assembler/MacroAssembler.h M Source/JavaScriptCore/b3/B3ConstDoubleValue.cpp M Source/JavaScriptCore/b3/B3ConstFloatValue.cpp M Source/JavaScriptCore/b3/testb3_3.cpp M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGOperations.cpp M Source/JavaScriptCore/jit/AssemblyHelpersSpoolers.h M Source/JavaScriptCore/runtime/DateConversion.cpp M Source/JavaScriptCore/runtime/ISO8601.cpp M Source/JavaScriptCore/runtime/MathCommon.cpp M Source/JavaScriptCore/runtime/MathObject.cpp M Source/JavaScriptCore/runtime/NumberPrototype.cpp M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp M Source/WTF/wtf/CurrentTime.cpp M Source/WTF/wtf/DateMath.cpp M Source/WTF/wtf/MediaTime.cpp M Source/WTF/wtf/text/TextStream.cpp M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp M Source/WebCore/Modules/webaudio/AudioParam.cpp M Source/WebCore/Modules/webaudio/AudioParamTimeline.cpp M Source/WebCore/Modules/webaudio/IIRFilterNode.cpp M Source/WebCore/Modules/webaudio/OscillatorNode.cpp M Source/WebCore/Modules/webaudio/PeriodicWave.cpp M Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/bindings/js/JSDOMConvertNumbers.cpp M Source/WebCore/contentextensions/DFABytecodeCompiler.cpp M Source/WebCore/display/css/DisplayBoxDecorationPainter.cpp M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/editing/cocoa/HTMLConverter.mm M Source/WebCore/html/CustomPaintImage.cpp M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/inspector/InspectorOverlay.cpp M Source/WebCore/layout/Verification.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/Frame.cpp M Source/WebCore/page/WheelEventDeltaFilter.cpp M Source/WebCore/page/ios/FrameIOS.mm M Source/WebCore/platform/LayoutUnit.h M Source/WebCore/platform/LocalizedStrings.cpp M Source/WebCore/platform/ScrollAnimationKeyboard.cpp M Source/WebCore/platform/ScrollAnimationKinetic.cpp M Source/WebCore/platform/ScrollView.cpp M Source/WebCore/platform/audio/Biquad.cpp M Source/WebCore/platform/audio/Cone.cpp M Source/WebCore/platform/audio/DenormalDisabler.h M Source/WebCore/platform/audio/FFTFrame.cpp M Source/WebCore/platform/audio/HRTFPanner.cpp M Source/WebCore/platform/audio/IIRFilter.cpp M Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm M Source/WebCore/platform/graphics/FloatLine.cpp M Source/WebCore/platform/graphics/FloatSize.cpp M Source/WebCore/platform/graphics/GradientImage.cpp M Source/WebCore/platform/graphics/IntSize.h M Source/WebCore/platform/graphics/PathUtilities.cpp M Source/WebCore/platform/graphics/ShadowBlur.cpp M Source/WebCore/platform/graphics/UnitBezier.h M Source/WebCore/platform/graphics/cairo/CairoOperations.cpp M Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp M Source/WebCore/platform/graphics/transforms/AffineTransform.cpp M Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp M Source/WebCore/platform/graphics/win/FontCacheWin.cpp M Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp M Source/WebCore/platform/graphics/win/SystemFontDatabaseWin.cpp M Source/WebCore/platform/ios/ScrollAnimatorIOS.mm M Source/WebCore/platform/ios/WebAVPlayerController.mm M Source/WebCore/platform/ios/wak/WKView.mm M Source/WebCore/platform/mac/ScrollAnimationRubberBand.mm M Source/WebCore/platform/mac/ScrollingEffectsController.mm M Source/WebCore/platform/win/BitmapInfo.h M Source/WebCore/platform/win/PopupMenuWin.cpp M Source/WebCore/platform/xr/openxr/OpenXRUtils.h M Source/WebCore/rendering/AttachmentLayout.mm M Source/WebCore/rendering/BorderPainter.cpp M Source/WebCore/rendering/RenderLayerScrollableArea.cpp M Source/WebCore/rendering/RenderListBox.cpp M Source/WebCore/rendering/RenderMarquee.cpp M Source/WebCore/rendering/shapes/RasterShape.cpp M Source/WebCore/rendering/svg/SVGMarkerData.h M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp M Source/WebCore/style/StyleBuilderConverter.h M Source/WebCore/style/StyleFontSizeFunctions.cpp M Source/WebCore/svg/SVGPathParser.cpp M Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.h M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm M Source/WebKit/UIProcess/gtk/KeyBindingTranslator.cpp
[webkit-changes] [WebKit/WebKit] 3b16fd: Scripts: Run the start command to open a URL in a ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b16fd1ed5236037b5fea73f819a33adec1399ec https://github.com/WebKit/WebKit/commit/3b16fd1ed5236037b5fea73f819a33adec1399ec Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-07 (Tue, 07 Mar 2023) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py Log Message: --- Scripts: Run the start command to open a URL in a browser on Windows https://bugs.webkit.org/show_bug.cgi?id=253515 Reviewed by Jonathan Bedard. On Windows, running explorer https://www.github.com opens a File Explorer window, not a web browser window. The start command on the other hand opens the URL in the correct browser, so let's use that instead. * Tools\Scripts\libraries\webkitcorepy\webkitcorepy\terminal.py: Run 'start' command instead of 'explorer' Canonical link: https://commits.webkit.org/261332@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cb1f64: Replace checks for ending slash in file paths with...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cb1f64337310fec41266ad91ef5600b6a45808c5 https://github.com/WebKit/WebKit/commit/cb1f64337310fec41266ad91ef5600b6a45808c5 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-05 (Sun, 05 Mar 2023) Changed paths: M Source/WTF/wtf/cocoa/FileSystemCocoa.mm M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm Log Message: --- Replace checks for ending slash in file paths with runtime assertions https://bugs.webkit.org/show_bug.cgi?id=253253 Reviewed by Alexey Proskuryakov. This issue has been long fixed on iOS Simulator. Therefore, this check is safe to turn into a runtime assertion. * Source/WTF/wtf/cocoa/FileSystemCocoa.mm:(openTemporaryFile): Change temporaryFilePath.last() check to a runtime assertion. * Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:(createHandleForTemporaryFile): Ditto. Canonical link: https://commits.webkit.org/261246@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87a1ee: Remove needsInputModeNoneImplicitly
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 87a1ee7dd4f2231b246ea65f1ef7ac0b8ac0d06a https://github.com/WebKit/WebKit/commit/87a1ee7dd4f2231b246ea65f1ef7ac0b8ac0d06a Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-03 (Fri, 03 Mar 2023) Changed paths: M Source/WebCore/html/HTMLElement.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Remove needsInputModeNoneImplicitly https://bugs.webkit.org/show_bug.cgi?id=252819 Reviewed by Ryosuke Niwa. After checking desmos.com and viewing its source, I can confirm the site now adopts inputmode="none", so we can remove this quirk. *Source\WebCore\html\HTMLElement.cpp: Remove needsInputModeNoneImplicitly check *Source\WebCore\page\Quirks.cpp: Remove needsInputModeNoneImplicitly *Source\WebCore\page\Quirks.h: Remove needsInputModeNoneImplicitly Canonical link: https://commits.webkit.org/261175@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8292d2: WebGPU-Vulkan: Reserve vector space where possible
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8292d20a046a37b9c6be992bbf53a144a183f0ff https://github.com/WebKit/WebKit/commit/8292d20a046a37b9c6be992bbf53a144a183f0ff Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-02 (Thu, 02 Mar 2023) Changed paths: M Tools/WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.cpp Log Message: --- WebGPU-Vulkan: Reserve vector space where possible https://bugs.webkit.org/show_bug.cgi?id=253155 Reviewed by Michael Catanzaro. It is good practice to reserve space in vectors before pushing back new elements with each iteration, as it saves the work of reallocating space between each push_back or emplace_back. * Tools\WebGPUAPIStructure\WebGPU-Vulkan\QueueImpl.cpp:(createRenderPass): Reserve space for vectors Canonical link: https://commits.webkit.org/261092@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3f8639: Do not CFRelease a CFSTR constant.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3f8639874e31f01d2d8ad8221f0b6803e5e2162d https://github.com/WebKit/WebKit/commit/3f8639874e31f01d2d8ad8221f0b6803e5e2162d Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-03-01 (Wed, 01 Mar 2023) Changed paths: M Source/JavaScriptCore/API/tests/testapi.c Log Message: --- Do not CFRelease a CFSTR constant. https://bugs.webkit.org/show_bug.cgi?id=253160 Reviewed by Elliott Williams. There is no need to CFRelease a CFSTR-created string. This is a constant and CFRelease has no effect. * Source\JavaScriptCore\API\tests\testapi.c: Remove CFRelease call Canonical link: https://commits.webkit.org/261024@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d13961: Remove old GCC workarounds
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d139619c4a1e761411647d6c27b646e81c80c1b7 https://github.com/WebKit/WebKit/commit/d139619c4a1e761411647d6c27b646e81c80c1b7 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-27 (Mon, 27 Feb 2023) Changed paths: M Source/JavaScriptCore/bytecode/InlineAccess.h M Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp M Source/WebCore/bridge/objc/WebScriptObject.mm M Source/WebCore/bridge/objc/objc_instance.mm M Source/WebCore/bridge/objc/objc_runtime.mm Log Message: --- Remove old GCC workarounds https://bugs.webkit.org/show_bug.cgi?id=252898 Reviewed by Michael Catanzaro. GCC is not used to compile Objective-C anymore, and GCC now supports std::max() inside a constexpr function. Source/JavaScriptCore/bytecode/InlineAccess.h: Make sizeForLengthAccess constexpr Source/WebCore/PAL/pal/text/TextCodecSingleByte.cpp: Make size constexpr Source/WebCore/bridge/objc/WebScriptObject.mm:(getListFromNSArray:) Remove gcc 3.3 workaround Source/WebCore/bridge/objc/objc_instance.mm: Remove const workarounds Source/WebCore/bridge/objc/objc_runtime.mm: Remove const workaround Canonical link: https://commits.webkit.org/260883@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4660c2: Remove _inspectorDelegate methods
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4660c27d821bd675b38c067ce0c43d66ab346f36 https://github.com/WebKit/WebKit/commit/4660c27d821bd675b38c067ce0c43d66ab346f36 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-25 (Sat, 25 Feb 2023) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm Log Message: --- Remove _inspectorDelegate methods https://bugs.webkit.org/show_bug.cgi?id=252823 Reviewed by Alex Christensen. We are now on Safari 16, which is after Safari 14. Hence, we can remove the methods removed herein. *Source\WebKit\UIProcess\API\Cocoa\WKWebView.mm: Canonical link: https://commits.webkit.org/260833@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85c350: Remove WebKitSetIsClassic check
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85c350cb0b0b9e0f1e8c762caa208a8904273536 https://github.com/WebKit/WebKit/commit/85c350cb0b0b9e0f1e8c762caa208a8904273536 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-25 (Sat, 25 Feb 2023) Changed paths: M Source/WebKitLegacy/ios/Misc/WebUIKitSupport.h M Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm M Source/WebKitLegacy/ios/WebKit.iOS.exp Log Message: --- Remove WebKitSetIsClassic check https://bugs.webkit.org/show_bug.cgi?id=252822 Reviewed by Alex Christensen. This function is no longer being called, so we can remove it. *Source\WebKitLegacy\ios\Misc\WebUIKitSupport.h: *Source\WebKitLegacy\ios\Misc\WebUIKitSupport.mm: *Source\WebKitLegacy\ios\WebKit.iOS.exp: Canonical link: https://commits.webkit.org/260832@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6aa0ef: Remove old and deprecated UIProcess functions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6aa0efabfa86bed906c718e69d96005316035e79 https://github.com/WebKit/WebKit/commit/6aa0efabfa86bed906c718e69d96005316035e79 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-25 (Sat, 25 Feb 2023) Changed paths: M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/C/WKPage.h M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/API/C/WKPreferencesRef.h M Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h M Source/WebKit/mac/WebKit2.order M Source/WebKitLegacy/mac/WebKit.order M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h M Tools/WebKitTestRunner/TestController.cpp Log Message: --- Remove old and deprecated UIProcess functions https://bugs.webkit.org/show_bug.cgi?id=251879 Reviewed by Alex Christensen. The code in question is literally code that was commented to be removed under certain conditions that have been met years ago, such as no longer compiling for Safari 8 and when Mavericks support is gone. This is very very old code that is the removal of which is obvious but has yet to be done. Canonical link: https://commits.webkit.org/260831@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 454308: Avoid unnecessary alloc/init when using dictionary...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4543085706efe7dfb684593f6b4e87410cefa34d https://github.com/WebKit/WebKit/commit/4543085706efe7dfb684593f6b4e87410cefa34d Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-23 (Thu, 23 Feb 2023) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm Log Message: --- Avoid unnecessary alloc/init when using dictionary literals https://bugs.webkit.org/show_bug.cgi?id=252813 Reviewed by Timothy Hatcher. The compiler initializes an NSDictionary when the @ syntax is used. If an underlying error happens, alloc/init is called again. Let's avoid that. *Source\WebKit\UIProcess\Extensions\Cocoa\WebExtensionCocoa.mm: Canonical link: https://commits.webkit.org/260782@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c0551: Replace deprecated isModalInPopover with replaceme...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c0551e351a97d2110f8f69d17a7510e4a29519e https://github.com/WebKit/WebKit/commit/9c0551e351a97d2110f8f69d17a7510e4a29519e Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-21 (Tue, 21 Feb 2023) Changed paths: M Source/WebKit/UIProcess/ios/WKActionSheet.mm Log Message: --- Replace deprecated isModalInPopover with replacement isModalInPresentation https://bugs.webkit.org/show_bug.cgi?id=252500 Reviewed by Megan Gardner. *Source\WebKit\UIProcess\ios\WKActionSheet.mm: Canonical link: https://commits.webkit.org/260631@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b1aa5: Remove unused mutableOptions variable
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b1aa5aeec5d7905aa0c6856abfaa11ca8588d65 https://github.com/WebKit/WebKit/commit/9b1aa5aeec5d7905aa0c6856abfaa11ca8588d65 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-20 (Mon, 20 Feb 2023) Changed paths: M Source/WebCore/editing/cocoa/DictionaryLookup.mm Log Message: --- Remove unused mutableOptions variable https://bugs.webkit.org/show_bug.cgi?id=252576 Reviewed by Wenson Hsieh and Megan Gardner. This variable is not used, and clang cannot tell due to all the fancy smart pointer and function calls going around it, so this variable should be removed. This variable has not had any use even within the last 9 years anyway. *Source\WebCore\editing\cocoa\DictionaryLookup.mm Canonical link: https://commits.webkit.org/260570@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 99f4e3: Remove Preprocessor Checks for Clang Prior to Vers...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99f4e3022fb8676139a5d58950f131dad0e2cbc0 https://github.com/WebKit/WebKit/commit/99f4e3022fb8676139a5d58950f131dad0e2cbc0 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M Source/WTF/wtf/Int128.cpp Log Message: --- Remove Preprocessor Checks for Clang Prior to Version 9 https://bugs.webkit.org/show_bug.cgi?id=252351 Reviewed by Michael Catanzaro. Given how clang has had its respective bugs resolved and fixed, we do not need these workarounds anymore. *Source\WTF\wtf\Int128.cpp: Remove clang + SSE3 workaround Canonical link: https://commits.webkit.org/260339@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 570db2: Fix Usage of IOObjects on Mac
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 570db2bde74d80b5aba9333e2fff3c835dedd80f https://github.com/WebKit/WebKit/commit/570db2bde74d80b5aba9333e2fff3c835dedd80f Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-13 (Mon, 13 Feb 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/platform/graphics/mac/GraphicsChecksMac.cpp M Tools/DumpRenderTree/mac/LayoutTestHelper.m Log Message: --- Fix Usage of IOObjects on Mac https://bugs.webkit.org/show_bug.cgi?id=251859 Reviewed by Brent Fulgham. IOMasterPort is deprecated, but still used up until Big Sur, so let's add a check for IOMainPort and then use it if the OS has it. Additionally, there is an unnecessary retain + release before IOServiceOpen, so let's remove that. *Source/WTF/wtf/PlatformHave.h: Add check for IOMainPort *Source/WebCore/platform/graphics/mac/GraphicsChecksMac.cpp: Rename masterPort to mainPort and remove pointless initialization. Also remove unneeded IOObjectRetain and IOObjectRelease calls in the same exact codepath. Replace calls from IOMasterPort to IOMainPort *Tools/DumpRenderTree/mac/LayoutTestHelper.m: Rename masterPort to mainPort. Replace calls from IOMasterPort to IOMainPort Canonical link: https://commits.webkit.org/260226@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da5fe9: Revert cc446ab5303d8f063c90ae113683f55b7f6883a8
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da5fe94f0691572d7a9829de09d232faa2965d8f https://github.com/WebKit/WebKit/commit/da5fe94f0691572d7a9829de09d232faa2965d8f Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-10 (Fri, 10 Feb 2023) Changed paths: M Source/WebKit/UIProcess/Cocoa/NavigationState.mm Log Message: --- Revert cc446ab5303d8f063c90ae113683f55b7f6883a8 https://bugs.webkit.org/show_bug.cgi?id=247995 rdar://102339404 Reviewed by Chris Dumez. Since the release of Safari 16.3 in January, we can now revert the aforementioned commit, as per the FIXME comment. * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction): Canonical link: https://commits.webkit.org/260118@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 115f23: JSStringCreateWithCFString can now use CFIndex
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 115f2370e6f35139cb1672d1b4cc89fd0d3d0121 https://github.com/WebKit/WebKit/commit/115f2370e6f35139cb1672d1b4cc89fd0d3d0121 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-09 (Thu, 09 Feb 2023) Changed paths: M Source/JavaScriptCore/API/JSStringRefCF.cpp Log Message: --- JSStringCreateWithCFString can now use CFIndex https://bugs.webkit.org/show_bug.cgi?id=251619 Reviewed by Yusuke Suzuki. The original size_t workaround came about 14 years ago, right when Apple was still compiling for PowerPC. Basically, so many devices ran on 32 bits. A long type can hold onto the required length now, so we no longer need to worry about it. *Source/JavaScriptCore/API/JSStringRefCF.cpp: JSStringRef JSStringCreateWithCFString(CFStringRef string): Canonical link: https://commits.webkit.org/260083@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d3456: Remove setWithoutBarrier
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d3456e83828b7032889c333a8ba7edd25ef2c1f https://github.com/WebKit/WebKit/commit/4d3456e83828b7032889c333a8ba7edd25ef2c1f Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-09 (Thu, 09 Feb 2023) Changed paths: M Source/WebCore/bindings/js/JSValueInWrappedObject.h Log Message: --- Remove setWithoutBarrier https://bugs.webkit.org/show_bug.cgi?id=236278 Reviewed by Yusuke Suzuki. The parsing bug has been fixed. Let's remove this workaround. *Source\WebCore\bindings\js\JSValueInWrappedObject.h: Canonical link: https://commits.webkit.org/260073@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1408c9: Remove getStorageUpdates
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1408c97255e8a7283832d05e2d7e7b5be6cf31a5 https://github.com/WebKit/WebKit/commit/1408c97255e8a7283832d05e2d7e7b5be6cf31a5 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/mac/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/win/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/wincairo/fast/dom/navigator-detached-no-crash-expected.txt M LayoutTests/platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt M Source/WebCore/page/Navigator.cpp M Source/WebCore/page/Navigator.h M Source/WebCore/page/Navigator.idl Log Message: --- Remove getStorageUpdates https://bugs.webkit.org/show_bug.cgi?id=251867 Reviewed by Sihui Liu. No one uses it anymore. No other web browser has this anymore. No calls happen to it anymore. Let us remove this. Canonical link: https://commits.webkit.org/260020@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 833921: Use currentDrawingAppearance instead of currentApp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 833921a024bca719124b3dd7e61d207a31ac65a5 https://github.com/WebKit/WebKit/commit/833921a024bca719124b3dd7e61d207a31ac65a5 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-08 (Wed, 08 Feb 2023) Changed paths: M Source/WebCore/page/scrolling/mac/ScrollerMac.mm M Source/WebCore/platform/graphics/mac/AppKitControlSystemImage.mm M Source/WebCore/platform/graphics/mac/ScrollbarTrackCornerSystemImageMac.mm M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm M Source/WebCore/platform/graphics/mac/controls/InnerSpinButtonMac.mm M Source/WebCore/platform/graphics/mac/controls/ProgressBarMac.mm M Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm M Source/WebCore/platform/mac/ThemeMac.mm Log Message: --- Use currentDrawingAppearance instead of currentAppearance https://bugs.webkit.org/show_bug.cgi?id=251853 Reviewed by Aditya Keerthi. currentAppearance is deprecated. We should be utilizing currentDrawingAppearance and find a way to avoid having to manually set and handle appearances. This PR takes the first step in this by using currentDrawingAppearance. Canonical link: https://commits.webkit.org/260017@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f488ed: Remove checks for long-discontinued applications
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f488ed361cf13d4c8d976cd33af22609b4f340f2 https://github.com/WebKit/WebKit/commit/f488ed361cf13d4c8d976cd33af22609b4f340f2 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-07 (Tue, 07 Feb 2023) Changed paths: M Source/WebCore/Modules/geolocation/Geolocation.cpp M Source/WebCore/WebCore.order M Source/WebCore/platform/RuntimeApplicationChecks.h M Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm M Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Remove checks for long-discontinued applications https://bugs.webkit.org/show_bug.cgi?id=251706 Reviewed by Brent Fulgham. Aperture is long gone; the program no longer runs on supported macOS releases. We can remove the checks for Aperture. Same as iTunes and AOL on Mac. Finally, remove the iBooks check since iBooks is also no longer affected by its old quirk. *Source/WebCore/Modules/geolocation/Geolocation.cpp: *Source/WebCore/WebCore.order: *Source/WebCore/platform/RuntimeApplicationChecks.h: *Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm: *Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h: *Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm: *Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm: *Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm: *Source/WebKitLegacy/mac/WebView/WebView.mm: Canonical link: https://commits.webkit.org/259988@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f5f182: Delete unused WebCoreNSURLSessionInternal.h file
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f5f182a2a26135138d99894791c62e87505a9f8c https://github.com/WebKit/WebKit/commit/f5f182a2a26135138d99894791c62e87505a9f8c Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-07 (Tue, 07 Feb 2023) Changed paths: R Source/WebCore/platform/network/cocoa/WebCoreNSURLSessionInternal.h Log Message: --- Delete unused WebCoreNSURLSessionInternal.h file https://bugs.webkit.org/show_bug.cgi?id=251798 Reviewed by Tim Nguyen. Nowhere in the repository is this file even mentioned. It is also an empty file. This can be safely removed. *Source\WebCore\platform\network\cocoa\WebCoreNSURLSessionInternal.h: Deleted. Canonical link: https://commits.webkit.org/259961@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c751bf: Remove pre-Mojave fallback in run-leaks
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c751bfa134b07b98a646ddf307211e4b407d0f46 https://github.com/WebKit/WebKit/commit/c751bfa134b07b98a646ddf307211e4b407d0f46 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-06 (Mon, 06 Feb 2023) Changed paths: M Tools/Scripts/run-leaks Log Message: --- Remove pre-Mojave fallback in run-leaks https://bugs.webkit.org/show_bug.cgi?id=251799 Reviewed by Alexey Proskuryakov and Jonathan Bedard. Mojave is not supported anymore. We can revert this workaround. *Tools\Scripts\run-leaks: Canonical link: https://commits.webkit.org/259929@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14d3cc: Remove checks for A8 devices https://bugs.webkit.o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14d3cca9ff6908a009167387b63846c5db002d74 https://github.com/WebKit/WebKit/commit/14d3cca9ff6908a009167387b63846c5db002d74 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-02 (Thu, 02 Feb 2023) Changed paths: M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm M Source/WebCore/testing/Internals.mm Log Message: --- Remove checks for A8 devices https://bugs.webkit.org/show_bug.cgi?id=251552 Reviewed by Kimmo Kinnunen. As of iOS 13, A8 devices are no longer supported. ANGLE has removed checks for A8 as well. * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (platformSupportsMetal) * Source/WebCore/testing/Internals.mm: ((NSAttributedString *)_attributedStringForRange:(NSRange)range): Canonical link: https://commits.webkit.org/259800@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d0cbdc: Create compile-time CFString instead of C literal ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0cbdc8286e32465118f4e01ceb89567f4431ecd https://github.com/WebKit/WebKit/commit/d0cbdc8286e32465118f4e01ceb89567f4431ecd Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-01 (Wed, 01 Feb 2023) Changed paths: M Source/JavaScriptCore/API/tests/testapi.c Log Message: --- Create compile-time CFString instead of C literal https://bugs.webkit.org/show_bug.cgi?id=250937 Reviewed by Yusuke Suzuki. Creating a CFString from a C literal at runtime is inefficient. Let's create the string at compile-time instead. * Source\JavaScriptCore\API\tests\testapi.c: (static void testCFStrings(void)): Use CFSTR macro Canonical link: https://commits.webkit.org/259730@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 078af4: CFArrayGetCount not SecTrustGetCertificateCount
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 078af423a71e82ce0563e34d19b7dacb034df5e3 https://github.com/WebKit/WebKit/commit/078af423a71e82ce0563e34d19b7dacb034df5e3 Author: Rose <83477269+ataridre...@users.noreply.github.com> Date: 2023-02-01 (Wed, 01 Feb 2023) Changed paths: M Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp M Source/WebCore/platform/network/cocoa/CertificateInfoCocoa.mm Log Message: --- CFArrayGetCount not SecTrustGetCertificateCount https://bugs.webkit.org/show_bug.cgi?id=250938 Reviewed by Chris Dumez. We already have the CFArrayRef, so let's call CFArrayGetCount instead of SecTrustGetCertificateCount. * Source\WebCore\platform\network\cf\CertificateInfoCFNet.cpp: (bool certificatesMatch(SecTrustRef trust1, SecTrustRef trust2)): Obtain count1 and count2 from CFArrayGetCount if supported. * Source\WebCore\platform\network\cocoa\CertificateInfoCocoa.mm: (void CertificateInfo::dump() const): Obtain entries from CFArrayGetCount if supported. Canonical link: https://commits.webkit.org/259712@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
