[webkit-changes] [WebKit/WebKit] 3b6d01: AX: Don't include password input value in aria-lab...

2023-03-31 Thread Tommy McHugh 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b6d017ba868a66c08ca684570e44269fb2b1274
  
https://github.com/WebKit/WebKit/commit/3b6d017ba868a66c08ca684570e44269fb2b1274
  Author: Tommy McHugh 
  Date:   2023-03-31 (Fri, 31 Mar 2023)

  Changed paths:
M LayoutTests/accessibility-isolated-tree/TestExpectations
A LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt
A LayoutTests/accessibility/aria-labelledby-on-password-input.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  ---
  AX: Don't include password input value in aria-labelledby description
https://bugs.webkit.org/show_bug.cgi?id=248717
rdar://problem/102815043

Reviewed by Tyler Wilcock.

accessibleNameForNode is erroneously returning the raw password input value when
an element has an aria-labelledby attribute to an input element with a password 
type.
This patch fixes that by checking HTMLInputElement::isPasswordField before 
returning
the input's value and when there is a password field returning a masked value 
matching
the length of the true value.

* LayoutTests/accessibility-isolated-tree/TestExpectations:
* LayoutTests/accessibility/aria-labelledby-on-password-input-expected.txt: 
Added.
* LayoutTests/accessibility/aria-labelledby-on-password-input.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):

Canonical link: https://commits.webkit.org/262433@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9a1184: AX: Expose bold and italic font styling as text at...

2022-12-21 Thread Tommy McHugh 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a11844523ca34c274cd4b361f9805010fc759ae
  
https://github.com/WebKit/WebKit/commit/9a11844523ca34c274cd4b361f9805010fc759ae
  Author: Tommy McHugh 
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
A 
LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling-expected.txt
A 
LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling.html
M 
LayoutTests/platform/mac/accessibility/content-editable-as-textarea-expected.txt
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm

  Log Message:
  ---
  AX: Expose bold and italic font styling as text attributes for macOS
https://bugs.webkit.org/show_bug.cgi?id=249688
rdar://problem/103577386

Reviewed by Chris Fleizach.

Currently WebKit only exposes bold and italic properties of font styling for 
iOS.
This patch adds bold and italic font styling information to accessibility for 
macOS
by checking the bold and italic symbolic font traits in 
AXAttributedStringSetFont and
adding their result as AXFontBold and AXFontItalic font attributes.

* 
LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling-expected.txt:
 Added.
* 
LayoutTests/accessibility/mac/attributed-string/attributed-string-text-styling.html:
 Added.
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(AXAttributedStringSetFont):

Canonical link: https://commits.webkit.org/258212@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f7a887: AX: Include AXKeyShortcutsValue in accessibilityAt...

2022-12-01 Thread Tommy McHugh 
  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7a887f4c25742af054956aec6cf2ef5c2512e14
  
https://github.com/WebKit/WebKit/commit/f7a887f4c25742af054956aec6cf2ef5c2512e14
  Author: Tommy McHugh 
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
A LayoutTests/accessibility/aria-keyshortcuts-expected.txt
A LayoutTests/accessibility/aria-keyshortcuts.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/win/TestExpectations
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityObjectInterface.h
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  ---
  AX: Include AXKeyShortcutsValue in accessibilityAttributeNames when there is 
an aria-keyshortcuts attribute
https://bugs.webkit.org/show_bug.cgi?id=248572
rdar://problem/102834471

Reviewed by Andres Gonzalez.

WebAccessibilityObjectWrapper supports returning the value of aria-keyshortcuts
through the AXKeyShortcutsValue accessibility attribute, but does not return the
attribute name in accessibilityAttributeNames if it is a supported attribute.
Additionally, this attribute is not updated in the isolated tree if it is 
changed.
This patch fixes that by including AXKeyShortcutsValue in 
accessibilityAttributeNames if it
is supported through AccessibilityObject::supportsKeyShortcutsValue and updates 
the AXIsolatedTree
value for AXPropertyName::KeyShortcutsValue if aria-keyshortcuts attribute is 
changed.

* LayoutTests/accessibility/aria-keyshortcuts-expected.txt: Added.
* LayoutTests/accessibility/aria-keyshortcuts.html: Added.
* LayoutTests/platform/win/TestExpectations:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsKeyShortcuts const):
(WebCore::AccessibilityObject::keyShortcuts const):
(WebCore::AccessibilityObject::keyShortcutsValue const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::attributes const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Canonical link: https://commits.webkit.org/257274@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes