[webkit-changes] [WebKit/WebKit] f8ceb0: Implement BackingStoreSkia

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8ceb0c9e43e72c947be2f388034a14bb7df27f6
  
https://github.com/WebKit/WebKit/commit/f8ceb0c9e43e72c947be2f388034a14bb7df27f6
  Author: Don Olmstead 
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/UIProcess/BackingStore.h
M Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp

  Log Message:
  ---
  Implement BackingStoreSkia
https://bugs.webkit.org/show_bug.cgi?id=273593

Reviewed by Carlos Garcia Campos.

Fill in the implementation of `BackingStore` when `USE(SKIA)` is `ON`. Follow
along with the behavior of the Cairo implementation.

* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/UIProcess/BackingStore.h:
* Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp:

Canonical link: https://commits.webkit.org/278877@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 3ca98c: Fix warnings in PlatformDisplaySkia for PlayStation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3ca98c9d4b1b7ba1df3d2f7e116b49ed9b4bd6ac
  
https://github.com/WebKit/WebKit/commit/3ca98c9d4b1b7ba1df3d2f7e116b49ed9b4bd6ac
  Author: Don Olmstead 
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp

  Log Message:
  ---
  Fix warnings in PlatformDisplaySkia for PlayStation
https://bugs.webkit.org/show_bug.cgi?id=274106

Unreviewed build fix.

Fix unused warnings for a build config.

* Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:

Canonical link: https://commits.webkit.org/278705@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 87d065: Hook in Skia rendering on PlayStation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87d0651fa15ce3cdc38e2298f800a810660283bb
  
https://github.com/WebKit/WebKit/commit/87d0651fa15ce3cdc38e2298f800a810660283bb
  Author: Don Olmstead 
  Date:   2024-05-09 (Thu, 09 May 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp
M Source/WebKit/Shared/API/c/skia/WKImageSkia.cpp
M Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
M Source/WebKit/WebProcess/playstation/WebProcessMainPlayStation.cpp

  Log Message:
  ---
  Hook in Skia rendering on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=273630

Reviewed by Fujii Hironori.

Port any Cairo implementations over to Skia. Get everything compiling.

* Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:
* Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp:
* Source/WebKit/Shared/API/c/skia/WKImageSkia.cpp:
* Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp:
* 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
* Source/WebKit/WebProcess/playstation/WebProcessMainPlayStation.cpp:

Canonical link: https://commits.webkit.org/278570@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 7f78e4: Add IPC for SkData

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f78e4799e9778e292febfbab858754745c580ac
  
https://github.com/WebKit/WebKit/commit/7f78e4799e9778e292febfbab858754745c580ac
  Author: Don Olmstead 
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
M Source/WebKit/Platform/Skia.cmake
M Source/WebKit/Shared/WebCoreArgumentCoders.h
A Source/WebKit/Shared/skia/CoreIPCSkData.h
A Source/WebKit/Shared/skia/CoreIPCSkData.serialization.in
M Source/WebKit/Shared/skia/WebCoreArgumentCodersSkia.cpp

  Log Message:
  ---
  Add IPC for SkData
https://bugs.webkit.org/show_bug.cgi?id=273890

Reviewed by Alex Christensen.

Add a wrapper of `SkData` for serialization over IPC.

* Source/WebKit/Platform/Skia.cmake:
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/skia/CoreIPCSkData.h: Added.
(WebKit::CoreIPCSkData::CoreIPCSkData):
(WebKit::CoreIPCSkData::skData const):
(WebKit::CoreIPCSkData::dataReference const):
* Source/WebKit/Shared/skia/CoreIPCSkData.serialization.in: Added.
* Source/WebKit/Shared/skia/WebCoreArgumentCodersSkia.cpp:
(IPC::ArgumentCoder>::encode):
(IPC::ArgumentCoder>::decode):

Canonical link: https://commits.webkit.org/278536@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 8b6db2: Support HAVE(DISPLAY_LINK) on PlayStation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b6db29df483dcc9bec4e5c6c45548178ca20100
  
https://github.com/WebKit/WebKit/commit/8b6db29df483dcc9bec4e5c6c45548178ca20100
  Author: Don Olmstead 
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/UIProcess/DisplayLink.h
A Source/WebKit/UIProcess/playstation/DisplayLinkPlayStation.cpp
M Source/cmake/OptionsPlayStation.cmake
M Tools/MiniBrowser/playstation/WebViewWindow.cpp

  Log Message:
  ---
  Support HAVE(DISPLAY_LINK) on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=270456

Reviewed by Adrian Perez de Castro.

Hook in WPE PlayStation Backend implementation of display link.

* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/UIProcess/DisplayLink.h:
* Source/WebKit/UIProcess/playstation/DisplayLinkPlayStation.cpp: Added.
* Source/cmake/OptionsPlayStation.cmake:
* Tools/MiniBrowser/playstation/WebViewWindow.cpp:

Canonical link: https://commits.webkit.org/278424@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1492af: Non-unified build fixes, early May 2024 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1492af7e4abed58586bc9bbd2a1fec8ad4998a0e
  
https://github.com/WebKit/WebKit/commit/1492af7e4abed58586bc9bbd2a1fec8ad4998a0e
  Author: Don Olmstead 
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
M Source/JavaScriptCore/jit/ExecutableAllocator.cpp
M Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp
M Source/WebCore/bindings/js/DOMWrapperWorld.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmHKDF.cpp
M Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp
M Source/WebCore/dom/WindowEventLoop.cpp
M Source/WebCore/layout/FormattingState.cpp
M Source/WebCore/layout/Verification.cpp
M Source/WebCore/layout/floats/FloatAvoider.cpp
M Source/WebCore/layout/formattingContexts/block/BlockFormattingState.cpp
M 
Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingQuirks.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineItem.cpp
M Source/WebCore/layout/formattingContexts/table/TableFormattingState.cpp
M Source/WebCore/layout/formattingContexts/table/TableGrid.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
M Source/WebCore/layout/layouttree/LayoutInitialContainingBlock.cpp
M Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp
M Source/WebCore/page/ElementTargetingController.cpp
M Source/WebCore/page/ElementTargetingController.h
M Source/WebCore/platform/graphics/FontCascadeDescription.cpp
M Source/WebCore/platform/graphics/PixelFormatValidated.cpp
M Source/WebCore/svg/properties/SVGSharedPrimitiveProperty.h
M Source/WebCore/xml/parser/XMLDocumentParserScope.cpp
M Source/WebCore/xml/parser/XMLDocumentParserScope.h
M Source/WebKit/UIProcess/API/APITargetedElementRequest.cpp
M Source/WebKit/UIProcess/API/APITargetedElementRequest.h

  Log Message:
  ---
  Non-unified build fixes, early May 2024 edition
https://bugs.webkit.org/show_bug.cgi?id=273273

Unreviewed non-unified build fix.

Fixing non-unified build for PlayStation.

* Source/JavaScriptCore/jit/ExecutableAllocator.cpp:
* Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp:
* Source/WebCore/bindings/js/DOMWrapperWorld.cpp:
* Source/WebCore/crypto/algorithms/CryptoAlgorithmHKDF.cpp:
* Source/WebCore/crypto/algorithms/CryptoAlgorithmHMAC.cpp:
* Source/WebCore/dom/WindowEventLoop.cpp:
* Source/WebCore/layout/FormattingState.cpp:
* Source/WebCore/layout/Verification.cpp:
* Source/WebCore/layout/floats/FloatAvoider.cpp:
* Source/WebCore/layout/formattingContexts/block/BlockFormattingState.cpp:
* 
Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingContext.cpp:
* 
Source/WebCore/layout/formattingContexts/block/tablewrapper/TableWrapperBlockFormattingQuirks.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineItem.cpp:
* Source/WebCore/layout/formattingContexts/table/TableFormattingState.cpp:
* Source/WebCore/layout/formattingContexts/table/TableGrid.cpp:
* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
* Source/WebCore/layout/layouttree/LayoutInitialContainingBlock.cpp:
* Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp:
* Source/WebCore/page/ElementTargetingController.cpp:
* Source/WebCore/page/ElementTargetingController.h:
* Source/WebCore/platform/graphics/FontCascadeDescription.cpp:
* Source/WebCore/platform/graphics/PixelFormatValidated.cpp:
* Source/WebCore/svg/properties/SVGSharedPrimitiveProperty.h:
* Source/WebCore/xml/parser/XMLDocumentParserScope.cpp:
* Source/WebCore/xml/parser/XMLDocumentParserScope.h:
* Source/WebKit/UIProcess/API/APITargetedElementRequest.cpp:
(API::TargetedElementRequest::makeRequest const):
* Source/WebKit/UIProcess/API/APITargetedElementRequest.h:

Canonical link: https://commits.webkit.org/278302@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cf7a63: Fix PlayStation build of WebKitTestRunner after 27...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf7a63097d4b8767b3311c614a45628332fec76a
  
https://github.com/WebKit/WebKit/commit/cf7a63097d4b8767b3311c614a45628332fec76a
  Author: Don Olmstead 
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
M 
Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp

  Log Message:
  ---
  Fix PlayStation build of WebKitTestRunner after 278039@main
https://bugs.webkit.org/show_bug.cgi?id=273645

Unreviewed build fix.

Update method signatures.

* 
Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp:

Canonical link: https://commits.webkit.org/278299@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a99db2: Fix build of GLFence.cpp for !USE(LIBEPOXY)

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a99db22709faf65bf67a14ab2073e02fff4b4206
  
https://github.com/WebKit/WebKit/commit/a99db22709faf65bf67a14ab2073e02fff4b4206
  Author: Don Olmstead 
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebCore/PlatformWin.cmake
M Source/WebCore/platform/graphics/egl/GLFence.cpp

  Log Message:
  ---
  Fix build of GLFence.cpp for !USE(LIBEPOXY)
https://bugs.webkit.org/show_bug.cgi?id=273597

Reviewed by Adrian Perez de Castro and Miguel Gomez.

The OpenGL ES functions require version 3.

* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/PlatformWin.cmake:
* Source/WebCore/platform/graphics/egl/GLFence.cpp:

Canonical link: https://commits.webkit.org/278262@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cd68ed: [PlayStation] Hook in rendering to GPU Process

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd68edac9b94617cdb1a1c59ed67b2955b7fef8a
  
https://github.com/WebKit/WebKit/commit/cd68edac9b94617cdb1a1c59ed67b2955b7fef8a
  Author: Don Olmstead 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebKit/GPUProcess/EntryPoint/playstation/GPUProcessMain.cpp
M Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp
M Source/WebKit/UIProcess/playstation/PageClientImpl.cpp
M Source/WebKit/UIProcess/playstation/PageClientImpl.h
M Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp

  Log Message:
  ---
  [PlayStation] Hook in rendering to GPU Process
https://bugs.webkit.org/show_bug.cgi?id=261055

Reviewed by Fujii Hironori.

Add in the plumbing to render the scene in the GPU Process.

* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebKit/GPUProcess/EntryPoint/playstation/GPUProcessMain.cpp:
(main):
* Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp:
(WebKit::GPUProcess::platformInitializeGPUProcess):
* Source/WebKit/UIProcess/playstation/PageClientImpl.cpp:
(WebKit::PageClientImpl::viewWidget):
* Source/WebKit/UIProcess/playstation/PageClientImpl.h:
* Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp:
(WebKit::WebPageProxy::viewWidget):

Canonical link: https://commits.webkit.org/278220@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 13023a: [CMake] Centralize Skia build in WebKit

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13023ae113eb6be6c43faa82f90a16ecea5f4c33
  
https://github.com/WebKit/WebKit/commit/13023ae113eb6be6c43faa82f90a16ecea5f4c33
  Author: Don Olmstead 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
A Source/WebKit/Platform/Skia.cmake
M Source/WebKit/PlatformGTK.cmake
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/PlatformWPE.cmake
M Source/WebKit/SourcesGTK.txt
M Source/WebKit/SourcesWPE.txt

  Log Message:
  ---
  [CMake] Centralize Skia build in WebKit
https://bugs.webkit.org/show_bug.cgi?id=273512

Reviewed by Michael Catanzaro.

Centralize the CMake definitions of Skia for the `WebKit` target into
`Platform/Skia.cmake`.

* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/Platform/Skia.cmake: Added.
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesWPE.txt:

Canonical link: https://commits.webkit.org/278191@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c24a25: Build error unknown type name HB_BEGIN_DECLS

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c24a25eda1fc492d06f0ecb0d1f719f989a3d194
  
https://github.com/WebKit/WebKit/commit/c24a25eda1fc492d06f0ecb0d1f719f989a3d194
  Author: Don Olmstead 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp

  Log Message:
  ---
  Build error unknown type name HB_BEGIN_DECLS
https://bugs.webkit.org/show_bug.cgi?id=273513

Unreviewed build fix.

During an update of HarfBuzz `FontCustomPlatformDataFreeType.cpp` started
erroring with an unknown type name error for `HB_BEGIN_DECLS`. Include `hb.h`
before `hb-features.h` so the macro is present.

* Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

Canonical link: https://commits.webkit.org/278183@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a66201: Fix PlayStation build with GPU Process

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a662016b2cd789c14f6c9fba394a84f058f1
  
https://github.com/WebKit/WebKit/commit/a662016b2cd789c14f6c9fba394a84f058f1
  Author: Don Olmstead 
  Date:   2024-04-29 (Mon, 29 Apr 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp
M Source/WebKit/GPUProcess/playstation/GPUProcessMainPlayStation.cpp

  Log Message:
  ---
  Fix PlayStation build with GPU Process
https://bugs.webkit.org/show_bug.cgi?id=273448

Reviewed by Fujii Hironori.

Update based on changes since the last time it was turned on.

* Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp:
* Source/WebKit/GPUProcess/playstation/GPUProcessMainPlayStation.cpp:

Canonical link: https://commits.webkit.org/278139@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 40ce17: Use naming conventions for Font IPC

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40ce17e8ec3287c304383c2641ca0e2e4a7bebf9
  
https://github.com/WebKit/WebKit/commit/40ce17e8ec3287c304383c2641ca0e2e4a7bebf9
  Author: Don Olmstead 
  Date:   2024-04-29 (Mon, 29 Apr 2024)

  Changed paths:
M Source/WebCore/platform/graphics/FontPlatformData.h
M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  ---
  Use naming conventions for Font IPC
https://bugs.webkit.org/show_bug.cgi?id=273422

Reviewed by Chris Dumez.

Use `toIPCData` and `fromIPCData` when serializing `FontPlatformData`. This
conforms with the updated naming conventions.

Organize the code so other platforms can start generating serialization.

* Source/WebCore/platform/graphics/FontPlatformData.h:
* Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp:
(WebCore::FontPlatformData::fromIPCData):
(WebCore::FontPlatformData::toIPCData const):
(WebCore::FontPlatformData::tryMakeFontPlatformData): Deleted.
(WebCore::FontPlatformData::platformSerializationData const): Deleted.
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/278132@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1ad20f: Turn on HAVE_ONLY_MODERN_SERIALIZATION for Windows

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ad20fe37f2075252dc66fbed60b9a624d22a70a
  
https://github.com/WebKit/WebKit/commit/1ad20fe37f2075252dc66fbed60b9a624d22a70a
  Author: Don Olmstead 
  Date:   2024-04-23 (Tue, 23 Apr 2024)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h

  Log Message:
  ---
  Turn on HAVE_ONLY_MODERN_SERIALIZATION for Windows
https://bugs.webkit.org/show_bug.cgi?id=273144

Reviewed by Alex Christensen.

The Windows port builds using only modern serialization. Turn on the build flag
flag for this. Correct the flag name in `PlatformHave.h`. Remove
`PLATFORM(COCOA)` since it doesn't compile with this flag.

* Source/WTF/wtf/PlatformHave.h:

Canonical link: https://commits.webkit.org/277898@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 38694a: Generate serialization of CurlProxySettings

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38694a9a62607c8f9f4ad897d6c3257b57c2258a
  
https://github.com/WebKit/WebKit/commit/38694a9a62607c8f9f4ad897d6c3257b57c2258a
  Author: Don Olmstead 
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
M Source/WebCore/platform/network/curl/CurlProxySettings.cpp
M Source/WebCore/platform/network/curl/CurlProxySettings.h
M Source/WebKit/Platform/Curl.cmake
M Source/WebKit/Shared/WebCoreArgumentCoders.h
R Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp
A Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.serialization.in

  Log Message:
  ---
  Generate serialization of CurlProxySettings
https://bugs.webkit.org/show_bug.cgi?id=272849

Reviewed by Chris Dumez and Alex Christensen.

Move serialization of `CurlProxySettings` into a `.serialization.in`. file.

* Source/WebCore/platform/network/curl/CurlProxySettings.cpp:
* Source/WebCore/platform/network/curl/CurlProxySettings.h:
* Source/WebKit/Platform/Curl.cmake:
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp: Removed.
* Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.serialization.in: Added.

Canonical link: https://commits.webkit.org/277705@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 19703e: Use modern decoders in WebProcessProxy

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19703e902a3349876fa639b0fe69e6b34c1feafb
  
https://github.com/WebKit/WebKit/commit/19703e902a3349876fa639b0fe69e6b34c1feafb
  Author: Don Olmstead 
  Date:   2024-04-17 (Wed, 17 Apr 2024)

  Changed paths:
M Source/WebKit/UIProcess/WebProcessProxy.cpp

  Log Message:
  ---
  Use modern decoders in WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=272855

Reviewed by Chris Dumez.

Use `std::optional decode()` instead of `bool decode(T&)` within
`WebProcessProxy`.

Issue found when compiling with `HAVE_ONLY_MODERN_SERIALIZATION`.

* Source/WebKit/UIProcess/WebProcessProxy.cpp:

Canonical link: https://commits.webkit.org/277644@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f35db6: Update googletest to v1.14.0

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f35db6f5b2fbcd3adeeecdeb583ed29ba5485210
  
https://github.com/WebKit/WebKit/commit/f35db6f5b2fbcd3adeeecdeb583ed29ba5485210
  Author: Don Olmstead 
  Date:   2024-04-17 (Wed, 17 Apr 2024)

  Changed paths:
M Source/ThirdParty/gmock/CMakeLists.txt
M Source/ThirdParty/gmock/README.WebKit
M Source/ThirdParty/gmock/README.md
M Source/ThirdParty/gmock/changes.diff
M Source/ThirdParty/gmock/include/gmock/gmock-actions.h
M Source/ThirdParty/gmock/include/gmock/gmock-cardinalities.h
M Source/ThirdParty/gmock/include/gmock/gmock-function-mocker.h
M Source/ThirdParty/gmock/include/gmock/gmock-matchers.h
M Source/ThirdParty/gmock/include/gmock/gmock-more-actions.h
M Source/ThirdParty/gmock/include/gmock/gmock-more-matchers.h
M Source/ThirdParty/gmock/include/gmock/gmock-nice-strict.h
M Source/ThirdParty/gmock/include/gmock/gmock-spec-builders.h
M Source/ThirdParty/gmock/include/gmock/gmock.h
M Source/ThirdParty/gmock/include/gmock/internal/custom/README.md
M 
Source/ThirdParty/gmock/include/gmock/internal/custom/gmock-generated-actions.h
M Source/ThirdParty/gmock/include/gmock/internal/custom/gmock-matchers.h
M Source/ThirdParty/gmock/include/gmock/internal/custom/gmock-port.h
M Source/ThirdParty/gmock/include/gmock/internal/gmock-internal-utils.h
M Source/ThirdParty/gmock/include/gmock/internal/gmock-port.h
R Source/ThirdParty/gmock/scripts/README.md
R Source/ThirdParty/gmock/scripts/fuse_gmock_files.py
R Source/ThirdParty/gmock/scripts/generator/LICENSE
R Source/ThirdParty/gmock/scripts/generator/README
R Source/ThirdParty/gmock/scripts/generator/README.cppclean
R Source/ThirdParty/gmock/scripts/generator/cpp/__init__.py
R Source/ThirdParty/gmock/scripts/generator/cpp/ast.py
R Source/ThirdParty/gmock/scripts/generator/cpp/gmock_class.py
R Source/ThirdParty/gmock/scripts/generator/cpp/gmock_class_test.py
R Source/ThirdParty/gmock/scripts/generator/cpp/keywords.py
R Source/ThirdParty/gmock/scripts/generator/cpp/tokenize.py
R Source/ThirdParty/gmock/scripts/generator/cpp/utils.py
R Source/ThirdParty/gmock/scripts/generator/gmock_gen.py
M Source/ThirdParty/gmock/src/gmock-all.cc
M Source/ThirdParty/gmock/src/gmock-cardinalities.cc
M Source/ThirdParty/gmock/src/gmock-internal-utils.cc
M Source/ThirdParty/gmock/src/gmock-matchers.cc
M Source/ThirdParty/gmock/src/gmock-spec-builders.cc
M Source/ThirdParty/gmock/src/gmock.cc
M Source/ThirdParty/gmock/src/gmock_main.cc
M Source/ThirdParty/gmock/test/BUILD.bazel
M Source/ThirdParty/gmock/test/gmock-actions_test.cc
M Source/ThirdParty/gmock/test/gmock-cardinalities_test.cc
M Source/ThirdParty/gmock/test/gmock-function-mocker_test.cc
M Source/ThirdParty/gmock/test/gmock-internal-utils_test.cc
A Source/ThirdParty/gmock/test/gmock-matchers-arithmetic_test.cc
A Source/ThirdParty/gmock/test/gmock-matchers-comparisons_test.cc
A Source/ThirdParty/gmock/test/gmock-matchers-containers_test.cc
A Source/ThirdParty/gmock/test/gmock-matchers-misc_test.cc
R Source/ThirdParty/gmock/test/gmock-matchers_test.cc
A Source/ThirdParty/gmock/test/gmock-matchers_test.h
M Source/ThirdParty/gmock/test/gmock-more-actions_test.cc
M Source/ThirdParty/gmock/test/gmock-nice-strict_test.cc
M Source/ThirdParty/gmock/test/gmock-port_test.cc
M Source/ThirdParty/gmock/test/gmock-pp-string_test.cc
M Source/ThirdParty/gmock/test/gmock-spec-builders_test.cc
M Source/ThirdParty/gmock/test/gmock_all_test.cc
M Source/ThirdParty/gmock/test/gmock_ex_test.cc
M Source/ThirdParty/gmock/test/gmock_leak_test.py
M Source/ThirdParty/gmock/test/gmock_leak_test_.cc
M Source/ThirdParty/gmock/test/gmock_link2_test.cc
M Source/ThirdParty/gmock/test/gmock_link_test.cc
M Source/ThirdParty/gmock/test/gmock_link_test.h
M Source/ThirdParty/gmock/test/gmock_output_test.py
M Source/ThirdParty/gmock/test/gmock_output_test_.cc
M Source/ThirdParty/gmock/test/gmock_output_test_golden.txt
M Source/ThirdParty/gmock/test/gmock_stress_test.cc
M Source/ThirdParty/gmock/test/gmock_test.cc
M Source/ThirdParty/gmock/test/gmock_test_utils.py
M Source/ThirdParty/gtest/README.WebKit
M Source/ThirdParty/gtest/README.md
A Source/ThirdParty/gtest/changes.diff
M Source/ThirdParty/gtest/cmake/internal_utils.cmake
A Source/ThirdParty/gtest/include/gtest/gtest-assertion-result.h
M Source/ThirdParty/gtest/include/gtest/gtest-death-test.h
M Source/ThirdParty/gtest/include/gtest/gtest-matchers.h
M Source/ThirdParty/gtest/include/gtest/gtest-message.h
M Source/ThirdParty/gtest/include/gtest/gtest-param-test.h
M Source/ThirdParty/gtest/include/gtest/gtest-printers.h
M Source/ThirdParty/gtest/include/gtest/gtest-spi.h
M Source/ThirdParty/gtest/include/gtest/gtest

[webkit-changes] [WebKit/WebKit] 4d1720: Remove ENABLE_CSS_PAINTING_API build flag

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d1720ec1d0f7dca40445a4a8d5c66226b2f1f9b
  
https://github.com/WebKit/WebKit/commit/4d1720ec1d0f7dca40445a4a8d5c66226b2f1f9b
  Author: Don Olmstead 
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformEnable.h
M Source/WebCore/bindings/js/JSPaintRenderingContext2DCustom.cpp
M Source/WebCore/bindings/js/JSPaintWorkletGlobalScopeCustom.cpp
M Source/WebCore/bindings/js/WebCoreJSClientData.cpp
M Source/WebCore/bindings/js/WebCoreJSClientData.h
M Source/WebCore/css/CSSPaintCallback.h
M Source/WebCore/css/CSSPaintCallback.idl
M Source/WebCore/css/CSSPaintImageValue.cpp
M Source/WebCore/css/CSSPaintImageValue.h
M Source/WebCore/css/CSSPaintSize.h
M Source/WebCore/css/CSSPaintSize.idl
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/DOMCSSNamespace+CSSPainting.idl
M Source/WebCore/css/DOMCSSPaintWorklet.cpp
M Source/WebCore/css/DOMCSSPaintWorklet.h
M Source/WebCore/css/parser/CSSParserContext.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/html/CustomPaintCanvas.cpp
M Source/WebCore/html/CustomPaintCanvas.h
M Source/WebCore/html/CustomPaintImage.cpp
M Source/WebCore/html/CustomPaintImage.h
M Source/WebCore/html/canvas/PaintRenderingContext2D.cpp
M Source/WebCore/html/canvas/PaintRenderingContext2D.h
M Source/WebCore/html/canvas/PaintRenderingContext2D.idl
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/StyleImage.h
M Source/WebCore/rendering/style/StylePaintImage.cpp
M Source/WebCore/rendering/style/StylePaintImage.h
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilderState.cpp
M Source/WebCore/workers/WorkerOrWorkletScriptController.cpp
M Source/WebCore/worklets/PaintWorkletGlobalScope.cpp
M Source/WebCore/worklets/PaintWorkletGlobalScope.h
M Source/WebCore/worklets/PaintWorkletGlobalScope.idl
M Source/WebCore/worklets/WorkletGlobalScope.h
M Source/cmake/WebKitFeatures.cmake
M Tools/Scripts/webkitperl/FeatureList.pm

  Log Message:
  ---
  Remove ENABLE_CSS_PAINTING_API build flag
https://bugs.webkit.org/show_bug.cgi?id=271913

Reviewed by Said Abou-Hallawa and Michael Catanzaro.

All ports are building with `ENABLE_CSS_PAINTING_API` as `ON`. Remove the
build option and use the runtime option for controlling use.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WebCore/bindings/js/JSPaintRenderingContext2DCustom.cpp:
* Source/WebCore/bindings/js/JSPaintWorkletGlobalScopeCustom.cpp:
* Source/WebCore/bindings/js/WebCoreJSClientData.cpp:
* Source/WebCore/bindings/js/WebCoreJSClientData.h:
* Source/WebCore/css/CSSPaintCallback.h:
* Source/WebCore/css/CSSPaintCallback.idl:
* Source/WebCore/css/CSSPaintImageValue.cpp:
* Source/WebCore/css/CSSPaintImageValue.h:
* Source/WebCore/css/CSSPaintSize.h:
* Source/WebCore/css/CSSPaintSize.idl:
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/CSSValue.h:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/DOMCSSNamespace+CSSPainting.idl:
* Source/WebCore/css/DOMCSSPaintWorklet.cpp:
* Source/WebCore/css/DOMCSSPaintWorklet.h:
* Source/WebCore/css/parser/CSSParserContext.cpp:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp:
* Source/WebCore/dom/Document.cpp:
* Source/WebCore/dom/Document.h:
* Source/WebCore/html/CustomPaintCanvas.cpp:
* Source/WebCore/html/CustomPaintCanvas.h:
* Source/WebCore/html/CustomPaintImage.cpp:
* Source/WebCore/html/CustomPaintImage.h:
* Source/WebCore/html/canvas/PaintRenderingContext2D.cpp:
* Source/WebCore/html/canvas/PaintRenderingContext2D.h:
* Source/WebCore/html/canvas/PaintRenderingContext2D.idl:
* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/StyleImage.h:
* Source/WebCore/rendering/style/StylePaintImage.cpp:
* Source/WebCore/rendering/style/StylePaintImage.h:
* Source/WebCore/style/StyleBuilder.cpp:
* Source/WebCore/style/StyleBuilderState.cpp:
* Source/WebCore/workers/WorkerOrWorkletScriptController.cpp:
* Source/WebCore/worklets/PaintWorkletGlobalScope.cpp:
* Source/WebCore/worklets/PaintWorkletGlobalScope.h:
* Source/WebCore/worklets/PaintWorkletGlobalScope.idl:
* Source/WebCore/worklets/WorkletGlobalScope.h:
* Source/cmake/WebKitFeatures.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: https

[webkit-changes] [WebKit/WebKit] aa7cd8: Turn ENABLE_CSS_PAINTING_API on for all ports

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa7cd8645213925174492b760d68ae24c57e3983
  
https://github.com/WebKit/WebKit/commit/aa7cd8645213925174492b760d68ae24c57e3983
  Author: Don Olmstead 
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/cmake/OptionsGTK.cmake
M Source/cmake/OptionsMac.cmake
M Source/cmake/OptionsPlayStation.cmake
M Source/cmake/OptionsWPE.cmake
M Source/cmake/OptionsWin.cmake
M Source/cmake/WebKitFeatures.cmake

  Log Message:
  ---
  Turn  ENABLE_CSS_PAINTING_API on for all ports
https://bugs.webkit.org/show_bug.cgi?id=272036

Reviewed by Michael Catanzaro.

All ports are building the CSS Painting API at least in developer mode. Set
`ENABLE_CSS_PAINTING_API` to `ON` by default. The actual API is guarded by a
runtime check.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:

Canonical link: https://commits.webkit.org/276958@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 641e3a: Prevent compile options from being added to MASM w...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 641e3aa79194b53c4ea7d52113bca8c68713a255
  
https://github.com/WebKit/WebKit/commit/641e3aa79194b53c4ea7d52113bca8c68713a255
  Author: Don Olmstead 
  Date:   2024-03-29 (Fri, 29 Mar 2024)

  Changed paths:
M Source/cmake/OptionsMSVC.cmake

  Log Message:
  ---
  Prevent compile options from being added to MASM within VS
https://bugs.webkit.org/show_bug.cgi?id=271861

Reviewed by Fujii Hironori.

When building within Visual Studio the CMake generator ends up adding values
from `add_compile_options` to the MASM compilation. This breaks compilation of
assembly files. Work around this by adding a CMake function that uses a
generator expression based on the language.

* Source/cmake/OptionsMSVC.cmake:

Canonical link: https://commits.webkit.org/276831@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9d4b24: Remove ENABLE_LAYER_BASED_SVG_ENGINE build flag

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9d4b24463c6eadcb58801aafd4eb8fe730d1f03d
  
https://github.com/WebKit/WebKit/commit/9d4b24463c6eadcb58801aafd4eb8fe730d1f03d
  Author: Don Olmstead 
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/loader/ImageLoader.cpp
M Source/WebCore/loader/cache/CachedImage.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/SettingsBase.cpp
M Source/WebCore/page/SettingsBase.h
M Source/WebCore/rendering/ReferencedSVGResources.cpp
M Source/WebCore/rendering/ReferencedSVGResources.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderElement.h
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayer.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerInlines.h
M Source/WebCore/rendering/RenderLayerModelObject.cpp
M Source/WebCore/rendering/RenderLayerModelObject.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderTreeAsText.cpp
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/rendering/TransformOperationData.cpp
M Source/WebCore/rendering/svg/RenderSVGBlock.cpp
M Source/WebCore/rendering/svg/RenderSVGBlock.h
M Source/WebCore/rendering/svg/RenderSVGContainer.cpp
M Source/WebCore/rendering/svg/RenderSVGContainer.h
M Source/WebCore/rendering/svg/RenderSVGEllipse.cpp
M Source/WebCore/rendering/svg/RenderSVGEllipse.h
M Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp
M Source/WebCore/rendering/svg/RenderSVGForeignObject.h
M Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp
M Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp
M Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h
M Source/WebCore/rendering/svg/RenderSVGImage.cpp
M Source/WebCore/rendering/svg/RenderSVGImage.h
M Source/WebCore/rendering/svg/RenderSVGInline.cpp
M Source/WebCore/rendering/svg/RenderSVGInline.h
M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/RenderSVGModelObject.h
M Source/WebCore/rendering/svg/RenderSVGPath.cpp
M Source/WebCore/rendering/svg/RenderSVGPath.h
M Source/WebCore/rendering/svg/RenderSVGRect.cpp
M Source/WebCore/rendering/svg/RenderSVGRect.h
M Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceClipper.h
M Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceContainer.h
M Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceGradient.h
M Source/WebCore/rendering/svg/RenderSVGResourceGradientInlines.h
M Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.h
M Source/WebCore/rendering/svg/RenderSVGResourceLinearGradientInlines.h
M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMarker.h
M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h
M Source/WebCore/rendering/svg/RenderSVGResourcePaintServer.cpp
M Source/WebCore/rendering/svg/RenderSVGResourcePaintServer.h
M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp
M Source/WebCore/rendering/svg/RenderSVGResourcePattern.h
M Source/WebCore/rendering/svg/RenderSVGResourcePatternInlines.h
M Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.h
M Source/WebCore/rendering/svg/RenderSVGResourceRadialGradientInlines.h
M Source/WebCore/rendering/svg/RenderSVGRoot.cpp
M Source/WebCore/rendering/svg/RenderSVGRoot.h
M Source/WebCore/rendering/svg/RenderSVGShape.cpp
M Source/WebCore/rendering/svg/RenderSVGShape.h
M Source/WebCore/rendering/svg/RenderSVGShapeInlines.h
M Source/WebCore/rendering/svg/RenderSVGText.cpp
M Source/WebCore/rendering/svg/RenderSVGText.h
M Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
M Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp
M Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h
M Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp
M Source/WebCore/rendering/svg/RenderSVGViewportContainer.h
M Source/WebCore

[webkit-changes] [WebKit/WebKit] baf506: Make bindRemoteAccessibilityFrames declaration con...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: baf5067a2bd642e023ffee731b37090d974715e0
  
https://github.com/WebKit/WebKit/commit/baf5067a2bd642e023ffee731b37090d974715e0
  Author: Don Olmstead 
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
M Source/WebCore/page/RemoteFrame.cpp
M Source/WebCore/page/RemoteFrameClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp

  Log Message:
  ---
  Make bindRemoteAccessibilityFrames declaration consistent
https://bugs.webkit.org/show_bug.cgi?id=271833

Reviewed by Chris Dumez.

In 274955@main the method `bindRemoteAccessibilityFrames` was added to
`RemoteFrameClient`. When overridden in `WebRemoteFrameClient` the
signature didn't match which triggered a warning in MSVC, C4373, due to
`const` qualifiers. This patch just makes the `std::span`
parameters consistent across the previous patch.

* Source/WebCore/page/RemoteFrame.cpp:
* Source/WebCore/page/RemoteFrameClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:

Canonical link: https://commits.webkit.org/276809@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 33e349: Fix MSVC warning in MathCommon

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33e3497f577ec238f2f6766fc43cae9c2496aac9
  
https://github.com/WebKit/WebKit/commit/33e3497f577ec238f2f6766fc43cae9c2496aac9
  Author: Don Olmstead 
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/MathCommon.h

  Log Message:
  ---
  Fix MSVC warning in MathCommon
https://bugs.webkit.org/show_bug.cgi?id=271835

Reviewed by Yusuke Suzuki.

In `toIntImpl` a warning, C4334, is emitted because MSVC is implicitly
converting the result of a 32-bit shift to 64-bit. By making an explicit
cast the warning is silenced.

* Source/JavaScriptCore/runtime/MathCommon.h:

Canonical link: https://commits.webkit.org/276799@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 38c6ec: Non-unified build fixes, early March 2024 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38c6ecad0ea32e80cb3e811c3ff759074006791f
  
https://github.com/WebKit/WebKit/commit/38c6ecad0ea32e80cb3e811c3ff759074006791f
  Author: Don Olmstead 
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
M Source/JavaScriptCore/jit/JITSizeStatistics.cpp
M Source/WebCore/Modules/model-element/ModelPlayerClient.h
M Source/WebCore/css/CSSCrossfadeValue.h
M Source/WebCore/css/CSSImageSetOptionValue.cpp
M Source/WebCore/css/CSSImageSetOptionValue.h
M Source/WebCore/css/CSSReflectValue.cpp
M Source/WebCore/css/CSSReflectValue.h
M Source/WebCore/css/CSSShadowValue.h
M Source/WebCore/css/CSSValuePair.cpp
M Source/WebCore/css/CSSValuePair.h
M Source/WebCore/dom/SlotAssignment.h
M Source/WebCore/dom/TrustedType.cpp
M Source/WebCore/rendering/svg/RenderSVGPath.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp
M Source/WebKit/Shared/WebGPU/WebGPURenderPassDepthStencilAttachment.cpp
M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
M Source/WebKit/UIProcess/FrameProcess.cpp
M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp

  Log Message:
  ---
  Non-unified build fixes, early March 2024 edition
https://bugs.webkit.org/show_bug.cgi?id=270719

Unreviewed non-unified build fix.

* Source/JavaScriptCore/jit/JITSizeStatistics.cpp:
* Source/WebCore/Modules/model-element/ModelPlayerClient.h:
* Source/WebCore/css/CSSCrossfadeValue.h:
* Source/WebCore/css/CSSImageSetOptionValue.cpp:
* Source/WebCore/css/CSSImageSetOptionValue.h:
* Source/WebCore/css/CSSReflectValue.cpp:
* Source/WebCore/css/CSSReflectValue.h:
* Source/WebCore/css/CSSShadowValue.h:
* Source/WebCore/css/CSSValuePair.cpp:
* Source/WebCore/css/CSSValuePair.h:
* Source/WebCore/dom/SlotAssignment.h:
* Source/WebCore/dom/TrustedType.cpp:
* Source/WebCore/rendering/svg/RenderSVGPath.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp:
* Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp:
* Source/WebKit/Shared/WebGPU/WebGPURenderPassDepthStencilAttachment.cpp:
* Source/WebKit/UIProcess/BrowsingContextGroup.cpp:
* Source/WebKit/UIProcess/FrameProcess.cpp:
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:

Canonical link: https://commits.webkit.org/275863@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9217a2: Fix Windows debug build after 275825@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9217a22a4000c04ee2da5624fc38b58415701a84
  
https://github.com/WebKit/WebKit/commit/9217a22a4000c04ee2da5624fc38b58415701a84
  Author: Don Olmstead 
  Date:   2024-03-08 (Fri, 08 Mar 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp

  Log Message:
  ---
  Fix Windows debug build after 275825@main
https://bugs.webkit.org/show_bug.cgi?id=270720

Unreviewed build fix.

Add a missing `HAVE(IOSURFACE)` guard.

* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

Canonical link: https://commits.webkit.org/275860@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] de89f2: [Skia] Stub out BackingStore implementation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de89f2977a314e5ddbe49384e35b953061d17f29
  
https://github.com/WebKit/WebKit/commit/de89f2977a314e5ddbe49384e35b953061d17f29
  Author: Don Olmstead 
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
M Source/WebKit/Platform/WC.cmake
M Source/WebKit/UIProcess/BackingStore.h
A Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp

  Log Message:
  ---
  [Skia] Stub out BackingStore implementation
https://bugs.webkit.org/show_bug.cgi?id=270537

Reviewed by Adrian Perez de Castro.

Add a stub of BackingStore when `USE(SKIA)` is turned `ON`. Actual
implementation to come later.

* Source/WebKit/Platform/WC.cmake:
* Source/WebKit/UIProcess/BackingStore.h:
* Source/WebKit/UIProcess/skia/BackingStoreSkia.cpp: Copied from 
Source\WebKit\UIProcess\BackingStore.h.

Canonical link: https://commits.webkit.org/275752@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cc0a3e: Cherry-pick 275381@main (3f4bd57a7ba1). https://bu...

[Don Olmstead]

 missing WebCore::LocalFrame forward
declaration.
* Source/WebCore/platform/MediaDescription.h: Add missing
wtf/text/WTFString.h inclusion, remove the unneeded wtf/Forward.h one.
* Source/WebCore/rendering/RenderViewTransitionCapture.cpp: Add missing
inclusions for ImageOverlayController.h, ImageQualityController.h,
PaintInfo.h, and wtf/IsoMallocInlines.h.
* Source/WebCore/rendering/svg/RenderSVGInlineText.cpp: Add missing
inclusion of RenderObjectInlines.h.
* Source/WebCore/style/Styleable.cpp: Add missing RenderView.h
inclusion.
* Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp: Add missing
Logging.h inclusion.
* Source/WebKit/NetworkProcess/cache/NetworkCacheDataGLib.cpp: Add
missing WebCore:: namespace prefixes to uses of the
WebCore::SharedMemory type.
(WebKit::NetworkCache::Data::tryCreateSharedMemory const):
* Source/WebKit/Shared/WebCompiledContentRuleListData.cpp: Ditto.
(WebKit::WebCompiledContentRuleListData::createDataHandle const):
(WebKit::WebCompiledContentRuleListData::WebCompiledContentRuleListData):
* Source/WebKit/Shared/gtk/WebEventFactory.cpp: Remove unused.
gtkScrollDeltaMultiplier constant.
* Source/WebKit/UIProcess/WebProcessProxy.cpp: Add missing inclusions
for APIPageConfiguration.h and wtf/Scope.h.
* Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp: Remove
unused swipeOverlayShadowOpacity constant.

Canonical link: https://commits.webkit.org/275381@main


  Commit: e764fa239f8f8832f9a384ed47748f2096499ffa
  
https://github.com/WebKit/WebKit/commit/e764fa239f8f8832f9a384ed47748f2096499ffa
  Author: Don Olmstead 
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
M Source/JavaScriptCore/interpreter/Interpreter.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp
M Source/WebCore/dom/ShadowRoot.h
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexLayout.h
M Source/WebCore/layout/formattingContexts/flex/LogicalFlexItem.h
M Source/WebCore/loader/CrossOriginPreflightChecker.cpp
M Source/WebCore/loader/MixedContentChecker.h
M Source/WebCore/loader/NavigationScheduler.cpp
M Source/WebCore/loader/PingLoader.cpp
M Source/WebCore/loader/ResourceTimingInformation.cpp
M Source/WebCore/loader/cache/CachedSVGFont.h
M Source/WebCore/page/Location.cpp
M Source/WebCore/page/PageConfiguration.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/svg/PatternAttributes.h
M Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp
M Source/WebCore/svg/SVGFEGaussianBlurElement.cpp
M Source/WebCore/svg/SVGGeometryElement.cpp
M Source/WebCore/svg/SVGLengthList.cpp
M Source/WebCore/svg/SVGPolyElement.cpp
M Source/WebCore/svg/SVGTests.cpp
M Source/WebCore/svg/SVGTests.h

  Log Message:
  ---
  Cherry-pick 274593@main (999789c62fb8). 
https://bugs.webkit.org/show_bug.cgi?id=269326

Non-unified build fixes, mid February 2024 edition
https://bugs.webkit.org/show_bug.cgi?id=269326

Unreviewed non-unified build fix.

* Source/JavaScriptCore/interpreter/Interpreter.cpp:
* Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:
* Source/WebCore/css/query/GenericMediaQueryParser.cpp:
* Source/WebCore/dom/ShadowRoot.h:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:
* Source/WebCore/layout/formattingContexts/flex/LogicalFlexItem.h:
* Source/WebCore/loader/CrossOriginPreflightChecker.cpp:
* Source/WebCore/loader/MixedContentChecker.h:
* Source/WebCore/loader/NavigationScheduler.cpp:
* Source/WebCore/loader/PingLoader.cpp:
* Source/WebCore/loader/ResourceTimingInformation.cpp:
* Source/WebCore/loader/cache/CachedSVGFont.h:
* Source/WebCore/page/Location.cpp:
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/platform/graphics/FontPlatformData.h:
* Source/WebCore/platform/graphics/skia/GlyphPageSkia.cpp:
* Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp:
* Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
* Source/WebCore/style/StyleBuilder.cpp:
* Source/WebCore/svg/PatternAttributes.h:
* Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp:
* Source/WebCore/svg/SVGFEGaussianBlurElement.cpp:
* Source/WebCore/svg

[webkit-changes] [WebKit/WebKit] 1c1624: [CMake] Centralize Nicosia sources

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c162458ba708e0aba191d5e2e4b0c81466426d7
  
https://github.com/WebKit/WebKit/commit/1c162458ba708e0aba191d5e2e4b0c81466426d7
  Author: Don Olmstead 
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebCore/SourcesGTK.txt
M Source/WebCore/SourcesWPE.txt
A Source/WebCore/platform/SourcesNicosia.txt
M Source/WebCore/platform/TextureMapper.cmake
M Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp
M Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.h

  Log Message:
  ---
  [CMake] Centralize Nicosia sources
https://bugs.webkit.org/show_bug.cgi?id=269935

Reviewed by Adrian Perez de Castro.

Move `USE(NICOSIA)` sources into `SourcesNicosia.txt`. Some are unable to be
moved because they will break the `USE(SKIA)` build.

Organize the `TextureMapper.cmake` file to check for `USE_NICOSIA`.

Fix some guards around ANGLE code.

* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/SourcesWPE.txt:
* Source/WebCore/platform/SourcesNicosia.txt: Added.
* Source/WebCore/platform/TextureMapper.cmake:
* Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.cpp:
* Source/WebCore/platform/graphics/nicosia/NicosiaGCGLANGLELayer.h:

Canonical link: https://commits.webkit.org/275245@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 90fc60: Fix USE(SKIA) build after 274990@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90fc60406598baad05467ef4bf30dbe721ec281a
  
https://github.com/WebKit/WebKit/commit/90fc60406598baad05467ef4bf30dbe721ec281a
  Author: Don Olmstead 
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
M 
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h

  Log Message:
  ---
  Fix USE(SKIA) build after 274990@main
https://bugs.webkit.org/show_bug.cgi?id=269940

Unreviewed build fix.

Commit forgot to use `WebCore::SkiaAcceleratedBufferPool`.

* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

Canonical link: https://commits.webkit.org/275202@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d5cdf8: Organize Windows Cairo implementation files

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5cdf88dfec9c3bf12861b6a5e806f0e1d6187b8
  
https://github.com/WebKit/WebKit/commit/d5cdf88dfec9c3bf12861b6a5e806f0e1d6187b8
  Author: Don Olmstead 
  Date:   2024-02-17 (Sat, 17 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformWin.cmake
R Source/WebCore/page/win/FrameCairoWin.cpp
M Source/WebCore/page/win/FrameWin.cpp
M Source/WebCore/platform/graphics/win/FontCacheWin.cpp
M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp
R Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp
M Source/WebCore/platform/graphics/win/FontWin.cpp
R Source/WebCore/platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp
A Source/WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp
R Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp
M Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp
M Source/WebCore/platform/graphics/win/ImageAdapterWin.cpp
M Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp
R Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp
M Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp
A Source/WebCore/platform/graphics/win/cairo/FontCacheWinCairo.cpp
A 
Source/WebCore/platform/graphics/win/cairo/FontCustomPlatformDataWinCairo.cpp
A Source/WebCore/platform/graphics/win/cairo/FontPlatformDataWinCairo.cpp
A Source/WebCore/platform/graphics/win/cairo/GraphicsContextWinCairo.cpp
A Source/WebCore/platform/graphics/win/cairo/ImageAdapterWinCairo.cpp
A 
Source/WebCore/platform/graphics/win/cairo/MediaPlayerPrivateMediaFoundationCairo.cpp
R Source/WebCore/platform/win/DragImageCairoWin.cpp
A Source/WebCore/platform/win/cairo/DragImageWinCairo.cpp

  Log Message:
  ---
  Organize Windows Cairo implementation files
https://bugs.webkit.org/show_bug.cgi?id=269593

Reviewed by Brent Fulgham.

Put `PLATFORM(WIN) && USE(CAIRO)` files into a `win/cairo` directory to make
it easier to determine where Cairo specific implementations live. Merge and
remove files that had no Cairo specific implementations but were named as if
they did.

* Source/WebCore/PlatformWin.cmake:
* Source/WebCore/page/win/FrameCairoWin.cpp: Removed.
* Source/WebCore/page/win/FrameWin.cpp:
* Source/WebCore/platform/graphics/win/FontCacheWin.cpp:
* Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp:
* Source/WebCore/platform/graphics/win/FontWin.cpp:
* Source/WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp: Renamed from 
Source/WebCore/platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp.
* Source/WebCore/platform/graphics/win/GraphicsContextWin.cpp:
* Source/WebCore/platform/graphics/win/ImageAdapterWin.cpp:
* Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
* Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp: Removed.
* Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp:
* Source/WebCore/platform/graphics/win/cairo/FontCacheWinCairo.cpp: Copied from 
Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp.
* 
Source/WebCore/platform/graphics/win/cairo/FontCustomPlatformDataWinCairo.cpp: 
Added.
* Source/WebCore/platform/graphics/win/cairo/FontPlatformDataWinCairo.cpp: 
Renamed from Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp.
* Source/WebCore/platform/graphics/win/cairo/GraphicsContextWinCairo.cpp: 
Renamed from Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp.
* Source/WebCore/platform/graphics/win/cairo/ImageAdapterWinCairo.cpp: Copied 
from Source/WebCore/platform/graphics/win/ImageAdapterWin.cpp.
* 
Source/WebCore/platform/graphics/win/cairo/MediaPlayerPrivateMediaFoundationCairo.cpp:
 Added.
* Source/WebCore/platform/win/cairo/DragImageWinCairo.cpp: Renamed from 
Source/WebCore/platform/win/DragImageCairoWin.cpp.

Canonical link: https://commits.webkit.org/274920@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] c9b847: Fix Windows build after 274842@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9b84792fc392b4d3a6d2442f902dabf493fbad2
  
https://github.com/WebKit/WebKit/commit/c9b84792fc392b4d3a6d2442f902dabf493fbad2
  Author: Don Olmstead 
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
M Source/JavaScriptCore/runtime/Options.cpp

  Log Message:
  ---
  Fix Windows build after 274842@main
https://bugs.webkit.org/show_bug.cgi?id=269602

Unreviewed build fix.

Add `ENABLE(UNIFIED_AND_FREEZABLE_CONFIG_RECORD)` guard.

* Source/JavaScriptCore/runtime/Options.cpp:

Canonical link: https://commits.webkit.org/274865@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6619d9: Remove Cairo dependency for BackingStore

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6619d9b70306f0cdf01f83b058ab995df16a4480
  
https://github.com/WebKit/WebKit/commit/6619d9b70306f0cdf01f83b058ab995df16a4480
  Author: Don Olmstead 
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
M Source/WebKit/Platform/WC.cmake
M Source/WebKit/PlatformGTK.cmake
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/PlatformWin.cmake
M Source/WebKit/SourcesGTK.txt
A Source/WebKit/UIProcess/BackingStore.h
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h
R Source/WebKit/UIProcess/cairo/BackingStore.cpp
R Source/WebKit/UIProcess/cairo/BackingStore.h
A Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp
M Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.cpp
M Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.h

  Log Message:
  ---
  Remove Cairo dependency for BackingStore
https://bugs.webkit.org/show_bug.cgi?id=269495

Reviewed by Adrian Perez de Castro.

Both `USE(GRAPHICS_LAYER)` and `USE(CAIRO)` for non-WPE platforms use instances
of `BackingStore`. To prepare for a `USE(SKIA)` implementation of it make the
code more cross-platform by using platform agnostic definitions. Rename and
move files accordingly to fit conventions.

Actual Skia implementation will come later.

* Source/WebKit/Platform/WC.cmake:
* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/PlatformWin.cmake:
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/UIProcess/BackingStore.h: Renamed from 
Source/WebKit/UIProcess/cairo/BackingStore.h.
* 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
* 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h:
* Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp: Renamed from 
Source/WebKit/UIProcess/cairo/BackingStore.cpp.
* Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.cpp:
* Source/WebKit/UIProcess/wc/DrawingAreaProxyWC.h:

Canonical link: https://commits.webkit.org/274823@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 59d807: Fix Skia build after 274746@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59d807d4223310dfc3b68fcd59ab0346a9bf1b56
  
https://github.com/WebKit/WebKit/commit/59d807d4223310dfc3b68fcd59ab0346a9bf1b56
  Author: Don Olmstead 
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
M Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp

  Log Message:
  ---
  Fix Skia build after 274746@main
https://bugs.webkit.org/show_bug.cgi?id=269533

Unreviewed build fix.

Update the method signature of `NativeImage::singlePixelSolidColor`.

* Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:

Canonical link: https://commits.webkit.org/274785@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d06223: Check for USE_CAIRO in PlatformWin.cmake files

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d062230acc064088efd401138f5029b5be1dd6fc
  
https://github.com/WebKit/WebKit/commit/d062230acc064088efd401138f5029b5be1dd6fc
  Author: Don Olmstead 
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformWin.cmake
M Source/WebKit/PlatformWin.cmake
M Tools/ImageDiff/PlatformWin.cmake

  Log Message:
  ---
  Check for USE_CAIRO in PlatformWin.cmake files
https://bugs.webkit.org/show_bug.cgi?id=269500

Reviewed by Fujii Hironori.

Add explicit checks for `USE_CAIRO` in `PlatformWin.cmake` files before
appending Cairo specific build options.

This is in preparation for building with `USE_SKIA` on Windows.

* Source/WebCore/PlatformWin.cmake:
* Source/WebKit/PlatformWin.cmake:
* Tools/ImageDiff/PlatformWin.cmake:

Canonical link: https://commits.webkit.org/274772@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4ce338: Fix guards of WKImageCairo

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ce338dca0934b42ce9d999725f36343c517d707
  
https://github.com/WebKit/WebKit/commit/4ce338dca0934b42ce9d999725f36343c517d707
  Author: Don Olmstead 
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
M Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp

  Log Message:
  ---
  Fix guards of WKImageCairo
https://bugs.webkit.org/show_bug.cgi?id=269414

Reviewed by Adrian Perez de Castro.

Prefer `USE(CAIRO)` over `USE(SKIA)` to guard implementation of API functions
in `WKImageCairo.cpp`.

* Source/WebKit/Shared/API/c/cairo/WKImageCairo.cpp:

Canonical link: https://commits.webkit.org/274745@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 43d104: [CMake] Centralize cURL definitions

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43d1049f80d50d5f3e1ca94adf21fb82df8edb64
  
https://github.com/WebKit/WebKit/commit/43d1049f80d50d5f3e1ca94adf21fb82df8edb64
  Author: Don Olmstead 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
A Source/WebKit/Platform/Curl.cmake
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/PlatformWin.cmake

  Log Message:
  ---
  [CMake] Centralize cURL definitions
https://bugs.webkit.org/show_bug.cgi?id=269424

Reviewed by Fujii Hironori.

Share `USE(CURL)` build definitions between ports.

* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/PlatformWin.cmake:
* Source/WebKit/Platform/Curl.cmake: Added.

Canonical link: https://commits.webkit.org/274681@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] b23842: [CMake] Support USE(SKIA) build on PlayStation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b2384277ae56839abfca022f4c70fdf6f9b38cc3
  
https://github.com/WebKit/WebKit/commit/b2384277ae56839abfca022f4c70fdf6f9b38cc3
  Author: Don Olmstead 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebKit/GPUProcess/EntryPoint/playstation/GPUProcessMain.cpp
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp
M Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp
M Source/cmake/OptionsPlayStation.cmake
M Tools/MiniBrowser/playstation/CMakeLists.txt
M Tools/MiniBrowser/playstation/WebViewWindow.cpp
M Tools/MiniBrowser/playstation/main.cpp
M Tools/TestWebKitAPI/playstation/main.cpp
M Tools/WebKitTestRunner/PlatformPlayStation.cmake

  Log Message:
  ---
  [CMake] Support USE(SKIA) build on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=269250

Reviewed by Fujii Hironori.

Handle the `USE(SKIA)` case within the PlayStation build of WebKit. Modify the
build to handle both `USE(CAIRO)` and `USE(SKIA)`. Guard more code with
`USE(CAIRO)`.

Cairo has to be used when building the MiniBrowser at this time so also support
that.

Building Skia itself in a cross platform way will be in separate patches.

* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebKit/GPUProcess/EntryPoint/playstation/GPUProcessMain.cpp:
(main):
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/UIProcess/API/C/playstation/WKPagePrivatePlayStation.cpp:
(WKPagePaint):
* Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp:
(main):
* Source/cmake/OptionsPlayStation.cmake:
* Tools/MiniBrowser/playstation/CMakeLists.txt:
* Tools/MiniBrowser/playstation/WebViewWindow.cpp:
(WebViewWindow::setSize):
(WebViewWindow::paintSelf):
* Tools/MiniBrowser/playstation/main.cpp:
(initialize):
* Tools/TestWebKitAPI/playstation/main.cpp:
(main):
* Tools/WebKitTestRunner/PlatformPlayStation.cmake:

Canonical link: https://commits.webkit.org/274675@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 424698: [CMake] Centralize WC definitions

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42469865934158548fa1313cba5520571f041ec3
  
https://github.com/WebKit/WebKit/commit/42469865934158548fa1313cba5520571f041ec3
  Author: Don Olmstead 
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformWin.cmake
M Source/WebCore/platform/TextureMapper.cmake
A Source/WebKit/Platform/WC.cmake
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/PlatformWin.cmake

  Log Message:
  ---
  [CMake] Centralize WC definitions
https://bugs.webkit.org/show_bug.cgi?id=269407

Reviewed by Fujii Hironori.

Share `USE(GRAPHICS_LAYER_WC)` build definitions between ports.

* Source/WebCore/PlatformWin.cmake:
* Source/WebCore/platform/TextureMapper.cmake:
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/PlatformWin.cmake:
* Source/WebKit/Platform/WC.cmake: Added.

Canonical link: https://commits.webkit.org/274672@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 999789: Non-unified build fixes, mid February 2024 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 999789c62fb87d37c028375e78ab4363ed2146fa
  
https://github.com/WebKit/WebKit/commit/999789c62fb87d37c028375e78ab4363ed2146fa
  Author: Don Olmstead 
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
M Source/JavaScriptCore/interpreter/Interpreter.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp
M Source/WebCore/css/query/GenericMediaQueryParser.cpp
M Source/WebCore/dom/ShadowRoot.h
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexLayout.h
M Source/WebCore/layout/formattingContexts/flex/LogicalFlexItem.h
M Source/WebCore/loader/CrossOriginPreflightChecker.cpp
M Source/WebCore/loader/MixedContentChecker.h
M Source/WebCore/loader/NavigationScheduler.cpp
M Source/WebCore/loader/PingLoader.cpp
M Source/WebCore/loader/ResourceTimingInformation.cpp
M Source/WebCore/loader/cache/CachedSVGFont.h
M Source/WebCore/page/Location.cpp
M Source/WebCore/page/PageConfiguration.h
M Source/WebCore/platform/graphics/FontPlatformData.h
M Source/WebCore/platform/graphics/skia/GlyphPageSkia.cpp
M Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp
M Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.h
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/svg/PatternAttributes.h
M Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp
M Source/WebCore/svg/SVGFEGaussianBlurElement.cpp
M Source/WebCore/svg/SVGGeometryElement.cpp
M Source/WebCore/svg/SVGLengthList.cpp
M Source/WebCore/svg/SVGPolyElement.cpp
M Source/WebCore/svg/SVGTests.cpp
M Source/WebCore/svg/SVGTests.h

  Log Message:
  ---
  Non-unified build fixes, mid February 2024 edition
https://bugs.webkit.org/show_bug.cgi?id=269326

Unreviewed non-unified build fix.

* Source/JavaScriptCore/interpreter/Interpreter.cpp:
* Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:
* Source/WebCore/css/query/GenericMediaQueryParser.cpp:
* Source/WebCore/dom/ShadowRoot.h:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:
* Source/WebCore/layout/formattingContexts/flex/LogicalFlexItem.h:
* Source/WebCore/loader/CrossOriginPreflightChecker.cpp:
* Source/WebCore/loader/MixedContentChecker.h:
* Source/WebCore/loader/NavigationScheduler.cpp:
* Source/WebCore/loader/PingLoader.cpp:
* Source/WebCore/loader/ResourceTimingInformation.cpp:
* Source/WebCore/loader/cache/CachedSVGFont.h:
* Source/WebCore/page/Location.cpp:
* Source/WebCore/page/PageConfiguration.h:
* Source/WebCore/platform/graphics/FontPlatformData.h:
* Source/WebCore/platform/graphics/skia/GlyphPageSkia.cpp:
* Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.cpp:
* Source/WebCore/platform/graphics/skia/ImageBufferUtilitiesSkia.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:
* Source/WebCore/style/StyleBuilder.cpp:
* Source/WebCore/svg/PatternAttributes.h:
* Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp:
* Source/WebCore/svg/SVGFEGaussianBlurElement.cpp:
* Source/WebCore/svg/SVGGeometryElement.cpp:
* Source/WebCore/svg/SVGLengthList.cpp:
* Source/WebCore/svg/SVGPolyElement.cpp:
* Source/WebCore/svg/SVGTests.cpp:
* Source/WebCore/svg/SVGTests.h:

Canonical link: https://commits.webkit.org/274593@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ac6651: Fix PlayStation build after 274563@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ac6651e9b0a03419e538dc8150681f03586c8f91
  
https://github.com/WebKit/WebKit/commit/ac6651e9b0a03419e538dc8150681f03586c8f91
  Author: Don Olmstead 
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
M Source/WebCore/platform/SharedBuffer.cpp

  Log Message:
  ---
  Fix PlayStation build after 274563@main
https://bugs.webkit.org/show_bug.cgi?id=269325

Unreviewed build fix.

A non-unified build issue manifesting on PlayStation due to the grouping of
generated unified sources.

* Source/WebCore/platform/SharedBuffer.cpp:

Canonical link: https://commits.webkit.org/274588@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2987fc: [CMake] Remove use of FORWARDING_HEADERS_DIR in Sk...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2987fca511f4c697b7c28edf6c4396dc8e923de7
  
https://github.com/WebKit/WebKit/commit/2987fca511f4c697b7c28edf6c4396dc8e923de7
  Author: Don Olmstead 
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
M Source/ThirdParty/skia/CMakeLists.txt
M Source/cmake/WebKitFS.cmake

  Log Message:
  ---
  [CMake] Remove use of FORWARDING_HEADERS_DIR in Skia build
https://bugs.webkit.org/show_bug.cgi?id=269313

Reviewed by Adrian Perez de Castro.

Add `Skia_FRAMEWORK_HEADERS_DIR` to `WebKitFS.cmake` and use that instead of
`FORWARDING_HEADERS_DIR`.

* Source/ThirdParty/skia/CMakeLists.txt:
* Source/cmake/WebKitFS.cmake:

Canonical link: https://commits.webkit.org/274572@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 0bb4f2: Guard BackingStore with USE(CAIRO)

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0bb4f2e6550c70d93fbd0a3b4e6c0967e3cadd7e
  
https://github.com/WebKit/WebKit/commit/0bb4f2e6550c70d93fbd0a3b4e6c0967e3cadd7e
  Author: Don Olmstead 
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
M 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h

  Log Message:
  ---
  Guard BackingStore with USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=269252

Reviewed by Adrian Perez de Castro.

In `DrawingAreaProxyCoordinatedGraphics` the use of `BackingStore` was just
checking for `!PLATFORM(WPE)`. Compiling with `USE_CAIRO` to `OFF` would fail
so update the guard to also check for cairo.

* 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
* 
Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h:

Canonical link: https://commits.webkit.org/274541@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cd2168: Guard use of libepoxy in NicosiaBuffer

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd2168b7c91387292e7f15f23ebd7466e1c5f012
  
https://github.com/WebKit/WebKit/commit/cd2168b7c91387292e7f15f23ebd7466e1c5f012
  Author: Don Olmstead 
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp

  Log Message:
  ---
  Guard use of libepoxy in NicosiaBuffer
https://bugs.webkit.org/show_bug.cgi?id=269254

Reviewed by Adrian Perez de Castro.

Include OpenGL headers from libepoxy if present, otherwise include OpenGL ES3
header directly.

* Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:

Canonical link: https://commits.webkit.org/274537@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2cc8f7: Fix PlayStation WPE build of WebKitTestRunner

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cc8f74ab704eb21c09d89ffce90367aee307f03
  
https://github.com/WebKit/WebKit/commit/2cc8f74ab704eb21c09d89ffce90367aee307f03
  Author: Don Olmstead 
  Date:   2024-02-12 (Mon, 12 Feb 2024)

  Changed paths:
A 
Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityControllerPlayStation.cpp
A 
Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp
M Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp
M Tools/WebKitTestRunner/PlatformPlayStation.cmake
M Tools/WebKitTestRunner/libwpe/EventSenderProxyLibWPE.cpp
M Tools/WebKitTestRunner/libwpe/PlatformWebViewLibWPE.cpp

  Log Message:
  ---
  Fix PlayStation WPE build of WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=269247

Reviewed by Fujii Hironori.

Add stubs for the accessibility within the InjectedBundle for PlayStation. Fix
a typo in `AccessibilityUIElementWin.cpp` while there.

Include additional libWPE files to the build and guard `ENABLE(WPE_PLATFORM)`.

* 
Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityControllerPlayStation.cpp:
 Added.
* 
Tools/WebKitTestRunner/InjectedBundle/playstation/AccessibilityUIElementPlayStation.cpp:
 Copied from 
Tools\WebKitTestRunner\InjectedBundle\win\AccessibilityUIElementWin.cpp.
* Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
* Tools/WebKitTestRunner/PlatformPlayStation.cmake:
* Tools/WebKitTestRunner/libwpe/EventSenderProxyLibWPE.cpp:
* Tools/WebKitTestRunner/libwpe/PlatformWebViewLibWPE.cpp:

Canonical link: https://commits.webkit.org/274509@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 50cdbe: [CMake] Expand USE_AVIF option

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50cdbe4cc19b7ca000e3b01cbe21e4bfde4bb5c3
  
https://github.com/WebKit/WebKit/commit/50cdbe4cc19b7ca000e3b01cbe21e4bfde4bb5c3
  Author: Don Olmstead 
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
M Source/cmake/OptionsWin.cmake
M Source/cmake/WebKitFeatures.cmake
M Tools/Scripts/webkitperl/FeatureList.pm

  Log Message:
  ---
  [CMake] Expand USE_AVIF option
https://bugs.webkit.org/show_bug.cgi?id=269036

Reviewed by Michael Catanzaro.

Add `--avif` option to `FeatureList.pm`. Standardize error messaging when the
library isn't found.

* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: https://commits.webkit.org/274378@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2c0eb7: [CMake] Centralize USE_WOFF2 option

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c0eb789a8806259d6264c949b27fbabb62a2a1a
  
https://github.com/WebKit/WebKit/commit/2c0eb789a8806259d6264c949b27fbabb62a2a1a
  Author: Don Olmstead 
  Date:   2024-02-09 (Fri, 09 Feb 2024)

  Changed paths:
M Source/WebCore/CMakeLists.txt
M Source/cmake/OptionsGTK.cmake
M Source/cmake/OptionsPlayStation.cmake
M Source/cmake/OptionsWPE.cmake
M Source/cmake/OptionsWin.cmake
M Source/cmake/WebKitFeatures.cmake
M Tools/Scripts/webkitperl/FeatureList.pm

  Log Message:
  ---
  [CMake] Centralize USE_WOFF2 option
https://bugs.webkit.org/show_bug.cgi?id=269031

Reviewed by Michael Catanzaro.

The `USE_WOFF2` option is common to almost all CMake ports so move the option
into `WebKitFeatures.cmake` and provide a flag in `FeatureList.pm`. Set the
default value for all CMake ports. Modify the `find_package` logic so its the
same across all ports.

PlayStation port uses WOFF2 support within FreeType so turn it `OFF`.

* Source/WebCore/CMakeLists.txt:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: https://commits.webkit.org/274370@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a6f41e: [CMake] Expand USE_JPEGXL option

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6f41eca20868ff40313c77902ee68cce7229163
  
https://github.com/WebKit/WebKit/commit/a6f41eca20868ff40313c77902ee68cce7229163
  Author: Don Olmstead 
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
M Source/WebCore/platform/ImageDecoders.cmake
M Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp
M Source/cmake/OptionsPlayStation.cmake
M Source/cmake/OptionsWin.cmake
M Source/cmake/WebKitFeatures.cmake
M Tools/Scripts/webkitperl/FeatureList.pm
M Tools/TestWebKitAPI/playstation/main.cpp

  Log Message:
  ---
  [CMake] Expand USE_JPEGXL option
https://bugs.webkit.org/show_bug.cgi?id=269030

Reviewed by Fujii Hironori.

Add `--jpegxl` option to `FeatureList.pm`. Look for libjxl on PlayStation when
requested, and handle loading of it as a module. Standardize error messaging
and fix an if statement's check.

* Source/WebCore/platform/ImageDecoders.cmake:
* Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp:
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:
* Tools/TestWebKitAPI/playstation/main.cpp:

Canonical link: https://commits.webkit.org/274341@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6f3176: [CMake] Centralize USE_LCMS option

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f31760639683d3f79253fc06ca49988fc352e5f
  
https://github.com/WebKit/WebKit/commit/6f31760639683d3f79253fc06ca49988fc352e5f
  Author: Don Olmstead 
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp
M Source/cmake/OptionsGTK.cmake
M Source/cmake/OptionsPlayStation.cmake
M Source/cmake/OptionsWPE.cmake
M Source/cmake/OptionsWin.cmake
M Source/cmake/WebKitFeatures.cmake
M Tools/Scripts/webkitperl/FeatureList.pm
M Tools/TestWebKitAPI/playstation/main.cpp

  Log Message:
  ---
  [CMake] Centralize USE_LCMS option
https://bugs.webkit.org/show_bug.cgi?id=269002

Reviewed by Michael Catanzaro.

The `USE_LCMS` option is common to all CMake ports so move the definition into
`WebKitFeatures.cmake` and provide a flag in `FeatureList.pm`. Set the default
value for all CMake ports. Modify the `find_package` logic so its the same for
all ports. Add additional PlayStation code for loading the module.

* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:
* Tools/TestWebKitAPI/playstation/main.cpp:

Canonical link: https://commits.webkit.org/274330@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a438e5: Remove OpenJPEG bits missed in 273978@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a438e5e3cebe9027a886ccf0ebf23fe115421798
  
https://github.com/WebKit/WebKit/commit/a438e5e3cebe9027a886ccf0ebf23fe115421798
  Author: Don Olmstead 
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
R Source/cmake/FindOpenJPEG.cmake
M Source/cmake/OptionsWin.cmake

  Log Message:
  ---
  Remove OpenJPEG bits missed in 273978@main
https://bugs.webkit.org/show_bug.cgi?id=269015

Reviewed by Michael Catanzaro.

Remove the find module for OpenJPEG and the reference to it in
`OptionsWin.cmake`.

* Source/cmake/FindOpenJPEG.cmake: Removed.
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/274328@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4480a4: Remove WebP compile guards

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4480a4c3b55fd801f475f131d77145a3085b7eb5
  
https://github.com/WebKit/WebKit/commit/4480a4c3b55fd801f475f131d77145a3085b7eb5
  Author: Don Olmstead 
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
M Source/WTF/wtf/PlatformHave.h
M Source/WTF/wtf/PlatformUse.h
M Source/WebCore/loader/cache/CachedResourceRequest.cpp
M Source/WebCore/platform/ImageDecoders.cmake
M Source/WebCore/platform/MIMETypeRegistry.cpp
M Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp
M Source/WebCore/platform/graphics/cg/UTIRegistry.cpp
M Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp
M Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp
M Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h
M Source/cmake/OptionsPlayStation.cmake
M Source/cmake/OptionsWin.cmake

  Log Message:
  ---
  Remove WebP compile guards
https://bugs.webkit.org/show_bug.cgi?id=269007

Reviewed by Said Abou-Hallawa.

All WebKit ports support WebP so remove the `USE_WEBP` for CMake ports and
`HAVE_WEBP` for Apple ports.

* Source/WTF/wtf/PlatformHave.h:
* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/loader/cache/CachedResourceRequest.cpp:
* Source/WebCore/platform/ImageDecoders.cmake:
* Source/WebCore/platform/MIMETypeRegistry.cpp:
* Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:
* Source/WebCore/platform/graphics/cg/UTIRegistry.cpp:
* Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp:
* Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.cpp:
* Source/WebCore/platform/image-decoders/webp/WEBPImageDecoder.h:
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/274327@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1355e3: Fix PlayStation WPE build after 273021@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1355e3b4246f4975cf8be09a1e0ecb891d26e5f8
  
https://github.com/WebKit/WebKit/commit/1355e3b4246f4975cf8be09a1e0ecb891d26e5f8
  Author: Don Olmstead 
  Date:   2024-02-07 (Wed, 07 Feb 2024)

  Changed paths:
M Tools/wpe/backends/PlatformPlayStation.cmake
M Tools/wpe/backends/PlatformWPE.cmake
M Tools/wpe/backends/ViewBackend.h
A Tools/wpe/backends/playstation/ViewBackendPlayStation.cpp

  Log Message:
  ---
  Fix PlayStation WPE build after 273021@main
https://bugs.webkit.org/show_bug.cgi?id=268935

Reviewed by Michael Catanzaro.

In 273021@main `ENABLE_ACCESSIBILITY` was removed. This broke the WPE
Backend PlayStation build because some methods were not present. Add those
methods into the build. Guard against ATK types being used.

* Tools/wpe/backends/PlatformPlayStation.cmake:
* Tools/wpe/backends/PlatformWPE.cmake:
* Tools/wpe/backends/ViewBackend.h:
* Tools/wpe/backends/playstation/ViewBackendPlayStation.cpp: Added.

Canonical link: https://commits.webkit.org/274250@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 72a370: [CMake] Centralize ShareableBitmapCairo.cpp build

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72a37094553f4d862bd524136db05f761ad462cf
  
https://github.com/WebKit/WebKit/commit/72a37094553f4d862bd524136db05f761ad462cf
  Author: Don Olmstead 
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
M Source/WebCore/PlatformPlayStation.cmake
M Source/WebCore/PlatformWin.cmake
M Source/WebCore/SourcesGTK.txt
M Source/WebCore/SourcesWPE.txt
M Source/WebCore/platform/SourcesCairo.txt

  Log Message:
  ---
  [CMake] Centralize ShareableBitmapCairo.cpp build
https://bugs.webkit.org/show_bug.cgi?id=268648

Reviewed by Chris Dumez.

Clean up CMake changes in 273995@main so they're in `Cairo.cmake`
instead of individual port definitions.

* Source/WebCore/PlatformPlayStation.cmake:
* Source/WebCore/PlatformWin.cmake:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/SourcesWPE.txt:
* Source/WebCore/platform/SourcesCairo.txt:

Canonical link: https://commits.webkit.org/274026@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 91c1a5: Non-unified build fixes, early February 2024 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91c1a5ef6fbb412d867b06761133dfded7e286a5
  
https://github.com/WebKit/WebKit/commit/91c1a5ef6fbb412d867b06761133dfded7e286a5
  Author: Don Olmstead 
  Date:   2024-02-02 (Fri, 02 Feb 2024)

  Changed paths:
M Source/WebCore/dom/EventTargetConcrete.cpp
M Source/WebCore/fileapi/FileReader.cpp
M Source/WebCore/html/VoidCallback.h
M Source/WebCore/html/parser/HTMLResourcePreloader.cpp
M Source/WebCore/html/track/VideoTrackList.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentCache.h
M Source/WebCore/loader/LinkLoader.cpp
M Source/WebCore/loader/MediaResourceLoader.cpp
M Source/WebCore/loader/PingLoader.cpp
M Source/WebCore/loader/TextTrackLoader.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/rendering/svg/RenderSVGPath.cpp
M Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp
M Source/WebCore/style/StylePendingResources.cpp
M Source/WebCore/style/StyleScopeRuleSets.cpp
M Source/WebCore/style/StyleSheetContentsCache.cpp
M Source/WebCore/style/StyleSheetContentsCache.h
M Source/WebCore/svg/SVGTitleElement.cpp
M Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp
M Source/WebCore/xml/XMLHttpRequestUpload.cpp
M Source/WebCore/xml/XSLStyleSheetLibxslt.cpp
M Source/WebCore/xml/XSLTProcessorLibxslt.cpp
M Source/WebKit/GPUProcess/GPUProcess.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.h
M Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteNativeImageBackendProxy.h
M Source/WebKit/WebProcess/GPU/media/RemoteMediaResourceProxy.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.cpp

  Log Message:
  ---
  Non-unified build fixes, early February 2024 edition
https://bugs.webkit.org/show_bug.cgi?id=268592

Unreviewed non-unified build fix.

* Source/WebCore/dom/EventTargetConcrete.cpp:
* Source/WebCore/fileapi/FileReader.cpp:
* Source/WebCore/html/VoidCallback.h:
* Source/WebCore/html/parser/HTMLResourcePreloader.cpp:
* Source/WebCore/html/track/VideoTrackList.cpp:
* Source/WebCore/layout/formattingContexts/inline/InlineContentCache.h:
* Source/WebCore/loader/LinkLoader.cpp:
* Source/WebCore/loader/MediaResourceLoader.cpp:
* Source/WebCore/loader/PingLoader.cpp:
* Source/WebCore/loader/TextTrackLoader.cpp:
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
* Source/WebCore/rendering/svg/RenderSVGPath.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp:
* Source/WebCore/style/StylePendingResources.cpp:
* Source/WebCore/style/StyleScopeRuleSets.cpp:
* Source/WebCore/style/StyleSheetContentsCache.cpp:
* Source/WebCore/style/StyleSheetContentsCache.h:
* Source/WebCore/svg/SVGTitleElement.cpp:
* Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp:
* Source/WebCore/xml/XMLHttpRequestUpload.cpp:
* Source/WebCore/xml/XSLStyleSheetLibxslt.cpp:
* Source/WebCore/xml/XSLTProcessorLibxslt.cpp:
* Source/WebKit/GPUProcess/GPUProcess.cpp:
* Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp:
* Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.h:
* Source/WebKit/WebProcess/Cache/WebCacheStorageConnection.cpp:
* Source/WebKit/WebProcess/GPU/graphics/RemoteNativeImageBackendProxy.h:
* Source/WebKit/WebProcess/GPU/media/RemoteMediaResourceProxy.cpp:
* Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:

Canonical link: https://commits.webkit.org/274008@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e45afd: Generate serialization of WCBackingStore

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e45afd87e47f85c70bd314c8a22de09f2c31e010
  
https://github.com/WebKit/WebKit/commit/e45afd87e47f85c70bd314c8a22de09f2c31e010
  Author: Don Olmstead 
  Date:   2024-02-01 (Thu, 01 Feb 2024)

  Changed paths:
M Source/WebKit/PlatformWin.cmake
A Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.cpp
M Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.h
A Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.serialization.in

  Log Message:
  ---
  Generate serialization of WCBackingStore
https://bugs.webkit.org/show_bug.cgi?id=268502

Reviewed by Alex Christensen.

Modify `WCBackingStore` so its serialization can be generated. Pass an
`ImageBufferBackendHandle` through IPC. Add a constructor to create from
a handle, and a method to retrieve a handle from an instance. Adding
these allows the serialization framework to work on the class.

* Source/WebKit/PlatformWin.cmake:
* Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.cpp: Copied from 
Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.h.
(WebKit::WCBackingStore::WCBackingStore):
(WebKit::WCBackingStore::handle const):
* Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.h:
(WebKit::WCBackingStore::encode const): Deleted.
(WebKit::WCBackingStore::decode): Deleted.
* Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.serialization.in: Added.

Canonical link: https://commits.webkit.org/273938@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e6e6c0: Refactor WCLayerUpdateInfo for serialization

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6e6c08dd097ff75e620ca93f357af5cabb65a8a
  
https://github.com/WebKit/WebKit/commit/e6e6c08dd097ff75e620ca93f357af5cabb65a8a
  Author: Don Olmstead 
  Date:   2024-01-31 (Wed, 31 Jan 2024)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp
M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp
M Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h
M Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in

  Log Message:
  ---
  Refactor WCLayerUpdateInfo for serialization
https://bugs.webkit.org/show_bug.cgi?id=267968

Reviewed by Chris Dumez.

Modify `WCLayerUpdateInfo` so it's serialization can be generated. The
values to serialize in an instance are controlled by an `OptionSet`.
The generator supports this through `OptionalTupleBit` but it expects
one field per enumeration which is not the case for `WCLayerUpdateInfo`.
Group those fields together into nested structs and sort the fields by
the value of `WCLayerChange` they correspond to.

The actual serialization of `WCLayerUpdateInfo` will come in a separate
change.

* Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp:
(WebKit::WCScene::update):
* Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp:
(WebKit::GraphicsLayerWC::flushCompositingStateForThisLayerOnly):
* Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.h:
(WebKit::WCLayerUpdateInfo::encode const):
(WebKit::WCLayerUpdateInfo::decode):
* Source/WebKit/WebProcess/WebPage/wc/WCUpdateInfo.serialization.in:

Canonical link: https://commits.webkit.org/273839@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] e9271e: Optionally support AVIF on Windows

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9271eae9cb9a6fbb46598c171dc1b3d927813e3
  
https://github.com/WebKit/WebKit/commit/e9271eae9cb9a6fbb46598c171dc1b3d927813e3
  Author: Don Olmstead 
  Date:   2024-01-30 (Tue, 30 Jan 2024)

  Changed paths:
M Source/WebCore/platform/win/MIMETypeRegistryWin.cpp
M Source/cmake/OptionsWin.cmake

  Log Message:
  ---
  Optionally support AVIF on Windows
https://bugs.webkit.org/show_bug.cgi?id=268328

Reviewed by Fujii Hironori.

Check for the presence of `libavif` on Windows and if found set
`USE_AVIF` to `ON`. WebKitRequirements at this will not be shipping a
built `libavif` so it is grouped with the other optional libraries.

* Source/WebCore/platform/win/MIMETypeRegistryWin.cpp:
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/273771@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 9c4ef3: [JSCOnly] Support building jsc.exe with dynamic JS...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c4ef355f719b6d4cf19586af9e56f048dcf2bb9
  
https://github.com/WebKit/WebKit/commit/9c4ef355f719b6d4cf19586af9e56f048dcf2bb9
  Author: Don Olmstead 
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
M Source/cmake/OptionsJSCOnly.cmake

  Log Message:
  ---
  [JSCOnly] Support building jsc.exe with dynamic JSC library on Windows
https://bugs.webkit.org/show_bug.cgi?id=172862

Reviewed by Yusuke Suzuki.

Turn on support for a `SHARED` JavaScriptCore on Windows.

* Source/cmake/OptionsJSCOnly.cmake:

Canonical link: https://commits.webkit.org/273589@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a04c3b: Setup MASM CMake support

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a04c3b4e0a4efaa58576a7e106ba5cdfa18b19bb
  
https://github.com/WebKit/WebKit/commit/a04c3b4e0a4efaa58576a7e106ba5cdfa18b19bb
  Author: Don Olmstead 
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
M Source/WTF/wtf/CMakeLists.txt
M Source/WTF/wtf/PlatformWin.cmake
M Source/cmake/OptionsMSVC.cmake

  Log Message:
  ---
  Setup MASM CMake support
https://bugs.webkit.org/show_bug.cgi?id=268188

Reviewed by Yusuke Suzuki.

Centralize the MASM setup within `OptionsMSVC.cmake`. Override the MASM
compile command to prevent unsupported flags from `add_compile_options`
and `add_definitions` from being passed to the assembler.

Remove custom commands for compiling the MASM files and add them like
normal sources. Move the compilation in WTF into the main
`CMakeLists.txt`. Simplify code to account for x86 being C loop only.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WTF/wtf/PlatformWin.cmake:
* Source/cmake/OptionsMSVC.cmake:

Canonical link: https://commits.webkit.org/273588@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d954e7: Fix JSCOnly build on Windows

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d954e73a94f82ec4124797dd0bfde18401cb935b
  
https://github.com/WebKit/WebKit/commit/d954e73a94f82ec4124797dd0bfde18401cb935b
  Author: Don Olmstead 
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
M Source/WTF/wtf/PlatformJSCOnly.cmake
M Source/WTF/wtf/Threading.cpp
M Source/cmake/OptionsJSCOnly.cmake

  Log Message:
  ---
  Fix JSCOnly build on Windows
https://bugs.webkit.org/show_bug.cgi?id=268189

Reviewed by Yusuke Suzuki.

Add `win/Win32Handle.cpp` to the source listing for Windows builds.

Fix the guard of `RunLoop::registerRunLoopMessageWindowClass()` which
is `USE(WINDOWS_EVENT_LOOP)` not `OS(WINDOWS)`.

Don't override the default for `ENABLE_WEBASSEMBLY` because it is not
available on x86. It will default to `ON` for x64.

* Source/WTF/wtf/PlatformJSCOnly.cmake:
* Source/WTF/wtf/Threading.cpp:
* Source/cmake/OptionsJSCOnly.cmake:

Canonical link: https://commits.webkit.org/273585@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 561efe: Check curl version for HTTP/3 support

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 561efe11068f9f66bad146080173de5d0b64ee73
  
https://github.com/WebKit/WebKit/commit/561efe11068f9f66bad146080173de5d0b64ee73
  Author: Don Olmstead 
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
M Source/WebCore/platform/network/curl/CurlContext.cpp

  Log Message:
  ---
  Check curl version for HTTP/3 support
https://bugs.webkit.org/show_bug.cgi?id=267868

Reviewed by Basuke Suzuki.

HTTP/3 support is no longer experimental starting from curl version
8.5.0. If the version is that or greater use curl's HTTP/3 support.

Note that the curl library is queried for whether or not HTTP/3 support
was built in so HTTP/3 connections will only be attempted if curl can
handle them.

* Source/WebCore/platform/network/curl/CurlContext.cpp:

Canonical link: https://commits.webkit.org/273520@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 67943c: Non-unified build fixes, late January 2024 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67943cb752bf84af9cdb249ad792f7369f9f0f96
  
https://github.com/WebKit/WebKit/commit/67943cb752bf84af9cdb249ad792f7369f9f0f96
  Author: Don Olmstead 
  Date:   2024-01-24 (Wed, 24 Jan 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/ExpressionInfo.cpp
M Source/JavaScriptCore/bytecode/ExpressionInfo.h
M Source/JavaScriptCore/llint/LLIntThunks.cpp
M Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.h
M Source/WebCore/Modules/WebGPU/GPUOutOfMemoryError.h
M Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h
M 
Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h
M Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h
M Source/WebCore/history/HistoryItem.cpp
M Source/WebCore/html/FormListedElement.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h
M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp
M Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.h

  Log Message:
  ---
  Non-unified build fixes, late January 2024 edition
https://bugs.webkit.org/show_bug.cgi?id=267954

Reviewed by Ryosuke Niwa.

Unreviewed non-unified build fix.

* Source/JavaScriptCore/bytecode/ExpressionInfo.cpp:
* Source/JavaScriptCore/bytecode/ExpressionInfo.h:
* Source/JavaScriptCore/llint/LLIntThunks.cpp:
* Source/JavaScriptCore/runtime/FileBasedFuzzerAgentBase.h:
* Source/WebCore/Modules/WebGPU/GPUOutOfMemoryError.h:
* Source/WebCore/Modules/WebGPU/GPURenderPassColorAttachment.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h:
* Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h:
* Source/WebCore/history/HistoryItem.cpp:
* Source/WebCore/html/FormListedElement.cpp:
* 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:
* Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp:
* Source/WebKit/Shared/WebGPU/WebGPURenderPassColorAttachment.h:

Canonical link: https://commits.webkit.org/273417@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 33a292: Add FELightingSoftwareApplierInlines.h

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33a29269d60facb4b3c80bd33d31c643b8a887e5
  
https://github.com/WebKit/WebKit/commit/33a29269d60facb4b3c80bd33d31c643b8a887e5
  Author: Don Olmstead 
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
M 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp
A 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplierInlines.h
M 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.cpp

  Log Message:
  ---
  Add FELightingSoftwareApplierInlines.h
https://bugs.webkit.org/show_bug.cgi?id=267602

Reviewed by Said Abou-Hallawa.

`FELightingSoftwareApplier::LightingData` struct declares a number of
`inline` methods which were defined in `FELightingSoftwareApplier.cpp`.
However usage outside of the file happened in 272873@main. Unified
builds continued to function because the `.cpp` files using it ended up
in the same compilation unit, but non-unified builds failed with a
linker error.

Move the inlined `FELightingSoftwareApplier::LightingData` methods to
a new file `FELightingSoftwareApplierInlines.h` and include them when
applicable.

* 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp:
* 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplierInlines.h:
 Copied from 
Source\WebCore\platform\graphics\filters\software\FELightingSoftwareApplier.cpp.
* 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.cpp:

Canonical link: https://commits.webkit.org/273112@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1c1922: Non-unified build fixes, mid January 2024 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1c19226f030bcafb4e0796354d3af7aed915f23d
  
https://github.com/WebKit/WebKit/commit/1c19226f030bcafb4e0796354d3af7aed915f23d
  Author: Don Olmstead 
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
M Source/JavaScriptCore/bytecode/CallLinkInfoBase.cpp
M Source/JavaScriptCore/heap/JITStubRoutineSet.h
M Source/JavaScriptCore/jit/JITOperations.cpp
M Source/JavaScriptCore/wasm/WasmCallsiteCollection.cpp
M Source/JavaScriptCore/wasm/WasmOperations.cpp
M Source/WebCore/Modules/gamepad/Gamepad.cpp
M Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
M Source/WebCore/Modules/screen-wake-lock/WakeLockSentinel.cpp
M Source/WebCore/css/CSSSelector.cpp
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/dom/ConstantPropertyMap.h
M Source/WebCore/dom/ExtensionStyleSheets.h
M Source/WebCore/dom/RejectedPromiseTracker.cpp
M Source/WebCore/dom/ScriptRunner.h
M Source/WebCore/dom/SimulatedClick.cpp
M Source/WebCore/dom/WheelEvent.cpp
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/html/track/TextTrackCueGeneric.cpp
M Source/WebCore/layout/formattingContexts/table/TableGrid.h
M 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.cpp
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp
M Source/WebCore/rendering/svg/RenderSVGShape.cpp
M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
M Source/WebCore/svg/SVGTextPathElement.cpp
M 
Source/WebCore/workers/service/background-fetch/BackgroundFetchRegistration.cpp
M Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp
M Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp
M Source/WebKit/UIProcess/RemotePageProxy.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp

  Log Message:
  ---
  Non-unified build fixes, mid January 2024 edition
https://bugs.webkit.org/show_bug.cgi?id=266437

Unreviewed non-unified build fix.

* Source/JavaScriptCore/bytecode/CallLinkInfoBase.cpp:
* Source/JavaScriptCore/heap/JITStubRoutineSet.h:
* Source/JavaScriptCore/jit/JITOperations.cpp:
* Source/JavaScriptCore/wasm/WasmCallsiteCollection.cpp:
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
* Source/WebCore/Modules/gamepad/Gamepad.cpp:
* Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:
* Source/WebCore/Modules/screen-wake-lock/WakeLockSentinel.cpp:
* Source/WebCore/css/CSSSelector.cpp:
* Source/WebCore/css/StyleRule.cpp:
* Source/WebCore/dom/ConstantPropertyMap.h:
* Source/WebCore/dom/ExtensionStyleSheets.h:
* Source/WebCore/dom/RejectedPromiseTracker.cpp:
* Source/WebCore/dom/ScriptRunner.h:
* Source/WebCore/dom/SimulatedClick.cpp:
* Source/WebCore/dom/WheelEvent.cpp:
* Source/WebCore/html/HTMLElement.cpp:
* Source/WebCore/html/track/TextTrackCueGeneric.cpp:
* Source/WebCore/layout/formattingContexts/table/TableGrid.h:
* 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareParallelApplier.cpp:
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceLinearGradient.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceRadialGradient.cpp:
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
* Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:
* Source/WebCore/svg/SVGTextPathElement.cpp:
* 
Source/WebCore/workers/service/background-fetch/BackgroundFetchRegistration.cpp:
* Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp:
* Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp:
* Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp:
* Source/WebKit/UIProcess/RemotePageProxy.cpp:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:

Canonical link: https://commits.webkit.org/273099@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] dab7a9: Remove unused ENABLEs in PlatformCocoa.h

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dab7a975371dc6c85c559db49b6fbf29b055f823
  
https://github.com/WebKit/WebKit/commit/dab7a975371dc6c85c559db49b6fbf29b055f823
  Author: Don Olmstead 
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h

  Log Message:
  ---
  Remove unused ENABLEs in PlatformCocoa.h
https://bugs.webkit.org/show_bug.cgi?id=265547

Reviewed by Alex Christensen.

Used `find-feature-flags` to find `ENABLE` flags that are present in
platform headers but are not used in source files.

python Tools\Scripts\find-feature-flags all-code --diff definitions

Marked `ENABLE` flags that are used in Apple internal builds so they are
not accidentally removed.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:

Canonical link: https://commits.webkit.org/271342@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] d9a9a0: Remove unused enables in FeatureList.pm

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d9a9a0984f5d0af5e92bc7b2f9c3408ab4925c23
  
https://github.com/WebKit/WebKit/commit/d9a9a0984f5d0af5e92bc7b2f9c3408ab4925c23
  Author: Don Olmstead 
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
M Source/cmake/WebKitFeatures.cmake
M Tools/Scripts/webkitperl/FeatureList.pm

  Log Message:
  ---
  Remove unused enables in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=265546

Reviewed by Jonathan Bedard and Michael Catanzaro.

Used `find-feature-flags` to find `ENABLE` flags that are present in
perl code but are not used in source files.

python Tools\Scripts\find-feature-flags all-code --diff definitions

* Source/cmake/WebKitFeatures.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: https://commits.webkit.org/271312@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 61e498: Search additional files in find-feature-flags

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61e49894bf901ea01fb739ea2e3d200b5ba5c0ee
  
https://github.com/WebKit/WebKit/commit/61e49894bf901ea01fb739ea2e3d200b5ba5c0ee
  Author: Don Olmstead 
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
M Tools/Scripts/find-feature-flags
M Tools/Scripts/webkitpy/featuredefines/search.py

  Log Message:
  ---
  Search additional files in find-feature-flags
https://bugs.webkit.org/show_bug.cgi?id=265545

Reviewed by Jonathan Bedard.

Search for flags in the sandboxing files, `.sb.in`, and preferences,
`UnifiedWebPreferences.yaml`. Include the `.serialization.in` files when
searching native code.

* Tools/Scripts/find-feature-flags:
* Tools/Scripts/webkitpy/featuredefines/search.py:

Canonical link: https://commits.webkit.org/271311@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] cc9b0d: Match multiple feature flags in a single line

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc9b0d88747e0d321660345a2d1235240e72d94a
  
https://github.com/WebKit/WebKit/commit/cc9b0d88747e0d321660345a2d1235240e72d94a
  Author: Don Olmstead 
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
M Tools/Scripts/webkitpy/featuredefines/matcher.py
M Tools/Scripts/webkitpy/featuredefines/matcher_unittest.py
M Tools/Scripts/webkitpy/featuredefines/search.py

  Log Message:
  ---
  Match multiple feature flags in a single line
https://bugs.webkit.org/show_bug.cgi?id=265488

Reviewed by Jonathan Bedard.

When searching through a line of source code use `finditer` instead of
`search` so multiple feature flags can be found on the same line.

Fix a typo while modifying the file.

* Tools/Scripts/webkitpy/featuredefines/matcher.py:
* Tools/Scripts/webkitpy/featuredefines/matcher_unittest.py:
* Tools/Scripts/webkitpy/featuredefines/search.py:

Canonical link: https://commits.webkit.org/271299@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 230249: Remove unused ENABLE macros

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2302494878b11514807ac973c25daf25d5891f4b
  
https://github.com/WebKit/WebKit/commit/2302494878b11514807ac973c25daf25d5891f4b
  Author: Don Olmstead 
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
M Source/WTF/wtf/PlatformEnable.h
M Source/WTF/wtf/PlatformEnableCocoa.h
M Source/WebCore/Headers.cmake
M Source/WebKit/CMakeLists.txt
M Source/cmake/OptionsMac.cmake
M Source/cmake/WebKitFeatures.cmake
M Tools/Scripts/webkitperl/FeatureList.pm

  Log Message:
  ---
  Remove unused ENABLE macros
https://bugs.webkit.org/show_bug.cgi?id=265482

Reviewed by Michael Catanzaro.

Used the `find-feature-flags` script to find `ENABLE` flags that were
only present in the CMake code. Identified `ENABLE` flags that could be
removed.

`ENABLE_RUBBER_BANDING` was changed to `HAVE_RUBBER_BANDING` so all
references could be removed.

`ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER` was removed completely.

`ENABLE_OPENCDM` isn't used and looks to be represented by
`ENABLE_THUNDER`.

Finally sort the listing of `ENABLE` flags in `WebKitFeatures.cmake`.

* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/Headers.cmake:
* Source/WebKit/CMakeLists.txt:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: https://commits.webkit.org/271250@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 807a4f: Remove USE(NEW_THEME)

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 807a4f73e523e68114ae6321d562a43e2afac288
  
https://github.com/WebKit/WebKit/commit/807a4f73e523e68114ae6321d562a43e2afac288
  Author: Don Olmstead 
  Date:   2023-11-27 (Mon, 27 Nov 2023)

  Changed paths:
M Source/WTF/wtf/PlatformUse.h
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h

  Log Message:
  ---
  Remove USE(NEW_THEME)
https://bugs.webkit.org/show_bug.cgi?id=264906

Reviewed by Darin Adler and Tim Horton.

Replaces all uses of `USE(NEW_THEME)` with `PLATFORM(IOS_FAMILY)`.

* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::baselinePosition const):
(WebCore::RenderTheme::adjustRepaintRect):
* Source/WebCore/rendering/RenderTheme.h:

Canonical link: https://commits.webkit.org/271158@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] bd68a8: Fix MSVC warnings November 2023 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd68a82273735df6b06124db3d44f5e0e839c4ce
  
https://github.com/WebKit/WebKit/commit/bd68a82273735df6b06124db3d44f5e0e839c4ce
  Author: Don Olmstead 
  Date:   2023-11-21 (Tue, 21 Nov 2023)

  Changed paths:
M Source/JavaScriptCore/assembler/X86Assembler.h
M Source/JavaScriptCore/wasm/WasmCallee.cpp
M Source/WebCore/dom/TreeScopeOrderedMap.cpp
M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  ---
  Fix MSVC warnings November 2023 edition
https://bugs.webkit.org/show_bug.cgi?id=263689

Reviewed by Fujii Hironori.

Fix MSVC warnings around types.

* Source/JavaScriptCore/assembler/X86Assembler.h:
(JSC::X86Assembler::replaceWithNops):
* Source/JavaScriptCore/wasm/WasmCallee.cpp:
(JSC::Wasm::IPIntCallee::IPIntCallee):
* Source/WebCore/dom/TreeScopeOrderedMap.cpp:
(WebCore::TreeScopeOrderedMap::get const):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::hitTestClipPath const):

Canonical link: https://commits.webkit.org/271031@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 65081c: [CMake] Specify stdlib version for PlayStation port

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65081c66319aad67525f892aadda11addbcaf821
  
https://github.com/WebKit/WebKit/commit/65081c66319aad67525f892aadda11addbcaf821
  Author: Don Olmstead 
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
M Source/cmake/OptionsPlayStation.cmake

  Log Message:
  ---
  [CMake] Specify stdlib version for PlayStation port
https://bugs.webkit.org/show_bug.cgi?id=264630

Reviewed by Basuke Suzuki.

Set the stdlib version if the CXX compiler supports the flag.

Remove an unnecessary include, its already in `WebKitCommon.cmake`,
while we're in this file.

* Source/cmake/OptionsPlayStation.cmake:

Canonical link: https://commits.webkit.org/270674@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5e2491: [CMake] Remove WebAssembly dependency on JIT

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e24910556de5f257de29cc2600d6f818a6d79fa
  
https://github.com/WebKit/WebKit/commit/5e24910556de5f257de29cc2600d6f818a6d79fa
  Author: Don Olmstead 
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
M Source/cmake/WebKitFeatures.cmake

  Log Message:
  ---
  [CMake] Remove WebAssembly dependency on JIT
https://bugs.webkit.org/show_bug.cgi?id=264627

Reviewed by Ross Kirsling.

Changes were made to the sources to allow the compilation of WASM files
without the requirement of JIT. Remove the `WEBKIT_OPTION_DEPEND` that
prevented compilation of WASM without JIT.

* Source/cmake/WebKitFeatures.cmake

Canonical link: https://commits.webkit.org/270651@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 2bcfd8: Non-unified build fixes, early November 2023 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2bcfd8571d24d97c08743a23e71f35b34c7f4a03
  
https://github.com/WebKit/WebKit/commit/2bcfd8571d24d97c08743a23e71f35b34c7f4a03
  Author: Don Olmstead 
  Date:   2023-11-13 (Mon, 13 Nov 2023)

  Changed paths:
M Source/WebCore/animation/AnimationEffectTiming.cpp
M Source/WebCore/css/CSSFontFaceRule.cpp
M Source/WebCore/css/CSSPendingSubstitutionValue.cpp
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp
M Source/WebCore/html/canvas/WebGLDefaultFramebuffer.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h
M Source/WebCore/loader/DocumentThreadableLoader.cpp
M Source/WebCore/loader/DocumentThreadableLoader.h
M Source/WebCore/page/NavigationHistoryEntry.cpp
M Source/WebCore/rendering/svg/RenderSVGModelObject.cpp
M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
M Source/WebKit/UIProcess/ProcessThrottler.cpp
M Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp

  Log Message:
  ---
  Non-unified build fixes, early November 2023 edition
https://bugs.webkit.org/show_bug.cgi?id=264638

Unreviewed non-unified build fix.

* Source/WebCore/animation/AnimationEffectTiming.cpp:
* Source/WebCore/css/CSSFontFaceRule.cpp:
* Source/WebCore/css/CSSPendingSubstitutionValue.cpp:
* Source/WebCore/css/CSSValue.cpp:
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp:
* Source/WebCore/html/canvas/WebGLDefaultFramebuffer.cpp:
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:
* Source/WebCore/loader/DocumentThreadableLoader.cpp:
* Source/WebCore/loader/DocumentThreadableLoader.h:
* Source/WebCore/page/NavigationHistoryEntry.cpp:
* Source/WebCore/rendering/svg/RenderSVGModelObject.cpp:
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
* Source/WebKit/UIProcess/ProcessThrottler.cpp:
* Source/WebKit/UIProcess/WebScreenOrientationManagerProxy.cpp:
(WebKit::WebScreenOrientationManagerProxy::lock):
(WebKit::WebScreenOrientationManagerProxy::unlock):
(WebKit::WebScreenOrientationManagerProxy::unlockIfNecessary):

Canonical link: https://commits.webkit.org/270650@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] af9679: ObjectIdentifierReference shouldn't require GPU Pr...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af9679551a8c750e4bc54f35f7c70c7bea99f682
  
https://github.com/WebKit/WebKit/commit/af9679551a8c750e4bc54f35f7c70c7bea99f682
  Author: Don Olmstead 
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
M Source/WebKit/Platform/IPC/ObjectIdentifierReferenceTracker.h

  Log Message:
  ---
  ObjectIdentifierReference shouldn't require GPU Process
https://bugs.webkit.org/show_bug.cgi?id=263453

Reviewed by Kimmo Kinnunen.

The implentation of `ObjectIdentifierReference` is guarded by
`ENABLE(GPU_PROCESS)` but its required for `ThreadSafeObjectHeap`.
Remove the guard so it compiles.

* Source/WebKit/Platform/IPC/ObjectIdentifierReferenceTracker.h:

Canonical link: https://commits.webkit.org/269821@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 003353: Fix return type of fabsConstExpr

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00335382d26d115addf730b88e6f8fb2beb4a889
  
https://github.com/WebKit/WebKit/commit/00335382d26d115addf730b88e6f8fb2beb4a889
  Author: Don Olmstead 
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
M Source/WTF/wtf/MathExtras.h

  Log Message:
  ---
  Fix return type of fabsConstExpr
https://bugs.webkit.org/show_bug.cgi?id=263685

Reviewed by Yusuke Suzuki.

The return type was listed as a `bool` rather than `T` which returns a
floating point type.

* Source/WTF/wtf/MathExtras.h:
(WTF::fabsConstExpr):

Canonical link: https://commits.webkit.org/269799@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ca84d4: SharedMemory::Handle should always be valid

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca84d41f56be91a82968e7464eb0d1379178767f
  
https://github.com/WebKit/WebKit/commit/ca84d41f56be91a82968e7464eb0d1379178767f
  Author: Don Olmstead 
  Date:   2023-10-10 (Tue, 10 Oct 2023)

  Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioSourceProviderProxy.cpp
M Source/WebKit/Platform/IPC/JSIPCBinding.h
M Source/WebKit/Platform/IPC/SharedBufferReference.cpp
M Source/WebKit/Platform/IPC/StreamServerConnection.h
M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp
M Source/WebKit/Platform/SharedMemory.cpp
M Source/WebKit/Platform/SharedMemory.h
M Source/WebKit/Platform/SharedMemory.serialization.in
M Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp
M Source/WebKit/Platform/unix/SharedMemoryUnix.cpp
M Source/WebKit/Platform/win/SharedMemoryWin.cpp
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/Cocoa/SharedCARingBuffer.cpp
M Source/WebKit/Shared/Cocoa/SharedCARingBuffer.h
M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
M Source/WebKit/Shared/IPCStreamTester.cpp
M Source/WebKit/Shared/IPCStreamTester.h
M Source/WebKit/Shared/IPCStreamTester.messages.in
M Source/WebKit/Shared/ShareableBitmap.serialization.in
M Source/WebKit/Shared/ShareableBitmapHandle.cpp
M Source/WebKit/Shared/ShareableResource.cpp
M Source/WebKit/Shared/ShareableResource.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
M Source/WebKit/Shared/WebHitTestResultData.cpp
M Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp
M 
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp
M Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp
M 
Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  ---
  SharedMemory::Handle should always be valid
https://bugs.webkit.org/show_bug.cgi?id=261695

Reviewed by Kimmo Kinnunen.

A `SharedMemory::Handle` should always be valid. Remove the `isNull`
method and default constructor. Instead of `isNull` checks use
`std::optional`. Validate the handle within the
generated serialization.

* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::readPixelsSharedMemory):
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:
(RemoteAudioDestinationManager::createAudioDestination):
* Source/WebKit/GPUProcess/media/RemoteAudioSourceProviderProxy.cpp:
(WebKit::RemoteAudioSourceProviderProxy::configureAudioStorage):
* Source/WebKit/Platform/IPC/JSIPCBinding.h:
(IPC::jsValueForDecodedArgumentValue):
* Source/WebKit/Platform/IPC/SharedBufferReference.cpp:
(IPC::SharedBufferReference::encode const):
(IPC::SharedBufferReference::decode):
* Source/WebKit/Platform/IPC/StreamServerConnection.h:
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage):
* Source/WebKit/Platform/SharedMemory.cpp:
(WebKit::SharedMemoryHandle::SharedMemoryHandle):
(WebKit::SharedMemoryHandle::isNull const): Deleted.
* Source/WebKit/Platform/SharedMemory.h:
* Source/WebKit/Platform/SharedMemory.serialization.in:
* Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::createHandle):
* Source/WebKit/Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::createHandle):
* Source/WebKit/Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::createHandle):
* Source/WebKit/Scripts/webkit/messages.py:
(types_that_must_be_moved):
* Source/WebKit/Shared/Cocoa/SharedCARingBuffer.cpp:
(WebKit::ProducerSharedCARingBuffer::allocate):
* Source/WebKit/Shared/Cocoa/SharedCARingBuffer.h:
* Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder::encodePlatformData):
(IPC::ArgumentCoder::decodePlatformData):
* Source/WebKit/Shared/IPCStreamTester.cpp:
(WebKit::IPCStreamTester::syncMessageReturningSharedMemory1):
* Source/WebKit/Shared/IPCStreamTester.h:
* Source/WebKit/Shared/IPCStreamTester.messages.in:
* Source/WebKit/Shared/ShareableBitmap.serialization.in:
* Source/WebKit/Shared/ShareableBitmapHandle.cpp:
(WebKit::ShareableBitmapHandle::ShareableBitmapHandle):
* Source/WebKit/Shared/ShareableResource.cpp:
(WebKit

[webkit-changes] [WebKit/WebKit] 4e458d: Non-unified build fixes, early October 2023 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4e458d4e5c4b3b4b84a4fc9af6429dd708214038
  
https://github.com/WebKit/WebKit/commit/4e458d4e5c4b3b4b84a4fc9af6429dd708214038
  Author: Don Olmstead 
  Date:   2023-10-06 (Fri, 06 Oct 2023)

  Changed paths:
M Source/JavaScriptCore/bytecode/AccessCase.cpp
M Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp
M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h
M Source/JavaScriptCore/bytecode/PutByVariant.h
M Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp
M Source/JavaScriptCore/jit/ExecutableAllocator.cpp
M Source/JavaScriptCore/parser/SourceTaintedOrigin.cpp
M Source/JavaScriptCore/parser/SourceTaintedOrigin.h
M Source/JavaScriptCore/runtime/FunctionConstructor.h
M Source/WebCore/Modules/webaudio/OscillatorNode.h
M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp
M Source/WebCore/Modules/webtransport/DatagramSink.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/css/CSSVariableReferenceValue.h
M Source/WebCore/dom/LoadableClassicScript.cpp
M Source/WebCore/dom/LoadableImportMap.cpp
M Source/WebCore/dom/LoadableModuleScript.cpp
M Source/WebCore/dom/PendingScript.cpp
M Source/WebCore/html/HTMLDetailsElement.cpp
M Source/WebCore/html/MediaDocument.cpp
M Source/WebCore/html/parser/CSSPreloadScanner.cpp
M Source/WebCore/inspector/agents/page/PageCanvasAgent.cpp
M Source/WebCore/layout/floats/FloatingContext.cpp
M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/block/BlockFormattingQuirks.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentCache.h
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h
M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.h
M 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp
M 
Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.h
M Source/WebCore/page/Location.h
M Source/WebCore/page/OpportunisticTaskScheduler.cpp
M Source/WebCore/page/PageConfiguration.cpp
M Source/WebCore/page/RemoteDOMWindow.cpp
M Source/WebCore/platform/AudioEncoder.cpp
M Source/WebCore/platform/ThreadTimers.cpp
M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp
M Source/WebCore/platform/adwaita/ThemeAdwaita.cpp
M Source/WebCore/platform/audio/HRTFElevation.cpp
M 
Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp
M 
Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp
M Source/WebCore/platform/network/BlobPart.h
M Source/WebCore/rendering/MotionPath.cpp
M Source/WebCore/rendering/RenderAttachment.cpp
M Source/WebCore/rendering/RenderThemeAdwaita.cpp
M Source/WebCore/rendering/mathml/MathOperator.cpp
M Source/WebCore/storage/StorageUtilities.h
M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
M Source/WebCore/workers/shared/SharedWorkerObjectConnection.cpp
M Source/WebKit/GPUProcess/ShapeDetection/RemoteBarcodeDetector.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
M Source/WebKit/GPUProcess/graphics/ScopedWebGLRenderingResourcesRequest.cpp
M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h
M Source/WebKit/Platform/IPC/Connection.cpp
M Source/WebKit/UIProcess/BrowsingContextGroup.cpp
M Source/WebKit/UIProcess/DisplayLinkProcessProxyClient.cpp
M Source/WebKit/UIProcess/WebProcessProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp
M Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp

  Log Message:
  ---
  Non-unified build fixes, early October 2023 edition
https://bugs.webkit.org/show_bug.cgi?id=262719

Unreviewed non-unified build fix.

Run a non-unified build of Windows with clang-cl and fix any compilation
issues and warnings. Warnings were all around unused code.

* Source/JavaScriptCore/bytecode/AccessCase.cpp:
* Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp:
* Source/JavaScriptCore/bytecode/InlineCacheCompiler.h:
* Source/JavaScriptCore/bytecode/PutByVariant.h:
* Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:
* Source/JavaScriptCore/jit/ExecutableAllocator.cpp:
* Source/JavaScriptCore/parser/SourceTaintedOrigin.cpp:
* Source/JavaScriptCore/parser/SourceTaintedOrigin.h:
* Source/JavaScriptCore/runtime/FunctionConstructor.h:
* Source/WebCore/Modules/webaudio/OscillatorNode.h:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp:
* Source/WebCore/Modules/webtransport/DatagramSink.cpp:
* Source/WebCore/accessibility

[webkit-changes] [WebKit/WebKit] fd3a4d: Optionally return a StreamConnectionPair in Stream...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd3a4d231104825ad39d97741e09928f391c32bb
  
https://github.com/WebKit/WebKit/commit/fd3a4d231104825ad39d97741e09928f391c32bb
  Author: Don Olmstead 
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
M Source/WebKit/Platform/IPC/StreamClientConnection.cpp
M Source/WebKit/Platform/IPC/StreamClientConnection.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp

  Log Message:
  ---
  Optionally return a StreamConnectionPair in StreamClientConnection::create
https://bugs.webkit.org/show_bug.cgi?id=261782

Reviewed by Kimmo Kinnunen.

Change function signature of `StreamClientConnection::create` to return
a `std::optional`. Modify `StreamConnectionPair`
to use a `Ref` since the value will never be
`null`. Updated the call sites for `StreamClientConnection::create` to
handle the changes.

This is a step towards `SharedMemory::Handle` also always being valid.

* Source/WebKit/Platform/IPC/StreamClientConnection.cpp:
(IPC::StreamClientConnection::create):
* Source/WebKit/Platform/IPC/StreamClientConnection.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::create):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::ensureGPUProcessConnection):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp:
(WebKit::RemoteGPUProxy::create):
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::createError):
(WebKit::IPCTestingAPI::JSIPC::createStreamClientConnection):
* Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp:

Canonical link: https://commits.webkit.org/268220@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] efca8e: Guard additional identifiers when generating messages

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: efca8e15c8b072d3f4dab2aff0b5cc84a0710f2f
  
https://github.com/WebKit/WebKit/commit/efca8e15c8b072d3f4dab2aff0b5cc84a0710f2f
  Author: Don Olmstead 
  Date:   2023-09-19 (Tue, 19 Sep 2023)

  Changed paths:
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp

  Log Message:
  ---
  Guard additional identifiers when generating messages
https://bugs.webkit.org/show_bug.cgi?id=261768

Reviewed by Chris Dumez.

Message generation for `WebKit::RemoteAudioSessionIdentifier` and
`WebCore::PlaybackTargetClientContextIdentifier` were not properly
guarded. Add the appropriate conditions to their headers.

Tests were updated to reflect the changes.

* Source/WebKit/Scripts/webkit/messages.py:
(conditions_for_header):
* Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
(IPC::serializedIdentifiers):

Canonical link: https://commits.webkit.org/268165@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 1084b5: Generate serialization of StreamServerConnectionHa...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1084b50affac3b51b40ec96aa627dab74600f0f5
  
https://github.com/WebKit/WebKit/commit/1084b50affac3b51b40ec96aa627dab74600f0f5
  Author: Don Olmstead 
  Date:   2023-09-19 (Tue, 19 Sep 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Platform/IPC/StreamConnectionBuffer.cpp
M Source/WebKit/Platform/IPC/StreamConnectionBuffer.h
M Source/WebKit/Platform/IPC/StreamServerConnection.h
A Source/WebKit/Platform/IPC/StreamServerConnection.serialization.in
M Source/WebKit/Platform/IPC/StreamServerConnectionBuffer.h
M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp

  Log Message:
  ---
  Generate serialization of StreamServerConnectionHandle
https://bugs.webkit.org/show_bug.cgi?id=261707

Reviewed by Alex Christensen.

Migrate `StreamServerConnectionHandle` to the serialization format.
Remove manual serialization.

Remove `struct StreamConnectionBuffer::Handle` and just use a
`WebKit::SharedMemory::Handle` directly. Move the validation checks into
serialization of `StreamServerConnectionHandle`.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Platform/IPC/StreamConnectionBuffer.cpp:
(IPC::StreamConnectionBuffer::Handle::encode): Deleted.
(IPC::StreamConnectionBuffer::Handle::decode): Deleted.
* Source/WebKit/Platform/IPC/StreamConnectionBuffer.h:
(IPC::StreamConnectionBuffer::sharedMemorySizeIsValid):
* Source/WebKit/Platform/IPC/StreamServerConnection.h:
(IPC::StreamServerConnectionHandle::StreamServerConnectionHandle):
(IPC::StreamServerConnection::Handle::encode): Deleted.
(IPC::StreamServerConnection::Handle::decode): Deleted.
* Source/WebKit/Platform/IPC/StreamServerConnection.serialization.in: Added.
* Source/WebKit/Platform/IPC/StreamServerConnectionBuffer.h:
(IPC::StreamServerConnectionBuffer::map):
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPCStreamConnectionBuffer::encode const):

Canonical link: https://commits.webkit.org/268162@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 45fe87: ShareableBitmap::Handle should always be valid

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 45fe8715b24526a8b1e9fc0002ae37b26558d10d
  
https://github.com/WebKit/WebKit/commit/45fe8715b24526a8b1e9fc0002ae37b26558d10d
  Author: Don Olmstead 
  Date:   2023-09-18 (Mon, 18 Sep 2023)

  Changed paths:
M Source/WebKit/GPUProcess/GPUProcess.cpp
M Source/WebKit/GPUProcess/GPUProcess.h
M Source/WebKit/GPUProcess/GPUProcess.messages.in
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.cpp
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h
M Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.messages.in
M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
M Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.h
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/ContextMenuContextData.cpp
M Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h
M Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.mm
M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
M Source/WebKit/Shared/ShareableBitmap.cpp
M Source/WebKit/Shared/ShareableBitmap.h
M Source/WebKit/Shared/ShareableBitmap.serialization.in
M Source/WebKit/Shared/ShareableBitmapHandle.cpp
M Source/WebKit/Shared/UpdateInfo.h
M Source/WebKit/Shared/UpdateInfo.serialization.in
M Source/WebKit/Shared/UserData.cpp
M Source/WebKit/Shared/WebImage.cpp
M Source/WebKit/Shared/WebImage.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm
M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
M Source/WebKit/UIProcess/Automation/WebAutomationSession.h
M Source/WebKit/UIProcess/Automation/WebAutomationSession.messages.in
M Source/WebKit/UIProcess/BackingStore.cpp
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WKContentView.mm
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/UIProcess/mac/WKPrintingView.mm
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/ImageBufferBackendHandleSharing.h
M 
Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp
M Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h
M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h
M 
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.h
M 
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBitmapBackend.cpp
M 
Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBitmapBackend.h
M Source/WebKit/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp
M Source/WebKit/WebProcess/WebPage/FindController.cpp
M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp
M Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.h

  Log Message:
  ---
  ShareableBitmap::Handle should always be valid
https://bugs.webkit.org/show_bug.cgi?id=261470

Reviewed by Kimmo Kinnunen.

The underyling `SharedMemory::Handle` in `ShareableBitmap::Handle`
should always be valid. Remove the `isNull` method and default
constructor. Use `std::optional` in place of
any `isNull` checks. Validate the handle within the generated
serialization.

This is a step towards `SharedMemory::Handle` also always being valid.

* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::requestBitmapImageForCurrentTime):
* Source/WebKit/GPUProcess/GPUProcess.h:
* Source/WebKit/GPUProcess/GPUProcess.messages.in:
* Source/WebKit/GPUProcess/graphics

[webkit-changes] [WebKit/WebKit] bc3ff0: ShareableResource::Handle should always be valid

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc3ff053ad9d4dc8da786f2d35c5d871796eca88
  
https://github.com/WebKit/WebKit/commit/bc3ff053ad9d4dc8da786f2d35c5d871796eca88
  Author: Don Olmstead 
  Date:   2023-09-18 (Mon, 18 Sep 2023)

  Changed paths:
M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCache.h
M Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp
M Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.h
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Shared/ShareableResource.cpp
M Source/WebKit/Shared/ShareableResource.h
M Source/WebKit/Shared/ShareableResource.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp

  Log Message:
  ---
  ShareableResource::Handle should always be valid
https://bugs.webkit.org/show_bug.cgi?id=261610

Reviewed by Kimmo Kinnunen.

The underyling `SharedMemory::Handle` in `ShareableResource::Handle`
should always be valid. Remove the `isNull` method and default
constructor. Use `std::optional` in place of
any `isNull` checks. Validate the handle within the generated
serialization.

This is a step towards `SharedMemory::Handle` also always being valid.

* Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):
* Source/WebKit/NetworkProcess/cache/NetworkCache.h:
* Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::initializeBufferFromStorageRecord const):
(WebKit::NetworkCache::Entry::shareableResourceHandle const):
(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord
 const): Deleted.
* Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.h:
* Source/WebKit/Scripts/webkit/messages.py:
(types_that_must_be_moved):
* Source/WebKit/Shared/ShareableResource.cpp:
(WebKit::ShareableResourceHandle::ShareableResourceHandle):
* Source/WebKit/Shared/ShareableResource.h:
(WebKit::ShareableResourceHandle::isNull const): Deleted.
* Source/WebKit/Shared/ShareableResource.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::tryConvertToShareableResourceHandle):
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
(IPC::decodeScriptBufferAsShareableResourceHandle): Deleted.

Canonical link: https://commits.webkit.org/268077@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] af4e6a: Fix !ENABLE(MATHML) build after 267903@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af4e6a068583b3efe1877a479180127990ffcb6a
  
https://github.com/WebKit/WebKit/commit/af4e6a068583b3efe1877a479180127990ffcb6a
  Author: Don Olmstead 
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  ---
  Fix !ENABLE(MATHML) build after 267903@main
https://bugs.webkit.org/show_bug.cgi?id=261475

Unreviewed build fix.

Place `ENABLE(MATHML)` guards around `RenderMathMLBlock`.

* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:

Canonical link: https://commits.webkit.org/267918@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a3cca2: Generate serialization of ShareableResourceHandle

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3cca24f6635ff5762f0b7b85d6ce4aaf2d79e51
  
https://github.com/WebKit/WebKit/commit/a3cca24f6635ff5762f0b7b85d6ce4aaf2d79e51
  Author: Don Olmstead 
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/ShareableResource.cpp
M Source/WebKit/Shared/ShareableResource.h
A Source/WebKit/Shared/ShareableResource.serialization.in

  Log Message:
  ---
  Generate serialization of ShareableResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=261351

Reviewed by Alex Christensen.

Migrate `ShareableResourceHandle` to the serialization format. Remove
manual serialization.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/ShareableResource.cpp:
(WebKit::ShareableResourceHandle::ShareableResourceHandle):
(WebKit::ShareableResource::createHandle):
(WebKit::ShareableResourceHandle::encode): Deleted.
(WebKit::ShareableResourceHandle::decode): Deleted.
* Source/WebKit/Shared/ShareableResource.h:
* Source/WebKit/Shared/ShareableResource.serialization.in: Added.

Canonical link: https://commits.webkit.org/267876@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] a23872: [CMake] Support port specific serialization files ...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a238722748a07a69056cb7e0565944416640df35
  
https://github.com/WebKit/WebKit/commit/a238722748a07a69056cb7e0565944416640df35
  Author: Don Olmstead 
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt

  Log Message:
  ---
  [CMake] Support port specific serialization files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=261336

Reviewed by Michael Catanzaro.

Move the listing before `WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS` so a
port's CMake can append to the values.

* Source/WebKit/CMakeLists.txt:

Canonical link: https://commits.webkit.org/267800@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4f6c2e: Expose platform specific initialization of GPU Pro...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f6c2e880164c1d4dac1234d14b0dbee33c99dae
  
https://github.com/WebKit/WebKit/commit/4f6c2e880164c1d4dac1234d14b0dbee33c99dae
  Author: Don Olmstead 
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
M Source/WebKit/GPUProcess/GPUProcess.cpp
M Source/WebKit/GPUProcess/GPUProcess.h
M Source/WebKit/GPUProcess/glib/GPUProcessGLib.cpp
M Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp
M Source/WebKit/GPUProcess/win/GPUProcessWin.cpp

  Log Message:
  ---
  Expose platform specific initialization of GPU Process
https://bugs.webkit.org/show_bug.cgi?id=257895

Reviewed by Myles C. Maxfield.

Expose the method `GPUProcess::platformInitializeGPUProcess` for all
ports to do any platform specific routines at start up. This mirrors the
behavior of the Web and Network process.

* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):
* Source/WebKit/GPUProcess/GPUProcess.h:
* Source/WebKit/GPUProcess/glib/GPUProcessGLib.cpp:
(WebKit::GPUProcess::platformInitializeGPUProcess):
* Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp:
(WebKit::GPUProcess::platformInitializeGPUProcess):
* Source/WebKit/GPUProcess/win/GPUProcessWin.cpp:
(WebKit::GPUProcess::platformInitializeGPUProcess):

Canonical link: https://commits.webkit.org/267572@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] eb79b7: Fix some guards for USE(THEME_ADWAITA)

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eb79b7552ad6879edf58b5fd1c05342295176644
  
https://github.com/WebKit/WebKit/commit/eb79b7552ad6879edf58b5fd1c05342295176644
  Author: Don Olmstead 
  Date:   2023-09-01 (Fri, 01 Sep 2023)

  Changed paths:
M Source/WTF/wtf/PlatformUse.h
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
M Source/WebCore/rendering/RenderThemeAdwaita.cpp

  Log Message:
  ---
  Fix some guards for USE(THEME_ADWAITA)
https://bugs.webkit.org/show_bug.cgi?id=261003

Reviewed by Michael Catanzaro.

Miscellaneous fixes to make `USE_THEME_ADWAITA` work more cross
platform.

* Source/WTF/wtf/PlatformUse.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::layoutTraitsClassName const):
* Source/WebCore/rendering/RenderThemeAdwaita.cpp:
(WebCore::RenderThemeAdwaita::systemColor const):

Canonical link: https://commits.webkit.org/267554@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4d0e5a: [PlayStation] Enable variation fonts experimentally

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d0e5aebe06eca31e00687fd7474b2db135355ea
  
https://github.com/WebKit/WebKit/commit/4d0e5aebe06eca31e00687fd7474b2db135355ea
  Author: Don Olmstead 
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
M Source/cmake/OptionsPlayStation.cmake

  Log Message:
  ---
  [PlayStation] Enable variation fonts experimentally
https://bugs.webkit.org/show_bug.cgi?id=260987

Reviewed by Fujii Hironori.

Check the versions of freetype, harfbuzz and fontconfig to see if its
possible to turn on `ENABLE_VARIATION_FONTS`.

* Source/cmake/OptionsPlayStation.cmake:

Canonical link: https://commits.webkit.org/267533@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f6b1fa: Use generator to set CMAKE_EXPORT_COMPILE_COMMANDS

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6b1fa7647c7e2b2f4eefbb45c79dbd27d5479ab
  
https://github.com/WebKit/WebKit/commit/f6b1fa7647c7e2b2f4eefbb45c79dbd27d5479ab
  Author: Don Olmstead 
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
M Source/cmake/WebKitCommon.cmake
M Tools/Scripts/webkitdirs.pm

  Log Message:
  ---
  Use generator to set CMAKE_EXPORT_COMPILE_COMMANDS
https://bugs.webkit.org/show_bug.cgi?id=260666

Reviewed by Michael Catanzaro.

In 266947@main a target `RewriteCompileCommands` was added for unified
builds where `CMAKE_EXPORT_COMPILE_COMMANDS` is `ON`. However this
is only valid for Makefile and Ninja generators. On Visual Studio it
is ignored so the target will always fail to build which was found out
because its always set to `ON` within `build-webkit`.

Move the logic for turning it `ON` into the CMake code and base it on
the `CMAKE_GENERATOR`.

* Source/cmake/WebKitCommon.cmake
* Tools/Scripts/webkitdirs.pm

Canonical link: https://commits.webkit.org/267521@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 53a54c: [CMake] Turn off pkg-config on PlayStation

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53a54cd39755b3ea25db0a1064f102f920f16236
  
https://github.com/WebKit/WebKit/commit/53a54cd39755b3ea25db0a1064f102f920f16236
  Author: Don Olmstead 
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
M Source/cmake/OptionsPlayStation.cmake

  Log Message:
  ---
  [CMake] Turn off pkg-config on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=260983

Reviewed by Michael Catanzaro.

The CMake find modules use pkg-config to get hints for a library's
location. With a Windows host it can pick up .pc files in the perl
install accidentally. PlayStation isn't using .pc files so just turn it
completely off.

Prevent the find module from running and override `pkg_check_modules`
so it doesn't return anything.

* Source/cmake/OptionsPlayStation.cmake:

Canonical link: https://commits.webkit.org/267519@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] ec1a5b: [CMake] Remove obsolete port names

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec1a5b9a9f9503751104365794c213327eec88d7
  
https://github.com/WebKit/WebKit/commit/ec1a5b9a9f9503751104365794c213327eec88d7
  Author: Don Olmstead 
  Date:   2023-08-30 (Wed, 30 Aug 2023)

  Changed paths:
M Source/cmake/WebKitCommon.cmake

  Log Message:
  ---
  [CMake] Remove obsolete port names
https://bugs.webkit.org/show_bug.cgi?id=260906

Reviewed by Michael Catanzaro.

The EFL and FTW ports aren't present in the source so remove from the
port name listing.

* Source/cmake/WebKitCommon.cmake

Canonical link: https://commits.webkit.org/267457@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] f7d824: Non-unified build fixes, late August 2023 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7d82401bd4141a44f197d0c24b612ec1a3f7adf
  
https://github.com/WebKit/WebKit/commit/f7d82401bd4141a44f197d0c24b612ec1a3f7adf
  Author: Don Olmstead 
  Date:   2023-08-30 (Wed, 30 Aug 2023)

  Changed paths:
M Source/JavaScriptCore/parser/ParserArena.h
M Source/JavaScriptCore/runtime/NativeCallee.h
M Source/JavaScriptCore/runtime/NumberPredictionFuzzerAgent.cpp
M Source/WebCore/Modules/webtransport/WebTransport.cpp
M Source/WebCore/Modules/webtransport/WebTransport.h
M Source/WebCore/Modules/webtransport/WebTransportBidirectionalStream.cpp
M Source/WebCore/Modules/webtransport/WebTransportBidirectionalStream.h
M Source/WebCore/Modules/webtransport/WebTransportDatagramDuplexStream.h
M Source/WebCore/Modules/webtransport/WebTransportReceiveStream.cpp
M Source/WebCore/Modules/webtransport/WebTransportReceiveStream.h
M Source/WebCore/Modules/webtransport/WebTransportSendStream.cpp
M Source/WebCore/Modules/webtransport/WebTransportSendStream.h
M Source/WebCore/bindings/js/WorkerModuleScriptLoader.cpp
M Source/WebCore/css/CSSFunctionValue.cpp
M Source/WebCore/dom/IdleDeadline.cpp
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
M Source/WebCore/html/canvas/WebGLTransformFeedback.h
M Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.h
M Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp
M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp
M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.h
M 
Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/rendering/BaselineAlignment.cpp
M Source/WebCore/rendering/CounterNode.h
M Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp
M Source/WebKit/UIProcess/BackgroundProcessResponsivenessTimer.h
M Source/WebKit/UIProcess/PageLoadState.cpp
M Source/WebKit/UIProcess/RemotePageProxy.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebProgressTrackerClient.h

  Log Message:
  ---
  Non-unified build fixes, late August 2023 edition
https://bugs.webkit.org/show_bug.cgi?id=260885

Unreviewed non-unified build fix.

* Source/JavaScriptCore/parser/ParserArena.h:
* Source/JavaScriptCore/runtime/NativeCallee.h:
* Source/JavaScriptCore/runtime/NumberPredictionFuzzerAgent.cpp:
* Source/WebCore/Modules/webtransport/WebTransport.cpp:
* Source/WebCore/Modules/webtransport/WebTransport.h:
* Source/WebCore/Modules/webtransport/WebTransportBidirectionalStream.cpp:
* Source/WebCore/Modules/webtransport/WebTransportBidirectionalStream.h:
* Source/WebCore/Modules/webtransport/WebTransportDatagramDuplexStream.h:
* Source/WebCore/Modules/webtransport/WebTransportReceiveStream.cpp:
* Source/WebCore/Modules/webtransport/WebTransportReceiveStream.h:
* Source/WebCore/Modules/webtransport/WebTransportSendStream.cpp:
* Source/WebCore/Modules/webtransport/WebTransportSendStream.h:
* Source/WebCore/bindings/js/WorkerModuleScriptLoader.cpp:
* Source/WebCore/css/CSSFunctionValue.cpp:
* Source/WebCore/dom/IdleDeadline.cpp:
* Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
* Source/WebCore/html/canvas/WebGLTransformFeedback.h:
* Source/WebCore/layout/formattingContexts/inline/AbstractLineBuilder.h:
* Source/WebCore/layout/formattingContexts/inline/InlineContentBalancer.cpp:
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.h:
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp:
* Source/WebCore/page/Page.cpp:
* Source/WebCore/rendering/BaselineAlignment.cpp:
* Source/WebCore/rendering/CounterNode.h:
* Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
* Source/WebKit/UIProcess/BackgroundProcessResponsivenessTimer.h:
* Source/WebKit/UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::didCommitLoad):
* Source/WebKit/UIProcess/RemotePageProxy.cpp:
* Source/WebKit/WebProcess/WebCoreSupport/WebProgressTrackerClient.h:

Canonical link: https://commits.webkit.org/267453@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 54b5e2: Fix guard for InbandTextTrackPrivate serialization

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 54b5e264e323b043f42c0564d17ae19be19b
  
https://github.com/WebKit/WebKit/commit/54b5e264e323b043f42c0564d17ae19be19b
  Author: Don Olmstead 
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
M Source/WebCore/platform/graphics/InbandTextTrackPrivate.serialization.in

  Log Message:
  ---
  Fix guard for InbandTextTrackPrivate serialization
https://bugs.webkit.org/show_bug.cgi?id=260669

Reviewed by Alex Christensen.

The guard should actually be `ENABLE(VIDEO)` && `ENABLE(GPU_PROCESS)`
and not be based on `PLATFORM`.

* Source/WebCore/platform/graphics/InbandTextTrackPrivate.serialization.in

Canonical link: https://commits.webkit.org/267380@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 98ef2d: [CMake] Specify dependencies for generate-serializers

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98ef2da48c447e6ea83107ff365fd3155b5e8b86
  
https://github.com/WebKit/WebKit/commit/98ef2da48c447e6ea83107ff365fd3155b5e8b86
  Author: Don Olmstead 
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
M Source/WebKit/CMakeLists.txt

  Log Message:
  ---
  [CMake] Specify dependencies for generate-serializers
https://bugs.webkit.org/show_bug.cgi?id=260819

Reviewed by Alex Christensen and Michael Catanzaro.

The `generate-serializers.py` script was missing dependencies to WebCore
`serialization.in` files. The script is called using relative paths
so expand them and add them to the custom target's dependencies so
changes to the WebCore files regenerate the serializers.

* Source/WebKit/CMakeLists.txt:

Canonical link: https://commits.webkit.org/267377@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 81b47f: Fix PlayStation build after 267138@main

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81b47f78ce09dc778e92f1d2ded82377d34dace4
  
https://github.com/WebKit/WebKit/commit/81b47f78ce09dc778e92f1d2ded82377d34dace4
  Author: Don Olmstead 
  Date:   2023-08-22 (Tue, 22 Aug 2023)

  Changed paths:
M Source/WebCore/platform/graphics/InbandTextTrackPrivate.serialization.in

  Log Message:
  ---
  Fix PlayStation build after 267138@main
https://bugs.webkit.org/show_bug.cgi?id=260560

Unreviewed build fix.

Add an `!PLATFORM(PLAYSTATION)` guard around the serializers just like
WPE and GTK ports.

* Source/WebCore/platform/graphics/InbandTextTrackPrivate.serialization.in

Canonical link: https://commits.webkit.org/267170@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 56e725: Non-unified build fixes, early August 2023 edition

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 56e725ce615193cd3472f3fe4d4e8df79f1c26ef
  
https://github.com/WebKit/WebKit/commit/56e725ce615193cd3472f3fe4d4e8df79f1c26ef
  Author: Don Olmstead 
  Date:   2023-08-07 (Mon, 07 Aug 2023)

  Changed paths:
M Source/WebCore/dom/ContentVisibilityDocumentState.cpp
M Source/WebCore/dom/FullscreenManager.cpp
M Source/WebCore/fileapi/ThreadableBlobRegistry.cpp
M Source/WebCore/fileapi/ThreadableBlobRegistry.h
M Source/WebCore/html/track/InbandGenericTextTrack.cpp
M Source/WebCore/html/track/VTTCue.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
M 
Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/loader/MixedContentChecker.cpp
M Source/WebCore/page/IntersectionObserver.cpp
M Source/WebCore/page/ResizeObservation.h
M Source/WebCore/page/SecurityOriginData.cpp
M Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
M Source/WebCore/storage/StorageUtilities.cpp
M Source/WebCore/storage/StorageUtilities.h
M Source/WebCore/style/Styleable.cpp
M Source/WebKit/NetworkProcess/NetworkLoadChecker.h
M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp
M Source/WebKit/Platform/IPC/Connection.cpp
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M Source/WebKit/WebProcess/WebPage/playstation/WebPagePlayStation.cpp

  Log Message:
  ---
  Non-unified build fixes, early August 2023 edition
https://bugs.webkit.org/show_bug.cgi?id=259913

Unreviewed non-unified build fix.

Fix non-unified build and any warnings found. A non-unified build
reports more warnings around unused statically scoped values.

* Source/WebCore/dom/ContentVisibilityDocumentState.cpp:
* Source/WebCore/dom/FullscreenManager.cpp:
* Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:
* Source/WebCore/fileapi/ThreadableBlobRegistry.h:
* Source/WebCore/html/track/InbandGenericTextTrack.cpp:
* Source/WebCore/html/track/VTTCue.cpp:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::horizontalMargin): Deleted.
(WebCore::Layout::verticalMargin): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::nextInlineLevelBoxToLayout): Deleted.
* Source/WebCore/loader/MixedContentChecker.cpp:
* Source/WebCore/page/IntersectionObserver.cpp:
* Source/WebCore/page/ResizeObservation.h:
* Source/WebCore/page/SecurityOriginData.cpp:
* Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:
(WebCore::NetworkStorageSession::setCookieFromDOM const):
(WebCore::NetworkStorageSession::cookiesForDOMAsVector const):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
* Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::svgExtensionsFromElement): Deleted.
* Source/WebCore/storage/StorageUtilities.cpp:
* Source/WebCore/storage/StorageUtilities.h:
* Source/WebCore/style/Styleable.cpp:
* Source/WebKit/NetworkProcess/NetworkLoadChecker.h:
* Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp:
* Source/WebKit/Platform/IPC/Connection.cpp:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::setPIPStandbyElement):
* Source/WebKit/WebProcess/WebPage/playstation/WebPagePlayStation.cpp:

Canonical link: https://commits.webkit.org/266674@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 5102c8: Fix warnings in GPU Process code when RELEASE_LOG_...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5102c8f298fbb6606f64483c029c8bc2d2e37d02
  
https://github.com/WebKit/WebKit/commit/5102c8f298fbb6606f64483c029c8bc2d2e37d02
  Author: Don Olmstead 
  Date:   2023-07-11 (Tue, 11 Jul 2023)

  Changed paths:
M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp
M Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp

  Log Message:
  ---
  Fix warnings in GPU Process code when RELEASE_LOG_DISABLED
https://bugs.webkit.org/show_bug.cgi?id=259003

Reviewed by Chris Dumez.

Guard code with checks for whether `RELEASE_LOG_DISABLED` is enabled.

* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::send):
(WebKit::RemoteDisplayListRecorderProxy::sendSync):
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.cpp:
(WebKit::RemoteImageBufferProxy::ensureBackendCreated const):

Canonical link: https://commits.webkit.org/265950@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 784117: Fix unused parameter warnings when !ENABLE(WEB_AUDIO)

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 784117b4fe33caec26a96a185b216eb48b58d460
  
https://github.com/WebKit/WebKit/commit/784117b4fe33caec26a96a185b216eb48b58d460
  Author: Don Olmstead 
  Date:   2023-07-10 (Mon, 10 Jul 2023)

  Changed paths:
M Source/WebCore/bindings/js/SerializedScriptValue.cpp

  Log Message:
  ---
  Fix unused parameter warnings when !ENABLE(WEB_AUDIO)
https://bugs.webkit.org/show_bug.cgi?id=259002

Reviewed by Youenn Fablet.

Add `UNUSED_PARAM`s to the `!ENABLE(WEB_AUDIO)` block.

* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::isTypeExposedToGlobalObject):

Canonical link: https://commits.webkit.org/265921@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 4776b3: [LibWPE] Fix click count logic

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4776b34f03c78abda6801614775b8c468f6a5a27
  
https://github.com/WebKit/WebKit/commit/4776b34f03c78abda6801614775b8c468f6a5a27
  Author: Don Olmstead 
  Date:   2023-07-07 (Fri, 07 Jul 2023)

  Changed paths:
M Source/WebKit/Shared/libwpe/WebEventFactory.cpp

  Log Message:
  ---
  [LibWPE] Fix click count logic
https://bugs.webkit.org/show_bug.cgi?id=259000

Reviewed by Michael Catanzaro.

When comparing screen coordinates for a click `==` was used instead of
a subtraction. Also modify the threshold to be an int so there isn't
a type warning since `std::abs` outputs an `int` not an `unsigned`.

* Source/WebKit/Shared/libwpe/WebEventFactory.cpp:
(WebKit::clickCount):

Canonical link: https://commits.webkit.org/265874@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [WebKit/WebKit] 6a797e: Fix unused field warning in RunLoopObserver for no...

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a797e18d7692574c6c6432ae28dc824a1a4d6a2
  
https://github.com/WebKit/WebKit/commit/6a797e18d7692574c6c6432ae28dc824a1a4d6a2
  Author: Don Olmstead 
  Date:   2023-07-07 (Fri, 07 Jul 2023)

  Changed paths:
M Source/WebCore/platform/RunLoopObserver.h

  Log Message:
  ---
  Fix unused field warning in RunLoopObserver for non-Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=258996

Reviewed by Wenson Hsieh.

Make `m_order` specific to `USE(CF)`.

* Source/WebCore/platform/RunLoopObserver.h:
(WebCore::RunLoopObserver::RunLoopObserver):

Canonical link: https://commits.webkit.org/265873@main


___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes