Title: [236811] trunk/Source/ThirdParty
- Revision
- 236811
- Author
- m...@apple.com
- Date
- 2018-10-03 14:08:53 -0700 (Wed, 03 Oct 2018)
Log Message
ANGLE and libwebrtc parts of [Xcode] Update some build settings as recommended by Xcode 10
https://bugs.webkit.org/show_bug.cgi?id=190250
Reviewed by Andy Estes.
Source/ThirdParty/ANGLE:
* ANGLE.xcodeproj/project.pbxproj: Kept the unreachable code warning off for four files that
were generated by tools: glslang_lex.cpp, glslang_tab.cpp, Tokenizer.cpp, and
ExpressionParser.cpp. Let Xcode update LastUpgradeCheck.
* Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_INFINITE_RECURSION,
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_SUSPICIOUS_MOVE,
CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
Source/ThirdParty/libwebrtc:
* Configurations/Base.xcconfig: Removed a duplicate reference to x_all.c and let Xcode
update LastUpgradeCheck.
* libwebrtc.xcodeproj/project.pbxproj: Enabled CLANG_WARN_INFINITE_RECURSION,
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and
CLANG_WARN_SUSPICIOUS_MOVE. Other warnings that Xcode 10 recommended were incompatible
with one or more source files in the project.
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (236810 => 236811)
--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2018-10-03 21:02:19 UTC (rev 236810)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2018-10-03 21:08:53 UTC (rev 236811)
@@ -20,8 +20,8 @@
31012E2918B97B9B0039062F /* DirectiveHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DB818B97B9B0039062F /* DirectiveHandler.h */; };
31012E2A18B97B9B0039062F /* ExtensionBehavior.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DB918B97B9B0039062F /* ExtensionBehavior.h */; };
31012E2D18B97B9B0039062F /* glslang.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DBD18B97B9B0039062F /* glslang.h */; };
- 31012E3018B97B9B0039062F /* glslang_lex.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC018B97B9B0039062F /* glslang_lex.cpp */; };
- 31012E3118B97B9B0039062F /* glslang_tab.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC118B97B9B0039062F /* glslang_tab.cpp */; };
+ 31012E3018B97B9B0039062F /* glslang_lex.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC018B97B9B0039062F /* glslang_lex.cpp */; settings = {COMPILER_FLAGS = "-Wno-unreachable-code"; }; };
+ 31012E3118B97B9B0039062F /* glslang_tab.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC118B97B9B0039062F /* glslang_tab.cpp */; settings = {COMPILER_FLAGS = "-Wno-unreachable-code"; }; };
31012E3218B97B9B0039062F /* glslang_tab.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DC218B97B9B0039062F /* glslang_tab.h */; };
31012E3318B97B9B0039062F /* HashNames.h in Headers */ = {isa = PBXBuildFile; fileRef = 31012DC318B97B9B0039062F /* HashNames.h */; };
31012E3418B97B9B0039062F /* InfoSink.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 31012DC418B97B9B0039062F /* InfoSink.cpp */; };
@@ -516,8 +516,8 @@
5CCD81C01DBFEA5C006066B8 /* UseInterfaceBlockFields.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CCD81A91DBFEA5C006066B8 /* UseInterfaceBlockFields.h */; };
5CCD81C31DBFEAD9006066B8 /* EmulateGLFragColorBroadcast.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 5CCD81C11DBFEAD9006066B8 /* EmulateGLFragColorBroadcast.cpp */; };
5CCD81C41DBFEAD9006066B8 /* EmulateGLFragColorBroadcast.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CCD81C21DBFEAD9006066B8 /* EmulateGLFragColorBroadcast.h */; };
- 72309A56183C27DE00370B93 /* Tokenizer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72309A55183C27DB00370B93 /* Tokenizer.cpp */; };
- 72309A58183C27F300370B93 /* ExpressionParser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72309A57183C27F100370B93 /* ExpressionParser.cpp */; };
+ 72309A56183C27DE00370B93 /* Tokenizer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72309A55183C27DB00370B93 /* Tokenizer.cpp */; settings = {COMPILER_FLAGS = "-Wno-unreachable-code"; }; };
+ 72309A58183C27F300370B93 /* ExpressionParser.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 72309A57183C27F100370B93 /* ExpressionParser.cpp */; settings = {COMPILER_FLAGS = "-Wno-unreachable-code"; }; };
A08C3CDC16D6CB61003F0B83 /* ArrayBoundsClamper.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A08C3CDA16D6CB61003F0B83 /* ArrayBoundsClamper.cpp */; };
A08C3CDD16D6CB61003F0B83 /* ArrayBoundsClamper.h in Headers */ = {isa = PBXBuildFile; fileRef = A08C3CDB16D6CB61003F0B83 /* ArrayBoundsClamper.h */; };
A264F8AC16974DED006FAA5A /* DiagnosticsBase.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A264F89316974DED006FAA5A /* DiagnosticsBase.cpp */; };
@@ -2282,7 +2282,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0700;
- LastUpgradeCheck = 0700;
+ LastUpgradeCheck = 1000;
};
buildConfigurationList = FB39D0731200ED9200088E69 /* Build configuration list for PBXProject "ANGLE" */;
compatibilityVersion = "Xcode 3.2";
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (236810 => 236811)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2018-10-03 21:02:19 UTC (rev 236810)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2018-10-03 21:08:53 UTC (rev 236811)
@@ -1,3 +1,19 @@
+2018-10-03 Dan Bernstein <m...@apple.com>
+
+ ANGLE part of [Xcode] Update some build settings as recommended by Xcode 10
+ https://bugs.webkit.org/show_bug.cgi?id=190250
+
+ Reviewed by Andy Estes.
+
+ * ANGLE.xcodeproj/project.pbxproj: Kept the unreachable code warning off for four files that
+ were generated by tools: glslang_lex.cpp, glslang_tab.cpp, Tokenizer.cpp, and
+ ExpressionParser.cpp. Let Xcode update LastUpgradeCheck.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_INFINITE_RECURSION,
+ CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_SUSPICIOUS_MOVE,
+ CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and
+ CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
+
2018-09-21 Adrian Perez de Castro <ape...@igalia.com>
[GTK] ANGLE's eglplatform.h does not support Wayland-only builds
Modified: trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig (236810 => 236811)
--- trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig 2018-10-03 21:02:19 UTC (rev 236810)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig 2018-10-03 21:08:53 UTC (rev 236811)
@@ -14,14 +14,19 @@
CLANG_ENABLE_OBJC_WEAK = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
+CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = dwarf-with-dsym;
@@ -47,6 +52,8 @@
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
+CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (236810 => 236811)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-10-03 21:02:19 UTC (rev 236810)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-10-03 21:08:53 UTC (rev 236811)
@@ -1,3 +1,18 @@
+2018-10-03 Dan Bernstein <m...@apple.com>
+
+ libwebrtc part of [Xcode] Update some build settings as recommended by Xcode 10
+ https://bugs.webkit.org/show_bug.cgi?id=190250
+
+ Reviewed by Andy Estes.
+
+ * Configurations/Base.xcconfig: Removed a duplicate reference to x_all.c and let Xcode
+ update LastUpgradeCheck.
+
+ * libwebrtc.xcodeproj/project.pbxproj: Enabled CLANG_WARN_INFINITE_RECURSION,
+ CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, and
+ CLANG_WARN_SUSPICIOUS_MOVE. Other warnings that Xcode 10 recommended were incompatible
+ with one or more source files in the project.
+
2018-10-03 Youenn Fablet <you...@apple.com>
Enable H264 simulcast
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig (236810 => 236811)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig 2018-10-03 21:02:19 UTC (rev 236810)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig 2018-10-03 21:08:53 UTC (rev 236811)
@@ -18,6 +18,7 @@
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
+CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
@@ -47,9 +48,12 @@
GCC_WARN_ABOUT_MISSING_NEWLINE = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
+CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
+CLANG_WARN_SUSPICIOUS_MOVE = YES;
PREBINDING = NO;
STRIP_INSTALLED_PRODUCT = NO;
WARNING_CFLAGS = -Wexit-time-destructors -Wglobal-constructors -Wthread-safety;
Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (236810 => 236811)
--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2018-10-03 21:02:19 UTC (rev 236810)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2018-10-03 21:08:53 UTC (rev 236811)
@@ -1452,7 +1452,6 @@
5C4B467E1E42AA3C002651C8 /* t_x509a.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44BD1E42A6F7002651C8 /* t_x509a.c */; };
5C4B467F1E42AA3C002651C8 /* vpm_int.h in Headers */ = {isa = PBXBuildFile; fileRef = 5C4B44BE1E42A6F7002651C8 /* vpm_int.h */; };
5C4B46801E42AA3C002651C8 /* x_algor.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44BF1E42A6F7002651C8 /* x_algor.c */; };
- 5C4B46811E42AA3C002651C8 /* x_all.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44C01E42A6F7002651C8 /* x_all.c */; };
5C4B46821E42AA3C002651C8 /* x_attrib.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44C11E42A6F7002651C8 /* x_attrib.c */; };
5C4B46831E42AA3C002651C8 /* x_crl.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44C21E42A6F7002651C8 /* x_crl.c */; };
5C4B46841E42AA3C002651C8 /* x_exten.c in Sources */ = {isa = PBXBuildFile; fileRef = 5C4B44C31E42A6F7002651C8 /* x_exten.c */; };
@@ -14597,7 +14596,7 @@
attributes = {
DefaultBuildSystemTypeForWorkspace = Original;
LastSwiftUpdateCheck = 0700;
- LastUpgradeCheck = 0700;
+ LastUpgradeCheck = 1000;
TargetAttributes = {
41F77D15215BE45E00E72967 = {
CreatedOnToolsVersion = 10.0;
@@ -15275,7 +15274,6 @@
41EA53FD1EFC2D1B002FF04C /* x86_64-gcc.c in Sources */,
5C4B46801E42AA3C002651C8 /* x_algor.c in Sources */,
41A391CC1EFC46DE00C4516A /* x_all.c in Sources */,
- 5C4B46811E42AA3C002651C8 /* x_all.c in Sources */,
5C4B46821E42AA3C002651C8 /* x_attrib.c in Sources */,
5C4B46831E42AA3C002651C8 /* x_crl.c in Sources */,
5C4B46841E42AA3C002651C8 /* x_exten.c in Sources */,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
