Title: [237380] trunk/Source/WebKit
- Revision
- 237380
- Author
- csaave...@igalia.com
- Date
- 2018-10-24 06:45:26 -0700 (Wed, 24 Oct 2018)
Log Message
[WPE][GTK] Cleanups to the certificate decoder
https://bugs.webkit.org/show_bug.cgi?id=190867
Reviewed by Žan Doberšek.
* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<CertificateInfo>::decode):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (237379 => 237380)
--- trunk/Source/WebKit/ChangeLog 2018-10-24 10:20:34 UTC (rev 237379)
+++ trunk/Source/WebKit/ChangeLog 2018-10-24 13:45:26 UTC (rev 237380)
@@ -1,5 +1,15 @@
2018-10-24 Claudio Saavedra <csaave...@igalia.com>
+ [WPE][GTK] Cleanups to the certificate decoder
+ https://bugs.webkit.org/show_bug.cgi?id=190867
+
+ Reviewed by Žan Doberšek.
+
+ * Shared/soup/WebCoreArgumentCodersSoup.cpp:
+ (IPC::ArgumentCoder<CertificateInfo>::decode):
+
+2018-10-24 Claudio Saavedra <csaave...@igalia.com>
+
[WPE][GTK] Cleanups to the certificate encoder
https://bugs.webkit.org/show_bug.cgi?id=190865
Modified: trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp (237379 => 237380)
--- trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp 2018-10-24 10:20:34 UTC (rev 237379)
+++ trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp 2018-10-24 13:45:26 UTC (rev 237380)
@@ -93,8 +93,7 @@
if (!chainLength)
return true;
- GTlsCertificate* issuer = nullptr;
- GTlsBackend* backend = g_tls_backend_get_default();
+ GType certificateType = g_tls_backend_get_certificate_type(g_tls_backend_get_default());
GRefPtr<GTlsCertificate> certificate;
for (uint32_t i = 0; i < chainLength; i++) {
IPC::DataReference certificateDataReference;
@@ -101,14 +100,11 @@
if (!decoder.decodeVariableLengthByteArray(certificateDataReference))
return false;
- GByteArray* certificateData = g_byte_array_sized_new(certificateDataReference.size());
- certificateData = g_byte_array_append(certificateData, certificateDataReference.data(), certificateDataReference.size());
- GRefPtr<GByteArray> certificateBytes = adoptGRef(certificateData);
+ GRefPtr<GByteArray> certificateData = g_byte_array_sized_new(certificateDataReference.size());
+ certificateData = g_byte_array_append(certificateData.get(), certificateDataReference.data(), certificateDataReference.size());
certificate = adoptGRef(G_TLS_CERTIFICATE(g_initable_new(
- g_tls_backend_get_certificate_type(backend), 0, 0, "certificate", certificateBytes.get(), "issuer", issuer, nullptr)));
-
- issuer = certificate.get();
+ certificateType, nullptr, nullptr, "certificate", certificateData.get(), "issuer", certificate.get(), nullptr)));
}
uint32_t tlsErrors;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
