Title: [239540] trunk/Tools
- Revision
- 239540
- Author
- carlo...@webkit.org
- Date
- 2018-12-22 04:37:15 -0800 (Sat, 22 Dec 2018)
Log Message
WebDriver: warn about non existing tests when parsing expectations
https://bugs.webkit.org/show_bug.cgi?id=192979
Reviewed by Michael Catanzaro.
It's common to update web driver tests and forget updating the test expectations in case of tests removed or
renamed.
* Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
(WebDriverTestRunner.__init__):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (239539 => 239540)
--- trunk/Tools/ChangeLog 2018-12-22 12:33:52 UTC (rev 239539)
+++ trunk/Tools/ChangeLog 2018-12-22 12:37:15 UTC (rev 239540)
@@ -1,3 +1,16 @@
+2018-12-22 Carlos Garcia Campos <cgar...@igalia.com>
+
+ WebDriver: warn about non existing tests when parsing expectations
+ https://bugs.webkit.org/show_bug.cgi?id=192979
+
+ Reviewed by Michael Catanzaro.
+
+ It's common to update web driver tests and forget updating the test expectations in case of tests removed or
+ renamed.
+
+ * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
+ (WebDriverTestRunner.__init__):
+
2018-12-21 Chris Dumez <cdu...@apple.com>
navigator.userAgent in service workers does not reflect customUserAgent set by client
Modified: trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py (239539 => 239540)
--- trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py 2018-12-22 12:33:52 UTC (rev 239539)
+++ trunk/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py 2018-12-22 12:37:15 UTC (rev 239540)
@@ -56,6 +56,9 @@
expectations_file = os.path.join(self._tests_dir, 'TestExpectations.json')
build_type = 'Debug' if self._port.get_option('debug') else 'Release'
self._expectations = TestExpectations(self._port.name(), expectations_file, build_type)
+ for test in self._expectations._expectations.keys():
+ if not os.path.isfile(os.path.join(self._tests_dir, test)):
+ _log.warning('Test %s does not exist' % test)
env = self._display_driver._setup_environ_for_test()
self._runners = [runner_cls(self._port, driver, env, self._expectations) for runner_cls in self.RUNNER_CLASSES]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
