Title: [239585] trunk/Source/WebInspectorUI
- Revision
- 239585
- Author
- nvasil...@apple.com
- Date
- 2019-01-02 20:05:04 -0800 (Wed, 02 Jan 2019)
Log Message
Web Inspector: Styles: it shouldn't be possible to delete read-only properties
https://bugs.webkit.org/show_bug.cgi?id=193099
<rdar://problem/47016335>
Reviewed by Devin Rousso.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor):
Drive-by: Forward Delete should work the same way as Delete (Backspace).
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (239584 => 239585)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-01-03 04:00:47 UTC (rev 239584)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-01-03 04:05:04 UTC (rev 239585)
@@ -1,3 +1,15 @@
+2019-01-02 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Styles: it shouldn't be possible to delete read-only properties
+ https://bugs.webkit.org/show_bug.cgi?id=193099
+ <rdar://problem/47016335>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
+ (WI.SpreadsheetCSSStyleDeclarationEditor):
+ Drive-by: Forward Delete should work the same way as Delete (Backspace).
+
2019-01-02 Devin Rousso <web...@devinrousso.com>
Web Inspector: Implement `queryObjects` Command Line API
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js (239584 => 239585)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2019-01-03 04:00:47 UTC (rev 239584)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js 2019-01-03 04:05:04 UTC (rev 239585)
@@ -533,7 +533,10 @@
event.stop();
property.startEditingName();
}
- } else if (event.key === "Backspace") {
+ } else if (event.key === "Backspace" || event.key === "Delete") {
+ if (!this.style.editable)
+ return;
+
let [startIndex, endIndex] = this.selectionRange;
let propertyIndexToSelect = NaN;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
