Diff
Modified: trunk/LayoutTests/ChangeLog (249554 => 249555)
--- trunk/LayoutTests/ChangeLog 2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/ChangeLog 2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,18 @@
+2019-09-05 Justin Fan <justin_...@apple.com>
+
+ [WebGPU] Fix new test results after adding console warnings
+ https://bugs.webkit.org/show_bug.cgi?id=201526
+
+ Unreviewed test expectation updates.
+
+ * webgpu/buffer-errors-expected.txt:
+ * webgpu/map-read-buffers-expected.txt:
+ * webgpu/map-write-buffers-expected.txt:
+ * webgpu/render-pipelines.html: Fix WHLSL compile error.
+ * webgpu/uncaptured-errors-expected.txt: Added.
+ * webgpu/whlsl/use-undefined-variable-2-expected.txt:
+ * webgpu/whlsl/use-undefined-variable-expected.txt:
+
2019-09-05 Ryan Haddad <ryanhad...@apple.com>
Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html is a flaky failure
Modified: trunk/LayoutTests/webgpu/buffer-errors-expected.txt (249554 => 249555)
--- trunk/LayoutTests/webgpu/buffer-errors-expected.txt 2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/buffer-errors-expected.txt 2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: GPUDevice.createBuffer(): Buffer cannot have both MAP_READ and MAP_WRITE usage!
PASS GPUBuffers can be created with both read-only and STORAGE usages.
PASS unmap on already unmapped, mappable GPUBuffer should not generate error.
Modified: trunk/LayoutTests/webgpu/map-read-buffers-expected.txt (249554 => 249555)
--- trunk/LayoutTests/webgpu/map-read-buffers-expected.txt 2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/map-read-buffers-expected.txt 2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,7 @@
+CONSOLE MESSAGE: GPUBuffer.mapReadAsync(): Invalid operation!
+CONSOLE MESSAGE: GPUBuffer.mapWriteAsync(): Invalid operation!
+CONSOLE MESSAGE: GPUBuffer.mapReadAsync(): Invalid operation!
+CONSOLE MESSAGE: GPUBuffer.mapReadAsync(): Invalid operation!
PASS mapReadAsync, unmap, and destroy on a GPUBuffer.
PASS GPUBuffer.mapReadAsync on a buffer created via GPUDevice.createBufferMapped.
Modified: trunk/LayoutTests/webgpu/map-write-buffers-expected.txt (249554 => 249555)
--- trunk/LayoutTests/webgpu/map-write-buffers-expected.txt 2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/map-write-buffers-expected.txt 2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: GPUBuffer.mapWriteAsync(): Invalid operation!
+CONSOLE MESSAGE: GPUBuffer.mapWriteAsync(): Invalid operation!
PASS Map write, unmap, and destroy a GPUBuffer.
PASS Reject a map write on a buffer not created with MAP_WRITE usage.
Modified: trunk/LayoutTests/webgpu/render-pipelines.html (249554 => 249555)
--- trunk/LayoutTests/webgpu/render-pipelines.html 2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/render-pipelines.html 2019-09-05 23:42:52 UTC (rev 249555)
@@ -5,7 +5,7 @@
<script src=""
<script>
const shaderCode = `
-vertex float4 vertex_main(uint vid [[vertex_id]]) : SV_Position
+vertex float4 vertex_main(uint vid : SV_VertexID) : SV_Position
{
float4 v;
switch (vid) {
Added: trunk/LayoutTests/webgpu/uncaptured-errors-expected.txt (0 => 249555)
--- trunk/LayoutTests/webgpu/uncaptured-errors-expected.txt (rev 0)
+++ trunk/LayoutTests/webgpu/uncaptured-errors-expected.txt 2019-09-05 23:42:52 UTC (rev 249555)
@@ -0,0 +1,7 @@
+CONSOLE MESSAGE: GPUDevice.createBuffer(): Buffer cannot have both MAP_READ and MAP_WRITE usage!
+CONSOLE MESSAGE: GPUDevice.createBuffer(): Buffer cannot have both MAP_READ and MAP_WRITE usage!
+
+PASS Fire an uncaptured GPUDevice error event at 'device'.
+PASS Intercept an uncaptured error with GPUDevice.onuncapturederror EventHandler.
+PASS GPUUncapturedErrorEvent async test.
+
Modified: trunk/LayoutTests/webgpu/whlsl/use-undefined-variable-2-expected.txt (249554 => 249555)
--- trunk/LayoutTests/webgpu/whlsl/use-undefined-variable-2-expected.txt 2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/whlsl/use-undefined-variable-2-expected.txt 2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: GPUDevice.createComputePipeline(): WHLSL compile error: 4:25: Cannot find the variable declaration.
PASS
PASS successfullyParsed is true
Modified: trunk/LayoutTests/webgpu/whlsl/use-undefined-variable-expected.txt (249554 => 249555)
--- trunk/LayoutTests/webgpu/whlsl/use-undefined-variable-expected.txt 2019-09-05 23:37:15 UTC (rev 249554)
+++ trunk/LayoutTests/webgpu/whlsl/use-undefined-variable-expected.txt 2019-09-05 23:42:52 UTC (rev 249555)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: GPUDevice.createComputePipeline(): WHLSL compile error: 6:9: Cannot find the variable declaration.
PASS
PASS successfullyParsed is true