Title: [254099] trunk/Source/WebCore
Revision
254099
Author
pvol...@apple.com
Date
2020-01-06 16:49:32 -0800 (Mon, 06 Jan 2020)

Log Message

[iOS] Only prewarm fonts with valid font names
https://bugs.webkit.org/show_bug.cgi?id=205822

Reviewed by Brent Fulgham.

The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.

No new tests, no behavior change.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::prewarmGlobally):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (254098 => 254099)


--- trunk/Source/WebCore/ChangeLog	2020-01-07 00:34:53 UTC (rev 254098)
+++ trunk/Source/WebCore/ChangeLog	2020-01-07 00:49:32 UTC (rev 254099)
@@ -1,3 +1,17 @@
+2020-01-06  Per Arne Vollan  <pvol...@apple.com>
+
+        [iOS] Only prewarm fonts with valid font names
+        https://bugs.webkit.org/show_bug.cgi?id=205822
+
+        Reviewed by Brent Fulgham.
+
+        The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.
+
+        No new tests, no behavior change.
+
+        * platform/graphics/cocoa/FontCacheCoreText.cpp:
+        (WebCore::FontCache::prewarmGlobally):
+
 2020-01-06  Peng Liu  <peng.l...@apple.com>
 
         Build (unified) failure after adding source files to support media in GPU process

Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (254098 => 254099)


--- trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2020-01-07 00:34:53 UTC (rev 254098)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2020-01-07 00:49:32 UTC (rev 254099)
@@ -1694,8 +1694,10 @@
         return;
 
     Vector<String> families = std::initializer_list<String> {
+#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
         ".SF NS Text"_s,
         ".SF NS Display"_s,
+#endif
         "Arial"_s,
         "Helvetica"_s,
         "Helvetica Neue"_s,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to