Title: [258298] trunk/Source/WebKit
- Revision
- 258298
- Author
- pvol...@apple.com
- Date
- 2020-03-11 16:58:38 -0700 (Wed, 11 Mar 2020)
Log Message
Unreviewed, reverting r258294.
https://bugs.webkit.org/show_bug.cgi?id=208957
Introduced API failure (Requested by perarne on #webkit).
Reverted changeset:
"[macOS] _AXSApplicationAccessibilityEnabled should not be
called"
https://bugs.webkit.org/show_bug.cgi?id=208953
https://trac.webkit.org/changeset/258294
Patch by Commit Queue <commit-qu...@webkit.org> on 2020-03-11
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258297 => 258298)
--- trunk/Source/WebKit/ChangeLog 2020-03-11 23:56:44 UTC (rev 258297)
+++ trunk/Source/WebKit/ChangeLog 2020-03-11 23:58:38 UTC (rev 258298)
@@ -1,3 +1,17 @@
+2020-03-11 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, reverting r258294.
+ https://bugs.webkit.org/show_bug.cgi?id=208957
+
+ Introduced API failure (Requested by perarne on #webkit).
+
+ Reverted changeset:
+
+ "[macOS] _AXSApplicationAccessibilityEnabled should not be
+ called"
+ https://bugs.webkit.org/show_bug.cgi?id=208953
+ https://trac.webkit.org/changeset/258294
+
2020-03-11 Kate Cheney <katherine_che...@apple.com>
Add a parameter to allow ignoring app-bound domain categorization
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258297 => 258298)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-03-11 23:56:44 UTC (rev 258297)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-03-11 23:58:38 UTC (rev 258298)
@@ -455,10 +455,7 @@
}
#if ENABLE(CFPREFS_DIRECT_MODE)
-#if PLATFORM(IOS_FAMILY)
- if (_AXSApplicationAccessibilityEnabled())
-#endif
- {
+ if (libAccessibilityLibrary() && _AXSApplicationAccessibilityEnabled()) {
SandboxExtension::Handle preferencesExtensionHandle;
SandboxExtension::createHandleForMachLookup("com.apple.cfprefsd.daemon", WTF::nullopt, preferencesExtensionHandle);
parameters.preferencesExtensionHandle = WTFMove(preferencesExtensionHandle);
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258297 => 258298)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-03-11 23:56:44 UTC (rev 258297)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm 2020-03-11 23:58:38 UTC (rev 258298)
@@ -46,6 +46,10 @@
namespace WebKit {
+#if PLATFORM(MAC)
+SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
+#endif
+
static const Seconds unexpectedActivityDuration = 10_s;
const HashSet<String>& WebProcessProxy::platformPathsWithAssumedReadAccess()
@@ -210,10 +214,12 @@
{
if (m_hasSentMessageToUnblockAccessibilityServer)
return;
-#if PLATFORM(IOS_FAMILY)
+#if PLATFORM(MAC)
+ if (!WebKit::libAccessibilityLibrary())
+ return;
+#endif
if (!_AXSApplicationAccessibilityEnabled())
return;
-#endif
if (!processIdentifier())
return;
if (!canSendMessage())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
