Title: [260825] trunk/Tools
Revision
260825
Author
csaave...@igalia.com
Date
2020-04-28 07:49:04 -0700 (Tue, 28 Apr 2020)

Log Message

[Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
https://bugs.webkit.org/show_bug.cgi?id=211123

Reviewed by Carlos Alberto Lopez Perez.

MiniBrowser's --geometry is on its way out, so use --fullscreen
instead as it does the job.

* Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
(GTKMiniBrowserDriver.launch_url):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (260824 => 260825)


--- trunk/Tools/ChangeLog	2020-04-28 14:44:42 UTC (rev 260824)
+++ trunk/Tools/ChangeLog	2020-04-28 14:49:04 UTC (rev 260825)
@@ -1,3 +1,16 @@
+2020-04-28  Claudio Saavedra  <csaave...@igalia.com>
+
+        [Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
+        https://bugs.webkit.org/show_bug.cgi?id=211123
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        MiniBrowser's --geometry is on its way out, so use --fullscreen
+        instead as it does the job.
+
+        * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
+        (GTKMiniBrowserDriver.launch_url):
+
 2020-04-27  Carlos Garcia Campos  <cgar...@igalia.com>
 
         [GTK4] Add support for motion events

Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py (260824 => 260825)


--- trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py	2020-04-28 14:44:42 UTC (rev 260824)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py	2020-04-28 14:49:04 UTC (rev 260825)
@@ -35,7 +35,7 @@
         self._browser_arguments = []
         if self.process_name.endswith('run-minibrowser'):
             self._browser_arguments.append('--gtk')
-        self._browser_arguments.append('--geometry={w}x{h}'.format(w=self._screen_size().width, h=self._screen_size().height))
+        self._browser_arguments.append('--full-screen')
         self._browser_arguments.append(url)
         super(GTKMiniBrowserDriver, self).launch_url(url, options, browser_build_path, browser_path)
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to