Modified: trunk/Source/_javascript_Core/ChangeLog (268324 => 268325)
--- trunk/Source/_javascript_Core/ChangeLog 2020-10-11 19:16:49 UTC (rev 268324)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-10-11 21:54:48 UTC (rev 268325)
@@ -1,5 +1,12 @@
2020-10-11 Yusuke Suzuki <ysuz...@apple.com>
+ Unreviewed, mark missing custom getter and setters
+ https://bugs.webkit.org/show_bug.cgi?id=217500
+
+ * tools/JSDollarVM.cpp:
+
+2020-10-11 Yusuke Suzuki <ysuz...@apple.com>
+
[JSC] arguments.callee should become ThrowTypeError if function has non simple parameter list
https://bugs.webkit.org/show_bug.cgi?id=217574
Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (268324 => 268325)
--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2020-10-11 19:16:49 UTC (rev 268324)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2020-10-11 21:54:48 UTC (rev 268325)
@@ -671,6 +671,7 @@
};
static JSC_DECLARE_CUSTOM_GETTER(testStaticAccessorGetter);
+static JSC_DECLARE_CUSTOM_SETTER(testStaticAccessorPutter);
JSC_DEFINE_CUSTOM_GETTER(testStaticAccessorGetter, (JSGlobalObject* globalObject, EncodedJSValue thisValue, PropertyName))
{
@@ -685,7 +686,7 @@
return JSValue::encode(jsUndefined());
}
-static bool testStaticAccessorPutter(JSGlobalObject* globalObject, EncodedJSValue thisValue, EncodedJSValue value)
+JSC_DEFINE_CUSTOM_SETTER(testStaticAccessorPutter, (JSGlobalObject* globalObject, EncodedJSValue thisValue, EncodedJSValue value))
{
DollarVMAssertScope assertScope;
VM& vm = globalObject->vm();
@@ -746,13 +747,16 @@
}
};
-static EncodedJSValue testStaticValueGetter(JSGlobalObject*, EncodedJSValue, PropertyName)
+static JSC_DECLARE_CUSTOM_GETTER(testStaticValueGetter);
+static JSC_DECLARE_CUSTOM_SETTER(testStaticValuePutter);
+
+JSC_DEFINE_CUSTOM_GETTER(testStaticValueGetter, (JSGlobalObject*, EncodedJSValue, PropertyName))
{
DollarVMAssertScope assertScope;
return JSValue::encode(jsUndefined());
}
-static bool testStaticValuePutter(JSGlobalObject* globalObject, EncodedJSValue thisValue, EncodedJSValue value)
+JSC_DEFINE_CUSTOM_SETTER(testStaticValuePutter, (JSGlobalObject* globalObject, EncodedJSValue thisValue, EncodedJSValue value))
{
DollarVMAssertScope assertScope;
VM& vm = globalObject->vm();
