Title: [277465] trunk/Tools
Revision
277465
Author
aakash_j...@apple.com
Date
2021-05-13 16:31:11 -0700 (Thu, 13 May 2021)

Log Message

[ews] Style fixes in steps.py
https://bugs.webkit.org/show_bug.cgi?id=225784

Reviewed by Dewei Zhu.

* CISupport/ews-build/steps.py:
(CheckOutSource.__init__):
(ShowIdentifier.hideStepIf):
(BugzillaMixin.get_bugzilla_api_key):
(RunJavaScriptCoreTests.commandComplete):
(AnalyzeJSCTestsResults.send_email_for_pre_existing_failure):
(AnalyzeLayoutTestsResults._report_flaky_tests):
(DownloadBuiltProduct):
(AnalyzeAPITestsResults.analyzeResults.getAPITestFailures):
(AnalyzeAPITestsResults.send_email_for_pre_existing_failure):

Modified Paths

Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (277464 => 277465)


--- trunk/Tools/CISupport/ews-build/steps.py	2021-05-13 23:27:20 UTC (rev 277464)
+++ trunk/Tools/CISupport/ews-build/steps.py	2021-05-13 23:31:11 UTC (rev 277465)
@@ -111,13 +111,13 @@
 
     def __init__(self, repourl='https://github.com/WebKit/WebKit.git', **kwargs):
         super(CheckOutSource, self).__init__(repourl=repourl,
-                                                retry=self.CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR,
-                                                timeout=2 * 60 * 60,
-                                                alwaysUseLatest=True,
-                                                logEnviron=False,
-                                                method='clean',
-                                                progress=True,
-                                                **kwargs)
+                                             retry=self.CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR,
+                                             timeout=2 * 60 * 60,
+                                             alwaysUseLatest=True,
+                                             logEnviron=False,
+                                             method='clean',
+                                             progress=True,
+                                             **kwargs)
 
     def getResultSummary(self):
         if self.results == FAILURE:
@@ -254,6 +254,7 @@
     def hideStepIf(self, results, step):
         return results == SUCCESS
 
+
 class CleanWorkingDirectory(shell.ShellCommand):
     name = 'clean-working-directory'
     description = ['clean-working-directory running']
@@ -715,7 +716,7 @@
         try:
             passwords = json.load(open('passwords.json'))
             return passwords.get('BUGZILLA_API_KEY', '')
-        except:
+        except Exception as e:
             print('Error in reading Bugzilla api key')
             return ''
 
@@ -1836,15 +1837,15 @@
             self._addToLog('stderr', 'ERROR: unable to parse data, exception: {}'.format(ex))
             return
 
-        if jsc_results.get('allMasmTestsPassed') == False:
+        if jsc_results.get('allMasmTestsPassed') is False:
             self.binaryFailures.append('testmasm')
-        if jsc_results.get('allAirTestsPassed') == False:
+        if jsc_results.get('allAirTestsPassed') is False:
             self.binaryFailures.append('testair')
-        if jsc_results.get('allB3TestsPassed') == False:
+        if jsc_results.get('allB3TestsPassed') is False:
             self.binaryFailures.append('testb3')
-        if jsc_results.get('allDFGTestsPassed') == False:
+        if jsc_results.get('allDFGTestsPassed') is False:
             self.binaryFailures.append('testdfg')
-        if jsc_results.get('allApiTestsPassed') == False:
+        if jsc_results.get('allApiTestsPassed') is False:
             self.binaryFailures.append('testapi')
 
         self.stressTestFailures = jsc_results.get('stressTestFailures')
@@ -2025,7 +2026,6 @@
             print('Error in sending email for pre-existing failure: {}'.format(e))
 
 
-
 class CleanBuild(shell.Compile):
     name = 'delete-WebKitBuild-directory'
     description = ['deleting WebKitBuild directory']
@@ -2543,7 +2543,7 @@
             print('Error in sending email for new layout test failures: {}'.format(e))
 
     def _report_flaky_tests(self, flaky_tests):
-        #TODO: implement this
+        # TODO: implement this
         pass
 
     def start(self):
@@ -2700,8 +2700,8 @@
 
 class DownloadBuiltProduct(shell.ShellCommand):
     command = ['python', 'Tools/CISupport/download-built-product',
-        WithProperties('--%(configuration)s'),
-        WithProperties(S3URL + 'ews-archives.webkit.org/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(patch_id)s.zip')]
+               WithProperties('--%(configuration)s'),
+               WithProperties(S3URL + 'ews-archives.webkit.org/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(patch_id)s.zip')]
     name = 'download-built-product'
     description = ['downloading built product']
     descriptionDone = ['Downloaded built product']
@@ -2874,8 +2874,8 @@
                 return set([])
             # TODO: Analyze Time-out, Crash and Failure independently
             return set([failure.get('name') for failure in result.get('Timedout', [])] +
-                [failure.get('name') for failure in result.get('Crashed', [])] +
-                [failure.get('name') for failure in result.get('Failed', [])])
+                       [failure.get('name') for failure in result.get('Crashed', [])] +
+                       [failure.get('name') for failure in result.get('Failed', [])])
 
         first_run_failures = getAPITestFailures(first_run_results)
         second_run_failures = getAPITestFailures(second_run_results)
@@ -2988,6 +2988,7 @@
         except Exception as e:
             print('Error in sending email for pre-existing failure: {}'.format(e))
 
+
 class ArchiveTestResults(shell.ShellCommand):
     command = ['python', 'Tools/CISupport/test-result-archive',
                Interpolate('--platform=%(prop:platform)s'), Interpolate('--%(prop:configuration)s'), 'archive']

Modified: trunk/Tools/ChangeLog (277464 => 277465)


--- trunk/Tools/ChangeLog	2021-05-13 23:27:20 UTC (rev 277464)
+++ trunk/Tools/ChangeLog	2021-05-13 23:31:11 UTC (rev 277465)
@@ -1,3 +1,21 @@
+2021-05-13  Aakash Jain  <aakash_j...@apple.com>
+
+        [ews] Style fixes in steps.py
+        https://bugs.webkit.org/show_bug.cgi?id=225784
+
+        Reviewed by Dewei Zhu.
+
+        * CISupport/ews-build/steps.py:
+        (CheckOutSource.__init__):
+        (ShowIdentifier.hideStepIf):
+        (BugzillaMixin.get_bugzilla_api_key):
+        (RunJavaScriptCoreTests.commandComplete):
+        (AnalyzeJSCTestsResults.send_email_for_pre_existing_failure):
+        (AnalyzeLayoutTestsResults._report_flaky_tests):
+        (DownloadBuiltProduct):
+        (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures):
+        (AnalyzeAPITestsResults.send_email_for_pre_existing_failure):
+
 2021-05-13  Chris Dumez  <cdu...@apple.com>
 
         Tweak ServiceWorkers.SuspendServiceWorkerProcessBasedOnClientProcesses to find out source of timeout
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to