Title: [291275] releases/WebKitGTK/webkit-2.36
Revision
291275
Author
carlo...@webkit.org
Date
2022-03-15 02:05:02 -0700 (Tue, 15 Mar 2022)

Log Message

Merge r290597 - -Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
https://bugs.webkit.org/show_bug.cgi?id=229867
<rdar://problem/82975115>

Patch by Michael Catanzaro <mcatanz...@gnome.org> on 2022-02-28
Reviewed by Carlos Garcia Campos.

Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
locally.

* Source/cmake/WebKitCompilerFlags.cmake:

 2022-02-24  Matt Woodrow  <mattwood...@apple.com>

 Unreviewed, update my (Matt Woodrow) status to committer.

 * metadata/contributors.json:

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.36/ChangeLog (291274 => 291275)


--- releases/WebKitGTK/webkit-2.36/ChangeLog	2022-03-15 09:04:59 UTC (rev 291274)
+++ releases/WebKitGTK/webkit-2.36/ChangeLog	2022-03-15 09:05:02 UTC (rev 291275)
@@ -1,3 +1,16 @@
+2022-02-28  Michael Catanzaro  <mcatanz...@gnome.org>
+
+        -Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
+        https://bugs.webkit.org/show_bug.cgi?id=229867
+        <rdar://problem/82975115>
+
+        Reviewed by Carlos Garcia Campos.
+
+        Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
+        locally.
+
+        * Source/cmake/WebKitCompilerFlags.cmake:
+
 2022-02-25  Adrian Perez de Castro  <ape...@igalia.com>
 
         Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.35.90 release

Modified: releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake (291274 => 291275)


--- releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake	2022-03-15 09:04:59 UTC (rev 291274)
+++ releases/WebKitGTK/webkit-2.36/Source/cmake/WebKitCompilerFlags.cmake	2022-03-15 09:05:02 UTC (rev 291275)
@@ -150,6 +150,12 @@
         WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-stringop-overread)
     endif ()
 
+    # -Wodr trips over our bindings integrity feature when LTO is enabled.
+    # https://bugs.webkit.org/show_bug.cgi?id=229867
+    if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+        WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-odr)
+    endif ()
+
     # -Wexpansion-to-defined produces false positives with GCC but not Clang
     # https://bugs.webkit.org/show_bug.cgi?id=167643#c13
     if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to