Title: [291847] trunk/JSTests
- Revision
- 291847
- Author
- ysuz...@apple.com
- Date
- 2022-03-24 21:14:29 -0700 (Thu, 24 Mar 2022)
Log Message
Add additional reported regression tests to ensure multiline token's column offset is reset
https://bugs.webkit.org/show_bug.cgi?id=221548
Reviewed by Alexey Shvayka.
The bug is fixed and tested in https://github.com/WebKit/WebKit/commit/6d1e5d9498f24805988ad81ca3228588dd000a51.
But let's add reported regression tests to ensure that they will not reproduce.
* stress/multiline-token-error-column.js: Added.
(shouldBe):
(throw.new.Error):
Modified Paths
Added Paths
Diff
Modified: trunk/JSTests/ChangeLog (291846 => 291847)
--- trunk/JSTests/ChangeLog 2022-03-25 04:08:00 UTC (rev 291846)
+++ trunk/JSTests/ChangeLog 2022-03-25 04:14:29 UTC (rev 291847)
@@ -1,3 +1,17 @@
+2022-03-24 Yusuke Suzuki <ysuz...@apple.com>
+
+ Add additional reported regression tests to ensure multiline token's column offset is reset
+ https://bugs.webkit.org/show_bug.cgi?id=221548
+
+ Reviewed by Alexey Shvayka.
+
+ The bug is fixed and tested in https://github.com/WebKit/WebKit/commit/6d1e5d9498f24805988ad81ca3228588dd000a51.
+ But let's add reported regression tests to ensure that they will not reproduce.
+
+ * stress/multiline-token-error-column.js: Added.
+ (shouldBe):
+ (throw.new.Error):
+
2022-03-23 Geza Lore <gl...@igalia.com>
[JSC] Fix remoteFunctionCallGenerator on MIPS
Added: trunk/JSTests/stress/multiline-token-error-column.js (0 => 291847)
--- trunk/JSTests/stress/multiline-token-error-column.js (rev 0)
+++ trunk/JSTests/stress/multiline-token-error-column.js 2022-03-25 04:14:29 UTC (rev 291847)
@@ -0,0 +1,24 @@
+function shouldBe(actual, expected) {
+ if (actual !== expected)
+ throw new Error('bad value: ' + actual);
+}
+
+{
+ let { line, column } = (function() {/*
+ something about this comment means the line number gets reported incorrectly in the stack
+ */const e = new Error("new error"); return e;
+ })();
+ shouldBe(line, 9);
+ shouldBe(column, 28);
+}
+{
+ let { line, column } = (function() {
+ let s = `
+multi
+line
+string
+`; const e = new Error("new error"); return e;
+ })();
+ shouldBe(line, 20);
+ shouldBe(column, 23);
+}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
