Title: [292429] trunk/Source/WebKit
- Revision
- 292429
- Author
- commit-qu...@webkit.org
- Date
- 2022-04-05 14:52:00 -0700 (Tue, 05 Apr 2022)
Log Message
Unreviewed, reverting r291821.
https://bugs.webkit.org/show_bug.cgi?id=238839
Invalid fix.
Reverted changeset:
"REGRESSION(r286590): Links with URL schemes are not clickable
in Mail"
https://bugs.webkit.org/show_bug.cgi?id=238262
https://commits.webkit.org/r291821
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (292428 => 292429)
--- trunk/Source/WebKit/ChangeLog 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/ChangeLog 2022-04-05 21:52:00 UTC (rev 292429)
@@ -1,3 +1,17 @@
+2022-04-05 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, reverting r291821.
+ https://bugs.webkit.org/show_bug.cgi?id=238839
+
+ Invalid fix.
+
+ Reverted changeset:
+
+ "REGRESSION(r286590): Links with URL schemes are not clickable
+ in Mail"
+ https://bugs.webkit.org/show_bug.cgi?id=238262
+ https://commits.webkit.org/r291821
+
2022-04-05 Sihui Liu <sihui_...@apple.com>
Verify generalStorageDirectory is not in use when creating WebsiteDataStore
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (292428 => 292429)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-04-05 21:52:00 UTC (rev 292429)
@@ -1132,7 +1132,6 @@
(extension "com.apple.webkit.extension.mach")
(global-name
"com.apple.iconservices"
- "com.apple.lsd.open"
)
)
)
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp (292428 => 292429)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2022-04-05 21:52:00 UTC (rev 292429)
@@ -167,7 +167,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
- encoder << dynamicMachExtensionHandles;
encoder << dynamicIOKitExtensionHandles;
#endif
@@ -455,12 +454,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
- std::optional<Vector<SandboxExtension::Handle>> dynamicMachExtensionHandles;
- decoder >> dynamicMachExtensionHandles;
- if (!dynamicMachExtensionHandles)
- return false;
- parameters.dynamicMachExtensionHandles = WTFMove(*dynamicMachExtensionHandles);
-
std::optional<Vector<SandboxExtension::Handle>> dynamicIOKitExtensionHandles;
decoder >> dynamicIOKitExtensionHandles;
if (!dynamicIOKitExtensionHandles)
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.h (292428 => 292429)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2022-04-05 21:52:00 UTC (rev 292429)
@@ -208,7 +208,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
- Vector<SandboxExtension::Handle> dynamicMachExtensionHandles;
Vector<SandboxExtension::Handle> dynamicIOKitExtensionHandles;
#endif
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (292428 => 292429)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2022-04-05 21:52:00 UTC (rev 292429)
@@ -285,17 +285,6 @@
m_resolvedPaths.uiProcessBundleResourcePath = resolvePathForSandboxExtension(String { [[NSBundle mainBundle] resourcePath] });
}
-#if PLATFORM(IOS_FAMILY)
-static const Vector<ASCIILiteral>& nonBrowserServices()
-{
- ASSERT(isMainRunLoop());
- static NeverDestroyed services = Vector<ASCIILiteral> {
- "com.apple.lsd.open"_s,
- };
- return services;
-}
-#endif
-
void WebProcessPool::platformInitializeWebProcess(const WebProcessProxy& process, WebProcessCreationParameters& parameters)
{
parameters.mediaMIMETypes = process.mediaMIMETypes();
@@ -396,9 +385,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
- if (!isFullWebBrowser())
- parameters.dynamicMachExtensionHandles = SandboxExtension::createHandlesForMachLookup(nonBrowserServices(), std::nullopt);
-
if (WebCore::deviceHasAGXCompilerService())
parameters.dynamicIOKitExtensionHandles = SandboxExtension::createHandlesForIOKitClassExtensions(WebCore::agxCompilerClasses(), std::nullopt);
#endif
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (292428 => 292429)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2022-04-05 21:48:50 UTC (rev 292428)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2022-04-05 21:52:00 UTC (rev 292429)
@@ -421,7 +421,6 @@
#endif
#if PLATFORM(IOS_FAMILY)
- SandboxExtension::consumePermanently(parameters.dynamicMachExtensionHandles);
SandboxExtension::consumePermanently(parameters.dynamicIOKitExtensionHandles);
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
