Title: [292740] trunk/Source/WebCore
- Revision
- 292740
- Author
- commit-qu...@webkit.org
- Date
- 2022-04-11 16:48:05 -0700 (Mon, 11 Apr 2022)
Log Message
[GStreamer] Debugs logs from VideoSinkCommon are missing
https://bugs.webkit.org/show_bug.cgi?id=239049
Patch by Philippe Normand <pnorm...@igalia.com> on 2022-04-11
Reviewed by Adrian Perez de Castro.
When this new module was added, the logging support was lost due to missing logging category.
* platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(webKitVideoSinkSetMediaPlayerPrivate):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (292739 => 292740)
--- trunk/Source/WebCore/ChangeLog 2022-04-11 23:45:18 UTC (rev 292739)
+++ trunk/Source/WebCore/ChangeLog 2022-04-11 23:48:05 UTC (rev 292740)
@@ -1,3 +1,15 @@
+2022-04-11 Philippe Normand <pnorm...@igalia.com>
+
+ [GStreamer] Debugs logs from VideoSinkCommon are missing
+ https://bugs.webkit.org/show_bug.cgi?id=239049
+
+ Reviewed by Adrian Perez de Castro.
+
+ When this new module was added, the logging support was lost due to missing logging category.
+
+ * platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
+ (webKitVideoSinkSetMediaPlayerPrivate):
+
2022-04-11 Nikolaos Mouchtaris <nmouchta...@apple.com>
calc(): Propogate nan for min, max, clamp, and hypot
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp (292739 => 292740)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp 2022-04-11 23:45:18 UTC (rev 292739)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp 2022-04-11 23:48:05 UTC (rev 292740)
@@ -26,8 +26,16 @@
using namespace WebCore;
+GST_DEBUG_CATEGORY(webkit_gst_video_sink_common_debug);
+#define GST_CAT_DEFAULT webkit_gst_video_sink_common_debug
+
void webKitVideoSinkSetMediaPlayerPrivate(GstElement* appSink, MediaPlayerPrivateGStreamer* player)
{
+ static std::once_flag onceFlag;
+ std::call_once(onceFlag, [] {
+ GST_DEBUG_CATEGORY_INIT(webkit_gst_video_sink_common_debug, "webkitvideosinkcommon", 0, "WebKit Video Sink Common utilities");
+ });
+
g_signal_connect(appSink, "new-sample", G_CALLBACK(+[](GstElement* sink, MediaPlayerPrivateGStreamer* player) -> GstFlowReturn {
GRefPtr<GstSample> sample = adoptGRef(gst_app_sink_pull_sample(GST_APP_SINK(sink)));
GstBuffer* buffer = gst_sample_get_buffer(sample.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
