Title: [292750] trunk/Tools
- Revision
- 292750
- Author
- cdu...@apple.com
- Date
- 2022-04-11 18:15:48 -0700 (Mon, 11 Apr 2022)
Log Message
REGRESSION:(r292696) lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=239087
Reviewed by Jonathan Bedard.
Revert change to aNullString made in r292696 as the the following test relies on this String being empty:
lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string
* lldb/lldbWebKitTester/main.cpp:
(testSummaryProviders):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (292749 => 292750)
--- trunk/Tools/ChangeLog 2022-04-12 00:43:49 UTC (rev 292749)
+++ trunk/Tools/ChangeLog 2022-04-12 01:15:48 UTC (rev 292750)
@@ -1,3 +1,16 @@
+2022-04-11 Chris Dumez <cdu...@apple.com>
+
+ REGRESSION:(r292696) lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string is a constant failure
+ https://bugs.webkit.org/show_bug.cgi?id=239087
+
+ Reviewed by Jonathan Bedard.
+
+ Revert change to aNullString made in r292696 as the the following test relies on this String being empty:
+ lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string
+
+ * lldb/lldbWebKitTester/main.cpp:
+ (testSummaryProviders):
+
2022-04-11 Alan Bujtas <za...@apple.com>
[ iOS iPhone 12 ] fast/hidpi & fast/layers/hidpi tests are flaky text/image failing
Modified: trunk/Tools/lldb/lldbWebKitTester/main.cpp (292749 => 292750)
--- trunk/Tools/lldb/lldbWebKitTester/main.cpp 2022-04-12 00:43:49 UTC (rev 292749)
+++ trunk/Tools/lldb/lldbWebKitTester/main.cpp 2022-04-12 01:15:48 UTC (rev 292750)
@@ -57,7 +57,7 @@
static void testSummaryProviders()
{
- String aNullString { };
+ String aNullString { ""_s };
StringImpl* aNullStringImpl = aNullString.impl();
String anEmptyString { ""_s };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
